date:20170621

[webkit-changes] [218680] tags/Safari-604.1.25.3.3/

2017-06-21 Thread bshafiei

Title: [218680] tags/Safari-604.1.25.3.3/








Revision 218680
Author bshaf...@apple.com
Date 2017-06-21 23:43:47 -0700 (Wed, 21 Jun 2017)


Log Message
New tag.

Added Paths

tags/Safari-604.1.25.3.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218679] trunk/Source/WebInspectorUI

2017-06-21 Thread commit-queue

Title: [218679] trunk/Source/WebInspectorUI








Revision 218679
Author commit-qu...@webkit.org
Date 2017-06-21 23:17:42 -0700 (Wed, 21 Jun 2017)


Log Message
[GTK] Web Inspector: Add NavigationItemCheckers.svg
https://bugs.webkit.org/show_bug.cgi?id=173692

Patch by Fujii Hironori  on 2017-06-21
Reviewed by Carlos Garcia Campos.

* UserInterface/Images/gtk/NavigationItemCheckers.svg: Added.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCheckers.svg




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (218678 => 218679)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-06-22 04:46:42 UTC (rev 218678)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-06-22 06:17:42 UTC (rev 218679)
@@ -1,3 +1,12 @@
+2017-06-21  Fujii Hironori  
+
+[GTK] Web Inspector: Add NavigationItemCheckers.svg
+https://bugs.webkit.org/show_bug.cgi?id=173692
+
+Reviewed by Carlos Garcia Campos.
+
+* UserInterface/Images/gtk/NavigationItemCheckers.svg: Added.
+
 2017-06-20  Devin Rousso  
 
 Web Inspector: change the selected ScopeBarItem on mousedown instead of click


Added: trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCheckers.svg (0 => 218679)

--- trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCheckers.svg	(rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCheckers.svg	2017-06-22 06:17:42 UTC (rev 218679)
@@ -0,0 +1,6 @@
+
+
+
+ 
+ 
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218678] trunk/Source/WebKit2

2017-06-21 Thread ddkilzer

Title: [218678] trunk/Source/WebKit2








Revision 218678
Author ddkil...@apple.com
Date 2017-06-21 21:46:42 -0700 (Wed, 21 Jun 2017)


Log Message
REGRESSION (r218419): 3 NSMutableDiciontary leaks calling -[WKProcessPool _pluginLoadClientPolicies]


Reviewed by Chris Dumez.

Caught by the clang static analyzer.

* UIProcess/API/Cocoa/WKProcessPool.mm:
(policiesHashMapToDictionary): Switch from using
[[NSMutableDictionary alloc] init] which returns a +1 retained
object in MRR to [NSMutableDictionary new] which returns an
autoreleased object under MRR.  This bug caused 3 leaks when
calling -[WKProcessPool _pluginLoadClientPolicies], which should
return an autoreleased object based on its signature.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (218677 => 218678)

--- trunk/Source/WebKit2/ChangeLog	2017-06-22 04:31:12 UTC (rev 218677)
+++ trunk/Source/WebKit2/ChangeLog	2017-06-22 04:46:42 UTC (rev 218678)
@@ -1,3 +1,20 @@
+2017-06-21  David Kilzer  
+
+REGRESSION (r218419): 3 NSMutableDiciontary leaks calling -[WKProcessPool _pluginLoadClientPolicies]
+
+
+Reviewed by Chris Dumez.
+
+Caught by the clang static analyzer.
+
+* UIProcess/API/Cocoa/WKProcessPool.mm:
+(policiesHashMapToDictionary): Switch from using
+[[NSMutableDictionary alloc] init] which returns a +1 retained
+object in MRR to [NSMutableDictionary new] which returns an
+autoreleased object under MRR.  This bug caused 3 leaks when
+calling -[WKProcessPool _pluginLoadClientPolicies], which should
+return an autoreleased object based on its signature.
+
 2017-06-21  Ryosuke Niwa  
 
 Add release assertions help diagnose a hang in CallbackMap


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm (218677 => 218678)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm	2017-06-22 04:31:12 UTC (rev 218677)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm	2017-06-22 04:46:42 UTC (rev 218678)
@@ -313,13 +313,13 @@
 
 static NSDictionary *policiesHashMapToDictionary(const HashMap>>& map)
 {
-NSMutableDictionary *policies = [[NSMutableDictionary alloc] init];
+NSMutableDictionary *policies = [NSMutableDictionary new];
 for (auto& hostPair : map) {
 NSString *host = hostPair.key;
-policies[host] = [[NSMutableDictionary alloc] init];
+policies[host] = [NSMutableDictionary new];
 for (auto& bundleIdentifierPair : hostPair.value) {
 NSString *bundlerIdentifier = bundleIdentifierPair.key;
-policies[host][bundlerIdentifier] = [[NSMutableDictionary alloc] init];
+policies[host][bundlerIdentifier] = [NSMutableDictionary new];
 for (auto& versionPair : bundleIdentifierPair.value) {
 NSString *version = versionPair.key;
 policies[host][bundlerIdentifier][version] = [NSNumber numberWithUnsignedInt:versionPair.value];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218677] trunk

2017-06-21 Thread commit-queue

Title: [218677] trunk








Revision 218677
Author commit-qu...@webkit.org
Date 2017-06-21 21:31:12 -0700 (Wed, 21 Jun 2017)


Log Message
[Fetch API] TypeError when called with body === {}
https://bugs.webkit.org/show_bug.cgi?id=173295


Patch by Youenn Fablet  on 2017-06-21
Reviewed by Sam Weinig.

Source/WebCore:

Test: fetch/body-init.html

Handling body of Request and Response using binding generator to correctly handle unions.
The biggest change is that any value that is not a specific type in the union will match a String.
This is matching WebIDL spec and Firefox behavior.

Handling of ReadableStream bodies remains in JS builtin for Response.
This allows easier handling cloning and consumption of body.
Adding setBodyAsReadableStream since this is no longer handled by extractBody.

* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract): Using Variant instead of JSC::JSValue.
(WebCore::FetchBody::readableStreamBody): Introduced to handle the
case of readable stream bodies.
* Modules/fetch/FetchBody.h:
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::extractBody):
* Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::setBody):
* Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::setBody): Splitting setBody for ease of readability.
(WebCore::FetchRequest::setBodyFromInputRequest):
* Modules/fetch/FetchRequest.h:
* Modules/fetch/FetchRequest.idl:
* Modules/fetch/FetchRequest.js:
(initializeFetchRequest):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::initializeWith):
(WebCore::FetchResponse::setBodyAsReadableStream):
* Modules/fetch/FetchResponse.h:
* Modules/fetch/FetchResponse.idl:
* Modules/fetch/FetchResponse.js:
(initializeFetchResponse):
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

* fetch/body-init-expected.txt: Added.
* fetch/body-init.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h
trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp
trunk/Source/WebCore/Modules/fetch/FetchRequest.h
trunk/Source/WebCore/Modules/fetch/FetchRequest.idl
trunk/Source/WebCore/Modules/fetch/FetchRequest.js
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
trunk/Source/WebCore/Modules/fetch/FetchResponse.idl
trunk/Source/WebCore/Modules/fetch/FetchResponse.js
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h


Added Paths

trunk/LayoutTests/fetch/body-init-expected.txt
trunk/LayoutTests/fetch/body-init.html




Diff

Modified: trunk/LayoutTests/ChangeLog (218676 => 218677)

--- trunk/LayoutTests/ChangeLog	2017-06-22 02:44:13 UTC (rev 218676)
+++ trunk/LayoutTests/ChangeLog	2017-06-22 04:31:12 UTC (rev 218677)
@@ -1,3 +1,14 @@
+2017-06-21  Youenn Fablet  
+
+[Fetch API] TypeError when called with body === {}
+https://bugs.webkit.org/show_bug.cgi?id=173295
+
+
+Reviewed by Sam Weinig.
+
+* fetch/body-init-expected.txt: Added.
+* fetch/body-init.html: Added.
+
 2017-06-21  Antoine Quint  
 
 CSS text properties affect  shadow root


Added: trunk/LayoutTests/fetch/body-init-expected.txt (0 => 218677)

--- trunk/LayoutTests/fetch/body-init-expected.txt	(rev 0)
+++ trunk/LayoutTests/fetch/body-init-expected.txt	2017-06-22 04:31:12 UTC (rev 218677)
@@ -0,0 +1,6 @@
+
+PASS Testing integer body passed to response 
+PASS Testing object body passed to response 
+PASS Testing integer body passed to request 
+PASS Testing object body passed to request 
+


Added: trunk/LayoutTests/fetch/body-init.html (0 => 218677)

--- trunk/LayoutTests/fetch/body-init.html	(rev 0)
+++ trunk/LayoutTests/fetch/body-init.html	2017-06-22 04:31:12 UTC (rev 218677)
@@ -0,0 +1,30 @@
+
+
+
+
+
+promise_test(() => {
+return new Response(1).text().then((text) => {
+assert_equals(text, "1");
+});
+}, "Testing integer body passed to response");
+
+promise_test(() => {
+return new Response({}).text().then((text) => {
+assert_equals(text, "[object Object]");
+});
+}, "Testing object body passed to response");
+
+promise_test(() => {
+return new Request("", {method: "POST", body: 1}).text().then((text) => {
+assert_equals(text, "1");
+});
+}, "Testing integer body passed to request");
+
+promise_test(() => {
+return new Request("", {method: "POST", body: {}}).text().then((text) => {
+assert_equals(text, "[object Object]");
+});
+}, "Testing object body passed to request");
+
+


Modified: trunk/Source/WebCore/ChangeLog (218676 => 218677)

--- trunk/Source/WebCore/ChangeLog	2017-06-22 02:44:13 UTC (rev 218676)
+++ trunk/Source/WebCore/ChangeLog	2017-06-22 04:31

[webkit-changes] [218676] trunk/Source/WebKit2

2017-06-21 Thread rniwa

Title: [218676] trunk/Source/WebKit2








Revision 218676
Author rn...@webkit.org
Date 2017-06-21 19:44:13 -0700 (Wed, 21 Jun 2017)


Log Message
Add release assertions help diagnose a hang in CallbackMap
https://bugs.webkit.org/show_bug.cgi?id=173680


Reviewed by Chris Dumez.

Assert that these functions are only called in the main thread and the empty value is never used as a key.

* UIProcess/GenericCallback.h:
(WebKit::CallbackMap::put):
(WebKit::CallbackMap::take):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/GenericCallback.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (218675 => 218676)

--- trunk/Source/WebKit2/ChangeLog	2017-06-22 02:24:09 UTC (rev 218675)
+++ trunk/Source/WebKit2/ChangeLog	2017-06-22 02:44:13 UTC (rev 218676)
@@ -1,3 +1,17 @@
+2017-06-21  Ryosuke Niwa  
+
+Add release assertions help diagnose a hang in CallbackMap
+https://bugs.webkit.org/show_bug.cgi?id=173680
+
+
+Reviewed by Chris Dumez.
+
+Assert that these functions are only called in the main thread and the empty value is never used as a key.
+
+* UIProcess/GenericCallback.h:
+(WebKit::CallbackMap::put):
+(WebKit::CallbackMap::take):
+
 2017-06-21  Wenson Hsieh  
 
 [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail


Modified: trunk/Source/WebKit2/UIProcess/GenericCallback.h (218675 => 218676)

--- trunk/Source/WebKit2/UIProcess/GenericCallback.h	2017-06-22 02:24:09 UTC (rev 218675)
+++ trunk/Source/WebKit2/UIProcess/GenericCallback.h	2017-06-22 02:44:13 UTC (rev 218676)
@@ -32,6 +32,7 @@
 #include "WKAPICast.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -171,9 +172,10 @@
 public:
 uint64_t put(Ref&& callback)
 {
-ASSERT(!m_map.contains(callback->callbackID()));
-
+RELEASE_ASSERT(isMainThread());
 uint64_t callbackID = callback->callbackID();
+RELEASE_ASSERT(callbackID);
+RELEASE_ASSERT(!m_map.contains(callbackID));
 m_map.set(callbackID, WTFMove(callback));
 return callbackID;
 }
@@ -198,6 +200,8 @@
 template
 RefPtr take(uint64_t callbackID)
 {
+RELEASE_ASSERT(callbackID);
+RELEASE_ASSERT(isMainThread());
 auto base = m_map.take(callbackID);
 if (!base)
 return nullptr;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218675] trunk/Source/WebCore

2017-06-21 Thread simon . fraser

Title: [218675] trunk/Source/WebCore








Revision 218675
Author simon.fra...@apple.com
Date 2017-06-21 19:24:09 -0700 (Wed, 21 Jun 2017)


Log Message
Add z-index to compositing logging output
https://bugs.webkit.org/show_bug.cgi?id=173684

Reviewed by Zalan Bujtas.

Show z-index, which is often useful to find negative z-index items.

Log "+foreground" rather than "foreground" to indicate that this layer has an
additional foreground/background layer, and fix spacing.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (218674 => 218675)

--- trunk/Source/WebCore/ChangeLog	2017-06-22 02:22:12 UTC (rev 218674)
+++ trunk/Source/WebCore/ChangeLog	2017-06-22 02:24:09 UTC (rev 218675)
@@ -1,3 +1,18 @@
+2017-06-21  Simon Fraser  
+
+Add z-index to compositing logging output
+https://bugs.webkit.org/show_bug.cgi?id=173684
+
+Reviewed by Zalan Bujtas.
+
+Show z-index, which is often useful to find negative z-index items.
+
+Log "+foreground" rather than "foreground" to indicate that this layer has an
+additional foreground/background layer, and fix spacing.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::logLayerInfo):
+
 2017-06-21  Chris Dumez  
 
 Unreviewed, fix Window Debug build after r218660.


Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (218674 => 218675)

--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2017-06-22 02:22:12 UTC (rev 218674)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2017-06-22 02:24:09 UTC (rev 218675)
@@ -814,6 +814,9 @@
 absoluteBounds.x().toFloat(), absoluteBounds.y().toFloat(), absoluteBounds.maxX().toFloat(), absoluteBounds.maxY().toFloat(),
 backing->backingStoreMemoryEstimate() / 1024));
 
+if (!layer.renderer().style().hasAutoZIndex())
+logString.append(String::format(" z-index: %d", layer.renderer().style().zIndex())); 
+
 logString.appendLiteral(" (");
 logString.append(logReasonsForCompositing(layer));
 logString.appendLiteral(") ");
@@ -836,12 +839,16 @@
 if (backing->foregroundLayer() || backing->backgroundLayer()) {
 if (prependSpace)
 logString.appendLiteral(", ");
-if (backing->foregroundLayer() && backing->backgroundLayer())
-logString.appendLiteral("foreground+background");
-else if (backing->foregroundLayer())
-logString.appendLiteral("foreground");
-else
-logString.appendLiteral("background");
+if (backing->foregroundLayer() && backing->backgroundLayer()) {
+logString.appendLiteral("+foreground+background");
+prependSpace = true;
+} else if (backing->foregroundLayer()) {
+logString.appendLiteral("+foreground");
+prependSpace = true;
+} else {
+logString.appendLiteral("+background");
+prependSpace = true;
+}
 }
 
 if (backing->paintsSubpixelAntialiasedText()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218674] trunk/Source/JavaScriptCore

2017-06-21 Thread sbarati

Title: [218674] trunk/Source/_javascript_Core








Revision 218674
Author sbar...@apple.com
Date 2017-06-21 19:22:12 -0700 (Wed, 21 Jun 2017)


Log Message
ArrayPrototype.map builtin declares a var it does not use
https://bugs.webkit.org/show_bug.cgi?id=173685

Reviewed by Keith Miller.

* builtins/ArrayPrototype.js:
(map):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/ArrayPrototype.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (218673 => 218674)

--- trunk/Source/_javascript_Core/ChangeLog	2017-06-22 01:54:45 UTC (rev 218673)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-06-22 02:22:12 UTC (rev 218674)
@@ -1,5 +1,15 @@
 2017-06-21  Saam Barati  
 
+ArrayPrototype.map builtin declares a var it does not use
+https://bugs.webkit.org/show_bug.cgi?id=173685
+
+Reviewed by Keith Miller.
+
+* builtins/ArrayPrototype.js:
+(map):
+
+2017-06-21  Saam Barati  
+
 eval virtual call is incorrect in the baseline JIT
 https://bugs.webkit.org/show_bug.cgi?id=173587
 


Modified: trunk/Source/_javascript_Core/builtins/ArrayPrototype.js (218673 => 218674)

--- trunk/Source/_javascript_Core/builtins/ArrayPrototype.js	2017-06-22 01:54:45 UTC (rev 218673)
+++ trunk/Source/_javascript_Core/builtins/ArrayPrototype.js	2017-06-22 02:22:12 UTC (rev 218674)
@@ -268,7 +268,6 @@
 else
 result = new constructor(length);
 
-var nextIndex = 0;
 for (var i = 0; i < length; i++) {
 if (!(i in array))
 continue;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218673] trunk

2017-06-21 Thread sbarati

Title: [218673] trunk








Revision 218673
Author sbar...@apple.com
Date 2017-06-21 18:54:45 -0700 (Wed, 21 Jun 2017)


Log Message
eval virtual call is incorrect in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=173587


Reviewed by Michael Saboff.

JSTests:

* stress/do-eval-virtual-call-correctly.js: Added.
(assert):
(f):
(i.test):
(catch):

Source/_javascript_Core:

When making a virtual call for call_eval, e.g, when the thing
we're calling isn't actually eval, we end up calling the caller
instead of the callee. This is clearly wrong. The code ends up
issuing a load for the Callee in the callers frame instead of
the callee we're calling. The fix is simple, we just need to
load the real callee. Only the 32-bit baseline JIT had this bug.

* jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITCall32_64.cpp


Added Paths

trunk/JSTests/stress/do-eval-virtual-call-correctly.js




Diff

Modified: trunk/JSTests/ChangeLog (218672 => 218673)

--- trunk/JSTests/ChangeLog	2017-06-22 01:41:36 UTC (rev 218672)
+++ trunk/JSTests/ChangeLog	2017-06-22 01:54:45 UTC (rev 218673)
@@ -1,3 +1,17 @@
+2017-06-21  Saam Barati  
+
+eval virtual call is incorrect in the baseline JIT
+https://bugs.webkit.org/show_bug.cgi?id=173587
+
+
+Reviewed by Michael Saboff.
+
+* stress/do-eval-virtual-call-correctly.js: Added.
+(assert):
+(f):
+(i.test):
+(catch):
+
 2017-06-20  Ryan Haddad  
 
 Update test262 test expectations after r218581.


Added: trunk/JSTests/stress/do-eval-virtual-call-correctly.js (0 => 218673)

--- trunk/JSTests/stress/do-eval-virtual-call-correctly.js	(rev 0)
+++ trunk/JSTests/stress/do-eval-virtual-call-correctly.js	2017-06-22 01:54:45 UTC (rev 218673)
@@ -0,0 +1,27 @@
+function assert(b) {
+if (!b) {
+abort(); 
+}
+}
+noInline(assert);
+
+let test;
+
+function f(eval) {
+assert(eval === test);
+eval(0x0);
+f(test);
+}
+
+for (let i = 0; i < 20; ++i) {
+test = function test() { return i; }
+}
+
+let error;
+try {
+f(test);
+} catch(e) {
+error = e;
+}
+assert(!!error);
+assert(error instanceof RangeError);


Modified: trunk/Source/_javascript_Core/ChangeLog (218672 => 218673)

--- trunk/Source/_javascript_Core/ChangeLog	2017-06-22 01:41:36 UTC (rev 218672)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-06-22 01:54:45 UTC (rev 218673)
@@ -1,3 +1,21 @@
+2017-06-21  Saam Barati  
+
+eval virtual call is incorrect in the baseline JIT
+https://bugs.webkit.org/show_bug.cgi?id=173587
+
+
+Reviewed by Michael Saboff.
+
+When making a virtual call for call_eval, e.g, when the thing
+we're calling isn't actually eval, we end up calling the caller
+instead of the callee. This is clearly wrong. The code ends up
+issuing a load for the Callee in the callers frame instead of
+the callee we're calling. The fix is simple, we just need to
+load the real callee. Only the 32-bit baseline JIT had this bug.
+
+* jit/JITCall32_64.cpp:
+(JSC::JIT::compileCallEvalSlowCase):
+
 2017-06-21  Joseph Pecoraro  
 
 Web Inspector: Using "break on all exceptions" when throwing stack overflow hangs inspector


Modified: trunk/Source/_javascript_Core/jit/JITCall32_64.cpp (218672 => 218673)

--- trunk/Source/_javascript_Core/jit/JITCall32_64.cpp	2017-06-22 01:41:36 UTC (rev 218672)
+++ trunk/Source/_javascript_Core/jit/JITCall32_64.cpp	2017-06-22 01:54:45 UTC (rev 218673)
@@ -208,12 +208,13 @@
 linkSlowCase(iter);
 
 int registerOffset = -instruction[4].u.operand;
+int callee = instruction[2].u.operand;
 
 addPtr(TrustedImm32(registerOffset * sizeof(Register) + sizeof(CallerFrameAndPC)), callFrameRegister, stackPointerRegister);
 
 move(TrustedImmPtr(info), regT2);
 
-emitLoad(CallFrameSlot::callee, regT1, regT0);
+emitLoad(callee, regT1, regT0);
 MacroAssemblerCodeRef virtualThunk = virtualThunkFor(m_vm, *info);
 info->setSlowStub(createJITStubRoutine(virtualThunk, *m_vm, nullptr, true));
 emitNakedCall(virtualThunk.code());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218672] trunk

2017-06-21 Thread wenson_hsieh

Title: [218672] trunk








Revision 218672
Author wenson_hs...@apple.com
Date 2017-06-21 18:41:36 -0700 (Wed, 21 Jun 2017)


Log Message
[iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
https://bugs.webkit.org/show_bug.cgi?id=173659


Reviewed by Tim Horton.

Source/WebKit2:

Currently, a drag session that failed to begin is cleaned up either when the web process responds in
-[WKContentView _didHandleStartDataInteractionRequest:] with started = NO, or if started is YES, in
-dragInteraction:session:didEndWithOperation: instead. However, it is possible that even when the pasteboard has
items and the drag has started in the web process, something in the UI process may then cause the drag to be
cancelled (for instance, an SPI client returning empty arrays for all adjusted item providers, or UIKit not even
calling into -dragInteraction:itemsForBeginningSession: when we invoke their completion block).

In any case, if the drag session is drag-item-less after calling the drag start completion block, clean up and
cancel the drag.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didHandleStartDataInteractionRequest:]):
(-[WKContentView dragInteraction:itemsForBeginningSession:]):

Tools:

Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.

* TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:

Augment this test page to log dragend and dragstart events on the drag source as well.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(checkStringArraysAreEqual):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html
trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (218671 => 218672)

--- trunk/Source/WebKit2/ChangeLog	2017-06-22 01:25:50 UTC (rev 218671)
+++ trunk/Source/WebKit2/ChangeLog	2017-06-22 01:41:36 UTC (rev 218672)
@@ -1,3 +1,25 @@
+2017-06-21  Wenson Hsieh  
+
+[iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
+https://bugs.webkit.org/show_bug.cgi?id=173659
+
+
+Reviewed by Tim Horton.
+
+Currently, a drag session that failed to begin is cleaned up either when the web process responds in
+-[WKContentView _didHandleStartDataInteractionRequest:] with started = NO, or if started is YES, in
+-dragInteraction:session:didEndWithOperation: instead. However, it is possible that even when the pasteboard has
+items and the drag has started in the web process, something in the UI process may then cause the drag to be
+cancelled (for instance, an SPI client returning empty arrays for all adjusted item providers, or UIKit not even
+calling into -dragInteraction:itemsForBeginningSession: when we invoke their completion block).
+
+In any case, if the drag session is drag-item-less after calling the drag start completion block, clean up and
+cancel the drag.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _didHandleStartDataInteractionRequest:]):
+(-[WKContentView dragInteraction:itemsForBeginningSession:]):
+
 2017-06-21  Tim Horton  
 
 REGRESSION (r218606): 3D Touch action menu for links is missing items


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (218671 => 218672)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2017-06-22 01:25:50 UTC (rev 218671)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2017-06-22 01:41:36 UTC (rev 218672)
@@ -4232,16 +4232,19 @@
 _dataInteractionState.dragStartCompletionBlock = nil;
 ASSERT(savedCompletionBlock);
 
-if (!started) {
-// The web process rejected the drag start request, so don't go through with the drag.
-// By clearing out the source session state, we force -itemsForDragInteraction:session: to return an empty array, which
-// causes UIKit to bail before beginning the lift animation.
-[self cleanUpDragSourceSessionState];
-}
-
 RELEASE_LOG(DragAndDrop, "Handling drag start request (started: %d, completion block: %p)", started, savedCompletionBlock.get());
 if (savedCompletionBlock)
 savedCompletionBlock();
+
+if (![_dataInteractionState.dragSession items].count) {
+CGPoint adjustedOrigin = _dataInteractionState.adjustedOrigin;
+[self cleanUpDragSourceSessionState];
+if (started) {
+// A client of the Objective C SPI or UIKit might have prevented the drag from beginning entirely in the UI process, in which case
+// we need to balance the `dragstart` event with a `dragend`.
+_page->dragEnded(roundedIntPoint(adjustedOrigin), rounde

[webkit-changes] [218671] trunk/Source/WebCore

2017-06-21 Thread cdumez

Title: [218671] trunk/Source/WebCore








Revision 218671
Author cdu...@apple.com
Date 2017-06-21 18:25:50 -0700 (Wed, 21 Jun 2017)


Log Message
Unreviewed, fix Window Debug build after r218660.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForWithReason):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (218670 => 218671)

--- trunk/Source/WebCore/ChangeLog	2017-06-22 01:22:40 UTC (rev 218670)
+++ trunk/Source/WebCore/ChangeLog	2017-06-22 01:25:50 UTC (rev 218671)
@@ -1,3 +1,10 @@
+2017-06-21  Chris Dumez  
+
+Unreviewed, fix Window Debug build after r218660.
+
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::canUseForWithReason):
+
 2017-06-21  Andreas Kling  
 
 Increase memory kill limits for WebContent processes that manage multiple tabs.


Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (218670 => 218671)

--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2017-06-22 01:22:40 UTC (rev 218670)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2017-06-22 01:25:50 UTC (rev 218671)
@@ -254,9 +254,9 @@
 #ifndef NDEBUG
 static std::once_flag onceFlag;
 std::call_once(onceFlag, [] {
-registerNotifyCallback("com.apple.WebKit.showSimpleLineLayoutCoverage", printSimpleLineLayoutCoverage);
-registerNotifyCallback("com.apple.WebKit.showSimpleLineLayoutReasons", printSimpleLineLayoutBlockList);
-registerNotifyCallback("com.apple.WebKit.toggleSimpleLineLayout", toggleSimpleLineLayout);
+registerNotifyCallback("com.apple.WebKit.showSimpleLineLayoutCoverage", WTF::Function { printSimpleLineLayoutCoverage });
+registerNotifyCallback("com.apple.WebKit.showSimpleLineLayoutReasons", WTF::Function { printSimpleLineLayoutBlockList });
+registerNotifyCallback("com.apple.WebKit.toggleSimpleLineLayout", WTF::Function { toggleSimpleLineLayout });
 });
 #endif
 AvoidanceReasonFlags reasons = { };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218669] trunk/Source

2017-06-21 Thread akling

Title: [218669] trunk/Source








Revision 218669
Author akl...@apple.com
Date 2017-06-21 18:09:26 -0700 (Wed, 21 Jun 2017)


Log Message
Increase memory kill limits for WebContent processes that manage multiple tabs.
https://bugs.webkit.org/show_bug.cgi?id=173674

Reviewed by Geoffrey Garen.

Source/WebCore:

Plumb the non-utility Page count down to WTF::MemoryPressureHandler.

* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):

Source/WTF:

When opening  links, we currently have to use the same WebContent
process for the new tab, to support scripting the window.opener object.
This means that some WebContent processes end up hosting multiple tabs, making it
more likely that those processes will hit the memory limits.

Address this by adding some additional allowance for multi-tab processes:

For each additional tab, up to 4 tabs, add 1GB to the memory kill limit.

* wtf/MemoryPressureHandler.cpp:
(WTF::thresholdForMemoryKillWithProcessState):
(WTF::MemoryPressureHandler::setTabCount):
(WTF::MemoryPressureHandler::thresholdForMemoryKill):
(WTF::MemoryPressureHandler::measurementTimerFired):
* wtf/MemoryPressureHandler.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryPressureHandler.cpp
trunk/Source/WTF/wtf/MemoryPressureHandler.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (218668 => 218669)

--- trunk/Source/WTF/ChangeLog	2017-06-22 00:56:02 UTC (rev 218668)
+++ trunk/Source/WTF/ChangeLog	2017-06-22 01:09:26 UTC (rev 218669)
@@ -1,3 +1,26 @@
+2017-06-21  Andreas Kling  
+
+Increase memory kill limits for WebContent processes that manage multiple tabs.
+https://bugs.webkit.org/show_bug.cgi?id=173674
+
+Reviewed by Geoffrey Garen.
+
+When opening  links, we currently have to use the same WebContent
+process for the new tab, to support scripting the window.opener object.
+This means that some WebContent processes end up hosting multiple tabs, making it
+more likely that those processes will hit the memory limits.
+
+Address this by adding some additional allowance for multi-tab processes:
+
+For each additional tab, up to 4 tabs, add 1GB to the memory kill limit.
+
+* wtf/MemoryPressureHandler.cpp:
+(WTF::thresholdForMemoryKillWithProcessState):
+(WTF::MemoryPressureHandler::setTabCount):
+(WTF::MemoryPressureHandler::thresholdForMemoryKill):
+(WTF::MemoryPressureHandler::measurementTimerFired):
+* wtf/MemoryPressureHandler.h:
+
 2017-06-21  Chris Dumez  
 
 Allow constructing a WTF:Function from a function pointer


Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.cpp (218668 => 218669)

--- trunk/Source/WTF/wtf/MemoryPressureHandler.cpp	2017-06-22 00:56:02 UTC (rev 218668)
+++ trunk/Source/WTF/wtf/MemoryPressureHandler.cpp	2017-06-22 01:09:26 UTC (rev 218669)
@@ -81,21 +81,34 @@
 }
 #endif
 
-static size_t thresholdForMemoryKillWithProcessState(WebsamProcessState processState)
+static size_t thresholdForMemoryKillWithProcessState(WebsamProcessState processState, unsigned tabCount)
 {
 #if CPU(X86_64) || CPU(ARM64)
+size_t baseThreshold;
 if (processState == WebsamProcessState::Active)
-return 4 * GB;
-return 2 * GB;
+baseThreshold = 4 * GB;
+else
+baseThreshold = 2 * GB;
+if (tabCount <= 1)
+return baseThreshold;
+return baseThreshold + (std::min(tabCount - 1, 4u) * 1 * GB);
 #else
 UNUSED_PARAM(processState);
+UNUSED_PARAM(tabCount);
 return 3 * GB;
 #endif
 }
 
+void MemoryPressureHandler::setTabCount(unsigned tabCount)
+{
+if (singleton().m_tabCount == tabCount)
+return;
+singleton().m_tabCount = tabCount;
+}
+
 size_t MemoryPressureHandler::thresholdForMemoryKill()
 {
-return thresholdForMemoryKillWithProcessState(m_processState);
+return thresholdForMemoryKillWithProcessState(m_processState, m_tabCount);
 }
 
 static size_t thresholdForPolicy(MemoryUsagePolicy policy)
@@ -176,7 +189,7 @@
 break;
 }
 
-if (processState() == WebsamProcessState::Active && footprint.value() > thresholdForMemoryKillWithProcessState(WebsamProcessState::Inactive))
+if (processState() == WebsamProcessState::Active && footprint.value() > thresholdForMemoryKillWithProcessState(WebsamProcessState::Inactive, m_tabCount))
 doesExceedInactiveLimitWhileActive();
 else
 doesNotExceedInactiveLimitWhileActive();


Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.h (218668 => 218669)

--- trunk/Source/WTF/wtf/MemoryPressureHandler.h	2017-06-22 00:56:02 UTC (rev 218668)
+++ trunk/Source/WTF/wtf/MemoryPressureHandler.h	2017-06-22 01:09:26 UTC (rev 218669)
@@ -147,6 +147,8 @@
 WTF_EXPORT_PRIVATE void setProcessState(WebsamProcessState);
 WebsamProcessState processState() const { return m_processState; }
 
+WTF_EXPORT_PRIVATE static void setTabCount(

[webkit-changes] [218668] branches/safari-604.1.25.3-branch/Source/JavaScriptCore

2017-06-21 Thread bshafiei

Title: [218668] branches/safari-604.1.25.3-branch/Source/_javascript_Core








Revision 218668
Author bshaf...@apple.com
Date 2017-06-21 17:56:02 -0700 (Wed, 21 Jun 2017)


Log Message
Roll out r217530.  rdar://problem/32912916

Modified Paths

branches/safari-604.1.25.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.1.25.3-branch/Source/_javascript_Core/builtins/GlobalOperations.js




Diff

Modified: branches/safari-604.1.25.3-branch/Source/_javascript_Core/ChangeLog (218667 => 218668)

--- branches/safari-604.1.25.3-branch/Source/_javascript_Core/ChangeLog	2017-06-22 00:54:10 UTC (rev 218667)
+++ branches/safari-604.1.25.3-branch/Source/_javascript_Core/ChangeLog	2017-06-22 00:56:02 UTC (rev 218668)
@@ -1,3 +1,7 @@
+2017-06-21  Babak Shafiei  
+
+Roll out r217530.
+
 2017-06-08  Dean Jackson  
 
 Disable some features on this release branch.


Modified: branches/safari-604.1.25.3-branch/Source/_javascript_Core/builtins/GlobalOperations.js (218667 => 218668)

--- branches/safari-604.1.25.3-branch/Source/_javascript_Core/builtins/GlobalOperations.js	2017-06-22 00:54:10 UTC (rev 218667)
+++ branches/safari-604.1.25.3-branch/Source/_javascript_Core/builtins/GlobalOperations.js	2017-06-22 00:56:02 UTC (rev 218668)
@@ -30,7 +30,7 @@
 {
 "use strict";
 
-var numberValue = +target;
+var numberValue = @Number(target);
 
 // isNaN(numberValue)
 if (numberValue !== numberValue)
@@ -45,7 +45,7 @@
 
 var length = @toInteger(target);
 // originally Math.min(Math.max(length, 0), maxSafeInteger));
-return +(length > 0 ? (length < @MAX_SAFE_INTEGER ? length : @MAX_SAFE_INTEGER) : 0);
+return length > 0 ? (length < @MAX_SAFE_INTEGER ? length : @MAX_SAFE_INTEGER) : 0;
 }
 
 @globalPrivate






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218667] branches/safari-604.1.25.3-branch/Source

2017-06-21 Thread bshafiei

Title: [218667] branches/safari-604.1.25.3-branch/Source








Revision 218667
Author bshaf...@apple.com
Date 2017-06-21 17:54:10 -0700 (Wed, 21 Jun 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.1.25.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.1.25.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.1.25.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.1.25.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.1.25.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.1.25.3-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-604.1.25.3-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.1.25.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (218666 => 218667)

--- branches/safari-604.1.25.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-06-22 00:40:58 UTC (rev 218666)
+++ branches/safari-604.1.25.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-06-22 00:54:10 UTC (rev 218667)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 25;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.25.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (218666 => 218667)

--- branches/safari-604.1.25.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-06-22 00:40:58 UTC (rev 218666)
+++ branches/safari-604.1.25.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-06-22 00:54:10 UTC (rev 218667)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 25;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.25.3-branch/Source/WebCore/Configurations/Version.xcconfig (218666 => 218667)

--- branches/safari-604.1.25.3-branch/Source/WebCore/Configurations/Version.xcconfig	2017-06-22 00:40:58 UTC (rev 218666)
+++ branches/safari-604.1.25.3-branch/Source/WebCore/Configurations/Version.xcconfig	2017-06-22 00:54:10 UTC (rev 218667)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 25;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.25.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (218666 => 218667)

--- branches/safari-604.1.25.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-06-22 00:40:58 UTC (rev 218666)
+++ branches/safari-604.1.25.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-06-22 00:54:10 UTC (rev 218667)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 25;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.25.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (218666 => 218667)

--- branches/safari-604.1.25.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-06-22 00:40:58 UTC (rev 218666)
+++ branches/safari-604.1.25.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-06-22 00:54:10 UTC (rev 218667)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 25;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-604.1.25.3-branch/Source/WebKit/mac/Configurations/Version.xcconfig (218666 => 218667)

--- branches/safari-604.1.25.3-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-06-22 00:40:58 UTC (rev 218666)
+++ branches/safari-604.1.25.3-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-06-22 00:54:10 UTC (rev 218667)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 25;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branc

[webkit-changes] [218666] trunk/Source/WebCore

2017-06-21 Thread jiewen_tan

Title: [218666] trunk/Source/WebCore








Revision 218666
Author jiewen_...@apple.com
Date 2017-06-21 17:40:58 -0700 (Wed, 21 Jun 2017)


Log Message
[WebCrypto] Restore ordering of CryptoAlgorithmIdentifier in SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=173678


Reviewed by Sam Weinig.

r218030 reorders the ordering of CryptoAlgorithmIdentifier in SerializedScriptValue,
which introduces backward compatibility issues with CryptoKey objects stored in the
IndexedDB. Hence, we should restore it back.

No tests.

* bindings/js/SerializedScriptValue.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (218665 => 218666)

--- trunk/Source/WebCore/ChangeLog	2017-06-22 00:27:51 UTC (rev 218665)
+++ trunk/Source/WebCore/ChangeLog	2017-06-22 00:40:58 UTC (rev 218666)
@@ -1,3 +1,19 @@
+2017-06-21  Jiewen Tan  
+
+[WebCrypto] Restore ordering of CryptoAlgorithmIdentifier in SerializedScriptValue
+https://bugs.webkit.org/show_bug.cgi?id=173678
+
+
+Reviewed by Sam Weinig.
+
+r218030 reorders the ordering of CryptoAlgorithmIdentifier in SerializedScriptValue,
+which introduces backward compatibility issues with CryptoKey objects stored in the
+IndexedDB. Hence, we should restore it back.
+
+No tests.
+
+* bindings/js/SerializedScriptValue.cpp:
+
 2017-06-21  Daniel Bates  
 
 Change FrameLoadRequest from a struct to a class


Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (218665 => 218666)

--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp	2017-06-22 00:27:51 UTC (rev 218665)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp	2017-06-22 00:40:58 UTC (rev 218666)
@@ -242,17 +242,17 @@
 ECDH = 5,
 AES_CTR = 6,
 AES_CBC = 7,
-AES_GCM = 8,
-AES_CFB = 9,
-AES_KW = 10,
-HMAC = 11,
-SHA_1 = 12,
-SHA_224 = 13,
-SHA_256 = 14,
-SHA_384 = 15,
-SHA_512 = 16,
-HKDF = 17,
-PBKDF2 = 18,
+AES_GCM = 9,
+AES_CFB = 10,
+AES_KW = 11,
+HMAC = 12,
+SHA_1 = 14,
+SHA_224 = 15,
+SHA_256 = 16,
+SHA_384 = 17,
+SHA_512 = 18,
+HKDF = 20,
+PBKDF2 = 21,
 };
 const uint8_t cryptoAlgorithmIdentifierTagMaximumValue = 21;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218665] trunk/Source/WebCore

2017-06-21 Thread dbates

Title: [218665] trunk/Source/WebCore








Revision 218665
Author dba...@webkit.org
Date 2017-06-21 17:27:51 -0700 (Wed, 21 Jun 2017)


Log Message
Change FrameLoadRequest from a struct to a class

FrameLoadRequest is underutilizing the purpose of a struct - default visibility of
members is public, as FrameLoadRequest explicitly groups its members under public:
or private: sections. Maybe in the future we can make FrameLoadRequest a struct
with only public members. For now, we should consider FrameLoadRequest a class.

* loader/FormSubmission.h:
* loader/FrameLoadRequest.h:
* loader/FrameLoader.h:
* page/Chrome.h:
* page/ChromeClient.h:
* replay/UserInputBridge.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FormSubmission.h
trunk/Source/WebCore/loader/FrameLoadRequest.h
trunk/Source/WebCore/loader/FrameLoader.h
trunk/Source/WebCore/page/Chrome.h
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/replay/UserInputBridge.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (218664 => 218665)

--- trunk/Source/WebCore/ChangeLog	2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/ChangeLog	2017-06-22 00:27:51 UTC (rev 218665)
@@ -1,3 +1,19 @@
+2017-06-21  Daniel Bates  
+
+Change FrameLoadRequest from a struct to a class
+
+FrameLoadRequest is underutilizing the purpose of a struct - default visibility of
+members is public, as FrameLoadRequest explicitly groups its members under public:
+or private: sections. Maybe in the future we can make FrameLoadRequest a struct
+with only public members. For now, we should consider FrameLoadRequest a class.
+
+* loader/FormSubmission.h:
+* loader/FrameLoadRequest.h:
+* loader/FrameLoader.h:
+* page/Chrome.h:
+* page/ChromeClient.h:
+* replay/UserInputBridge.h:
+
 2017-06-21  Daewoong Jang  
 
 Compiler error while building with !HAVE(ACCESSIBILITY)


Modified: trunk/Source/WebCore/loader/FormSubmission.h (218664 => 218665)

--- trunk/Source/WebCore/loader/FormSubmission.h	2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/loader/FormSubmission.h	2017-06-22 00:27:51 UTC (rev 218665)
@@ -38,9 +38,8 @@
 
 class Event;
 class FormData;
+class FrameLoadRequest;
 
-struct FrameLoadRequest;
-
 class FormSubmission : public RefCounted {
 public:
 enum class Method { Get, Post };


Modified: trunk/Source/WebCore/loader/FrameLoadRequest.h (218664 => 218665)

--- trunk/Source/WebCore/loader/FrameLoadRequest.h	2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/loader/FrameLoadRequest.h	2017-06-22 00:27:51 UTC (rev 218665)
@@ -31,9 +31,10 @@
 #include "SubstituteData.h"
 
 namespace WebCore {
+
 class Frame;
 
-struct FrameLoadRequest {
+class FrameLoadRequest {
 public:
 FrameLoadRequest(SecurityOrigin& requester, const ResourceRequest& resourceRequest, const String& frameName, LockHistory lockHistory, LockBackForwardList lockBackForwardList, ShouldSendReferrer shouldSendReferrer, AllowNavigationToInvalidURL allowNavigationToInvalidURL, NewFrameOpenerPolicy newFrameOpenerPolicy, ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicy, ShouldReplaceDocumentIfJavaScriptURL shouldReplaceDocumentIfJavaScriptURL = ReplaceDocumentIfJavaScriptURL, const AtomicString& downloadAttribute = { })
 : m_requester { makeRef(requester) }


Modified: trunk/Source/WebCore/loader/FrameLoader.h (218664 => 218665)

--- trunk/Source/WebCore/loader/FrameLoader.h	2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/loader/FrameLoader.h	2017-06-22 00:27:51 UTC (rev 218665)
@@ -61,6 +61,7 @@
 class Event;
 class FormState;
 class FormSubmission;
+class FrameLoadRequest;
 class FrameLoaderClient;
 class FrameNetworkingContext;
 class HistoryController;
@@ -78,7 +79,6 @@
 class SubframeLoader;
 class SubstituteData;
 
-struct FrameLoadRequest;
 struct WindowFeatures;
 
 WEBCORE_EXPORT bool isBackForwardLoadType(FrameLoadType);


Modified: trunk/Source/WebCore/page/Chrome.h (218664 => 218665)

--- trunk/Source/WebCore/page/Chrome.h	2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/page/Chrome.h	2017-06-22 00:27:51 UTC (rev 218665)
@@ -41,6 +41,7 @@
 class FileChooser;
 class FileIconLoader;
 class FloatRect;
+class FrameLoadRequest;
 class Element;
 class Frame;
 class Geolocation;
@@ -55,7 +56,6 @@
 class SearchPopupMenu;
 
 struct DateTimeChooserParameters;
-struct FrameLoadRequest;
 struct ViewportArguments;
 struct WindowFeatures;
 


Modified: trunk/Source/WebCore/page/ChromeClient.h (218664 => 218665)

--- trunk/Source/WebCore/page/ChromeClient.h	2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/page/ChromeClient.h	2017-06-22 00:27:51 UTC (rev 218665)
@@ -74,6 +74,7 @@
 class FileIconLoader;
 class FloatRect;
 class Frame;
+class FrameLoadRequest;
 class Geolocation;
 class GraphicsLayer;
 class GraphicsLayerFactory;
@@ -96,7 +97,6 @@
 #endif
 
 struct DateTimeChooserParameters;
-st

[webkit-changes] [218664] trunk/Source/WebCore

2017-06-21 Thread commit-queue

Title: [218664] trunk/Source/WebCore








Revision 218664
Author commit-qu...@webkit.org
Date 2017-06-21 17:25:06 -0700 (Wed, 21 Jun 2017)


Log Message
Compiler error while building with !HAVE(ACCESSIBILITY)
https://bugs.webkit.org/show_bug.cgi?id=173670

Patch by Daewoong Jang  on 2017-06-21
Reviewed by Chris Fleizach.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::childrenChanged):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (218663 => 218664)

--- trunk/Source/WebCore/ChangeLog	2017-06-22 00:24:38 UTC (rev 218663)
+++ trunk/Source/WebCore/ChangeLog	2017-06-22 00:25:06 UTC (rev 218664)
@@ -1,3 +1,14 @@
+2017-06-21  Daewoong Jang  
+
+Compiler error while building with !HAVE(ACCESSIBILITY)
+https://bugs.webkit.org/show_bug.cgi?id=173670
+
+Reviewed by Chris Fleizach.
+
+* accessibility/AXObjectCache.h:
+(WebCore::AXObjectCache::getOrCreate):
+(WebCore::AXObjectCache::childrenChanged):
+
 2017-06-21  Antoine Quint  
 
 Build fix.


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (218663 => 218664)

--- trunk/Source/WebCore/accessibility/AXObjectCache.h	2017-06-22 00:24:38 UTC (rev 218663)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h	2017-06-22 00:25:06 UTC (rev 218664)
@@ -461,6 +461,7 @@
 inline AccessibilityObject* AXObjectCache::get(RenderObject*) { return nullptr; }
 inline AccessibilityObject* AXObjectCache::get(Node*) { return nullptr; }
 inline AccessibilityObject* AXObjectCache::get(Widget*) { return nullptr; }
+inline AccessibilityObject* AXObjectCache::getOrCreate(RenderObject*) { return nullptr; }
 inline AccessibilityObject* AXObjectCache::getOrCreate(AccessibilityRole) { return nullptr; }
 inline AccessibilityObject* AXObjectCache::getOrCreate(Node*) { return nullptr; }
 inline AccessibilityObject* AXObjectCache::getOrCreate(Widget*) { return nullptr; }
@@ -477,7 +478,6 @@
 inline void AXObjectCache::childrenChanged(RenderObject*, RenderObject*) { }
 inline void AXObjectCache::childrenChanged(Node*, Node*) { }
 inline void AXObjectCache::childrenChanged(AccessibilityObject*) { }
-inline void AXObjectCache::textChanged(RenderObject*) { }
 inline void AXObjectCache::textChanged(Node*) { }
 inline void AXObjectCache::textChanged(AccessibilityObject*) { }
 inline void AXObjectCache::updateCacheAfterNodeIsAttached(Node*) { }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218663] trunk/Source/WebCore

2017-06-21 Thread graouts

Title: [218663] trunk/Source/WebCore








Revision 218663
Author grao...@webkit.org
Date 2017-06-21 17:24:38 -0700 (Wed, 21 Jun 2017)


Log Message
Build fix.

Reviewed by Tim "Mr. T" Horton.

* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::logSuspendCount):
* page/Page.cpp:
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptedAnimationController.cpp
trunk/Source/WebCore/page/Page.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (218662 => 218663)

--- trunk/Source/WebCore/ChangeLog	2017-06-21 23:55:15 UTC (rev 218662)
+++ trunk/Source/WebCore/ChangeLog	2017-06-22 00:24:38 UTC (rev 218663)
@@ -1,5 +1,17 @@
 2017-06-21  Antoine Quint  
 
+Build fix.
+
+Reviewed by Tim "Mr. T" Horton.
+
+* dom/ScriptedAnimationController.cpp:
+(WebCore::ScriptedAnimationController::logSuspendCount):
+* page/Page.cpp:
+(WebCore::Page::suspendScriptedAnimations):
+(WebCore::Page::resumeScriptedAnimations):
+
+2017-06-21  Antoine Quint  
+
 Ensure DRT always logs rAF suspension debugging code
 https://bugs.webkit.org/show_bug.cgi?id=173681
 


Modified: trunk/Source/WebCore/dom/ScriptedAnimationController.cpp (218662 => 218663)

--- trunk/Source/WebCore/dom/ScriptedAnimationController.cpp	2017-06-21 23:55:15 UTC (rev 218662)
+++ trunk/Source/WebCore/dom/ScriptedAnimationController.cpp	2017-06-22 00:24:38 UTC (rev 218663)
@@ -94,11 +94,13 @@
 
 void ScriptedAnimationController::logSuspendCount()
 {
+#if PLATFORM(MAC)
 if (!m_document || !m_document->frame() || MacApplication::isDumpRenderTree())
 return;
 
 WTFLogAlways("\nScriptedAnimationController::m_suspendCount = %d", m_suspendCount);
 WTFReportBacktrace();
+#endif
 }
 
 #if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && !RELEASE_LOG_DISABLED


Modified: trunk/Source/WebCore/page/Page.cpp (218662 => 218663)

--- trunk/Source/WebCore/page/Page.cpp	2017-06-21 23:55:15 UTC (rev 218662)
+++ trunk/Source/WebCore/page/Page.cpp	2017-06-22 00:24:38 UTC (rev 218663)
@@ -1146,10 +1146,12 @@
 
 void Page::suspendScriptedAnimations()
 {
+#if PLATFORM(MAC)
 if (MacApplication::isDumpRenderTree()) {
 WTFLogAlways("\nPage::suspendScriptedAnimations()");
 WTFReportBacktrace();
 }
+#endif
 
 m_scriptedAnimationsSuspended = true;
 for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {
@@ -1160,10 +1162,12 @@
 
 void Page::resumeScriptedAnimations()
 {
+#if PLATFORM(MAC)
 if (MacApplication::isDumpRenderTree()) {
 WTFLogAlways("\nPage::resumeScriptedAnimations()");
 WTFReportBacktrace();
 }
+#endif
 
 m_scriptedAnimationsSuspended = false;
 for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218662] trunk

2017-06-21 Thread graouts

Title: [218662] trunk








Revision 218662
Author grao...@webkit.org
Date 2017-06-21 16:55:15 -0700 (Wed, 21 Jun 2017)


Log Message
Ensure DRT always logs rAF suspension debugging code
https://bugs.webkit.org/show_bug.cgi?id=173681

Reviewed by Tim "Mr. T" Horton.

Source/WebCore:

Instead of using a setting to check whether we should log information related to rAF
callbacks being suspended with WK1, we now check whether we're using in DRT to avoid
any potential issue with settings being in the incorrect state when a test is run.

* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::logSuspendCount):
* page/Page.cpp:
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):
* page/Settings.in:
* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::MacApplication::isDumpRenderTree):

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
(-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptedAnimationController.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (218661 => 218662)

--- trunk/Source/WebCore/ChangeLog	2017-06-21 22:55:34 UTC (rev 218661)
+++ trunk/Source/WebCore/ChangeLog	2017-06-21 23:55:15 UTC (rev 218662)
@@ -1,3 +1,24 @@
+2017-06-21  Antoine Quint  
+
+Ensure DRT always logs rAF suspension debugging code
+https://bugs.webkit.org/show_bug.cgi?id=173681
+
+Reviewed by Tim "Mr. T" Horton.
+
+Instead of using a setting to check whether we should log information related to rAF
+callbacks being suspended with WK1, we now check whether we're using in DRT to avoid
+any potential issue with settings being in the incorrect state when a test is run.
+
+* dom/ScriptedAnimationController.cpp:
+(WebCore::ScriptedAnimationController::logSuspendCount):
+* page/Page.cpp:
+(WebCore::Page::suspendScriptedAnimations):
+(WebCore::Page::resumeScriptedAnimations):
+* page/Settings.in:
+* platform/RuntimeApplicationChecks.h:
+* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+(WebCore::MacApplication::isDumpRenderTree):
+
 2017-06-21  Chris Dumez  
 
 Allow constructing a WTF:Function from a function pointer


Modified: trunk/Source/WebCore/dom/ScriptedAnimationController.cpp (218661 => 218662)

--- trunk/Source/WebCore/dom/ScriptedAnimationController.cpp	2017-06-21 22:55:34 UTC (rev 218661)
+++ trunk/Source/WebCore/dom/ScriptedAnimationController.cpp	2017-06-21 23:55:15 UTC (rev 218662)
@@ -39,6 +39,7 @@
 #include "MainFrame.h"
 #include "Page.h"
 #include "RequestAnimationFrameCallback.h"
+#include "RuntimeApplicationChecks.h"
 #include "Settings.h"
 #include 
 #include 
@@ -93,7 +94,7 @@
 
 void ScriptedAnimationController::logSuspendCount()
 {
-if (!m_document || !m_document->frame() || !m_document->frame()->settings().shouldLogScriptedAnimationControllerSuspensionChange())
+if (!m_document || !m_document->frame() || MacApplication::isDumpRenderTree())
 return;
 
 WTFLogAlways("\nScriptedAnimationController::m_suspendCount = %d", m_suspendCount);


Modified: trunk/Source/WebCore/page/Page.cpp (218661 => 218662)

--- trunk/Source/WebCore/page/Page.cpp	2017-06-21 22:55:34 UTC (rev 218661)
+++ trunk/Source/WebCore/page/Page.cpp	2017-06-21 23:55:15 UTC (rev 218662)
@@ -85,6 +85,7 @@
 #include "RenderView.h"
 #include "RenderWidget.h"
 #include "ResourceUsageOverlay.h"
+#include "RuntimeApplicationChecks.h"
 #include "RuntimeEnabledFeatures.h"
 #include "SVGDocumentExtensions.h"
 #include "SchemeRegistry.h"
@@ -1145,7 +1146,7 @@
 
 void Page::suspendScriptedAnimations()
 {
-if (settings().shouldLogScriptedAnimationControllerSuspensionChange()) {
+if (MacApplication::isDumpRenderTree()) {
 WTFLogAlways("\nPage::suspendScriptedAnimations()");
 WTFReportBacktrace();
 }
@@ -1159,7 +1160,7 @@
 
 void Page::resumeScriptedAnimations()
 {
-if (settings().shouldLogScriptedAnimationControllerSuspensionChan

[webkit-changes] [218661] tags/Safari-604.1.27/Source/WebKit2

2017-06-21 Thread matthew_hanson

Title: [218661] tags/Safari-604.1.27/Source/WebKit2








Revision 218661
Author matthew_han...@apple.com
Date 2017-06-21 15:55:34 -0700 (Wed, 21 Jun 2017)


Log Message
Cherry-pick r218656. rdar://problem/32905541

Modified Paths

tags/Safari-604.1.27/Source/WebKit2/ChangeLog
tags/Safari-604.1.27/Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm




Diff

Modified: tags/Safari-604.1.27/Source/WebKit2/ChangeLog (218660 => 218661)

--- tags/Safari-604.1.27/Source/WebKit2/ChangeLog	2017-06-21 22:53:14 UTC (rev 218660)
+++ tags/Safari-604.1.27/Source/WebKit2/ChangeLog	2017-06-21 22:55:34 UTC (rev 218661)
@@ -1,3 +1,25 @@
+2017-06-21  Matthew Hanson  
+
+Cherry-pick r218656. rdar://problem/32905541
+
+2017-06-21  Tim Horton  
+
+REGRESSION (r218606): 3D Touch action menu for links is missing items
+https://bugs.webkit.org/show_bug.cgi?id=173669
+
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/ios/WKActionSheetAssistant.mm:
+(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
+defaultActionsForLinkSheet is used outside the usual action sheet flow,
+by 3D Touch code. Therefore, we're not guaranteed to have a _positionInformation.
+We don't need one, though -- we can get the URL from the passed-in
+_WKActivatedElementInfo, exactly like defaultActionsForImageSheet already did.
+
+(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
+Remove the delegate null check, which isn't used after r218606.
+
 2017-06-21  Miguel Gomez  
 
 [GTK][WAYLAND] Create WaylandCompositorDisplay unconditionally when initializing the WebProcess


Modified: tags/Safari-604.1.27/Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm (218660 => 218661)

--- tags/Safari-604.1.27/Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm	2017-06-21 22:53:14 UTC (rev 218660)
+++ tags/Safari-604.1.27/Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm	2017-06-21 22:55:34 UTC (rev 218661)
@@ -441,14 +441,7 @@
 
 - (RetainPtr)defaultActionsForLinkSheet:(_WKActivatedElementInfo *)elementInfo
 {
-auto delegate = _delegate.get();
-if (!delegate)
-return nil;
-
-if (!_positionInformation)
-return nil;
-
-NSURL *targetURL = [NSURL URLWithString:_positionInformation->url];
+NSURL *targetURL = [elementInfo URL];
 if (!targetURL)
 return nil;
 
@@ -469,10 +462,6 @@
 
 - (RetainPtr)defaultActionsForImageSheet:(_WKActivatedElementInfo *)elementInfo
 {
-auto delegate = _delegate.get();
-if (!delegate)
-return nil;
-
 NSURL *targetURL = [elementInfo URL];
 
 auto defaultActions = adoptNS([[NSMutableArray alloc] init]);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218660] trunk

2017-06-21 Thread cdumez

Title: [218660] trunk








Revision 218660
Author cdu...@apple.com
Date 2017-06-21 15:53:14 -0700 (Wed, 21 Jun 2017)


Log Message
Allow constructing a WTF:Function from a function pointer
https://bugs.webkit.org/show_bug.cgi?id=173660

Reviewed by Alex Christensen.

Source/WebCore:

Construct WTF:Function directly from a function pointer when possible
instead of constructing a lambda to do so.

* Modules/encryptedmedia/InitDataRegistry.cpp:
(WebCore::InitDataRegistry::InitDataRegistry):
* page/Page.cpp:
* page/mac/PageMac.mm:
(WebCore::Page::platformInitialize):
* platform/cf/MainThreadSharedTimerCF.cpp:
(WebCore::setupPowerObserver):
* platform/mac/WebCoreNSURLExtras.mm:
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForWithReason):
* workers/Worker.cpp:
(WebCore::Worker::Worker):

Source/WTF:

Allow constructing a WTF:Function from a function pointer and
assigning a function pointer to a WTF:Function.

* wtf/Function.h:

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WTF/Function.cpp:
(TestWebKitAPI::returnThree):
(TestWebKitAPI::returnFour):
(TestWebKitAPI::returnPassedValue):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Function.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/mac/PageMac.mm
trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp
trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp
trunk/Source/WebCore/workers/Worker.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Function.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (218659 => 218660)

--- trunk/Source/WTF/ChangeLog	2017-06-21 22:46:46 UTC (rev 218659)
+++ trunk/Source/WTF/ChangeLog	2017-06-21 22:53:14 UTC (rev 218660)
@@ -1,3 +1,15 @@
+2017-06-21  Chris Dumez  
+
+Allow constructing a WTF:Function from a function pointer
+https://bugs.webkit.org/show_bug.cgi?id=173660
+
+Reviewed by Alex Christensen.
+
+Allow constructing a WTF:Function from a function pointer and
+assigning a function pointer to a WTF:Function.
+
+* wtf/Function.h:
+
 2017-06-20  Simon Fraser  
 
 Remove WILL_REVEAL_EDGE_EVENTS code


Modified: trunk/Source/WTF/wtf/Function.h (218659 => 218660)

--- trunk/Source/WTF/wtf/Function.h	2017-06-21 22:46:46 UTC (rev 218659)
+++ trunk/Source/WTF/wtf/Function.h	2017-06-21 22:53:14 UTC (rev 218660)
@@ -44,6 +44,12 @@
 {
 }
 
+template::value && std::is_function::type>::value>::type>
+Function(FunctionType f)
+: m_callableWrapper(std::make_unique>(WTFMove(f)))
+{
+}
+
 Out operator()(In... in) const
 {
 if (m_callableWrapper)
@@ -60,6 +66,13 @@
 return *this;
 }
 
+template::value && std::is_function::type>::value>::type>
+Function& operator=(FunctionType f)
+{
+m_callableWrapper = std::make_unique>(WTFMove(f));
+return *this;
+}
+
 Function& operator=(std::nullptr_t)
 {
 m_callableWrapper = nullptr;


Modified: trunk/Source/WebCore/ChangeLog (218659 => 218660)

--- trunk/Source/WebCore/ChangeLog	2017-06-21 22:46:46 UTC (rev 218659)
+++ trunk/Source/WebCore/ChangeLog	2017-06-21 22:53:14 UTC (rev 218660)
@@ -1,3 +1,26 @@
+2017-06-21  Chris Dumez  
+
+Allow constructing a WTF:Function from a function pointer
+https://bugs.webkit.org/show_bug.cgi?id=173660
+
+Reviewed by Alex Christensen.
+
+Construct WTF:Function directly from a function pointer when possible
+instead of constructing a lambda to do so.
+
+* Modules/encryptedmedia/InitDataRegistry.cpp:
+(WebCore::InitDataRegistry::InitDataRegistry):
+* page/Page.cpp:
+* page/mac/PageMac.mm:
+(WebCore::Page::platformInitialize):
+* platform/cf/MainThreadSharedTimerCF.cpp:
+(WebCore::setupPowerObserver):
+* platform/mac/WebCoreNSURLExtras.mm:
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::canUseForWithReason):
+* workers/Worker.cpp:
+(WebCore::Worker::Worker):
+
 2017-06-21  Antoine Quint  
 
 CSS text properties affect  shadow root


Modified: trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp (218659 => 218660)

--- trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp	2017-06-21 22:46:46 UTC (rev 218659)
+++ trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp	2017-06-21 22:53:14 UTC (rev 218660)
@@ -131,9 +131,9 @@
 
 InitDataRegistry::InitDataRegistry()
 {
-registerInitDataType("keyids", { &sanitizeKeyids, &extractKeyIDsKeyids });
-registerInitDataType("cenc", { &sanitizeCenc, &extractKeyIDsCenc });
-registerInitDataType("webm", { &sanitizeWebM, &extractKeyIDsWebM });
+registerInitDataType("keyids", { sanitizeKeyids, extractKeyIDsKeyids });
+

[webkit-changes] [218659] tags/Safari-604.1.27/

2017-06-21 Thread jmarcell

Title: [218659] tags/Safari-604.1.27/








Revision 218659
Author jmarc...@apple.com
Date 2017-06-21 15:46:46 -0700 (Wed, 21 Jun 2017)


Log Message
Tag Safari-604.1.27.

Added Paths

tags/Safari-604.1.27/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218658] branches/safari-604.1.25.3-branch/LayoutTests

2017-06-21 Thread ryanhaddad

Title: [218658] branches/safari-604.1.25.3-branch/LayoutTests








Revision 218658
Author ryanhad...@apple.com
Date 2017-06-21 15:43:25 -0700 (Wed, 21 Jun 2017)


Log Message
Unreviewed test gardening.

LayoutTests/imported/w3c:

* web-platform-tests/html/dom/reflection-metadata-expected.txt:
* web-platform-tests/html/dom/reflection-misc-expected.txt:
* web-platform-tests/html/dom/self-origin.sub-expected.txt:

LayoutTests:

* platform/mac/TestExpectations:

Modified Paths

branches/safari-604.1.25.3-branch/LayoutTests/ChangeLog
branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt
branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-misc-expected.txt
branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/web-platform-tests/html/dom/self-origin.sub-expected.txt
branches/safari-604.1.25.3-branch/LayoutTests/platform/mac/TestExpectations




Diff

Modified: branches/safari-604.1.25.3-branch/LayoutTests/ChangeLog (218657 => 218658)

--- branches/safari-604.1.25.3-branch/LayoutTests/ChangeLog	2017-06-21 22:13:19 UTC (rev 218657)
+++ branches/safari-604.1.25.3-branch/LayoutTests/ChangeLog	2017-06-21 22:43:25 UTC (rev 218658)
@@ -1,3 +1,9 @@
+2017-06-21  Ryan Haddad  
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2017-06-09  Matthew Hanson  
 
 Cherry-pick r218009. rdar://problem/32677465


Modified: branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/ChangeLog (218657 => 218658)

--- branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/ChangeLog	2017-06-21 22:13:19 UTC (rev 218657)
+++ branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/ChangeLog	2017-06-21 22:43:25 UTC (rev 218658)
@@ -1,3 +1,11 @@
+2017-06-21  Ryan Haddad  
+
+Unreviewed test gardening.
+
+* web-platform-tests/html/dom/reflection-metadata-expected.txt:
+* web-platform-tests/html/dom/reflection-misc-expected.txt:
+* web-platform-tests/html/dom/self-origin.sub-expected.txt:
+
 2017-06-09  Zan Dobersek  
 
 [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds


Modified: branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt (218657 => 218658)

--- branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt	2017-06-21 22:13:19 UTC (rev 218657)
+++ branches/safari-604.1.25.3-branch/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt	2017-06-21 22:43:25 UTC (rev 218658)
@@ -1399,38 +1399,38 @@
 PASS link.nonce: IDL set to null 
 PASS link.nonce: IDL set to object "test-toString" 
 PASS link.nonce: IDL set to object "test-valueOf" 
-PASS link.integrity: typeof IDL attribute 
-PASS link.integrity: IDL get with DOM attribute unset 
-PASS link.integrity: setAttribute() to "" 
-PASS link.integrity: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " 
-PASS link.integrity: setAttribute() to undefined 
-PASS link.integrity: setAttribute() to 7 
-PASS link.integrity: setAttribute() to 1.5 
-PASS link.integrity: setAttribute() to true 
-PASS link.integrity: setAttribute() to false 
-PASS link.integrity: setAttribute() to object "[object Object]" 
-PASS link.integrity: setAttribute() to NaN 
-PASS link.integrity: setAttribute() to Infinity 
-PASS link.integrity: setAttribute() to -Infinity 
-PASS link.integrity: setAttribute() to "\0" 
-PASS link.integrity: setAttribute() to null 
-PASS link.integrity: setAttribute() to object "test-toString" 
-PASS link.integrity: setAttribute() to object "test-valueOf" 
-PASS link.integrity: IDL set to "" 
-PASS link.integrity: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " 
-PASS link.integrity: IDL set to undefined 
-PASS link.integrity: IDL set to 7 
-PASS link.integrity: IDL set to 1.5 
-PASS link.integrity: IDL set to true 
-PASS link.integrity: IDL set to false 
-PASS link.integrity: IDL set to object "[object Object]" 
-PASS link.integrity: IDL set to NaN 
-PASS link.integrity: IDL set to Infinity 
-PASS link.integrity: IDL set to -Infinity 
-PASS link.integrity: IDL set to "\0" 
-PASS link.integrity: IDL set to null 
-PASS link.integrity: IDL set to object "test-toString" 
-PASS link.integrity: IDL set to object "test-valueOf" 
+FAIL link.integrity: typeof IDL attribute assert_equals: expected "string" but got "undefined"
+FAIL link.integrity: IDL get with DOM attribute unset assert_equals: expected (string) "" but got (undefined) undefined
+FAIL link.integrity: setAttribute() to "" assert_equals: IDL get expected (string) "" but got (undefined) undefined
+FAIL link.integrity: setAttribute

[webkit-changes] [218657] trunk/Source/ThirdParty/libwebrtc

2017-06-21 Thread commit-queue

Title: [218657] trunk/Source/ThirdParty/libwebrtc








Revision 218657
Author commit-qu...@webkit.org
Date 2017-06-21 15:13:19 -0700 (Wed, 21 Jun 2017)


Log Message
Fix build after r218645
https://bugs.webkit.org/show_bug.cgi?id=173668

Unreviewed.

Patch by Youenn Fablet  on 2017-06-21

* Source/webrtc/base/sigslottester.h: Removing executable right.
* Source/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:
(webrtc::TemporalLayersFactory::Create): Inline a default implementation.
* Source/webrtc/modules/video_processing/util/skin_detection.h: Removing executable right.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/sigslottester.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_processing/util/skin_detection.h


Property Changed

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/sigslottester.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_processing/util/skin_detection.h




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (218656 => 218657)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-06-21 22:11:07 UTC (rev 218656)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-06-21 22:13:19 UTC (rev 218657)
@@ -1,5 +1,17 @@
 2017-06-21  Youenn Fablet  
 
+Fix build after r218645
+https://bugs.webkit.org/show_bug.cgi?id=173668
+
+Unreviewed.
+
+* Source/webrtc/base/sigslottester.h: Removing executable right.
+* Source/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:
+(webrtc::TemporalLayersFactory::Create): Inline a default implementation.
+* Source/webrtc/modules/video_processing/util/skin_detection.h: Removing executable right.
+
+2017-06-21  Youenn Fablet  
+
 Remove expat source code from Source/ThirdParty/libwebrtc
 https://bugs.webkit.org/show_bug.cgi?id=173656
 
Index: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/sigslottester.h
===
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/sigslottester.h	2017-06-21 22:11:07 UTC (rev 218656)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/sigslottester.h	2017-06-21 22:13:19 UTC (rev 218657)


Property changes: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/sigslottester.h



Deleted: svn:executable
-*
\ No newline at end of property

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (218656 => 218657)

--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h	2017-06-21 22:11:07 UTC (rev 218656)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h	2017-06-21 22:13:19 UTC (rev 218657)
@@ -100,9 +100,9 @@
  public:
   TemporalLayersFactory() : listener_(nullptr) {}
   virtual ~TemporalLayersFactory() {}
-  virtual TemporalLayers* Create(int simulcast_id,
- int temporal_layers,
- uint8_t initial_tl0_pic_idx) const;
+  virtual TemporalLayers* Create(int /* simulcast_id */,
+ int /* temporal_layers */,
+ uint8_t /* initial_tl0_pic_idx */) const { return nullptr; }
   void SetListener(TemporalLayersListener* listener);
 
  protected:
Index: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_processing/util/skin_detection.h
===
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_processing/util/skin_detection.h	2017-06-21 22:11:07 UTC (rev 218656)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_processing/util/skin_detection.h	2017-06-21 22:13:19 UTC (rev 218657)


Property changes: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_processing/util/skin_detection.h



Deleted: svn:executable
-*
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218656] trunk/Source/WebKit2

2017-06-21 Thread timothy_horton

Title: [218656] trunk/Source/WebKit2








Revision 218656
Author timothy_hor...@apple.com
Date 2017-06-21 15:11:07 -0700 (Wed, 21 Jun 2017)


Log Message
REGRESSION (r218606): 3D Touch action menu for links is missing items
https://bugs.webkit.org/show_bug.cgi?id=173669


Reviewed by Wenson Hsieh.

* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
defaultActionsForLinkSheet is used outside the usual action sheet flow,
by 3D Touch code. Therefore, we're not guaranteed to have a _positionInformation.
We don't need one, though -- we can get the URL from the passed-in
_WKActivatedElementInfo, exactly like defaultActionsForImageSheet already did.

(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
Remove the delegate null check, which isn't used after r218606.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (218655 => 218656)

--- trunk/Source/WebKit2/ChangeLog	2017-06-21 21:55:27 UTC (rev 218655)
+++ trunk/Source/WebKit2/ChangeLog	2017-06-21 22:11:07 UTC (rev 218656)
@@ -1,3 +1,21 @@
+2017-06-21  Tim Horton  
+
+REGRESSION (r218606): 3D Touch action menu for links is missing items
+https://bugs.webkit.org/show_bug.cgi?id=173669
+
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/ios/WKActionSheetAssistant.mm:
+(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
+defaultActionsForLinkSheet is used outside the usual action sheet flow,
+by 3D Touch code. Therefore, we're not guaranteed to have a _positionInformation.
+We don't need one, though -- we can get the URL from the passed-in
+_WKActivatedElementInfo, exactly like defaultActionsForImageSheet already did.
+
+(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
+Remove the delegate null check, which isn't used after r218606.
+
 2017-06-21  Daniel Bates  
 
 Cleanup FrameLoadRequest


Modified: trunk/Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm (218655 => 218656)

--- trunk/Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm	2017-06-21 21:55:27 UTC (rev 218655)
+++ trunk/Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm	2017-06-21 22:11:07 UTC (rev 218656)
@@ -441,14 +441,7 @@
 
 - (RetainPtr)defaultActionsForLinkSheet:(_WKActivatedElementInfo *)elementInfo
 {
-auto delegate = _delegate.get();
-if (!delegate)
-return nil;
-
-if (!_positionInformation)
-return nil;
-
-NSURL *targetURL = [NSURL URLWithString:_positionInformation->url];
+NSURL *targetURL = [elementInfo URL];
 if (!targetURL)
 return nil;
 
@@ -469,10 +462,6 @@
 
 - (RetainPtr)defaultActionsForImageSheet:(_WKActivatedElementInfo *)elementInfo
 {
-auto delegate = _delegate.get();
-if (!delegate)
-return nil;
-
 NSURL *targetURL = [elementInfo URL];
 
 auto defaultActions = adoptNS([[NSMutableArray alloc] init]);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218655] trunk

2017-06-21 Thread commit-queue

Title: [218655] trunk








Revision 218655
Author commit-qu...@webkit.org
Date 2017-06-21 14:55:27 -0700 (Wed, 21 Jun 2017)


Log Message
CSS text properties affect  shadow root
https://bugs.webkit.org/show_bug.cgi?id=173664


Patch by Antoine Quint  on 2017-06-21
Reviewed by Dean Jackson.

Source/WebCore:

Ensure that we reset all inheritable styles back to their initial value for media shadow roots.

Test: media/modern-media-controls/time-label/time-label-inherited-text-indent.html

* Modules/modern-media-controls/controls/media-controls.css:
(.media-controls-container):

LayoutTests:

Add a test that ensures that setting an inheritable style on the  does not affect
time labels within the shadow root.

* media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt: Added.
* media/modern-media-controls/time-label/time-label-inherited-text-indent.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css


Added Paths

trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt
trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent.html




Diff

Modified: trunk/LayoutTests/ChangeLog (218654 => 218655)

--- trunk/LayoutTests/ChangeLog	2017-06-21 21:50:42 UTC (rev 218654)
+++ trunk/LayoutTests/ChangeLog	2017-06-21 21:55:27 UTC (rev 218655)
@@ -1,3 +1,17 @@
+2017-06-21  Antoine Quint  
+
+CSS text properties affect  shadow root
+https://bugs.webkit.org/show_bug.cgi?id=173664
+
+
+Reviewed by Dean Jackson.
+
+Add a test that ensures that setting an inheritable style on the  does not affect
+time labels within the shadow root.
+
+* media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt: Added.
+* media/modern-media-controls/time-label/time-label-inherited-text-indent.html: Added.
+
 2017-06-21  Joseph Pecoraro  
 
 Web Inspector: Using "break on all exceptions" when throwing stack overflow hangs inspector


Added: trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt (0 => 218655)

--- trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt	2017-06-21 21:55:27 UTC (rev 218655)
@@ -0,0 +1,11 @@
+Testing that the text-indent property set on the host does not affect time labels.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS !!shadowRoot.querySelector('.time-label') became true
+PASS getComputedStyle(shadowRoot.querySelector('.time-label')).textIndent is "0px"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent.html (0 => 218655)

--- trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent.html	(rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent.html	2017-06-21 21:55:27 UTC (rev 218655)
@@ -0,0 +1,22 @@
+
+
+
+
+
+
+window.jsTestIsAsync = true;
+
+description("Testing that the text-indent property set on the host does not affect time labels.");
+
+const media = document.querySelector("video");
+const shadowRoot = window.internals.shadowRoot(media);
+
+shouldBecomeEqual("!!shadowRoot.querySelector('.time-label')", "true", () => {
+shouldBeEqualToString("getComputedStyle(shadowRoot.querySelector('.time-label')).textIndent", "0px");
+finishJSTest();
+});
+
+
+

[webkit-changes] [218654] branches/safari-603-branch/Source

2017-06-21 Thread jmarcell

Title: [218654] branches/safari-603-branch/Source








Revision 218654
Author jmarc...@apple.com
Date 2017-06-21 14:50:42 -0700 (Wed, 21 Jun 2017)


Log Message
Versioning.

Modified Paths

branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig (218653 => 218654)

--- branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-06-21 21:35:22 UTC (rev 218653)
+++ branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-06-21 21:50:42 UTC (rev 218654)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig (218653 => 218654)

--- branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig	2017-06-21 21:35:22 UTC (rev 218653)
+++ branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig	2017-06-21 21:50:42 UTC (rev 218654)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (218653 => 218654)

--- branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-06-21 21:35:22 UTC (rev 218653)
+++ branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-06-21 21:50:42 UTC (rev 218654)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig (218653 => 218654)

--- branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-06-21 21:35:22 UTC (rev 218653)
+++ branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-06-21 21:50:42 UTC (rev 218654)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig (218653 => 218654)

--- branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-06-21 21:35:22 UTC (rev 218653)
+++ branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-06-21 21:50:42 UTC (rev 218654)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218653] tags/Safari-603.3.7/

2017-06-21 Thread jmarcell

Title: [218653] tags/Safari-603.3.7/








Revision 218653
Author jmarc...@apple.com
Date 2017-06-21 14:35:22 -0700 (Wed, 21 Jun 2017)


Log Message
Tag Safari-603.3.7.

Added Paths

tags/Safari-603.3.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218652] trunk

2017-06-21 Thread commit-queue

Title: [218652] trunk








Revision 218652
Author commit-qu...@webkit.org
Date 2017-06-21 14:32:44 -0700 (Wed, 21 Jun 2017)


Log Message
Web Inspector: Using "break on all exceptions" when throwing stack overflow hangs inspector
https://bugs.webkit.org/show_bug.cgi?id=172432


Patch by Joseph Pecoraro  on 2017-06-21
Reviewed by Saam Barati.

Source/_javascript_Core:

Avoid pausing on StackOverflow and OutOfMemory errors to avoid a hang.
We will proceed to improve debugging of these cases in the follow-up bugs.

* debugger/Debugger.cpp:
(JSC::Debugger::exception):
Ignore pausing on these errors.

* runtime/ErrorInstance.h:
(JSC::ErrorInstance::setStackOverflowError):
(JSC::ErrorInstance::isStackOverflowError):
(JSC::ErrorInstance::setOutOfMemoryError):
(JSC::ErrorInstance::isOutOfMemoryError):
* runtime/ExceptionHelpers.cpp:
(JSC::createStackOverflowError):
* runtime/Error.cpp:
(JSC::createOutOfMemoryError):
Mark these kinds of errors.

LayoutTests:

* inspector/debugger/no-pause-out-of-memory-exception-expected.txt: Added.
* inspector/debugger/no-pause-out-of-memory-exception.html: Added.
* inspector/debugger/no-pause-stack-overflow-exception-expected.txt: Added.
* inspector/debugger/no-pause-stack-overflow-exception.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/debugger/Debugger.cpp
trunk/Source/_javascript_Core/runtime/Error.cpp
trunk/Source/_javascript_Core/runtime/ErrorInstance.h
trunk/Source/_javascript_Core/runtime/ExceptionHelpers.cpp


Added Paths

trunk/LayoutTests/inspector/debugger/no-pause-out-of-memory-exception-expected.txt
trunk/LayoutTests/inspector/debugger/no-pause-out-of-memory-exception.html
trunk/LayoutTests/inspector/debugger/no-pause-stack-overflow-exception-expected.txt
trunk/LayoutTests/inspector/debugger/no-pause-stack-overflow-exception.html




Diff

Modified: trunk/LayoutTests/ChangeLog (218651 => 218652)

--- trunk/LayoutTests/ChangeLog	2017-06-21 21:29:21 UTC (rev 218651)
+++ trunk/LayoutTests/ChangeLog	2017-06-21 21:32:44 UTC (rev 218652)
@@ -1,3 +1,16 @@
+2017-06-21  Joseph Pecoraro  
+
+Web Inspector: Using "break on all exceptions" when throwing stack overflow hangs inspector
+https://bugs.webkit.org/show_bug.cgi?id=172432
+
+
+Reviewed by Saam Barati.
+
+* inspector/debugger/no-pause-out-of-memory-exception-expected.txt: Added.
+* inspector/debugger/no-pause-out-of-memory-exception.html: Added.
+* inspector/debugger/no-pause-stack-overflow-exception-expected.txt: Added.
+* inspector/debugger/no-pause-stack-overflow-exception.html: Added.
+
 2017-06-20  Simon Fraser  
 
 Remove WILL_REVEAL_EDGE_EVENTS code


Added: trunk/LayoutTests/inspector/debugger/no-pause-out-of-memory-exception-expected.txt (0 => 218652)

--- trunk/LayoutTests/inspector/debugger/no-pause-out-of-memory-exception-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/no-pause-out-of-memory-exception-expected.txt	2017-06-21 21:32:44 UTC (rev 218652)
@@ -0,0 +1,9 @@
+CONSOLE MESSAGE: line 12: Error: Out of memory
+Test we do not pause on a OutOfMemory Exception.
+
+
+== Running test suite: Debugger.OutOfMemoryException
+-- Running test case: Debugger.OutOfMemoryException.NoPause
+Uncaught exception in test page: Error: Out of memory [no-pause-out-of-memory-exception.html:12]
+PASS: Should not pause on OutOfMemory Exception.
+


Added: trunk/LayoutTests/inspector/debugger/no-pause-out-of-memory-exception.html (0 => 218652)

--- trunk/LayoutTests/inspector/debugger/no-pause-out-of-memory-exception.html	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/no-pause-out-of-memory-exception.html	2017-06-21 21:32:44 UTC (rev 218652)
@@ -0,0 +1,54 @@
+
+
+
+
+TestPage.allowUncaughtExceptions = true;
+TestPage.needToSanitizeUncaughtExceptionURLs = true;
+
+function triggerOutOfMemoryException() {
+let s = "a";
+while (true)
+s += s;
+}
+
+window.addEventListener("error", (event) => {
+TestPage.dispatchEventToFrontend("AfterError");
+});
+
+function test()
+{
+WebInspector.debuggerManager.allExceptionsBreakpoint.disabled = false;
+
+let suite = InspectorTest.createAsyncSuite("Debugger.OutOfMemoryException");
+
+suite.addTestCase({
+name: "Debugger.OutOfMemoryException.NoPause",
+description: "Should not pause on a OutOfMemory Exception.",
+test(resolve, reject) {
+let paused = false;
+
+WebInspector.debuggerManager.singleFireEventListener(WebInspector.DebuggerManager.Event.Paused, (event) => {
+paused = true;
+InspectorTest.fail("Should not pause.");
+reject();
+});
+
+InspectorTest.singleFireEventListener("AfterError", (event) => {
+if (!paused)
+InspectorTest.pass("Should not pause on OutOfMemory Exception.");
+

[webkit-changes] [218651] trunk

2017-06-21 Thread simon . fraser

Title: [218651] trunk








Revision 218651
Author simon.fra...@apple.com
Date 2017-06-21 14:29:21 -0700 (Wed, 21 Jun 2017)


Log Message
Remove WILL_REVEAL_EDGE_EVENTS code
https://bugs.webkit.org/show_bug.cgi?id=173632

Reviewed by Sam Weinig, Beth Dakin.

Remove will-reveal-edge events, which never took off.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::clearScriptedAnimationController):
(WebCore::Document::sendWillRevealEdgeEventsIfNeeded): Deleted.
* dom/Document.h:
* dom/GlobalEventHandlers.idl:
* html/HTMLBodyElement.idl:
* html/HTMLFrameSetElement.idl:
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):

Source/WTF:

* wtf/FeatureDefines.h:

LayoutTests:

* fast/events/will-reveal-edge-on-div-expected.txt: Removed.
* fast/events/will-reveal-edge-on-div.html: Removed.
* fast/events/will-reveal-edges-body-attributes-expected.txt: Removed.
* fast/events/will-reveal-edges-body-attributes.html: Removed.
* fast/events/will-reveal-edges-event-listeners-expected.txt: Removed.
* fast/events/will-reveal-edges-event-listeners.html: Removed.
* fast/events/will-reveal-edges-window-attributes-expected.txt: Removed.
* fast/events/will-reveal-edges-window-attributes.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/GlobalEventHandlers.idl
trunk/Source/WebCore/html/HTMLBodyElement.idl
trunk/Source/WebCore/html/HTMLFrameSetElement.idl
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp


Removed Paths

trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt
trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html
trunk/LayoutTests/fast/events/will-reveal-edges-body-attributes-expected.txt
trunk/LayoutTests/fast/events/will-reveal-edges-body-attributes.html
trunk/LayoutTests/fast/events/will-reveal-edges-event-listeners-expected.txt
trunk/LayoutTests/fast/events/will-reveal-edges-event-listeners.html
trunk/LayoutTests/fast/events/will-reveal-edges-window-attributes-expected.txt
trunk/LayoutTests/fast/events/will-reveal-edges-window-attributes.html




Diff

Modified: trunk/LayoutTests/ChangeLog (218650 => 218651)

--- trunk/LayoutTests/ChangeLog	2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/ChangeLog	2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,3 +1,21 @@
+2017-06-20  Simon Fraser  
+
+Remove WILL_REVEAL_EDGE_EVENTS code
+https://bugs.webkit.org/show_bug.cgi?id=173632
+
+Reviewed by Sam Weinig, Beth Dakin.
+
+Remove will-reveal-edge events, which never took off.
+
+* fast/events/will-reveal-edge-on-div-expected.txt: Removed.
+* fast/events/will-reveal-edge-on-div.html: Removed.
+* fast/events/will-reveal-edges-body-attributes-expected.txt: Removed.
+* fast/events/will-reveal-edges-body-attributes.html: Removed.
+* fast/events/will-reveal-edges-event-listeners-expected.txt: Removed.
+* fast/events/will-reveal-edges-event-listeners.html: Removed.
+* fast/events/will-reveal-edges-window-attributes-expected.txt: Removed.
+* fast/events/will-reveal-edges-window-attributes.html: Removed.
+
 2017-06-21  Simon Fraser  
 
 svgPath.getTotalLength() freezes webkit


Deleted: trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt (218650 => 218651)

--- trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt	2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt	2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,10 +0,0 @@
-This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html (218650 => 218651)

--- trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html	2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html	2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,83 +0,0 @@
-
-
-#scrolly-div {
-width:200px;
-height:200px;
-border:2px solid black;
-overflow:scroll;
-}
-
-.big {
-background-color:purple;
-width:600px;
-height:600px;
-}
-
-
-