[webkit-changes] [225777] trunk/Source/WebCore/PAL
Title: [225777] trunk/Source/WebCore/PAL Revision 225777 Author joep...@webkit.org Date 2017-12-11 23:20:37 -0800 (Mon, 11 Dec 2017) Log Message Unreviewed build fix after r225766. * pal/spi/mac/AVFoundationSPI.h: Conform AVStreamDataParser to the AVContentKeyRecipient protocol if available. Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (225776 => 225777) --- trunk/Source/WebCore/PAL/ChangeLog 2017-12-12 07:11:04 UTC (rev 225776) +++ trunk/Source/WebCore/PAL/ChangeLog 2017-12-12 07:20:37 UTC (rev 225777) @@ -1,3 +1,10 @@ +2017-12-11 Joseph Pecoraro + +Unreviewed build fix after r225766. + +* pal/spi/mac/AVFoundationSPI.h: +Conform AVStreamDataParser to the AVContentKeyRecipient protocol if available. + 2017-12-11 David Quesada Turn on ENABLE_APPLICATION_MANIFEST Modified: trunk/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h (225776 => 225777) --- trunk/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h 2017-12-12 07:11:04 UTC (rev 225776) +++ trunk/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h 2017-12-12 07:20:37 UTC (rev 225777) @@ -146,6 +146,12 @@ NS_ASSUME_NONNULL_END +#if HAVE(AVCONTENTKEYSESSION) +#import +@interface AVStreamDataParser () +@end +#endif + #endif // !PLATFORM(IOS) #endif // USE(APPLE_INTERNAL_SDK) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225776] trunk
Title: [225776] trunk Revision 225776 Author r...@igalia.com Date 2017-12-11 23:11:04 -0800 (Mon, 11 Dec 2017) Log Message [css-grid] Automatic minimum size is not clamped if min track sizing function is auto https://bugs.webkit.org/show_bug.cgi?id=180283 Reviewed by Darin Adler. LayoutTests/imported/w3c: Update expected result in the following WPT tests, as now everything is passing there. * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022-expected.txt: * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023-expected.txt: Source/WebCore: We were not clamping the automatic minimum size when the min track sizing function was intrinsic (e.g. minmax(auto, 0px)). However the spec (https://drafts.csswg.org/css-grid/#min-size-auto) is very clear regarding that. This patch modifies GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem(), so in the case of a fixed max track sizing function it clamps the automatic minimum size of the item to the stretch fit of the grid area's size. It needs to take into account if the item has fixed size, margin, border and/or padding as those cannot be clamped. Using WPT tests to verify this behavior, and corrected a bunch of other tests that were wrong. Test: imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-017.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023.html * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem): * rendering/GridTrackSizingAlgorithm.h: (WebCore::GridTrack::growthLimitIsInfinite const): * rendering/style/GridTrackSize.h: (WebCore::GridTrackSize::cacheMinMaxTrackBreadthTypes): (WebCore::GridTrackSize::hasFixedMaxTrackBreadth const): LayoutTests: This patch updates a bunch of tests that were wrong to follow the new behavior. * TestExpectations: Now we're passing one WPT test more. * fast/css-grid-layout/min-height-border-box.html: * fast/css-grid-layout/min-width-margin-box.html: * fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html: * fast/css-grid-layout/percent-of-indefinite-track-size.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/fast/css-grid-layout/min-height-border-box.html trunk/LayoutTests/fast/css-grid-layout/min-width-margin-box.html trunk/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html trunk/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h trunk/Source/WebCore/rendering/style/GridTrackSize.h Diff Modified: trunk/LayoutTests/ChangeLog (225775 => 225776) --- trunk/LayoutTests/ChangeLog 2017-12-12 07:06:16 UTC (rev 225775) +++ trunk/LayoutTests/ChangeLog 2017-12-12 07:11:04 UTC (rev 225776) @@ -1,3 +1,19 @@ +2017-12-11 Manuel Rego Casasnovas + +[css-grid] Automatic minimum size is not clamped if min track sizing function is auto +https://bugs.webkit.org/show_bug.cgi?id=180283 + +Reviewed by Darin Adler. + +This patch updates a bunch of tests that were wrong +to follow the new behavior. + +* TestExpectations: Now we're passing one WPT test more. +* fast/css-grid-layout/min-height-border-box.html: +* fast/css-grid-layout/min-width-margin-box.html: +* fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html: +* fast/css-grid-layout/percent-of-indefinite-track-size.html: + 2017-12-11 Eric Carlson Web Inspector: Optionally log WebKit log parameters as JSON Modified: trunk/LayoutTests/TestExpectations (225775 => 225776) --- trunk/LayoutTests/TestExpectations 2017-12-12 07:06:16 UTC (rev 225775) +++ trunk/LayoutTests/TestExpectations 2017-12-12 07:11:04 UTC (rev 225776) @@ -478,7 +478,6 @@ webkit.org/b/165062 fast/css-grid-layout/grid-baseline.html [ ImageOnlyFailure ] webkit.org/b/165062 fast/css-grid-layout/grid-baseline-margins.html [ ImageOnlyFailure ] webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ] -webkit.org/b/180283 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-017.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-001.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-te
[webkit-changes] [225775] trunk/Source/WebCore
Title: [225775] trunk/Source/WebCore
Revision 225775
Author zandober...@gmail.com
Date 2017-12-11 23:06:16 -0800 (Mon, 11 Dec 2017)
Log Message
[Cairo] Cairo::clipToImageBuffer() should operate on a cairo_surface_t
https://bugs.webkit.org/show_bug.cgi?id=180665
Reviewed by Michael Catanzaro.
Have the Cairo::clipToImageBuffer() function in the CairoUtilities code
operate on a cairo_surface_t object, instead of an Image object.
Call site in GraphicsContext::clipToImageBuffer() is adjusted to first
ensure a non-null Image object, and then retrieve a cairo_surface_t
object from that, passing it on to Cairo::clipToImageBuffer().
No new tests -- no change in functionality.
* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::clipToImageBuffer):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipToImageBuffer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp
trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (225774 => 225775)
--- trunk/Source/WebCore/ChangeLog 2017-12-12 07:05:30 UTC (rev 225774)
+++ trunk/Source/WebCore/ChangeLog 2017-12-12 07:06:16 UTC (rev 225775)
@@ -1,5 +1,27 @@
2017-12-11 Zan Dobersek
+[Cairo] Cairo::clipToImageBuffer() should operate on a cairo_surface_t
+https://bugs.webkit.org/show_bug.cgi?id=180665
+
+Reviewed by Michael Catanzaro.
+
+Have the Cairo::clipToImageBuffer() function in the CairoUtilities code
+operate on a cairo_surface_t object, instead of an Image object.
+
+Call site in GraphicsContext::clipToImageBuffer() is adjusted to first
+ensure a non-null Image object, and then retrieve a cairo_surface_t
+object from that, passing it on to Cairo::clipToImageBuffer().
+
+No new tests -- no change in functionality.
+
+* platform/graphics/cairo/CairoOperations.cpp:
+(WebCore::Cairo::clipToImageBuffer):
+* platform/graphics/cairo/CairoOperations.h:
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+(WebCore::GraphicsContext::clipToImageBuffer):
+
+2017-12-11 Zan Dobersek
+
[Cairo] Don't use a static cairo_surface_t object for CairoPath contexts
https://bugs.webkit.org/show_bug.cgi?id=180663
Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp (225774 => 225775)
--- trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp 2017-12-12 07:05:30 UTC (rev 225774)
+++ trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp 2017-12-12 07:06:16 UTC (rev 225775)
@@ -1004,11 +1004,9 @@
graphicsContextPrivate->clip(path);
}
-void clipToImageBuffer(PlatformContextCairo& platformContext, Image& image, const FloatRect& destRect)
+void clipToImageBuffer(PlatformContextCairo& platformContext, cairo_surface_t* image, const FloatRect& destRect)
{
-RefPtr surface = image.nativeImageForCurrentFrame();
-if (surface)
-platformContext.pushImageMask(surface.get(), destRect);
+platformContext.pushImageMask(image, destRect);
}
} // namespace Cairo
Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h (225774 => 225775)
--- trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h 2017-12-12 07:05:30 UTC (rev 225774)
+++ trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h 2017-12-12 07:06:16 UTC (rev 225775)
@@ -47,7 +47,6 @@
class FloatRoundedRect;
class FloatSize;
class GraphicsContext;
-class Image;
class Path;
class PlatformContextCairo;
@@ -123,7 +122,7 @@
void clipOut(PlatformContextCairo&, const Path&);
void clipPath(PlatformContextCairo&, const Path&, WindRule);
-void clipToImageBuffer(PlatformContextCairo&, Image&, const FloatRect&);
+void clipToImageBuffer(PlatformContextCairo&, cairo_surface_t*, const FloatRect&);
} // namespace Cairo
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (225774 => 225775)
--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2017-12-12 07:05:30 UTC (rev 225774)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2017-12-12 07:06:16 UTC (rev 225775)
@@ -267,9 +267,12 @@
return;
RefPtr image = buffer.copyImage(DontCopyBackingStore);
+if (!image)
+return;
ASSERT(hasPlatformContext());
-Cairo::clipToImageBuffer(*platformContext(), *image, destRect);
+if (auto surface = image->nativeImageForCurrentFrame())
+Cairo::clipToImageBuffer(*platformContext(), surface.get(), destRect);
}
IntRect GraphicsContext::clipBounds() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org
[webkit-changes] [225774] trunk/Source/WebCore
Title: [225774] trunk/Source/WebCore
Revision 225774
Author zandober...@gmail.com
Date 2017-12-11 23:05:30 -0800 (Mon, 11 Dec 2017)
Log Message
[Cairo] Don't use a static cairo_surface_t object for CairoPath contexts
https://bugs.webkit.org/show_bug.cgi?id=180663
Reviewed by Michael Catanzaro.
Instead of using a single cairo_surface_t object and sharing it between
different cairo_t objects handled by CairoPath, create a new mock 1x1px
alpha-only surface for each cairo_t object that's allocated in the
CairoPath constructor.
This avoids potential issues in how Cairo's state handling internally
uses these surfaces, which is completely opaque to us and out of our
control. This also avoids crashes when using this one cairo_surface_t
object through different CairoPath objects across different threads.
No new tests -- no change in behavior.
* platform/graphics/cairo/PlatformPathCairo.cpp:
(WebCore::CairoPath::CairoPath):
(WebCore::pathSurface): Deleted.
* platform/graphics/cairo/PlatformPathCairo.h:
(WebCore::CairoPath::context):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/PlatformPathCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/PlatformPathCairo.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (225773 => 225774)
--- trunk/Source/WebCore/ChangeLog 2017-12-12 07:04:44 UTC (rev 225773)
+++ trunk/Source/WebCore/ChangeLog 2017-12-12 07:05:30 UTC (rev 225774)
@@ -1,5 +1,30 @@
2017-12-11 Zan Dobersek
+[Cairo] Don't use a static cairo_surface_t object for CairoPath contexts
+https://bugs.webkit.org/show_bug.cgi?id=180663
+
+Reviewed by Michael Catanzaro.
+
+Instead of using a single cairo_surface_t object and sharing it between
+different cairo_t objects handled by CairoPath, create a new mock 1x1px
+alpha-only surface for each cairo_t object that's allocated in the
+CairoPath constructor.
+
+This avoids potential issues in how Cairo's state handling internally
+uses these surfaces, which is completely opaque to us and out of our
+control. This also avoids crashes when using this one cairo_surface_t
+object through different CairoPath objects across different threads.
+
+No new tests -- no change in behavior.
+
+* platform/graphics/cairo/PlatformPathCairo.cpp:
+(WebCore::CairoPath::CairoPath):
+(WebCore::pathSurface): Deleted.
+* platform/graphics/cairo/PlatformPathCairo.h:
+(WebCore::CairoPath::context):
+
+2017-12-11 Zan Dobersek
+
[CoordGraphics] Move UpdateAtlas, AreaAllocator into the platform layer
https://bugs.webkit.org/show_bug.cgi?id=180641
Modified: trunk/Source/WebCore/platform/graphics/cairo/PlatformPathCairo.cpp (225773 => 225774)
--- trunk/Source/WebCore/platform/graphics/cairo/PlatformPathCairo.cpp 2017-12-12 07:04:44 UTC (rev 225773)
+++ trunk/Source/WebCore/platform/graphics/cairo/PlatformPathCairo.cpp 2017-12-12 07:05:30 UTC (rev 225774)
@@ -26,15 +26,11 @@
namespace WebCore {
-static cairo_surface_t* pathSurface()
-{
-static cairo_surface_t* s_pathSurface = cairo_image_surface_create(CAIRO_FORMAT_A8, 1, 1);
-return s_pathSurface;
-}
-
CairoPath::CairoPath()
-: m_cr(adoptRef(cairo_create(pathSurface(
{
+// cairo_t takes its own reference of the surface, meaning we don't have to keep one.
+auto surface = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_A8, 1, 1));
+m_context = adoptRef(cairo_create(surface.get()));
}
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/graphics/cairo/PlatformPathCairo.h (225773 => 225774)
--- trunk/Source/WebCore/platform/graphics/cairo/PlatformPathCairo.h 2017-12-12 07:04:44 UTC (rev 225773)
+++ trunk/Source/WebCore/platform/graphics/cairo/PlatformPathCairo.h 2017-12-12 07:05:30 UTC (rev 225774)
@@ -18,8 +18,7 @@
* Boston, MA 02110-1301, USA.
*/
-#ifndef PlatformPathCairo_h
-#define PlatformPathCairo_h
+#pragma once
#if USE(CAIRO)
@@ -31,17 +30,14 @@
class CairoPath {
public:
CairoPath();
-
~CairoPath() = default;
-cairo_t* context() { return m_cr.get(); }
+cairo_t* context() { return m_context.get(); }
private:
-RefPtr m_cr;
+RefPtr m_context;
};
} // namespace WebCore
#endif // USE(CAIRO)
-
-#endif // PlatformPathCairo_h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225773] trunk/Source
Title: [225773] trunk/Source Revision 225773 Author zandober...@gmail.com Date 2017-12-11 23:04:44 -0800 (Mon, 11 Dec 2017) Log Message [CoordGraphics] Move UpdateAtlas, AreaAllocator into the platform layer https://bugs.webkit.org/show_bug.cgi?id=180641 Reviewed by Michael Catanzaro. Source/WebCore: Move the UpdateAtlas and AreaAllocator classes and their source files into the platform layer. This still means using the WebCore namespace, but apart from that these two classes have no dependency on anything in the WebKit layer, so they can be moved from there. No new tests -- no change in functionality. * platform/TextureMapper.cmake: * platform/graphics/texmap/coordinated/AreaAllocator.cpp: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp. (WebCore::AreaAllocator::AreaAllocator): (WebCore::AreaAllocator::~AreaAllocator): (WebCore::AreaAllocator::expand): (WebCore::AreaAllocator::expandBy): (WebCore::AreaAllocator::release): (WebCore::AreaAllocator::overhead const): (WebCore::AreaAllocator::roundAllocation const): (WebCore::GeneralAreaAllocator::GeneralAreaAllocator): (WebCore::GeneralAreaAllocator::~GeneralAreaAllocator): (WebCore::GeneralAreaAllocator::freeNode): (WebCore::GeneralAreaAllocator::expand): (WebCore::fitsWithin): (WebCore::GeneralAreaAllocator::allocate): (WebCore::GeneralAreaAllocator::allocateFromNode): (WebCore::GeneralAreaAllocator::splitNode): (WebCore::GeneralAreaAllocator::updateLargestFree): (WebCore::GeneralAreaAllocator::release): (WebCore::GeneralAreaAllocator::overhead const): * platform/graphics/texmap/coordinated/AreaAllocator.h: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h. (WebCore::nextPowerOfTwo): (WebCore::AreaAllocator::size const): (WebCore::AreaAllocator::minimumAllocation const): (WebCore::AreaAllocator::setMinimumAllocation): (WebCore::AreaAllocator::margin const): (WebCore::AreaAllocator::setMargin): * platform/graphics/texmap/coordinated/UpdateAtlas.cpp: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp. (WebCore::UpdateAtlas::UpdateAtlas): (WebCore::UpdateAtlas::~UpdateAtlas): (WebCore::UpdateAtlas::buildLayoutIfNeeded): (WebCore::UpdateAtlas::didSwapBuffers): (WebCore::UpdateAtlas::getCoordinatedBuffer): * platform/graphics/texmap/coordinated/UpdateAtlas.h: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h. (WebCore::UpdateAtlas::size const): (WebCore::UpdateAtlas::supportsAlpha const): (WebCore::UpdateAtlas::addTimeInactive): (WebCore::UpdateAtlas::isInactive const): (WebCore::UpdateAtlas::isInUse const): Source/WebKit: Move the UpdateAtlas and AreaAllocator classes into the platform layer, moving over build targets and adjust UpdateAtlas class references in CompositingCoordinator. * PlatformGTK.cmake: * PlatformWPE.cmake: * PlatformWin.cmake: * WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/TextureMapper.cmake trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformGTK.cmake trunk/Source/WebKit/PlatformWPE.cmake trunk/Source/WebKit/PlatformWin.cmake trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h Added Paths trunk/Source/WebCore/platform/graphics/texmap/coordinated/AreaAllocator.cpp trunk/Source/WebCore/platform/graphics/texmap/coordinated/AreaAllocator.h trunk/Source/WebCore/platform/graphics/texmap/coordinated/UpdateAtlas.cpp trunk/Source/WebCore/platform/graphics/texmap/coordinated/UpdateAtlas.h Removed Paths trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h Diff Modified: trunk/Source/WebCore/ChangeLog (225772 => 225773) --- trunk/Source/WebCore/ChangeLog 2017-12-12 06:30:34 UTC (rev 225772) +++ trunk/Source/WebCore/ChangeLog 2017-12-12 07:04:44 UTC (rev 225773) @@ -1,3 +1,57 @@ +2017-12-11 Zan Dobersek + +[CoordGraphics] Move UpdateAtlas, AreaAllocator into the platform layer +https://bugs.webkit.org/show_bug.cgi?id=180641 + +Reviewed by Michael Catanzaro. + +Move the UpdateAtlas and AreaAllocator classes and their source files +into the platform layer. This still means using the WebCore namespace, +but apart from that these two classes have no dependency on anything in +the WebKit layer, so they can be moved from there. + +No new tests -- no change in functionality. + +* platform/TextureMapper.cmake: +* platform/graphics/texmap/coordinated/AreaAllocator.cpp: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp. +(WebCore::AreaAllocator::AreaAllocator): +(WebCore::AreaAllocator::~AreaAllocator
[webkit-changes] [225772] trunk/Source/WebCore
Title: [225772] trunk/Source/WebCore
Revision 225772
Author rn...@webkit.org
Date 2017-12-11 22:30:34 -0800 (Mon, 11 Dec 2017)
Log Message
Disable NoEventDispatchAssertion release assertion in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=180616
Reviewed by Zalan Bujtas.
Disabled the release assertion for NoEventDispatchAssertion in WebKit1 since there are many
delegate callbacks that happen at unsafe timing, and we don't have any hope of fixing them
in short term.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canExecuteScripts):
* dom/Document.cpp:
(WebCore::isSafeToUpdateStyleOrLayout):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeClassicScript):
* platform/RuntimeApplicationChecks.h:
(WebCore::isInWebProcess):
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::isInWebProcess): Extracted from IOSApplication::isWebProcess.
(WebCore::IOSApplication::isWebProcess):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/ScriptElement.cpp
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (225771 => 225772)
--- trunk/Source/WebCore/ChangeLog 2017-12-12 05:47:18 UTC (rev 225771)
+++ trunk/Source/WebCore/ChangeLog 2017-12-12 06:30:34 UTC (rev 225772)
@@ -1,3 +1,26 @@
+2017-12-11 Ryosuke Niwa
+
+Disable NoEventDispatchAssertion release assertion in WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=180616
+
+Reviewed by Zalan Bujtas.
+
+Disabled the release assertion for NoEventDispatchAssertion in WebKit1 since there are many
+delegate callbacks that happen at unsafe timing, and we don't have any hope of fixing them
+in short term.
+
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::canExecuteScripts):
+* dom/Document.cpp:
+(WebCore::isSafeToUpdateStyleOrLayout):
+* dom/ScriptElement.cpp:
+(WebCore::ScriptElement::executeClassicScript):
+* platform/RuntimeApplicationChecks.h:
+(WebCore::isInWebProcess):
+* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+(WebCore::isInWebProcess): Extracted from IOSApplication::isWebProcess.
+(WebCore::IOSApplication::isWebProcess):
+
2017-12-11 Darin Adler
Improve FontSelectionAlgorithm, including moving from IntegerHasher to Hasher
Modified: trunk/Source/WebCore/bindings/js/ScriptController.cpp (225771 => 225772)
--- trunk/Source/WebCore/bindings/js/ScriptController.cpp 2017-12-12 05:47:18 UTC (rev 225771)
+++ trunk/Source/WebCore/bindings/js/ScriptController.cpp 2017-12-12 06:30:34 UTC (rev 225772)
@@ -48,6 +48,7 @@
#include "PageConsoleClient.h"
#include "PageGroup.h"
#include "PluginViewBase.h"
+#include "RuntimeApplicationChecks.h"
#include "ScriptSourceCode.h"
#include "ScriptableDocumentParser.h"
#include "Settings.h"
@@ -668,7 +669,7 @@
bool ScriptController::canExecuteScripts(ReasonForCallingCanExecuteScripts reason)
{
if (reason == AboutToExecuteScript)
-RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::InMainThread::isEventAllowed());
+RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::InMainThread::isEventAllowed() || !isInWebProcess());
if (m_frame.document() && m_frame.document()->isSandboxed(SandboxScripts)) {
// FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
Modified: trunk/Source/WebCore/dom/Document.cpp (225771 => 225772)
--- trunk/Source/WebCore/dom/Document.cpp 2017-12-12 05:47:18 UTC (rev 225771)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-12-12 06:30:34 UTC (rev 225772)
@@ -152,6 +152,7 @@
#include "RenderWidget.h"
#include "RequestAnimationFrameCallback.h"
#include "ResourceLoadObserver.h"
+#include "RuntimeApplicationChecks.h"
#include "RuntimeEnabledFeatures.h"
#include "SVGDocumentExtensions.h"
#include "SVGElement.h"
@@ -1924,15 +1925,9 @@
inline bool static isSafeToUpdateStyleOrLayout(FrameView* frameView)
{
-#if USE(WEB_THREAD)
-// FIXME: Remove this code:
-bool usingWebThread = WebThreadIsEnabled();
-#else
-bool usingWebThread = false;
-#endif
bool isSafeToExecuteScript = NoEventDispatchAssertion::InMainThread::isEventAllowed();
bool isInFrameFlattening = frameView && frameView->isInChildFrameWithFrameFlattening();
-return isSafeToExecuteScript || isInFrameFlattening || usingWebThread;
+return isSafeToExecuteScript || isInFrameFlattening || !isInWebProcess();
}
bool Document::updateStyleIfNeeded()
Modified: trunk/Source/WebCore/dom/ScriptElement.cpp (225771 => 225772)
--- trunk/Source/WebCore/dom/ScriptElement.cpp 2017-12-12 05:47:18 UTC (rev 225771)
+++ trunk/Source/WebCore/dom/Script
[webkit-changes] [225771] trunk/Source/JavaScriptCore
Title: [225771] trunk/Source/_javascript_Core
Revision 225771
Author msab...@apple.com
Date 2017-12-11 21:47:18 -0800 (Mon, 11 Dec 2017)
Log Message
REGRESSION(r225683): Chakra test failure in es6/regex-unicode.js for 32bit builds
https://bugs.webkit.org/show_bug.cgi?id=180685
Reviewed by Saam Barati.
The characterClass->m_anyCharacter check at the top of checkCharacterClass() caused
the character class check to return true without reading the character. Given that
the character could be a surrogate pair, we need to read the character even if we
don't have the check it.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::testCharacterClass):
(JSC::Yarr::Interpreter::checkCharacterClass):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225770 => 225771)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-12 04:54:24 UTC (rev 225770)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-12 05:47:18 UTC (rev 225771)
@@ -1,3 +1,19 @@
+2017-12-11 Michael Saboff
+
+REGRESSION(r225683): Chakra test failure in es6/regex-unicode.js for 32bit builds
+https://bugs.webkit.org/show_bug.cgi?id=180685
+
+Reviewed by Saam Barati.
+
+The characterClass->m_anyCharacter check at the top of checkCharacterClass() caused
+the character class check to return true without reading the character. Given that
+the character could be a surrogate pair, we need to read the character even if we
+don't have the check it.
+
+* yarr/YarrInterpreter.cpp:
+(JSC::Yarr::Interpreter::testCharacterClass):
+(JSC::Yarr::Interpreter::checkCharacterClass):
+
2017-12-11 Saam Barati
We need to disableCaching() in ErrorInstance when we materialize properties
Modified: trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp (225770 => 225771)
--- trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp 2017-12-12 04:54:24 UTC (rev 225770)
+++ trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp 2017-12-12 05:47:18 UTC (rev 225771)
@@ -352,6 +352,9 @@
return false;
};
+if (characterClass->m_anyCharacter)
+return true;
+
const size_t thresholdForBinarySearch = 6;
if (!isASCII(ch)) {
@@ -409,9 +412,6 @@
bool checkCharacterClass(CharacterClass* characterClass, bool invert, unsigned negativeInputOffset)
{
-if (characterClass->m_anyCharacter)
-return !invert;
-
bool match = testCharacterClass(characterClass, input.readChecked(negativeInputOffset));
return invert ? !match : match;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225770] trunk/Tools
Title: [225770] trunk/Tools Revision 225770 Author commit-qu...@webkit.org Date 2017-12-11 20:54:24 -0800 (Mon, 11 Dec 2017) Log Message [WinCairo] Enable running sharded tests https://bugs.webkit.org/show_bug.cgi?id=180660 Patch by Basuke Suzuki on 2017-12-11 Reviewed by Alex Christensen. The sharder splits the test inputs into groups of test based on the directory, but separation of base name and directory name was wrong because of this bug. Once sharded correctly, the execution of layout test on native Windows environment is in parallel and much less time to run. * Scripts/webkitpy/port/win.py: (WinCairoPort): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/win.py Diff Modified: trunk/Tools/ChangeLog (225769 => 225770) --- trunk/Tools/ChangeLog 2017-12-12 03:50:06 UTC (rev 225769) +++ trunk/Tools/ChangeLog 2017-12-12 04:54:24 UTC (rev 225770) @@ -1,3 +1,18 @@ +2017-12-11 Basuke Suzuki + +[WinCairo] Enable running sharded tests +https://bugs.webkit.org/show_bug.cgi?id=180660 + +Reviewed by Alex Christensen. + +The sharder splits the test inputs into groups of test based on the directory, +but separation of base name and directory name was wrong because of this bug. +Once sharded correctly, the execution of layout test on native Windows environment +is in parallel and much less time to run. + +* Scripts/webkitpy/port/win.py: +(WinCairoPort): + 2017-12-11 Fujii Hironori [WinCairo] DLLLauncherMain should use SetDllDirectory Modified: trunk/Tools/Scripts/webkitpy/port/win.py (225769 => 225770) --- trunk/Tools/Scripts/webkitpy/port/win.py 2017-12-12 03:50:06 UTC (rev 225769) +++ trunk/Tools/Scripts/webkitpy/port/win.py 2017-12-12 04:54:24 UTC (rev 225770) @@ -436,6 +436,8 @@ class WinCairoPort(WinPort): port_name = "wincairo" +TEST_PATH_SEPARATOR = os.sep + VERSION_FALLBACK_ORDER = ["wincairo-" + os_name.lower() for os_name in VersionNameMap.map().names()] def default_baseline_search_path(self): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225769] trunk/Source/WebCore
Title: [225769] trunk/Source/WebCore Revision 225769 Author da...@apple.com Date 2017-12-11 19:50:06 -0800 (Mon, 11 Dec 2017) Log Message Improve FontSelectionAlgorithm, including moving from IntegerHasher to Hasher https://bugs.webkit.org/show_bug.cgi?id=180340 Reviewed by Dan Bates. * css/CSSFontFaceSet.h: Moved FontSelectionRequestKey and FontSelectionRequestKeyHash here to be private members, and used a std::optional instead of a class for this. Also use the new Hasher to compute the hash. Also added FontSelectionRequestKeyHashTraits. * platform/graphics/FontDescription.cpp: (WebCore::FontDescription::FontDescription): Updated since FontSelectionRequest does not always have a constructor any more. * platform/graphics/FontSelectionAlgorithm.h: Tweaked comments. Used "using" instead of typedef. Formatted some trivial functions as single lines. Stopped using NeverDestroyed for simple classes like FontSelectionValue; it's not needed unless there is a destructor. Got rid of some incorrect use of const. Replaced some member functions with non-member functions. Moved some function bodies out of class definitions. Used a lot of constexpr functions. (WebCore::FontSelectionRequest::tied const): Added so we can easily write both == and the hash function without listing the data members. (WebCore::add): Added an overload so we can hash things that include FontSelectionRequest. (WebCore::FontSelectionRequestKey::FontSelectionRequestKey): Changed this class to use std::optional instead of a separate boolean for deleted values. (WebCore::FontSelectionRequestKey::isHashTableDeletedValue const): Ditto. (WebCore::FontSelectionRequestKey::operator== const): Ditto. (WebCore::FontSelectionRequestKeyHash::hash): Ditto. (WebCore::FontSelectionRequestKeyHash::equal): Ditto. (WebCore::FontSelectionCapabilities::tied const): Added so we can easily write both == and the hash function without listing the data members. (WebCore::FontSelectionSpecifiedCapabilities::tied const): Ditto. (WebCore::FontSelectionAlgorithm::FontSelectionAlgorithm): Use make_unique instead of new. * platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::findClosestFont): Move in the vector instead of copying it when creating a FontSelectionAlgorithm object. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSFontFaceSet.h trunk/Source/WebCore/platform/graphics/FontDescription.cpp trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.cpp trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h Diff Modified: trunk/Source/WebCore/ChangeLog (225768 => 225769) --- trunk/Source/WebCore/ChangeLog 2017-12-12 03:24:43 UTC (rev 225768) +++ trunk/Source/WebCore/ChangeLog 2017-12-12 03:50:06 UTC (rev 225769) @@ -1,3 +1,42 @@ +2017-12-11 Darin Adler + +Improve FontSelectionAlgorithm, including moving from IntegerHasher to Hasher +https://bugs.webkit.org/show_bug.cgi?id=180340 + +Reviewed by Dan Bates. + +* css/CSSFontFaceSet.h: Moved FontSelectionRequestKey and FontSelectionRequestKeyHash +here to be private members, and used a std::optional instead of a class for this. +Also use the new Hasher to compute the hash. Also added FontSelectionRequestKeyHashTraits. + +* platform/graphics/FontDescription.cpp: +(WebCore::FontDescription::FontDescription): Updated since FontSelectionRequest +does not always have a constructor any more. + +* platform/graphics/FontSelectionAlgorithm.h: Tweaked comments. Used "using" instead +of typedef. Formatted some trivial functions as single lines. Stopped using +NeverDestroyed for simple classes like FontSelectionValue; it's not needed unless +there is a destructor. Got rid of some incorrect use of const. Replaced some member +functions with non-member functions. Moved some function bodies out of class definitions. +Used a lot of constexpr functions. +(WebCore::FontSelectionRequest::tied const): Added so we can easily write both == and the +hash function without listing the data members. +(WebCore::add): Added an overload so we can hash things that include FontSelectionRequest. +(WebCore::FontSelectionRequestKey::FontSelectionRequestKey): Changed this class to +use std::optional instead of a separate boolean for deleted values. +(WebCore::FontSelectionRequestKey::isHashTableDeletedValue const): Ditto. +(WebCore::FontSelectionRequestKey::operator== const): Ditto. +(WebCore::FontSelectionRequestKeyHash::hash): Ditto. +(WebCore::FontSelectionRequestKeyHash::equal): Ditto. +(WebCore::FontSelectionCapabilities::tied const): Added so we can easily write both == +and the hash function without listing the data members. +(WebCore::FontSelectionSpecifiedCapabilities::tied const): Ditto. +(WebCore::FontSelectionAlgorithm::FontSelectionAlgorithm): Use make_unique ins
[webkit-changes] [225768] trunk
Title: [225768] trunk
Revision 225768
Author sbar...@apple.com
Date 2017-12-11 19:24:43 -0800 (Mon, 11 Dec 2017)
Log Message
We need to disableCaching() in ErrorInstance when we materialize properties
https://bugs.webkit.org/show_bug.cgi?id=180343
Reviewed by Mark Lam.
JSTests:
* stress/disable-caching-when-lazy-materializing-error-property-on-put.js: Added.
(assert):
(makeError):
(storeToStack):
(storeToStackAlreadyMaterialized):
Source/_javascript_Core:
This patch fixes a bug in ErrorInstance where we forgot to call PutPropertySlot::disableCaching
on puts() to a property that we lazily materialized. Forgetting to do this goes against the
PutPropertySlot's caching API. This lazy materialization caused the ErrorInstance to transition
from a Structure A to a Structure B. However, we were telling the IC that we were caching an
existing property only found on Structure B. This is obviously wrong as it would lead to an
OOB store if we didn't already crash when generating the IC.
* jit/Repatch.cpp:
(JSC::tryCachePutByID):
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::materializeErrorInfoIfNeeded):
(JSC::ErrorInstance::put):
* runtime/ErrorInstance.h:
* runtime/Structure.cpp:
(JSC::Structure::didCachePropertyReplacement):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp
trunk/Source/_javascript_Core/runtime/ErrorInstance.h
trunk/Source/_javascript_Core/runtime/Structure.cpp
Added Paths
trunk/JSTests/stress/disable-caching-when-lazy-materializing-error-property-on-put.js
Diff
Modified: trunk/JSTests/ChangeLog (225767 => 225768)
--- trunk/JSTests/ChangeLog 2017-12-12 02:45:13 UTC (rev 225767)
+++ trunk/JSTests/ChangeLog 2017-12-12 03:24:43 UTC (rev 225768)
@@ -1,3 +1,17 @@
+2017-12-11 Saam Barati
+
+We need to disableCaching() in ErrorInstance when we materialize properties
+https://bugs.webkit.org/show_bug.cgi?id=180343
+
+
+Reviewed by Mark Lam.
+
+* stress/disable-caching-when-lazy-materializing-error-property-on-put.js: Added.
+(assert):
+(makeError):
+(storeToStack):
+(storeToStackAlreadyMaterialized):
+
2017-12-05 JF Bastien
WebAssembly: don't eagerly checksum
Added: trunk/JSTests/stress/disable-caching-when-lazy-materializing-error-property-on-put.js (0 => 225768)
--- trunk/JSTests/stress/disable-caching-when-lazy-materializing-error-property-on-put.js (rev 0)
+++ trunk/JSTests/stress/disable-caching-when-lazy-materializing-error-property-on-put.js 2017-12-12 03:24:43 UTC (rev 225768)
@@ -0,0 +1,27 @@
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+function makeError() { return new Error; }
+noInline(makeError);
+
+function storeToStack(e) {
+e.stack = "foo";
+}
+noInline(storeToStack);
+
+function storeToStackAlreadyMaterialized(e) {
+e.stack = "bar";
+}
+noInline(storeToStackAlreadyMaterialized);
+
+for (let i = 0; i < 1; ++i) {
+let e = makeError();
+storeToStack(e);
+assert(e.stack === "foo");
+if (!!(i % 2))
+e.fooBar = 25;
+storeToStackAlreadyMaterialized(e);
+assert(e.stack === "bar");
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (225767 => 225768)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-12 02:45:13 UTC (rev 225767)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-12 03:24:43 UTC (rev 225768)
@@ -1,3 +1,27 @@
+2017-12-11 Saam Barati
+
+We need to disableCaching() in ErrorInstance when we materialize properties
+https://bugs.webkit.org/show_bug.cgi?id=180343
+
+
+Reviewed by Mark Lam.
+
+This patch fixes a bug in ErrorInstance where we forgot to call PutPropertySlot::disableCaching
+on puts() to a property that we lazily materialized. Forgetting to do this goes against the
+PutPropertySlot's caching API. This lazy materialization caused the ErrorInstance to transition
+from a Structure A to a Structure B. However, we were telling the IC that we were caching an
+existing property only found on Structure B. This is obviously wrong as it would lead to an
+OOB store if we didn't already crash when generating the IC.
+
+* jit/Repatch.cpp:
+(JSC::tryCachePutByID):
+* runtime/ErrorInstance.cpp:
+(JSC::ErrorInstance::materializeErrorInfoIfNeeded):
+(JSC::ErrorInstance::put):
+* runtime/ErrorInstance.h:
+* runtime/Structure.cpp:
+(JSC::Structure::didCachePropertyReplacement):
+
2017-12-11 Fujii Hironori
[WinCairo] DLLLauncherMain should use SetDllDirectory
Modified: trunk/Source/_javascript_Core/jit/Repatch.cpp (225767 => 225768)
--- trunk/Source/_javascript_Core/jit/Repatch.cpp 2017-12-12 02:45:13 UTC (rev 225767)
+++ trunk/Source/_javascript_Core/jit/Repatch.cpp 2017-12-12 03:24:43 U
[webkit-changes] [225767] trunk
Title: [225767] trunk
Revision 225767
Author commit-qu...@webkit.org
Date 2017-12-11 18:45:13 -0800 (Mon, 11 Dec 2017)
Log Message
[WinCairo] DLLLauncherMain should use SetDllDirectory
https://bugs.webkit.org/show_bug.cgi?id=180642
Patch by Fujii Hironori on 2017-12-11
Reviewed by Alex Christensen.
Windows have icuuc.dll in the system directory. WebKit should find
one in WebKitLibraries directory, not one in the system directory.
Source/_javascript_Core:
* shell/DLLLauncherMain.cpp:
(modifyPath): Use SetDllDirectory for WebKitLibraries directory instead of modifying path.
Tools:
* win/DLLLauncher/DLLLauncherMain.cpp:
(modifyPath): Use SetDllDirectory for WebKitLibraries directory instead of modifying path.
Do not add a path for GStreamer because nobody is using now.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp
trunk/Tools/ChangeLog
trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225766 => 225767)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-12 01:17:21 UTC (rev 225766)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-12 02:45:13 UTC (rev 225767)
@@ -1,3 +1,16 @@
+2017-12-11 Fujii Hironori
+
+[WinCairo] DLLLauncherMain should use SetDllDirectory
+https://bugs.webkit.org/show_bug.cgi?id=180642
+
+Reviewed by Alex Christensen.
+
+Windows have icuuc.dll in the system directory. WebKit should find
+one in WebKitLibraries directory, not one in the system directory.
+
+* shell/DLLLauncherMain.cpp:
+(modifyPath): Use SetDllDirectory for WebKitLibraries directory instead of modifying path.
+
2017-12-11 Eric Carlson
Web Inspector: Optionally log WebKit log parameters as JSON
Modified: trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp (225766 => 225767)
--- trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp 2017-12-12 01:17:21 UTC (rev 225766)
+++ trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp 2017-12-12 02:45:13 UTC (rev 225767)
@@ -124,12 +124,18 @@
{
#ifdef WIN_CAIRO
+wstring pathWinCairo = copyEnvironmentVariable(L"WEBKIT_LIBRARIES");
+if (!directoryExists(pathWinCairo))
+return true;
#if defined(_M_X64)
-wstring pathWinCairo = copyEnvironmentVariable(L"WEBKIT_LIBRARIES") + L"\\bin64";
+pathWinCairo += L"\\bin64";
#else
-wstring pathWinCairo = copyEnvironmentVariable(L"WEBKIT_LIBRARIES") + L"\\bin32";
+pathWinCairo += L"\\bin32";
#endif
-prependPath(pathWinCairo);
+if (!SetDllDirectory(pathWinCairo.c_str())) {
+fatalError(programName, L"Failed to SetDllDirectory");
+return false;
+}
return true;
#else
Modified: trunk/Tools/ChangeLog (225766 => 225767)
--- trunk/Tools/ChangeLog 2017-12-12 01:17:21 UTC (rev 225766)
+++ trunk/Tools/ChangeLog 2017-12-12 02:45:13 UTC (rev 225767)
@@ -1,3 +1,17 @@
+2017-12-11 Fujii Hironori
+
+[WinCairo] DLLLauncherMain should use SetDllDirectory
+https://bugs.webkit.org/show_bug.cgi?id=180642
+
+Reviewed by Alex Christensen.
+
+Windows have icuuc.dll in the system directory. WebKit should find
+one in WebKitLibraries directory, not one in the system directory.
+
+* win/DLLLauncher/DLLLauncherMain.cpp:
+(modifyPath): Use SetDllDirectory for WebKitLibraries directory instead of modifying path.
+Do not add a path for GStreamer because nobody is using now.
+
2017-12-11 David Quesada
Turn on ENABLE_APPLICATION_MANIFEST
Modified: trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp (225766 => 225767)
--- trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp 2017-12-12 01:17:21 UTC (rev 225766)
+++ trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp 2017-12-12 02:45:13 UTC (rev 225767)
@@ -121,16 +121,18 @@
{
#ifdef WIN_CAIRO
+wstring pathWinCairo = copyEnvironmentVariable(L"WEBKIT_LIBRARIES");
+if (!directoryExists(pathWinCairo))
+return true;
#if defined(_M_X64)
-wstring pathGStreamer = copyEnvironmentVariable(L"GSTREAMER_1_0_ROOT_X86_64") + L"bin";
-wstring pathWinCairo = copyEnvironmentVariable(L"WEBKIT_LIBRARIES") + L"\\bin64";
+pathWinCairo += L"\\bin64";
#else
-wstring pathGStreamer = copyEnvironmentVariable(L"GSTREAMER_1_0_ROOT_X86") + L"bin";
-wstring pathWinCairo = copyEnvironmentVariable(L"WEBKIT_LIBRARIES") + L"\\bin32";
+pathWinCairo += L"\\bin32";
#endif
-prependPath(pathWinCairo);
-if (directoryExists(pathGStreamer))
-prependPath(pathGStreamer);
+if (!SetDllDirectory(pathWinCairo.c_str())) {
+fatalError(programName, L"Failed to SetDllDirectory");
+return false;
+}
return true;
#else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225766] trunk/Source/WebCore
Title: [225766] trunk/Source/WebCore Revision 225766 Author jer.no...@apple.com Date 2017-12-11 17:17:21 -0800 (Mon, 11 Dec 2017) Log Message [EME] support update() for FairPlayStreaming in Modern EME API https://bugs.webkit.org/show_bug.cgi?id=180542 Reviewed by Eric Carlson. Support the updateLicense() method in CDMInstanceFairPlayStreaming. Also, support adding a AVStreamDataParser to the AVContentKeySession. Drive-by fixes: - Sometimes, AVFoundation will give us a base64 encoded string with spaces url-disallowed characters, so use base64Decode() rather than base64URLDecode(). * platform/graphics/avfoundation/CDMFairPlayStreaming.cpp: (WebCore::validFairPlayStreamingSchemes): (WebCore::extractSinfData): * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::didFailToProvideRequest): * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstance const): * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceAttached): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceDetached): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::attemptToDecryptWithInstance): * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::destroyParser): (WebCore::SourceBufferPrivateAVFObjC::setCDMInstance): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm Diff Modified: trunk/Source/WebCore/ChangeLog (225765 => 225766) --- trunk/Source/WebCore/ChangeLog 2017-12-12 00:53:30 UTC (rev 225765) +++ trunk/Source/WebCore/ChangeLog 2017-12-12 01:17:21 UTC (rev 225766) @@ -1,3 +1,37 @@ +2017-12-11 Jer Noble + +[EME] support update() for FairPlayStreaming in Modern EME API +https://bugs.webkit.org/show_bug.cgi?id=180542 + +Reviewed by Eric Carlson. + +Support the updateLicense() method in CDMInstanceFairPlayStreaming. Also, support adding a +AVStreamDataParser to the AVContentKeySession. + +Drive-by fixes: + +- Sometimes, AVFoundation will give us a base64 encoded string with spaces url-disallowed +characters, so use base64Decode() rather than base64URLDecode(). + +* platform/graphics/avfoundation/CDMFairPlayStreaming.cpp: +(WebCore::validFairPlayStreamingSchemes): +(WebCore::extractSinfData): +* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: +* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didFailToProvideRequest): +* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: +(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstance const): +* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: +(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceAttached): +(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceDetached): +(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::attemptToDecryptWithInstance): +* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: +* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: +(WebCore::SourceBufferPrivateAVFObjC::destroyParser): +(WebCore::SourceBufferPrivateAVFObjC::setCDMInstance): + 2017-12-11 Eric Carlson Web Inspector: Optionally log WebKit log parameters as JSON Modified: trunk/Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp (225765 => 225766) --- trunk/Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp 2017-12-12 00:53:30 UTC (rev 225765) +++ trunk/Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp 2017
[webkit-changes] [225765] trunk/Source/WebKit
Title: [225765] trunk/Source/WebKit
Revision 225765
Author achristen...@apple.com
Date 2017-12-11 16:53:30 -0800 (Mon, 11 Dec 2017)
Log Message
Add a WKPageGroupRef setter in WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=180674
Reviewed by Brady Eidson.
There is a Mac app trying to transition to WKWebView, and it uses WKPageGroupRef extensively.
To help it transition, we are temporarily giving it an ObjC way to use this organization for
its UserContentControllers to be united per PageGroup before it transitions away from SPIs like
WKBundleAddUserScript. Make it Mac-only to indicate that this should be transitioned away from,
rather than adopted on iOS.
No change in behavior for apps not using the new WKWebViewConfiguration._pageGroup SPI.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _pageGroup]):
(-[WKWebViewConfiguration _setPageGroup:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (225764 => 225765)
--- trunk/Source/WebKit/ChangeLog 2017-12-12 00:41:54 UTC (rev 225764)
+++ trunk/Source/WebKit/ChangeLog 2017-12-12 00:53:30 UTC (rev 225765)
@@ -1,3 +1,27 @@
+2017-12-11 Alex Christensen
+
+Add a WKPageGroupRef setter in WKWebViewConfiguration
+https://bugs.webkit.org/show_bug.cgi?id=180674
+
+
+Reviewed by Brady Eidson.
+
+There is a Mac app trying to transition to WKWebView, and it uses WKPageGroupRef extensively.
+To help it transition, we are temporarily giving it an ObjC way to use this organization for
+its UserContentControllers to be united per PageGroup before it transitions away from SPIs like
+WKBundleAddUserScript. Make it Mac-only to indicate that this should be transitioned away from,
+rather than adopted on iOS.
+
+No change in behavior for apps not using the new WKWebViewConfiguration._pageGroup SPI.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _initializeWithConfiguration:]):
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration copyWithZone:]):
+(-[WKWebViewConfiguration _pageGroup]):
+(-[WKWebViewConfiguration _setPageGroup:]):
+* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
+
2017-12-11 Brent Fulgham
[iOS] Remove unused services from WebContent Process sandbox
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (225764 => 225765)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2017-12-12 00:41:54 UTC (rev 225764)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2017-12-12 00:53:30 UTC (rev 225765)
@@ -517,11 +517,16 @@
if (NSString *overrideContentSecurityPolicy = configuration._overrideContentSecurityPolicy)
pageConfiguration->setOverrideContentSecurityPolicy(overrideContentSecurityPolicy);
-RefPtr pageGroup;
-NSString *groupIdentifier = configuration._groupIdentifier;
-if (groupIdentifier.length) {
-pageGroup = WebKit::WebPageGroup::create(configuration._groupIdentifier);
-pageConfiguration->setPageGroup(pageGroup.get());
+#if PLATFORM(MAC)
+if (auto pageGroup = WebKit::toImpl([configuration _pageGroup])) {
+pageConfiguration->setPageGroup(pageGroup);
+pageConfiguration->setUserContentController(&pageGroup->userContentController());
+} else
+#endif
+{
+NSString *groupIdentifier = configuration._groupIdentifier;
+if (groupIdentifier.length)
+pageConfiguration->setPageGroup(WebKit::WebPageGroup::create(configuration._groupIdentifier).ptr());
}
pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::suppressesIncrementalRenderingKey(), WebKit::WebPreferencesStore::Value(!![_configuration suppressesIncrementalRendering]));
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (225764 => 225765)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2017-12-12 00:41:54 UTC (rev 225764)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2017-12-12 00:53:30 UTC (rev 225765)
@@ -32,6 +32,7 @@
#import "VersionChecks.h"
#import "WKPreferences.h"
#import "WKProcessPool.h"
+#import "WKRetainPtr.h"
#import "WKUserContentController.h"
#import "WKWebView.h"
#import "WKWebViewContentProviderRegistry.h"
@@ -136,6 +137,7 @@
BOOL _mainContentUserGestureOverrideEnabled;
#if PLATFORM(MAC)
+WKRetainPtr _pageGroup;
double _cpuLimit;
BOOL _showsURLsInToolTips;
BOOL _serviceControlsE
[webkit-changes] [225764] trunk
Title: [225764] trunk Revision 225764 Author eric.carl...@apple.com Date 2017-12-11 16:41:54 -0800 (Mon, 11 Dec 2017) Log Message Web Inspector: Optionally log WebKit log parameters as JSON https://bugs.webkit.org/show_bug.cgi?id=180529 Reviewed by Joseph Pecoraro. Source/_javascript_Core: * inspector/ConsoleMessage.cpp: (Inspector::ConsoleMessage::ConsoleMessage): New constructor that takes a vector of JSON log values. Concatenate all adjacent strings to make logging cleaner. (Inspector::ConsoleMessage::addToFrontend): Process WebKit logging arguments. (Inspector::ConsoleMessage::scriptState const): * inspector/ConsoleMessage.h: * inspector/InjectedScript.cpp: (Inspector::InjectedScript::wrapJSONString const): Wrap JSON string log arguments. * inspector/InjectedScript.h: * inspector/InjectedScriptSource.js: (let.InjectedScript.prototype.wrapJSONString): Source/WebCore: * dom/Document.cpp: (WebCore::Document::didLogMessage):Update for API change. Don't check for main thread, that is already done in addConsoleMessage. * dom/Document.h: * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState): Cleanup logging. * html/track/DataCue.cpp: (WebCore::DataCue::toJSONString const): Serialize to JSON string. (WebCore::DataCue::toString const): Deleted. * html/track/DataCue.h: (WTF::LogArgument::toString): * html/track/TextTrackCue.cpp: (WebCore::TextTrackCue::toJSON const): Ditto. (WebCore::TextTrackCue::toJSONString const): (WebCore::TextTrackCue::toString const): Deleted. * html/track/TextTrackCue.h: (WTF::LogArgument::toString): * html/track/TextTrackCueGeneric.cpp: (WebCore::TextTrackCueGeneric::toJSONString const): Ditto. (WebCore::TextTrackCueGeneric::toString const): Deleted. * html/track/TextTrackCueGeneric.h: (WTF::LogArgument::toString): * html/track/VTTCue.cpp: (WebCore::VTTCue::toJSONString const): Ditto. (WebCore::VTTCue::toString const): Deleted. * html/track/VTTCue.h: (WTF::LogArgument::toString): * platform/graphics/InbandTextTrackPrivateClient.h: (WebCore::GenericCueData::toJSONString const): Ditto. (WTF::LogArgument::toString): (WebCore::GenericCueData::toString const): Deleted. * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: (WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Cleanup logging. (WebCore::InbandTextTrackPrivateAVF::removeCompletedCues): Ditto. (WebCore::InbandTextTrackPrivateAVF::processNativeSamples): Log the entire cue. (WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer): Cleanup logging. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::maxMediaTimeSeekable const): Don't log, it isn't interesting and happens frequently. (WebCore::MediaPlayerPrivateAVFoundation::minMediaTimeSeekable const): Ditto. * platform/graphics/iso/ISOVTTCue.cpp: (WebCore::ISOWebVTTCue::toJSONString const): Serialize to JSON string. * platform/graphics/iso/ISOVTTCue.h: (WTF::LogArgument::toString): Ditto. Source/WTF: * wtf/Logger.h: (WTF::Logger::log): (WTF::LogArgument::toString): * wtf/MediaTime.cpp: (WTF::MediaTime::toJSONString const): Serialize to JSON string. * wtf/MediaTime.h: LayoutTests: * inspector/canvas/recording-2d-expected.txt: * inspector/canvas/recording-webgl-expected.txt: * inspector/canvas/recording-webgl-snapshots-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/canvas/recording-2d-expected.txt trunk/LayoutTests/inspector/canvas/recording-webgl-expected.txt trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots-expected.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/ConsoleMessage.cpp trunk/Source/_javascript_Core/inspector/ConsoleMessage.h trunk/Source/_javascript_Core/inspector/InjectedScript.cpp trunk/Source/_javascript_Core/inspector/InjectedScript.h trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Logger.h trunk/Source/WTF/wtf/MediaTime.cpp trunk/Source/WTF/wtf/MediaTime.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/track/DataCue.cpp trunk/Source/WebCore/html/track/DataCue.h trunk/Source/WebCore/html/track/TextTrackCue.cpp trunk/Source/WebCore/html/track/TextTrackCue.h trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp trunk/Source/WebCore/html/track/TextTrackCueGeneric.h trunk/Source/WebCore/html/track/VTTCue.cpp trunk/Source/WebCore/html/track/VTTCue.h trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp trunk/Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp trunk/Source/WebCore/platform/graphics/iso/ISOVTTCue.h Diff Modified: trunk/LayoutTests/ChangeLog (225763 => 225764
[webkit-changes] [225763] trunk/Source/WebKit
Title: [225763] trunk/Source/WebKit Revision 225763 Author bfulg...@apple.com Date 2017-12-11 16:39:37 -0800 (Mon, 11 Dec 2017) Log Message [iOS] Remove unused services from WebContent Process sandbox https://bugs.webkit.org/show_bug.cgi?id=180670 Reviewed by Eric Carlson. Pare down the set of sandbox exceptions in the iOS WebContent process sandbox to just those services actually in use: 1. Remove unused code. 2. Instead of defining a 'UIKit-app' function and calling it, just declare the individual sandbox commands inline. This will allow them to be more easily consolidated with other parts of the sandbox in a future step. This update should not change behavior. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Diff Modified: trunk/Source/WebKit/ChangeLog (225762 => 225763) --- trunk/Source/WebKit/ChangeLog 2017-12-12 00:28:59 UTC (rev 225762) +++ trunk/Source/WebKit/ChangeLog 2017-12-12 00:39:37 UTC (rev 225763) @@ -1,3 +1,21 @@ +2017-12-11 Brent Fulgham + +[iOS] Remove unused services from WebContent Process sandbox +https://bugs.webkit.org/show_bug.cgi?id=180670 + +Reviewed by Eric Carlson. + +Pare down the set of sandbox exceptions in the iOS WebContent process sandbox to just +those services actually in use: +1. Remove unused code. +2. Instead of defining a 'UIKit-app' function and calling it, just declare the individual sandbox +commands inline. This will allow them to be more easily consolidated with other parts of the +sandbox in a future step. + +This update should not change behavior. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: + 2017-12-11 Chris Dumez Merge ServiceWorkerClientIdentifier into ServiceWorkerClientData Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (225762 => 225763) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2017-12-12 00:28:59 UTC (rev 225762) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2017-12-12 00:39:37 UTC (rev 225763) @@ -34,507 +34,369 @@ ;;; remove unneeded sandbox extensions. ;;; -;;; -;;; Declare that the process hosts UI provided by another process. -;;; (This could potentially be any application; see and -;;; for details) -;;; -(define-once (remote-view-client) -(allow mach-lookup -(global-name "com.apple.frontboard.systemappservices") ; -[UIViewServiceInterface _createProcessAssertion] -> SBSProcessIDForDisplayIdentifier() -(global-name-regex #"^com\.apple\.uikit\.viewservice\..+"))) +;;; Allow UIKit apps access to com.apple.TextInput.preferences mach service +(allow mach-lookup +(global-name "com.apple.TextInput.preferences")) -;;; -;;; Declare that the process serves UI that can be remotely-hosted by another process. -;;; -(define-once (remote-view-service) -;; RemoteViewServices need to lookup their own accessility service in order to send -;; the mach port to the hosting app. -(allow mach-lookup -(local-name "com.apple.iphone.axserver")) -;; RemoteViewServices need to lookup the bundle identifier of the application hosting -;; their views (see ). -(allow mach-lookup -(global-name "com.apple.springboard.backgroundappservices"))) +(allow mach-lookup +(xpc-service-name "com.apple.siri.context.service")) -(define (uikit-app . rest) -;;; Allow UIKit apps access to com.apple.TextInput.preferences mach service -(allow mach-lookup -(global-name "com.apple.TextInput.preferences")) +(allow mach-lookup +(global-name "com.apple.frontboard.systemappservices") ; -[UIViewServiceInterface _createProcessAssertion] -> SBSProcessIDForDisplayIdentifier() +(global-name-regex #"^com\.apple\.uikit\.viewservice\..+")) -(allow mach-lookup -(xpc-service-name "com.apple.siri.context.service")) +;; Any app could use ubiquity. +(ubiquity-client) -;; Any UI could be remote-hosted. -(remote-view-client) +;; Any app can play audio & movies. +(play-audio) +(play-media) -;; Any app could use ubiquity. -(ubiquity-client) +(url-translation) -;; Any app can play audio & movies. -(play-audio) -(play-media) +;; For All applications need to be able to access the com.apple.UIKit.KeyboardManagement running in backboardd +;; renamed in Rename com.apple.UIKit.KeyboardManagement +(allow mach-lookup +(global-name "com.apple.UIKit.KeyboardManagement") +(global-name "com.apple.UIKit.KeyboardManagement.hosted")) -;; Any app can use ProgressKit -(progresskit-client) - -(url-translation) - -;; For All applications need to be able to access the com.apple.UIKit.KeyboardManagement running in ba
[webkit-changes] [225762] trunk/Source/JavaScriptCore
Title: [225762] trunk/Source/_javascript_Core Revision 225762 Author commit-qu...@webkit.org Date 2017-12-11 16:28:59 -0800 (Mon, 11 Dec 2017) Log Message Remove unused builtin names https://bugs.webkit.org/show_bug.cgi?id=180673 Patch by Joseph Pecoraro on 2017-12-11 Reviewed by Keith Miller. * builtins/BuiltinNames.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/builtins/BuiltinNames.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (225761 => 225762) --- trunk/Source/_javascript_Core/ChangeLog 2017-12-11 23:37:38 UTC (rev 225761) +++ trunk/Source/_javascript_Core/ChangeLog 2017-12-12 00:28:59 UTC (rev 225762) @@ -1,3 +1,12 @@ +2017-12-11 Joseph Pecoraro + +Remove unused builtin names +https://bugs.webkit.org/show_bug.cgi?id=180673 + +Reviewed by Keith Miller. + +* builtins/BuiltinNames.h: + 2017-12-11 David Quesada Turn on ENABLE_APPLICATION_MANIFEST Modified: trunk/Source/_javascript_Core/builtins/BuiltinNames.h (225761 => 225762) --- trunk/Source/_javascript_Core/builtins/BuiltinNames.h 2017-12-11 23:37:38 UTC (rev 225761) +++ trunk/Source/_javascript_Core/builtins/BuiltinNames.h 2017-12-12 00:28:59 UTC (rev 225762) @@ -54,11 +54,6 @@ macro(iteratedString) \ macro(stringIteratorNextIndex) \ macro(promise) \ -macro(fulfillmentHandler) \ -macro(rejectionHandler) \ -macro(index) \ -macro(deferred) \ -macro(countdownHolder) \ macro(Object) \ macro(Number) \ macro(Array) \ @@ -131,7 +126,6 @@ macro(asyncGeneratorQueueLast) \ macro(asyncGeneratorQueueItemNext) \ macro(asyncGeneratorQueueItemPrevious) \ -macro(promiseCapability) \ macro(generatorResumeMode) \ macro(Collator) \ macro(DateTimeFormat) \ @@ -150,8 +144,6 @@ macro(isConstructor) \ macro(concatMemcpy) \ macro(appendMemcpy) \ -macro(predictFinalLengthFromArgumunts) \ -macro(print) \ macro(regExpCreate) \ macro(replaceUsingRegExp) \ macro(replaceUsingStringSearch) \ @@ -176,7 +168,6 @@ macro(regExpProtoStickyGetter) \ macro(regExpProtoUnicodeGetter) \ macro(regExpPrototypeSymbolReplace) \ -macro(regExpReplaceFast) \ macro(regExpSearchFast) \ macro(regExpSplitFast) \ macro(regExpTestFast) \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225760] trunk/Source
Title: [225760] trunk/Source Revision 225760 Author cdu...@apple.com Date 2017-12-11 15:24:51 -0800 (Mon, 11 Dec 2017) Log Message Merge ServiceWorkerClientIdentifier into ServiceWorkerClientData https://bugs.webkit.org/show_bug.cgi?id=180669 Reviewed by Youenn Fablet. Merge ServiceWorkerClientIdentifier into ServiceWorkerClientData, for consistency with ServiceWorkerIdentifier / ServiceWorkerData, and start simplifying the postMessage() code. Source/WebCore: * WebCore.xcodeproj/project.pbxproj: * dom/Document.cpp: (WebCore::Document::setServiceWorkerConnection): * workers/service/SWClientConnection.h: * workers/service/ServiceWorker.cpp: (WebCore::ServiceWorker::postMessage): * workers/service/ServiceWorkerClient.cpp: (WebCore::ServiceWorkerClient::getOrCreate): (WebCore::ServiceWorkerClient::ServiceWorkerClient): * workers/service/ServiceWorkerClient.h: (WebCore::ServiceWorkerClient::identifier const): * workers/service/ServiceWorkerClientData.cpp: (WebCore::ServiceWorkerClientData::isolatedCopy const): (WebCore::ServiceWorkerClientData::from): * workers/service/ServiceWorkerClientData.h: (WebCore::ServiceWorkerClientData::encode const): (WebCore::ServiceWorkerClientData::decode): * workers/service/ServiceWorkerClientInformation.h: Removed. * workers/service/ServiceWorkerClients.cpp: (WebCore::didFinishGetRequest): (WebCore::ServiceWorkerClients::get): (WebCore::matchAllCompleted): * workers/service/ServiceWorkerTypes.h: * workers/service/ServiceWorkerWindowClient.cpp: (WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient): * workers/service/ServiceWorkerWindowClient.h: * workers/service/context/SWContextManager.cpp: (WebCore::SWContextManager::postMessageToServiceWorker): * workers/service/context/SWContextManager.h: * workers/service/context/ServiceWorkerThread.cpp: (WebCore::ServiceWorkerThread::postMessageToServiceWorker): * workers/service/context/ServiceWorkerThread.h: * workers/service/server/SWServer.cpp: (WebCore::SWServer::findClientByIdentifier): (WebCore::SWServer::matchAll): (WebCore::SWServer::claim): (WebCore::SWServer::registerServiceWorkerClient): * workers/service/server/SWServer.h: * workers/service/server/SWServerToContextConnection.h: * workers/service/server/SWServerWorker.h: Source/WebKit: * Scripts/webkit/messages.py: (forward_declarations_and_headers): (headers_for_type): * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): * Shared/WebCoreArgumentCoders.h: * StorageProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::~WebSWServerConnection): (WebKit::WebSWServerConnection::postMessageToServiceWorkerFromClient): (WebKit::WebSWServerConnection::postMessageToServiceWorkerFromServiceWorker): (WebKit::WebSWServerConnection::registerServiceWorkerClient): (WebKit::WebSWServerConnection::unregisterServiceWorkerClient): * StorageProcess/ServiceWorker/WebSWServerConnection.h: * StorageProcess/ServiceWorker/WebSWServerConnection.messages.in: * StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::matchAllCompleted): * StorageProcess/ServiceWorker/WebSWServerToContextConnection.h: * WebProcess/Storage/WebSWClientConnection.cpp: (WebKit::WebSWClientConnection::registerServiceWorkerClient): (WebKit::WebSWClientConnection::unregisterServiceWorkerClient): * WebProcess/Storage/WebSWClientConnection.h: * WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::postMessageToServiceWorker): (WebKit::WebSWContextManagerConnection::matchAllCompleted): * WebProcess/Storage/WebSWContextManagerConnection.h: * WebProcess/Storage/WebSWContextManagerConnection.messages.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/workers/service/SWClientConnection.h trunk/Source/WebCore/workers/service/ServiceWorker.cpp trunk/Source/WebCore/workers/service/ServiceWorkerClient.cpp trunk/Source/WebCore/workers/service/ServiceWorkerClient.h trunk/Source/WebCore/workers/service/ServiceWorkerClientData.cpp trunk/Source/WebCore/workers/service/ServiceWorkerClientData.h trunk/Source/WebCore/workers/service/ServiceWorkerClients.cpp trunk/Source/WebCore/workers/service/ServiceWorkerTypes.h trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.h trunk/Source/WebCore/workers/service/context/SWContextManager.cpp trunk/Source/WebCore/workers/service/context/SWContextManager.h trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.h trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebCore/workers/service/server/SWServer.h trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h trunk/Source/WebCore/workers/service/server/SWServerWorker.h trunk/Sou
[webkit-changes] [225759] trunk/Source/WebKit
Title: [225759] trunk/Source/WebKit
Revision 225759
Author commit-qu...@webkit.org
Date 2017-12-11 15:23:52 -0800 (Mon, 11 Dec 2017)
Log Message
RTCPacketOptions::packet_id should be encoded as 32 bits integer.
https://bugs.webkit.org/show_bug.cgi?id=180654
Patch by Youenn Fablet on 2017-12-11
Reviewed by Eric Carlson.
packet_id is a 16 bit unsigned integer, but it can also take -1 if its value is not set.
Before the patch, it was IPC encoded as a 16 bit signed integer which is not large enough.
* Shared/RTCPacketOptions.cpp:
(WebKit::RTCPacketOptions::encode const):
(WebKit::RTCPacketOptions::decode):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RTCPacketOptions.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (225758 => 225759)
--- trunk/Source/WebKit/ChangeLog 2017-12-11 22:49:10 UTC (rev 225758)
+++ trunk/Source/WebKit/ChangeLog 2017-12-11 23:23:52 UTC (rev 225759)
@@ -1,3 +1,17 @@
+2017-12-11 Youenn Fablet
+
+RTCPacketOptions::packet_id should be encoded as 32 bits integer.
+https://bugs.webkit.org/show_bug.cgi?id=180654
+
+Reviewed by Eric Carlson.
+
+packet_id is a 16 bit unsigned integer, but it can also take -1 if its value is not set.
+Before the patch, it was IPC encoded as a 16 bit signed integer which is not large enough.
+
+* Shared/RTCPacketOptions.cpp:
+(WebKit::RTCPacketOptions::encode const):
+(WebKit::RTCPacketOptions::decode):
+
2017-12-11 Chris Dumez
Layout Test http/tests/workers/service/postmessage-after-sw-process-crash.https.html is flaky
Modified: trunk/Source/WebKit/Shared/RTCPacketOptions.cpp (225758 => 225759)
--- trunk/Source/WebKit/Shared/RTCPacketOptions.cpp 2017-12-11 22:49:10 UTC (rev 225758)
+++ trunk/Source/WebKit/Shared/RTCPacketOptions.cpp 2017-12-11 23:23:52 UTC (rev 225759)
@@ -36,7 +36,7 @@
void RTCPacketOptions::encode(IPC::Encoder& encoder) const
{
encoder.encodeEnum(options.dscp);
-encoder << safeCast(options.packet_id);
+encoder << safeCast(options.packet_id);
encoder << options.packet_time_params.rtp_sendtime_extension_id;
encoder << static_cast(options.packet_time_params.srtp_auth_tag_len);
@@ -56,7 +56,7 @@
return std::nullopt;
options.dscp = dscp;
-std::optional packetId;
+std::optional packetId;
decoder >> packetId;
if (!packetId)
return std::nullopt;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225758] trunk
Title: [225758] trunk
Revision 225758
Author cdu...@apple.com
Date 2017-12-11 14:49:10 -0800 (Mon, 11 Dec 2017)
Log Message
Layout Test http/tests/workers/service/postmessage-after-sw-process-crash.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=180659
Reviewed by Youenn Fablet.
Source/WebKit:
Fix flaky crash due to capturing an IPC::DataReference in a lambda, which would point to invalid
memory when the lambda is called asynchronously.
* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromClient):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromServiceWorker):
LayoutTests:
Rewrite test so that it is no longer flaky.
* http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt:
* http/tests/workers/service/resources/postmessage-after-sw-process-crash-worker.js: Added.
* http/tests/workers/service/resources/postmessage-after-sw-process-crash.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt
trunk/LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash.js
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp
Added Paths
trunk/LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash-worker.js
Diff
Modified: trunk/LayoutTests/ChangeLog (225757 => 225758)
--- trunk/LayoutTests/ChangeLog 2017-12-11 22:35:30 UTC (rev 225757)
+++ trunk/LayoutTests/ChangeLog 2017-12-11 22:49:10 UTC (rev 225758)
@@ -1,3 +1,16 @@
+2017-12-11 Chris Dumez
+
+Layout Test http/tests/workers/service/postmessage-after-sw-process-crash.https.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=180659
+
+Reviewed by Youenn Fablet.
+
+Rewrite test so that it is no longer flaky.
+
+* http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt:
+* http/tests/workers/service/resources/postmessage-after-sw-process-crash-worker.js: Added.
+* http/tests/workers/service/resources/postmessage-after-sw-process-crash.js:
+
2017-12-11 David Quesada
Turn on ENABLE_APPLICATION_MANIFEST
Modified: trunk/LayoutTests/http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt (225757 => 225758)
--- trunk/LayoutTests/http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt 2017-12-11 22:35:30 UTC (rev 225757)
+++ trunk/LayoutTests/http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt 2017-12-11 22:49:10 UTC (rev 225758)
@@ -1,8 +1,5 @@
-* Sending 'Message 1' to Service Worker
-PASS: Client received message from service worker, origin: https://127.0.0.1:8443
-PASS: Service worker received message 'Message 1' from origin 'https://127.0.0.1:8443'
+* Sending State to Service Worker
+* Asking Service Worker if it received the state
* Simulating Service Worker process crash
-* Sending 'Message 2' to Service Worker
-PASS: Client received message from service worker, origin: https://127.0.0.1:8443
-PASS: Service worker received message 'Message 2' from origin 'https://127.0.0.1:8443'
+PASS: service worker lost the state and responded the postMessage after process termination
Added: trunk/LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash-worker.js (0 => 225758)
--- trunk/LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash-worker.js (rev 0)
+++ trunk/LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash-worker.js 2017-12-11 22:49:10 UTC (rev 225758)
@@ -0,0 +1,15 @@
+var client = null;
+let receivedState = false;
+
+self.addEventListener("message", (event) => {
+if (event.data ="" "SetState") {
+receivedState = true;
+return;
+}
+
+if (event.data ="" "HasState") {
+event.source.postMessage(receivedState);
+return;
+}
+});
+
Modified: trunk/LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash.js (225757 => 225758)
--- trunk/LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash.js 2017-12-11 22:35:30 UTC (rev 225757)
+++ trunk/LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash.js 2017-12-11 22:49:10 UTC (rev 225758)
@@ -1,28 +1,46 @@
-var messageNumber = 1;
+let serviceWorkerHasReceivedState = false;
+let worker = null;
+let remainingAttempts = 1000; // We try for 10 seconds before timing out.
+
navigator.serviceWorker.addEventListener("message", function(event) {
-log("PASS: Client received message from service worker, origin: " + event.origin);
-log(event.data);
-if (messageNumber == 1) {
+if (!serviceWorkerHasReceivedState) {
+if (!event.data) {
+log("FAIL: ser
[webkit-changes] [225757] trunk/Source/WebCore
Title: [225757] trunk/Source/WebCore Revision 225757 Author dba...@webkit.org Date 2017-12-11 14:35:30 -0800 (Mon, 11 Dec 2017) Log Message Fix the macOS Sierra build following r225179 (https://bugs.webkit.org/show_bug.cgi?id=180011) Substitute TARGET_MAC_OS_X_VERSION_LESS_THAN_101300 for TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000. * Configurations/WebCore.xcconfig: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/WebCore.xcconfig Diff Modified: trunk/Source/WebCore/ChangeLog (225756 => 225757) --- trunk/Source/WebCore/ChangeLog 2017-12-11 22:27:43 UTC (rev 225756) +++ trunk/Source/WebCore/ChangeLog 2017-12-11 22:35:30 UTC (rev 225757) @@ -1,3 +1,12 @@ +2017-12-11 Daniel Bates + +Fix the macOS Sierra build following r225179 +(https://bugs.webkit.org/show_bug.cgi?id=180011) + +Substitute TARGET_MAC_OS_X_VERSION_LESS_THAN_101300 for TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000. + +* Configurations/WebCore.xcconfig: + 2017-12-11 Zalan Bujtas Make FrameView objects IsoHeap allocated Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (225756 => 225757) --- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2017-12-11 22:27:43 UTC (rev 225756) +++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2017-12-11 22:35:30 UTC (rev 225757) @@ -84,7 +84,7 @@ OTHER_LDFLAGS_PLATFORM[sdk=iphonesimulator*] = $(OTHER_LDFLAGS_BASE_ios) $(LIBWEBRTC_LDFLAGS); OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(OTHER_LDFLAGS_BASE) -sub_library libobjc -umbrella WebKit -framework ApplicationServices -framework AudioUnit -framework Carbon -framework Cocoa -framework DataDetectorsCore -framework IOSurface -framework OpenGL -framework SystemConfiguration $(LIBWEBRTC_LDFLAGS); -WK_UNDEFINED_SYMBOLS_LDFLAGS = $(WK_UNDEFINED_SYMBOLS_LDFLAGS_$(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000)); +WK_UNDEFINED_SYMBOLS_LDFLAGS = $(WK_UNDEFINED_SYMBOLS_LDFLAGS_$(TARGET_MAC_OS_X_VERSION_LESS_THAN_101300)); WK_UNDEFINED_SYMBOLS_LDFLAGS_YES = -Wl,-U,_CTFontCreatePhysicalFontForCharactersWithLanguage; WK_UNDEFINED_SYMBOLS_LDFLAGS_YES[sdk=macosx10.12*] =; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225756] trunk/Source/WebCore
Title: [225756] trunk/Source/WebCore
Revision 225756
Author za...@apple.com
Date 2017-12-11 14:27:43 -0800 (Mon, 11 Dec 2017)
Log Message
Make FrameView objects IsoHeap allocated
https://bugs.webkit.org/show_bug.cgi?id=180668
Reviewed by Simon Fraser.
Related to
* page/FrameView.cpp:
* page/FrameView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (225755 => 225756)
--- trunk/Source/WebCore/ChangeLog 2017-12-11 21:29:49 UTC (rev 225755)
+++ trunk/Source/WebCore/ChangeLog 2017-12-11 22:27:43 UTC (rev 225756)
@@ -1,3 +1,16 @@
+2017-12-11 Zalan Bujtas
+
+Make FrameView objects IsoHeap allocated
+https://bugs.webkit.org/show_bug.cgi?id=180668
+
+
+Reviewed by Simon Fraser.
+
+Related to
+
+* page/FrameView.cpp:
+* page/FrameView.h:
+
2017-12-11 Antoine Quint
[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
Modified: trunk/Source/WebCore/page/FrameView.cpp (225755 => 225756)
--- trunk/Source/WebCore/page/FrameView.cpp 2017-12-11 21:29:49 UTC (rev 225755)
+++ trunk/Source/WebCore/page/FrameView.cpp 2017-12-11 22:27:43 UTC (rev 225756)
@@ -98,6 +98,7 @@
#include
#include
+#include
#include
#include
#include
@@ -120,6 +121,8 @@
using namespace HTMLNames;
+WTF_MAKE_ISO_ALLOCATED_IMPL(FrameView);
+
double FrameView::sCurrentPaintTimeStamp = 0.0;
// The maximum number of updateEmbeddedObjects iterations that should be done before returning.
Modified: trunk/Source/WebCore/page/FrameView.h (225755 => 225756)
--- trunk/Source/WebCore/page/FrameView.h 2017-12-11 21:29:49 UTC (rev 225755)
+++ trunk/Source/WebCore/page/FrameView.h 2017-12-11 22:27:43 UTC (rev 225756)
@@ -39,6 +39,7 @@
#include
#include
#include
+#include
#include
#include
@@ -67,6 +68,7 @@
Pagination::Mode paginationModeForRenderStyle(const RenderStyle&);
class FrameView final : public ScrollView {
+WTF_MAKE_ISO_ALLOCATED(FrameView);
public:
friend class RenderView;
friend class Internals;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225755] tags/Safari-605.1.17/
Title: [225755] tags/Safari-605.1.17/ Revision 225755 Author jmarc...@apple.com Date 2017-12-11 13:29:49 -0800 (Mon, 11 Dec 2017) Log Message Tag Safari-605.1.17. Added Paths tags/Safari-605.1.17/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225754] trunk/Source/WebKit
Title: [225754] trunk/Source/WebKit Revision 225754 Author bfulg...@apple.com Date 2017-12-11 13:25:51 -0800 (Mon, 11 Dec 2017) Log Message [iOS] Don't import 'UIKit-apps.sb' to the WebContent process sandbox https://bugs.webkit.org/show_bug.cgi?id=180610 Reviewed by Dean Jackson. Stop including 'system.sb', and just include the portions of that sandbox that we actually use in WebContent Process. This is the first step in some further sandbox tightening. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Diff Modified: trunk/Source/WebKit/ChangeLog (225753 => 225754) --- trunk/Source/WebKit/ChangeLog 2017-12-11 20:10:03 UTC (rev 225753) +++ trunk/Source/WebKit/ChangeLog 2017-12-11 21:25:51 UTC (rev 225754) @@ -1,3 +1,17 @@ +2017-12-11 Brent Fulgham + +[iOS] Don't import 'UIKit-apps.sb' to the WebContent process sandbox +https://bugs.webkit.org/show_bug.cgi?id=180610 + + +Reviewed by Dean Jackson. + +Stop including 'system.sb', and just include the portions of that sandbox that we +actually use in WebContent Process. This is the first step in some further sandbox +tightening. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: + 2017-12-11 Yusuke Suzuki [WTF] Add Converter traits to StringHasher instead of function pointer Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (225753 => 225754) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2017-12-11 20:10:03 UTC (rev 225753) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2017-12-11 21:25:51 UTC (rev 225754) @@ -1,4 +1,4 @@ -; Copyright (C) 2010-2015 Apple Inc. All rights reserved. +; Copyright (C) 2010-2017 Apple Inc. All rights reserved. ; ; Redistribution and use in source and binary forms, with or without ; modification, are permitted provided that the following conditions @@ -27,8 +27,512 @@ (deny mach-lookup (xpc-service-name-prefix "")) -(import "UIKit-apps.sb") +(import "common.sb") +;;; +;;; The following rules were originally contained in 'UIKit-apps.sb'. We are duplicating them here so we can +;;; remove unneeded sandbox extensions. +;;; + +;;; +;;; Declare that the process hosts UI provided by another process. +;;; (This could potentially be any application; see and +;;; for details) +;;; +(define-once (remote-view-client) +(allow mach-lookup +(global-name "com.apple.frontboard.systemappservices") ; -[UIViewServiceInterface _createProcessAssertion] -> SBSProcessIDForDisplayIdentifier() +(global-name-regex #"^com\.apple\.uikit\.viewservice\..+"))) + +;;; +;;; Declare that the process serves UI that can be remotely-hosted by another process. +;;; +(define-once (remote-view-service) +;; RemoteViewServices need to lookup their own accessility service in order to send +;; the mach port to the hosting app. +(allow mach-lookup +(local-name "com.apple.iphone.axserver")) +;; RemoteViewServices need to lookup the bundle identifier of the application hosting +;; their views (see ). +(allow mach-lookup +(global-name "com.apple.springboard.backgroundappservices"))) + +(define (uikit-app . rest) +;;; Allow UIKit apps access to com.apple.TextInput.preferences mach service +(allow mach-lookup +(global-name "com.apple.TextInput.preferences")) + +(allow mach-lookup +(xpc-service-name "com.apple.siri.context.service")) + +;; Any UI could be remote-hosted. +(remote-view-client) + +;; Any app could use ubiquity. +(ubiquity-client) + +;; Any app can play audio & movies. +(play-audio) +(play-media) + +;; Any app can use ProgressKit +(progresskit-client) + +(url-translation) + +;; For All applications need to be able to access the com.apple.UIKit.KeyboardManagement running in backboardd +;; renamed in Rename com.apple.UIKit.KeyboardManagement +(allow mach-lookup +(global-name "com.apple.UIKit.KeyboardManagement") +(global-name "com.apple.UIKit.KeyboardManagement.hosted")) + +;; For Allow UIKit-based apps to access com.apple.remote-text-editing mach service +;; and REM: Allow UIKit-based apps to access com.apple.remote-input-limiting mach service +(when tv? +(allow mach-lookup +(global-name "com.apple.remote-input-limiting") +(global-name "com.apple.remote-text-editing") +(global-name "com.apple.remote-text-editing-legacy") +(global-name "com.apple.sharing.remote-text-editing"))) + +;; For ApplicationScripting +;; ASProcessScriptEvent fails to obtain port for event return +(allow mach-lookup +(global-name "ScripterServer")) + +
[webkit-changes] [225753] trunk
Title: [225753] trunk Revision 225753 Author timothy_hor...@apple.com Date 2017-12-11 12:10:03 -0800 (Mon, 11 Dec 2017) Log Message Stop using deprecated target conditional for simulator builds https://bugs.webkit.org/show_bug.cgi?id=180662 Reviewed by Simon Fraser. PerformanceTests: * StitchMarker/wtf/Platform.h: * StitchMarker/wtf/dependencies/bmalloc/BPlatform.h: Source/bmalloc: * bmalloc/BPlatform.h: Source/ThirdParty/libwebrtc: * Source/third_party/libyuv/source/mjpeg_decoder.cc: * Source/webrtc/examples/objc/AppRTCMobile/ARDAppClient.m: (-[ARDAppClient createLocalVideoTrack]): * Source/webrtc/examples/objc/AppRTCMobile/tests/ARDAppClient_xctest.mm: * Source/webrtc/modules/audio_device/ios/audio_device_ios.mm: (webrtc::LogDeviceInfo): Source/WebKitLegacy/mac: * postprocess-headers.sh: Source/WTF: * wtf/Platform.h: Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/StitchMarker/wtf/Platform.h trunk/PerformanceTests/StitchMarker/wtf/dependencies/bmalloc/BPlatform.h trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/mjpeg_decoder.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/examples/objc/AppRTCMobile/ARDAppClient.m trunk/Source/ThirdParty/libwebrtc/Source/webrtc/examples/objc/AppRTCMobile/tests/ARDAppClient_xctest.mm trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_device/ios/audio_device_ios.mm trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/postprocess-headers.sh trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/BPlatform.h Diff Modified: trunk/PerformanceTests/ChangeLog (225752 => 225753) --- trunk/PerformanceTests/ChangeLog 2017-12-11 19:41:46 UTC (rev 225752) +++ trunk/PerformanceTests/ChangeLog 2017-12-11 20:10:03 UTC (rev 225753) @@ -1,3 +1,14 @@ +2017-12-11 Tim Horton + +Stop using deprecated target conditional for simulator builds +https://bugs.webkit.org/show_bug.cgi?id=180662 + + +Reviewed by Simon Fraser. + +* StitchMarker/wtf/Platform.h: +* StitchMarker/wtf/dependencies/bmalloc/BPlatform.h: + 2017-12-11 Antti Koivisto StyleBench improvements Modified: trunk/PerformanceTests/StitchMarker/wtf/Platform.h (225752 => 225753) --- trunk/PerformanceTests/StitchMarker/wtf/Platform.h 2017-12-11 19:41:46 UTC (rev 225752) +++ trunk/PerformanceTests/StitchMarker/wtf/Platform.h 2017-12-11 20:10:03 UTC (rev 225753) @@ -378,7 +378,7 @@ /* OS(MAC_OS_X) - Mac OS X (not including iOS) */ #if OS(DARWIN) && ((defined(TARGET_OS_EMBEDDED) && TARGET_OS_EMBEDDED) \ || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) \ -|| (defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR)) +|| (defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR)) #define WTF_OS_IOS 1 #elif OS(DARWIN) && defined(TARGET_OS_MAC) && TARGET_OS_MAC #define WTF_OS_MAC_OS_X 1 @@ -474,7 +474,7 @@ #define WTF_PLATFORM_MAC 1 #elif OS(IOS) #define WTF_PLATFORM_IOS 1 -#if defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR +#if defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR #define WTF_PLATFORM_IOS_SIMULATOR 1 #endif #elif OS(WINDOWS) Modified: trunk/PerformanceTests/StitchMarker/wtf/dependencies/bmalloc/BPlatform.h (225752 => 225753) --- trunk/PerformanceTests/StitchMarker/wtf/dependencies/bmalloc/BPlatform.h 2017-12-11 19:41:46 UTC (rev 225752) +++ trunk/PerformanceTests/StitchMarker/wtf/dependencies/bmalloc/BPlatform.h 2017-12-11 20:10:03 UTC (rev 225753) @@ -48,9 +48,9 @@ #if BOS(DARWIN) && ((defined(TARGET_OS_EMBEDDED) && TARGET_OS_EMBEDDED) \ || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) \ -|| (defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR)) +|| (defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR)) #define BPLATFORM_IOS 1 -#if (defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR) +#if (defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR) #define BPLATFORM_IOS_SIMULATOR 1 #endif #elif BOS(DARWIN) && defined(TARGET_OS_MAC) && TARGET_OS_MAC Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (225752 => 225753) --- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2017-12-11 19:41:46 UTC (rev 225752) +++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2017-12-11 20:10:03 UTC (rev 225753) @@ -1,3 +1,18 @@ +2017-12-11 Tim Horton + +Stop using deprecated target conditional for simulator builds +https://bugs.webkit.org/show_bug.cgi?id=180662 + + +Reviewed by Simon Fraser. + +* Source/third_party/libyuv/source/mjpeg_decoder.cc: +* Source/webrtc/examples/objc/AppRTCMobile/ARDAppClient.m: +(-[ARDAppClient createLocalVideoTrack]): +* Source/webrtc/examples/objc/AppRTCMobile/tests/ARDAppClient_xctest.mm: +* Source/webrtc/modules/audio_device/ios/audio_device_ios.mm: +(webrtc::LogDeviceInfo): + 2
[webkit-changes] [225752] trunk/PerformanceTests
Title: [225752] trunk/PerformanceTests
Revision 225752
Author an...@apple.com
Date 2017-12-11 11:41:46 -0800 (Mon, 11 Dec 2017)
Log Message
StyleBench improvements
https://bugs.webkit.org/show_bug.cgi?id=180646
Reviewed by Geoffrey Garen.
- Remove :empty rule from global stylesheet. It caused all tests to hit positional pseudo-class code paths.
- Instead use min-width to create easy flexible layout. Use it for ::before/::after too.
- Add :empty to positional pseudo-class test.
- Include some id attributes and id selectors
- Chance to have more than 1 classes per compound selector
- Change distribution of elements and classes to be non-uniform
- Other bug fixes
* StyleBench/resources/style-bench.js:
(Random.prototype.numberSquareWeightedToLow):
(Random):
(defaultConfiguration):
(prototype.randomElementName):
(prototype.randomId):
(prototype.makeCompoundSelector):
(prototype.makeSelector):
(prototype.makeElement):
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/StyleBench/index.html
trunk/PerformanceTests/StyleBench/resources/style-bench.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (225751 => 225752)
--- trunk/PerformanceTests/ChangeLog 2017-12-11 19:22:01 UTC (rev 225751)
+++ trunk/PerformanceTests/ChangeLog 2017-12-11 19:41:46 UTC (rev 225752)
@@ -1,3 +1,28 @@
+2017-12-11 Antti Koivisto
+
+StyleBench improvements
+https://bugs.webkit.org/show_bug.cgi?id=180646
+
+Reviewed by Geoffrey Garen.
+
+- Remove :empty rule from global stylesheet. It caused all tests to hit positional pseudo-class code paths.
+- Instead use min-width to create easy flexible layout. Use it for ::before/::after too.
+- Add :empty to positional pseudo-class test.
+- Include some id attributes and id selectors
+- Chance to have more than 1 classes per compound selector
+- Change distribution of elements and classes to be non-uniform
+- Other bug fixes
+
+* StyleBench/resources/style-bench.js:
+(Random.prototype.numberSquareWeightedToLow):
+(Random):
+(defaultConfiguration):
+(prototype.randomElementName):
+(prototype.randomId):
+(prototype.makeCompoundSelector):
+(prototype.makeSelector):
+(prototype.makeElement):
+
2017-12-08 Konstantin Tokarev
[python] Replace print operator with print() function for python3 compatibility
Modified: trunk/PerformanceTests/StyleBench/index.html (225751 => 225752)
--- trunk/PerformanceTests/StyleBench/index.html 2017-12-11 19:22:01 UTC (rev 225751)
+++ trunk/PerformanceTests/StyleBench/index.html 2017-12-11 19:41:46 UTC (rev 225752)
@@ -2,7 +2,7 @@
-StyleBench 0.1
+StyleBench 0.2
Modified: trunk/PerformanceTests/StyleBench/resources/style-bench.js (225751 => 225752)
--- trunk/PerformanceTests/StyleBench/resources/style-bench.js 2017-12-11 19:22:01 UTC (rev 225751)
+++ trunk/PerformanceTests/StyleBench/resources/style-bench.js 2017-12-11 19:41:46 UTC (rev 225752)
@@ -12,9 +12,14 @@
return this.seed = this.seed * 16807 % 2147483647;
}
+underOne()
+{
+return (this.next % 1048576) / 1048576;
+}
+
chance(chance)
{
-return this.next % 1048576 < chance * 1048576;
+return this.underOne() < chance;
}
number(under)
@@ -21,6 +26,13 @@
{
return this.next % under;
}
+
+numberSquareWeightedToLow(under)
+{
+const random = this.underOne();
+const random2 = random * random;
+return Math.floor(random2 * under);
+}
}
function nextAnimationFrame()
@@ -35,6 +47,7 @@
return {
name: 'Default',
elementTypeCount: 10,
+idChance: 0.05,
elementChance: 0.5,
classCount: 200,
classChance: 0.3,
@@ -85,6 +98,7 @@
'first-of-type',
'last-of-type',
'only-of-type',
+'empty',
],
});
}
@@ -110,6 +124,7 @@
constructor(configuration)
{
this.configuration = configuration;
+this.idCount = 0;
this.baseStyle = document.createElement("style");
this.baseStyle.textContent = `
@@ -119,10 +134,8 @@
}
#testroot * {
display: inline-block;
-}
-#testroot :empty {
-width:10px;
height:10px;
+min-width:10px;
}
`;
document.head.appendChild(this.baseStyle);
@@ -137,19 +150,19 @@
randomElementName()
{
const elementTypeCount = this.configuration.elementTypeCount;
-return `elem${ this.random.number(elementTypeCount) }`;
+return `elem${ this.random.numberSquareWeightedToLow(elementTypeCount) }`;
}
randomClassName()
{
const classCount = this.configuratio
[webkit-changes] [225751] trunk/Source
Title: [225751] trunk/Source
Revision 225751
Author utatane@gmail.com
Date 2017-12-11 11:22:01 -0800 (Mon, 11 Dec 2017)
Log Message
[WTF] Add Converter traits to StringHasher instead of function pointer
https://bugs.webkit.org/show_bug.cgi?id=180656
Reviewed by JF Bastien.
Source/WebKit:
* WebProcess/WebProcess.cpp:
(WebKit::addCaseFoldedCharacters):
Source/WTF:
In the latest ICU, UChar is char16_t. So defining defaultConverter(UChar)
and defaultConverter(char16_t) causes duplicate definitions.
Instead of passing a funtion pointer, we pass a trait class DefaultConveter
which has `convert` static function. And we make this `convert` function
generic. This avoids defining convert function for UChar and char16_t.
* wtf/text/StringHash.h:
(WTF::ASCIICaseInsensitiveHash::FoldCase::convert):
(WTF::ASCIICaseInsensitiveHash::hash):
(WTF::ASCIICaseInsensitiveHash::foldCase): Deleted.
* wtf/text/StringHasher.h:
(WTF::StringHasher::DefaultConverter::convert):
(WTF::StringHasher::addCharactersAssumingAligned):
(WTF::StringHasher::addCharacters):
(WTF::StringHasher::computeHashAndMaskTop8Bits):
(WTF::StringHasher::computeHash):
(WTF::StringHasher::computeLiteralHash):
(WTF::StringHasher::computeLiteralHashAndMaskTop8Bits):
(WTF::StringHasher::computeHashImpl):
(WTF::StringHasher::Converter): Deleted.
(WTF::StringHasher::defaultConverter): Deleted.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringHash.h
trunk/Source/WTF/wtf/text/StringHasher.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (225750 => 225751)
--- trunk/Source/WTF/ChangeLog 2017-12-11 19:19:35 UTC (rev 225750)
+++ trunk/Source/WTF/ChangeLog 2017-12-11 19:22:01 UTC (rev 225751)
@@ -1,3 +1,32 @@
+2017-12-11 Yusuke Suzuki
+
+[WTF] Add Converter traits to StringHasher instead of function pointer
+https://bugs.webkit.org/show_bug.cgi?id=180656
+
+Reviewed by JF Bastien.
+
+In the latest ICU, UChar is char16_t. So defining defaultConverter(UChar)
+and defaultConverter(char16_t) causes duplicate definitions.
+Instead of passing a funtion pointer, we pass a trait class DefaultConveter
+which has `convert` static function. And we make this `convert` function
+generic. This avoids defining convert function for UChar and char16_t.
+
+* wtf/text/StringHash.h:
+(WTF::ASCIICaseInsensitiveHash::FoldCase::convert):
+(WTF::ASCIICaseInsensitiveHash::hash):
+(WTF::ASCIICaseInsensitiveHash::foldCase): Deleted.
+* wtf/text/StringHasher.h:
+(WTF::StringHasher::DefaultConverter::convert):
+(WTF::StringHasher::addCharactersAssumingAligned):
+(WTF::StringHasher::addCharacters):
+(WTF::StringHasher::computeHashAndMaskTop8Bits):
+(WTF::StringHasher::computeHash):
+(WTF::StringHasher::computeLiteralHash):
+(WTF::StringHasher::computeLiteralHashAndMaskTop8Bits):
+(WTF::StringHasher::computeHashImpl):
+(WTF::StringHasher::Converter): Deleted.
+(WTF::StringHasher::defaultConverter): Deleted.
+
2017-12-10 Yusuke Suzuki
[WTF] Reduce sizeof(Thread) by adjusting alignment
Modified: trunk/Source/WTF/wtf/text/StringHash.h (225750 => 225751)
--- trunk/Source/WTF/wtf/text/StringHash.h 2017-12-11 19:19:35 UTC (rev 225750)
+++ trunk/Source/WTF/wtf/text/StringHash.h 2017-12-11 19:22:01 UTC (rev 225751)
@@ -80,14 +80,17 @@
};
struct ASCIICaseInsensitiveHash {
-template static inline UChar foldCase(T character)
-{
-return toASCIILower(character);
-}
+template
+struct FoldCase {
+static inline UChar convert(T character)
+{
+return toASCIILower(character);
+}
+};
static unsigned hash(const UChar* data, unsigned length)
{
-return StringHasher::computeHashAndMaskTop8Bits>(data, length);
+return StringHasher::computeHashAndMaskTop8Bits>(data, length);
}
static unsigned hash(StringImpl& string)
@@ -104,7 +107,7 @@
static unsigned hash(const LChar* data, unsigned length)
{
-return StringHasher::computeHashAndMaskTop8Bits>(data, length);
+return StringHasher::computeHashAndMaskTop8Bits>(data, length);
}
static inline unsigned hash(const char* data, unsigned length)
Modified: trunk/Source/WTF/wtf/text/StringHasher.h (225750 => 225751)
--- trunk/Source/WTF/wtf/text/StringHasher.h 2017-12-11 19:19:35 UTC (rev 225750)
+++ trunk/Source/WTF/wtf/text/StringHasher.h 2017-12-11 19:22:01 UTC (rev 225751)
@@ -42,6 +42,14 @@
static constexpr const unsigned flagCount = 8; // Save 8 bits for StringImpl to use as flags.
static constexpr const unsigned maskHash = (1U << (sizeof(unsigned) * 8 - flagCount)) - 1;
+struct DefaultConverte
[webkit-changes] [225750] trunk/Source/WebCore
Title: [225750] trunk/Source/WebCore
Revision 225750
Author grao...@webkit.org
Date 2017-12-11 11:19:35 -0800 (Mon, 11 Dec 2017)
Log Message
[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
https://bugs.webkit.org/show_bug.cgi?id=180647
Reviewed by Dean Jackson.
Actually fix Windows build this time.
* animation/AnimationPlaybackEventInit.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (225749 => 225750)
--- trunk/Source/WebCore/ChangeLog 2017-12-11 18:56:56 UTC (rev 225749)
+++ trunk/Source/WebCore/ChangeLog 2017-12-11 19:19:35 UTC (rev 225750)
@@ -2,6 +2,17 @@
[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
https://bugs.webkit.org/show_bug.cgi?id=180647
+
+Reviewed by Dean Jackson.
+
+Actually fix Windows build this time.
+
+* animation/AnimationPlaybackEventInit.h:
+
+2017-12-11 Antoine Quint
+
+[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
+https://bugs.webkit.org/show_bug.cgi?id=180647
Reviewed by Dean Jackson.
Modified: trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h (225749 => 225750)
--- trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h 2017-12-11 18:56:56 UTC (rev 225749)
+++ trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h 2017-12-11 19:19:35 UTC (rev 225750)
@@ -26,7 +26,7 @@
#pragma once
#include "EventInit.h"
-#include "Optional.h"
+#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225749] trunk/Source/WebCore
Title: [225749] trunk/Source/WebCore
Revision 225749
Author grao...@webkit.org
Date 2017-12-11 10:56:56 -0800 (Mon, 11 Dec 2017)
Log Message
[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
https://bugs.webkit.org/show_bug.cgi?id=180647
Reviewed by Dean Jackson.
Unreviewed, fix Windows build.
* animation/AnimationPlaybackEventInit.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (225748 => 225749)
--- trunk/Source/WebCore/ChangeLog 2017-12-11 18:23:48 UTC (rev 225748)
+++ trunk/Source/WebCore/ChangeLog 2017-12-11 18:56:56 UTC (rev 225749)
@@ -1,3 +1,15 @@
+2017-12-11 Antoine Quint
+
+[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
+https://bugs.webkit.org/show_bug.cgi?id=180647
+
+
+Reviewed by Dean Jackson.
+
+Unreviewed, fix Windows build.
+
+* animation/AnimationPlaybackEventInit.h:
+
2017-12-11 Zalan Bujtas
FloatingObjects/FloatingObject classes should hold weak references to renderers
Modified: trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h (225748 => 225749)
--- trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h 2017-12-11 18:23:48 UTC (rev 225748)
+++ trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h 2017-12-11 18:56:56 UTC (rev 225749)
@@ -26,6 +26,7 @@
#pragma once
#include "EventInit.h"
+#include "Optional.h"
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225748] trunk/Source/WebCore
Title: [225748] trunk/Source/WebCore Revision 225748 Author za...@apple.com Date 2017-12-11 10:23:48 -0800 (Mon, 11 Dec 2017) Log Message FloatingObjects/FloatingObject classes should hold weak references to renderers https://bugs.webkit.org/show_bug.cgi?id=180627 Reviewed by Antti Koivisto. * rendering/FloatingObjects.cpp: (WebCore::FloatingObject::FloatingObject): (WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter): (WebCore::ComputeFloatOffsetForFloatLayoutAdapter::ComputeFloatOffsetForFloatLayoutAdapter): (WebCore::ComputeFloatOffsetForLineLayoutAdapter::ComputeFloatOffsetForLineLayoutAdapter): (WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter): (WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded): (WebCore::FloatingObjects::findNextFloatLogicalBottomBelow): (WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock): (WebCore::FloatingObjects::FloatingObjects): (WebCore::FloatingObjects::clearLineBoxTreePointers): (WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat): (WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat): (WebCore::FloatingObjects::logicalLeftOffset): (WebCore::FloatingObjects::logicalRightOffset): (WebCore::ComputeFloatOffsetForFloatLayoutAdapter::updateOffsetIfNeeded): (WebCore::ComputeFloatOffsetForFloatLayoutAdapter::updateOffsetIfNeeded): (WebCore::ComputeFloatOffsetForFloatLayoutAdapter::heightRemaining const): (WebCore::ComputeFloatOffsetAdapter::collectIfNeeded): (WebCore::ComputeFloatOffsetForLineLayoutAdapter::updateOffsetIfNeeded): (WebCore::ComputeFloatOffsetForLineLayoutAdapter::updateOffsetIfNeeded): * rendering/FloatingObjects.h: (WebCore::FloatingObject::renderer const): (WebCore::FloatingObjects::renderer const): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/FloatingObjects.cpp trunk/Source/WebCore/rendering/FloatingObjects.h Diff Modified: trunk/Source/WebCore/ChangeLog (225747 => 225748) --- trunk/Source/WebCore/ChangeLog 2017-12-11 18:09:32 UTC (rev 225747) +++ trunk/Source/WebCore/ChangeLog 2017-12-11 18:23:48 UTC (rev 225748) @@ -1,3 +1,36 @@ +2017-12-11 Zalan Bujtas + +FloatingObjects/FloatingObject classes should hold weak references to renderers +https://bugs.webkit.org/show_bug.cgi?id=180627 + + +Reviewed by Antti Koivisto. + +* rendering/FloatingObjects.cpp: +(WebCore::FloatingObject::FloatingObject): +(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter): +(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::ComputeFloatOffsetForFloatLayoutAdapter): +(WebCore::ComputeFloatOffsetForLineLayoutAdapter::ComputeFloatOffsetForLineLayoutAdapter): +(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter): +(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded): +(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow): +(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock): +(WebCore::FloatingObjects::FloatingObjects): +(WebCore::FloatingObjects::clearLineBoxTreePointers): +(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat): +(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat): +(WebCore::FloatingObjects::logicalLeftOffset): +(WebCore::FloatingObjects::logicalRightOffset): +(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::updateOffsetIfNeeded): +(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::updateOffsetIfNeeded): +(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::heightRemaining const): +(WebCore::ComputeFloatOffsetAdapter::collectIfNeeded): +(WebCore::ComputeFloatOffsetForLineLayoutAdapter::updateOffsetIfNeeded): +(WebCore::ComputeFloatOffsetForLineLayoutAdapter::updateOffsetIfNeeded): +* rendering/FloatingObjects.h: +(WebCore::FloatingObject::renderer const): +(WebCore::FloatingObjects::renderer const): + 2017-12-11 David Quesada Turn on ENABLE_APPLICATION_MANIFEST Modified: trunk/Source/WebCore/rendering/FloatingObjects.cpp (225747 => 225748) --- trunk/Source/WebCore/rendering/FloatingObjects.cpp 2017-12-11 18:09:32 UTC (rev 225747) +++ trunk/Source/WebCore/rendering/FloatingObjects.cpp 2017-12-11 18:23:48 UTC (rev 225748) @@ -43,7 +43,7 @@ COMPILE_ASSERT(sizeof(FloatingObject) == sizeof(SameSizeAsFloatingObject), FloatingObject_should_stay_small); FloatingObject::FloatingObject(RenderBox& renderer) -: m_renderer(renderer) +: m_renderer(makeWeakPtr(renderer)) , m_shouldPaint(true) , m_isDescendant(false) , m_isPlaced(false) @@ -60,7 +60,7 @@ } FloatingObject::FloatingObject(RenderBox& renderer, Type type, const LayoutRect& frameRect, const LayoutSize& marginOffset, bool shouldPaint, bool isDescendant) -: m_renderer(renderer) +: m_renderer(makeWeakPtr(renderer))
[webkit-changes] [225747] trunk
Title: [225747] trunk Revision 225747 Author commit-qu...@webkit.org Date 2017-12-11 10:09:32 -0800 (Mon, 11 Dec 2017) Log Message Turn on ENABLE_APPLICATION_MANIFEST https://bugs.webkit.org/show_bug.cgi?id=180562 rdar://problem/35924737 Patch by David Quesada on 2017-12-11 Reviewed by Geoffrey Garen. Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: * loader/LinkLoader.cpp: (WebCore::createLinkPreloadResourceClient): * loader/cached/CachedResourceRequest.cpp: Add a missing #include that was implicitly added in the unified source when the feature is disabled. Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: Source/WebKit: * Configurations/FeatureDefines.xcconfig: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: Tools: * Configurations/FeatureDefines.xcconfig: LayoutTests: * platform/ios-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/loader/LinkLoader.cpp trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/LayoutTests/ChangeLog (225746 => 225747) --- trunk/LayoutTests/ChangeLog 2017-12-11 18:07:48 UTC (rev 225746) +++ trunk/LayoutTests/ChangeLog 2017-12-11 18:09:32 UTC (rev 225747) @@ -1,3 +1,14 @@ +2017-12-11 David Quesada + +Turn on ENABLE_APPLICATION_MANIFEST +https://bugs.webkit.org/show_bug.cgi?id=180562 +rdar://problem/35924737 + +Reviewed by Geoffrey Garen. + +* platform/ios-wk2/TestExpectations: +* platform/mac-wk2/TestExpectations: + 2017-12-11 Dean Jackson Add a runtime feature flag for ImageBitmap and OffscreenCanvas Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (225746 => 225747) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-12-11 18:07:48 UTC (rev 225746) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-12-11 18:09:32 UTC (rev 225747) @@ -61,6 +61,10 @@ webkit.org/b/170713 imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-022.html [ ImageOnlyFailure ] +http/tests/security/contentSecurityPolicy/manifest-src-allowed.html [ Pass ] +http/tests/security/contentSecurityPolicy/manifest-src-blocked.html [ Pass ] +applicationmanifest/ [ Pass ] + #// # End platform-specific directories. #// Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (225746 => 225747) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-12-11 18:07:48 UTC (rev 225746) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-12-11 18:09:32 UTC (rev 225747) @@ -58,6 +58,10 @@ imported/w3c/web-platform-tests/payment-request/user-abort-algorithm-manual.https.html [ Skip ] imported/w3c/web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html [ Skip ] +http/tests/security/contentSecurityPolicy/manifest-src-allowed.html [ Pass ] +http/tests/security/contentSecurityPolicy/manifest-src-blocked.html [ Pass ] +applicationmanifest/ [ Pass ] + #// # End platform-specific directories. #// Modified: trunk/Source/_javascript_Core/ChangeLog (225746 => 225747) --- trunk/Source/_javascript_Core/ChangeLog 2017-12-11 18:07:48 UTC (rev 225746) +++ trunk/Source/_javascript_Core/ChangeLog 2017-12-11 18:09:32 UTC (rev 225747) @@ -1,3 +1,13 @@ +2017-12-11 David Quesada + +Turn on ENABLE_APPLICATION_MANIFEST +https://bugs.webkit.org/show_bug.cgi?id=180562 +rdar://problem/35924737 + +Reviewed by Geoffrey Garen. + +* Configurations/FeatureDefines.xcconfig: + 2017-12-10 Filip Pizlo Harden a few assertions in GC sweep Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (225746 => 225747) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-12-11 18:07:48 UTC (rev 225746) +++ trunk/Source/_j
[webkit-changes] [225746] trunk
Title: [225746] trunk
Revision 225746
Author d...@apple.com
Date 2017-12-11 10:07:48 -0800 (Mon, 11 Dec 2017)
Log Message
Add a runtime feature flag for ImageBitmap and OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=180652
Reviewed by Antoine Quint.
Source/WebCore:
Add a RuntimeEnabledFeature for these interfaces, and link the bindings
to the feature.
Test: fast/canvas/offscreen-enabled.html
* bindings/js/WebCoreBuiltinNames.h:
* html/ImageBitmap.idl:
* html/OffscreenCanvas.idl:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setImageBitmapOffscreenCanvasEnabled):
(WebCore::RuntimeEnabledFeatures::imageBitmapOffscreenCanvasEnabled const):
* page/WindowOrWorkerGlobalScope.idl:
Source/WebKit:
Add an experimental feature flag for these interfaces.
* Shared/WebPreferences.yaml:
Websites/webkit.org:
Simple test to validate if these interfaces are enabled.
* experimental-features.html:
LayoutTests:
* fast/canvas/offscreen-enabled-expected.txt: Added.
* fast/canvas/offscreen-enabled.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/html/ImageBitmap.idl
trunk/Source/WebCore/html/OffscreenCanvas.idl
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebCore/page/WindowOrWorkerGlobalScope.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/experimental-features.html
Added Paths
trunk/LayoutTests/fast/canvas/offscreen-enabled-expected.txt
trunk/LayoutTests/fast/canvas/offscreen-enabled.html
Diff
Modified: trunk/LayoutTests/ChangeLog (225745 => 225746)
--- trunk/LayoutTests/ChangeLog 2017-12-11 18:02:37 UTC (rev 225745)
+++ trunk/LayoutTests/ChangeLog 2017-12-11 18:07:48 UTC (rev 225746)
@@ -1,3 +1,14 @@
+2017-12-11 Dean Jackson
+
+Add a runtime feature flag for ImageBitmap and OffscreenCanvas
+https://bugs.webkit.org/show_bug.cgi?id=180652
+
+
+Reviewed by Antoine Quint.
+
+* fast/canvas/offscreen-enabled-expected.txt: Added.
+* fast/canvas/offscreen-enabled.html: Added.
+
2017-12-11 Ms2ger
[WPE] Enable most wpt html tests.
Added: trunk/LayoutTests/fast/canvas/offscreen-enabled-expected.txt (0 => 225746)
--- trunk/LayoutTests/fast/canvas/offscreen-enabled-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/offscreen-enabled-expected.txt 2017-12-11 18:07:48 UTC (rev 225746)
@@ -0,0 +1,3 @@
+createImageBitmap exists
+
+OffscreenCanvas exists
Property changes on: trunk/LayoutTests/fast/canvas/offscreen-enabled-expected.txt
___
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/plain
\ No newline at end of property
Added: trunk/LayoutTests/fast/canvas/offscreen-enabled.html (0 => 225746)
--- trunk/LayoutTests/fast/canvas/offscreen-enabled.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/offscreen-enabled.html 2017-12-11 18:07:48 UTC (rev 225746)
@@ -0,0 +1,16 @@
+
+function log(msg) {
+const out = document.querySelector("div");
+const p = document.createElement("p");
+p.textContent = msg;
+out.appendChild(p);
+}
+if (window.testRunner)
+window.testRunner.dumpAsText();
+
+window.addEventListener("load", function () {
+log('createImageBitmap' in window ? "createImageBitmap exists" : "FAIL: createImageBitmap should exist");
+log('OffscreenCanvas' in window ? "OffscreenCanvas exists" : "FAIL: OffscreenCanvas should exist");
+}, false);
+
+
Property changes on: trunk/LayoutTests/fast/canvas/offscreen-enabled.html
___
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/html
\ No newline at end of property
Modified: trunk/Source/WebCore/ChangeLog (225745 => 225746)
--- trunk/Source/WebCore/ChangeLog 2017-12-11 18:02:37 UTC (rev 225745)
+++ trunk/Source/WebCore/ChangeLog 2017-12-11 18:07:48 UTC (rev 225746)
@@ -1,3 +1,24 @@
+2017-12-11 Dean Jackson
+
+Add a runtime feature flag for ImageBitmap and OffscreenCanvas
+https://bugs.webkit.org/show_bug.cgi?id=180652
+
+
+Reviewed by Antoine Quint.
+
+Add a RuntimeEnabledFeature for these interfaces, and link the bindings
+to the feature.
+
+Test: fast/canvas/offscreen-enabled.html
+
+* bindings/js/WebCoreBuiltinNames.h:
+* html/ImageBitmap.idl:
+* html/OffscreenCanvas.idl:
+* page/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::setImageBitmapOffscreenCanvasEnabled):
+
[webkit-changes] [225745] trunk/Source/WebCore
Title: [225745] trunk/Source/WebCore Revision 225745 Author grao...@webkit.org Date 2017-12-11 10:02:37 -0800 (Mon, 11 Dec 2017) Log Message [Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit https://bugs.webkit.org/show_bug.cgi?id=180647 Reviewed by Dean Jackson. We implement the AnimationPlaybackEvent interface and AnimationPlaybackEventInit dictionary as the first step towards dispatching animation "finish" and "cancel" events. Animation playback events will be dispatched on Animation objects and expose the timeline time and animation current time at the time they were constructed. Dispatch itself, which will be the focus of the next patch, is not synchronous, so it's important to track those values at creation time. No new tests yet, followup patches will enable event dispatch and existing Web Platform Tests will show progressions. * CMakeLists.txt: * DerivedSources.make: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * animation/AnimationPlaybackEvent.cpp: Added. (WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent): (WebCore::AnimationPlaybackEvent::bindingsCurrentTime const): (WebCore::AnimationPlaybackEvent::bindingsTimelineTime const): * animation/AnimationPlaybackEvent.h: Added. * animation/AnimationPlaybackEvent.idl: Added. * animation/AnimationPlaybackEventInit.h: Added. * animation/AnimationPlaybackEventInit.idl: Added. * bindings/js/WebCoreBuiltinNames.h: * dom/EventNames.in: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h trunk/Source/WebCore/dom/EventNames.in Added Paths trunk/Source/WebCore/animation/AnimationPlaybackEvent.cpp trunk/Source/WebCore/animation/AnimationPlaybackEvent.h trunk/Source/WebCore/animation/AnimationPlaybackEvent.idl trunk/Source/WebCore/animation/AnimationPlaybackEventInit.h trunk/Source/WebCore/animation/AnimationPlaybackEventInit.idl Diff Modified: trunk/Source/WebCore/CMakeLists.txt (225744 => 225745) --- trunk/Source/WebCore/CMakeLists.txt 2017-12-11 17:46:26 UTC (rev 225744) +++ trunk/Source/WebCore/CMakeLists.txt 2017-12-11 18:02:37 UTC (rev 225745) @@ -424,6 +424,8 @@ animation/Animatable.idl animation/AnimationEffect.idl animation/AnimationEffectTiming.idl +animation/AnimationPlaybackEvent.idl +animation/AnimationPlaybackEventInit.idl animation/AnimationTimeline.idl animation/DocumentTimeline.idl animation/KeyframeEffect.idl Modified: trunk/Source/WebCore/ChangeLog (225744 => 225745) --- trunk/Source/WebCore/ChangeLog 2017-12-11 17:46:26 UTC (rev 225744) +++ trunk/Source/WebCore/ChangeLog 2017-12-11 18:02:37 UTC (rev 225745) @@ -1,3 +1,37 @@ +2017-12-11 Antoine Quint + +[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit +https://bugs.webkit.org/show_bug.cgi?id=180647 + + +Reviewed by Dean Jackson. + +We implement the AnimationPlaybackEvent interface and AnimationPlaybackEventInit dictionary +as the first step towards dispatching animation "finish" and "cancel" events. + +Animation playback events will be dispatched on Animation objects and expose the timeline time +and animation current time at the time they were constructed. Dispatch itself, which will be +the focus of the next patch, is not synchronous, so it's important to track those values +at creation time. + +No new tests yet, followup patches will enable event dispatch and existing Web Platform Tests +will show progressions. + +* CMakeLists.txt: +* DerivedSources.make: +* Sources.txt: +* WebCore.xcodeproj/project.pbxproj: +* animation/AnimationPlaybackEvent.cpp: Added. +(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent): +(WebCore::AnimationPlaybackEvent::bindingsCurrentTime const): +(WebCore::AnimationPlaybackEvent::bindingsTimelineTime const): +* animation/AnimationPlaybackEvent.h: Added. +* animation/AnimationPlaybackEvent.idl: Added. +* animation/AnimationPlaybackEventInit.h: Added. +* animation/AnimationPlaybackEventInit.idl: Added. +* bindings/js/WebCoreBuiltinNames.h: +* dom/EventNames.in: + 2017-12-11 Basuke Suzuki [WinCairo] DumpRenderTree times out for all non-http tests Modified: trunk/Source/WebCore/DerivedSources.make (225744 => 225745) --- trunk/Source/WebCore/DerivedSources.make 2017-12-11 17:46:26 UTC (rev 225744) +++ trunk/Source/WebCore/DerivedSources.make 2017-12-11 18:02:37 UTC (rev 225745) @@ -348,6 +348,8 @@ $(WebCore)/animation/Animatable.idl \ $(WebCore)/animation/AnimationEffect.idl \ $(WebCore)/animation/AnimationEffectTiming.idl \ +$(WebCore)/animation/AnimationPlaybackEvent.i
[webkit-changes] [225744] trunk/LayoutTests
Title: [225744] trunk/LayoutTests Revision 225744 Author ms2...@igalia.com Date 2017-12-11 09:46:26 -0800 (Mon, 11 Dec 2017) Log Message [WPE] Enable most wpt html tests. https://bugs.webkit.org/show_bug.cgi?id=180650 Unreviewed test gardening. * platform/wpe/TestExpectations: * platform/wpe/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt: Added: same as GTK; whitespace-only difference with the generic expectation file. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Added: whitespace-only difference with the generic expectation file. * platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Added: some subtests pass because the plugin array does not contain any plugins on WPE, and issues with the actual elements of the array can not be detected. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wpe/TestExpectations Added Paths trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/interactive-elements/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/selectors/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/webappapis/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (225743 => 225744) --- trunk/LayoutTests/ChangeLog 2017-12-11 17:38:57 UTC (rev 225743) +++ trunk/LayoutTests/ChangeLog 2017-12-11 17:46:26 UTC (rev 225744) @@ -1,3 +1,20 @@ +2017-12-11 Ms2ger + +[WPE] Enable most wpt html tests. +https://bugs.webkit.org/show_bug.cgi?id=180650 + +Unreviewed test gardening. + +* platform/wpe/TestExpectations: +* platform/wpe/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt: + Added: same as GTK; whitespace-only difference with the generic expectation file. +* platform/wpe/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: + Added: whitespace-only difference with the generic expectation file. +* platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: + Added: some subtests pass because the plugin array does not contain any + plugins on WPE, and issues with the actual elements of the array can + not be detected. + 2017-12-11 Zan Dobersek Unreviewed, rolling out r225737. Modified: trunk/LayoutTests/platform/wpe/TestExpectations (225743 => 225744) --- trunk/LayoutTests/platform/wpe/TestExpectations 2017-12-11 17:38:57 UTC (rev 225743) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2017-12-11 17:46:26 UTC (rev 225744) @@ -212,7 +212,6 @@ Bug(WPE) imported/w3c/web-platform-tests/custom-elements [ Skip ] Bug(WPE) imported/w3c/web-platform-tests/feature-policy [ Skip ] Bug(WPE) imported/w3c/web-platform-tests/fetch [ Skip ] -Bug(WPE) imported/w3c/web-platform-tests/html [ Skip ] Bug(WPE) imported/w3c/web-platform-tests/mediacapture-fromelement [ Skip ] Bug(WPE) imported/w3c/web-platform-tests/mediacapture-streams [ Skip ] Bug(WPE) imported/w3c/web-platform-tests/media-source [ Skip ] @@ -288,6 +287,22 @@ webkit.org/b/172099 imported/w3c/web-platform-tests/FileAPI/url/url_xmlhttprequest_img.html [ ImageOnlyFailure ] +# WPT: html +# = +Bug(WPE) imported/w3c/web-platform-tests/html/browsers [ Skip ] +Bug(WPE) imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ [ Skip ] +Bug(WPE) imported/w3c/web-platform-tests/html/semantics/forms/ [ Skip ] + +webkit.org/b/177322 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-dir
[webkit-changes] [225743] trunk/Source/WebCore
Title: [225743] trunk/Source/WebCore
Revision 225743
Author commit-qu...@webkit.org
Date 2017-12-11 09:38:57 -0800 (Mon, 11 Dec 2017)
Log Message
[WinCairo] DumpRenderTree times out for all non-http tests
https://bugs.webkit.org/show_bug.cgi?id=180571
Patch by Basuke Suzuki on 2017-12-11
Reviewed by Alex Christensen.
Bug fix on processing the curl event for file protocol.
No new tests. This fix is to run existing tests.
* platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::completeDidReceiveResponse):
* platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::isCompleted const):
(WebCore::CurlRequest::isCancelled const):
(WebCore::CurlRequest::isCompletedOrCancelled const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
trunk/Source/WebCore/platform/network/curl/CurlRequest.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (225742 => 225743)
--- trunk/Source/WebCore/ChangeLog 2017-12-11 10:16:55 UTC (rev 225742)
+++ trunk/Source/WebCore/ChangeLog 2017-12-11 17:38:57 UTC (rev 225743)
@@ -1,3 +1,21 @@
+2017-12-11 Basuke Suzuki
+
+[WinCairo] DumpRenderTree times out for all non-http tests
+https://bugs.webkit.org/show_bug.cgi?id=180571
+
+Reviewed by Alex Christensen.
+
+Bug fix on processing the curl event for file protocol.
+
+No new tests. This fix is to run existing tests.
+
+* platform/network/curl/CurlRequest.cpp:
+(WebCore::CurlRequest::completeDidReceiveResponse):
+* platform/network/curl/CurlRequest.h:
+(WebCore::CurlRequest::isCompleted const):
+(WebCore::CurlRequest::isCancelled const):
+(WebCore::CurlRequest::isCompletedOrCancelled const):
+
2017-12-11 Manuel Rego Casasnovas
REGRESSION(r221931): Row stretch doesn't work for grid container with min-height
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (225742 => 225743)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2017-12-11 10:16:55 UTC (rev 225742)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2017-12-11 17:38:57 UTC (rev 225743)
@@ -536,9 +536,12 @@
ASSERT(m_didNotifyResponse);
ASSERT(!m_didReturnFromNotify);
-if (isCompletedOrCancelled())
+if (isCancelled())
return;
+if (m_actionAfterInvoke != Action::StartTransfer && isCompleted())
+return;
+
m_didReturnFromNotify = true;
if (m_actionAfterInvoke == Action::ReceiveData) {
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.h (225742 => 225743)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.h 2017-12-11 10:16:55 UTC (rev 225742)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.h 2017-12-11 17:38:57 UTC (rev 225743)
@@ -60,7 +60,9 @@
void resume();
bool isSyncRequest() const { return m_isSyncRequest; }
-bool isCompletedOrCancelled() const { return !m_curlHandle || m_cancelled; }
+bool isCompleted() const { return !m_curlHandle; }
+bool isCancelled() const { return m_cancelled; }
+bool isCompletedOrCancelled() const { return isCompleted() || isCancelled(); }
// Processing for DidReceiveResponse
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225742] trunk
Title: [225742] trunk Revision 225742 Author zandober...@gmail.com Date 2017-12-11 02:16:55 -0800 (Mon, 11 Dec 2017) Log Message Unreviewed, rolling out r225737. Breaks Git clones of the repository, including EWSs and webkitbot. Reverted changeset: "Add a script to automate W3c web-platform-tests pull request creations from WebKit commits" https://bugs.webkit.org/show_bug.cgi?id=169462 https://trac.webkit.org/changeset/225737 Modified Paths trunk/LayoutTests/ChangeLog trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py trunk/Tools/Scripts/webkitpy/common/net/web.py trunk/Tools/Scripts/webkitpy/common/net/web_mock.py Removed Paths trunk/Tools/Scripts/export-w3c-test-changes trunk/Tools/Scripts/webkitpy/w3c/common.py trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py trunk/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py trunk/Tools/Scripts/webkitpy/w3c/wpt_github.py trunk/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py trunk/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py Diff Modified: trunk/LayoutTests/ChangeLog (225741 => 225742) --- trunk/LayoutTests/ChangeLog 2017-12-11 09:11:19 UTC (rev 225741) +++ trunk/LayoutTests/ChangeLog 2017-12-11 10:16:55 UTC (rev 225742) @@ -1,3 +1,16 @@ +2017-12-11 Zan Dobersek + +Unreviewed, rolling out r225737. + +Breaks Git clones of the repository, including EWSs and webkitbot. + +Reverted changeset: + +"Add a script to automate W3c web-platform-tests pull request +creations from WebKit commits" +https://bugs.webkit.org/show_bug.cgi?id=169462 +https://trac.webkit.org/changeset/225737 + 2017-12-11 Manuel Rego Casasnovas REGRESSION(r221931): Row stretch doesn't work for grid container with min-height Modified: trunk/Tools/ChangeLog (225741 => 225742) --- trunk/Tools/ChangeLog 2017-12-11 09:11:19 UTC (rev 225741) +++ trunk/Tools/ChangeLog 2017-12-11 10:16:55 UTC (rev 225742) @@ -1,3 +1,16 @@ +2017-12-11 Zan Dobersek + +Unreviewed, rolling out r225737. + +Breaks Git clones of the repository, including EWSs and webkitbot. + +Reverted changeset: + +"Add a script to automate W3c web-platform-tests pull request +creations from WebKit commits" +https://bugs.webkit.org/show_bug.cgi?id=169462 +https://trac.webkit.org/changeset/225737 + 2017-12-11 Carlos Garcia Campos [GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in tmp Deleted: trunk/Tools/Scripts/export-w3c-test-changes (225741 => 225742) --- trunk/Tools/Scripts/export-w3c-test-changes 2017-12-11 09:11:19 UTC (rev 225741) +++ trunk/Tools/Scripts/export-w3c-test-changes 2017-12-11 10:16:55 UTC (rev 225742) @@ -1,35 +0,0 @@ -#!/usr/bin/env python - -# Copyright (C) 2017 Apple Incorporated. All rights reserved. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: -# -# 1. Redistributions of source code must retain the above -#copyright notice, this list of conditions and the following -#disclaimer. -# 2. Redistributions in binary form must reproduce the above -#copyright notice, this list of conditions and the following -#disclaimer in the documentation and/or other materials -#provided with the distribution. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER "AS IS" AND ANY -# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE -# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR -# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE -# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, -# OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, -# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR -# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR -# TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF -# THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF -# SUCH DAMAGE. - -import sys - -from webkitpy.w3c import test_exporter - - -sys.exit(test_exporter.main(sys.argv[1:], sys.stdout, sys.stderr)) Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py (225741 => 225742) --- trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2017-12-11 09:11:19 UTC (rev 225741) +++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2017-12-11 10:16:55 UTC (rev 225742) @@ -29,6 +29,7 @@ import datetime import logging +import os import re from webkitpy.common.memoized import memoized @@ -36,7 +37,7 @@ from .commitmessage import CommitMessage from .scm import AuthenticationError, SCM, commit_error_handler -from .svn import SVNRepository +from .svn import SVN, SVNRepository _log = logging.getLogger(__name__) @@ -506,11 +507,11 @@ def deinit_submodules(self): return se
[webkit-changes] [225741] trunk
Title: [225741] trunk Revision 225741 Author r...@igalia.com Date 2017-12-11 01:11:19 -0800 (Mon, 11 Dec 2017) Log Message REGRESSION(r221931): Row stretch doesn't work for grid container with min-height https://bugs.webkit.org/show_bug.cgi?id=180287 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/css/css-grid/grid-model/grid-box-sizing-001-expected.txt: Update expectations as the test is now passing. Source/WebCore: In r221931 we moved the stretch phase as the last step of the track sizing algorithm. However this introduced a regression as we were no longer taking into account the grid container min-width|height constraints during this step. The CSS WG modified the spec so it now defines what to do in these situations (https://drafts.csswg.org/css-grid/#algo-stretch): "If the free space is indefinite, but the grid container has a definite min-width/height, use that size to calculate the free space for this step instead." This patch adds a new method GridTrackSizingAlgorithmStrategy::freeSpaceForStretchAutoTracksStep(). When we're in the DefiniteSizeStrategy it just returns the current free space. For the IndefiniteSizeStrategy in the columns case we don't need any special computation (the same that happens in recomputeUsedFlexFractionIfNeeded()); for rows it uses the min size of the grid container (respecting min-width|height properties) to calculate the free space. Test: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-stretch-respects-min-size-001.html * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::IndefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep const): (WebCore::DefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep const): (WebCore::GridTrackSizingAlgorithm::stretchAutoTracks): * rendering/GridTrackSizingAlgorithm.h: LayoutTests: * TestExpectations: Now layout-algorithm/grid-stretch-respects-min-size-001.html from WPT is passing, so this patch removes it from TestExpectations file. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-box-sizing-001-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h Diff Modified: trunk/LayoutTests/ChangeLog (225740 => 225741) --- trunk/LayoutTests/ChangeLog 2017-12-11 08:31:38 UTC (rev 225740) +++ trunk/LayoutTests/ChangeLog 2017-12-11 09:11:19 UTC (rev 225741) @@ -1,3 +1,13 @@ +2017-12-11 Manuel Rego Casasnovas + +REGRESSION(r221931): Row stretch doesn't work for grid container with min-height +https://bugs.webkit.org/show_bug.cgi?id=180287 + +Reviewed by Darin Adler. + +* TestExpectations: Now layout-algorithm/grid-stretch-respects-min-size-001.html +from WPT is passing, so this patch removes it from TestExpectations file. + 2017-12-10 Minsheng Liu Incorrect bounds inside / when a stretchy operator is present Modified: trunk/LayoutTests/TestExpectations (225740 => 225741) --- trunk/LayoutTests/TestExpectations 2017-12-11 08:31:38 UTC (rev 225740) +++ trunk/LayoutTests/TestExpectations 2017-12-11 09:11:19 UTC (rev 225741) @@ -479,7 +479,6 @@ webkit.org/b/165062 fast/css-grid-layout/grid-baseline-margins.html [ ImageOnlyFailure ] webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ] webkit.org/b/180283 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-017.html [ ImageOnlyFailure ] -webkit.org/b/180287 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-stretch-respects-min-size-001.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-001.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-002.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-003.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (225740 => 225741) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-11 08:31:38 UTC (rev 225740) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-11 09:11:19 UTC (rev 225741) @@ -1,3 +1,13 @@ +2017-12-11 Manuel Rego Casasnovas + +REGRESSION(r221931): Row stretch doesn't work for grid container with min-height +https://bugs.webkit.org/show_bug.cgi?id=180287 + +Reviewed by Darin Adler. + +* web-platform-tests/css/css-grid/grid-model/grid-box-sizing-001-expected.txt: +Update expectations as the test is now passing. + 2017-12-08 Chris Dumez ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL Modified: trunk/LayoutTests/impo
[webkit-changes] [225740] trunk/Tools
Title: [225740] trunk/Tools Revision 225740 Author carlo...@webkit.org Date 2017-12-11 00:31:38 -0800 (Mon, 11 Dec 2017) Log Message [GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in tmp https://bugs.webkit.org/show_bug.cgi?id=180426 Reviewed by Michael Catanzaro. This happens when running the tests with Xvfb driver, because _setup_environ_for_test() is called twice and the DTR temp directory is created there every time. Only the last directory created is cleaned up by the driver destructor. The DRT temp directory is only needed for layout tests, so we could even avoid its creation by moving it to the start() method like other drivers do (included the base driver implementation). Since API and WebDriver tests don't call start(), the directory is not even created, and the required env vars are not set either in that case. Weston driver was behaving differently for some reason, it's now consistent with all other drivers. * Scripts/webkitpy/port/headlessdriver.py: (HeadlessDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None. (HeadlessDriver._start): Use Port._driver_tempdir() to create the driver temp directory. * Scripts/webkitpy/port/waylanddriver.py: (WaylandDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None. (WaylandDriver._start): Use Port._driver_tempdir() to create the driver temp directory. * Scripts/webkitpy/port/westondriver.py: (WestonDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None. (WestonDriver._start): Use Port._driver_tempdir() to create the driver temp directory. (WestonDriver.stop): Do not delete the temp directory, it's done by the parent class. (WestonDriver._ensure_driver_tmpdir_subdirectory): Deleted. * Scripts/webkitpy/port/westondriver_unittest.py: (WestonDriverTest.make_driver): (WestonDriverTest.test_stop): * Scripts/webkitpy/port/xorgdriver.py: (XorgDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None. (XorgDriver._start): Use Port._driver_tempdir() to create the driver temp directory. * Scripts/webkitpy/port/xvfbdriver.py: (XvfbDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None. (XvfbDriver._start): Use Port._driver_tempdir() to create the driver temp directory. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/headlessdriver.py trunk/Tools/Scripts/webkitpy/port/waylanddriver.py trunk/Tools/Scripts/webkitpy/port/westondriver.py trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py trunk/Tools/Scripts/webkitpy/port/xorgdriver.py trunk/Tools/Scripts/webkitpy/port/xvfbdriver.py Diff Modified: trunk/Tools/ChangeLog (225739 => 225740) --- trunk/Tools/ChangeLog 2017-12-11 08:30:25 UTC (rev 225739) +++ trunk/Tools/ChangeLog 2017-12-11 08:31:38 UTC (rev 225740) @@ -1,3 +1,39 @@ +2017-12-11 Carlos Garcia Campos + +[GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in tmp +https://bugs.webkit.org/show_bug.cgi?id=180426 + +Reviewed by Michael Catanzaro. + +This happens when running the tests with Xvfb driver, because _setup_environ_for_test() is called twice and the +DTR temp directory is created there every time. Only the last directory created is cleaned up by the driver +destructor. The DRT temp directory is only needed for layout tests, so we could even avoid its creation by +moving it to the start() method like other drivers do (included the base driver implementation). Since API and +WebDriver tests don't call start(), the directory is not even created, and the required env vars are not set +either in that case. Weston driver was behaving differently for some reason, it's now consistent with all other +drivers. + +* Scripts/webkitpy/port/headlessdriver.py: +(HeadlessDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None. +(HeadlessDriver._start): Use Port._driver_tempdir() to create the driver temp directory. +* Scripts/webkitpy/port/waylanddriver.py: +(WaylandDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None. +(WaylandDriver._start): Use Port._driver_tempdir() to create the driver temp directory. +* Scripts/webkitpy/port/westondriver.py: +(WestonDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None. +(WestonDriver._start): Use Port._driver_tempdir() to create the driver temp directory. +(WestonDriver.stop): Do not delete the temp directory, it's done by the parent class. +(WestonDriver._ensure_driver_tmpdir_subdirectory): Deleted. +* Scripts/webkitpy/port/w
[webkit-changes] [225739] trunk/Source/WebDriver
Title: [225739] trunk/Source/WebDriver
Revision 225739
Author carlo...@webkit.org
Date 2017-12-11 00:30:25 -0800 (Mon, 11 Dec 2017)
Log Message
WebDriver: get active element should return no such element error when there isn't an active element
https://bugs.webkit.org/show_bug.cgi?id=180421
Reviewed by Brian Burg.
We currently return unknown error.
Fixes: imported/w3c/webdriver/tests/element_retrieval/get_active_element.py::test_missing_document_element
* Session.cpp:
(WebDriver::Session::getActiveElement):
Modified Paths
trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/Session.cpp
Diff
Modified: trunk/Source/WebDriver/ChangeLog (225738 => 225739)
--- trunk/Source/WebDriver/ChangeLog 2017-12-11 07:55:10 UTC (rev 225738)
+++ trunk/Source/WebDriver/ChangeLog 2017-12-11 08:30:25 UTC (rev 225739)
@@ -1,3 +1,17 @@
+2017-12-11 Carlos Garcia Campos
+
+WebDriver: get active element should return no such element error when there isn't an active element
+https://bugs.webkit.org/show_bug.cgi?id=180421
+
+Reviewed by Brian Burg.
+
+We currently return unknown error.
+
+Fixes: imported/w3c/webdriver/tests/element_retrieval/get_active_element.py::test_missing_document_element
+
+* Session.cpp:
+(WebDriver::Session::getActiveElement):
+
2017-12-04 Brian Burg
Web Automation: add flag to preserve legacy page screenshot behavior
Modified: trunk/Source/WebDriver/Session.cpp (225738 => 225739)
--- trunk/Source/WebDriver/Session.cpp 2017-12-11 07:55:10 UTC (rev 225738)
+++ trunk/Source/WebDriver/Session.cpp 2017-12-11 08:30:25 UTC (rev 225739)
@@ -996,7 +996,7 @@
}
RefPtr elementObject = createElement(WTFMove(resultValue));
if (!elementObject) {
-completionHandler(CommandResult::fail(CommandResult::ErrorCode::UnknownError));
+completionHandler(CommandResult::fail(CommandResult::ErrorCode::NoSuchElement));
return;
}
completionHandler(CommandResult::success(WTFMove(elementObject)));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
