[webkit-changes] [227267] trunk/WebDriverTests
Title: [227267] trunk/WebDriverTests Revision 227267 Author carlo...@webkit.org Date 2018-01-19 23:45:32 -0800 (Fri, 19 Jan 2018) Log Message Unreviewed GTK+ gardening. Skip imported/w3c/webdriver/tests/sessions/new_session/response.py. It's causing a crash in the driver process and affecting all other tests. * TestExpectations.json: Modified Paths trunk/WebDriverTests/ChangeLog trunk/WebDriverTests/TestExpectations.json Diff Modified: trunk/WebDriverTests/ChangeLog (227266 => 227267) --- trunk/WebDriverTests/ChangeLog 2018-01-20 07:24:50 UTC (rev 227266) +++ trunk/WebDriverTests/ChangeLog 2018-01-20 07:45:32 UTC (rev 227267) @@ -1,3 +1,11 @@ +2018-01-19 Carlos Garcia Campos+ +Unreviewed GTK+ gardening. Skip imported/w3c/webdriver/tests/sessions/new_session/response.py. + +It's causing a crash in the driver process and affecting all other tests. + +* TestExpectations.json: + 2018-01-18 Carlos Garcia Campos Unreviewed. Update Selenium WebDriver imported tests. Modified: trunk/WebDriverTests/TestExpectations.json (227266 => 227267) --- trunk/WebDriverTests/TestExpectations.json 2018-01-20 07:24:50 UTC (rev 227266) +++ trunk/WebDriverTests/TestExpectations.json 2018-01-20 07:45:32 UTC (rev 227267) @@ -353,6 +353,7 @@ } }, "imported/w3c/webdriver/tests/sessions/new_session/response.py": { +"expected": {"gtk": {"status": ["SKIP"], "bug": "webkit.org/b/181904"}}, "subtests": { "test_resp_capabilites": { "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180408"}} ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [227266] trunk/Source/WebCore
Title: [227266] trunk/Source/WebCore Revision 227266 Author wenson_hs...@apple.com Date 2018-01-19 23:24:50 -0800 (Fri, 19 Jan 2018) Log Message [macOS] [WK2] Drag location is computed incorrectly when dragging content from subframes https://bugs.webkit.org/show_bug.cgi?id=181896 Reviewed by Tim Horton. In r218837, I packaged most of the information needed to start a drag into DragItem, which is propagated to the client layer via the startDrag codepath. However, this introduced a bug in computing the event position and drag location in window coordinates. Consider the case where we're determining the drag image offset for a dragged element in a subframe: Before the patch, the drag location (which starts out in the subframe's content coordinates) would be converted to root view coordinates, which would then be converted to mainframe content coordinates, which would then be converted to window coordinates using the mainframe's view. After the patch, we carry out the same math until the last step, where we erroneously use the _subframe's_ view to convert to window coordinates from content coordinates. This results in the position of the iframe relative to the mainframe being accounted for twice. To fix this, we simply use the main frame's view to convert from mainframe content coordinates to window coordinates while computing the drag location. As for the event position in window coordinates, this is currently unused by any codepath in WebKit, so we can just remove it altogether. Since this bug only affects drag and drop in the macOS WebKit2 port, there's currently no way to test this. I'll be using to track adding test support for drag and drop on macOS WebKit2. Manually tested dragging in both WebKit1 and WebKit2 on macOS. dragLocationInWindowCoordinates isn't used at all for iOS drag and drop. * page/DragController.cpp: (WebCore::DragController::doSystemDrag): * platform/DragItem.h: (WebCore::DragItem::encode const): (WebCore::DragItem::decode): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/DragController.cpp trunk/Source/WebCore/platform/DragItem.h Diff Modified: trunk/Source/WebCore/ChangeLog (227265 => 227266) --- trunk/Source/WebCore/ChangeLog 2018-01-20 06:40:33 UTC (rev 227265) +++ trunk/Source/WebCore/ChangeLog 2018-01-20 07:24:50 UTC (rev 227266) @@ -1,3 +1,35 @@ +2018-01-19 Wenson Hsieh+ +[macOS] [WK2] Drag location is computed incorrectly when dragging content from subframes +https://bugs.webkit.org/show_bug.cgi?id=181896 + + +Reviewed by Tim Horton. + +In r218837, I packaged most of the information needed to start a drag into DragItem, which is propagated to the client layer +via the startDrag codepath. However, this introduced a bug in computing the event position and drag location in window +coordinates. Consider the case where we're determining the drag image offset for a dragged element in a subframe: + +Before the patch, the drag location (which starts out in the subframe's content coordinates) would be converted to root view +coordinates, which would then be converted to mainframe content coordinates, which would then be converted to window coordinates +using the mainframe's view. After the patch, we carry out the same math until the last step, where we erroneously use the +_subframe's_ view to convert to window coordinates from content coordinates. This results in the position of the iframe relative +to the mainframe being accounted for twice. + +To fix this, we simply use the main frame's view to convert from mainframe content coordinates to window coordinates while +computing the drag location. As for the event position in window coordinates, this is currently unused by any codepath in WebKit, +so we can just remove it altogether. + +Since this bug only affects drag and drop in the macOS WebKit2 port, there's currently no way to test this. I'll be using + to track adding test support for drag and drop on macOS WebKit2. Manually tested +dragging in both WebKit1 and WebKit2 on macOS. dragLocationInWindowCoordinates isn't used at all for iOS drag and drop. + +* page/DragController.cpp: +(WebCore::DragController::doSystemDrag): +* platform/DragItem.h: +(WebCore::DragItem::encode const): +(WebCore::DragItem::decode): + 2018-01-19 Ryan Haddad Unreviewed, rolling out r227235. Modified: trunk/Source/WebCore/page/DragController.cpp (227265 => 227266) --- trunk/Source/WebCore/page/DragController.cpp 2018-01-20 06:40:33 UTC (rev 227265) +++ trunk/Source/WebCore/page/DragController.cpp 2018-01-20 07:24:50 UTC (rev 227266) @@ -1227,8 +1227,7 @@ auto dragLocationInRootViewCoordinates = frame.view()->contentsToRootView(dragLoc); item.eventPositionInContentCoordinates =
[webkit-changes] [227265] trunk
Title: [227265] trunk Revision 227265 Author commit-qu...@webkit.org Date 2018-01-19 22:40:33 -0800 (Fri, 19 Jan 2018) Log Message Expose Safe Browsing SPI https://bugs.webkit.org/show_bug.cgi?id=181804 Patch by Zach Lion 2018-01-19 Reviewed by Dan Bernstein. If client is using Apple internal SDK, then we can just import the header; if not, then we declare necessary symbols that client will need. * Configurations/WebKit.xcconfig: Only link against SafariSafeBrowsing framework on macOS High Sierra and iOS 11 and above. Weak link against SafariSafeBrowsing framework because it is not present on the Base system. * Platform/spi/Cocoa/SafeBrowsingSPI.h: Added. * WebKit.xcodeproj/project.pbxproj: Added SafeBrowsingSPI.h. * WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/11/SafariSafeBrowsing.framework/SafariSafeBrowsing.tbd: Added. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/WebKit.xcconfig trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/11/SafariSafeBrowsing.framework/ trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/11/SafariSafeBrowsing.framework/SafariSafeBrowsing.tbd Diff Modified: trunk/Source/WebKit/ChangeLog (227264 => 227265) --- trunk/Source/WebKit/ChangeLog 2018-01-20 04:34:01 UTC (rev 227264) +++ trunk/Source/WebKit/ChangeLog 2018-01-20 06:40:33 UTC (rev 227265) @@ -1,3 +1,27 @@ +2018-01-19 Zach Li + +Expose Safe Browsing SPI +https://bugs.webkit.org/show_bug.cgi?id=181804 + + +Reviewed by Dan Bernstein. + +If client is using Apple internal SDK, then we can just import the header; if not, +then we declare necessary symbols that client will need. + +* Configurations/WebKit.xcconfig: +Only link against SafariSafeBrowsing framework on macOS High Sierra +and iOS 11 and above. Weak link against SafariSafeBrowsing framework +because it is not present on the Base system. + +* Platform/spi/Cocoa/SafeBrowsingSPI.h: Added. + +* WebKit.xcodeproj/project.pbxproj: +Added SafeBrowsingSPI.h. + +* WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/11/SafariSafeBrowsing.framework/SafariSafeBrowsing.tbd: +Added. + 2018-01-19 Ryan Haddad Unreviewed build fix, removed unused lambda capture. Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (227264 => 227265) --- trunk/Source/WebKit/Configurations/WebKit.xcconfig 2018-01-20 04:34:01 UTC (rev 227264) +++ trunk/Source/WebKit/Configurations/WebKit.xcconfig 2018-01-20 06:40:33 UTC (rev 227265) @@ -55,7 +55,7 @@ LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_NO = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks; LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR); -OTHER_LDFLAGS = $(inherited) -F"$(SDK_DIR)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks" $(UNEXPORTED_SYMBOL_LDFLAGS) $(ASAN_OTHER_LDFLAGS) $(FRAMEWORK_AND_LIBRARY_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS) $(WK_CORE_PREDICTION_LDFLAGS) -framework WebKitLegacy; +OTHER_LDFLAGS = $(inherited) -F"$(SDK_DIR)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks" $(UNEXPORTED_SYMBOL_LDFLAGS) $(ASAN_OTHER_LDFLAGS) $(FRAMEWORK_AND_LIBRARY_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS) $(WK_CORE_PREDICTION_LDFLAGS) -framework WebKitLegacy $(WK_SAFE_BROWSING_LDFLAGS); OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(LIBWEBRTC_LDFLAGS); OTHER_LDFLAGS_PLATFORM[sdk=iphoneos*] = -lAccessibility $(LIBWEBRTC_LDFLAGS); OTHER_LDFLAGS_PLATFORM[sdk=iphonesimulator*] = -lAccessibility $(LIBWEBRTC_LDFLAGS); @@ -86,3 +86,8 @@ WK_CORE_PREDICTION_LDFLAGS = $(WK_CORE_PREDICTION_LDFLAGS_$(WK_HAVE_CORE_PREDICTION)); WK_CORE_PREDICTION_LDFLAGS_YES = -framework CorePrediction; WK_CORE_PREDICTION_LDFLAGS_YES[sdk=macosx*] = -weak_framework CorePrediction; + +WK_SAFE_BROWSING_LDFLAGS[sdk=iphone*] = -framework SafariSafeBrowsing; +WK_SAFE_BROWSING_LDFLAGS[sdk=iphone*10.*] = ; +WK_SAFE_BROWSING_LDFLAGS[sdk=macosx*] = $(WK_SAFE_BROWSING_LDFLAGS$(WK_MACOS_1013)); +WK_SAFE_BROWSING_LDFLAGS_MACOS_SINCE_1013 = -weak_framework SafariSafeBrowsing; Added: trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h (0 => 227265) --- trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h (rev 0) +++ trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h 2018-01-20 06:40:33 UTC (rev 227265) @@ -0,0 +1,76 @@ +/* + * Copyright (C) 2018 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the
[webkit-changes] [227264] trunk/LayoutTests
Title: [227264] trunk/LayoutTests Revision 227264 Author ryanhad...@apple.com Date 2018-01-19 20:34:01 -0800 (Fri, 19 Jan 2018) Log Message Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=181901 Unreviewed test gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (227263 => 227264) --- trunk/LayoutTests/ChangeLog 2018-01-20 04:21:55 UTC (rev 227263) +++ trunk/LayoutTests/ChangeLog 2018-01-20 04:34:01 UTC (rev 227264) @@ -1,5 +1,14 @@ 2018-01-19 Ryan Haddad+Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=181901 + +Unreviewed test gardening. + +* TestExpectations: + +2018-01-19 Ryan Haddad + Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=181900 Modified: trunk/LayoutTests/TestExpectations (227263 => 227264) --- trunk/LayoutTests/TestExpectations 2018-01-20 04:21:55 UTC (rev 227263) +++ trunk/LayoutTests/TestExpectations 2018-01-20 04:34:01 UTC (rev 227264) @@ -178,7 +178,7 @@ imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.serviceworker.https.html [ Pass Failure ] imported/w3c/web-platform-tests/service-workers/service-worker/update.https.html [ Pass Failure ] -imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ DumpJSConsoleLogInStdErr ] +webkit.org/b/181901 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ Pass Failure ] webkit.org/b/181897 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ Pass Failure ] webkit.org/b/181900 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ Pass Failure ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html [ DumpJSConsoleLogInStdErr ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [227263] trunk/LayoutTests
Title: [227263] trunk/LayoutTests Revision 227263 Author ryanhad...@apple.com Date 2018-01-19 20:21:55 -0800 (Fri, 19 Jan 2018) Log Message Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=181900 Unreviewed test gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (227262 => 227263) --- trunk/LayoutTests/ChangeLog 2018-01-20 04:05:58 UTC (rev 227262) +++ trunk/LayoutTests/ChangeLog 2018-01-20 04:21:55 UTC (rev 227263) @@ -1,5 +1,14 @@ 2018-01-19 Ryan Haddad+Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=181900 + +Unreviewed test gardening. + +* TestExpectations: + +2018-01-19 Ryan Haddad + Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=181897 Modified: trunk/LayoutTests/TestExpectations (227262 => 227263) --- trunk/LayoutTests/TestExpectations 2018-01-20 04:05:58 UTC (rev 227262) +++ trunk/LayoutTests/TestExpectations 2018-01-20 04:21:55 UTC (rev 227263) @@ -180,7 +180,7 @@ imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ DumpJSConsoleLogInStdErr ] webkit.org/b/181897 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ Pass Failure ] -imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ DumpJSConsoleLogInStdErr ] +webkit.org/b/181900 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ Pass Failure ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html [ DumpJSConsoleLogInStdErr ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html [ Slow ] [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html [ Slow ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [227262] trunk/LayoutTests
Title: [227262] trunk/LayoutTests Revision 227262 Author ryanhad...@apple.com Date 2018-01-19 20:05:58 -0800 (Fri, 19 Jan 2018) Log Message Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=181897 Unreviewed test gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (227261 => 227262) --- trunk/LayoutTests/ChangeLog 2018-01-20 03:55:15 UTC (rev 227261) +++ trunk/LayoutTests/ChangeLog 2018-01-20 04:05:58 UTC (rev 227262) @@ -1,5 +1,14 @@ 2018-01-19 Ryan Haddad+Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=181897 + +Unreviewed test gardening. + +* TestExpectations: + +2018-01-19 Ryan Haddad + Unreviewed, rolling out r227235. The test for this change consistently times out on High Modified: trunk/LayoutTests/TestExpectations (227261 => 227262) --- trunk/LayoutTests/TestExpectations 2018-01-20 03:55:15 UTC (rev 227261) +++ trunk/LayoutTests/TestExpectations 2018-01-20 04:05:58 UTC (rev 227262) @@ -179,7 +179,7 @@ imported/w3c/web-platform-tests/service-workers/service-worker/update.https.html [ Pass Failure ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ DumpJSConsoleLogInStdErr ] -imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ DumpJSConsoleLogInStdErr ] +webkit.org/b/181897 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ Pass Failure ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ DumpJSConsoleLogInStdErr ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html [ DumpJSConsoleLogInStdErr ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html [ Slow ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [227261] trunk
Title: [227261] trunk Revision 227261 Author ryanhad...@apple.com Date 2018-01-19 19:55:15 -0800 (Fri, 19 Jan 2018) Log Message Unreviewed, rolling out r227235. The test for this change consistently times out on High Sierra. Reverted changeset: "Support for preconnect Link headers" https://bugs.webkit.org/show_bug.cgi?id=181657 https://trac.webkit.org/changeset/227235 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-simulator/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/LinkLoader.cpp trunk/Source/WebCore/loader/LinkLoader.h Removed Paths trunk/LayoutTests/http/tests/preconnect/link-header-rel-preconnect-http-expected.txt trunk/LayoutTests/http/tests/preconnect/link-header-rel-preconnect-http.html trunk/LayoutTests/http/tests/preconnect/resources/ Diff Modified: trunk/LayoutTests/ChangeLog (227260 => 227261) --- trunk/LayoutTests/ChangeLog 2018-01-20 03:50:34 UTC (rev 227260) +++ trunk/LayoutTests/ChangeLog 2018-01-20 03:55:15 UTC (rev 227261) @@ -1,3 +1,16 @@ +2018-01-19 Ryan Haddad+ +Unreviewed, rolling out r227235. + +The test for this change consistently times out on High +Sierra. + +Reverted changeset: + +"Support for preconnect Link headers" +https://bugs.webkit.org/show_bug.cgi?id=181657 +https://trac.webkit.org/changeset/227235 + 2018-01-19 Andy Estes [Sierra Debug WK2] ASSERTION FAILED: paymentCoordinator().supportsVersion(version) Deleted: trunk/LayoutTests/http/tests/preconnect/link-header-rel-preconnect-http-expected.txt (227260 => 227261) --- trunk/LayoutTests/http/tests/preconnect/link-header-rel-preconnect-http-expected.txt 2018-01-20 03:50:34 UTC (rev 227260) +++ trunk/LayoutTests/http/tests/preconnect/link-header-rel-preconnect-http-expected.txt 2018-01-20 03:55:15 UTC (rev 227261) @@ -1,10 +0,0 @@ -CONSOLE MESSAGE: Successfuly preconnected to http://localhost:8000/ -Tests that Link header's rel=preconnect works as expected over HTTP. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS successfullyParsed is true - -TEST COMPLETE - Deleted: trunk/LayoutTests/http/tests/preconnect/link-header-rel-preconnect-http.html (227260 => 227261) --- trunk/LayoutTests/http/tests/preconnect/link-header-rel-preconnect-http.html 2018-01-20 03:50:34 UTC (rev 227260) +++ trunk/LayoutTests/http/tests/preconnect/link-header-rel-preconnect-http.html 2018-01-20 03:55:15 UTC (rev 227261) @@ -1,23 +0,0 @@ - - - - - -