[webkit-changes] [240893] trunk/Source/JavaScriptCore
Title: [240893] trunk/Source/_javascript_Core Revision 240893 Author ysuz...@apple.com Date 2019-02-01 23:15:47 -0800 (Fri, 01 Feb 2019) Log Message [JSC] Decouple JIT related data from CodeBlock https://bugs.webkit.org/show_bug.cgi?id=194187 Patch by Yusuke Suzuki on 2019-02-01 Reviewed by Saam Barati. CodeBlock holds bunch of data which is only used after JIT starts compiling it. We have three types of data in CodeBlock. 1. The data which is always used. CodeBlock needs to hold it. 2. The data which is touched even in LLInt, but it is only meaningful in JIT tiers. The example is profiling. 3. The data which is used after the JIT compiler starts running for the given CodeBlock. This patch decouples (3) from CodeBlock as CodeBlock::JITData. Even if we have bunch of CodeBlocks, only small number of them gets JIT compilation. Always allocating (3) data enlarges the size of CodeBlock, leading to the memory waste. Potentially we can decouple (2) in another data structure, but we first do (3) since (3) is beneficial in both non-JIT and *JIT* modes. JITData is created only when JIT compiler wants to use it. So it can be concurrently created and used, so it is guarded by the lock of CodeBlock. The size of CodeBlock is reduced from 512 to 352. This patch improves memory footprint and gets 1.1% improvement in RAMification. Footprint geomean: 36696503 (34.997 MB) Peak Footprint geomean: 38595988 (36.808 MB) Score: 37634263 (35.891 MB) Footprint geomean: 37172768 (35.451 MB) Peak Footprint geomean: 38978288 (37.173 MB) Score: 38064824 (36.301 MB) * bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::propagateTransitions): (JSC::CodeBlock::ensureJITDataSlow): (JSC::CodeBlock::finalizeBaselineJITInlineCaches): (JSC::CodeBlock::getICStatusMap): (JSC::CodeBlock::addStubInfo): (JSC::CodeBlock::addJITAddIC): (JSC::CodeBlock::addJITMulIC): (JSC::CodeBlock::addJITSubIC): (JSC::CodeBlock::addJITNegIC): (JSC::CodeBlock::findStubInfo): (JSC::CodeBlock::addByValInfo): (JSC::CodeBlock::addCallLinkInfo): (JSC::CodeBlock::getCallLinkInfoForBytecodeIndex): (JSC::CodeBlock::addRareCaseProfile): (JSC::CodeBlock::rareCaseProfileForBytecodeOffset): (JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset): (JSC::CodeBlock::resetJITData): (JSC::CodeBlock::stronglyVisitStrongReferences): (JSC::CodeBlock::shrinkToFit): (JSC::CodeBlock::linkIncomingCall): (JSC::CodeBlock::linkIncomingPolymorphicCall): (JSC::CodeBlock::unlinkIncomingCalls): (JSC::CodeBlock::updateAllPredictionsAndCountLiveness): (JSC::CodeBlock::dumpValueProfiles): (JSC::CodeBlock::setPCToCodeOriginMap): (JSC::CodeBlock::findPC): (JSC::CodeBlock::dumpMathICStats): * bytecode/CodeBlock.h: (JSC::CodeBlock::ensureJITData): (JSC::CodeBlock::setJITCodeMap): (JSC::CodeBlock::jitCodeMap): (JSC::CodeBlock::likelyToTakeSlowCase): (JSC::CodeBlock::couldTakeSlowCase): (JSC::CodeBlock::lazyOperandValueProfiles): (JSC::CodeBlock::stubInfoBegin): Deleted. (JSC::CodeBlock::stubInfoEnd): Deleted. (JSC::CodeBlock::callLinkInfosBegin): Deleted. (JSC::CodeBlock::callLinkInfosEnd): Deleted. (JSC::CodeBlock::jitCodeMap const): Deleted. (JSC::CodeBlock::numberOfRareCaseProfiles): Deleted. * bytecode/MethodOfGettingAValueProfile.cpp: (JSC::MethodOfGettingAValueProfile::emitReportValue const): (JSC::MethodOfGettingAValueProfile::reportValue): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): * jit/JIT.h: * jit/JITOperations.cpp: (JSC::tryGetByValOptimize): * jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByVal): (JSC::JIT::privateCompilePutByVal): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecode/CodeBlock.h trunk/Source/_javascript_Core/bytecode/MethodOfGettingAValueProfile.cpp trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/jit/JIT.h trunk/Source/_javascript_Core/jit/JITOperations.cpp trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (240892 => 240893) --- trunk/Source/_javascript_Core/ChangeLog 2019-02-02 04:05:55 UTC (rev 240892) +++ trunk/Source/_javascript_Core/ChangeLog 2019-02-02 07:15:47 UTC (rev 240893) @@ -1,3 +1,91 @@ +2019-02-01 Yusuke Suzuki + +[JSC] Decouple JIT related data from CodeBlock +https://bugs.webkit.org/show_bug.cgi?id=194187 + +Reviewed by Saam Barati. + +CodeBlock holds bunch of data which is only used after JIT starts compiling it. +We have three types of data in CodeBlock. + +1. The data which is always used. CodeBlock needs to hold it. +2. The data which is touched even in LLInt, but it is only meaningful in JIT tiers. The example is profiling. +3. The data which is used after the JIT compiler starts running for the given CodeBlock. + +This patch decouples (3) from CodeBlock as CodeB
[webkit-changes] [240892] trunk
Title: [240892] trunk
Revision 240892
Author da...@apple.com
Date 2019-02-01 20:05:55 -0800 (Fri, 01 Feb 2019)
Log Message
Convert additional String::format clients to alternative approaches
https://bugs.webkit.org/show_bug.cgi?id=192746
Reviewed by Alexey Proskuryakov.
Source/_javascript_Core:
* inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::stopTiming): Use makeString
and FormattedNumber::fixedWidth.
Source/WebCore:
This round of conversions covers less-trivial cases such as floating
point numerals and hexadecimal. Not yet taking on pointer serialization
("%p") or padding with spaces of zero digits, so call sites using those
have been left untouched.
In some cases these new idioms are a bit clumsy, and we could follow up
with additional convenience functions to make them more elegant.
* Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString const): Use more ASCIILiteral and
more appendLiteral for efficiency. Use upperNibbleToLowercaseASCIIHexDigit,
lowerNibbleToLowercaseASCIIHexDigit, and also makeString and FormattedNumber.
* css/MediaQueryEvaluator.cpp:
(WebCore::aspectRatioValueAsString): Use makeString and FormattedNumber.
Doing it this way makes it a little clearer that we have an unpleasant
use of fixed 6-digit precision here.
* html/FTPDirectoryDocument.cpp:
(WebCore::processFilesizeString): Use makeString and FormattedNumber.
* html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties): Ditto.
* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::windowRoundedCornerRadiusCSS const): Ditto.
* page/History.cpp:
(WebCore::History::stateObjectAdded): Ditto.
* page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::formatByteNumber): Ditto.
(WebCore::gcTimerString): Use String::number.
(WebCore::ResourceUsageOverlay::platformDraw): Use makeString and FormattedNumber.
* page/scrolling/AxisScrollSnapOffsets.cpp:
(WebCore::snapOffsetsToString): Removed some unnecessary copying in the for loop,
use appendLiteral, and use appendFixedWidthNumber.
(WebCore::snapOffsetRangesToString): Ditto.
(WebCore::snapPortOrAreaToString): Use makeString and FormattedNumber.
* platform/animation/TimingFunction.cpp:
(WebCore::TimingFunction::cssText const): Use makeString.
* platform/cocoa/KeyEventCocoa.mm:
(WebCore::keyIdentifierForCharCode): Use makeString and the ASCIIHexDigit
functions.
* platform/graphics/Color.cpp:
(WebCore::Color::nameForRenderTreeAsText const): Ditto.
* platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::drawText): Use makeString and FormattedNumber.
* platform/text/PlatformLocale.cpp:
(WebCore::DateTimeStringBuilder::visitField): Use String::numberToStringFixedWidth.
Source/WebCore/PAL:
* pal/FileSizeFormatter.cpp:
(fileSizeDescription): Use makeString and FormattedNumber.
Source/WebKit:
* UIProcess/Cocoa/ViewGestureController.cpp:
(WebKit::ViewGestureController::SnapshotRemovalTracker::startWatchdog):
Use makeString and FormattedNumber.
* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::getAssertion): Added a comment about an
incorrect format specifier and left this code as is for now.
Source/WTF:
* wtf/JSONValues.cpp:
(WTF::appendDoubleQuotedStringEscapedCharacter): Renamed from
escapeChar and reordered arguments to make sense as an append function.
(WTF::appendDoubleQuotedString): Renamed from doubleQuoteString,
reordered arguments to make sense as an append function, take a
StringView instead of a String, used early exit to make the code
a bit easier to read. Use the ASCIIHexDigit functions to construct
a hex number a nibble at a time rather than using String::format.
(WTF::JSONImpl::Value::writeJSON const): Update for name change.
(WTF::JSONImpl::ObjectBase::writeJSON const): Ditto.
Tools:
* WebKitTestRunner/TestController.cpp:
(WTR::originUserVisibleName): Use makeString and reduce the use of std::string
as an intermediate in code that ultimately constructs a WTF::String.
(WTR::userMediaOriginHash): Use makeString.
(WTR::TestController::didNavigateWithNavigationData): More of the same.
(WTR::TestController::didPerformClientRedirect): Ditto.
(WTR::TestController::didPerformServerRedirect): Ditto.
(WTR::TestController::didUpdateHistoryTitle): Ditto.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/agents/InspectorConsoleAgent.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/JSONValues.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/FileSizeFormatter.cpp
trunk/Source/WebCore/css/MediaQueryEvaluator.cpp
trunk/Source/WebCore/html/FTPDirectoryDocument.cpp
trunk/Source/WebCore/html/track/VTTCue.cpp
trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
trunk/Source/WebCore/page/History.cpp
trunk/Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm
trunk/Source/WebCore/pa
[webkit-changes] [240891] trunk/Source/WebCore
Title: [240891] trunk/Source/WebCore
Revision 240891
Author simon.fra...@apple.com
Date 2019-02-01 18:30:53 -0800 (Fri, 01 Feb 2019)
Log Message
Remove the unused layerForScrolling()
https://bugs.webkit.org/show_bug.cgi?id=194180
Reviewed by Zalan Bujtas.
Remove ScrollableArea::layerForScrolling() and derivations. This was unused.
* page/FrameView.cpp:
(WebCore::FrameView::layerForScrolling const): Deleted.
* page/FrameView.h:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea): Deleted.
* page/scrolling/ScrollingCoordinator.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::layerForScrolling const): Deleted.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderLayer.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (240890 => 240891)
--- trunk/Source/WebCore/ChangeLog 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/ChangeLog 2019-02-02 02:30:53 UTC (rev 240891)
@@ -1,3 +1,24 @@
+2019-02-01 Simon Fraser
+
+Remove the unused layerForScrolling()
+https://bugs.webkit.org/show_bug.cgi?id=194180
+
+Reviewed by Zalan Bujtas.
+
+Remove ScrollableArea::layerForScrolling() and derivations. This was unused.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::layerForScrolling const): Deleted.
+* page/FrameView.h:
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea): Deleted.
+* page/scrolling/ScrollingCoordinator.h:
+* platform/ScrollableArea.h:
+(WebCore::ScrollableArea::layerForScrolling const): Deleted.
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::calculateClipRects const):
+* rendering/RenderLayer.h:
+
2019-02-01 Zalan Bujtas
[LFC] Fix statically positioned replaced out-of-flow horizontal geometry
Modified: trunk/Source/WebCore/page/FrameView.cpp (240890 => 240891)
--- trunk/Source/WebCore/page/FrameView.cpp 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/page/FrameView.cpp 2019-02-02 02:30:53 UTC (rev 240891)
@@ -848,14 +848,6 @@
renderView->compositor().updateCompositingLayers(CompositingUpdateType::AfterLayout);
}
-GraphicsLayer* FrameView::layerForScrolling() const
-{
-RenderView* renderView = this->renderView();
-if (!renderView)
-return nullptr;
-return renderView->compositor().scrollLayer();
-}
-
GraphicsLayer* FrameView::layerForHorizontalScrollbar() const
{
RenderView* renderView = this->renderView();
Modified: trunk/Source/WebCore/page/FrameView.h (240890 => 240891)
--- trunk/Source/WebCore/page/FrameView.h 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/page/FrameView.h 2019-02-02 02:30:53 UTC (rev 240891)
@@ -729,7 +729,6 @@
ScrollableArea* enclosingScrollableArea() const final;
IntRect scrollableAreaBoundingBox(bool* = nullptr) const final;
bool scrollAnimatorEnabled() const final;
-GraphicsLayer* layerForScrolling() const final;
GraphicsLayer* layerForScrollCorner() const final;
#if ENABLE(RUBBER_BANDING)
GraphicsLayer* layerForOverhangAreas() const final;
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (240890 => 240891)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2019-02-02 02:30:53 UTC (rev 240891)
@@ -224,11 +224,6 @@
updateSynchronousScrollingReasons(frameView);
}
-GraphicsLayer* ScrollingCoordinator::scrollLayerForScrollableArea(ScrollableArea& scrollableArea)
-{
-return scrollableArea.layerForScrolling();
-}
-
GraphicsLayer* ScrollingCoordinator::scrollLayerForFrameView(FrameView& frameView)
{
if (auto* renderView = frameView.frame().contentRenderer())
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h (240890 => 240891)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h 2019-02-02 02:30:53 UTC (rev 240891)
@@ -192,8 +192,6 @@
protected:
explicit ScrollingCoordinator(Page*);
-static GraphicsLayer* scrollLayerForScrollableArea(ScrollableArea&);
-
GraphicsLayer* scrollLayerForFrameView(FrameView&);
GraphicsLayer* counterScrollingLayerForFrameView(FrameView&);
GraphicsLayer* insetClipLayerForFrameView(FrameView&);
Modified: trunk/Source/WebCore/platform/ScrollableArea.h
[webkit-changes] [240890] trunk/Tools
Title: [240890] trunk/Tools
Revision 240890
Author aakash_j...@apple.com
Date 2019-02-01 18:19:43 -0800 (Fri, 01 Feb 2019)
Log Message
[ews-build] Add unit test to verify builder keys
https://bugs.webkit.org/show_bug.cgi?id=194152
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-build/loadConfig_unittest.py:
(ConfigDotJSONTest.test_builder_keys): Added unit-test.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py (240889 => 240890)
--- trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py 2019-02-02 00:45:51 UTC (rev 240889)
+++ trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py 2019-02-02 02:19:43 UTC (rev 240890)
@@ -23,6 +23,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import json
import os
import unittest
@@ -34,7 +35,17 @@
cwd = os.path.dirname(os.path.abspath(__file__))
loadConfig.loadBuilderConfig({}, master_prefix_path=cwd)
+def test_builder_keys(self):
+cwd = os.path.dirname(os.path.abspath(__file__))
+config = json.load(open(os.path.join(cwd, 'config.json')))
+valid_builder_keys = ['additionalArguments', 'architectures', 'builddir', 'configuration', 'description',
+ 'defaultProperties', 'env', 'factory', 'locks', 'name', 'platform', 'properties', 'tags',
+ 'triggers', 'workernames', 'workerbuilddir']
+for builder in config.get('builders', []):
+for key in builder:
+self.assertTrue(key in valid_builder_keys, 'Unexpected key {} for builder {}'.format(key, builder.get('name')))
+
class TagsForBuilderTeest(unittest.TestCase):
def verifyTags(self, builderName, expectedTags):
tags = loadConfig.getTagsForBuilder({'name': builderName})
Modified: trunk/Tools/ChangeLog (240889 => 240890)
--- trunk/Tools/ChangeLog 2019-02-02 00:45:51 UTC (rev 240889)
+++ trunk/Tools/ChangeLog 2019-02-02 02:19:43 UTC (rev 240890)
@@ -1,3 +1,13 @@
+2019-02-01 Aakash Jain
+
+[ews-build] Add unit test to verify builder keys
+https://bugs.webkit.org/show_bug.cgi?id=194152
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-build/loadConfig_unittest.py:
+(ConfigDotJSONTest.test_builder_keys): Added unit-test.
+
2019-02-01 Zalan Bujtas
[LFC] Expand tests coverage (12 new tests -> 787)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240889] trunk/Source
Title: [240889] trunk/Source
Revision 240889
Author ddkil...@apple.com
Date 2019-02-01 16:45:51 -0800 (Fri, 01 Feb 2019)
Log Message
Move soft-linking of TelephonyUtilities.framework out of TUCallSPI.h
Reviewed by Alex Christensen.
Source/WebCore/PAL:
* PAL.xcodeproj/project.pbxproj:
* pal/PlatformMac.cmake:
- Update for rename of TUCallSPI.h to TelephonyUtilitiesSPI.h.
* pal/spi/mac/TelephonyUtilitiesSPI.h: Rename from Source/WebCore/PAL/pal/spi/mac/TUCallSPI.h.
- Remove soft-linking code from header.
Source/WebKit:
* Platform/mac/MenuUtilities.mm:
- Update for rename of TUCallSPI.h to TelephonyUtilitiesSPI.h.
- Add soft-linking code formerly in TUCallSPI.h.
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/PAL/pal/PlatformMac.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/mac/MenuUtilities.mm
Added Paths
trunk/Source/WebCore/PAL/pal/spi/mac/TelephonyUtilitiesSPI.h
Removed Paths
trunk/Source/WebCore/PAL/pal/spi/mac/TUCallSPI.h
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (240888 => 240889)
--- trunk/Source/WebCore/PAL/ChangeLog 2019-02-02 00:24:47 UTC (rev 240888)
+++ trunk/Source/WebCore/PAL/ChangeLog 2019-02-02 00:45:51 UTC (rev 240889)
@@ -1,3 +1,17 @@
+2019-02-01 David Kilzer
+
+Move soft-linking of TelephonyUtilities.framework out of TUCallSPI.h
+
+
+Reviewed by Alex Christensen.
+
+* PAL.xcodeproj/project.pbxproj:
+* pal/PlatformMac.cmake:
+- Update for rename of TUCallSPI.h to TelephonyUtilitiesSPI.h.
+
+* pal/spi/mac/TelephonyUtilitiesSPI.h: Rename from Source/WebCore/PAL/pal/spi/mac/TUCallSPI.h.
+- Remove soft-linking code from header.
+
2019-01-30 Daniel Bates
[iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (240888 => 240889)
--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2019-02-02 00:24:47 UTC (rev 240888)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2019-02-02 00:45:51 UTC (rev 240889)
@@ -96,7 +96,7 @@
0C77859E1F45130F00F4EBB6 /* PIPSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 0C7785851F45130F00F4EBB6 /* PIPSPI.h */; };
0C77859F1F45130F00F4EBB6 /* QTKitSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 0C7785861F45130F00F4EBB6 /* QTKitSPI.h */; };
0C7785A01F45130F00F4EBB6 /* QuickLookMacSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 0C7785871F45130F00F4EBB6 /* QuickLookMacSPI.h */; };
- 0C7785A11F45130F00F4EBB6 /* TUCallSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 0C7785881F45130F00F4EBB6 /* TUCallSPI.h */; };
+ 0C7785A11F45130F00F4EBB6 /* TelephonyUtilitiesSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 0C7785881F45130F00F4EBB6 /* TelephonyUtilitiesSPI.h */; };
0CF99CA41F736375007EE793 /* MediaTimeAVFoundation.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0C00CFD11F68CE4600AAC26D /* MediaTimeAVFoundation.cpp */; };
0CF99CA81F738437007EE793 /* CoreMediaSoftLink.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0CF99CA61F738436007EE793 /* CoreMediaSoftLink.cpp */; };
0CF99CA91F738437007EE793 /* CoreMediaSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 0CF99CA71F738437007EE793 /* CoreMediaSoftLink.h */; };
@@ -250,7 +250,7 @@
0C7785851F45130F00F4EBB6 /* PIPSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PIPSPI.h; sourceTree = ""; };
0C7785861F45130F00F4EBB6 /* QTKitSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QTKitSPI.h; sourceTree = ""; };
0C7785871F45130F00F4EBB6 /* QuickLookMacSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QuickLookMacSPI.h; sourceTree = ""; };
- 0C7785881F45130F00F4EBB6 /* TUCallSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TUCallSPI.h; sourceTree = ""; };
+ 0C7785881F45130F00F4EBB6 /* TelephonyUtilitiesSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TelephonyUtilitiesSPI.h; sourceTree = ""; };
0CF99CA61F738436007EE793 /* CoreMediaSoftLink.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CoreMediaSoftLink.cpp; sourceTree = ""; };
0CF99CA71F738437007EE793 /* CoreMediaSoftLink.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CoreMediaSoftLink.h; sourceTree = ""; };
1C09D03D1E31C32800725F18 /* libPAL.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libPAL.a; sourceTree = BUILT_PRODUCTS_DIR; };
@@ -481,7 +481,7 @@
A102658A1F56748C00B4C844 /* QuickDrawSPI.h */,
0C7785871F45130F00F4EBB6 /* QuickLookMacSPI.h */,
A1175B481F6AFF8E00C4B9F0 /* SpeechSynt
[webkit-changes] [240888] trunk/Source/JavaScriptCore
Title: [240888] trunk/Source/_javascript_Core
Revision 240888
Author ysuz...@apple.com
Date 2019-02-01 16:24:47 -0800 (Fri, 01 Feb 2019)
Log Message
[JSC] Remove some of IsoSubspaces for JSFunction subclasses
https://bugs.webkit.org/show_bug.cgi?id=194177
Reviewed by Saam Barati.
JSGeneratorFunction, JSAsyncFunction, and JSAsyncGeneratorFunction do not add any fields / classInfo methods.
We can share the IsoSubspace for JSFunction.
* runtime/JSAsyncFunction.h:
* runtime/JSAsyncGeneratorFunction.h:
* runtime/JSGeneratorFunction.h:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSAsyncFunction.h
trunk/Source/_javascript_Core/runtime/JSAsyncGeneratorFunction.h
trunk/Source/_javascript_Core/runtime/JSGeneratorFunction.h
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240887 => 240888)
--- trunk/Source/_javascript_Core/ChangeLog 2019-02-01 23:59:56 UTC (rev 240887)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-02-02 00:24:47 UTC (rev 240888)
@@ -1,3 +1,20 @@
+2019-02-01 Yusuke Suzuki
+
+[JSC] Remove some of IsoSubspaces for JSFunction subclasses
+https://bugs.webkit.org/show_bug.cgi?id=194177
+
+Reviewed by Saam Barati.
+
+JSGeneratorFunction, JSAsyncFunction, and JSAsyncGeneratorFunction do not add any fields / classInfo methods.
+We can share the IsoSubspace for JSFunction.
+
+* runtime/JSAsyncFunction.h:
+* runtime/JSAsyncGeneratorFunction.h:
+* runtime/JSGeneratorFunction.h:
+* runtime/VM.cpp:
+(JSC::VM::VM):
+* runtime/VM.h:
+
2019-02-01 Mark Lam
Remove invalid assertion in DFG's compileDoubleRep().
Modified: trunk/Source/_javascript_Core/runtime/JSAsyncFunction.h (240887 => 240888)
--- trunk/Source/_javascript_Core/runtime/JSAsyncFunction.h 2019-02-01 23:59:56 UTC (rev 240887)
+++ trunk/Source/_javascript_Core/runtime/JSAsyncFunction.h 2019-02-02 00:24:47 UTC (rev 240888)
@@ -41,7 +41,7 @@
template
static IsoSubspace* subspaceFor(VM& vm)
{
-return &vm.asyncFunctionSpace;
+return &vm.functionSpace;
}
DECLARE_EXPORT_INFO;
@@ -67,5 +67,6 @@
static JSAsyncFunction* createImpl(VM&, FunctionExecutable*, JSScope*, Structure*);
};
+static_assert(sizeof(JSAsyncFunction) == sizeof(JSFunction), "Some subclasses of JSFunction should be the same size to share IsoSubspace");
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/JSAsyncGeneratorFunction.h (240887 => 240888)
--- trunk/Source/_javascript_Core/runtime/JSAsyncGeneratorFunction.h 2019-02-01 23:59:56 UTC (rev 240887)
+++ trunk/Source/_javascript_Core/runtime/JSAsyncGeneratorFunction.h 2019-02-02 00:24:47 UTC (rev 240888)
@@ -41,7 +41,7 @@
template
static IsoSubspace* subspaceFor(VM& vm)
{
-return &vm.asyncGeneratorFunctionSpace;
+return &vm.functionSpace;
}
DECLARE_EXPORT_INFO;
@@ -80,5 +80,6 @@
static JSAsyncGeneratorFunction* createImpl(VM&, FunctionExecutable*, JSScope*, Structure*);
};
+static_assert(sizeof(JSAsyncGeneratorFunction) == sizeof(JSFunction), "Some subclasses of JSFunction should be the same size to share IsoSubspace");
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/JSGeneratorFunction.h (240887 => 240888)
--- trunk/Source/_javascript_Core/runtime/JSGeneratorFunction.h 2019-02-01 23:59:56 UTC (rev 240887)
+++ trunk/Source/_javascript_Core/runtime/JSGeneratorFunction.h 2019-02-02 00:24:47 UTC (rev 240888)
@@ -69,7 +69,7 @@
template
static IsoSubspace* subspaceFor(VM& vm)
{
-return &vm.generatorFunctionSpace;
+return &vm.functionSpace;
}
DECLARE_EXPORT_INFO;
@@ -97,5 +97,6 @@
friend class LLIntOffsetsExtractor;
};
+static_assert(sizeof(JSGeneratorFunction) == sizeof(JSFunction), "Some subclasses of JSFunction should be the same size to share IsoSubspace");
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (240887 => 240888)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2019-02-01 23:59:56 UTC (rev 240887)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2019-02-02 00:24:47 UTC (rev 240888)
@@ -287,14 +287,11 @@
, destructibleObjectSpace("JSDestructibleObject", heap, destructibleObjectHeapCellType.get(), fastMallocAllocator.get())
, eagerlySweptDestructibleObjectSpace("Eagerly Swept JSDestructibleObject", heap, destructibleObjectHeapCellType.get(), fastMallocAllocator.get())
, segmentedVariableObjectSpace("JSSegmentedVariableObjectSpace", heap, segmentedVariableObjectHeapCellType.get(), fastMallocAllocator.get())
-, asyncFunctionSpace ISO_SUBSPACE_INIT(heap, cellHeapCellType.get(), JSAsyncFunction)
-, asyncGeneratorFunctionSpace ISO_SUBSPACE_INIT(heap, cellHeapCellType.get(), JS
[webkit-changes] [240887] trunk/Tools
Title: [240887] trunk/Tools Revision 240887 Author za...@apple.com Date 2019-02-01 15:59:56 -0800 (Fri, 01 Feb 2019) Log Message [LFC] Expand tests coverage (12 new tests -> 787) Unreviewed test gardening. * LayoutReloaded/misc/LFC-passing-tests.txt: Modified Paths trunk/Tools/ChangeLog trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt Diff Modified: trunk/Tools/ChangeLog (240886 => 240887) --- trunk/Tools/ChangeLog 2019-02-01 23:54:22 UTC (rev 240886) +++ trunk/Tools/ChangeLog 2019-02-01 23:59:56 UTC (rev 240887) @@ -1,5 +1,13 @@ 2019-02-01 Zalan Bujtas +[LFC] Expand tests coverage (12 new tests -> 787) + +Unreviewed test gardening. + +* LayoutReloaded/misc/LFC-passing-tests.txt: + +2019-02-01 Zalan Bujtas + [LFC] Fix statically positioned replaced out-of-flow horizontal geometry https://bugs.webkit.org/show_bug.cgi?id=194163 Modified: trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt (240886 => 240887) --- trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt 2019-02-01 23:54:22 UTC (rev 240886) +++ trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt 2019-02-01 23:59:56 UTC (rev 240887) @@ -1,3 +1,6 @@ +fast/block/float/001.html +fast/block/block-only/abs-pos-with-border-padding-and-float-child.html +fast/block/inside-inlines/basic-float-intrusion.html fast/block/block-only/absolute-auto-with-sibling-margin-bottom.html fast/block/block-only/absolute-height-stretch.html fast/block/block-only/absolute-left-auto.html @@ -8,6 +11,8 @@ fast/block/block-only/absolute-position-min-max-width.html fast/block/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context2.html fast/block/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context.html +fast/block/block-only/absolute-position-with-margin-auto-simple2.html +fast/block/block-only/absolute-position-with-margin-auto-simple.html fast/block/block-only/absolute-simple.html fast/block/block-only/absolute-width-shrink-to-fit.html fast/block/block-only/absolute-width-stretch.html @@ -18,14 +23,26 @@ fast/block/block-only/body-height-with-non-auto-html-height-quirk2.html fast/block/block-only/body-height-with-non-auto-html-height-quirk.html fast/block/block-only/border-simple.html +fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html fast/block/block-only/collapsed-margin-with-min-height.html +fast/block/block-only/collapsed-through-siblings.html +fast/block/block-only/collapsed-through-with-parent.html +fast/block/basic/002.html fast/block/block-only/fixed-nested.html +fast/block/basic/003.html +fast/block/float/003.html fast/block/block-only/float-and-siblings-with-margins.html +fast/block/basic/004.html fast/block/block-only/float-avoider-multiple-roots.html +fast/block/basic/005.html fast/block/block-only/float-avoider-simple-left.html +fast/block/basic/006.html fast/block/block-only/float-avoider-simple-right.html +fast/block/basic/007.html fast/block/block-only/float-avoider-with-margins.html +fast/block/basic/008.html fast/block/block-only/float-left-when-container-has-padding-margin.html +fast/block/basic/009.html fast/block/block-only/float-min-max-height.html fast/block/block-only/float-min-max-width.html fast/block/block-only/floating-and-next-previous-inflow-with-margin-with-no-border.html @@ -63,10 +80,12 @@ fast/block/block-only/margin-propagation-simple-content-height.html fast/block/block-only/margin-sibling-collapse-propagated.html fast/block/block-only/margin-simple.html -fast/block/block-only/collapsed-through-siblings.html -fast/block/block-only/collapsed-through-with-parent.html fast/block/block-only/min-max-height-percentage.html fast/block/block-only/negative-margin-simple.html +fast/block/block-only/non-auto-top-bottom-height-with-auto-margins.html +fast/block/block-only/non-auto-top-bottom-height-with-margins.html +fast/block/block-only/non-auto-top-bottom-left-right-widht-height-out-of-flow.html +fast/block/block-only/out-of-flow-with-containing-block-border-padding.html fast/block/block-only/padding-nested.html fast/block/block-only/padding-simple.html fast/block/block-only/relative-auto-with-parent-offset.html @@ -76,83 +95,28 @@ fast/block/block-only/relative-right.html fast/block/block-only/relative-siblings.html fast/block/block-only/relative-simple.html -fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html -fast/block/block-only/out-of-flow-with-containing-block-border-padding.html -fast/block/block-only/non-auto-top-bottom-left-right-widht-height-out-of-flow.html -fast/block/block-only/non-auto-top-bottom-height-with-margins.html -fast/block/block-only/non-auto-top-bottom-height-with-auto-margins.html -fast/block/block-only/abs-pos-with-border-padding-and-float-child-expected.html -fast/block/block-only/absolute-position-with-margin-auto-simple.html -fast/block/block-only/absolute-position-with-margin-auto-simple2.html -fast/block/basic/002.ht
[webkit-changes] [240886] trunk
Title: [240886] trunk
Revision 240886
Author za...@apple.com
Date 2019-02-01 15:54:22 -0800 (Fri, 01 Feb 2019)
Log Message
[LFC] Fix statically positioned replaced out-of-flow horizontal geometry
https://bugs.webkit.org/show_bug.cgi?id=194163
Reviewed by Simon Fraser.
Source/WebCore:
Fix a typo.
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
Tools:
775
* LayoutReloaded/misc/LFC-passing-tests.txt:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContextGeometry.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
Diff
Modified: trunk/Source/WebCore/ChangeLog (240885 => 240886)
--- trunk/Source/WebCore/ChangeLog 2019-02-01 23:32:42 UTC (rev 240885)
+++ trunk/Source/WebCore/ChangeLog 2019-02-01 23:54:22 UTC (rev 240886)
@@ -1,3 +1,15 @@
+2019-02-01 Zalan Bujtas
+
+[LFC] Fix statically positioned replaced out-of-flow horizontal geometry
+https://bugs.webkit.org/show_bug.cgi?id=194163
+
+Reviewed by Simon Fraser.
+
+Fix a typo.
+
+* layout/FormattingContextGeometry.cpp:
+(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
+
2019-02-01 Chris Dumez
REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
Modified: trunk/Source/WebCore/layout/FormattingContextGeometry.cpp (240885 => 240886)
--- trunk/Source/WebCore/layout/FormattingContextGeometry.cpp 2019-02-01 23:32:42 UTC (rev 240885)
+++ trunk/Source/WebCore/layout/FormattingContextGeometry.cpp 2019-02-01 23:54:22 UTC (rev 240886)
@@ -711,7 +711,7 @@
// For out-of-flow elements the containing block is formed by the padding edge of the ancestor.
// At this point the non-statically positioned value is in the coordinate system of the padding box. Let's convert it to border box coordinate system.
-if (isStaticallyPositioned) {
+if (!isStaticallyPositioned) {
auto containingBlockPaddingVerticalEdge = containingBlockDisplayBox.paddingBoxLeft();
*left += containingBlockPaddingVerticalEdge;
*right += containingBlockPaddingVerticalEdge;
Modified: trunk/Tools/ChangeLog (240885 => 240886)
--- trunk/Tools/ChangeLog 2019-02-01 23:32:42 UTC (rev 240885)
+++ trunk/Tools/ChangeLog 2019-02-01 23:54:22 UTC (rev 240886)
@@ -1,3 +1,14 @@
+2019-02-01 Zalan Bujtas
+
+[LFC] Fix statically positioned replaced out-of-flow horizontal geometry
+https://bugs.webkit.org/show_bug.cgi?id=194163
+
+Reviewed by Simon Fraser.
+
+775
+
+* LayoutReloaded/misc/LFC-passing-tests.txt:
+
2019-02-01 Wenson Hsieh
[iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
Modified: trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt (240885 => 240886)
--- trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt 2019-02-01 23:32:42 UTC (rev 240885)
+++ trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt 2019-02-01 23:54:22 UTC (rev 240886)
@@ -389,8 +389,10 @@
css2.1/20110323/absolute-non-replaced-height-012.htm
css2.1/20110323/absolute-non-replaced-max-height-001.htm
css2.1/20110323/absolute-non-replaced-max-height-002.htm
+css2.1/t0402-c71-fwd-parsing-00-f.html
css2.1/20110323/absolute-non-replaced-max-height-003.htm
css2.1/20110323/absolute-non-replaced-max-height-004.htm
+css2.1/t0402-c71-fwd-parsing-01-f.html
css2.1/20110323/absolute-non-replaced-max-height-005.htm
css2.1/20110323/absolute-non-replaced-max-height-006.htm
css2.1/20110323/absolute-non-replaced-max-height-007.htm
@@ -405,6 +407,7 @@
css2.1/20110323/absolute-non-replaced-width-004.htm
css2.1/20110323/absolute-non-replaced-width-005.htm
css2.1/20110323/absolute-non-replaced-width-006.htm
+css2.1/t0402-c71-fwd-parsing-03-f.html
css2.1/20110323/absolute-non-replaced-width-007.htm
css2.1/20110323/absolute-non-replaced-width-008.htm
css2.1/20110323/absolute-non-replaced-width-009.htm
@@ -415,9 +418,6 @@
css2.1/20110323/absolute-non-replaced-width-014.htm
css2.1/20110323/absolute-non-replaced-width-015.htm
css2.1/20110323/absolute-non-replaced-width-016.htm
-css2.1/t0402-c71-fwd-parsing-00-f.html
-css2.1/t0402-c71-fwd-parsing-01-f.html
-css2.1/t0402-c71-fwd-parsing-03-f.html
css2.1/t0402-syntax-01-f.html
css2.1/t0402-syntax-02-f.html
css2.1/t0402-syntax-03-f.html
@@ -460,6 +460,7 @@
css2.1/20110323/absolute-replaced-height-026.htm
css2.1/20110323/absolute-replaced-height-028.htm
css2.1/20110323/absolute-replaced-height-029.htm
+css2.1/t0803-c5502-imrgn-r-00-b-ag.html
css2.1/20110323/absolute-replaced-height-030.htm
css2.1/20110323/absolute-replaced-height-031.htm
css2.1/20110323/absolute-replaced-height-032.htm
@@ -467,35 +468,35 @@
css2.1/20110323/absolute-replaced-heigh
[webkit-changes] [240885] trunk/Source/WebKit
Title: [240885] trunk/Source/WebKit Revision 240885 Author achristen...@apple.com Date 2019-02-01 15:32:42 -0800 (Fri, 01 Feb 2019) Log Message Move XPCService entry points from mac directory to new Cocoa directory https://bugs.webkit.org/show_bug.cgi?id=194129 Reviewed by Chris Dumez. * Configurations/NetworkService.xcconfig: * Configurations/PluginService.64.xcconfig: * Configurations/WebContentService.xcconfig: * NetworkProcess/EntryPoint/Cocoa: Copied from Source/WebKit/NetworkProcess/EntryPoint/mac. * NetworkProcess/EntryPoint/mac: Removed. * PluginProcess/EntryPoint/Cocoa: Copied from Source/WebKit/PluginProcess/EntryPoint/mac. * PluginProcess/EntryPoint/mac: Removed. * Shared/EntryPointUtilities/Cocoa: Copied from Source/WebKit/Shared/EntryPointUtilities/mac. * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h: * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm: * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: * Shared/EntryPointUtilities/mac: Removed. * SourcesCocoa.txt: * WebKit.xcodeproj/project.pbxproj: * WebProcess/EntryPoint/Cocoa: Copied from Source/WebKit/WebProcess/EntryPoint/mac. * WebProcess/EntryPoint/mac: Removed. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/NetworkService.xcconfig trunk/Source/WebKit/Configurations/PluginService.64.xcconfig trunk/Source/WebKit/Configurations/WebContentService.xcconfig trunk/Source/WebKit/SourcesCocoa.txt trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/ trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/Daemon/ trunk/Source/WebKit/PluginProcess/EntryPoint/Cocoa/ trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/ trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/ Removed Paths trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/ trunk/Source/WebKit/PluginProcess/EntryPoint/mac/ trunk/Source/WebKit/Shared/EntryPointUtilities/mac/ trunk/Source/WebKit/WebProcess/EntryPoint/mac/ Diff Modified: trunk/Source/WebKit/ChangeLog (240884 => 240885) --- trunk/Source/WebKit/ChangeLog 2019-02-01 23:29:36 UTC (rev 240884) +++ trunk/Source/WebKit/ChangeLog 2019-02-01 23:32:42 UTC (rev 240885) @@ -1,3 +1,27 @@ +2019-02-01 Alex Christensen + +Move XPCService entry points from mac directory to new Cocoa directory +https://bugs.webkit.org/show_bug.cgi?id=194129 + +Reviewed by Chris Dumez. + +* Configurations/NetworkService.xcconfig: +* Configurations/PluginService.64.xcconfig: +* Configurations/WebContentService.xcconfig: +* NetworkProcess/EntryPoint/Cocoa: Copied from Source/WebKit/NetworkProcess/EntryPoint/mac. +* NetworkProcess/EntryPoint/mac: Removed. +* PluginProcess/EntryPoint/Cocoa: Copied from Source/WebKit/PluginProcess/EntryPoint/mac. +* PluginProcess/EntryPoint/mac: Removed. +* Shared/EntryPointUtilities/Cocoa: Copied from Source/WebKit/Shared/EntryPointUtilities/mac. +* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h: +* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm: +* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: +* Shared/EntryPointUtilities/mac: Removed. +* SourcesCocoa.txt: +* WebKit.xcodeproj/project.pbxproj: +* WebProcess/EntryPoint/Cocoa: Copied from Source/WebKit/WebProcess/EntryPoint/mac. +* WebProcess/EntryPoint/mac: Removed. + 2019-02-01 Wenson Hsieh [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events Modified: trunk/Source/WebKit/Configurations/NetworkService.xcconfig (240884 => 240885) --- trunk/Source/WebKit/Configurations/NetworkService.xcconfig 2019-02-01 23:29:36 UTC (rev 240884) +++ trunk/Source/WebKit/Configurations/NetworkService.xcconfig 2019-02-01 23:32:42 UTC (rev 240885) @@ -37,8 +37,8 @@ PRODUCT_NAME = com.apple.WebKit.Networking; PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME); -INFOPLIST_FILE[sdk=iphone*] = NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist; -INFOPLIST_FILE[sdk=macosx*] = NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist; +INFOPLIST_FILE[sdk=iphone*] = NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist; +INFOPLIST_FILE[sdk=macosx*] = NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist; OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS); OTHER_LDFLAGS[sdk=macosx*] = $(inherited) $(BUILT_PRODUCTS_DIR)/SecItemShim.dylib; Modified: trunk/Source/WebKit/Configurations/PluginService.64.xcconfig (240884 => 240885) --- trunk/Source/WebKit/Configurations/PluginService.64.xcconfig 2019-02-01 23:29:36 UTC (rev 240884) +++ trunk/Source/WebKit/Configurations/PluginService.64.xcconfig 2019-02-01 23:32:42 UTC (rev 240885) @@ -27,7 +27,7 @@
[webkit-changes] [240884] trunk/Source/WebInspectorUI
Title: [240884] trunk/Source/WebInspectorUI Revision 240884 Author drou...@apple.com Date 2019-02-01 15:29:36 -0800 (Fri, 01 Feb 2019) Log Message Web Inspector: create icons for media event types instead of using a blue circle https://bugs.webkit.org/show_bug.cgi?id=190381 Reviewed by Brian Burg. * UserInterface/Models/DOMNode.js: (WI.DOMNode.isPlayEvent): Added. (WI.DOMNode.isPauseEvent): Added. (WI.DOMNode.isStopEvent): Added. * UserInterface/Views/DOMEventsBreakdownView.js: (WI.DOMEventsBreakdownView.prototype.layout): * UserInterface/Views/DOMEventsBreakdownView.css: (.dom-events-breakdown tr > :matches(th, td)): (.dom-events-breakdown .graph): (.dom-events-breakdown .graph > :matches(img, .area)): Added. (.dom-events-breakdown .graph > img): Added. (.dom-events-breakdown .inherited > .name, .dom-events-breakdown .inherited > .graph > img): Added. (.dom-events-breakdown .graph > :matches(.point, .area)): Deleted. (.dom-events-breakdown .graph > .point): Deleted. (.dom-events-breakdown .inherited > .name, .dom-events-breakdown .inherited > .graph > .point): Deleted. * UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView.prototype._populateWaterfallGraph.createDOMEventLine): * UserInterface/Images/EventPause.svg: Added. * UserInterface/Images/EventPlay.svg: Added. * UserInterface/Images/EventProcessing.svg: Added. * UserInterface/Images/EventStop.svg: Added. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMEventsBreakdownView.css trunk/Source/WebInspectorUI/UserInterface/Views/DOMEventsBreakdownView.js trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js Added Paths trunk/Source/WebInspectorUI/UserInterface/Images/EventPause.svg trunk/Source/WebInspectorUI/UserInterface/Images/EventPlay.svg trunk/Source/WebInspectorUI/UserInterface/Images/EventProcessing.svg trunk/Source/WebInspectorUI/UserInterface/Images/EventStop.svg Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (240883 => 240884) --- trunk/Source/WebInspectorUI/ChangeLog 2019-02-01 23:27:30 UTC (rev 240883) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-01 23:29:36 UTC (rev 240884) @@ -1,3 +1,36 @@ +2019-02-01 Devin Rousso + +Web Inspector: create icons for media event types instead of using a blue circle +https://bugs.webkit.org/show_bug.cgi?id=190381 + + +Reviewed by Brian Burg. + +* UserInterface/Models/DOMNode.js: +(WI.DOMNode.isPlayEvent): Added. +(WI.DOMNode.isPauseEvent): Added. +(WI.DOMNode.isStopEvent): Added. + +* UserInterface/Views/DOMEventsBreakdownView.js: +(WI.DOMEventsBreakdownView.prototype.layout): +* UserInterface/Views/DOMEventsBreakdownView.css: +(.dom-events-breakdown tr > :matches(th, td)): +(.dom-events-breakdown .graph): +(.dom-events-breakdown .graph > :matches(img, .area)): Added. +(.dom-events-breakdown .graph > img): Added. +(.dom-events-breakdown .inherited > .name, .dom-events-breakdown .inherited > .graph > img): Added. +(.dom-events-breakdown .graph > :matches(.point, .area)): Deleted. +(.dom-events-breakdown .graph > .point): Deleted. +(.dom-events-breakdown .inherited > .name, .dom-events-breakdown .inherited > .graph > .point): Deleted. + +* UserInterface/Views/NetworkTableContentView.js: +(WI.NetworkTableContentView.prototype._populateWaterfallGraph.createDOMEventLine): + +* UserInterface/Images/EventPause.svg: Added. +* UserInterface/Images/EventPlay.svg: Added. +* UserInterface/Images/EventProcessing.svg: Added. +* UserInterface/Images/EventStop.svg: Added. + 2019-02-01 Joseph Pecoraro Web Inspector: Make WI.ColumnChart a WI.View subclass Added: trunk/Source/WebInspectorUI/UserInterface/Images/EventPause.svg (0 => 240884) --- trunk/Source/WebInspectorUI/UserInterface/Images/EventPause.svg (rev 0) +++ trunk/Source/WebInspectorUI/UserInterface/Images/EventPause.svg 2019-02-01 23:29:36 UTC (rev 240884) @@ -0,0 +1,5 @@ + + + + + Added: trunk/Source/WebInspectorUI/UserInterface/Images/EventPlay.svg (0 => 240884) --- trunk/Source/WebInspectorUI/UserInterface/Images/EventPlay.svg (rev 0) +++ trunk/Source/WebInspectorUI/UserInterface/Images/EventPlay.svg 2019-02-01 23:29:36 UTC (rev 240884) @@ -0,0 +1,5 @@ + + + + + Added: trunk/Source/WebInspectorUI/UserInterface/Images/EventProcessing.svg (0 => 240884) --- trunk/Source/WebInspectorUI/UserInterface/Images/EventProcessing.svg (rev 0) +++ trunk/Source/WebInspectorUI/UserInterface/Images/EventProcessing.svg 2019-02-01 23:29:36 UTC (rev 240884) @@ -0,0 +1,5 @@ + + + + + Added: trunk/Source/WebInspectorUI/UserInterface/Images/EventStop.svg (0 => 240
[webkit-changes] [240883] trunk/LayoutTests
Title: [240883] trunk/LayoutTests
Revision 240883
Author megan_gard...@apple.com
Date 2019-02-01 15:27:30 -0800 (Fri, 01 Feb 2019)
Log Message
Rewrite and rebaseline smart copy paste tests to work on iOS and MacOS
https://bugs.webkit.org/show_bug.cgi?id=194175
Reviewed by Megan Gardner.
Using the functions committed in 194070 Ryosuke wrote, make the
smart copy paste tests run on both iOS and MacOS.
These tests will be turned on in 193786.
* editing/editing.js:
(runEditingTestWithCallbackLogging):
(runDumpAsTextEditingTest):
* editing/pasteboard/smart-paste-001.html:
* editing/pasteboard/smart-paste-002-expected.txt:
* editing/pasteboard/smart-paste-002.html:
* editing/pasteboard/smart-paste-003.html:
* editing/pasteboard/smart-paste-004.html:
* editing/pasteboard/smart-paste-005-expected.txt:
* editing/pasteboard/smart-paste-005.html:
* editing/pasteboard/smart-paste-006-expected.txt:
* editing/pasteboard/smart-paste-006.html:
* editing/pasteboard/smart-paste-007.html:
* editing/pasteboard/smart-paste-008.html:
* platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/editing.js
trunk/LayoutTests/editing/pasteboard/smart-paste-001.html
trunk/LayoutTests/editing/pasteboard/smart-paste-002-expected.txt
trunk/LayoutTests/editing/pasteboard/smart-paste-002.html
trunk/LayoutTests/editing/pasteboard/smart-paste-003.html
trunk/LayoutTests/editing/pasteboard/smart-paste-004.html
trunk/LayoutTests/editing/pasteboard/smart-paste-005-expected.txt
trunk/LayoutTests/editing/pasteboard/smart-paste-005.html
trunk/LayoutTests/editing/pasteboard/smart-paste-006-expected.txt
trunk/LayoutTests/editing/pasteboard/smart-paste-006.html
trunk/LayoutTests/editing/pasteboard/smart-paste-007.html
trunk/LayoutTests/editing/pasteboard/smart-paste-008.html
trunk/LayoutTests/platform/mac/editing/pasteboard/smart-paste-008-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (240882 => 240883)
--- trunk/LayoutTests/ChangeLog 2019-02-01 23:12:14 UTC (rev 240882)
+++ trunk/LayoutTests/ChangeLog 2019-02-01 23:27:30 UTC (rev 240883)
@@ -1,3 +1,31 @@
+2019-02-01 Megan Gardner
+
+Rewrite and rebaseline smart copy paste tests to work on iOS and MacOS
+https://bugs.webkit.org/show_bug.cgi?id=194175
+
+Reviewed by Megan Gardner.
+Patch by Ryosuke Niwa.
+
+Using the functions committed in 194070 Ryosuke wrote, make the
+smart copy paste tests run on both iOS and MacOS.
+These tests will be turned on in 193786.
+
+* editing/editing.js:
+(runEditingTestWithCallbackLogging):
+(runDumpAsTextEditingTest):
+* editing/pasteboard/smart-paste-001.html:
+* editing/pasteboard/smart-paste-002-expected.txt:
+* editing/pasteboard/smart-paste-002.html:
+* editing/pasteboard/smart-paste-003.html:
+* editing/pasteboard/smart-paste-004.html:
+* editing/pasteboard/smart-paste-005-expected.txt:
+* editing/pasteboard/smart-paste-005.html:
+* editing/pasteboard/smart-paste-006-expected.txt:
+* editing/pasteboard/smart-paste-006.html:
+* editing/pasteboard/smart-paste-007.html:
+* editing/pasteboard/smart-paste-008.html:
+* platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
+
2019-02-01 Wenson Hsieh
[iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
Modified: trunk/LayoutTests/editing/editing.js (240882 => 240883)
--- trunk/LayoutTests/editing/editing.js 2019-02-01 23:12:14 UTC (rev 240882)
+++ trunk/LayoutTests/editing/editing.js 2019-02-01 23:27:30 UTC (rev 240883)
@@ -924,7 +924,17 @@
var elem = document.getElementById("test");
var selection = window.getSelection();
selection.setPosition(elem, 0);
-editingTest();
+
+const result = editingTest();
+
+if (result instanceof Promise) {
+if (window.testRunner)
+testRunner.waitUntilDone();
+result.then(() => {
+if (window.testRunner)
+testRunner.notifyDone();
+});
+}
}
var dumpAsText = false;
@@ -942,7 +952,7 @@
var elem = document.getElementById("test");
var selection = window.getSelection();
selection.setPosition(elem, 0);
-editingTest();
+const result = editingTest();
for (var i = 0; i < elementsForDumpingMarkupList.length; i++)
document.body.appendChild(elementsForDumpingMarkupList[i]);
Modified: trunk/LayoutTests/editing/pasteboard/smart-paste-001.html (240882 => 240883)
--- trunk/LayoutTests/editing/pasteboard/smart-paste-001.html 2019-02-01 23:12:14 UTC (rev 240882)
+++ trunk/LayoutTests/editing/pasteboard/smart-paste-001.html 2019-02-01 23:27:30 UTC (rev 240883)
@@ -39,10 +39,11 @@
+