[webkit-changes] [259336] trunk/Source/WebKit
Title: [259336] trunk/Source/WebKit
Revision 259336
Author megan_gard...@apple.com
Date 2020-03-31 20:19:45 -0700 (Tue, 31 Mar 2020)
Log Message
Dismiss color picker on color selection on MacCatalyst
https://bugs.webkit.org/show_bug.cgi?id=209840
Reviewed by Darin Adler.
To have correct behavior on mac, we need to dismiss the color picker popover once
a color has been selected.
* UIProcess/ios/forms/WKFormColorControl.mm:
(-[WKColorPopover initWithView:]):
* UIProcess/ios/forms/WKFormColorPicker.h:
* UIProcess/ios/forms/WKFormColorPicker.mm:
(-[WKColorPicker initWithView:]):
(-[WKColorPicker initWithView:inPopover:]):
(-[WKColorPicker colorMatrixView:didTapColorButton:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm
trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.h
trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (259335 => 259336)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 02:49:32 UTC (rev 259335)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 03:19:45 UTC (rev 259336)
@@ -1,3 +1,22 @@
+2020-03-31 Megan Gardner
+
+Dismiss color picker on color selection on MacCatalyst
+https://bugs.webkit.org/show_bug.cgi?id=209840
+
+
+Reviewed by Darin Adler.
+
+To have correct behavior on mac, we need to dismiss the color picker popover once
+a color has been selected.
+
+* UIProcess/ios/forms/WKFormColorControl.mm:
+(-[WKColorPopover initWithView:]):
+* UIProcess/ios/forms/WKFormColorPicker.h:
+* UIProcess/ios/forms/WKFormColorPicker.mm:
+(-[WKColorPicker initWithView:]):
+(-[WKColorPicker initWithView:inPopover:]):
+(-[WKColorPicker colorMatrixView:didTapColorButton:]):
+
2020-03-31 Simon Fraser
Add type traits for ScrollableArea, and other cleanup
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm (259335 => 259336)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm 2020-04-01 02:49:32 UTC (rev 259335)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm 2020-04-01 03:19:45 UTC (rev 259336)
@@ -53,7 +53,7 @@
if (!(self = [super initWithView:view]))
return nil;
-_innerControl = adoptNS([[WKColorPicker alloc] initWithView:view]);
+_innerControl = adoptNS([[WKColorPicker alloc] initWithView:view inPopover:self]);
RetainPtr popoverViewController = adoptNS([[UIViewController alloc] init]);
RetainPtr controlContainerView = adoptNS([[UIView alloc] initWithFrame:CGRectMake(0, 0, colorPopoverWidth, colorPopoverWidth)]);
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.h (259335 => 259336)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.h 2020-04-01 02:49:32 UTC (rev 259335)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.h 2020-04-01 03:19:45 UTC (rev 259336)
@@ -31,6 +31,7 @@
OBJC_CLASS WKColorButton;
OBJC_CLASS WKColorMatrixView;
OBJC_CLASS WKContentView;
+OBJC_CLASS WKColorPopover;
@protocol WKColorMatrixViewDelegate
- (void)colorMatrixView:(WKColorMatrixView *)matrixView didTapColorButton:(WKColorButton *)colorButton;
@@ -39,6 +40,7 @@
@interface WKColorPicker : NSObject
- (instancetype)initWithView:(WKContentView *)view;
+- (instancetype)initWithView:(WKContentView *)view inPopover:(WKColorPopover *)popover;
@end
#endif // ENABLE(INPUT_TYPE_COLOR) && PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm (259335 => 259336)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm 2020-04-01 02:49:32 UTC (rev 259335)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm 2020-04-01 03:19:45 UTC (rev 259336)
@@ -151,6 +151,7 @@
@implementation WKColorPicker {
WKContentView *_view;
+__weak WKColorPopover *_popover;
RetainPtr _colorPicker;
RetainPtr _colorSelectionIndicator;
@@ -170,10 +171,17 @@
- (instancetype)initWithView:(WKContentView *)view
{
+return [self initWithView:view inPopover:nil];
+}
+
+- (instancetype)initWithView:(WKContentView *)view inPopover:(WKColorPopover *)popover
+{
if (!(self = [super init]))
return nil;
_view = view;
+
+_popover = popover;
CGSize colorPickerSize;
if (currentUserInterfaceIdiomIsPad())
@@ -296,6 +304,9 @@
[self drawSelectionIndicatorForColorButton:colorButton];
[self setControlValueFromUIColor:colorButton.color];
+#if PLATFORM(MACCATALYST)
+[_popover dismissPopoverAnimated:NO];
+#endif
}
#pragma mark UIPanGestureRecognizer
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259335] trunk/Source/WebCore
Title: [259335] trunk/Source/WebCore
Revision 259335
Author simon.fra...@apple.com
Date 2020-03-31 19:49:32 -0700 (Tue, 31 Mar 2020)
Log Message
Make FrameView and Frame TextStream-loggable
https://bugs.webkit.org/show_bug.cgi?id=209826
Reviewed by Darin Adler.
Provide operator<<(TextStream&, ...) for Frame and FrameView so they can be logged.
Only basic data logging currently; this can be adjusted as necessary.
* page/Frame.cpp:
(WebCore::operator<<):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::operator<<):
* page/FrameView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/Frame.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259334 => 259335)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 02:32:49 UTC (rev 259334)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 02:49:32 UTC (rev 259335)
@@ -1,3 +1,20 @@
+2020-03-31 Simon Fraser
+
+Make FrameView and Frame TextStream-loggable
+https://bugs.webkit.org/show_bug.cgi?id=209826
+
+Reviewed by Darin Adler.
+
+Provide operator<<(TextStream&, ...) for Frame and FrameView so they can be logged.
+Only basic data logging currently; this can be adjusted as necessary.
+
+* page/Frame.cpp:
+(WebCore::operator<<):
+* page/Frame.h:
+* page/FrameView.cpp:
+(WebCore::operator<<):
+* page/FrameView.h:
+
2020-03-31 Zalan Bujtas
[MultiColumn] Call RenderTreeBuilder::multiColumnDescendantInserted only when the enclosing fragmented flow has changed
Modified: trunk/Source/WebCore/page/Frame.cpp (259334 => 259335)
--- trunk/Source/WebCore/page/Frame.cpp 2020-04-01 02:32:49 UTC (rev 259334)
+++ trunk/Source/WebCore/page/Frame.cpp 2020-04-01 02:49:32 UTC (rev 259335)
@@ -106,6 +106,7 @@
#include
#include
#include
+#include
#define RELEASE_LOG_ERROR_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_ERROR_IF(isAlwaysOnLoggingAllowed(), channel, "%p - Frame::" fmt, this, ##__VA_ARGS__)
@@ -1052,6 +1053,12 @@
deref();
}
+TextStream& operator<<(TextStream& ts, const Frame& frame)
+{
+ts << "Frame " << << " view " << frame.view() << " (is main frame " << frame.isMainFrame() << ") " << (frame.document() ? frame.document()->documentURI() : emptyString());
+return ts;
+}
+
} // namespace WebCore
#undef RELEASE_LOG_ERROR_IF_ALLOWED
Modified: trunk/Source/WebCore/page/Frame.h (259334 => 259335)
--- trunk/Source/WebCore/page/Frame.h 2020-04-01 02:32:49 UTC (rev 259334)
+++ trunk/Source/WebCore/page/Frame.h 2020-04-01 02:49:32 UTC (rev 259335)
@@ -59,6 +59,10 @@
class RegularExpression;
} }
+namespace WTF {
+class TextStream;
+}
+
namespace WebCore {
class CSSAnimationController;
@@ -412,6 +416,8 @@
return m_mainFrame;
}
+WTF::TextStream& operator<<(WTF::TextStream&, const Frame&);
+
} // namespace WebCore
SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::Frame)
Modified: trunk/Source/WebCore/page/FrameView.cpp (259334 => 259335)
--- trunk/Source/WebCore/page/FrameView.cpp 2020-04-01 02:32:49 UTC (rev 259334)
+++ trunk/Source/WebCore/page/FrameView.cpp 2020-04-01 02:49:32 UTC (rev 259335)
@@ -5089,7 +5089,6 @@
return ScrollableArea::handleWheelEvent(wheelEvent);
}
-
bool FrameView::isVerticalDocument() const
{
RenderView* renderView = this->renderView();
@@ -5445,6 +5444,12 @@
return renderView() && renderView()->shouldPlaceBlockDirectionScrollbarOnLeft();
}
+TextStream& operator<<(TextStream& ts, const FrameView& view)
+{
+ts << "FrameView " << << " frame " << view.frame();
+return ts;
+}
+
} // namespace WebCore
#undef PAGE_ID
Modified: trunk/Source/WebCore/page/FrameView.h (259334 => 259335)
--- trunk/Source/WebCore/page/FrameView.h 2020-04-01 02:32:49 UTC (rev 259334)
+++ trunk/Source/WebCore/page/FrameView.h 2020-04-01 02:49:32 UTC (rev 259335)
@@ -49,6 +49,10 @@
#include
#include
+namespace WTF {
+class TextStream;
+}
+
namespace WebCore {
class AXObjectCache;
@@ -954,6 +958,8 @@
m_visuallyNonEmptyPixelCount += size.width() * size.height();
}
+WTF::TextStream& operator<<(WTF::TextStream&, const FrameView&);
+
} // namespace WebCore
SPECIALIZE_TYPE_TRAITS_WIDGET(FrameView, isFrameView())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259334] trunk
Title: [259334] trunk
Revision 259334
Author za...@apple.com
Date 2020-03-31 19:32:49 -0700 (Tue, 31 Mar 2020)
Log Message
[MultiColumn] Call RenderTreeBuilder::multiColumnDescendantInserted only when the enclosing fragmented flow has changed
https://bugs.webkit.org/show_bug.cgi?id=209816
Reviewed by Antti Koivisto.
Source/WebCore:
Just because an element goes from out-of-flow to in-flow, it does not necessarily mean that the enclosing flow is going to change.
This patch ensure that we only call RenderTreeBuilder::multiColumnDescendantInserted when the flow actually gains new content.
Test: fast/multicol/absolute-to-static-change-same-enclosing-flow.html
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::childFlowStateChangesAndAffectsParentBlock):
LayoutTests:
* fast/multicol/absolute-to-static-change-same-enclosing-flow-expected.txt: Added.
* fast/multicol/absolute-to-static-change-same-enclosing-flow.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
Added Paths
trunk/LayoutTests/fast/multicol/absolute-to-static-change-same-enclosing-flow-expected.txt
trunk/LayoutTests/fast/multicol/absolute-to-static-change-same-enclosing-flow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259333 => 259334)
--- trunk/LayoutTests/ChangeLog 2020-04-01 02:29:56 UTC (rev 259333)
+++ trunk/LayoutTests/ChangeLog 2020-04-01 02:32:49 UTC (rev 259334)
@@ -1,3 +1,14 @@
+2020-03-31 Zalan Bujtas
+
+[MultiColumn] Call RenderTreeBuilder::multiColumnDescendantInserted only when the enclosing fragmented flow has changed
+https://bugs.webkit.org/show_bug.cgi?id=209816
+
+
+Reviewed by Antti Koivisto.
+
+* fast/multicol/absolute-to-static-change-same-enclosing-flow-expected.txt: Added.
+* fast/multicol/absolute-to-static-change-same-enclosing-flow.html: Added.
+
2020-03-31 Wenson Hsieh
Datalist option's label not used
Added: trunk/LayoutTests/fast/multicol/absolute-to-static-change-same-enclosing-flow-expected.txt (0 => 259334)
--- trunk/LayoutTests/fast/multicol/absolute-to-static-change-same-enclosing-flow-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/multicol/absolute-to-static-change-same-enclosing-flow-expected.txt 2020-04-01 02:32:49 UTC (rev 259334)
@@ -0,0 +1,2 @@
+Pass if no crash or assert when the absolute positioned element becomes static and it still part of the same column fragment.
+
Added: trunk/LayoutTests/fast/multicol/absolute-to-static-change-same-enclosing-flow.html (0 => 259334)
--- trunk/LayoutTests/fast/multicol/absolute-to-static-change-same-enclosing-flow.html (rev 0)
+++ trunk/LayoutTests/fast/multicol/absolute-to-static-change-same-enclosing-flow.html 2020-04-01 02:32:49 UTC (rev 259334)
@@ -0,0 +1,18 @@
+
+summary {
+ column-span: all;
+}
+#details {
+ column-count: 2;
+ position: absolute;
+}
+html {
+ column-count: 2;
+}
+Pass if no crash or assert when the absolute positioned element becomes static and it still part of the same column fragment.
+if (window.testRunner)
+testRunner.dumpAsText();
+document.body.offsetHeight;
+details.style.columnCount = "1";
+details.style.position = "static";
+
Modified: trunk/Source/WebCore/ChangeLog (259333 => 259334)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 02:29:56 UTC (rev 259333)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 02:32:49 UTC (rev 259334)
@@ -1,3 +1,19 @@
+2020-03-31 Zalan Bujtas
+
+[MultiColumn] Call RenderTreeBuilder::multiColumnDescendantInserted only when the enclosing fragmented flow has changed
+https://bugs.webkit.org/show_bug.cgi?id=209816
+
+
+Reviewed by Antti Koivisto.
+
+Just because an element goes from out-of-flow to in-flow, it does not necessarily mean that the enclosing flow is going to change.
+This patch ensure that we only call RenderTreeBuilder::multiColumnDescendantInserted when the flow actually gains new content.
+
+Test: fast/multicol/absolute-to-static-change-same-enclosing-flow.html
+
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::childFlowStateChangesAndAffectsParentBlock):
+
2020-03-31 Simon Fraser
Add type traits for ScrollableArea, and other cleanup
Modified: trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp (259333 => 259334)
--- trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp 2020-04-01 02:29:56 UTC (rev 259333)
+++ trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp 2020-04-01 02:32:49 UTC (rev 259334)
@@ -686,27 +686,29 @@
void RenderTreeBuilder::childFlowStateChangesAndAffectsParentBlock(RenderElement& child)
{
-auto* parent = child.parent();
if (!child.isInline()) {
-if (is(parent))
+auto* currentEnclosingFragment = child.enclosingFragmentedFlow();
+
[webkit-changes] [259333] trunk/Source
Title: [259333] trunk/Source
Revision 259333
Author simon.fra...@apple.com
Date 2020-03-31 19:29:56 -0700 (Tue, 31 Mar 2020)
Log Message
Add type traits for ScrollableArea, and other cleanup
https://bugs.webkit.org/show_bug.cgi?id=209838
Reviewed by Chris Dumez.
Source/WebCore:
Make it possible to use type casts on ScrollableArea so that EventHandler code can stop
passing around so many different types.
Because ScrollView inherits from both Widget and ScrollableArea, expand out its SPECIALIZE_TYPE_TRAITS macros.
Mark RenderLayer and RenderListBox ScrollableArea overrides as final.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformPrepareForWheelEvents): Null-check page and return early.
* platform/ScrollView.h:
(isType):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::isScrollView const):
(WebCore::ScrollableArea::isRenderLayer const):
(WebCore::ScrollableArea::isListBox const):
(WebCore::ScrollableArea::isPDFPlugin const):
* rendering/RenderLayer.h:
(isType):
* rendering/RenderListBox.h:
(isType):
Source/WebCore/../WebKit:
Because PDFPlugin inherits from both Plugin and ScrollableArea, expand out its SPECIALIZE_TYPE_TRAITS macros
and change the macros to use the isFoo() pattern.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/PDF/PDFPlugin.h:
(isType):
* WebProcess/Plugins/Plugin.h:
(WebKit::Plugin::isPluginProxy const):
(WebKit::Plugin::isNetscapePlugin const):
(WebKit::Plugin::isPDFPlugin const):
* WebProcess/Plugins/PluginProxy.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/mac/EventHandlerMac.mm
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderListBox.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
trunk/Source/WebKit/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit/WebProcess/Plugins/PluginProxy.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259332 => 259333)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 02:06:50 UTC (rev 259332)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 02:29:56 UTC (rev 259333)
@@ -1,3 +1,31 @@
+2020-03-31 Simon Fraser
+
+Add type traits for ScrollableArea, and other cleanup
+https://bugs.webkit.org/show_bug.cgi?id=209838
+
+Reviewed by Chris Dumez.
+
+Make it possible to use type casts on ScrollableArea so that EventHandler code can stop
+passing around so many different types.
+
+Because ScrollView inherits from both Widget and ScrollableArea, expand out its SPECIALIZE_TYPE_TRAITS macros.
+
+Mark RenderLayer and RenderListBox ScrollableArea overrides as final.
+
+* page/mac/EventHandlerMac.mm:
+(WebCore::EventHandler::platformPrepareForWheelEvents): Null-check page and return early.
+* platform/ScrollView.h:
+(isType):
+* platform/ScrollableArea.h:
+(WebCore::ScrollableArea::isScrollView const):
+(WebCore::ScrollableArea::isRenderLayer const):
+(WebCore::ScrollableArea::isListBox const):
+(WebCore::ScrollableArea::isPDFPlugin const):
+* rendering/RenderLayer.h:
+(isType):
+* rendering/RenderListBox.h:
+(isType):
+
2020-03-31 Kate Cheney
Requests for messageHandlers() in the DOMWindow should be ignored for non-app-bound navigations
Modified: trunk/Source/WebCore/page/mac/EventHandlerMac.mm (259332 => 259333)
--- trunk/Source/WebCore/page/mac/EventHandlerMac.mm 2020-04-01 02:06:50 UTC (rev 259332)
+++ trunk/Source/WebCore/page/mac/EventHandlerMac.mm 2020-04-01 02:29:56 UTC (rev 259333)
@@ -950,8 +950,12 @@
{
clearOrScheduleClearingLatchedStateIfNeeded(wheelEvent);
-FrameView* view = m_frame.view();
+auto* page = m_frame.page();
+if (!page)
+return;
+auto* view = m_frame.view();
+
if (!view)
scrollableContainer = wheelEventTarget;
else {
@@ -971,13 +975,12 @@
}
}
-Page* page = m_frame.page();
-if (scrollableArea && page && page->isMonitoringWheelEvents())
+if (scrollableArea && page->isMonitoringWheelEvents())
scrollableArea->scrollAnimator().setWheelEventTestMonitor(page->wheelEventTestMonitor());
-ScrollLatchingState* latchingState = page ? page->latchingState() : nullptr;
+auto* latchingState = page->latchingState();
if (wheelEvent.shouldConsiderLatching()) {
-if (scrollableContainer && scrollableArea && page) {
+if (scrollableContainer && scrollableArea) {
bool startingAtScrollLimit = scrolledToEdgeInDominantDirection(*scrollableContainer, *scrollableArea.get(), wheelEvent.deltaX(), wheelEvent.deltaY());
if (!startingAtScrollLimit) {
auto latchingState = WTF::makeUnique();
Modified:
[webkit-changes] [259332] trunk/Source/WTF
Title: [259332] trunk/Source/WTF Revision 259332 Author commit-qu...@webkit.org Date 2020-03-31 19:06:50 -0700 (Tue, 31 Mar 2020) Log Message Update check for aarch64 https://bugs.webkit.org/show_bug.cgi?id=209322 Patch by Michael Catanzaro on 2020-03-31 Reviewed by Mark Lam. CPU(ARM64) is used on Linux, so checking to avoid Apple platforms doesn't make much sense. The comment implying that this is an Apple architecture also no longer makes sense. * wtf/PlatformCPU.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformCPU.h Diff Modified: trunk/Source/WTF/ChangeLog (259331 => 259332) --- trunk/Source/WTF/ChangeLog 2020-04-01 01:42:53 UTC (rev 259331) +++ trunk/Source/WTF/ChangeLog 2020-04-01 02:06:50 UTC (rev 259332) @@ -1,3 +1,15 @@ +2020-03-31 Michael Catanzaro + +Update check for aarch64 +https://bugs.webkit.org/show_bug.cgi?id=209322 + +Reviewed by Mark Lam. + +CPU(ARM64) is used on Linux, so checking to avoid Apple platforms doesn't make much sense. +The comment implying that this is an Apple architecture also no longer makes sense. + +* wtf/PlatformCPU.h: + 2020-03-31 Sihui Liu IndexedDB: destroy WebIDBServer when session is removed in network process Modified: trunk/Source/WTF/wtf/PlatformCPU.h (259331 => 259332) --- trunk/Source/WTF/wtf/PlatformCPU.h 2020-04-01 01:42:53 UTC (rev 259331) +++ trunk/Source/WTF/wtf/PlatformCPU.h 2020-04-01 02:06:50 UTC (rev 259332) @@ -112,8 +112,8 @@ #define WTF_CPU_KNOWN 1 #endif -/* CPU(ARM64) - Apple */ -#if (defined(__arm64__) && defined(__APPLE__)) || defined(__aarch64__) +/* CPU(ARM64) */ +#if defined(__arm64__) || defined(__aarch64__) #define WTF_CPU_ARM64 1 #define WTF_CPU_KNOWN 1 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259331] trunk
Title: [259331] trunk
Revision 259331
Author katherine_che...@apple.com
Date 2020-03-31 18:42:53 -0700 (Tue, 31 Mar 2020)
Log Message
Requests for messageHandlers() in the DOMWindow should be ignored for non-app-bound navigations
https://bugs.webkit.org/show_bug.cgi?id=209836
Reviewed by Brent Fulgham.
Source/WebCore:
Ignore calls for WebKitNamespace::messageHandlers() and add release
logging if the domain is not app-bound.
* page/WebKitNamespace.cpp:
(WebCore::WebKitNamespace::messageHandlers):
Tools:
Most of this patch is changes to the tests, which formerly relied
on message handlers to test script injection protections. I rewrote
three tests to remove the use of message handlers which were used to
confirm normal script injection behavior before enabling In-App
Browser Privacy. Since normal script injection behavior is tested in
WKUserContentController.mm already it is unecessary to test here.
I removed one test, IgnoreAppBoundDomainsAcceptsUserScripts, which
fully relied on message handler use and could not be tested without
somehow disabling this feature.
* TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(TEST):
(-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
* TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html:
Add a message handler to this page to demonstrate that message
handlers work for app-bound navigations (file:// protocol is always
app-bound).
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/WebKitNamespace.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html
Diff
Modified: trunk/Source/WebCore/ChangeLog (259330 => 259331)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 01:22:59 UTC (rev 259330)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 01:42:53 UTC (rev 259331)
@@ -1,3 +1,17 @@
+2020-03-31 Kate Cheney
+
+Requests for messageHandlers() in the DOMWindow should be ignored for non-app-bound navigations
+https://bugs.webkit.org/show_bug.cgi?id=209836
+
+
+Reviewed by Brent Fulgham.
+
+Ignore calls for WebKitNamespace::messageHandlers() and add release
+logging if the domain is not app-bound.
+
+* page/WebKitNamespace.cpp:
+(WebCore::WebKitNamespace::messageHandlers):
+
2020-03-31 Wenson Hsieh
Datalist option's label not used
Modified: trunk/Source/WebCore/page/WebKitNamespace.cpp (259330 => 259331)
--- trunk/Source/WebCore/page/WebKitNamespace.cpp 2020-04-01 01:22:59 UTC (rev 259330)
+++ trunk/Source/WebCore/page/WebKitNamespace.cpp 2020-04-01 01:42:53 UTC (rev 259331)
@@ -26,6 +26,12 @@
#include "config.h"
#include "WebKitNamespace.h"
+#include "FrameLoader.h"
+#include "FrameLoaderClient.h"
+#include "Logging.h"
+
+#define RELEASE_LOG_ERROR_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_ERROR_IF(frame() && frame()->isAlwaysOnLoggingAllowed(), channel, "%p - WebKitNamespace::" fmt, this, ##__VA_ARGS__)
+
#if ENABLE(USER_MESSAGE_HANDLERS)
#include "DOMWindow.h"
@@ -44,6 +50,11 @@
UserMessageHandlersNamespace* WebKitNamespace::messageHandlers()
{
+if (frame() && frame()->loader().client().hasNavigatedAwayFromAppBoundDomain()) {
+RELEASE_LOG_ERROR_IF_ALLOWED(Loading, "Ignoring messageHandlers() request for non app-bound domain");
+return nullptr;
+}
+
return _messageHandlerNamespace.get();
}
@@ -50,3 +61,5 @@
} // namespace WebCore
#endif // ENABLE(USER_MESSAGE_HANDLERS)
+
+#undef RELEASE_LOG_ERROR_IF_ALLOWED
Modified: trunk/Tools/ChangeLog (259330 => 259331)
--- trunk/Tools/ChangeLog 2020-04-01 01:22:59 UTC (rev 259330)
+++ trunk/Tools/ChangeLog 2020-04-01 01:42:53 UTC (rev 259331)
@@ -1,3 +1,30 @@
+2020-03-31 Kate Cheney
+
+Requests for messageHandlers() in the DOMWindow should be ignored for non-app-bound navigations
+https://bugs.webkit.org/show_bug.cgi?id=209836
+
+
+Reviewed by Brent Fulgham.
+
+Most of this patch is changes to the tests, which formerly relied
+on message handlers to test script injection protections. I rewrote
+three tests to remove the use of message handlers which were used to
+confirm normal script injection behavior before enabling In-App
+Browser Privacy. Since normal script injection behavior is tested in
+WKUserContentController.mm already it is unecessary to test here.
+
+I removed one test, IgnoreAppBoundDomainsAcceptsUserScripts, which
+fully relied on message handler use and could not be tested without
+somehow disabling this feature.
+
+* TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
+(TEST):
+(-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
+*
[webkit-changes] [259330] trunk
Title: [259330] trunk Revision 259330 Author wenson_hs...@apple.com Date 2020-03-31 18:22:59 -0700 (Tue, 31 Mar 2020) Log Message Datalist option's label not used https://bugs.webkit.org/show_bug.cgi?id=201768 Reviewed by Darin Adler. Source/WebCore: Refactor DataListSuggestionInformation's suggestions to include label text as well as values, and then adjust TextFieldInputType::suggestions() to match label text as well as values for ports that are capable of showing label text in datalist suggestion UI. Test: fast/forms/datalist/datalist-option-labels.html * html/DataListSuggestionInformation.h: Introduce DataListSuggestion, a wrapper around a value and label. Currently, the list of datalist suggestions is only a `Vector`; change it to be a `Vector` instead. (WebCore::DataListSuggestion::encode const): (WebCore::DataListSuggestion::decode): (WebCore::DataListSuggestionInformation::encode const): (WebCore::DataListSuggestionInformation::decode): Move encoding and decoding for DataListSuggestionInformation out of WebCoreArgumentCoders and into WebCore. * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::listAttributeTargetChanged): (WebCore::TextFieldInputType::suggestions): When computing suggestions, match label text in addition to values on ports that display label text in the chrome; for the time being, this is only the case for macOS, but will be extended to iOS as well in a future patch. Note that we don't plumb label text if it is already the same as the value, to avoid duplicate strings from showing up. (WebCore::TextFieldInputType::didCloseSuggestions): * html/TextFieldInputType.h: * loader/EmptyClients.h: * page/ChromeClient.h: Add a chrome client hook to return whether or not the client shows label text in its datalist UI. * platform/DataListSuggestionsClient.h: Source/WebKit: Add support on macOS for showing option labels in datalist suggestions. * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Shared/WebCoreArgumentCoders.h: Remove WebCoreArgumentCoders logic for encoding and decoding DataListSuggestionInformation. See DataListSuggestionInformation.h in WebCore for more detail. * UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp: (WebKit::WebDataListSuggestionsDropdownGtk::show): Tweak GTK code to adjust for the change from `String` to `DataListSuggestion`. * UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm: (-[WKDataListSuggestionsControl didSelectOptionAtIndex:]): (-[WKDataListSuggestionsControl textSuggestions]): (-[WKDataListSuggestionsControl suggestionAtIndex:]): Adjust some iOS codepaths to use DataListSuggestion::value as the value string to display. * UIProcess/mac/WebDataListSuggestionsDropdownMac.mm: Tweak several UI constants. A suggestion cell may now be either 20 or 40pt tall, depending on whether it has label text to show. Currently, the maximum combined height of the table view cells is 120 (not including spacing between cells and vertical padding around the top and bottom of the table view), since the maximum number of cells to show is 6 and each cell is 20pt tall. Maintain this constant by making the maximum cell height 120, which accomodates either three labeled cells, or 6 unlabeled cells (i.e. to match shipping behavior). (-[WKDataListSuggestionView initWithFrame:]): (-[WKDataListSuggestionView layout]): Maintain two text fields or value and (optionally) label text: `_valueField` and `_labelField`. The value field fills the bounds of the cell in the case where there is no label text, but fills only the top half of the cell in the case where there is label text. The label field takes the bottom half of the cell in this case. Additionally, add a divider view that may appear at the very bottom of each cell. This divider view is present when one or more suggestions in the datalist are labeled. (-[WKDataListSuggestionView setValue:label:]): Renamed from -setText:. Add a label string argument as well. (-[WKDataListSuggestionView setShouldShowBottomDivider:]): Add getters and setters for the -shouldShowBottomDivider property, which can be used to make the divider view visible or hidden. (-[WKDataListSuggestionView shouldShowBottomDivider]): (-[WKDataListSuggestionView setBackgroundStyle:]): Use -[NSColor secondaryLabelColor] for the label text field. (shouldShowDividersBetweenCells): Add a helper method to determine whether the table view should be showing clear dividers between each item. We only do so if there are one or more labels to be shown. (-[WKDataListSuggestionsController initWithInformation:inView:]): (-[WKDataListSuggestionsController currentSelectedString]): (-[WKDataListSuggestionsController updateWithInformation:]): (-[WKDataListSuggestionsController moveSelectionByDirection:]): Drive-by fix: scroll to reveal each selected row when using the arrow keys to navigate between items. (-[WKDataListSuggestionsController
[webkit-changes] [259329] trunk/Source/WebInspectorUI
Title: [259329] trunk/Source/WebInspectorUI
Revision 259329
Author j...@apple.com
Date 2020-03-31 17:55:30 -0700 (Tue, 31 Mar 2020)
Log Message
Added new WebSocket icon
https://bugs.webkit.org/show_bug.cgi?id=209433
Reviewed by Joseph Pecoraro.
Drive-by: remove unused #doc-orig
* UserInterface/Images/DocumentIcons.svg:
* UserInterface/Views/ResourceIcons.css:
(.resource-icon.resource-type-websocket .icon):
(@media (prefers-color-scheme: dark) .resource-icon.resource-type-websocket .icon):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Images/DocumentIcons.svg
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceIcons.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (259328 => 259329)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-04-01 00:45:13 UTC (rev 259328)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-04-01 00:55:30 UTC (rev 259329)
@@ -1,3 +1,17 @@
+2020-03-31 Jon Davis
+
+Added new WebSocket icon
+https://bugs.webkit.org/show_bug.cgi?id=209433
+
+Reviewed by Joseph Pecoraro.
+
+Drive-by: remove unused #doc-orig
+
+* UserInterface/Images/DocumentIcons.svg:
+* UserInterface/Views/ResourceIcons.css:
+(.resource-icon.resource-type-websocket .icon):
+(@media (prefers-color-scheme: dark) .resource-icon.resource-type-websocket .icon):
+
2020-03-30 Nikita Vasilyev
Web Inspector: the Dock Side navigation item is automatically focused when Web Inspector is opened detached, preventing any global spacebar shortcuts from working
Modified: trunk/Source/WebInspectorUI/UserInterface/Images/DocumentIcons.svg (259328 => 259329)
--- trunk/Source/WebInspectorUI/UserInterface/Images/DocumentIcons.svg 2020-04-01 00:45:13 UTC (rev 259328)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/DocumentIcons.svg 2020-04-01 00:55:30 UTC (rev 259329)
@@ -110,11 +110,6 @@
}
-
-
-
-
-
@@ -152,6 +147,14 @@
+
+
+
+
+
+
+
+
@@ -180,6 +183,8 @@
+
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceIcons.css (259328 => 259329)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceIcons.css 2020-04-01 00:45:13 UTC (rev 259328)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceIcons.css 2020-04-01 00:55:30 UTC (rev 259329)
@@ -96,7 +96,7 @@
}
.resource-icon.resource-type-websocket .icon {
-content: url(../Images/WebSocket.svg#light);
+content: url(../Images/DocumentIcons.svg#websocket-light);
}
.resource-icon.resource-type-ping .icon,
@@ -178,7 +178,7 @@
}
.resource-icon.resource-type-websocket .icon {
-content: url(../Images/WebSocket.svg#dark);
+content: url(../Images/DocumentIcons.svg#websocket-dark);
}
.resource-icon.resource-type-ping .icon,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259328] trunk
Title: [259328] trunk
Revision 259328
Author pvol...@apple.com
Date 2020-03-31 17:45:13 -0700 (Tue, 31 Mar 2020)
Log Message
[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
https://bugs.webkit.org/show_bug.cgi?id=209814
Reviewed by Darin Adler.
Source/WebKit:
This was done for iOS in , and in order to be able to do this
on macOS, checking in with Launch Services and updating the process name needs to be done after the
Launch Services database mapping has been done in WebProcess::platformInitializeWebProcess. Also, the
previous call to RegisterApplication has been replaced with a call to launchServicesCheckIn, since
RegisterApplication is an AppKit function, and should be avoided since the WebContent process is not
a NSApplication anymore.
Test: fast/sandbox/mac/sandbox-mach-lookup.html
* Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::launchServicesCheckIn):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::updateProcessName):
(WebKit::WebProcess::platformInitializeProcess):
* WebProcess/com.apple.WebProcess.sb.in:
LayoutTests:
* fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
* fast/sandbox/mac/sandbox-mach-lookup.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt
trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
Diff
Modified: trunk/LayoutTests/ChangeLog (259327 => 259328)
--- trunk/LayoutTests/ChangeLog 2020-04-01 00:31:15 UTC (rev 259327)
+++ trunk/LayoutTests/ChangeLog 2020-04-01 00:45:13 UTC (rev 259328)
@@ -1,3 +1,13 @@
+2020-03-31 Per Arne Vollan
+
+[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
+https://bugs.webkit.org/show_bug.cgi?id=209814
+
+Reviewed by Darin Adler.
+
+* fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
+* fast/sandbox/mac/sandbox-mach-lookup.html:
+
2020-03-31 Ryan Haddad
[ Catalina ] editing/mac/selection/context-menu-select-editability.html is failing on Catalina
Modified: trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt (259327 => 259328)
--- trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt 2020-04-01 00:31:15 UTC (rev 259327)
+++ trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt 2020-04-01 00:45:13 UTC (rev 259328)
@@ -8,4 +8,5 @@
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager.content-filter") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.system.logger") is false
+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.lsd.mapdb") is false
Modified: trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html (259327 => 259328)
--- trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html 2020-04-01 00:31:15 UTC (rev 259327)
+++ trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html 2020-04-01 00:45:13 UTC (rev 259328)
@@ -11,6 +11,7 @@
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager.content-filter\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.system.logger\")");
+shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.lsd.mapdb\")");
}
Modified: trunk/Source/WebKit/ChangeLog (259327 => 259328)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 00:31:15 UTC (rev 259327)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 00:45:13 UTC (rev 259328)
@@ -1,3 +1,30 @@
+2020-03-31 Per Arne Vollan
+
+[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
+https://bugs.webkit.org/show_bug.cgi?id=209814
+
+Reviewed by Darin Adler.
+
+This was done for iOS in , and in order to be able to do this
+on macOS, checking in with Launch Services and updating the process name needs to be done after the
+Launch Services database mapping has been done in WebProcess::platformInitializeWebProcess. Also, the
+previous call to RegisterApplication has been replaced
[webkit-changes] [259327] branches/safari-609-branch/Source/WebCore
Title: [259327] branches/safari-609-branch/Source/WebCore
Revision 259327
Author repst...@apple.com
Date 2020-03-31 17:31:15 -0700 (Tue, 31 Mar 2020)
Log Message
Cherry-pick r259305. rdar://problem/61131083
Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=209786
Patch by Pinki Gyanchandani on 2020-03-31
Reviewed by Ryosuke Niwa.
No new tests. Reduced test would be added later. Currently issue is verified with the original testcase in associated radar-58416328.
Webkit1 only issue, where m_client.dispatchDidCommitLoad in FrameLoader::dispatchDidCommitLoad could cause the frame
to be destroyed, and m_frame still being accessed outside. Changes made to protect the DocumentLoader and Frame.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/loader/DocumentLoader.cpp
branches/safari-609-branch/Source/WebCore/loader/FrameLoader.cpp
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (259326 => 259327)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-04-01 00:31:11 UTC (rev 259326)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-04-01 00:31:15 UTC (rev 259327)
@@ -1,5 +1,46 @@
2020-03-31 Russell Epstein
+Cherry-pick r259305. rdar://problem/61131083
+
+Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
+https://bugs.webkit.org/show_bug.cgi?id=209786
+
+Patch by Pinki Gyanchandani on 2020-03-31
+Reviewed by Ryosuke Niwa.
+
+No new tests. Reduced test would be added later. Currently issue is verified with the original testcase in associated radar-58416328.
+
+Webkit1 only issue, where m_client.dispatchDidCommitLoad in FrameLoader::dispatchDidCommitLoad could cause the frame
+to be destroyed, and m_frame still being accessed outside. Changes made to protect the DocumentLoader and Frame.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::finishedLoading):
+(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::receivedFirstData):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-31 Pinki Gyanchandani
+
+Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
+https://bugs.webkit.org/show_bug.cgi?id=209786
+
+Reviewed by Ryosuke Niwa.
+
+No new tests. Reduced test would be added later. Currently issue is verified with the original testcase in associated radar-58416328.
+
+Webkit1 only issue, where m_client.dispatchDidCommitLoad in FrameLoader::dispatchDidCommitLoad could cause the frame
+to be destroyed, and m_frame still being accessed outside. Changes made to protect the DocumentLoader and Frame.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::finishedLoading):
+(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::receivedFirstData):
+
+2020-03-31 Russell Epstein
+
Cherry-pick r259244. rdar://problem/61131078
Assertion failure in HTMLFormElement::formElementIndex
Modified: branches/safari-609-branch/Source/WebCore/loader/DocumentLoader.cpp (259326 => 259327)
--- branches/safari-609-branch/Source/WebCore/loader/DocumentLoader.cpp 2020-04-01 00:31:11 UTC (rev 259326)
+++ branches/safari-609-branch/Source/WebCore/loader/DocumentLoader.cpp 2020-04-01 00:31:15 UTC (rev 259327)
@@ -438,6 +438,9 @@
// DocumentWriter::begin() gets called and creates the Document.
if (!m_gotFirstByte)
commitData(0, 0);
+
+if (!frameLoader())
+return;
frameLoader()->client().finishedLoading(this);
}
@@ -474,6 +477,8 @@
void DocumentLoader::handleSubstituteDataLoadNow()
{
+Ref protectedThis = makeRef(*this);
+
ResourceResponse response = m_substituteData.response();
if (response.url().isEmpty())
response = ResourceResponse(m_request.url(), m_substituteData.mimeType(), m_substituteData.content()->size(), m_substituteData.textEncoding());
Modified: branches/safari-609-branch/Source/WebCore/loader/FrameLoader.cpp (259326 => 259327)
--- branches/safari-609-branch/Source/WebCore/loader/FrameLoader.cpp 2020-04-01 00:31:11 UTC (rev 259326)
+++ branches/safari-609-branch/Source/WebCore/loader/FrameLoader.cpp 2020-04-01 00:31:15 UTC (rev 259327)
@@ -705,6 +705,8
[webkit-changes] [259326] branches/safari-609-branch/Source/WebCore
Title: [259326] branches/safari-609-branch/Source/WebCore
Revision 259326
Author repst...@apple.com
Date 2020-03-31 17:31:11 -0700 (Tue, 31 Mar 2020)
Log Message
Cherry-pick r259244. rdar://problem/61131078
Assertion failure in HTMLFormElement::formElementIndex
https://bugs.webkit.org/show_bug.cgi?id=209643
Reviewed by Darin Adler.
The bug was caused by FormAssociatedElement::findAssociatedForm finding a wrong form element
when it's called on an element which appears later in the removed subtree.
When we find the new form element to associate this element with, check to make sure its root
element is that of the tree scope. This condition will be false if this element is in in the midst
of being removed.
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::findAssociatedForm):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/html/FormAssociatedElement.cpp
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (259325 => 259326)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-04-01 00:12:10 UTC (rev 259325)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-04-01 00:31:11 UTC (rev 259326)
@@ -1,5 +1,44 @@
2020-03-31 Russell Epstein
+Cherry-pick r259244. rdar://problem/61131078
+
+Assertion failure in HTMLFormElement::formElementIndex
+https://bugs.webkit.org/show_bug.cgi?id=209643
+
+Reviewed by Darin Adler.
+
+The bug was caused by FormAssociatedElement::findAssociatedForm finding a wrong form element
+when it's called on an element which appears later in the removed subtree.
+
+When we find the new form element to associate this element with, check to make sure its root
+element is that of the tree scope. This condition will be false if this element is in in the midst
+of being removed.
+
+* html/FormAssociatedElement.cpp:
+(WebCore::FormAssociatedElement::findAssociatedForm):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-27 Ryosuke Niwa
+
+Assertion failure in HTMLFormElement::formElementIndex
+https://bugs.webkit.org/show_bug.cgi?id=209643
+
+Reviewed by Darin Adler.
+
+The bug was caused by FormAssociatedElement::findAssociatedForm finding a wrong form element
+when it's called on an element which appears later in the removed subtree.
+
+When we find the new form element to associate this element with, check to make sure its root
+element is that of the tree scope. This condition will be false if this element is in in the midst
+of being removed.
+
+* html/FormAssociatedElement.cpp:
+(WebCore::FormAssociatedElement::findAssociatedForm):
+
+2020-03-31 Russell Epstein
+
Cherry-pick r258326. rdar://problem/61113047
Remove no longer used code in LibWebRTCMediaEndpoint to handle remote streams
Modified: branches/safari-609-branch/Source/WebCore/html/FormAssociatedElement.cpp (259325 => 259326)
--- branches/safari-609-branch/Source/WebCore/html/FormAssociatedElement.cpp 2020-04-01 00:12:10 UTC (rev 259325)
+++ branches/safari-609-branch/Source/WebCore/html/FormAssociatedElement.cpp 2020-04-01 00:31:11 UTC (rev 259326)
@@ -108,9 +108,12 @@
// the value of form attribute, so we put the result of
// treeScope().getElementById() over the given element.
RefPtr newFormCandidate = element->treeScope().getElementById(formId);
-if (is(newFormCandidate))
+if (!is(newFormCandidate))
+return nullptr;
+if (>traverseToRootNode() == >treeScope().rootNode()) {
+ASSERT(>traverseToRootNode() == >traverseToRootNode());
return downcast(newFormCandidate.get());
-return nullptr;
+}
}
if (!currentAssociatedForm)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259325] trunk/Source
Title: [259325] trunk/Source
Revision 259325
Author don.olmst...@sony.com
Date 2020-03-31 17:12:10 -0700 (Tue, 31 Mar 2020)
Log Message
[PlayStation] Fix build breaks after r259112
https://bugs.webkit.org/show_bug.cgi?id=209830
Unreviewed build fix.
Source/WebCore:
Add USE(GLIB) guards around RunLoopSourcePriority usage.
* platform/ScrollAnimationKinetic.cpp:
(WebCore::ScrollAnimationKinetic::ScrollAnimationKinetic):
Source/WebKit:
Replace PLATFORM(WPE) with USE(LIBWPE) within WebWheelEvent.
* Shared/WebEvent.h:
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::encode const):
(WebKit::WebWheelEvent::decode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollAnimationKinetic.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebEvent.h
trunk/Source/WebKit/Shared/WebWheelEvent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259324 => 259325)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 00:09:44 UTC (rev 259324)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 00:12:10 UTC (rev 259325)
@@ -1,3 +1,15 @@
+2020-03-31 Don Olmstead
+
+[PlayStation] Fix build breaks after r259112
+https://bugs.webkit.org/show_bug.cgi?id=209830
+
+Unreviewed build fix.
+
+Add USE(GLIB) guards around RunLoopSourcePriority usage.
+
+* platform/ScrollAnimationKinetic.cpp:
+(WebCore::ScrollAnimationKinetic::ScrollAnimationKinetic):
+
2020-03-31 Sihui Liu
IndexedDB: destroy WebIDBServer when session is removed in network process
Modified: trunk/Source/WebCore/platform/ScrollAnimationKinetic.cpp (259324 => 259325)
--- trunk/Source/WebCore/platform/ScrollAnimationKinetic.cpp 2020-04-01 00:09:44 UTC (rev 259324)
+++ trunk/Source/WebCore/platform/ScrollAnimationKinetic.cpp 2020-04-01 00:12:10 UTC (rev 259325)
@@ -27,7 +27,10 @@
#include "ScrollAnimationKinetic.h"
#include "PlatformWheelEvent.h"
+
+#if USE(GLIB)
#include
+#endif
/*
* PerAxisData is a port of GtkKineticScrolling as of GTK+ 3.20,
@@ -111,7 +114,9 @@
, m_notifyPositionChangedFunction(WTFMove(notifyPositionChangedFunction))
, m_animationTimer(RunLoop::current(), this, ::animationTimerFired)
{
+#if USE(GLIB)
m_animationTimer.setPriority(WTF::RunLoopSourcePriority::DisplayRefreshMonitorTimer);
+#endif
}
ScrollAnimationKinetic::~ScrollAnimationKinetic() = default;
Modified: trunk/Source/WebKit/ChangeLog (259324 => 259325)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 00:09:44 UTC (rev 259324)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 00:12:10 UTC (rev 259325)
@@ -1,3 +1,17 @@
+2020-03-31 Don Olmstead
+
+[PlayStation] Fix build breaks after r259112
+https://bugs.webkit.org/show_bug.cgi?id=209830
+
+Unreviewed build fix.
+
+Replace PLATFORM(WPE) with USE(LIBWPE) within WebWheelEvent.
+
+* Shared/WebEvent.h:
+* Shared/WebWheelEvent.cpp:
+(WebKit::WebWheelEvent::encode const):
+(WebKit::WebWheelEvent::decode):
+
2020-03-31 Alex Christensen
Send correct UserContentControllerIdentifier after using SPI WKWebpagePreferences._userContentController
Modified: trunk/Source/WebKit/Shared/WebEvent.h (259324 => 259325)
--- trunk/Source/WebKit/Shared/WebEvent.h 2020-04-01 00:09:44 UTC (rev 259324)
+++ trunk/Source/WebKit/Shared/WebEvent.h 2020-04-01 00:12:10 UTC (rev 259325)
@@ -205,7 +205,7 @@
WebWheelEvent(Type, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, const WebCore::FloatSize& delta, const WebCore::FloatSize& wheelTicks, Granularity, OptionSet, WallTime timestamp);
#if PLATFORM(COCOA)
WebWheelEvent(Type, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, const WebCore::FloatSize& delta, const WebCore::FloatSize& wheelTicks, Granularity, bool directionInvertedFromDevice, Phase, Phase momentumPhase, bool hasPreciseScrollingDeltas, uint32_t scrollCount, const WebCore::FloatSize& unacceleratedScrollingDelta, OptionSet, WallTime timestamp);
-#elif PLATFORM(GTK) || PLATFORM(WPE)
+#elif PLATFORM(GTK) || USE(LIBWPE)
WebWheelEvent(Type, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, const WebCore::FloatSize& delta, const WebCore::FloatSize& wheelTicks, Phase, Phase momentumPhase, Granularity, OptionSet, WallTime timestamp);
#endif
Modified: trunk/Source/WebKit/Shared/WebWheelEvent.cpp (259324 => 259325)
--- trunk/Source/WebKit/Shared/WebWheelEvent.cpp 2020-04-01 00:09:44 UTC (rev 259324)
+++ trunk/Source/WebKit/Shared/WebWheelEvent.cpp 2020-04-01 00:12:10 UTC (rev 259325)
@@ -65,7 +65,7 @@
{
ASSERT(isWheelEventType(type));
}
-#elif PLATFORM(GTK) || PLATFORM(WPE)
+#elif PLATFORM(GTK) || USE(LIBWPE)
WebWheelEvent::WebWheelEvent(Type type, const IntPoint& position, const IntPoint& globalPosition, const FloatSize& delta, const FloatSize& wheelTicks, Phase phase, Phase momentumPhase, Granularity granularity, OptionSet modifiers,
[webkit-changes] [259324] trunk
Title: [259324] trunk
Revision 259324
Author achristen...@apple.com
Date 2020-03-31 17:09:44 -0700 (Tue, 31 Mar 2020)
Log Message
Send correct UserContentControllerIdentifier after using SPI WKWebpagePreferences._userContentController
https://bugs.webkit.org/show_bug.cgi?id=209833
Reviewed by Tim Hatcher.
Source/WebKit:
Covered by an API test. I knew something was broken in r259307 and this was it.
* Shared/UserContentControllerParameters.cpp:
(WebKit::UserContentControllerParameters::encode const):
(WebKit::UserContentControllerParameters::decode):
* Shared/UserContentControllerParameters.h:
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::parameters const):
* UIProcess/WebPageProxy.cpp:
* WebProcess/WebPage/WebPage.cpp:
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/UserContentControllerParameters.cpp
trunk/Source/WebKit/Shared/UserContentControllerParameters.h
trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp
trunk/Source/WebKit/Shared/WebPageCreationParameters.h
trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (259323 => 259324)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 00:05:04 UTC (rev 259323)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 00:09:44 UTC (rev 259324)
@@ -1,3 +1,25 @@
+2020-03-31 Alex Christensen
+
+Send correct UserContentControllerIdentifier after using SPI WKWebpagePreferences._userContentController
+https://bugs.webkit.org/show_bug.cgi?id=209833
+
+Reviewed by Tim Hatcher.
+
+Covered by an API test. I knew something was broken in r259307 and this was it.
+
+* Shared/UserContentControllerParameters.cpp:
+(WebKit::UserContentControllerParameters::encode const):
+(WebKit::UserContentControllerParameters::decode):
+* Shared/UserContentControllerParameters.h:
+* Shared/WebPageCreationParameters.cpp:
+(WebKit::WebPageCreationParameters::encode const):
+(WebKit::WebPageCreationParameters::decode):
+* Shared/WebPageCreationParameters.h:
+* UIProcess/UserContent/WebUserContentControllerProxy.cpp:
+(WebKit::WebUserContentControllerProxy::parameters const):
+* UIProcess/WebPageProxy.cpp:
+* WebProcess/WebPage/WebPage.cpp:
+
2020-03-31 Fujii Hironori
Deduplicate WebsiteDataStore::parameters() of Cocoa port and non-Cocoa port
Modified: trunk/Source/WebKit/Shared/UserContentControllerParameters.cpp (259323 => 259324)
--- trunk/Source/WebKit/Shared/UserContentControllerParameters.cpp 2020-04-01 00:05:04 UTC (rev 259323)
+++ trunk/Source/WebKit/Shared/UserContentControllerParameters.cpp 2020-04-01 00:09:44 UTC (rev 259324)
@@ -33,6 +33,7 @@
void UserContentControllerParameters::encode(IPC::Encoder& encoder) const
{
+encoder << identifier;
encoder << userContentWorlds;
encoder << userScripts;
encoder << userStyleSheets;
@@ -44,6 +45,11 @@
Optional UserContentControllerParameters::decode(IPC::Decoder& decoder)
{
+Optional identifier;
+decoder >> identifier;
+if (!identifier)
+return WTF::nullopt;
+
Optional>> userContentWorlds;
decoder >> userContentWorlds;
if (!userContentWorlds)
@@ -72,6 +78,7 @@
#endif
return {{
+WTFMove(*identifier),
WTFMove(*userContentWorlds),
WTFMove(*userScripts),
WTFMove(*userStyleSheets),
Modified: trunk/Source/WebKit/Shared/UserContentControllerParameters.h (259323 => 259324)
--- trunk/Source/WebKit/Shared/UserContentControllerParameters.h 2020-04-01 00:05:04 UTC (rev 259323)
+++ trunk/Source/WebKit/Shared/UserContentControllerParameters.h 2020-04-01 00:09:44 UTC (rev 259324)
@@ -25,6 +25,7 @@
#pragma once
+#include "UserContentControllerIdentifier.h"
#include "WebCompiledContentRuleListData.h"
#include "WebUserContentControllerDataTypes.h"
@@ -37,6 +38,7 @@
struct UserContentControllerParameters {
+UserContentControllerIdentifier identifier;
Vector> userContentWorlds;
Vector userScripts;
Vector userStyleSheets;
Modified: trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp (259323 => 259324)
--- trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp 2020-04-01 00:05:04 UTC (rev 259323)
+++ trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp 2020-04-01 00:09:44 UTC (rev 259324)
@@ -54,7 +54,6 @@
encoder << userAgent;
encoder << itemStatesWereRestoredByAPIRequest;
[webkit-changes] [259323] trunk/Source/WebKit
Title: [259323] trunk/Source/WebKit
Revision 259323
Author hironori.fu...@sony.com
Date 2020-03-31 17:05:04 -0700 (Tue, 31 Mar 2020)
Log Message
Deduplicate WebsiteDataStore::parameters() of Cocoa port and non-Cocoa port
https://bugs.webkit.org/show_bug.cgi?id=209644
Reviewed by Youenn Fablet.
WinCairo WTR was failing an assertion ensuring
ResourceLoadStatistics was enabled in
NetworkSession::setThirdPartyCookieBlockingMode while running
LayoutTests with useEphemeralSession=true becuase
ResourceLoadStatisticsParameters was not set in
WebsiteDataStoreParameters.
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::platformSetNetworkParameters): Added.
(WebKit::WebsiteDataStore::parameters): Deleted.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::parameters):
* UIProcess/WebsiteData/WebsiteDataStore.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (259322 => 259323)
--- trunk/Source/WebKit/ChangeLog 2020-03-31 23:58:47 UTC (rev 259322)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 00:05:04 UTC (rev 259323)
@@ -1,3 +1,24 @@
+2020-03-31 Fujii Hironori
+
+Deduplicate WebsiteDataStore::parameters() of Cocoa port and non-Cocoa port
+https://bugs.webkit.org/show_bug.cgi?id=209644
+
+Reviewed by Youenn Fablet.
+
+WinCairo WTR was failing an assertion ensuring
+ResourceLoadStatistics was enabled in
+NetworkSession::setThirdPartyCookieBlockingMode while running
+LayoutTests with useEphemeralSession=true becuase
+ResourceLoadStatisticsParameters was not set in
+WebsiteDataStoreParameters.
+
+* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
+(WebKit::WebsiteDataStore::platformSetNetworkParameters): Added.
+(WebKit::WebsiteDataStore::parameters): Deleted.
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::parameters):
+* UIProcess/WebsiteData/WebsiteDataStore.h:
+
2020-03-31 Brent Fulgham
Allow WKAppBoundDomains to be initialized with eTLD+1 only (no protocol)
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm (259322 => 259323)
--- trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm 2020-03-31 23:58:47 UTC (rev 259322)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm 2020-04-01 00:05:04 UTC (rev 259323)
@@ -90,12 +90,10 @@
}
#endif
-WebsiteDataStoreParameters WebsiteDataStore::parameters()
+void WebsiteDataStore::platformSetNetworkParameters(WebsiteDataStoreParameters& parameters)
{
ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));
-resolveDirectoriesIfNecessary();
-
NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
bool shouldLogCookieInformation = false;
bool enableResourceLoadStatisticsDebugMode = false;
@@ -154,16 +152,6 @@
if (!httpsProxy.isValid() && (isSafari || isMiniBrowser))
httpsProxy = URL(URL(), [defaults stringForKey:(NSString *)WebKit2HTTPSProxyDefaultsKey]);
-auto resourceLoadStatisticsDirectory = m_configuration->resourceLoadStatisticsDirectory();
-SandboxExtension::Handle resourceLoadStatisticsDirectoryHandle;
-if (!resourceLoadStatisticsDirectory.isEmpty())
-SandboxExtension::createHandleForReadWriteDirectory(resourceLoadStatisticsDirectory, resourceLoadStatisticsDirectoryHandle);
-
-auto networkCacheDirectory = resolvedNetworkCacheDirectory();
-SandboxExtension::Handle networkCacheDirectoryExtensionHandle;
-if (!networkCacheDirectory.isEmpty())
-SandboxExtension::createHandleForReadWriteDirectory(networkCacheDirectory, networkCacheDirectoryExtensionHandle);
-
#if HAVE(CFNETWORK_ALTERNATIVE_SERVICE)
String alternativeServiceStorageDirectory = resolvedAlternativeServicesStorageDirectory();
SandboxExtension::Handle alternativeServiceStorageDirectoryExtensionHandle;
@@ -175,53 +163,24 @@
bool shouldIncludeLocalhostInResourceLoadStatistics = isSafari;
bool isInAppBrowserPrivacyEnabled = [defaults boolForKey:[NSString stringWithFormat:@"WebKitDebug%@", WebPreferencesKey::isInAppBrowserPrivacyEnabledKey().createCFString().get()]];
-WebsiteDataStoreParameters parameters;
-
-ResourceLoadStatisticsParameters resourceLoadStatisticsParameters {
-WTFMove(resourceLoadStatisticsDirectory),
-WTFMove(resourceLoadStatisticsDirectoryHandle),
-resourceLoadStatisticsEnabled(),
-isItpStateExplicitlySet(),
-hasStatisticsTestingCallback(),
-shouldIncludeLocalhostInResourceLoadStatistics,
-enableResourceLoadStatisticsDebugMode,
-
[webkit-changes] [259322] trunk
Title: [259322] trunk
Revision 259322
Author bfulg...@apple.com
Date 2020-03-31 16:58:47 -0700 (Tue, 31 Mar 2020)
Log Message
Allow WKAppBoundDomains to be initialized with eTLD+1 only (no protocol)
https://bugs.webkit.org/show_bug.cgi?id=209839
Reviewed by Darin Adler.
Source/WebKit:
Create a convenience mode for WKAppBoundDomains that assumes https if the user does
not supply the full URL. This doesn't effect the behavior of the app-bound domains
because we only deal in RegistrableDomains.
Tested by TestWebKitAPI.
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::initializeAppBoundDomains): If the protocol is missing from
a domain supplied by WKAppBoundDomains, assume it was https.
Tools:
* TestWebKitAPI/Info.plist:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Info.plist
Diff
Modified: trunk/Source/WebKit/ChangeLog (259321 => 259322)
--- trunk/Source/WebKit/ChangeLog 2020-03-31 23:47:47 UTC (rev 259321)
+++ trunk/Source/WebKit/ChangeLog 2020-03-31 23:58:47 UTC (rev 259322)
@@ -1,5 +1,23 @@
2020-03-31 Brent Fulgham
+Allow WKAppBoundDomains to be initialized with eTLD+1 only (no protocol)
+https://bugs.webkit.org/show_bug.cgi?id=209839
+
+
+Reviewed by Darin Adler.
+
+Create a convenience mode for WKAppBoundDomains that assumes https if the user does
+not supply the full URL. This doesn't effect the behavior of the app-bound domains
+because we only deal in RegistrableDomains.
+
+Tested by TestWebKitAPI.
+
+* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
+(WebKit::WebsiteDataStore::initializeAppBoundDomains): If the protocol is missing from
+a domain supplied by WKAppBoundDomains, assume it was https.
+
+2020-03-31 Brent Fulgham
+
[macOS] Update sandbox rules for correct sanitizer paths in current OS releases
https://bugs.webkit.org/show_bug.cgi?id=209818
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm (259321 => 259322)
--- trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm 2020-03-31 23:47:47 UTC (rev 259321)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm 2020-03-31 23:58:47 UTC (rev 259322)
@@ -486,6 +486,8 @@
for (NSString *domain in domains.get()) {
URL url { URL(), domain };
+if (url.protocol().isEmpty())
+url.setProtocol("https"_s);
if (!url.isValid())
continue;
WebCore::RegistrableDomain appBoundDomain { url };
Modified: trunk/Tools/ChangeLog (259321 => 259322)
--- trunk/Tools/ChangeLog 2020-03-31 23:47:47 UTC (rev 259321)
+++ trunk/Tools/ChangeLog 2020-03-31 23:58:47 UTC (rev 259322)
@@ -1,3 +1,13 @@
+2020-03-31 Brent Fulgham
+
+Allow WKAppBoundDomains to be initialized with eTLD+1 only (no protocol)
+https://bugs.webkit.org/show_bug.cgi?id=209839
+
+
+Reviewed by Darin Adler.
+
+* TestWebKitAPI/Info.plist:
+
2020-03-31 Alex Christensen
Add SPI WKWebpagePreferences._userContentController
Modified: trunk/Tools/TestWebKitAPI/Info.plist (259321 => 259322)
--- trunk/Tools/TestWebKitAPI/Info.plist 2020-03-31 23:47:47 UTC (rev 259321)
+++ trunk/Tools/TestWebKitAPI/Info.plist 2020-03-31 23:58:47 UTC (rev 259322)
@@ -5,10 +5,11 @@
WKAppBoundDomains
testDomain1
- https://sub.domain.webkit.org/road/to/nowhere/
- https://webkit.org
- https://localhost:8000
- http://localhost/road/to/nowhere/
+ apple.com
+ sub.domain.webkit.org/road/to/nowhere/
+ webkit.org
+ localhost:8000
+ localhost/road/to/nowhere/
file:///some/file
127.0.0.1
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259321] trunk/LayoutTests
Title: [259321] trunk/LayoutTests Revision 259321 Author ryanhad...@apple.com Date 2020-03-31 16:47:47 -0700 (Tue, 31 Mar 2020) Log Message [ Catalina ] editing/mac/selection/context-menu-select-editability.html is failing on Catalina https://bugs.webkit.org/show_bug.cgi?id=204246 Unreviewed test gardening. * platform/mac/TestExpectations: Remove failure expectation since the test is now passing. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259320 => 259321) --- trunk/LayoutTests/ChangeLog 2020-03-31 23:41:50 UTC (rev 259320) +++ trunk/LayoutTests/ChangeLog 2020-03-31 23:47:47 UTC (rev 259321) @@ -1,3 +1,12 @@ +2020-03-31 Ryan Haddad + +[ Catalina ] editing/mac/selection/context-menu-select-editability.html is failing on Catalina +https://bugs.webkit.org/show_bug.cgi?id=204246 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: Remove failure expectation since the test is now passing. + 2020-03-31 Jason Lawrence [ Mojave wk1 Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html is timing out. Modified: trunk/LayoutTests/platform/mac/TestExpectations (259320 => 259321) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-31 23:41:50 UTC (rev 259320) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-31 23:47:47 UTC (rev 259321) @@ -1816,8 +1816,6 @@ webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-8.html [ ImageOnlyFailure ] webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-9.html [ ImageOnlyFailure ] -webkit.org/b/204246 [ Catalina ] editing/mac/selection/context-menu-select-editability.html [ Pass Failure ] - webkit.org/b/204247 [ Catalina ] webaudio/silence-after-playback.html [ Failure ] webkit.org/b/205216 imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259320] trunk/Source/JavaScriptCore
Title: [259320] trunk/Source/_javascript_Core Revision 259320 Author ysuz...@apple.com Date 2020-03-31 16:41:50 -0700 (Tue, 31 Mar 2020) Log Message [JSC] Introduce UCPUStrictInt32 for result type of DFG operations https://bugs.webkit.org/show_bug.cgi?id=209832 Reviewed by Saam Barati. Let's introduce UCPUStrictInt32 to DFG operations to offload StrictInt32 code into operations C++ code. UCPUStrictInt32 is the same size to UCPURegister, and it is used for StrictInt32, which requires upper 32-bits are zeroed. * assembler/CPU.h: * dfg/DFGOperations.cpp: * dfg/DFGOperations.h: * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetCharCodeAt): (JSC::DFG::SpeculativeJIT::compileValueToInt32): (JSC::DFG::SpeculativeJIT::compileUInt32ToNumber): (JSC::DFG::SpeculativeJIT::compileDoubleAsInt32): (JSC::DFG::SpeculativeJIT::setIntTypedArrayLoadResult): (JSC::DFG::SpeculativeJIT::compileBitwiseNot): (JSC::DFG::SpeculativeJIT::compileBitwiseOp): (JSC::DFG::SpeculativeJIT::compileShiftOp): (JSC::DFG::SpeculativeJIT::compileArithAdd): (JSC::DFG::SpeculativeJIT::compileArithAbs): (JSC::DFG::SpeculativeJIT::compileArithClz32): (JSC::DFG::SpeculativeJIT::compileArithSub): (JSC::DFG::SpeculativeJIT::compileArithNegate): (JSC::DFG::SpeculativeJIT::compileArithMul): (JSC::DFG::SpeculativeJIT::compileArithDiv): (JSC::DFG::SpeculativeJIT::compileArithMod): (JSC::DFG::SpeculativeJIT::compileArithRounding): (JSC::DFG::SpeculativeJIT::compileArithMinMax): (JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset): (JSC::DFG::SpeculativeJIT::compileGetArrayLength): (JSC::DFG::SpeculativeJIT::compileVarargsLength): (JSC::DFG::SpeculativeJIT::compileGetRestLength): (JSC::DFG::SpeculativeJIT::compileArrayIndexOf): (JSC::DFG::SpeculativeJIT::compileGetEnumerableLength): (JSC::DFG::SpeculativeJIT::compileGetArgumentCountIncludingThis): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::strictInt32Result): (JSC::DFG::SpeculativeJIT::int32Result): Deleted. * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): (JSC::DFG::SpeculativeJIT::compileStringCodePointAt): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileArithClz32): (JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf): (JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength): (JSC::FTL::DFG::LowerDFGToB3::mapHashString): (JSC::FTL::DFG::LowerDFGToB3::compileMapHash): (JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty): (JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom): (JSC::FTL::DFG::LowerDFGToB3::doubleToInt32): (JSC::FTL::DFG::LowerDFGToB3::sensibleDoubleToInt32): * ftl/FTLOperations.cpp: (JSC::FTL::operationSwitchStringAndGetBranchOffset): (JSC::FTL::operationTypeOfObjectAsTypeofType): * ftl/FTLOperations.h: * jit/JITOperations.cpp: * jit/JITOperations.h: * runtime/MathCommon.cpp: (JSC::operationToInt32): (JSC::operationToInt32SensibleSlow): * runtime/MathCommon.h: (JSC::toUCPUStrictInt32): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/CPU.h trunk/Source/_javascript_Core/dfg/DFGOperations.cpp trunk/Source/_javascript_Core/dfg/DFGOperations.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp trunk/Source/_javascript_Core/ftl/FTLOperations.cpp trunk/Source/_javascript_Core/ftl/FTLOperations.h trunk/Source/_javascript_Core/jit/JITOperations.cpp trunk/Source/_javascript_Core/jit/JITOperations.h trunk/Source/_javascript_Core/runtime/MathCommon.cpp trunk/Source/_javascript_Core/runtime/MathCommon.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (259319 => 259320) --- trunk/Source/_javascript_Core/ChangeLog 2020-03-31 23:03:29 UTC (rev 259319) +++ trunk/Source/_javascript_Core/ChangeLog 2020-03-31 23:41:50 UTC (rev 259320) @@ -1,3 +1,73 @@ +2020-03-31 Yusuke Suzuki + +[JSC] Introduce UCPUStrictInt32 for result type of DFG operations +https://bugs.webkit.org/show_bug.cgi?id=209832 + +Reviewed by Saam Barati. + +Let's introduce UCPUStrictInt32 to DFG operations to offload StrictInt32 code into operations C++ code. +UCPUStrictInt32 is the same size to UCPURegister, and it is used for StrictInt32, which requires upper 32-bits +are zeroed. + +* assembler/CPU.h: +* dfg/DFGOperations.cpp: +* dfg/DFGOperations.h: +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt): +(JSC::DFG::SpeculativeJIT::compileValueToInt32): +(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber): +(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32): +(JSC::DFG::SpeculativeJIT::setIntTypedArrayLoadResult): +(JSC::DFG::SpeculativeJIT::compileBitwiseNot): +
[webkit-changes] [259319] trunk/LayoutTests
Title: [259319] trunk/LayoutTests Revision 259319 Author lawrenc...@apple.com Date 2020-03-31 16:03:29 -0700 (Tue, 31 Mar 2020) Log Message [ Mojave wk1 Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html is timing out. https://bugs.webkit.org/show_bug.cgi?id=209837 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259318 => 259319) --- trunk/LayoutTests/ChangeLog 2020-03-31 22:41:15 UTC (rev 259318) +++ trunk/LayoutTests/ChangeLog 2020-03-31 23:03:29 UTC (rev 259319) @@ -1,5 +1,14 @@ 2020-03-31 Jason Lawrence +[ Mojave wk1 Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html is timing out. +https://bugs.webkit.org/show_bug.cgi?id=209837 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + +2020-03-31 Jason Lawrence + [ Mac wk1 Debug] inspector/injected-script/avoid-getter-invocation.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=209073 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259318 => 259319) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-31 22:41:15 UTC (rev 259318) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-31 23:03:29 UTC (rev 259319) @@ -945,3 +945,5 @@ webkit.org/b/209560 imported/w3c/web-platform-tests/xhr/send-response-upload-event-progress.htm [ Pass Crash Failure ] webkit.org/b/209621 fast/loader/child-frame-add-after-back-forward.html [ Pass Timeout ] + +webkit.org/b/209837 [ Mojave Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html [ Pass Timeout ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259318] trunk/LayoutTests
Title: [259318] trunk/LayoutTests Revision 259318 Author lawrenc...@apple.com Date 2020-03-31 15:41:15 -0700 (Tue, 31 Mar 2020) Log Message [ Mac wk1 Debug] inspector/injected-script/avoid-getter-invocation.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=209073 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259317 => 259318) --- trunk/LayoutTests/ChangeLog 2020-03-31 22:38:00 UTC (rev 259317) +++ trunk/LayoutTests/ChangeLog 2020-03-31 22:41:15 UTC (rev 259318) @@ -1,3 +1,12 @@ +2020-03-31 Jason Lawrence + +[ Mac wk1 Debug] inspector/injected-script/avoid-getter-invocation.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=209073 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2020-03-31 Ryan Haddad Unreviewed test gardening for iOS and macOS. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259317 => 259318) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-31 22:38:00 UTC (rev 259317) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-31 22:41:15 UTC (rev 259318) @@ -930,7 +930,7 @@ webkit.org/b/209067 http/tests/security/_javascript_URL/xss-DENIED-to-_javascript_-url-in-foreign-domain-subframe.html [ Pass Failure ] -webkit.org/b/209073 [ Debug ] inspector/injected-script/avoid-getter-invocation.html [ Pass Failure ] +webkit.org/b/209073 [ Debug ] inspector/injected-script/avoid-getter-invocation.html [ Pass Failure Timeout ] webkit.org/b/209154 http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259317] trunk/Source/WebKit
Title: [259317] trunk/Source/WebKit Revision 259317 Author bfulg...@apple.com Date 2020-03-31 15:38:00 -0700 (Tue, 31 Mar 2020) Log Message [macOS] Update sandbox rules for correct sanitizer paths in current OS releases https://bugs.webkit.org/show_bug.cgi?id=209818 Reviewed by Per Arne Vollan. Update the sandbox rules to allow access to the new system Asan library locations. * GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: Note: Don't bother leaving the old location in this sandbox, since it is not being used on any shipping software. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (259316 => 259317) --- trunk/Source/WebKit/ChangeLog 2020-03-31 22:19:25 UTC (rev 259316) +++ trunk/Source/WebKit/ChangeLog 2020-03-31 22:38:00 UTC (rev 259317) @@ -1,3 +1,20 @@ +2020-03-31 Brent Fulgham + +[macOS] Update sandbox rules for correct sanitizer paths in current OS releases +https://bugs.webkit.org/show_bug.cgi?id=209818 + + +Reviewed by Per Arne Vollan. + +Update the sandbox rules to allow access to the new system Asan library +locations. + +* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: Note: Don't bother leaving +the old location in this sandbox, since it is not being used on any shipping +software. +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: +* WebProcess/com.apple.WebProcess.sb.in: + 2020-03-31 Sihui Liu IndexedDB: destroy WebIDBServer when session is removed in network process Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (259316 => 259317) --- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2020-03-31 22:19:25 UTC (rev 259316) +++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2020-03-31 22:38:00 UTC (rev 259317) @@ -58,7 +58,7 @@ (subpath "/System/Library/Frameworks") (subpath "/System/Library/PrivateFrameworks") (subpath "/usr/lib") -(literal "/usr/local/lib/sanitizers")) +(subpath "/usr/appleinternal/lib/sanitizers")) (allow file-read-metadata (literal "/etc") Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (259316 => 259317) --- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2020-03-31 22:19:25 UTC (rev 259316) +++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2020-03-31 22:38:00 UTC (rev 259317) @@ -44,7 +44,8 @@ (subpath "/System/Library/Frameworks") (subpath "/System/Library/PrivateFrameworks") (subpath "/usr/lib") - (literal "/usr/local/lib/sanitizers")) + (literal "/usr/local/lib/sanitizers") ;; FIXME(209820) + (subpath "/usr/appleinternal/lib/sanitizers")) (allow file-read-metadata (literal "/etc") @@ -86,7 +87,8 @@ (literal "/dev/dtracehelper")) (allow file-read* - (literal "/usr/local/lib/sanitizers")) + (literal "/usr/local/lib/sanitizers") ;; FIXME(209820) + (subpath "/usr/appleinternal/lib/sanitizers")) (allow file-write-create (require-all (prefix "/cores/") Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (259316 => 259317) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-03-31 22:19:25 UTC (rev 259316) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-03-31 22:38:00 UTC (rev 259317) @@ -58,7 +58,8 @@ (subpath "/System/Library/Frameworks") (subpath "/System/Library/PrivateFrameworks") (subpath "/usr/lib") -(literal "/usr/local/lib/sanitizers")) +(literal "/usr/local/lib/sanitizers") ;; FIXME(209820) +(subpath "/usr/appleinternal/lib/sanitizers")) (allow file-read-metadata (literal "/etc") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259316] trunk/Source
Title: [259316] trunk/Source
Revision 259316
Author sihui_...@apple.com
Date 2020-03-31 15:19:25 -0700 (Tue, 31 Mar 2020)
Log Message
IndexedDB: destroy WebIDBServer when session is removed in network process
https://bugs.webkit.org/show_bug.cgi?id=209606
Reviewed by Geoffrey Garen.
Source/WebCore:
Rename immediateCloseForUserDelete to immediateClose as we now use it in destructor of IDBServer to make sure
everything in database finishes correctly.
* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::~IDBServer):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::immediateClose):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete): Deleted.
* Modules/indexeddb/server/UniqueIDBDatabase.h:
Source/WebKit:
Tested manually to verify WebIDBServer is removed and its thread ends when session is removed.
* NetworkProcess/IndexedDB/WebIDBServer.cpp:
(WebKit::WebIDBServer::~WebIDBServer):
(WebKit::WebIDBServer::addConnection):
(WebKit::WebIDBServer::removeConnection):
(WebKit::WebIDBServer::close):
* NetworkProcess/IndexedDB/WebIDBServer.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::connectionToWebProcessClosed):
Source/WTF:
Add function to kill CrossThreadTaskHandler and make thread finish. Also add a callback to be called before
thread finishes.
* wtf/CrossThreadTaskHandler.cpp:
(WTF::CrossThreadTaskHandler::CrossThreadTaskHandler):
(WTF::CrossThreadTaskHandler::setCompletionCallback):
(WTF::CrossThreadTaskHandler::kill):
* wtf/CrossThreadTaskHandler.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp
trunk/Source/WTF/wtf/CrossThreadTaskHandler.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp
trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (259315 => 259316)
--- trunk/Source/WTF/ChangeLog 2020-03-31 22:09:46 UTC (rev 259315)
+++ trunk/Source/WTF/ChangeLog 2020-03-31 22:19:25 UTC (rev 259316)
@@ -1,3 +1,20 @@
+2020-03-31 Sihui Liu
+
+IndexedDB: destroy WebIDBServer when session is removed in network process
+https://bugs.webkit.org/show_bug.cgi?id=209606
+
+
+Reviewed by Geoffrey Garen.
+
+Add function to kill CrossThreadTaskHandler and make thread finish. Also add a callback to be called before
+thread finishes.
+
+* wtf/CrossThreadTaskHandler.cpp:
+(WTF::CrossThreadTaskHandler::CrossThreadTaskHandler):
+(WTF::CrossThreadTaskHandler::setCompletionCallback):
+(WTF::CrossThreadTaskHandler::kill):
+* wtf/CrossThreadTaskHandler.h:
+
2020-03-30 David Kilzer
Fix "Dead nested assignment" static analyzer warning in monthFromDayInYear()
Modified: trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp (259315 => 259316)
--- trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp 2020-03-31 22:09:46 UTC (rev 259315)
+++ trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp 2020-03-31 22:19:25 UTC (rev 259316)
@@ -37,6 +37,9 @@
Locker locker(m_taskThreadCreationLock);
Thread::create(threadName, [this] {
taskRunLoop();
+
+if (m_completionCallback)
+m_completionCallback();
})->detach();
}
@@ -89,4 +92,15 @@
task->performTask();
}
+void CrossThreadTaskHandler::setCompletionCallback(Function&& completionCallback)
+{
+m_completionCallback = WTFMove(completionCallback);
+}
+
+void CrossThreadTaskHandler::kill()
+{
+m_taskQueue.kill();
+m_taskReplyQueue.kill();
+}
+
} // namespace WTF
Modified: trunk/Source/WTF/wtf/CrossThreadTaskHandler.h (259315 => 259316)
--- trunk/Source/WTF/wtf/CrossThreadTaskHandler.h 2020-03-31 22:09:46 UTC (rev 259315)
+++ trunk/Source/WTF/wtf/CrossThreadTaskHandler.h 2020-03-31 22:19:25 UTC (rev 259316)
@@ -46,6 +46,9 @@
WTF_EXPORT_PRIVATE void postTask(CrossThreadTask&&);
WTF_EXPORT_PRIVATE void postTaskReply(CrossThreadTask&&);
+WTF_EXPORT_PRIVATE void kill();
+WTF_EXPORT_PRIVATE void setCompletionCallback(Function&&);
+
private:
void handleTaskRepliesOnMainThread();
void taskRunLoop();
@@ -58,6 +61,8 @@
CrossThreadQueue m_taskQueue;
CrossThreadQueue m_taskReplyQueue;
+
+Function m_completionCallback;
};
} // namespace WTF
Modified: trunk/Source/WebCore/ChangeLog (259315 => 259316)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 22:09:46 UTC (rev 259315)
+++
[webkit-changes] [259315] trunk/Source
Title: [259315] trunk/Source Revision 259315 Author cdu...@apple.com Date 2020-03-31 15:09:46 -0700 (Tue, 31 Mar 2020) Log Message Regression(r253357) DeviceMotionEvent acceleration and rotationRate are null https://bugs.webkit.org/show_bug.cgi?id=209831 Reviewed by Darin Adler. Source/WebCore: The issue was that DeviceMotionClientIOS::motionChanged() would only initialize the acceleration and rotationRate if [m_motionManager gyroAvailable] returned YES. After r253357, m_motionManager is nil because we get motion data from the UIProcess so [m_motionManager gyroAvailable] would always resolve to NO. To address the issue, I made the rotationRate parameters to motionChanged() optional and we rely on them being set to know if gyro data is available. Note that I did not make the acceleration optional because according to [1], all devices have an accelerometer. [1] https://developer.apple.com/documentation/coremotion/cmmotionmanager/1616094-devicemotionavailable?language=objc * platform/ios/DeviceMotionClientIOS.h: * platform/ios/DeviceMotionClientIOS.mm: (WebCore::DeviceMotionClientIOS::motionChanged): * platform/ios/DeviceOrientationUpdateProvider.h: * platform/ios/MotionManagerClient.h: (WebCore::MotionManagerClient::motionChanged): * platform/ios/WebCoreMotionManager.mm: (-[WebCoreMotionManager sendAccelerometerData:]): Source/WebKit: * UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.h: * UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.mm: (WebKit::WebDeviceOrientationUpdateProviderProxy::motionChanged): * WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.cpp: (WebKit::WebDeviceOrientationUpdateProvider::deviceMotionChanged): * WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.h: * WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.messages.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ios/DeviceMotionClientIOS.h trunk/Source/WebCore/platform/ios/DeviceMotionClientIOS.mm trunk/Source/WebCore/platform/ios/DeviceOrientationUpdateProvider.h trunk/Source/WebCore/platform/ios/MotionManagerClient.h trunk/Source/WebCore/platform/ios/WebCoreMotionManager.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.h trunk/Source/WebKit/UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.mm trunk/Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.cpp trunk/Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.h trunk/Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.messages.in Diff Modified: trunk/Source/WebCore/ChangeLog (259314 => 259315) --- trunk/Source/WebCore/ChangeLog 2020-03-31 22:07:32 UTC (rev 259314) +++ trunk/Source/WebCore/ChangeLog 2020-03-31 22:09:46 UTC (rev 259315) @@ -1,3 +1,32 @@ +2020-03-31 Chris Dumez + +Regression(r253357) DeviceMotionEvent acceleration and rotationRate are null +https://bugs.webkit.org/show_bug.cgi?id=209831 + + +Reviewed by Darin Adler. + +The issue was that DeviceMotionClientIOS::motionChanged() would only initialize the +acceleration and rotationRate if [m_motionManager gyroAvailable] returned YES. After +r253357, m_motionManager is nil because we get motion data from the UIProcess so +[m_motionManager gyroAvailable] would always resolve to NO. + +To address the issue, I made the rotationRate parameters to motionChanged() optional +and we rely on them being set to know if gyro data is available. Note that I did not +make the acceleration optional because according to [1], all devices have an +accelerometer. + +[1] https://developer.apple.com/documentation/coremotion/cmmotionmanager/1616094-devicemotionavailable?language=objc + +* platform/ios/DeviceMotionClientIOS.h: +* platform/ios/DeviceMotionClientIOS.mm: +(WebCore::DeviceMotionClientIOS::motionChanged): +* platform/ios/DeviceOrientationUpdateProvider.h: +* platform/ios/MotionManagerClient.h: +(WebCore::MotionManagerClient::motionChanged): +* platform/ios/WebCoreMotionManager.mm: +(-[WebCoreMotionManager sendAccelerometerData:]): + 2020-03-31 Antoine Quint [iPadOS] Unable to scrub videos on nba.com Modified: trunk/Source/WebCore/platform/ios/DeviceMotionClientIOS.h (259314 => 259315) --- trunk/Source/WebCore/platform/ios/DeviceMotionClientIOS.h 2020-03-31 22:07:32 UTC (rev 259314) +++ trunk/Source/WebCore/platform/ios/DeviceMotionClientIOS.h 2020-03-31 22:09:46 UTC (rev 259315) @@ -48,7 +48,7 @@ DeviceMotionData* lastMotion() const override; void deviceMotionControllerDestroyed() override; -void motionChanged(double, double, double, double, double, double, double, double, double) override; +void motionChanged(double, double, double, double, double, double, Optional, Optional, Optional) override;
[webkit-changes] [259314] branches/safari-610.1.7-branch
Title: [259314] branches/safari-610.1.7-branch Revision 259314 Author alanc...@apple.com Date 2020-03-31 15:07:32 -0700 (Tue, 31 Mar 2020) Log Message Cherry-pick r258436. rdar://problem/61125864 [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing https://bugs.webkit.org/show_bug.cgi?id=209016 Reviewed by Chris Dumez. Source/WebKit: This patch adds a function to re-initialize app bound domains for in-app-browser-privacy tests, since they are only initialized once when the WebsiteDataStore is created. This causes issues if the tests are run in parallel with other tests with different app-bound domains. * UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreReinitializeAppBoundDomains): * UIProcess/API/C/WKWebsiteDataStoreRef.h: * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::clearAppBoundDomains): (WebKit::WebsiteDataStore::reinitializeAppBoundDomains): * UIProcess/WebsiteData/WebsiteDataStore.h: Tools: Re-initialize the app-bound domains when the correct TestOptions parameter is set. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions): (WTR::TestController::reinitializeAppBoundDomains): * WebKitTestRunner/TestController.h: LayoutTests: Use TestOptions to trigger the re-initialization of app-bound domains. * http/tests/in-app-browser-privacy/app-bound-domain.html: * http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258436 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610.1.7-branch/LayoutTests/ChangeLog branches/safari-610.1.7-branch/LayoutTests/http/tests/in-app-browser-privacy/app-bound-domain.html branches/safari-610.1.7-branch/LayoutTests/http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html branches/safari-610.1.7-branch/Source/WebKit/ChangeLog branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h branches/safari-610.1.7-branch/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm branches/safari-610.1.7-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h branches/safari-610.1.7-branch/Tools/ChangeLog branches/safari-610.1.7-branch/Tools/WebKitTestRunner/TestController.cpp branches/safari-610.1.7-branch/Tools/WebKitTestRunner/TestController.h Diff Modified: branches/safari-610.1.7-branch/LayoutTests/ChangeLog (259313 => 259314) --- branches/safari-610.1.7-branch/LayoutTests/ChangeLog 2020-03-31 21:29:12 UTC (rev 259313) +++ branches/safari-610.1.7-branch/LayoutTests/ChangeLog 2020-03-31 22:07:32 UTC (rev 259314) @@ -1,3 +1,61 @@ +2020-03-31 Alan Coon + +Cherry-pick r258436. rdar://problem/61125864 + +[ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing +https://bugs.webkit.org/show_bug.cgi?id=209016 + + +Reviewed by Chris Dumez. + +Source/WebKit: + +This patch adds a function to re-initialize app bound domains for +in-app-browser-privacy tests, since they are only initialized once +when the WebsiteDataStore is created. This causes issues if the tests +are run in parallel with other tests with different app-bound domains. + +* UIProcess/API/C/WKWebsiteDataStoreRef.cpp: +(WKWebsiteDataStoreReinitializeAppBoundDomains): +* UIProcess/API/C/WKWebsiteDataStoreRef.h: +* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: +(WebKit::WebsiteDataStore::clearAppBoundDomains): +(WebKit::WebsiteDataStore::reinitializeAppBoundDomains): +* UIProcess/WebsiteData/WebsiteDataStore.h: + +Tools: + +Re-initialize the app-bound domains when the correct +TestOptions parameter is set. + +* WebKitTestRunner/TestController.cpp: +(WTR::TestController::createWebViewWithOptions): +(WTR::TestController::reinitializeAppBoundDomains): +* WebKitTestRunner/TestController.h: + +LayoutTests: + +Use TestOptions to trigger the re-initialization of app-bound domains. + +* http/tests/in-app-browser-privacy/app-bound-domain.html: +* http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258436 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-03-13 Kate Cheney + +[ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing +https://bugs.webkit.org/show_bug.cgi?id=209016 + + +Reviewed by Chris Dumez. + +Use TestOptions to trigger the re-initialization of app-bound domains. + +* http/tests/in-app-browser-privacy/app-bound-domain.html: +*
[webkit-changes] [259313] trunk/Source/WebCore
Title: [259313] trunk/Source/WebCore
Revision 259313
Author commit-qu...@webkit.org
Date 2020-03-31 14:29:12 -0700 (Tue, 31 Mar 2020)
Log Message
[iPadOS] Unable to scrub videos on nba.com
https://bugs.webkit.org/show_bug.cgi?id=209829
Patch by Antoine Quint on 2020-03-31
Reviewed by Dean Jackson.
Opt nba.com into the simulated mouse events dispatch quirk.
* page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Quirks.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259312 => 259313)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 21:25:09 UTC (rev 259312)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 21:29:12 UTC (rev 259313)
@@ -1,3 +1,16 @@
+2020-03-31 Antoine Quint
+
+[iPadOS] Unable to scrub videos on nba.com
+https://bugs.webkit.org/show_bug.cgi?id=209829
+
+
+Reviewed by Dean Jackson.
+
+Opt nba.com into the simulated mouse events dispatch quirk.
+
+* page/Quirks.cpp:
+(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+
2020-03-31 Rob Buis
Append Upgrade-Insecure-Requests header in CachedResourceLoader
Modified: trunk/Source/WebCore/page/Quirks.cpp (259312 => 259313)
--- trunk/Source/WebCore/page/Quirks.cpp 2020-03-31 21:25:09 UTC (rev 259312)
+++ trunk/Source/WebCore/page/Quirks.cpp 2020-03-31 21:29:12 UTC (rev 259313)
@@ -332,6 +332,8 @@
return true;
if (host == "nhl.com" || host.endsWith(".nhl.com"))
return true;
+if (host == "nba.com" || host.endsWith(".nba.com"))
+return true;
if (host.endsWith(".naver.com")) {
// Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
if (host == "tv.naver.com")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259312] trunk/LayoutTests
Title: [259312] trunk/LayoutTests Revision 259312 Author ryanhad...@apple.com Date 2020-03-31 14:25:09 -0700 (Tue, 31 Mar 2020) Log Message Unreviewed test gardening for iOS and macOS. * platform/ios-simulator-wk2/TestExpectations: Skip a test that is consistently timing out. * platform/ios/TestExpectations: Skip a crashing test, add failure expectation for webkit.org/b/208023 * platform/mac/TestExpectations: Add failure expectation for webkit.org/b/208023 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259311 => 259312) --- trunk/LayoutTests/ChangeLog 2020-03-31 21:11:11 UTC (rev 259311) +++ trunk/LayoutTests/ChangeLog 2020-03-31 21:25:09 UTC (rev 259312) @@ -1,3 +1,11 @@ +2020-03-31 Ryan Haddad + +Unreviewed test gardening for iOS and macOS. + +* platform/ios-simulator-wk2/TestExpectations: Skip a test that is consistently timing out. +* platform/ios/TestExpectations: Skip a crashing test, add failure expectation for webkit.org/b/208023 +* platform/mac/TestExpectations: Add failure expectation for webkit.org/b/208023 + 2020-03-31 Jer Noble REGRESSION: [ Mac wk2 Release ] Flaky crash in WebCore::MediaPlayer::createVideoFullscreenLayer Modified: trunk/LayoutTests/platform/ios/TestExpectations (259311 => 259312) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-03-31 21:11:11 UTC (rev 259311) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-03-31 21:25:09 UTC (rev 259312) @@ -3503,6 +3503,11 @@ webkit.org/b/207858 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html [ Pass Failure ] webkit.org/b/207858 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas.html [ Pass Failure ] +# REGRESSION: http/wpt/webauthn/public-key-credential-get-success-local.https.html is crashing +http/wpt/webauthn/public-key-credential-get-success-local.https.html [ Skip ] + +webkit.org/b/208023 fast/text/international/system-language/declarative-language.html [ Failure ] + webkit.org/b/208053 imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-effects.sub.html [ Skip ] webkit.org/b/208053 imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-occlusion.sub.html [ Skip ] Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (259311 => 259312) --- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2020-03-31 21:11:11 UTC (rev 259311) +++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2020-03-31 21:25:09 UTC (rev 259312) @@ -28,7 +28,7 @@ webkit.org/b/172384 fast/hidpi/hidpi-long-page-with-inset-element.html [ Pass ImageOnlyFailure ] -webkit.org/b/175865 quicklook/multi-sheet-numbers-09.html [ Pass Failure ] +webkit.org/b/175865 quicklook/multi-sheet-numbers-09.html [ Skip ] webkit.org/b/187699 [ Debug ] fast/forms/submit-change-fragment.html [ Pass Timeout ] @@ -98,4 +98,4 @@ webkit.org/b/208840 editing/selection/selection-change-in-mutation-event-by-remove-children.html [ Pass Timeout ] -webkit.org/b/209234 [ Release ] platform/ios/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/209234 [ Release ] platform/ios/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac/TestExpectations (259311 => 259312) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-31 21:11:11 UTC (rev 259311) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-31 21:25:09 UTC (rev 259312) @@ -1972,4 +1972,6 @@ webkit.org/b/209619 [ Catalina ] compositing/clipping/border-radius-async-overflow-stacking.html [ Pass ImageOnlyFailure ] +webkit.org/b/208023 [ Catalina ] fast/text/international/system-language/declarative-language.html [ Failure ] + webkit.org/b/209740 webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259311] branches/safari-609-branch/Source/WebCore
Title: [259311] branches/safari-609-branch/Source/WebCore
Revision 259311
Author repst...@apple.com
Date 2020-03-31 14:11:11 -0700 (Tue, 31 Mar 2020)
Log Message
Cherry-pick r258326. rdar://problem/61113047
Remove no longer used code in LibWebRTCMediaEndpoint to handle remote streams
https://bugs.webkit.org/show_bug.cgi?id=208919
Reviewed by Eric Carlson.
These stream APIs are legacy now and not useful anymore.
Stop implementing the corresponding callbacks and remove related code.
Coverd by existing tests.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::addRemoteStream): Deleted.
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack): Deleted.
(WebCore::LibWebRTCMediaEndpoint::OnAddStream): Deleted.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
branches/safari-609-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (259310 => 259311)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-03-31 20:57:09 UTC (rev 259310)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-03-31 21:11:11 UTC (rev 259311)
@@ -1,3 +1,42 @@
+2020-03-31 Russell Epstein
+
+Cherry-pick r258326. rdar://problem/61113047
+
+Remove no longer used code in LibWebRTCMediaEndpoint to handle remote streams
+https://bugs.webkit.org/show_bug.cgi?id=208919
+
+Reviewed by Eric Carlson.
+
+These stream APIs are legacy now and not useful anymore.
+Stop implementing the corresponding callbacks and remove related code.
+Coverd by existing tests.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::LibWebRTCMediaEndpoint::addRemoteStream): Deleted.
+(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack): Deleted.
+(WebCore::LibWebRTCMediaEndpoint::OnAddStream): Deleted.
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-12 youenn fablet
+
+Remove no longer used code in LibWebRTCMediaEndpoint to handle remote streams
+https://bugs.webkit.org/show_bug.cgi?id=208919
+
+Reviewed by Eric Carlson.
+
+These stream APIs are legacy now and not useful anymore.
+Stop implementing the corresponding callbacks and remove related code.
+Coverd by existing tests.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::LibWebRTCMediaEndpoint::addRemoteStream): Deleted.
+(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack): Deleted.
+(WebCore::LibWebRTCMediaEndpoint::OnAddStream): Deleted.
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
+
2020-03-30 Alan Coon
Cherry-pick r258837. rdar://problem/61064858
Modified: branches/safari-609-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (259310 => 259311)
--- branches/safari-609-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2020-03-31 20:57:09 UTC (rev 259310)
+++ branches/safari-609-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2020-03-31 21:11:11 UTC (rev 259311)
@@ -354,44 +354,6 @@
return *mediaStream.iterator->value;
}
-void LibWebRTCMediaEndpoint::addRemoteStream(webrtc::MediaStreamInterface&)
-{
-}
-
-void LibWebRTCMediaEndpoint::addRemoteTrack(rtc::scoped_refptr&& rtcReceiver, const std::vector>& rtcStreams)
-{
-ASSERT(rtcReceiver);
-RefPtr receiver;
-RefPtr remoteSource;
-
-auto* rtcTrack = rtcReceiver->track().get();
-
-switch (rtcReceiver->media_type()) {
-case cricket::MEDIA_TYPE_DATA:
-return;
-case cricket::MEDIA_TYPE_AUDIO: {
-rtc::scoped_refptr audioTrack = static_cast(rtcTrack);
-auto audioReceiver = m_peerConnectionBackend.audioReceiver(fromStdString(rtcTrack->id()));
-
-receiver = WTFMove(audioReceiver.receiver);
-audioReceiver.source->setSourceTrack(WTFMove(audioTrack));
-break;
-}
-case cricket::MEDIA_TYPE_VIDEO: {
-rtc::scoped_refptr videoTrack = static_cast(rtcTrack);
-auto videoReceiver = m_peerConnectionBackend.videoReceiver(fromStdString(rtcTrack->id()));
-
-receiver = WTFMove(videoReceiver.receiver);
-videoReceiver.source->setSourceTrack(WTFMove(videoTrack));
-break;
-}
-}
-
-receiver->setBackend(makeUnique(WTFMove(rtcReceiver)));
-auto& track = receiver->track();
-
[webkit-changes] [259310] trunk/Source/JavaScriptCore
Title: [259310] trunk/Source/_javascript_Core
Revision 259310
Author ross.kirsl...@sony.com
Date 2020-03-31 13:57:09 -0700 (Tue, 31 Mar 2020)
Log Message
REGRESSION: ASSERTION FAILED: regExpObjectNode in JSC::DFG::StrengthReductionPhase::handleNode
https://bugs.webkit.org/show_bug.cgi?id=209824
Reviewed by Mark Lam.
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
It's true that we need to verify lastIndex even when a RegExp is neither global nor sticky,
but if DFG's already converted RegExpExec to RegExpExecNonGlobalOrSticky, that means we've thrown away
the RegExpObject node, so we shouldn't try to reverify lastIndex when we reconsider folding to constant.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259309 => 259310)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-31 20:38:00 UTC (rev 259309)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-31 20:57:09 UTC (rev 259310)
@@ -1,3 +1,16 @@
+2020-03-31 Ross Kirsling
+
+REGRESSION: ASSERTION FAILED: regExpObjectNode in JSC::DFG::StrengthReductionPhase::handleNode
+https://bugs.webkit.org/show_bug.cgi?id=209824
+
+Reviewed by Mark Lam.
+
+* dfg/DFGStrengthReductionPhase.cpp:
+(JSC::DFG::StrengthReductionPhase::handleNode):
+It's true that we need to verify lastIndex even when a RegExp is neither global nor sticky,
+but if DFG's already converted RegExpExec to RegExpExecNonGlobalOrSticky, that means we've thrown away
+the RegExpObject node, so we shouldn't try to reverify lastIndex when we reconsider folding to constant.
+
2020-03-30 Yusuke Suzuki
[JSC] DFGArrayMode::alreadyChecked should have NonArray check when ArrayMode is NonArray+SlowPutArrayStorage
Modified: trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp (259309 => 259310)
--- trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp 2020-03-31 20:38:00 UTC (rev 259309)
+++ trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp 2020-03-31 20:57:09 UTC (rev 259310)
@@ -535,34 +535,36 @@
ASSERT(m_node->op() != RegExpMatchFast);
-// This will only work if we can prove what the value of lastIndex is. To do this
-// safely, we need to execute the insertion set so that we see any previous strength
-// reductions. This is needed for soundness since otherwise the effectfulness of any
-// previous strength reductions would be invisible to us.
-ASSERT(regExpObjectNode);
-executeInsertionSet();
unsigned lastIndex = UINT_MAX;
-for (unsigned otherNodeIndex = m_nodeIndex; otherNodeIndex--;) {
-Node* otherNode = m_block->at(otherNodeIndex);
-if (otherNode == regExpObjectNode) {
-lastIndex = 0;
-break;
+if (m_node->op() != RegExpExecNonGlobalOrSticky) {
+// This will only work if we can prove what the value of lastIndex is. To do this
+// safely, we need to execute the insertion set so that we see any previous strength
+// reductions. This is needed for soundness since otherwise the effectfulness of any
+// previous strength reductions would be invisible to us.
+ASSERT(regExpObjectNode);
+executeInsertionSet();
+for (unsigned otherNodeIndex = m_nodeIndex; otherNodeIndex--;) {
+Node* otherNode = m_block->at(otherNodeIndex);
+if (otherNode == regExpObjectNode) {
+lastIndex = 0;
+break;
+}
+if (otherNode->op() == SetRegExpObjectLastIndex
+&& otherNode->child1() == regExpObjectNode
+&& otherNode->child2()->isInt32Constant()
+&& otherNode->child2()->asInt32() >= 0) {
+lastIndex = otherNode->child2()->asUInt32();
+break;
+}
+if (writesOverlap(m_graph, otherNode, RegExpObject_lastIndex))
+break;
}
-if (otherNode->op() == SetRegExpObjectLastIndex
-&& otherNode->child1() == regExpObjectNode
-&& otherNode->child2()->isInt32Constant()
-&& otherNode->child2()->asInt32() >= 0) {
-lastIndex = static_cast(otherNode->child2()->asInt32());
+if (lastIndex == UINT_MAX) {
+if (verbose)
+dataLog("Giving up because the last index is not known.\n");
break;
}
-if (writesOverlap(m_graph, otherNode,
[webkit-changes] [259309] branches/safari-610.1.7-branch/Source/WebKit
Title: [259309] branches/safari-610.1.7-branch/Source/WebKit
Revision 259309
Author alanc...@apple.com
Date 2020-03-31 13:38:00 -0700 (Tue, 31 Mar 2020)
Log Message
Cherry-pick r258600. rdar://problem/61082995
Add internal debugging when initializing an app-bound session
https://bugs.webkit.org/show_bug.cgi?id=209190
Reviewed by Brent Fulgham.
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::SessionWrapper::initialize):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::NetworkSessionCocoa::initializeEphemeralStatelessSession):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::NetworkSessionCocoa::appBoundSession):
(WebKit::NetworkSessionCocoa::isolatedSession):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610.1.7-branch/Source/WebKit/ChangeLog
branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (259308 => 259309)
--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog 2020-03-31 20:21:48 UTC (rev 259308)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog 2020-03-31 20:38:00 UTC (rev 259309)
@@ -1,3 +1,46 @@
+2020-03-31 Alan Coon
+
+Cherry-pick r258600. rdar://problem/61082995
+
+Add internal debugging when initializing an app-bound session
+ https://bugs.webkit.org/show_bug.cgi?id=209190
+
+
+Reviewed by Brent Fulgham.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+* NetworkProcess/cocoa/NetworkSessionCocoa.h:
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::SessionWrapper::initialize):
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+(WebKit::NetworkSessionCocoa::initializeEphemeralStatelessSession):
+(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
+(WebKit::NetworkSessionCocoa::appBoundSession):
+(WebKit::NetworkSessionCocoa::isolatedSession):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-17 Kate Cheney
+
+ Add internal debugging when initializing an app-bound session
+ https://bugs.webkit.org/show_bug.cgi?id=209190
+
+
+Reviewed by Brent Fulgham.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+* NetworkProcess/cocoa/NetworkSessionCocoa.h:
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::SessionWrapper::initialize):
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+(WebKit::NetworkSessionCocoa::initializeEphemeralStatelessSession):
+(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
+(WebKit::NetworkSessionCocoa::appBoundSession):
+(WebKit::NetworkSessionCocoa::isolatedSession):
+
2020-03-30 Alan Coon
Cherry-pick r258958. rdar://problem/61082960
Modified: branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (259308 => 259309)
--- branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2020-03-31 20:21:48 UTC (rev 259308)
+++ branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2020-03-31 20:38:00 UTC (rev 259309)
@@ -52,12 +52,6 @@
#import
#endif
-#if USE(APPLE_INTERNAL_SDK)
-#include
-#else
-#define NETWORK_DATA_TASK_COCOA_ADDITIONS
-#endif
-
namespace WebKit {
#if USE(CREDENTIAL_STORAGE_WITH_NETWORK_SESSION)
@@ -187,8 +181,6 @@
, m_isForMainResourceNavigationForAnyFrame(dataTaskIsForMainResourceNavigationForAnyFrame)
, m_isAlwaysOnLoggingAllowed(computeIsAlwaysOnLoggingAllowed(session))
{
-NETWORK_DATA_TASK_COCOA_ADDITIONS
-
if (m_scheduledFailureType != NoFailure)
return;
Modified: branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h (259308 => 259309)
--- branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h 2020-03-31 20:21:48 UTC (rev 259308)
+++ branches/safari-610.1.7-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h 2020-03-31 20:38:00 UTC (rev 259309)
@@ -50,7 +50,7 @@
class NetworkSessionCocoa;
struct SessionWrapper : public CanMakeWeakPtr {
-void initialize(NSURLSessionConfiguration *,
[webkit-changes] [259308] trunk/Source/WebCore
Title: [259308] trunk/Source/WebCore
Revision 259308
Author commit-qu...@webkit.org
Date 2020-03-31 13:21:48 -0700 (Tue, 31 Mar 2020)
Log Message
Append Upgrade-Insecure-Requests header in CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=209664
Patch by Rob Buis on 2020-03-31
Reviewed by Youenn Fablet.
Append Upgrade-Insecure-Requests header in CachedResourceLoader, following
the fetch spec [1, step 3].
[1] https://fetch.spec.whatwg.org/#concept-main-fetch
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::populateFrameLoadRequest):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::createWindow):
(WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded): Deleted.
* loader/FrameLoader.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FormSubmission.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259307 => 259308)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 20:13:48 UTC (rev 259307)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 20:21:48 UTC (rev 259308)
@@ -1,3 +1,26 @@
+2020-03-31 Rob Buis
+
+Append Upgrade-Insecure-Requests header in CachedResourceLoader
+https://bugs.webkit.org/show_bug.cgi?id=209664
+
+Reviewed by Youenn Fablet.
+
+Append Upgrade-Insecure-Requests header in CachedResourceLoader, following
+the fetch spec [1, step 3].
+
+[1] https://fetch.spec.whatwg.org/#concept-main-fetch
+
+* loader/FormSubmission.cpp:
+(WebCore::FormSubmission::populateFrameLoadRequest):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest):
+(WebCore::FrameLoader::loadDifferentDocumentItem):
+(WebCore::createWindow):
+(WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded): Deleted.
+* loader/FrameLoader.h:
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::requestResource):
+
2020-03-31 Pinki Gyanchandani
Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
Modified: trunk/Source/WebCore/loader/FormSubmission.cpp (259307 => 259308)
--- trunk/Source/WebCore/loader/FormSubmission.cpp 2020-03-31 20:13:48 UTC (rev 259307)
+++ trunk/Source/WebCore/loader/FormSubmission.cpp 2020-03-31 20:21:48 UTC (rev 259308)
@@ -253,7 +253,6 @@
auto origin = SecurityPolicy::generateOriginHeader(frameRequest.requester().referrerPolicy(), frameRequest.resourceRequest().url(), securityOrigin);
frameRequest.resourceRequest().setHTTPOrigin(origin);
}
-FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded(frameRequest.resourceRequest());
}
}
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (259307 => 259308)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2020-03-31 20:13:48 UTC (rev 259307)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2020-03-31 20:21:48 UTC (rev 259308)
@@ -2885,9 +2885,6 @@
// FIXME: Using m_loadType seems wrong for some callers.
// If we are only preparing to load the main resource, that is previous load's load type!
addExtraFieldsToRequest(request, m_loadType, true);
-
-// Upgrade-Insecure-Requests should only be added to main resource requests
-addHTTPUpgradeInsecureRequestsIfNeeded(request);
}
ResourceRequestCachePolicy FrameLoader::defaultRequestCachingPolicy(const ResourceRequest& request, FrameLoadType loadType, bool isMainResource)
@@ -3002,16 +2999,6 @@
request.setIsSameSite(areRegistrableDomainsEqual(initiator->siteForCookies(), request.url()));
}
-void FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded(ResourceRequest& request)
-{
-if (request.url().protocolIs("https")) {
-// FIXME: Identify HSTS cases and avoid adding the header.
-return;
-}
-
-request.setHTTPHeaderField(HTTPHeaderName::UpgradeInsecureRequests, "1"_s);
-}
-
void FrameLoader::loadPostRequest(FrameLoadRequest&& request, const String& referrer, FrameLoadType loadType, Event* event, RefPtr&& formState, CompletionHandler&& completionHandler)
{
FRAMELOADER_RELEASE_LOG_IF_ALLOWED(ResourceLoading, "loadPostRequest: frame load started");
@@ -3785,7 +3772,6 @@
auto origin = SecurityPolicy::generateOriginHeader(m_frame.document()->referrerPolicy(), request.url(), securityOrigin);
request.setHTTPOrigin(origin);
}
-addHTTPUpgradeInsecureRequestsIfNeeded(request);
// Make sure to add extra fields to the request after the Origin header is added for the FormData case.
// See https://bugs.webkit.org/show_bug.cgi?id=22194 for more discussion.
@@ -4101,7 +4087,6
[webkit-changes] [259307] trunk
Title: [259307] trunk Revision 259307 Author achristen...@apple.com Date 2020-03-31 13:13:48 -0700 (Tue, 31 Mar 2020) Log Message Add SPI WKWebpagePreferences._userContentController https://bugs.webkit.org/show_bug.cgi?id=209795 Reviewed by Tim Hatcher. Source/WebKit: This will allow us to switch which WKUserContentController we are using at decidePolicyForNavigationAction time like we do WKWebsiteDataStores. This is only allowed with main frame navigations. To do this I moved UserContentControllerParameters into their own struct. I remove unused WebsitePoliciesData.websiteDataStoreParameters. I pass an API::WebsitePolicies* further down the chain instead of switching to Optional, which allows us to access the WebUserContentControllerProxy* from the former in WebPageProxy::creationParameters. I removed an unused WebsitePolicies constructor. I added a missing copied member variable in WebsitePolicies::copy. * NetworkProcess/NetworkSession.cpp: * Shared/UserContentControllerParameters.cpp: Added. (WebKit::UserContentControllerParameters::encode const): (WebKit::UserContentControllerParameters::decode): * Shared/UserContentControllerParameters.h: Added. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: * Shared/WebsitePoliciesData.cpp: (WebKit::WebsitePoliciesData::encode const): (WebKit::WebsitePoliciesData::decode): * Shared/WebsitePoliciesData.h: * Sources.txt: * UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::copy const): (API::WebsitePolicies::setUserContentController): (API::WebsitePolicies::data): (API::WebsitePolicies::WebsitePolicies): Deleted. * UIProcess/API/APIWebsitePolicies.h: * UIProcess/API/C/WKPage.cpp: (WKPageUpdateWebsitePolicies): * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _updateWebpagePreferences:]): * UIProcess/API/Cocoa/WKWebpagePreferences.mm: (-[WKWebpagePreferences _userContentController]): (-[WKWebpagePreferences _setUserContentController:]): * UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h: * UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): * UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::initializeWebPage): (WebKit::ProvisionalPageProxy::goToBackForwardItem): * UIProcess/ProvisionalPageProxy.h: * UIProcess/UserContent/WebUserContentControllerProxy.cpp: (WebKit::WebUserContentControllerProxy::addProcess): (WebKit::WebUserContentControllerProxy::parameters const): (WebKit::WebUserContentControllerProxy::contentRuleListData const): (WebKit::WebUserContentControllerProxy::contentRuleListData): Deleted. * UIProcess/UserContent/WebUserContentControllerProxy.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::receivedNavigationPolicyDecision): (WebKit::WebPageProxy::receivedPolicyDecision): (WebKit::WebPageProxy::continueNavigationInNewProcess): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForResponseShared): * UIProcess/WebPageProxy.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::addWebUserContentControllerProxy): * UIProcess/WebProcessProxy.h: * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebPage/WebPage.cpp: (WebKit::m_processDisplayName): * WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveMessage): Tools: * TestWebKitAPI/SourcesCocoa.txt: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm: (-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted. * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: * TestWebKitAPI/cocoa/TestUIDelegate.h: Added. * TestWebKitAPI/cocoa/TestUIDelegate.mm: Added. (-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (-[TestUIDelegate waitForAlert]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp trunk/Source/WebKit/Shared/WebPageCreationParameters.h trunk/Source/WebKit/Shared/WebsitePoliciesData.cpp trunk/Source/WebKit/Shared/WebsitePoliciesData.h trunk/Source/WebKit/Sources.txt trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.h trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.h trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp
[webkit-changes] [259306] trunk/Source/WebKit
Title: [259306] trunk/Source/WebKit
Revision 259306
Author achristen...@apple.com
Date 2020-03-31 13:08:10 -0700 (Tue, 31 Mar 2020)
Log Message
Remove call to PageConfiguration::setUserContentController added in r225765
https://bugs.webkit.org/show_bug.cgi?id=209828
Reviewed by Brian Weinstein.
r225765 added a way for a certain Mac application to use WKWebViewConfiguration._pageGroup to set its WKUserContentController.
That Mac application has transitioned to setting the WKUserContentController manually, and this workaround needs to be removed
for that application's WKUserContentControllers to continue working as desired. I verified this fixes that application, and
it is the only user of WKWebViewConfiguration._pageGroup and all other applications will have no change in behavior.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (259305 => 259306)
--- trunk/Source/WebKit/ChangeLog 2020-03-31 19:56:26 UTC (rev 259305)
+++ trunk/Source/WebKit/ChangeLog 2020-03-31 20:08:10 UTC (rev 259306)
@@ -1,3 +1,19 @@
+2020-03-31 Alex Christensen
+
+Remove call to PageConfiguration::setUserContentController added in r225765
+https://bugs.webkit.org/show_bug.cgi?id=209828
+
+
+Reviewed by Brian Weinstein.
+
+r225765 added a way for a certain Mac application to use WKWebViewConfiguration._pageGroup to set its WKUserContentController.
+That Mac application has transitioned to setting the WKUserContentController manually, and this workaround needs to be removed
+for that application's WKUserContentControllers to continue working as desired. I verified this fixes that application, and
+it is the only user of WKWebViewConfiguration._pageGroup and all other applications will have no change in behavior.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _setupPageConfiguration:]):
+
2020-03-31 Brent Fulgham
[macOS] Add additional IPC permission needed by Security.framework
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (259305 => 259306)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2020-03-31 19:56:26 UTC (rev 259305)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2020-03-31 20:08:10 UTC (rev 259306)
@@ -424,10 +424,9 @@
pageConfiguration->setDefaultWebsitePolicies([_configuration defaultWebpagePreferences]->_websitePolicies.get());
#if PLATFORM(MAC)
-if (auto pageGroup = WebKit::toImpl([_configuration _pageGroup])) {
+if (auto pageGroup = WebKit::toImpl([_configuration _pageGroup]))
pageConfiguration->setPageGroup(pageGroup);
-pageConfiguration->setUserContentController(>userContentController());
-} else
+else
#endif
{
NSString *groupIdentifier = [_configuration _groupIdentifier];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259305] trunk/Source/WebCore
Title: [259305] trunk/Source/WebCore
Revision 259305
Author commit-qu...@webkit.org
Date 2020-03-31 12:56:26 -0700 (Tue, 31 Mar 2020)
Log Message
Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=209786
Patch by Pinki Gyanchandani on 2020-03-31
Reviewed by Ryosuke Niwa.
No new tests. Reduced test would be added later. Currently issue is verified with the original testcase in associated radar-58416328.
Webkit1 only issue, where m_client.dispatchDidCommitLoad in FrameLoader::dispatchDidCommitLoad could cause the frame
to be destroyed, and m_frame still being accessed outside. Changes made to protect the DocumentLoader and Frame.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259304 => 259305)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 19:55:33 UTC (rev 259304)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 19:56:26 UTC (rev 259305)
@@ -1,3 +1,21 @@
+2020-03-31 Pinki Gyanchandani
+
+Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
+https://bugs.webkit.org/show_bug.cgi?id=209786
+
+Reviewed by Ryosuke Niwa.
+
+No new tests. Reduced test would be added later. Currently issue is verified with the original testcase in associated radar-58416328.
+
+Webkit1 only issue, where m_client.dispatchDidCommitLoad in FrameLoader::dispatchDidCommitLoad could cause the frame
+to be destroyed, and m_frame still being accessed outside. Changes made to protect the DocumentLoader and Frame.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::finishedLoading):
+(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::receivedFirstData):
+
2020-03-31 Lauro Moura
Buildfix after r259928.
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (259304 => 259305)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2020-03-31 19:55:33 UTC (rev 259304)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2020-03-31 19:56:26 UTC (rev 259305)
@@ -443,6 +443,9 @@
// DocumentWriter::begin() gets called and creates the Document.
if (!m_gotFirstByte)
commitData(0, 0);
+
+if (!frameLoader())
+return;
frameLoader()->client().finishedLoading(this);
}
@@ -479,6 +482,8 @@
void DocumentLoader::handleSubstituteDataLoadNow()
{
+Ref protectedThis = makeRef(*this);
+
ResourceResponse response = m_substituteData.response();
if (response.url().isEmpty())
response = ResourceResponse(m_request.url(), m_substituteData.mimeType(), m_substituteData.content()->size(), m_substituteData.textEncoding());
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (259304 => 259305)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2020-03-31 19:55:33 UTC (rev 259304)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2020-03-31 19:56:26 UTC (rev 259305)
@@ -706,6 +706,8 @@
void FrameLoader::receivedFirstData()
{
+auto protectedFrame = makeRef(m_frame);
+
dispatchDidCommitLoad(WTF::nullopt, WTF::nullopt);
dispatchDidClearWindowObjectsInAllWorlds();
dispatchGlobalObjectAvailableInAllWorlds();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259304] trunk/Source/WebCore
Title: [259304] trunk/Source/WebCore
Revision 259304
Author lmo...@igalia.com
Date 2020-03-31 12:55:33 -0700 (Tue, 31 Mar 2020)
Log Message
Buildfix after r259928.
Replace outer function with its virtual implementation in
child class.
Unreviewed build fix.
* workers/WorkerAnimationController.cpp:
(WebCore::WorkerAnimationController::virtualHasPendingActivity const):
(WebCore::WorkerAnimationController::hasPendingActivity const): Deleted.
* workers/WorkerAnimationController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerAnimationController.cpp
trunk/Source/WebCore/workers/WorkerAnimationController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259303 => 259304)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 19:40:05 UTC (rev 259303)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 19:55:33 UTC (rev 259304)
@@ -1,3 +1,17 @@
+2020-03-31 Lauro Moura
+
+Buildfix after r259928.
+
+Replace outer function with its virtual implementation in
+child class.
+
+Unreviewed build fix.
+
+* workers/WorkerAnimationController.cpp:
+(WebCore::WorkerAnimationController::virtualHasPendingActivity const):
+(WebCore::WorkerAnimationController::hasPendingActivity const): Deleted.
+* workers/WorkerAnimationController.h:
+
2020-03-31 Eric Carlson
[iPad] Use AVAudioSession to detect AirPlay route changes
Modified: trunk/Source/WebCore/workers/WorkerAnimationController.cpp (259303 => 259304)
--- trunk/Source/WebCore/workers/WorkerAnimationController.cpp 2020-03-31 19:40:05 UTC (rev 259303)
+++ trunk/Source/WebCore/workers/WorkerAnimationController.cpp 2020-03-31 19:55:33 UTC (rev 259304)
@@ -61,7 +61,7 @@
return "WorkerAnimationController";
}
-bool WorkerAnimationController::hasPendingActivity() const
+bool WorkerAnimationController::virtualHasPendingActivity() const
{
return m_animationTimer.isActive();
}
Modified: trunk/Source/WebCore/workers/WorkerAnimationController.h (259303 => 259304)
--- trunk/Source/WebCore/workers/WorkerAnimationController.h 2020-03-31 19:40:05 UTC (rev 259303)
+++ trunk/Source/WebCore/workers/WorkerAnimationController.h 2020-03-31 19:55:33 UTC (rev 259304)
@@ -56,7 +56,7 @@
const char* activeDOMObjectName() const final;
-bool hasPendingActivity() const final;
+bool virtualHasPendingActivity() const final;
void stop() final;
void suspend(ReasonForSuspension) final;
void resume() final;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259303] trunk/Source/WebCore
Title: [259303] trunk/Source/WebCore Revision 259303 Author eric.carl...@apple.com Date 2020-03-31 12:40:05 -0700 (Tue, 31 Mar 2020) Log Message [iPad] Use AVAudioSession to detect AirPlay route changes https://bugs.webkit.org/show_bug.cgi?id=209789 Reviewed by Jer Noble. Source/WebCore: No new tests: changes only affect playback on device to an actual AirPlay device, which is not testable on our current testing infrastructure. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::checkPlaybackTargetCompatablity): Drive-by fix: pass log identifier into lambda so the method name is logged. (WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget): Ditto. (WebCore::HTMLMediaElement::setWirelessPlaybackTarget): Update logging. (WebCore::HTMLMediaElement::setShouldPlayToPlaybackTarget): Call setIsPlayingToWirelessTarget so we kick off a media player compatibility check. * platform/audio/PlatformMediaSessionManager.h: Remove unused instance variables. * platform/audio/ios/MediaSessionHelperIOS.mm: (MediaSessionHelperiOS::activeAudioRouteDidChange): Change parameter to bool as it is always present. (MediaSessionHelperiOS::activeVideoRouteDidChange): Remove parameters, use the new MediaPlaybackTargetCocoa create method and ask it if the target supports AirPlay. (-[WebMediaSessionHelper initWithCallback:]): Listen for AVAudioSessionRouteChangeNotification. (-[WebMediaSessionHelper activeOutputDeviceDidChange:]): Update for new notification source. (-[WebMediaSessionHelper activeAudioRouteDidChange:]): Deleted. * platform/audio/ios/MediaSessionManagerIOS.h: * platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::sessionWillBeginPlayback): Set playback target on session that is about to begin playback. (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange): Save the target and state. * platform/graphics/MediaPlaybackTarget.h: * platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h: * platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm: (WebCore::MediaPlaybackTargetCocoa::create): Create a target from the application's currently active AVOutputContext. (WebCore::MediaPlaybackTargetCocoa::supportsAirPlayVideo const): New. (WebCore::MediaPlaybackTargetCocoa::hasActiveRoute const): Use new API if available instead of just checking for the AVOutputContext name. * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setWirelessPlaybackTarget): Log. (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setShouldPlayToPlaybackTarget): * platform/mock/MediaPlaybackTargetMock.h: Source/WebCore/PAL: * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: * pal/spi/cocoa/AVFoundationSPI.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h trunk/Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm trunk/Source/WebCore/platform/graphics/MediaPlaybackTarget.h trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm trunk/Source/WebCore/platform/mock/MediaPlaybackTargetMock.h Diff Modified: trunk/Source/WebCore/ChangeLog (259302 => 259303) --- trunk/Source/WebCore/ChangeLog 2020-03-31 19:19:43 UTC (rev 259302) +++ trunk/Source/WebCore/ChangeLog 2020-03-31 19:40:05 UTC (rev 259303) @@ -1,3 +1,52 @@ +2020-03-31 Eric Carlson + +[iPad] Use AVAudioSession to detect AirPlay route changes +https://bugs.webkit.org/show_bug.cgi?id=209789 + + +Reviewed by Jer Noble. + +No new tests: changes only affect playback on device to an actual AirPlay device, which +is not testable on our current testing infrastructure. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::checkPlaybackTargetCompatablity): Drive-by fix: pass log identifier +into lambda so the method name is logged. +(WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget): Ditto. +(WebCore::HTMLMediaElement::setWirelessPlaybackTarget): Update logging. +(WebCore::HTMLMediaElement::setShouldPlayToPlaybackTarget): Call setIsPlayingToWirelessTarget +so we kick off a media player compatibility check. + +* platform/audio/PlatformMediaSessionManager.h: Remove unused instance variables. +*
[webkit-changes] [259302] trunk
Title: [259302] trunk
Revision 259302
Author jer.no...@apple.com
Date 2020-03-31 12:19:43 -0700 (Tue, 31 Mar 2020)
Log Message
REGRESSION: [ Mac wk2 Release ] Flaky crash in WebCore::MediaPlayer::createVideoFullscreenLayer
https://bugs.webkit.org/show_bug.cgi?id=209668
Reviewed by Darin Adler.
Source/WebCore:
Null check m_player and m_videoElement before calling createVideoFullscreenLayer().
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createVideoFullscreenLayer):
* platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::createVideoFullscreenLayer):
LayoutTests:
* platform/mac-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (259301 => 259302)
--- trunk/LayoutTests/ChangeLog 2020-03-31 18:22:44 UTC (rev 259301)
+++ trunk/LayoutTests/ChangeLog 2020-03-31 19:19:43 UTC (rev 259302)
@@ -1,3 +1,13 @@
+2020-03-31 Jer Noble
+
+REGRESSION: [ Mac wk2 Release ] Flaky crash in WebCore::MediaPlayer::createVideoFullscreenLayer
+https://bugs.webkit.org/show_bug.cgi?id=209668
+
+
+Reviewed by Darin Adler.
+
+* platform/mac-wk2/TestExpectations:
+
2020-03-31 Jason Lawrence
[ Mac Debug ] ASSERTION FAILED: m_videoFullscreenMode on media/media-fullscreen-return-to-inline.html
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (259301 => 259302)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-03-31 18:22:44 UTC (rev 259301)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-03-31 19:19:43 UTC (rev 259302)
@@ -760,7 +760,7 @@
webkit.org/b/182176 imported/w3c/web-platform-tests/service-workers/service-worker/appcache-ordering-main.https.html [ Skip ]
-webkit.org/b/183869 media/modern-media-controls/seek-backward-support/seek-backward-support.html [ Pass Failure Crash ]
+webkit.org/b/183869 media/modern-media-controls/seek-backward-support/seek-backward-support.html [ Pass Failure ]
webkit.org/b/184245 http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
@@ -1039,6 +1039,4 @@
webkit.org/b/209672 http/wpt/service-workers/service-worker-spinning-fetch.https.html [ Pass Failure Crash ]
-webkit.org/b/209688 media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Pass Crash ]
-
webkit.org/b/209769 [ Catalina ] tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html [ Pass Failure ]
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (259301 => 259302)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 18:22:44 UTC (rev 259301)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 19:19:43 UTC (rev 259302)
@@ -1,3 +1,18 @@
+2020-03-31 Jer Noble
+
+REGRESSION: [ Mac wk2 Release ] Flaky crash in WebCore::MediaPlayer::createVideoFullscreenLayer
+https://bugs.webkit.org/show_bug.cgi?id=209668
+
+
+Reviewed by Darin Adler.
+
+Null check m_player and m_videoElement before calling createVideoFullscreenLayer().
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::createVideoFullscreenLayer):
+* platform/cocoa/VideoFullscreenModelVideoElement.mm:
+(WebCore::VideoFullscreenModelVideoElement::createVideoFullscreenLayer):
+
2020-03-31 Chris Dumez
ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (259301 => 259302)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2020-03-31 18:22:44 UTC (rev 259301)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2020-03-31 19:19:43 UTC (rev 259302)
@@ -6248,7 +6248,9 @@
RetainPtr HTMLMediaElement::createVideoFullscreenLayer()
{
-return m_player->createVideoFullscreenLayer();
+if (m_player)
+return m_player->createVideoFullscreenLayer();
+return nullptr;
}
void HTMLMediaElement::setVideoFullscreenLayer(PlatformLayer* platformLayer, WTF::Function&& completionHandler)
Modified: trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm (259301 => 259302)
--- trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm 2020-03-31 18:22:44 UTC (rev 259301)
+++ trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm 2020-03-31 19:19:43 UTC (rev 259302)
@@ -112,7 +112,9 @@
RetainPtr VideoFullscreenModelVideoElement::createVideoFullscreenLayer()
{
-return m_videoElement->createVideoFullscreenLayer();
+if (m_videoElement)
+return m_videoElement->createVideoFullscreenLayer();
+return nullptr;
}
void VideoFullscreenModelVideoElement::setVideoFullscreenLayer(PlatformLayer*
[webkit-changes] [259301] trunk/LayoutTests
Title: [259301] trunk/LayoutTests Revision 259301 Author lawrenc...@apple.com Date 2020-03-31 11:22:44 -0700 (Tue, 31 Mar 2020) Log Message [ Mac Debug ] ASSERTION FAILED: m_videoFullscreenMode on media/media-fullscreen-return-to-inline.html https://bugs.webkit.org/show_bug.cgi?id=209823 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259300 => 259301) --- trunk/LayoutTests/ChangeLog 2020-03-31 17:40:37 UTC (rev 259300) +++ trunk/LayoutTests/ChangeLog 2020-03-31 18:22:44 UTC (rev 259301) @@ -1,3 +1,12 @@ +2020-03-31 Jason Lawrence + +[ Mac Debug ] ASSERTION FAILED: m_videoFullscreenMode on media/media-fullscreen-return-to-inline.html +https://bugs.webkit.org/show_bug.cgi?id=209823 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2020-03-31 Chris Lord requestAnimationFrame and cancelAnimationFrame should be present on DedicatedWorkerGlobalScope Modified: trunk/LayoutTests/platform/mac/TestExpectations (259300 => 259301) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-31 17:40:37 UTC (rev 259300) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-31 18:22:44 UTC (rev 259301) @@ -1655,7 +1655,7 @@ webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html [ Pass Failure Crash ] webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/error-codes/error.html [ Pass Failure ] -webkit.org/b/193399 media/media-fullscreen-return-to-inline.html [ Pass Timeout ] +webkit.org/b/193399 media/media-fullscreen-return-to-inline.html [ Pass Timeout Crash ] http/tests/websocket/tests/hybi/handshake-ok-with-legacy-sec-websocket-response-headers.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259300] trunk/Source/WebKit
Title: [259300] trunk/Source/WebKit Revision 259300 Author bfulg...@apple.com Date 2020-03-31 10:40:37 -0700 (Tue, 31 Mar 2020) Log Message [macOS] Add additional IPC permission needed by Security.framework https://bugs.webkit.org/show_bug.cgi?id=209815 Reviewed by Per Arne Vollan. Add missing permission needed for recent macOS releases. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (259299 => 259300) --- trunk/Source/WebKit/ChangeLog 2020-03-31 17:39:41 UTC (rev 259299) +++ trunk/Source/WebKit/ChangeLog 2020-03-31 17:40:37 UTC (rev 259300) @@ -1,3 +1,15 @@ +2020-03-31 Brent Fulgham + +[macOS] Add additional IPC permission needed by Security.framework +https://bugs.webkit.org/show_bug.cgi?id=209815 + + +Reviewed by Per Arne Vollan. + +Add missing permission needed for recent macOS releases. + +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: + 2020-03-31 Per Arne Vollan Silence preference write sandbox violations in the WebContent process Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (259299 => 259300) --- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2020-03-31 17:39:41 UTC (rev 259299) +++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2020-03-31 17:40:37 UTC (rev 259300) @@ -355,7 +355,7 @@ (home-regex (string-append "/Library/Preferences/ByHost/com\.apple\.ist\.ds\.appleconnect2\.production\." (uuid-regex-string) "\.plist$")) ) -(allow ipc-posix-shm-read* ipc-posix-shm-write-data +(allow ipc-posix-shm-read* ipc-posix-shm-write-create ipc-posix-shm-write-data (ipc-posix-name "com.apple.AppleDatabaseChanged")) (system-network) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259299] trunk/Source/WebCore
Title: [259299] trunk/Source/WebCore
Revision 259299
Author cdu...@apple.com
Date 2020-03-31 10:39:41 -0700 (Tue, 31 Mar 2020)
Log Message
ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
https://bugs.webkit.org/show_bug.cgi?id=209684
Reviewed by Darin Adler.
I have not been able to reproduce so this is a speculative fix. HTMLMediaElement::virtualHasPendingActivity()
was checking MainThreadGenericEventQueue::hasPendingEvents() but this would return false for a short amount
of time where we've removed the last event from the queue and before we've actually fired the event. To
address the issue, we now rely on MainThreadGenericEventQueue::hasPendingActivity() which keeps returning
true after we've dequeued the last event, until we've fired it.
No new tests, covered by imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html.
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::virtualHasPendingActivity const):
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::virtualHasPendingActivity const):
* dom/GenericEventQueue.cpp:
(WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
(WebCore::MainThreadGenericEventQueue::hasPendingActivity const):
(WebCore::MainThreadGenericEventQueue::hasPendingEvents const): Deleted.
* dom/GenericEventQueue.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
* html/track/TrackListBase.cpp:
(WebCore::TrackListBase::virtualHasPendingActivity const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
trunk/Source/WebCore/dom/GenericEventQueue.cpp
trunk/Source/WebCore/dom/GenericEventQueue.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/track/TrackListBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259298 => 259299)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 17:35:30 UTC (rev 259298)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 17:39:41 UTC (rev 259299)
@@ -1,3 +1,33 @@
+2020-03-31 Chris Dumez
+
+ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
+https://bugs.webkit.org/show_bug.cgi?id=209684
+
+
+Reviewed by Darin Adler.
+
+I have not been able to reproduce so this is a speculative fix. HTMLMediaElement::virtualHasPendingActivity()
+was checking MainThreadGenericEventQueue::hasPendingEvents() but this would return false for a short amount
+of time where we've removed the last event from the queue and before we've actually fired the event. To
+address the issue, we now rely on MainThreadGenericEventQueue::hasPendingActivity() which keeps returning
+true after we've dequeued the last event, until we've fired it.
+
+No new tests, covered by imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html.
+
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::virtualHasPendingActivity const):
+* Modules/mediasource/SourceBuffer.cpp:
+(WebCore::SourceBuffer::virtualHasPendingActivity const):
+* dom/GenericEventQueue.cpp:
+(WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
+(WebCore::MainThreadGenericEventQueue::hasPendingActivity const):
+(WebCore::MainThreadGenericEventQueue::hasPendingEvents const): Deleted.
+* dom/GenericEventQueue.h:
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
+* html/track/TrackListBase.cpp:
+(WebCore::TrackListBase::virtualHasPendingActivity const):
+
2020-03-31 Chris Lord
requestAnimationFrame and cancelAnimationFrame should be present on DedicatedWorkerGlobalScope
Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (259298 => 259299)
--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2020-03-31 17:35:30 UTC (rev 259298)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2020-03-31 17:39:41 UTC (rev 259299)
@@ -973,7 +973,7 @@
bool MediaSource::virtualHasPendingActivity() const
{
-return m_private || m_asyncEventQueue->hasPendingEvents();
+return m_private || m_asyncEventQueue->hasPendingActivity();
}
void MediaSource::stop()
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (259298 => 259299)
--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2020-03-31 17:35:30 UTC (rev 259298)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2020-03-31 17:39:41 UTC (rev 259299)
@@ -537,7 +537,7 @@
bool SourceBuffer::virtualHasPendingActivity() const
{
-return m_source || m_asyncEventQueue->hasPendingEvents();
+
[webkit-changes] [259298] trunk
Title: [259298] trunk Revision 259298 Author cl...@igalia.com Date 2020-03-31 10:35:30 -0700 (Tue, 31 Mar 2020) Log Message requestAnimationFrame and cancelAnimationFrame should be present on DedicatedWorkerGlobalScope https://bugs.webkit.org/show_bug.cgi?id=202525 Reviewed by Simon Fraser. Source/WebCore: Implement AnimationFrameProvider on DedicatedWorkerGlobalScope, This allows use of requestAnimationFrame and cancelAnimationFrame inside a dedicated worker thread. This is useful to control animation when using OffscreenCanvas, and this implementation is only enabled with the OffscreenCanvas build flag and runtime setting. Specification: https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#animation-frames No new tests. Covered by existing tests. * Headers.cmake: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/WebCoreBuiltinNames.h: * dom/RequestAnimationFrameCallback.h: * workers/DedicatedWorkerGlobalScope.cpp: (WebCore::DedicatedWorkerGlobalScope::requestAnimationFrame): (WebCore::DedicatedWorkerGlobalScope::cancelAnimationFrame): * workers/DedicatedWorkerGlobalScope.h: * workers/DedicatedWorkerGlobalScope.idl: * workers/WorkerAnimationController.cpp: Added. * workers/WorkerAnimationController.h: Added. * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::WorkerGlobalScope): * workers/WorkerGlobalScope.h: (WebCore::WorkerGlobalScope::requestAnimationFrameEnabled const): * workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerGlobalScope): * workers/WorkerThread.cpp: (WebCore::WorkerParameters::isolatedCopy const): * workers/WorkerThread.h: * workers/service/context/ServiceWorkerThread.cpp: (WebCore::ServiceWorkerThread::ServiceWorkerThread): LayoutTests: Add PASS expectations for DedicatedWorkerGlobalScope.AnimationFrameProvider on platforms where OffscreenCanvas is enabled. * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h trunk/Source/WebCore/dom/RequestAnimationFrameCallback.h trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.h trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl trunk/Source/WebCore/workers/WorkerGlobalScope.cpp trunk/Source/WebCore/workers/WorkerGlobalScope.h trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp trunk/Source/WebCore/workers/WorkerThread.cpp trunk/Source/WebCore/workers/WorkerThread.h trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp Added Paths trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/workers/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/workers/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt trunk/Source/WebCore/workers/WorkerAnimationController.cpp trunk/Source/WebCore/workers/WorkerAnimationController.h Diff Modified: trunk/LayoutTests/ChangeLog (259297 => 259298) --- trunk/LayoutTests/ChangeLog 2020-03-31 17:28:01 UTC (rev 259297) +++ trunk/LayoutTests/ChangeLog 2020-03-31 17:35:30 UTC (rev 259298) @@ -1,3 +1,18 @@ +2020-03-31 Chris Lord + +requestAnimationFrame and cancelAnimationFrame should be present on DedicatedWorkerGlobalScope +https://bugs.webkit.org/show_bug.cgi?id=202525 + +Reviewed by Simon Fraser. + +Add PASS expectations for DedicatedWorkerGlobalScope.AnimationFrameProvider on platforms where +OffscreenCanvas is enabled. + +* platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Added. +* platform/gtk/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt:
[webkit-changes] [259297] trunk/Source/WebKit
Title: [259297] trunk/Source/WebKit Revision 259297 Author pvol...@apple.com Date 2020-03-31 10:28:01 -0700 (Tue, 31 Mar 2020) Log Message Silence preference write sandbox violations in the WebContent process https://bugs.webkit.org/show_bug.cgi?id=209806 Reviewed by Brent Fulgham. When CFPrefs direct mode is enabled in the WebContent process, the UI process will notify the WebContent about preference changes. When receiving these notifications, the WebContent process will use the CFPrefs API to update the value of these preferences in-process, which will also attempt to write these values to disk. Writing the preference values to disk is unnecessary, and will also be denied by the sandbox, so the sandbox violations should be silenced. No new tests, no behavior change. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (259296 => 259297) --- trunk/Source/WebKit/ChangeLog 2020-03-31 17:03:58 UTC (rev 259296) +++ trunk/Source/WebKit/ChangeLog 2020-03-31 17:28:01 UTC (rev 259297) @@ -1,3 +1,20 @@ +2020-03-31 Per Arne Vollan + +Silence preference write sandbox violations in the WebContent process +https://bugs.webkit.org/show_bug.cgi?id=209806 + +Reviewed by Brent Fulgham. + +When CFPrefs direct mode is enabled in the WebContent process, the UI process will notify the WebContent about preference changes. +When receiving these notifications, the WebContent process will use the CFPrefs API to update the value of these preferences +in-process, which will also attempt to write these values to disk. Writing the preference values to disk is unnecessary, and will +also be denied by the sandbox, so the sandbox violations should be silenced. + +No new tests, no behavior change. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: +* WebProcess/com.apple.WebProcess.sb.in: + 2020-03-31 Devin Rousso REGRESSION: (r259236) [ iOS and Catalina wk2 Debug ] ASSERTION FAILED: m_debugLoggingEnabled in WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (259296 => 259297) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-03-31 17:03:58 UTC (rev 259296) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-03-31 17:28:01 UTC (rev 259297) @@ -845,6 +845,11 @@ (literal "/usr/local/lib/log") ; ) +;; +(deny file-write* +(home-subpath "/Library/Preferences/") +(with no-log)) + (allow mach-lookup (require-all (extension "com.apple.webkit.extension.mach") Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (259296 => 259297) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-03-31 17:03:58 UTC (rev 259296) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-03-31 17:28:01 UTC (rev 259297) @@ -873,6 +873,11 @@ (allow device-camera)) #endif // PLATFORM(MAC) +;; +(deny file-write* +(home-subpath "/Library/Preferences/") +(with no-log)) + (allow mach-lookup (require-all (extension "com.apple.webkit.extension.mach") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259296] trunk
Title: [259296] trunk
Revision 259296
Author za...@apple.com
Date 2020-03-31 10:03:58 -0700 (Tue, 31 Mar 2020)
Log Message
[Tables] Infinite recursion in RenderTreeBuilder::attach
https://bugs.webkit.org/show_bug.cgi?id=209771
Reviewed by Simon Fraser.
Source/WebCore:
Let's construct a COLGROUP wrapper when a COL element is inserted into a . The rest of the table code assumes such structure.
(https://www.w3.org/TR/html52/tabular-data.html#the-col-element)
Test: fast/table/anonymous-colgroup-simple.html
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
(WebCore::RenderTableCol::updateFromElement):
* rendering/RenderTableCol.h:
* rendering/updating/RenderTreeBuilderTable.cpp:
(WebCore::RenderTreeBuilder::Table::findOrCreateParentForChild):
LayoutTests:
* fast/table/anonymous-colgroup-simple-expected.txt: Added.
* fast/table/anonymous-colgroup-simple.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt
trunk/LayoutTests/platform/ios/css2.1/20110323/margin-applies-to-006-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/form-hides-table-expected.txt
trunk/LayoutTests/platform/ios/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt
trunk/LayoutTests/platform/ios/tables/mozilla_expected_failures/dom/appendCol1-expected.txt
trunk/LayoutTests/platform/ios-wk1/fast/table/table-insert-before-non-anonymous-block-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/margin-applies-to-006-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/form-hides-table-expected.txt
trunk/LayoutTests/platform/mac/fast/table/table-insert-before-non-anonymous-block-expected.txt
trunk/LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt
trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableCol.cpp
trunk/Source/WebCore/rendering/RenderTableCol.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderTable.cpp
Added Paths
trunk/LayoutTests/fast/table/anonymous-colgroup-simple-expected.txt
trunk/LayoutTests/fast/table/anonymous-colgroup-simple.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259295 => 259296)
--- trunk/LayoutTests/ChangeLog 2020-03-31 16:52:39 UTC (rev 259295)
+++ trunk/LayoutTests/ChangeLog 2020-03-31 17:03:58 UTC (rev 259296)
@@ -1,3 +1,14 @@
+2020-03-31 Zalan Bujtas
+
+[Tables] Infinite recursion in RenderTreeBuilder::attach
+https://bugs.webkit.org/show_bug.cgi?id=209771
+
+
+Reviewed by Simon Fraser.
+
+* fast/table/anonymous-colgroup-simple-expected.txt: Added.
+* fast/table/anonymous-colgroup-simple.html: Added.
+
2020-03-31 Jason Lawrence
REGRESSION: [ iOS wk2 ] fast/forms/input-text-scroll-left-on-blur.html is flaky failing.
Added: trunk/LayoutTests/fast/table/anonymous-colgroup-simple-expected.txt (0 => 259296)
--- trunk/LayoutTests/fast/table/anonymous-colgroup-simple-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/table/anonymous-colgroup-simple-expected.txt 2020-03-31 17:03:58 UTC (rev 259296)
@@ -0,0 +1 @@
+Pass if no crash or assert.
Added: trunk/LayoutTests/fast/table/anonymous-colgroup-simple.html (0 => 259296)
--- trunk/LayoutTests/fast/table/anonymous-colgroup-simple.html (rev 0)
+++ trunk/LayoutTests/fast/table/anonymous-colgroup-simple.html 2020-03-31 17:03:58 UTC (rev 259296)
@@ -0,0 +1,13 @@
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+document.body.offsetHeight;
+tbody.prepend(col);
+document.body.offsetHeight;
+col.before("or assert.");
+document.body.offsetHeight;
+tbody.prepend(col);
+document.body.offsetHeight;
+col.before("Pass if no crash ");
+
Modified: trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt (259295 => 259296)
--- trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt 2020-03-31 16:52:39 UTC (rev 259295)
+++ trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt 2020-03-31 17:03:58 UTC (rev 259296)
@@ -38,7 +38,8 @@
RenderTableRow (anonymous) at (0,0) size 100x50
RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
-RenderTableCol {DIV} at (0,0) size 0x0
+RenderTableCol at (0,0) size 0x0
+ RenderTableCol {DIV} at (0,0) size 0x0
RenderTable {DIV} at (0,300) size 101x50
RenderTableSection (anonymous) at (0,0) size 101x50
RenderTableRow (anonymous) at (0,0) size 101x50
Modified: trunk/LayoutTests/platform/ios/css2.1/20110323/margin-applies-to-006-expected.txt (259295 => 259296)
---
[webkit-changes] [259295] trunk/Tools
Title: [259295] trunk/Tools Revision 259295 Author aakash_j...@apple.com Date 2020-03-31 09:52:39 -0700 (Tue, 31 Mar 2020) Log Message Delete code for security EWS from old EWS (follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=209683 Revert 233220. Unreviewed follow-up fix. * Scripts/webkitpy/common/net/statusserver_mock.py: * Scripts/webkitpy/tool/commands/queues.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/net/statusserver_mock.py trunk/Tools/Scripts/webkitpy/tool/commands/queues.py Diff Modified: trunk/Tools/ChangeLog (259294 => 259295) --- trunk/Tools/ChangeLog 2020-03-31 16:10:58 UTC (rev 259294) +++ trunk/Tools/ChangeLog 2020-03-31 16:52:39 UTC (rev 259295) @@ -1,3 +1,15 @@ +2020-03-31 Aakash Jain + +Delete code for security EWS from old EWS (follow-up fix) +https://bugs.webkit.org/show_bug.cgi?id=209683 + +Revert 233220. + +Unreviewed follow-up fix. + +* Scripts/webkitpy/common/net/statusserver_mock.py: +* Scripts/webkitpy/tool/commands/queues.py: + 2020-03-30 Peng Liu PiP support of MiniBrowser is broken Modified: trunk/Tools/Scripts/webkitpy/common/net/statusserver_mock.py (259294 => 259295) --- trunk/Tools/Scripts/webkitpy/common/net/statusserver_mock.py 2020-03-31 16:10:58 UTC (rev 259294) +++ trunk/Tools/Scripts/webkitpy/common/net/statusserver_mock.py 2020-03-31 16:52:39 UTC (rev 259295) @@ -38,7 +38,6 @@ self.host = "example.com" self.bot_id = bot_id self._work_items = work_items or [] -self.use_https = True def patch_status(self, queue_name, patch_id): return None Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (259294 => 259295) --- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2020-03-31 16:10:58 UTC (rev 259294) +++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2020-03-31 16:52:39 UTC (rev 259295) @@ -90,8 +90,6 @@ # because our global option code looks for the first argument which does # not begin with "-" and assumes that is the command name. webkit_patch_args += ["--status-host=%s" % self._tool.status_server.host] -if not self._tool.status_server.use_https: -webkit_patch_args += ['--status-host-uses-http'] if self._tool.status_server.bot_id: webkit_patch_args += ["--bot-id=%s" % self._tool.status_server.bot_id] if self._options.port: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259294] trunk/LayoutTests
Title: [259294] trunk/LayoutTests Revision 259294 Author lawrenc...@apple.com Date 2020-03-31 09:10:58 -0700 (Tue, 31 Mar 2020) Log Message REGRESSION: [ iOS wk2 ] fast/forms/input-text-scroll-left-on-blur.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=209812 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259293 => 259294) --- trunk/LayoutTests/ChangeLog 2020-03-31 16:09:09 UTC (rev 259293) +++ trunk/LayoutTests/ChangeLog 2020-03-31 16:10:58 UTC (rev 259294) @@ -1,3 +1,12 @@ +2020-03-31 Jason Lawrence + +REGRESSION: [ iOS wk2 ] fast/forms/input-text-scroll-left-on-blur.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=209812 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-03-31 Ryan Haddad Flaky Test: media/track/track-in-band-metadata-display-order.html Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (259293 => 259294) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-31 16:09:09 UTC (rev 259293) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-31 16:10:58 UTC (rev 259294) @@ -1756,3 +1756,5 @@ webkit.org/b/209520 http/wpt/fetch/dnt-header-after-redirection.html [ Pass Timeout ] webkit.org/b/209544 svg/custom/object-sizing-explicit-width.xhtml [ Pass Failure ] + +webkit.org/b/209812 fast/forms/input-text-scroll-left-on-blur.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259293] trunk/Source/WebKit
Title: [259293] trunk/Source/WebKit
Revision 259293
Author drou...@apple.com
Date 2020-03-31 09:09:09 -0700 (Tue, 31 Mar 2020)
Log Message
REGRESSION: (r259236) [ iOS and Catalina wk2 Debug ] ASSERTION FAILED: m_debugLoggingEnabled in WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage
https://bugs.webkit.org/show_bug.cgi?id=209810
Unreviewed, covered by existing tests.
* NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage):
Remove the assertion since `debugBroadcastConsoleMessage` is also called when turning off
debug logging mode via `setResourceLoadStatisticsDebugMode`. Fundamentally, it's just a
wrapper function for `broadcastConsoleMessage` anyways, so it doesn't need to be gated.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (259292 => 259293)
--- trunk/Source/WebKit/ChangeLog 2020-03-31 15:40:01 UTC (rev 259292)
+++ trunk/Source/WebKit/ChangeLog 2020-03-31 16:09:09 UTC (rev 259293)
@@ -1,3 +1,17 @@
+2020-03-31 Devin Rousso
+
+REGRESSION: (r259236) [ iOS and Catalina wk2 Debug ] ASSERTION FAILED: m_debugLoggingEnabled in WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage
+https://bugs.webkit.org/show_bug.cgi?id=209810
+
+
+Unreviewed, covered by existing tests.
+
+* NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
+(WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage):
+Remove the assertion since `debugBroadcastConsoleMessage` is also called when turning off
+debug logging mode via `setResourceLoadStatisticsDebugMode`. Fundamentally, it's just a
+wrapper function for `broadcastConsoleMessage` anyways, so it doesn't need to be gated.
+
2020-03-31 Pablo Saavedra
Several refactorings done in the MemoryPressureMonitor.cpp
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp (259292 => 259293)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp 2020-03-31 15:40:01 UTC (rev 259292)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp 2020-03-31 16:09:09 UTC (rev 259293)
@@ -588,8 +588,6 @@
void ResourceLoadStatisticsStore::debugBroadcastConsoleMessage(MessageSource source, MessageLevel level, const String& message)
{
-ASSERT(m_debugLoggingEnabled);
-
if (!RunLoop::isMain()) {
RunLoop::main().dispatch([&, weakThis = makeWeakPtr(*this), source = crossThreadCopy(source), level = crossThreadCopy(level), message = crossThreadCopy(message)]() {
if (!weakThis)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259292] trunk/LayoutTests
Title: [259292] trunk/LayoutTests Revision 259292 Author ryanhad...@apple.com Date 2020-03-31 08:40:01 -0700 (Tue, 31 Mar 2020) Log Message Flaky Test: media/track/track-in-band-metadata-display-order.html https://bugs.webkit.org/show_bug.cgi?id=206226 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Mark test as flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259291 => 259292) --- trunk/LayoutTests/ChangeLog 2020-03-31 15:13:00 UTC (rev 259291) +++ trunk/LayoutTests/ChangeLog 2020-03-31 15:40:01 UTC (rev 259292) @@ -1,3 +1,12 @@ +2020-03-31 Ryan Haddad + +Flaky Test: media/track/track-in-band-metadata-display-order.html +https://bugs.webkit.org/show_bug.cgi?id=206226 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: Mark test as flaky. + 2020-03-31 Diego Pino Garcia [WPE] Gardening, add missing expectation files Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259291 => 259292) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-31 15:13:00 UTC (rev 259291) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-31 15:40:01 UTC (rev 259292) @@ -683,6 +683,8 @@ webkit.org/b/183220 media/track/track-css-matching-timestamps.html [ Pass Timeout ] +webkit.org/b/206226 [ Debug ] media/track/track-in-band-metadata-display-order.html [ Pass Failure ] + imported/w3c/web-platform-tests/css/selectors/selector-placeholder-shown-type-change-002.html [ ImageOnlyFailure ] webkit.org/b/184456 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259291] trunk/LayoutTests
Title: [259291] trunk/LayoutTests Revision 259291 Author dp...@igalia.com Date 2020-03-31 08:13:00 -0700 (Tue, 31 Mar 2020) Log Message [WPE] Gardening, add missing expectation files https://bugs.webkit.org/show_bug.cgi?id=209807 Unreviewed gardening. * platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt: Added. * platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt: Added. * platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt: Added. * platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt: Added. * platform/wpe/fast/html/details-marker-style-mixed-expected.txt: Added. * platform/wpe/fast/html/details-writing-mode-mixed-expected.txt: Added. * platform/wpe/fast/multicol/tall-image-behavior-lr-mixed-expected.txt: Added. * platform/wpe/fast/writing-mode/background-vertical-lr-mixed-expected.txt: Added. * platform/wpe/fast/writing-mode/background-vertical-rl-mixed-expected.txt: Added. * platform/wpe/fast/writing-mode/basic-vertical-line-mixed-expected.txt: Added. * platform/wpe/fast/writing-mode/border-styles-vertical-lr-mixed-expected.txt: Added. * platform/wpe/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt: Added. * platform/wpe/fast/writing-mode/vertical-baseline-alignment-mixed-expected.txt: Added. * platform/wpe/fast/writing-mode/vertical-lr-replaced-selection-mixed-expected.txt: Added. * platform/wpe/fast/writing-mode/vertical-rl-replaced-selection-mixed-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/html/details-marker-style-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/html/details-writing-mode-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/multicol/tall-image-behavior-lr-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/writing-mode/background-vertical-lr-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/writing-mode/background-vertical-rl-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/writing-mode/basic-vertical-line-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/writing-mode/border-styles-vertical-lr-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/writing-mode/vertical-baseline-alignment-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/writing-mode/vertical-lr-replaced-selection-mixed-expected.txt trunk/LayoutTests/platform/wpe/fast/writing-mode/vertical-rl-replaced-selection-mixed-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (259290 => 259291) --- trunk/LayoutTests/ChangeLog 2020-03-31 15:01:15 UTC (rev 259290) +++ trunk/LayoutTests/ChangeLog 2020-03-31 15:13:00 UTC (rev 259291) @@ -1,3 +1,26 @@ +2020-03-31 Diego Pino Garcia + +[WPE] Gardening, add missing expectation files +https://bugs.webkit.org/show_bug.cgi?id=209807 + +Unreviewed gardening. + +* platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt: Added. +* platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt: Added. +* platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt: Added. +* platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt: Added. +* platform/wpe/fast/html/details-marker-style-mixed-expected.txt: Added. +* platform/wpe/fast/html/details-writing-mode-mixed-expected.txt: Added. +* platform/wpe/fast/multicol/tall-image-behavior-lr-mixed-expected.txt: Added. +* platform/wpe/fast/writing-mode/background-vertical-lr-mixed-expected.txt: Added. +* platform/wpe/fast/writing-mode/background-vertical-rl-mixed-expected.txt: Added. +* platform/wpe/fast/writing-mode/basic-vertical-line-mixed-expected.txt: Added. +* platform/wpe/fast/writing-mode/border-styles-vertical-lr-mixed-expected.txt: Added. +* platform/wpe/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt: Added. +* platform/wpe/fast/writing-mode/vertical-baseline-alignment-mixed-expected.txt: Added. +* platform/wpe/fast/writing-mode/vertical-lr-replaced-selection-mixed-expected.txt: Added. +* platform/wpe/fast/writing-mode/vertical-rl-replaced-selection-mixed-expected.txt: Added. + 2020-03-31 youenn fablet Fix SDP filtering after
[webkit-changes] [259290] trunk
Title: [259290] trunk
Revision 259290
Author you...@apple.com
Date 2020-03-31 08:01:15 -0700 (Tue, 31 Mar 2020)
Log Message
Fix SDP filtering after https://trac.webkit.org/changeset/258545
https://bugs.webkit.org/show_bug.cgi?id=209799
Reviewed by Eric Carlson.
Source/WebCore:
Covered by updated test.
* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::filterSDP const):
Do not return early in case of filtering of mDNS candidate inlined in SDP description.
LayoutTests:
* webrtc/datachannel/mdns-ice-candidates-expected.txt:
* webrtc/datachannel/mdns-ice-candidates.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates-expected.txt
trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (259289 => 259290)
--- trunk/LayoutTests/ChangeLog 2020-03-31 14:53:03 UTC (rev 259289)
+++ trunk/LayoutTests/ChangeLog 2020-03-31 15:01:15 UTC (rev 259290)
@@ -1,3 +1,13 @@
+2020-03-31 youenn fablet
+
+Fix SDP filtering after https://trac.webkit.org/changeset/258545
+https://bugs.webkit.org/show_bug.cgi?id=209799
+
+Reviewed by Eric Carlson.
+
+* webrtc/datachannel/mdns-ice-candidates-expected.txt:
+* webrtc/datachannel/mdns-ice-candidates.html:
+
2020-03-31 Antti Koivisto
Nullptr crash in InlineTextBox::emphasisMarkExistsAndIsAbove
Modified: trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates-expected.txt (259289 => 259290)
--- trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates-expected.txt 2020-03-31 14:53:03 UTC (rev 259289)
+++ trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates-expected.txt 2020-03-31 15:01:15 UTC (rev 259290)
@@ -4,4 +4,5 @@
PASS Basic data channel exchange from receiver to offerer
PASS Basic data channel exchange from offerer to receiver using UDP only
PASS Basic data channel exchange from offerer to receiver 2
+PASS Ensure that local description SDP filtering is correctly filtering mDNS local candidates
Modified: trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates.html (259289 => 259290)
--- trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates.html 2020-03-31 14:53:03 UTC (rev 259289)
+++ trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates.html 2020-03-31 15:01:15 UTC (rev 259290)
@@ -153,6 +153,29 @@
});
}, "Basic data channel exchange from offerer to receiver 2");
+promise_test(async (test) => {
+const pc = new RTCPeerConnection();
+const channel = pc.createDataChannel('sendDataChannel');
+const offer = await pc.createOffer();
+await pc.setLocalDescription(offer);
+await new Promise(resolve => setTimeout(resolve, 200));
+
+const channel2 = pc.createDataChannel('sendDataChannel2');
+const offer2 = await pc.createOffer();
+const description = pc.localDescription;
+
+// Make sure we can apply the filtered description.
+await pc.setLocalDescription(description);
+
+const lines = description.sdp.split('\r\n').filter(line => {
+return line.indexOf('a=candidate') === 0;
+});
+
+assert_true(lines.length > 0, "candidates are gathered");
+assert_true(lines[0].includes(' host '), "candidate is host");
+assert_true(lines[0].includes('.local '), "candidate is mDNS");
+}, "Ensure that local description SDP filtering is correctly filtering mDNS local candidates");
+
Modified: trunk/Source/WebCore/ChangeLog (259289 => 259290)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 14:53:03 UTC (rev 259289)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 15:01:15 UTC (rev 259290)
@@ -1,5 +1,18 @@
2020-03-31 youenn fablet
+Fix SDP filtering after https://trac.webkit.org/changeset/258545
+https://bugs.webkit.org/show_bug.cgi?id=209799
+
+Reviewed by Eric Carlson.
+
+Covered by updated test.
+
+* Modules/mediastream/PeerConnectionBackend.cpp:
+(WebCore::PeerConnectionBackend::filterSDP const):
+Do not return early in case of filtering of mDNS candidate inlined in SDP description.
+
+2020-03-31 youenn fablet
+
Ensure that RealtimeMediaSource::setShouldApplyRotation is called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=209797
Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp (259289 => 259290)
--- trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2020-03-31 14:53:03 UTC (rev 259289)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2020-03-31 15:01:15 UTC (rev 259290)
@@ -455,7 +455,6 @@
sdp.replace(ipAddress, mdnsName);
filteredSDP.append(sdp);
}
-return;
}
filteredSDP.append('\n');
});
___
[webkit-changes] [259289] trunk/Source/WebCore
Title: [259289] trunk/Source/WebCore
Revision 259289
Author you...@apple.com
Date 2020-03-31 07:53:03 -0700 (Tue, 31 Mar 2020)
Log Message
Ensure that RealtimeMediaSource::setShouldApplyRotation is called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=209797
Reviewed by Eric Carlson.
Hop to the main thread before calling setShouldApplyRotation on the source.
* platform/mediastream/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::setSource):
(WebCore::RealtimeOutgoingVideoSource::applyRotation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259288 => 259289)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 14:52:40 UTC (rev 259288)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 14:53:03 UTC (rev 259289)
@@ -1,3 +1,16 @@
+2020-03-31 youenn fablet
+
+Ensure that RealtimeMediaSource::setShouldApplyRotation is called on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=209797
+
+Reviewed by Eric Carlson.
+
+Hop to the main thread before calling setShouldApplyRotation on the source.
+
+* platform/mediastream/RealtimeOutgoingVideoSource.cpp:
+(WebCore::RealtimeOutgoingVideoSource::setSource):
+(WebCore::RealtimeOutgoingVideoSource::applyRotation):
+
2020-03-31 Andres Gonzalez
The relative frame and hit test of isolated objects must be dispatched to the main thread.
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp (259288 => 259289)
--- trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp 2020-03-31 14:52:40 UTC (rev 259288)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp 2020-03-31 14:53:03 UTC (rev 259289)
@@ -78,6 +78,7 @@
void RealtimeOutgoingVideoSource::setSource(Ref&& newSource)
{
+ASSERT(isMainThread());
ASSERT(!m_videoSource->hasObserver(*this));
m_videoSource = WTFMove(newSource);
@@ -89,6 +90,12 @@
void RealtimeOutgoingVideoSource::applyRotation()
{
+if (!isMainThread()) {
+callOnMainThread([this, protectedThis = makeRef(*this)] {
+applyRotation();
+});
+return;
+}
if (m_areSinksAskingToApplyRotation)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259288] trunk/Source/WebCore
Title: [259288] trunk/Source/WebCore Revision 259288 Author andresg...@apple.com Date 2020-03-31 07:52:40 -0700 (Tue, 31 Mar 2020) Log Message The relative frame and hit test of isolated objects must be dispatched to the main thread. https://bugs.webkit.org/show_bug.cgi?id=209792 Reviewed by Chris Fleizach. The relative frame of isolated objects must be calculated on the main thread because it requires the scroll ancestor to convert to the appropriate scroll offset. The relative frame cannot be cached because the scroll offset can change. Accordingly, the hit test cannot rely on a cached relative frame and must be dispatched to be computed on the main thread as well. * accessibility/AXObjectCache.h: * accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeAttributeData): Do not cache the relative frame any longer. (WebCore::AXIsolatedObject::accessibilityHitTest const): Dispatched to the main thread. (WebCore::AXIsolatedObject::relativeFrame const): Dispatched to the main thread. * accessibility/isolatedtree/AXIsolatedObject.h: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper position]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): (-[WebAccessibilityObjectWrapper accessibilityHitTest:]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.h trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (259287 => 259288) --- trunk/Source/WebCore/ChangeLog 2020-03-31 14:20:40 UTC (rev 259287) +++ trunk/Source/WebCore/ChangeLog 2020-03-31 14:52:40 UTC (rev 259288) @@ -1,3 +1,28 @@ +2020-03-31 Andres Gonzalez + +The relative frame and hit test of isolated objects must be dispatched to the main thread. +https://bugs.webkit.org/show_bug.cgi?id=209792 + +Reviewed by Chris Fleizach. + +The relative frame of isolated objects must be calculated on the main +thread because it requires the scroll ancestor to convert to the +appropriate scroll offset. The relative frame cannot be cached because +the scroll offset can change. +Accordingly, the hit test cannot rely on a cached relative frame and +must be dispatched to be computed on the main thread as well. + +* accessibility/AXObjectCache.h: +* accessibility/isolatedtree/AXIsolatedObject.cpp: +(WebCore::AXIsolatedObject::initializeAttributeData): Do not cache the relative frame any longer. +(WebCore::AXIsolatedObject::accessibilityHitTest const): Dispatched to the main thread. +(WebCore::AXIsolatedObject::relativeFrame const): Dispatched to the main thread. +* accessibility/isolatedtree/AXIsolatedObject.h: +* accessibility/mac/WebAccessibilityObjectWrapperMac.mm: +(-[WebAccessibilityObjectWrapper position]): +(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): +(-[WebAccessibilityObjectWrapper accessibilityHitTest:]): + 2020-03-31 Antti Koivisto Nullptr crash in InlineTextBox::emphasisMarkExistsAndIsAbove Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (259287 => 259288) --- trunk/Source/WebCore/accessibility/AXObjectCache.h 2020-03-31 14:20:40 UTC (rev 259287) +++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2020-03-31 14:52:40 UTC (rev 259288) @@ -358,8 +358,8 @@ AXCoreObject* isolatedTreeRootObject(); AXCoreObject* isolatedTreeFocusedObject(); void setIsolatedTreeFocusedObject(Node*); +static Ref generateIsolatedTree(PageIdentifier, Document&); RefPtr getOrCreateIsolatedTree() const; -static Ref generateIsolatedTree(PageIdentifier, Document&); void updateIsolatedTree(AXCoreObject&, AXNotification); void updateIsolatedTree(const Vector, AXNotification>>&); static void initializeSecondaryAXThread(); Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp (259287 => 259288) --- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp 2020-03-31 14:20:40 UTC (rev 259287) +++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp 2020-03-31 14:52:40 UTC (rev 259288) @@ -121,7 +121,6 @@ setProperty(AXPropertyName::IsValueAutofilled, object.isValueAutofilled()); setProperty(AXPropertyName::IsVisible, object.isVisible()); setProperty(AXPropertyName::IsVisited, object.isVisited()); -setProperty(AXPropertyName::RelativeFrame, object.relativeFrame()); setProperty(AXPropertyName::RoleDescription, object.roleDescription().isolatedCopy()); setProperty(AXPropertyName::RolePlatformString, object.rolePlatformString().isolatedCopy()); setProperty(AXPropertyName::RoleValue, static_cast(object.roleValue())); @@
[webkit-changes] [259287] trunk/Source/WebKit
Title: [259287] trunk/Source/WebKit
Revision 259287
Author psaave...@igalia.com
Date 2020-03-31 07:20:40 -0700 (Tue, 31 Mar 2020)
Log Message
Several refactorings done in the MemoryPressureMonitor.cpp
https://bugs.webkit.org/show_bug.cgi?id=209464
Reviewed by Adrian Perez de Castro.
1) toIntegralType() parses the C-string str interpreting its content
as an `unsigned long long int` which is more appropriate for
the size_t (unsigned integer type) variables used by the
MemoryPressureMonitor functions in counterpoint of atoll() what
returns a `long long int`.
This change also controls if the parsing was succesful. In negative
case returns `notSet`.
2) Added the getCgroupFileValue() function what encapsulates the
manipulation of the opened files in the `/sys/fs/cgroup` hierarchy.
This change simplify the code avoding unnecessary code repetion.
3) getCgroupControllerPath() now checks if there is a `name=systemd`
controller listed in the `/proc/self/cgroup`. This important for
cgroup v2 activated with `systemd.unified_cgroup_hierarchy=yes`
through the Linux kernel cmdline. The unified hierarchy simplies
path of the controllers under the same directory (check the
"Deprecated v1 Core Features" section in the Linux Kernel
documentation fir cgroup v2 [1]):
Multiple hierarchies including named ones are not supported
[1] https://www.kernel.org/doc/Documentation/cgroup-v2.txt
4) Because 3) the patch composited for cgroupV2 changes
getMemoryUsageWithCgroup() slightly. The name of the controller
is not needed anymore.
5) For cgroup v2, the MemoryTotal is calculated as the minimum
between memory.high and memory.max.
* UIProcess/linux/MemoryPressureMonitor.cpp:
(WebKit::lowWatermarkPages):
(WebKit::getCgroupFileValue):
(WebKit::getMemoryTotalWithCgroup):
(WebKit::getMemoryUsageWithCgroup):
(WebKit::getCgroupControllerPath):
(WebKit::systemMemoryUsedAsPercentage):
(WebKit::getCgroupController): Deleted.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (259286 => 259287)
--- trunk/Source/WebKit/ChangeLog 2020-03-31 14:13:50 UTC (rev 259286)
+++ trunk/Source/WebKit/ChangeLog 2020-03-31 14:20:40 UTC (rev 259287)
@@ -1,3 +1,51 @@
+2020-03-31 Pablo Saavedra
+
+Several refactorings done in the MemoryPressureMonitor.cpp
+https://bugs.webkit.org/show_bug.cgi?id=209464
+
+Reviewed by Adrian Perez de Castro.
+
+1) toIntegralType() parses the C-string str interpreting its content
+as an `unsigned long long int` which is more appropriate for
+the size_t (unsigned integer type) variables used by the
+MemoryPressureMonitor functions in counterpoint of atoll() what
+returns a `long long int`.
+
+This change also controls if the parsing was succesful. In negative
+case returns `notSet`.
+
+2) Added the getCgroupFileValue() function what encapsulates the
+manipulation of the opened files in the `/sys/fs/cgroup` hierarchy.
+This change simplify the code avoding unnecessary code repetion.
+
+3) getCgroupControllerPath() now checks if there is a `name=systemd`
+controller listed in the `/proc/self/cgroup`. This important for
+cgroup v2 activated with `systemd.unified_cgroup_hierarchy=yes`
+through the Linux kernel cmdline. The unified hierarchy simplies
+path of the controllers under the same directory (check the
+"Deprecated v1 Core Features" section in the Linux Kernel
+documentation fir cgroup v2 [1]):
+
+Multiple hierarchies including named ones are not supported
+
+[1] https://www.kernel.org/doc/Documentation/cgroup-v2.txt
+
+4) Because 3) the patch composited for cgroupV2 changes
+getMemoryUsageWithCgroup() slightly. The name of the controller
+is not needed anymore.
+
+5) For cgroup v2, the MemoryTotal is calculated as the minimum
+between memory.high and memory.max.
+
+* UIProcess/linux/MemoryPressureMonitor.cpp:
+(WebKit::lowWatermarkPages):
+(WebKit::getCgroupFileValue):
+(WebKit::getMemoryTotalWithCgroup):
+(WebKit::getMemoryUsageWithCgroup):
+(WebKit::getCgroupControllerPath):
+(WebKit::systemMemoryUsedAsPercentage):
+(WebKit::getCgroupController): Deleted.
+
2020-03-31 Zan Dobersek
[GTK][WPE] Jumpy rendering of fixed-element layers while scrolling
Modified: trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp (259286 => 259287)
--- trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp 2020-03-31 14:13:50 UTC (rev 259286)
+++ trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp 2020-03-31 14:20:40 UTC (rev 259287)
@@ -36,6 +36,7 @@
#include
#include
#include
+#include
namespace WebKit {
@@ -49,7 +50,7 @@
static const int
[webkit-changes] [259286] trunk
Title: [259286] trunk
Revision 259286
Author an...@apple.com
Date 2020-03-31 07:13:50 -0700 (Tue, 31 Mar 2020)
Log Message
Nullptr crash in InlineTextBox::emphasisMarkExistsAndIsAbove
https://bugs.webkit.org/show_bug.cgi?id=207034
Reviewed by Zalan Bujtas.
Source/WebCore:
The repro case was fixed in https://bugs.webkit.org/show_bug.cgi?id=209695.
Test: editing/selection/selection-update-during-anonymous-inline-teardown.html
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
Also add a null check to be sure.
LayoutTests:
* editing/selection/selection-update-during-anonymous-inline-teardown-expected.txt: Added.
* editing/selection/selection-update-during-anonymous-inline-teardown.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineTextBox.cpp
Added Paths
trunk/LayoutTests/editing/selection/selection-update-during-anonymous-inline-teardown-expected.txt
trunk/LayoutTests/editing/selection/selection-update-during-anonymous-inline-teardown.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259285 => 259286)
--- trunk/LayoutTests/ChangeLog 2020-03-31 12:58:32 UTC (rev 259285)
+++ trunk/LayoutTests/ChangeLog 2020-03-31 14:13:50 UTC (rev 259286)
@@ -1,3 +1,13 @@
+2020-03-31 Antti Koivisto
+
+Nullptr crash in InlineTextBox::emphasisMarkExistsAndIsAbove
+https://bugs.webkit.org/show_bug.cgi?id=207034
+
+Reviewed by Zalan Bujtas.
+
+* editing/selection/selection-update-during-anonymous-inline-teardown-expected.txt: Added.
+* editing/selection/selection-update-during-anonymous-inline-teardown.html: Added.
+
2020-03-31 Diego Pino Garcia
[GTK] Gardening, update TestExpectations and add baseline
Added: trunk/LayoutTests/editing/selection/selection-update-during-anonymous-inline-teardown-expected.txt (0 => 259286)
--- trunk/LayoutTests/editing/selection/selection-update-during-anonymous-inline-teardown-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/selection/selection-update-during-anonymous-inline-teardown-expected.txt 2020-03-31 14:13:50 UTC (rev 259286)
@@ -0,0 +1,2 @@
+This test passes if it doesn't crash
+content
Added: trunk/LayoutTests/editing/selection/selection-update-during-anonymous-inline-teardown.html (0 => 259286)
--- trunk/LayoutTests/editing/selection/selection-update-during-anonymous-inline-teardown.html (rev 0)
+++ trunk/LayoutTests/editing/selection/selection-update-during-anonymous-inline-teardown.html 2020-03-31 14:13:50 UTC (rev 259286)
@@ -0,0 +1,15 @@
+
+span {
+ -webkit-text-emphasis: open;
+ display: contents;
+}
+svg {
+ border-left: 1px solid red;
+}
+This test passes if it doesn't crashcontent
+if (window.testRunner)
+testRunner.dumpAsText();
+document.body.offsetHeight;
+document.execCommand("selectAll", false);
+document.linkColor = "red";
+
Modified: trunk/Source/WebCore/ChangeLog (259285 => 259286)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 12:58:32 UTC (rev 259285)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 14:13:50 UTC (rev 259286)
@@ -1,3 +1,19 @@
+2020-03-31 Antti Koivisto
+
+Nullptr crash in InlineTextBox::emphasisMarkExistsAndIsAbove
+https://bugs.webkit.org/show_bug.cgi?id=207034
+
+Reviewed by Zalan Bujtas.
+
+The repro case was fixed in https://bugs.webkit.org/show_bug.cgi?id=209695.
+
+Test: editing/selection/selection-update-during-anonymous-inline-teardown.html
+
+* rendering/InlineTextBox.cpp:
+(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
+
+Also add a null check to be sure.
+
2020-03-31 Zan Dobersek
[GTK][WPE] Jumpy rendering of fixed-element layers while scrolling
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (259285 => 259286)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2020-03-31 12:58:32 UTC (rev 259285)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2020-03-31 14:13:50 UTC (rev 259286)
@@ -417,7 +417,7 @@
return isAbove; // Ruby text is always over, so it cannot suppress emphasis marks under.
RenderBlock* containingBlock = renderer().containingBlock();
-if (!containingBlock->isRubyBase())
+if (!containingBlock || !containingBlock->isRubyBase())
return isAbove; // This text is not inside a ruby base, so it does not have ruby text over it.
if (!is(*containingBlock->parent()))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259285] trunk/LayoutTests
Title: [259285] trunk/LayoutTests Revision 259285 Author dp...@igalia.com Date 2020-03-31 05:58:32 -0700 (Tue, 31 Mar 2020) Log Message [GTK] Gardening, update TestExpectations and add baseline https://bugs.webkit.org/show_bug.cgi?id=209803 Unreviewed gardening. * platform/gtk/TestExpectations: * platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Added Paths trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (259284 => 259285) --- trunk/LayoutTests/ChangeLog 2020-03-31 09:38:35 UTC (rev 259284) +++ trunk/LayoutTests/ChangeLog 2020-03-31 12:58:32 UTC (rev 259285) @@ -1,3 +1,13 @@ +2020-03-31 Diego Pino Garcia + +[GTK] Gardening, update TestExpectations and add baseline +https://bugs.webkit.org/show_bug.cgi?id=209803 + +Unreviewed gardening. + +* platform/gtk/TestExpectations: +* platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt: Added. + 2020-03-30 Antti Koivisto Delete css-modsel-* tests under css3/ and fast/ Modified: trunk/LayoutTests/platform/gtk/TestExpectations (259284 => 259285) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-03-31 09:38:35 UTC (rev 259284) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-03-31 12:58:32 UTC (rev 259285) @@ -1369,6 +1369,8 @@ webkit.org/b/209727 fast/forms/placeholder-content-line-height.html [ ImageOnlyFailure ] +webkit.org/b/209801 imported/w3c/web-platform-tests/xhr/header-user-agent-sync.htm [ Failure ] + # # End of Expected failures. # Added: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt (0 => 259285) --- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt 2020-03-31 12:58:32 UTC (rev 259285) @@ -0,0 +1,7 @@ +This test checks that any element focused via an autofocus attribute will have :focus-visible matching enabled. +If the button that says "I will be focused automatically" has a red background, then the test result is FAILURE. If it has a green outline, then the test result is SUCCESS. + +I will be focused automatically. + +FAIL Autofocus should match :focus-visible assert_equals: expected "rgb(0, 100, 0)" but got "rgb(0, 0, 0)" + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259284] trunk/Source
Title: [259284] trunk/Source Revision 259284 Author zandober...@gmail.com Date 2020-03-31 02:38:35 -0700 (Tue, 31 Mar 2020) Log Message [GTK][WPE] Jumpy rendering of fixed-element layers while scrolling https://bugs.webkit.org/show_bug.cgi?id=209466 Reviewed by Carlos Garcia Campos. Source/WebCore: Avoid intermittent state application that can occur when asynchronous scrolling is done on the dedicated thread while the general scene update is being done in parallel on the composition thread, leading to partial scrolling updates that visually present themselves as e.g. fixed elements "jumping" around the view. Instead of the staging state of a given Nicosia::CompositionLayer, the scrolling nodes now update the base state with the given scrolling change. At the end of the update, inside the UpdateScope descructor, the updated states inside the scene are flushed into the staging phase before they are adopted by the composition thread. * page/scrolling/nicosia/ScrollingTreeFixedNode.cpp: (WebCore::ScrollingTreeFixedNode::applyLayerPositions): * page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp: (WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionScrollingLayers): (WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionRelatedLayers): * page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.cpp: (WebCore::ScrollingTreeOverflowScrollProxyNode::applyLayerPositions): * page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp: (WebCore::ScrollingTreeOverflowScrollingNodeNicosia::repositionScrollingLayers): * page/scrolling/nicosia/ScrollingTreePositionedNode.cpp: (WebCore::ScrollingTreePositionedNode::applyLayerPositions): * page/scrolling/nicosia/ScrollingTreeStickyNode.cpp: (WebCore::ScrollingTreeStickyNode::applyLayerPositions): * platform/graphics/nicosia/NicosiaPlatformLayer.h: (Nicosia::CompositionLayer::accessStaging): Deleted. * platform/graphics/nicosia/NicosiaSceneIntegration.cpp: (Nicosia::SceneIntegration::SceneIntegration): (Nicosia::SceneIntegration::invalidate): (Nicosia::SceneIntegration::UpdateScope::~UpdateScope): * platform/graphics/nicosia/NicosiaSceneIntegration.h: (Nicosia::SceneIntegration::create): * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::syncPosition): Don't signal the related attribute delta flag since this change is now strictly applied by the scrolling thread. (WebCore::CoordinatedGraphicsLayer::syncBoundsOrigin): Ditto. Source/WebKit: Move the Nicosia::SceneIntegration ownership into the CompositingCoordinator class, along with the SceneIntegration::Client inheritance. LayerTreeHost in turn now implements the updateScene() method that triggers a scene update when invoked. * WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: (WebKit::CompositingCoordinator::CompositingCoordinator): (WebKit::CompositingCoordinator::invalidate): (WebKit::CompositingCoordinator::attachLayer): (WebKit::CompositingCoordinator::requestUpdate): * WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h: * WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp: (WebKit::LayerTreeHost::LayerTreeHost): (WebKit::LayerTreeHost::~LayerTreeHost): (WebKit::LayerTreeHost::updateScene): (WebKit::LayerTreeHost::sceneIntegration): Deleted. (WebKit::LayerTreeHost::requestUpdate): Deleted. * WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNode.cpp trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.cpp trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.cpp trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNode.cpp trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.h trunk/Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.cpp trunk/Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h Diff Modified: trunk/Source/WebCore/ChangeLog (259283 => 259284) --- trunk/Source/WebCore/ChangeLog 2020-03-31 09:10:58 UTC (rev 259283) +++ trunk/Source/WebCore/ChangeLog 2020-03-31 09:38:35 UTC (rev 259284) @@ -1,3 +1,49 @@ +2020-03-31 Zan Dobersek + +[GTK][WPE] Jumpy rendering of fixed-element layers while scrolling +
[webkit-changes] [259283] trunk/Source/WebKit
Title: [259283] trunk/Source/WebKit
Revision 259283
Author carlo...@webkit.org
Date 2020-03-31 02:10:58 -0700 (Tue, 31 Mar 2020)
Log Message
REGRESSION(r258829): [CoordinatedGraphics] Web view not updated after cross site navigation with PSON enabled
https://bugs.webkit.org/show_bug.cgi?id=209741
Reviewed by Žan Doberšek.
Since r258829, the drawing area proxy of a provisional page ignores all messages until the load is
committed. This is causing 2 problems for coordinated graphics drawing area. When not in accelerated compositing
mode, Update message is sent before the commit is loaded, and the web process keeps waiting for the DidUpdate
response message forever. When accelerated compositing mode is forced, the EnterAcceleratedCompositing message
is also sent before the load is committed and ignored, so the UI process doesn't know it's in accelerated mode.
* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::scheduleRenderingUpdate): Return early if layer tree is frozen. This
ensures that Update messages are not sent to the UI process while layer tree is frozen.
(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode): Disable layer flush on the newly
created LayerTreeHost if layer tree is frozen. This ensures that EnterAcceleratedCompositing message is sent
after the first layer flush once the layer tree is no longer frozen.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (259282 => 259283)
--- trunk/Source/WebKit/ChangeLog 2020-03-31 06:19:49 UTC (rev 259282)
+++ trunk/Source/WebKit/ChangeLog 2020-03-31 09:10:58 UTC (rev 259283)
@@ -1,3 +1,23 @@
+2020-03-31 Carlos Garcia Campos
+
+REGRESSION(r258829): [CoordinatedGraphics] Web view not updated after cross site navigation with PSON enabled
+https://bugs.webkit.org/show_bug.cgi?id=209741
+
+Reviewed by Žan Doberšek.
+
+Since r258829, the drawing area proxy of a provisional page ignores all messages until the load is
+committed. This is causing 2 problems for coordinated graphics drawing area. When not in accelerated compositing
+mode, Update message is sent before the commit is loaded, and the web process keeps waiting for the DidUpdate
+response message forever. When accelerated compositing mode is forced, the EnterAcceleratedCompositing message
+is also sent before the load is committed and ignored, so the UI process doesn't know it's in accelerated mode.
+
+* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+(WebKit::DrawingAreaCoordinatedGraphics::scheduleRenderingUpdate): Return early if layer tree is frozen. This
+ensures that Update messages are not sent to the UI process while layer tree is frozen.
+(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode): Disable layer flush on the newly
+created LayerTreeHost if layer tree is frozen. This ensures that EnterAcceleratedCompositing message is sent
+after the first layer flush once the layer tree is no longer frozen.
+
2020-03-30 David Kilzer
REGRESSION (r251574, r251600): _WKTextManipulationToken and _WKTextManipulationConfiguration are missing -dealloc
Modified: trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (259282 => 259283)
--- trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2020-03-31 06:19:49 UTC (rev 259282)
+++ trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2020-03-31 09:10:58 UTC (rev 259283)
@@ -342,6 +342,9 @@
void DrawingAreaCoordinatedGraphics::scheduleRenderingUpdate()
{
+if (m_layerTreeStateIsFrozen)
+return;
+
if (m_layerTreeHost)
m_layerTreeHost->scheduleLayerFlush();
else
@@ -594,6 +597,8 @@
m_layerTreeHost = nullptr;
return;
#endif
+if (m_layerTreeStateIsFrozen)
+m_layerTreeHost->setLayerFlushSchedulingEnabled(false);
if (m_isPaintingSuspended)
m_layerTreeHost->pauseRendering();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259282] trunk/Source/WebCore
Title: [259282] trunk/Source/WebCore
Revision 259282
Author simon.fra...@apple.com
Date 2020-03-30 23:19:49 -0700 (Mon, 30 Mar 2020)
Log Message
Scroll latching state is not a stack
https://bugs.webkit.org/show_bug.cgi?id=209790
Reviewed by Zalan Bujtas.
No-one ever called Page::popLatchingState(), so the fact that latchingState on Page
was a stack was never important. Just make it a single state.
* page/Page.cpp:
(WebCore::Page::latchingState):
(WebCore::Page::setLatchingState):
(WebCore::Page::resetLatchingState):
(WebCore::Page::removeLatchingStateForTarget):
(WebCore::Page::pushNewLatchingState): Deleted.
(WebCore::Page::popLatchingState): Deleted.
* page/Page.h:
(WebCore::Page::latchingStateStack const): Deleted.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformPrepareForWheelEvents):
* page/scrolling/ScrollLatchingState.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/page/mac/EventHandlerMac.mm
trunk/Source/WebCore/page/scrolling/ScrollLatchingState.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259281 => 259282)
--- trunk/Source/WebCore/ChangeLog 2020-03-31 05:59:07 UTC (rev 259281)
+++ trunk/Source/WebCore/ChangeLog 2020-03-31 06:19:49 UTC (rev 259282)
@@ -1,3 +1,26 @@
+2020-03-30 Simon Fraser
+
+Scroll latching state is not a stack
+https://bugs.webkit.org/show_bug.cgi?id=209790
+
+Reviewed by Zalan Bujtas.
+
+No-one ever called Page::popLatchingState(), so the fact that latchingState on Page
+was a stack was never important. Just make it a single state.
+
+* page/Page.cpp:
+(WebCore::Page::latchingState):
+(WebCore::Page::setLatchingState):
+(WebCore::Page::resetLatchingState):
+(WebCore::Page::removeLatchingStateForTarget):
+(WebCore::Page::pushNewLatchingState): Deleted.
+(WebCore::Page::popLatchingState): Deleted.
+* page/Page.h:
+(WebCore::Page::latchingStateStack const): Deleted.
+* page/mac/EventHandlerMac.mm:
+(WebCore::EventHandler::platformPrepareForWheelEvents):
+* page/scrolling/ScrollLatchingState.h:
+
2020-03-28 Simon Fraser
ScrollLatchingState should use WeakPtr
Modified: trunk/Source/WebCore/page/Page.cpp (259281 => 259282)
--- trunk/Source/WebCore/page/Page.cpp 2020-03-31 05:59:07 UTC (rev 259281)
+++ trunk/Source/WebCore/page/Page.cpp 2020-03-31 06:19:49 UTC (rev 259282)
@@ -2943,41 +2943,26 @@
#if ENABLE(WHEEL_EVENT_LATCHING)
ScrollLatchingState* Page::latchingState()
{
-if (m_latchingState.isEmpty())
-return nullptr;
-
-return _latchingState.last();
+return m_latchingState.get();
}
-void Page::pushNewLatchingState(ScrollLatchingState&& state)
+void Page::setLatchingState(std::unique_ptr&& state)
{
-m_latchingState.append(WTFMove(state));
+m_latchingState = WTFMove(state);
}
void Page::resetLatchingState()
{
-m_latchingState.clear();
+m_latchingState = nullptr;
}
-void Page::popLatchingState()
-{
-m_latchingState.removeLast();
-LOG_WITH_STREAM(ScrollLatching, stream << "Page::popLatchingState() - new state " << m_latchingState);
-}
-
void Page::removeLatchingStateForTarget(Element& targetNode)
{
-if (m_latchingState.isEmpty())
+if (!m_latchingState)
return;
-m_latchingState.removeAllMatching([] (ScrollLatchingState& state) {
-auto* wheelElement = state.wheelEventElement();
-if (!wheelElement)
-return false;
-
-return targetNode.isEqualNode(wheelElement);
-});
-LOG_WITH_STREAM(ScrollLatching, stream << "Page::removeLatchingStateForTarget() - new state " << m_latchingState);
+if (m_latchingState->wheelEventElement() == )
+m_latchingState = nullptr;
}
#endif // ENABLE(WHEEL_EVENT_LATCHING)
Modified: trunk/Source/WebCore/page/Page.h (259281 => 259282)
--- trunk/Source/WebCore/page/Page.h 2020-03-31 05:59:07 UTC (rev 259281)
+++ trunk/Source/WebCore/page/Page.h 2020-03-31 06:19:49 UTC (rev 259282)
@@ -430,9 +430,7 @@
#if ENABLE(WHEEL_EVENT_LATCHING)
ScrollLatchingState* latchingState();
-const Vector& latchingStateStack() const { return m_latchingState; }
-void pushNewLatchingState(ScrollLatchingState&&);
-void popLatchingState();
+void setLatchingState(std::unique_ptr&&);
void resetLatchingState();
void removeLatchingStateForTarget(Element&);
#endif // ENABLE(WHEEL_EVENT_LATCHING)
@@ -980,7 +978,7 @@
std::unique_ptr m_performanceLogging;
#if ENABLE(WHEEL_EVENT_LATCHING)
-Vector m_latchingState;
+std::unique_ptr m_latchingState;
#endif
#if PLATFORM(MAC) && (ENABLE(SERVICE_CONTROLS) || ENABLE(TELEPHONE_NUMBER_DETECTION))
std::unique_ptr m_servicesOverlayController;
Modified: trunk/Source/WebCore/page/mac/EventHandlerMac.mm (259281 => 259282)
--- trunk/Source/WebCore/page/mac/EventHandlerMac.mm
