[webkit-changes] [266102] trunk/Tools
Title: [266102] trunk/Tools
Revision 266102
Author achristen...@apple.com
Date 2020-08-24 22:04:44 -0700 (Mon, 24 Aug 2020)
Log Message
Fix TLSVersion.DefaultBehavior on Mojave
https://bugs.webkit.org/show_bug.cgi?id=215791
* TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
HTTPServer::Protocol::HttpsWithLegacyTLS uses tls_protocol_version_t, so this test times out on Mojave.
Enable it for newer OSes.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm
Diff
Modified: trunk/Tools/ChangeLog (266101 => 266102)
--- trunk/Tools/ChangeLog 2020-08-25 04:32:13 UTC (rev 266101)
+++ trunk/Tools/ChangeLog 2020-08-25 05:04:44 UTC (rev 266102)
@@ -1,5 +1,14 @@
2020-08-24 Alex Christensen
+Fix TLSVersion.DefaultBehavior on Mojave
+https://bugs.webkit.org/show_bug.cgi?id=215791
+
+* TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
+HTTPServer::Protocol::HttpsWithLegacyTLS uses tls_protocol_version_t, so this test times out on Mojave.
+Enable it for newer OSes.
+
+2020-08-24 Alex Christensen
+
Make TLSVersion.DefaultBehavior more robust
https://bugs.webkit.org/show_bug.cgi?id=215791
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm (266101 => 266102)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm 2020-08-25 04:32:13 UTC (rev 266101)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm 2020-08-25 05:04:44 UTC (rev 266102)
@@ -144,7 +144,7 @@
const uint16_t tls1_1 = 0x0302;
static NSString *defaultsKey = @"WebKitEnableLegacyTLS";
-#if HAVE(NETWORK_FRAMEWORK)
+#if HAVE(NETWORK_FRAMEWORK) && HAVE(TLS_PROTOCOL_VERSION_T)
TEST(TLSVersion, DefaultBehavior)
{
@@ -160,7 +160,7 @@
[delegate waitForDidFinishNavigation];
}
-#endif // HAVE(NETWORK_FRAMEWORK)
+#endif // HAVE(NETWORK_FRAMEWORK) && HAVE(TLS_PROTOCOL_VERSION_T)
#if HAVE(TLS_VERSION_DURING_CHALLENGE)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266101] trunk/Source/JavaScriptCore
Title: [266101] trunk/Source/_javascript_Core
Revision 266101
Author keith_mil...@apple.com
Date 2020-08-24 21:32:13 -0700 (Mon, 24 Aug 2020)
Log Message
DFG should always run CFG Simplification after Constant Folding.
https://bugs.webkit.org/show_bug.cgi?id=215286
Reviewed by Robin Morisset.
We didn't do this originally because LICM, many years ago, was
unsound if the CFG didn't have exactly the right shape around
loops. This is no longer true so we don't have to worry about
changing the CFG anymore. While, this doesn't appear to be a
speedup on JetStream 2 CFG, probably because we'd eventually
simplify the graph in B3, CFG Simplification is very cheap and
make other DFG optimizations easier in the future.
Also, remove unecessary validation rule that no exitOKs can come
before any Phi nodes in DFG. This isn't required and fails after
merging two basic blocks where the latter block has a Phi.
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* dfg/DFGValidate.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp
trunk/Source/_javascript_Core/dfg/DFGValidate.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (266100 => 266101)
--- trunk/Source/_javascript_Core/ChangeLog 2020-08-25 03:36:45 UTC (rev 266100)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-08-25 04:32:13 UTC (rev 266101)
@@ -1,5 +1,30 @@
2020-08-24 Keith Miller
+DFG should always run CFG Simplification after Constant Folding.
+https://bugs.webkit.org/show_bug.cgi?id=215286
+
+Reviewed by Robin Morisset.
+
+We didn't do this originally because LICM, many years ago, was
+unsound if the CFG didn't have exactly the right shape around
+loops. This is no longer true so we don't have to worry about
+changing the CFG anymore. While, this doesn't appear to be a
+speedup on JetStream 2 CFG, probably because we'd eventually
+simplify the graph in B3, CFG Simplification is very cheap and
+make other DFG optimizations easier in the future.
+
+Also, remove unecessary validation rule that no exitOKs can come
+before any Phi nodes in DFG. This isn't required and fails after
+merging two basic blocks where the latter block has a Phi.
+
+* dfg/DFGCFGSimplificationPhase.cpp:
+(JSC::DFG::CFGSimplificationPhase::run):
+* dfg/DFGPlan.cpp:
+(JSC::DFG::Plan::compileInThreadImpl):
+* dfg/DFGValidate.cpp:
+
+2020-08-24 Keith Miller
+
Remove MovHintRemoval phase
https://bugs.webkit.org/show_bug.cgi?id=215785
Modified: trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp (266100 => 266101)
--- trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp 2020-08-25 03:36:45 UTC (rev 266100)
+++ trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp 2020-08-25 04:32:13 UTC (rev 266101)
@@ -49,9 +49,6 @@
bool run()
{
-// FIXME: We should make this work in SSA. https://bugs.webkit.org/show_bug.cgi?id=148260
-DFG_ASSERT(m_graph, nullptr, m_graph.m_form != SSA);
-
const bool extremeLogging = false;
bool outerChanged = false;
Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (266100 => 266101)
--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp 2020-08-25 03:36:45 UTC (rev 266100)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp 2020-08-25 04:32:13 UTC (rev 266101)
@@ -364,6 +364,7 @@
if (changed) {
RUN_PHASE(performCFA);
RUN_PHASE(performConstantFolding);
+RUN_PHASE(performCFGSimplification);
}
// If we're doing validation, then run some analyses, to give them an opportunity
@@ -429,6 +430,7 @@
RUN_PHASE(performLivenessAnalysis);
RUN_PHASE(performCFA);
RUN_PHASE(performConstantFolding);
+RUN_PHASE(performCFGSimplification);
RUN_PHASE(performCleanUp); // Reduce the graph size a lot.
changed = false;
RUN_PHASE(performStrengthReduction);
@@ -444,6 +446,7 @@
RUN_PHASE(performLivenessAnalysis);
RUN_PHASE(performCFA);
RUN_PHASE(performConstantFolding);
+RUN_PHASE(performCFGSimplification);
}
// Currently, this relies on pre-headers still being valid. That precludes running CFG
Modified: trunk/Source/_javascript_Core/dfg/DFGValidate.cpp (266100 => 266101)
--- trunk/Source/_javascript_Core/dfg/DFGValidate.cpp 2020-08-25 03:36:45 UTC (rev 266100)
+++ trunk/Source/_javascript_Core/dfg/DFGValidate.cpp 2020-08-25 04:32:13 UTC (rev 266101)
@@ -830,22 +830,16 @@
for (BasicBlock* block : m_graph.blocksInNaturalOrder()) {
VALIDATE((block), block->phis.isEmpty());
-bool
[webkit-changes] [266100] trunk/Tools
Title: [266100] trunk/Tools
Revision 266100
Author commit-qu...@webkit.org
Date 2020-08-24 20:36:45 -0700 (Mon, 24 Aug 2020)
Log Message
Make TLSVersion.DefaultBehavior more robust
https://bugs.webkit.org/show_bug.cgi?id=215791
Patch by Alex Christensen on 2020-08-24
Reviewed by Darin Adler.
After r265573 sometimes it would assert, which is not a problem because it was failing the first connection
then succeeding the second connection as intended and as happens in the real internet.
Use HTTPServer which accepts a variable number of connections to keep the test coverage.
* TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/cocoa/HTTPServer.h:
* TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
(TestWebKitAPI::HTTPServer::respondWithOK):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.h
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm
Diff
Modified: trunk/Tools/ChangeLog (266099 => 266100)
--- trunk/Tools/ChangeLog 2020-08-25 02:44:39 UTC (rev 266099)
+++ trunk/Tools/ChangeLog 2020-08-25 03:36:45 UTC (rev 266100)
@@ -1,3 +1,21 @@
+2020-08-24 Alex Christensen
+
+Make TLSVersion.DefaultBehavior more robust
+https://bugs.webkit.org/show_bug.cgi?id=215791
+
+Reviewed by Darin Adler.
+
+After r265573 sometimes it would assert, which is not a problem because it was failing the first connection
+then succeeding the second connection as intended and as happens in the real internet.
+Use HTTPServer which accepts a variable number of connections to keep the test coverage.
+
+* TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/cocoa/HTTPServer.h:
+* TestWebKitAPI/cocoa/HTTPServer.mm:
+(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
+(TestWebKitAPI::HTTPServer::respondWithOK):
+
2020-08-24 Wenson Hsieh
Unreviewed, fix the internal iOS 13.4 build
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm (266099 => 266100)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm 2020-08-25 02:44:39 UTC (rev 266099)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm 2020-08-25 03:36:45 UTC (rev 266100)
@@ -144,9 +144,11 @@
const uint16_t tls1_1 = 0x0302;
static NSString *defaultsKey = @"WebKitEnableLegacyTLS";
+#if HAVE(NETWORK_FRAMEWORK)
+
TEST(TLSVersion, DefaultBehavior)
{
-TCPServer server(TCPServer::Protocol::HTTPS, TCPServer::respondWithOK, tls1_1);
+HTTPServer server(HTTPServer::respondWithOK, HTTPServer::Protocol::HttpsWithLegacyTLS);
auto delegate = adoptNS([TestNavigationDelegate new]);
auto webView = adoptNS([WKWebView new]);
[webView setNavigationDelegate:delegate.get()];
@@ -158,6 +160,8 @@
[delegate waitForDidFinishNavigation];
}
+#endif // HAVE(NETWORK_FRAMEWORK)
+
#if HAVE(TLS_VERSION_DURING_CHALLENGE)
TEST(TLSVersion, NetworkSession)
Modified: trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.h (266099 => 266100)
--- trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.h 2020-08-25 02:44:39 UTC (rev 266099)
+++ trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.h 2020-08-25 03:36:45 UTC (rev 266100)
@@ -54,8 +54,9 @@
size_t totalRequests() const;
void cancel();
+static void respondWithOK(Connection);
static void respondWithChallengeThenOK(Connection);
-
+
private:
static RetainPtr listenerParameters(Protocol, CertificateVerifier&&, RetainPtr&&, Optional port);
static void respondToRequests(Connection, Ref);
Modified: trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm (266099 => 266100)
--- trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm 2020-08-25 02:44:39 UTC (rev 266099)
+++ trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm 2020-08-25 03:36:45 UTC (rev 266100)
@@ -150,17 +150,22 @@
"Content-Length: 0\r\n"
"WWW-Authenticate: Basic realm=\"testrealm\"\r\n\r\n";
connection.send(challengeHeader, [connection] {
-connection.receiveHTTPRequest([connection] (Vector&&) {
-connection.send(
-"HTTP/1.1 200 OK\r\n"
-"Content-Length: 13\r\n\r\n"
-"Hello, World!"
-);
-});
+respondWithOK(connection);
});
});
}
+void HTTPServer::respondWithOK(Connection connection)
+{
+connection.receiveHTTPRequest([connection] (Vector&&) {
+connection.send(
+"HTTP/1.1 200 OK\r\n"
+"Content-Length: 13\r\n\r\n"
+"Hello, World!"
+);
+});
+}
+
size_t HTTPServer::totalRequests() const
{
return m_requestData->requestCount;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [266099] trunk/Source/WebKit
Title: [266099] trunk/Source/WebKit
Revision 266099
Author beid...@apple.com
Date 2020-08-24 19:44:39 -0700 (Mon, 24 Aug 2020)
Log Message
CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
and https://bugs.webkit.org/show_bug.cgi?id=215787
Reviewed by Tim Horton.
To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.
This is a speculative fix due to the aforementioned reproducibility issue.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called,
instead of when deciding to dispatch to the main thread.
(WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch
to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread.
(WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when
(WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is
safe to do after destroy(), up until the very end when we get into pluginView() derefencing.
So it seems prudent to add another check here.
(WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and
adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument,
so for added coverage it seems like a prudent place to add the check.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (266098 => 266099)
--- trunk/Source/WebKit/ChangeLog 2020-08-25 02:03:51 UTC (rev 266098)
+++ trunk/Source/WebKit/ChangeLog 2020-08-25 02:44:39 UTC (rev 266099)
@@ -1,3 +1,30 @@
+2020-08-24 Brady Eidson
+
+CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
+ and https://bugs.webkit.org/show_bug.cgi?id=215787
+
+Reviewed by Tim Horton.
+
+To quote Tim from r264945:
+No new tests; timing is such that I can't reproduce without inserting
+intentional delays into the main thread hops, which is further than
+I'm willing to go for a test.
+
+This is a speculative fix due to the aforementioned reproducibility issue.
+
+* WebProcess/Plugins/PDF/PDFPlugin.mm:
+(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called,
+ instead of when deciding to dispatch to the main thread.
+(WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch
+ to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread.
+(WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when
+(WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is
+ safe to do after destroy(), up until the very end when we get into pluginView() derefencing.
+ So it seems prudent to add another check here.
+(WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and
+ adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument,
+ so for added coverage it seems like a prudent place to add the check.
+
2020-08-24 Wenson Hsieh
Unreviewed, fix the internal iOS 13.4 build
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (266098 => 266099)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2020-08-25 02:03:51 UTC (rev 266098)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2020-08-25 02:44:39 UTC (rev 266099)
@@ -705,13 +705,14 @@
{
m_incrementalPDFLoadingEnabled = false;
+if (m_hasBeenDestroyed)
+return;
+
if (!isMainThread()) {
#if !LOG_DISABLED
pdfLog("Disabling incremental PDF loading on background thread");
#endif
callOnMainThread([this, protectedThis = makeRef(*this)] {
-if (m_hasBeenDestroyed)
-return;
receivedNonLinearizedPDFSentinel();
});
return;
@@ -890,8 +891,6 @@
[m_backgroundThreadDocument preloadDataOfPagesInRange:NSMakeRange(0, 1) onQueue:firstPageQueue->dispatchQueue() completion:[, this] (NSIndexSet *) mutable {
if (m_incrementalPDFLoadingEnabled) {
callOnMainThread([this] {
-if (m_hasBeenDestroyed)
-return;
adoptBackgroundThreadDocument();
});
} else
@@ -986,6 +985,9 @@
void
[webkit-changes] [266098] trunk/LayoutTests/imported/w3c
Title: [266098] trunk/LayoutTests/imported/w3c
Revision 266098
Author achristen...@apple.com
Date 2020-08-24 19:03:51 -0700 (Mon, 24 Aug 2020)
Log Message
Update iOS layout test results after r266087
https://bugs.webkit.org/show_bug.cgi?id=215671
* web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt:
Apparently there's a newly passing test here, too.
I wonder why macOS isn't affected by this change.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266097 => 266098)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-25 02:00:07 UTC (rev 266097)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-25 02:03:51 UTC (rev 266098)
@@ -1,5 +1,14 @@
2020-08-24 Alex Christensen
+Update iOS layout test results after r266087
+https://bugs.webkit.org/show_bug.cgi?id=215671
+
+* web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt:
+Apparently there's a newly passing test here, too.
+I wonder why macOS isn't affected by this change.
+
+2020-08-24 Alex Christensen
+
Implement Request/Response consuming as FormData
https://bugs.webkit.org/show_bug.cgi?id=215671
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt (266097 => 266098)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt 2020-08-25 02:00:07 UTC (rev 266097)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt 2020-08-25 02:03:51 UTC (rev 266098)
@@ -2,9 +2,7 @@
PASS Fetching a resource with bad gzip content should still resolve
PASS Consuming the body of a resource with bad gzip content with arrayBuffer() should reject
PASS Consuming the body of a resource with bad gzip content with blob() should reject
-FAIL Consuming the body of a resource with bad gzip content with formData() should reject promise_rejects_js: function "function () { throw e }" threw object "NotSupportedError: The operation is not supported." ("NotSupportedError") expected instance of function "function TypeError() {
-[native code]
-}" ("TypeError")
+PASS Consuming the body of a resource with bad gzip content with formData() should reject
PASS Consuming the body of a resource with bad gzip content with json() should reject
PASS Consuming the body of a resource with bad gzip content with text() should reject
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266097] trunk/LayoutTests
Title: [266097] trunk/LayoutTests Revision 266097 Author mmaxfi...@apple.com Date 2020-08-24 19:00:07 -0700 (Mon, 24 Aug 2020) Log Message [macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing Unreviewed test gardening. platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords. Modified Paths trunk/LayoutTests/ChangeLog Property Changed trunk/LayoutTests/platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (266096 => 266097) --- trunk/LayoutTests/ChangeLog 2020-08-25 01:53:51 UTC (rev 266096) +++ trunk/LayoutTests/ChangeLog 2020-08-25 02:00:07 UTC (rev 266097) @@ -7,6 +7,15 @@ * platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords. +2020-08-24 Myles C. Maxfield + +[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing + + +Unreviewed test gardening. + +* platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords. + 2020-08-24 Hector Lopez [ macOS ] Tests expectations changed as test passing but expected to fail Index: trunk/LayoutTests/platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt === --- trunk/LayoutTests/platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt 2020-08-25 01:53:51 UTC (rev 266096) +++ trunk/LayoutTests/platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt 2020-08-25 02:00:07 UTC (rev 266097) Property changes: trunk/LayoutTests/platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt Deleted: svn:keywords -Author Date Id Rev URL \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266096] trunk/LayoutTests/ChangeLog
Title: [266096] trunk/LayoutTests/ChangeLog Revision 266096 Author mmaxfi...@apple.com Date 2020-08-24 18:53:51 -0700 (Mon, 24 Aug 2020) Log Message [macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing Unreviewed test gardening. * platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords. Modified Paths trunk/LayoutTests/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (266095 => 266096) --- trunk/LayoutTests/ChangeLog 2020-08-25 01:51:15 UTC (rev 266095) +++ trunk/LayoutTests/ChangeLog 2020-08-25 01:53:51 UTC (rev 266096) @@ -1,3 +1,12 @@ +2020-08-24 Myles C. Maxfield + +[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing + + +Unreviewed test gardening. + +* platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords. + 2020-08-24 Hector Lopez [ macOS ] Tests expectations changed as test passing but expected to fail ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266095] trunk/Source/JavaScriptCore
Title: [266095] trunk/Source/_javascript_Core Revision 266095 Author keith_mil...@apple.com Date 2020-08-24 18:51:15 -0700 (Mon, 24 Aug 2020) Log Message Remove MovHintRemoval phase https://bugs.webkit.org/show_bug.cgi?id=215785 Reviewed by Saam Barati. The MovHintRemoval phase doesn't play nicely with our OSR Availability. Specifically, it needs to do a tricky dance where it marks all the live ranges of the ZombieHints as not exitOK. There's also an issue because we treated unused locals as kill in this block, which is wrong for SSA when a MovHint is used in another block. Since removing MovHintRemoval isn't a performance regression, we are removing it rather than fixing bugs related to it. Relatedly, since the only place we produce ZombieHints is MovHintRemoval this patch also removes that node type. * Sources.txt: * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * dfg/DFGClobberize.h: (JSC::DFG::clobberize): * dfg/DFGClobbersExitState.cpp: (JSC::DFG::clobbersExitState): * dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * dfg/DFGMayExit.cpp: * dfg/DFGMovHintRemovalPhase.cpp: Removed. * dfg/DFGMovHintRemovalPhase.h: Removed. * dfg/DFGNode.h: (JSC::DFG::Node::containsMovHint): (JSC::DFG::Node::hasUnlinkedOperand): * dfg/DFGNodeType.h: * dfg/DFGOSRAvailabilityAnalysisPhase.cpp: (JSC::DFG::LocalOSRAvailabilityCalculator::executeNode): * dfg/DFGPhantomInsertionPhase.cpp: * dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl): * dfg/DFGPredictionPropagationPhase.cpp: * dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileMovHint): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGVarargsForwardingPhase.cpp: * ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::validateAIState): (JSC::FTL::DFG::LowerDFGToB3::compileNode): * runtime/OptionsList.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Sources.txt trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h trunk/Source/_javascript_Core/dfg/DFGClobberize.h trunk/Source/_javascript_Core/dfg/DFGClobbersExitState.cpp trunk/Source/_javascript_Core/dfg/DFGDoesGC.cpp trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp trunk/Source/_javascript_Core/dfg/DFGMayExit.cpp trunk/Source/_javascript_Core/dfg/DFGNode.h trunk/Source/_javascript_Core/dfg/DFGNodeType.h trunk/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp trunk/Source/_javascript_Core/dfg/DFGPhantomInsertionPhase.cpp trunk/Source/_javascript_Core/dfg/DFGPlan.cpp trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/dfg/DFGVarargsForwardingPhase.cpp trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp trunk/Source/_javascript_Core/runtime/OptionsList.h Removed Paths trunk/Source/_javascript_Core/dfg/DFGMovHintRemovalPhase.cpp trunk/Source/_javascript_Core/dfg/DFGMovHintRemovalPhase.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (266094 => 266095) --- trunk/Source/_javascript_Core/ChangeLog 2020-08-25 00:36:10 UTC (rev 266094) +++ trunk/Source/_javascript_Core/ChangeLog 2020-08-25 01:51:15 UTC (rev 266095) @@ -1,3 +1,61 @@ +2020-08-24 Keith Miller + +Remove MovHintRemoval phase +https://bugs.webkit.org/show_bug.cgi?id=215785 + +Reviewed by Saam Barati. + +The MovHintRemoval phase doesn't play nicely with our OSR +Availability. Specifically, it needs to do a tricky dance where it +marks all the live ranges of the ZombieHints as not +exitOK. There's also an issue because we treated unused locals as +kill in this block, which is wrong for SSA when a MovHint is +used in another block. Since removing MovHintRemoval isn't a +performance regression, we are removing it rather than fixing bugs +related to it. Relatedly, since the only place we produce +ZombieHints is MovHintRemoval this patch also removes that node +type. + +* Sources.txt: +* dfg/DFGAbstractInterpreterInlines.h: +(JSC::DFG::AbstractInterpreter::executeEffects): +* dfg/DFGClobberize.h: +(JSC::DFG::clobberize): +* dfg/DFGClobbersExitState.cpp: +(JSC::DFG::clobbersExitState): +* dfg/DFGDoesGC.cpp: +(JSC::DFG::doesGC): +* dfg/DFGFixupPhase.cpp: +(JSC::DFG::FixupPhase::fixupNode): +* dfg/DFGMayExit.cpp: +*
[webkit-changes] [266094] trunk/LayoutTests
Title: [266094] trunk/LayoutTests Revision 266094 Author hector_i_lo...@apple.com Date 2020-08-24 17:36:10 -0700 (Mon, 24 Aug 2020) Log Message [ macOS ] Tests expectations changed as test passing but expected to fail https://bugs.webkit.org/show_bug.cgi?id=215786 Unreviewed test gardening. * TestExpectations: * platform/ios-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266093 => 266094) --- trunk/LayoutTests/ChangeLog 2020-08-25 00:26:09 UTC (rev 266093) +++ trunk/LayoutTests/ChangeLog 2020-08-25 00:36:10 UTC (rev 266094) @@ -1,3 +1,15 @@ +2020-08-24 Hector Lopez + +[ macOS ] Tests expectations changed as test passing but expected to fail +https://bugs.webkit.org/show_bug.cgi?id=215786 + +Unreviewed test gardening. + +* TestExpectations: +* platform/ios-wk2/TestExpectations: +* platform/mac-wk2/TestExpectations: +* platform/mac/TestExpectations: + 2020-08-24 Karl Rackler rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure) Modified: trunk/LayoutTests/TestExpectations (266093 => 266094) --- trunk/LayoutTests/TestExpectations 2020-08-25 00:26:09 UTC (rev 266093) +++ trunk/LayoutTests/TestExpectations 2020-08-25 00:36:10 UTC (rev 266094) @@ -1192,8 +1192,6 @@ imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html [ Pass Failure ] imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-013.html [ Pass Failure ] imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html [ Pass Failure ] -webkit.org/b/191367 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002.html [ ImageOnlyFailure ] -webkit.org/b/209461 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001.html [ Failure ] webkit.org/b/209461 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-003.html [ ImageOnlyFailure ] webkit.org/b/209461 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-004.html [ ImageOnlyFailure ] webkit.org/b/209461 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-005.html [ ImageOnlyFailure ] @@ -2020,7 +2018,6 @@ imported/w3c/web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-001.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-content/quotes-005.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-006.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-007.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-012.html [ ImageOnlyFailure ] @@ -2027,14 +2024,11 @@ imported/w3c/web-platform-tests/css/css-content/quotes-013.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-014.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-017.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-content/quotes-018.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-019.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-020.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-021.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-022.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-023.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-content/quotes-025.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-content/quotes-027.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-content/quotes-033.html [ ImageOnlyFailure ] # Need to re-import canvas tests @@ -3900,7 +3894,6 @@ webkit.org/b/136754 imported/w3c/web-platform-tests/css/css-flexbox/flexbox_stf-table-singleline-2.html [ ImageOnlyFailure ] webkit.org/b/145176 imported/w3c/web-platform-tests/css/css-flexbox/flexbox_align-items-stretch-3.html [ ImageOnlyFailure ] -webkit.org/b/169007 imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict.html [ Failure ] webkit.org/b/206767 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-gap-position-absolute.html [ ImageOnlyFailure ] webkit.org/b/206767
[webkit-changes] [266093] branches/safari-610.1.28.0-branch/Source
Title: [266093] branches/safari-610.1.28.0-branch/Source Revision 266093 Author alanc...@apple.com Date 2020-08-24 17:26:09 -0700 (Mon, 24 Aug 2020) Log Message Versioning. WebKit-7610.1.28.0.3 Modified Paths branches/safari-610.1.28.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-610.1.28.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-610.1.28.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-610.1.28.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-610.1.28.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-610.1.28.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-610.1.28.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-610.1.28.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-610.1.28.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (266092 => 266093) --- branches/safari-610.1.28.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-08-25 00:14:28 UTC (rev 266092) +++ branches/safari-610.1.28.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-08-25 00:26:09 UTC (rev 266093) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 28; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.28.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (266092 => 266093) --- branches/safari-610.1.28.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-08-25 00:14:28 UTC (rev 266092) +++ branches/safari-610.1.28.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-08-25 00:26:09 UTC (rev 266093) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 28; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.28.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (266092 => 266093) --- branches/safari-610.1.28.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-08-25 00:14:28 UTC (rev 266092) +++ branches/safari-610.1.28.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-08-25 00:26:09 UTC (rev 266093) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 28; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.28.0-branch/Source/WebCore/Configurations/Version.xcconfig (266092 => 266093) --- branches/safari-610.1.28.0-branch/Source/WebCore/Configurations/Version.xcconfig 2020-08-25 00:14:28 UTC (rev 266092) +++ branches/safari-610.1.28.0-branch/Source/WebCore/Configurations/Version.xcconfig 2020-08-25 00:26:09 UTC (rev 266093) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 28; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.28.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (266092 => 266093) --- branches/safari-610.1.28.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-08-25 00:14:28 UTC (rev 266092) +++ branches/safari-610.1.28.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-08-25 00:26:09 UTC (rev 266093) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 28; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.28.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (266092 => 266093) --- branches/safari-610.1.28.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-08-25 00:14:28 UTC (rev 266092) +++ branches/safari-610.1.28.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-08-25 00:26:09 UTC (rev 266093) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 28; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION =
[webkit-changes] [266092] trunk/LayoutTests
Title: [266092] trunk/LayoutTests Revision 266092 Author rack...@apple.com Date 2020-08-24 17:14:28 -0700 (Mon, 24 Aug 2020) Log Message rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure) Unreviewed test gardening. * platform/ios-13/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-13/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266091 => 266092) --- trunk/LayoutTests/ChangeLog 2020-08-25 00:05:58 UTC (rev 266091) +++ trunk/LayoutTests/ChangeLog 2020-08-25 00:14:28 UTC (rev 266092) @@ -1,3 +1,11 @@ +2020-08-24 Karl Rackler + +rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure) + +Unreviewed test gardening. + +* platform/ios-13/TestExpectations: + 2020-08-24 Hector Lopez [ iOS wk2 Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-fetch-error-external-module.html is a flaky failure Modified: trunk/LayoutTests/platform/ios-13/TestExpectations (266091 => 266092) --- trunk/LayoutTests/platform/ios-13/TestExpectations 2020-08-25 00:05:58 UTC (rev 266091) +++ trunk/LayoutTests/platform/ios-13/TestExpectations 2020-08-25 00:14:28 UTC (rev 266092) @@ -10,3 +10,6 @@ http/tests/resourceLoadStatistics/cname-cloaking-top-no-cname-sub-1p-cname.html [ Skip ] http/tests/resourceLoadStatistics/cname-cloaking-top-no-cname-sub-3p-cname.html [ Skip ] http/tests/resourceLoadStatistics/cname-cloaking-top-no-cname-sub-no-cname.html [ Skip ] + +# rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure) +imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266091] trunk/JSTests
Title: [266091] trunk/JSTests Revision 266091 Author keith_mil...@apple.com Date 2020-08-24 17:05:58 -0700 (Mon, 24 Aug 2020) Log Message Update test262 (mid Aug 2020 edition) https://bugs.webkit.org/show_bug.cgi?id=215784 Rubber-stamped by Saam Barati and Yusuke Suzuki. * test262/expectations.yaml: * test262/latest-changes-summary.txt: * test262/test/built-ins/String/prototype/split/limit-touint32-error.js: Added. (ExpectedError): (ExpectedError.prototype.toString): (nonStringableSeparator.Symbol.toPrimitive): (nonStringableSeparator.toString): (nonStringableSeparator.valueOf): (nonNumberableLimit.Symbol.toPrimitive): * test262/test/built-ins/String/prototype/split/separator-tostring-error.js: Added. (ExpectedError): (ExpectedError.prototype.toString): (nonStringableSeparator.toString): * test262/test/built-ins/String/prototype/split/separator-undef-limit-zero.js: * test262/test/built-ins/String/prototype/split/this-value-tostring-error.js: Added. (ExpectedError): (ExpectedError.prototype.toString): (nonStringableReceiver.toString): (splitter.Symbol.split): (catch): (nonStringableSeparator.Symbol.toPrimitive): (nonStringableSeparator.toString): (nonStringableSeparator.valueOf): * test262/test/language/module-code/export-default-asyncfunction-declaration-binding-exists.js: Added. (A): (export.default.async A): * test262/test/language/module-code/export-default-asyncfunction-declaration-binding.js: Added. (export.default.async A): * test262/test/language/module-code/export-default-asyncgenerator-declaration-binding-exists.js: Added. (AG): (export.default.async AG): * test262/test/language/module-code/export-default-asyncgenerator-declaration-binding.js: Added. (export.default.async AG): * test262/test/language/module-code/export-default-function-declaration-binding-exists.js: Added. (F): (export.default.F): * test262/test/language/module-code/export-default-function-declaration-binding.js: Added. (export.default.F): * test262/test/language/module-code/export-default-generator-declaration-binding-exists.js: Added. (G): (export.default.G): * test262/test/language/module-code/export-default-generator-declaration-binding.js: Added. (export.default.G): * test262/test262-Revision.txt: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262/expectations.yaml trunk/JSTests/test262/latest-changes-summary.txt trunk/JSTests/test262/test/built-ins/String/prototype/split/separator-undef-limit-zero.js trunk/JSTests/test262/test262-Revision.txt Added Paths trunk/JSTests/test262/test/built-ins/String/prototype/split/limit-touint32-error.js trunk/JSTests/test262/test/built-ins/String/prototype/split/separator-tostring-error.js trunk/JSTests/test262/test/built-ins/String/prototype/split/this-value-tostring-error.js trunk/JSTests/test262/test/language/module-code/export-default-asyncfunction-declaration-binding-exists.js trunk/JSTests/test262/test/language/module-code/export-default-asyncfunction-declaration-binding.js trunk/JSTests/test262/test/language/module-code/export-default-asyncgenerator-declaration-binding-exists.js trunk/JSTests/test262/test/language/module-code/export-default-asyncgenerator-declaration-binding.js trunk/JSTests/test262/test/language/module-code/export-default-function-declaration-binding-exists.js trunk/JSTests/test262/test/language/module-code/export-default-function-declaration-binding.js trunk/JSTests/test262/test/language/module-code/export-default-generator-declaration-binding-exists.js trunk/JSTests/test262/test/language/module-code/export-default-generator-declaration-binding.js Diff Modified: trunk/JSTests/ChangeLog (266090 => 266091) --- trunk/JSTests/ChangeLog 2020-08-24 22:48:19 UTC (rev 266090) +++ trunk/JSTests/ChangeLog 2020-08-25 00:05:58 UTC (rev 266091) @@ -1,3 +1,55 @@ +2020-08-24 Keith Miller + +Update test262 (mid Aug 2020 edition) +https://bugs.webkit.org/show_bug.cgi?id=215784 + +Rubber-stamped by Saam Barati and Yusuke Suzuki. + +* test262/expectations.yaml: +* test262/latest-changes-summary.txt: +* test262/test/built-ins/String/prototype/split/limit-touint32-error.js: Added. +(ExpectedError): +(ExpectedError.prototype.toString): +(nonStringableSeparator.Symbol.toPrimitive): +(nonStringableSeparator.toString): +(nonStringableSeparator.valueOf): +(nonNumberableLimit.Symbol.toPrimitive): +* test262/test/built-ins/String/prototype/split/separator-tostring-error.js: Added. +(ExpectedError): +(ExpectedError.prototype.toString): +(nonStringableSeparator.toString): +* test262/test/built-ins/String/prototype/split/separator-undef-limit-zero.js: +* test262/test/built-ins/String/prototype/split/this-value-tostring-error.js: Added. +(ExpectedError): +(ExpectedError.prototype.toString): +(nonStringableReceiver.toString): +(splitter.Symbol.split): +(catch): +
[webkit-changes] [266090] trunk
Title: [266090] trunk
Revision 266090
Author wenson_hs...@apple.com
Date 2020-08-24 15:48:19 -0700 (Mon, 24 Aug 2020)
Log Message
Unreviewed, fix the internal iOS 13.4 build
Source/WebKit:
The -_selectionClipRect SPI method isn't declared in any private headers on iOS 13.4 and prior. This isn't a
problem when building with a non-internal SDK since the SPI is declared in the `!USE(APPLE_INTERNAL_SDK)`
section in `UIKitSPI.h`, but on internal builds of iOS 13.4, this declaration is absent from both the internal
SDK and `UIKitSPI.h`.
To fix the build, simply declare it in the IPI section — once we stop supporting iOS 13.4 as a build target,
this can be moved back into the non-internal section only.
* Platform/spi/ios/UIKitSPI.h:
Tools:
See Source/WebKit/ChangeLog.
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::clipSelectionViewRectToContentView):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (266089 => 266090)
--- trunk/Source/WebKit/ChangeLog 2020-08-24 22:46:50 UTC (rev 266089)
+++ trunk/Source/WebKit/ChangeLog 2020-08-24 22:48:19 UTC (rev 266090)
@@ -1,3 +1,17 @@
+2020-08-24 Wenson Hsieh
+
+Unreviewed, fix the internal iOS 13.4 build
+
+The -_selectionClipRect SPI method isn't declared in any private headers on iOS 13.4 and prior. This isn't a
+problem when building with a non-internal SDK since the SPI is declared in the `!USE(APPLE_INTERNAL_SDK)`
+section in `UIKitSPI.h`, but on internal builds of iOS 13.4, this declaration is absent from both the internal
+SDK and `UIKitSPI.h`.
+
+To fix the build, simply declare it in the IPI section — once we stop supporting iOS 13.4 as a build target,
+this can be moved back into the non-internal section only.
+
+* Platform/spi/ios/UIKitSPI.h:
+
2020-08-24 Alex Christensen
Implement Request/Response consuming as FormData
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (266089 => 266090)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2020-08-24 22:46:50 UTC (rev 266089)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2020-08-24 22:48:19 UTC (rev 266090)
@@ -487,7 +487,6 @@
- (void)modifierFlagsDidChangeFrom:(UIKeyModifierFlags)oldFlags to:(UIKeyModifierFlags)newFlags;
#endif
@property (nonatomic) UITextGranularity selectionGranularity;
-@property (nonatomic, readonly) CGRect _selectionClipRect;
@required
- (BOOL)hasContent;
- (BOOL)hasSelection;
@@ -1374,6 +1373,11 @@
@end
#endif
+@protocol UITextInputInternal
+@optional
+@property (nonatomic, readonly) CGRect _selectionClipRect;
+@end
+
@interface UIDevice ()
@property (nonatomic, setter=_setBacklightLevel:) float _backlightLevel;
@end
Modified: trunk/Tools/ChangeLog (266089 => 266090)
--- trunk/Tools/ChangeLog 2020-08-24 22:46:50 UTC (rev 266089)
+++ trunk/Tools/ChangeLog 2020-08-24 22:48:19 UTC (rev 266090)
@@ -1,3 +1,12 @@
+2020-08-24 Wenson Hsieh
+
+Unreviewed, fix the internal iOS 13.4 build
+
+See Source/WebKit/ChangeLog.
+
+* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+(WTR::clipSelectionViewRectToContentView):
+
2020-08-24 Aakash Jain
[ews] enable email notifications to patch authors for build or layout test failures on their patch
Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm (266089 => 266090)
--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2020-08-24 22:46:50 UTC (rev 266089)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2020-08-24 22:48:19 UTC (rev 266090)
@@ -793,9 +793,9 @@
static void clipSelectionViewRectToContentView(CGRect& rect, UIView *contentView)
{
rect = CGRectIntersection(contentView.bounds, rect);
-// The content view (a WKContentView in WebKit) is expected to implement the optional UITextInputPrivate method -_selectionClipRect.
+// The content view (a WKContentView in WebKit) is expected to implement the optional text input method -_selectionClipRect.
ASSERT([contentView respondsToSelector:@selector(_selectionClipRect)]);
-auto selectionClipRect = [(UIView *)contentView _selectionClipRect];
+auto selectionClipRect = [(UIView *)contentView _selectionClipRect];
if (!CGRectIsNull(selectionClipRect))
rect = CGRectIntersection(selectionClipRect, rect);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266089] trunk/Tools
Title: [266089] trunk/Tools
Revision 266089
Author aakash_j...@apple.com
Date 2020-08-24 15:46:50 -0700 (Mon, 24 Aug 2020)
Log Message
[ews] enable email notifications to patch authors for build or layout test failures on their patch
https://bugs.webkit.org/show_bug.cgi?id=215776
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.analyzeResults): Send email notification to patch authors for build failure due to their patch.
(AnalyzeLayoutTestsResults.report_failure): Send email notification to patch authors for layout test failure.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (266088 => 266089)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-08-24 22:45:09 UTC (rev 266088)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-08-24 22:46:50 UTC (rev 266089)
@@ -1419,6 +1419,8 @@
self.build.results = FAILURE
patch_id = self.getProperty('patch_id', '')
message = 'Patch {} does not build'.format(patch_id)
+self.send_email_for_new_build_failure()
+
self.descriptionDone = message
if self.getProperty('buildername', '').lower() == 'commit-queue':
self.setProperty('bugzilla_comment_text', message)
@@ -2071,6 +2073,7 @@
if len(new_failures) > self.NUM_FAILURES_TO_DISPLAY:
message += ' ...'
self.descriptionDone = message
+self.send_email_for_new_test_failures(new_failures)
if self.getProperty('buildername', '').lower() == 'commit-queue':
self.setProperty('bugzilla_comment_text', message)
Modified: trunk/Tools/ChangeLog (266088 => 266089)
--- trunk/Tools/ChangeLog 2020-08-24 22:45:09 UTC (rev 266088)
+++ trunk/Tools/ChangeLog 2020-08-24 22:46:50 UTC (rev 266089)
@@ -1,5 +1,16 @@
2020-08-24 Aakash Jain
+[ews] enable email notifications to patch authors for build or layout test failures on their patch
+https://bugs.webkit.org/show_bug.cgi?id=215776
+
+Reviewed by Jonathan Bedard.
+
+* BuildSlaveSupport/ews-build/steps.py:
+(AnalyzeCompileWebKitResults.analyzeResults): Send email notification to patch authors for build failure due to their patch.
+(AnalyzeLayoutTestsResults.report_failure): Send email notification to patch authors for layout test failure.
+
+2020-08-24 Aakash Jain
+
[ews] set references header in email so as to group similar emails together
https://bugs.webkit.org/show_bug.cgi?id=215777
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266088] trunk/Tools
Title: [266088] trunk/Tools
Revision 266088
Author aakash_j...@apple.com
Date 2020-08-24 15:45:09 -0700 (Mon, 24 Aug 2020)
Log Message
[ews] set references header in email so as to group similar emails together
https://bugs.webkit.org/show_bug.cgi?id=215777
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/send_email.py:
(send_email): Add support for setting references header.
(send_email_to_patch_author):
(send_email_to_bot_watchers):
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Set references header appropriately.
(ReRunWebKitTests.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-build/send_email.py
trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/send_email.py (266087 => 266088)
--- trunk/Tools/BuildSlaveSupport/ews-build/send_email.py 2020-08-24 22:36:02 UTC (rev 266087)
+++ trunk/Tools/BuildSlaveSupport/ews-build/send_email.py 2020-08-24 22:45:09 UTC (rev 266088)
@@ -42,7 +42,7 @@
return []
-def send_email(to_emails, subject, text):
+def send_email(to_emails, subject, text, reference=''):
if is_test_mode_enabled:
return
if not to_emails:
@@ -59,6 +59,9 @@
msg['From'] = FROM_EMAIL
msg['To'] = ', '.join(to_emails)
msg['Subject'] = subject
+msg.add_header('reply-to', 'aakash_j...@apple.com')
+if reference:
+msg.add_header('references', '{}@webkit.org'.format(reference))
server = smtplib.SMTP(SERVER)
server.sendmail(FROM_EMAIL, to_emails, msg.as_string())
@@ -65,14 +68,14 @@
server.quit()
-def send_email_to_patch_author(author_email, subject, text):
+def send_email_to_patch_author(author_email, subject, text, reference=''):
if not author_email:
return
if author_email in get_email_ids('EMAIL_IDS_TO_UNSUBSCRIBE'):
print('email {} is in unsubscribe list, skipping email'.format(author_email))
return
-send_email([author_email], subject, text)
+send_email([author_email], subject, text, reference)
-def send_email_to_bot_watchers(subject, text):
-send_email(get_email_ids('BOT_WATCHERS_EMAILS'), subject, text)
+def send_email_to_bot_watchers(subject, text, reference=''):
+send_email(get_email_ids('BOT_WATCHERS_EMAILS'), subject, text, reference)
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (266087 => 266088)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-08-24 22:36:02 UTC (rev 266087)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-08-24 22:45:09 UTC (rev 266088)
@@ -1490,7 +1490,7 @@
logs = logs.replace('&', '').replace('<', '').replace('>', '')
email_text += u'\n\nError lines:\n\n{}'.format(logs)
email_text += '\n\nTo unsubscrible from these notifications or to provide any feedback please email aakash_j...@apple.com'
-send_email_to_patch_author(patch_author, email_subject, email_text)
+send_email_to_patch_author(patch_author, email_subject, email_text, patch_id)
except Exception as e:
print('Error in sending email for new build failure: {}'.format(e))
@@ -2027,7 +2027,7 @@
email_subject = u'Flaky test: {}'.format(test_name)
email_text = 'Test {} flaked in {}\n\nBuilder: {}'.format(test_name, build_url, builder_name)
email_text = 'Flaky test: {}\n\nBuild: {}\n\nBuilder: {}\n\nWorker: {}\n\nHistory: {}'.format(test_name, build_url, builder_name, worker_name, history_url)
-send_email_to_bot_watchers(email_subject, email_text)
+send_email_to_bot_watchers(email_subject, email_text, 'flaky-{}'.format(test_name))
except Exception as e:
# Catching all exceptions here to ensure that failure to send email doesn't impact the build
print('Error in sending email for flaky failures: {}'.format(e))
@@ -2125,7 +2125,7 @@
email_subject = u'Flaky test: {}'.format(test_name)
email_text = 'Flaky test: {}\n\nBuild: {}\n\nBuilder: {}\n\nWorker: {}\n\nHistory: {}'.format(test_name, build_url, builder_name, worker_name, history_url)
-send_email_to_bot_watchers(email_subject, email_text)
+send_email_to_bot_watchers(email_subject, email_text, 'flaky-{}'.format(test_name))
except Exception as e:
print('Error in sending email for flaky failure: {}'.format(e))
@@ -2138,7 +2138,7 @@
email_subject = u'Pre-existing test failure: {}'.format(test_name)
email_text = 'Test {} failed on clean tree run in {}.\n\nBuilder: {}\n\nWorker: {}\n\nHistory: {}'.format(test_name,
[webkit-changes] [266087] trunk
Title: [266087] trunk Revision 266087 Author commit-qu...@webkit.org Date 2020-08-24 15:36:02 -0700 (Mon, 24 Aug 2020) Log Message Implement Request/Response consuming as FormData https://bugs.webkit.org/show_bug.cgi?id=215671 Patch by Alex Christensen on 2020-08-24 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/abort/general.any-expected.txt: * web-platform-tests/fetch/api/abort/general.any.worker-expected.txt: * web-platform-tests/fetch/api/request/request-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers. * web-platform-tests/fetch/api/request/request-consume-expected.txt: * web-platform-tests/fetch/api/request/request-init-002-expected.txt: * web-platform-tests/fetch/api/response/response-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers. * web-platform-tests/fetch/api/response/response-consume-expected.txt: * web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt: This change makes the formData failures in this file look like all the other failures in this file, which should be fixed together in a separate patch. * web-platform-tests/fetch/api/response/response-init-002-expected.txt: * web-platform-tests/url/urlencoded-parser.any-expected.txt: * web-platform-tests/url/urlencoded-parser.any.worker-expected.txt: * web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt: Source/WebCore: Covered by many newly passing WPT tests, for most of which Safari was the only failing browser. * Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::formData): (WebCore::FetchBody::consume): (WebCore::FetchBody::consumeFormData): * Modules/fetch/FetchBody.h: * Modules/fetch/FetchBodyConsumer.cpp: (WebCore::formDataFromData): (WebCore::resolveWithTypeAndData): (WebCore::FetchBodyConsumer::resolve): * Modules/fetch/FetchBodyConsumer.h: Source/WebKit: * WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish): Add a fast path that allows non-blob FormData responses from service workers to not hang. This part is covered by this layout test: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https.html Source/WTF: In order to be compatible with other browsers, we need a verson of String::fromUTF8 that uses U8_NEXT_OR_FFFD instead of U8_NEXT, but changing that across the board will break other things. Leave everything else as it is, use templates and constexpr to not add any branches, but add String::fromUTF8ReplacingInvalidSequences to allow me to make our FormData consuming compatible with other browsers. * wtf/text/WTFString.cpp: (WTF::fromUTF8Helper): (WTF::String::fromUTF8): (WTF::String::fromUTF8ReplacingInvalidSequences): * wtf/text/WTFString.h: * wtf/unicode/UTF8Conversion.cpp: (WTF::Unicode::convertUTF8ToUTF16Impl): (WTF::Unicode::convertUTF8ToUTF16): (WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences): * wtf/unicode/UTF8Conversion.h: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-init-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/urlencoded-parser.any-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/urlencoded-parser.any.worker-expected.txt trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WTF/wtf/StringExtras.h trunk/Source/WTF/wtf/URLParser.cpp trunk/Source/WTF/wtf/text/WTFString.cpp trunk/Source/WTF/wtf/text/WTFString.h trunk/Source/WTF/wtf/unicode/UTF8Conversion.cpp trunk/Source/WTF/wtf/unicode/UTF8Conversion.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchBody.cpp trunk/Source/WebCore/Modules/fetch/FetchBody.h trunk/Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp trunk/Source/WebCore/Modules/fetch/FetchBodyConsumer.h
[webkit-changes] [266086] trunk/Source
Title: [266086] trunk/Source Revision 266086 Author commit-qu...@webkit.org Date 2020-08-24 14:41:43 -0700 (Mon, 24 Aug 2020) Log Message Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory https://bugs.webkit.org/show_bug.cgi?id=213048 Patch by Alex Christensen on 2020-08-24 Reviewed by Youenn Fablet. Source/WebCore/PAL: * pal/spi/cf/CFNetworkSPI.h: Source/WebKit: This uses CFNetwork SPI introduced in rdar://problem/50109631 to allow HSTS storage per NSURLSession. To be complete, I also deprecated our UI process HSTS state removal attempt SPIs, WKContextResetHSTSHosts and WKContextResetHSTSHostsAddedAfterDate, which had their last use removed in rdar://problem/64220838. I manually verified that this new SPI puts HSTS data in the specified location, and I also verified that HSTS state querying and removal works with the new CFNetwork SPI as it did with the old one. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::fetchWebsiteData): (WebKit::NetworkProcess::deleteWebsiteData): (WebKit::NetworkProcess::deleteWebsiteDataForOrigins): (WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains): (WebKit::NetworkProcess::registrableDomainsWithWebsiteData): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::encode const): (WebKit::NetworkSessionCreationParameters::decode): * NetworkProcess/NetworkSessionCreationParameters.h: * NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::hostNamesWithHSTSCache const): (WebKit::NetworkProcess::deleteHSTSCacheForHostNames): (WebKit::NetworkProcess::clearHSTSCache): (WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted. * NetworkProcess/cocoa/NetworkSessionCocoa.h: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::hstsStorage const): (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): * NetworkProcess/soup/NetworkProcessSoup.cpp: (WebKit::NetworkProcess::hostNamesWithHSTSCache const): (WebKit::NetworkProcess::deleteHSTSCacheForHostNames): (WebKit::NetworkProcess::clearHSTSCache): (WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted. * UIProcess/API/C/mac/WKContextPrivateMac.h: * UIProcess/API/C/mac/WKContextPrivateMac.mm: (WKContextResetHSTSHosts): (WKContextResetHSTSHostsAddedAfterDate): * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: (-[_WKWebsiteDataStoreConfiguration hstsStorageDirectory]): (-[_WKWebsiteDataStoreConfiguration setHSTSStorageDirectory:]): * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::privateBrowsingSession): Deleted. (WebKit::WebProcessPool::resetHSTSHosts): Deleted. (WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Deleted. * UIProcess/WebProcessPool.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary): (WebKit::WebsiteDataStore::parameters): * UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::resolvedHSTSStorageDirectory const): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: (WebKit::WebsiteDataStoreConfiguration::copy const): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: Source/WTF: * wtf/PlatformHave.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcess.h trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm trunk/Source/WebKit/UIProcess/WebProcessPool.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h Diff Modified: trunk/Source/WTF/ChangeLog (266085 => 266086) --- trunk/Source/WTF/ChangeLog 2020-08-24 21:35:54 UTC (rev 266085) +++ trunk/Source/WTF/ChangeLog 2020-08-24
[webkit-changes] [266085] trunk/LayoutTests
Title: [266085] trunk/LayoutTests Revision 266085 Author hector_i_lo...@apple.com Date 2020-08-24 14:35:54 -0700 (Mon, 24 Aug 2020) Log Message [ iOS wk2 Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-fetch-error-external-module.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=215783 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266084 => 266085) --- trunk/LayoutTests/ChangeLog 2020-08-24 21:06:20 UTC (rev 266084) +++ trunk/LayoutTests/ChangeLog 2020-08-24 21:35:54 UTC (rev 266085) @@ -1,5 +1,14 @@ 2020-08-24 Hector Lopez +[ iOS wk2 Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-fetch-error-external-module.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=215783 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2020-08-24 Hector Lopez + [ macOS wk1 ] fast/overflow/horizontal-scroll-after-back.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=215778 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (266084 => 266085) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-08-24 21:06:20 UTC (rev 266084) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-08-24 21:35:54 UTC (rev 266085) @@ -1864,3 +1864,5 @@ webkit.org/b/215773 http/tests/websocket/tests/hybi/client-close-2.html [ Pass Failure ] webkit.org/b/215772 platform/ios/ios/fast/coordinates/range-client-rects.html [ Failure ] + +webkit.org/b/215783 [ Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-fetch-error-external-module.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266084] trunk/Websites/webkit.org
Title: [266084] trunk/Websites/webkit.org Revision 266084 Author j...@apple.com Date 2020-08-24 14:06:20 -0700 (Mon, 24 Aug 2020) Log Message Disable unused RPC services https://bugs.webkit.org/show_bug.cgi?id=215779 Reviewed by Alexey Proskuryakov. * .htaccess: Modified Paths trunk/Websites/webkit.org/.htaccess trunk/Websites/webkit.org/ChangeLog Diff Modified: trunk/Websites/webkit.org/.htaccess (266083 => 266084) --- trunk/Websites/webkit.org/.htaccess 2020-08-24 19:26:03 UTC (rev 266083) +++ trunk/Websites/webkit.org/.htaccess 2020-08-24 21:06:20 UTC (rev 266084) @@ -111,6 +111,12 @@ # Pixar USD support. Change to model/vnd.usdz+zip once WebKit support is in the wild. AddType model/vnd.pixar.usd usdz +# Disable XML-RPC + +Order Allow,Deny +Deny from all + + # BEGIN WordPress RewriteEngine On Modified: trunk/Websites/webkit.org/ChangeLog (266083 => 266084) --- trunk/Websites/webkit.org/ChangeLog 2020-08-24 19:26:03 UTC (rev 266083) +++ trunk/Websites/webkit.org/ChangeLog 2020-08-24 21:06:20 UTC (rev 266084) @@ -1,3 +1,12 @@ +2020-08-24 Jon Davis + +Disable unused RPC services +https://bugs.webkit.org/show_bug.cgi?id=215779 + +Reviewed by Alexey Proskuryakov. + +* .htaccess: + 2020-08-18 Darin Adler * languages.md: Fixed "Movaje" typo. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266083] trunk/LayoutTests
Title: [266083] trunk/LayoutTests Revision 266083 Author hector_i_lo...@apple.com Date 2020-08-24 12:26:03 -0700 (Mon, 24 Aug 2020) Log Message [ macOS wk1 ] fast/overflow/horizontal-scroll-after-back.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=215778 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266082 => 266083) --- trunk/LayoutTests/ChangeLog 2020-08-24 19:17:52 UTC (rev 266082) +++ trunk/LayoutTests/ChangeLog 2020-08-24 19:26:03 UTC (rev 266083) @@ -1,3 +1,12 @@ +2020-08-24 Hector Lopez + + [ macOS wk1 ] fast/overflow/horizontal-scroll-after-back.html is a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=215778 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2020-08-24 Emilio Cobos Álvarez Support quotes:auto and fix quotes serialization. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (266082 => 266083) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-08-24 19:17:52 UTC (rev 266082) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-08-24 19:26:03 UTC (rev 266083) @@ -1137,3 +1137,6 @@ webkit.org/b/215767 [ Debug ] inspector/animation/nameChanged.html [ Pass Crash ] +webkit.org/b/215778 fast/overflow/horizontal-scroll-after-back.html [ Pass Timeout ] + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266082] trunk
Title: [266082] trunk Revision 266082 Author emi...@crisal.io Date 2020-08-24 12:17:52 -0700 (Mon, 24 Aug 2020) Log Message Support quotes:auto and fix quotes serialization. https://bugs.webkit.org/show_bug.cgi?id=215646 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/css/css-content/inheritance-expected.txt: Annotate progression. * web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto. Source/WebCore: Tests: imported/w3c/web-platform-tests/css/css-content/inheritance.html imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::RefvalueForQuotes): (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeQuotes): * rendering/style/QuotesData.h: (WebCore::QuotesData::size const): * style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertQuotes): LayoutTests: * platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Annotate progression. * platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto. * platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-content/inheritance-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp trunk/Source/WebCore/rendering/style/QuotesData.h trunk/Source/WebCore/style/StyleBuilderConverter.h Diff Modified: trunk/LayoutTests/ChangeLog (266081 => 266082) --- trunk/LayoutTests/ChangeLog 2020-08-24 18:57:05 UTC (rev 266081) +++ trunk/LayoutTests/ChangeLog 2020-08-24 19:17:52 UTC (rev 266082) @@ -1,3 +1,14 @@ +2020-08-24 Emilio Cobos Álvarez + +Support quotes:auto and fix quotes serialization. +https://bugs.webkit.org/show_bug.cgi?id=215646 + +Reviewed by Darin Adler. + +* platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Annotate progression. +* platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto. +* platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto. + 2020-08-24 Hector Lopez [ macOS wk2 Release ] http/tests/workers/service/basic-install-event-waitUntil-reject.html is a flaky timeout Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266081 => 266082) --- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-24 18:57:05 UTC (rev 266081) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-24 19:17:52 UTC (rev 266082) @@ -1,3 +1,13 @@ +2020-08-24 Emilio Cobos Álvarez + +Support quotes:auto and fix quotes serialization. +https://bugs.webkit.org/show_bug.cgi?id=215646 + +Reviewed by Darin Adler. + +* web-platform-tests/css/css-content/inheritance-expected.txt: Annotate progression. +* web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto. + 2020-08-24 Justin Uberti RTCRtpSynchronizationSource.rtpTimestamp is not present Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-content/inheritance-expected.txt (266081 => 266082) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-content/inheritance-expected.txt 2020-08-24 18:57:05 UTC (rev 266081) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-content/inheritance-expected.txt 2020-08-24 19:17:52 UTC (rev 266082) @@ -1,6 +1,6 @@ -FAIL Property quotes has initial value auto assert_equals: expected "auto" but got "" -FAIL Property quotes inherits assert_equals: expected "none" but got "" +PASS Property quotes has initial value auto +PASS Property quotes inherits FAIL Property bookmark-level has initial value none assert_true: bookmark-level doesn't seem to be supported in the computed style expected true got false FAIL Property bookmark-level does not inherit assert_true: expected true got false FAIL Property bookmark-state has initial value open assert_true: bookmark-state doesn't seem to be supported in the computed style expected true got false Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt (266081
[webkit-changes] [266081] trunk/Source
Title: [266081] trunk/Source Revision 266081 Author repst...@apple.com Date 2020-08-24 11:57:05 -0700 (Mon, 24 Aug 2020) Log Message Versioning. WebKit-7611.1.1 Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (266080 => 266081) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2020-08-24 18:53:31 UTC (rev 266080) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2020-08-24 18:57:05 UTC (rev 266081) @@ -21,9 +21,9 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -MAJOR_VERSION = 610; -MINOR_VERSION = 2; -TINY_VERSION = 2; +MAJOR_VERSION = 611; +MINOR_VERSION = 1; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (266080 => 266081) --- trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-08-24 18:53:31 UTC (rev 266080) +++ trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-08-24 18:57:05 UTC (rev 266081) @@ -21,9 +21,9 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -MAJOR_VERSION = 610; -MINOR_VERSION = 2; -TINY_VERSION = 2; +MAJOR_VERSION = 611; +MINOR_VERSION = 1; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (266080 => 266081) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-08-24 18:53:31 UTC (rev 266080) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-08-24 18:57:05 UTC (rev 266081) @@ -21,9 +21,9 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -MAJOR_VERSION = 610; -MINOR_VERSION = 2; -TINY_VERSION = 2; +MAJOR_VERSION = 611; +MINOR_VERSION = 1; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (266080 => 266081) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2020-08-24 18:53:31 UTC (rev 266080) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2020-08-24 18:57:05 UTC (rev 266081) @@ -21,9 +21,9 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -MAJOR_VERSION = 610; -MINOR_VERSION = 2; -TINY_VERSION = 2; +MAJOR_VERSION = 611; +MINOR_VERSION = 1; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (266080 => 266081) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-08-24 18:53:31 UTC (rev 266080) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-08-24 18:57:05 UTC (rev 266081) @@ -21,9 +21,9 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -MAJOR_VERSION = 610; -MINOR_VERSION = 2; -TINY_VERSION = 2; +MAJOR_VERSION = 611; +MINOR_VERSION = 1; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (266080 => 266081) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-08-24 18:53:31 UTC (rev 266080) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-08-24 18:57:05 UTC (rev 266081) @@ -1,6 +1,6 @@ -MAJOR_VERSION = 610; -MINOR_VERSION = 2; -TINY_VERSION = 2; +MAJOR_VERSION = 611; +MINOR_VERSION = 1; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (266080 => 266081) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2020-08-24 18:53:31 UTC (rev 266080) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2020-08-24 18:57:05 UTC (rev 266081) @@ -21,9 +21,9 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
[webkit-changes] [266080] trunk/Tools
Title: [266080] trunk/Tools Revision 266080 Author jbed...@apple.com Date 2020-08-24 11:53:31 -0700 (Mon, 24 Aug 2020) Log Message [resultsdbpy] Fix pip package https://bugs.webkit.org/show_bug.cgi?id=215721 Reviewed by Dewei Zhu. * Scripts/libraries/resultsdbpy/MANIFEST.in: Add html and css. * Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Include submodules. * Scripts/libraries/resultsdbpy/setup.py: Version bump. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/resultsdbpy/MANIFEST.in trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py trunk/Tools/Scripts/libraries/resultsdbpy/setup.py Diff Modified: trunk/Tools/ChangeLog (266079 => 266080) --- trunk/Tools/ChangeLog 2020-08-24 18:44:29 UTC (rev 266079) +++ trunk/Tools/ChangeLog 2020-08-24 18:53:31 UTC (rev 266080) @@ -1,3 +1,15 @@ +2020-08-24 Jonathan Bedard + +[resultsdbpy] Fix pip package +https://bugs.webkit.org/show_bug.cgi?id=215721 + + +Reviewed by Dewei Zhu. + +* Scripts/libraries/resultsdbpy/MANIFEST.in: Add html and css. +* Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Include submodules. +* Scripts/libraries/resultsdbpy/setup.py: Version bump. + 2020-08-24 Sihui Liu Text manipulationshould not manipulate nodes out of paragraph range Modified: trunk/Tools/Scripts/libraries/resultsdbpy/MANIFEST.in (266079 => 266080) --- trunk/Tools/Scripts/libraries/resultsdbpy/MANIFEST.in 2020-08-24 18:44:29 UTC (rev 266079) +++ trunk/Tools/Scripts/libraries/resultsdbpy/MANIFEST.in 2020-08-24 18:53:31 UTC (rev 266080) @@ -1 +1,3 @@ include README.md +recursive-include resultsdbpy/view/static * +recursive-include resultsdbpy/view/templates * Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py (266079 => 266080) --- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py 2020-08-24 18:44:29 UTC (rev 266079) +++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py 2020-08-24 18:53:31 UTC (rev 266080) @@ -43,6 +43,6 @@ "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `" ) -version = Version(1, 0, 0) +version = Version(1, 0, 1) name = 'resultsdbpy' Modified: trunk/Tools/Scripts/libraries/resultsdbpy/setup.py (266079 => 266080) --- trunk/Tools/Scripts/libraries/resultsdbpy/setup.py 2020-08-24 18:44:29 UTC (rev 266079) +++ trunk/Tools/Scripts/libraries/resultsdbpy/setup.py 2020-08-24 18:53:31 UTC (rev 266080) @@ -50,7 +50,14 @@ author='Jonathan Bedard', author_email='jbed...@apple.com', license='Modified BSD', -packages=['resultsdbpy'], +packages=[ +'resultsdbpy', +'resultsdbpy.controller', +'resultsdbpy.example', +'resultsdbpy.flask_support', +'resultsdbpy.model', +'resultsdbpy.view', +], install_requires=[ 'cassandra-driver', 'fakeredis', ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266079] branches/safari-610-branch/
Title: [266079] branches/safari-610-branch/ Revision 266079 Author repst...@apple.com Date 2020-08-24 11:44:29 -0700 (Mon, 24 Aug 2020) Log Message New branch. Added Paths branches/safari-610-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266078] trunk/LayoutTests
Title: [266078] trunk/LayoutTests Revision 266078 Author hector_i_lo...@apple.com Date 2020-08-24 11:44:25 -0700 (Mon, 24 Aug 2020) Log Message [ macOS wk2 Release ] http/tests/workers/service/basic-install-event-waitUntil-reject.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=214997 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266077 => 266078) --- trunk/LayoutTests/ChangeLog 2020-08-24 18:40:30 UTC (rev 266077) +++ trunk/LayoutTests/ChangeLog 2020-08-24 18:44:25 UTC (rev 266078) @@ -1,3 +1,12 @@ +2020-08-24 Hector Lopez + + [ macOS wk2 Release ] http/tests/workers/service/basic-install-event-waitUntil-reject.html is a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=214997 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-08-24 Devin Rousso Web Inspector: allow event breakpoints to be configured Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (266077 => 266078) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-08-24 18:40:30 UTC (rev 266077) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-08-24 18:44:25 UTC (rev 266078) @@ -1276,3 +1276,6 @@ [ BigSur+ ] media/vp9.html [ Pass ] webkit.org/b/215700 [ Debug ] fast/scrolling/mac/scrollbars/overlay-scrollbar-hovered.html [ Pass Failure Timeout ] + +webkit.org/b/214997 [ Release ] http/tests/workers/service/basic-install-event-waitUntil-reject.html [ Pass Timeout ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266076] trunk/Source/WebInspectorUI
Title: [266076] trunk/Source/WebInspectorUI
Revision 266076
Author drou...@apple.com
Date 2020-08-24 11:13:03 -0700 (Mon, 24 Aug 2020)
Log Message
Web Inspector: remove legacy code for replacing the Resources Tab and Debugger Tab with the Sources Tab
https://bugs.webkit.org/show_bug.cgi?id=205826
Reviewed by Joseph Pecoraro.
* UserInterface/Base/Main.js:
(WI.loaded):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (266075 => 266076)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-08-24 18:06:01 UTC (rev 266075)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-08-24 18:13:03 UTC (rev 266076)
@@ -1,5 +1,15 @@
2020-08-24 Devin Rousso
+Web Inspector: remove legacy code for replacing the Resources Tab and Debugger Tab with the Sources Tab
+https://bugs.webkit.org/show_bug.cgi?id=205826
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Base/Main.js:
+(WI.loaded):
+
+2020-08-24 Devin Rousso
+
Web Inspector: allow event breakpoints to be configured
https://bugs.webkit.org/show_bug.cgi?id=215362
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (266075 => 266076)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-08-24 18:06:01 UTC (rev 266075)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-08-24 18:13:03 UTC (rev 266076)
@@ -158,26 +158,6 @@
]);
WI._selectedTabIndexSetting = new WI.Setting("selected-tab-index", 0);
-// FIXME: Web Inspector: remove legacy code for replacing the Resources Tab and Debugger Tab with the Sources Tab
-let debuggerIndex = WI._openTabsSetting.value.indexOf("debugger");
-let resourcesIndex = WI._openTabsSetting.value.indexOf("resources");
-if (debuggerIndex >= 0 || resourcesIndex >= 0) {
-WI._openTabsSetting.value.remove("debugger");
-WI._openTabsSetting.value.remove("resources");
-
-if (debuggerIndex === -1)
-debuggerIndex = Infinity;
-if (resourcesIndex === -1)
-resourcesIndex = Infinity;
-
-let sourcesIndex = Math.min(debuggerIndex, resourcesIndex);
-WI._openTabsSetting.value.splice(sourcesIndex, 1, WI.SourcesTabContentView.Type);
-WI._openTabsSetting.save();
-
-if (WI._selectedTabIndexSetting.value === debuggerIndex || WI._selectedTabIndexSetting.value === resourcesIndex)
-WI._selectedTabIndexSetting.value = sourcesIndex;
-}
-
// State.
WI.printStylesEnabled = false;
WI.setZoomFactor(WI.settings.zoomFactor.value);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266075] trunk
Title: [266075] trunk
Revision 266075
Author sihui_...@apple.com
Date 2020-08-24 11:06:01 -0700 (Mon, 24 Aug 2020)
Log Message
Source/WebCore:
Text manipulation should not manipulate nodes out of paragraph range
https://bugs.webkit.org/show_bug.cgi?id=215406
Reviewed by Wenson Hsieh.
TextManipulationController currently does not set correct start path for insertion. Therefore, it does not mark
the nodes on the start path but out of range correctly, and may change position of those nodes by mistake. For
example, in the newly added test, text node "zero" can be moved around even though it is not in range.
API test: TextManipulation.CompleteTextManipulationShouldOnlyChangeNodesInParagraphRange
* editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::replace):
Tools:
Text manipulationshould not manipulate nodes out of paragraph range
https://bugs.webkit.org/show_bug.cgi?id=215406
Reviewed by Wenson Hsieh.
* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextManipulationController.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (266074 => 266075)
--- trunk/Source/WebCore/ChangeLog 2020-08-24 17:34:12 UTC (rev 266074)
+++ trunk/Source/WebCore/ChangeLog 2020-08-24 18:06:01 UTC (rev 266075)
@@ -1,3 +1,19 @@
+2020-08-24 Sihui Liu
+
+Text manipulation should not manipulate nodes out of paragraph range
+https://bugs.webkit.org/show_bug.cgi?id=215406
+
+Reviewed by Wenson Hsieh.
+
+TextManipulationController currently does not set correct start path for insertion. Therefore, it does not mark
+the nodes on the start path but out of range correctly, and may change position of those nodes by mistake. For
+example, in the newly added test, text node "zero" can be moved around even though it is not in range.
+
+API test: TextManipulation.CompleteTextManipulationShouldOnlyChangeNodesInParagraphRange
+
+* editing/TextManipulationController.cpp:
+(WebCore::TextManipulationController::replace):
+
2020-08-24 Devin Rousso
Web Inspector: allow event breakpoints to be configured
Modified: trunk/Source/WebCore/editing/TextManipulationController.cpp (266074 => 266075)
--- trunk/Source/WebCore/editing/TextManipulationController.cpp 2020-08-24 17:34:12 UTC (rev 266074)
+++ trunk/Source/WebCore/editing/TextManipulationController.cpp 2020-08-24 18:06:01 UTC (rev 266075)
@@ -829,8 +829,20 @@
nodesToRemove.remove(*node);
HashSet> reusedOriginalNodes;
-Vector lastTopDownPath;
Vector insertions;
+auto startTopDownPath = getPath(commonAncestor.get(), firstContentNode.get());
+while (!startTopDownPath.isEmpty()) {
+auto lastNode = startTopDownPath.last();
+ASSERT(is(lastNode.get()));
+if (!downcast(lastNode.get()).hasOneChild())
+break;
+nodesToRemove.add(startTopDownPath.takeLast());
+}
+auto lastTopDownPath = startTopDownPath.map([&](auto node) -> NodeEntry {
+reusedOriginalNodes.add(node.copyRef());
+return { node, node };
+});
+
for (size_t index = 0; index < replacementTokens.size(); ++index) {
auto& replacementToken = replacementTokens[index];
auto it = tokenExchangeMap.find(replacementToken.identifier);
Modified: trunk/Tools/ChangeLog (266074 => 266075)
--- trunk/Tools/ChangeLog 2020-08-24 17:34:12 UTC (rev 266074)
+++ trunk/Tools/ChangeLog 2020-08-24 18:06:01 UTC (rev 266075)
@@ -1,3 +1,13 @@
+2020-08-24 Sihui Liu
+
+Text manipulationshould not manipulate nodes out of paragraph range
+https://bugs.webkit.org/show_bug.cgi?id=215406
+
+Reviewed by Wenson Hsieh.
+
+* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
+(TestWebKitAPI::TEST):
+
2020-08-24 Aditya Keerthi
[macOS] Show picker for date and datetime-local input types
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm (266074 => 266075)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm 2020-08-24 17:34:12 UTC (rev 266074)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm 2020-08-24 18:06:01 UTC (rev 266075)
@@ -3131,6 +3131,54 @@
EXPECT_WK_STREQ("ImagesLink }
+TEST(TextManipulation, CompleteTextManipulationShouldOnlyChangeNodesInParagraphRange)
+{
+auto delegate = adoptNS([[TextManipulationDelegate alloc] init]);
+auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 400, 400)]);
+[webView _setTextManipulationDelegate:delegate.get()];
+[webView synchronouslyLoadHTMLString:@""
+""
+""
+"span { white-space:pre; }"
+""
+""
+""
+"zero two four"
+"one"
+"three"
+
[webkit-changes] [266073] trunk/LayoutTests
Title: [266073] trunk/LayoutTests Revision 266073 Author hector_i_lo...@apple.com Date 2020-08-24 10:32:03 -0700 (Mon, 24 Aug 2020) Log Message Regression (r266028): platform/ios/ios/fast/coordinates/range-client-rects.html https://bugs.webkit.org/show_bug.cgi?id=215772 Unreviewwed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266072 => 266073) --- trunk/LayoutTests/ChangeLog 2020-08-24 17:31:56 UTC (rev 266072) +++ trunk/LayoutTests/ChangeLog 2020-08-24 17:32:03 UTC (rev 266073) @@ -1,3 +1,12 @@ +2020-08-24 Hector Lopez + +Regression (r266028): platform/ios/ios/fast/coordinates/range-client-rects.html +https://bugs.webkit.org/show_bug.cgi?id=215772 + +Unreviewwed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-08-24 Youenn Fablet Add a test showing the difference of behavior when closing a WebSocket connection between legacy WebSocket and NSURLSession WebSocket code paths Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (266072 => 266073) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-08-24 17:31:56 UTC (rev 266072) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-08-24 17:32:03 UTC (rev 266073) @@ -1862,3 +1862,5 @@ webkit.org/b/215706 [ Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-createHTMLDocument-parse-error-external-classic.html [ Pass Failure ] webkit.org/b/215773 http/tests/websocket/tests/hybi/client-close-2.html [ Pass Failure ] + +webkit.org/b/215772 platform/ios/ios/fast/coordinates/range-client-rects.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266072] trunk/Source
Title: [266072] trunk/Source Revision 266072 Author drou...@apple.com Date 2020-08-24 10:31:56 -0700 (Mon, 24 Aug 2020) Log Message Web Inspector: remove "extra domains" concept now that domains can be added based on the debuggable type https://bugs.webkit.org/show_bug.cgi?id=201150 Reviewed by Brian Burg. Source/_javascript_Core: * inspector/scripts/codegen/objc_generator_templates.py: * inspector/augmentable/AugmentableInspectorController.h: * inspector/JSGlobalObjectInspectorController.h: * inspector/JSGlobalObjectInspectorController.cpp: (Inspector::JSGlobalObjectInspectorController::connectFrontend): (Inspector::JSGlobalObjectInspectorController::registerAlternateAgent): Added. (Inspector::JSGlobalObjectInspectorController::appendExtraAgent): Deleted. * inspector/InspectorAgentRegistry.h: * inspector/InspectorAgentRegistry.cpp: (Inspector::AgentRegistry::appendExtraAgent): Deleted. * inspector/protocol/Inspector.json: * inspector/agents/InspectorAgent.h: * inspector/agents/InspectorAgent.cpp: (Inspector::InspectorAgent::activateExtraDomain): Deleted. (Inspector::InspectorAgent::activateExtraDomains): Deleted. * inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result: * inspector/scripts/tests/expected/commands-with-async-attribute.json-result: * inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result: * inspector/scripts/tests/expected/definitions-with-mac-platform.json-result: * inspector/scripts/tests/expected/domain-debuggableTypes.json-result: * inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result: * inspector/scripts/tests/expected/domain-targetTypes.json-result: * inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result: * inspector/scripts/tests/expected/enum-values.json-result: * inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result: * inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result: Rebase protocol tests. Source/WebInspectorUI: * UserInterface/Base/Object.js: * UserInterface/Protocol/InspectorObserver.js: (WI.InspectorObserver.prototype.activateExtraDomains): * UserInterface/Protocol/Target.js: (WI.Target.prototype.activateExtraDomain): * UserInterface/Controllers/AppController.js: (WI.AppController.prototype.activateExtraDomains): * UserInterface/Controllers/AnimationManager.js: (WI.AnimationManager.prototype.activateExtraDomain): * UserInterface/Controllers/ApplicationCacheManager.js: (WI.ApplicationCacheManager.prototype.activateExtraDomain): * UserInterface/Controllers/CanvasManager.js: (WI.CanvasManager.prototype.activateExtraDomain): * UserInterface/Controllers/DOMStorageManager.js: (WI.DOMStorageManager.prototype.activateExtraDomain): * UserInterface/Controllers/DatabaseManager.js: (WI.DatabaseManager.prototype.activateExtraDomain): * UserInterface/Controllers/HeapManager.js: (WI.HeapManager.prototype.activateExtraDomain): * UserInterface/Controllers/IndexedDBManager.js: (WI.IndexedDBManager.prototype.activateExtraDomain): * UserInterface/Controllers/MemoryManager.js: (WI.MemoryManager.prototype.activateExtraDomain): * UserInterface/Controllers/NetworkManager.js: (WI.NetworkManager.prototype._extraDomainsActivated): * UserInterface/Controllers/TimelineManager.js: (WI.TimelineManager.prototype.activateExtraDomain): * UserInterface/Base/Main.js: (WI.activateExtraDomains): * UserInterface/Views/SourcesNavigationSidebarPanel.js: (WI.SourcesNavigationSidebarPanel): (WI.SourcesNavigationSidebarPanel.prototype._handleExtraDomainsActivated): Add compatibility comments. * UserInterface/Protocol/InspectorBackend.js: (InspectorBackendClass): (InspectorBackend.Domain): Add FIXMEs. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/InspectorAgentRegistry.cpp trunk/Source/_javascript_Core/inspector/InspectorAgentRegistry.h trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.h trunk/Source/_javascript_Core/inspector/agents/InspectorAgent.cpp trunk/Source/_javascript_Core/inspector/agents/InspectorAgent.h trunk/Source/_javascript_Core/inspector/augmentable/AugmentableInspectorController.h trunk/Source/_javascript_Core/inspector/protocol/Inspector.json trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator_templates.py trunk/Source/_javascript_Core/inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/expected/definitions-with-mac-platform.json-result
[webkit-changes] [266071] trunk/Source/WebInspectorUI
Title: [266071] trunk/Source/WebInspectorUI
Revision 266071
Author drou...@apple.com
Date 2020-08-24 10:30:29 -0700 (Mon, 24 Aug 2020)
Log Message
Web Inspector: remove legacy code for replacing the Canvas Tab with the Graphics Tab
https://bugs.webkit.org/show_bug.cgi?id=205827
Reviewed by Joseph Pecoraro.
* UserInterface/Base/Main.js:
(WI.loaded):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (266070 => 266071)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-08-24 17:24:52 UTC (rev 266070)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-08-24 17:30:29 UTC (rev 266071)
@@ -1,5 +1,15 @@
2020-08-24 Devin Rousso
+Web Inspector: remove legacy code for replacing the Canvas Tab with the Graphics Tab
+https://bugs.webkit.org/show_bug.cgi?id=205827
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Base/Main.js:
+(WI.loaded):
+
+2020-08-24 Devin Rousso
+
Web Inspector: Elements: Styles: don't show swatches for properties that aren't used/apply
https://bugs.webkit.org/show_bug.cgi?id=215681
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (266070 => 266071)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-08-24 17:24:52 UTC (rev 266070)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-08-24 17:30:29 UTC (rev 266071)
@@ -178,13 +178,6 @@
WI._selectedTabIndexSetting.value = sourcesIndex;
}
-// FIXME: Web Inspector: remove legacy code for replacing the Canvas Tab with the Graphics Tab
-let canvasIndex = WI._openTabsSetting.value.indexOf("canvas");
-if (canvasIndex >= 0) {
-WI._openTabsSetting.value.splice(canvasIndex, 1, WI.GraphicsTabContentView.Type);
-WI._openTabsSetting.save();
-}
-
// State.
WI.printStylesEnabled = false;
WI.setZoomFactor(WI.settings.zoomFactor.value);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266070] trunk/Source/WebInspectorUI
Title: [266070] trunk/Source/WebInspectorUI
Revision 266070
Author drou...@apple.com
Date 2020-08-24 10:24:52 -0700 (Mon, 24 Aug 2020)
Log Message
Web Inspector: Elements: Styles: don't show swatches for properties that aren't used/apply
https://bugs.webkit.org/show_bug.cgi?id=215681
Reviewed by Brian Burg.
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._renderValue):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (266069 => 266070)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-08-24 17:21:07 UTC (rev 266069)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-08-24 17:24:52 UTC (rev 266070)
@@ -1,5 +1,15 @@
2020-08-24 Devin Rousso
+Web Inspector: Elements: Styles: don't show swatches for properties that aren't used/apply
+https://bugs.webkit.org/show_bug.cgi?id=215681
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/SpreadsheetStyleProperty.js:
+(WI.SpreadsheetStyleProperty.prototype._renderValue):
+
+2020-08-24 Devin Rousso
+
Web Inspector: Elements: Styles: don't show non-inherited properties
https://bugs.webkit.org/show_bug.cgi?id=215682
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (266069 => 266070)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2020-08-24 17:21:07 UTC (rev 266069)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2020-08-24 17:24:52 UTC (rev 266070)
@@ -463,7 +463,7 @@
const maxValueLength = 150;
let tokens = WI.tokenizeCSSValue(value);
-if (this._property.enabled)
+if (this._property.enabled && !this._property.overridden && this._property.valid && !this._property.hasOtherVendorNameOrKeyword())
tokens = this._replaceSpecialTokens(tokens);
tokens = tokens.map((token) => {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266069] trunk/Source/WebInspectorUI
Title: [266069] trunk/Source/WebInspectorUI Revision 266069 Author drou...@apple.com Date 2020-08-24 10:21:07 -0700 (Mon, 24 Aug 2020) Log Message Web Inspector: Elements: Styles: don't show non-inherited properties https://bugs.webkit.org/show_bug.cgi?id=215682 Reviewed by Brian Burg. * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js: (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get propertiesToRender): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (266068 => 266069) --- trunk/Source/WebInspectorUI/ChangeLog 2020-08-24 17:17:55 UTC (rev 266068) +++ trunk/Source/WebInspectorUI/ChangeLog 2020-08-24 17:21:07 UTC (rev 266069) @@ -1,5 +1,15 @@ 2020-08-24 Devin Rousso +Web Inspector: Elements: Styles: don't show non-inherited properties +https://bugs.webkit.org/show_bug.cgi?id=215682 + +Reviewed by Brian Burg. + +* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js: +(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get propertiesToRender): + +2020-08-24 Devin Rousso + Web Inspector: Elements: Styles: grey out properties that aren't used/apply https://bugs.webkit.org/show_bug.cgi?id=215680 Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js (266068 => 266069) --- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2020-08-24 17:17:55 UTC (rev 266068) +++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2020-08-24 17:21:07 UTC (rev 266069) @@ -230,6 +230,9 @@ else properties = this._style.properties; +if (this._style.inherited) +properties = properties.filter((property) => property.inherited); + if (this._sortPropertiesByName) properties.sort((a, b) => a.name.extendedLocaleCompare(b.name)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266068] trunk/LayoutTests
Title: [266068] trunk/LayoutTests
Revision 266068
Author you...@apple.com
Date 2020-08-24 10:17:55 -0700 (Mon, 24 Aug 2020)
Log Message
Add a test showing the difference of behavior when closing a WebSocket connection between legacy WebSocket and NSURLSession WebSocket code paths
https://bugs.webkit.org/show_bug.cgi?id=215766
Reviewed by Alex Christensen.
Add a test showing the difference of behavior at connection close time in python websocket script.
This behavior was previously covered in http/tests/websocket/tests/hybi/close-on-* tests.
The test is written so that Chrome, Firefox and NSURLSession WebSocket code path generate all PASS.
Legacy WebSocket code path generates one FAIL.
* http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py: Added.
* http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt: Added.
* http/tests/websocket/tests/hybi/close-and-server-script-exception.html: Added.
* http/tests/websocket/tests/hybi/resources/close-and-server-script-exception-iframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py
trunk/LayoutTests/http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/close-and-server-script-exception.html
trunk/LayoutTests/http/tests/websocket/tests/hybi/resources/close-and-server-script-exception-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (266067 => 266068)
--- trunk/LayoutTests/ChangeLog 2020-08-24 17:13:04 UTC (rev 266067)
+++ trunk/LayoutTests/ChangeLog 2020-08-24 17:17:55 UTC (rev 266068)
@@ -1,3 +1,20 @@
+2020-08-24 Youenn Fablet
+
+Add a test showing the difference of behavior when closing a WebSocket connection between legacy WebSocket and NSURLSession WebSocket code paths
+https://bugs.webkit.org/show_bug.cgi?id=215766
+
+Reviewed by Alex Christensen.
+
+Add a test showing the difference of behavior at connection close time in python websocket script.
+This behavior was previously covered in http/tests/websocket/tests/hybi/close-on-* tests.
+The test is written so that Chrome, Firefox and NSURLSession WebSocket code path generate all PASS.
+Legacy WebSocket code path generates one FAIL.
+
+* http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py: Added.
+* http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt: Added.
+* http/tests/websocket/tests/hybi/close-and-server-script-exception.html: Added.
+* http/tests/websocket/tests/hybi/resources/close-and-server-script-exception-iframe.html: Added.
+
2020-08-24 Hector Lopez
[ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure
Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py (0 => 266068)
--- trunk/LayoutTests/http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py (rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py 2020-08-24 17:17:55 UTC (rev 266068)
@@ -0,0 +1,55 @@
+# Copyright 2009, Google Inc.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+# * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+from mod_pywebsocket import msgutil
+
+
+connections = {}
+
+
+def web_socket_do_extra_handshake(request):
+pass # Always accept.
+
+
+def web_socket_transfer_data(request):
+global connections
+connections[request] =
[webkit-changes] [266067] trunk/LayoutTests
Title: [266067] trunk/LayoutTests Revision 266067 Author hector_i_lo...@apple.com Date 2020-08-24 10:13:04 -0700 (Mon, 24 Aug 2020) Log Message [ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=215773 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266066 => 266067) --- trunk/LayoutTests/ChangeLog 2020-08-24 17:11:11 UTC (rev 266066) +++ trunk/LayoutTests/ChangeLog 2020-08-24 17:13:04 UTC (rev 266067) @@ -1,5 +1,14 @@ 2020-08-24 Hector Lopez +[ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=215773 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2020-08-24 Hector Lopez + webkit-test-runner: Add support for the reftest-wait class name https://bugs.webkit.org/show_bug.cgi?id=186045 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (266066 => 266067) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-08-24 17:11:11 UTC (rev 266066) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-08-24 17:13:04 UTC (rev 266067) @@ -1859,4 +1859,6 @@ webkit.org/b/215583 media/track/track-in-band-style.html [ Pass Timeout ] -webkit.org/b/215706 [ Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-createHTMLDocument-parse-error-external-classic.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/215706 [ Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-createHTMLDocument-parse-error-external-classic.html [ Pass Failure ] + +webkit.org/b/215773 http/tests/websocket/tests/hybi/client-close-2.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266066] trunk/Source/WebInspectorUI
Title: [266066] trunk/Source/WebInspectorUI Revision 266066 Author drou...@apple.com Date 2020-08-24 10:11:11 -0700 (Mon, 24 Aug 2020) Log Message Web Inspector: Elements: Styles: grey out properties that aren't used/apply https://bugs.webkit.org/show_bug.cgi?id=215680 Reviewed by Brian Burg. * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css: (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .name:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .name:not(:hover, .editing)): Added. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing)): Added. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .name:not(.editing), body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .value-container > .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .name:not(:hover, .editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .value-container > .value:not(:hover, .editing)): Added. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-link, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-link): Added. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-string, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-string): Added. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-comment, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-comment): Added. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .name:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .name:not(:hover, .editing)): Deleted. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing)): Deleted. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-link, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-link): Deleted. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-string, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-string): Deleted. (body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-comment, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-comment): Deleted. Add additional `:not`s to existing rules to ensure that they don't conflict with a new rule that changes the color of the `.name`/`.value` to grey when the property is not applied/used. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (266065 => 266066) ---
[webkit-changes] [266065] trunk/LayoutTests
Title: [266065] trunk/LayoutTests Revision 266065 Author hector_i_lo...@apple.com Date 2020-08-24 10:01:03 -0700 (Mon, 24 Aug 2020) Log Message webkit-test-runner: Add support for the reftest-wait class name https://bugs.webkit.org/show_bug.cgi?id=186045 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266064 => 266065) --- trunk/LayoutTests/ChangeLog 2020-08-24 16:51:20 UTC (rev 266064) +++ trunk/LayoutTests/ChangeLog 2020-08-24 17:01:03 UTC (rev 266065) @@ -1,3 +1,12 @@ +2020-08-24 Hector Lopez + +webkit-test-runner: Add support for the reftest-wait class name +https://bugs.webkit.org/show_bug.cgi?id=186045 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-08-24 Aditya Keerthi [macOS] Show picker for date and datetime-local input types Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (266064 => 266065) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-08-24 16:51:20 UTC (rev 266064) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-08-24 17:01:03 UTC (rev 266065) @@ -1764,7 +1764,7 @@ webkit.org/b/212219 media/track/track-cue-missing.html [ Pass Failure ] -webkit.org/b/186045 [ Release ] imported/w3c/web-platform-tests/css/css-display/display-none-inline-img.html [ Pass Failure ] +webkit.org/b/186045 [ Release ] imported/w3c/web-platform-tests/css/css-display/display-none-inline-img.html [ Pass ImageOnlyFailure ] webkit.org/b/212532 http/wpt/service-workers/service-worker-crashing-while-fetching.https.html [ Slow Pass Failure ] webkit.org/b/212532 http/wpt/service-workers/service-worker-different-process.https.html [ Slow Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266064] trunk/Source/ThirdParty/libwebrtc
Title: [266064] trunk/Source/ThirdParty/libwebrtc
Revision 266064
Author you...@apple.com
Date 2020-08-24 09:51:20 -0700 (Mon, 24 Aug 2020)
Log Message
Enable VP9D_SET_LOOP_FILTER_OPT for libvpx vp9 decoder
https://bugs.webkit.org/show_bug.cgi?id=215765
Reviewed by Eric Carlson.
Following https://webrtc-review.googlesource.com/c/src/+/177335 upstream, let's enable VP9D_SET_LOOP_FILTER_OPT for improved performances.
* Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (266063 => 266064)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-08-24 16:25:10 UTC (rev 266063)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-08-24 16:51:20 UTC (rev 266064)
@@ -1,3 +1,15 @@
+2020-08-24 Youenn Fablet
+
+Enable VP9D_SET_LOOP_FILTER_OPT for libvpx vp9 decoder
+https://bugs.webkit.org/show_bug.cgi?id=215765
+
+
+Reviewed by Eric Carlson.
+
+Following https://webrtc-review.googlesource.com/c/src/+/177335 upstream, let's enable VP9D_SET_LOOP_FILTER_OPT for improved performances.
+
+* Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:
+
2020-08-12 Youenn Fablet
Enable H264 low latency code path by default for MacOS
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (266063 => 266064)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc 2020-08-24 16:25:10 UTC (rev 266063)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc 2020-08-24 16:51:20 UTC (rev 266064)
@@ -1670,6 +1670,15 @@
return WEBRTC_VIDEO_CODEC_UNINITIALIZED;
}
}
+
+ vpx_codec_err_t status =
+vpx_codec_control(decoder_, VP9D_SET_LOOP_FILTER_OPT, 1);
+ if (status != VPX_CODEC_OK) {
+RTC_LOG(LS_ERROR) << "Failed to enable VP9D_SET_LOOP_FILTER_OPT. "
+ << vpx_codec_error(decoder_);
+return WEBRTC_VIDEO_CODEC_UNINITIALIZED;
+ }
+
return WEBRTC_VIDEO_CODEC_OK;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266063] trunk
Title: [266063] trunk Revision 266063 Author akeer...@apple.com Date 2020-08-24 09:25:10 -0700 (Mon, 24 Aug 2020) Log Message [macOS] Show picker for date and datetime-local input types https://bugs.webkit.org/show_bug.cgi?id=214946 Reviewed by Darin Adler and Wenson Hsieh. Source/WebCore: Date and datetime-local input types require a calendar picker to be presented when activated. Consequently, BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent was modified to create a DateTimeChooser and display a calendar upon activation. This object is destroyed when the element is blurred, hiding the calendar. There is currently no picker UI for month, week, and time input types. As a result, handleDOMActivateEvent is a no-op on those input types. Wrote an encoder and decoder for DateTimeChooserParameters, so that the picker can be created with the correct values. Tests: fast/forms/date/date-show-hide-picker.html fast/forms/datetimelocal/datetimelocal-show-hide-picker.html * WebCore.xcodeproj/project.pbxproj: * html/BaseChooserOnlyDateAndTimeInputType.cpp: (WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent): (WebCore::BaseChooserOnlyDateAndTimeInputType::elementDidBlur): (WebCore::BaseChooserOnlyDateAndTimeInputType::isPresentingAttachedView const): (WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue): * html/BaseChooserOnlyDateAndTimeInputType.h: * html/HTMLInputElement.cpp: * html/MonthInputType.cpp: (WebCore::MonthInputType::handleDOMActivateEvent): * html/MonthInputType.h: * html/TimeInputType.cpp: (WebCore::TimeInputType::handleDOMActivateEvent): * html/TimeInputType.h: * html/WeekInputType.cpp: (WebCore::WeekInputType::handleDOMActivateEvent): * html/WeekInputType.h: * loader/EmptyClients.cpp: (WebCore::EmptyChromeClient::createDateTimeChooser): * loader/EmptyClients.h: * page/Chrome.cpp: (WebCore::Chrome::createDateTimeChooser): * page/Chrome.h: * page/ChromeClient.h: * platform/DateTimeChooser.h: * platform/DateTimeChooserClient.h: * platform/DateTimeChooserParameters.h: Added. (WebCore::DateTimeChooserParameters::encode const): (WebCore::DateTimeChooserParameters::decode): Source/WebKit: Created WKDateTimePicker as a wrapper around NSDatePicker. The picker is displayed in its own NSWindow, ensuring the view is always above the page. WebPageProxy and WKDateTimePicker communicate through WebDateTimePickerMac, in order for the picker to be initialized with the correct initial, minimum, and maximum date, and so that the chosen date can be sent back to the WebProcess. Added IPC messages to enable communication between the UIProcess and the WebProcess necessary for showing and hiding the picker. * Sources.txt: * SourcesCocoa.txt: * UIProcess/PageClient.h: * UIProcess/WebDateTimePicker.cpp: Added. (WebKit::WebDateTimePicker::WebDateTimePicker): (WebKit::WebDateTimePicker::~WebDateTimePicker): (WebKit::WebDateTimePicker::endPicker): * UIProcess/WebDateTimePicker.h: Added. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showDateTimePicker): (WebKit::WebPageProxy::endDateTimePicker): (WebKit::WebPageProxy::didChooseDate): (WebKit::WebPageProxy::didEndDateTimePicker): (WebKit::WebPageProxy::closeOverlayedViews): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/PageClientImplIOS.h: * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::createDateTimePicker): * UIProcess/mac/PageClientImplMac.h: * UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::createDateTimePicker): * UIProcess/mac/WebDateTimePickerMac.h: Added. * UIProcess/mac/WebDateTimePickerMac.mm: Added. (WebKit::WebDateTimePickerMac::create): (WebKit::WebDateTimePickerMac::~WebDateTimePickerMac): (WebKit::WebDateTimePickerMac::WebDateTimePickerMac): (WebKit::WebDateTimePickerMac::endPicker): (WebKit::WebDateTimePickerMac::showDateTimePicker): (WebKit::WebDateTimePickerMac::didChooseDate): (-[WKDateTimePickerWindow initWithContentRect:styleMask:backing:defer:]): (-[WKDateTimePickerWindow canBecomeKeyWindow]): (-[WKDateTimePickerWindow hasKeyAppearance]): (-[WKDateTimePickerWindow shadowOptions]): (-[WKDateTimePicker initWithParams:inView:]): (-[WKDateTimePicker showPicker:]): (-[WKDateTimePicker invalidate]): (-[WKDateTimePicker didChooseDate:]): (-[WKDateTimePicker dateFormatStringForType:]): * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createDateTimeChooser): * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebCoreSupport/WebDateTimeChooser.cpp: Added. (WebKit::WebDateTimeChooser::WebDateTimeChooser): (WebKit::WebDateTimeChooser::didChooseDate): (WebKit::WebDateTimeChooser::didEndChooser): (WebKit::WebDateTimeChooser::endChooser): (WebKit::WebDateTimeChooser::showChooser): * WebProcess/WebCoreSupport/WebDateTimeChooser.h: Added. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setActiveDateTimeChooser): (WebKit::WebPage::didChooseDate):
[webkit-changes] [266062] trunk/Source/WebCore
Title: [266062] trunk/Source/WebCore
Revision 266062
Author za...@apple.com
Date 2020-08-24 09:22:06 -0700 (Mon, 24 Aug 2020)
Log Message
[LFC][IFC] Rename LineBox::baseline to alignment baseline
https://bugs.webkit.org/show_bug.cgi?id=214784
Reviewed by Antti Koivisto.
See https://www.w3.org/TR/css-inline-3/#alignment-baseline
Use the spec term. This helps to tell the dominant and the alignment baselines apart during line building.
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):
* layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::setAlignmentBaselineIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::LineBox::resetAlignmentBaseline):
(WebCore::Layout::LineBox::setBaselineIfGreater): Deleted.
(WebCore::Layout::LineBox::baseline const): Deleted.
(WebCore::Layout::LineBox::resetBaseline): Deleted.
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
* layout/inlineformatting/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::baseline const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBox.h
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (266061 => 266062)
--- trunk/Source/WebCore/ChangeLog 2020-08-24 15:50:22 UTC (rev 266061)
+++ trunk/Source/WebCore/ChangeLog 2020-08-24 16:22:06 UTC (rev 266062)
@@ -1,3 +1,30 @@
+2020-08-24 Zalan Bujtas
+
+[LFC][IFC] Rename LineBox::baseline to alignment baseline
+https://bugs.webkit.org/show_bug.cgi?id=214784
+
+Reviewed by Antti Koivisto.
+
+See https://www.w3.org/TR/css-inline-3/#alignment-baseline
+Use the spec term. This helps to tell the dominant and the alignment baselines apart during line building.
+
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):
+* layout/inlineformatting/InlineLineBox.h:
+(WebCore::Layout::LineBox::LineBox):
+(WebCore::Layout::LineBox::setAlignmentBaselineIfGreater):
+(WebCore::Layout::LineBox::setAscentIfGreater):
+(WebCore::Layout::LineBox::alignmentBaseline const):
+(WebCore::Layout::LineBox::resetAlignmentBaseline):
+(WebCore::Layout::LineBox::setBaselineIfGreater): Deleted.
+(WebCore::Layout::LineBox::baseline const): Deleted.
+(WebCore::Layout::LineBox::resetBaseline): Deleted.
+* layout/inlineformatting/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::close):
+(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
+* layout/inlineformatting/InlineLineBuilder.h:
+(WebCore::Layout::LineBuilder::baseline const):
+
2020-08-24 Adrian Perez de Castro
Non-unified build fixes, late August 2020 edition
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp (266061 => 266062)
--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp 2020-08-24 15:50:22 UTC (rev 266061)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp 2020-08-24 16:22:06 UTC (rev 266062)
@@ -569,7 +569,7 @@
ASSERT_NOT_REACHED();
}
// FIXME: This is where the logical to physical translate should happen.
-inlineContent.lineBoxes.append({ lineBox.logicalRect(), lineBox.scrollableOverflow(), lineInkOverflow, lineBox.baseline() });
+inlineContent.lineBoxes.append({ lineBox.logicalRect(), lineBox.scrollableOverflow(), lineInkOverflow, lineBox.alignmentBaseline() });
}
void InlineFormattingContext::invalidateFormattingState(const InvalidationState&)
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBox.h (266061 => 266062)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBox.h 2020-08-24 15:50:22 UTC (rev 266061)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBox.h 2020-08-24 16:22:06 UTC (rev 266062)
@@ -50,7 +50,7 @@
AscentAndDescent ascentAndDescent;
};
-LineBox(const Display::InlineRect&, const AscentAndDescent&, InlineLayoutUnit baseline);
+LineBox(const Display::InlineRect&, const AscentAndDescent&, InlineLayoutUnit alignmentBaseline);
LineBox() = default;
const Display::InlineRect& logicalRect() const { return m_rect; }
@@ -64,12 +64,12 @@
InlineLayoutUnit logicalWidth() const { return m_rect.width(); }
InlineLayoutUnit logicalHeight() const { return m_rect.height(); }
-// Baseline from line logical top. Note that the baseline does not
[webkit-changes] [266061] trunk/Source
Title: [266061] trunk/Source
Revision 266061
Author ape...@igalia.com
Date 2020-08-24 08:50:22 -0700 (Mon, 24 Aug 2020)
Log Message
Non-unified build fixes, late August 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=215768
Unreviewed build fix.
Source/WebCore:
No new tests needed.
* Modules/webaudio/StereoPannerNode.cpp: Add missing headers AudioNodeInput.h,
AudioNodeOutput.h, and wtf/IsoMallocInlines.h.
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):
Add JSC:: namespace to SlotVisitor parameter type.
* dom/SimpleRange.cpp: Add missing ShadowRoot.h header.
* history/CachedPage.cpp: Add missing FrameLoaderClient.h header.
Source/WebKit:
* UIProcess/WebURLSchemeTask.cpp: Add missing SharedBufferDataReference.h header.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.cpp
trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp
trunk/Source/WebCore/dom/SimpleRange.cpp
trunk/Source/WebCore/history/CachedPage.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebURLSchemeTask.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (266060 => 266061)
--- trunk/Source/WebCore/ChangeLog 2020-08-24 15:42:26 UTC (rev 266060)
+++ trunk/Source/WebCore/ChangeLog 2020-08-24 15:50:22 UTC (rev 266061)
@@ -1,3 +1,20 @@
+2020-08-24 Adrian Perez de Castro
+
+Non-unified build fixes, late August 2020 edition
+https://bugs.webkit.org/show_bug.cgi?id=215768
+
+Unreviewed build fix.
+
+No new tests needed.
+
+* Modules/webaudio/StereoPannerNode.cpp: Add missing headers AudioNodeInput.h,
+AudioNodeOutput.h, and wtf/IsoMallocInlines.h.
+* bindings/js/JSHTMLCanvasElementCustom.cpp:
+(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):
+Add JSC:: namespace to SlotVisitor parameter type.
+* dom/SimpleRange.cpp: Add missing ShadowRoot.h header.
+* history/CachedPage.cpp: Add missing FrameLoaderClient.h header.
+
2020-08-24 Zalan Bujtas
[LFC][IFC] Use the term 'baseline' to indicate alignment baseline
Modified: trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.cpp (266060 => 266061)
--- trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.cpp 2020-08-24 15:42:26 UTC (rev 266060)
+++ trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.cpp 2020-08-24 15:50:22 UTC (rev 266061)
@@ -30,6 +30,9 @@
#if ENABLE(WEB_AUDIO)
#include "AudioBus.h"
+#include "AudioNodeInput.h"
+#include "AudioNodeOutput.h"
+#include
namespace WebCore {
Modified: trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp (266060 => 266061)
--- trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp 2020-08-24 15:42:26 UTC (rev 266060)
+++ trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp 2020-08-24 15:50:22 UTC (rev 266061)
@@ -31,7 +31,7 @@
namespace WebCore {
-void JSHTMLCanvasElement::visitAdditionalChildren(SlotVisitor& visitor)
+void JSHTMLCanvasElement::visitAdditionalChildren(JSC::SlotVisitor& visitor)
{
visitor.addOpaqueRoot(static_cast(()));
}
Modified: trunk/Source/WebCore/dom/SimpleRange.cpp (266060 => 266061)
--- trunk/Source/WebCore/dom/SimpleRange.cpp 2020-08-24 15:42:26 UTC (rev 266060)
+++ trunk/Source/WebCore/dom/SimpleRange.cpp 2020-08-24 15:50:22 UTC (rev 266061)
@@ -28,6 +28,7 @@
#include "CharacterData.h"
#include "NodeTraversal.h"
+#include "ShadowRoot.h"
namespace WebCore {
Modified: trunk/Source/WebCore/history/CachedPage.cpp (266060 => 266061)
--- trunk/Source/WebCore/history/CachedPage.cpp 2020-08-24 15:42:26 UTC (rev 266060)
+++ trunk/Source/WebCore/history/CachedPage.cpp 2020-08-24 15:50:22 UTC (rev 266061)
@@ -31,6 +31,7 @@
#include "FocusController.h"
#include "Frame.h"
#include "FrameLoader.h"
+#include "FrameLoaderClient.h"
#include "FrameView.h"
#include "HistoryController.h"
#include "HistoryItem.h"
Modified: trunk/Source/WebKit/ChangeLog (266060 => 266061)
--- trunk/Source/WebKit/ChangeLog 2020-08-24 15:42:26 UTC (rev 266060)
+++ trunk/Source/WebKit/ChangeLog 2020-08-24 15:50:22 UTC (rev 266061)
@@ -1,3 +1,12 @@
+2020-08-24 Adrian Perez de Castro
+
+Non-unified build fixes, late August 2020 edition
+https://bugs.webkit.org/show_bug.cgi?id=215768
+
+Unreviewed build fix.
+
+* UIProcess/WebURLSchemeTask.cpp: Add missing SharedBufferDataReference.h header.
+
2020-08-24 Youenn Fablet
Cocoa WebSocketTask should expose WebSocket server extensions
Modified: trunk/Source/WebKit/UIProcess/WebURLSchemeTask.cpp (266060 => 266061)
--- trunk/Source/WebKit/UIProcess/WebURLSchemeTask.cpp 2020-08-24 15:42:26 UTC (rev 266060)
+++ trunk/Source/WebKit/UIProcess/WebURLSchemeTask.cpp 2020-08-24 15:50:22 UTC (rev 266061)
@@ -27,6 +27,7 @@
#include "WebURLSchemeTask.h"
#include "APIFrameInfo.h"
+#include "SharedBufferDataReference.h"
#include
[webkit-changes] [266060] trunk/LayoutTests
Title: [266060] trunk/LayoutTests Revision 266060 Author hector_i_lo...@apple.com Date 2020-08-24 08:42:26 -0700 (Mon, 24 Aug 2020) Log Message WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance2 https://bugs.webkit.org/show_bug.cgi?id=189672 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266059 => 266060) --- trunk/LayoutTests/ChangeLog 2020-08-24 15:02:59 UTC (rev 266059) +++ trunk/LayoutTests/ChangeLog 2020-08-24 15:42:26 UTC (rev 266060) @@ -1,3 +1,12 @@ +2020-08-24 Hector Lopez + +WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance2 +https://bugs.webkit.org/show_bug.cgi?id=189672 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2020-08-24 Youenn Fablet http/tests/websocket/tests/hybi/close-on-* tests are not interoperable Modified: trunk/LayoutTests/platform/mac/TestExpectations (266059 => 266060) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-08-24 15:02:59 UTC (rev 266059) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-08-24 15:42:26 UTC (rev 266060) @@ -2209,3 +2209,6 @@ webkit.org/b/215649 accessibility/mac/select-element-selection-with-optgroups.html [ Pass Failure ] webkit.org/b/215723 fast/repaint/list-item-equal-style-change-no-repaint.html [ Pass Failure ] + +webkit.org/b/189672 [ Release ] webgl/2.0.0/conformance2/textures/canvas/tex-2d-rg32f-rg-float.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266059] trunk/LayoutTests
Title: [266059] trunk/LayoutTests Revision 266059 Author you...@apple.com Date 2020-08-24 08:02:59 -0700 (Mon, 24 Aug 2020) Log Message http/tests/websocket/tests/hybi/close-on-* tests are not interoperable https://bugs.webkit.org/show_bug.cgi?id=215692 Reviewed by Darin Adler. Before the patch, tests were not passing in Chrome, Firefox and NSURLSession WebSocket code path. This was due to the fact the web socket script is using try/finally and the closure of the connection is not raising an exception while it is for Chrome, Firefox and NSURLSession WebSocket code path. Change the WebSocket server script to more reliably send the socket message at closing time of the connection. * http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: * http/tests/websocket/tests/hybi/close-on-navigate-new-location.html: * http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: * http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html: * http/tests/websocket/tests/hybi/close-on-unload-expected.txt: * http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: * http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html: * http/tests/websocket/tests/hybi/close-on-unload.html: * http/tests/websocket/tests/hybi/close-on-unload_wsh.py: (web_socket_transfer_data): * http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: * http/tests/websocket/tests/hybi/send-after-close-on-unload.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location.html trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload.html trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py trunk/LayoutTests/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/send-after-close-on-unload.html Diff Modified: trunk/LayoutTests/ChangeLog (266058 => 266059) --- trunk/LayoutTests/ChangeLog 2020-08-24 15:02:47 UTC (rev 266058) +++ trunk/LayoutTests/ChangeLog 2020-08-24 15:02:59 UTC (rev 266059) @@ -1,3 +1,28 @@ +2020-08-24 Youenn Fablet + +http/tests/websocket/tests/hybi/close-on-* tests are not interoperable +https://bugs.webkit.org/show_bug.cgi?id=215692 + +Reviewed by Darin Adler. + +Before the patch, tests were not passing in Chrome, Firefox and NSURLSession WebSocket code path. +This was due to the fact the web socket script is using try/finally and the closure of the connection is not raising an exception +while it is for Chrome, Firefox and NSURLSession WebSocket code path. +Change the WebSocket server script to more reliably send the socket message at closing time of the connection. + +* http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: +* http/tests/websocket/tests/hybi/close-on-navigate-new-location.html: +* http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: +* http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html: +* http/tests/websocket/tests/hybi/close-on-unload-expected.txt: +* http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: +* http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html: +* http/tests/websocket/tests/hybi/close-on-unload.html: +* http/tests/websocket/tests/hybi/close-on-unload_wsh.py: +(web_socket_transfer_data): +* http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: +* http/tests/websocket/tests/hybi/send-after-close-on-unload.html: + 2020-08-24 Hector Lopez [ macOS wk1 Debug ] inspector/animation/nameChanged.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=215767 Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt (266058 => 266059) --- trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt 2020-08-24 15:02:47 UTC (rev 266058) +++ trunk/LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt 2020-08-24 15:02:59 UTC (rev 266059) @@ -5,7 +5,7 @@ PASS ws on master document is ready. PASS insert a iframe, where open ws called 'socket1' PASS 'socket1' is sent to the server. navigate
[webkit-changes] [266058] trunk/LayoutTests
Title: [266058] trunk/LayoutTests Revision 266058 Author hector_i_lo...@apple.com Date 2020-08-24 08:02:47 -0700 (Mon, 24 Aug 2020) Log Message [ macOS wk1 Debug ] inspector/animation/nameChanged.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=215767 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266057 => 266058) --- trunk/LayoutTests/ChangeLog 2020-08-24 14:57:58 UTC (rev 266057) +++ trunk/LayoutTests/ChangeLog 2020-08-24 15:02:47 UTC (rev 266058) @@ -1,3 +1,11 @@ +2020-08-24 Hector Lopez +[ macOS wk1 Debug ] inspector/animation/nameChanged.html is a flaky crash +https://bugs.webkit.org/show_bug.cgi?id=215767 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2020-08-24 Youenn Fablet Cocoa WebSocketTask should expose WebSocket server extensions Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (266057 => 266058) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-08-24 14:57:58 UTC (rev 266057) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-08-24 15:02:47 UTC (rev 266058) @@ -1135,3 +1135,5 @@ webkit.org/b/122021 media/track/track-cue-rendering-mode-changed.html [ Pass Failure ] +webkit.org/b/215767 [ Debug ] inspector/animation/nameChanged.html [ Pass Crash ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266057] trunk
Title: [266057] trunk
Revision 266057
Author you...@apple.com
Date 2020-08-24 07:57:58 -0700 (Mon, 24 Aug 2020)
Log Message
Cocoa WebSocketTask should expose WebSocket server extensions
https://bugs.webkit.org/show_bug.cgi?id=215696
Reviewed by Darin Adler.
Source/WebKit:
Send back to WebProcess the value of server WebSocket extensions.
* NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
(WebKit::WebSocketTask::didConnect):
LayoutTests:
Make the tests agnostic of using the legacy or standard deflate extension.
If using the standard deflate extensions, do not expect subparameters (this matches Chrome, Firefox and NSURLSession code path).
* http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt:
* http/tests/websocket/tests/hybi/deflate-frame-parameter.html:
* http/tests/websocket/tests/hybi/extensions-expected.txt:
* http/tests/websocket/tests/hybi/extensions.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-parameter.html
trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (266056 => 266057)
--- trunk/LayoutTests/ChangeLog 2020-08-24 14:50:31 UTC (rev 266056)
+++ trunk/LayoutTests/ChangeLog 2020-08-24 14:57:58 UTC (rev 266057)
@@ -1,3 +1,18 @@
+2020-08-24 Youenn Fablet
+
+Cocoa WebSocketTask should expose WebSocket server extensions
+https://bugs.webkit.org/show_bug.cgi?id=215696
+
+Reviewed by Darin Adler.
+
+Make the tests agnostic of using the legacy or standard deflate extension.
+If using the standard deflate extensions, do not expect subparameters (this matches Chrome, Firefox and NSURLSession code path).
+
+* http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt:
+* http/tests/websocket/tests/hybi/deflate-frame-parameter.html:
+* http/tests/websocket/tests/hybi/extensions-expected.txt:
+* http/tests/websocket/tests/hybi/extensions.html:
+
2020-08-24 Rob Buis
Make window.find not default the search string to undefined
Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt (266056 => 266057)
--- trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt 2020-08-24 14:50:31 UTC (rev 266056)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt 2020-08-24 14:57:58 UTC (rev 266057)
@@ -3,23 +3,19 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Testing query: "max_window_bits=8"
-PASS ws.extensions.search('x-webkit-deflate-frame') != -1 is true
-PASS ws.extensions.search('max_window_bits=8') != -1 is true
+PASS testResult is true
PASS event.data is firstMessage
PASS event.data is secondMessage
onclose() was called.
PASS closeEvent.wasClean is true
Testing query: "no_context_takeover"
-PASS ws.extensions.search('x-webkit-deflate-frame') != -1 is true
-PASS ws.extensions.search('no_context_takeover') != -1 is true
+PASS testResult is true
PASS event.data is firstMessage
PASS event.data is secondMessage
onclose() was called.
PASS closeEvent.wasClean is true
Testing query: "max_window_bits=8_context_takeover"
-PASS ws.extensions.search('x-webkit-deflate-frame') != -1 is true
-PASS ws.extensions.search('max_window_bits=8') != -1 is true
-PASS ws.extensions.search('no_context_takeover') != -1 is true
+PASS testResult is true
PASS event.data is firstMessage
PASS event.data is secondMessage
onclose() was called.
Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-parameter.html (266056 => 266057)
--- trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-parameter.html 2020-08-24 14:50:31 UTC (rev 266056)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-parameter.html 2020-08-24 14:57:58 UTC (rev 266057)
@@ -38,6 +38,7 @@
secondMessage += 'a';
}
+let testResult;
function doTest(queryIndex)
{
var query = queries[queryIndex];
@@ -49,10 +50,15 @@
ws._onopen_ = function(event)
{
-shouldBeTrue("ws.extensions.search('x-webkit-deflate-frame') != -1");
-parameters = query.split('&');
-for (var i = 0; i < parameters.length; ++i)
-shouldBeTrue("ws.extensions.search('" + parameters[i] + "') != -1");
+const isUsingLegacyExtension = ws.extensions.search('x-webkit-deflate-frame') != -1;
+if (isUsingLegacyExtension) {
+testResult = true;
+parameters = query.split('&');
+for (var i = 0; i < parameters.length; ++i)
+testResult = testResult && (ws.extensions.search(parameters[i]) !=
[webkit-changes] [266056] trunk/Source/WebCore
Title: [266056] trunk/Source/WebCore Revision 266056 Author za...@apple.com Date 2020-08-24 07:50:31 -0700 (Mon, 24 Aug 2020) Log Message [LFC][IFC] Use the term 'baseline' to indicate alignment baseline https://bugs.webkit.org/show_bug.cgi?id=214779 Reviewed by Antti Koivisto. This patch is in preparation for decoupling the line box and the root inline box geometry. Inline boxes have ascent/descent pairs, while line boxes have inline boxes and a baseline. * layout/displaytree/DisplayPainter.cpp: (WebCore::Display::paintInlineContent): * layout/inlineformatting/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine): * layout/inlineformatting/InlineFormattingContextQuirks.cpp: (WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const): * layout/inlineformatting/InlineLineBox.h: (WebCore::Layout::AscentAndDescent::height const): (WebCore::Layout::LineBox::ascentAndDescent const): (WebCore::Layout::LineBox::LineBox): (WebCore::Layout::LineBox::InlineBox::InlineBox): (WebCore::Layout::LineBox::setBaselineIfGreater): (WebCore::Layout::LineBox::setAscentIfGreater): (WebCore::Layout::LineBox::setDescentIfGreater): (WebCore::Layout::LineBox::baseline const): (WebCore::Layout::LineBox::resetBaseline): (WebCore::Layout::LineBox::InlineBox::Baseline::height const): Deleted. (WebCore::Layout::LineBox::setBaselineOffsetIfGreater): Deleted. (WebCore::Layout::LineBox::baselineOffset const): Deleted. (WebCore::Layout::LineBox::InlineBox::Baseline::Baseline): Deleted. (WebCore::Layout::LineBox::InlineBox::Baseline::setAscent): Deleted. (WebCore::Layout::LineBox::InlineBox::Baseline::setDescent): Deleted. (WebCore::Layout::LineBox::InlineBox::Baseline::reset): Deleted. (WebCore::Layout::LineBox::InlineBox::Baseline::ascent const): Deleted. (WebCore::Layout::LineBox::InlineBox::Baseline::descent const): Deleted. * layout/inlineformatting/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::initialize): (WebCore::Layout::LineBuilder::alignContentVertically): (WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight): (WebCore::Layout::LineBuilder::halfLeadingMetrics): * layout/inlineformatting/InlineLineBuilder.h: (WebCore::Layout::LineBuilder::baseline const): (WebCore::Layout::LineBuilder::baselineOffset const): Deleted. * layout/integration/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::paint): * layout/tableformatting/TableFormattingContext.cpp: (WebCore::Layout::TableFormattingContext::setUsedGeometryForCells): (WebCore::Layout::TableFormattingContext::setUsedGeometryForRows): (WebCore::Layout::TableFormattingContext::computeAndDistributeExtraSpace): * layout/tableformatting/TableFormattingContextGeometry.cpp: (WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell): * layout/tableformatting/TableGrid.h: (WebCore::Layout::TableGrid::Row::setBaseline): (WebCore::Layout::TableGrid::Row::baseline const): (WebCore::Layout::TableGrid::Cell::setBaseline): (WebCore::Layout::TableGrid::Cell::baseline const): (WebCore::Layout::TableGrid::Row::setBaselineOffset): Deleted. (WebCore::Layout::TableGrid::Row::baselineOffset const): Deleted. (WebCore::Layout::TableGrid::Cell::setBaselineOffset): Deleted. (WebCore::Layout::TableGrid::Cell::baselineOffset const): Deleted. * layout/tableformatting/TableLayout.cpp: (WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/displaytree/DisplayPainter.cpp trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextQuirks.cpp trunk/Source/WebCore/layout/inlineformatting/InlineLineBox.h trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.h trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp trunk/Source/WebCore/layout/tableformatting/TableFormattingContextGeometry.cpp trunk/Source/WebCore/layout/tableformatting/TableGrid.h trunk/Source/WebCore/layout/tableformatting/TableLayout.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (266055 => 266056) --- trunk/Source/WebCore/ChangeLog 2020-08-24 13:10:57 UTC (rev 266055) +++ trunk/Source/WebCore/ChangeLog 2020-08-24 14:50:31 UTC (rev 266056) @@ -1,3 +1,66 @@ +2020-08-24 Zalan Bujtas + +[LFC][IFC] Use the term 'baseline' to indicate alignment baseline +https://bugs.webkit.org/show_bug.cgi?id=214779 + +Reviewed by Antti Koivisto. + +This patch is in preparation for decoupling the line box and the root inline box geometry. +Inline boxes have ascent/descent pairs, while line boxes have inline boxes and a baseline. + +* layout/displaytree/DisplayPainter.cpp: +(WebCore::Display::paintInlineContent): +*
[webkit-changes] [266055] trunk
Title: [266055] trunk
Revision 266055
Author carlo...@webkit.org
Date 2020-08-24 06:10:57 -0700 (Mon, 24 Aug 2020)
Log Message
Unreviewed. Fix GTK4 build
Source/WebCore:
* SourcesGTK.txt:
* platform/gtk/GtkUtilities.cpp:
(WebCore::monitorWorkArea):
* platform/gtk/GtkUtilities.h:
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenAvailableRect):
Source/WebKit:
* PlatformGTK.cmake:
* UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(webkitAuthenticationDialogInitialize):
* UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:
(webkitScriptDialogImplConstructed):
(webkit_script_dialog_impl_class_init):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseEvent):
(webkit_web_view_base_class_init):
* UIProcess/API/gtk/WebKitWebViewDialog.cpp:
(webkitWebViewDialogConstructed):
(webkitWebViewDialogSetChild):
* UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp:
(webkit_inspector_window_init):
* UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:
(WebKit::WebDataListSuggestionsDropdownGtk::show):
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
Tools:
* MiniBrowser/gtk/BrowserSearchBox.c:
* MiniBrowser/gtk/BrowserWindow.c:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesGTK.txt
trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp
trunk/Source/WebCore/platform/gtk/GtkUtilities.h
trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitScriptDialogImpl.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewDialog.cpp
trunk/Source/WebKit/UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp
trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp
trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp
trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserSearchBox.c
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c
Diff
Modified: trunk/Source/WebCore/ChangeLog (266054 => 266055)
--- trunk/Source/WebCore/ChangeLog 2020-08-24 12:29:24 UTC (rev 266054)
+++ trunk/Source/WebCore/ChangeLog 2020-08-24 13:10:57 UTC (rev 266055)
@@ -1,3 +1,14 @@
+2020-08-24 Carlos Garcia Campos
+
+Unreviewed. Fix GTK4 build
+
+* SourcesGTK.txt:
+* platform/gtk/GtkUtilities.cpp:
+(WebCore::monitorWorkArea):
+* platform/gtk/GtkUtilities.h:
+* platform/gtk/PlatformScreenGtk.cpp:
+(WebCore::screenAvailableRect):
+
2020-08-24 Rob Buis
Make window.find not default the search string to undefined
Modified: trunk/Source/WebCore/SourcesGTK.txt (266054 => 266055)
--- trunk/Source/WebCore/SourcesGTK.txt 2020-08-24 12:29:24 UTC (rev 266054)
+++ trunk/Source/WebCore/SourcesGTK.txt 2020-08-24 13:10:57 UTC (rev 266055)
@@ -107,7 +107,7 @@
platform/gtk/DragDataGtk.cpp
platform/gtk/DragImageGtk.cpp
platform/gtk/GRefPtrGtk.cpp
-platform/gtk/GtkUtilities.cpp
+platform/gtk/GtkUtilities.cpp @no-unify
platform/gtk/LocalizedStringsGtk.cpp
platform/gtk/PasteboardGtk.cpp
platform/gtk/PlatformKeyboardEventGtk.cpp
Modified: trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp (266054 => 266055)
--- trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp 2020-08-24 12:29:24 UTC (rev 266054)
+++ trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp 2020-08-24 13:10:57 UTC (rev 266055)
@@ -24,6 +24,10 @@
#include
#include
+#if USE(GTK4) && PLATFORM(X11)
+#include
+#endif
+
namespace WebCore {
static IntPoint gtkWindowGetOrigin(GtkWidget* window)
@@ -187,4 +191,20 @@
return static_cast(0);
}
+void monitorWorkArea(GdkMonitor* monitor, GdkRectangle* area)
+{
+#if USE(GTK4)
+#if PLATFORM(X11)
+if (GDK_IS_X11_MONITOR(monitor)) {
+gdk_x11_monitor_get_workarea(monitor, area);
+return;
+}
+#endif
+
+gdk_monitor_get_geometry(monitor, area);
+#else
+gdk_monitor_get_workarea(monitor, area);
+#endif
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/gtk/GtkUtilities.h (266054 => 266055)
--- trunk/Source/WebCore/platform/gtk/GtkUtilities.h 2020-08-24 12:29:24 UTC (rev 266054)
+++ trunk/Source/WebCore/platform/gtk/GtkUtilities.h 2020-08-24 13:10:57 UTC (rev 266055)
@@ -55,4 +55,6 @@
WEBCORE_EXPORT GdkDragAction dragOperationToGdkDragActions(OptionSet);
WEBCORE_EXPORT GdkDragAction dragOperationToSingleGdkDragAction(OptionSet);
+void monitorWorkArea(GdkMonitor*, GdkRectangle*);
+
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp (266054 => 266055)
--- trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp 2020-08-24 12:29:24 UTC (rev 266054)
+++ trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp 2020-08-24 13:10:57
[webkit-changes] [266054] trunk
Title: [266054] trunk
Revision 266054
Author commit-qu...@webkit.org
Date 2020-08-24 05:29:24 -0700 (Mon, 24 Aug 2020)
Log Message
Make window.find not default the search string to undefined
https://bugs.webkit.org/show_bug.cgi?id=215757
Patch by Rob Buis on 2020-08-24
Reviewed by Darin Adler.
Source/WebCore:
Make window.find not default the search string to undefined, instead
use the null string. Before this change window.find() would find a
hit in a page containing the text string "undefined".
Test: fast/text/window-find.html
* page/DOMWindow.idl:
LayoutTests:
Add tests to verify window.find() does not use "undefined"
as text string. This also fixes the logic of the test to
not always output PASS at the end.
* fast/text/window-find.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text/window-find.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (266053 => 266054)
--- trunk/LayoutTests/ChangeLog 2020-08-24 09:55:13 UTC (rev 266053)
+++ trunk/LayoutTests/ChangeLog 2020-08-24 12:29:24 UTC (rev 266054)
@@ -1,3 +1,16 @@
+2020-08-24 Rob Buis
+
+Make window.find not default the search string to undefined
+https://bugs.webkit.org/show_bug.cgi?id=215757
+
+Reviewed by Darin Adler.
+
+Add tests to verify window.find() does not use "undefined"
+as text string. This also fixes the logic of the test to
+not always output PASS at the end.
+
+* fast/text/window-find.html:
+
2020-08-23 Wenson Hsieh
Programmatic selection of text in a text field causes the highlight overlay to spill out
Modified: trunk/LayoutTests/fast/text/window-find.html (266053 => 266054)
--- trunk/LayoutTests/fast/text/window-find.html 2020-08-24 09:55:13 UTC (rev 266053)
+++ trunk/LayoutTests/fast/text/window-find.html 2020-08-24 12:29:24 UTC (rev 266054)
@@ -5,11 +5,16 @@
if (window.testRunner)
testRunner.dumpAsText();
+var passed = true;
+
function fail(s) {
-document.body.innerHTML = "FAIL: " + s;
+document.body.innerHTML += "FAIL: " + s + "";
+passed = false;
}
function runTest() {
+if (window.find()) fail('found: find with no parameters');
+if (window.find('')) fail('found: empty string');
if (window.find('nonsense')) fail('found: nonsense');
if (window.find('nonsense', true)) fail('found: nonsense');
if (window.find('nonsense', false)) fail('found: nonsense');
@@ -34,7 +39,7 @@
if (!window.find('for', true, false, true)) fail('not found: for');
if (window.find('FOR', true, false, true)) fail('found: FOR');
-document.body.innerHTML = "This is a test for window.find(). SUCCESS!";
+if (passed) document.body.innerHTML = "This is a test for window.find(). SUCCESS!";
}
Modified: trunk/Source/WebCore/ChangeLog (266053 => 266054)
--- trunk/Source/WebCore/ChangeLog 2020-08-24 09:55:13 UTC (rev 266053)
+++ trunk/Source/WebCore/ChangeLog 2020-08-24 12:29:24 UTC (rev 266054)
@@ -1,3 +1,18 @@
+2020-08-24 Rob Buis
+
+Make window.find not default the search string to undefined
+https://bugs.webkit.org/show_bug.cgi?id=215757
+
+Reviewed by Darin Adler.
+
+Make window.find not default the search string to undefined, instead
+use the null string. Before this change window.find() would find a
+hit in a page containing the text string "undefined".
+
+Test: fast/text/window-find.html
+
+* page/DOMWindow.idl:
+
2020-08-24 Justin Uberti
RTCRtpSynchronizationSource.rtpTimestamp is not present
Modified: trunk/Source/WebCore/page/DOMWindow.idl (266053 => 266054)
--- trunk/Source/WebCore/page/DOMWindow.idl 2020-08-24 09:55:13 UTC (rev 266053)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2020-08-24 12:29:24 UTC (rev 266054)
@@ -159,7 +159,7 @@
[Replaceable, CustomGetter] readonly attribute Event event;
attribute DOMString defaultStatus;
[ImplementedAs=defaultStatus] attribute DOMString defaultstatus; // For compatibility with legacy content.
-boolean find(optional DOMString string = "undefined", optional boolean caseSensitive = false, optional boolean backwards = false, optional boolean wrap = false, optional boolean wholeWord = false, optional boolean searchInFrames = false, optional boolean showDialog = false); // FIXME: Using "undefined" as default parameter value is wrong.
+boolean find(optional DOMString string, optional boolean caseSensitive = false, optional boolean backwards = false, optional boolean wrap = false, optional boolean wholeWord = false, optional boolean searchInFrames = false, optional boolean showDialog = false); // FIXME: Using "undefined" as default parameter value is wrong.
[Replaceable] readonly attribute boolean offscreenBuffering;
[Replaceable] readonly attribute long screenLeft;
[Replaceable] readonly attribute long screenTop;
[webkit-changes] [266053] trunk/JSTests
Title: [266053] trunk/JSTests
Revision 266053
Author ysuz...@apple.com
Date 2020-08-24 02:55:13 -0700 (Mon, 24 Aug 2020)
Log Message
Unreviewed, ignore RangeErrors when ICU is too old
Since ICU version is different (very sad), some of tests can throw an error.
* stress/intl-language-tag.js:
(let.shouldThrow):
(let.shouldNotThrow):
(suppressErrors):
(vm.icuVersion):
(shouldThrow): Deleted.
(shouldNotThrow): Deleted.
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/intl-language-tag.js
Diff
Modified: trunk/JSTests/ChangeLog (266052 => 266053)
--- trunk/JSTests/ChangeLog 2020-08-24 09:26:58 UTC (rev 266052)
+++ trunk/JSTests/ChangeLog 2020-08-24 09:55:13 UTC (rev 266053)
@@ -1,3 +1,17 @@
+2020-08-24 Yusuke Suzuki
+
+Unreviewed, ignore RangeErrors when ICU is too old
+
+Since ICU version is different (very sad), some of tests can throw an error.
+
+* stress/intl-language-tag.js:
+(let.shouldThrow):
+(let.shouldNotThrow):
+(suppressErrors):
+(vm.icuVersion):
+(shouldThrow): Deleted.
+(shouldNotThrow): Deleted.
+
2020-08-22 Yusuke Suzuki
[JSC] Implement Intl Language Tag Parser
Modified: trunk/JSTests/stress/intl-language-tag.js (266052 => 266053)
--- trunk/JSTests/stress/intl-language-tag.js 2020-08-24 09:26:58 UTC (rev 266052)
+++ trunk/JSTests/stress/intl-language-tag.js 2020-08-24 09:55:13 UTC (rev 266053)
@@ -31,11 +31,17 @@
shouldThrow(() => Intl.getCanonicalLocales("en-US-a-xxx"), RangeError);
shouldThrow(() => Intl.getCanonicalLocales("en-US-a-ok-ok-$"), RangeError);
shouldNotThrow(() => Intl.getCanonicalLocales("en-US-a-ok-ok"));
-shouldNotThrow(() => Intl.getCanonicalLocales("en-US-0-ok1"));
+if ($vm.icuVersion() < 64)
+shouldThrow(() => Intl.getCanonicalLocales("en-US-0-ok1"), RangeError);
+else
+shouldNotThrow(() => Intl.getCanonicalLocales("en-US-0-ok1"));
shouldThrow(() => Intl.getCanonicalLocales("en-US-0"), RangeError);
shouldThrow(() => Intl.getCanonicalLocales("en-US-0-xxx"), RangeError);
shouldThrow(() => Intl.getCanonicalLocales("en-US-0-ok-ok-$"), RangeError);
-shouldNotThrow(() => Intl.getCanonicalLocales("en-US-0-ok-ok"));
+if ($vm.icuVersion() < 64)
+shouldThrow(() => Intl.getCanonicalLocales("en-US-0-ok-ok"), RangeError);
+else
+shouldNotThrow(() => Intl.getCanonicalLocales("en-US-0-ok-ok"));
shouldNotThrow(() => Intl.getCanonicalLocales("de"));
shouldNotThrow(() => Intl.getCanonicalLocales("fr"));
shouldNotThrow(() => Intl.getCanonicalLocales("ja"));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266052] trunk
Title: [266052] trunk Revision 266052 Author commit-qu...@webkit.org Date 2020-08-24 02:26:58 -0700 (Mon, 24 Aug 2020) Log Message RTCRtpSynchronizationSource.rtpTimestamp is not present https://bugs.webkit.org/show_bug.cgi?id=215722 Patch by Justin Uberti on 2020-08-24 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: Updated expectations file to indicate that tests checking for .rtpTimestamp now pass. * LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt: Source/WebCore: Updated expected results in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt. * Modules/mediastream/RTCRtpContributingSource.idl: * Modules/mediastream/RTCRtpContributingSource.idl: * Modules/mediastream/RTCRtpSynchronizationSource.idl: Minor modification to ensure JSRTCRtpSynchronizationSource.cpp gets regenerated. * Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp: (WebCore::fillRTCRtpContributingSource): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/RTCRtpContributingSource.h trunk/Source/WebCore/Modules/mediastream/RTCRtpContributingSource.idl trunk/Source/WebCore/Modules/mediastream/RTCRtpSynchronizationSource.idl trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266051 => 266052) --- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-24 01:51:56 UTC (rev 266051) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-24 09:26:58 UTC (rev 266052) @@ -1,3 +1,14 @@ +2020-08-24 Justin Uberti + +RTCRtpSynchronizationSource.rtpTimestamp is not present +https://bugs.webkit.org/show_bug.cgi?id=215722 + +Reviewed by Youenn Fablet. + +Updated expectations file to indicate that tests checking for .rtpTimestamp now pass. + +* LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt: + 2020-08-22 Emilio Cobos Álvarez Import css-content tests. Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt (266051 => 266052) --- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt 2020-08-24 01:51:56 UTC (rev 266051) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt 2020-08-24 09:26:58 UTC (rev 266052) @@ -1,13 +1,13 @@ PASS [audio] getSynchronizationSources() eventually returns a non-empty list PASS [audio] RTCRtpSynchronizationSource.timestamp is a number -FAIL [audio] RTCRtpSynchronizationSource.rtpTimestamp is a number [0, 2^32-1] assert_equals: expected "number" but got "undefined" +PASS [audio] RTCRtpSynchronizationSource.rtpTimestamp is a number [0, 2^32-1] PASS [audio] getSynchronizationSources() does not contain SSRCs older than 10 seconds FAIL [audio] RTCRtpSynchronizationSource.timestamp is comparable to performance.timeOrigin + performance.now() assert_true: expected true got false PASS [audio] RTCRtpSynchronizationSource.source is a number PASS [video] getSynchronizationSources() eventually returns a non-empty list PASS [video] RTCRtpSynchronizationSource.timestamp is a number -FAIL [video] RTCRtpSynchronizationSource.rtpTimestamp is a number [0, 2^32-1] assert_equals: expected "number" but got "undefined" +PASS [video] RTCRtpSynchronizationSource.rtpTimestamp is a number [0, 2^32-1] PASS [video] getSynchronizationSources() does not contain SSRCs older than 10 seconds FAIL [video] RTCRtpSynchronizationSource.timestamp is comparable to performance.timeOrigin + performance.now() assert_true: expected true got false PASS [video] RTCRtpSynchronizationSource.source is a number Modified: trunk/Source/WebCore/ChangeLog (266051 => 266052) --- trunk/Source/WebCore/ChangeLog 2020-08-24 01:51:56 UTC (rev 266051) +++ trunk/Source/WebCore/ChangeLog 2020-08-24 09:26:58 UTC (rev 266052) @@ -1,3 +1,19 @@ +2020-08-24 Justin Uberti + +RTCRtpSynchronizationSource.rtpTimestamp is not present +https://bugs.webkit.org/show_bug.cgi?id=215722 + +Reviewed by Youenn Fablet. + +Updated expected results in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt. + +* Modules/mediastream/RTCRtpContributingSource.idl: +* Modules/mediastream/RTCRtpContributingSource.idl: +* Modules/mediastream/RTCRtpSynchronizationSource.idl: +Minor modification to ensure JSRTCRtpSynchronizationSource.cpp gets regenerated. +*
