[webkit-changes] [266579] trunk/Source/WTF
Title: [266579] trunk/Source/WTF
Revision 266579
Author rn...@webkit.org
Date 2020-09-03 23:10:30 -0700 (Thu, 03 Sep 2020)
Log Message
GTK+ build fix attempt after r266573.
* wtf/CompactUniquePtrTuple.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CompactUniquePtrTuple.h
Diff
Modified: trunk/Source/WTF/ChangeLog (266578 => 266579)
--- trunk/Source/WTF/ChangeLog 2020-09-04 05:58:17 UTC (rev 266578)
+++ trunk/Source/WTF/ChangeLog 2020-09-04 06:10:30 UTC (rev 266579)
@@ -1,3 +1,9 @@
+2020-09-03 Ryosuke Niwa
+
+GTK+ build fix attempt after r266573.
+
+* wtf/CompactUniquePtrTuple.h:
+
2020-09-02 Ryosuke Niwa
Add CompactUniquePtrTuple
Modified: trunk/Source/WTF/wtf/CompactUniquePtrTuple.h (266578 => 266579)
--- trunk/Source/WTF/wtf/CompactUniquePtrTuple.h 2020-09-04 05:58:17 UTC (rev 266578)
+++ trunk/Source/WTF/wtf/CompactUniquePtrTuple.h 2020-09-04 06:10:30 UTC (rev 266579)
@@ -80,7 +80,7 @@
return std::unique_ptr(pointer);
}
-void setPointer(nullptr_t)
+void setPointer(std::nullptr_t)
{
deletePointer();
m_data.setPointer(nullptr);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266578] trunk/Source/WebCore
Title: [266578] trunk/Source/WebCore Revision 266578 Author rn...@webkit.org Date 2020-09-03 22:58:17 -0700 (Thu, 03 Sep 2020) Log Message Store all styling flags in m_rendererWithStyleFlags https://bugs.webkit.org/show_bug.cgi?id=216069 Reviewed by Darin Adler. This patch moves all remaining styling flags and Style::Validity from m_nodeFlags to m_rendererWithStyleFlags since CSS JIT no longer rely on these flags directly and CompactPointerTuple has been expanded to store up to 16 bits of data as opposed to just 8 bits. No new tests since there should be no behavioral change. * dom/ContainerNode.h: (WebCore::ContainerNode::directChildNeedsStyleRecalc const): (WebCore::ContainerNode::setDirectChildNeedsStyleRecalc): * dom/Element.cpp: (WebCore::Element::resetStyleRelations): * dom/Element.h: (WebCore::Element::styleAffectedByEmpty const): (WebCore::Element::descendantsAffectedByPreviousSibling const): (WebCore::Element::childrenAffectedByFirstChildRules const): (WebCore::Element::childrenAffectedByLastChildRules const): (WebCore::Element::childrenAffectedByForwardPositionalRules const): (WebCore::Element::descendantsAffectedByForwardPositionalRules const): (WebCore::Element::childrenAffectedByBackwardPositionalRules const): (WebCore::Element::descendantsAffectedByBackwardPositionalRules const): (WebCore::Element::childrenAffectedByPropertyBasedBackwardPositionalRules const): (WebCore::Element::affectsNextSiblingElementStyle const): (WebCore::Element::styleIsAffectedByPreviousSibling const): Moved here from Node. (WebCore::Element::setStyleAffectedByEmpty): (WebCore::Element::setDescendantsAffectedByPreviousSibling): (WebCore::Element::setChildrenAffectedByFirstChildRules): (WebCore::Element::setChildrenAffectedByLastChildRules): (WebCore::Element::setChildrenAffectedByForwardPositionalRules): (WebCore::Element::setDescendantsAffectedByForwardPositionalRules): (WebCore::Element::setChildrenAffectedByBackwardPositionalRules): (WebCore::Element::setDescendantsAffectedByBackwardPositionalRules): (WebCore::Element::setChildrenAffectedByPropertyBasedBackwardPositionalRules): (WebCore::Element::setAffectsNextSiblingElementStyle): (WebCore::Element::setStyleIsAffectedByPreviousSibling): * dom/Node.cpp: (WebCore::Node::adjustStyleValidity): * dom/Node.h: (WebCore::Node::styleValidity const): (WebCore::Node::styleResolutionShouldRecompositeLayer const): (WebCore::Node::childNeedsStyleRecalc const): (WebCore::Node::styleIsAffectedByPreviousSibling const): Moved to Element. (WebCore::Node::setChildNeedsStyleRecalc): (WebCore::Node::flagChildrenAffectedByFirstChildRulesFlag): Deleted. (WebCore::Node::flagChildrenAffectedByLastChildRulesFlag): Deleted. (WebCore::Node::flagAffectsNextSiblingElementStyle): Deleted. (WebCore::Node::flagStyleIsAffectedByPreviousSibling): Deleted. (WebCore::Node::NodeStyleFlag): Added. Moved most of flags from m_nodeFlags here. (WebCore::Node::DynamicStyleRelationFlag): Renamed from ElementStyleFlag. (WebCore::Node::StyleBitfields): Added. A helper struct to read and manipulate bit-fields stored in m_rendererWithStyleFlags. (WebCore::Node::StyleBitfields::fromRaw): Added. (WebCore::Node::StyleBitfields::toRaw): Added. (WebCore::Node::StyleBitfields::styleValidity const): Added. (WebCore::Node::StyleBitfields::setStyleValidity): Added. (WebCore::Node::StyleBitfields::dynamicStyleRelations const): Added. (WebCore::Node::StyleBitfields::setDynamicStyleRelation): Added. (WebCore::Node::StyleBitfields::clearDynamicStyleRelations): Added. (WebCore::Node::StyleBitfields::flags const): Added. (WebCore::Node::StyleBitfields::setFlag): Added. (WebCore::Node::StyleBitfields::clearFlag): Added. (WebCore::Node::StyleBitfields::clearDescendantsNeedStyleResolution): Added. (WebCore::Node::styleBitfields const): Added. (WebCore::Node::setStyleBitfields): Added. (WebCore::Node::hasStyleFlag const): (WebCore::Node::setStyleFlag): (WebCore::Node::clearStyleFlags): Deleted. (WebCore::Node::hasDynamicStyleRelationFlag const): Added. (WebCore::Node::setHasValidStyle): Moved here from the class declaration. (WebCore::Node::setDynamicStyleRelationFlag): Added. (WebCore::Node::clearChildNeedsStyleRecalc): Added. (WebCore::Node::setHasValidStyle): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ContainerNode.h trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.h Diff Modified: trunk/Source/WebCore/ChangeLog (266577 => 266578) --- trunk/Source/WebCore/ChangeLog 2020-09-04 05:19:20 UTC (rev 266577) +++ trunk/Source/WebCore/ChangeLog 2020-09-04 05:58:17 UTC (rev 266578) @@ -1,3 +1,83 @@ +2020-09-03 Ryosuke Niwa + +Store all styling flags in m_rendererWithStyleFlags +https://bugs.webkit.org/show_bug.cgi?id=216069 + +Reviewed by Darin Adler. + +This patch moves all remaining styling flags and Style::Validity from m_nodeFlags +to m_rendererWithStyleFlags
[webkit-changes] [266577] trunk/Source/JavaScriptCore
Title: [266577] trunk/Source/_javascript_Core Revision 266577 Author carlo...@webkit.org Date 2020-09-03 22:19:20 -0700 (Thu, 03 Sep 2020) Log Message Unreviewed. [GLIB] Add missing return There's no change in behavior because jsObjectCall() returns undefined in case of failure, but fixes a memory leak. * API/glib/JSCValue.cpp: (jsc_value_object_invoke_methodv): Modified Paths trunk/Source/_javascript_Core/API/glib/JSCValue.cpp trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/API/glib/JSCValue.cpp (266576 => 266577) --- trunk/Source/_javascript_Core/API/glib/JSCValue.cpp 2020-09-04 05:13:53 UTC (rev 266576) +++ trunk/Source/_javascript_Core/API/glib/JSCValue.cpp 2020-09-04 05:19:20 UTC (rev 266577) @@ -1010,7 +1010,7 @@ auto result = jsObjectCall(jsContext, function, JSC::JSCCallbackFunction::Type::Method, object, arguments, &exception); if (jscContextHandleExceptionIfNeeded(priv->context.get(), exception)) -jsc_value_new_undefined(priv->context.get()); +return jsc_value_new_undefined(priv->context.get()); return jscContextGetOrCreateValue(priv->context.get(), result).leakRef(); } Modified: trunk/Source/_javascript_Core/ChangeLog (266576 => 266577) --- trunk/Source/_javascript_Core/ChangeLog 2020-09-04 05:13:53 UTC (rev 266576) +++ trunk/Source/_javascript_Core/ChangeLog 2020-09-04 05:19:20 UTC (rev 266577) @@ -1,3 +1,12 @@ +2020-09-03 Carlos Garcia Campos + +Unreviewed. [GLIB] Add missing return + +There's no change in behavior because jsObjectCall() returns undefined in case of failure, but fixes a memory leak. + +* API/glib/JSCValue.cpp: +(jsc_value_object_invoke_methodv): + 2020-09-02 Yusuke Suzuki [JSC] Cache toString / valueOf / @@toPrimitive for major cases ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266576] trunk
Title: [266576] trunk Revision 266576 Author carlo...@webkit.org Date 2020-09-03 22:13:53 -0700 (Thu, 03 Sep 2020) Log Message [GTK] Unexpected User-Agent on redirect https://bugs.webkit.org/show_bug.cgi?id=191858 Reviewed by Youenn Fablet. Source/WebKit: Clear the user agent on new request after a redirect to ensure a new one is computed taking into account the quirks if needed. Also ensure quirks are applied for downloads started in the UI process. * NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Clear the user agent on new request. * UIProcess/API/glib/WebKitDownloadClient.cpp: * UIProcess/WebPageProxy.h: Add userAgentForURL(). * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::download): Use userAgentForURL() instead of userAgent(). * UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::userAgentForURL): Implement it to apply quirks if needed. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::userAgentForURL): Just return the web page user agent. * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::userAgentForURL): Ditto. * UIProcess/playstation/WebPageProxyPlayStation.cpp: (WebKit::WebPageProxy::userAgentForURL): Ditto. * UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::userAgentForURL): Ditto. * UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::userAgentForURL): Ditto. Tools: Add unit tests to check the user agent is sent in headers and preserved after a redirect for both main resource and subresources. * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: (serverCallback): (testDownloadUserAgent): (beforeAll): * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: (testUserAgent): (serverCallback): (beforeAll): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp trunk/Source/WebKit/UIProcess/API/glib/WebKitDownloadClient.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm trunk/Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp trunk/Source/WebKit/UIProcess/win/WebPageProxyWin.cpp trunk/Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (266575 => 266576) --- trunk/Source/WebKit/ChangeLog 2020-09-04 03:07:48 UTC (rev 266575) +++ trunk/Source/WebKit/ChangeLog 2020-09-04 05:13:53 UTC (rev 266576) @@ -1,3 +1,32 @@ +2020-09-03 Carlos Garcia Campos + +[GTK] Unexpected User-Agent on redirect +https://bugs.webkit.org/show_bug.cgi?id=191858 + +Reviewed by Youenn Fablet. + +Clear the user agent on new request after a redirect to ensure a new one is computed taking into account the +quirks if needed. Also ensure quirks are applied for downloads started in the UI process. + +* NetworkProcess/soup/NetworkDataTaskSoup.cpp: +(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Clear the user agent on new request. +* UIProcess/API/glib/WebKitDownloadClient.cpp: +* UIProcess/WebPageProxy.h: Add userAgentForURL(). +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::download): Use userAgentForURL() instead of userAgent(). +* UIProcess/gtk/WebPageProxyGtk.cpp: +(WebKit::WebPageProxy::userAgentForURL): Implement it to apply quirks if needed. +* UIProcess/ios/WebPageProxyIOS.mm: +(WebKit::WebPageProxy::userAgentForURL): Just return the web page user agent. +* UIProcess/mac/WebPageProxyMac.mm: +(WebKit::WebPageProxy::userAgentForURL): Ditto. +* UIProcess/playstation/WebPageProxyPlayStation.cpp: +(WebKit::WebPageProxy::userAgentForURL): Ditto. +* UIProcess/win/WebPageProxyWin.cpp: +(WebKit::WebPageProxy::userAgentForURL): Ditto. +* UIProcess/wpe/WebPageProxyWPE.cpp: +(WebKit::WebPageProxy::userAgentForURL): Ditto. + 2020-09-02 Darin Adler Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType Modified: trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp (266575 => 266576) --- trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2020-09-04 03:07:48 UTC (rev 266575) +++ trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2020-09-04 05:13:53 UTC (rev 266576) @@ -671,6 +671,10 @@ redirectedURL.setFragmentIdentifier(request.url().fragmentIdentifier()); request.setURL(redirectedURL); +// Clear the user agent to ensure a new one is computed. +auto userAgent = request.httpUserAgent(); +request.clearHTTPUserAgent(); + // Should not set
[webkit-changes] [266575] trunk/LayoutTests/imported/w3c
Title: [266575] trunk/LayoutTests/imported/w3c Revision 266575 Author cdu...@apple.com Date 2020-09-03 20:07:48 -0700 (Thu, 03 Sep 2020) Log Message Unreviewed, rebaseline flaky Web Audio tests. * web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266574 => 266575) --- trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-04 03:03:47 UTC (rev 266574) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-04 03:07:48 UTC (rev 266575) @@ -1,5 +1,22 @@ 2020-09-03 Chris Dumez +Unreviewed, rebaseline flaky Web Audio tests. + +* web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt: +* web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt: + +2020-09-03 Chris Dumez +
[webkit-changes] [266574] trunk/LayoutTests
Title: [266574] trunk/LayoutTests Revision 266574 Author rack...@apple.com Date 2020-09-03 20:03:47 -0700 (Thu, 03 Sep 2020) Log Message [ Catalina debug wk2 ] html5lib/generated/run-template-data.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=216164 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266573 => 266574) --- trunk/LayoutTests/ChangeLog 2020-09-04 03:01:34 UTC (rev 266573) +++ trunk/LayoutTests/ChangeLog 2020-09-04 03:03:47 UTC (rev 266574) @@ -1,3 +1,12 @@ +2020-09-03 Karl Rackler + +[ Catalina debug wk2 ] html5lib/generated/run-template-data.html is a flaky crash +https://bugs.webkit.org/show_bug.cgi?id=216164 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-09-03 Hector Lopez Correction for Rebasline at changeset https://trac.webkit.org/changeset/266500/webkit Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (266573 => 266574) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-09-04 03:01:34 UTC (rev 266573) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-09-04 03:03:47 UTC (rev 266574) @@ -1283,3 +1283,4 @@ webkit.org/b/216159 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html [ Pass Failure ] +webkit.org/b/216164 [ Catalina Debug ] html5lib/generated/run-template-data.html [ Pass Crash ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266573] trunk
Title: [266573] trunk
Revision 266573
Author rn...@webkit.org
Date 2020-09-03 20:01:34 -0700 (Thu, 03 Sep 2020)
Log Message
Add CompactUniquePtrTuple
https://bugs.webkit.org/show_bug.cgi?id=215936
Reviewed by Darin Adler.
Source/WTF:
Added a new template class, CompactUniquePtrTuple, which stores a pointer and up to 16-bits of
a POD type using CompactPointerTuple.
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/CompactUniquePtrTuple.h: Added.
(WTF::makeCompactUniquePtr): Added. Like makeUnique, creates an object of the specified type
and returns CompactUniquePtrTuple.
(WTF::CompactUniquePtrTuple): Added.
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Move constructor.
(WTF::CompactUniquePtrTuple::~CompactUniquePtrTuple):
(WTF::CompactUniquePtrTuple::operator=):
(WTF::CompactUniquePtrTuple::pointer):
(WTF::CompactUniquePtrTuple::moveToUniquePtr): Clears this pointer and returns unique_ptr.
(WTF::CompactUniquePtrTuple::setPointer): Like CompactPointerTuple sets the pointer component
of this tuple, freeing the old object if there is already one stored.
(WTF::CompactUniquePtrTuple::type):
(WTF::CompactUniquePtrTuple::setType):
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Constructor which takes unique_ptr&&.
(WTF::CompactUniquePtrTuple::deletePointer):
Tools:
Added basic unit tests for CompactUniquePtrTuple.
* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp: Added.
(TestWebKitAPI::A): Adde.
(TestWebKitAPI::A::A):
(TestWebKitAPI::A::~A):
(WTF_CompactUniquePtrTuple.Basic):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/CMakeLists.txt
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WTF/wtf/CompactUniquePtrTuple.h
trunk/Tools/TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (266572 => 266573)
--- trunk/Source/WTF/ChangeLog 2020-09-04 02:33:25 UTC (rev 266572)
+++ trunk/Source/WTF/ChangeLog 2020-09-04 03:01:34 UTC (rev 266573)
@@ -1,5 +1,33 @@
2020-09-02 Ryosuke Niwa
+Add CompactUniquePtrTuple
+https://bugs.webkit.org/show_bug.cgi?id=215936
+
+Reviewed by Darin Adler.
+
+Added a new template class, CompactUniquePtrTuple, which stores a pointer and up to 16-bits of
+a POD type using CompactPointerTuple.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/CMakeLists.txt:
+* wtf/CompactUniquePtrTuple.h: Added.
+(WTF::makeCompactUniquePtr): Added. Like makeUnique, creates an object of the specified type
+and returns CompactUniquePtrTuple.
+(WTF::CompactUniquePtrTuple): Added.
+(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Move constructor.
+(WTF::CompactUniquePtrTuple::~CompactUniquePtrTuple):
+(WTF::CompactUniquePtrTuple::operator=):
+(WTF::CompactUniquePtrTuple::pointer):
+(WTF::CompactUniquePtrTuple::moveToUniquePtr): Clears this pointer and returns unique_ptr.
+(WTF::CompactUniquePtrTuple::setPointer): Like CompactPointerTuple sets the pointer component
+of this tuple, freeing the old object if there is already one stored.
+(WTF::CompactUniquePtrTuple::type):
+(WTF::CompactUniquePtrTuple::setType):
+(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Constructor which takes unique_ptr&&.
+(WTF::CompactUniquePtrTuple::deletePointer):
+
+2020-09-02 Ryosuke Niwa
+
Add a variant of map which filters items to Vector.h
https://bugs.webkit.org/show_bug.cgi?id=215879
Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (266572 => 266573)
--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2020-09-04 02:33:25 UTC (rev 266572)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2020-09-04 03:01:34 UTC (rev 266573)
@@ -496,6 +496,7 @@
974CFC8D16A4F327006D5404 /* WeakPtr.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WeakPtr.h; sourceTree = ""; };
996B17841EBA441C007E10EB /* DebugUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DebugUtilities.h; sourceTree = ""; };
9B67F3F12228D5310030DE9C /* WeakHashSet.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WeakHashSet.h; sourceTree = ""; };
+ 9B96E9B324FF77B8001756C3 /* CompactUniquePtrTuple.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CompactUniquePtrTuple.h; sourceTree = ""; };
9BC70F04176C379D00101DEC /* AtomStringTable.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AtomStringTable.cpp; sourceTree = ""; };
9BD8F40A176C2AD80002D865 /* AtomStringTable.h */ = {isa = PBXFileReference; lastKnownFileType = s
[webkit-changes] [266572] trunk/LayoutTests
Title: [266572] trunk/LayoutTests
Revision 266572
Author hector_i_lo...@apple.com
Date 2020-09-03 19:33:25 -0700 (Thu, 03 Sep 2020)
Log Message
Correction for Rebasline at changeset https://trac.webkit.org/changeset/266500/webkit
Unreviewed test gardening.
* platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt: Removed.
* platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt
trunk/LayoutTests/platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (266571 => 266572)
--- trunk/LayoutTests/ChangeLog 2020-09-04 02:33:09 UTC (rev 266571)
+++ trunk/LayoutTests/ChangeLog 2020-09-04 02:33:25 UTC (rev 266572)
@@ -1,5 +1,14 @@
2020-09-03 Hector Lopez
+Correction for Rebasline at changeset https://trac.webkit.org/changeset/266500/webkit
+
+Unreviewed test gardening.
+
+* platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt: Removed.
+* platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt: Removed.
+
+2020-09-03 Hector Lopez
+
[ iOS wk2 Debug ] imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=216162
Deleted: trunk/LayoutTests/platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt (266571 => 266572)
--- trunk/LayoutTests/platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt 2020-09-04 02:33:09 UTC (rev 266571)
+++ trunk/LayoutTests/platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt 2020-09-04 02:33:25 UTC (rev 266572)
@@ -1,48 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
- RenderText {#text} at (110,5) size 4x18
-text run at (110,5) width 4: " "
- RenderText {#text} at (0,0) size 0x0
-layer at (8,10) size 110x25 clip at (10,12) size 106x21
- RenderFlexibleBox {INPUT} at (0,2) size 110x25 [bgcolor=#FF] [border: (2px inset #00)]
-layer at (11,13) size 98x19 clip at (12,14) size 96x17 scrollHeight 18
- RenderBlock {DIV} at (3,3) size 99x19 [border: (1px solid #FF)]
-RenderBlock {DIV} at (1,1) size 97x17
- RenderInline {DIV} at (0,0) size 21x19 [color=#FF]
-RenderText {#text} at (1,0) size 19x17
- text run at (1,0) width 19: "04"
- RenderInline {DIV} at (0,0) size 10x17 [color=#00]
-RenderText {#text} at (20,0) size 10x17
- text run at (20,0) width 10: "/"
- RenderInline {DIV} at (0,0) size 21x19 [color=#008000]
-RenderText {#text} at (30,0) size 19x17
- text run at (30,0) width 19: "01"
- RenderInline {DIV} at (0,0) size 10x17 [color=#00]
-RenderText {#text} at (49,0) size 10x17
- text run at (49,0) width 10: "/"
- RenderInline {DIV} at (0,0) size 39x19 [color=#FF]
-RenderText {#text} at (59,0) size 37x17
- text run at (59,0) width 37: "1976"
-layer at (122,10) size 110x25 clip at (124,12) size 106x21
- RenderFlexibleBox {INPUT} at (114,2) size 110x25 [bgcolor=#FF] [border: (2px inset #00)]
-layer at (131,13) size 98x19 clip at (132,14) size 96x17 scrollHeight 18
- RenderBlock {DIV} at (8,3) size 99x19 [border: (1px solid #FF)]
-RenderBlock {DIV} at (1,1) size 97x17
- RenderInline {DIV} at (0,0) size 21x19 [color=#FF]
-RenderText {#text} at (1,0) size 19x17
- text run at (1,0) width 19: "04"
- RenderInline {DIV} at (0,0) size 10x17 [color=#00]
-RenderText {#text} at (20,0) size 10x17
- text run at (20,0) width 10: "/"
- RenderInline {DIV} at (0,0) size 21x19 [color=#008000]
-RenderText {#text} at (30,0) size 19x17
- text run at (30,0) width 19: "01"
- RenderInline {DIV} at (0,0) size 10x17 [color=#00]
-RenderText {#text} at (49,0) size 10x17
- text run at (49,0) width 10: "/"
- RenderInline {DIV} at (0,0) size 39x19 [color=#FF]
-RenderText {#text} at (59,0) size 37x17
- text run at (59,0) width 37: "1976"
Deleted: trunk/LayoutTests/platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt (266571 => 266572)
--- trunk/LayoutTests/platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt 2020-09-04 02:33:09 UTC (rev 266571)
+++ trunk/LayoutTests/platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt 2020-09-04 02:33:25 UTC (rev 266572)
@@ -1,48 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) siz
[webkit-changes] [266571] trunk/Source/WebCore
Title: [266571] trunk/Source/WebCore Revision 266571 Author cdu...@apple.com Date 2020-09-03 19:33:09 -0700 (Thu, 03 Sep 2020) Log Message Unreviewed, fix debug build after r266570. * Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::periodicWave): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (266570 => 266571) --- trunk/Source/WebCore/ChangeLog 2020-09-04 02:00:00 UTC (rev 266570) +++ trunk/Source/WebCore/ChangeLog 2020-09-04 02:33:09 UTC (rev 266571) @@ -1,5 +1,12 @@ 2020-09-03 Chris Dumez +Unreviewed, fix debug build after r266570. + +* Modules/webaudio/BaseAudioContext.cpp: +(WebCore::BaseAudioContext::periodicWave): + +2020-09-03 Chris Dumez + Tests using OscillatorNode are flaky https://bugs.webkit.org/show_bug.cgi?id=216152 Modified: trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp (266570 => 266571) --- trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp 2020-09-04 02:00:00 UTC (rev 266570) +++ trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp 2020-09-04 02:33:09 UTC (rev 266571) @@ -1315,7 +1315,7 @@ return *m_cachedPeriodicWaveTriangle; case OscillatorType::Custom: ASSERT_NOT_REACHED(); -#if NDEBUG +#ifdef NDEBUG FALLTHROUGH; #endif case OscillatorType::Sine: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266570] trunk
Title: [266570] trunk
Revision 266570
Author cdu...@apple.com
Date 2020-09-03 19:00:00 -0700 (Thu, 03 Sep 2020)
Log Message
Tests using OscillatorNode are flaky
https://bugs.webkit.org/show_bug.cgi?id=216152
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT tests.
* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
Source/WebCore:
OscillatorNode was caching the different kind of PeriodicWaves in global static
variables. However, the PeriodicWaves are specific to a given sample rate.
As a result, we would sometimes use a cached periodic wave that was using the
wrong sample rate, leading to flaky failures. To address the issue, we now
cache the periodic waves per audio context instead.
No new tests, rebaselined existing tests and unskip them.
* Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::periodicWave):
* Modules/webaudio/BaseAudioContext.h:
* Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::setType):
* Modules/webaudio/OscillatorNode.h:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp
trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h
trunk/Source/WebCore/Modules/webaudio/OscillatorNode.cpp
trunk/Source/WebCore/Modules/webaudio/OscillatorNode.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266569 => 266570)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-04 01:54:05 UTC (rev 266569)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-04 02:00:00 UTC (rev 266570)
@@ -1,5 +1,18 @@
2020-09-03 Chris Dumez
+Tests using OscillatorNode are flaky
+https://bugs.webkit.org/show_bug.cgi?id=216152
+
+Reviewed by Darin Adler.
+
+Rebaseline WPT tests.
+
+* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
+* web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
+* web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
+
+2020-09-03 Chris Dumez
+
AudioDestinationNode.maxChannelCount always returns 0
https://bugs.webkit.org/show_bug.cgi?id=216127
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt (266569 => 266570)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt 2020-09-04 01:54:05 UTC (rev 266569)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt 2020-09-04 02:00:00 UTC (rev 266570)
@@ -24,7 +24,7 @@
PASS Test 2: modDetune.offset.setValueAtTime(0, 0) did not throw an exception.
PASS Test 2: modDetune.offset.linearRampToValueAtTime(2000, 0.078125) did not throw an exception.
PASS Test 2: modDetune.connect(srcTest.detune) did not throw an exception.
-PASS k-rate detune with input equals [0,0.3387378752231598,0.6374238729476929,0.8607419729232788,0.9822871685028076,0.9876880645751953,0.8763062953948975,0.6613117456436157,0.3681243062019348,0.03141050040721893,-0.3090170621871948,-0.6129071116447449,-0.8443278074264526,-0.9759165644645691,-0.9921145439147949,-0.8910062313079834...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
+PASS k-rate detune with input equals [0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.247789382935,-0.9394593238830566...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
PASS < [Test 2] All assertions passed. (total 8 assertions)
PASS > [Test 3] k-rate frequency input with a-rate detune
PASS Test 3: srcRef.frequency.automationRate = 'k-rate' did not throw an exception.
@@ -38,7 +38,7 @@
PASS Test 3: modFreq.offset.setValueAtTime(100, 0) did not throw an exception.
PASS Test 3: modFreq.offset.linearRampToValueAtTi
[webkit-changes] [266569] trunk/LayoutTests
Title: [266569] trunk/LayoutTests Revision 266569 Author hector_i_lo...@apple.com Date 2020-09-03 18:54:05 -0700 (Thu, 03 Sep 2020) Log Message [ iOS wk2 Debug ] imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=216162 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266568 => 266569) --- trunk/LayoutTests/ChangeLog 2020-09-04 01:11:55 UTC (rev 266568) +++ trunk/LayoutTests/ChangeLog 2020-09-04 01:54:05 UTC (rev 266569) @@ -1,3 +1,12 @@ +2020-09-03 Hector Lopez + +[ iOS wk2 Debug ] imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker.html is a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=216162 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-09-03 Patrick Angle Web Inspector fails to preview response from XHR requests Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (266568 => 266569) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-09-04 01:11:55 UTC (rev 266568) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-09-04 01:54:05 UTC (rev 266569) @@ -1879,3 +1879,5 @@ webkit.org/b/216160 css2.1/t0905-c5525-fltwidth-00-c-g.html [ Failure ] +webkit.org/b/216162 [ Debug ] imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker.html [ Pass Timeout ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266568] trunk
Title: [266568] trunk Revision 266568 Author commit-qu...@webkit.org Date 2020-09-03 18:11:55 -0700 (Thu, 03 Sep 2020) Log Message Web Inspector fails to preview response from XHR requests https://bugs.webkit.org/show_bug.cgi?id=215852 Patch by Patrick Angle on 2020-09-03 Reviewed by Devin Rousso. Source/WebCore: Test: http/tests/inspector/network/fetch-response-body.html Added workaround for 304 XHR/Fetch requests so that the mimeType and content are correctly set, otherwise the frontend does not have the information it needs to preview the response. * inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::responseReceived): Storing new ResourceData members (WebCore::NetworkResourcesData::dataForURL): Support for finding a previous non-304 response for a URL. * inspector/NetworkResourcesData.h: (WebCore::NetworkResourcesData::ResourceData::httpStatusText const): (WebCore::NetworkResourcesData::ResourceData::setHTTPStatusText): (WebCore::NetworkResourcesData::ResourceData::mimeType const): (WebCore::NetworkResourcesData::ResourceData::setMIMEType): (WebCore::NetworkResourcesData::ResourceData::responseTimestamp const): (WebCore::NetworkResourcesData::ResourceData::setResponseTimestamp): * inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::willSendRequest): Fixed issue where it was possible that we would inform the frontend that a request was of type `Other` even though we had request information indicating it was `XHR` or `Fetch`. (WebCore::InspectorNetworkAgent::didReceiveResponse): Added code path to work around underlying issue where XHR/Fetch 304s are not cached, and end up not passing necessary information to the frontend as a result. Source/WebInspectorUI: Responses with a no content error and a status code of 304 now show a `Resource has no cached content` message instead of a generic error. Also responses with empty content and no mime type now show a `Resource has no content` message. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Models/Resource.js: More consistant error handling model - previously some paths rejected on failure and some resolved with an error property. (WI.Resource.prototype.requestContent): (WI.Resource.prototype._requestContentFailure): * UserInterface/Views/ResourceContentView.js: Error messages (WI.ResourceContentView.prototype.async showGenericNoContentMessage): Text now consistent with other messages. (WI.ResourceContentView.prototype.showNoCachedContentMessage): (WI.ResourceContentView.prototype._contentAvailable): LayoutTests: Added new test cases and associated resources to test handling of `304 Not Modified` responses to XHR requests. We test both XHR for a PHP page as well as for a text file, as they behaved differently (incorrectly) before this patch. * http/tests/inspector/network/fetch-response-body-304-expected.txt: * http/tests/inspector/network/fetch-response-body-304.html: * http/tests/inspector/network/resources/.htaccess: Cache-Control header for fetch-cachable.txt * http/tests/inspector/network/resources/fetch-cachable.php: * http/tests/inspector/network/resources/fetch-cachable.txt: * platform/mac-wk1/TestExpectations: Tests rely on disk-cache which is not present in WK1 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/NetworkResourcesData.cpp trunk/Source/WebCore/inspector/NetworkResourcesData.h trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js trunk/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js Added Paths trunk/LayoutTests/http/tests/inspector/network/fetch-response-body-304-expected.txt trunk/LayoutTests/http/tests/inspector/network/fetch-response-body-304.html trunk/LayoutTests/http/tests/inspector/network/resources/.htaccess trunk/LayoutTests/http/tests/inspector/network/resources/fetch-cachable.php trunk/LayoutTests/http/tests/inspector/network/resources/fetch-cachable.txt Diff Modified: trunk/LayoutTests/ChangeLog (266567 => 266568) --- trunk/LayoutTests/ChangeLog 2020-09-04 01:03:33 UTC (rev 266567) +++ trunk/LayoutTests/ChangeLog 2020-09-04 01:11:55 UTC (rev 266568) @@ -1,3 +1,21 @@ +2020-09-03 Patrick Angle + +Web Inspector fails to preview response from XHR requests +https://bugs.webkit.org/show_bug.cgi?id=215852 + +Reviewed by Devin Rousso. + +Added new test cases and associated resources to test handling of `304 Not Modified` responses to XHR requests. +We test both XHR for a PHP page as well as for a text file, as they behaved differently (incorrectly) before +this patch. + +* http/tests/inspector/network/fetch-response-body-304-expected.txt: +* http/tests/inspec
[webkit-changes] [266567] trunk
Title: [266567] trunk Revision 266567 Author ysuz...@apple.com Date 2020-09-03 18:03:33 -0700 (Thu, 03 Sep 2020) Log Message [JSC] Cache toString / valueOf / @@toPrimitive for major cases https://bugs.webkit.org/show_bug.cgi?id=216061 Reviewed by Saam Barati. JSTests: * stress/delete-cached-to-primitive-property.js: Added. (shouldBe): (object.__proto__.Symbol.toPrimitive): * stress/delete-cached-to-string-property.js: Added. (shouldBe): (object.__proto__.toString): * stress/delete-cached-value-of-property.js: Added. (shouldBe): (shouldThrow): (object.__proto__.valueOf): * stress/hide-cached-to-primitive-property.js: Added. (shouldBe): (object.__proto__.Symbol.toPrimitive): * stress/hide-cached-to-string-property.js: Added. (shouldBe): (object.__proto__.toString): * stress/hide-cached-value-of-property.js: Added. (shouldBe): (object.__proto__.valueOf): * stress/replace-cached-to-primitive-property.js: Added. (shouldBe): (object.__proto__.Symbol.toPrimitive): * stress/replace-cached-to-string-property.js: Added. (shouldBe): (object.__proto__.toString): * stress/replace-cached-value-of-property.js: Added. (shouldBe): (object.__proto__.valueOf): Source/_javascript_Core: When toPrimitive is called, we need to look-up three properties at most to perform operation. And these special properties do not have caching mechanism at all. We found that Speedometer2/EmberJS-Debug-TodoMVC is using very much time for this property look-up. We should have caching mechanism in StructureRareData, which should be similar to @@toStringTag & Object#toString caching mechanism. This patch generalizes @@toStringTag & Object#toString caching mechanism as SpecialPropertyCache. And we accelerate toString / valueOf / @@toPrimitive look-ups in toPrimitive with this caching mechanism. This patch improved Speedometer2/EmberJS-Debug-TodoMVC by 10%. * _javascript_Core.xcodeproj/project.pbxproj: * Sources.txt: * bytecode/Watchpoint.cpp: * bytecode/Watchpoint.h: * runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.cpp: Renamed from Source/_javascript_Core/runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp. (JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::CachedSpecialPropertyAdaptiveStructureWatchpoint): (JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::install): (JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::fireInternal): * runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.h: Renamed from Source/_javascript_Core/runtime/ObjectToStringAdaptiveStructureWatchpoint.h. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildren): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::objectProtoToStringFunction const): * runtime/JSObject.cpp: (JSC::callToPrimitiveFunction): (JSC::JSObject::ordinaryToPrimitive const): (JSC::JSObject::toPrimitive const): * runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::finishCreation): (JSC::objectProtoFuncToString): * runtime/Structure.h: * runtime/StructureInlines.h: (JSC::Structure::cacheSpecialProperty): (JSC::Structure::setObjectToStringValue): Deleted. * runtime/StructureRareData.cpp: (JSC::StructureRareData::visitChildren): (JSC::StructureRareData::ensureSpecialPropertyCacheSlow): (JSC::StructureRareData::giveUpOnSpecialPropertyCache): (JSC::StructureRareData::cacheSpecialPropertySlow): (JSC::StructureRareData::clearCachedSpecialProperty): (JSC::StructureRareData::finalizeUnconditionally): (JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint): (JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::isValid const): (JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::handleFire): (JSC::StructureRareData::setObjectToStringValue): Deleted. (JSC::StructureRareData::clearObjectToStringValue): Deleted. (JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::ObjectToStringAdaptiveInferredPropertyValueWatchpoint): Deleted. (JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::isValid const): Deleted. (JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire): Deleted. * runtime/StructureRareData.h: * runtime/StructureRareDataInlines.h: (JSC::StructureRareData::cachedSpecialProperty const): (JSC::StructureRareData::canCacheSpecialProperty): (JSC::StructureRareData::ensureSpecialPropertyCache): (JSC::StructureRareData::cacheSpecialProperty): (JSC::StructureRareData::objectToStringValue const): Deleted. Modified Paths trunk/JSTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/Sources.txt trunk/Source/_javascript_Core/bytecode/Watchpoint.cpp trunk/Source/_javascript_Core/bytecode/Watchpoint.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/Object
[webkit-changes] [266566] trunk/LayoutTests/ChangeLog
Title: [266566] trunk/LayoutTests/ChangeLog Revision 266566 Author hector_i_lo...@apple.com Date 2020-09-03 18:02:12 -0700 (Thu, 03 Sep 2020) Log Message REGRESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=216160 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (266565 => 266566) --- trunk/LayoutTests/ChangeLog 2020-09-04 00:59:50 UTC (rev 266565) +++ trunk/LayoutTests/ChangeLog 2020-09-04 01:02:12 UTC (rev 266566) @@ -1,6 +1,6 @@ 2020-09-03 Hector Lopez -RERESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure +REGRESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=216160 Unreviewed test gardening. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266565] trunk/LayoutTests
Title: [266565] trunk/LayoutTests Revision 266565 Author hector_i_lo...@apple.com Date 2020-09-03 17:59:50 -0700 (Thu, 03 Sep 2020) Log Message RERESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=216160 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266564 => 266565) --- trunk/LayoutTests/ChangeLog 2020-09-04 00:58:57 UTC (rev 266564) +++ trunk/LayoutTests/ChangeLog 2020-09-04 00:59:50 UTC (rev 266565) @@ -1,3 +1,12 @@ +2020-09-03 Hector Lopez + +RERESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure +https://bugs.webkit.org/show_bug.cgi?id=216160 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-09-03 Karl Rackler [ Mac wk2 ] webgpu/whlsl/ensure-proper-variable-lifetime.html is flaky ImageOnlyFailure. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (266564 => 266565) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-09-04 00:58:57 UTC (rev 266564) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-09-04 00:59:50 UTC (rev 266565) @@ -1876,3 +1876,6 @@ webkit.org/b/216156 http/tests/misc/script-async.html [ Pass Failure ] webkit.org/b/216159 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html [ Pass Failure ] + +webkit.org/b/216160 css2.1/t0905-c5525-fltwidth-00-c-g.html [ Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266564] trunk/LayoutTests
Title: [266564] trunk/LayoutTests Revision 266564 Author rack...@apple.com Date 2020-09-03 17:58:57 -0700 (Thu, 03 Sep 2020) Log Message [ Mac wk2 ] webgpu/whlsl/ensure-proper-variable-lifetime.html is flaky ImageOnlyFailure. https://bugs.webkit.org/show_bug.cgi?id=207267 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266563 => 266564) --- trunk/LayoutTests/ChangeLog 2020-09-04 00:43:27 UTC (rev 266563) +++ trunk/LayoutTests/ChangeLog 2020-09-04 00:58:57 UTC (rev 266564) @@ -1,3 +1,12 @@ +2020-09-03 Karl Rackler + +[ Mac wk2 ] webgpu/whlsl/ensure-proper-variable-lifetime.html is flaky ImageOnlyFailure. +https://bugs.webkit.org/show_bug.cgi?id=207267 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-09-03 Hector Lopez REGRESSION(r266511): [ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html is a flaky failure Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (266563 => 266564) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-09-04 00:43:27 UTC (rev 266563) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-09-04 00:58:57 UTC (rev 266564) @@ -926,7 +926,7 @@ webkit.org/b/206627 storage/websql [ Skip ] -webkit.org/b/207267 webgpu/whlsl/ensure-proper-variable-lifetime.html [ Pass Failure ] +webkit.org/b/207267 webgpu/whlsl/ensure-proper-variable-lifetime.html [ Pass ImageOnlyFailure ] webkit.org/b/207269 [ Debug ] http/tests/websocket/tests/hybi/server-close.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266563] trunk/LayoutTests
Title: [266563] trunk/LayoutTests Revision 266563 Author hector_i_lo...@apple.com Date 2020-09-03 17:43:27 -0700 (Thu, 03 Sep 2020) Log Message REGRESSION(r266511): [ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=216159 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266562 => 266563) --- trunk/LayoutTests/ChangeLog 2020-09-04 00:13:35 UTC (rev 266562) +++ trunk/LayoutTests/ChangeLog 2020-09-04 00:43:27 UTC (rev 266563) @@ -1,3 +1,13 @@ +2020-09-03 Hector Lopez + +REGRESSION(r266511): [ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=216159 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: +* platform/mac-wk2/TestExpectations: + 2020-09-03 Karl Rackler [ Mojave+ debug wk2 ] imported/w3c/web-platform-tests/css/css-transitions/transition-base-response-002.html is a flaky failure Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (266562 => 266563) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-09-04 00:13:35 UTC (rev 266562) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-09-04 00:43:27 UTC (rev 266563) @@ -1874,3 +1874,5 @@ webkit.org/b/216126 fast/encoding/charset-replacement.html [ Failure ] webkit.org/b/216156 http/tests/misc/script-async.html [ Pass Failure ] + +webkit.org/b/216159 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (266562 => 266563) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-09-04 00:13:35 UTC (rev 266562) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-09-04 00:43:27 UTC (rev 266563) @@ -1280,3 +1280,6 @@ webkit.org/b/215875 [ Debug ] fast/layoutformattingcontext/line-heigt-when-text-is-inside-inline-container.html [ Skip ] webkit.org/b/216059 fast/scrolling/latching/latched-scroll-remove-iframe.html [ Pass Failure ] + +webkit.org/b/216159 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266562] trunk/LayoutTests
Title: [266562] trunk/LayoutTests Revision 266562 Author rack...@apple.com Date 2020-09-03 17:13:35 -0700 (Thu, 03 Sep 2020) Log Message [ Mojave+ debug wk2 ] imported/w3c/web-platform-tests/css/css-transitions/transition-base-response-002.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=216155 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266561 => 266562) --- trunk/LayoutTests/ChangeLog 2020-09-04 00:00:34 UTC (rev 266561) +++ trunk/LayoutTests/ChangeLog 2020-09-04 00:13:35 UTC (rev 266562) @@ -1,3 +1,12 @@ +2020-09-03 Karl Rackler + +[ Mojave+ debug wk2 ] imported/w3c/web-platform-tests/css/css-transitions/transition-base-response-002.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=216155 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-09-03 Hector Lopez [ iOS wk2 ] http/tests/misc/script-async.html is a flaky failure Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (266561 => 266562) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-09-04 00:00:34 UTC (rev 266561) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-09-04 00:13:35 UTC (rev 266562) @@ -1258,7 +1258,7 @@ [ arm64 ] fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not.html [ ImageOnlyFailure ] # rdar://66807554 -[ arm64 ] imported/w3c/web-platform-tests/css/css-transitions/transition-base-response-002.html [ Failure ] +webkit.org/b/216155 [ Mojave+ Debug ] imported/w3c/web-platform-tests/css/css-transitions/transition-base-response-002.html [ Pass Failure ] webkit.org/b/215581 imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getStats.https.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266561] trunk/LayoutTests
Title: [266561] trunk/LayoutTests Revision 266561 Author hector_i_lo...@apple.com Date 2020-09-03 17:00:34 -0700 (Thu, 03 Sep 2020) Log Message [ iOS wk2 ] http/tests/misc/script-async.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=216156 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (266560 => 266561) --- trunk/LayoutTests/ChangeLog 2020-09-03 22:47:33 UTC (rev 266560) +++ trunk/LayoutTests/ChangeLog 2020-09-04 00:00:34 UTC (rev 266561) @@ -1,3 +1,12 @@ +2020-09-03 Hector Lopez + +[ iOS wk2 ] http/tests/misc/script-async.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=216156 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-09-03 Frank Yang CoreImage Implementation of SourceGraphic and saturate(), hue-rotate(), grayscale() and sepia() Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (266560 => 266561) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-09-03 22:47:33 UTC (rev 266560) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-09-04 00:00:34 UTC (rev 266561) @@ -1872,3 +1872,5 @@ webkit.org/b/216124 imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html [ Failure ] webkit.org/b/216126 fast/encoding/charset-replacement.html [ Failure ] + +webkit.org/b/216156 http/tests/misc/script-async.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266560] trunk/Source/JavaScriptCore
Title: [266560] trunk/Source/_javascript_Core
Revision 266560
Author sbar...@apple.com
Date 2020-09-03 15:47:33 -0700 (Thu, 03 Sep 2020)
Log Message
Sampling profiler should dump hash as part of the top function key to prevent incorrectly grouping nameless functions together
https://bugs.webkit.org/show_bug.cgi?id=216087
Reviewed by Tadeu Zagallo.
* runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::reportTopFunctions):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (266559 => 266560)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-03 21:43:41 UTC (rev 266559)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-03 22:47:33 UTC (rev 266560)
@@ -1,3 +1,13 @@
+2020-09-03 Saam Barati
+
+Sampling profiler should dump hash as part of the top function key to prevent incorrectly grouping nameless functions together
+https://bugs.webkit.org/show_bug.cgi?id=216087
+
+Reviewed by Tadeu Zagallo.
+
+* runtime/SamplingProfiler.cpp:
+(JSC::SamplingProfiler::reportTopFunctions):
+
2020-09-03 Devin Rousso
Web Inspector: allow url breakpoints to be configured
Modified: trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp (266559 => 266560)
--- trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp 2020-09-03 21:43:41 UTC (rev 266559)
+++ trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp 2020-09-03 22:47:33 UTC (rev 266560)
@@ -1030,7 +1030,14 @@
continue;
StackFrame& frame = stackTrace.frames.first();
-String frameDescription = makeString(frame.displayName(m_vm), ':', frame.sourceID());
+String hash = ""_s;
+if (frame.semanticLocation.hasCodeBlockHash()) {
+StringPrintStream stream;
+frame.semanticLocation.codeBlockHash.dump(stream);
+hash = stream.toString();
+} else
+hash = ""_s;
+String frameDescription = makeString(frame.displayName(m_vm), '#', hash, ':', frame.sourceID());
functionCounts.add(frameDescription, 0).iterator->value++;
}
@@ -1050,7 +1057,7 @@
if (Options::samplingProfilerTopFunctionsCount()) {
out.print("\n\nSampling rate: ", m_timingInterval.microseconds(), " microseconds\n");
-out.print("Top functions as \n");
+out.print("Top functions as \n");
for (size_t i = 0; i < Options::samplingProfilerTopFunctionsCount(); i++) {
auto pair = takeMax();
if (pair.first.isEmpty())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266559] trunk
Title: [266559] trunk Revision 266559 Author cdu...@apple.com Date 2020-09-03 14:43:41 -0700 (Thu, 03 Sep 2020) Log Message AudioDestinationNode.maxChannelCount always returns 0 https://bugs.webkit.org/show_bug.cgi?id=216127 Reviewed by Eric Carlson. LayoutTests/imported/w3c: Rebaseline WPT tests now that more checks are passing. * web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/ctor-waveshaper-expected.txt: Source/WebCore: Update AudioDestinationNode.maxChannelCount to return a sane value on both macOS and iOS. Also make sure the proper exceptions are thrown when trying to create an AudioNode with an invalid number of channels. No new tests, rebaselined existing tests. * Modules/webaudio/AudioDestinationNode.h: * Modules/webaudio/AudioNode.cpp: (WebCore::AudioNode::setChannelCount): * Modules/webaudio/DefaultAudioDestinationNode.cpp: (WebCore::DefaultAudioDestinationNode::setChannelCount): * platform/audio/AudioSession.cpp: (WebCore::AudioSession::maximumNumberOfOutputChannels const): * platform/audio/AudioSession.h: * platform/audio/cocoa/AudioDestinationCocoa.cpp: (WebCore::AudioDestination::create): (WebCore::AudioDestination::maxChannelCount): * platform/audio/ios/AudioSessionIOS.mm: (WebCore::AudioSession::maximumNumberOfOutputChannels const): * platform/audio/mac/AudioSessionMac.mm: (WebCore::AudioSession::maximumNumberOfOutputChannels const): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/ctor-waveshaper-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webaudio/AudioDestinationNode.h trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp trunk/Source/WebCore/platform/audio/AudioSession.cpp trunk/Source/WebCore/platform/audio/AudioSession.h trunk/Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm trunk/Source/WebCore/platform/audio/mac/AudioSessionMac.mm Diff Modified: trunk/LayoutTests/imported/w3c/ChangeL
[webkit-changes] [266558] trunk
Title: [266558] trunk Revision 266558 Author cdu...@apple.com Date 2020-09-03 14:42:44 -0700 (Thu, 03 Sep 2020) Log Message Make AudioParam.cancelScheduledValues() standards compliant https://bugs.webkit.org/show_bug.cgi?id=216132 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Rebaseline WPT test now that it is passing. * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt: Source/WebCore: Align our implementation of AudioParam.cancelScheduledValues() with Chromium's to give us a few more passes on WPT tests. In particular, this adds special handling for when the cancelTime lands in the middle of a SetValueCurve event. No new tests, rebaselined existing test. * Modules/webaudio/AudioParamTimeline.cpp: (WebCore::AudioParamTimeline::cancelScheduledValues): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266557 => 266558) --- trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-03 21:38:50 UTC (rev 266557) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-03 21:42:44 UTC (rev 266558) @@ -1,5 +1,16 @@ 2020-09-03 Chris Dumez +Make AudioParam.cancelScheduledValues() standards compliant +https://bugs.webkit.org/show_bug.cgi?id=216132 + +Reviewed by Geoffrey Garen. + +Rebaseline WPT test now that it is passing. + +* web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt: + +2020-09-03 Chris Dumez + BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies https://bugs.webkit.org/show_bug.cgi?id=216130 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt (266557 => 266558) --- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt 2020-09-03 21:38:50 UTC (rev 266557) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt 2020-09-03 21:42:44 UTC (rev 266558) @@ -10,22 +10,10 @@ PASS gain.gain.setValueCurveAtTime(..., 0.25, 0.25) did not throw an exception. PASS gain.gain.setValueAtTime(99, 0.5) did not throw an exception. PASS gain.gain.cancelScheduledValues(0.3) did not throw an exception. -FAIL X gain.gain.setValueAtTime(3, 0.375) incorrectly threw NotSupportedError: "Events are overlapping". assert_true: expected true got false +PASS gain.gain.setValueAtTime(3, 0.375) did not throw an exception. PASS output[0:1999] contains only the constant 0.5. -FAIL X output[2000:2999]: Expected 1.5 for all values but found 1000 unexpected values: - Index Actual - [0] 1 - [1] 1 - [2] 1 - [3] 1 - ...and 996 more errors. assert_true: expected true got false -FAIL X output[3000:]: Expected 3 for all values but found 5000 unexpected values: - Index Actual - [0] -1 - [1] -1 - [2] -1 - [3] -1 - ...and 4996 more errors. assert_true: expected true got false -FAIL < [cancel1] 3 out of 11 assertions were failed. assert_true: expected true got false -FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed. assert_true: expected true got false +PASS output[2000:2999] contains only the constant 1.5. +PASS output[3000:] contains only the constant 3. +PASS < [cancel1] All assertions passed. (total 11 assertions) +PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully. Modified: trunk/Source/WebCore/ChangeLog (266557 => 266558) --- trunk/Source/WebCore/ChangeLog 2020-09-03 21:38:50 UTC (rev 266557) +++ trunk/Source/WebCore/ChangeLog 2020-09-03 21:42:44 UTC (rev 266558) @@ -1,3 +1,19 @@ +2020-09-03 Chris Dumez + +Make AudioParam.cancelScheduledValues() standards compliant +https://bugs.webkit.org/show_bug.cgi?id=216132 + +Reviewed by Geoffrey Garen. + +Align our implementation of AudioParam.cancelScheduledValues() with Chromium's +to give us a few more passes on WPT tests. In particular, this adds special +handling for when the cancelTime lands in the middle of a SetValueCurve event. + +No new tests, rebaselined existing test. + +* Modules/webaudio/AudioParamTimeline.cpp: +(WebCore::AudioParamTimeline::cancelScheduledValues): + 2020-09-02 Darin Adler Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType Modified: trunk/Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp (266557 => 266558) --- trunk/Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp 2020-09-03 21:38:50 UTC (rev 266557) +++
[webkit-changes] [266556] trunk/Source/WebCore
Title: [266556] trunk/Source/WebCore
Revision 266556
Author commit-qu...@webkit.org
Date 2020-09-03 14:35:17 -0700 (Thu, 03 Sep 2020)
Log Message
Unreviewed, reverting r266498.
https://bugs.webkit.org/show_bug.cgi?id=216143
crashes in debug
Reverted changeset:
"Simplify some editing code"
https://bugs.webkit.org/show_bug.cgi?id=216097
https://trac.webkit.org/changeset/266498
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/editing/ios/EditorIOS.mm
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/page/DOMSelection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (266555 => 266556)
--- trunk/Source/WebCore/ChangeLog 2020-09-03 21:31:21 UTC (rev 266555)
+++ trunk/Source/WebCore/ChangeLog 2020-09-03 21:35:17 UTC (rev 266556)
@@ -1,3 +1,16 @@
+2020-09-03 Commit Queue
+
+Unreviewed, reverting r266498.
+https://bugs.webkit.org/show_bug.cgi?id=216143
+
+crashes in debug
+
+Reverted changeset:
+
+"Simplify some editing code"
+https://bugs.webkit.org/show_bug.cgi?id=216097
+https://trac.webkit.org/changeset/266498
+
2020-09-03 Frank Yang
CoreImage Implementation of SourceGraphic and saturate(), hue-rotate(), grayscale() and sepia()
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (266555 => 266556)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2020-09-03 21:31:21 UTC (rev 266555)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2020-09-03 21:35:17 UTC (rev 266556)
@@ -632,11 +632,6 @@
// https://dom.spec.whatwg.org/#concept-node-replace-all
void ContainerNode::replaceAllChildrenWithNewText(const String& text)
{
-if (text.isEmpty()) {
-replaceAllChildren(nullptr);
-return;
-}
-
auto node = document().createTextNode(text);
if (!hasChildNodes()) {
// appendChildWithoutPreInsertionValidityCheck() can only throw when node has a parent and we already asserted it doesn't.
Modified: trunk/Source/WebCore/dom/Node.cpp (266555 => 266556)
--- trunk/Source/WebCore/dom/Node.cpp 2020-09-03 21:31:21 UTC (rev 266555)
+++ trunk/Source/WebCore/dom/Node.cpp 2020-09-03 21:35:17 UTC (rev 266556)
@@ -1580,9 +1580,14 @@
case PROCESSING_INSTRUCTION_NODE:
return setNodeValue(text);
case ELEMENT_NODE:
-case DOCUMENT_FRAGMENT_NODE:
-downcast(*this).replaceAllChildrenWithNewText(text);
+case DOCUMENT_FRAGMENT_NODE: {
+auto& container = downcast(*this);
+if (text.isEmpty())
+container.replaceAllChildren(nullptr);
+else
+container.replaceAllChildrenWithNewText(text);
return { };
+}
case DOCUMENT_NODE:
case DOCUMENT_TYPE_NODE:
// Do nothing.
Modified: trunk/Source/WebCore/editing/ios/EditorIOS.mm (266555 => 266556)
--- trunk/Source/WebCore/editing/ios/EditorIOS.mm 2020-09-03 21:31:21 UTC (rev 266555)
+++ trunk/Source/WebCore/editing/ios/EditorIOS.mm 2020-09-03 21:35:17 UTC (rev 266556)
@@ -329,21 +329,49 @@
clearUndoRedoOperations();
// If the element is empty already and we're not adding text, we can early return and avoid clearing/setting
-// a selection at [0, 0] and the expense involved in creating VisiblePositions.
+// a selection at [0, 0] and the expense involved in creation VisiblePositions.
if (!element.firstChild() && text.isEmpty())
return;
-// As a side effect this function sets a caret selection after the inserted content.
-// What follows is more expensive if there is a selection, so clear it since it's going to change anyway.
+// As a side effect this function sets a caret selection after the inserted content. Much of what
+// follows is more expensive if there is a selection, so clear it since it's going to change anyway.
m_document.selection().clear();
-element.replaceAllChildrenWithNewText(text);
+// clear out all current children of element
+element.removeChildren();
-VisiblePosition afterContents = createLegacyEditingPosition(&element, element.countChildNodes());
-if (afterContents.isNull())
+if (text.length()) {
+// insert new text
+// remove element from tree while doing it
+// FIXME: The element we're inserting into is often the body element. It seems strange to be removing it
+// (even if it is only temporary). ReplaceSelectionCommand doesn't bother doing this when it inserts
+// content, why should we here?
+RefPtr parent = element.parentNode();
+RefPtr siblingAfter = element.nextSibling();
+if (parent)
+element.remove();
+
+element.appendChild(createFragmentFromText(makeRangeSelectingNodeContents(element), text));
+
+// restore element to document
+if (parent) {
+if (siblingAfter)
+parent->insertBefore(element, siblingAfter.get());
+
[webkit-changes] [266553] branches/safari-610-branch
Title: [266553] branches/safari-610-branch
Revision 266553
Author alanc...@apple.com
Date 2020-09-03 14:31:12 -0700 (Thu, 03 Sep 2020)
Log Message
Cherry-pick r266156. rdar://problem/68168945
Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
https://bugs.webkit.org/show_bug.cgi?id=215719
Reviewed by Simon Fraser.
Source/WebCore:
While computing the scrollable overflow for inflow positioned (or transformed) renderers, we need to take their paint geometry into
account so that scrolling matches their final positions.
e.g.
While the inflow positioned block box is placed right below the previous sibling div, visually they overlap each other.
If these boxes happen to be in a scrollable container, the scrolling should be driven by the overlapping state (paint geometry) and not
by the layout geometry (where the 2 boxes are placed vertically after each other).
While stickily positioned boxes are also considered inflow positioned, their initial inflow layout positions contribute to the scrollable overflow
as they are not stationary boxes.
Test: fast/css/scrollable-overflow-with-sticky-positioning.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::layoutOverflowRectForPropagation const):
LayoutTests:
* fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
* fast/css/scrollable-overflow-with-sticky-positioning.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610-branch/LayoutTests/ChangeLog
branches/safari-610-branch/Source/WebCore/ChangeLog
branches/safari-610-branch/Source/WebCore/rendering/RenderBox.cpp
Added Paths
branches/safari-610-branch/LayoutTests/fast/css/scrollable-overflow-with-sticky-positioning-expected.html
branches/safari-610-branch/LayoutTests/fast/css/scrollable-overflow-with-sticky-positioning.html
Diff
Modified: branches/safari-610-branch/LayoutTests/ChangeLog (266552 => 266553)
--- branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:31:09 UTC (rev 266552)
+++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:31:12 UTC (rev 266553)
@@ -1,5 +1,55 @@
2020-09-03 Alan Coon
+Cherry-pick r266156. rdar://problem/68168945
+
+Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
+https://bugs.webkit.org/show_bug.cgi?id=215719
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+While computing the scrollable overflow for inflow positioned (or transformed) renderers, we need to take their paint geometry into
+account so that scrolling matches their final positions.
+e.g.
+
+
+
+
+While the inflow positioned block box is placed right below the previous sibling div, visually they overlap each other.
+If these boxes happen to be in a scrollable container, the scrolling should be driven by the overlapping state (paint geometry) and not
+by the layout geometry (where the 2 boxes are placed vertically after each other).
+
+While stickily positioned boxes are also considered inflow positioned, their initial inflow layout positions contribute to the scrollable overflow
+as they are not stationary boxes.
+
+Test: fast/css/scrollable-overflow-with-sticky-positioning.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::layoutOverflowRectForPropagation const):
+
+LayoutTests:
+
+* fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
+* fast/css/scrollable-overflow-with-sticky-positioning.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-08-25 Zalan Bujtas
+
+Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
+https://bugs.webkit.org/show_bug.cgi?id=215719
+
+
+Reviewed by Simon Fraser.
+
+* fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
+* fast/css/scrollable-overflow-with-sticky-positioning.html: Added.
+
+2020-09-03 Alan Coon
+
Cherry-pick r266158. rdar://problem/67812825
Web Share API Level 2 functions even when its experimental feature flag is disabled
Added: branches/safari-610-branch/LayoutTests/fast/css/scrollable-overflow-with-sticky-positioning-expected.html (0 => 266553)
--- branches/safari-610-branch/LayoutTests/fast/css/scrollable-overflow-with-sticky-positioning-expected.html (rev 0)
+++ branches/safari-610-branch/LayoutTests/fast/css/scrollable-overflow-with-sticky-positioning-expected.html 2020-09-03 21:31:12 UTC (rev 266553)
@@ -0,0 +1,40 @@
+
+#container {
+ height: 500px;
+ width
[webkit-changes] [266547] branches/safari-610-branch
Title: [266547] branches/safari-610-branch Revision 266547 Author alanc...@apple.com Date 2020-09-03 14:30:50 -0700 (Thu, 03 Sep 2020) Log Message Cherry-pick r266248. rdar://problem/67963541 Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString https://bugs.webkit.org/show_bug.cgi?id=215892 Reviewed by Tim Horton. Source/WebCore: While reverting the replaced string in `Editor::changeBackToReplacedString`, it's possible for text replacement (`Editor::replaceSelectionWithText`) to cause the text checking paragraph range to become orphaned (if for no reason other than the fact that arbitrary script can run in between). If this happens, then our attempts to expand the checking range to paragraph boundaries underneath `TextCheckingParagraph::paragraphRange` will result in a null dereference, since the boundary points computed underneath the `expandToParagraphBoundary` helper will be `nullopt`. Mitigate this (and any other potentially similar crashes) by making `expandToParagraphBoundary` robust in the case where expanding to the start and end fails, and just fall back to returning the original text checking range instead. Test: editing/mac/input/change-back-to-replaced-string.html * editing/Editor.h: * editing/TextCheckingHelper.cpp: (WebCore::expandToParagraphBoundary): See above for more details. * testing/Internals.cpp: (WebCore::Internals::changeBackToReplacedString): * testing/Internals.h: * testing/Internals.idl: Add a simple internal testing hook to change the currently selected text back to the given replaced string. LayoutTests: Add a layout test to exercise the crash. * editing/mac/input/change-back-to-replaced-string-expected.txt: Added. * editing/mac/input/change-back-to-replaced-string.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266248 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610-branch/LayoutTests/ChangeLog branches/safari-610-branch/Source/WebCore/ChangeLog branches/safari-610-branch/Source/WebCore/editing/Editor.h branches/safari-610-branch/Source/WebCore/editing/TextCheckingHelper.cpp branches/safari-610-branch/Source/WebCore/testing/Internals.cpp branches/safari-610-branch/Source/WebCore/testing/Internals.h branches/safari-610-branch/Source/WebCore/testing/Internals.idl Added Paths branches/safari-610-branch/LayoutTests/editing/mac/input/change-back-to-replaced-string-expected.txt branches/safari-610-branch/LayoutTests/editing/mac/input/change-back-to-replaced-string.html Diff Modified: branches/safari-610-branch/LayoutTests/ChangeLog (266546 => 266547) --- branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:46 UTC (rev 266546) +++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:50 UTC (rev 266547) @@ -1,5 +1,66 @@ 2020-09-03 Alan Coon +Cherry-pick r266248. rdar://problem/67963541 + +Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString +https://bugs.webkit.org/show_bug.cgi?id=215892 + + +Reviewed by Tim Horton. + +Source/WebCore: + +While reverting the replaced string in `Editor::changeBackToReplacedString`, it's possible for text replacement +(`Editor::replaceSelectionWithText`) to cause the text checking paragraph range to become orphaned (if for no +reason other than the fact that arbitrary script can run in between). If this happens, then our attempts to +expand the checking range to paragraph boundaries underneath `TextCheckingParagraph::paragraphRange` will result +in a null dereference, since the boundary points computed underneath the `expandToParagraphBoundary` helper will +be `nullopt`. + +Mitigate this (and any other potentially similar crashes) by making `expandToParagraphBoundary` robust in the +case where expanding to the start and end fails, and just fall back to returning the original text checking +range instead. + +Test: editing/mac/input/change-back-to-replaced-string.html + +* editing/Editor.h: +* editing/TextCheckingHelper.cpp: +(WebCore::expandToParagraphBoundary): + +See above for more details. + +* testing/Internals.cpp: +(WebCore::Internals::changeBackToReplacedString): +* testing/Internals.h: +* testing/Internals.idl: + +Add a simple internal testing hook to change the currently selected text back to the given replaced string. + +LayoutTests: + +Add a layout test to exercise the crash. + +* editing/mac/input/change-back-to-replaced-string-expected.txt: Added. +* editing/mac/input/change-back-to-replaced-string.html: Added. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266248 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-08-27 Wenson Hsieh + +Occ
[webkit-changes] [266551] branches/safari-610-branch
Title: [266551] branches/safari-610-branch Revision 266551 Author alanc...@apple.com Date 2020-09-03 14:31:06 -0700 (Thu, 03 Sep 2020) Log Message Cherry-pick r266158. rdar://problem/67812825 Web Share API Level 2 functions even when its experimental feature flag is disabled https://bugs.webkit.org/show_bug.cgi?id=215831 Reviewed by Darin Adler. Source/WebCore: Tests: fast/web-share/canShare-with-files-feature-disabled.html fast/web-share/share-with-files-feature-disabled.html We had a feature flag for Web Share API Level 2, but it isn't actually consulted anywhere in the implementation. * page/Navigator.cpp: (WebCore::Navigator::canShare): Rewrite canShare to be a bit more readable, and also to consult the Level 2 feature flag. (WebCore::Navigator::share): Since canShare (per the spec) will return true if we have files and other content, even if files are not shareable, check the feature flag again before loading the files. Source/WebKit: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showShareSheet): If the Web Content process sends us files, but the Level 2 feature flag is disabled, something fishy is happening, so fire a MESSAGE_CHECK. LayoutTests: * fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added. * fast/web-share/canShare-with-files-feature-disabled.html: Added. * fast/web-share/share-with-files-feature-disabled-expected.txt: Added. * fast/web-share/share-with-files-feature-disabled.html: Added. Add some tests that ensure that disabling the feature actually works. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266158 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610-branch/LayoutTests/ChangeLog branches/safari-610-branch/Source/WebCore/ChangeLog branches/safari-610-branch/Source/WebCore/page/Navigator.cpp branches/safari-610-branch/Source/WebKit/ChangeLog branches/safari-610-branch/Source/WebKit/UIProcess/WebPageProxy.cpp Added Paths branches/safari-610-branch/LayoutTests/fast/web-share/canShare-with-files-feature-disabled-expected.txt branches/safari-610-branch/LayoutTests/fast/web-share/canShare-with-files-feature-disabled.html branches/safari-610-branch/LayoutTests/fast/web-share/share-with-files-feature-disabled-expected.txt branches/safari-610-branch/LayoutTests/fast/web-share/share-with-files-feature-disabled.html Diff Modified: branches/safari-610-branch/LayoutTests/ChangeLog (266550 => 266551) --- branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:31:02 UTC (rev 266550) +++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:31:06 UTC (rev 266551) @@ -1,5 +1,63 @@ 2020-09-03 Alan Coon +Cherry-pick r266158. rdar://problem/67812825 + +Web Share API Level 2 functions even when its experimental feature flag is disabled +https://bugs.webkit.org/show_bug.cgi?id=215831 + + +Reviewed by Darin Adler. + +Source/WebCore: + +Tests: fast/web-share/canShare-with-files-feature-disabled.html + fast/web-share/share-with-files-feature-disabled.html + +We had a feature flag for Web Share API Level 2, but it isn't actually +consulted anywhere in the implementation. + +* page/Navigator.cpp: +(WebCore::Navigator::canShare): +Rewrite canShare to be a bit more readable, and also to consult the Level 2 feature flag. + +(WebCore::Navigator::share): +Since canShare (per the spec) will return true if we have files and other content, +even if files are not shareable, check the feature flag again before loading the files. + +Source/WebKit: + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::showShareSheet): +If the Web Content process sends us files, but the Level 2 feature flag is disabled, +something fishy is happening, so fire a MESSAGE_CHECK. + +LayoutTests: + +* fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added. +* fast/web-share/canShare-with-files-feature-disabled.html: Added. +* fast/web-share/share-with-files-feature-disabled-expected.txt: Added. +* fast/web-share/share-with-files-feature-disabled.html: Added. +Add some tests that ensure that disabling the feature actually works. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266158 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-08-25 Tim Horton + +Web Share API Level 2 functions even when its experimental feature flag is disabled +https://bugs.webkit.org/show_bug.cgi?id=215831 + + +Reviewed by Darin Adler. + +* fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added. +* fast/web-share/canShare-with-files-feature-disabled.html: Added. +* fast/web-share/share-with-files-feature-disabled-expected.txt: Added. +
[webkit-changes] [266552] branches/safari-610-branch/Source/WebCore
Title: [266552] branches/safari-610-branch/Source/WebCore
Revision 266552
Author alanc...@apple.com
Date 2020-09-03 14:31:09 -0700 (Thu, 03 Sep 2020)
Log Message
Cherry-pick r266144. rdar://problem/68168942
When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
https://bugs.webkit.org/show_bug.cgi?id=215821
Reviewed by Eric Carlson.
We should ignore the request to paint the current video frame when we are using airplay.
It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
will block the web process for a long time if the video is airplaying.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610-branch/Source/WebCore/ChangeLog
branches/safari-610-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: branches/safari-610-branch/Source/WebCore/ChangeLog (266551 => 266552)
--- branches/safari-610-branch/Source/WebCore/ChangeLog 2020-09-03 21:31:06 UTC (rev 266551)
+++ branches/safari-610-branch/Source/WebCore/ChangeLog 2020-09-03 21:31:09 UTC (rev 266552)
@@ -1,5 +1,38 @@
2020-09-03 Alan Coon
+Cherry-pick r266144. rdar://problem/68168942
+
+When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
+https://bugs.webkit.org/show_bug.cgi?id=215821
+
+Reviewed by Eric Carlson.
+
+We should ignore the request to paint the current video frame when we are using airplay.
+It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
+will block the web process for a long time if the video is airplaying.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-08-25 Peng Liu
+
+When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
+https://bugs.webkit.org/show_bug.cgi?id=215821
+
+Reviewed by Eric Carlson.
+
+We should ignore the request to paint the current video frame when we are using airplay.
+It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
+will block the web process for a long time if the video is airplaying.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
+
+2020-09-03 Alan Coon
+
Cherry-pick r266158. rdar://problem/67812825
Web Share API Level 2 functions even when its experimental feature flag is disabled
Modified: branches/safari-610-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (266551 => 266552)
--- branches/safari-610-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2020-09-03 21:31:06 UTC (rev 266551)
+++ branches/safari-610-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2020-09-03 21:31:09 UTC (rev 266552)
@@ -1523,7 +1523,7 @@
void MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext(GraphicsContext& context, const FloatRect& rect)
{
-if (!metaDataAvailable() || context.paintingDisabled())
+if (!metaDataAvailable() || context.paintingDisabled() || isCurrentPlaybackTargetWireless())
return;
setDelayCallbacks(true);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266546] branches/safari-610-branch/Source/WebKit
Title: [266546] branches/safari-610-branch/Source/WebKit
Revision 266546
Author alanc...@apple.com
Date 2020-09-03 14:30:46 -0700 (Thu, 03 Sep 2020)
Log Message
Cherry-pick r266240. rdar://problem/67963550
REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
https://bugs.webkit.org/show_bug.cgi?id=215861
Reviewed by Eric Carlson.
Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
here without running the +instancesRespondToSelector: check.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::updatePageScreenProperties):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610-branch/Source/WebKit/ChangeLog
branches/safari-610-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Diff
Modified: branches/safari-610-branch/Source/WebKit/ChangeLog (266545 => 266546)
--- branches/safari-610-branch/Source/WebKit/ChangeLog 2020-09-03 21:30:44 UTC (rev 266545)
+++ branches/safari-610-branch/Source/WebKit/ChangeLog 2020-09-03 21:30:46 UTC (rev 266546)
@@ -1,3 +1,38 @@
+2020-09-03 Alan Coon
+
+Cherry-pick r266240. rdar://problem/67963550
+
+REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
+https://bugs.webkit.org/show_bug.cgi?id=215861
+
+Reviewed by Eric Carlson.
+
+Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
+AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
+in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
+here without running the +instancesRespondToSelector: check.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::updatePageScreenProperties):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-08-27 Jer Noble
+
+REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
+https://bugs.webkit.org/show_bug.cgi?id=215861
+
+Reviewed by Eric Carlson.
+
+Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
+AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
+in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
+here without running the +instancesRespondToSelector: check.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::updatePageScreenProperties):
+
2020-09-01 Alan Coon
Cherry-pick r266301. rdar://problem/68177648
Modified: branches/safari-610-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (266545 => 266546)
--- branches/safari-610-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2020-09-03 21:30:44 UTC (rev 266545)
+++ branches/safari-610-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2020-09-03 21:30:46 UTC (rev 266546)
@@ -1016,14 +1016,9 @@
#if PLATFORM(MAC)
void WebProcess::updatePageScreenProperties()
{
-#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE)
-// If AVPlayer.videoRangeOverride support is present, there's no need to override HDR mode
-// at the MediaToolbox level, as the MediaToolbox override functionality is both duplicative
-// and process global.
-if (PAL::isAVFoundationFrameworkAvailable() && [PAL::getAVPlayerClass() instancesRespondToSelector:@selector(setVideoRangeOverride:)])
-return;
-#endif
-
+#if !HAVE(AVPLAYER_VIDEORANGEOVERRIDE)
+// Only override HDR support at the MediaToolbox level if AVPlayer.videoRangeOverride support is
+// not present, as the MediaToolbox override functionality is both duplicative and process global.
if (hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)) {
setShouldOverrideScreenSupportsHighDynamicRange(false, false);
return;
@@ -1033,6 +1028,7 @@
return screenSupportsHighDynamicRange(page->mainFrameView());
});
setShouldOverrideScreenSupportsHighDynamicRange(true, allPagesAreOnHDRScreens);
+#endif
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailma
[webkit-changes] [266555] branches/safari-610-branch
Title: [266555] branches/safari-610-branch Revision 266555 Author alanc...@apple.com Date 2020-09-03 14:31:21 -0700 (Thu, 03 Sep 2020) Log Message Cherry-pick r266265. rdar://problem/68168939 [iOS] provide a way to get previously inserted alternatives for the selected text https://bugs.webkit.org/show_bug.cgi?id=215816 Reviewed by Darin Adler. Source/WebCore: * editing/cocoa/AlternativeTextUIController.h: * editing/cocoa/AlternativeTextUIController.mm: (WebCore::AlternativeTextUIController::alternativesForContext): Return the raw `NSTextAlternatives *` and let the caller create the `Vector` if they need to so that callers that don't can use the actual `NSTextAlternatives *`. * editing/Editor.h: * editing/Editor.cpp: (WebCore::Editor::applyDictationAlternative): Added. (WebCore::Editor::applyDictationAlternativelternative): Deleted. * page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Drive-by: fix typo. Source/WebKit: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView alternativesForSelectedText]): * UIProcess/WebPageProxy.h: * UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::platformDictationAlternatives): Added. * UIProcess/PageClient.h: * UIProcess/Cocoa/PageClientImplCocoa.h: * UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::dictationAlternatives): (WebKit::PageClientImplCocoa::platformDictationAlternatives): Added. Provide a way to get the raw `NSTextAlternatives *` for a given `WebCore::DictationContext`. * Shared/EditorState.h: * Shared/EditorState.cpp: (WebKit::EditorState::PostLayoutData::encode const): (WebKit::EditorState::PostLayoutData::decode): * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getPlatformEditorState const): Include a `Vector` as part of the `EditorState` that contains all of the `WebCore::DictationContext` that exist in the currently selected range (or the range of the word containing the cursor if nothing is selected). * Platform/spi/ios/UIKitSPI.h: Source/WebKitLegacy/mac: * WebView/WebView.mm: (-[WebView _dictationAlternatives:]): Create a `Vector` from the returned `NSTextAlternatives *` now that the member `WebCore::AlternativeTextUIController::alternativesForContext` returns it. Tools: * TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm: (InsertTextAlternatives.Simple): * TestWebKitAPI/ios/UIKitSPI.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266265 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610-branch/Source/WebCore/ChangeLog branches/safari-610-branch/Source/WebCore/editing/Editor.cpp branches/safari-610-branch/Source/WebCore/editing/Editor.h branches/safari-610-branch/Source/WebCore/editing/cocoa/AlternativeTextUIController.h branches/safari-610-branch/Source/WebCore/editing/cocoa/AlternativeTextUIController.mm branches/safari-610-branch/Source/WebCore/page/ContextMenuController.cpp branches/safari-610-branch/Source/WebKit/ChangeLog branches/safari-610-branch/Source/WebKit/Platform/spi/ios/UIKitSPI.h branches/safari-610-branch/Source/WebKit/Shared/EditorState.cpp branches/safari-610-branch/Source/WebKit/Shared/EditorState.h branches/safari-610-branch/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h branches/safari-610-branch/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm branches/safari-610-branch/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm branches/safari-610-branch/Source/WebKit/UIProcess/PageClient.h branches/safari-610-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-610-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm branches/safari-610-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm branches/safari-610-branch/Source/WebKitLegacy/mac/ChangeLog branches/safari-610-branch/Source/WebKitLegacy/mac/WebView/WebView.mm branches/safari-610-branch/Tools/ChangeLog branches/safari-610-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm branches/safari-610-branch/Tools/TestWebKitAPI/ios/UIKitSPI.h Diff Modified: branches/safari-610-branch/Source/WebCore/ChangeLog (266554 => 266555) --- branches/safari-610-branch/Source/WebCore/ChangeLog 2020-09-03 21:31:15 UTC (rev 266554) +++ branches/safari-610-branch/Source/WebCore/ChangeLog 2020-09-03 21:31:21 UTC (rev 266555) @@ -1,5 +1,97 @@ 2020-09-03 Alan Coon +Cherry-pick r266265. rdar://problem/68168939 + +[iOS] provide a way to get previously inserted alternatives for the selected text +https://bugs.webkit.org/show_bug.cgi?id=215816 + + +Reviewed by Darin Adler. + +Source/WebCore: + +* editing/cocoa/AlternativeTextUIController.h: +* editing/cocoa/AlternativeTextUIController.mm: +(WebCore::AlternativeTextUIController::alternativesForCo
[webkit-changes] [266550] branches/safari-610-branch
Title: [266550] branches/safari-610-branch Revision 266550 Author alanc...@apple.com Date 2020-09-03 14:31:02 -0700 (Thu, 03 Sep 2020) Log Message Cherry-pick r266151. rdar://problem/68168950 Web Share API can share non-HTTP(S) URLs https://bugs.webkit.org/show_bug.cgi?id=215823 Reviewed by Wenson Hsieh. Source/WebCore: Test: fast/web-share/share-disallows-file-urls.html * page/Navigator.cpp: (WebCore::shareableURLForShareData): (WebCore::Navigator::canShare): (WebCore::Navigator::share): Factor out the code to complete and check the scheme of the URL. Make canShare() return NO and share() fail for non-HTTP(S) or data: URLs. Source/WebKit: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showShareSheet): Ensure that only HTTP family or data: URLs are shared. LayoutTests: * fast/web-share/share-disallows-file-urls-expected.txt: Added. * fast/web-share/share-disallows-file-urls.html: Added. * fast/web-share/share-transient-activation-expired.html: * fast/web-share/share-transient-activation.html: * fast/web-share/share.html: Add a test that ensures that sharing a non-HTTP-family URL fails, and fix the existing tests to share HTTP-family URLs. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266151 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610-branch/LayoutTests/ChangeLog branches/safari-610-branch/LayoutTests/fast/web-share/share-transient-activation-expired.html branches/safari-610-branch/LayoutTests/fast/web-share/share-transient-activation.html branches/safari-610-branch/LayoutTests/fast/web-share/share.html branches/safari-610-branch/Source/WebCore/ChangeLog branches/safari-610-branch/Source/WebCore/page/Navigator.cpp branches/safari-610-branch/Source/WebKit/ChangeLog branches/safari-610-branch/Source/WebKit/UIProcess/WebPageProxy.cpp Added Paths branches/safari-610-branch/LayoutTests/fast/web-share/share-disallows-file-urls-expected.txt branches/safari-610-branch/LayoutTests/fast/web-share/share-disallows-file-urls.html Diff Modified: branches/safari-610-branch/LayoutTests/ChangeLog (266549 => 266550) --- branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:58 UTC (rev 266549) +++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:31:02 UTC (rev 266550) @@ -1,5 +1,61 @@ 2020-09-03 Alan Coon +Cherry-pick r266151. rdar://problem/67812825 + +Web Share API can share non-HTTP(S) URLs +https://bugs.webkit.org/show_bug.cgi?id=215823 + + +Reviewed by Wenson Hsieh. + +Source/WebCore: + +Test: fast/web-share/share-disallows-file-urls.html + +* page/Navigator.cpp: +(WebCore::shareableURLForShareData): +(WebCore::Navigator::canShare): +(WebCore::Navigator::share): +Factor out the code to complete and check the scheme of the URL. +Make canShare() return NO and share() fail for non-HTTP(S) or data: URLs. + +Source/WebKit: + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::showShareSheet): +Ensure that only HTTP family or data: URLs are shared. + +LayoutTests: + +* fast/web-share/share-disallows-file-urls-expected.txt: Added. +* fast/web-share/share-disallows-file-urls.html: Added. +* fast/web-share/share-transient-activation-expired.html: +* fast/web-share/share-transient-activation.html: +* fast/web-share/share.html: +Add a test that ensures that sharing a non-HTTP-family URL fails, +and fix the existing tests to share HTTP-family URLs. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266151 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-08-25 Tim Horton + +Web Share API can share non-HTTP(S) URLs +https://bugs.webkit.org/show_bug.cgi?id=215823 + + +Reviewed by Wenson Hsieh. + +* fast/web-share/share-disallows-file-urls-expected.txt: Added. +* fast/web-share/share-disallows-file-urls.html: Added. +* fast/web-share/share-transient-activation-expired.html: +* fast/web-share/share-transient-activation.html: +* fast/web-share/share.html: +Add a test that ensures that sharing a non-HTTP-family URL fails, +and fix the existing tests to share HTTP-family URLs. + +2020-09-03 Alan Coon + Cherry-pick r266292. rdar://problem/67963525 Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results) Added: branches/safari-610-branch/LayoutTests/fast/web-share/share-disallows-file-urls-expected.txt (0 => 266550) --- branches/safari-610-branch/LayoutTests/fast/web-share/share-disallows-file-urls-expected.txt (rev 0) +++ branches/safari-610-branch/LayoutTests/fast/web-share/share-disallows-file-urls-expected.txt 2020-09-03 21:31:02 UTC (rev 266550) @@ -
[webkit-changes] [266554] branches/safari-610-branch/Source/WebCore
Title: [266554] branches/safari-610-branch/Source/WebCore
Revision 266554
Author alanc...@apple.com
Date 2020-09-03 14:31:15 -0700 (Thu, 03 Sep 2020)
Log Message
Cherry-pick r266218. rdar://problem/68168930
REGRESSION: touchbar controls don't reflect video state in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=215873
Reviewed by Eric Carlson.
* platform/mac/WebPlaybackControlsManager.h:
* platform/mac/WebPlaybackControlsManager.mm:
(-[WebPlaybackControlsManager setPlaying:]):
(-[WebPlaybackControlsManager isPlaying]):
Create an actual ivar `_playing` for holding the play/pause state. This is needed because
`AVTouchBarScrubber` uses KVO to update the state of the play/pause button whenever the
related video controller (in this case `AVTouchBarPlaybackControlsControlling`) changes
using an `NSValueBinding`. KVO needs an actual ivar in order to function properly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610-branch/Source/WebCore/ChangeLog
branches/safari-610-branch/Source/WebCore/platform/mac/WebPlaybackControlsManager.h
branches/safari-610-branch/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm
Diff
Modified: branches/safari-610-branch/Source/WebCore/ChangeLog (266553 => 266554)
--- branches/safari-610-branch/Source/WebCore/ChangeLog 2020-09-03 21:31:12 UTC (rev 266553)
+++ branches/safari-610-branch/Source/WebCore/ChangeLog 2020-09-03 21:31:15 UTC (rev 266554)
@@ -1,5 +1,44 @@
2020-09-03 Alan Coon
+Cherry-pick r266218. rdar://problem/68168930
+
+REGRESSION: touchbar controls don't reflect video state in fullscreen
+https://bugs.webkit.org/show_bug.cgi?id=215873
+
+
+Reviewed by Eric Carlson.
+
+* platform/mac/WebPlaybackControlsManager.h:
+* platform/mac/WebPlaybackControlsManager.mm:
+(-[WebPlaybackControlsManager setPlaying:]):
+(-[WebPlaybackControlsManager isPlaying]):
+Create an actual ivar `_playing` for holding the play/pause state. This is needed because
+`AVTouchBarScrubber` uses KVO to update the state of the play/pause button whenever the
+related video controller (in this case `AVTouchBarPlaybackControlsControlling`) changes
+using an `NSValueBinding`. KVO needs an actual ivar in order to function properly.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-08-26 Devin Rousso
+
+REGRESSION: touchbar controls don't reflect video state in fullscreen
+https://bugs.webkit.org/show_bug.cgi?id=215873
+
+
+Reviewed by Eric Carlson.
+
+* platform/mac/WebPlaybackControlsManager.h:
+* platform/mac/WebPlaybackControlsManager.mm:
+(-[WebPlaybackControlsManager setPlaying:]):
+(-[WebPlaybackControlsManager isPlaying]):
+Create an actual ivar `_playing` for holding the play/pause state. This is needed because
+`AVTouchBarScrubber` uses KVO to update the state of the play/pause button whenever the
+related video controller (in this case `AVTouchBarPlaybackControlsControlling`) changes
+using an `NSValueBinding`. KVO needs an actual ivar in order to function properly.
+
+2020-09-03 Alan Coon
+
Cherry-pick r266156. rdar://problem/68168945
Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
Modified: branches/safari-610-branch/Source/WebCore/platform/mac/WebPlaybackControlsManager.h (266553 => 266554)
--- branches/safari-610-branch/Source/WebCore/platform/mac/WebPlaybackControlsManager.h 2020-09-03 21:31:12 UTC (rev 266553)
+++ branches/safari-610-branch/Source/WebCore/platform/mac/WebPlaybackControlsManager.h 2020-09-03 21:31:15 UTC (rev 266554)
@@ -51,6 +51,7 @@
RetainPtr _currentAudioTouchBarMediaSelectionOption;
RetainPtr> _legibleTouchBarMediaSelectionOptions;
RetainPtr _currentLegibleTouchBarMediaSelectionOption;
+BOOL _playing;
float _rate;
BOOL _canTogglePlayback;
Modified: branches/safari-610-branch/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm (266553 => 266554)
--- branches/safari-610-branch/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm 2020-09-03 21:31:12 UTC (rev 266553)
+++ branches/safari-610-branch/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm 2020-09-03 21:31:15 UTC (rev 266554)
@@ -288,22 +288,27 @@
- (void)setPlaying:(BOOL)playing
{
-if (!_playbackSessionInterfaceMac || !_playbackSessionInterfaceMac->playbackSessionModel())
+if (playing != _playing) {
+[self willChangeValueForKey:@"playing"];
+_playing = playing;
+[self didChangeValueForKey:@"playing"];
+}
+
+if (!_playbackSessionInterfaceMac)
return;
-BOOL isCurrentlyPlayi
[webkit-changes] [266549] branches/safari-610-branch
Title: [266549] branches/safari-610-branch Revision 266549 Author alanc...@apple.com Date 2020-09-03 14:30:58 -0700 (Thu, 03 Sep 2020) Log Message Cherry-pick r266292. rdar://problem/67963525 Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results) https://bugs.webkit.org/show_bug.cgi?id=215641 Reviewed by Tim Horton. Source/WebCore: There are two parts to this fix. First, findEnclosingScrollableContainer() needs to use the same vertical-biasing delta fixup that we use in other places, to bias towards vertical scrolling. Second, when we've determined that the main frame should perform the scroll and dispatch the wheel event to the scrolling thread, we used to hit-test from scratch on the scrolling thread and and try to send the event to a scroller which we already know should not handle it. So pass along a target ScrollingNodeID, and start the scrolling thread handling from that node. Test: fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html * page/FrameView.cpp: (WebCore::FrameView::wheelEvent): * page/mac/EventHandlerMac.mm: (WebCore::findEnclosingScrollableContainer): * page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::handleWheelEvent): * page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::handleWheelEvent): (WebCore::ScrollingTree::handleWheelEventWithNode): * page/scrolling/ScrollingTree.h: * page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread): * page/scrolling/ThreadedScrollingTree.h: * page/scrolling/mac/ScrollingCoordinatorMac.h: * page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::handleWheelEvent): * page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp: (WebCore::ScrollingCoordinatorNicosia::handleWheelEvent): * page/scrolling/nicosia/ScrollingCoordinatorNicosia.h: LayoutTests: After this change iframe-latch-small-deltas.html would time-out because WheelEventTestMonitor would get stuck with a "content scrolling" defer region, due to begin/end wheel events not getting both sent to the iframe. But the test was actually broken; logging shows that it reset latching state anyway, and it's not testing the shipping configuration of async iframe scrolling. So fix the test to use async iframe scrolling, and to avoid rubber-banding, so that latching is not cleared due to elapsed time. * fast/scrolling/latching/iframe-latch-small-deltas-expected.txt: * fast/scrolling/latching/iframe-latch-small-deltas.html: * fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt: Added. * fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266292 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610-branch/LayoutTests/ChangeLog branches/safari-610-branch/LayoutTests/fast/scrolling/latching/iframe-latch-small-deltas-expected.txt branches/safari-610-branch/LayoutTests/fast/scrolling/latching/iframe-latch-small-deltas.html branches/safari-610-branch/LayoutTests/platform/mac-wk1/fast/scrolling/latching/iframe-latch-small-deltas-expected.txt branches/safari-610-branch/Source/WebCore/ChangeLog branches/safari-610-branch/Source/WebCore/page/FrameView.cpp branches/safari-610-branch/Source/WebCore/page/mac/EventHandlerMac.mm branches/safari-610-branch/Source/WebCore/page/scrolling/ScrollingCoordinator.h branches/safari-610-branch/Source/WebCore/page/scrolling/ScrollingTree.cpp branches/safari-610-branch/Source/WebCore/page/scrolling/ScrollingTree.h branches/safari-610-branch/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp branches/safari-610-branch/Source/WebCore/page/scrolling/ThreadedScrollingTree.h branches/safari-610-branch/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h branches/safari-610-branch/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm branches/safari-610-branch/Source/WebCore/page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp branches/safari-610-branch/Source/WebCore/page/scrolling/nicosia/ScrollingCoordinatorNicosia.h Added Paths branches/safari-610-branch/LayoutTests/fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt branches/safari-610-branch/LayoutTests/fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html Diff Modified: branches/safari-610-branch/LayoutTests/ChangeLog (266548 => 266549) --- branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:53 UTC (rev 266548) +++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:58 UTC (rev 266549) @@ -1,5 +1,84 @@ 2020-09-03 Alan Coon +Cherry-pick r266292. rdar://problem/67963525 + +Vertical scrolling gets stuck when a horizontal scroller is under the mouse (googl
[webkit-changes] [266544] branches/safari-610-branch
Title: [266544] branches/safari-610-branch
Revision 266544
Author alanc...@apple.com
Date 2020-09-03 14:30:40 -0700 (Thu, 03 Sep 2020)
Log Message
Cherry-pick r266189. rdar://problem/68145721
Flickering on sedona.dev
https://bugs.webkit.org/show_bug.cgi?id=215141
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/canvas/webgl/compositing-without-drawing.html
Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.
The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only
mark if we're rendering to the default framebuffer.
LayoutTests:
Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.
* fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
* fast/canvas/webgl/compositing-without-drawing.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610-branch/LayoutTests/ChangeLog
branches/safari-610-branch/Source/WebCore/ChangeLog
branches/safari-610-branch/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
Added Paths
branches/safari-610-branch/LayoutTests/fast/canvas/webgl/compositing-without-drawing-expected.html
branches/safari-610-branch/LayoutTests/fast/canvas/webgl/compositing-without-drawing.html
Diff
Modified: branches/safari-610-branch/LayoutTests/ChangeLog (266543 => 266544)
--- branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:37 UTC (rev 266543)
+++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:40 UTC (rev 266544)
@@ -1,3 +1,53 @@
+2020-09-03 Alan Coon
+
+Cherry-pick r266189. rdar://problem/68145721
+
+Flickering on sedona.dev
+https://bugs.webkit.org/show_bug.cgi?id=215141
+
+Reviewed by Darin Adler.
+
+Source/WebCore:
+
+Test: fast/canvas/webgl/compositing-without-drawing.html
+
+Our logic to determine if a canvas needs to be "repainted"
+was over-zealous for WebGL. We were marking any context
+that called draw commands as dirty, but they could in fact
+be rendering to an offscreen texture/framebuffer. Then, when
+it came time to composite, we'd happily swap buffers and
+show something that had never been rendered to.
+
+The fix is simply to ignore any of the dirtying notifications
+when we are not bound to the default (canvas) framebuffer.
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only
+mark if we're rendering to the default framebuffer.
+
+LayoutTests:
+
+Test that serves an animation frame that touches
+WebGL, but not in a way that requires a recomposite.
+
+* fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
+* fast/canvas/webgl/compositing-without-drawing.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-08-26 Dean Jackson
+
+Flickering on sedona.dev
+https://bugs.webkit.org/show_bug.cgi?id=215141
+
+Reviewed by Darin Adler.
+
+Test that serves an animation frame that touches
+WebGL, but not in a way that requires a recomposite.
+
+* fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
+* fast/canvas/webgl/compositing-without-drawing.html: Added.
+
2020-09-01 Alan Coon
Cherry-pick r266280. rdar://problem/68177624
Added: branches/safari-610-branch/LayoutTests/fast/canvas/webgl/compositing-without-drawing-expected.html (0 => 266544)
--- branches/safari-610-branch/LayoutTests/fast/canvas/webgl/compositing-without-drawing-expected.html (rev 0)
+++ branches/safari-610-branch/LayoutTests/fast/canvas/webgl/compositing-without-drawing-expected.html 2020-09-03 21:30:40 UTC (rev 266544)
@@ -0,0 +1,101 @@
+
+body {
+font-family: monospace;
+}
+canvas {
+width: 10px;
+height: 10px;
+}
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+}
+
+const WIDTH = 10;
+const HEIGHT = 10;
+
+const COLORS = [
+[0, 0, 1, 1],
+[0, 1, 1, 1],
+[0, 0.5, 0, 1],
+[1, 0, 1, 1],
+[1, 1, 0.5, 1],
+[0.5, 0, 1, 1],
+[0.5, 0.5, 0.5, 1],
+[0.5, 0.5, 1, 1],
+[0.25, 1, 1, 1],
+[0, 1, 0, 1]
+];
+
+let gl;
+let currentFrame = 0;
[webkit-changes] [266548] branches/safari-610-branch
Title: [266548] branches/safari-610-branch Revision 266548 Author alanc...@apple.com Date 2020-09-03 14:30:53 -0700 (Thu, 03 Sep 2020) Log Message Cherry-pick r266262. rdar://problem/67963581 Scrolling on select element doesn't work after scrolling the page https://bugs.webkit.org/show_bug.cgi?id=215900 Source/WebCore: Reviewed by Tim Horton. The scrolling thread could use a node that was latched some time ago; we need to check the freshness of the latched node before using it. Test: fast/scrolling/latching/latching-stuck-to-main-page.html * page/scrolling/ScrollingTreeLatchingController.cpp: (WebCore::ScrollingTreeLatchingController::receivedWheelEvent): (WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): (WebCore::ScrollingTreeLatchingController::latchedNodeIsRelevant const): * page/scrolling/ScrollingTreeLatchingController.h: LayoutTests: Reviewed by Tim Horton. * fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added. * fast/scrolling/latching/latching-stuck-to-main-page.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266262 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610-branch/LayoutTests/ChangeLog branches/safari-610-branch/Source/WebCore/ChangeLog branches/safari-610-branch/Source/WebCore/page/scrolling/ScrollingTreeLatchingController.cpp branches/safari-610-branch/Source/WebCore/page/scrolling/ScrollingTreeLatchingController.h Added Paths branches/safari-610-branch/LayoutTests/fast/scrolling/latching/latching-stuck-to-main-page-expected.txt branches/safari-610-branch/LayoutTests/fast/scrolling/latching/latching-stuck-to-main-page.html Diff Modified: branches/safari-610-branch/LayoutTests/ChangeLog (266547 => 266548) --- branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:50 UTC (rev 266547) +++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-03 21:30:53 UTC (rev 266548) @@ -1,5 +1,48 @@ 2020-09-03 Alan Coon +Cherry-pick r266262. rdar://problem/67963581 + +Scrolling on select element doesn't work after scrolling the page +https://bugs.webkit.org/show_bug.cgi?id=215900 +Source/WebCore: + + + +Reviewed by Tim Horton. + +The scrolling thread could use a node that was latched some time ago; we need to +check the freshness of the latched node before using it. + +Test: fast/scrolling/latching/latching-stuck-to-main-page.html + +* page/scrolling/ScrollingTreeLatchingController.cpp: +(WebCore::ScrollingTreeLatchingController::receivedWheelEvent): +(WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): +(WebCore::ScrollingTreeLatchingController::latchedNodeIsRelevant const): +* page/scrolling/ScrollingTreeLatchingController.h: + +LayoutTests: + +Reviewed by Tim Horton. + +* fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added. +* fast/scrolling/latching/latching-stuck-to-main-page.html: Added. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266262 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-08-27 Simon Fraser + +Scrolling on select element doesn't work after scrolling the page +https://bugs.webkit.org/show_bug.cgi?id=215900 + +Reviewed by Tim Horton. + +* fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added. +* fast/scrolling/latching/latching-stuck-to-main-page.html: Added. + +2020-09-03 Alan Coon + Cherry-pick r266248. rdar://problem/67963541 Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString Added: branches/safari-610-branch/LayoutTests/fast/scrolling/latching/latching-stuck-to-main-page-expected.txt (0 => 266548) --- branches/safari-610-branch/LayoutTests/fast/scrolling/latching/latching-stuck-to-main-page-expected.txt (rev 0) +++ branches/safari-610-branch/LayoutTests/fast/scrolling/latching/latching-stuck-to-main-page-expected.txt 2020-09-03 21:30:53 UTC (rev 266548) @@ -0,0 +1,21 @@ + +Tests that scrolling doesn't get wrongly latched to the main page. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +Checking wheel event over the select +PASS selectScrollCount > 0 is true +PASS pageScrollCount == 0 is true +Triggering main page latch; scrolling down +Triggering main page latch; scrolling up +PASS selectScrollCount == 0 is true +PASS pageScrollCount > 0 is true +PASS document.scrollingElement.scrollTop == 0 is true +Checking wheel event over the select again +PASS selectScrollCount > 0 is true +PASS pageScrollCount == 0 is true +PASS successfullyParsed is true + +TEST COMPLETE + Added: branches/safari-610-branch/LayoutTests/fast/scrolling/latching/latching-stuck-to-main-page.html (0 => 266548) --- branches/saf
[webkit-changes] [266542] trunk
Title: [266542] trunk Revision 266542 Author commit-qu...@webkit.org Date 2020-09-03 14:04:05 -0700 (Thu, 03 Sep 2020) Log Message CoreImage Implementation of SourceGraphic and saturate(), hue-rotate(), grayscale() and sepia() https://bugs.webkit.org/show_bug.cgi?id=213673 Patch by Frank Yang on 2020-09-03 Reviewed by Darin Adler, Simon Fraser. Source/WebCore: Tests: css3/filters/effect-grayscale-square.html css3/filters/effect-hue-rotate-square.html css3/filters/effect-saturate-square.html css3/filters/effect-sepia-square.html Added CoreImage implementation of SourceGraphic and partial of FEColorMatrix, which is used to implement sepia(), grayscale() hue-rotate() and saturate(). Also added CIFilter caching, by storing CIFilters in a hash map, where the key is the level of traversal (an integer). * platform/graphics/coreimage/FilterEffectRendererCoreImage.h: Imported FEColorMatrix.h and SourceGraphic.h; added function getCIContext() that returns a static copy of CIContext. * platform/graphics/coreimage/FilterEffectRendererCoreImage.mm: (WebCore::FilterEffectRendererCoreImage::getCIContext): Creating a CIContext is expensive. Instead of creating a CIContext on each frame update, we just use a static singleton on every draw (WebCore::FilterEffectRendererCoreImage::supportsCoreImageRendering): the function now returns true if the filter chain contains SourceGraphic and FEColorMatrix of TYPE_MATRIX, TYPE_SATURATE and TYPE_HUEROTATE (WebCore::FilterEffectRendererCoreImage::connectCIFilters): Made slight changes to wrap Obj-C pointers in RetainPtr (WebCore::FilterEffectRendererCoreImage::imageForSourceGraphic): Use the source image to create a CIImage and return it. If the source image is backed by IOSurface, we create a CIImage directly from the IOSurface; otherwise we create a CIImage by getting the NativeImagePtr from source image. (WebCore::FilterEffectRendererCoreImage::imageForFEColorMatrix): Based on the type of the matrix and input parameter, create different types of CIColorMatrix filers that are used to implement sepia, grayscale, hue-rotate, saturate (WebCore::FilterEffectRendererCoreImage::output const): Added a logging line (WebCore::FilterEffectRendererCoreImage::renderToImageBuffer): Minor refactors (WebCore::FilterEffectRendererCoreImage::clearResult): (WebCore::FilterEffectRendererCoreImage::FilterEffectRendererCoreImage): * platform/graphics/filters/FEColorMatrix.h: (isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to FEColorMatrix * platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::requestedRegionOfInputImageData const): removed ASSERT(hasResult()); from the function, because CoreImage path wouldn't create image buffers inside FilterEffect, but CI path still needs to consult this function to obtain geometry info * platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::filterEffectClassType const): Made the function a const (WebCore::FilterEffect::normalizedFloats): Changed this function to public since it is consulted in FilterEffectCoreImageRenderer. (WebCore::FilterEffect::filterEffectClassType): Deleted. * platform/graphics/filters/SourceGraphic.h: (isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to SourceGraphic * rendering/CSSFilter.cpp: (WebCore::CSSFilter::build): Checks whether m_filterRenderer is already created, no need to re-create if the pointer is non-null (WebCore::CSSFilter::allocateBackingStoreIfNeeded): If we are using m_filterRenderer, which is currently using CoreImage and relies on IOSurfaces, we ask source image to use IOSurface for performance concerns. LayoutTests: * css3/filters/effect-grayscale-square-expected.html: Added. * css3/filters/effect-grayscale-square.html: Added. * css3/filters/effect-hue-rotate-square-expected.html: Added. * css3/filters/effect-hue-rotate-square.html: Added. * css3/filters/effect-saturate-square-expected.html: Added. * css3/filters/effect-saturate-square.html: Added. * css3/filters/effect-sepia-square-expected.html: Added. * css3/filters/effect-sepia-square.html: Added. * fast/filter-image/background-filter-image-expected.html: This is the expected result for the background image filter. The background image is not upsampled for retina screens due to a bug, so the test runner is comparing an unscaled image with an upscaled-then-downscaled image. CoreImage handles upscaling and downscaling differently, so the pixel diff will fail. Thus, turning off CI for this particular test case until the background image filter not upsampling bug is fixed. * fast/filter-image/background-filter-image.html: ditto Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/filter-image/background-filter-image-expected.html trunk/LayoutTests/fast/filter-image/background-filter-image.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platf
[webkit-changes] [266541] trunk
Title: [266541] trunk
Revision 266541
Author cdu...@apple.com
Date 2020-09-03 13:54:28 -0700 (Thu, 03 Sep 2020)
Log Message
BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies
https://bugs.webkit.org/show_bug.cgi?id=216130
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT test now that it is passing.
* web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
Source/WebCore:
BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies.
No new tests, rebaselined existing test.
* platform/audio/Biquad.cpp:
(WebCore::Biquad::getFrequencyResponse):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/Biquad.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266540 => 266541)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-03 20:43:43 UTC (rev 266540)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-03 20:54:28 UTC (rev 266541)
@@ -1,3 +1,14 @@
+2020-09-03 Chris Dumez
+
+BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies
+https://bugs.webkit.org/show_bug.cgi?id=216130
+
+Reviewed by Eric Carlson.
+
+Rebaseline WPT test now that it is passing.
+
+* web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
+
2020-09-03 Alex Christensen
Remove unused test expectations file.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt (266540 => 266541)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt 2020-09-03 20:43:43 UTC (rev 266540)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt 2020-09-03 20:54:28 UTC (rev 266541)
@@ -83,10 +83,10 @@
PASS allpass: Max error (0.13259871597205388 deg) in phase response at frequency 1080 Hz is less than or equal to 0.0007597420363434716.
PASS < [allpass] All assertions passed. (total 7 assertions)
PASS > [getFrequencyResponse] Test out-of-bounds frequency values
-FAIL X Magnitude response at frequency -1 is not NaN but should be. Got 1.048875808716. assert_true: expected true got false
-FAIL X Magnitude response at frequency 16385 is not NaN but should be. Got 1.0357666981042346e-11. assert_true: expected true got false
-FAIL X Phase response at frequency -1 is not NaN but should be. Got 0.0025454906281083822. assert_true: expected true got false
-FAIL X Phase response at frequency 16385 is not NaN but should be. Got 3.141589879989624. assert_true: expected true got false
-FAIL < [getFrequencyResponse] 4 out of 4 assertions were failed. assert_true: expected true got false
-FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 9 tasks were failed. assert_true: expected true got false
+PASS Magnitude response at frequency -1 is NaN.
+PASS Magnitude response at frequency 16385 is NaN.
+PASS Phase response at frequency -1 is NaN.
+PASS Phase response at frequency 16385 is NaN.
+PASS < [getFrequencyResponse] All assertions passed. (total 4 assertions)
+PASS # AUDIT TASK RUNNER FINISHED: 9 tasks ran successfully.
Modified: trunk/Source/WebCore/ChangeLog (266540 => 266541)
--- trunk/Source/WebCore/ChangeLog 2020-09-03 20:43:43 UTC (rev 266540)
+++ trunk/Source/WebCore/ChangeLog 2020-09-03 20:54:28 UTC (rev 266541)
@@ -1,3 +1,17 @@
+2020-09-03 Chris Dumez
+
+BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies
+https://bugs.webkit.org/show_bug.cgi?id=216130
+
+Reviewed by Eric Carlson.
+
+BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies.
+
+No new tests, rebaselined existing test.
+
+* platform/audio/Biquad.cpp:
+(WebCore::Biquad::getFrequencyResponse):
+
2020-09-03 Devin Rousso
Web Inspector: allow url breakpoints to be configured
Modified: trunk/Source/WebCore/platform/audio/Biquad.cpp (266540 => 266541)
--- trunk/Source/WebCore/platform/audio/Biquad.cpp 2020-09-03 20:43:43 UTC (rev 266540)
+++ trunk/Source/WebCore/platform/audio/Biquad.cpp 2020-09-03 20:54:28 UTC (rev 266541)
@@ -576,13 +576,19 @@
double a2 = m_a2[0];
for (unsigned k = 0; k < nFrequencies; ++k) {
-double omega = -piDouble * frequency[k];
-std::complex z = std::complex(cos(omega), sin(omega));
-std::complex numerator = b0 + (b1 + b2 * z) * z;
-std::complex denominat
[webkit-changes] [266540] trunk/Tools
Title: [266540] trunk/Tools
Revision 266540
Author lmo...@igalia.com
Date 2020-09-03 13:43:43 -0700 (Thu, 03 Sep 2020)
Log Message
[GTK][WPE] generate-bundle: Remove the zip extension from the uploaded checksum filename
https://bugs.webkit.org/show_bug.cgi?id=216137
Reviewed by Jonathan Bedard.
* Scripts/generate-bundle:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/generate-bundle
Diff
Modified: trunk/Tools/ChangeLog (266539 => 266540)
--- trunk/Tools/ChangeLog 2020-09-03 20:32:28 UTC (rev 266539)
+++ trunk/Tools/ChangeLog 2020-09-03 20:43:43 UTC (rev 266540)
@@ -1,3 +1,12 @@
+2020-09-03 Lauro Moura
+
+[GTK][WPE] generate-bundle: Remove the zip extension from the uploaded checksum filename
+https://bugs.webkit.org/show_bug.cgi?id=216137
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/generate-bundle:
+
2020-09-03 Commit Queue
Unreviewed, reverting r266507.
Modified: trunk/Tools/Scripts/generate-bundle (266539 => 266540)
--- trunk/Tools/Scripts/generate-bundle 2020-09-03 20:32:28 UTC (rev 266539)
+++ trunk/Tools/Scripts/generate-bundle 2020-09-03 20:43:43 UTC (rev 266540)
@@ -552,7 +552,8 @@
# SFTP upload instructions file
uploadinstructionsfile.write('progress\n')
uploadinstructionsfile.write('put %s %s\n' % (self._bundle_file_path, remote_file_bundle_path))
-uploadinstructionsfile.write('put %s %s\n' % (hashcheckfile.name, remote_file_bundle_path + '.sha256sum'))
+remote_file_bundle_path_no_ext, _ = os.path.splitext(remote_file_bundle_path)
+uploadinstructionsfile.write('put %s %s\n' % (hashcheckfile.name, remote_file_bundle_path_no_ext + '.sha256sum'))
uploadinstructionsfile.write('put %s %s\n' % (lastisfile.name, os.path.join(os.path.dirname(remote_file_bundle_path), 'LAST-IS')))
uploadinstructionsfile.write('quit\n')
uploadinstructionsfile.flush()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266539] trunk
Title: [266539] trunk Revision 266539 Author commit-qu...@webkit.org Date 2020-09-03 13:32:28 -0700 (Thu, 03 Sep 2020) Log Message Mark uniform samplers in an array unused per element https://bugs.webkit.org/show_bug.cgi?id=215630 Patch by Kimmo Kinnunen on 2020-09-03 Reviewed by Dean Jackson. Mark uniform samplers in an uniform sampler array unused per element, if driver informs the element being unused. Before, one element would mark the whole array as being unused, and samplers that were in use would not be updated. Source/ThirdParty/ANGLE: * src/libANGLE/Context.cpp: (gl::StateCache::updateActiveImageUnitIndices): * src/libANGLE/Program.cpp: (gl::SamplerBinding::SamplerBinding): (gl::ImageBinding::ImageBinding): (gl::Program::getSamplerUniformBinding const): (gl::Program::getImageUniformBinding const): (gl::Program::linkSamplerAndImageBindings): (gl::Program::updateSamplerUniform): (gl::Program::serialize const): (gl::Program::deserialize): * src/libANGLE/ProgramExecutable.cpp: (gl::ProgramExecutable::updateActiveSamplers): (gl::ProgramExecutable::updateActiveImages): (gl::ProgramExecutable::setSamplerUniformTextureTypeAndFormat): * src/libANGLE/ProgramExecutable.h: * src/libANGLE/renderer/gl/ProgramGL.cpp: (rx::ProgramGL::markUnusedUniformLocations): * src/libANGLE/renderer/metal/ProgramMtl.mm: (rx::ProgramMtl::updateTextures): * src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp: (rx::ProgramExecutableVk::updateImagesDescriptorSet): (rx::ProgramExecutableVk::updateTexturesDescriptorSet): * src/tests/gl_tests/ComputeShaderTest.cpp: * src/tests/gl_tests/UniformTest.cpp: LayoutTests: * fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt: Added. * fast/canvas/webgl/glsl-sampler-array-unused-element.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp trunk/Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp trunk/Source/ThirdParty/ANGLE/src/libANGLE/ProgramExecutable.cpp trunk/Source/ThirdParty/ANGLE/src/libANGLE/ProgramExecutable.h trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/ProgramGL.cpp trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp trunk/Source/ThirdParty/ANGLE/src/tests/gl_tests/ComputeShaderTest.cpp trunk/Source/ThirdParty/ANGLE/src/tests/gl_tests/UniformTest.cpp Added Paths trunk/LayoutTests/fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt trunk/LayoutTests/fast/canvas/webgl/glsl-sampler-array-unused-element.html Diff Modified: trunk/LayoutTests/ChangeLog (266538 => 266539) --- trunk/LayoutTests/ChangeLog 2020-09-03 20:07:39 UTC (rev 266538) +++ trunk/LayoutTests/ChangeLog 2020-09-03 20:32:28 UTC (rev 266539) @@ -1,3 +1,18 @@ +2020-09-03 Kimmo Kinnunen + +Mark uniform samplers in an array unused per element +https://bugs.webkit.org/show_bug.cgi?id=215630 + +Reviewed by Dean Jackson. + +Mark uniform samplers in an uniform sampler array unused per +element, if driver informs the element being unused. +Before, one element would mark the whole array as being +unused, and samplers that were in use would not be updated. + +* fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt: Added. +* fast/canvas/webgl/glsl-sampler-array-unused-element.html: Added. + 2020-09-03 Devin Rousso Web Inspector: allow url breakpoints to be configured Added: trunk/LayoutTests/fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt (0 => 266539) --- trunk/LayoutTests/fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt 2020-09-03 20:32:28 UTC (rev 266539) @@ -0,0 +1,12 @@ +Test that GLSL uniform sampler2D arrays work in presence of unused elements. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + +PASS getError was expected value: NO_ERROR : Should be no errors from setup +PASS getError was expected value: NO_ERROR : Should be no errors from setup +PASS getError was expected value: NO_ERROR : Should be no errors from setup +PASS getError was expected value: NO_ERROR : Should be no errors from setup +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/canvas/webgl/glsl-sampler-array-unused-element.html (0 => 266539) --- trunk/LayoutTests/fast/canvas/webgl/glsl-sampler-array-unused-element.html (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/glsl-sampler-array-unused-element.html 2020-09-03 20:32:28 UTC (rev 266539) @@ -0,0 +1,86 @@ + + + +WebGL GLSL uniform sampler2D array unused element test. + +