[webkit-changes] [273197] trunk/Source/WebCore
Title: [273197] trunk/Source/WebCore
Revision 273197
Author commit-qu...@webkit.org
Date 2021-02-20 02:39:06 -0800 (Sat, 20 Feb 2021)
Log Message
Remove unused isGoogle function
https://bugs.webkit.org/show_bug.cgi?id=27
Patch by Rob Buis on 2021-02-20
Reviewed by Frédéric Wang.
Remove unused (after r273084) isGoogle function.
* platform/UserAgentQuirks.cpp:
(WebCore::isGoogle): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/UserAgentQuirks.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (273196 => 273197)
--- trunk/Source/WebCore/ChangeLog 2021-02-20 06:56:06 UTC (rev 273196)
+++ trunk/Source/WebCore/ChangeLog 2021-02-20 10:39:06 UTC (rev 273197)
@@ -1,3 +1,15 @@
+2021-02-20 Rob Buis
+
+Remove unused isGoogle function
+https://bugs.webkit.org/show_bug.cgi?id=27
+
+Reviewed by Frédéric Wang.
+
+Remove unused (after r273084) isGoogle function.
+
+* platform/UserAgentQuirks.cpp:
+(WebCore::isGoogle): Deleted.
+
2021-02-19 Chris Dumez
Review remaining usage of autorelease to make sure it is necessary
Modified: trunk/Source/WebCore/platform/UserAgentQuirks.cpp (273196 => 273197)
--- trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2021-02-20 06:56:06 UTC (rev 273196)
+++ trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2021-02-20 10:39:06 UTC (rev 273197)
@@ -35,30 +35,6 @@
// When editing the quirks in this file, be sure to update
// Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp.
-static bool isGoogle(const URL& url)
-{
-String domain = url.host().toString();
-String baseDomain = topPrivatelyControlledDomain(domain);
-
-// Our Google UA is *very* complicated to get right. Read
-// https://webkit.org/b/142074 carefully before changing. Test that 3D
-// view is available in Google Maps. Test Google Calendar. Test logging out
-// and logging in to a Google account. Change platformVersionForUAString()
-// to return "FreeBSD amd64" and test everything again.
-if (baseDomain.startsWith("google."))
-return true;
-if (baseDomain == "gstatic.com")
-return true;
-if (baseDomain == "googleusercontent.com")
-return true;
-// googleapis.com is in the public suffix list, which is confusing. E.g.
-// fonts.googleapis.com is actually a base domain.
-if (domain.endsWith(".googleapis.com"))
-return true;
-
-return false;
-}
-
// Be careful with this quirk: it's an invitation for sites to use _javascript_
// that works in Chrome that WebKit cannot handle. Prefer other quirks instead.
static bool urlRequiresChromeBrowser(const URL& url)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273198] trunk/Source/WebCore
Title: [273198] trunk/Source/WebCore
Revision 273198
Author za...@apple.com
Date 2021-02-20 06:18:45 -0800 (Sat, 20 Feb 2021)
Log Message
[LFC][Integration] Enclosing top and bottom value are relative to the containing block's border box
https://bugs.webkit.org/show_bug.cgi?id=20
Reviewed by Antti Koivisto.
This patch ensures that the enclosing top and bottom values are in the same coordinate space
as the line top and bottom values are.
See fast/scrolling/scroll-to-anchor-zoomed-header.html.
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
* layout/inlineformatting/InlineLineGeometry.h:
* layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::operator+):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineGeometry.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (273197 => 273198)
--- trunk/Source/WebCore/ChangeLog 2021-02-20 10:39:06 UTC (rev 273197)
+++ trunk/Source/WebCore/ChangeLog 2021-02-20 14:18:45 UTC (rev 273198)
@@ -1,3 +1,21 @@
+2021-02-20 Zalan Bujtas
+
+[LFC][Integration] Enclosing top and bottom value are relative to the containing block's border box
+https://bugs.webkit.org/show_bug.cgi?id=20
+
+Reviewed by Antti Koivisto.
+
+This patch ensures that the enclosing top and bottom values are in the same coordinate space
+as the line top and bottom values are.
+See fast/scrolling/scroll-to-anchor-zoomed-header.html.
+
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
+* layout/inlineformatting/InlineLineGeometry.h:
+* layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
+(WebCore::LayoutIntegration::operator+):
+(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
+
2021-02-20 Rob Buis
Remove unused isGoogle function
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp (273197 => 273198)
--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp 2021-02-20 10:39:06 UTC (rev 273197)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp 2021-02-20 14:18:45 UTC (rev 273198)
@@ -478,7 +478,7 @@
}
auto rootInlineBoxLogicalRect = lineBox.logicalRectForRootInlineBox();
-auto enclosingTopAndBottom = InlineLineGeometry::EnclosingTopAndBottom { lineBoxLogicalRect.top() + rootInlineBoxLogicalRect.top(), lineBoxLogicalRect.top() + rootInlineBoxLogicalRect.bottom() };
+auto enclosingTopAndBottom = InlineLineGeometry::EnclosingTopAndBottom { rootInlineBoxLogicalRect.top(), rootInlineBoxLogicalRect.bottom() };
HashSet inlineBoxStartSet;
HashSet inlineBoxEndSet;
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineGeometry.h (273197 => 273198)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineGeometry.h 2021-02-20 10:39:06 UTC (rev 273197)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineGeometry.h 2021-02-20 14:18:45 UTC (rev 273198)
@@ -37,8 +37,8 @@
public:
struct EnclosingTopAndBottom {
// This values encloses the root inline box and any other inline level box's border box.
-float top { 0 };
-float bottom { 0 };
+InlineLayoutUnit top { 0 };
+InlineLayoutUnit bottom { 0 };
};
InlineLineGeometry(const InlineRect& lineBoxLogicalRect, EnclosingTopAndBottom, InlineLayoutUnit aligmentBaseline, InlineLayoutUnit contentLogicalLeftOffset, InlineLayoutUnit contentLogicalWidth);
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp (273197 => 273198)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp 2021-02-20 10:39:06 UTC (rev 273197)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp 2021-02-20 14:18:45 UTC (rev 273198)
@@ -50,6 +50,11 @@
bool needsTrailingContentReplacement { false };
};
+inline Layout::InlineLineGeometry::EnclosingTopAndBottom operator+(const Layout::InlineLineGeometry::EnclosingTopAndBottom enclosingTopAndBottom, float offset)
+{
+return { enclosingTopAndBottom.top + offset, enclosingTopAndBottom.bottom + offset };
+}
+
inline static float lineOverflowWidth(const RenderBlockFlow& flow, InlineLayoutUnit lineBoxLogicalWidth, InlineLayoutUnit lineContentLogicalWidth)
{
// FIXME: It's the copy of the lets-adjust-overflow-for-the-caret behavior from ComplexLineLayout::addOverflowFromInlineChildren.
@@ -348,7 +353,8 @@
}
[webkit-changes] [273199] trunk/Tools
Title: [273199] trunk/Tools
Revision 273199
Author aakash_j...@apple.com
Date 2021-02-20 09:00:21 -0800 (Sat, 20 Feb 2021)
Log Message
Revert r272384 [Python-3] Change shebang in git-webkit
https://bugs.webkit.org/show_bug.cgi?id=221412
Unreviewed infrastructure fix.
Revert to Python 2 for git-webkit command because of auto-install issues.
* CISupport/ews-build/steps.py:
* CISupport/ews-build/steps_unittest.py:
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (273198 => 273199)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-02-20 14:18:45 UTC (rev 273198)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-02-20 17:00:21 UTC (rev 273199)
@@ -183,7 +183,7 @@
revision = self.getProperty('ews_revision', self.getProperty('got_revision'))
if not revision:
revision = 'HEAD'
-self.setCommand(['python3', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision])
+self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision])
return shell.ShellCommand.start(self)
def evaluateCommand(self, cmd):
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (273198 => 273199)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-02-20 14:18:45 UTC (rev 273198)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-02-20 17:00:21 UTC (rev 273199)
@@ -3833,7 +3833,7 @@
ExpectShell(workdir='wkdir',
timeout=300,
logEnviron=False,
-command=['python3', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', '51a6aec9f664']) +
+command=['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', '51a6aec9f664']) +
ExpectShell.log('stdio', stdout='Identifier: 233175@main') +
0,
)
@@ -3848,7 +3848,7 @@
ExpectShell(workdir='wkdir',
timeout=300,
logEnviron=False,
-command=['python3', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', 'HEAD']) +
+command=['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', 'HEAD']) +
ExpectShell.log('stdio', stdout='Unexpected failure') +
2,
)
Modified: trunk/Tools/ChangeLog (273198 => 273199)
--- trunk/Tools/ChangeLog 2021-02-20 14:18:45 UTC (rev 273198)
+++ trunk/Tools/ChangeLog 2021-02-20 17:00:21 UTC (rev 273199)
@@ -1,3 +1,14 @@
+2021-02-20 Aakash Jain
+
+Revert r272384 [Python-3] Change shebang in git-webkit
+https://bugs.webkit.org/show_bug.cgi?id=221412
+
+Unreviewed infrastructure fix.
+
+Revert to Python 2 for git-webkit command because of auto-install issues.
+* CISupport/ews-build/steps.py:
+* CISupport/ews-build/steps_unittest.py:
+
2021-02-19 Chris Dumez
Review remaining usage of autorelease to make sure it is necessary
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273200] trunk/Source/ThirdParty/ANGLE
Title: [273200] trunk/Source/ThirdParty/ANGLE Revision 273200 Author d...@apple.com Date 2021-02-20 10:11:59 -0800 (Sat, 20 Feb 2021) Log Message Fix a number of functional regressions caused by enabling the Metal ANGLE backend by default. https://bugs.webkit.org/show_bug.cgi?id=220895 Patch by Kyle Piddington on 2021-02-19 Reviewed by Kenneth Russell. Take two of this patch - this time with the new files FixTypeConstructors and NameEmbeddedUniformStructsMetal Fixed webgl/1.0.3/conformance/context/context-hidden-alpha.html MTL Translator direct fixes for webgl/1.0.3/conformance/glsl/constructors/glsl-construct-*vec2 tests, Plus fix for GL_VertexIndex Fix EmitMetal crash for missing function textureRect. Additional fixes for 73675990, shaders-with-invariance.html, shaders-with-uniform-structs.html, struct-specifiers-in-uniforms.html, framebuffer-object-attachment.html Fixed clamping of array elements. * ANGLE.xcodeproj/project.pbxproj: * src/compiler/translator/TranslatorMetalDirect.cpp: (sh::TranslatorMetalDirect::translateImpl): * src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp: (GenMetalTraverser::emitPostQualifier): (GenMetalTraverser::visitBinary): (GenMetalTraverser::BuildFuncToName): * src/compiler/translator/TranslatorMetalDirect/FixTypeConstructors.cpp: Added. (sh::FixTypeTraverser::FixTypeTraverser): (sh::FixTypeConstructors): * src/compiler/translator/TranslatorMetalDirect/FixTypeConstructors.h: Added. * src/compiler/translator/TranslatorMetalDirect/NameEmbeddedUniformStructsMetal.cpp: Added. (sh::NameEmbeddedStructUniformsMetal): * src/compiler/translator/TranslatorMetalDirect/NameEmbeddedUniformStructsMetal.h: Added. * src/compiler/translator/TranslatorMetalDirect/Pipeline.cpp: (SaturateVectorOf): * src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp: (sh::ProgramPrelude::ProgramPrelude): * src/compiler/translator/TranslatorMetalDirect/ReduceInterfaceBlocks.cpp: (sh::Reducer::Reducer): (sh::ReduceInterfaceBlocks): * src/compiler/translator/TranslatorMetalDirect/ReduceInterfaceBlocks.h: * src/compiler/translator/TranslatorMetalDirect/SeparateCompoundStructDeclarations.cpp: * src/libANGLE/renderer/load_functions_table_autogen.cpp: * src/libANGLE/renderer/metal/ContextMtl.mm: (rx::ContextMtl::drawElementsImpl): * src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.h: * src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm: (rx::IOSurfaceSurfaceMtl::IOSurfaceSurfaceMtl): (rx::IOSurfaceSurfaceMtl::createBackingTexture): * src/libANGLE/renderer/metal/RenderBufferMtl.mm: (rx::RenderbufferMtl::setStorageImpl): * src/libANGLE/renderer/metal/VertexArrayMtl.h: * src/libANGLE/renderer/metal/VertexArrayMtl.mm: (rx::VertexArrayMtl::getIndexBuffer): (rx::VertexArrayMtl::convertIndexBuffer): (rx::VertexArrayMtl::streamIndexBufferFromClient): * src/libANGLE/renderer/metal/mtl_utils.mm: (rx::mtl::InitializeDepthStencilTextureContentsGPU): * src/libANGLE/renderer/metal/shaders/blit.metal: * src/libANGLE/renderer/metal/shaders/mtl_default_shaders_src_autogen.inc: Modified Paths trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/Pipeline.cpp trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/ReduceInterfaceBlocks.cpp trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/ReduceInterfaceBlocks.h trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/SeparateCompoundStructDeclarations.cpp trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect.cpp trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/load_functions_table_autogen.cpp trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.h trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/RenderBufferMtl.mm trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.h trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/blit.metal trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/shaders/mtl_default_shaders_src_autogen.inc Added Paths trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/FixTypeConstructors.cpp trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/FixTypeConstructors.h trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/NameEmbeddedUniformStructsMetal.cpp trunk/Source/ThirdParty/ANGLE/src/compil
[webkit-changes] [273201] trunk/Source/WebKit
Title: [273201] trunk/Source/WebKit
Revision 273201
Author cdu...@apple.com
Date 2021-02-20 10:13:36 -0800 (Sat, 20 Feb 2021)
Log Message
Unreviewed, fix regression from r273194 that was spotted by Darin Adler after landing.
* Platform/cocoa/WKPaymentAuthorizationDelegate.mm:
(-[WKPaymentAuthorizationDelegate completePaymentMethodSelection:]):
(-[WKPaymentAuthorizationDelegate completeShippingContactSelection:]):
(-[WKPaymentAuthorizationDelegate completeShippingMethodSelection:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (273200 => 273201)
--- trunk/Source/WebKit/ChangeLog 2021-02-20 18:11:59 UTC (rev 273200)
+++ trunk/Source/WebKit/ChangeLog 2021-02-20 18:13:36 UTC (rev 273201)
@@ -1,3 +1,12 @@
+2021-02-20 Chris Dumez
+
+Unreviewed, fix regression from r273194 that was spotted by Darin Adler after landing.
+
+* Platform/cocoa/WKPaymentAuthorizationDelegate.mm:
+(-[WKPaymentAuthorizationDelegate completePaymentMethodSelection:]):
+(-[WKPaymentAuthorizationDelegate completeShippingContactSelection:]):
+(-[WKPaymentAuthorizationDelegate completeShippingMethodSelection:]):
+
2021-02-19 Chris Dumez
Crash under Decoder::Decoder()
Modified: trunk/Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.mm (273200 => 273201)
--- trunk/Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.mm 2021-02-20 18:11:59 UTC (rev 273200)
+++ trunk/Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.mm 2021-02-20 18:13:36 UTC (rev 273201)
@@ -69,7 +69,7 @@
- (void)completePaymentMethodSelection:(PKPaymentRequestPaymentMethodUpdate *)paymentMethodUpdate
{
-auto update = !paymentMethodUpdate ? adoptNS([PAL::allocPKPaymentRequestPaymentMethodUpdateInstance() initWithPaymentSummaryItems:_summaryItems.get()]) : nil;
+auto update = paymentMethodUpdate ? retainPtr(paymentMethodUpdate) : adoptNS([PAL::allocPKPaymentRequestPaymentMethodUpdateInstance() initWithPaymentSummaryItems:_summaryItems.get()]);
_summaryItems = adoptNS([[update paymentSummaryItems] copy]);
std::exchange(_didSelectPaymentMethodCompletion, nil)(update.get());
}
@@ -81,7 +81,7 @@
}
- (void)completeShippingContactSelection:(PKPaymentRequestShippingContactUpdate *)shippingContactUpdate
{
-auto update = !shippingContactUpdate ? adoptNS([PAL::allocPKPaymentRequestShippingContactUpdateInstance() initWithErrors:@[] paymentSummaryItems:_summaryItems.get() shippingMethods:_shippingMethods.get()]) : nil;
+auto update = shippingContactUpdate ? retainPtr(shippingContactUpdate) : adoptNS([PAL::allocPKPaymentRequestShippingContactUpdateInstance() initWithErrors:@[] paymentSummaryItems:_summaryItems.get() shippingMethods:_shippingMethods.get()]);
_summaryItems = adoptNS([[update paymentSummaryItems] copy]);
_shippingMethods = adoptNS([[update shippingMethods] copy]);
std::exchange(_didSelectShippingContactCompletion, nil)(update.get());
@@ -89,7 +89,7 @@
- (void)completeShippingMethodSelection:(PKPaymentRequestShippingMethodUpdate *)shippingMethodUpdate
{
-auto update = !shippingMethodUpdate ? adoptNS([PAL::allocPKPaymentRequestShippingMethodUpdateInstance() initWithPaymentSummaryItems:_summaryItems.get()]) : nil;
+auto update = shippingMethodUpdate ? retainPtr(shippingMethodUpdate) : adoptNS([PAL::allocPKPaymentRequestShippingMethodUpdateInstance() initWithPaymentSummaryItems:_summaryItems.get()]);
_summaryItems = adoptNS([[update paymentSummaryItems] copy]);
std::exchange(_didSelectShippingMethodCompletion, nil)(update.get());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273202] trunk
Title: [273202] trunk
Revision 273202
Author wenson_hs...@apple.com
Date 2021-02-20 10:17:33 -0800 (Sat, 20 Feb 2021)
Log Message
Unreviewed, reverting r273115.
Breaks autocorrect without the accompanying change in
rdar://problem/74211293
Reverted changeset:
"Unconditionally return information in _autofillContext SPI
when a field is focused"
https://bugs.webkit.org/show_bug.cgi?id=221828
https://commits.webkit.org/r273115
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm
trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (273201 => 273202)
--- trunk/Source/WebKit/ChangeLog 2021-02-20 18:13:36 UTC (rev 273201)
+++ trunk/Source/WebKit/ChangeLog 2021-02-20 18:17:33 UTC (rev 273202)
@@ -1,3 +1,17 @@
+2021-02-20 Wenson Hsieh
+
+Unreviewed, reverting r273115.
+
+Breaks autocorrect without the accompanying change in
+rdar://problem/74211293
+
+Reverted changeset:
+
+"Unconditionally return information in _autofillContext SPI
+when a field is focused"
+https://bugs.webkit.org/show_bug.cgi?id=221828
+https://commits.webkit.org/r273115
+
2021-02-20 Chris Dumez
Unreviewed, fix regression from r273194 that was spotted by Darin Adler after landing.
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (273201 => 273202)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2021-02-20 18:13:36 UTC (rev 273201)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2021-02-20 18:17:33 UTC (rev 273202)
@@ -8117,23 +8117,18 @@
- (NSDictionary *)_autofillContext
{
-if (!self._hasFocusedElement)
+BOOL provideStrongPasswordAssistance = _focusRequiresStrongPasswordAssistance && _focusedElementInformation.elementType == WebKit::InputType::Password;
+if (!self._hasFocusedElement || (!_focusedElementInformation.acceptsAutofilledLoginCredentials && !provideStrongPasswordAssistance))
return nil;
-auto context = adoptNS([[NSMutableDictionary alloc] init]);
-context.get()[@"_WKAutofillContextVersion"] = @(2);
+if (provideStrongPasswordAssistance)
+return @{ @"_automaticPasswordKeyboard" : @YES, @"strongPasswordAdditionalContext" : _additionalContextForStrongPasswordAssistance.get() };
-if (_focusRequiresStrongPasswordAssistance && _focusedElementInformation.elementType == WebKit::InputType::Password) {
-context.get()[@"_automaticPasswordKeyboard"] = @YES;
-context.get()[@"strongPasswordAdditionalContext"] = _additionalContextForStrongPasswordAssistance.get();
-} else if (_focusedElementInformation.acceptsAutofilledLoginCredentials)
-context.get()[@"_acceptsLoginCredentials"] = @YES;
-
NSURL *platformURL = _focusedElementInformation.representingPageURL;
if (platformURL)
-context.get()[@"_WebViewURL"] = platformURL;
+return @{ @"_WebViewURL" : platformURL };
-return context.autorelease();
+return nil;
}
- (BOOL)supportsImagePaste
Modified: trunk/Tools/ChangeLog (273201 => 273202)
--- trunk/Tools/ChangeLog 2021-02-20 18:13:36 UTC (rev 273201)
+++ trunk/Tools/ChangeLog 2021-02-20 18:17:33 UTC (rev 273202)
@@ -1,3 +1,17 @@
+2021-02-20 Wenson Hsieh
+
+Unreviewed, reverting r273115.
+
+Breaks autocorrect without the accompanying change in
+rdar://problem/74211293
+
+Reverted changeset:
+
+"Unconditionally return information in _autofillContext SPI
+when a field is focused"
+https://bugs.webkit.org/show_bug.cgi?id=221828
+https://commits.webkit.org/r273115
+
2021-02-20 Aakash Jain
Revert r272384 [Python-3] Change shebang in git-webkit
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm (273201 => 273202)
--- trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm 2021-02-20 18:13:36 UTC (rev 273201)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm 2021-02-20 18:17:33 UTC (rev 273202)
@@ -689,7 +689,6 @@
NSDictionary *actual = [[webView textInputContentView] _autofillContext];
EXPECT_TRUE([[actual allValues] containsObject:expected]);
-EXPECT_TRUE([actual[@"_automaticPasswordKeyboard"] boolValue]);
}
TEST(KeyboardInputTests, TestWebViewAccessoryDoneDuringStrongPasswordAssistance)
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm (273201 => 273202)
--- trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm 2021-02-20 18:13:36 UTC (rev 273201)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm 2021-02-20 18:17:33 UTC (rev 273202)
@@ -66,16 +66,14 @@
return (AutoFillInputView *)self.textInputContentView;
}
-- (BOOL)acceptsAutoFillLoginCredentials
+- (BOOL)textInputHasAutoFillContext
{
-
[webkit-changes] [273205] trunk/Source/WebCore
Title: [273205] trunk/Source/WebCore Revision 273205 Author lmo...@igalia.com Date 2021-02-20 14:22:43 -0800 (Sat, 20 Feb 2021) Log Message Unreviewed. GLib buildfix after r273203 * bindings/js/WorkerModuleScriptLoader.h: * bindings/js/WorkerScriptFetcher.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/WorkerModuleScriptLoader.h trunk/Source/WebCore/bindings/js/WorkerScriptFetcher.h Diff Modified: trunk/Source/WebCore/ChangeLog (273204 => 273205) --- trunk/Source/WebCore/ChangeLog 2021-02-20 20:33:25 UTC (rev 273204) +++ trunk/Source/WebCore/ChangeLog 2021-02-20 22:22:43 UTC (rev 273205) @@ -1,3 +1,10 @@ +2021-02-20 Lauro Moura + +Unreviewed. GLib buildfix after r273203 + +* bindings/js/WorkerModuleScriptLoader.h: +* bindings/js/WorkerScriptFetcher.h: + 2021-02-19 Yusuke Suzuki JS Modules in Workers Modified: trunk/Source/WebCore/bindings/js/WorkerModuleScriptLoader.h (273204 => 273205) --- trunk/Source/WebCore/bindings/js/WorkerModuleScriptLoader.h 2021-02-20 20:33:25 UTC (rev 273204) +++ trunk/Source/WebCore/bindings/js/WorkerModuleScriptLoader.h 2021-02-20 22:22:43 UTC (rev 273205) @@ -26,6 +26,7 @@ #pragma once #include "ModuleScriptLoader.h" +#include "WorkerScriptFetcher.h" #include "WorkerScriptLoaderClient.h" #include #include Modified: trunk/Source/WebCore/bindings/js/WorkerScriptFetcher.h (273204 => 273205) --- trunk/Source/WebCore/bindings/js/WorkerScriptFetcher.h 2021-02-20 20:33:25 UTC (rev 273204) +++ trunk/Source/WebCore/bindings/js/WorkerScriptFetcher.h 2021-02-20 22:22:43 UTC (rev 273205) @@ -25,6 +25,7 @@ #pragma once +#include "FetchOptions.h" #include "LoadableScript.h" #include "ModuleFetchParameters.h" #include <_javascript_Core/ScriptFetcher.h> ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273206] trunk
Title: [273206] trunk Revision 273206 Author commit-qu...@webkit.org Date 2021-02-20 14:40:54 -0800 (Sat, 20 Feb 2021) Log Message "min-content" & "max-content" keywords should behave as initial value in block axis (but WebKit improperly treats them as the content-size) https://bugs.webkit.org/show_bug.cgi?id=191390 Patch by Rob Buis on 2021-02-20 Reviewed by Darin Adler. LayoutTests/imported/w3c: Update improved test expectation. * web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/min-inline-size-expected.txt: Source/WebCore: "min-content" & "max-content" should use automatic size in block direction [1]. This behavior matches Gecko and Blink. [1] https://drafts.csswg.org/css-sizing-3/#valdef-width-min-content * rendering/RenderBox.cpp: (WebCore::RenderBox::constrainLogicalHeightByMinMax const): LayoutTests: Adapt test to new behavior. * fast/css-intrinsic-dimensions/height-expected.html: Removed. * fast/css-intrinsic-dimensions/height.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css-intrinsic-dimensions/height-expected.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/min-inline-size-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp Diff Modified: trunk/LayoutTests/ChangeLog (273205 => 273206) --- trunk/LayoutTests/ChangeLog 2021-02-20 22:22:43 UTC (rev 273205) +++ trunk/LayoutTests/ChangeLog 2021-02-20 22:40:54 UTC (rev 273206) @@ -1,3 +1,15 @@ +2021-02-20 Rob Buis + +"min-content" & "max-content" keywords should behave as initial value in block axis (but WebKit improperly treats them as the content-size) +https://bugs.webkit.org/show_bug.cgi?id=191390 + +Reviewed by Darin Adler. + +Adapt test to new behavior. + +* fast/css-intrinsic-dimensions/height-expected.html: Removed. +* fast/css-intrinsic-dimensions/height.html: Removed. + 2021-02-20 Kimmo Kinnunen WebGL GPU process IPC should use shared memory for asynchronous messages Modified: trunk/LayoutTests/fast/css-intrinsic-dimensions/height-expected.html (273205 => 273206) --- trunk/LayoutTests/fast/css-intrinsic-dimensions/height-expected.html 2021-02-20 22:22:43 UTC (rev 273205) +++ trunk/LayoutTests/fast/css-intrinsic-dimensions/height-expected.html 2021-02-20 22:40:54 UTC (rev 273206) @@ -40,11 +40,11 @@ - + min-height: min-contenton this box. - + min-height: max-contenton this box. Modified: trunk/LayoutTests/imported/w3c/ChangeLog (273205 => 273206) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-20 22:22:43 UTC (rev 273205) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-20 22:40:54 UTC (rev 273206) @@ -1,3 +1,14 @@ +2021-02-20 Rob Buis + +"min-content" & "max-content" keywords should behave as initial value in block axis (but WebKit improperly treats them as the content-size) +https://bugs.webkit.org/show_bug.cgi?id=191390 + +Reviewed by Darin Adler. + +Update improved test expectation. + +* web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/min-inline-size-expected.txt: + 2021-02-19 Yusuke Suzuki JS Modules in Workers Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/min-inline-size-expected.txt (273205 => 273206) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/min-inline-size-expected.txt 2021-02-20 22:22:43 UTC (rev 273205) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/min-inline-size-expected.txt 2021-02-20 22:40:54 UTC (rev 273206) @@ -3,9 +3,9 @@ PASS horizontal-tb -FAIL vertical-lr assert_equals: width expected "0px" but got "100px" -FAIL vertical-rl assert_equals: width expected "0px" but got "100px" +FAIL vertical-lr assert_equals: height expected "100px" but got "0px" +FAIL vertical-rl assert_equals: height expected "100px" but got "0px" PASS horizontal-tb override -FAIL vertical-lr override assert_equals: width expected "0px" but got "100px" -FAIL vertical-rl override assert_equals: width expected "0px" but got "100px" +PASS vertical-lr override +PASS vertical-rl override Modified: trunk/Source/WebCore/ChangeLog (273205 => 273206) --- trunk/Source/WebCore/ChangeLog 2021-02-20 22:22:43 UTC (rev 273205) +++ trunk/Source/WebCore/ChangeLog 2021-02-20 22:40:54 UTC (rev 273206) @@ -1,3 +1,19 @@ +2021-02-20 Rob Buis + +"min-content" & "max-content" keywords should behave as initial value in block axis (but WebKit improperly treats them as the content-size) +https://bugs.webkit.org/show_bug.cgi?id=191390 + +
[webkit-changes] [273207] trunk/Source/WTF
Title: [273207] trunk/Source/WTF Revision 273207 Author s...@apple.com Date 2021-02-20 14:43:39 -0800 (Sat, 20 Feb 2021) Log Message Make PaintTimingEnabled default to false https://bugs.webkit.org/show_bug.cgi?id=222186 Reviewed by Simon Fraser. PaintTiming causes about 4% regression in the MotionMark sub-tests: Multiply and Focus. Do disable it for now. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (273206 => 273207) --- trunk/Source/WTF/ChangeLog 2021-02-20 22:40:54 UTC (rev 273206) +++ trunk/Source/WTF/ChangeLog 2021-02-20 22:43:39 UTC (rev 273207) @@ -1,3 +1,15 @@ +2021-02-20 Said Abou-Hallawa + +Make PaintTimingEnabled default to false +https://bugs.webkit.org/show_bug.cgi?id=222186 + +Reviewed by Simon Fraser. + +PaintTiming causes about 4% regression in the MotionMark sub-tests: +Multiply and Focus. Do disable it for now. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2021-02-19 Wenson Hsieh [iOS] Specify a _UIDataOwner when reading or writing from the system pasteboard Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (273206 => 273207) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-02-20 22:40:54 UTC (rev 273206) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-02-20 22:43:39 UTC (rev 273207) @@ -671,7 +671,7 @@ WebKitLegacy: default: false WebKit: - default: true + default: false PassiveWheelListenersAsDefaultOnDocument: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273208] trunk/Source/WTF
Title: [273208] trunk/Source/WTF Revision 273208 Author jiewen_...@apple.com Date 2021-02-20 15:01:38 -0800 (Sat, 20 Feb 2021) Log Message PCM: Turn the fraud prevention on by default https://bugs.webkit.org/show_bug.cgi?id=24 Reviewed by John Wilander. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (273207 => 273208) --- trunk/Source/WTF/ChangeLog 2021-02-20 22:43:39 UTC (rev 273207) +++ trunk/Source/WTF/ChangeLog 2021-02-20 23:01:38 UTC (rev 273208) @@ -1,3 +1,13 @@ +2021-02-20 Jiewen Tan + +PCM: Turn the fraud prevention on by default +https://bugs.webkit.org/show_bug.cgi?id=24 + + +Reviewed by John Wilander. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2021-02-20 Said Abou-Hallawa Make PaintTimingEnabled default to false Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (273207 => 273208) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-02-20 22:43:39 UTC (rev 273207) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-02-20 23:01:38 UTC (rev 273208) @@ -719,6 +719,7 @@ webcoreBinding: RuntimeEnabledFeatures defaultValue: WebKit: + "HAVE(RSA_BSSA)": true default: false ProcessSwapOnCrossSiteNavigationEnabled: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273209] trunk
Title: [273209] trunk Revision 273209 Author jiewen_...@apple.com Date 2021-02-20 15:17:32 -0800 (Sat, 20 Feb 2021) Log Message PCM: Store and report source unlinkable tokens https://bugs.webkit.org/show_bug.cgi?id=08 Reviewed by John Wilander. Source/WebCore: This patch hooks up the network process with the PCM fraud prevention feature to enable the generation, storing and reporting the source unlinkable token. Existing tests updated. * loader/PrivateClickMeasurement.h: (WebCore::PrivateClickMeasurement::setSourceSecretTokenValue): Adds infrastructure to mock the crypto operations such that layout tests can be conducted without the server side crypto support. * loader/PrivateClickMeasurement.cpp: (WebCore::PrivateClickMeasurement::attributionReportJSON const): (WebCore::PrivateClickMeasurement::tokenSignatureJSON const): (WebCore::PrivateClickMeasurement::setSourceUnlinkableToken): (WebCore::PrivateClickMeasurement::tokenSignatureJSON): Deleted. * loader/PrivateClickMeasurement.h: (WebCore::PrivateClickMeasurement::sourceUnlinkableToken const): * loader/cocoa/PrivateClickMeasurementCocoa.mm: (WebCore::PrivateClickMeasurement::calculateAndUpdateSourceSecretToken): (WebCore::PrivateClickMeasurement::calculateAndUpdateSourceUnlinkableToken): (WebCore::PrivateClickMeasurement::sourceSecretToken): Deleted. (WebCore::PrivateClickMeasurement::calculateSourceUnlinkableToken): Deleted. Update interfaces to service the use cases in the Networking process better. Source/WebKit: * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::setFraudPreventionValuesForTesting): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::setFraudPreventionValuesForTesting): * NetworkProcess/NetworkSession.h: * NetworkProcess/PrivateClickMeasurementManager.cpp: (WebKit::PrivateClickMeasurementManager::storeUnattributed): (WebKit::PrivateClickMeasurementManager::getSignedSecretToken): (WebKit::PrivateClickMeasurementManager::setFraudPreventionValuesForTesting): * NetworkProcess/PrivateClickMeasurementManager.h: * UIProcess/API/C/WKPage.cpp: (WKPageSetFraudPreventionValuesForTesting): * UIProcess/API/C/WKPagePrivate.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::markPrivateClickMeasurementsAsExpiredForTesting): (WebKit::WebPageProxy::setFraudPreventionValuesForTesting): * UIProcess/WebPageProxy.h: Adds infrastructure to mock the crypto operations such that layout tests can be conducted without the server side crypto support. * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::buildPrivateClickMeasurementFromDatabase): (WebKit::ResourceLoadStatisticsDatabaseStore::insertPrivateClickMeasurement): * NetworkProcess/PrivateClickMeasurementManager.cpp: (WebKit::PrivateClickMeasurementManager::storeUnattributed): (WebKit::PrivateClickMeasurementManager::getTokenPublicKey): (WebKit::PrivateClickMeasurementManager::getSignedSecretToken): (WebKit::PrivateClickMeasurementManager::fireConversionRequest): (WebKit::PrivateClickMeasurementManager::fireConversionRequestImpl): * NetworkProcess/PrivateClickMeasurementManager.h: Connects the fraud prevention feature in PCM to generate, store, and report the unlinkable token. Tools: * TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp: (TestWebKitAPI::TEST): * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setFraudPreventionValuesForTesting): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::setFraudPreventionValuesForTesting): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Rebases some test cases. LayoutTests: * http/tests/privateClickMeasurement/expired-attribution-report-gets-sent-on-session-start-expected.txt: * http/tests/privateClickMeasurement/resources/signToken.php: * http/tests/privateClickMeasurement/send-attribution-conversion-request-expected.txt: * http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce-expected.txt: * http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html: Modifies the test to mock the whole round trip. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/privateClickMeasurement/expired-attribution-report-gets-sent-on-session-start-expected.txt trunk/LayoutTests/http/tests/privateClickMeasurement/resources/signToken.php trunk/LayoutTests/http/tests/privateClickMeasurement/send-attribution-conversion-request-expected.txt trunk/LayoutTests/http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce-expected.txt trunk/LayoutTests/http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html trunk/Source/WebCore/C
[webkit-changes] [273210] trunk/Source/WebCore
Title: [273210] trunk/Source/WebCore
Revision 273210
Author simon.fra...@apple.com
Date 2021-02-20 16:38:20 -0800 (Sat, 20 Feb 2021)
Log Message
Fix the build when TREE_DEBUGGING is enabled in release builds
https://bugs.webkit.org/show_bug.cgi?id=38
Reviewed by Zalan Bujtas.
FloatingObjects logging needs to use ENABLE(TREE_DEBUGGING) not #ifndef NDEBUG.
* rendering/FloatingObjects.cpp:
* rendering/FloatingObjects.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/FloatingObjects.cpp
trunk/Source/WebCore/rendering/FloatingObjects.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (273209 => 273210)
--- trunk/Source/WebCore/ChangeLog 2021-02-20 23:17:32 UTC (rev 273209)
+++ trunk/Source/WebCore/ChangeLog 2021-02-21 00:38:20 UTC (rev 273210)
@@ -1,3 +1,15 @@
+2021-02-20 Simon Fraser
+
+Fix the build when TREE_DEBUGGING is enabled in release builds
+https://bugs.webkit.org/show_bug.cgi?id=38
+
+Reviewed by Zalan Bujtas.
+
+FloatingObjects logging needs to use ENABLE(TREE_DEBUGGING) not #ifndef NDEBUG.
+
+* rendering/FloatingObjects.cpp:
+* rendering/FloatingObjects.h:
+
2021-02-20 Jiewen Tan
PCM: Store and report source unlinkable tokens
Modified: trunk/Source/WebCore/rendering/FloatingObjects.cpp (273209 => 273210)
--- trunk/Source/WebCore/rendering/FloatingObjects.cpp 2021-02-20 23:17:32 UTC (rev 273209)
+++ trunk/Source/WebCore/rendering/FloatingObjects.cpp 2021-02-21 00:38:20 UTC (rev 273210)
@@ -107,7 +107,7 @@
return locationOffsetOfBorderBox() - renderer().locationOffset();
}
-#ifndef NDEBUG
+#if ENABLE(TREE_DEBUGGING)
TextStream& operator<<(TextStream& stream, const FloatingObject& object)
{
Modified: trunk/Source/WebCore/rendering/FloatingObjects.h (273209 => 273210)
--- trunk/Source/WebCore/rendering/FloatingObjects.h 2021-02-20 23:17:32 UTC (rev 273209)
+++ trunk/Source/WebCore/rendering/FloatingObjects.h 2021-02-21 00:38:20 UTC (rev 273210)
@@ -189,7 +189,7 @@
WeakPtr m_renderer;
};
-#ifndef NDEBUG
+#if ENABLE(TREE_DEBUGGING)
TextStream& operator<<(TextStream&, const FloatingObject&);
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273211] trunk
Title: [273211] trunk Revision 273211 Author wei...@apple.com Date 2021-02-20 16:47:59 -0800 (Sat, 20 Feb 2021) Log Message color(lab ...) should serialize as color(lab ...) not lab() according to latest CSS Color 4 spec https://bugs.webkit.org/show_bug.cgi?id=222110 Reviewed by Dean Jackson. Source/WebCore: To make this work it was necessary to make it so that extended colors, like Lab, could store an extra bit of data on Color to indicate that it should use the color() function for serialization when parsed using the color() form. To do that, Color was reworked to allow extra metadata flags for both inline and extended colors. Previously, only inline colors could make use of the extra bits. Now, we take advantage of the fact that we have the high 16 bits available to us for pointers to also store that metadata for extended colors. Rather than using a union, we encode the pointer / inline color into a uint64_t, and use the extra bits for the flags we need. Currently we only use 6, so there is quite a bit more that could be used here. Finally, the color serialization code has been updated to check for the new bit, called UseColorFunctionSerialization, and to serialize using color() notation if it is set. We are currently only taking advantage of this for differentiating between lab(...) and color(lab ...), but in the future we should be able to also optimize color(srgb ...) values that can be represented fully by SRGBA. Since we can now add flags for extended colors, the semantic bit is also now usable for extended colors, though none currently exist. * css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::parseColorFunctionForRGBTypes): (WebCore::CSSPropertyParserHelpers::parseColorFunctionForLabParameters): (WebCore::CSSPropertyParserHelpers::parseColorFunctionForXYZParameters): (WebCore::CSSPropertyParserHelpers::parseColorFunctionParameters): * platform/graphics/Color.cpp: (WebCore::Color::Color): (WebCore::Color::operator=): (WebCore::Color::colorWithAlpha const): (WebCore::Color::semanticColor const): * platform/graphics/Color.h: (WebCore::Color::isHashTableDeletedValue const): (WebCore::Color::Color): (WebCore::Color::toAllFlags): (WebCore::Color::setColor): (WebCore::Color::setExtendedColor): (WebCore::operator==): (WebCore::extendedColorsEqual): (WebCore::extendedColorsEqualIgnoringSemanticColor): (WebCore::equalIgnoringSemanticColor): (WebCore::Color::~Color): (WebCore::Color::hash const): (WebCore::Color::isValid const): (WebCore::Color::isSemantic const): (WebCore::Color::usesColorFunctionSerialization const): (WebCore::Color::flags const): (WebCore::Color::isExtended const): (WebCore::Color::isInline const): (WebCore::Color::asExtended const): (WebCore::Color::asExtendedRef const): (WebCore::Color::asInline const): (WebCore::Color::asPackedInline const): (WebCore::Color::encodedFlags): (WebCore::Color::encodedInlineColor): (WebCore::Color::encodedPackedInlineColor): (WebCore::Color::encodedExtendedColor): (WebCore::Color::decodedFlags): (WebCore::Color::decodedInlineColor): (WebCore::Color::decodedPackedInlineColor): (WebCore::Color::decodedExtendedColor): (WebCore::Color::setInvalid): (WebCore::Color::encode const): (WebCore::Color::decode): (WebCore::Color::tagAsSemantic): Deleted. (WebCore::Color::tagAsValid): Deleted. * platform/graphics/ColorBlending.cpp: (WebCore::blendWithWhite): * platform/graphics/ColorSerialization.cpp: (WebCore::serializationForCSS): (WebCore::serializationForHTML): (WebCore::serializationForRenderTreeAsText): (WebCore::serializationUsingColorFunction): * platform/graphics/cg/ColorCG.cpp: (WebCore::Color::Color): * platform/graphics/mac/ColorMac.mm: (WebCore::semanticColorFromNSColor): * rendering/RenderThemeIOS.mm: (WebCore::systemColorFromCSSValueIDSelector): (WebCore::systemColorFromCSSValueID): * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::systemColor const): LayoutTests: * fast/css/parsing-lab-colors-expected.txt: * fast/css/parsing-lab-colors.html: Update test and results for new serialization of color(lab ...). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/parsing-lab-colors-expected.txt trunk/LayoutTests/fast/css/parsing-lab-colors.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp trunk/Source/WebCore/platform/graphics/Color.cpp trunk/Source/WebCore/platform/graphics/Color.h trunk/Source/WebCore/platform/graphics/ColorBlending.cpp trunk/Source/WebCore/platform/graphics/ColorSerialization.cpp trunk/Source/WebCore/platform/graphics/ColorUtilities.h trunk/Source/WebCore/platform/graphics/cg/ColorCG.cpp trunk/Source/WebCore/platform/graphics/mac/ColorMac.mm trunk/Source/WebCore/rendering/RenderThemeIOS.mm trunk/Source/WebCore/rendering/RenderThemeMac.mm Diff Modified: trunk/LayoutTests/ChangeLog (273210 => 273211) --- trunk/LayoutTests/ChangeLog 2021-02-21 00:38:20 UTC (rev 273210) +++ trunk/LayoutTests/ChangeLog 2021-02-21 00:47:5
[webkit-changes] [273212] trunk
Title: [273212] trunk
Revision 273212
Author you...@apple.com
Date 2021-02-20 17:06:59 -0800 (Sat, 20 Feb 2021)
Log Message
Add support for adding/removing/clearing mock devices in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=222174
Reviewed by Eric Carlson.
Source/WebKit:
Make sure to forward mock device orders to GPU process so that it is kept in sync with UIProcess.
Covered by updated test.
* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::addMockMediaDevice):
(WebKit::GPUProcess::clearMockMediaDevices):
(WebKit::GPUProcess::removeMockMediaDevice):
(WebKit::GPUProcess::resetMockMediaDevices):
* GPUProcess/GPUProcess.h:
* GPUProcess/GPUProcess.messages.in:
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::addMockMediaDevice):
(WebKit::GPUProcessProxy::clearMockMediaDevices):
(WebKit::GPUProcessProxy::removeMockMediaDevice):
(WebKit::GPUProcessProxy::resetMockMediaDevices):
* UIProcess/GPU/GPUProcessProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::addMockMediaDevice):
(WebKit::WebProcessPool::clearMockMediaDevices):
(WebKit::WebProcessPool::removeMockMediaDevice):
(WebKit::WebProcessPool::resetMockMediaDevices):
LayoutTests:
* fast/mediastream/device-change-event-2.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/device-change-event-2.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/GPUProcess.cpp
trunk/Source/WebKit/GPUProcess/GPUProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (273211 => 273212)
--- trunk/LayoutTests/ChangeLog 2021-02-21 00:47:59 UTC (rev 273211)
+++ trunk/LayoutTests/ChangeLog 2021-02-21 01:06:59 UTC (rev 273212)
@@ -1,3 +1,12 @@
+2021-02-20 Youenn Fablet
+
+Add support for adding/removing/clearing mock devices in GPUProcess
+https://bugs.webkit.org/show_bug.cgi?id=222174
+
+Reviewed by Eric Carlson.
+
+* fast/mediastream/device-change-event-2.html:
+
2021-02-20 Sam Weinig
color(lab ...) should serialize as color(lab ...) not lab() according to latest CSS Color 4 spec
Modified: trunk/LayoutTests/fast/mediastream/device-change-event-2.html (273211 => 273212)
--- trunk/LayoutTests/fast/mediastream/device-change-event-2.html 2021-02-21 00:47:59 UTC (rev 273211)
+++ trunk/LayoutTests/fast/mediastream/device-change-event-2.html 2021-02-21 01:06:59 UTC (rev 273212)
@@ -69,6 +69,8 @@
assert_equals(devices[0].kind, "audioinput");
assert_equals(devices[0].label, "my mic");
+const micStream = await navigator.mediaDevices.getUserMedia({ audio : { deviceId : "id2" } });
+assert_equals(micStream.getAudioTracks()[0].label, "my mic");
}, "'devicechange' event fired when device list changes");
promise_test(async (test) => {
Modified: trunk/Source/WebKit/ChangeLog (273211 => 273212)
--- trunk/Source/WebKit/ChangeLog 2021-02-21 00:47:59 UTC (rev 273211)
+++ trunk/Source/WebKit/ChangeLog 2021-02-21 01:06:59 UTC (rev 273212)
@@ -1,3 +1,32 @@
+2021-02-20 Youenn Fablet
+
+Add support for adding/removing/clearing mock devices in GPUProcess
+https://bugs.webkit.org/show_bug.cgi?id=222174
+
+Reviewed by Eric Carlson.
+
+Make sure to forward mock device orders to GPU process so that it is kept in sync with UIProcess.
+Covered by updated test.
+
+* GPUProcess/GPUProcess.cpp:
+(WebKit::GPUProcess::addMockMediaDevice):
+(WebKit::GPUProcess::clearMockMediaDevices):
+(WebKit::GPUProcess::removeMockMediaDevice):
+(WebKit::GPUProcess::resetMockMediaDevices):
+* GPUProcess/GPUProcess.h:
+* GPUProcess/GPUProcess.messages.in:
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::addMockMediaDevice):
+(WebKit::GPUProcessProxy::clearMockMediaDevices):
+(WebKit::GPUProcessProxy::removeMockMediaDevice):
+(WebKit::GPUProcessProxy::resetMockMediaDevices):
+* UIProcess/GPU/GPUProcessProxy.h:
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::addMockMediaDevice):
+(WebKit::WebProcessPool::clearMockMediaDevices):
+(WebKit::WebProcessPool::removeMockMediaDevice):
+(WebKit::WebProcessPool::resetMockMediaDevices):
+
2021-02-20 Jiewen Tan
PCM: Store and report source unlinkable tokens
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.cpp (273211 => 273212)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2021-02-21 00:47:59 UTC (rev 273211)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2021-02-21 01:06:59 UTC (rev 273212)
@@ -228,6 +228,26 @@
completionHandler();
}
+
+void GPUProcess::addMockMediaDevice(const WebCore::MockMediaDevice& device)
+{
+MockRealtimeMediaSourceCente
[webkit-changes] [273213] trunk
Title: [273213] trunk
Revision 273213
Author peng.l...@apple.com
Date 2021-02-20 18:05:38 -0800 (Sat, 20 Feb 2021)
Log Message
Video elements do not work as sources for TexImage2D calls in GPU Process
https://bugs.webkit.org/show_bug.cgi?id=218184
Reviewed by Jer Noble.
Source/WebCore:
Add a function `GraphicsContextGL::copyTextureFromMedia()` which can be used by the graphics
context to copy video texture from a video element (player).
This patch also replaces `MediaPlayer::copyVideoTextureToPlatformTexture()` with
`MediaPlayer::pixelBufferForCurrentTime()` on Cocoa ports. The motivation is that
`RemoteGraphicsContextGL::copyTextureFromMedia()` will run in a background thread
("RemoteGraphicsContextGL work queue") and it is difficult to make
`MediaPlayer::copyVideoTextureToPlatformTexture()` thread-safe. In addition, we cannot
simply run it on the main thread because it uses graphic context internally. Adding a
function `MediaPlayer::pixelBufferForCurrentTime()` solves the problem.
Manually tested.
We need to enable both "GPU Process: Media" and "GPU Process: WebGL" to test the feature.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::copyVideoTextureToPlatformTexture): Deleted.
* html/HTMLVideoElement.h:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texImageSourceHelper):
* platform/graphics/GraphicsContextGL.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::pixelBufferForCurrentTime):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::pixelBufferForCurrentTime):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::pixelBufferForCurrentTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::copyVideoTextureToPlatformTexture): Deleted.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pixelBufferForCurrentTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::copyVideoTextureToPlatformTexture): Deleted.
* platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia):
* platform/graphics/opengl/GraphicsContextGLOpenGL.h:
Source/WebKit:
Add an IPC message `RemoteGraphicsContextGL::CopyTextureFromMedia` to implement
`RemoteGraphicsContextGLProxy::copyTextureFromMedia()` in the Web process.
* GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::copyTextureFromMedia):
* GPUProcess/graphics/RemoteGraphicsContextGL.h:
We should use `m_gpuConnectionToWebProcess` in the main thread only.
* GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
* WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::copyTextureFromMedia):
* WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
* WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
Tools:
* Scripts/generate-gpup-webgl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLVideoElement.cpp
trunk/Source/WebCore/html/HTMLVideoElement.h
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContextGL.h
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
trunk/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
trunk/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/generate-gpup-webgl
Diff
Modified: trunk/Source/WebCore/ChangeLog (273212 => 273213)
--- trunk/Source/WebCore/ChangeLog 2021-02-21 01:06:59 UTC (rev 273212)
+++ trunk/Source/WebCore/ChangeLog 2021-02-21 02:05:38 UTC (rev 273213)
@@ -1,
[webkit-changes] [273214] trunk
Title: [273214] trunk Revision 273214 Author cfleiz...@apple.com Date 2021-02-20 20:15:52 -0800 (Sat, 20 Feb 2021) Log Message AX: Image should report the embedded accessibility description if available https://bugs.webkit.org/show_bug.cgi?id=221875 Reviewed by Jer Noble. Source/WebCore: Check if images have accessibility description metadata and expose that to the AX API. Test: accessibility/embedded-image-description.html * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::embeddedImageDescription const): * accessibility/AccessibilityObject.h: * accessibility/AccessibilityObjectInterface.h: * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper _accessibilityPhotoDescription]): * accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeAttributeData): * accessibility/isolatedtree/AXIsolatedObject.h: * accessibility/isolatedtree/AXIsolatedTree.h: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): * platform/cf/MediaAccessibilitySoftLink.cpp: * platform/cf/MediaAccessibilitySoftLink.h: * platform/graphics/BitmapImage.h: * platform/graphics/Image.h: (WebCore::Image::accessibilityDescription const): * platform/graphics/ImageDecoder.h: * platform/graphics/ImageSource.cpp: (WebCore::ImageSource::accessibilityDescription): * platform/graphics/ImageSource.h: * platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h: * platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::ImageDecoderCG::accessibilityDescription const): * platform/graphics/cg/ImageDecoderCG.h: * rendering/RenderImage.h: (WebCore::RenderImage::accessibilityDescription const): Source/WebCore/PAL: * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/MediaAccessibilitySPI.h: Added. Source/WebKit: * WebProcess/GPU/media/RemoteImageDecoderAVF.h: Tools: * DumpRenderTree/AccessibilityUIElement.cpp: (getEmbeddedImageDescription): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::embeddedImageDescription const): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::embeddedImageDescription const): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::embeddedImageDescription const): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::embeddedImageDescription const): LayoutTests: * accessibility/embedded-image-description-expected.txt: Added. * accessibility/embedded-image-description.html: Added. * accessibility/resources/embedded-image-description-example.jpg: Added. * platform/ios-simulator/TestExpectations: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/image-link-expected.txt trunk/LayoutTests/platform/ios-simulator/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj trunk/Source/WebCore/PAL/pal/PlatformAppleWin.cmake trunk/Source/WebCore/PAL/pal/PlatformMac.cmake trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm trunk/Source/WebCore/platform/cf/MediaAccessibilitySoftLink.cpp trunk/Source/WebCore/platform/cf/MediaAccessibilitySoftLink.h trunk/Source/WebCore/platform/graphics/BitmapImage.h trunk/Source/WebCore/platform/graphics/Image.h trunk/Source/WebCore/platform/graphics/ImageDecoder.h trunk/Source/WebCore/platform/graphics/ImageSource.cpp trunk/Source/WebCore/platform/graphics/ImageSource.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.h trunk/Source/WebCore/rendering/RenderImage.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp trunk/Tools/DumpRenderTree/AccessibilityUIElement.h trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm trunk/Tools/WebKitTestRunner/I
[webkit-changes] [273215] trunk/Source/WebKit
Title: [273215] trunk/Source/WebKit
Revision 273215
Author bb...@apple.com
Date 2021-02-20 20:24:31 -0800 (Sat, 20 Feb 2021)
Log Message
[Cocoa] Web Inspector: expose the WKBrowsingContextHandle associated with Web Inspector's page
https://bugs.webkit.org/show_bug.cgi?id=26
Reviewed by Timothy Hatcher.
In order to implement browser.devtools.inspectedWindow.tabId for Web Extensions,
we need a way to do a reverse lookup of the tabId using the current browsing context
controller (WKWebProcessPlugInBrowserContextController) in the injected bundle.
This patch exposes the browsing context handle for the underlying WKWebView that
hosts the inspector page. Clients can use this to precompute a tabId for each
inspector browsing context that may be encountered by injected bundle code.
* UIProcess/API/Cocoa/_WKInspectorPrivate.h:
* UIProcess/API/Cocoa/_WKInspector.mm:
(-[_WKInspector handle]): Added.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::classesForCoder):
Drive-by, make it possible to use WKBrowsingContextHandle in injected bundle parameters.
This is easy because it conforms to NSSecureCoding and is simply a pageId + frameId.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivate.h
trunk/Source/WebKit/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (273214 => 273215)
--- trunk/Source/WebKit/ChangeLog 2021-02-21 04:15:52 UTC (rev 273214)
+++ trunk/Source/WebKit/ChangeLog 2021-02-21 04:24:31 UTC (rev 273215)
@@ -1,3 +1,27 @@
+2021-02-20 BJ Burg
+
+[Cocoa] Web Inspector: expose the WKBrowsingContextHandle associated with Web Inspector's page
+https://bugs.webkit.org/show_bug.cgi?id=26
+
+Reviewed by Timothy Hatcher.
+
+In order to implement browser.devtools.inspectedWindow.tabId for Web Extensions,
+we need a way to do a reverse lookup of the tabId using the current browsing context
+controller (WKWebProcessPlugInBrowserContextController) in the injected bundle.
+
+This patch exposes the browsing context handle for the underlying WKWebView that
+hosts the inspector page. Clients can use this to precompute a tabId for each
+inspector browsing context that may be encountered by injected bundle code.
+
+* UIProcess/API/Cocoa/_WKInspectorPrivate.h:
+* UIProcess/API/Cocoa/_WKInspector.mm:
+(-[_WKInspector handle]): Added.
+
+* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
+(WebKit::InjectedBundle::classesForCoder):
+Drive-by, make it possible to use WKBrowsingContextHandle in injected bundle parameters.
+This is easy because it conforms to NSSecureCoding and is simply a pageId + frameId.
+
2021-02-20 Chris Fleizach
AX: Image should report the embedded accessibility description if available
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm (273214 => 273215)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm 2021-02-21 04:15:52 UTC (rev 273214)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm 2021-02-21 04:24:31 UTC (rev 273215)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2018 Apple Inc. All rights reserved.
+ * Copyright (C) 2018-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -169,6 +169,11 @@
_inspector->setDiagnosticLoggingAvailable(!!delegate);
}
+- (WKBrowsingContextHandle *)handle
+{
+return self.inspectorWebView._handle;
+}
+
// MARK: _WKInspectorInternal methods
- (API::Object&)_apiObject
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivate.h (273214 => 273215)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivate.h 2021-02-21 04:15:52 UTC (rev 273214)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivate.h 2021-02-21 04:24:31 UTC (rev 273215)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2019-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -25,6 +25,7 @@
#import "_WKInspector.h"
+@class WKBrowsingContextHandle;
@protocol _WKDiagnosticLoggingDelegate;
@interface _WKInspector (WKPrivate)
@@ -31,4 +32,11 @@
@property (nonatomic, weak, setter=_setDiagnosticLoggingDelegate:) id<_WKDiagnosticLoggingDelegate> _diagnosticLoggingDelegate;
+/**
+ * @abstract The browsing context handle associated with Web Inspector's user interface.
+ * @discussion This can be used to identify the inspector page and any associated subframes
+ * from within the injected bundle.
+ */
+@property (nonatomic, readonly) WKBrowsingContextHandle *handle;
+
@end
[webkit-changes] [273216] trunk/Source/WebKit
Title: [273216] trunk/Source/WebKit
Revision 273216
Author bfulg...@apple.com
Date 2021-02-20 23:27:31 -0800 (Sat, 20 Feb 2021)
Log Message
[Cocoa] Update WebCoreArgumentCodersMac with some new additions
https://bugs.webkit.org/show_bug.cgi?id=42
Reviewed by Tim Horton.
Will be tested by new API Tests in a subsequent patch.
* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder::encodePlatformData):
(IPC::ArgumentCoder::decodePlatformData):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (273215 => 273216)
--- trunk/Source/WebKit/ChangeLog 2021-02-21 04:24:31 UTC (rev 273215)
+++ trunk/Source/WebKit/ChangeLog 2021-02-21 07:27:31 UTC (rev 273216)
@@ -1,3 +1,17 @@
+2021-02-20 Brent Fulgham
+
+[Cocoa] Update WebCoreArgumentCodersMac with some new additions
+https://bugs.webkit.org/show_bug.cgi?id=42
+
+
+Reviewed by Tim Horton.
+
+Will be tested by new API Tests in a subsequent patch.
+
+* Shared/mac/WebCoreArgumentCodersMac.mm:
+(IPC::ArgumentCoder::encodePlatformData):
+(IPC::ArgumentCoder::decodePlatformData):
+
2021-02-20 BJ Burg
[Cocoa] Web Inspector: expose the WKBrowsingContextHandle associated with Web Inspector's page
Modified: trunk/Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm (273215 => 273216)
--- trunk/Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm 2021-02-21 04:24:31 UTC (rev 273215)
+++ trunk/Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm 2021-02-21 07:27:31 UTC (rev 273216)
@@ -42,6 +42,10 @@
#import
#import
+#if USE(APPLE_INTERNAL_SDK)
+#include
+#endif
+
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
#import
#import
@@ -48,6 +52,14 @@
#import
#endif
+#ifndef WEBCORE_ARGUMENTCODERS_MAC_DECODE_ADDITIONS
+#define WEBCORE_ARGUMENTCODERS_MAC_DECODE_ADDITIONS
+#endif
+
+#ifndef WEBCORE_ARGUMENTCODERS_MAC_ENCODE_ADDITIONS
+#define WEBCORE_ARGUMENTCODERS_MAC_ENCODE_ADDITIONS
+#endif
+
namespace IPC {
static RetainPtr createSerializableRepresentation(CFIndex version, CFTypeRef* objects, CFIndex objectCount, CFDictionaryRef protocolProperties, CFNumberRef expectedContentLength, CFStringRef mimeType, CFTypeRef tokenNull)
@@ -209,6 +221,8 @@
auto dictionary = createSerializableRepresentation(requestToSerialize.get(), IPC::tokenNullptrTypeRef());
IPC::encode(encoder, dictionary.get());
+WEBCORE_ARGUMENTCODERS_MAC_ENCODE_ADDITIONS
+
// The fallback array is part of NSURLRequest, but it is not encoded by WKNSURLRequestCreateSerializableRepresentation.
encoder << resourceRequest.responseContentDispositionEncodingFallbackArray();
encoder << resourceRequest.requester();
@@ -235,6 +249,8 @@
if (!nsURLRequest)
return false;
+WEBCORE_ARGUMENTCODERS_MAC_DECODE_ADDITIONS
+
resourceRequest = WebCore::ResourceRequest(nsURLRequest.get());
Vector responseContentDispositionEncodingFallbackArray;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
