[webkit-changes] [273875] trunk

[commit-queue]

Title: [273875] trunk








Revision 273875
Author commit-qu...@webkit.org
Date 2021-03-03 23:22:33 -0800 (Wed, 03 Mar 2021)


Log Message
WKRemoteObjectCoder should be able to handle NSErrors from TLS failures
https://bugs.webkit.org/show_bug.cgi?id=222401
Source/WebKit:



Patch by Alex Christensen  on 2021-03-03
Reviewed by Chris Dumez.

NSErrors from TLS failures contain values like a SecTrustRef or a SecCertificateRef,
which are not ObjC objects, and they don't like it when you call encodeWithCoder: on them.
Until r273141 it would crash when we do, but even after that we just decode a nil NSError.
Add a special case like we did in encodeNSError to successfully encode and decode these errors.

* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(decodeObjCObject):
(transformCertificatesToData):
(transformTrustToData):
(encodeError):
(transformDataToCertificates):
(transformDataToTrust):
(decodeError):
(encodeObject):
(decodeObject):

Tools:

Patch by Alex Christensen  on 2021-03-03
Reviewed by Chris Dumez.

* TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
* TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
(-[RemoteObjectRegistryPlugIn sendError:completionHandler:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (273874 => 273875)

--- trunk/Source/WebKit/ChangeLog	2021-03-04 06:13:44 UTC (rev 273874)
+++ trunk/Source/WebKit/ChangeLog	2021-03-04 07:22:33 UTC (rev 273875)
@@ -1,5 +1,29 @@
 2021-03-03  Alex Christensen  
 
+WKRemoteObjectCoder should be able to handle NSErrors from TLS failures
+https://bugs.webkit.org/show_bug.cgi?id=222401
+
+
+Reviewed by Chris Dumez.
+
+NSErrors from TLS failures contain values like a SecTrustRef or a SecCertificateRef,
+which are not ObjC objects, and they don't like it when you call encodeWithCoder: on them.
+Until r273141 it would crash when we do, but even after that we just decode a nil NSError.
+Add a special case like we did in encodeNSError to successfully encode and decode these errors.
+
+* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
+(decodeObjCObject):
+(transformCertificatesToData):
+(transformTrustToData):
+(encodeError):
+(transformDataToCertificates):
+(transformDataToTrust):
+(decodeError):
+(encodeObject):
+(decodeObject):
+
+2021-03-03  Alex Christensen  
+
 Limit HashTable entry size to 500 bytes
 https://bugs.webkit.org/show_bug.cgi?id=222658
 


Modified: trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm (273874 => 273875)

--- trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm	2021-03-04 06:13:44 UTC (rev 273874)
+++ trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm	2021-03-04 07:22:33 UTC (rev 273875)
@@ -33,6 +33,7 @@
 #import "APIString.h"
 #import "Logging.h"
 #import "NSInvocationSPI.h"
+#import "_WKErrorRecoveryAttempting.h"
 #import "_WKRemoteObjectInterfaceInternal.h"
 #import 
 #import 
@@ -299,6 +300,120 @@
 encoder->_currentDictionary->set(stringKey, API::String::create(string));
 }
 
+static RetainPtr decodeObjCObject(WKRemoteObjectDecoder *decoder, Class objectClass)
+{
+id allocation = [objectClass allocWithZone:decoder.zone];
+if (!allocation)
+[NSException raise:NSInvalidUnarchiveOperationException format:@"Class \"%@\" returned nil from +alloc while being decoded", NSStringFromClass(objectClass)];
+
+RetainPtr result = adoptNS([allocation initWithCoder:decoder]);
+if (!result)
+[NSException raise:NSInvalidUnarchiveOperationException format:@"Object of class \"%@\" returned nil from -initWithCoder: while being decoded", NSStringFromClass(objectClass)];
+
+result = [result awakeAfterUsingCoder:decoder];
+if (!result)
+[NSException raise:NSInvalidUnarchiveOperationException format:@"Object of class \"%@\" returned nil from -awakeAfterUsingCoder: while being decoded", NSStringFromClass(objectClass)];
+
+return result;
+}
+
+static constexpr NSString *peerCertificateKey = @"NSErrorPeerCertificateChainKey";
+static constexpr NSString *peerTrustKey = @"NSURLErrorFailingURLPeerTrustErrorKey";
+static constexpr NSString *clientCertificateKey = @"NSErrorClientCertificateChainKey";
+
+static RetainPtr> transformCertificatesToData(NSArray *input)
+{
+auto dataArray = adoptNS([[NSMutableArray alloc] initWithCapacity:input.count]);
+for (id certificate in input) {
+if (CFGetTypeID(certificate) != SecCertificateGetTypeID())
+[NSException raise:NSInvalidArgumentE

[webkit-changes] [273874] trunk/JSTests

[ysuzuki]

Title: [273874] trunk/JSTests








Revision 273874
Author ysuz...@apple.com
Date 2021-03-03 22:13:44 -0800 (Wed, 03 Mar 2021)


Log Message
[JSC] Update test262
https://bugs.webkit.org/show_bug.cgi?id=222710

Reviewed by Ross Kirsling.

Update test262. New failure is due to the spec change, tracked in https://bugs.webkit.org/show_bug.cgi?id=222526.

* test262/expectations.yaml:
* test262/latest-changes-summary.txt:
* test262/test/built-ins/Array/prototype/sort/call-with-primitive.js: Added.
* test262/test/built-ins/Function/internals/Call/class-ctor-realm.js:
* test262/test/language/expressions/object/dstr/object-rest-proxy-get-not-called-on-dontenum-keys.js: Added.
(getOwnPropertyDescriptor):
(ownKeys):
* test262/test/language/expressions/object/dstr/object-rest-proxy-gopd-not-called-on-excluded-keys.js: Added.
(getOwnPropertyDescriptor):
(ownKeys):
* test262/test/language/expressions/object/object-spread-proxy-get-not-called-on-dontenum-keys.js: Added.
(getOwnPropertyDescriptor):
(ownKeys):
* test262/test/language/expressions/object/object-spread-proxy-no-excluded-keys.js: Copied from JSTests/test262/test/language/expressions/object/object-spread-proxy-ownkeys-returned-keys-order.js.
(getOwnPropertyDescriptor):
(ownKeys):
* test262/test/language/expressions/object/object-spread-proxy-ownkeys-returned-keys-order.js:
* test262/test/language/statements/class/constructor-inferred-observable-iteration.js: Removed.
* test262/test/language/statements/class/subclass/default-constructor-spread-override.js:
(Array.prototype.Symbol.iterator):
(Base):
* test262/test262-Revision.txt:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/JSTests/test262/latest-changes-summary.txt
trunk/JSTests/test262/test/built-ins/Function/internals/Call/class-ctor-realm.js
trunk/JSTests/test262/test/language/expressions/object/object-spread-proxy-ownkeys-returned-keys-order.js
trunk/JSTests/test262/test/language/statements/class/subclass/default-constructor-spread-override.js
trunk/JSTests/test262/test262-Revision.txt


Added Paths

trunk/JSTests/test262/test/built-ins/Array/prototype/sort/call-with-primitive.js
trunk/JSTests/test262/test/language/expressions/object/dstr/object-rest-proxy-get-not-called-on-dontenum-keys.js
trunk/JSTests/test262/test/language/expressions/object/dstr/object-rest-proxy-gopd-not-called-on-excluded-keys.js
trunk/JSTests/test262/test/language/expressions/object/object-spread-proxy-get-not-called-on-dontenum-keys.js
trunk/JSTests/test262/test/language/expressions/object/object-spread-proxy-no-excluded-keys.js


Removed Paths

trunk/JSTests/test262/test/language/statements/class/constructor-inferred-observable-iteration.js




Diff

Modified: trunk/JSTests/ChangeLog (273873 => 273874)

--- trunk/JSTests/ChangeLog	2021-03-04 05:59:26 UTC (rev 273873)
+++ trunk/JSTests/ChangeLog	2021-03-04 06:13:44 UTC (rev 273874)
@@ -1,3 +1,35 @@
+2021-03-03  Yusuke Suzuki  
+
+[JSC] Update test262
+https://bugs.webkit.org/show_bug.cgi?id=222710
+
+Reviewed by Ross Kirsling.
+
+Update test262. New failure is due to the spec change, tracked in https://bugs.webkit.org/show_bug.cgi?id=222526.
+
+* test262/expectations.yaml:
+* test262/latest-changes-summary.txt:
+* test262/test/built-ins/Array/prototype/sort/call-with-primitive.js: Added.
+* test262/test/built-ins/Function/internals/Call/class-ctor-realm.js:
+* test262/test/language/expressions/object/dstr/object-rest-proxy-get-not-called-on-dontenum-keys.js: Added.
+(getOwnPropertyDescriptor):
+(ownKeys):
+* test262/test/language/expressions/object/dstr/object-rest-proxy-gopd-not-called-on-excluded-keys.js: Added.
+(getOwnPropertyDescriptor):
+(ownKeys):
+* test262/test/language/expressions/object/object-spread-proxy-get-not-called-on-dontenum-keys.js: Added.
+(getOwnPropertyDescriptor):
+(ownKeys):
+* test262/test/language/expressions/object/object-spread-proxy-no-excluded-keys.js: Copied from JSTests/test262/test/language/expressions/object/object-spread-proxy-ownkeys-returned-keys-order.js.
+(getOwnPropertyDescriptor):
+(ownKeys):
+* test262/test/language/expressions/object/object-spread-proxy-ownkeys-returned-keys-order.js:
+* test262/test/language/statements/class/constructor-inferred-observable-iteration.js: Removed.
+* test262/test/language/statements/class/subclass/default-constructor-spread-override.js:
+(Array.prototype.Symbol.iterator):
+(Base):
+* test262/test262-Revision.txt:
+
 2021-03-03  Caio Lima  
 
 [ESNext] Private methods can't be named as '#constructor'


Modified: trunk/JSTests/test262/expectations.yaml (273873 => 273874)

--- trunk/JSTests/test262/expectations.yaml	2021-03-04 05:59:26 UTC (rev 273873)
+++ trunk/JSTests/test262/expectations.yaml	2021-03-04 06:13:44 UTC (rev 273874)
@@ -606,9 +606,6 @@
 te

[webkit-changes] [273873] trunk/Source/WebCore

[commit-queue]

Title: [273873] trunk/Source/WebCore








Revision 273873
Author commit-qu...@webkit.org
Date 2021-03-03 21:59:26 -0800 (Wed, 03 Mar 2021)


Log Message
Remove RemoteCommandListenerIOS in favor of a common RemoteCommandListenerCocoa
https://bugs.webkit.org/show_bug.cgi?id=222342
rdar://problem/74773837

Patch by Jean-Yves Avenard  on 2021-03-03
Reviewed by Eric Carlson.

There is no change in behavior with this commit.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/RemoteCommandListener.cpp:
(WebCore::RemoteCommandListener::resetCreationFunction):
* platform/cocoa/RemoteCommandListenerCocoa.h: Renamed from Source/WebCore/platform/mac/RemoteCommandListenerMac.h.
* platform/cocoa/RemoteCommandListenerCocoa.mm: Renamed from Source/WebCore/platform/mac/RemoteCommandListenerMac.mm.
(WebCore::RemoteCommandListenerCocoa::create):
(WebCore::RemoteCommandListenerCocoa::defaultCommands):
(WebCore::RemoteCommandListenerCocoa::updateSupportedCommands):
(WebCore::RemoteCommandListenerCocoa::RemoteCommandListenerCocoa):
(WebCore::RemoteCommandListenerCocoa::~RemoteCommandListenerCocoa):
* platform/ios/RemoteCommandListenerIOS.h: Removed.
* platform/ios/RemoteCommandListenerIOS.mm: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/RemoteCommandListener.cpp


Added Paths

trunk/Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.h
trunk/Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.mm


Removed Paths

trunk/Source/WebCore/platform/ios/RemoteCommandListenerIOS.h
trunk/Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm
trunk/Source/WebCore/platform/mac/RemoteCommandListenerMac.h
trunk/Source/WebCore/platform/mac/RemoteCommandListenerMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (273872 => 273873)

--- trunk/Source/WebCore/ChangeLog	2021-03-04 05:00:08 UTC (rev 273872)
+++ trunk/Source/WebCore/ChangeLog	2021-03-04 05:59:26 UTC (rev 273873)
@@ -1,3 +1,27 @@
+2021-03-03  Jean-Yves Avenard  
+
+Remove RemoteCommandListenerIOS in favor of a common RemoteCommandListenerCocoa
+https://bugs.webkit.org/show_bug.cgi?id=222342
+rdar://problem/74773837
+
+Reviewed by Eric Carlson.
+
+There is no change in behavior with this commit.
+
+* SourcesCocoa.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/RemoteCommandListener.cpp:
+(WebCore::RemoteCommandListener::resetCreationFunction):
+* platform/cocoa/RemoteCommandListenerCocoa.h: Renamed from Source/WebCore/platform/mac/RemoteCommandListenerMac.h.
+* platform/cocoa/RemoteCommandListenerCocoa.mm: Renamed from Source/WebCore/platform/mac/RemoteCommandListenerMac.mm.
+(WebCore::RemoteCommandListenerCocoa::create):
+(WebCore::RemoteCommandListenerCocoa::defaultCommands):
+(WebCore::RemoteCommandListenerCocoa::updateSupportedCommands):
+(WebCore::RemoteCommandListenerCocoa::RemoteCommandListenerCocoa):
+(WebCore::RemoteCommandListenerCocoa::~RemoteCommandListenerCocoa):
+* platform/ios/RemoteCommandListenerIOS.h: Removed.
+* platform/ios/RemoteCommandListenerIOS.mm: Removed.
+
 2021-03-03  Alex Christensen  
 
 Limit HashTable entry size to 500 bytes


Modified: trunk/Source/WebCore/SourcesCocoa.txt (273872 => 273873)

--- trunk/Source/WebCore/SourcesCocoa.txt	2021-03-04 05:00:08 UTC (rev 273872)
+++ trunk/Source/WebCore/SourcesCocoa.txt	2021-03-04 05:59:26 UTC (rev 273873)
@@ -251,6 +251,7 @@
 platform/cocoa/PlatformPasteboardCocoa.mm
 platform/cocoa/PlaybackSessionModelMediaElement.mm
 platform/cocoa/PowerSourceNotifier.mm
+platform/cocoa/RemoteCommandListenerCocoa.mm
 platform/cocoa/RuntimeApplicationChecksCocoa.mm
 platform/cocoa/SearchPopupMenuCocoa.mm
 platform/cocoa/SharedBufferCocoa.mm
@@ -452,7 +453,6 @@
 platform/ios/PlaybackSessionInterfaceAVKit.mm @no-unify
 platform/ios/PreviewConverterIOS.mm
 platform/ios/QuickLook.mm
-platform/ios/RemoteCommandListenerIOS.mm
 platform/ios/ScrollAnimatorIOS.mm
 platform/ios/ScrollViewIOS.mm
 platform/ios/ScrollbarThemeIOS.mm
@@ -500,7 +500,6 @@
 platform/mac/PluginBlocklist.mm
 platform/mac/PowerObserverMac.cpp
 platform/mac/PublicSuffixMac.mm
-platform/mac/RemoteCommandListenerMac.mm
 platform/mac/SSLKeyGeneratorMac.mm
 platform/mac/ScrollAnimatorMac.mm @no-unify
 platform/mac/ScrollController.mm


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (273872 => 273873)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-03-04 05:00:08 UTC (rev 273872)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-03-04 05:59:26 UTC (rev 273873)
@@ -1433,6 +1433,7 @@
 		510D4A37103165EE0049EA54 /* SocketStreamHandle.h in Headers */ = {isa = PBXBuildFile; fileRef = 510D4A31103165EE0049EA54 /* SocketStreamHandle.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		510D4A38103165EE00

[webkit-changes] [273872] trunk/Source

[commit-queue]

Title: [273872] trunk/Source








Revision 273872
Author commit-qu...@webkit.org
Date 2021-03-03 21:00:08 -0800 (Wed, 03 Mar 2021)


Log Message
Limit HashTable entry size to 500 bytes
https://bugs.webkit.org/show_bug.cgi?id=222658

Patch by Alex Christensen  on 2021-03-03
Reviewed by Yusuke Suzuki.

Source/WebCore:

Moving large structures inside HashTables is slower than just moving a pointer.
There is a point at which it becomes more efficient to add a separate allocation
rather than have gigantic HashTables that use all that memory for each empty slot
and use all those read and write operations to move when rehashing.  I'm not sure
exactly where that point is, but I'm pretty sure it's less than 500 bytes.  This
introduces a limit and removes the two largest HashTables in WebKit, replacing their
values with std::unique_ptr to save memory and time.

* Modules/cache/DOMCacheEngine.h:
* platform/network/NetworkLoadInformation.h:

Source/WebKit:

* NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::getNetworkLoadInformationResponse):
(WebKit::NetworkConnectionToWebProcess::getNetworkLoadIntermediateInformation):
(WebKit::NetworkConnectionToWebProcess::takeNetworkLoadInformationMetrics):
(WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformation):
(WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics):
* NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::writeRecord):
(WebKit::CacheStorage::Caches::readRecord):
* NetworkProcess/cache/CacheStorageEngineCaches.h:

Source/WTF:

* wtf/HashTable.h:
(WTF::KeyTraits>::inlineLookup):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashTable.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h
trunk/Source/WebCore/platform/network/NetworkLoadInformation.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp
trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h




Diff

Modified: trunk/Source/WTF/ChangeLog (273871 => 273872)

--- trunk/Source/WTF/ChangeLog	2021-03-04 04:35:28 UTC (rev 273871)
+++ trunk/Source/WTF/ChangeLog	2021-03-04 05:00:08 UTC (rev 273872)
@@ -1,3 +1,13 @@
+2021-03-03  Alex Christensen  
+
+Limit HashTable entry size to 500 bytes
+https://bugs.webkit.org/show_bug.cgi?id=222658
+
+Reviewed by Yusuke Suzuki.
+
+* wtf/HashTable.h:
+(WTF::KeyTraits>::inlineLookup):
+
 2021-03-03  Yusuke Suzuki  
 
 [JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE)


Modified: trunk/Source/WTF/wtf/HashTable.h (273871 => 273872)

--- trunk/Source/WTF/wtf/HashTable.h	2021-03-04 04:35:28 UTC (rev 273871)
+++ trunk/Source/WTF/wtf/HashTable.h	2021-03-04 05:00:08 UTC (rev 273872)
@@ -665,6 +665,8 @@
 template
 ALWAYS_INLINE auto HashTable::inlineLookup(const T& key) -> ValueType*
 {
+static_assert(sizeof(Key) + sizeof(Value) < 500, "Your HashTable types are too big to efficiently move when rehashing.  Consider using std::unique_ptr instead");
+
 checkKey(key);
 
 unsigned k = 0;


Modified: trunk/Source/WebCore/ChangeLog (273871 => 273872)

--- trunk/Source/WebCore/ChangeLog	2021-03-04 04:35:28 UTC (rev 273871)
+++ trunk/Source/WebCore/ChangeLog	2021-03-04 05:00:08 UTC (rev 273872)
@@ -1,3 +1,21 @@
+2021-03-03  Alex Christensen  
+
+Limit HashTable entry size to 500 bytes
+https://bugs.webkit.org/show_bug.cgi?id=222658
+
+Reviewed by Yusuke Suzuki.
+
+Moving large structures inside HashTables is slower than just moving a pointer.
+There is a point at which it becomes more efficient to add a separate allocation
+rather than have gigantic HashTables that use all that memory for each empty slot
+and use all those read and write operations to move when rehashing.  I'm not sure
+exactly where that point is, but I'm pretty sure it's less than 500 bytes.  This
+introduces a limit and removes the two largest HashTables in WebKit, replacing their
+values with std::unique_ptr to save memory and time.
+
+* Modules/cache/DOMCacheEngine.h:
+* platform/network/NetworkLoadInformation.h:
+
 2021-03-03  Andres Gonzalez  
 
 Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.


Modified: trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h (273871 => 273872)

--- trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h	2021-03-04 04:35:28 UTC (rev 273871)
+++ trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h	2021-03-04 05:00:08 UTC (rev 273872)
@@ -61,6 +61,7 @@
 WEBCORE_EXPORT ResponseBody copyResponseBody(const ResponseBody&);
 
 struct Record {
+WTF_MAKE_STRUCT_FAST_ALLOCATED;
 WEBCORE_EXPORT Record copy() const;
 
 uint64_t identifier;


Modified: trunk/Source/We

[webkit-changes] [273871] trunk/LayoutTests

[ryanhaddad]

Title: [273871] trunk/LayoutTests








Revision 273871
Author ryanhad...@apple.com
Date 2021-03-03 20:35:28 -0800 (Wed, 03 Mar 2021)


Log Message
[ Catalina wk1 ews ] media/remote-control-command-seek.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215325

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations: Update test expectations since EWS moved to Catalina.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (273870 => 273871)

--- trunk/LayoutTests/ChangeLog	2021-03-04 04:19:56 UTC (rev 273870)
+++ trunk/LayoutTests/ChangeLog	2021-03-04 04:35:28 UTC (rev 273871)
@@ -1,3 +1,12 @@
+2021-03-03  Ryan Haddad  
+
+[ Catalina wk1 ews ] media/remote-control-command-seek.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=215325
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations: Update test expectations since EWS moved to Catalina.
+
 2021-03-03  Andres Gonzalez  
 
 Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (273870 => 273871)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-03-04 04:19:56 UTC (rev 273870)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-03-04 04:35:28 UTC (rev 273871)
@@ -1203,7 +1203,7 @@
 
 webkit.org/b/217478 imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-descendant-text-mutated-001.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/215325 [ Mojave ] media/remote-control-command-seek.html [ Pass Timeout ]
+webkit.org/b/215325 [ Catalina ] media/remote-control-command-seek.html [ Pass Timeout ]
 
 webkit.org/b/217934 inspector/debugger/breakpoint-resolve-when-script-added.html [ Skip ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273870] trunk/Source/WTF

[ysuzuki]

Title: [273870] trunk/Source/WTF








Revision 273870
Author ysuz...@apple.com
Date 2021-03-03 20:19:56 -0800 (Wed, 03 Mar 2021)


Log Message
[JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE)
https://bugs.webkit.org/show_bug.cgi?id=222695

Reviewed by Saam Barati.

HAVE(JIT_CAGE) is internally defined. We use HAVE(JIT_CAGE) when defining ENABLE(JIT_CAGE).

* wtf/PlatformEnable.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformEnable.h




Diff

Modified: trunk/Source/WTF/ChangeLog (273869 => 273870)

--- trunk/Source/WTF/ChangeLog	2021-03-04 02:31:17 UTC (rev 273869)
+++ trunk/Source/WTF/ChangeLog	2021-03-04 04:19:56 UTC (rev 273870)
@@ -1,3 +1,14 @@
+2021-03-03  Yusuke Suzuki  
+
+[JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE)
+https://bugs.webkit.org/show_bug.cgi?id=222695
+
+Reviewed by Saam Barati.
+
+HAVE(JIT_CAGE) is internally defined. We use HAVE(JIT_CAGE) when defining ENABLE(JIT_CAGE).
+
+* wtf/PlatformEnable.h:
+
 2021-03-03  Chris Dumez  
 
 Unreviewed, reverting r273851.


Modified: trunk/Source/WTF/wtf/PlatformEnable.h (273869 => 273870)

--- trunk/Source/WTF/wtf/PlatformEnable.h	2021-03-04 02:31:17 UTC (rev 273869)
+++ trunk/Source/WTF/wtf/PlatformEnable.h	2021-03-04 04:19:56 UTC (rev 273870)
@@ -891,7 +891,7 @@
 #error "ENABLE(WHLSL_COMPILER) requires ENABLE(WEBGPU)"
 #endif
 
-#if OS(DARWIN) && ENABLE(JIT) && USE(APPLE_INTERNAL_SDK) && CPU(ARM64E) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 12))
+#if OS(DARWIN) && ENABLE(JIT) && USE(APPLE_INTERNAL_SDK) && CPU(ARM64E) && HAVE(JIT_CAGE)
 #define ENABLE_JIT_CAGE 1
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273869] trunk

[andresg_22]

Title: [273869] trunk








Revision 273869
Author andresg...@apple.com
Date 2021-03-03 18:31:17 -0800 (Wed, 03 Mar 2021)


Log Message
Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.
https://bugs.webkit.org/show_bug.cgi?id=221707

Reviewed by Chris Fleizach.

Source/WebCore:

Instead of having a postXXXNotification method per notification in the
iOS WebAccessibilitObjectWrapper implementation, we now have a single
method that takes the name of the notification. This cleans up the
existing notification posting code and simplifies adding new notifications.

* accessibility/AXLogger.cpp:
(WebCore::operator<<): Added a new notification constant AXPageScrolled.
* accessibility/AXObjectCache.h:
* accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::notificationPlatformName):
Handles all notifications used on iOS.
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityScroll:]):
Uses the helper AXObjectCache::notificationPlatformName to get page scrolled notification name.
(-[WebAccessibilityObjectWrapper postFocusChangeNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postSelectedTextChangeNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postLayoutChangeNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postLiveRegionChangeNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postLiveRegionCreatedNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postLoadCompleteNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postChildrenChangedNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postInvalidStatusChangedNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postValueChangedNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postExpandedChangedNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postScrollStatusChangeNotification]): Deleted.
(-[WebAccessibilityObjectWrapper postCurrentStateChangedNotification]): Deleted.

LayoutTests:

The name of the notification is now "AXPageScrolled". Adjusted the script
and the expected output accordingly.

* accessibility/ios-simulator/scroll-in-overflow-div-expected.txt:
* accessibility/ios-simulator/scroll-in-overflow-div.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div-expected.txt
trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXLogger.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (273868 => 273869)

--- trunk/LayoutTests/ChangeLog	2021-03-04 02:13:28 UTC (rev 273868)
+++ trunk/LayoutTests/ChangeLog	2021-03-04 02:31:17 UTC (rev 273869)
@@ -1,3 +1,16 @@
+2021-03-03  Andres Gonzalez  
+
+Replace the multiple WebAccessibilityObjectWrapperIOS postXXXNotification methods with a single postNotification method.
+https://bugs.webkit.org/show_bug.cgi?id=221707
+
+Reviewed by Chris Fleizach.
+
+The name of the notification is now "AXPageScrolled". Adjusted the script
+and the expected output accordingly.
+
+* accessibility/ios-simulator/scroll-in-overflow-div-expected.txt:
+* accessibility/ios-simulator/scroll-in-overflow-div.html:
+
 2021-03-03  Devin Rousso  
 
 Web Inspector: `RecordCanvasActionVariant` causes a huge symbol to be created in WebCore


Modified: trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div-expected.txt (273868 => 273869)

--- trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div-expected.txt	2021-03-04 02:13:28 UTC (rev 273868)
+++ trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div-expected.txt	2021-03-04 02:31:17 UTC (rev 273869)
@@ -3,43 +3,43 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-AXScrollByPage received: data: AXScroll [position: 0.00 220.00]
+AXPageScrolled received: data: AXScroll [position: 0.00 220.00]
 scroll down 0 : success true
-AXScrollByPage received: data: AXScroll [position: 0.00 440.00]
+AXPageScrolled received: data: AXScroll [position: 0.00 440.00]
 scroll down 1 : success true
-AXScrollByPage received: data: AXScroll [position: 0.00 660.00]
+AXPageScrolled received: data: AXScroll [position: 0.00 660.00]
 scroll down 2 : success true
-AXScrollByPage received: data: AXScroll [position: 0.00 716.00]
+AXPageScrolled received: data: AXScroll [position: 0.00 716.00]
 scroll down 3 : success true
 scroll down 4 : success false
-AXScrollByPage received: dat

[webkit-changes] [273868] trunk/Source/WebCore

[commit-queue]

Title: [273868] trunk/Source/WebCore








Revision 273868
Author commit-qu...@webkit.org
Date 2021-03-03 18:13:28 -0800 (Wed, 03 Mar 2021)


Log Message
Crash in removeSymbolElementsFromSubtree()
https://bugs.webkit.org/show_bug.cgi?id=222397

Patch by Julian Gonzalez  on 2021-03-03
Reviewed by Ryosuke Niwa.

Skip children in removeSymbolElementsFromSubtree(), so that
we don't see nodes that have been removed in disassociateAndRemoveClones.

Thanks to Darin Adler for the initial version of this patch
and Ryosuke Niwa for refinements.

* svg/SVGUseElement.cpp:
(WebCore::removeSymbolElementsFromSubtree):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (273867 => 273868)

--- trunk/Source/WebCore/ChangeLog	2021-03-04 01:49:00 UTC (rev 273867)
+++ trunk/Source/WebCore/ChangeLog	2021-03-04 02:13:28 UTC (rev 273868)
@@ -1,3 +1,19 @@
+2021-03-03  Julian Gonzalez  
+
+Crash in removeSymbolElementsFromSubtree()
+https://bugs.webkit.org/show_bug.cgi?id=222397
+
+Reviewed by Ryosuke Niwa.
+
+Skip children in removeSymbolElementsFromSubtree(), so that
+we don't see nodes that have been removed in disassociateAndRemoveClones.
+
+Thanks to Darin Adler for the initial version of this patch
+and Ryosuke Niwa for refinements.
+
+* svg/SVGUseElement.cpp:
+(WebCore::removeSymbolElementsFromSubtree):
+
 2021-03-03  Ryosuke Niwa  
 
 Nulllptr crash in DeleteSelectionCommand::handleGeneralDelete()


Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (273867 => 273868)

--- trunk/Source/WebCore/svg/SVGUseElement.cpp	2021-03-04 01:49:00 UTC (rev 273867)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp	2021-03-04 02:13:28 UTC (rev 273868)
@@ -350,8 +350,14 @@
 // into  elements, which is correct for symbol elements directly referenced by use elements,
 // but incorrect for ones that just happen to be in a subtree.
 Vector symbolElements;
-for (auto& descendant : descendantsOfType(subtree))
-symbolElements.append(&descendant);
+for (auto it = descendantsOfType(subtree).begin(); it; ) {
+if (is(*it)) {
+symbolElements.append(&*it);
+it.traverseNextSkippingChildren();
+continue;
+}
+++it;
+}
 disassociateAndRemoveClones(symbolElements);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273867] trunk

[cdumez]

Title: [273867] trunk








Revision 273867
Author cdu...@apple.com
Date 2021-03-03 17:49:00 -0800 (Wed, 03 Mar 2021)


Log Message
Unreviewed, reverting r273851.

Caused some tests failures on macOS Big Sur

Reverted changeset:

"[macOS][WK2] Changing the system language does not update
navigator.language"
https://bugs.webkit.org/show_bug.cgi?id=222619
https://commits.webkit.org/r273851

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Language.cpp
trunk/Source/WTF/wtf/Language.h
trunk/Source/WTF/wtf/cf/LanguageCF.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (273866 => 273867)

--- trunk/Source/WTF/ChangeLog	2021-03-04 01:48:53 UTC (rev 273866)
+++ trunk/Source/WTF/ChangeLog	2021-03-04 01:49:00 UTC (rev 273867)
@@ -1,3 +1,16 @@
+2021-03-03  Chris Dumez  
+
+Unreviewed, reverting r273851.
+
+Caused some tests failures on macOS Big Sur
+
+Reverted changeset:
+
+"[macOS][WK2] Changing the system language does not update
+navigator.language"
+https://bugs.webkit.org/show_bug.cgi?id=222619
+https://commits.webkit.org/r273851
+
 2021-03-03  Ryan Haddad  
 
 Unreviewed, reverting r273832.


Modified: trunk/Source/WTF/wtf/Language.cpp (273866 => 273867)

--- trunk/Source/WTF/wtf/Language.cpp	2021-03-04 01:48:53 UTC (rev 273866)
+++ trunk/Source/WTF/wtf/Language.cpp	2021-03-04 01:49:00 UTC (rev 273867)
@@ -62,7 +62,6 @@
 
 void languageDidChange()
 {
-platformLanguageDidChange();
 for (auto& observer : copyToVector(observerMap())) {
 if (observerMap().contains(observer.key))
 observer.value(observer.key);
@@ -184,10 +183,4 @@
 return localeName;
 }
 
-#if !PLATFORM(COCOA)
-void platformLanguageDidChange()
-{
 }
-#endif
-
-}


Modified: trunk/Source/WTF/wtf/Language.h (273866 => 273867)

--- trunk/Source/WTF/wtf/Language.h	2021-03-04 01:48:53 UTC (rev 273866)
+++ trunk/Source/WTF/wtf/Language.h	2021-03-04 01:49:00 UTC (rev 273867)
@@ -41,8 +41,6 @@
 WTF_EXPORT_PRIVATE void overrideUserPreferredLanguages(const Vector&);
 WTF_EXPORT_PRIVATE size_t indexOfBestMatchingLanguageInList(const String& language, const Vector& languageList, bool& exactMatch);
 WTF_EXPORT_PRIVATE Vector platformUserPreferredLanguages();
-WTF_EXPORT_PRIVATE void platformLanguageDidChange();
-
 // Called from platform specific code when the user's preferred language(s) change.
 WTF_EXPORT_PRIVATE void languageDidChange();
 
@@ -54,7 +52,6 @@
 
 #if PLATFORM(COCOA)
 bool canMinimizeLanguages();
-WTF_EXPORT_PRIVATE void listenForLanguageChangeNotifications();
 RetainPtr minimizedLanguagesFromLanguages(CFArrayRef);
 #endif
 


Modified: trunk/Source/WTF/wtf/cf/LanguageCF.cpp (273866 => 273867)

--- trunk/Source/WTF/wtf/cf/LanguageCF.cpp	2021-03-04 01:48:53 UTC (rev 273866)
+++ trunk/Source/WTF/wtf/cf/LanguageCF.cpp	2021-03-04 01:49:00 UTC (rev 273867)
@@ -40,13 +40,6 @@
 
 static Lock preferredLanguagesMutex;
 
-#if PLATFORM(MAC)
-static void languagePreferencesDidChange(CFNotificationCenterRef, void*, CFStringRef, const void*, CFDictionaryRef)
-{
-languageDidChange();
-}
-#endif
-
 static Vector& preferredLanguages()
 {
 static LazyNeverDestroyed> languages;
@@ -90,26 +83,27 @@
 
 }
 
-void platformLanguageDidChange()
+#if PLATFORM(MAC)
+static void languagePreferencesDidChange(CFNotificationCenterRef, void*, CFStringRef, const void*, CFDictionaryRef)
 {
 {
 auto locker = holdLock(preferredLanguagesMutex);
 preferredLanguages().clear();
 }
+
+languageDidChange();
 }
+#endif
 
-void listenForLanguageChangeNotifications()
+Vector platformUserPreferredLanguages()
 {
 #if PLATFORM(MAC)
 static dispatch_once_t onceToken;
-dispatch_once(&onceToken, ^{
+dispatch_once(&onceToken, ^ {
 CFNotificationCenterAddObserver(CFNotificationCenterGetDistributedCenter(), nullptr, &languagePreferencesDidChange, CFSTR("AppleLanguagePreferencesChangedNotification"), nullptr, CFNotificationSuspensionBehaviorCoalesce);
 });
 #endif
-}
 
-Vector platformUserPreferredLanguages()
-{
 auto locker = holdLock(preferredLanguagesMutex);
 Vector& userPreferredLanguages = preferredLanguages();
 


Modified: trunk/Source/WebKit/ChangeLog (273866 => 273867)

--- trunk/Source/WebKit/ChangeLog	2021-03-04 01:48:53 UTC (rev 273866)
+++ trunk/Source/WebKit/ChangeLog	2021-03-04 01:49:00 UTC (rev 273867)
@@ -1,3 +1,16 @@
+2021-03-03  Chris Dumez  
+
+Unreviewed, reverting r273851.
+
+Caused some tests failures on macOS Big Sur
+
+Reverted changeset:
+
+"[macOS][WK2] Changing the system language does not update
+navig

[webkit-changes] [273866] trunk/Source/WebCore

[rniwa]

Title: [273866] trunk/Source/WebCore








Revision 273866
Author rn...@webkit.org
Date 2021-03-03 17:48:53 -0800 (Wed, 03 Mar 2021)


Log Message
Nulllptr crash in DeleteSelectionCommand::handleGeneralDelete()
https://bugs.webkit.org/show_bug.cgi?id=222681

Reviewed by Wenson Hsieh.

Skip the loop when m_downstreamEnd.isNull() or im_downstreamEnd.isOrphan() is true
to avoid dereferencing a nullptr.

No new tests since we don't have any reproduction for this crash,
and it's not obvious how we're getting into that state.

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (273865 => 273866)

--- trunk/Source/WebCore/ChangeLog	2021-03-04 01:34:21 UTC (rev 273865)
+++ trunk/Source/WebCore/ChangeLog	2021-03-04 01:48:53 UTC (rev 273866)
@@ -1,3 +1,19 @@
+2021-03-03  Ryosuke Niwa  
+
+Nulllptr crash in DeleteSelectionCommand::handleGeneralDelete()
+https://bugs.webkit.org/show_bug.cgi?id=222681
+
+Reviewed by Wenson Hsieh.
+
+Skip the loop when m_downstreamEnd.isNull() or im_downstreamEnd.isOrphan() is true
+to avoid dereferencing a nullptr.
+
+No new tests since we don't have any reproduction for this crash,
+and it's not obvious how we're getting into that state.
+
+* editing/DeleteSelectionCommand.cpp:
+(WebCore::DeleteSelectionCommand::handleGeneralDelete):
+
 2021-03-03  Devin Rousso  
 
 Web Inspector: `RecordCanvasActionVariant` causes a huge symbol to be created in WebCore


Modified: trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp (273865 => 273866)

--- trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp	2021-03-04 01:34:21 UTC (rev 273865)
+++ trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp	2021-03-04 01:48:53 UTC (rev 273866)
@@ -599,7 +599,7 @@
 }
 
 // handle deleting all nodes that are completely selected
-while (node && node != m_downstreamEnd.deprecatedNode()) {
+while (node && node != m_downstreamEnd.deprecatedNode() && !m_downstreamEnd.isNull() && !m_downstreamEnd.isOrphan()) {
 if (firstPositionInOrBeforeNode(node.get()) >= m_downstreamEnd) {
 // NodeTraversal::nextSkippingChildren just blew past the end position, so stop deleting
 node = nullptr;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273864] tags/Safari-611.1.21.0.3/

[repstein]

Title: [273864] tags/Safari-611.1.21.0.3/








Revision 273864
Author repst...@apple.com
Date 2021-03-03 17:19:04 -0800 (Wed, 03 Mar 2021)


Log Message
Tag Safari-611.1.21.0.3.

Added Paths

tags/Safari-611.1.21.0.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273861] branches/safari-612.1.5-branch

[alancoon]

Title: [273861] branches/safari-612.1.5-branch








Revision 273861
Author alanc...@apple.com
Date 2021-03-03 17:00:45 -0800 (Wed, 03 Mar 2021)


Log Message
Cherry-pick r273764. rdar://problem/75009398

The layout of SVGImage should force the layout for its clients
https://bugs.webkit.org/show_bug.cgi?id=221253


Reviewed by Simon Fraser.

Source/WebCore:

Unlike the bitmap image, the intrinsic size of SVGImage can only be known
after running its layout. Because SVGImage can be used by multiple clients,
CachedImage maintains an SVGImageCache which maps a client to an
SVGImageForContainer. SVGImageForContainer is just a wrapper of SVGImage
with the intrinsic size of the client. Because we may set an entry for
the renderer in SVGImageCache early before running a layout for SVGImage
and because the renderer intrinsic size depends on the intrinsic size of
SVGImage, SVGImageForContainer may have an empty intrinsic size.

So basically it is a race condition: knowing the intrinsic size of the
SVGImage client depends on the intrinsic size of SVGImage itself. And the
intrinsic size of SVGImageForContainer depends on the intrinsic size of
the client. This may lead to not rendering the clients because their sizes
are empty. To fix this issue we need to force calculateBackgroundImageGeometry()
once we finish the layout of the SVGImage which happens after receiving all
its data and calling RenderBox::imageChanged().

Test: fast/css/background-svg-image-loading.html

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::finishLoading):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):

LayoutTests:

* fast/css/background-svg-image-loading-expected.html: Added.
* fast/css/background-svg-image-loading.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.5-branch/LayoutTests/ChangeLog
branches/safari-612.1.5-branch/Source/WebCore/ChangeLog
branches/safari-612.1.5-branch/Source/WebCore/loader/cache/CachedImage.cpp
branches/safari-612.1.5-branch/Source/WebCore/rendering/RenderBox.cpp


Added Paths

branches/safari-612.1.5-branch/LayoutTests/fast/css/background-svg-image-loading-expected.html
branches/safari-612.1.5-branch/LayoutTests/fast/css/background-svg-image-loading.html




Diff

Modified: branches/safari-612.1.5-branch/LayoutTests/ChangeLog (273860 => 273861)

--- branches/safari-612.1.5-branch/LayoutTests/ChangeLog	2021-03-04 01:00:42 UTC (rev 273860)
+++ branches/safari-612.1.5-branch/LayoutTests/ChangeLog	2021-03-04 01:00:45 UTC (rev 273861)
@@ -1,3 +1,58 @@
+2021-03-03  Alan Coon  
+
+Cherry-pick r273764. rdar://problem/75009398
+
+The layout of SVGImage should force the layout for its clients
+https://bugs.webkit.org/show_bug.cgi?id=221253
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+Unlike the bitmap image, the intrinsic size of SVGImage can only be known
+after running its layout. Because SVGImage can be used by multiple clients,
+CachedImage maintains an SVGImageCache which maps a client to an
+SVGImageForContainer. SVGImageForContainer is just a wrapper of SVGImage
+with the intrinsic size of the client. Because we may set an entry for
+the renderer in SVGImageCache early before running a layout for SVGImage
+and because the renderer intrinsic size depends on the intrinsic size of
+SVGImage, SVGImageForContainer may have an empty intrinsic size.
+
+So basically it is a race condition: knowing the intrinsic size of the
+SVGImage client depends on the intrinsic size of SVGImage itself. And the
+intrinsic size of SVGImageForContainer depends on the intrinsic size of
+the client. This may lead to not rendering the clients because their sizes
+are empty. To fix this issue we need to force calculateBackgroundImageGeometry()
+once we finish the layout of the SVGImage which happens after receiving all
+its data and calling RenderBox::imageChanged().
+
+Test: fast/css/background-svg-image-loading.html
+
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::finishLoading):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::repaintLayerRectsForImage):
+
+LayoutTests:
+
+* fast/css/background-svg-image-loading-expected.html: Added.
+* fast/css/background-svg-image-loading.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-03-02  Said Abou-Hallawa  
+
+The layout of SVGImage should force the layout for its clients
+https://bugs.webkit.org/show_bug.cgi?id=221253
+
+
+Reviewed by Simon Fraser.
+
+* fast/css/background-svg-image-loading-expected.html: Added.
+  

[webkit-changes] [273862] branches/safari-612.1.5-branch

[alancoon]

Title: [273862] branches/safari-612.1.5-branch








Revision 273862
Author alanc...@apple.com
Date 2021-03-03 17:00:49 -0800 (Wed, 03 Mar 2021)


Log Message
Cherry-pick r273821. rdar://problem/75009461

REGRESSION (r266288): Web Inspector: ::marker shows on every element now
https://bugs.webkit.org/show_bug.cgi?id=222384

Reviewed by Devin Rousso.

Source/WebCore:

Test: inspector/css/getMatchedStylesForNodeMarkerPseudoId.html

Add filtering of the `::marker` CSS rule for elements that are not list items, as they do no apply to the
element.

* inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
- Added filtering for `*::marker` rules on non-`display:list-item` elements.
(WebCore::InspectorCSSAgent::buildObjectForRule):
- Drive-by refactoring to reduce code duplication.

LayoutTests:

Added test for the filtering of `*::marker` selector from the rule results of `CSS.getMatchedStyleForNode` on
elements that don't support `::marker`.

* inspector/css/getMatchedStylesForNode-expected.txt:
- Updated expectations to account for the abscence of the `::marker` rule on non-list elements.
* inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt: Added.
* inspector/css/getMatchedStylesForNodeMarkerPseudoId.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.5-branch/LayoutTests/ChangeLog
branches/safari-612.1.5-branch/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt
branches/safari-612.1.5-branch/Source/WebCore/ChangeLog
branches/safari-612.1.5-branch/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp


Added Paths

branches/safari-612.1.5-branch/LayoutTests/inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt
branches/safari-612.1.5-branch/LayoutTests/inspector/css/getMatchedStylesForNodeMarkerPseudoId.html




Diff

Modified: branches/safari-612.1.5-branch/LayoutTests/ChangeLog (273861 => 273862)

--- branches/safari-612.1.5-branch/LayoutTests/ChangeLog	2021-03-04 01:00:45 UTC (rev 273861)
+++ branches/safari-612.1.5-branch/LayoutTests/ChangeLog	2021-03-04 01:00:49 UTC (rev 273862)
@@ -1,5 +1,55 @@
 2021-03-03  Alan Coon  
 
+Cherry-pick r273821. rdar://problem/75009461
+
+REGRESSION (r266288): Web Inspector: ::marker shows on every element now
+https://bugs.webkit.org/show_bug.cgi?id=222384
+
+Reviewed by Devin Rousso.
+
+Source/WebCore:
+
+Test: inspector/css/getMatchedStylesForNodeMarkerPseudoId.html
+
+Add filtering of the `::marker` CSS rule for elements that are not list items, as they do no apply to the
+element.
+
+* inspector/agents/InspectorCSSAgent.cpp:
+(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
+- Added filtering for `*::marker` rules on non-`display:list-item` elements.
+(WebCore::InspectorCSSAgent::buildObjectForRule):
+- Drive-by refactoring to reduce code duplication.
+
+LayoutTests:
+
+Added test for the filtering of `*::marker` selector from the rule results of `CSS.getMatchedStyleForNode` on
+elements that don't support `::marker`.
+
+* inspector/css/getMatchedStylesForNode-expected.txt:
+- Updated expectations to account for the abscence of the `::marker` rule on non-list elements.
+* inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt: Added.
+* inspector/css/getMatchedStylesForNodeMarkerPseudoId.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-03-03  Patrick Angle  
+
+REGRESSION (r266288): Web Inspector: ::marker shows on every element now
+https://bugs.webkit.org/show_bug.cgi?id=222384
+
+Reviewed by Devin Rousso.
+
+Added test for the filtering of `*::marker` selector from the rule results of `CSS.getMatchedStyleForNode` on
+elements that don't support `::marker`.
+
+* inspector/css/getMatchedStylesForNode-expected.txt:
+- Updated expectations to account for the abscence of the `::marker` rule on non-list elements.
+* inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt: Added.
+* inspector/css/getMatchedStylesForNodeMarkerPseudoId.html: Added.
+
+2021-03-03  Alan Coon  
+
 Cherry-pick r273764. rdar://problem/75009398
 
 The layout of SVGImage should force the layout for its clients


Modified: branches/safari-612.1.5-branch/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt (273861 => 273862)

--- branches/safari-612.1.5-branch/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt	2021-03-04 01:00:45 UTC (rev 273861)
+++ branches/safari-612.1.5-branch/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt	2021-03-04 01:00:49 UTC (rev

[webkit-changes] [273860] branches/safari-612.1.5-branch

[alancoon]

Title: [273860] branches/safari-612.1.5-branch








Revision 273860
Author alanc...@apple.com
Date 2021-03-03 17:00:42 -0800 (Wed, 03 Mar 2021)


Log Message
Cherry-pick r273699. rdar://problem/75009467

[Win] Fix build failure
https://bugs.webkit.org/show_bug.cgi?id=222576

Reviewed by Brent Fulgham.

It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.

* Source/cmake/OptionsAppleWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.5-branch/ChangeLog
branches/safari-612.1.5-branch/Source/cmake/OptionsAppleWin.cmake




Diff

Modified: branches/safari-612.1.5-branch/ChangeLog (273859 => 273860)

--- branches/safari-612.1.5-branch/ChangeLog	2021-03-04 00:49:31 UTC (rev 273859)
+++ branches/safari-612.1.5-branch/ChangeLog	2021-03-04 01:00:42 UTC (rev 273860)
@@ -1,3 +1,30 @@
+2021-03-03  Alan Coon  
+
+Cherry-pick r273699. rdar://problem/75009467
+
+[Win] Fix build failure
+https://bugs.webkit.org/show_bug.cgi?id=222576
+
+Reviewed by Brent Fulgham.
+
+It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.
+
+* Source/cmake/OptionsAppleWin.cmake:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-03-01  Per Arne  
+
+[Win] Fix build failure
+https://bugs.webkit.org/show_bug.cgi?id=222576
+
+Reviewed by Brent Fulgham.
+
+It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.
+
+* Source/cmake/OptionsAppleWin.cmake:
+
 2021-02-18  Martin Robinson  
 
 [GTK][WPE] Implement support for CSS Scroll Snap


Modified: branches/safari-612.1.5-branch/Source/cmake/OptionsAppleWin.cmake (273859 => 273860)

--- branches/safari-612.1.5-branch/Source/cmake/OptionsAppleWin.cmake	2021-03-04 00:49:31 UTC (rev 273859)
+++ branches/safari-612.1.5-branch/Source/cmake/OptionsAppleWin.cmake	2021-03-04 01:00:42 UTC (rev 273860)
@@ -25,6 +25,7 @@
 include(OptionsWin)
 
 set(ENABLE_WEBCORE ON)
+set(ENABLE_WEBINSPECTORUI OFF)
 
 SET_AND_EXPOSE_TO_BUILD(USE_CF ON)
 SET_AND_EXPOSE_TO_BUILD(USE_CFURLCONNECTION ON)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273863] branches/safari-612.1.5-branch/Source/WebCore

[alancoon]

Title: [273863] branches/safari-612.1.5-branch/Source/WebCore








Revision 273863
Author alanc...@apple.com
Date 2021-03-03 17:00:52 -0800 (Wed, 03 Mar 2021)


Log Message
Cherry-pick r273839. rdar://problem/75009410

REGRESSION (r273154): Speedometer 2 is 1-2% regressed on iOS
https://bugs.webkit.org/show_bug.cgi?id=222663


Reviewed by Ryosuke Niwa.

A 1-2% regression was observed in Speedometer 2 after enabling the iOS
Form Control Refresh (FCR). Traces indicated an increased amount of time
spent in style resolution. Note that currently the FCR styles are
appended to the base UA stylesheet at runtime, to apply the necessary
changes for the new appearance, while making it possible to toggle the
feature.

To fix, the FCR stylesheet is merged into the base UA stylesheet. This
avoids ruleset duplication, which made it more expensive to resolve
styles. To preserve the old appearance when the feature is runtime
disabled, the old styles are moved into a separate stylesheet, appended
at runtime.

The fix was verified as an equivalent progression using internal A/B
testing infrastructure.

Note that this solution means that disabling the FCR will result in a
Speedometer regression, due to ruleset duplication. However, this should
not be a concern since the feature is controlled by an internal switch,
is enabled by default, and is not intended to be disabled.

* css/formControlsIOS.css:
* css/html.css:
* style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.5-branch/Source/WebCore/ChangeLog
branches/safari-612.1.5-branch/Source/WebCore/css/formControlsIOS.css
branches/safari-612.1.5-branch/Source/WebCore/css/html.css
branches/safari-612.1.5-branch/Source/WebCore/style/UserAgentStyle.cpp




Diff

Modified: branches/safari-612.1.5-branch/Source/WebCore/ChangeLog (273862 => 273863)

--- branches/safari-612.1.5-branch/Source/WebCore/ChangeLog	2021-03-04 01:00:49 UTC (rev 273862)
+++ branches/safari-612.1.5-branch/Source/WebCore/ChangeLog	2021-03-04 01:00:52 UTC (rev 273863)
@@ -1,5 +1,78 @@
 2021-03-03  Alan Coon  
 
+Cherry-pick r273839. rdar://problem/75009410
+
+REGRESSION (r273154): Speedometer 2 is 1-2% regressed on iOS
+https://bugs.webkit.org/show_bug.cgi?id=222663
+
+
+Reviewed by Ryosuke Niwa.
+
+A 1-2% regression was observed in Speedometer 2 after enabling the iOS
+Form Control Refresh (FCR). Traces indicated an increased amount of time
+spent in style resolution. Note that currently the FCR styles are
+appended to the base UA stylesheet at runtime, to apply the necessary
+changes for the new appearance, while making it possible to toggle the
+feature.
+
+To fix, the FCR stylesheet is merged into the base UA stylesheet. This
+avoids ruleset duplication, which made it more expensive to resolve
+styles. To preserve the old appearance when the feature is runtime
+disabled, the old styles are moved into a separate stylesheet, appended
+at runtime.
+
+The fix was verified as an equivalent progression using internal A/B
+testing infrastructure.
+
+Note that this solution means that disabling the FCR will result in a
+Speedometer regression, due to ruleset duplication. However, this should
+not be a concern since the feature is controlled by an internal switch,
+is enabled by default, and is not intended to be disabled.
+
+* css/formControlsIOS.css:
+* css/html.css:
+* style/UserAgentStyle.cpp:
+(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-03-03  Aditya Keerthi  
+
+REGRESSION (r273154): Speedometer 2 is 1-2% regressed on iOS
+https://bugs.webkit.org/show_bug.cgi?id=222663
+
+
+Reviewed by Ryosuke Niwa.
+
+A 1-2% regression was observed in Speedometer 2 after enabling the iOS
+Form Control Refresh (FCR). Traces indicated an increased amount of time
+spent in style resolution. Note that currently the FCR styles are
+appended to the base UA stylesheet at runtime, to apply the necessary
+changes for the new appearance, while making it possible to toggle the
+feature.
+
+To fix, the FCR stylesheet is merged into the base UA stylesheet. This
+avoids ruleset duplication, which made it more expensive to resolve
+styles. To preserve the old appearance when the feature is runtime
+disabled, the old styles are moved into a separate stylesheet, appended
+at runtime.
+
+  

[webkit-changes] [273859] trunk/Source

[ryanhaddad]

Title: [273859] trunk/Source








Revision 273859
Author ryanhad...@apple.com
Date 2021-03-03 16:49:31 -0800 (Wed, 03 Mar 2021)


Log Message
Unreviewed, reverting r273832.

26 inspector tests failing a new assert added with this change

Reverted changeset:

"Limit HashTable entry size to 500 bytes"
https://bugs.webkit.org/show_bug.cgi?id=222658
https://commits.webkit.org/r273832

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashTable.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h
trunk/Source/WebCore/platform/network/NetworkLoadInformation.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp
trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h




Diff

Modified: trunk/Source/WTF/ChangeLog (273858 => 273859)

--- trunk/Source/WTF/ChangeLog	2021-03-04 00:41:02 UTC (rev 273858)
+++ trunk/Source/WTF/ChangeLog	2021-03-04 00:49:31 UTC (rev 273859)
@@ -1,3 +1,15 @@
+2021-03-03  Ryan Haddad  
+
+Unreviewed, reverting r273832.
+
+26 inspector tests failing a new assert added with this change
+
+Reverted changeset:
+
+"Limit HashTable entry size to 500 bytes"
+https://bugs.webkit.org/show_bug.cgi?id=222658
+https://commits.webkit.org/r273832
+
 2021-03-03  Chris Dumez  
 
 [macOS][WK2] Changing the system language does not update navigator.language


Modified: trunk/Source/WTF/wtf/HashTable.h (273858 => 273859)

--- trunk/Source/WTF/wtf/HashTable.h	2021-03-04 00:41:02 UTC (rev 273858)
+++ trunk/Source/WTF/wtf/HashTable.h	2021-03-04 00:49:31 UTC (rev 273859)
@@ -665,8 +665,6 @@
 template
 ALWAYS_INLINE auto HashTable::inlineLookup(const T& key) -> ValueType*
 {
-static_assert(sizeof(Key) + sizeof(Value) < 500, "Your HashTable types are too big to efficiently move when rehashing.  Consider using std::unique_ptr instead");
-
 checkKey(key);
 
 unsigned k = 0;


Modified: trunk/Source/WebCore/ChangeLog (273858 => 273859)

--- trunk/Source/WebCore/ChangeLog	2021-03-04 00:41:02 UTC (rev 273858)
+++ trunk/Source/WebCore/ChangeLog	2021-03-04 00:49:31 UTC (rev 273859)
@@ -1,3 +1,15 @@
+2021-03-03  Ryan Haddad  
+
+Unreviewed, reverting r273832.
+
+26 inspector tests failing a new assert added with this change
+
+Reverted changeset:
+
+"Limit HashTable entry size to 500 bytes"
+https://bugs.webkit.org/show_bug.cgi?id=222658
+https://commits.webkit.org/r273832
+
 2021-03-03  Chris Dumez  
 
 Use adoptNS() right away after calling [obj copy] / [obj mutableCopy]


Modified: trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h (273858 => 273859)

--- trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h	2021-03-04 00:41:02 UTC (rev 273858)
+++ trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h	2021-03-04 00:49:31 UTC (rev 273859)
@@ -61,7 +61,6 @@
 WEBCORE_EXPORT ResponseBody copyResponseBody(const ResponseBody&);
 
 struct Record {
-WTF_MAKE_STRUCT_FAST_ALLOCATED;
 WEBCORE_EXPORT Record copy() const;
 
 uint64_t identifier;


Modified: trunk/Source/WebCore/platform/network/NetworkLoadInformation.h (273858 => 273859)

--- trunk/Source/WebCore/platform/network/NetworkLoadInformation.h	2021-03-04 00:41:02 UTC (rev 273858)
+++ trunk/Source/WebCore/platform/network/NetworkLoadInformation.h	2021-03-04 00:49:31 UTC (rev 273859)
@@ -33,7 +33,7 @@
 namespace WebCore {
 
 struct NetworkTransactionInformation {
-enum class Type : bool { Redirection, Preflight };
+enum class Type { Redirection, Preflight };
 Type type;
 ResourceRequest request;
 ResourceResponse response;
@@ -44,7 +44,6 @@
 };
 
 struct NetworkLoadInformation {
-WTF_MAKE_STRUCT_FAST_ALLOCATED;
 ResourceRequest request;
 ResourceResponse response;
 NetworkLoadMetrics metrics;
@@ -51,6 +50,20 @@
 Vector transactions;
 };
 
+}
+
+namespace WTF {
+template<> struct EnumTraits {
+using values = EnumValues<
+WebCore::NetworkTransactionInformation::Type,
+WebCore::NetworkTransactionInformation::Type::Redirection,
+WebCore::NetworkTransactionInformation::Type::Preflight
+>;
+};
+}
+
+namespace WebCore {
+
 template inline void NetworkTransactionInformation::encode(Encoder& encoder) const
 {
 encoder << type;


Modified: trunk/Source/WebKit/ChangeLog (273858 => 273859)

--- trunk/Source/WebKit/ChangeLog	2021-03-04 00:41:02 UTC (rev 273858)
+++ trunk/Source/WebKit/ChangeLog	2021-03-04 00:49:31 UTC (rev 273859)
@@ -1,3 +1,15 @@
+2021-03-03  Ryan Haddad  
+
+Unreviewed, reverting r273832.
+
+26 inspector tests failing a new assert added with this change
+
+Reverted changeset:
+
+"Limit HashTable entry size to 500 bytes"
+https://bugs.webkit.org/show_bug.cgi?id=222658
+https://commits.webkit.org/r273832
+
 2021-03-03  Ch

[webkit-changes] [273858] tags/Safari-611.1.21.1.4/

[repstein]

Title: [273858] tags/Safari-611.1.21.1.4/








Revision 273858
Author repst...@apple.com
Date 2021-03-03 16:41:02 -0800 (Wed, 03 Mar 2021)


Log Message
Tag Safari-611.1.21.1.4.

Added Paths

tags/Safari-611.1.21.1.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273857] tags/Safari-611.1.21.1.4/

[repstein]

Title: [273857] tags/Safari-611.1.21.1.4/








Revision 273857
Author repst...@apple.com
Date 2021-03-03 16:40:10 -0800 (Wed, 03 Mar 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-611.1.21.1.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273856] branches/safari-611.1.21.1-branch/Source

[repstein]

Title: [273856] branches/safari-611.1.21.1-branch/Source








Revision 273856
Author repst...@apple.com
Date 2021-03-03 16:39:42 -0800 (Wed, 03 Mar 2021)


Log Message
Versioning.

WebKit-7611.1.21.1.4

Modified Paths

branches/safari-611.1.21.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.1.21.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.1.21.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.1.21.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.1.21.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.1.21.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.1.21.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.1.21.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.1.21.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273855 => 273856)

--- branches/safari-611.1.21.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-03-04 00:29:36 UTC (rev 273855)
+++ branches/safari-611.1.21.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-03-04 00:39:42 UTC (rev 273856)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273855 => 273856)

--- branches/safari-611.1.21.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-03-04 00:29:36 UTC (rev 273855)
+++ branches/safari-611.1.21.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-03-04 00:39:42 UTC (rev 273856)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273855 => 273856)

--- branches/safari-611.1.21.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-03-04 00:29:36 UTC (rev 273855)
+++ branches/safari-611.1.21.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-03-04 00:39:42 UTC (rev 273856)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.1-branch/Source/WebCore/Configurations/Version.xcconfig (273855 => 273856)

--- branches/safari-611.1.21.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-03-04 00:29:36 UTC (rev 273855)
+++ branches/safari-611.1.21.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-03-04 00:39:42 UTC (rev 273856)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273855 => 273856)

--- branches/safari-611.1.21.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-03-04 00:29:36 UTC (rev 273855)
+++ branches/safari-611.1.21.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-03-04 00:39:42 UTC (rev 273856)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (273855 => 273856)

--- branches/safari-611.1.21.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-03-04 00:29:36 UTC (rev 273855)
+++ branches/safari-611.1.21.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-03-04 00:39:42 UTC (rev 273856)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TI

[webkit-changes] [273855] tags/Safari-611.1.21.1.4/

[rubent_22]

Title: [273855] tags/Safari-611.1.21.1.4/








Revision 273855
Author rubent...@apple.com
Date 2021-03-03 16:29:36 -0800 (Wed, 03 Mar 2021)


Log Message
Tag Safari-611.1.21.1.4.

Added Paths

tags/Safari-611.1.21.1.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273854] trunk/Tools

[commit-queue]

Title: [273854] trunk/Tools








Revision 273854
Author commit-qu...@webkit.org
Date 2021-03-03 16:15:01 -0800 (Wed, 03 Mar 2021)


Log Message
Make LayoutTestFinder.find_tests/find_tests_by_path return List[Test]
https://bugs.webkit.org/show_bug.cgi?id=222662

Patch by Sam Sneddon  on 2021-03-03
Reviewed by Jonathan Bedard.

This introduces a Test class, to later be able to migrate finding
expectations to LayoutTestFinder.

* Scripts/open-layout-test:
(main):
* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder.find_tests):
(LayoutTestFinder.find_tests_by_path):
* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
(LayoutTestFinderTests.test_find_with_skipped_directories):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
(Manager.print_expectations):
* Scripts/webkitpy/layout_tests/models/test.py: Added.
(Test):
(Test.__init__):
(Test.__repr__):
(Test.__eq__):
* Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.execute):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/open-layout-test
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_input.py
trunk/Tools/Scripts/webkitpy/tool/commands/queries.py


Added Paths

trunk/Tools/Scripts/webkitpy/layout_tests/models/test.py




Diff

Modified: trunk/Tools/ChangeLog (273853 => 273854)

--- trunk/Tools/ChangeLog	2021-03-03 23:54:50 UTC (rev 273853)
+++ trunk/Tools/ChangeLog	2021-03-04 00:15:01 UTC (rev 273854)
@@ -1,3 +1,33 @@
+2021-03-03  Sam Sneddon  
+
+Make LayoutTestFinder.find_tests/find_tests_by_path return List[Test]
+https://bugs.webkit.org/show_bug.cgi?id=222662
+
+Reviewed by Jonathan Bedard.
+
+This introduces a Test class, to later be able to migrate finding
+expectations to LayoutTestFinder.
+
+* Scripts/open-layout-test:
+(main):
+* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
+(LayoutTestFinder.find_tests):
+(LayoutTestFinder.find_tests_by_path):
+* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
+(LayoutTestFinderTests.test_find_with_skipped_directories):
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager.run):
+(Manager.print_expectations):
+* Scripts/webkitpy/layout_tests/models/test.py: Added.
+(Test):
+(Test.__init__):
+(Test.__repr__):
+(Test.__eq__):
+* Scripts/webkitpy/layout_tests/models/test_input.py:
+(TestInput):
+* Scripts/webkitpy/tool/commands/queries.py:
+(PrintExpectations.execute):
+
 2021-03-03  Cameron McCormack  
 
 Send console.log() etc. to stdout in MiniBrowser on macOS


Modified: trunk/Tools/Scripts/open-layout-test (273853 => 273854)

--- trunk/Tools/Scripts/open-layout-test	2021-03-03 23:54:50 UTC (rev 273853)
+++ trunk/Tools/Scripts/open-layout-test	2021-03-04 00:15:01 UTC (rev 273854)
@@ -54,7 +54,8 @@
 driver = port.create_driver(0)
 finder = LayoutTestFinder(port, {})
 
-paths, test_files = finder.find_tests(None, [test_name])
+paths, tests = finder.find_tests(None, [test_name])
+test_files = [test.test_path for test in tests]
 test_name = paths[0]
 
 needs_server = False


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py (273853 => 273854)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py	2021-03-03 23:54:50 UTC (rev 273853)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py	2021-03-04 00:15:01 UTC (rev 273854)
@@ -33,6 +33,7 @@
 
 from webkitpy.common import find_files
 from webkitpy.layout_tests.models import test_expectations
+from webkitpy.layout_tests.models.test import Test
 from webkitpy.port.base import Port
 
 
@@ -84,13 +85,13 @@
 paths = self._strip_test_dir_prefixes(args)
 if options and options.test_list:
 paths += self._strip_test_dir_prefixes(self._read_test_names_from_file(options.test_list, self._port.TEST_PATH_SEPARATOR))
-test_files = self.find_tests_by_path(paths, device_type=device_type)
-return (paths, test_files)
+tests = self.find_tests_by_path(paths, device_type=device_type)
+return (paths, tests)
 
 def find_tests_by_path(self, paths, device_type=None):
 """Return the list of tests found. Both generic and platform-specific tests matching paths should be returned."""
 expanded_paths = self._expanded_paths(paths, device_type=device_type)
-return self._real_tests(expanded_paths)
+return [Test(test_file) for test_file in self._re

[webkit-changes] [273853] trunk/LayoutTests

[peng . liu6]

Title: [273853] trunk/LayoutTests








Revision 273853
Author peng.l...@apple.com
Date 2021-03-03 15:54:50 -0800 (Wed, 03 Mar 2021)


Log Message
[GPUP] Two tests related to media element state are flaky when media in GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=221688

Reviewed by Jer Noble.

This patch fixes two flaky tests by updating the expected value of a media element's "networkState"
in a "loadstart" event handler.

A video/audio element's network state may have changed from LOADING to IDLE before the "loadstart"
event handler executes. That will happen when the media player notifies the element with a network
state change (by calling HTMLMediaElement::setNetworkState()) from LOADING to LOADED quickly.
The code snippet is below:

```
void HTMLMediaElement::setNetworkState(MediaPlayer::NetworkState state)
{
...
if (state == MediaPlayer::NetworkState::Loaded) {
if (m_networkState != NETWORK_IDLE)
changeNetworkStateFromLoadingToIdle();
m_completelyLoaded = true;
}
}
```

* media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
* media/W3C/audio/networkState/networkState_during_loadstart.html:
* media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
* media/W3C/video/networkState/networkState_during_loadstart.html:
* platform/mac/TestExpectations:
* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart-expected.txt
trunk/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart.html
trunk/LayoutTests/media/W3C/video/networkState/networkState_during_loadstart-expected.txt
trunk/LayoutTests/media/W3C/video/networkState/networkState_during_loadstart.html
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (273852 => 273853)

--- trunk/LayoutTests/ChangeLog	2021-03-03 23:46:37 UTC (rev 273852)
+++ trunk/LayoutTests/ChangeLog	2021-03-03 23:54:50 UTC (rev 273853)
@@ -1,3 +1,37 @@
+2021-03-03  Peng Liu  
+
+[GPUP] Two tests related to media element state are flaky when media in GPU Process is enabled
+https://bugs.webkit.org/show_bug.cgi?id=221688
+
+Reviewed by Jer Noble.
+
+This patch fixes two flaky tests by updating the expected value of a media element's "networkState"
+in a "loadstart" event handler.
+
+A video/audio element's network state may have changed from LOADING to IDLE before the "loadstart"
+event handler executes. That will happen when the media player notifies the element with a network
+state change (by calling HTMLMediaElement::setNetworkState()) from LOADING to LOADED quickly.
+The code snippet is below:
+
+```
+void HTMLMediaElement::setNetworkState(MediaPlayer::NetworkState state)
+{
+...
+if (state == MediaPlayer::NetworkState::Loaded) {
+if (m_networkState != NETWORK_IDLE)
+changeNetworkStateFromLoadingToIdle();
+m_completelyLoaded = true;
+}
+}
+```
+
+* media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
+* media/W3C/audio/networkState/networkState_during_loadstart.html:
+* media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
+* media/W3C/video/networkState/networkState_during_loadstart.html:
+* platform/mac/TestExpectations:
+* platform/wk2/TestExpectations:
+
 2021-03-03  Amir Mark Jr  
 
 [BigSur WK1 Release] media/video-aspect-ratio.html is a flakey timeout


Modified: trunk/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart-expected.txt (273852 => 273853)

--- trunk/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart-expected.txt	2021-03-03 23:46:37 UTC (rev 273852)
+++ trunk/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart-expected.txt	2021-03-03 23:54:50 UTC (rev 273853)
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS "2" is "2"
+PASS true is true
 
 TEST COMPLETE
 spec reference


Modified: trunk/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart.html (273852 => 273853)

--- trunk/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart.html	2021-03-03 23:46:37 UTC (rev 273852)
+++ trunk/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart.html	2021-03-03 23:54:50 UTC (rev 273853)
@@ -15,8 +15,7 @@
 var a = document.getElementById("a");
 a.addEventListener("loadstart", function() {
   t.step(function() {
-   assert_equals(a.networkState,
-   a.NETWORK_LOADING);
+   assert_true(a.networkState == a.NETWORK_LOADING || a.networkState == a.NETWORK_IDLE);
   });
   t.done();
   a.pause();


Modified: trunk/LayoutTests/medi

[webkit-changes] [273852] trunk/Tools

[commit-queue]

Title: [273852] trunk/Tools








Revision 273852
Author commit-qu...@webkit.org
Date 2021-03-03 15:46:37 -0800 (Wed, 03 Mar 2021)


Log Message
Send console.log() etc. to stdout in MiniBrowser on macOS
https://bugs.webkit.org/show_bug.cgi?id=222629

Patch by Cameron McCormack  on 2021-03-03
Reviewed by Tim Horton.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate defaultConfiguration]):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/AppDelegate.m




Diff

Modified: trunk/Tools/ChangeLog (273851 => 273852)

--- trunk/Tools/ChangeLog	2021-03-03 23:46:21 UTC (rev 273851)
+++ trunk/Tools/ChangeLog	2021-03-03 23:46:37 UTC (rev 273852)
@@ -1,3 +1,13 @@
+2021-03-03  Cameron McCormack  
+
+Send console.log() etc. to stdout in MiniBrowser on macOS
+https://bugs.webkit.org/show_bug.cgi?id=222629
+
+Reviewed by Tim Horton.
+
+* MiniBrowser/mac/AppDelegate.m:
+(-[BrowserAppDelegate defaultConfiguration]):
+
 2021-03-03  Chris Dumez  
 
 [macOS][WK2] Changing the system language does not update navigator.language


Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (273851 => 273852)

--- trunk/Tools/MiniBrowser/mac/AppDelegate.m	2021-03-03 23:46:21 UTC (rev 273851)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m	2021-03-03 23:46:37 UTC (rev 273852)
@@ -144,6 +144,7 @@
 configuration.preferences._developerExtrasEnabled = YES;
 configuration.preferences._mockCaptureDevicesEnabled = YES;
 configuration.preferences._accessibilityIsolatedTreeEnabled = YES;
+configuration.preferences._logsPageMessagesToSystemConsoleEnabled = YES;
 }
 
 configuration.suppressesIncrementalRendering = _settingsController.incrementalRenderingSuppressed;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273851] trunk

[cdumez]

Title: [273851] trunk








Revision 273851
Author cdu...@apple.com
Date 2021-03-03 15:46:21 -0800 (Wed, 03 Mar 2021)


Log Message
[macOS][WK2] Changing the system language does not update navigator.language
https://bugs.webkit.org/show_bug.cgi?id=222619

Reviewed by Per Arne Vollan.

Source/WebKit:

* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::setAppleLanguagesPreference):
- When ENABLE(CFPREFS_DIRECT_MODE), we don't need to set the AppleLanguages
in a volatile domain. This does not change behavior but I made this change
so that I don't need to set AppleLanguages in the volatile domain in
WebProcessCocoa when the preference changes.
- Also fix a memory leak for newArguments.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
If CFPREFS_DIRECT_MODE is not enabled, we need to listen for AppleLanguagePreferencesChangedNotification
inside the WebProcess. This used to happen implicitly inside WTF::platformUserPreferredLanguages() but
it is now explicit since we don't want/need it when using CFPREFS_DIRECT_MODE.

(WebKit::setPreferenceValue):
- Call CFPreferencesSetAppValue() instead of CFPreferencesSetValue(). Without this change
trying to set AppleLanguages here would have no effect and CFLocaleCopyPreferredLanguages()
would keep returning outdated languages.
- Call WTF::languageDidChange() when the AppleLanguages preference gets updated so that
  language change listeners get notified of the language change (e.g. we fire a languagechange
  event at the Window).

Source/WebKitLegacy/mac:

We need to listen for AppleLanguagePreferencesChangedNotification on mac WK1.
This used to happen implicitly inside WTF::platformUserPreferredLanguages() but
it is now explicit since we don't want/need it when using CFPREFS_DIRECT_MODE in WK2.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WTF:

Update WTF::languageDidChange() to clear preferredLanguages() on Cocoa platforms
so that we get updated values from the system the next time
platformUserPreferredLanguages() is called.

platformUserPreferredLanguages() used to implicitly register a AppleLanguagePreferencesChangedNotification
listener. We've now made this registering opt-in by moving it to a separate
listenForLanguageChangeNotifications() function. This function is getting called
on Mac WK1 and WK2 when CFPREFS_DIRECT_MODE is disabled (legacy).
When CFPREFS_DIRECT_MODE is enabled in WK2, we don't want/need to listen for this
notification because the AppleLanguages preference gets pushed by the UIProcess
down to the WebProcesses. Even though we could listen for this notification,
the WebProcess would not have the latest AppleLanguages preference when receiving
the notification. This would cause us to fire the languagechange event at the
Window too early and navigator.language would keep returning the old language.
For WK2 with CFPREFS_DIRECT_MODE enabled, we now explicitly call
WTF::languageDidChange() when the "AppleLanguages" preference gets sync'd from
the UIProcess instead.

* wtf/Language.cpp:
(WTF::languageDidChange):
(WTF::platformLanguageDidChange):
* wtf/Language.h:
* wtf/cf/LanguageCF.cpp:
(WTF::languagePreferencesDidChange):
(WTF::platformLanguageDidChange):
(WTF::listenForLanguageChangeNotifications):
(WTF::platformUserPreferredLanguages):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:
(TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Language.cpp
trunk/Source/WTF/wtf/Language.h
trunk/Source/WTF/wtf/cf/LanguageCF.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (273850 => 273851)

--- trunk/Source/WTF/ChangeLog	2021-03-03 23:38:08 UTC (rev 273850)
+++ trunk/Source/WTF/ChangeLog	2021-03-03 23:46:21 UTC (rev 273851)
@@ -1,3 +1,38 @@
+2021-03-03  Chris Dumez  
+
+[macOS][WK2] Changing the system language does not update navigator.language
+https://bugs.webkit.org/show_bug.cgi?id=222619
+
+Reviewed by Per Arne Vollan.
+
+Update WTF::languageDidChange() to clear preferredLanguages() on Cocoa platforms
+so that we get updated values from the system the next time
+platformUserPreferredLanguages() is called.
+
+platformUserPreferredLanguages() used to implicitly register a AppleLanguagePreferencesChangedNotification
+listener. We've now made this registering opt-in by moving it to a separate
+listenForLanguageChangeNotifications() function. This function is getting called
+on Mac WK1 and WK2 when CFPREFS_DIRECT_MODE is disabled (legacy).
+Wh

[webkit-changes] [273850] trunk/LayoutTests

[tsavell]

Title: [273850] trunk/LayoutTests








Revision 273850
Author tsav...@apple.com
Date 2021-03-03 15:38:08 -0800 (Wed, 03 Mar 2021)


Log Message
[BigSur WK1 Release] media/video-aspect-ratio.html is a flakey timeout
https://bugs.webkit.org/show_bug.cgi?id=222693

Unreviewed test gardening.

Patch by Amir Mark Jr  on 2021-03-03

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (273849 => 273850)

--- trunk/LayoutTests/ChangeLog	2021-03-03 23:31:21 UTC (rev 273849)
+++ trunk/LayoutTests/ChangeLog	2021-03-03 23:38:08 UTC (rev 273850)
@@ -1,3 +1,12 @@
+2021-03-03  Amir Mark Jr  
+
+[BigSur WK1 Release] media/video-aspect-ratio.html is a flakey timeout
+https://bugs.webkit.org/show_bug.cgi?id=222693
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-03-03  Commit Queue  
 
 Unreviewed, reverting r273727.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (273849 => 273850)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-03-03 23:31:21 UTC (rev 273849)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-03-03 23:38:08 UTC (rev 273850)
@@ -1256,4 +1256,6 @@
 
 webkit.org/b/222493 [ BigSur ] platform/mac-bigsur/media/media-source/media-source-webm-vp8-malformed-header.html [ Skip ]
 
-webkit.org/b/221819 [ Debug ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/221819 [ Debug ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html [ Pass Failure ]
+
+webkit.org/b/222693 [ BigSur Release ] media/video-aspect-ratio.html [ Failure Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273849] trunk/Source/WTF

[ysuzuki]

Title: [273849] trunk/Source/WTF








Revision 273849
Author ysuz...@apple.com
Date 2021-03-03 15:31:21 -0800 (Wed, 03 Mar 2021)


Log Message
[WTF] Add System.framework PrivateHeaders to header path of WTF
https://bugs.webkit.org/show_bug.cgi?id=222688

Reviewed by Tim Horton.

The other non-third-party components excluding WTF have System.framework PrivateHeaders in their header search path.
This causes the problem that we cannot use some system headers (e.g. ``) in WTF while it is
usable in _javascript_Core and the other components. This patch adds it as the other components did.

* Configurations/Base.xcconfig:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Configurations/Base.xcconfig




Diff

Modified: trunk/Source/WTF/ChangeLog (273848 => 273849)

--- trunk/Source/WTF/ChangeLog	2021-03-03 23:07:08 UTC (rev 273848)
+++ trunk/Source/WTF/ChangeLog	2021-03-03 23:31:21 UTC (rev 273849)
@@ -1,3 +1,16 @@
+2021-03-03  Yusuke Suzuki  
+
+[WTF] Add System.framework PrivateHeaders to header path of WTF
+https://bugs.webkit.org/show_bug.cgi?id=222688
+
+Reviewed by Tim Horton.
+
+The other non-third-party components excluding WTF have System.framework PrivateHeaders in their header search path.
+This causes the problem that we cannot use some system headers (e.g. ``) in WTF while it is
+usable in _javascript_Core and the other components. This patch adds it as the other components did.
+
+* Configurations/Base.xcconfig:
+
 2021-03-03  Michael Catanzaro  
 
 std::is_literal_type causes -Wdeprecated-declarations warning with GCC 11


Modified: trunk/Source/WTF/Configurations/Base.xcconfig (273848 => 273849)

--- trunk/Source/WTF/Configurations/Base.xcconfig	2021-03-03 23:07:08 UTC (rev 273848)
+++ trunk/Source/WTF/Configurations/Base.xcconfig	2021-03-03 23:31:21 UTC (rev 273849)
@@ -128,6 +128,8 @@
 
 SDKROOT = macosx.internal;
 
+OTHER_CPLUSPLUSFLAGS = $(inherited) -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders;
+
 LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273848] trunk

[cdumez]

Title: [273848] trunk








Revision 273848
Author cdu...@apple.com
Date 2021-03-03 15:07:08 -0800 (Wed, 03 Mar 2021)


Log Message
Use adoptNS() right away after calling [obj copy] / [obj mutableCopy]
https://bugs.webkit.org/show_bug.cgi?id=222634

Reviewed by Darin Adler.

Use adoptNS() right away after calling [obj copy] / [obj mutableCopy] to minimize the chance of leaks.

Source/WebCore:

* editing/cocoa/HTMLConverter.mm:
(defaultParagraphStyle):
* platform/cocoa/SystemVersion.mm:
(WebCore::createSystemMarketingVersion):
(WebCore::systemMarketingVersion):

Source/WebKit:

* Shared/ApplePay/ApplePayPaymentSetupFeatures.mm:
(WebKit::PaymentSetupFeatures::decode):
* Shared/ApplePay/PaymentSetupConfiguration.mm:
(WebKit::PaymentSetupConfiguration::decode):
* Shared/ApplePay/cocoa/PaymentSetupConfiguration.mm:
(WebKitAdditions::PaymentSetupConfiguration::decode):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::systemDirectoryPath):
* UIProcess/mac/ServicesController.mm:
(WebKit::ServicesController::refreshExistingServices):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::temporaryPDFDirectoryPath):

Source/WebKitLegacy/mac:

* Misc/WebNSPasteboardExtras.mm:
(_writableTypesForImageWithArchive):
* WebCoreSupport/WebApplicationCache.mm:
(overrideBundleIdentifier):
(+[WebApplicationCache initializeWithBundleIdentifier:]):
(applicationCacheBundleIdentifier):
* WebView/WebPreferences.mm:
(classIBCreatorID):
(+[WebPreferences _setIBCreatorID:]):
(+[WebPreferences _IBCreatorID]):

Tools:

* TestWebKitAPI/Tests/WebKit/mac/ContextMenuMouseEvents.mm:
(TestWebKitAPI::runTest):
* TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm
trunk/Source/WebCore/platform/cocoa/SystemVersion.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeatures.mm
trunk/Source/WebKit/Shared/ApplePay/PaymentSetupConfiguration.mm
trunk/Source/WebKit/Shared/ApplePay/cocoa/PaymentSetupConfiguration.mm
trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm
trunk/Source/WebKit/UIProcess/mac/ServicesController.mm
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Misc/WebNSPasteboardExtras.mm
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebApplicationCache.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/mac/ContextMenuMouseEvents.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (273847 => 273848)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 23:00:40 UTC (rev 273847)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 23:07:08 UTC (rev 273848)
@@ -1,3 +1,18 @@
+2021-03-03  Chris Dumez  
+
+Use adoptNS() right away after calling [obj copy] / [obj mutableCopy]
+https://bugs.webkit.org/show_bug.cgi?id=222634
+
+Reviewed by Darin Adler.
+
+Use adoptNS() right away after calling [obj copy] / [obj mutableCopy] to minimize the chance of leaks.
+
+* editing/cocoa/HTMLConverter.mm:
+(defaultParagraphStyle):
+* platform/cocoa/SystemVersion.mm:
+(WebCore::createSystemMarketingVersion):
+(WebCore::systemMarketingVersion):
+
 2021-03-03  Zalan Bujtas  
 
 [LFC][IFC] Enable simplified vertical alignment for non-empty inline boxes


Modified: trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm (273847 => 273848)

--- trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm	2021-03-03 23:00:40 UTC (rev 273847)
+++ trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm	2021-03-03 23:07:08 UTC (rev 273848)
@@ -517,13 +517,13 @@
 
 static NSParagraphStyle *defaultParagraphStyle()
 {
-static NSMutableParagraphStyle *defaultParagraphStyle = nil;
-if (!defaultParagraphStyle) {
-defaultParagraphStyle = [[PlatformNSParagraphStyle defaultParagraphStyle] mutableCopy];
+static auto defaultParagraphStyle = makeNeverDestroyed([] {
+auto defaultParagraphStyle = adoptNS([[PlatformNSParagraphStyle defaultParagraphStyle] mutableCopy]);
 [defaultParagraphStyle setDefaultTabInterval:36];
 [defaultParagraphStyle setTabStops:@[]];
-}
-return defaultParagraphStyle;
+return defaultParagraphStyle;
+}());
+return defaultParagraphStyle.get().get();
 }
 
 RefPtr HTMLConverterCaches::computedStylePropertyForElement(Element& element, CSSPropertyID propertyId)


Modified: trunk/Source/WebCore/platform/cocoa/SystemVersion.mm (273847 => 273848)

--- trunk/Source/WebCore/platform/cocoa/SystemVersion.mm	2021-03-03 23:00:40 UTC (rev 273847)
+++ trunk/Source/WebCore/platform/cocoa/SystemVersion.mm	2021-03-03 23:07:08 UTC (rev 273848)
@@ -27,7 +27,7 @@
 
 namespace WebCore {
 
-static NSString *createSystemMarketingVersion()
+static RetainPtr createSystemMarketingVersion()
 {
 // Can

[webkit-changes] [273847] trunk/Source/WebInspectorUI

[commit-queue]

Title: [273847] trunk/Source/WebInspectorUI








Revision 273847
Author commit-qu...@webkit.org
Date 2021-03-03 15:00:40 -0800 (Wed, 03 Mar 2021)


Log Message
Web Inspector: Refine CSS Grid overlay options
https://bugs.webkit.org/show_bug.cgi?id=222428


Patch by Razvan Caliman  on 2021-03-03
Reviewed by BJ Burg.

Move CSS Grid overlay settings above node list, simplify labels, reorder and set default values.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Setting.js:
* UserInterface/Views/CSSGridSection.js:
(WI.CSSGridSection.prototype.initialLayout):
* UserInterface/Views/LayoutDetailsSidebarPanel.css:
(.details-section.layout-css-grid.collapsed > .content):
Drive-by: Fix a bug which prevented the contents from being hidden when the section is collapsed.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
trunk/Source/WebInspectorUI/UserInterface/Views/CSSGridSection.js
trunk/Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (273846 => 273847)

--- trunk/Source/WebInspectorUI/ChangeLog	2021-03-03 23:00:09 UTC (rev 273846)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-03-03 23:00:40 UTC (rev 273847)
@@ -1,3 +1,21 @@
+2021-03-03  Razvan Caliman  
+
+Web Inspector: Refine CSS Grid overlay options
+https://bugs.webkit.org/show_bug.cgi?id=222428
+
+
+Reviewed by BJ Burg.
+
+Move CSS Grid overlay settings above node list, simplify labels, reorder and set default values.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Base/Setting.js:
+* UserInterface/Views/CSSGridSection.js:
+(WI.CSSGridSection.prototype.initialLayout):
+* UserInterface/Views/LayoutDetailsSidebarPanel.css:
+(.details-section.layout-css-grid.collapsed > .content):
+Drive-by: Fix a bug which prevented the contents from being hidden when the section is collapsed.
+
 2021-02-25  BJ Burg  
 
 [Cocoa] Web Inspector: add support for receiving Web Extension events via _WKInspectorExtensionDelegate


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (273846 => 273847)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2021-03-03 23:00:09 UTC (rev 273846)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2021-03-03 23:00:40 UTC (rev 273847)
@@ -178,6 +178,8 @@
 /* Approximate count of events */
 localizedStrings["Approximate Number"] = "~%s";
 localizedStrings["Area"] = "Area";
+/* Label for option to toggle the area names setting for CSS grid overlays */
+localizedStrings["Area names @ Layout Panel Overlay Options"] = "Area Names";
 localizedStrings["Assertion"] = "Assertion";
 localizedStrings["Assertion Failed"] = "Assertion Failed";
 localizedStrings["Assertion Failed: %s"] = "Assertion Failed: %s";
@@ -842,6 +844,10 @@
 localizedStrings["Line %d"] = "Line %d";
 localizedStrings["Line %d:%d"] = "Line %d:%d";
 localizedStrings["Line Number"] = "Line Number";
+/* Label for option to toggle the line names setting for CSS grid overlays */
+localizedStrings["Line names @ Layout Panel Overlay Options"] = "Line Names";
+/* Label for option to toggle the line numbers setting for CSS grid overlays */
+localizedStrings["Line numbers @ Layout Panel Overlay Options"] = "Line Numbers";
 localizedStrings["Line wrapping:"] = "Line wrapping:";
 localizedStrings["Linear Gradient"] = "Linear Gradient";
 /* Property value for `font-variant-numeric: lining-nums`. */
@@ -1033,8 +1039,8 @@
 localizedStrings["PNG"] = "PNG";
 localizedStrings["Page"] = "Page";
 localizedStrings["Page Issue"] = "Page Issue";
-/* Heading for list of grid overlay settings */
-localizedStrings["Page Overlay Settings @ Layout Panel Section Header"] = "Grid Overlay Settings";
+/* Heading for list of grid overlay options */
+localizedStrings["Page Overlay Options @ Layout Panel Section Header"] = "Page Overlay Options";
 /* Heading for list of grid nodes */
 localizedStrings["Page Overlays @ Layout Sidebar Section Header"] = "Grid Overlays";
 localizedStrings["Page navigated at %s"] = "Page navigated at %s";
@@ -1315,11 +1321,9 @@
 localizedStrings["Show Scope Chain on pause"] = "Show Scope Chain on pause";
 localizedStrings["Show all actions"] = "Show all actions";
 localizedStrings["Show all resources"] = "Show all resources";
-/* Label for option to toggle the area names setting for CSS grid overlays */
-localizedStrings["Show area names @ Layers Panel Grid Overlay Setting"] = "Show area names";
 localizedStrings["Show compositing borders"] = "Show compositing borders";
 /* Label for option to toggle the extended lines setting for CSS grid overlays */
-localizedStrings["Show extended lines @ Layers Panel Grid Overlay Setting"] = "Show extended lines";
+localized

[webkit-changes] [273846] trunk

[ticaiolima]

Title: [273846] trunk








Revision 273846
Author ticaiol...@gmail.com
Date 2021-03-03 15:00:09 -0800 (Wed, 03 Mar 2021)


Log Message
[ESNext] Private methods can't be named as '#constructor'
https://bugs.webkit.org/show_bug.cgi?id=222680

Reviewed by Yusuke Suzuki.

JSTests:

* stress/private-method-and-field-named-constructor.js: Added.

Source/_javascript_Core:

It's a `SyntaxError` when we try to use `#constructor` as private name
for methods, accessors, and fields. This patch is fixing such bug for
methods and accessors.

* parser/Parser.cpp:
(JSC::Parser::parseClass):
(JSC::Parser::parseGetterSetter):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Parser.cpp


Added Paths

trunk/JSTests/stress/private-method-and-field-named-constructor.js




Diff

Modified: trunk/JSTests/ChangeLog (273845 => 273846)

--- trunk/JSTests/ChangeLog	2021-03-03 22:57:13 UTC (rev 273845)
+++ trunk/JSTests/ChangeLog	2021-03-03 23:00:09 UTC (rev 273846)
@@ -1,3 +1,12 @@
+2021-03-03  Caio Lima  
+
+[ESNext] Private methods can't be named as '#constructor'
+https://bugs.webkit.org/show_bug.cgi?id=222680
+
+Reviewed by Yusuke Suzuki.
+
+* stress/private-method-and-field-named-constructor.js: Added.
+
 2021-03-03  Alexey Shvayka  
 
 Add JSModuleNamespaceObject::deletePropertyByIndex() method


Added: trunk/JSTests/stress/private-method-and-field-named-constructor.js (0 => 273846)

--- trunk/JSTests/stress/private-method-and-field-named-constructor.js	(rev 0)
+++ trunk/JSTests/stress/private-method-and-field-named-constructor.js	2021-03-03 23:00:09 UTC (rev 273846)
@@ -0,0 +1,32 @@
+//@ requireOptions("--usePrivateMethods=true")
+
+function assertSyntaxError(code) {
+try {
+eval(code);
+throw new Error("Should throw SyntaxError, but executed code without throwing");
+} catch(e) {
+if (!e instanceof SyntaxError)
+throw new Error("Should throw SyntaxError, but threw " + e);
+}
+}
+
+assertSyntaxError("let C = class { #constructor() {} }");
+assertSyntaxError("let C = class { static #constructor() {} }");
+assertSyntaxError("class C { #constructor() {} }");
+assertSyntaxError("class C { static #constructor() {} }");
+
+assertSyntaxError("let C = class { get #constructor() {} }");
+assertSyntaxError("let C = class { static get #constructor() {} }");
+assertSyntaxError("class C { get #constructor() {} }");
+assertSyntaxError("class C { static get #constructor() {} }");
+
+assertSyntaxError("let C = class { set #constructor(v) {} }");
+assertSyntaxError("let C = class { static set #constructor(v) {} }");
+assertSyntaxError("class C { set #constructor(v) {} }");
+assertSyntaxError("class C { static set #constructor(v) {} }");
+
+assertSyntaxError("let C = class { #constructor; }");
+assertSyntaxError("let C = class { static #constructor; }");
+assertSyntaxError("class C { #constructor; }");
+assertSyntaxError("class C { static #constructor; }");
+


Modified: trunk/Source/_javascript_Core/ChangeLog (273845 => 273846)

--- trunk/Source/_javascript_Core/ChangeLog	2021-03-03 22:57:13 UTC (rev 273845)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-03-03 23:00:09 UTC (rev 273846)
@@ -1,3 +1,18 @@
+2021-03-03  Caio Lima  
+
+[ESNext] Private methods can't be named as '#constructor'
+https://bugs.webkit.org/show_bug.cgi?id=222680
+
+Reviewed by Yusuke Suzuki.
+
+It's a `SyntaxError` when we try to use `#constructor` as private name
+for methods, accessors, and fields. This patch is fixing such bug for
+methods and accessors.
+
+* parser/Parser.cpp:
+(JSC::Parser::parseClass):
+(JSC::Parser::parseGetterSetter):
+
 2021-03-03  Commit Queue  
 
 Unreviewed, reverting r273814.


Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (273845 => 273846)

--- trunk/Source/_javascript_Core/parser/Parser.cpp	2021-03-03 22:57:13 UTC (rev 273845)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp	2021-03-03 23:00:09 UTC (rev 273846)
@@ -3015,7 +3015,7 @@
 next();
 if (Options::usePrivateMethods() && match(OPENPAREN)) {
 semanticFailIfTrue(classScope->declarePrivateMethod(*ident, tag) & DeclarationResult::InvalidDuplicateDeclaration, "Cannot declare private method twice");
-semanticFailIfTrue(tag == ClassElementTag::Static && *ident == propertyNames.constructorPrivateField, "Cannot declare a static private method named 'constructor'");
+semanticFailIfTrue(*ident == propertyNames.constructorPrivateField, "Cannot declare a private method named '#constructor'");
 
 if (tag == ClassElementTag::Static)
 declaresStaticPrivateAccessor = true;
@@ -4482,6 +4482,7 @@
 "Cannot declare a static method named 'prototype'");
 semanticFailIfTrue(tag == ClassElementTag::Instanc

[webkit-changes] [273845] trunk/Source/WebCore

[zalan]

Title: [273845] trunk/Source/WebCore








Revision 273845
Author za...@apple.com
Date 2021-03-03 14:57:13 -0800 (Wed, 03 Mar 2021)


Log Message
[LFC][IFC] Enable simplified vertical alignment for non-empty inline boxes
https://bugs.webkit.org/show_bug.cgi?id=222666

Reviewed by Antti Koivisto.

This patch enables the simplified vertical alignment for cases when the line has non-stretching, baseline aligned non-empty inline boxes
even when the inline box spans multiple lines.
e.g.
text content

* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::canUseSimplifiedAlignment):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (273844 => 273845)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 22:55:56 UTC (rev 273844)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 22:57:13 UTC (rev 273845)
@@ -1,3 +1,19 @@
+2021-03-03  Zalan Bujtas  
+
+[LFC][IFC] Enable simplified vertical alignment for non-empty inline boxes
+https://bugs.webkit.org/show_bug.cgi?id=222666
+
+Reviewed by Antti Koivisto.
+
+This patch enables the simplified vertical alignment for cases when the line has non-stretching, baseline aligned non-empty inline boxes
+even when the inline box spans multiple lines.
+e.g.
+text content
+
+* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
+(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::canUseSimplifiedAlignment):
+
 2021-03-03  Chris Dumez  
 
 Crash under SubresourceLoader::notifyDone()


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp (273844 => 273845)

--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp	2021-03-03 22:55:56 UTC (rev 273844)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp	2021-03-03 22:57:13 UTC (rev 273845)
@@ -48,7 +48,7 @@
 struct SimplifiedVerticalAlignment {
 SimplifiedVerticalAlignment(const LineBox::InlineLevelBox& rootInlineBox);
 
-static bool canUseSimplifiedAlignment(const LineBox::InlineLevelBox& rootInlineBox, const LineBox::InlineLevelBox&, const BoxGeometry& inlineLevelBoxGeometry);
+static bool canUseSimplifiedAlignment(const LineBox::InlineLevelBox& rootInlineBox, const LineBox::InlineLevelBox&, Optional inlineLevelBoxGeometry);
 
 void align(LineBox::InlineLevelBox&);
 
@@ -227,6 +227,16 @@
 // FIXME: Add fast path support for line-height content.
 simplifiedVerticalAlignment.setEnabled(layoutState().inStandardsMode() && rootBox().style().lineHeight().isNegative());
 
+auto simplifiedAlignVerticallyIfApplicable = [&](auto& inlineLevelBox, Optional boxGeometry) {
+if (!simplifiedVerticalAlignment.isEnabled())
+return;
+if (!SimplifiedVerticalAlignment::canUseSimplifiedAlignment(rootInlineBox, inlineLevelBox, boxGeometry)) {
+simplifiedVerticalAlignment.setEnabled(false);
+return;
+}
+simplifiedVerticalAlignment.align(inlineLevelBox);
+};
+
 auto createWrappedInlineBoxes = [&] {
 if (runs.isEmpty())
 return;
@@ -258,6 +268,7 @@
 for (auto* layoutBox : WTF::makeReversedRange(layoutBoxesWithoutInlineBoxes)) {
 auto inlineBox = LineBox::InlineLevelBox::createInlineBox(*layoutBox, rootInlineBox.logicalLeft(), lineBox.contentLogicalWidth());
 setVerticalGeometryForInlineBox(*inlineBox);
+simplifiedAlignVerticallyIfApplicable(*inlineBox, { });
 lineBox.addInlineLevelBox(WTFMove(inlineBox));
 }
 };
@@ -282,17 +293,6 @@
 return true;
 };
 lineHasContent = lineHasContent || runHasContent();
-
-auto simplifiedAlignVerticallyIfApplicable = [&](auto& inlineLevelBox, const auto& boxGeometry) {
-if (!simplifiedVerticalAlignment.isEnabled())
-return;
-if (!SimplifiedVerticalAlignment::canUseSimplifiedAlignment(rootInlineBox, inlineLevelBox, boxGeometry)) {
-simplifiedVerticalAlignment.setEnabled(false);
-return;
-}
-simplifiedVerticalAlignment.align(inlineLevelBox);
-};
-
 auto logicalLeft = rootInlineBox.logicalLeft() + run.logicalLeft();
 if (run.isBox()) {
 auto& inlineLevelBoxGeometry = formattingContext().geometryForBox(layoutBox);
@@ -326,9 +326,6 @@
 lineBox.addInlineLevelBox(WTFMove(atomicInlineLevelBox));
 continue;
 }
-// FIXME: Add support for simple inline boxes too.
-// We can do simplifie

[webkit-changes] [273844] trunk/Tools

[commit-queue]

Title: [273844] trunk/Tools








Revision 273844
Author commit-qu...@webkit.org
Date 2021-03-03 14:55:56 -0800 (Wed, 03 Mar 2021)


Log Message
Move LayoutTestFinder.skip_tests to Manager._skip_tests
https://bugs.webkit.org/show_bug.cgi?id=222661

Patch by Sam Sneddon  on 2021-03-03
Reviewed by Jonathan Bedard.

This has nothing to do with finding tests, and everything to do about
test selection depending on the CLI.

Additionally, this removes the unused LayoutTestFinder.skip_tests
all_tests_list argument.

* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder._skip_tests):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._skip_tests):
(Manager._prepare_lists):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py




Diff

Modified: trunk/Tools/ChangeLog (273843 => 273844)

--- trunk/Tools/ChangeLog	2021-03-03 22:39:29 UTC (rev 273843)
+++ trunk/Tools/ChangeLog	2021-03-03 22:55:56 UTC (rev 273844)
@@ -1,3 +1,23 @@
+2021-03-03  Sam Sneddon  
+
+Move LayoutTestFinder.skip_tests to Manager._skip_tests
+https://bugs.webkit.org/show_bug.cgi?id=222661
+
+Reviewed by Jonathan Bedard.
+
+This has nothing to do with finding tests, and everything to do about
+test selection depending on the CLI.
+
+Additionally, this removes the unused LayoutTestFinder.skip_tests
+all_tests_list argument.
+
+* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
+(LayoutTestFinder._skip_tests):
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager._skip_tests):
+(Manager._prepare_lists):
+
+
 2021-03-03  Aakash Jain  
 
 [ews] Add python 3 support - part 4


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py (273843 => 273844)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py	2021-03-03 22:39:29 UTC (rev 273843)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py	2021-03-03 22:55:56 UTC (rev 273844)
@@ -189,25 +189,6 @@
 else:
 return line
 
-def skip_tests(self, paths, all_tests_list, expectations, http_tests):
-all_tests = set(all_tests_list)
-
-tests_to_skip = expectations.model().get_tests_with_result_type(test_expectations.SKIP)
-if self._options.skip_failing_tests:
-tests_to_skip.update(expectations.model().get_tests_with_result_type(test_expectations.FAIL))
-tests_to_skip.update(expectations.model().get_tests_with_result_type(test_expectations.FLAKY))
-
-if self._options.skipped == 'only':
-tests_to_skip = all_tests - tests_to_skip
-elif self._options.skipped == 'ignore':
-tests_to_skip = set()
-
-# unless of course we don't want to run the HTTP tests :)
-if not self._options.http:
-tests_to_skip.update(set(http_tests))
-
-return tests_to_skip
-
 def split_into_chunks(self, test_names):
 """split into a list to run and a set to skip, based on --run-chunk and --run-part."""
 if not self._options.run_chunk and not self._options.run_part:


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (273843 => 273844)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2021-03-03 22:39:29 UTC (rev 273843)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2021-03-03 22:55:56 UTC (rev 273844)
@@ -109,8 +109,27 @@
 def _http_tests(self, test_names):
 return set(test for test in test_names if self._is_http_test(test))
 
+def _skip_tests(self, all_tests_list, expectations, http_tests):
+all_tests = set(all_tests_list)
+
+tests_to_skip = expectations.model().get_tests_with_result_type(test_expectations.SKIP)
+if self._options.skip_failing_tests:
+tests_to_skip.update(expectations.model().get_tests_with_result_type(test_expectations.FAIL))
+tests_to_skip.update(expectations.model().get_tests_with_result_type(test_expectations.FLAKY))
+
+if self._options.skipped == 'only':
+tests_to_skip = all_tests - tests_to_skip
+elif self._options.skipped == 'ignore':
+tests_to_skip = set()
+
+# unless of course we don't want to run the HTTP tests :)
+if not self._options.http:
+tests_to_skip.update(set(http_tests))
+
+return tests_to_skip
+
 def _prepare_lists(self, paths, test_names, device_type=None):
-tests_to_skip = self._finder.skip_tests(paths, test_names, self._expectations[device_type], self._http_tests(test_names))
+tests_to_skip = self._skip_tests(test_names, self._expectations[device_type], self._http_tests(test_names))
 tests_to_run = [test for test in test_names

[webkit-changes] [273843] trunk

[commit-queue]

Title: [273843] trunk








Revision 273843
Author commit-qu...@webkit.org
Date 2021-03-03 14:39:29 -0800 (Wed, 03 Mar 2021)


Log Message
Unreviewed, reverting r273727.
https://bugs.webkit.org/show_bug.cgi?id=222689

Landed broken test

Reverted changeset:

"Null check platformData when decoding"
https://bugs.webkit.org/show_bug.cgi?id=221442
https://trac.webkit.org/changeset/273727

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp


Removed Paths

trunk/LayoutTests/ipc/pasteboard-write-custom-data-expected.txt
trunk/LayoutTests/ipc/pasteboard-write-custom-data.html




Diff

Modified: trunk/LayoutTests/ChangeLog (273842 => 273843)

--- trunk/LayoutTests/ChangeLog	2021-03-03 22:37:40 UTC (rev 273842)
+++ trunk/LayoutTests/ChangeLog	2021-03-03 22:39:29 UTC (rev 273843)
@@ -1,3 +1,16 @@
+2021-03-03  Commit Queue  
+
+Unreviewed, reverting r273727.
+https://bugs.webkit.org/show_bug.cgi?id=222689
+
+Landed broken test
+
+Reverted changeset:
+
+"Null check platformData when decoding"
+https://bugs.webkit.org/show_bug.cgi?id=221442
+https://trac.webkit.org/changeset/273727
+
 2021-03-03  Robert Jenner  
 
 [ macOS Wk2 ] inspector/model/auditTestCase.html is a flakey timeout


Deleted: trunk/LayoutTests/ipc/pasteboard-write-custom-data-expected.txt (273842 => 273843)

--- trunk/LayoutTests/ipc/pasteboard-write-custom-data-expected.txt	2021-03-03 22:37:40 UTC (rev 273842)
+++ trunk/LayoutTests/ipc/pasteboard-write-custom-data-expected.txt	2021-03-03 22:39:29 UTC (rev 273843)
@@ -1 +0,0 @@
-Test passes if it does not crash.


Deleted: trunk/LayoutTests/ipc/pasteboard-write-custom-data.html (273842 => 273843)

--- trunk/LayoutTests/ipc/pasteboard-write-custom-data.html	2021-03-03 22:37:40 UTC (rev 273842)
+++ trunk/LayoutTests/ipc/pasteboard-write-custom-data.html	2021-03-03 22:39:29 UTC (rev 273843)
@@ -1,11 +0,0 @@
-
-
-Test passes if it does not crash.
-
-if (window.testRunner)
-testRunner.dumpAsText();
-if (window.IPC) {
-buf = new Uint8Array([0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0xff,0xff,0xff,0xff,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x10,0x0,0x0,0x0,0x0,0x0,0xb,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x2,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x9,])
 ;
-IPC.sendMessage('UI',9,IPC.messages.WebPasteboardProxy_WriteCustomData.name,[buf]);
-}
-


Modified: trunk/Source/WebKit/ChangeLog (273842 => 273843)

--- trunk/Source/WebKit/ChangeLog	2021-03-03 22:37:40 UTC (rev 273842)
+++ trunk/Source/WebKit/ChangeLog	2021-03-03 22:39:29 UTC (rev 273843)
@@ -1,5 +1,18 @@
 2021-03-03  Commit Queue  
 
+Unreviewed, reverting r273727.
+https://bugs.webkit.org/show_bug.cgi?id=222689
+
+Landed broken test
+
+Reverted changeset:
+
+"Null check platformData when decoding"
+https://bugs.webkit.org/show_bug.cgi?id=221442
+https://trac.webkit.org/changeset/273727
+
+2021-03-03  Commit Queue  
+
 Unreviewed, reverting r273814.
 https://bugs.webkit.org/show_bug.cgi?id=222676
 


Modified: trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp (273842 => 273843)

--- trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp	2021-03-03 22:37:40 UTC (rev 273842)
+++ trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp	2021-03-03 22:39:29 UTC (rev 273843)
@@ -1571,7 +1571,7 @@
 
 if (hasBuffer) {
 RefPtr value;
-if (!decodeSharedBuffer(decoder, value) || !value)
+if (!decodeSharedBuffer(decoder, value))
 return false;
 data.platformData = { value.releaseNonNull() };
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273842] trunk/Source/WebCore

[cdumez]

Title: [273842] trunk/Source/WebCore








Revision 273842
Author cdu...@apple.com
Date 2021-03-03 14:37:40 -0800 (Wed, 03 Mar 2021)


Log Message
Crash under SubresourceLoader::notifyDone()
https://bugs.webkit.org/show_bug.cgi?id=222683


Reviewed by Geoffrey Garen.

We were crashing doing a null-dereference of m_documentLoader under
SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader
similarly to what is already done elsewhere in ResourceLoader.

No new tests, I do not know how to reproduce this.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::notifyDone):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (273841 => 273842)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 22:23:18 UTC (rev 273841)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 22:37:40 UTC (rev 273842)
@@ -1,3 +1,20 @@
+2021-03-03  Chris Dumez  
+
+Crash under SubresourceLoader::notifyDone()
+https://bugs.webkit.org/show_bug.cgi?id=222683
+
+
+Reviewed by Geoffrey Garen.
+
+We were crashing doing a null-dereference of m_documentLoader under
+SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader
+similarly to what is already done elsewhere in ResourceLoader.
+
+No new tests, I do not know how to reproduce this.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::notifyDone):
+
 2021-03-03  Aditya Keerthi  
 
 REGRESSION (r273154): Speedometer 2 is 1-2% regressed on iOS


Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (273841 => 273842)

--- trunk/Source/WebCore/loader/SubresourceLoader.cpp	2021-03-03 22:23:18 UTC (rev 273841)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp	2021-03-03 22:37:40 UTC (rev 273842)
@@ -845,10 +845,12 @@
 if (m_state == CancelledWhileInitializing)
 shouldPerformPostLoadActions = false;
 #endif
-m_documentLoader->cachedResourceLoader().loadDone(type, shouldPerformPostLoadActions);
+if (m_documentLoader)
+m_documentLoader->cachedResourceLoader().loadDone(type, shouldPerformPostLoadActions);
 if (reachedTerminalState())
 return;
-m_documentLoader->removeSubresourceLoader(type, this);
+if (m_documentLoader)
+m_documentLoader->removeSubresourceLoader(type, this);
 }
 
 void SubresourceLoader::releaseResources()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273841] trunk/Source/WTF

[commit-queue]

Title: [273841] trunk/Source/WTF








Revision 273841
Author commit-qu...@webkit.org
Date 2021-03-03 14:23:18 -0800 (Wed, 03 Mar 2021)


Log Message
std::is_literal_type causes -Wdeprecated-declarations warning with GCC 11
https://bugs.webkit.org/show_bug.cgi?id=220662


Patch by Michael Catanzaro  on 2021-03-03
Reviewed by Darin Adler.

Ignore the warning. It would be better to not use the deprecated std::is_literal_type, but
this works for now.

* wtf/Variant.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Variant.h




Diff

Modified: trunk/Source/WTF/ChangeLog (273840 => 273841)

--- trunk/Source/WTF/ChangeLog	2021-03-03 22:23:00 UTC (rev 273840)
+++ trunk/Source/WTF/ChangeLog	2021-03-03 22:23:18 UTC (rev 273841)
@@ -1,3 +1,16 @@
+2021-03-03  Michael Catanzaro  
+
+std::is_literal_type causes -Wdeprecated-declarations warning with GCC 11
+https://bugs.webkit.org/show_bug.cgi?id=220662
+
+
+Reviewed by Darin Adler.
+
+Ignore the warning. It would be better to not use the deprecated std::is_literal_type, but
+this works for now.
+
+* wtf/Variant.h:
+
 2021-03-03  Tim Horton  
 
 Modernize WebKit2 PDFKit softlinking
@@ -6609,7 +6622,8 @@
 
 Reviewed by Carlos Garcia Campos.
 
- use the RunLoop. Let's match them for consistency, and to delete some
+As of https://bugs.webkit.org/show_bug.cgi?id=213063, Darwin platforms
+use the RunLoop. Let's match them for consistency, and to delete some
 code.
 
 * wtf/generic/MainThreadGeneric.cpp:


Modified: trunk/Source/WTF/wtf/Variant.h (273840 => 273841)

--- trunk/Source/WTF/wtf/Variant.h	2021-03-03 22:23:00 UTC (rev 273840)
+++ trunk/Source/WTF/wtf/Variant.h	2021-03-03 22:23:18 UTC (rev 273841)
@@ -387,6 +387,8 @@
 template
 union __variant_data;
 
+// std::is_literal_type is deprecated in C++17 and removed in C++20
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 template::value>
 struct __variant_storage{
 typedef _Type __type;
@@ -405,6 +407,7 @@
 }
 static void __destroy(__type&){}
 };
+ALLOW_DEPRECATED_DECLARATIONS_END
 
 template
 struct __storage_wrapper{






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273840] trunk/LayoutTests

[jenner]

Title: [273840] trunk/LayoutTests








Revision 273840
Author jen...@apple.com
Date 2021-03-03 14:23:00 -0800 (Wed, 03 Mar 2021)


Log Message
[ macOS Wk2 ] inspector/model/auditTestCase.html is a flakey timeout
https://bugs.webkit.org/show_bug.cgi?id=222677

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations: Updating test expectations to Pass Timeout until test is fixed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (273839 => 273840)

--- trunk/LayoutTests/ChangeLog	2021-03-03 22:04:55 UTC (rev 273839)
+++ trunk/LayoutTests/ChangeLog	2021-03-03 22:23:00 UTC (rev 273840)
@@ -1,3 +1,12 @@
+2021-03-03  Robert Jenner  
+
+[ macOS Wk2 ] inspector/model/auditTestCase.html is a flakey timeout
+https://bugs.webkit.org/show_bug.cgi?id=222677
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations: Updating test expectations to Pass Timeout until test is fixed.
+
 2021-03-03  Truitt Savell  
 
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html fails for mac wk1 debug


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (273839 => 273840)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-03-03 22:04:55 UTC (rev 273839)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-03-03 22:23:00 UTC (rev 273840)
@@ -1362,4 +1362,6 @@
 imported/w3c/web-platform-tests/mediacapture-record/idlharness.window.html [ Skip ]
 imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-error.html [ Pass Failure ]
 
-webkit.org/b/222500 fast/canvas/webgl/texImage2D-video-flipY-false.html [ Timeout ]
\ No newline at end of file
+webkit.org/b/222500 fast/canvas/webgl/texImage2D-video-flipY-false.html [ Timeout ]
+
+webkit.org/b/222677 inspector/model/auditTestCase.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273839] trunk/Source/WebCore

[akeerthi]

Title: [273839] trunk/Source/WebCore








Revision 273839
Author akeer...@apple.com
Date 2021-03-03 14:04:55 -0800 (Wed, 03 Mar 2021)


Log Message
REGRESSION (r273154): Speedometer 2 is 1-2% regressed on iOS
https://bugs.webkit.org/show_bug.cgi?id=222663


Reviewed by Ryosuke Niwa.

A 1-2% regression was observed in Speedometer 2 after enabling the iOS
Form Control Refresh (FCR). Traces indicated an increased amount of time
spent in style resolution. Note that currently the FCR styles are
appended to the base UA stylesheet at runtime, to apply the necessary
changes for the new appearance, while making it possible to toggle the
feature.

To fix, the FCR stylesheet is merged into the base UA stylesheet. This
avoids ruleset duplication, which made it more expensive to resolve
styles. To preserve the old appearance when the feature is runtime
disabled, the old styles are moved into a separate stylesheet, appended
at runtime.

The fix was verified as an equivalent progression using internal A/B
testing infrastructure.

Note that this solution means that disabling the FCR will result in a
Speedometer regression, due to ruleset duplication. However, this should
not be a concern since the feature is controlled by an internal switch,
is enabled by default, and is not intended to be disabled.

* css/formControlsIOS.css:
* css/html.css:
* style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/formControlsIOS.css
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/style/UserAgentStyle.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (273838 => 273839)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 22:00:22 UTC (rev 273838)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 22:04:55 UTC (rev 273839)
@@ -1,3 +1,37 @@
+2021-03-03  Aditya Keerthi  
+
+REGRESSION (r273154): Speedometer 2 is 1-2% regressed on iOS
+https://bugs.webkit.org/show_bug.cgi?id=222663
+
+
+Reviewed by Ryosuke Niwa.
+
+A 1-2% regression was observed in Speedometer 2 after enabling the iOS
+Form Control Refresh (FCR). Traces indicated an increased amount of time
+spent in style resolution. Note that currently the FCR styles are
+appended to the base UA stylesheet at runtime, to apply the necessary
+changes for the new appearance, while making it possible to toggle the
+feature.
+
+To fix, the FCR stylesheet is merged into the base UA stylesheet. This
+avoids ruleset duplication, which made it more expensive to resolve
+styles. To preserve the old appearance when the feature is runtime
+disabled, the old styles are moved into a separate stylesheet, appended
+at runtime.
+
+The fix was verified as an equivalent progression using internal A/B
+testing infrastructure.
+
+Note that this solution means that disabling the FCR will result in a
+Speedometer regression, due to ruleset duplication. However, this should
+not be a concern since the feature is controlled by an internal switch,
+is enabled by default, and is not intended to be disabled.
+
+* css/formControlsIOS.css:
+* css/html.css:
+* style/UserAgentStyle.cpp:
+(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
+
 2021-03-03  Alex Christensen  
 
 Limit HashTable entry size to 500 bytes


Modified: trunk/Source/WebCore/css/formControlsIOS.css (273838 => 273839)

--- trunk/Source/WebCore/css/formControlsIOS.css	2021-03-03 22:00:22 UTC (rev 273838)
+++ trunk/Source/WebCore/css/formControlsIOS.css	2021-03-03 22:04:55 UTC (rev 273839)
@@ -24,91 +24,101 @@
 
 #if defined(ENABLE_IOS_FORM_CONTROL_REFRESH) && ENABLE_IOS_FORM_CONTROL_REFRESH
 
+/* Legacy styles for iOS form controls. */
+
 textarea,
 input {
-border: 1px solid rgb(217, 217, 217);
-font: 11px system-ui;
+border: 1px solid #4c4c4c;
+font: 11px Helvetica, -webkit-pictograph;
 }
 
 input:matches([type="checkbox"], [type="radio"]) {
-border: initial;
-box-sizing: border-box;
+border: 1px solid #4c4c4c;
 }
 
 input::-webkit-list-button {
-width: 11px;
-content: url('data:image/svg+xml,');
+width: 16px;
+content: url('data:image/svg+xml,');
 }
 
 input[type="search"] {
-border: initial;
-background-color: rgb(238, 238, 238);
+border: 1px solid #4c4c4c;
+background-color: initial;
 }
 
 input[type="search"]::-webkit-search-decoration,
+input[type="search"]::-webkit-search-results-decoration {
+margin: auto 0;
+}
+
+input[type="search"]::-webkit-search-results-button {
+align-self: initial;
+margin: initial;
+}
+
+input[type="search"]::-webkit-search-decoration,
 input[type="search"]::-webkit-search-results-decoration,
 input[type="search"]::-webkit-search-results-button {
-align-self: flex-start;
-background-color: darkgray;
-

[webkit-changes] [273838] trunk/Tools

[aakash_jain]

Title: [273838] trunk/Tools








Revision 273838
Author aakash_j...@apple.com
Date 2021-03-03 14:00:22 -0800 (Wed, 03 Mar 2021)


Log Message
[ews] Add python 3 support - part 4
https://bugs.webkit.org/show_bug.cgi?id=222672

Reviewed by Jonathan Bedard.

* CISupport/ews-build/events.py:
(JSONProducer): Use implementer (python 3 compatible) instead of implements.
(JSONProducer.__init__): Encode data as utf-8 explicitly.
(Events):
(Events.sendData):

Modified Paths

trunk/Tools/CISupport/ews-build/events.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/ews-build/events.py (273837 => 273838)

--- trunk/Tools/CISupport/ews-build/events.py	2021-03-03 21:56:50 UTC (rev 273837)
+++ trunk/Tools/CISupport/ews-build/events.py	2021-03-03 22:00:22 UTC (rev 273838)
@@ -34,18 +34,18 @@
 from twisted.web.client import Agent
 from twisted.web.http_headers import Headers
 from twisted.web.iweb import IBodyProducer
-from zope.interface import implements
+from zope.interface import implementer
 
 
+@implementer(IBodyProducer)
 class JSONProducer(object):
 """
 Perform JSON asynchronously as to not lock the buildbot main event loop
 """
-implements(IBodyProducer)
 
 def __init__(self, data):
 try:
-self.body = json.dumps(data, default=self.json_serialize_datetime)
+self.body = json.dumps(data, default=self.json_serialize_datetime).encode('utf-8')
 except TypeError:
 self.body = ''
 self.length = len(self.body)
@@ -73,7 +73,7 @@
 
 class Events(service.BuildbotService):
 
-EVENT_SERVER_ENDPOINT = 'https://ews.webkit.org/results/'
+EVENT_SERVER_ENDPOINT = b'https://ews.webkit.org/results/'
 
 def __init__(self, master_hostname, type_prefix='', name='Events'):
 """
@@ -95,7 +95,7 @@
 agent = Agent(reactor)
 body = JSONProducer(data)
 
-agent.request('POST', self.EVENT_SERVER_ENDPOINT, Headers({'Content-Type': ['application/json']}), body)
+agent.request(b'POST', self.EVENT_SERVER_ENDPOINT, Headers({'Content-Type': ['application/json']}), body)
 
 def getBuilderName(self, build):
 if not (build and 'properties' in build):


Modified: trunk/Tools/ChangeLog (273837 => 273838)

--- trunk/Tools/ChangeLog	2021-03-03 21:56:50 UTC (rev 273837)
+++ trunk/Tools/ChangeLog	2021-03-03 22:00:22 UTC (rev 273838)
@@ -1,3 +1,16 @@
+2021-03-03  Aakash Jain  
+
+[ews] Add python 3 support - part 4
+https://bugs.webkit.org/show_bug.cgi?id=222672
+
+Reviewed by Jonathan Bedard.
+
+* CISupport/ews-build/events.py:
+(JSONProducer): Use implementer (python 3 compatible) instead of implements.
+(JSONProducer.__init__): Encode data as utf-8 explicitly.
+(Events):
+(Events.sendData):
+
 2021-03-03  Robert Jenner  
 
 Adding myself as a committer in the contributors file. 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273837] trunk/Tools

[jenner]

Title: [273837] trunk/Tools








Revision 273837
Author jen...@apple.com
Date 2021-03-03 13:56:50 -0800 (Wed, 03 Mar 2021)


Log Message
Adding myself as a committer in the contributors file.
N/A

N/A

* Scripts/webkitpy/common/config/contributors.json: Added myself as a committer.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (273836 => 273837)

--- trunk/Tools/ChangeLog	2021-03-03 21:29:10 UTC (rev 273836)
+++ trunk/Tools/ChangeLog	2021-03-03 21:56:50 UTC (rev 273837)
@@ -1,3 +1,12 @@
+2021-03-03  Robert Jenner  
+
+Adding myself as a committer in the contributors file. 
+N/A
+
+N/A
+
+* Scripts/webkitpy/common/config/contributors.json: Added myself as a committer.
+
 2021-03-03  Commit Queue  
 
 Unreviewed, reverting r273814.


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (273836 => 273837)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2021-03-03 21:29:10 UTC (rev 273836)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2021-03-03 21:56:50 UTC (rev 273837)
@@ -4836,6 +4836,12 @@
  "rhogan"
   ]
},
+   "Robert Jenner" : {
+  "emails" : [
+ "jen...@apple.com"
+  ],
+  "status" : "committer"
+   },
"Robert Kroeger" : {
   "emails" : [
  "rjkro...@chromium.org"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273836] trunk

[commit-queue]

Title: [273836] trunk








Revision 273836
Author commit-qu...@webkit.org
Date 2021-03-03 13:29:10 -0800 (Wed, 03 Mar 2021)


Log Message
Unreviewed, reverting r273814.
https://bugs.webkit.org/show_bug.cgi?id=222676

Unresolved types in _javascript_Core-4.0.gir

Reverted changeset:

"[CMake] _javascript_Core GLib headers should be copies"
https://bugs.webkit.org/show_bug.cgi?id=222625
https://trac.webkit.org/changeset/273814

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/API/glib/JSCClassPrivate.h
trunk/Source/_javascript_Core/API/glib/JSCContext.cpp
trunk/Source/_javascript_Core/API/glib/JSCContextPrivate.h
trunk/Source/_javascript_Core/API/glib/JSCExceptionPrivate.h
trunk/Source/_javascript_Core/API/glib/JSCValuePrivate.h
trunk/Source/_javascript_Core/API/glib/JSCVirtualMachine.cpp
trunk/Source/_javascript_Core/API/glib/JSCVirtualMachinePrivate.h
trunk/Source/_javascript_Core/API/glib/JSCWrapperMap.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GLib.cmake
trunk/Source/_javascript_Core/PlatformGTK.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMNode.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/wpe/CMakeLists.txt
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake
trunk/Tools/TestWebKitAPI/PlatformWPE.cmake
trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp
trunk/Tools/TestWebKitAPI/glib/CMakeLists.txt
trunk/Tools/TestWebKitAPI/glib/PlatformGTK.cmake




Diff

Modified: trunk/ChangeLog (273835 => 273836)

--- trunk/ChangeLog	2021-03-03 21:23:08 UTC (rev 273835)
+++ trunk/ChangeLog	2021-03-03 21:29:10 UTC (rev 273836)
@@ -1,3 +1,16 @@
+2021-03-03  Commit Queue  
+
+Unreviewed, reverting r273814.
+https://bugs.webkit.org/show_bug.cgi?id=222676
+
+Unresolved types in _javascript_Core-4.0.gir
+
+Reverted changeset:
+
+"[CMake] _javascript_Core GLib headers should be copies"
+https://bugs.webkit.org/show_bug.cgi?id=222625
+https://trac.webkit.org/changeset/273814
+
 2021-03-03  Don Olmstead  
 
 [CMake] _javascript_Core GLib headers should be copies


Modified: trunk/Source/_javascript_Core/API/glib/JSCClassPrivate.h (273835 => 273836)

--- trunk/Source/_javascript_Core/API/glib/JSCClassPrivate.h	2021-03-03 21:23:08 UTC (rev 273835)
+++ trunk/Source/_javascript_Core/API/glib/JSCClassPrivate.h	2021-03-03 21:29:10 UTC (rev 273836)
@@ -19,18 +19,12 @@
 
 #pragma once
 
-#include 
-#include 
-#include 
+#include "APICast.h"
+#include "JSCClass.h"
+#include "JSCContext.h"
+#include "JSCValue.h"
 #include 
 
-namespace JSC {
-class JSObject;
-}
-
-typedef struct OpaqueJSClass* JSClassRef;
-typedef struct OpaqueJSContext* JSGlobalContextRef;
-
 GRefPtr jscClassCreate(JSCContext*, const char*, JSCClass*, JSCClassVTable*, GDestroyNotify);
 JSClassRef jscClassGetJSClass(JSCClass*);
 JSC::JSObject* jscClassGetOrCreateJSWrapper(JSCClass*, JSCContext*, gpointer);


Modified: trunk/Source/_javascript_Core/API/glib/JSCContext.cpp (273835 => 273836)

--- trunk/Source/_javascript_Core/API/glib/JSCContext.cpp	2021-03-03 21:23:08 UTC (rev 273835)
+++ trunk/Source/_javascript_Core/API/glib/JSCContext.cpp	2021-03-03 21:29:10 UTC (rev 273836)
@@ -20,7 +20,6 @@
 #include "config.h"
 #include "JSCContext.h"
 
-#include "APICast.h"
 #include "JSCClassPrivate.h"
 #include "JSCContextPrivate.h"
 #include "JSCExceptionPrivate.h"


Modified: trunk/Source/_javascript_Core/API/glib/JSCContextPrivate.h (273835 => 273836)

--- trunk/Source/_javascript_Core/API/glib/JSCContextPrivate.h	2021-03-03 21:23:08 UTC (rev 273835)
+++ trunk/Source/_javascript_Core/API/glib/JSCContextPrivate.h	2021-03-03 21:29:10 UTC (rev 273836)
@@ -19,19 +19,12 @@
 
 #pragma once
 
-#include 
-#include 
+#include "APICast.h"
+#include "JSCContext.h"
+#include "JSCValue.h"
+#include "JSContextRef.h"
 #include 
 
-namespace JSC {
-class JSObject;
-}
-
-typedef struct OpaqueJSClass* JSClassRef;
-typedef struct OpaqueJSContext* JSGlobalContextRef;
-typedef const struct OpaqueJSValue* JSValueRef;
-typedef struct OpaqueJSValue* JSObjectRef;
-
 JS_EXPORT_PRIVATE GRefPtr jscContextGetOrCreate(JSGlobalContextRef);
 JS_EXPORT_PRIVATE JSGlobalContextRef jscContextGetJSContext(JSCContext*);
 JS_EXPORT_PRIVATE GRefPtr jscContextGetOrCreateValue(JSCContext*, JSValueRef);


Modified: trunk/Source/_javascript_Core/API/glib/JSCExceptionPrivate.h (273835 => 273836)

--- trunk/Source/_javascript_Core/API/glib/JSCExceptionPrivate.h	2021-03-03 21:23:08 UTC (rev 273835)
+++ trunk/Source/_javascript_Core/API/glib/JSCExceptionPrivate.h	2021-03-03 21:29:10 UTC (rev 273836)
@@ -19,8 +19,8 @@
 
 #pragma once
 
-#include 
-#include 
+#include "JSCContext.h"
+#include "JSCException.h"
 #include 
 
 GRefPtr j

[webkit-changes] [273835] trunk/Tools

[commit-queue]

Title: [273835] trunk/Tools








Revision 273835
Author commit-qu...@webkit.org
Date 2021-03-03 13:23:08 -0800 (Wed, 03 Mar 2021)


Log Message
Remove LayoutTestFinder.touched_tests, which is now dead code
https://bugs.webkit.org/show_bug.cgi?id=222660

Patch by Sam Sneddon  on 2021-03-03
Reviewed by Jonathan Bedard.

* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder.find_touched_tests): Removed.
* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
Remove related tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (273834 => 273835)

--- trunk/Tools/ChangeLog	2021-03-03 21:05:25 UTC (rev 273834)
+++ trunk/Tools/ChangeLog	2021-03-03 21:23:08 UTC (rev 273835)
@@ -1,3 +1,15 @@
+2021-03-03  Sam Sneddon  
+
+Remove LayoutTestFinder.touched_tests, which is now dead code
+https://bugs.webkit.org/show_bug.cgi?id=222660
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
+(LayoutTestFinder.find_touched_tests): Removed.
+* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
+Remove related tests.
+
 2021-03-03  Jonathan Bedard  
 
 [resultsdbpy] Make testing compatible with Python 3.8


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py (273834 => 273835)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py	2021-03-03 21:05:25 UTC (rev 273834)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py	2021-03-03 21:23:08 UTC (rev 273835)
@@ -146,31 +146,6 @@
 return True
 return False
 
-def find_touched_tests(self, new_or_modified_paths, apply_skip_expectations=True):
-potential_test_paths = []
-for test_file in new_or_modified_paths:
-if not test_file.startswith(self.LAYOUT_TESTS_DIRECTORY):
-continue
-
-test_file = self._strip_test_dir_prefix(test_file)
-test_paths = self._port.potential_test_names_from_expected_file(test_file)
-if test_paths:
-potential_test_paths.extend(test_paths)
-else:
-potential_test_paths.append(test_file)
-
-if not potential_test_paths:
-return None
-
-tests = self.find_tests_by_path(list(set(potential_test_paths)))
-if not apply_skip_expectations:
-return tests
-
-expectations = test_expectations.TestExpectations(self._port, tests, force_expectations_pass=False)
-expectations.parse_all_expectations()
-tests_to_skip = self.skip_tests(potential_test_paths, tests, expectations, None)
-return [test for test in tests if test not in tests_to_skip]
-
 def _strip_test_dir_prefixes(self, paths):
 return [self._strip_test_dir_prefix(path) for path in paths if path]
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py (273834 => 273835)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py	2021-03-03 21:05:25 UTC (rev 273834)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py	2021-03-03 21:23:08 UTC (rev 273835)
@@ -46,15 +46,6 @@
 port = TestPort(host)
 return LayoutTestFinder(port, None)
 
-def touched_files(self, touched_files, fs=None):
-host = MockHost()
-if fs:
-host.filesystem = fs
-else:
-fs = host.filesystem
-port = TestPort(host)
-return (fs, MockLayoutTestFinder(port, optparse.Values({'skipped': 'always', 'skip_failing_tests': False, 'http': True})).find_touched_tests(touched_files))
-
 def test_supported_test_extensions(self):
 self.assertEqual(_supported_test_extensions & Port._supported_reference_extensions, Port._supported_reference_extensions)
 
@@ -139,45 +130,3 @@
 self.assertFalse(finder._is_w3c_resource_file(finder._filesystem, finder._port.layout_tests_dir() + "/imported/w3c/web-platform-tests/XMLHttpRequest", "xmlhttprequest-sync-block-defer-scripts-subframe.html.html"))
 self.assertTrue(finder._is_w3c_resource_file(finder._filesystem, finder._port.layout_tests_dir() + "/imported/w3c/web-platform-tests/XMLHttpRequest", "xmlhttprequest-sync-block-defer-scripts-subframe.html"))
 self.assertTrue(finder._is_w3c_resource_file(finder._filesystem, finder._port.layout_tests_dir() + "/imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace-tests", "test.html"))
-
-def test_touched_test(self):
-paths = ['LayoutTests/test.html', 'LayoutTests/test', 'test2.html', 'Source/test1.html']
-fs, touched_tests = se

[webkit-changes] [273834] trunk/Tools

[jbedard]

Title: [273834] trunk/Tools








Revision 273834
Author jbed...@apple.com
Date 2021-03-03 13:05:25 -0800 (Wed, 03 Mar 2021)


Log Message
[resultsdbpy] Make testing compatible with Python 3.8
https://bugs.webkit.org/show_bug.cgi?id=222678


Rubber-stamped by Aakash Jain.

* Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Bump version.
* Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_test_context.py:
(FlaskTestContext):
(FlaskTestContext.start_webserver): Make function pickle able.
(FlaskTestContext.__init__): Pass class to owning webserver setup.
(FlaskTestContext.__enter__):
* Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
(FlaskTestCase.run_with_real_webserver.decorator.real_method):
* Scripts/libraries/resultsdbpy/resultsdbpy/model/cassandra_context.py:
(filter_for_argument): Style fix.
* Scripts/libraries/resultsdbpy/setup.py: Bump version.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_test_context.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_testcase.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/cassandra_context.py
trunk/Tools/Scripts/libraries/resultsdbpy/setup.py




Diff

Modified: trunk/Tools/ChangeLog (273833 => 273834)

--- trunk/Tools/ChangeLog	2021-03-03 21:04:47 UTC (rev 273833)
+++ trunk/Tools/ChangeLog	2021-03-03 21:05:25 UTC (rev 273834)
@@ -1,3 +1,23 @@
+2021-03-03  Jonathan Bedard  
+
+[resultsdbpy] Make testing compatible with Python 3.8
+https://bugs.webkit.org/show_bug.cgi?id=222678
+
+
+Rubber-stamped by Aakash Jain.
+
+* Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Bump version.
+* Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_test_context.py:
+(FlaskTestContext):
+(FlaskTestContext.start_webserver): Make function pickle able.
+(FlaskTestContext.__init__): Pass class to owning webserver setup.
+(FlaskTestContext.__enter__):
+* Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
+(FlaskTestCase.run_with_real_webserver.decorator.real_method):
+* Scripts/libraries/resultsdbpy/resultsdbpy/model/cassandra_context.py:
+(filter_for_argument): Style fix.
+* Scripts/libraries/resultsdbpy/setup.py: Bump version.
+
 2021-03-03  Kate Cheney  
 
 Report the correct document uri in the case of a ContentSecurityPolicyClient


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py (273833 => 273834)

--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py	2021-03-03 21:04:47 UTC (rev 273833)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py	2021-03-03 21:05:25 UTC (rev 273834)
@@ -44,6 +44,6 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(1, 1, 2)
+version = Version(1, 1, 3)
 
 name = 'resultsdbpy'


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_test_context.py (273833 => 273834)

--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_test_context.py	2021-03-03 21:04:47 UTC (rev 273833)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_test_context.py	2021-03-03 21:05:25 UTC (rev 273834)
@@ -30,23 +30,24 @@
 class FlaskTestContext(object):
 PORT = 5001
 
-@classmethod
-def start_webserver(cls, method, semaphore):
+@staticmethod
+def start_webserver(cls, semaphore, **kwargs):
 try:
 app = Flask('testing')
-method(app)
+cls.setup_webserver(app, **kwargs)
 app.add_url_rule('/__health', 'health', lambda: 'ok', methods=('GET',))
 finally:
 semaphore.release()
-return app.run(host='0.0.0.0', port=cls.PORT)
+return app.run(host='0.0.0.0', port=FlaskTestContext.PORT)
 
-def __init__(self, method):
-self.method = method
+def __init__(self, cls, **kwargs):
+self.cls = cls
+self.kwargs = kwargs
 self.process = None
 
 def __enter__(self):
 semaphore = Semaphore(0)
-self.process = Process(target=self.start_webserver, args=(self.method, semaphore))
+self.process = Process(target=self.start_webserver, args=(self.cls, semaphore), kwargs=self.kwargs)
 self.process.start()
 
 with semaphore:


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_testcase.py (273833 => 273834)

--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_testcase.py	2021-03-03 21:04:47 UTC (rev 273833)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_testcase.py	2021-03-03 21:05:25 UTC (rev 273834)
@@ -89,7 +89,7 @@
 def run_with_real_webserve

[webkit-changes] [273833] trunk/Source

[timothy_horton]

Title: [273833] trunk/Source








Revision 273833
Author timothy_hor...@apple.com
Date 2021-03-03 13:04:47 -0800 (Wed, 03 Mar 2021)


Log Message
Modernize WebKit2 PDFKit softlinking
https://bugs.webkit.org/show_bug.cgi?id=222643

Reviewed by Alex Christensen.

Source/WebKit:

WebKit2 has long had an unusual way of softlinking PDFKit, using NSBundle.
It has caused much trouble in the past, because it means that running
WebKit against a custom PDFKit requires either installing it into
the system, or changing the hardcoded path.

Instead of this, just use the normal softlinking macros that the rest
of WebKit uses.

* Shared/Cocoa/PDFKitSoftLink.h: Added.
* Shared/Cocoa/PDFKitSoftLink.mm: Added.
* Shared/mac/PDFKitImports.h: Removed.
* Shared/mac/PDFKitImports.mm: Removed.
* SourcesCocoa.txt:
* UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _drawPDFDocument:page:atPoint:]):
(-[WKPrintingView drawRect:]):
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Plugins/PDF/PDFPlugin.h:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel):
(WebKit::PDFPlugin::threadEntry):
(WebKit::PDFPlugin::documentDataDidFinishLoading):
(WebKit::PDFPlugin::setActiveAnnotation):
(WebKit::PDFPlugin::nextMatchForString):
(WebKit:: const):
* WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::create):
* WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
* WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:
* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldUsePDFPlugin const):
(WebKit::drawPDFPage):

Source/WTF:

* wtf/PlatformHave.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/mac/WKPrintingView.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm


Added Paths

trunk/Source/WebKit/Shared/Cocoa/PDFKitSoftLink.h
trunk/Source/WebKit/Shared/Cocoa/PDFKitSoftLink.mm


Removed Paths

trunk/Source/WebKit/Shared/mac/PDFKitImports.h
trunk/Source/WebKit/Shared/mac/PDFKitImports.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (273832 => 273833)

--- trunk/Source/WTF/ChangeLog	2021-03-03 20:54:26 UTC (rev 273832)
+++ trunk/Source/WTF/ChangeLog	2021-03-03 21:04:47 UTC (rev 273833)
@@ -1,3 +1,12 @@
+2021-03-03  Tim Horton  
+
+Modernize WebKit2 PDFKit softlinking
+https://bugs.webkit.org/show_bug.cgi?id=222643
+
+Reviewed by Alex Christensen.
+
+* wtf/PlatformHave.h:
+
 2021-03-03  Alex Christensen  
 
 Limit HashTable entry size to 500 bytes


Modified: trunk/Source/WTF/wtf/PlatformHave.h (273832 => 273833)

--- trunk/Source/WTF/wtf/PlatformHave.h	2021-03-03 20:54:26 UTC (rev 273832)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2021-03-03 21:04:47 UTC (rev 273833)
@@ -920,3 +920,7 @@
 #if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST)
 #define HAVE_NSURL_TITLE 1
 #endif
+
+#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(MACCATALYST)
+#define HAVE_PDFKIT 1
+#endif


Modified: trunk/Source/WebKit/ChangeLog (273832 => 273833)

--- trunk/Source/WebKit/ChangeLog	2021-03-03 20:54:26 UTC (rev 273832)
+++ trunk/Source/WebKit/ChangeLog	2021-03-03 21:04:47 UTC (rev 273833)
@@ -1,3 +1,45 @@
+2021-03-03  Tim Horton  
+
+Modernize WebKit2 PDFKit softlinking
+https://bugs.webkit.org/show_bug.cgi?id=222643
+
+Reviewed by Alex Christensen.
+
+WebKit2 has long had an unusual way of softlinking PDFKit, using NSBundle.
+It has caused much trouble in the past, because it means that running
+WebKit against a custom PDFKit requires either installing it into
+the system, or changing the hardcoded path.
+
+Instead of this, just use the normal softlinking macros that the rest
+of WebKit uses.
+
+* Shared/Cocoa/PDFKitSoftLink.h: Added.
+* Shared/Cocoa/PDFKitSoftLink.mm: Added.
+* Shared/mac/PDFKitImports.h: Removed.
+* Shared/mac/PDFKitImports.mm: Removed.
+* SourcesCocoa.txt:
+* UIProcess/mac/WKPrintingView.mm:
+(-[WKPrintingView _drawPDFDocument:page:atPoint:]):
+(-[WKPrintingView drawRect:]):
+* WebKit.xcodeproj/project.pbxproj:
+* WebProcess/Plugins/PDF/PDFPlugin.h:
+* WebProcess/Plugins/PDF/PDFPlugin.mm:
+(WebKit::PDFPlugin::PDFPlugin):
+(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel):
+(WebKit::PDFPlugin::thre

[webkit-changes] [273832] trunk/Source

[commit-queue]

Title: [273832] trunk/Source








Revision 273832
Author commit-qu...@webkit.org
Date 2021-03-03 12:54:26 -0800 (Wed, 03 Mar 2021)


Log Message
Limit HashTable entry size to 500 bytes
https://bugs.webkit.org/show_bug.cgi?id=222658

Patch by Alex Christensen  on 2021-03-03
Reviewed by Yusuke Suzuki.

Source/WebCore:

Moving large structures inside HashTables is slower than just moving a pointer.
There is a point at which it becomes more efficient to add a separate allocation
rather than have gigantic HashTables that use all that memory for each empty slot
and use all those read and write operations to move when rehashing.  I'm not sure
exactly where that point is, but I'm pretty sure it's less than 500 bytes.  This
introduces a limit and removes the two largest HashTables in WebKit, replacing their
values with std::unique_ptr to save memory and time.

* Modules/cache/DOMCacheEngine.h:
* platform/network/NetworkLoadInformation.h:

Source/WebKit:

* NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::getNetworkLoadInformationResponse):
(WebKit::NetworkConnectionToWebProcess::getNetworkLoadIntermediateInformation):
(WebKit::NetworkConnectionToWebProcess::takeNetworkLoadInformationMetrics):
(WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformation):
(WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics):
* NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::writeRecord):
(WebKit::CacheStorage::Caches::readRecord):
* NetworkProcess/cache/CacheStorageEngineCaches.h:

Source/WTF:

* wtf/HashTable.h:
(WTF::KeyTraits>::inlineLookup):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashTable.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h
trunk/Source/WebCore/platform/network/NetworkLoadInformation.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp
trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h




Diff

Modified: trunk/Source/WTF/ChangeLog (273831 => 273832)

--- trunk/Source/WTF/ChangeLog	2021-03-03 20:19:00 UTC (rev 273831)
+++ trunk/Source/WTF/ChangeLog	2021-03-03 20:54:26 UTC (rev 273832)
@@ -1,3 +1,13 @@
+2021-03-03  Alex Christensen  
+
+Limit HashTable entry size to 500 bytes
+https://bugs.webkit.org/show_bug.cgi?id=222658
+
+Reviewed by Yusuke Suzuki.
+
+* wtf/HashTable.h:
+(WTF::KeyTraits>::inlineLookup):
+
 2021-03-03  Youenn Fablet  
 
 WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set


Modified: trunk/Source/WTF/wtf/HashTable.h (273831 => 273832)

--- trunk/Source/WTF/wtf/HashTable.h	2021-03-03 20:19:00 UTC (rev 273831)
+++ trunk/Source/WTF/wtf/HashTable.h	2021-03-03 20:54:26 UTC (rev 273832)
@@ -665,6 +665,8 @@
 template
 ALWAYS_INLINE auto HashTable::inlineLookup(const T& key) -> ValueType*
 {
+static_assert(sizeof(Key) + sizeof(Value) < 500, "Your HashTable types are too big to efficiently move when rehashing.  Consider using std::unique_ptr instead");
+
 checkKey(key);
 
 unsigned k = 0;


Modified: trunk/Source/WebCore/ChangeLog (273831 => 273832)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 20:19:00 UTC (rev 273831)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 20:54:26 UTC (rev 273832)
@@ -1,3 +1,21 @@
+2021-03-03  Alex Christensen  
+
+Limit HashTable entry size to 500 bytes
+https://bugs.webkit.org/show_bug.cgi?id=222658
+
+Reviewed by Yusuke Suzuki.
+
+Moving large structures inside HashTables is slower than just moving a pointer.
+There is a point at which it becomes more efficient to add a separate allocation
+rather than have gigantic HashTables that use all that memory for each empty slot
+and use all those read and write operations to move when rehashing.  I'm not sure
+exactly where that point is, but I'm pretty sure it's less than 500 bytes.  This
+introduces a limit and removes the two largest HashTables in WebKit, replacing their
+values with std::unique_ptr to save memory and time.
+
+* Modules/cache/DOMCacheEngine.h:
+* platform/network/NetworkLoadInformation.h:
+
 2021-03-03  Megan Gardner  
 
 Preserve information about the origin of the app highlight request


Modified: trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h (273831 => 273832)

--- trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h	2021-03-03 20:19:00 UTC (rev 273831)
+++ trunk/Source/WebCore/Modules/cache/DOMCacheEngine.h	2021-03-03 20:54:26 UTC (rev 273832)
@@ -61,6 +61,7 @@
 WEBCORE_EXPORT ResponseBody copyResponseBody(const ResponseBody&);
 
 struct Record {
+WTF_MAKE_STRUCT_FAST_ALLOCATED;
 WEBCORE_EXPORT Record copy() const;
 
 uint64_t identifier;


Modified: trunk/Source/WebCore/platfor

[webkit-changes] [273830] branches/safari-611.1.21.1-branch

[rubent_22]

Title: [273830] branches/safari-611.1.21.1-branch








Revision 273830
Author rubent...@apple.com
Date 2021-03-03 12:18:56 -0800 (Wed, 03 Mar 2021)


Log Message
Cherry-pick r273699. rdar://problem/74992920

[Win] Fix build failure
https://bugs.webkit.org/show_bug.cgi?id=222576

Reviewed by Brent Fulgham.

It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.

* Source/cmake/OptionsAppleWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-611.1.21.1-branch/ChangeLog
branches/safari-611.1.21.1-branch/Source/cmake/OptionsAppleWin.cmake




Diff

Modified: branches/safari-611.1.21.1-branch/ChangeLog (273829 => 273830)

--- branches/safari-611.1.21.1-branch/ChangeLog	2021-03-03 19:42:23 UTC (rev 273829)
+++ branches/safari-611.1.21.1-branch/ChangeLog	2021-03-03 20:18:56 UTC (rev 273830)
@@ -1,3 +1,30 @@
+2021-03-03  Ruben Turcios  
+
+Cherry-pick r273699. rdar://problem/74992920
+
+[Win] Fix build failure
+https://bugs.webkit.org/show_bug.cgi?id=222576
+
+Reviewed by Brent Fulgham.
+
+It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.
+
+* Source/cmake/OptionsAppleWin.cmake:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-03-01  Per Arne  
+
+[Win] Fix build failure
+https://bugs.webkit.org/show_bug.cgi?id=222576
+
+Reviewed by Brent Fulgham.
+
+It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.
+
+* Source/cmake/OptionsAppleWin.cmake:
+
 2021-01-11  Xabier Rodriguez Calvar  
 
 [GStreamer] Add support to build with native audio and video


Modified: branches/safari-611.1.21.1-branch/Source/cmake/OptionsAppleWin.cmake (273829 => 273830)

--- branches/safari-611.1.21.1-branch/Source/cmake/OptionsAppleWin.cmake	2021-03-03 19:42:23 UTC (rev 273829)
+++ branches/safari-611.1.21.1-branch/Source/cmake/OptionsAppleWin.cmake	2021-03-03 20:18:56 UTC (rev 273830)
@@ -25,6 +25,7 @@
 include(OptionsWin)
 
 set(ENABLE_WEBCORE ON)
+set(ENABLE_WEBINSPECTORUI OFF)
 
 SET_AND_EXPOSE_TO_BUILD(USE_CF ON)
 SET_AND_EXPOSE_TO_BUILD(USE_CFURLCONNECTION ON)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273831] branches/safari-611.1.21.1-branch

[rubent_22]

Title: [273831] branches/safari-611.1.21.1-branch








Revision 273831
Author rubent...@apple.com
Date 2021-03-03 12:19:00 -0800 (Wed, 03 Mar 2021)


Log Message
Cherry-pick r273764. rdar://problem/74992878

The layout of SVGImage should force the layout for its clients
https://bugs.webkit.org/show_bug.cgi?id=221253


Reviewed by Simon Fraser.

Source/WebCore:

Unlike the bitmap image, the intrinsic size of SVGImage can only be known
after running its layout. Because SVGImage can be used by multiple clients,
CachedImage maintains an SVGImageCache which maps a client to an
SVGImageForContainer. SVGImageForContainer is just a wrapper of SVGImage
with the intrinsic size of the client. Because we may set an entry for
the renderer in SVGImageCache early before running a layout for SVGImage
and because the renderer intrinsic size depends on the intrinsic size of
SVGImage, SVGImageForContainer may have an empty intrinsic size.

So basically it is a race condition: knowing the intrinsic size of the
SVGImage client depends on the intrinsic size of SVGImage itself. And the
intrinsic size of SVGImageForContainer depends on the intrinsic size of
the client. This may lead to not rendering the clients because their sizes
are empty. To fix this issue we need to force calculateBackgroundImageGeometry()
once we finish the layout of the SVGImage which happens after receiving all
its data and calling RenderBox::imageChanged().

Test: fast/css/background-svg-image-loading.html

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::finishLoading):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):

LayoutTests:

* fast/css/background-svg-image-loading-expected.html: Added.
* fast/css/background-svg-image-loading.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-611.1.21.1-branch/LayoutTests/ChangeLog
branches/safari-611.1.21.1-branch/Source/WebCore/ChangeLog
branches/safari-611.1.21.1-branch/Source/WebCore/loader/cache/CachedImage.cpp
branches/safari-611.1.21.1-branch/Source/WebCore/rendering/RenderBox.cpp


Added Paths

branches/safari-611.1.21.1-branch/LayoutTests/fast/css/background-svg-image-loading-expected.html
branches/safari-611.1.21.1-branch/LayoutTests/fast/css/background-svg-image-loading.html




Diff

Modified: branches/safari-611.1.21.1-branch/LayoutTests/ChangeLog (273830 => 273831)

--- branches/safari-611.1.21.1-branch/LayoutTests/ChangeLog	2021-03-03 20:18:56 UTC (rev 273830)
+++ branches/safari-611.1.21.1-branch/LayoutTests/ChangeLog	2021-03-03 20:19:00 UTC (rev 273831)
@@ -1,3 +1,58 @@
+2021-03-03  Ruben Turcios  
+
+Cherry-pick r273764. rdar://problem/74992878
+
+The layout of SVGImage should force the layout for its clients
+https://bugs.webkit.org/show_bug.cgi?id=221253
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+Unlike the bitmap image, the intrinsic size of SVGImage can only be known
+after running its layout. Because SVGImage can be used by multiple clients,
+CachedImage maintains an SVGImageCache which maps a client to an
+SVGImageForContainer. SVGImageForContainer is just a wrapper of SVGImage
+with the intrinsic size of the client. Because we may set an entry for
+the renderer in SVGImageCache early before running a layout for SVGImage
+and because the renderer intrinsic size depends on the intrinsic size of
+SVGImage, SVGImageForContainer may have an empty intrinsic size.
+
+So basically it is a race condition: knowing the intrinsic size of the
+SVGImage client depends on the intrinsic size of SVGImage itself. And the
+intrinsic size of SVGImageForContainer depends on the intrinsic size of
+the client. This may lead to not rendering the clients because their sizes
+are empty. To fix this issue we need to force calculateBackgroundImageGeometry()
+once we finish the layout of the SVGImage which happens after receiving all
+its data and calling RenderBox::imageChanged().
+
+Test: fast/css/background-svg-image-loading.html
+
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::finishLoading):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::repaintLayerRectsForImage):
+
+LayoutTests:
+
+* fast/css/background-svg-image-loading-expected.html: Added.
+* fast/css/background-svg-image-loading.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-03-02  Said Abou-Hallawa  
+
+The layout of SVGImage should force the layout for its clients
+https://bugs.webkit.org/show_bug.cgi?id=221253
+
+
+Reviewed by Simon Fraser.
+
+* fast/css/background-svg-image-loadin

[webkit-changes] [273829] trunk/LayoutTests

[tsavell]

Title: [273829] trunk/LayoutTests








Revision 273829
Author tsav...@apple.com
Date 2021-03-03 11:42:23 -0800 (Wed, 03 Mar 2021)


Log Message
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html fails for mac wk1 debug
https://bugs.webkit.org/show_bug.cgi?id=221819

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (273828 => 273829)

--- trunk/LayoutTests/ChangeLog	2021-03-03 19:10:45 UTC (rev 273828)
+++ trunk/LayoutTests/ChangeLog	2021-03-03 19:42:23 UTC (rev 273829)
@@ -1,3 +1,12 @@
+2021-03-03  Truitt Savell  
+
+imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html fails for mac wk1 debug
+https://bugs.webkit.org/show_bug.cgi?id=221819
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-03-03  Chris Gambrell  
 
 [LayoutTests] Convert http/tests/dom convert PHP to Python


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (273828 => 273829)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-03-03 19:10:45 UTC (rev 273828)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-03-03 19:42:23 UTC (rev 273829)
@@ -1255,3 +1255,5 @@
 webkit.org/b/221559 [ BigSur ] svg/canvas/canvas-global-alpha-svg.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/222493 [ BigSur ] platform/mac-bigsur/media/media-source/media-source-webm-vp8-malformed-header.html [ Skip ]
+
+webkit.org/b/221819 [ Debug ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273828] trunk/LayoutTests

[cgambrell]

Title: [273828] trunk/LayoutTests








Revision 273828
Author cgambr...@apple.com
Date 2021-03-03 11:10:45 -0800 (Wed, 03 Mar 2021)


Log Message
[LayoutTests] Convert http/tests/dom convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=222656


Reviewed by Jonathan Bedard.

* http/tests/dom/document-contentType-xhr.html:
* http/tests/dom/document-contentType.html:
* http/tests/dom/resources/send-mime-type.php: Removed.
* http/tests/dom/resources/send-mime-type.py: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/dom/document-contentType-xhr.html
trunk/LayoutTests/http/tests/dom/document-contentType.html


Added Paths

trunk/LayoutTests/http/tests/dom/resources/send-mime-type.py


Removed Paths

trunk/LayoutTests/http/tests/dom/resources/send-mime-type.php




Diff

Modified: trunk/LayoutTests/ChangeLog (273827 => 273828)

--- trunk/LayoutTests/ChangeLog	2021-03-03 19:08:56 UTC (rev 273827)
+++ trunk/LayoutTests/ChangeLog	2021-03-03 19:10:45 UTC (rev 273828)
@@ -1,3 +1,16 @@
+2021-03-03  Chris Gambrell  
+
+[LayoutTests] Convert http/tests/dom convert PHP to Python
+https://bugs.webkit.org/show_bug.cgi?id=222656
+
+
+Reviewed by Jonathan Bedard.
+
+* http/tests/dom/document-contentType-xhr.html:
+* http/tests/dom/document-contentType.html:
+* http/tests/dom/resources/send-mime-type.php: Removed.
+* http/tests/dom/resources/send-mime-type.py: Added.
+
 2021-03-03  Sergio Villar Senin  
 
 [css-flexbox] Import latest WPT tests


Modified: trunk/LayoutTests/http/tests/dom/document-contentType-xhr.html (273827 => 273828)

--- trunk/LayoutTests/http/tests/dom/document-contentType-xhr.html	2021-03-03 19:08:56 UTC (rev 273827)
+++ trunk/LayoutTests/http/tests/dom/document-contentType-xhr.html	2021-03-03 19:10:45 UTC (rev 273828)
@@ -10,12 +10,12 @@
 }
 
 var toTest = [
-{ mimeType: "text/html", uri: "resources/send-mime-type.php?m=text/html" },
-{ mimeType: "text/xml", uri: "resources/send-mime-type.php?m=text/xml" },
-{ mimeType: "application/xml", uri: "resources/send-mime-type.php?m=application/xml" },
-{ mimeType: "text/html", uri: "resources/send-mime-type.php?m=text/html;charset=utf-8" },
-{ mimeType: "text/xml", uri: "resources/send-mime-type.php?m=text/xml;charset=utf-8" },
-{ mimeType: "application/xml", uri: "resources/send-mime-type.php?m=application/xml;charset=utf-8" }
+{ mimeType: "text/html", uri: "resources/send-mime-type.py?m=text/html" },
+{ mimeType: "text/xml", uri: "resources/send-mime-type.py?m=text/xml" },
+{ mimeType: "application/xml", uri: "resources/send-mime-type.py?m=application/xml" },
+{ mimeType: "text/html", uri: "resources/send-mime-type.py?m=text/html;charset=utf-8" },
+{ mimeType: "text/xml", uri: "resources/send-mime-type.py?m=text/xml;charset=utf-8" },
+{ mimeType: "application/xml", uri: "resources/send-mime-type.py?m=application/xml;charset=utf-8" }
 ];
 
 function onrequestload(expectedMimeType) {


Modified: trunk/LayoutTests/http/tests/dom/document-contentType.html (273827 => 273828)

--- trunk/LayoutTests/http/tests/dom/document-contentType.html	2021-03-03 19:08:56 UTC (rev 273827)
+++ trunk/LayoutTests/http/tests/dom/document-contentType.html	2021-03-03 19:10:45 UTC (rev 273828)
@@ -7,9 +7,9 @@
   -+ 
  

Deleted: trunk/LayoutTests/http/tests/dom/resources/send-mime-type.php (273827 => 273828)

--- trunk/LayoutTests/http/tests/dom/resources/send-mime-type.php	2021-03-03 19:08:56 UTC (rev 273827)
+++ trunk/LayoutTests/http/tests/dom/resources/send-mime-type.php	2021-03-03 19:10:45 UTC (rev 273828)
@@ -1,6 +0,0 @@
-Hello"
-?>
\ No newline at end of file


Added: trunk/LayoutTests/http/tests/dom/resources/send-mime-type.py (0 => 273828)

--- trunk/LayoutTests/http/tests/dom/resources/send-mime-type.py	(rev 0)
+++ trunk/LayoutTests/http/tests/dom/resources/send-mime-type.py	2021-03-03 19:10:45 UTC (rev 273828)
@@ -0,0 +1,13 @@
+#!/usr/bin/env python3
+
+import os
+import sys
+from urllib.parse import parse_qs
+
+content_type = parse_qs(os.environ.get('QUERY_STRING', ''), keep_blank_values=True).get('m', ['text/html'])[0]
+
+sys.stdout.write(
+'status: 200\r\n'
+'Content-Type: {}\r\n\r\n'
+'Hello'.format(content_type)
+)
\ No newline at end of file
Property changes on: trunk/LayoutTests/http/tests/dom/resources/send-mime-type.py
___


Added: svn:executable
+*
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273827] branches/safari-611.1.21.0-branch/Source

[rubent_22]

Title: [273827] branches/safari-611.1.21.0-branch/Source








Revision 273827
Author rubent...@apple.com
Date 2021-03-03 11:08:56 -0800 (Wed, 03 Mar 2021)


Log Message
Versioning.

WebKit-7611.1.21.0.3

Modified Paths

branches/safari-611.1.21.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.1.21.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.1.21.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.1.21.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.1.21.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.1.21.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.1.21.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.1.21.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.1.21.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273826 => 273827)

--- branches/safari-611.1.21.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-03-03 18:54:58 UTC (rev 273826)
+++ branches/safari-611.1.21.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-03-03 19:08:56 UTC (rev 273827)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273826 => 273827)

--- branches/safari-611.1.21.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-03-03 18:54:58 UTC (rev 273826)
+++ branches/safari-611.1.21.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-03-03 19:08:56 UTC (rev 273827)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273826 => 273827)

--- branches/safari-611.1.21.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-03-03 18:54:58 UTC (rev 273826)
+++ branches/safari-611.1.21.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-03-03 19:08:56 UTC (rev 273827)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.0-branch/Source/WebCore/Configurations/Version.xcconfig (273826 => 273827)

--- branches/safari-611.1.21.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-03-03 18:54:58 UTC (rev 273826)
+++ branches/safari-611.1.21.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-03-03 19:08:56 UTC (rev 273827)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273826 => 273827)

--- branches/safari-611.1.21.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-03-03 18:54:58 UTC (rev 273826)
+++ branches/safari-611.1.21.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-03-03 19:08:56 UTC (rev 273827)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.21.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (273826 => 273827)

--- branches/safari-611.1.21.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-03-03 18:54:58 UTC (rev 273826)
+++ branches/safari-611.1.21.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-03-03 19:08:56 UTC (rev 273827)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(T

[webkit-changes] [273826] trunk/Source

[megan_gardner]

Title: [273826] trunk/Source








Revision 273826
Author megan_gard...@apple.com
Date 2021-03-03 10:54:58 -0800 (Wed, 03 Mar 2021)


Log Message
Preserve information about the origin of the app highlight request
https://bugs.webkit.org/show_bug.cgi?id=23

Reviewed by Wenson Hsieh.

Source/WebCore:

* Modules/highlight/AppHighlight.h:
(WebCore::AppHighlight::encode const):
(WebCore::AppHighlight::decode):
* Modules/highlight/AppHighlightStorage.cpp:
(WebCore::AppHighlightStorage::storeAppHighlight):
* Modules/highlight/AppHighlightStorage.h:
* loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::storeAppHighlight const):
* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::storeAppHighlight const):
* page/Chrome.h:
* page/ChromeClient.h:

Source/WebKit:

* Scripts/webkit/messages.py:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _storeAppHighlight:]):
(-[WKWebView _addAppHighlight]):
* UIProcess/API/Cocoa/_WKAppHighlightDelegate.h:
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::createAppHighlightInSelectedRange):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView createHighlightInCurrentGroupWithRange:]):
(-[WKContentView createHighlightInNewGroupWithRange:]):
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::storeAppHighlight const):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createAppHighlightInSelectedRange):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::highlightIsNewGroup const):
(WebKit::WebPage::highlightRequestOriginatedInApp const):
* WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::storeAppHighlight const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/highlight/AppHighlight.h
trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.cpp
trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.h
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/page/Chrome.cpp
trunk/Source/WebCore/page/Chrome.h
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAppHighlightDelegate.h
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (273825 => 273826)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 18:47:07 UTC (rev 273825)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 18:54:58 UTC (rev 273826)
@@ -1,3 +1,24 @@
+2021-03-03  Megan Gardner  
+
+Preserve information about the origin of the app highlight request
+https://bugs.webkit.org/show_bug.cgi?id=23
+
+Reviewed by Wenson Hsieh.
+
+* Modules/highlight/AppHighlight.h:
+(WebCore::AppHighlight::encode const):
+(WebCore::AppHighlight::decode):
+* Modules/highlight/AppHighlightStorage.cpp:
+(WebCore::AppHighlightStorage::storeAppHighlight):
+* Modules/highlight/AppHighlightStorage.h:
+* loader/EmptyClients.cpp:
+(WebCore::EmptyChromeClient::storeAppHighlight const):
+* loader/EmptyClients.h:
+* page/Chrome.cpp:
+(WebCore::Chrome::storeAppHighlight const):
+* page/Chrome.h:
+* page/ChromeClient.h:
+
 2021-03-03  Ryan Haddad  
 
 Unreviewed, reverting r273809.


Modified: trunk/Source/WebCore/Modules/highlight/AppHighlight.h (273825 => 273826)

--- trunk/Source/WebCore/Modules/highlight/AppHighlight.h	2021-03-03 18:47:07 UTC (rev 273825)
+++ trunk/Source/WebCore/Modules/highlight/AppHighlight.h	2021-03-03 18:54:58 UTC (rev 273826)
@@ -35,10 +35,13 @@
 
 enum class CreateNewGroupForHighlight : bool { No, Yes };
 
+enum class HighlightRequestOriginatedInApp : bool { No, Yes };
+
 struct AppHighlight {
 Ref highlight;
 Optional text;
 CreateNewGroupForHighlight isNewGroup;
+HighlightRequestOriginatedInApp requestOriginatedInApp;
 
 template void encode(Encoder&) const;
 template

[webkit-changes] [273825] trunk/LayoutTests

[svillar]

Title: [273825] trunk/LayoutTests








Revision 273825
Author svil...@igalia.com
Date 2021-03-03 10:47:07 -0800 (Wed, 03 Mar 2021)


Log Message
[css-flexbox] Import latest WPT tests
https://bugs.webkit.org/show_bug.cgi?id=222651

Reviewed by Rob Buis.

LayoutTests/imported/w3c:

Synced flex tests to 5b5efcee.

* resources/resource-files.json:
* web-platform-tests/css/css-flexbox/canvas-contain-size-expected.html: Added.
* web-platform-tests/css/css-flexbox/canvas-contain-size.html: Added.
* web-platform-tests/css/css-flexbox/css-flexbox-column-expected.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-reverse-expected.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-reverse-wrap-expected.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-reverse-wrap-reverse-expected.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-reverse-wrap-reverse.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-reverse-wrap.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-reverse.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-wrap-expected.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-wrap-reverse-expected.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-wrap-reverse.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column-wrap.html: Removed.
* web-platform-tests/css/css-flexbox/css-flexbox-column.html: Removed.
* web-platform-tests/css/css-flexbox/flexbox-basic-canvas-vert-001-expected.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-canvas-vert-001.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-canvas-vert-001v-expected.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-canvas-vert-001v.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-iframe-vert-001-expected.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-iframe-vert-001.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-img-vert-001-expected.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-img-vert-001.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-textarea-vert-001-expected.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-textarea-vert-001.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-video-vert-001-expected.xhtml:
* web-platform-tests/css/css-flexbox/flexbox-basic-video-vert-001.xhtml:
* web-platform-tests/css/css-flexbox/frameset-crash.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-1-expected.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-1.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-2-expected.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-2.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-1-expected.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-1.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2-expected.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-narrow-content-2-expected.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-narrow-content-2.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-specified-height-expected.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-specified-height.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-specified-width.html:
* web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-2-expected.xht: Added.
* web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-2.html: Added.
* web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-3-expected.xht: Added.
* web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-3.html: Added.
* web-platform-tests/css/css-flexbox/table-item-flex-percentage-min-width-expected.html: Added.
* web-platform-tests/css/css-flexbox/table-item-flex-percentage-min-width.html: Added.
* web-platform-tests/css/css-flexbox/w3c-import.log:

LayoutTests:

Imported latest changes in the test suite.

* TestExpectations:
* imported/w3c/web-platform-tests/css/css-flexbox/frameset-crash-expected.txt: Added.
* platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/frameset-crash-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/resource-files.json
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-basic-canvas-vert-001-expected.xhtml
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-basic-canvas-vert-001.xhtml
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-basic-canv

[webkit-changes] [273824] trunk/Source/ThirdParty/ANGLE/ChangeLog

[dino]

Title: [273824] trunk/Source/ThirdParty/ANGLE/ChangeLog








Revision 273824
Author d...@apple.com
Date 2021-03-03 10:37:00 -0800 (Wed, 03 Mar 2021)


Log Message
Add bug link to previous commit

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (273823 => 273824)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-03-03 18:33:51 UTC (rev 273823)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-03-03 18:37:00 UTC (rev 273824)
@@ -1,6 +1,7 @@
 2021-03-03  Kyle Piddington  
 
 Support Depth24_Stencil8 simulation in the MTLSimulator
+https://bugs.webkit.org/show_bug.cgi?id=222624
 
 Reviewed by Dean Jackson.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273823] trunk/Source/ThirdParty/ANGLE

[dino]

Title: [273823] trunk/Source/ThirdParty/ANGLE








Revision 273823
Author d...@apple.com
Date 2021-03-03 10:33:51 -0800 (Wed, 03 Mar 2021)


Log Message
Support Depth24_Stencil8 simulation in the MTLSimulator

Patch by Kyle Piddington  on 2021-03-03
Reviewed by Dean Jackson.

Fixes the following tests:
fast/canvas/webgl/context-creation-attributes.html
fast/canvas/webgl/webgl-depth-texture.html
webgl/1.0.3/conformance/misc/webgl-specific.html
webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html

* src/libANGLE/renderer/metal/mtl_format_map.json:
* src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:
(rx::mtl::Format::init):

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_map.json
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (273822 => 273823)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-03-03 18:11:37 UTC (rev 273822)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-03-03 18:33:51 UTC (rev 273823)
@@ -1,3 +1,19 @@
+2021-03-03  Kyle Piddington  
+
+Support Depth24_Stencil8 simulation in the MTLSimulator
+
+Reviewed by Dean Jackson.
+
+Fixes the following tests:
+fast/canvas/webgl/context-creation-attributes.html
+fast/canvas/webgl/webgl-depth-texture.html
+webgl/1.0.3/conformance/misc/webgl-specific.html
+webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
+
+* src/libANGLE/renderer/metal/mtl_format_map.json:
+* src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:
+(rx::mtl::Format::init):
+
 2021-02-26  Kyle Piddington  
 
 Support  fast/canvas/webgl/copyBufferSubData.html, fix bugs in fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator


Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_map.json (273822 => 273823)

--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_map.json	2021-03-03 18:11:37 UTC (rev 273822)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_map.json	2021-03-03 18:33:51 UTC (rev 273823)
@@ -213,7 +213,8 @@
  "override_sim": {
 "R5G6B5_UNORM": "R8G8B8A8_UNORM",
 "R5G5B5A1_UNORM": "R8G8B8A8_UNORM",
-"R4G4B4A4_UNORM": "R8G8B8A8_UNORM"
+"R4G4B4A4_UNORM": "R8G8B8A8_UNORM",
+"D24_UNORM_S8_UINT": "D32_FLOAT_S8X24_UINT"
 },
 "override_mac": {
 "R5G6B5_UNORM": "R8G8B8A8_UNORM",


Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm (273822 => 273823)

--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm	2021-03-03 18:11:37 UTC (rev 273822)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm	2021-03-03 18:33:51 UTC (rev 273823)
@@ -37,7 +37,7 @@
 switch (this->intendedFormatId)
 {
 case angle::FormatID::A8_UNORM:
-
+
 this->metalFormat = MTLPixelFormatA8Unorm;
 this->actualFormatId = angle::FormatID::A8_UNORM;
 this->initFunction = nullptr;
@@ -47,7 +47,7 @@
 
 #if TARGET_OS_OSX || TARGET_OS_MACCATALYST
 case angle::FormatID::B8G8R8A8_UNORM:
-
+
 if (metalDevice.depth24Stencil8PixelFormatSupported &&
!display->getFeatures().forceD24S8AsUnsupported.enabled)
 {
@@ -67,7 +67,7 @@
 
 #else  // TARGET_OS_OSX || TARGET_OS_MACCATALYST
 case angle::FormatID::B8G8R8A8_UNORM:
-
+
 this->metalFormat = MTLPixelFormatBGRA8Unorm;
 this->actualFormatId = angle::FormatID::B8G8R8A8_UNORM;
 this->initFunction = nullptr;
@@ -77,7 +77,7 @@
 
 #endif  // TARGET_OS_OSX || TARGET_OS_MACCATALYST
 case angle::FormatID::B8G8R8A8_UNORM_SRGB:
-
+
 this->metalFormat = MTLPixelFormatBGRA8Unorm_sRGB;
 this->actualFormatId = angle::FormatID::B8G8R8A8_UNORM_SRGB;
 this->initFunction = nullptr;
@@ -86,7 +86,7 @@
 break;
 
 case angle::FormatID::D16_UNORM:
-
+
 this->metalFormat = MTLPixelFormatDepth16Unorm;
 this->actualFormatId = angle::FormatID::D16_UNORM;
 this->initFunction = nullptr;
@@ -95,7 +95,7 @@
 break;
 
 case angle::FormatID::D32_FLOAT:
-
+
 this->metalFormat = MTLPixelFormatDepth32Float;
 this->actualFormatId = angle::FormatID::D32_FLOAT;
 this->initFunction = nullptr;
@@ -104,7 +104,7 @@
 break;
 
 case angle::FormatID::D32_FLOAT_S8X24_UINT:
-
+
 this->metalFormat = MTLPixelFormatDepth32Float_Stencil8;
 this->actualFormatId = angle::FormatID::D32_FLOAT_S8X24_UINT;
 

[webkit-changes] [273822] trunk/Source/WebCore

[ryanhaddad]

Title: [273822] trunk/Source/WebCore








Revision 273822
Author ryanhad...@apple.com
Date 2021-03-03 10:11:37 -0800 (Wed, 03 Mar 2021)


Log Message
Unreviewed, reverting r273809.

Caused assertion failure on debug WK2 bots

Reverted changeset:

"Crash in removeSymbolElementsFromSubtree()"
https://bugs.webkit.org/show_bug.cgi?id=222397
https://commits.webkit.org/r273809

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (273821 => 273822)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 17:59:27 UTC (rev 273821)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 18:11:37 UTC (rev 273822)
@@ -1,3 +1,15 @@
+2021-03-03  Ryan Haddad  
+
+Unreviewed, reverting r273809.
+
+Caused assertion failure on debug WK2 bots
+
+Reverted changeset:
+
+"Crash in removeSymbolElementsFromSubtree()"
+https://bugs.webkit.org/show_bug.cgi?id=222397
+https://commits.webkit.org/r273809
+
 2021-03-03  Patrick Angle  
 
 REGRESSION (r266288): Web Inspector: ::marker shows on every element now


Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (273821 => 273822)

--- trunk/Source/WebCore/svg/SVGUseElement.cpp	2021-03-03 17:59:27 UTC (rev 273821)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp	2021-03-03 18:11:37 UTC (rev 273822)
@@ -224,9 +224,6 @@
 
 if (!isConnected())
 return;
-
-ScriptDisallowedScope::InMainThread scriptDisallowedScope;
-
 document().removeSVGUseElement(*this);
 
 String targetID;
@@ -353,14 +350,8 @@
 // into  elements, which is correct for symbol elements directly referenced by use elements,
 // but incorrect for ones that just happen to be in a subtree.
 Vector symbolElements;
-for (auto it = descendantsOfType(subtree).begin(); it; ) {
-if (is(*it)) {
-symbolElements.append(&*it);
-it.traverseNextSkippingChildren();
-continue;
-}
-++it;
-}
+for (auto& descendant : descendantsOfType(subtree))
+symbolElements.append(&descendant);
 disassociateAndRemoveClones(symbolElements);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273821] trunk

[pangle]

Title: [273821] trunk








Revision 273821
Author pan...@apple.com
Date 2021-03-03 09:59:27 -0800 (Wed, 03 Mar 2021)


Log Message
REGRESSION (r266288): Web Inspector: ::marker shows on every element now
https://bugs.webkit.org/show_bug.cgi?id=222384

Reviewed by Devin Rousso.

Source/WebCore:

Test: inspector/css/getMatchedStylesForNodeMarkerPseudoId.html

Add filtering of the `::marker` CSS rule for elements that are not list items, as they do no apply to the
element.

* inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
- Added filtering for `*::marker` rules on non-`display:list-item` elements.
(WebCore::InspectorCSSAgent::buildObjectForRule):
- Drive-by refactoring to reduce code duplication.

LayoutTests:

Added test for the filtering of `*::marker` selector from the rule results of `CSS.getMatchedStyleForNode` on
elements that don't support `::marker`.

* inspector/css/getMatchedStylesForNode-expected.txt:
- Updated expectations to account for the abscence of the `::marker` rule on non-list elements.
* inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt: Added.
* inspector/css/getMatchedStylesForNodeMarkerPseudoId.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp


Added Paths

trunk/LayoutTests/inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt
trunk/LayoutTests/inspector/css/getMatchedStylesForNodeMarkerPseudoId.html




Diff

Modified: trunk/LayoutTests/ChangeLog (273820 => 273821)

--- trunk/LayoutTests/ChangeLog	2021-03-03 17:51:55 UTC (rev 273820)
+++ trunk/LayoutTests/ChangeLog	2021-03-03 17:59:27 UTC (rev 273821)
@@ -1,3 +1,18 @@
+2021-03-03  Patrick Angle  
+
+REGRESSION (r266288): Web Inspector: ::marker shows on every element now
+https://bugs.webkit.org/show_bug.cgi?id=222384
+
+Reviewed by Devin Rousso.
+
+Added test for the filtering of `*::marker` selector from the rule results of `CSS.getMatchedStyleForNode` on
+elements that don't support `::marker`.
+
+* inspector/css/getMatchedStylesForNode-expected.txt:
+- Updated expectations to account for the abscence of the `::marker` rule on non-list elements.
+* inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt: Added.
+* inspector/css/getMatchedStylesForNodeMarkerPseudoId.html: Added.
+
 2021-03-03  Kate Cheney  
 
 Report the correct document uri in the case of a ContentSecurityPolicyClient


Modified: trunk/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt (273820 => 273821)

--- trunk/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt	2021-03-03 17:51:55 UTC (rev 273820)
+++ trunk/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt	2021-03-03 17:59:27 UTC (rev 273821)
@@ -379,54 +379,6 @@
 ]
   },
   {
-"pseudoId": "marker",
-"matches": [
-  {
-"rule": {
-  "selectorList": {
-"selectors": [
-  {
-"text": "div::marker",
-"specificity": [
-  0,
-  0,
-  2
-]
-  }
-],
-"text": "div::marker",
-"range": ""
-  },
-  "sourceLine": "",
-  "origin": "author",
-  "style": {
-"cssProperties": [
-  {
-"name": "z-index",
-"value": "3",
-"text": "z-index: 3;",
-"range": "",
-"implicit": false,
-"status": "active"
-  }
-],
-"shorthandEntries": [],
-"styleId": "",
-"width": "",
-"height": "",
-"range": "",
-"cssText": " z-index: 3; "
-  },
-  "sourceURL": "",
-  "ruleId": ""
-},
-"matchingSelectors": [
-  0
-]
-  }
-]
-  },
-  {
 "pseudoId": "before",
 "matches": [
   {


Added: trunk/LayoutTests/inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt (0 => 273821)

--- trunk/LayoutTests/inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/css/getMatchedStylesForNodeMarkerPseudoId-expected.txt	2021-03-03 17:59:27 UTC (rev 273821)
@@ -0,0 +1,14 @@
+Tests for the CSS.getMatchedStyleForNode command and the `::marker` CSS rule selector.
+
+
+== Running test suite: CSS.getMatchedStyleForNode.MarkerPseudoId
+-- Running test case: CSS.getMatchedStyleForNode.MarkerPseudoId.ListItem
+PASS: Expected exactly 2 rules for selector `*::marker`.
+
+-- Running test case: CSS.getMatchedStyleForNode.MarkerPseudoId.NonListItem
+PASS: Expected no rules entry for selector `*::marker`.
+
+-- Running test case: 

[webkit-changes] [273820] trunk

[katherine_cheney]

Title: [273820] trunk








Revision 273820
Author katherine_che...@apple.com
Date 2021-03-03 09:51:55 -0800 (Wed, 03 Mar 2021)


Log Message
Report the correct document uri in the case of a ContentSecurityPolicyClient
https://bugs.webkit.org/show_bug.cgi?id=222489


Reviewed by Brent Fulgham.

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect.html
   http/tests/security/contentSecurityPolicy/report-document-uri-blob.html

Previously we were setting the document URI to be the blocked URI in
the case where we were using a ContentSecurityPolicyClient and didn't
have access to the document URL. This patch passes the document URL
to the network process when loading a resource so we can properly set
the document URI in this case.

* page/csp/ContentSecurityPolicy.cpp:
(WebCore::shouldReportProtocolOnly):
(WebCore::ContentSecurityPolicy::deprecatedURLForReporting const):
(WebCore::ContentSecurityPolicy::reportViolation const):
Follow spec guidelines https://www.w3.org/TR/CSP2/#violation-reports
and set the document URI to be the URI's scheme if it is a globally
unique identifier.

In the case where we are using a client and don't have the document
URL, we should at least strip the blocked URL before reporting to align
with the spec.

* page/csp/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::setDocumentURL):

Source/WebKit:

Pass the document URL from the Network Process when we schedule a load
in case we need to report a CSP violation in NetworkLoadChecker.

* NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::contentSecurityPolicy):
The regular toString() method sets file:// URLs to null. We should use
toRawString() so we can report the scheme if the source origin is a
local file, as per the W3C spec.

* NetworkProcess/NetworkLoadChecker.h:
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/NetworkResourceLoader.cpp:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):

Tools:

Rename OverrideContentSecurityPolicy.mm to ContentSecurityPolicy.mm
so we can use it for more general purpose CSP testing.

Add a test for document-uri reporting for file:, data: and about: protocols.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicy.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/OverrideContentSecurityPolicy.mm.
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/csp-document-uri-report.html: Added.

LayoutTests:

Layout test coverage for redirects using a ContentSecurityPolicyClient
and blob files.

* http/tests/security/contentSecurityPolicy/report-document-uri-blob-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/report-document-uri-blob.html: Added.
* http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect.html: Added.
* platform/mac-wk1/http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect-expected.txt: Added.
* platform/win/http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect-expected.txt: Added.
* platform/win/TestExpectations:
Blob URLs timeout on win.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp
trunk/Source/WebCore/page/csp/ContentSecurityPolicy.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/PingLoad.cpp
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/LayoutTests/http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/report-document-uri-blob-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/report-document-uri-blob.html
trunk/LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/report-document-uri-after-blocked-redirect-expected.txt
trunk/LayoutTests/platform/win/http/tests/security/contentSecu

[webkit-changes] [273818] trunk/LayoutTests

[youenn]

Title: [273818] trunk/LayoutTests








Revision 273818
Author you...@apple.com
Date 2021-03-03 09:11:34 -0800 (Wed, 03 Mar 2021)


Log Message
[GPUP] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html times out with GPU Process enabled
https://bugs.webkit.org/show_bug.cgi?id=222505


Unreviewed.


* gpu-process/TestExpectations:
Test is no longer timing out on GPUProcess bot.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (273817 => 273818)

--- trunk/LayoutTests/ChangeLog	2021-03-03 16:55:05 UTC (rev 273817)
+++ trunk/LayoutTests/ChangeLog	2021-03-03 17:11:34 UTC (rev 273818)
@@ -1,3 +1,14 @@
+2021-03-03  Youenn Fablet  
+
+[GPUP] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html times out with GPU Process enabled
+https://bugs.webkit.org/show_bug.cgi?id=222505
+
+
+Unreviewed.
+
+* gpu-process/TestExpectations:
+Test is no longer timing out on GPUProcess bot.
+
 2021-03-02  Manuel Rego Casasnovas  
 
 [selectors] :focus-visible implementation


Modified: trunk/LayoutTests/gpu-process/TestExpectations (273817 => 273818)

--- trunk/LayoutTests/gpu-process/TestExpectations	2021-03-03 16:55:05 UTC (rev 273817)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2021-03-03 17:11:34 UTC (rev 273818)
@@ -52,5 +52,3 @@
 webgl/max-active-contexts-gc.html [ Failure ]
 webgl/max-active-contexts-oldest-context-lost.html [ Failure ]
 webgl/max-active-contexts-webglcontextlost-prevent-default.html [ Timeout ]
-
-imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html [ Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273817] trunk

[youenn]

Title: [273817] trunk








Revision 273817
Author you...@apple.com
Date 2021-03-03 08:55:05 -0800 (Wed, 03 Mar 2021)


Log Message
WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set
https://bugs.webkit.org/show_bug.cgi?id=222589


Reviewed by Geoffrey Garen.

Source/WebCore:

Use the new flag to allow reuse of JSDOMWindow objects even though they are created at a time where its SecurityOrigin is not set yet.
This allows keeping WebKitLegacy existing functionality.

Covered by API test.

* bindings/js/JSWindowProxy.cpp:
(WebCore::JSWindowProxy::setWindow):

Source/WTF:

* Scripts/Preferences/WebPreferencesInternal.yaml:
Introduce a flag, on for WebKit and off for WebKitLegacy.

Tools:

* TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWindowProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (273816 => 273817)

--- trunk/Source/WTF/ChangeLog	2021-03-03 16:37:24 UTC (rev 273816)
+++ trunk/Source/WTF/ChangeLog	2021-03-03 16:55:05 UTC (rev 273817)
@@ -1,3 +1,14 @@
+2021-03-03  Youenn Fablet  
+
+WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set
+https://bugs.webkit.org/show_bug.cgi?id=222589
+
+
+Reviewed by Geoffrey Garen.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+Introduce a flag, on for WebKit and off for WebKitLegacy.
+
 2021-03-02  Simon Fraser  
 
 Rename ForcePageRenderingUpdatesAt60FPSEnabled preference to PreferPageRenderingUpdatesNear60FPSEnabled


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (273816 => 273817)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2021-03-03 16:37:24 UTC (rev 273816)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2021-03-03 16:55:05 UTC (rev 273817)
@@ -885,6 +885,18 @@
 WebKit:
   default: true
 
+WindowObjectAlwaysInitializedWithSecurityOriginEnabled:
+  type: bool
+  humanReadableName: "Ensure Window object is initialized with a security origin"
+  humanReadableDescription: "Ensure Window object is initialized with a security origin"
+  defaultValue:
+WebKitLegacy:
+  default: false
+WebKit:
+  default: true
+WebCore:
+  default: true
+
 ZoomOnDoubleTapWhenRoot:
   type: bool
   condition: PLATFORM(IOS_FAMILY)


Modified: trunk/Source/WebCore/ChangeLog (273816 => 273817)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 16:37:24 UTC (rev 273816)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 16:55:05 UTC (rev 273817)
@@ -1,3 +1,19 @@
+2021-03-03  Youenn Fablet  
+
+WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set
+https://bugs.webkit.org/show_bug.cgi?id=222589
+
+
+Reviewed by Geoffrey Garen.
+
+Use the new flag to allow reuse of JSDOMWindow objects even though they are created at a time where its SecurityOrigin is not set yet.
+This allows keeping WebKitLegacy existing functionality.
+
+Covered by API test.
+
+* bindings/js/JSWindowProxy.cpp:
+(WebCore::JSWindowProxy::setWindow):
+
 2021-03-03  Zalan Bujtas  
 
 [LFC][IFC] Enable simplified vertical alignment for empty inline boxes


Modified: trunk/Source/WebCore/bindings/js/JSWindowProxy.cpp (273816 => 273817)

--- trunk/Source/WebCore/bindings/js/JSWindowProxy.cpp	2021-03-03 16:37:24 UTC (rev 273816)
+++ trunk/Source/WebCore/bindings/js/JSWindowProxy.cpp	2021-03-03 16:55:05 UTC (rev 273817)
@@ -106,7 +106,7 @@
 auto& localWindow = downcast(domWindow);
 auto& windowStructure = *JSDOMWindow::createStructure(vm, nullptr, prototype);
 window = JSDOMWindow::create(vm, &windowStructure, localWindow, this);
-if (!localWindow.document()->haveInitializedSecurityOrigin())
+if (!localWindow.document()->haveInitializedSecurityOrigin() && localWindow.document()->settings().windowObjectAlwaysInitializedWithSecurityOriginEnabled())
 localWindow.setAsWrappedWithoutInitializedSecurityOrigin();
 }
 


Modified: trunk/Tools/ChangeLog (273816 => 273817)

--- trunk/Tools/ChangeLog	2021-03-03 16:37:24 UTC (rev 273816)
+++ trunk/Tools/ChangeLog	2021-03-03 16:55:05 UTC (rev 273817)
@@ -1,3 +1,14 @@
+2021-03-03  Youenn Fablet  
+
+WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set
+https://bugs.webkit.org/show_bug.cgi?id=222589
+
+
+Reviewed by Geoffrey Garen.
+
+* TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm:
+(TestWebKitAPI::TEST):
+
 2021-03-03  Don Olmstead  
 
 [CMake] _javascript_Core GLib headers should be copies


Mo

[webkit-changes] [273816] trunk

[shvaikalesh]

Title: [273816] trunk








Revision 273816
Author shvaikal...@gmail.com
Date 2021-03-03 08:37:24 -0800 (Wed, 03 Mar 2021)


Log Message
Add JSModuleNamespaceObject::deletePropertyByIndex() method
https://bugs.webkit.org/show_bug.cgi?id=222611

Reviewed by Yusuke Suzuki.

JSTests:

* modules/arbitrary-module-names-indexed.js: Added.
* modules/arbitrary-module-names/export-indexed.js: Added.

Source/_javascript_Core:

r270923 introduced arbitrary module namespace identifiers, enabling indexed identifiers
to be exported. While they were already handled by getOwnPropertySlotByIndex(), indexed
[[Delete]] override was absent, which prevented TypeError from being thrown.

This patch adds the missing method, aligning JSC with the spec [1].

[1]: https://tc39.es/ecma262/#sec-module-namespace-exotic-objects-delete-p

* runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::deleteProperty):
(JSC::JSModuleNamespaceObject::deletePropertyByIndex):
* runtime/JSModuleNamespaceObject.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSModuleNamespaceObject.cpp
trunk/Source/_javascript_Core/runtime/JSModuleNamespaceObject.h


Added Paths

trunk/JSTests/modules/arbitrary-module-names/export-indexed.js
trunk/JSTests/modules/arbitrary-module-names-indexed.js




Diff

Modified: trunk/JSTests/ChangeLog (273815 => 273816)

--- trunk/JSTests/ChangeLog	2021-03-03 16:34:03 UTC (rev 273815)
+++ trunk/JSTests/ChangeLog	2021-03-03 16:37:24 UTC (rev 273816)
@@ -1,3 +1,13 @@
+2021-03-03  Alexey Shvayka  
+
+Add JSModuleNamespaceObject::deletePropertyByIndex() method
+https://bugs.webkit.org/show_bug.cgi?id=222611
+
+Reviewed by Yusuke Suzuki.
+
+* modules/arbitrary-module-names-indexed.js: Added.
+* modules/arbitrary-module-names/export-indexed.js: Added.
+
 2021-03-02  Alexey Shvayka  
 
 TypedArray's [[DefineOwnProperty]] should throw in case of failure


Added: trunk/JSTests/modules/arbitrary-module-names/export-indexed.js (0 => 273816)

--- trunk/JSTests/modules/arbitrary-module-names/export-indexed.js	(rev 0)
+++ trunk/JSTests/modules/arbitrary-module-names/export-indexed.js	2021-03-03 16:37:24 UTC (rev 273816)
@@ -0,0 +1,6 @@
+var a = 0;
+var b = 1;
+export {
+a as "0",
+b as "1",
+};


Added: trunk/JSTests/modules/arbitrary-module-names-indexed.js (0 => 273816)

--- trunk/JSTests/modules/arbitrary-module-names-indexed.js	(rev 0)
+++ trunk/JSTests/modules/arbitrary-module-names-indexed.js	2021-03-03 16:37:24 UTC (rev 273816)
@@ -0,0 +1,22 @@
+import { shouldBe, shouldThrow } from "./resources/assert.js";
+import * as ns from "./arbitrary-module-names/export-indexed.js";
+
+(() => {
+for (let i = 0; i < 1e5; i++) {
+shouldBe(ns[0], 0);
+shouldBe(Reflect.get(ns, 1), 1);
+shouldBe(ns[2], undefined);
+
+shouldThrow(() => { ns[0] = 1; }, `TypeError: Attempted to assign to readonly property.`);
+shouldBe(Reflect.set(ns, 1, 1), false);
+shouldThrow(() => { ns[2] = 2; }, `TypeError: Attempted to assign to readonly property.`);
+
+shouldBe(0 in ns, true);
+shouldBe(Reflect.has(ns, 1), true);
+shouldBe(2 in ns, false);
+
+shouldThrow(() => { delete ns[0]; }, `TypeError: Unable to delete property.`);
+shouldBe(Reflect.deleteProperty(ns, 1), false);
+shouldBe(delete ns[2], true);
+}
+})();


Modified: trunk/Source/_javascript_Core/ChangeLog (273815 => 273816)

--- trunk/Source/_javascript_Core/ChangeLog	2021-03-03 16:34:03 UTC (rev 273815)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-03-03 16:37:24 UTC (rev 273816)
@@ -1,3 +1,23 @@
+2021-03-03  Alexey Shvayka  
+
+Add JSModuleNamespaceObject::deletePropertyByIndex() method
+https://bugs.webkit.org/show_bug.cgi?id=222611
+
+Reviewed by Yusuke Suzuki.
+
+r270923 introduced arbitrary module namespace identifiers, enabling indexed identifiers
+to be exported. While they were already handled by getOwnPropertySlotByIndex(), indexed
+[[Delete]] override was absent, which prevented TypeError from being thrown.
+
+This patch adds the missing method, aligning JSC with the spec [1].
+
+[1]: https://tc39.es/ecma262/#sec-module-namespace-exotic-objects-delete-p
+
+* runtime/JSModuleNamespaceObject.cpp:
+(JSC::JSModuleNamespaceObject::deleteProperty):
+(JSC::JSModuleNamespaceObject::deletePropertyByIndex):
+* runtime/JSModuleNamespaceObject.h:
+
 2021-03-03  Don Olmstead  
 
 [CMake] _javascript_Core GLib headers should be copies


Modified: trunk/Source/_javascript_Core/runtime/JSModuleNamespaceObject.cpp (273815 => 273816)

--- trunk/Source/_javascript_Core/runtime/JSModuleNamespaceObject.cpp	2021-03-03 16:34:03 UTC (rev 273815)
+++ trunk/Source/_javascript_Core/runtime/JSModuleNamespaceObject.cpp	2021-03-03

[webkit-changes] [273815] trunk/Source/WebCore

[zalan]

Title: [273815] trunk/Source/WebCore








Revision 273815
Author za...@apple.com
Date 2021-03-03 08:34:03 -0800 (Wed, 03 Mar 2021)


Log Message
[LFC][IFC] Enable simplified vertical alignment for empty inline boxes
https://bugs.webkit.org/show_bug.cgi?id=222630

Reviewed by Antti Koivisto.

This patch enables the simplified vertical alignment for cases when the line has non-stretching empty inline boxes.
e.g.
textcontent
but not
textcontent (in standards mode the empty inline box starts with a strut, so this would be stretching the root inline box to ~100px).

* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::canUseSimplifiedAlignment):
(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::align):
* layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::InlineLevelBox::LayoutBounds::operator== const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (273814 => 273815)

--- trunk/Source/WebCore/ChangeLog	2021-03-03 16:02:09 UTC (rev 273814)
+++ trunk/Source/WebCore/ChangeLog	2021-03-03 16:34:03 UTC (rev 273815)
@@ -1,3 +1,23 @@
+2021-03-03  Zalan Bujtas  
+
+[LFC][IFC] Enable simplified vertical alignment for empty inline boxes
+https://bugs.webkit.org/show_bug.cgi?id=222630
+
+Reviewed by Antti Koivisto.
+
+This patch enables the simplified vertical alignment for cases when the line has non-stretching empty inline boxes.
+e.g.
+textcontent
+but not
+textcontent (in standards mode the empty inline box starts with a strut, so this would be stretching the root inline box to ~100px).
+
+* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
+(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::canUseSimplifiedAlignment):
+(WebCore::Layout::LineBoxBuilder::SimplifiedVerticalAlignment::align):
+* layout/inlineformatting/InlineLineBox.h:
+(WebCore::Layout::LineBox::InlineLevelBox::LayoutBounds::operator== const):
+
 2021-03-02  Manuel Rego Casasnovas  
 
 [selectors] :focus-visible implementation


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp (273814 => 273815)

--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp	2021-03-03 16:02:09 UTC (rev 273814)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp	2021-03-03 16:34:03 UTC (rev 273815)
@@ -341,7 +341,6 @@
 auto inlineBox = LineBox::InlineLevelBox::createInlineBox(layoutBox, logicalLeft, initialLogicalWidth);
 setVerticalGeometryForInlineBox(*inlineBox);
 lineBox.addInlineLevelBox(WTFMove(inlineBox));
-simplifiedVerticalAlignment.setEnabled(!lineHasContent);
 continue;
 }
 if (run.isInlineBoxEnd()) {
@@ -349,10 +348,11 @@
 auto& inlineBox = lineBox.inlineLevelBoxForLayoutBox(layoutBox);
 ASSERT(inlineBox.isInlineBox());
 // Inline box run is based on margin box. Let's convert it to border box.
-auto marginEnd = std::max(0_lu, formattingContext().geometryForBox(layoutBox).marginEnd());
+auto& inlineBoxGeometry = formattingContext().geometryForBox(layoutBox);
+auto marginEnd = std::max(0_lu, inlineBoxGeometry.marginEnd());
 auto inlineBoxLogicalRight = logicalLeft + run.logicalWidth() - marginEnd;
 inlineBox.setLogicalWidth(inlineBoxLogicalRight - inlineBox.logicalLeft());
-simplifiedVerticalAlignment.setEnabled(!lineHasContent);
+simplifiedAlignVerticallyIfApplicable(inlineBox, inlineBoxGeometry);
 continue;
 }
 if (run.isText() || run.isSoftLineBreak()) {
@@ -638,16 +638,18 @@
 }
 if (inlineLevelBox.isLineBreakBox()) {
 // Baseline aligned, non-stretchy line breaks e.g.  but not .
-auto& layoutBox = inlineLevelBox.layoutBox();
-return layoutBox.style().verticalAlign() == VerticalAlign::Baseline
-&& inlineLevelBox.baseline() <= rootInlineBox.baseline();
+return inlineLevelBox.layoutBox().style().verticalAlign() == VerticalAlign::Baseline && inlineLevelBox.baseline() <= rootInlineBox.baseline();
 }
+if (inlineLevelBox.isInlineBox()) {
+// Baseline aligned, non-stretchy inline boxes e.g.  but not .
+return inlineLevelBox.layoutBox().style().verticalAlign() == VerticalAlign::Baseline && inlineLevelBox.layoutBounds() == rootInlineBox.layoutBounds();
+}
 return false;
 }
 
 void LineBoxBuilder::

[webkit-changes] [273814] trunk

[don . olmstead]

Title: [273814] trunk








Revision 273814
Author don.olmst...@sony.com
Date 2021-03-03 08:02:09 -0800 (Wed, 03 Mar 2021)


Log Message
[CMake] _javascript_Core GLib headers should be copies
https://bugs.webkit.org/show_bug.cgi?id=222625

Reviewed by Michael Catanzaro.

.:

Specify the directories for _javascript_Core GLib headers and derived sources.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Source/_javascript_Core:

Copy the headers rather than creating a symbolic link to structure the _javascript_Core Glib
headers into a jsc directory. This follows the convention used in _javascript_Core where
there are public and private headers.

The public _javascript_Core GLib headers are copied before building _javascript_Core. The
private _javascript_Core were modified to include the public GLib headers through
 rather than "Header.h" which is convention for the private C APIs in
_javascript_Core.

APICast.h was being erroneously included in JSCClassPrivate.h because its not a
_javascript_Core GLib header. Instead forward declarations were added to the private headers
and APICast.h was used as necessary in the .cpp files.

* API/glib/JSCClassPrivate.h:
* API/glib/JSCContext.cpp:
* API/glib/JSCContextPrivate.h:
* API/glib/JSCExceptionPrivate.h:
* API/glib/JSCValuePrivate.h:
* API/glib/JSCVirtualMachine.cpp:
* API/glib/JSCVirtualMachinePrivate.h:
* API/glib/JSCWrapperMap.cpp:
* GLib.cmake:
* PlatformGTK.cmake:

Source/WebKit:

Update the includes for the GLib ports.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMNode.cpp:
* WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:

Tools:

Update the includes for the GLib ports.

* MiniBrowser/wpe/CMakeLists.txt:
* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/PlatformWPE.cmake:
* TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp:
* TestWebKitAPI/glib/CMakeLists.txt:
* TestWebKitAPI/glib/PlatformGTK.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/API/glib/JSCClassPrivate.h
trunk/Source/_javascript_Core/API/glib/JSCContext.cpp
trunk/Source/_javascript_Core/API/glib/JSCContextPrivate.h
trunk/Source/_javascript_Core/API/glib/JSCExceptionPrivate.h
trunk/Source/_javascript_Core/API/glib/JSCValuePrivate.h
trunk/Source/_javascript_Core/API/glib/JSCVirtualMachine.cpp
trunk/Source/_javascript_Core/API/glib/JSCVirtualMachinePrivate.h
trunk/Source/_javascript_Core/API/glib/JSCWrapperMap.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GLib.cmake
trunk/Source/_javascript_Core/PlatformGTK.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMNode.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/wpe/CMakeLists.txt
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake
trunk/Tools/TestWebKitAPI/PlatformWPE.cmake
trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp
trunk/Tools/TestWebKitAPI/glib/CMakeLists.txt
trunk/Tools/TestWebKitAPI/glib/PlatformGTK.cmake




Diff

Modified: trunk/ChangeLog (273813 => 273814)

--- trunk/ChangeLog	2021-03-03 12:20:00 UTC (rev 273813)
+++ trunk/ChangeLog	2021-03-03 16:02:09 UTC (rev 273814)
@@ -1,3 +1,15 @@
+2021-03-03  Don Olmstead  
+
+[CMake] _javascript_Core GLib headers should be copies
+https://bugs.webkit.org/show_bug.cgi?id=222625
+
+Reviewed by Michael Catanzaro.
+
+Specify the directories for _javascript_Core GLib headers and derived sources.
+
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/OptionsWPE.cmake:
+
 2021-03-01  Per Arne  
 
 [Win] Fix build failure


Modified: trunk/Source/_javascript_Core/API/glib/JSCClassPrivate.h (273813 => 273814)

--- trunk/Source/_javascript_Core/API/glib/JSCClassPrivate.h	2021-03-03 12:20:00 UTC (rev 273813)
+++ trunk/Source/_javascript_Core/API/glib/JSCClassPrivate.h	2021-03-03 16:02:09 UTC (rev 273814)
@@ -19,12 +19,18 @@
 
 #pragma once
 
-#include "APICast.h"
-#include "JSCClass.h"
-#include "JSCContext.h"
-#include "JSCValue.h"
+#include 
+#include 
+#include 
 #include 
 
+namespace JSC {
+class JSObject;
+}
+
+typedef struct OpaqueJSClass* JSClassRef;
+typedef struct OpaqueJSContext* JSGlobalContextRef;
+
 GRefPtr jscClassCreate(JSCContext*, const char*, JSCClass*, JSCClassVTable*, GDestroyNotify);
 JSClassRef jscClassGetJSClass(JSCClass*);
 JSC::JSObject* jscClassGetOrCreateJSWrapper(JSCClass*, JSCContext*, gpointer);


Modified: trunk/Source/_javascript_Core/API/glib/JSCContext.cpp (273813 => 273814)

--- trunk/Source/_javascript_Core/API/glib/JSCContext.cpp	2021-03-03 12:20:00 UTC (rev 273813)
+++ trunk/Source/_javascript_Core/API/glib/JSCContext.cpp	2021-03-03 16:02:09 UTC (rev 273814)
@@ -20,6 +20,7 @@
 #include "config.h"
 #include "JSCContext.