[webkit-changes] [273950] trunk/Source
Title: [273950] trunk/Source Revision 273950 Author commit-qu...@webkit.org Date 2021-03-04 23:05:47 -0800 (Thu, 04 Mar 2021) Log Message Add internal preference to disable HTTPS upgrade https://bugs.webkit.org/show_bug.cgi?id=222778 Patch by Alex Christensen on 2021-03-04 Reviewed by Simon Fraser. Source/WebKit: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Source/WTF: This is needed for an internal performance benchmark, which serves canned content from a local http server pretending to be from different domains that are in our internal HTTPS upgrade list because the real server supports HTTPS. That internal benchmark should eventually change, but that's not going to happen this year. This is also likely going to be useful for QA purposes to be able to easily tell on an internal build whether HTTPS upgrade is breaking something. * Scripts/Preferences/WebPreferencesInternal.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WTF/ChangeLog (273949 => 273950) --- trunk/Source/WTF/ChangeLog 2021-03-05 05:47:46 UTC (rev 273949) +++ trunk/Source/WTF/ChangeLog 2021-03-05 07:05:47 UTC (rev 273950) @@ -1,5 +1,20 @@ 2021-03-04 Alex Christensen +Add internal preference to disable HTTPS upgrade +https://bugs.webkit.org/show_bug.cgi?id=222778 + +Reviewed by Simon Fraser. + +This is needed for an internal performance benchmark, which serves canned content from a local http server +pretending to be from different domains that are in our internal HTTPS upgrade list because the real server +supports HTTPS. That internal benchmark should eventually change, but that's not going to happen this year. +This is also likely going to be useful for QA purposes to be able to easily tell on an internal build +whether HTTPS upgrade is breaking something. + +* Scripts/Preferences/WebPreferencesInternal.yaml: + +2021-03-04 Alex Christensen + Remove the HTTPSUpgradeEnabled experimental feature https://bugs.webkit.org/show_bug.cgi?id=222706 Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (273949 => 273950) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-03-05 05:47:46 UTC (rev 273949) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-03-05 07:05:47 UTC (rev 273950) @@ -754,6 +754,16 @@ WebCore: default: false +UpgradeKnownHostsToHTTPSEnabled: + type: bool + humanReadableName: "Upgrade known hosts to HTTPS" + humanReadableDescription: "Upgrade known hosts to HTTPS" + webcoreBinding: none + exposed: [ WebKit ] + defaultValue: +WebKit: + default: true + UseGPUProcessForCanvasRenderingEnabled: type: bool humanReadableName: "GPU Process: Canvas Rendering" Modified: trunk/Source/WebKit/ChangeLog (273949 => 273950) --- trunk/Source/WebKit/ChangeLog 2021-03-05 05:47:46 UTC (rev 273949) +++ trunk/Source/WebKit/ChangeLog 2021-03-05 07:05:47 UTC (rev 273950) @@ -1,5 +1,15 @@ 2021-03-04 Alex Christensen +Add internal preference to disable HTTPS upgrade +https://bugs.webkit.org/show_bug.cgi?id=222778 + +Reviewed by Simon Fraser. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::creationParameters): + +2021-03-04 Alex Christensen + Fix clean build after r273946 https://bugs.webkit.org/show_bug.cgi?id=222706 Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (273949 => 273950) --- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-03-05 05:47:46 UTC (rev 273949) +++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-03-05 07:05:47 UTC (rev 273950) @@ -7981,7 +7981,7 @@ #endif parameters.textInteractionEnabled = preferences().textInteractionEnabled(); -parameters.httpsUpgradeEnabled = m_configuration->httpsUpgradeEnabled(); +parameters.httpsUpgradeEnabled = preferences().upgradeKnownHostsToHTTPSEnabled() ? m_configuration->httpsUpgradeEnabled() : false; #if PLATFORM(IOS) parameters.allowsDeprecatedSynchronousXMLHttpRequestDuringUnload = allowsDeprecatedSynchronousXMLHttpRequestDuringUnload(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273949] trunk/Source/WebKit
Title: [273949] trunk/Source/WebKit
Revision 273949
Author achristen...@apple.com
Date 2021-03-04 21:47:46 -0800 (Thu, 04 Mar 2021)
Log Message
Fix clean build after r273946
https://bugs.webkit.org/show_bug.cgi?id=222706
* DerivedSources-output.xcfilelist:
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/DerivedSources-output.xcfilelist
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit/ChangeLog (273948 => 273949)
--- trunk/Source/WebKit/ChangeLog 2021-03-05 05:46:58 UTC (rev 273948)
+++ trunk/Source/WebKit/ChangeLog 2021-03-05 05:47:46 UTC (rev 273949)
@@ -1,5 +1,13 @@
2021-03-04 Alex Christensen
+Fix clean build after r273946
+https://bugs.webkit.org/show_bug.cgi?id=222706
+
+* DerivedSources-output.xcfilelist:
+* WebKit.xcodeproj/project.pbxproj:
+
+2021-03-04 Alex Christensen
+
Remove the HTTPSUpgradeEnabled experimental feature
https://bugs.webkit.org/show_bug.cgi?id=222706
Modified: trunk/Source/WebKit/DerivedSources-output.xcfilelist (273948 => 273949)
--- trunk/Source/WebKit/DerivedSources-output.xcfilelist 2021-03-05 05:46:58 UTC (rev 273948)
+++ trunk/Source/WebKit/DerivedSources-output.xcfilelist 2021-03-05 05:47:46 UTC (rev 273949)
@@ -46,7 +46,6 @@
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit2/GPUProcessProxyMessageReceiver.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit2/GPUProcessProxyMessages.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit2/GPUProcessProxyMessagesReplies.h
-$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit2/HTTPSUpgradeList.db
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit2/LegacyCustomProtocolManagerMessageReceiver.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit2/LegacyCustomProtocolManagerMessages.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit2/LegacyCustomProtocolManagerMessagesReplies.h
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (273948 => 273949)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-03-05 05:46:58 UTC (rev 273948)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-03-05 05:47:46 UTC (rev 273949)
@@ -1218,7 +1218,6 @@
57FD318522B35169008D0E8B /* SOAuthorizationSession.h in Headers */ = {isa = PBXBuildFile; fileRef = 57FD317C22B3514A008D0E8B /* SOAuthorizationSession.h */; };
57FD318622B3516C008D0E8B /* SubFrameSOAuthorizationSession.h in Headers */ = {isa = PBXBuildFile; fileRef = 57FD317D22B3514A008D0E8B /* SubFrameSOAuthorizationSession.h */; };
57FD318722B35170008D0E8B /* WKSOAuthorizationDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 57FD317122B35148008D0E8B /* WKSOAuthorizationDelegate.h */; };
- 587743A621C30BBE00AE9084 /* HTTPSUpgradeList.db in Resources */ = {isa = PBXBuildFile; fileRef = 587743A421C30AD800AE9084 /* HTTPSUpgradeList.db */; };
5C0B17781E7C880E00E9123C /* NetworkSocketStreamMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5C0B17741E7C879C00E9123C /* NetworkSocketStreamMessageReceiver.cpp */; };
5C0B17791E7C882100E9123C /* WebSocketStreamMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5C0B17761E7C879C00E9123C /* WebSocketStreamMessageReceiver.cpp */; };
5C121E842410208D00486F9B /* FrameTreeNodeData.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C121E8324101F7000486F9B /* FrameTreeNodeData.h */; };
@@ -4323,7 +4322,6 @@
57FD317D22B3514A008D0E8B /* SubFrameSOAuthorizationSession.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SubFrameSOAuthorizationSession.h; sourceTree = ""; };
57FD317E22B3514A008D0E8B /* WKSOAuthorizationDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKSOAuthorizationDelegate.mm; sourceTree = ""; };
57FD317F22B3514A008D0E8B /* SOAuthorizationSession.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SOAuthorizationSession.mm; sourceTree = ""; };
- 587743A421C30AD800AE9084 /* HTTPSUpgradeList.db */ = {isa = PBXFileReference; lastKnownFileType = file; name = HTTPSUpgradeList.db; path = DerivedSources/WebKit2/HTTPSUpgradeList.db; sourceTree = BUILT_PRODUCTS_DIR; };
5C00993B2417FB7E00D53C25 /* ResourceLoadStatisticsParameters.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResourceLoadStatisticsParameters.h; sourceTree = ""; };
5C0A10C1235241A30053E2CA /* NetworkSchemeRegistry.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NetworkSchemeRegistry.cpp; sourceTree = ""; };
5C0B17741E7C879C00E9123C /* NetworkSocketStreamMessageReceiver.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = NetworkSocketStreamMessageReceiver.cpp; path = DerivedSources/WebKit2/NetworkSocketStreamMessageReceiver.cpp; sourceTree = BUILT_PRODUCTS_DIR; };
@@
[webkit-changes] [273948] branches/safari-612.1.5-branch/Source/WebKit
Title: [273948] branches/safari-612.1.5-branch/Source/WebKit Revision 273948 Author repst...@apple.com Date 2021-03-04 21:46:58 -0800 (Thu, 04 Mar 2021) Log Message Cherry-pick r273485. rdar://problem/75075088 Temporarily stop enforcing notification filtering https://bugs.webkit.org/show_bug.cgi?id=222386 Reviewed by Brent Fulgham. Temporarily stop enforcing notification filtering on macOS and iOS. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: * WebProcess/com.apple.WebProcess.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273485 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.1.5-branch/Source/WebKit/ChangeLog branches/safari-612.1.5-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb branches/safari-612.1.5-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: branches/safari-612.1.5-branch/Source/WebKit/ChangeLog (273947 => 273948) --- branches/safari-612.1.5-branch/Source/WebKit/ChangeLog 2021-03-05 04:48:49 UTC (rev 273947) +++ branches/safari-612.1.5-branch/Source/WebKit/ChangeLog 2021-03-05 05:46:58 UTC (rev 273948) @@ -1,5 +1,36 @@ 2021-03-04 Alan Coon +Cherry-pick r273485. rdar://problem/75075088 + +Temporarily stop enforcing notification filtering +https://bugs.webkit.org/show_bug.cgi?id=222386 + + +Reviewed by Brent Fulgham. + +Temporarily stop enforcing notification filtering on macOS and iOS. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: +* WebProcess/com.apple.WebProcess.sb.in: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273485 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-02-25 Per Arne + +Temporarily stop enforcing notification filtering +https://bugs.webkit.org/show_bug.cgi?id=222386 + + +Reviewed by Brent Fulgham. + +Temporarily stop enforcing notification filtering on macOS and iOS. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: +* WebProcess/com.apple.WebProcess.sb.in: + +2021-03-04 Alan Coon + Cherry-pick r273784. rdar://problem/75059445 REGRESSION(r270691): It's impossible to use MobileAsset fonts on macOS Modified: branches/safari-612.1.5-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (273947 => 273948) --- branches/safari-612.1.5-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2021-03-05 04:48:49 UTC (rev 273947) +++ branches/safari-612.1.5-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2021-03-05 05:46:58 UTC (rev 273948) @@ -642,7 +642,7 @@ (allow mach-lookup (global-name "com.apple.system.notification_center") (apply-message-filter -(deny mach-message-send (with telemetry-backtrace)) +(allow mach-message-send (with telemetry-backtrace)) (deny mach-message-send (with no-report) (message-number 1023)) (allow mach-message-send (with telemetry-backtrace) (message-number 1002 Modified: branches/safari-612.1.5-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (273947 => 273948) --- branches/safari-612.1.5-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-03-05 04:48:49 UTC (rev 273947) +++ branches/safari-612.1.5-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-03-05 05:46:58 UTC (rev 273948) @@ -1269,7 +1269,7 @@ (global-name "com.apple.system.notification_center") #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 (apply-message-filter -(deny mach-message-send (with telemetry-backtrace)) +(allow mach-message-send (with telemetry-backtrace)) (deny mach-message-send (with no-report) (message-number 1023)) (allow mach-message-send (with telemetry-backtrace) (message-number 1002 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273947] trunk/Source/WebCore
Title: [273947] trunk/Source/WebCore
Revision 273947
Author akeer...@apple.com
Date 2021-03-04 20:48:49 -0800 (Thu, 04 Mar 2021)
Log Message
[iOS] Add legacy prefix to the form controls UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=222741
Reviewed by Ryosuke Niwa.
Followup to r273839. Rename the iOS form controls UA stylesheet to
indicate it contains outdated styles.
* DerivedSources-input.xcfilelist:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* css/legacyFormControlsIOS.css: Renamed from Source/WebCore/css/formControlsIOS.css.
Removed redundant comment after the rename.
* style/InspectorCSSOMWrappers.cpp:
(WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers):
* style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
* style/UserAgentStyle.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources-input.xcfilelist
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/style/InspectorCSSOMWrappers.cpp
trunk/Source/WebCore/style/UserAgentStyle.cpp
trunk/Source/WebCore/style/UserAgentStyle.h
Added Paths
trunk/Source/WebCore/css/legacyFormControlsIOS.css
Removed Paths
trunk/Source/WebCore/css/formControlsIOS.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (273946 => 273947)
--- trunk/Source/WebCore/ChangeLog 2021-03-05 04:41:06 UTC (rev 273946)
+++ trunk/Source/WebCore/ChangeLog 2021-03-05 04:48:49 UTC (rev 273947)
@@ -1,3 +1,27 @@
+2021-03-04 Aditya Keerthi
+
+[iOS] Add legacy prefix to the form controls UA stylesheet
+https://bugs.webkit.org/show_bug.cgi?id=222741
+
+
+Reviewed by Ryosuke Niwa.
+
+Followup to r273839. Rename the iOS form controls UA stylesheet to
+indicate it contains outdated styles.
+
+* DerivedSources-input.xcfilelist:
+* DerivedSources.make:
+* WebCore.xcodeproj/project.pbxproj:
+* css/legacyFormControlsIOS.css: Renamed from Source/WebCore/css/formControlsIOS.css.
+
+Removed redundant comment after the rename.
+
+* style/InspectorCSSOMWrappers.cpp:
+(WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers):
+* style/UserAgentStyle.cpp:
+(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
+* style/UserAgentStyle.h:
+
2021-03-04 Chris Dumez
Make RegistrableDomain() private constructor take the String as an rvalue reference
Modified: trunk/Source/WebCore/DerivedSources-input.xcfilelist (273946 => 273947)
--- trunk/Source/WebCore/DerivedSources-input.xcfilelist 2021-03-05 04:41:06 UTC (rev 273946)
+++ trunk/Source/WebCore/DerivedSources-input.xcfilelist 2021-03-05 04:48:49 UTC (rev 273947)
@@ -682,9 +682,9 @@
$(PROJECT_DIR)/css/WebKitCSSViewportRule.idl
$(PROJECT_DIR)/css/WebKitFontFamilyNames.in
$(PROJECT_DIR)/css/dialog.css
-$(PROJECT_DIR)/css/formControlsIOS.css
$(PROJECT_DIR)/css/fullscreen.css
$(PROJECT_DIR)/css/html.css
+$(PROJECT_DIR)/css/legacyFormControlsIOS.css
$(PROJECT_DIR)/css/make-css-file-arrays.pl
$(PROJECT_DIR)/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
$(PROJECT_DIR)/css/makeSelectorPseudoElementsMap.py
Modified: trunk/Source/WebCore/DerivedSources.make (273946 => 273947)
--- trunk/Source/WebCore/DerivedSources.make 2021-03-05 04:41:06 UTC (rev 273946)
+++ trunk/Source/WebCore/DerivedSources.make 2021-03-05 04:48:49 UTC (rev 273947)
@@ -1526,9 +1526,9 @@
USER_AGENT_STYLE_SHEETS = \
$(WebCore)/css/dialog.css \
-$(WebCore)/css/formControlsIOS.css \
$(WebCore)/css/fullscreen.css \
$(WebCore)/css/html.css \
+$(WebCore)/css/legacyFormControlsIOS.css \
$(WebCore)/css/mathml.css \
$(WebCore)/css/mediaControls.css \
$(WebCore)/css/plugIns.css \
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (273946 => 273947)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-03-05 04:41:06 UTC (rev 273946)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-03-05 04:48:49 UTC (rev 273947)
@@ -16529,7 +16529,7 @@
E52CF54E20A35A2800DADA27 /* DataListSuggestionPicker.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = DataListSuggestionPicker.h; sourceTree = ""; };
E52EFDF22112875A00AD282A /* InputMode.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = InputMode.h; sourceTree = ""; };
E52EFDF32112875A00AD282A /* InputMode.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = InputMode.cpp; sourceTree = ""; };
- E54CA6DD255DE2D500F901A3 /* formControlsIOS.css */ = {isa = PBXFileReference; lastKnownFileType = text.css; path = formControlsIOS.css; sourceTree = ""; };
+ E54CA6DD255DE2D500F901A3 /* legacyFormControlsIOS.css */ = {isa = PBXFileReference; lastKnownFileType = text.css; path = legacyFormControlsIOS.css; sourceTree = ""; };
[webkit-changes] [273946] trunk/Source/WebKit
Title: [273946] trunk/Source/WebKit
Revision 273946
Author achristen...@apple.com
Date 2021-03-04 20:41:06 -0800 (Thu, 04 Mar 2021)
Log Message
Remove the HTTPSUpgradeEnabled experimental feature
https://bugs.webkit.org/show_bug.cgi?id=222706
Reviewed by Simon Fraser.
* DerivedSources.make:
* Scripts/generate-https-upgrade-database.sh: Removed.
* Shared/HTTPSUpgrade/HTTPSUpgradeList.txt: Removed.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/DerivedSources.make
Removed Paths
trunk/Source/WebKit/Scripts/generate-https-upgrade-database.sh
trunk/Source/WebKit/Shared/HTTPSUpgrade/
Diff
Modified: trunk/Source/WebKit/ChangeLog (273945 => 273946)
--- trunk/Source/WebKit/ChangeLog 2021-03-05 04:36:45 UTC (rev 273945)
+++ trunk/Source/WebKit/ChangeLog 2021-03-05 04:41:06 UTC (rev 273946)
@@ -1,3 +1,14 @@
+2021-03-04 Alex Christensen
+
+Remove the HTTPSUpgradeEnabled experimental feature
+https://bugs.webkit.org/show_bug.cgi?id=222706
+
+Reviewed by Simon Fraser.
+
+* DerivedSources.make:
+* Scripts/generate-https-upgrade-database.sh: Removed.
+* Shared/HTTPSUpgrade/HTTPSUpgradeList.txt: Removed.
+
2021-03-04 Chris Dumez
NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains() can take domains as an rvalue reference
Modified: trunk/Source/WebKit/DerivedSources.make (273945 => 273946)
--- trunk/Source/WebKit/DerivedSources.make 2021-03-05 04:36:45 UTC (rev 273945)
+++ trunk/Source/WebKit/DerivedSources.make 2021-03-05 04:41:06 UTC (rev 273946)
@@ -396,12 +396,3 @@
$(WEB_PREFERENCES_PATTERNS) : $(WTF_BUILD_SCRIPTS_DIR)/GeneratePreferences.rb $(WEB_PREFERENCES_TEMPLATES) $(WEB_PREFERENCES_COMBINED_INPUT_FILE) $(WEB_PREFERENCES_CATEGORY_INPUT_FILES)
$(RUBY) $< --frontend WebKit --base $(WEB_PREFERENCES_COMBINED_INPUT_FILE) --debug ${WTF_BUILD_SCRIPTS_DIR}/Preferences/WebPreferencesDebug.yaml --experimental ${WTF_BUILD_SCRIPTS_DIR}/Preferences/WebPreferencesExperimental.yaml --internal ${WTF_BUILD_SCRIPTS_DIR}/Preferences/WebPreferencesInternal.yaml $(addprefix --template , $(WEB_PREFERENCES_TEMPLATES))
-
-
-# FIXME: We should switch to the internal HTTPSUpgradeList.txt once the feature is ready.
-# VPATH += $(WebKit2)/Shared/HTTPSUpgrade/
-VPATH := $(WebKit2)/Shared/HTTPSUpgrade/ $(VPATH)
-
-all : HTTPSUpgradeList.db
-HTTPSUpgradeList.db : HTTPSUpgradeList.txt $(WebKit2)/Scripts/generate-https-upgrade-database.sh
- sh $(WebKit2)/Scripts/generate-https-upgrade-database.sh $< $@
Deleted: trunk/Source/WebKit/Scripts/generate-https-upgrade-database.sh (273945 => 273946)
--- trunk/Source/WebKit/Scripts/generate-https-upgrade-database.sh 2021-03-05 04:36:45 UTC (rev 273945)
+++ trunk/Source/WebKit/Scripts/generate-https-upgrade-database.sh 2021-03-05 04:41:06 UTC (rev 273946)
@@ -1,52 +0,0 @@
-#!/bin/sh
-#
-# Copyright (C) 2018 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1. Redistributions of source code must retain the above copyright
-#notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-#notice, this list of conditions and the following disclaimer in the
-#documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
-# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
-# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-# THE POSSIBILITY OF SUCH DAMAGE.
-
-# This script requires that HTTPSUpgradeList.txt has the following format:
-# 1. It must be a plain text file with domains delimited by new lines ("\n").
-# 2. The file must not contain duplicate domains.
-# 3. All domains must be lowercase.
-# 4. All domains must be IDNA encoded.
-#
-# Usage:
-# $ sh ./generate-https-upgrade-database.sh
-
-set -e
-
-INPUT_FILE_PATH="${1}"
-OUTPUT_FILE_PATH="${2}"
-
-DB_VERSION="1";
-DB_SCHEMA="CREATE TABLE hosts (host TEXT PRIMARY KEY);"
-
-if [[ ! -f "${INPUT_FILE_PATH}" ]]; then
-echo "Invalid input file" 1>&2;
-exit 1
-fi
-
-if [[ -f "${OUTPUT_FILE_PATH}" ]]; then
-rm "${OUTPUT_FILE_PATH}"
-fi
-
-sqlite3 "${OUTPUT_FILE_PATH}" "PRAGMA user_version=${DB_VERSION}" "${DB_SCHEMA}" ".import ${INPUT_FILE_PATH}
[webkit-changes] [273945] tags/Safari-612.1.5.2.2/
Title: [273945] tags/Safari-612.1.5.2.2/ Revision 273945 Author repst...@apple.com Date 2021-03-04 20:36:45 -0800 (Thu, 04 Mar 2021) Log Message Tag Safari-612.1.5.2.2. Added Paths tags/Safari-612.1.5.2.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273944] trunk/Source/WebCore
Title: [273944] trunk/Source/WebCore
Revision 273944
Author cdu...@apple.com
Date 2021-03-04 20:36:13 -0800 (Thu, 04 Mar 2021)
Log Message
Make RegistrableDomain() private constructor take the String as an rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=222767
Reviewed by Alex Christensen.
Make RegistrableDomain() private constructor take the String as an rvalue reference.
Most call sites have an rvalue reference and it reduces ref counting churn this way.
* platform/RegistrableDomain.h:
(WebCore::RegistrableDomain::uncheckedCreateFromRegistrableDomainString):
(WebCore::RegistrableDomain::uncheckedCreateFromHost):
(WebCore::RegistrableDomain::RegistrableDomain):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RegistrableDomain.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (273943 => 273944)
--- trunk/Source/WebCore/ChangeLog 2021-03-05 04:36:09 UTC (rev 273943)
+++ trunk/Source/WebCore/ChangeLog 2021-03-05 04:36:13 UTC (rev 273944)
@@ -1,3 +1,18 @@
+2021-03-04 Chris Dumez
+
+Make RegistrableDomain() private constructor take the String as an rvalue reference
+https://bugs.webkit.org/show_bug.cgi?id=222767
+
+Reviewed by Alex Christensen.
+
+Make RegistrableDomain() private constructor take the String as an rvalue reference.
+Most call sites have an rvalue reference and it reduces ref counting churn this way.
+
+* platform/RegistrableDomain.h:
+(WebCore::RegistrableDomain::uncheckedCreateFromRegistrableDomainString):
+(WebCore::RegistrableDomain::uncheckedCreateFromHost):
+(WebCore::RegistrableDomain::RegistrableDomain):
+
2021-03-04 Devin Rousso
[Payment Request] remove some unnecessary WebKitAdditions hooks
Modified: trunk/Source/WebCore/platform/RegistrableDomain.h (273943 => 273944)
--- trunk/Source/WebCore/platform/RegistrableDomain.h 2021-03-05 04:36:09 UTC (rev 273943)
+++ trunk/Source/WebCore/platform/RegistrableDomain.h 2021-03-05 04:36:13 UTC (rev 273944)
@@ -81,7 +81,7 @@
static RegistrableDomain uncheckedCreateFromRegistrableDomainString(const String& domain)
{
-return RegistrableDomain { domain };
+return RegistrableDomain { String { domain } };
}
static RegistrableDomain uncheckedCreateFromHost(const String& host)
@@ -90,7 +90,7 @@
auto registrableDomain = topPrivatelyControlledDomain(host);
if (registrableDomain.isEmpty())
return uncheckedCreateFromRegistrableDomainString(host);
-return RegistrableDomain { registrableDomain };
+return RegistrableDomain { WTFMove(registrableDomain) };
#else
return uncheckedCreateFromRegistrableDomainString(host);
#endif
@@ -102,8 +102,8 @@
protected:
private:
-explicit RegistrableDomain(const String& domain)
-: m_registrableDomain { domain.isEmpty() ? "nullOrigin"_s : domain }
+explicit RegistrableDomain(String&& domain)
+: m_registrableDomain { domain.isEmpty() ? "nullOrigin"_s : WTFMove(domain) }
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273943] branches/safari-612.1.5.2-branch/Source/WebKit
Title: [273943] branches/safari-612.1.5.2-branch/Source/WebKit Revision 273943 Author repst...@apple.com Date 2021-03-04 20:36:09 -0800 (Thu, 04 Mar 2021) Log Message Cherry-pick r273485. rdar://problem/75075050 Temporarily stop enforcing notification filtering https://bugs.webkit.org/show_bug.cgi?id=222386 Reviewed by Brent Fulgham. Temporarily stop enforcing notification filtering on macOS and iOS. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: * WebProcess/com.apple.WebProcess.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273485 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.1.5.2-branch/Source/WebKit/ChangeLog branches/safari-612.1.5.2-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb branches/safari-612.1.5.2-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: branches/safari-612.1.5.2-branch/Source/WebKit/ChangeLog (273942 => 273943) --- branches/safari-612.1.5.2-branch/Source/WebKit/ChangeLog 2021-03-05 04:35:23 UTC (rev 273942) +++ branches/safari-612.1.5.2-branch/Source/WebKit/ChangeLog 2021-03-05 04:36:09 UTC (rev 273943) @@ -1,3 +1,34 @@ +2021-03-04 Russell Epstein + +Cherry-pick r273485. rdar://problem/75075050 + +Temporarily stop enforcing notification filtering +https://bugs.webkit.org/show_bug.cgi?id=222386 + + +Reviewed by Brent Fulgham. + +Temporarily stop enforcing notification filtering on macOS and iOS. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: +* WebProcess/com.apple.WebProcess.sb.in: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273485 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-02-25 Per Arne + +Temporarily stop enforcing notification filtering +https://bugs.webkit.org/show_bug.cgi?id=222386 + + +Reviewed by Brent Fulgham. + +Temporarily stop enforcing notification filtering on macOS and iOS. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: +* WebProcess/com.apple.WebProcess.sb.in: + 2021-02-24 Russell Epstein Cherry-pick r273424. rdar://problem/74708164 Modified: branches/safari-612.1.5.2-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (273942 => 273943) --- branches/safari-612.1.5.2-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2021-03-05 04:35:23 UTC (rev 273942) +++ branches/safari-612.1.5.2-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2021-03-05 04:36:09 UTC (rev 273943) @@ -642,7 +642,7 @@ (allow mach-lookup (global-name "com.apple.system.notification_center") (apply-message-filter -(deny mach-message-send (with telemetry-backtrace)) +(allow mach-message-send (with telemetry-backtrace)) (deny mach-message-send (with no-report) (message-number 1023)) (allow mach-message-send (with telemetry-backtrace) (message-number 1002 Modified: branches/safari-612.1.5.2-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (273942 => 273943) --- branches/safari-612.1.5.2-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-03-05 04:35:23 UTC (rev 273942) +++ branches/safari-612.1.5.2-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-03-05 04:36:09 UTC (rev 273943) @@ -1259,7 +1259,7 @@ (global-name "com.apple.system.notification_center") #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 (apply-message-filter -(deny mach-message-send (with telemetry-backtrace)) +(allow mach-message-send (with telemetry-backtrace)) (deny mach-message-send (with no-report) (message-number 1023)) (allow mach-message-send (with telemetry-backtrace) (message-number 1002 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273942] branches/safari-612.1.5.2-branch/Source
Title: [273942] branches/safari-612.1.5.2-branch/Source Revision 273942 Author repst...@apple.com Date 2021-03-04 20:35:23 -0800 (Thu, 04 Mar 2021) Log Message Versioning. WebKit-7612.1.5.2.2 Modified Paths branches/safari-612.1.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.5.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.5.2-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.5.2-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.5.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273941 => 273942) --- branches/safari-612.1.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-03-05 04:33:07 UTC (rev 273941) +++ branches/safari-612.1.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-03-05 04:35:23 UTC (rev 273942) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.5.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273941 => 273942) --- branches/safari-612.1.5.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-03-05 04:33:07 UTC (rev 273941) +++ branches/safari-612.1.5.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-03-05 04:35:23 UTC (rev 273942) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273941 => 273942) --- branches/safari-612.1.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-03-05 04:33:07 UTC (rev 273941) +++ branches/safari-612.1.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-03-05 04:35:23 UTC (rev 273942) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.5.2-branch/Source/WebCore/Configurations/Version.xcconfig (273941 => 273942) --- branches/safari-612.1.5.2-branch/Source/WebCore/Configurations/Version.xcconfig 2021-03-05 04:33:07 UTC (rev 273941) +++ branches/safari-612.1.5.2-branch/Source/WebCore/Configurations/Version.xcconfig 2021-03-05 04:35:23 UTC (rev 273942) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273941 => 273942) --- branches/safari-612.1.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-03-05 04:33:07 UTC (rev 273941) +++ branches/safari-612.1.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-03-05 04:35:23 UTC (rev 273942) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (273941 => 273942) --- branches/safari-612.1.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-03-05 04:33:07 UTC (rev 273941) +++ branches/safari-612.1.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-03-05 04:35:23 UTC (rev 273942) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [273941] trunk/Source/WebKit
Title: [273941] trunk/Source/WebKit
Revision 273941
Author cdu...@apple.com
Date 2021-03-04 20:33:07 -0800 (Thu, 04 Mar 2021)
Log Message
NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains() can take domains as an rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=222768
Reviewed by Geoffrey Garen.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataForRegistrableDomains):
* UIProcess/WebsiteData/WebsiteDataStore.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (273940 => 273941)
--- trunk/Source/WebKit/ChangeLog 2021-03-05 04:17:40 UTC (rev 273940)
+++ trunk/Source/WebKit/ChangeLog 2021-03-05 04:33:07 UTC (rev 273941)
@@ -1,3 +1,17 @@
+2021-03-04 Chris Dumez
+
+NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains() can take domains as an rvalue reference
+https://bugs.webkit.org/show_bug.cgi?id=222768
+
+Reviewed by Geoffrey Garen.
+
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains):
+* UIProcess/Network/NetworkProcessProxy.h:
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::fetchDataForRegistrableDomains):
+* UIProcess/WebsiteData/WebsiteDataStore.h:
+
2021-03-04 Devin Rousso
[Payment Request] remove some unnecessary WebKitAdditions hooks
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (273940 => 273941)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-03-05 04:17:40 UTC (rev 273940)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-03-05 04:33:07 UTC (rev 273941)
@@ -1180,7 +1180,7 @@
sendWithAsyncReply(Messages::NetworkProcess::DeleteCookiesForTesting(sessionID, domain, includeHttpOnlyCookies), WTFMove(completionHandler));
}
-void NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains(PAL::SessionID sessionID, OptionSet dataTypes, OptionSet fetchOptions, Vector domains, CompletionHandler&&)>&& completionHandler)
+void NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains(PAL::SessionID sessionID, OptionSet dataTypes, OptionSet fetchOptions, Vector&& domains, CompletionHandler&&)>&& completionHandler)
{
auto* websiteDataStore = websiteDataStoreFromSessionID(sessionID);
if (!websiteDataStore || dataTypes.isEmpty() || domains.isEmpty()) {
@@ -1188,7 +1188,7 @@
return;
}
-websiteDataStore->fetchDataForRegistrableDomains(dataTypes, fetchOptions, domains, [dataTypes, websiteDataStore = makeRef(*websiteDataStore), completionHandler = WTFMove(completionHandler)] (Vector&& matchingDataRecords, HashSet&& domainsWithMatchingDataRecords) mutable {
+websiteDataStore->fetchDataForRegistrableDomains(dataTypes, fetchOptions, WTFMove(domains), [dataTypes, websiteDataStore = makeRef(*websiteDataStore), completionHandler = WTFMove(completionHandler)] (Vector&& matchingDataRecords, HashSet&& domainsWithMatchingDataRecords) mutable {
websiteDataStore->removeData(dataTypes, WTFMove(matchingDataRecords), [domainsWithMatchingDataRecords = WTFMove(domainsWithMatchingDataRecords), completionHandler = WTFMove(completionHandler)] () mutable {
completionHandler(WTFMove(domainsWithMatchingDataRecords));
});
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h (273940 => 273941)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2021-03-05 04:17:40 UTC (rev 273940)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2021-03-05 04:33:07 UTC (rev 273941)
@@ -187,7 +187,7 @@
void setCrossSiteLoadWithLinkDecorationForTesting(PAL::SessionID, const NavigatedFromDomain&, const NavigatedToDomain&, CompletionHandler&&);
void resetCrossSiteLoadsWithLinkDecorationForTesting(PAL::SessionID, CompletionHandler&&);
void deleteCookiesForTesting(PAL::SessionID, const RegistrableDomain&, bool includeHttpOnlyCookies, CompletionHandler&&);
-void deleteWebsiteDataInUIProcessForRegistrableDomains(PAL::SessionID, OptionSet, OptionSet, Vector, CompletionHandler&&)>&&);
+void deleteWebsiteDataInUIProcessForRegistrableDomains(PAL::SessionID, OptionSet, OptionSet, Vector&&, CompletionHandler&&)>&&);
void hasIsolatedSession(PAL::SessionID, const RegistrableDomain&, CompletionHandler&&);
#if ENABLE(APP_BOUND_DOMAINS)
void
[webkit-changes] [273940] trunk/Source/JavaScriptCore
Title: [273940] trunk/Source/_javascript_Core
Revision 273940
Author achristen...@apple.com
Date 2021-03-04 20:17:40 -0800 (Thu, 04 Mar 2021)
Log Message
[Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
https://bugs.webkit.org/show_bug.cgi?id=222610
Reviewed by Chris Dumez.
* inspector/scripts/codegen/objc_generator.py:
(ObjCGenerator.objc_protocol_import_expression_for_member):
(ObjCGenerator.objc_protocol_import_expression_for_parameter):
(ObjCGenerator.protocol_to_objc_expression_for_member):
(ObjCGenerator.payload_to_objc_expression_for_member):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (273939 => 273940)
--- trunk/Source/_javascript_Core/ChangeLog 2021-03-05 02:57:55 UTC (rev 273939)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-03-05 04:17:40 UTC (rev 273940)
@@ -1,3 +1,16 @@
+2021-03-04 Alex Christensen
+
+[Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
+https://bugs.webkit.org/show_bug.cgi?id=222610
+
+Reviewed by Chris Dumez.
+
+* inspector/scripts/codegen/objc_generator.py:
+(ObjCGenerator.objc_protocol_import_expression_for_member):
+(ObjCGenerator.objc_protocol_import_expression_for_parameter):
+(ObjCGenerator.protocol_to_objc_expression_for_member):
+(ObjCGenerator.payload_to_objc_expression_for_member):
+
2021-03-04 Saam Barati
Don't trust parsing information to tell us if we've emitted op_call_eval
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py (273939 => 273940)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py 2021-03-05 02:57:55 UTC (rev 273939)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py 2021-03-05 04:17:40 UTC (rev 273940)
@@ -390,8 +390,8 @@
def objc_protocol_import_expression_for_member(self, name, declaration, member):
if isinstance(member.type, EnumType):
if member.type.is_anonymous:
-return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), name)
-return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), name)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), name)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), name)
return self.objc_protocol_import_expression_for_variable(member.type, name)
def objc_protocol_import_expression_for_parameter(self, name, domain, event_or_command_name, parameter):
@@ -442,8 +442,8 @@
if category in [ObjCTypeCategory.Simple, ObjCTypeCategory.String]:
if isinstance(member.type, EnumType):
if member.type.is_anonymous:
-return 'fromProtocolString<%s>(%s).value()' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
-return 'fromProtocolString<%s>(%s).value()' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s).value()' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s).value()' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
return sub_expression
if category == ObjCTypeCategory.Object:
raise Exception("protocol_to_objc_expression_for_member does not support an Object type. See: protocol_to_objc_code_block_for_object_member")
@@ -487,9 +487,9 @@
if isinstance(member.type, EnumType):
sub_expression = 'payload[@"%s"]' % member.member_name
if member.type.is_anonymous:
-return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
else:
-return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
if isinstance(_type, ObjectType):
objc_class = self.objc_class_for_type(member.type)
return '[[%s alloc] initWithPayload:payload[@"%s"]]' % (objc_class, member.member_name)
[webkit-changes] [273939] trunk/Source
Title: [273939] trunk/Source
Revision 273939
Author drou...@apple.com
Date 2021-03-04 18:57:55 -0800 (Thu, 04 Mar 2021)
Log Message
[Payment Request] remove some unnecessary WebKitAdditions hooks
https://bugs.webkit.org/show_bug.cgi?id=222765
Reviewed by Andy Estes.
Source/WebCore:
* Modules/applepay/ApplePaySession.cpp:
Source/WebKit:
* Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (273938 => 273939)
--- trunk/Source/WebCore/ChangeLog 2021-03-05 01:50:52 UTC (rev 273938)
+++ trunk/Source/WebCore/ChangeLog 2021-03-05 02:57:55 UTC (rev 273939)
@@ -1,3 +1,13 @@
+2021-03-04 Devin Rousso
+
+[Payment Request] remove some unnecessary WebKitAdditions hooks
+https://bugs.webkit.org/show_bug.cgi?id=222765
+
+
+Reviewed by Andy Estes.
+
+* Modules/applepay/ApplePaySession.cpp:
+
2021-03-04 Julian Gonzalez
Deploy Ref in SVGUseElement.cpp
Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp (273938 => 273939)
--- trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp 2021-03-05 01:50:52 UTC (rev 273938)
+++ trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp 2021-03-05 02:57:55 UTC (rev 273939)
@@ -141,10 +141,6 @@
return WTFMove(result);
}
-#if defined(ApplePaySessionAdditions_convertAndValidate)
-ApplePaySessionAdditions_convertAndValidate
-#endif
-
static ExceptionOr convertAndValidate(Document& document, unsigned version, ApplePayPaymentRequest&& paymentRequest, const PaymentCoordinator& paymentCoordinator)
{
auto convertedRequest = convertAndValidate(document, version, paymentRequest, paymentCoordinator);
Modified: trunk/Source/WebKit/ChangeLog (273938 => 273939)
--- trunk/Source/WebKit/ChangeLog 2021-03-05 01:50:52 UTC (rev 273938)
+++ trunk/Source/WebKit/ChangeLog 2021-03-05 02:57:55 UTC (rev 273939)
@@ -1,3 +1,13 @@
+2021-03-04 Devin Rousso
+
+[Payment Request] remove some unnecessary WebKitAdditions hooks
+https://bugs.webkit.org/show_bug.cgi?id=222765
+
+
+Reviewed by Andy Estes.
+
+* Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
+
2021-03-04 Sihui Liu
Validate documentState of FrameState when setting and getting it
Modified: trunk/Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm (273938 => 273939)
--- trunk/Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2021-03-05 01:50:52 UTC (rev 273938)
+++ trunk/Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2021-03-05 02:57:55 UTC (rev 273939)
@@ -61,10 +61,6 @@
namespace WebKit {
-#if defined(WebPaymentCoordinatorProxyCocoaAdditions_members)
-WebPaymentCoordinatorProxyCocoaAdditions_members
-#endif
-
WebPaymentCoordinatorProxy::WebPaymentCoordinatorProxy(WebPaymentCoordinatorProxy::Client& client)
: m_client(client)
, m_canMakePaymentsQueue(WorkQueue::create("com.apple.WebKit.CanMakePayments"))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273938] trunk/Source/WebCore
Title: [273938] trunk/Source/WebCore
Revision 273938
Author commit-qu...@webkit.org
Date 2021-03-04 17:50:52 -0800 (Thu, 04 Mar 2021)
Log Message
Deploy Ref in SVGUseElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=222637
Patch by Julian Gonzalez on 2021-03-04
Reviewed by Ryosuke Niwa.
Remove usage of raw pointers in a few functions here
that showed issues in 222397.
Thanks to Darin Adler for the initial version of this patch
and Ryosuke Niwa for refinements.
* svg/SVGUseElement.cpp:
(WebCore::disassociateAndRemoveClones):
(WebCore::removeDisallowedElementsFromSubtree):
(WebCore::removeSymbolElementsFromSubtree):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (273937 => 273938)
--- trunk/Source/WebCore/ChangeLog 2021-03-05 01:45:24 UTC (rev 273937)
+++ trunk/Source/WebCore/ChangeLog 2021-03-05 01:50:52 UTC (rev 273938)
@@ -1,3 +1,21 @@
+2021-03-04 Julian Gonzalez
+
+Deploy Ref in SVGUseElement.cpp
+https://bugs.webkit.org/show_bug.cgi?id=222637
+
+Reviewed by Ryosuke Niwa.
+
+Remove usage of raw pointers in a few functions here
+that showed issues in 222397.
+
+Thanks to Darin Adler for the initial version of this patch
+and Ryosuke Niwa for refinements.
+
+* svg/SVGUseElement.cpp:
+(WebCore::disassociateAndRemoveClones):
+(WebCore::removeDisallowedElementsFromSubtree):
+(WebCore::removeSymbolElementsFromSubtree):
+
2021-03-04 Ryosuke Niwa
"precustomized" state of custom elements can become HTMLUnknownElement
Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (273937 => 273938)
--- trunk/Source/WebCore/svg/SVGUseElement.cpp 2021-03-05 01:45:24 UTC (rev 273937)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp 2021-03-05 01:50:52 UTC (rev 273938)
@@ -309,14 +309,14 @@
return targetClone->renderer();
}
-static inline void disassociateAndRemoveClones(const Vector& clones)
+static inline void disassociateAndRemoveClones(const Vector>& clones)
{
for (auto& clone : clones) {
-for (auto& descendant : descendantsOfType(*clone))
+for (auto& descendant : descendantsOfType(clone.get()))
descendant.setCorrespondingElement(nullptr);
if (is(clone))
-downcast(*clone).setCorrespondingElement(nullptr);
-clone->parentNode()->removeChild(*clone);
+downcast(clone.get()).setCorrespondingElement(nullptr);
+clone->remove();
}
}
@@ -330,10 +330,10 @@
// Assert that it's not in a document to make sure callers are still using it this way.
ASSERT(!subtree.isConnected());
-Vector disallowedElements;
+Vector> disallowedElements;
for (auto it = descendantsOfType(subtree).begin(); it; ) {
if (isDisallowedElement(*it)) {
-disallowedElements.append(&*it);
+disallowedElements.append(*it);
it.traverseNextSkippingChildren();
continue;
}
@@ -349,10 +349,10 @@
// don't need to be cloned to get correct rendering. 2) expandSymbolElementsInShadowTree will turn them
// into elements, which is correct for symbol elements directly referenced by use elements,
// but incorrect for ones that just happen to be in a subtree.
-Vector symbolElements;
+Vector> symbolElements;
for (auto it = descendantsOfType(subtree).begin(); it; ) {
if (is(*it)) {
-symbolElements.append(&*it);
+symbolElements.append(*it);
it.traverseNextSkippingChildren();
continue;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273937] tags/Safari-611.1.21.0.4/
Title: [273937] tags/Safari-611.1.21.0.4/ Revision 273937 Author repst...@apple.com Date 2021-03-04 17:45:24 -0800 (Thu, 04 Mar 2021) Log Message Tag Safari-611.1.21.0.4. Added Paths tags/Safari-611.1.21.0.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273936] tags/Safari-611.1.21.1.5/
Title: [273936] tags/Safari-611.1.21.1.5/ Revision 273936 Author repst...@apple.com Date 2021-03-04 17:44:37 -0800 (Thu, 04 Mar 2021) Log Message Tag Safari-611.1.21.1.5. Added Paths tags/Safari-611.1.21.1.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273935] trunk/Source/WebCore
Title: [273935] trunk/Source/WebCore Revision 273935 Author rn...@webkit.org Date 2021-03-04 17:28:03 -0800 (Thu, 04 Mar 2021) Log Message "precustomized" state of custom elements can become HTMLUnknownElement https://bugs.webkit.org/show_bug.cgi?id=221652 Reviewed by Darin Adler. The bug was caused by createJSHTMLWrapper in JSHTMLElementWrapperFactory.cpp relying on !isCustomElementUpgradeCandidate() to create HTMLUnknownElement as JS wrapper of the element. This is problematic after r266269 since that change re-purposes CustomElementState::Failed on a custom element as "precustomized" state instead of introducing another enum value in CustomElementState as RareDataBitFields has no more bits available. This patch fixes the problem by introducing a new NodeFlag::IsUnknownElement and using that to check whether JSHTMLUnknownElement should be created for a given element or not. Note that HTMLElement had a virtual function, isHTMLUnknownElement, to check this condition but invoking a virtual function proved to incur too much runtime cost. * dom/Node.h: (WebCore::Node::isUnknownElement const): Added. (WebCore::Node::isHTMLUnknownElement const): Added. (WebCore::Node::isSVGUnknownElement const): Added. (WebCore::Node::isMathMLUnknownElement const): Added. (WebCore::Node::NodeFlag): Added NodeFlag::IsUnknownElement. * dom/make_names.pl: (printWrapperFactoryCppFile): Treat the element as HTMLUnknownElement only if isUnknownElement returns true instead of isCustomElementUpgradeCandidate returning false. * html/HTMLElement.h: (WebCore::HTMLElement::isHTMLUnknownElement const): Deleted. * html/HTMLUnknownElement.h: * mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): Added ConstructionType as an argument. * mathml/MathMLElement.h: * mathml/MathMLUnknownElement.h: (WebCore::MathMLUnknownElement::MathMLUnknownElement): Set NodeFlag::IsUnknownElement. * svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Added ConstructionType as an argument. * svg/SVGElement.h: * svg/SVGUnknownElement.h: (WebCore::SVGUnknownElement::SVGUnknownElement): Set NodeFlag::IsUnknownElement. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/dom/make_names.pl trunk/Source/WebCore/html/HTMLElement.h trunk/Source/WebCore/html/HTMLUnknownElement.h trunk/Source/WebCore/mathml/MathMLElement.cpp trunk/Source/WebCore/mathml/MathMLElement.h trunk/Source/WebCore/mathml/MathMLUnknownElement.h trunk/Source/WebCore/svg/SVGElement.cpp trunk/Source/WebCore/svg/SVGElement.h trunk/Source/WebCore/svg/SVGUnknownElement.h Diff Modified: trunk/Source/WebCore/ChangeLog (273934 => 273935) --- trunk/Source/WebCore/ChangeLog 2021-03-05 01:18:12 UTC (rev 273934) +++ trunk/Source/WebCore/ChangeLog 2021-03-05 01:28:03 UTC (rev 273935) @@ -1,3 +1,45 @@ +2021-03-04 Ryosuke Niwa + +"precustomized" state of custom elements can become HTMLUnknownElement +https://bugs.webkit.org/show_bug.cgi?id=221652 + +Reviewed by Darin Adler. + +The bug was caused by createJSHTMLWrapper in JSHTMLElementWrapperFactory.cpp relying on +!isCustomElementUpgradeCandidate() to create HTMLUnknownElement as JS wrapper of the element. + +This is problematic after r266269 since that change re-purposes CustomElementState::Failed +on a custom element as "precustomized" state instead of introducing another enum value in +CustomElementState as RareDataBitFields has no more bits available. + +This patch fixes the problem by introducing a new NodeFlag::IsUnknownElement and using that +to check whether JSHTMLUnknownElement should be created for a given element or not. Note that +HTMLElement had a virtual function, isHTMLUnknownElement, to check this condition but invoking +a virtual function proved to incur too much runtime cost. + +* dom/Node.h: +(WebCore::Node::isUnknownElement const): Added. +(WebCore::Node::isHTMLUnknownElement const): Added. +(WebCore::Node::isSVGUnknownElement const): Added. +(WebCore::Node::isMathMLUnknownElement const): Added. +(WebCore::Node::NodeFlag): Added NodeFlag::IsUnknownElement. +* dom/make_names.pl: +(printWrapperFactoryCppFile): Treat the element as HTMLUnknownElement only if isUnknownElement +returns true instead of isCustomElementUpgradeCandidate returning false. +* html/HTMLElement.h: +(WebCore::HTMLElement::isHTMLUnknownElement const): Deleted. +* html/HTMLUnknownElement.h: +* mathml/MathMLElement.cpp: +(WebCore::MathMLElement::MathMLElement): Added ConstructionType as an argument. +* mathml/MathMLElement.h: +* mathml/MathMLUnknownElement.h: +(WebCore::MathMLUnknownElement::MathMLUnknownElement): Set NodeFlag::IsUnknownElement. +* svg/SVGElement.cpp: +(WebCore::SVGElement::SVGElement): Added ConstructionType as an argument. +
[webkit-changes] [273934] trunk/Tools
Title: [273934] trunk/Tools Revision 273934 Author commit-qu...@webkit.org Date 2021-03-04 17:18:12 -0800 (Thu, 04 Mar 2021) Log Message Undeprecate many more webkit-patch commands https://bugs.webkit.org/show_bug.cgi?id=222745 Patch by Sam Sneddon on 2021-03-04 Reviewed by Jonathan Bedard. * Scripts/webkitpy/tool/commands/download.py: (ChangeStyleLocal): * Scripts/webkitpy/tool/commands/queries.py: (SuggestReviewers): * Scripts/webkitpy/tool/commands/setupgitclone.py: (SetupGitClone): * Scripts/webkitpy/tool/commands/suggestnominations.py: (SuggestNominations): * Scripts/webkitpy/tool/commands/upload.py: (Post): (Prepare): (MarkBugFixed): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/commands/download.py trunk/Tools/Scripts/webkitpy/tool/commands/queries.py trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py trunk/Tools/Scripts/webkitpy/tool/commands/upload.py Diff Modified: trunk/Tools/ChangeLog (273933 => 273934) --- trunk/Tools/ChangeLog 2021-03-05 00:45:13 UTC (rev 273933) +++ trunk/Tools/ChangeLog 2021-03-05 01:18:12 UTC (rev 273934) @@ -1,3 +1,23 @@ +2021-03-04 Sam Sneddon + +Undeprecate many more webkit-patch commands +https://bugs.webkit.org/show_bug.cgi?id=222745 + +Reviewed by Jonathan Bedard. + +* Scripts/webkitpy/tool/commands/download.py: +(ChangeStyleLocal): +* Scripts/webkitpy/tool/commands/queries.py: +(SuggestReviewers): +* Scripts/webkitpy/tool/commands/setupgitclone.py: +(SetupGitClone): +* Scripts/webkitpy/tool/commands/suggestnominations.py: +(SuggestNominations): +* Scripts/webkitpy/tool/commands/upload.py: +(Post): +(Prepare): +(MarkBugFixed): + 2021-03-04 Aakash Jain Reduce unnecessary logging in ews-app Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download.py (273933 => 273934) --- trunk/Tools/Scripts/webkitpy/tool/commands/download.py 2021-03-05 00:45:13 UTC (rev 273933) +++ trunk/Tools/Scripts/webkitpy/tool/commands/download.py 2021-03-05 01:18:12 UTC (rev 273934) @@ -144,7 +144,6 @@ LandCowhand._prepare_state(self, options, args, tool) -@DeprecatedCommand class CheckStyleLocal(AbstractSequencedCommand): name = "check-style-local" help_text = "Run check-webkit-style on the current working directory diff" Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queries.py (273933 => 273934) --- trunk/Tools/Scripts/webkitpy/tool/commands/queries.py 2021-03-05 00:45:13 UTC (rev 273933) +++ trunk/Tools/Scripts/webkitpy/tool/commands/queries.py 2021-03-05 01:18:12 UTC (rev 273934) @@ -58,7 +58,6 @@ _log = logging.getLogger(__name__) -@DeprecatedCommand class SuggestReviewers(AbstractSequencedCommand): name = "suggest-reviewers" help_text = "Suggest reviewers for a patch based on recent changes to the modified files." Modified: trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py (273933 => 273934) --- trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py 2021-03-05 00:45:13 UTC (rev 273933) +++ trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py 2021-03-05 01:18:12 UTC (rev 273934) @@ -32,7 +32,6 @@ from webkitpy.tool.multicommandtool import Command -@DeprecatedCommand class SetupGitClone(Command): name = "setup-git-clone" help_text = "Configures a new Git clone for the WebKit development" Modified: trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py (273933 => 273934) --- trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py 2021-03-05 00:45:13 UTC (rev 273933) +++ trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py 2021-03-05 01:18:12 UTC (rev 273934) @@ -145,7 +145,6 @@ } -@DeprecatedCommand class SuggestNominations(AbstractCommitLogCommand): name = "suggest-nominations" help_text = "Suggest contributors for committer/reviewer nominations" Modified: trunk/Tools/Scripts/webkitpy/tool/commands/upload.py (273933 => 273934) --- trunk/Tools/Scripts/webkitpy/tool/commands/upload.py 2021-03-05 00:45:13 UTC (rev 273933) +++ trunk/Tools/Scripts/webkitpy/tool/commands/upload.py 2021-03-05 01:18:12 UTC (rev 273934) @@ -214,7 +214,6 @@ return state -@DeprecatedCommand class Post(AbstractPatchUploadingCommand): name = "post" help_text = "Attach the current working directory diff to a bug as a patch file" @@ -259,7 +258,6 @@ ] -@DeprecatedCommand class Prepare(AbstractSequencedCommand): name = "prepare" help_text = "Creates a bug (or prompts for an existing bug) and prepares the ChangeLogs" @@ -381,7 +379,6 @@ # FIXME: This command needs to be brought into the modern age with steps and CommitInfo. -@DeprecatedCommand class MarkBugFixed(Command): name = "mark-bug-fixed" help_text = "Mark the specified bug as fixed"
[webkit-changes] [273933] trunk/LayoutTests
Title: [273933] trunk/LayoutTests Revision 273933 Author peng.l...@apple.com Date 2021-03-04 16:45:13 -0800 (Thu, 04 Mar 2021) Log Message [GPUP] Some tests in imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements fail when media in GPU Process is enabled https://bugs.webkit.org/show_bug.cgi?id=221697 Unreviewed test gardening. Remove the tests which are consistently passing on bots from the test expectations. * platform/wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (273932 => 273933) --- trunk/LayoutTests/ChangeLog 2021-03-05 00:43:41 UTC (rev 273932) +++ trunk/LayoutTests/ChangeLog 2021-03-05 00:45:13 UTC (rev 273933) @@ -1,3 +1,14 @@ +2021-03-04 Peng Liu + +[GPUP] Some tests in imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements fail when media in GPU Process is enabled +https://bugs.webkit.org/show_bug.cgi?id=221697 + +Unreviewed test gardening. + +Remove the tests which are consistently passing on bots from the test expectations. + +* platform/wk2/TestExpectations: + 2021-03-04 Ryan Haddad Unreivewed test gardening, remove failure expectation for some tests that are consistently passing. Modified: trunk/LayoutTests/platform/wk2/TestExpectations (273932 => 273933) --- trunk/LayoutTests/platform/wk2/TestExpectations 2021-03-05 00:43:41 UTC (rev 273932) +++ trunk/LayoutTests/platform/wk2/TestExpectations 2021-03-05 00:45:13 UTC (rev 273933) @@ -216,9 +216,6 @@ http/tests/media/hls/hls-progress.html [ Failure ] http/tests/media/video-play-stall.html [ Failure ] -# webkit.org/b/221697 -imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_progress_noautoplay.html [ Failure ] - # webkit.org/b/221685 media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Timeout Failure Pass ] media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Timeout Pass ] @@ -234,9 +231,6 @@ media/modern-media-controls/seek-backward-support/seek-backward-support.html [ Timeout Pass ] http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html [ Timeout ] -# webkit.org/b/221689 -media/picture-in-picture/picture-in-picture-api-pip-window.html [ Timeout Pass ] - # webkit.org/b/221693 media/encrypted-media/clearKey/clearKey-session-life-cycle.html [ Failure Crash ] media/media-controller-unpause.html [ Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273932] trunk/LayoutTests
Title: [273932] trunk/LayoutTests Revision 273932 Author ryanhad...@apple.com Date 2021-03-04 16:43:41 -0800 (Thu, 04 Mar 2021) Log Message Unreivewed test gardening, remove failure expectation for some tests that are consistently passing. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (273931 => 273932) --- trunk/LayoutTests/ChangeLog 2021-03-05 00:18:23 UTC (rev 273931) +++ trunk/LayoutTests/ChangeLog 2021-03-05 00:43:41 UTC (rev 273932) @@ -1,3 +1,9 @@ +2021-03-04 Ryan Haddad + +Unreivewed test gardening, remove failure expectation for some tests that are consistently passing. + +* platform/ios-wk2/TestExpectations: + 2021-03-04 Jon Lee [GPUP] Test platform/mac/media/encrypted-media/fps-encrypted-event.html times out when media in GPU Process is enabled Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (273931 => 273932) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-03-05 00:18:23 UTC (rev 273931) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-03-05 00:43:41 UTC (rev 273932) @@ -1889,12 +1889,6 @@ webkit.org/b/217641 [ Debug ] imported/w3c/web-platform-tests/xhr/event-timeout.any.worker.html [ Pass Failure ] -# 2 compositing/contents-scale/* and 2 fast/canvas/canvas* tests are flaky failures -compositing/contents-scale/non-decomposable-matrix.html [ Pass Failure ] -compositing/contents-scale/rasterization-scale.html [ Pass Failure ] -fast/canvas/canvas-blending-global-alpha.html [ Pass Failure ] -fast/canvas/canvas-scale-shadowBlur.html [ Pass Failure ] - webkit.org/b/219403 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-candidate-in-sdp.https.html [ Pass Failure ] webkit.org/b/219438 [ Release ] fast/canvas/canvas-overflow-hidden-animation.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273931] trunk
Title: [273931] trunk
Revision 273931
Author sbar...@apple.com
Date 2021-03-04 16:18:23 -0800 (Thu, 04 Mar 2021)
Log Message
Don't trust parsing information to tell us if we've emitted op_call_eval
https://bugs.webkit.org/show_bug.cgi?id=222694
rdar://74778016
Reviewed by Yusuke Suzuki.
JSTests:
* stress/eval-liveness-should-not-come-from-parser.js: Added.
(foo):
Source/_javascript_Core:
In the DFG, op_call_eval can't be inlined. Not inlining is required for how
eval is currently implemented in the DFG. For CodeBlocks with eval in them,
the scope register is also alive everywhere.
When doing spread of arguments in eval, we end up emitting a call varargs
instead of a direct eval. This seems like a spec bug:
https://bugs.webkit.org/show_bug.cgi?id=222671
However, this leads to something that had eval textually in it leading to
us reporting the scope register is always alive, even if op_call_eval isn't
in the bytecode stream. This leads to a validation error, since the DFG
isn't actually keeping this scope register alive everywhere, because
op_call_eval isn't in the bytecode stream.
This patch fixes this by having a bit indicating if op_call_eval is in
the bytecode stream or not.
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeIndex):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::usesCallEval const):
(JSC::CodeBlock::usesEval const): Deleted.
* bytecode/ExecutableInfo.h:
(JSC::ExecutableInfo::ExecutableInfo):
(JSC::ExecutableInfo::usesEval const): Deleted.
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::usesCallEval const):
(JSC::UnlinkedCodeBlock::setUsesCallEval):
(JSC::UnlinkedCodeBlock::usesEval const): Deleted.
* bytecode/UnlinkedCodeBlockGenerator.h:
(JSC::UnlinkedCodeBlockGenerator::usesCallEval const):
(JSC::UnlinkedCodeBlockGenerator::setUsesCallEval):
(JSC::UnlinkedCodeBlockGenerator::usesEval const): Deleted.
* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::isThisUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isNewTargetUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isSuperUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isSuperCallUsedInInnerArrowFunction):
* dfg/DFGGraph.h:
* runtime/CachedTypes.cpp:
(JSC::CachedCodeBlock::usesCallEval const):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::CachedCodeBlock::encode):
(JSC::CachedCodeBlock::usesEval const): Deleted.
* runtime/CodeCache.cpp:
(JSC::generateUnlinkedCodeBlockImpl):
* runtime/EvalExecutable.h:
(JSC::EvalExecutable::executableInfo const): Deleted.
* runtime/ModuleProgramExecutable.h:
* runtime/ProgramExecutable.h:
* runtime/ScriptExecutable.h:
(JSC::ScriptExecutable::usesEval const): Deleted.
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecode/ExecutableInfo.h
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlockGenerator.h
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/runtime/CachedTypes.cpp
trunk/Source/_javascript_Core/runtime/CodeCache.cpp
trunk/Source/_javascript_Core/runtime/EvalExecutable.h
trunk/Source/_javascript_Core/runtime/ModuleProgramExecutable.h
trunk/Source/_javascript_Core/runtime/ProgramExecutable.h
trunk/Source/_javascript_Core/runtime/ScriptExecutable.h
Added Paths
trunk/JSTests/stress/eval-liveness-should-not-come-from-parser.js
Diff
Modified: trunk/JSTests/ChangeLog (273930 => 273931)
--- trunk/JSTests/ChangeLog 2021-03-05 00:14:08 UTC (rev 273930)
+++ trunk/JSTests/ChangeLog 2021-03-05 00:18:23 UTC (rev 273931)
@@ -1,3 +1,14 @@
+2021-03-04 Saam Barati
+
+Don't trust parsing information to tell us if we've emitted op_call_eval
+https://bugs.webkit.org/show_bug.cgi?id=222694
+rdar://74778016
+
+Reviewed by Yusuke Suzuki.
+
+* stress/eval-liveness-should-not-come-from-parser.js: Added.
+(foo):
+
2021-03-03 Yusuke Suzuki
[JSC] Update test262
Added: trunk/JSTests/stress/eval-liveness-should-not-come-from-parser.js (0 => 273931)
--- trunk/JSTests/stress/eval-liveness-should-not-come-from-parser.js (rev 0)
+++ trunk/JSTests/stress/eval-liveness-should-not-come-from-parser.js 2021-03-05 00:18:23 UTC (rev 273931)
@@ -0,0 +1,12 @@
+//@ runDefault("--validateGraphAtEachPhase=1", "--validateFTLOSRExitLiveness=1", "--useConcurrentJIT=0", "--jitPolicyScale=0",
[webkit-changes] [273930] trunk/Tools
Title: [273930] trunk/Tools
Revision 273930
Author aakash_j...@apple.com
Date 2021-03-04 16:14:08 -0800 (Thu, 04 Mar 2021)
Log Message
Reduce unnecessary logging in ews-app
https://bugs.webkit.org/show_bug.cgi?id=222764
Reviewed by Jonathan Bedard.
* CISupport/ews-app/ews/views/retrypatch.py:
(RetryPatch.post):
Modified Paths
trunk/Tools/CISupport/ews-app/ews/views/retrypatch.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-app/ews/views/retrypatch.py (273929 => 273930)
--- trunk/Tools/CISupport/ews-app/ews/views/retrypatch.py 2021-03-05 00:12:41 UTC (rev 273929)
+++ trunk/Tools/CISupport/ews-app/ews/views/retrypatch.py 2021-03-05 00:14:08 UTC (rev 273930)
@@ -47,7 +47,7 @@
patch_id = request.POST.get('patch_id')
patch_id = int(patch_id)
except (ValueError, TypeError) as e:
-return HttpResponse('Invalid patch id: {}'.format(request.POST.get('patch_id')))
+return HttpResponse('Invalid patch id')
builds_to_retry = StatusBubble().find_failed_builds_for_patch(patch_id)
_log.info('Retrying patch: {}. Failed builds: {}'.format(patch_id, builds_to_retry))
Modified: trunk/Tools/ChangeLog (273929 => 273930)
--- trunk/Tools/ChangeLog 2021-03-05 00:12:41 UTC (rev 273929)
+++ trunk/Tools/ChangeLog 2021-03-05 00:14:08 UTC (rev 273930)
@@ -1,3 +1,13 @@
+2021-03-04 Aakash Jain
+
+Reduce unnecessary logging in ews-app
+https://bugs.webkit.org/show_bug.cgi?id=222764
+
+Reviewed by Jonathan Bedard.
+
+* CISupport/ews-app/ews/views/retrypatch.py:
+(RetryPatch.post):
+
2021-03-04 Matt Lewis
Add Apple Silicon Devices to Big Sur builders and testers.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273929] trunk/Source/WebKit
Title: [273929] trunk/Source/WebKit
Revision 273929
Author commit-qu...@webkit.org
Date 2021-03-04 16:12:41 -0800 (Thu, 04 Mar 2021)
Log Message
Validate documentState of FrameState when setting and getting it
https://bugs.webkit.org/show_bug.cgi?id=222587
Patch by Sihui Liu on 2021-03-04
Reviewed by Geoffrey Garen.
In rdar://48634553, strings of documentState can be invalid when they are encoded in encodeFrameStateNode
in UI process. To get a better idea of when the strings become invalid, add checks for documentState when
getting and setting it.
No test as no behavior change.
* Shared/SessionState.cpp:
(WebKit::FrameState::encode const):
(WebKit::FrameState::decode):
(WebKit::FrameState::validateDocumentState const):
(WebKit::FrameState::setDocumentState):
* Shared/SessionState.h:
(WebKit::FrameState::FrameState):
(WebKit::FrameState::~FrameState):
(WebKit::FrameState::documentState const):
* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
* UIProcess/API/glib/WebKitWebViewSessionState.cpp:
(encodeFrameState):
(decodeFrameState):
* UIProcess/Cocoa/SessionStateCoding.h:
* UIProcess/LegacySessionStateCoding.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionState const):
* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeFrameStateNode):
(WebKit::decodeBackForwardTreeNode):
* WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toFrameState):
(WebKit::applyFrameState):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/SessionState.cpp
trunk/Source/WebKit/Shared/SessionState.h
trunk/Source/WebKit/Shared/WebBackForwardListItem.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp
trunk/Source/WebKit/UIProcess/Cocoa/SessionStateCoding.h
trunk/Source/WebKit/UIProcess/LegacySessionStateCoding.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/SessionStateConversion.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (273928 => 273929)
--- trunk/Source/WebKit/ChangeLog 2021-03-04 23:58:19 UTC (rev 273928)
+++ trunk/Source/WebKit/ChangeLog 2021-03-05 00:12:41 UTC (rev 273929)
@@ -1,3 +1,42 @@
+2021-03-04 Sihui Liu
+
+Validate documentState of FrameState when setting and getting it
+https://bugs.webkit.org/show_bug.cgi?id=222587
+
+Reviewed by Geoffrey Garen.
+
+In rdar://48634553, strings of documentState can be invalid when they are encoded in encodeFrameStateNode
+in UI process. To get a better idea of when the strings become invalid, add checks for documentState when
+getting and setting it.
+
+No test as no behavior change.
+
+* Shared/SessionState.cpp:
+(WebKit::FrameState::encode const):
+(WebKit::FrameState::decode):
+(WebKit::FrameState::validateDocumentState const):
+(WebKit::FrameState::setDocumentState):
+* Shared/SessionState.h:
+(WebKit::FrameState::FrameState):
+(WebKit::FrameState::~FrameState):
+(WebKit::FrameState::documentState const):
+* Shared/WebBackForwardListItem.cpp:
+(WebKit::WebBackForwardListItem::create):
+(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
+* UIProcess/API/glib/WebKitWebViewSessionState.cpp:
+(encodeFrameState):
+(decodeFrameState):
+* UIProcess/Cocoa/SessionStateCoding.h:
+* UIProcess/LegacySessionStateCoding.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::sessionState const):
+* UIProcess/mac/LegacySessionStateCoding.cpp:
+(WebKit::encodeFrameStateNode):
+(WebKit::decodeBackForwardTreeNode):
+* WebProcess/WebCoreSupport/SessionStateConversion.cpp:
+(WebKit::toFrameState):
+(WebKit::applyFrameState):
+
2021-03-04 Tim Horton
Fix the build after r273904
Modified: trunk/Source/WebKit/Shared/SessionState.cpp (273928 => 273929)
--- trunk/Source/WebKit/Shared/SessionState.cpp 2021-03-04 23:58:19 UTC (rev 273928)
+++ trunk/Source/WebKit/Shared/SessionState.cpp 2021-03-05 00:12:41 UTC (rev 273929)
@@ -110,7 +110,7 @@
encoder << referrer;
encoder << target;
-encoder << documentState;
+encoder << m_documentState;
encoder << stateObjectData;
encoder << documentSequenceNumber;
@@ -146,8 +146,10 @@
if (!decoder.decode(result.target))
return WTF::nullopt;
-if (!decoder.decode(result.documentState))
+if (!decoder.decode(result.m_documentState))
return WTF::nullopt;
+result.validateDocumentState();
+
if (!decoder.decode(result.stateObjectData))
return WTF::nullopt;
@@ -270,4 +272,30 @@
return {{ WTFMove(*items), WTFMove(currentIndex) }};
}
+void FrameState::validateDocumentState() const
+{
+for (auto& stateString :
[webkit-changes] [273928] trunk/Source/WebCore
Title: [273928] trunk/Source/WebCore
Revision 273928
Author don.olmst...@sony.com
Date 2021-03-04 15:58:19 -0800 (Thu, 04 Mar 2021)
Log Message
Non-unified build fixes, early March 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=222755
Unreviewed non-unified build fixes.
* dom/EventContext.cpp:
* html/canvas/ImageBitmapRenderingContext.cpp:
* inspector/agents/worker/WorkerNetworkAgent.cpp:
* page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:
* rendering/RenderModel.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventContext.cpp
trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp
trunk/Source/WebCore/inspector/agents/worker/WorkerNetworkAgent.cpp
trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp
trunk/Source/WebCore/rendering/RenderModel.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (273927 => 273928)
--- trunk/Source/WebCore/ChangeLog 2021-03-04 23:46:12 UTC (rev 273927)
+++ trunk/Source/WebCore/ChangeLog 2021-03-04 23:58:19 UTC (rev 273928)
@@ -1,3 +1,16 @@
+2021-03-04 Don Olmstead
+
+Non-unified build fixes, early March 2021 edition
+https://bugs.webkit.org/show_bug.cgi?id=222755
+
+Unreviewed non-unified build fixes.
+
+* dom/EventContext.cpp:
+* html/canvas/ImageBitmapRenderingContext.cpp:
+* inspector/agents/worker/WorkerNetworkAgent.cpp:
+* page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:
+* rendering/RenderModel.cpp:
+
2021-03-04 Devin Rousso
[Payment Request] increment the current version
Modified: trunk/Source/WebCore/dom/EventContext.cpp (273927 => 273928)
--- trunk/Source/WebCore/dom/EventContext.cpp 2021-03-04 23:46:12 UTC (rev 273927)
+++ trunk/Source/WebCore/dom/EventContext.cpp 2021-03-04 23:58:19 UTC (rev 273928)
@@ -30,6 +30,7 @@
#include "DOMWindow.h"
#include "Document.h"
+#include "EventNames.h"
#include "FocusEvent.h"
#include "HTMLFormElement.h"
#include "MouseEvent.h"
Modified: trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp (273927 => 273928)
--- trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp 2021-03-04 23:46:12 UTC (rev 273927)
+++ trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp 2021-03-04 23:58:19 UTC (rev 273928)
@@ -26,6 +26,7 @@
#include "config.h"
#include "ImageBitmapRenderingContext.h"
+#include "HTMLCanvasElement.h"
#include "ImageBitmap.h"
#include "ImageBuffer.h"
#include "InspectorInstrumentation.h"
Modified: trunk/Source/WebCore/inspector/agents/worker/WorkerNetworkAgent.cpp (273927 => 273928)
--- trunk/Source/WebCore/inspector/agents/worker/WorkerNetworkAgent.cpp 2021-03-04 23:46:12 UTC (rev 273927)
+++ trunk/Source/WebCore/inspector/agents/worker/WorkerNetworkAgent.cpp 2021-03-04 23:58:19 UTC (rev 273928)
@@ -26,6 +26,7 @@
#include "config.h"
#include "WorkerNetworkAgent.h"
+#include "SharedBuffer.h"
#include "WorkerDebuggerProxy.h"
#include "WorkerOrWorkletGlobalScope.h"
#include "WorkerThread.h"
Modified: trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp (273927 => 273928)
--- trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp 2021-03-04 23:46:12 UTC (rev 273927)
+++ trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp 2021-03-04 23:58:19 UTC (rev 273928)
@@ -27,10 +27,11 @@
#include "config.h"
#include "ScrollingTreeScrollingNodeDelegateNicosia.h"
+#if ENABLE(ASYNC_SCROLLING) && USE(NICOSIA)
+
#include "NicosiaPlatformLayer.h"
+#include "ScrollingTreeFrameScrollingNode.h"
-#if ENABLE(ASYNC_SCROLLING) && USE(NICOSIA)
-
namespace WebCore {
class ScrollAnimation;
class ScrollAnimationKinetic;
Modified: trunk/Source/WebCore/rendering/RenderModel.cpp (273927 => 273928)
--- trunk/Source/WebCore/rendering/RenderModel.cpp 2021-03-04 23:46:12 UTC (rev 273927)
+++ trunk/Source/WebCore/rendering/RenderModel.cpp 2021-03-04 23:58:19 UTC (rev 273928)
@@ -23,11 +23,11 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#if ENABLE(MODEL_ELEMENT)
-
#include "config.h"
#include "RenderModel.h"
+#if ENABLE(MODEL_ELEMENT)
+
#include "HTMLModelElement.h"
#include "RenderStyle.h"
#include
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273927] trunk/LayoutTests
Title: [273927] trunk/LayoutTests Revision 273927 Author jon...@apple.com Date 2021-03-04 15:46:12 -0800 (Thu, 04 Mar 2021) Log Message [GPUP] Test platform/mac/media/encrypted-media/fps-encrypted-event.html times out when media in GPU Process is enabled https://bugs.webkit.org/show_bug.cgi?id=221847 Reviewed by Simon Fraser. * platform/mac-wk2/TestExpectations: The test no longer times out. Remove expectation. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (273926 => 273927) --- trunk/LayoutTests/ChangeLog 2021-03-04 23:37:58 UTC (rev 273926) +++ trunk/LayoutTests/ChangeLog 2021-03-04 23:46:12 UTC (rev 273927) @@ -1,5 +1,14 @@ 2021-03-04 Jon Lee +[GPUP] Test platform/mac/media/encrypted-media/fps-encrypted-event.html times out when media in GPU Process is enabled +https://bugs.webkit.org/show_bug.cgi?id=221847 + +Reviewed by Simon Fraser. + +* platform/mac-wk2/TestExpectations: The test no longer times out. Remove expectation. + +2021-03-04 Jon Lee + Garden encrypted media tests https://bugs.webkit.org/show_bug.cgi?id=221687 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (273926 => 273927) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-03-04 23:37:58 UTC (rev 273926) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-03-04 23:46:12 UTC (rev 273927) @@ -1327,8 +1327,6 @@ # webkit.org/b/221826 fast/mediastream/media-element-current-time.html [ Failure ] -webkit.org/b/221847 platform/mac/media/encrypted-media/fps-encrypted-event.html [ Timeout ] - webkit.org/b/221965 [ BigSur ] imported/w3c/web-platform-tests/media-source/mediasource-seekable.html [ Pass Failure ] webkit.org/b/221857 fast/selectors/text-field-selection-window-inactive-text-shadow.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273926] trunk/Tools
Title: [273926] trunk/Tools
Revision 273926
Author jlew...@apple.com
Date 2021-03-04 15:37:58 -0800 (Thu, 04 Mar 2021)
Log Message
Add Apple Silicon Devices to Big Sur builders and testers.
https://bugs.webkit.org/show_bug.cgi?id=222616
Reviewed by Aakash Jain.
* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (273925 => 273926)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2021-03-04 23:30:44 UTC (rev 273925)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2021-03-04 23:37:58 UTC (rev 273926)
@@ -1,13 +1,23 @@
{
"workers": [
+{ "name": "bot105", "platform": "mac-bigsur" },
+{ "name": "bot111", "platform": "mac-bigsur" },
+{ "name": "bot121", "platform": "mac-bigsur" },
+{ "name": "bot124", "platform": "mac-bigsur" },
+{ "name": "bot126", "platform": "mac-bigsur" },
+{ "name": "bot131", "platform": "mac-bigsur" },
+{ "name": "bot132", "platform": "mac-bigsur" },
+{ "name": "bot135", "platform": "mac-bigsur" },
+{ "name": "bot137", "platform": "mac-bigsur" },
+{ "name": "bot138", "platform": "mac-bigsur" },
+{ "name": "bot139", "platform": "mac-bigsur" },
+{ "name": "bot140", "platform": "mac-bigsur" },
+{ "name": "bot141", "platform": "mac-bigsur" },
+{ "name": "bot142", "platform": "mac-bigsur" },
{ "name": "bot279", "platform": "mac-bigsur" },
{ "name": "bot302", "platform": "mac-bigsur" },
-{ "name": "bot600", "platform": "mac-bigsur" },
{ "name": "bot603", "platform": "mac-bigsur" },
-{ "name": "bot614", "platform": "mac-bigsur" },
{ "name": "bot632", "platform": "mac-bigsur" },
-{ "name": "bot684", "platform": "mac-bigsur" },
-{ "name": "bot685", "platform": "mac-bigsur" },
{ "name": "bot1020", "platform": "mac-bigsur" },
{ "name": "bot1021", "platform": "mac-bigsur" },
{ "name": "bot1022", "platform": "mac-bigsur" },
@@ -17,7 +27,6 @@
{ "name": "bot1026", "platform": "mac-bigsur" },
{ "name": "bot1027", "platform": "mac-bigsur" },
-{ "name": "bot121", "platform": "mac-catalina" },
{ "name": "bot187", "platform": "mac-catalina" },
{ "name": "bot205", "platform": "mac-catalina" },
{ "name": "bot241", "platform": "mac-catalina" },
@@ -37,7 +46,6 @@
{ "name": "bot688", "platform": "mac-catalina" },
-{ "name": "bot132", "platform": "*" },
{ "name": "bot178", "platform": "*" },
{ "name": "bot179", "platform": "*" },
{ "name": "bot183", "platform": "*" },
@@ -48,6 +56,10 @@
{ "name": "bot611", "platform": "*" },
{ "name": "bot612", "platform": "*" },
{ "name": "bot613", "platform": "*" },
+{ "name": "bot600", "platform": "*" },
+{ "name": "bot614", "platform": "*" },
+{ "name": "bot684", "platform": "*" },
+{ "name": "bot685", "platform": "*" },
{ "name": "bot673", "platform": "ios-14" },
@@ -121,8 +133,11 @@
"builders": [
{ "name": "Apple-BigSur-Release-Build", "factory": "BuildFactory", "builddir": "bigsur-release",
"platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64", "arm64"],
- "triggers": ["bigsur-release-tests-test262", "bigsur-release-tests-wk1", "bigsur-release-tests-wk2", "bigsur-release-tests-wk2-webgl"],
- "workernames": ["bot279", "bot600", "bot614"]
+ "triggers": [
+ "bigsur-release-tests-test262", "bigsur-release-tests-wk1", "bigsur-release-tests-wk2", "bigsur-release-applesilicon-tests-wk1",
+ "bigsur-release-applesilicon-tests-wk2", "bigsur-applesilicon-release-tests-jsc", "bigsur-release-tests-wk2-webgl"
+ ],
+ "workernames": ["bot279", "bot121", "bot124"]
},
{ "name": "Apple-BigSur-Release-Test262-Tests", "factory": "Test262Factory", "builddir":
[webkit-changes] [273925] branches/safari-612.1.5-branch
Title: [273925] branches/safari-612.1.5-branch Revision 273925 Author repst...@apple.com Date 2021-03-04 15:30:44 -0800 (Thu, 04 Mar 2021) Log Message Cherry-pick r273784. rdar://problem/75059445 REGRESSION(r270691): It's impossible to use MobileAsset fonts on macOS https://bugs.webkit.org/show_bug.cgi?id=222582 Reviewed by Per Arne Vollan. Source/WebKit: Simply apply the iOS codepath to macOS. There is also an additional change here to the Mac sandbox. On Big Sur and earlier, before this patch, com.apple.mobileassetd was allowed, and com.apple.mobileassetd.v2 was disallowed. After this patch, they both are allowed, but only with the com.apple.webkit.extension.mach extension. On other OSes, before this patch, nothing was allowed, whereas after this patch, only com.apple.mobileassetd.v2 is allowed with the com.apple.webkit.extension.mach extension. Test: WebKit.MobileAssetSandboxCheck * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _grantAccessToAssetServices]): (-[WKWebView _revokeAccessToAssetServices]): * UIProcess/API/Cocoa/WKWebViewPrivate.h: * UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _grantAccessToAssetServices]): Deleted. (-[WKWebView _revokeAccessToAssetServices]): Deleted. * UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::grantAccessToAssetServices): (WebKit::WebPageProxy::revokeAccessToAssetServices): * UIProcess/WebPageProxy.h: * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::grantAccessToAssetServices): Deleted. (WebKit::WebPageProxy::revokeAccessToAssetServices): Deleted. * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::revokeAccessToAssetServices): * WebProcess/com.apple.WebProcess.sb.in: * WebProcess/glib/WebProcessGLib.cpp: (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::revokeAccessToAssetServices): * WebProcess/playstation/WebProcessPlayStation.cpp: (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::revokeAccessToAssetServices): * WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::revokeAccessToAssetServices): Tools: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/MobileAssetSandboxCheck.mm: Copied from Source/WebKit/WebProcess/win/WebProcessWin.cpp. (TEST): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273784 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.1.5-branch/Source/WebKit/ChangeLog branches/safari-612.1.5-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm branches/safari-612.1.5-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h branches/safari-612.1.5-branch/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm branches/safari-612.1.5-branch/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm branches/safari-612.1.5-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-612.1.5-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm branches/safari-612.1.5-branch/Source/WebKit/WebProcess/WebProcess.h branches/safari-612.1.5-branch/Source/WebKit/WebProcess/WebProcess.messages.in branches/safari-612.1.5-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm branches/safari-612.1.5-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in branches/safari-612.1.5-branch/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp branches/safari-612.1.5-branch/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp branches/safari-612.1.5-branch/Source/WebKit/WebProcess/win/WebProcessWin.cpp branches/safari-612.1.5-branch/Tools/ChangeLog branches/safari-612.1.5-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Added Paths branches/safari-612.1.5-branch/Tools/TestWebKitAPI/Tests/WebKit/MobileAssetSandboxCheck.mm Diff Modified: branches/safari-612.1.5-branch/Source/WebKit/ChangeLog (273924 => 273925) --- branches/safari-612.1.5-branch/Source/WebKit/ChangeLog 2021-03-04 23:22:29 UTC (rev 273924) +++ branches/safari-612.1.5-branch/Source/WebKit/ChangeLog 2021-03-04 23:30:44 UTC (rev 273925) @@ -1,3 +1,114 @@ +2021-03-04 Alan Coon + +Cherry-pick r273784. rdar://problem/75059445 + +REGRESSION(r270691): It's impossible to use MobileAsset fonts on macOS +https://bugs.webkit.org/show_bug.cgi?id=222582 + + +Reviewed by Per Arne Vollan. + +Source/WebKit: + +Simply apply the iOS codepath to macOS. + +There is also an additional change here to the Mac sandbox. +On Big Sur and earlier, before this patch, com.apple.mobileassetd was allowed, +and com.apple.mobileassetd.v2 was disallowed. After this patch, they both are +allowed, but only with the com.apple.webkit.extension.mach extension. +On other OSes, before
[webkit-changes] [273924] trunk/Source/WebKit
Title: [273924] trunk/Source/WebKit
Revision 273924
Author timothy_hor...@apple.com
Date 2021-03-04 15:22:29 -0800 (Thu, 04 Mar 2021)
Log Message
Fix the build after r273904
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::setPreferenceValue):
auto's evilness rears its head again. -mutableCopy returns `id`, so
we infer RetainPtr, so depending on what headers are included
we get ambiguous selector errors. De-auto to fix.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (273923 => 273924)
--- trunk/Source/WebKit/ChangeLog 2021-03-04 23:14:54 UTC (rev 273923)
+++ trunk/Source/WebKit/ChangeLog 2021-03-04 23:22:29 UTC (rev 273924)
@@ -1,3 +1,13 @@
+2021-03-04 Tim Horton
+
+Fix the build after r273904
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::setPreferenceValue):
+auto's evilness rears its head again. -mutableCopy returns `id`, so
+we infer RetainPtr, so depending on what headers are included
+we get ambiguous selector errors. De-auto to fix.
+
2021-03-04 Chris Dumez
Clean up API::ResourceLoadStatisticsThirdParty / API::ResourceLoadStatisticsFirstParty
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (273923 => 273924)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2021-03-04 23:14:54 UTC (rev 273923)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2021-03-04 23:22:29 UTC (rev 273924)
@@ -1109,7 +1109,7 @@
if (key == "AppleLanguages") {
// We need to set AppleLanguages for the volatile domain, similarly to what we do in XPCServiceMain.mm.
NSDictionary *existingArguments = [[NSUserDefaults standardUserDefaults] volatileDomainForName:NSArgumentDomain];
-auto newArguments = adoptNS([existingArguments mutableCopy]);
+RetainPtr newArguments = adoptNS([existingArguments mutableCopy]);
[newArguments setValue:value forKey:@"AppleLanguages"];
[[NSUserDefaults standardUserDefaults] setVolatileDomain:newArguments.get() forName:NSArgumentDomain];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273923] trunk/Source/WebKit
Title: [273923] trunk/Source/WebKit
Revision 273923
Author cdu...@apple.com
Date 2021-03-04 15:14:54 -0800 (Thu, 04 Mar 2021)
Log Message
Clean up API::ResourceLoadStatisticsThirdParty / API::ResourceLoadStatisticsFirstParty
https://bugs.webkit.org/show_bug.cgi?id=222701
Reviewed by Geoffrey Garen.
Clean up API::ResourceLoadStatisticsThirdParty / API::ResourceLoadStatisticsFirstParty:
1. Make constructors private since there is a create() factory function.
2. Mark constructor as explicit since they take a single parameter.
3. Update ResourceLoadStatisticsFirstParty constructor to take parameter as a const
reference instead of passing it by value.
4. Add assertions to make sure those are constructed and destroyed on the main thread.
* UIProcess/API/APIResourceLoadStatisticsFirstParty.h:
* UIProcess/API/APIResourceLoadStatisticsThirdParty.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIResourceLoadStatisticsFirstParty.h
trunk/Source/WebKit/UIProcess/API/APIResourceLoadStatisticsThirdParty.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (273922 => 273923)
--- trunk/Source/WebKit/ChangeLog 2021-03-04 23:06:39 UTC (rev 273922)
+++ trunk/Source/WebKit/ChangeLog 2021-03-04 23:14:54 UTC (rev 273923)
@@ -1,3 +1,20 @@
+2021-03-04 Chris Dumez
+
+Clean up API::ResourceLoadStatisticsThirdParty / API::ResourceLoadStatisticsFirstParty
+https://bugs.webkit.org/show_bug.cgi?id=222701
+
+Reviewed by Geoffrey Garen.
+
+Clean up API::ResourceLoadStatisticsThirdParty / API::ResourceLoadStatisticsFirstParty:
+1. Make constructors private since there is a create() factory function.
+2. Mark constructor as explicit since they take a single parameter.
+3. Update ResourceLoadStatisticsFirstParty constructor to take parameter as a const
+ reference instead of passing it by value.
+4. Add assertions to make sure those are constructed and destroyed on the main thread.
+
+* UIProcess/API/APIResourceLoadStatisticsFirstParty.h:
+* UIProcess/API/APIResourceLoadStatisticsThirdParty.h:
+
2021-03-04 Alex Christensen
Remove the HTTPSUpgradeEnabled experimental feature
Modified: trunk/Source/WebKit/UIProcess/API/APIResourceLoadStatisticsFirstParty.h (273922 => 273923)
--- trunk/Source/WebKit/UIProcess/API/APIResourceLoadStatisticsFirstParty.h 2021-03-04 23:06:39 UTC (rev 273922)
+++ trunk/Source/WebKit/UIProcess/API/APIResourceLoadStatisticsFirstParty.h 2021-03-04 23:14:54 UTC (rev 273923)
@@ -33,14 +33,15 @@
class ResourceLoadStatisticsFirstParty final : public ObjectImpl {
public:
-static Ref create(const WebKit::WebResourceLoadStatisticsStore::ThirdPartyDataForSpecificFirstParty firstPartyData)
+static Ref create(const WebKit::WebResourceLoadStatisticsStore::ThirdPartyDataForSpecificFirstParty& firstPartyData)
{
+RELEASE_ASSERT(RunLoop::isMain());
return adoptRef(*new ResourceLoadStatisticsFirstParty(firstPartyData));
}
-ResourceLoadStatisticsFirstParty(const WebKit::WebResourceLoadStatisticsStore::ThirdPartyDataForSpecificFirstParty firstPartyData)
-: m_firstPartyData(firstPartyData)
+~ResourceLoadStatisticsFirstParty()
{
+RELEASE_ASSERT(RunLoop::isMain());
}
const WTF::String& firstPartyDomain() const { return m_firstPartyData.firstPartyDomain.string(); }
@@ -48,8 +49,12 @@
double timeLastUpdated() const { return m_firstPartyData.timeLastUpdated.value(); }
private:
+explicit ResourceLoadStatisticsFirstParty(const WebKit::WebResourceLoadStatisticsStore::ThirdPartyDataForSpecificFirstParty& firstPartyData)
+: m_firstPartyData(firstPartyData)
+{
+}
+
const WebKit::WebResourceLoadStatisticsStore::ThirdPartyDataForSpecificFirstParty m_firstPartyData;
-
};
} // namespace API
Modified: trunk/Source/WebKit/UIProcess/API/APIResourceLoadStatisticsThirdParty.h (273922 => 273923)
--- trunk/Source/WebKit/UIProcess/API/APIResourceLoadStatisticsThirdParty.h 2021-03-04 23:06:39 UTC (rev 273922)
+++ trunk/Source/WebKit/UIProcess/API/APIResourceLoadStatisticsThirdParty.h 2021-03-04 23:14:54 UTC (rev 273923)
@@ -35,12 +35,13 @@
public:
static Ref create(WebKit::WebResourceLoadStatisticsStore::ThirdPartyData&& thirdPartyData)
{
+RELEASE_ASSERT(RunLoop::isMain());
return adoptRef(*new ResourceLoadStatisticsThirdParty(WTFMove(thirdPartyData)));
}
-ResourceLoadStatisticsThirdParty(WebKit::WebResourceLoadStatisticsStore::ThirdPartyData&& thirdPartyData)
-: m_thirdPartyData(WTFMove(thirdPartyData))
+~ResourceLoadStatisticsThirdParty()
{
+RELEASE_ASSERT(RunLoop::isMain());
}
const WTF::String& thirdPartyDomain() const { return m_thirdPartyData.thirdPartyDomain.string(); }
@@ -47,6 +48,11 @@
const Vector& underFirstParties() const { return m_thirdPartyData.underFirstParties; }
private:
+
[webkit-changes] [273922] trunk/Source/WebCore
Title: [273922] trunk/Source/WebCore
Revision 273922
Author drou...@apple.com
Date 2021-03-04 15:06:39 -0800 (Thu, 04 Mar 2021)
Log Message
[Payment Request] increment the current version
https://bugs.webkit.org/show_bug.cgi?id=222742
Reviewed by Wenson Hsieh.
* Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm:
(WebCore::PaymentAPIVersion::current):
* testing/MockPaymentCoordinator.h:
* testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeShippingMethodSelection):
(WebCore::MockPaymentCoordinator::completeShippingContactSelection):
(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):
(WebCore::MockPaymentCoordinator::completePaymentMethodModeChange):
* Modules/paymentrequest/PaymentRequestUtilities.h: Added.
* Modules/paymentrequest/PaymentRequestUtilities.cpp: Added.
(isValidDecimalMonetaryValue):
* Modules/paymentrequest/PaymentRequest.cpp:
(isValidDecimalMonetaryValue): Deleted.
* Modules/applepay/ApplePaySession.cpp:
(convertAndValidateTotal):
(convertAndValidate):
(validateAmount): Deleted.
* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
Move `isValidDecimalMonetaryValue` so it can be used in other files.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp
trunk/Source/WebCore/Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/testing/MockPaymentCoordinator.cpp
trunk/Source/WebCore/testing/MockPaymentCoordinator.h
Added Paths
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequestUtilities.cpp
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequestUtilities.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (273921 => 273922)
--- trunk/Source/WebCore/ChangeLog 2021-03-04 23:06:01 UTC (rev 273921)
+++ trunk/Source/WebCore/ChangeLog 2021-03-04 23:06:39 UTC (rev 273922)
@@ -1,3 +1,37 @@
+2021-03-04 Devin Rousso
+
+[Payment Request] increment the current version
+https://bugs.webkit.org/show_bug.cgi?id=222742
+
+
+Reviewed by Wenson Hsieh.
+
+* Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm:
+(WebCore::PaymentAPIVersion::current):
+
+* testing/MockPaymentCoordinator.h:
+* testing/MockPaymentCoordinator.cpp:
+(WebCore::MockPaymentCoordinator::showPaymentUI):
+(WebCore::MockPaymentCoordinator::completeShippingMethodSelection):
+(WebCore::MockPaymentCoordinator::completeShippingContactSelection):
+(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):
+(WebCore::MockPaymentCoordinator::completePaymentMethodModeChange):
+
+* Modules/paymentrequest/PaymentRequestUtilities.h: Added.
+* Modules/paymentrequest/PaymentRequestUtilities.cpp: Added.
+(isValidDecimalMonetaryValue):
+* Modules/paymentrequest/PaymentRequest.cpp:
+(isValidDecimalMonetaryValue): Deleted.
+* Modules/applepay/ApplePaySession.cpp:
+(convertAndValidateTotal):
+(convertAndValidate):
+(validateAmount): Deleted.
+* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
+Move `isValidDecimalMonetaryValue` so it can be used in other files.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+
2021-03-04 Zalan Bujtas
[LFC][IFC] LineStatus::availableWidth should always be a valid number
Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp (273921 => 273922)
--- trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp 2021-03-04 23:06:01 UTC (rev 273921)
+++ trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp 2021-03-04 23:06:39 UTC (rev 273922)
@@ -59,6 +59,7 @@
#include "PaymentCoordinator.h"
#include "PaymentMerchantSession.h"
#include "PaymentMethod.h"
+#include "PaymentRequestUtilities.h"
#include "PaymentRequestValidator.h"
#include "SecurityOrigin.h"
#include "Settings.h"
@@ -74,76 +75,9 @@
WTF_MAKE_ISO_ALLOCATED_IMPL(ApplePaySession);
-// The amount follows the regular _expression_ -?[0-9]+(\.[0-9][0-9])?.
-static bool validateAmount(const String& amountString)
-{
-enum class State {
-Start,
-Sign,
-Digit,
-Dot,
-DotDigit,
-End,
-};
-
-State state = State::Start;
-
-for (unsigned i = 0; i < amountString.length(); ++i) {
-UChar c = amountString[i];
-
-switch (state) {
-case State::Start:
-if (c == '-') {
-state = State::Sign;
-break;
-}
-
-if (!isASCIIDigit(c))
-return false;
-state = State::Digit;
-
[webkit-changes] [273921] branches/safari-611.1.21.0-branch
Title: [273921] branches/safari-611.1.21.0-branch Revision 273921 Author repst...@apple.com Date 2021-03-04 15:06:01 -0800 (Thu, 04 Mar 2021) Log Message Cherry-pick r273901. rdar://problem/75058982 window proxy of detached iframe doesn't respect updates to global values https://bugs.webkit.org/show_bug.cgi?id=206445 Reviewed by Chris Dumez. Source/WebCore: According to the html spec the frame should only be needing for COOP access violation reporting, which we don't support. This patch removes our old behavior of blocking stores to windows that have been detached. I also removed some stale caching code from getOwnPropertySlotByIndex since it's only accessed once now. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlotByIndex): (WebCore::JSDOMWindow::doPutPropertySecurityCheck): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::putByIndex): LayoutTests: * fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added. * fast/frames/iframe-detached-window-still-writable-eval.html: Added. * fast/frames/iframe-detached-window-still-writable-expected.txt: Added. * fast/frames/iframe-detached-window-still-writable.html: Added. * http/tests/dom/cross-origin-detached-window-properties-expected.txt: * http/tests/dom/cross-origin-detached-window-properties.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273901 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611.1.21.0-branch/LayoutTests/ChangeLog branches/safari-611.1.21.0-branch/LayoutTests/http/tests/dom/cross-origin-detached-window-properties-expected.txt branches/safari-611.1.21.0-branch/LayoutTests/http/tests/dom/cross-origin-detached-window-properties.html branches/safari-611.1.21.0-branch/Source/WebCore/ChangeLog branches/safari-611.1.21.0-branch/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp Added Paths branches/safari-611.1.21.0-branch/LayoutTests/fast/frames/iframe-detached-window-still-writable-eval-expected.txt branches/safari-611.1.21.0-branch/LayoutTests/fast/frames/iframe-detached-window-still-writable-eval.html branches/safari-611.1.21.0-branch/LayoutTests/fast/frames/iframe-detached-window-still-writable-expected.txt branches/safari-611.1.21.0-branch/LayoutTests/fast/frames/iframe-detached-window-still-writable.html Diff Modified: branches/safari-611.1.21.0-branch/LayoutTests/ChangeLog (273920 => 273921) --- branches/safari-611.1.21.0-branch/LayoutTests/ChangeLog 2021-03-04 23:04:08 UTC (rev 273920) +++ branches/safari-611.1.21.0-branch/LayoutTests/ChangeLog 2021-03-04 23:06:01 UTC (rev 273921) @@ -1,3 +1,54 @@ +2021-03-04 Alan Coon + +Cherry-pick r273901. rdar://problem/75058982 + +window proxy of detached iframe doesn't respect updates to global values +https://bugs.webkit.org/show_bug.cgi?id=206445 + +Reviewed by Chris Dumez. + +Source/WebCore: + +According to the html spec the frame should only be needing for +COOP access violation reporting, which we don't support. This +patch removes our old behavior of blocking stores to windows that +have been detached. + +I also removed some stale caching code from +getOwnPropertySlotByIndex since it's only accessed once now. + +* bindings/js/JSDOMWindowCustom.cpp: +(WebCore::JSDOMWindow::getOwnPropertySlotByIndex): +(WebCore::JSDOMWindow::doPutPropertySecurityCheck): +(WebCore::JSDOMWindow::put): +(WebCore::JSDOMWindow::putByIndex): + +LayoutTests: + +* fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added. +* fast/frames/iframe-detached-window-still-writable-eval.html: Added. +* fast/frames/iframe-detached-window-still-writable-expected.txt: Added. +* fast/frames/iframe-detached-window-still-writable.html: Added. +* http/tests/dom/cross-origin-detached-window-properties-expected.txt: +* http/tests/dom/cross-origin-detached-window-properties.html: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273901 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-03-04 Keith Miller + +window proxy of detached iframe doesn't respect updates to global values +https://bugs.webkit.org/show_bug.cgi?id=206445 + +Reviewed by Chris Dumez. + +* fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added. +* fast/frames/iframe-detached-window-still-writable-eval.html: Added. +* fast/frames/iframe-detached-window-still-writable-expected.txt: Added. +* fast/frames/iframe-detached-window-still-writable.html: Added. +* http/tests/dom/cross-origin-detached-window-properties-expected.txt: +* http/tests/dom/cross-origin-detached-window-properties.html: + 2021-03-02 Alan Coon Cherry-pick r273656. rdar://problem/74883345
[webkit-changes] [273920] branches/safari-611.1.21.1-branch
Title: [273920] branches/safari-611.1.21.1-branch Revision 273920 Author repst...@apple.com Date 2021-03-04 15:04:08 -0800 (Thu, 04 Mar 2021) Log Message Cherry-pick r273901. rdar://problem/75058990 window proxy of detached iframe doesn't respect updates to global values https://bugs.webkit.org/show_bug.cgi?id=206445 Reviewed by Chris Dumez. Source/WebCore: According to the html spec the frame should only be needing for COOP access violation reporting, which we don't support. This patch removes our old behavior of blocking stores to windows that have been detached. I also removed some stale caching code from getOwnPropertySlotByIndex since it's only accessed once now. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlotByIndex): (WebCore::JSDOMWindow::doPutPropertySecurityCheck): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::putByIndex): LayoutTests: * fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added. * fast/frames/iframe-detached-window-still-writable-eval.html: Added. * fast/frames/iframe-detached-window-still-writable-expected.txt: Added. * fast/frames/iframe-detached-window-still-writable.html: Added. * http/tests/dom/cross-origin-detached-window-properties-expected.txt: * http/tests/dom/cross-origin-detached-window-properties.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273901 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611.1.21.1-branch/LayoutTests/ChangeLog branches/safari-611.1.21.1-branch/LayoutTests/http/tests/dom/cross-origin-detached-window-properties-expected.txt branches/safari-611.1.21.1-branch/LayoutTests/http/tests/dom/cross-origin-detached-window-properties.html branches/safari-611.1.21.1-branch/Source/WebCore/ChangeLog branches/safari-611.1.21.1-branch/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp Added Paths branches/safari-611.1.21.1-branch/LayoutTests/fast/frames/iframe-detached-window-still-writable-eval-expected.txt branches/safari-611.1.21.1-branch/LayoutTests/fast/frames/iframe-detached-window-still-writable-eval.html branches/safari-611.1.21.1-branch/LayoutTests/fast/frames/iframe-detached-window-still-writable-expected.txt branches/safari-611.1.21.1-branch/LayoutTests/fast/frames/iframe-detached-window-still-writable.html Diff Modified: branches/safari-611.1.21.1-branch/LayoutTests/ChangeLog (273919 => 273920) --- branches/safari-611.1.21.1-branch/LayoutTests/ChangeLog 2021-03-04 22:51:25 UTC (rev 273919) +++ branches/safari-611.1.21.1-branch/LayoutTests/ChangeLog 2021-03-04 23:04:08 UTC (rev 273920) @@ -1,3 +1,54 @@ +2021-03-04 Alan Coon + +Cherry-pick r273901. rdar://problem/75058990 + +window proxy of detached iframe doesn't respect updates to global values +https://bugs.webkit.org/show_bug.cgi?id=206445 + +Reviewed by Chris Dumez. + +Source/WebCore: + +According to the html spec the frame should only be needing for +COOP access violation reporting, which we don't support. This +patch removes our old behavior of blocking stores to windows that +have been detached. + +I also removed some stale caching code from +getOwnPropertySlotByIndex since it's only accessed once now. + +* bindings/js/JSDOMWindowCustom.cpp: +(WebCore::JSDOMWindow::getOwnPropertySlotByIndex): +(WebCore::JSDOMWindow::doPutPropertySecurityCheck): +(WebCore::JSDOMWindow::put): +(WebCore::JSDOMWindow::putByIndex): + +LayoutTests: + +* fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added. +* fast/frames/iframe-detached-window-still-writable-eval.html: Added. +* fast/frames/iframe-detached-window-still-writable-expected.txt: Added. +* fast/frames/iframe-detached-window-still-writable.html: Added. +* http/tests/dom/cross-origin-detached-window-properties-expected.txt: +* http/tests/dom/cross-origin-detached-window-properties.html: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273901 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-03-04 Keith Miller + +window proxy of detached iframe doesn't respect updates to global values +https://bugs.webkit.org/show_bug.cgi?id=206445 + +Reviewed by Chris Dumez. + +* fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added. +* fast/frames/iframe-detached-window-still-writable-eval.html: Added. +* fast/frames/iframe-detached-window-still-writable-expected.txt: Added. +* fast/frames/iframe-detached-window-still-writable.html: Added. +* http/tests/dom/cross-origin-detached-window-properties-expected.txt: +* http/tests/dom/cross-origin-detached-window-properties.html: + 2021-03-03 Ruben Turcios Cherry-pick r273764. rdar://problem/74992878
[webkit-changes] [273919] trunk/LayoutTests
Title: [273919] trunk/LayoutTests Revision 273919 Author jon...@apple.com Date 2021-03-04 14:51:25 -0800 (Thu, 04 Mar 2021) Log Message Garden encrypted media tests https://bugs.webkit.org/show_bug.cgi?id=221687 Reviewed by Simon Fraser. * platform/mac-wk2/TestExpectations: All but platform/mac/media/encrypted-media/fps-clearkey-crash.html are now passing. Remove expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (273918 => 273919) --- trunk/LayoutTests/ChangeLog 2021-03-04 22:16:16 UTC (rev 273918) +++ trunk/LayoutTests/ChangeLog 2021-03-04 22:51:25 UTC (rev 273919) @@ -1,3 +1,12 @@ +2021-03-04 Jon Lee + +Garden encrypted media tests +https://bugs.webkit.org/show_bug.cgi?id=221687 + +Reviewed by Simon Fraser. + +* platform/mac-wk2/TestExpectations: All but platform/mac/media/encrypted-media/fps-clearkey-crash.html are now passing. Remove expectations. + 2021-03-04 Zalan Bujtas [LFC][IFC] LineStatus::availableWidth should always be a valid number Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (273918 => 273919) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-03-04 22:16:16 UTC (rev 273918) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-03-04 22:51:25 UTC (rev 273919) @@ -1323,11 +1323,6 @@ # webkit.org/b/221687 platform/mac/media/encrypted-media/fps-clearkey-crash.html [ Timeout Crash ] -platform/mac/media/encrypted-media/fps-createMediaKeys.html [ Crash ] -platform/mac/media/encrypted-media/fps-createSession.html [ Crash ] -platform/mac/media/encrypted-media/fps-ephemeral-requestMediaKeySystemAccess.html [ Crash ] -platform/mac/media/encrypted-media/fps-generateRequest.html [ Crash ] -platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess.html [ Crash ] # webkit.org/b/221826 fast/mediastream/media-element-current-time.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273918] trunk
Title: [273918] trunk
Revision 273918
Author za...@apple.com
Date 2021-03-04 14:16:16 -0800 (Thu, 04 Mar 2021)
Log Message
[LFC][IFC] LineStatus::availableWidth should always be a valid number
https://bugs.webkit.org/show_bug.cgi?id=222752
Reviewed by Antti Koivisto.
Source/WebCore:
A NaN available width value can confuse the line breaking logic. This patch ensures we always provide a valid value.
Test: fast/inline/crash-when-negative-spacing-produce-nan.html
* layout/inlineformatting/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::processInlineContent):
(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::handleInlineContent):
LayoutTests:
* fast/inline/crash-when-negative-spacing-produce-nan-expected.txt: Added.
* fast/inline/crash-when-negative-spacing-produce-nan.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineContentBreaker.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
Added Paths
trunk/LayoutTests/fast/inline/crash-when-negative-spacing-produce-nan-expected.txt
trunk/LayoutTests/fast/inline/crash-when-negative-spacing-produce-nan.html
Diff
Modified: trunk/LayoutTests/ChangeLog (273917 => 273918)
--- trunk/LayoutTests/ChangeLog 2021-03-04 22:05:53 UTC (rev 273917)
+++ trunk/LayoutTests/ChangeLog 2021-03-04 22:16:16 UTC (rev 273918)
@@ -1,3 +1,14 @@
+2021-03-04 Zalan Bujtas
+
+[LFC][IFC] LineStatus::availableWidth should always be a valid number
+https://bugs.webkit.org/show_bug.cgi?id=222752
+
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/crash-when-negative-spacing-produce-nan-expected.txt: Added.
+* fast/inline/crash-when-negative-spacing-produce-nan.html: Added.
+
2021-03-04 Peng Liu
[GPUP] Some media tests are flaky when media in GPU Process is enabled
Added: trunk/LayoutTests/fast/inline/crash-when-negative-spacing-produce-nan-expected.txt (0 => 273918)
--- trunk/LayoutTests/fast/inline/crash-when-negative-spacing-produce-nan-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/inline/crash-when-negative-spacing-produce-nan-expected.txt 2021-03-04 22:16:16 UTC (rev 273918)
@@ -0,0 +1,3 @@
+* { display: block; } html { zoom: 12345678901234567890; } style { letter-spacing: -1px; zoom: 12345678901234567890; }
+PASS if no crash or assert
+if (window.testRunner) testRunner.dumpAsText();
Added: trunk/LayoutTests/fast/inline/crash-when-negative-spacing-produce-nan.html (0 => 273918)
--- trunk/LayoutTests/fast/inline/crash-when-negative-spacing-produce-nan.html (rev 0)
+++ trunk/LayoutTests/fast/inline/crash-when-negative-spacing-produce-nan.html 2021-03-04 22:16:16 UTC (rev 273918)
@@ -0,0 +1,19 @@
+
+
+ * {
+ display: block;
+ }
+ html {
+zoom: 12345678901234567890;
+ }
+ style {
+letter-spacing: -1px;
+zoom: 12345678901234567890;
+ }
+
+PASS if no crash or assert
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+
Modified: trunk/Source/WebCore/ChangeLog (273917 => 273918)
--- trunk/Source/WebCore/ChangeLog 2021-03-04 22:05:53 UTC (rev 273917)
+++ trunk/Source/WebCore/ChangeLog 2021-03-04 22:16:16 UTC (rev 273918)
@@ -1,3 +1,21 @@
+2021-03-04 Zalan Bujtas
+
+[LFC][IFC] LineStatus::availableWidth should always be a valid number
+https://bugs.webkit.org/show_bug.cgi?id=222752
+
+
+Reviewed by Antti Koivisto.
+
+A NaN available width value can confuse the line breaking logic. This patch ensures we always provide a valid value.
+
+Test: fast/inline/crash-when-negative-spacing-produce-nan.html
+
+* layout/inlineformatting/InlineContentBreaker.cpp:
+(WebCore::Layout::InlineContentBreaker::processInlineContent):
+(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):
+* layout/inlineformatting/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::handleInlineContent):
+
2021-03-04 Youenn Fablet
In case of POST navigation redirected by a 302, the 'Origin' header is kept in the redirected request
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineContentBreaker.cpp (273917 => 273918)
--- trunk/Source/WebCore/layout/inlineformatting/InlineContentBreaker.cpp 2021-03-04 22:05:53 UTC (rev 273917)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineContentBreaker.cpp 2021-03-04 22:16:16 UTC (rev 273918)
@@ -131,6 +131,7 @@
InlineContentBreaker::Result InlineContentBreaker::processInlineContent(const ContinuousContent& candidateContent, const LineStatus& lineStatus)
{
+ASSERT(!std::isnan(lineStatus.availableWidth));
auto processCandidateContent = [&] {
if (candidateContent.logicalWidth() <= lineStatus.availableWidth)
return Result {
[webkit-changes] [273917] trunk/Source/JavaScriptCore
Title: [273917] trunk/Source/_javascript_Core
Revision 273917
Author achristen...@apple.com
Date 2021-03-04 14:05:53 -0800 (Thu, 04 Mar 2021)
Log Message
Unreviewed, reverting r273906.
Broke internal build
Reverted changeset:
"[Cocoa] REGRESSION(r272752): fix some internal builds that
use WTFString::WTFString(NSString *)"
https://bugs.webkit.org/show_bug.cgi?id=222610
https://commits.webkit.org/r273906
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (273916 => 273917)
--- trunk/Source/_javascript_Core/ChangeLog 2021-03-04 21:43:33 UTC (rev 273916)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-03-04 22:05:53 UTC (rev 273917)
@@ -1,5 +1,18 @@
2021-03-04 Alex Christensen
+Unreviewed, reverting r273906.
+
+Broke internal build
+
+Reverted changeset:
+
+"[Cocoa] REGRESSION(r272752): fix some internal builds that
+use WTFString::WTFString(NSString *)"
+https://bugs.webkit.org/show_bug.cgi?id=222610
+https://commits.webkit.org/r273906
+
+2021-03-04 Alex Christensen
+
[Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
https://bugs.webkit.org/show_bug.cgi?id=222610
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py (273916 => 273917)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py 2021-03-04 21:43:33 UTC (rev 273916)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py 2021-03-04 22:05:53 UTC (rev 273917)
@@ -390,13 +390,13 @@
def objc_protocol_import_expression_for_member(self, name, declaration, member):
if isinstance(member.type, EnumType):
if member.type.is_anonymous:
-return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), name)
-return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), name)
+return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), name)
+return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), name)
return self.objc_protocol_import_expression_for_variable(member.type, name)
def objc_protocol_import_expression_for_parameter(self, name, domain, event_or_command_name, parameter):
if isinstance(parameter.type, EnumType):
-return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(parameter.type), name)
+return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_non_anonymous_enum(parameter.type), name)
return self.objc_protocol_import_expression_for_variable(parameter.type, name)
def objc_protocol_import_expression_for_variable(self, var_type, var_name):
@@ -442,8 +442,8 @@
if category in [ObjCTypeCategory.Simple, ObjCTypeCategory.String]:
if isinstance(member.type, EnumType):
if member.type.is_anonymous:
-return 'fromProtocolString<%s>((__bridge CFStringRef)%s).value()' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
-return 'fromProtocolString<%s>((__bridge CFStringRef)%s).value()' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
+return 'fromProtocolString<%s>(%s).value()' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
+return 'fromProtocolString<%s>(%s).value()' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
return sub_expression
if category == ObjCTypeCategory.Object:
raise Exception("protocol_to_objc_expression_for_member does not support an Object type. See: protocol_to_objc_code_block_for_object_member")
@@ -487,9 +487,9 @@
if isinstance(member.type, EnumType):
sub_expression = 'payload[@"%s"]' % member.member_name
if member.type.is_anonymous:
-return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
+return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
else:
-return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
+return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
if isinstance(_type, ObjectType):
[webkit-changes] [273916] trunk/Source
Title: [273916] trunk/Source Revision 273916 Author achristen...@apple.com Date 2021-03-04 13:43:33 -0800 (Thu, 04 Mar 2021) Log Message Remove the HTTPSUpgradeEnabled experimental feature https://bugs.webkit.org/show_bug.cgi?id=222706 Reviewed by Simon Fraser. Source/WebKit: * NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: Removed. * NetworkProcess/NetworkHTTPSUpgradeChecker.h: Removed. * NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::NetworkLoadChecker): (WebKit::NetworkLoadChecker::checkRequest): (WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded const): Deleted. * NetworkProcess/NetworkLoadChecker.h: * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::encode const): (WebKit::NetworkResourceLoadParameters::decode): * NetworkProcess/NetworkResourceLoadParameters.h: * NetworkProcess/NetworkResourceLoader.cpp: * NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::networkHTTPSUpgradeChecker): Deleted. * Sources.txt: * WebKit.xcodeproj/project.pbxproj: * WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::addParametersShared): Source/WTF: It was a good experimental implementation, but the feature is now implemented in makeSecureIfNecessary and turned on and off by WKWebViewConfiguration.upgradeKnownHostsToHTTPS. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h trunk/Source/WebKit/NetworkProcess/NetworkProcess.h trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm trunk/Source/WebKit/Sources.txt trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp Removed Paths trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.h Diff Modified: trunk/Source/WTF/ChangeLog (273915 => 273916) --- trunk/Source/WTF/ChangeLog 2021-03-04 21:06:56 UTC (rev 273915) +++ trunk/Source/WTF/ChangeLog 2021-03-04 21:43:33 UTC (rev 273916) @@ -1,3 +1,15 @@ +2021-03-04 Alex Christensen + +Remove the HTTPSUpgradeEnabled experimental feature +https://bugs.webkit.org/show_bug.cgi?id=222706 + +Reviewed by Simon Fraser. + +It was a good experimental implementation, but the feature is now implemented in makeSecureIfNecessary +and turned on and off by WKWebViewConfiguration.upgradeKnownHostsToHTTPS. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2021-03-04 Chris Dumez [macOS][WK2] Changing the system language does not update navigator.language Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (273915 => 273916) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-03-04 21:06:56 UTC (rev 273915) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-03-04 21:43:33 UTC (rev 273916) @@ -380,19 +380,6 @@ WebKit: default: false -# FIXME: This is not implemented for WebKitLegacy, so should be excluded from WebKitLegacy entirely. -HTTPSUpgradeEnabled: - type: bool - humanReadableName: "Automatic HTTPS upgrade" - humanReadableDescription: "Automatic HTTPS upgrade for known supported sites" - defaultValue: -WebKitLegacy: - default: false -WebKit: - default: false -WebCore: - default: false - HighlightAPIEnabled: type: bool humanReadableName: "Highlight API" Modified: trunk/Source/WebKit/ChangeLog (273915 => 273916) --- trunk/Source/WebKit/ChangeLog 2021-03-04 21:06:56 UTC (rev 273915) +++ trunk/Source/WebKit/ChangeLog 2021-03-04 21:43:33 UTC (rev 273916) @@ -1,3 +1,30 @@ +2021-03-04 Alex Christensen + +Remove the HTTPSUpgradeEnabled experimental feature +https://bugs.webkit.org/show_bug.cgi?id=222706 + +Reviewed by Simon Fraser. + +* NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: Removed. +* NetworkProcess/NetworkHTTPSUpgradeChecker.h: Removed. +* NetworkProcess/NetworkLoadChecker.cpp: +(WebKit::NetworkLoadChecker::NetworkLoadChecker): +(WebKit::NetworkLoadChecker::checkRequest): +(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded const): Deleted. +* NetworkProcess/NetworkLoadChecker.h: +* NetworkProcess/NetworkProcess.h: +* NetworkProcess/NetworkResourceLoadParameters.cpp: +(WebKit::NetworkResourceLoadParameters::encode const): +(WebKit::NetworkResourceLoadParameters::decode): +*
[webkit-changes] [273915] trunk/Source/WebKit
Title: [273915] trunk/Source/WebKit Revision 273915 Author wenson_hs...@apple.com Date 2021-03-04 13:06:56 -0800 (Thu, 04 Mar 2021) Log Message [iOS] Add support for a new image-extraction-related responder action https://bugs.webkit.org/show_bug.cgi?id=222743 Reviewed by Devin Rousso. Add support for the new action, such that we return `YES` if and only if we're in an editable context, and also such that we return a non-null target for the new action. * UIProcess/ios/WKContentViewInteraction.h: Add a fallback definition for `FOR_EACH_ADDITIONAL_WKCONTENTVIEW_ACTION`, which can be used by WebKitAdditions to inject additional responder actions when generating selector forwarding code between `WKContentView` and `WKWebView`. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView canPerformActionForWebView:withSender:]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: trunk/Source/WebKit/ChangeLog (273914 => 273915) --- trunk/Source/WebKit/ChangeLog 2021-03-04 21:00:51 UTC (rev 273914) +++ trunk/Source/WebKit/ChangeLog 2021-03-04 21:06:56 UTC (rev 273915) @@ -1,3 +1,23 @@ +2021-03-04 Wenson Hsieh + +[iOS] Add support for a new image-extraction-related responder action +https://bugs.webkit.org/show_bug.cgi?id=222743 + + +Reviewed by Devin Rousso. + +Add support for the new action, such that we return `YES` if and only if we're in an editable context, and also +such that we return a non-null target for the new action. + +* UIProcess/ios/WKContentViewInteraction.h: + +Add a fallback definition for `FOR_EACH_ADDITIONAL_WKCONTENTVIEW_ACTION`, which can be used by WebKitAdditions +to inject additional responder actions when generating selector forwarding code between `WKContentView` and +`WKWebView`. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView canPerformActionForWebView:withSender:]): + 2021-03-04 Chris Dumez Unreviewed build fix after r272629. Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (273914 => 273915) --- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2021-03-04 21:00:51 UTC (rev 273914) +++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2021-03-04 21:06:56 UTC (rev 273915) @@ -145,7 +145,12 @@ typedef BlockPtr InteractionInformationCallback; typedef std::pair InteractionInformationRequestAndCallback; +#if !defined(FOR_EACH_ADDITIONAL_WKCONTENTVIEW_ACTION) +#define FOR_EACH_ADDITIONAL_WKCONTENTVIEW_ACTION(M) +#endif + #define FOR_EACH_WKCONTENTVIEW_ACTION(M) \ +FOR_EACH_ADDITIONAL_WKCONTENTVIEW_ACTION(M) \ M(_addShortcut) \ M(_define) \ M(_lookup) \ Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (273914 => 273915) --- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2021-03-04 21:00:51 UTC (rev 273914) +++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2021-03-04 21:06:56 UTC (rev 273915) @@ -3698,6 +3698,11 @@ return baseWritingDirection != WebCore::WritingDirection::RightToLeft; } +#if ENABLE(IMAGE_EXTRACTION) +if (action == WebKit::imageExtractionAction()) +return editorState.isContentEditable; +#endif + return [super canPerformAction:action withSender:sender]; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273914] trunk/LayoutTests
Title: [273914] trunk/LayoutTests Revision 273914 Author peng.l...@apple.com Date 2021-03-04 13:00:51 -0800 (Thu, 04 Mar 2021) Log Message [GPUP] Some media tests are flaky when media in GPU Process is enabled https://bugs.webkit.org/show_bug.cgi?id=221693 Unreviewed test gardening. Remove the tests which are consistently passing on bots from the test expectations. * platform/wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (273913 => 273914) --- trunk/LayoutTests/ChangeLog 2021-03-04 20:42:52 UTC (rev 273913) +++ trunk/LayoutTests/ChangeLog 2021-03-04 21:00:51 UTC (rev 273914) @@ -1,3 +1,14 @@ +2021-03-04 Peng Liu + +[GPUP] Some media tests are flaky when media in GPU Process is enabled +https://bugs.webkit.org/show_bug.cgi?id=221693 + +Unreviewed test gardening. + +Remove the tests which are consistently passing on bots from the test expectations. + +* platform/wk2/TestExpectations: + 2021-03-04 Youenn Fablet In case of POST navigation redirected by a 302, the 'Origin' header is kept in the redirected request Modified: trunk/LayoutTests/platform/wk2/TestExpectations (273913 => 273914) --- trunk/LayoutTests/platform/wk2/TestExpectations 2021-03-04 20:42:52 UTC (rev 273913) +++ trunk/LayoutTests/platform/wk2/TestExpectations 2021-03-04 21:00:51 UTC (rev 273914) @@ -238,13 +238,8 @@ media/picture-in-picture/picture-in-picture-api-pip-window.html [ Timeout Pass ] # webkit.org/b/221693 -media/audio-playback-restriction-removed-track-enabled.html [ Timeout Pass ] -media/controls/inline-elements-dropoff-order.html [ Failure Pass ] media/encrypted-media/clearKey/clearKey-session-life-cycle.html [ Failure Crash ] -media/media-can-play-webm.html [ Failure ] media/media-controller-unpause.html [ Timeout ] -media/track/track-cues-pause-on-exit.html [ Timeout Pass ] -media/video-as-img-output-pts.html [ Timeout Pass ] media/video-controller-child-rate.html [ Failure Pass ] media/video-set-rate-from-pause.html [ Timeout Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273913] trunk/Tools
Title: [273913] trunk/Tools
Revision 273913
Author aakash_j...@apple.com
Date 2021-03-04 12:42:52 -0800 (Thu, 04 Mar 2021)
Log Message
[ews] Add python 3 support - part 5
https://bugs.webkit.org/show_bug.cgi?id=222744
Reviewed by Jonathan Bedard.
* CISupport/ews-build/steps.py:
(CheckPatchRelevance._patch_is_relevant): Ensure that in python 3, path and changes are bytes. This is because buildbot
stores patch as bytes, as mentioned in https://github.com/buildbot/buildbot/issues/5812#issuecomment-790175979
* CISupport/ews-build/steps_unittest.py: Updated one unit-test to test binary patch.
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (273912 => 273913)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-03-04 20:12:09 UTC (rev 273912)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-03-04 20:42:52 UTC (rev 273913)
@@ -406,6 +406,11 @@
for change in patch.splitlines():
for path in relevant_paths:
+if sys.version_info > (3, 0):
+if type(path) == str:
+path = path.encode(encoding='utf-8', errors='replace')
+if type(change) == str:
+change = change.encode(encoding='utf-8', errors='replace')
if re.search(path, change, re.IGNORECASE):
return True
return False
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (273912 => 273913)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-03-04 20:12:09 UTC (rev 273912)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-03-04 20:42:52 UTC (rev 273913)
@@ -2437,7 +2437,7 @@
return rc
def test_relevant_windows_wk1_patch(self):
-CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: Source/WebKitLegacy'
+CheckPatchRelevance._get_patch = lambda x: b'Sample patch; file: Source/WebKitLegacy'
self.setupStep(CheckPatchRelevance())
self.setProperty('buildername', 'Windows-EWS')
self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
Modified: trunk/Tools/ChangeLog (273912 => 273913)
--- trunk/Tools/ChangeLog 2021-03-04 20:12:09 UTC (rev 273912)
+++ trunk/Tools/ChangeLog 2021-03-04 20:42:52 UTC (rev 273913)
@@ -1,3 +1,15 @@
+2021-03-04 Aakash Jain
+
+[ews] Add python 3 support - part 5
+https://bugs.webkit.org/show_bug.cgi?id=222744
+
+Reviewed by Jonathan Bedard.
+
+* CISupport/ews-build/steps.py:
+(CheckPatchRelevance._patch_is_relevant): Ensure that in python 3, path and changes are bytes. This is because buildbot
+stores patch as bytes, as mentioned in https://github.com/buildbot/buildbot/issues/5812#issuecomment-790175979
+* CISupport/ews-build/steps_unittest.py: Updated one unit-test to test binary patch.
+
2021-03-04 Chris Dumez
[macOS][WK2] Changing the system language does not update navigator.language
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273912] trunk/Source/WebInspectorUI
Title: [273912] trunk/Source/WebInspectorUI
Revision 273912
Author commit-qu...@webkit.org
Date 2021-03-04 12:12:09 -0800 (Thu, 04 Mar 2021)
Log Message
Web Inspector: Persist CSS Grid overlay colors
https://bugs.webkit.org/show_bug.cgi?id=222319
Patch by Razvan Caliman on 2021-03-04
Reviewed by Devin Rousso.
Save and restore CSS Grid overlay colors edited by a user.
* UserInterface/Controllers/OverlayManager.js:
(WI.OverlayManager):
(WI.OverlayManager.prototype.showGridOverlay):
(WI.OverlayManager.prototype.getGridColorForNode):
(WI.OverlayManager.prototype.setGridColorForNode):
(WI.OverlayManager.prototype._handleMainResourceDidChange):
* UserInterface/Views/CSSGridSection.js:
(WI.CSSGridSection.prototype.layout):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/OverlayManager.js
trunk/Source/WebInspectorUI/UserInterface/Views/CSSGridSection.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (273911 => 273912)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-03-04 19:52:49 UTC (rev 273911)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-03-04 20:12:09 UTC (rev 273912)
@@ -1,5 +1,24 @@
2021-03-04 Razvan Caliman
+Web Inspector: Persist CSS Grid overlay colors
+https://bugs.webkit.org/show_bug.cgi?id=222319
+
+
+Reviewed by Devin Rousso.
+
+Save and restore CSS Grid overlay colors edited by a user.
+
+* UserInterface/Controllers/OverlayManager.js:
+(WI.OverlayManager):
+(WI.OverlayManager.prototype.showGridOverlay):
+(WI.OverlayManager.prototype.getGridColorForNode):
+(WI.OverlayManager.prototype.setGridColorForNode):
+(WI.OverlayManager.prototype._handleMainResourceDidChange):
+* UserInterface/Views/CSSGridSection.js:
+(WI.CSSGridSection.prototype.layout):
+
+2021-03-04 Razvan Caliman
+
Web Inspector: Audits Tab: nothing happens when clicking "Start" button in the content area placeholder text
https://bugs.webkit.org/show_bug.cgi?id=222740
rdar://75008042
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/OverlayManager.js (273911 => 273912)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/OverlayManager.js 2021-03-04 19:52:49 UTC (rev 273911)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/OverlayManager.js 2021-03-04 20:12:09 UTC (rev 273912)
@@ -30,11 +30,10 @@
super();
this._gridOverlayForNodeMap = new Map;
+this._nextDefaultGridColorIndex = 0;
+this._gridColorForNodeMap = new WeakMap;
+this._gridColorSettingForNodeMap = new WeakMap;
-// Can't reuse `this._gridOverlayForNodeMap` because nodes are removed from it when overlay isn't visible.
-this._colorForNodeMap = new WeakMap;
-this._nextDOMNodeColorIndex = 0;
-
WI.settings.gridOverlayShowExtendedGridLines.addEventListener(WI.Setting.Event.Changed, this._handleGridSettingChanged, this);
WI.settings.gridOverlayShowLineNames.addEventListener(WI.Setting.Event.Changed, this._handleGridSettingChanged, this);
WI.settings.gridOverlayShowLineNumbers.addEventListener(WI.Setting.Event.Changed, this._handleGridSettingChanged, this);
@@ -60,7 +59,7 @@
console.assert(!color || color instanceof WI.Color, color);
console.assert(domNode.layoutContextType === WI.DOMNode.LayoutContextType.Grid, domNode.layoutContextType);
-color ||= this.colorForNode(domNode);
+color ||= this.getGridColorForNode(domNode);
let target = WI.assumingMainTarget();
let commandArguments = {
nodeId: domNode.id,
@@ -74,10 +73,13 @@
target.DOMAgent.showGridOverlay.invoke(commandArguments);
let overlay = {domNode, ...commandArguments};
+
+// The method to show the overlay will be called repeatedly while updating the grid overlay color. Avoid adding duplicate event listeners
+if (!this._gridOverlayForNodeMap.has(domNode))
+domNode.addEventListener(WI.DOMNode.Event.LayoutContextTypeChanged, this._handleLayoutContextTypeChanged, this);
+
this._gridOverlayForNodeMap.set(domNode, overlay);
-this._colorForNodeMap.set(domNode, color);
-domNode.addEventListener(WI.DOMNode.Event.LayoutContextTypeChanged, this._handleLayoutContextTypeChanged, this);
this.dispatchEventToListeners(WI.OverlayManager.Event.GridOverlayShown, overlay);
}
@@ -113,13 +115,13 @@
this.showGridOverlay(domNode);
}
-colorForNode(domNode)
+getGridColorForNode(domNode)
{
-let color = this._colorForNodeMap.get(domNode);
+let color = this._gridColorForNodeMap.get(domNode);
if (color)
return color;
-const hslColors = [
+const defaultGridHSLColors = [
[329, 91, 70],
[207, 96, 69],
[92, 90, 64],
@@ -127,13 +129,34
[webkit-changes] [273911] branches/safari-611.1.21.1-branch/Source/WebCore
Title: [273911] branches/safari-611.1.21.1-branch/Source/WebCore Revision 273911 Author alanc...@apple.com Date 2021-03-04 11:52:49 -0800 (Thu, 04 Mar 2021) Log Message Cherry-pick r273842. rdar://problem/75049285 Crash under SubresourceLoader::notifyDone() https://bugs.webkit.org/show_bug.cgi?id=222683 Reviewed by Geoffrey Garen. We were crashing doing a null-dereference of m_documentLoader under SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader similarly to what is already done elsewhere in ResourceLoader. No new tests, I do not know how to reproduce this. * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::notifyDone): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273842 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611.1.21.1-branch/Source/WebCore/ChangeLog branches/safari-611.1.21.1-branch/Source/WebCore/loader/SubresourceLoader.cpp Diff Modified: branches/safari-611.1.21.1-branch/Source/WebCore/ChangeLog (273910 => 273911) --- branches/safari-611.1.21.1-branch/Source/WebCore/ChangeLog 2021-03-04 19:51:24 UTC (rev 273910) +++ branches/safari-611.1.21.1-branch/Source/WebCore/ChangeLog 2021-03-04 19:52:49 UTC (rev 273911) @@ -1,3 +1,42 @@ +2021-03-04 Alan Coon + +Cherry-pick r273842. rdar://problem/75049285 + +Crash under SubresourceLoader::notifyDone() +https://bugs.webkit.org/show_bug.cgi?id=222683 + + +Reviewed by Geoffrey Garen. + +We were crashing doing a null-dereference of m_documentLoader under +SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader +similarly to what is already done elsewhere in ResourceLoader. + +No new tests, I do not know how to reproduce this. + +* loader/SubresourceLoader.cpp: +(WebCore::SubresourceLoader::notifyDone): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273842 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-03-03 Chris Dumez + +Crash under SubresourceLoader::notifyDone() +https://bugs.webkit.org/show_bug.cgi?id=222683 + + +Reviewed by Geoffrey Garen. + +We were crashing doing a null-dereference of m_documentLoader under +SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader +similarly to what is already done elsewhere in ResourceLoader. + +No new tests, I do not know how to reproduce this. + +* loader/SubresourceLoader.cpp: +(WebCore::SubresourceLoader::notifyDone): + 2021-03-03 Ruben Turcios Cherry-pick r273764. rdar://problem/74992878 Modified: branches/safari-611.1.21.1-branch/Source/WebCore/loader/SubresourceLoader.cpp (273910 => 273911) --- branches/safari-611.1.21.1-branch/Source/WebCore/loader/SubresourceLoader.cpp 2021-03-04 19:51:24 UTC (rev 273910) +++ branches/safari-611.1.21.1-branch/Source/WebCore/loader/SubresourceLoader.cpp 2021-03-04 19:52:49 UTC (rev 273911) @@ -842,10 +842,12 @@ if (m_state == CancelledWhileInitializing) shouldPerformPostLoadActions = false; #endif -m_documentLoader->cachedResourceLoader().loadDone(type, shouldPerformPostLoadActions); +if (m_documentLoader) +m_documentLoader->cachedResourceLoader().loadDone(type, shouldPerformPostLoadActions); if (reachedTerminalState()) return; -m_documentLoader->removeSubresourceLoader(type, this); +if (m_documentLoader) +m_documentLoader->removeSubresourceLoader(type, this); } void SubresourceLoader::releaseResources() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273910] branches/safari-611.1.21.1-branch/Source
Title: [273910] branches/safari-611.1.21.1-branch/Source Revision 273910 Author alanc...@apple.com Date 2021-03-04 11:51:24 -0800 (Thu, 04 Mar 2021) Log Message Versioning. WebKit-7611.1.21.1.5 Modified Paths branches/safari-611.1.21.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-611.1.21.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-611.1.21.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-611.1.21.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-611.1.21.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-611.1.21.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-611.1.21.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-611.1.21.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-611.1.21.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273909 => 273910) --- branches/safari-611.1.21.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-03-04 19:46:00 UTC (rev 273909) +++ branches/safari-611.1.21.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-03-04 19:51:24 UTC (rev 273910) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273909 => 273910) --- branches/safari-611.1.21.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-03-04 19:46:00 UTC (rev 273909) +++ branches/safari-611.1.21.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-03-04 19:51:24 UTC (rev 273910) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273909 => 273910) --- branches/safari-611.1.21.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-03-04 19:46:00 UTC (rev 273909) +++ branches/safari-611.1.21.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-03-04 19:51:24 UTC (rev 273910) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.1-branch/Source/WebCore/Configurations/Version.xcconfig (273909 => 273910) --- branches/safari-611.1.21.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-03-04 19:46:00 UTC (rev 273909) +++ branches/safari-611.1.21.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-03-04 19:51:24 UTC (rev 273910) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273909 => 273910) --- branches/safari-611.1.21.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-03-04 19:46:00 UTC (rev 273909) +++ branches/safari-611.1.21.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-03-04 19:51:24 UTC (rev 273910) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (273909 => 273910) --- branches/safari-611.1.21.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-03-04 19:46:00 UTC (rev 273909) +++ branches/safari-611.1.21.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-03-04 19:51:24 UTC (rev 273910) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION =
[webkit-changes] [273909] branches/safari-611.1.21.0-branch/Source/WebCore
Title: [273909] branches/safari-611.1.21.0-branch/Source/WebCore Revision 273909 Author alanc...@apple.com Date 2021-03-04 11:46:00 -0800 (Thu, 04 Mar 2021) Log Message Cherry-pick r273842. rdar://problem/75049263 Crash under SubresourceLoader::notifyDone() https://bugs.webkit.org/show_bug.cgi?id=222683 Reviewed by Geoffrey Garen. We were crashing doing a null-dereference of m_documentLoader under SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader similarly to what is already done elsewhere in ResourceLoader. No new tests, I do not know how to reproduce this. * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::notifyDone): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273842 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-611.1.21.0-branch/Source/WebCore/ChangeLog branches/safari-611.1.21.0-branch/Source/WebCore/loader/SubresourceLoader.cpp Diff Modified: branches/safari-611.1.21.0-branch/Source/WebCore/ChangeLog (273908 => 273909) --- branches/safari-611.1.21.0-branch/Source/WebCore/ChangeLog 2021-03-04 19:44:26 UTC (rev 273908) +++ branches/safari-611.1.21.0-branch/Source/WebCore/ChangeLog 2021-03-04 19:46:00 UTC (rev 273909) @@ -1,3 +1,42 @@ +2021-03-04 Alan Coon + +Cherry-pick r273842. rdar://problem/75049263 + +Crash under SubresourceLoader::notifyDone() +https://bugs.webkit.org/show_bug.cgi?id=222683 + + +Reviewed by Geoffrey Garen. + +We were crashing doing a null-dereference of m_documentLoader under +SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader +similarly to what is already done elsewhere in ResourceLoader. + +No new tests, I do not know how to reproduce this. + +* loader/SubresourceLoader.cpp: +(WebCore::SubresourceLoader::notifyDone): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273842 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-03-03 Chris Dumez + +Crash under SubresourceLoader::notifyDone() +https://bugs.webkit.org/show_bug.cgi?id=222683 + + +Reviewed by Geoffrey Garen. + +We were crashing doing a null-dereference of m_documentLoader under +SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader +similarly to what is already done elsewhere in ResourceLoader. + +No new tests, I do not know how to reproduce this. + +* loader/SubresourceLoader.cpp: +(WebCore::SubresourceLoader::notifyDone): + 2021-03-02 Russell Epstein Apply patch. rdar://problem/74944257 Modified: branches/safari-611.1.21.0-branch/Source/WebCore/loader/SubresourceLoader.cpp (273908 => 273909) --- branches/safari-611.1.21.0-branch/Source/WebCore/loader/SubresourceLoader.cpp 2021-03-04 19:44:26 UTC (rev 273908) +++ branches/safari-611.1.21.0-branch/Source/WebCore/loader/SubresourceLoader.cpp 2021-03-04 19:46:00 UTC (rev 273909) @@ -842,10 +842,12 @@ if (m_state == CancelledWhileInitializing) shouldPerformPostLoadActions = false; #endif -m_documentLoader->cachedResourceLoader().loadDone(type, shouldPerformPostLoadActions); +if (m_documentLoader) +m_documentLoader->cachedResourceLoader().loadDone(type, shouldPerformPostLoadActions); if (reachedTerminalState()) return; -m_documentLoader->removeSubresourceLoader(type, this); +if (m_documentLoader) +m_documentLoader->removeSubresourceLoader(type, this); } void SubresourceLoader::releaseResources() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273908] branches/safari-611.1.21.0-branch/Source
Title: [273908] branches/safari-611.1.21.0-branch/Source Revision 273908 Author alanc...@apple.com Date 2021-03-04 11:44:26 -0800 (Thu, 04 Mar 2021) Log Message Versioning. WebKit-7611.1.21.0.4 Modified Paths branches/safari-611.1.21.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-611.1.21.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-611.1.21.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-611.1.21.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-611.1.21.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-611.1.21.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-611.1.21.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-611.1.21.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-611.1.21.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273907 => 273908) --- branches/safari-611.1.21.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-03-04 19:41:56 UTC (rev 273907) +++ branches/safari-611.1.21.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-03-04 19:44:26 UTC (rev 273908) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 0; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273907 => 273908) --- branches/safari-611.1.21.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-03-04 19:41:56 UTC (rev 273907) +++ branches/safari-611.1.21.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-03-04 19:44:26 UTC (rev 273908) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 0; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273907 => 273908) --- branches/safari-611.1.21.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-03-04 19:41:56 UTC (rev 273907) +++ branches/safari-611.1.21.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-03-04 19:44:26 UTC (rev 273908) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 0; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.0-branch/Source/WebCore/Configurations/Version.xcconfig (273907 => 273908) --- branches/safari-611.1.21.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-03-04 19:41:56 UTC (rev 273907) +++ branches/safari-611.1.21.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-03-04 19:44:26 UTC (rev 273908) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 0; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273907 => 273908) --- branches/safari-611.1.21.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-03-04 19:41:56 UTC (rev 273907) +++ branches/safari-611.1.21.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-03-04 19:44:26 UTC (rev 273908) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 0; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.1.21.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (273907 => 273908) --- branches/safari-611.1.21.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-03-04 19:41:56 UTC (rev 273907) +++ branches/safari-611.1.21.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-03-04 19:44:26 UTC (rev 273908) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 21; MICRO_VERSION = 0; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION =
[webkit-changes] [273907] trunk/Source/WebKit
Title: [273907] trunk/Source/WebKit
Revision 273907
Author cdu...@apple.com
Date 2021-03-04 11:41:56 -0800 (Thu, 04 Mar 2021)
Log Message
Unreviewed build fix after r272629.
* UIProcess/Cocoa/WKBlankOverlayView.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WKBlankOverlayView.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (273906 => 273907)
--- trunk/Source/WebKit/ChangeLog 2021-03-04 19:40:02 UTC (rev 273906)
+++ trunk/Source/WebKit/ChangeLog 2021-03-04 19:41:56 UTC (rev 273907)
@@ -1,5 +1,11 @@
2021-03-04 Chris Dumez
+Unreviewed build fix after r272629.
+
+* UIProcess/Cocoa/WKBlankOverlayView.mm:
+
+2021-03-04 Chris Dumez
+
[macOS][WK2] Changing the system language does not update navigator.language
https://bugs.webkit.org/show_bug.cgi?id=222619
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKBlankOverlayView.mm (273906 => 273907)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKBlankOverlayView.mm 2021-03-04 19:40:02 UTC (rev 273906)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKBlankOverlayView.mm 2021-03-04 19:41:56 UTC (rev 273907)
@@ -24,7 +24,7 @@
*/
#import "config.h"
-#import "WKBlankOverlayView.mm"
+#import "WKBlankOverlayView.h"
@implementation WKBlankOverlayView {
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273906] trunk/Source/JavaScriptCore
Title: [273906] trunk/Source/_javascript_Core
Revision 273906
Author achristen...@apple.com
Date 2021-03-04 11:40:02 -0800 (Thu, 04 Mar 2021)
Log Message
[Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
https://bugs.webkit.org/show_bug.cgi?id=222610
Reviewed by Chris Dumez.
* inspector/scripts/codegen/objc_generator.py:
(ObjCGenerator.objc_protocol_import_expression_for_member):
(ObjCGenerator.objc_protocol_import_expression_for_parameter):
(ObjCGenerator.protocol_to_objc_expression_for_member):
(ObjCGenerator.payload_to_objc_expression_for_member):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (273905 => 273906)
--- trunk/Source/_javascript_Core/ChangeLog 2021-03-04 19:30:12 UTC (rev 273905)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-03-04 19:40:02 UTC (rev 273906)
@@ -1,3 +1,16 @@
+2021-03-04 Alex Christensen
+
+[Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
+https://bugs.webkit.org/show_bug.cgi?id=222610
+
+Reviewed by Chris Dumez.
+
+* inspector/scripts/codegen/objc_generator.py:
+(ObjCGenerator.objc_protocol_import_expression_for_member):
+(ObjCGenerator.objc_protocol_import_expression_for_parameter):
+(ObjCGenerator.protocol_to_objc_expression_for_member):
+(ObjCGenerator.payload_to_objc_expression_for_member):
+
2021-03-03 Devin Rousso
Web Inspector: `RecordCanvasActionVariant` causes a huge symbol to be created in WebCore
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py (273905 => 273906)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py 2021-03-04 19:30:12 UTC (rev 273905)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py 2021-03-04 19:40:02 UTC (rev 273906)
@@ -390,13 +390,13 @@
def objc_protocol_import_expression_for_member(self, name, declaration, member):
if isinstance(member.type, EnumType):
if member.type.is_anonymous:
-return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), name)
-return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), name)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), name)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(member.type), name)
return self.objc_protocol_import_expression_for_variable(member.type, name)
def objc_protocol_import_expression_for_parameter(self, name, domain, event_or_command_name, parameter):
if isinstance(parameter.type, EnumType):
-return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_non_anonymous_enum(parameter.type), name)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(parameter.type), name)
return self.objc_protocol_import_expression_for_variable(parameter.type, name)
def objc_protocol_import_expression_for_variable(self, var_type, var_name):
@@ -442,8 +442,8 @@
if category in [ObjCTypeCategory.Simple, ObjCTypeCategory.String]:
if isinstance(member.type, EnumType):
if member.type.is_anonymous:
-return 'fromProtocolString<%s>(%s).value()' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
-return 'fromProtocolString<%s>(%s).value()' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s).value()' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s).value()' % (self.objc_enum_name_for_non_anonymous_enum(member.type), sub_expression)
return sub_expression
if category == ObjCTypeCategory.Object:
raise Exception("protocol_to_objc_expression_for_member does not support an Object type. See: protocol_to_objc_code_block_for_object_member")
@@ -487,9 +487,9 @@
if isinstance(member.type, EnumType):
sub_expression = 'payload[@"%s"]' % member.member_name
if member.type.is_anonymous:
-return 'fromProtocolString<%s>(%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
+return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_anonymous_enum_member(declaration, member), sub_expression)
else:
-
[webkit-changes] [273905] trunk
Title: [273905] trunk Revision 273905 Author you...@apple.com Date 2021-03-04 11:30:12 -0800 (Thu, 04 Mar 2021) Log Message In case of POST navigation redirected by a 302, the 'Origin' header is kept in the redirected request https://bugs.webkit.org/show_bug.cgi?id=222653 Reviewed by Alex Christensen. Source/WebCore: Remove Origin header if the navigation request goes from POST to GET. This aligns with other browsers and removes some known interop issues. This is consistent with WebKit not sending Origin headers for GET navigations. Test: http/wpt/fetch/navigation-post-to-get-origin.html * loader/DocumentLoader.cpp: (WebCore::isRedirectToGetAfterPost): (WebCore::DocumentLoader::willSendRequest): LayoutTests: * http/wpt/fetch/echo-origin.py: Added. * http/wpt/fetch/navigation-post-to-get-origin-expected.txt: Added. * http/wpt/fetch/navigation-post-to-get-origin.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentLoader.cpp Added Paths trunk/LayoutTests/http/wpt/fetch/navigation-post-to-get-origin-expected.txt trunk/LayoutTests/http/wpt/fetch/navigation-post-to-get-origin.html trunk/LayoutTests/http/wpt/fetch/resources/echo-origin.py Diff Modified: trunk/LayoutTests/ChangeLog (273904 => 273905) --- trunk/LayoutTests/ChangeLog 2021-03-04 19:02:27 UTC (rev 273904) +++ trunk/LayoutTests/ChangeLog 2021-03-04 19:30:12 UTC (rev 273905) @@ -1,3 +1,15 @@ +2021-03-04 Youenn Fablet + +In case of POST navigation redirected by a 302, the 'Origin' header is kept in the redirected request +https://bugs.webkit.org/show_bug.cgi?id=222653 + + +Reviewed by Alex Christensen. + +* http/wpt/fetch/echo-origin.py: Added. +* http/wpt/fetch/navigation-post-to-get-origin-expected.txt: Added. +* http/wpt/fetch/navigation-post-to-get-origin.html: Added. + 2021-03-04 Said Abou-Hallawa Followup (r273764): Use different container sizes in background-svg-image-loading.html Added: trunk/LayoutTests/http/wpt/fetch/navigation-post-to-get-origin-expected.txt (0 => 273905) --- trunk/LayoutTests/http/wpt/fetch/navigation-post-to-get-origin-expected.txt (rev 0) +++ trunk/LayoutTests/http/wpt/fetch/navigation-post-to-get-origin-expected.txt 2021-03-04 19:30:12 UTC (rev 273905) @@ -0,0 +1,8 @@ + + + + + +PASS No origin header after POST submission and 302 redirection +PASS No origin header after POST submission and 303 redirection + Added: trunk/LayoutTests/http/wpt/fetch/navigation-post-to-get-origin.html (0 => 273905) --- trunk/LayoutTests/http/wpt/fetch/navigation-post-to-get-origin.html (rev 0) +++ trunk/LayoutTests/http/wpt/fetch/navigation-post-to-get-origin.html 2021-03-04 19:30:12 UTC (rev 273905) @@ -0,0 +1,32 @@ + + + + +Navigation and POST to GET redirect + + ++