date:20210622

[webkit-changes] [279164] trunk/Source

2021-06-22 Thread wenson_hsieh

Title: [279164] trunk/Source








Revision 279164
Author wenson_hs...@apple.com
Date 2021-06-22 18:32:54 -0700 (Tue, 22 Jun 2021)


Log Message
[Live Text] [macOS] Add an internal option to disable inline text selection in images
https://bugs.webkit.org/show_bug.cgi?id=227265
rdar://79460142

Reviewed by Tim Horton.

Source/WebCore:

Add support for the new feature flag. See WebKit/ChangeLog for more details.

* en.lproj/Localizable.strings:

Add additional localizable strings to represent each of the possible titles for the "Quick Look"/"Look Up"
context menu item. When inline text selection is enabled, the item shows up as "Look Up", and is only added if
we actually discover visual search results.

However, when inline text selection is disabled, this item will always be added to the context menu under the
title "Quick Look", and will be retitled to either "Look Up in Quick Look" or "Select Text in Quick Look" once
either visual search results or text is recognized, respectively.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):

In the case where inline text selection is disabled, add the Quick Look item to the end of the context menu,
after a separator. Note that in the case where inline text selection is enabled, it doesn't actually matter
where we add this item, since it is automatically removed and only reinserted if we find visual search results
for the image.

(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

Rename the existing ContextMenuItemTagLookUpImage to ContextMenuItemTagQuickLookImage, since it is no longer
limited to the visual look up feature.

* page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):

Consult the feature flag and avoid kicking off the text recognition timer if inline text selection is disabled.

* platform/ContextMenuItem.cpp:
(WebCore::isValidContextMenuAction):
* platform/ContextMenuItem.h:
* platform/LocalizedStrings.h:
* platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::contextMenuItemTagQuickLookImage):
(WebCore::contextMenuItemTagQuickLookImageForTextSelection):
(WebCore::contextMenuItemTagQuickLookImageForVisualSearch):

Source/WebKit:

Refactor Live Text and Visual Look Up logic, such that the ability to select text inside of images is behind an
internal feature flag that can be toggled at runtime. When Live Text is disabled, we'll unconditionally show the
"Look Up" context menu action using the more generic title "Quick Look". This "Quick Look" action is then
retitled to either "Look Up in Quick Look" or "Select Text in Quick Look" once image analysis completes.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):

Rename ContextMenuItemTagLookUpImage to ContextMenuItemTagQuickLookImage.

* UIProcess/Cocoa/QuickLookPreviewActivity.h: Copied from Source/WebKit/UIProcess/mac/WKQuickLookPreviewController.h.

Move this enum out of WKQuickLookPreviewController.h, such that we can use and import it in non-Cocoa headers
and implementation files.

* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::computeHasImageAnalysisResults):

Rename `computeHasVisualSearchResults` to `computeHasImageAnalysisResults`, and allow it to take a flag to
indicate whether or not it should request text recognition results or visual search results. We use this for the
"Quick Look" context menu action when inline text selection is disabled, in order to retitle the item to "Select
Text in Quick Look".

(WebKit::WebViewImpl::computeHasVisualSearchResults): Deleted.
* UIProcess/PageClient.h:
(WebKit::PageClient::computeHasImageAnalysisResults):
(WebKit::PageClient::computeHasVisualSearchResults): Deleted.
* UIProcess/WebContextMenuProxy.h:
(WebKit::WebContextMenuProxy::quickLookPreviewActivity const):

Add a flag to WebContextMenuProxy to determine what initial activity to use when presenting the QuickLook
preview panel after selecting the ContextMenuItemTagQuickLookImage item.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::computeHasImageAnalysisResults):
(WebKit::WebPageProxy::computeHasVisualSearchResults): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/PageClientImplMac.h:
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::computeHasImageAnalysisResults):
(WebKit::PageClientImpl::computeHasVisualSearchResults): Deleted.
* UIProcess/mac/WKQuickLookPreviewController.h:
* UIProcess/mac/WKQuickLookPreviewController.mm:
* UIProcess/mac/WebContextMenuProxyMac.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

Add logic to either remove and reinsert the "Look Up" context menu action (if inline text selection in images is
enabled), or to promote the "Quick Look" context menu action to either "Select Text in Quick Look" or "Look Up
in Quick Look" in the case where

[webkit-changes] [279163] tags/Safari-611.3.10.1.1/

2021-06-22 Thread repstein

Title: [279163] tags/Safari-611.3.10.1.1/








Revision 279163
Author repst...@apple.com
Date 2021-06-22 18:19:44 -0700 (Tue, 22 Jun 2021)


Log Message
Tag Safari-611.3.10.1.1.

Added Paths

tags/Safari-611.3.10.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279161] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ Source/webrtc/sdk/WebKit/WebKitDecoder.h

2021-06-22 Thread repstein

Title: [279161] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h








Revision 279161
Author repst...@apple.com
Date 2021-06-22 18:16:57 -0700 (Tue, 22 Jun 2021)


Log Message
Revert "Unreviewed build fix. rdar://problem/79474211"

This reverts commit r279157.

Modified Paths

branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h




Diff

Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h (279160 => 279161)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-23 01:00:31 UTC (rev 279160)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-23 01:16:57 UTC (rev 279161)
@@ -33,7 +33,7 @@
 
 namespace webrtc {
 
-#if (TARGET_OS_OSX || TARGET_OS_MACCATALYST) && defined(__x86_64__) 
+#if (TARGET_OS_OSX || TARGET_OS_MACCATALYST) && TARGET_CPU_X86_64
 #define CMBASE_OBJECT_NEEDS_ALIGNMENT 1
 #else
 #define CMBASE_OBJECT_NEEDS_ALIGNMENT 0






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279162] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc

2021-06-22 Thread repstein

Title: [279162] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc








Revision 279162
Author repst...@apple.com
Date 2021-06-22 18:16:59 -0700 (Tue, 22 Jun 2021)


Log Message
Revert "Revert "Revert r279101. rdar://problem/79474211""

This reverts commit r279156.

Modified Paths

branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp




Diff

Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog (279161 => 279162)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-23 01:16:57 UTC (rev 279161)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-23 01:16:59 UTC (rev 279162)
@@ -1,46 +1,5 @@
 2021-06-22  Russell Epstein  
 
-Cherry-pick r279101. rdar://problem/79474211
-
-[Mac] libwebrtc CMBaseClass objects need alignment fixup
-https://bugs.webkit.org/show_bug.cgi?id=227137
-
-
-Reviewed by Youenn Fablet.
-
-* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.
-
-* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
-(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
-Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
-Add static_asserts to ensure alignment and sizes are correct.
-
-* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
-(webrtc::createWebKitVP9Decoder): Ditto.
-
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2021-06-21  Eric Carlson  
-
-[Mac] libwebrtc CMBaseClass objects need alignment fixup
-https://bugs.webkit.org/show_bug.cgi?id=227137
-
-
-Reviewed by Youenn Fablet.
-
-* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.
-
-* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
-(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
-Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
-Add static_asserts to ensure alignment and sizes are correct.
-
-* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
-(webrtc::createWebKitVP9Decoder): Ditto.
-
-2021-06-22  Russell Epstein  
-
 Cherry-pick r278906. rdar://problem/79581492
 
 Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h (279161 => 279162)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-23 01:16:57 UTC (rev 279161)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-23 01:16:59 UTC (rev 279162)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
+ * Copyright (C) 2020 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -25,7 +25,6 @@
 
 #pragma once
 
-#include 
 #include "WebKitUtilities.h"
 #include "api/video_codecs/video_decoder_factory.h"
 
@@ -33,12 +32,6 @@
 
 namespace webrtc {
 
-#if (TARGET_OS_OSX || TARGET_OS_MACCATALYST) && TARGET_CPU_X86_64
-#define CMBASE_OBJECT_NEEDS_ALIGNMENT 1
-#else
-#define CMBASE_OBJECT_NEEDS_ALIGNMENT 0
-#endif
-
 struct SdpVideoFormat;
 class VideoDecoderFactory;
 
@@ -53,6 +46,7 @@
 std::unique_ptr createWebKitDecoderFactory(WebKitH265, WebKitVP9, WebKitVP9VTB);
 void videoDecoderTaskComplete(void* callback, uint32_t timeStamp, CVPixelBufferRef, uint32_t timeStampRTP);
 
+
 using LocalDecoder = void*;
 using LocalDecoderCallback = void (^)(CVPixelBufferRef, uint32_t timeStamp, uint32_t timeStampNs);
 void* createLocalH264Decoder(LocalDecoderCallback);


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp (279161 => 279162)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp	2021-06-23 01:16:57 UTC (rev 279161)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp	2021-06-23 01:16:59 UTC (rev 279162)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
+ * Copyright (C) 2020 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms,

[webkit-changes] [279160] tags/Safari-611.3.8.1.1/

2021-06-22 Thread alancoon

Title: [279160] tags/Safari-611.3.8.1.1/








Revision 279160
Author alanc...@apple.com
Date 2021-06-22 18:00:31 -0700 (Tue, 22 Jun 2021)


Log Message
Tag Safari-611.3.8.1.1.

Added Paths

tags/Safari-611.3.8.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279159] tags/Safari-612.1.18.1.4/

2021-06-22 Thread repstein

Title: [279159] tags/Safari-612.1.18.1.4/








Revision 279159
Author repst...@apple.com
Date 2021-06-22 17:43:38 -0700 (Tue, 22 Jun 2021)


Log Message
Tag Safari-612.1.18.1.4.

Added Paths

tags/Safari-612.1.18.1.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279158] trunk/LayoutTests

2021-06-22 Thread amir_mark

Title: [279158] trunk/LayoutTests








Revision 279158
Author amir_m...@apple.com
Date 2021-06-22 17:27:09 -0700 (Tue, 22 Jun 2021)


Log Message
[Catalina WK2 Debug/ iOS 14 Debug] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=227273

Unrevieweed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279157 => 279158)

--- trunk/LayoutTests/ChangeLog	2021-06-22 23:52:08 UTC (rev 279157)
+++ trunk/LayoutTests/ChangeLog	2021-06-23 00:27:09 UTC (rev 279158)
@@ -1,3 +1,13 @@
+2021-06-22  Amir Mark Jr  
+
+[Catalina WK2 Debug/ iOS 14 Debug] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=227273
+
+Unrevieweed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2021-06-22  Per Arne Vollan  
 
 [macOS] Deny mach-lookup to the service 'com.apple.print.normalizerd'


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (279157 => 279158)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-06-22 23:52:08 UTC (rev 279157)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-06-23 00:27:09 UTC (rev 279158)
@@ -1938,4 +1938,6 @@
 webkit.org/b/225686 imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-snap-root-001.html [ ImageOnlyFailure ]
 webkit.org/b/225686 imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-snap-root-002.html [ ImageOnlyFailure ]
 
-webkit.org/b/226826 http/tests/ssl/applepay/ApplePayButton.html [ Failure ]
\ No newline at end of file
+webkit.org/b/226826 http/tests/ssl/applepay/ApplePayButton.html [ Failure ]
+
+webkit.org/b/227273 fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ Pass Timeout ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (279157 => 279158)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-06-22 23:52:08 UTC (rev 279157)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-06-23 00:27:09 UTC (rev 279158)
@@ -1375,3 +1375,5 @@
 
 webkit.org/b/226783 [ arm64 ] http/tests/contentextensions/plugin-doesnt-crash.html [ Skip ]
 webkit.org/b/226783 [ arm64 ] tiled-drawing/scrolling/non-fast-region/wheel-event-plugin.html [ Skip ]
+
+webkit.org/b/227273 [ Catalina Debug ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279157] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ Source/webrtc/sdk/WebKit/WebKitDecoder.h

2021-06-22 Thread repstein

Title: [279157] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h








Revision 279157
Author repst...@apple.com
Date 2021-06-22 16:52:08 -0700 (Tue, 22 Jun 2021)


Log Message
Unreviewed build fix. rdar://problem/79474211

Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:82:5: error: static_assert failed due to requirement 'sizeof (WebKitVP8Decoder_BaseClass.alignedClass.version) == sizeof(unsigned long)'

Modified Paths

branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h




Diff

Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h (279156 => 279157)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-22 23:52:06 UTC (rev 279156)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-22 23:52:08 UTC (rev 279157)
@@ -33,7 +33,7 @@
 
 namespace webrtc {
 
-#if (TARGET_OS_OSX || TARGET_OS_MACCATALYST) && TARGET_CPU_X86_64
+#if (TARGET_OS_OSX || TARGET_OS_MACCATALYST) && defined(__x86_64__) 
 #define CMBASE_OBJECT_NEEDS_ALIGNMENT 1
 #else
 #define CMBASE_OBJECT_NEEDS_ALIGNMENT 0






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279156] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc

2021-06-22 Thread repstein

Title: [279156] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc








Revision 279156
Author repst...@apple.com
Date 2021-06-22 16:52:06 -0700 (Tue, 22 Jun 2021)


Log Message
Revert "Revert r279101. rdar://problem/79474211"

This reverts commit r279154.

Modified Paths

branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp




Diff

Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog (279155 => 279156)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 23:48:33 UTC (rev 279155)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 23:52:06 UTC (rev 279156)
@@ -1,5 +1,46 @@
 2021-06-22  Russell Epstein  
 
+Cherry-pick r279101. rdar://problem/79474211
+
+[Mac] libwebrtc CMBaseClass objects need alignment fixup
+https://bugs.webkit.org/show_bug.cgi?id=227137
+
+
+Reviewed by Youenn Fablet.
+
+* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.
+
+* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
+(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
+Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
+Add static_asserts to ensure alignment and sizes are correct.
+
+* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
+(webrtc::createWebKitVP9Decoder): Ditto.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-21  Eric Carlson  
+
+[Mac] libwebrtc CMBaseClass objects need alignment fixup
+https://bugs.webkit.org/show_bug.cgi?id=227137
+
+
+Reviewed by Youenn Fablet.
+
+* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.
+
+* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
+(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
+Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
+Add static_asserts to ensure alignment and sizes are correct.
+
+* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
+(webrtc::createWebKitVP9Decoder): Ditto.
+
+2021-06-22  Russell Epstein  
+
 Cherry-pick r278906. rdar://problem/79581492
 
 Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h (279155 => 279156)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-22 23:48:33 UTC (rev 279155)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-22 23:52:06 UTC (rev 279156)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -25,6 +25,7 @@
 
 #pragma once
 
+#include 
 #include "WebKitUtilities.h"
 #include "api/video_codecs/video_decoder_factory.h"
 
@@ -32,6 +33,12 @@
 
 namespace webrtc {
 
+#if (TARGET_OS_OSX || TARGET_OS_MACCATALYST) && TARGET_CPU_X86_64
+#define CMBASE_OBJECT_NEEDS_ALIGNMENT 1
+#else
+#define CMBASE_OBJECT_NEEDS_ALIGNMENT 0
+#endif
+
 struct SdpVideoFormat;
 class VideoDecoderFactory;
 
@@ -46,7 +53,6 @@
 std::unique_ptr createWebKitDecoderFactory(WebKitH265, WebKitVP9, WebKitVP9VTB);
 void videoDecoderTaskComplete(void* callback, uint32_t timeStamp, CVPixelBufferRef, uint32_t timeStampRTP);
 
-
 using LocalDecoder = void*;
 using LocalDecoderCallback = void (^)(CVPixelBufferRef, uint32_t timeStamp, uint32_t timeStampNs);
 void* createLocalH264Decoder(LocalDecoderCallback);


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp (279155 => 279156)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp	2021-06-22 23:48:33 UTC (rev 279155)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp	2021-06-22 23:52:06 UTC (rev 279156)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or

[webkit-changes] [279155] trunk/Source/WebKit

2021-06-22 Thread cdumez

Title: [279155] trunk/Source/WebKit








Revision 279155
Author cdu...@apple.com
Date 2021-06-22 16:48:33 -0700 (Tue, 22 Jun 2021)


Log Message
[macOS] Suspend WebProcesses that are in the process cache
https://bugs.webkit.org/show_bug.cgi?id=227269

Reviewed by Geoffrey Garen.

Suspend WebProcesses that are in the process cache on macOS to make sure they use no CPU.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setIsInProcessCache):
(WebKit::WebProcessProxy::platformSuspendProcess):
(WebKit::WebProcessProxy::platformResumeProcess):
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::platformSuspendProcess):
(WebKit::WebProcessProxy::platformResumeProcess):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setIsInProcessCache):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/WebProcess.messages.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (279154 => 279155)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 22:06:54 UTC (rev 279154)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 23:48:33 UTC (rev 279155)
@@ -1,3 +1,25 @@
+2021-06-22  Chris Dumez  
+
+[macOS] Suspend WebProcesses that are in the process cache
+https://bugs.webkit.org/show_bug.cgi?id=227269
+
+Reviewed by Geoffrey Garen.
+
+Suspend WebProcesses that are in the process cache on macOS to make sure they use no CPU.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::setIsInProcessCache):
+(WebKit::WebProcessProxy::platformSuspendProcess):
+(WebKit::WebProcessProxy::platformResumeProcess):
+* UIProcess/WebProcessProxy.h:
+* UIProcess/mac/WebProcessProxyMac.mm:
+(WebKit::WebProcessProxy::platformSuspendProcess):
+(WebKit::WebProcessProxy::platformResumeProcess):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::setIsInProcessCache):
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+
 2021-06-22  Jer Noble  
 
 Further unreviewed build fix after r279133: remove even more things.


Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (279154 => 279155)

--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2021-06-22 22:06:54 UTC (rev 279154)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2021-06-22 23:48:33 UTC (rev 279155)
@@ -283,8 +283,14 @@
 ASSERT(m_isInProcessCache != value);
 m_isInProcessCache = value;
 
-send(Messages::WebProcess::SetIsInProcessCache(m_isInProcessCache), 0);
+if (!m_isInProcessCache)
+platformResumeProcess();
 
+sendWithAsyncReply(Messages::WebProcess::SetIsInProcessCache(m_isInProcessCache), [weakThis = makeWeakPtr(*this), isEnteringProcessCache = value]() mutable {
+if (isEnteringProcessCache && weakThis && weakThis->m_isInProcessCache)
+weakThis->platformSuspendProcess();
+});
+
 if (m_isInProcessCache) {
 // WebProcessProxy objects normally keep the process pool alive but we do not want this to be the case
 // for cached processes or it would leak the pool.
@@ -1954,6 +1960,16 @@
 PAL::systemBeep();
 }
 
+#if !PLATFORM(MAC)
+void WebProcessProxy::platformSuspendProcess()
+{
+}
+
+void WebProcessProxy::platformResumeProcess()
+{
+}
+#endif
+
 } // namespace WebKit
 
 #undef MESSAGE_CHECK


Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.h (279154 => 279155)

--- trunk/Source/WebKit/UIProcess/WebProcessProxy.h	2021-06-22 22:06:54 UTC (rev 279154)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.h	2021-06-22 23:48:33 UTC (rev 279155)
@@ -471,6 +471,9 @@
 
 void processDidTerminateOrFailedToLaunch(ProcessTerminationReason);
 
+void platformSuspendProcess();
+void platformResumeProcess();
+
 // IPC::Connection::Client
 friend class WebConnectionToWebProcess;
 void didReceiveMessage(IPC::Connection&, IPC::Decoder&) override;


Modified: trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm (279154 => 279155)

--- trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm	2021-06-22 22:06:54 UTC (rev 279154)
+++ trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm	2021-06-22 23:48:33 UTC (rev 279155)
@@ -31,6 +31,7 @@
 
 #import "WKFullKeyboardAccessWatcher.h"
 #import 
+#import 
 #import 
 #import 
 
@@ -78,6 +79,24 @@
 processPool().setDisplayLinkPreferredFramesPerSecond(*connection(), observerID, displayID, preferredFramesPerSecond);
 }
 
+void WebProcessProxy::platformSuspendProcess()
+{
+RELEASE_LOG(Process, "%p - [PID=%i] WebProcessProxy::platformSuspendProcess", this, processIdentifier());
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN

[webkit-changes] [279154] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc

2021-06-22 Thread alancoon

Title: [279154] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc








Revision 279154
Author alanc...@apple.com
Date 2021-06-22 15:06:54 -0700 (Tue, 22 Jun 2021)


Log Message
Revert r279101. rdar://problem/79474211

This reverts commit r279141.

Modified Paths

branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp




Diff

Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog (279153 => 279154)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 22:00:49 UTC (rev 279153)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 22:06:54 UTC (rev 279154)
@@ -1,46 +1,5 @@
 2021-06-22  Russell Epstein  
 
-Cherry-pick r279101. rdar://problem/79474211
-
-[Mac] libwebrtc CMBaseClass objects need alignment fixup
-https://bugs.webkit.org/show_bug.cgi?id=227137
-
-
-Reviewed by Youenn Fablet.
-
-* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.
-
-* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
-(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
-Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
-Add static_asserts to ensure alignment and sizes are correct.
-
-* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
-(webrtc::createWebKitVP9Decoder): Ditto.
-
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2021-06-21  Eric Carlson  
-
-[Mac] libwebrtc CMBaseClass objects need alignment fixup
-https://bugs.webkit.org/show_bug.cgi?id=227137
-
-
-Reviewed by Youenn Fablet.
-
-* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.
-
-* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
-(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
-Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
-Add static_asserts to ensure alignment and sizes are correct.
-
-* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
-(webrtc::createWebKitVP9Decoder): Ditto.
-
-2021-06-22  Russell Epstein  
-
 Cherry-pick r278906. rdar://problem/79581492
 
 Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h (279153 => 279154)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-22 22:00:49 UTC (rev 279153)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-22 22:06:54 UTC (rev 279154)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
+ * Copyright (C) 2020 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -25,7 +25,6 @@
 
 #pragma once
 
-#include 
 #include "WebKitUtilities.h"
 #include "api/video_codecs/video_decoder_factory.h"
 
@@ -33,12 +32,6 @@
 
 namespace webrtc {
 
-#if (TARGET_OS_OSX || TARGET_OS_MACCATALYST) && TARGET_CPU_X86_64
-#define CMBASE_OBJECT_NEEDS_ALIGNMENT 1
-#else
-#define CMBASE_OBJECT_NEEDS_ALIGNMENT 0
-#endif
-
 struct SdpVideoFormat;
 class VideoDecoderFactory;
 
@@ -53,6 +46,7 @@
 std::unique_ptr createWebKitDecoderFactory(WebKitH265, WebKitVP9, WebKitVP9VTB);
 void videoDecoderTaskComplete(void* callback, uint32_t timeStamp, CVPixelBufferRef, uint32_t timeStampRTP);
 
+
 using LocalDecoder = void*;
 using LocalDecoderCallback = void (^)(CVPixelBufferRef, uint32_t timeStamp, uint32_t timeStampNs);
 void* createLocalH264Decoder(LocalDecoderCallback);


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp (279153 => 279154)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp	2021-06-22 22:00:49 UTC (rev 279153)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp	2021-06-22 22:06:54 UTC (rev 279154)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
+ * Copyright (C) 2020 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  *

[webkit-changes] [279153] branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc

2021-06-22 Thread repstein

Title: [279153] branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc








Revision 279153
Author repst...@apple.com
Date 2021-06-22 15:00:49 -0700 (Tue, 22 Jun 2021)


Log Message
Cherry-pick r278906. rdar://problem/79634523

Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder
https://bugs.webkit.org/show_bug.cgi?id=226873

Reviewed by Eric Carlson.

In case software encoder is being created for baseline, we can use kVTVideoEncoderSpecification_RequiredLowLatency
which provides better bitrate management than the regular SW encoder while still generating baseline content.
We check whether SW encoder is created based on kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder.
If property is unsupported or if its value is false, it means the encoder is software.

* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm




Diff

Modified: branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/ChangeLog (279152 => 279153)

--- branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 21:58:58 UTC (rev 279152)
+++ branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 22:00:49 UTC (rev 279153)
@@ -1,3 +1,38 @@
+2021-06-22  Russell Epstein  
+
+Cherry-pick r278906. rdar://problem/79634523
+
+Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder
+https://bugs.webkit.org/show_bug.cgi?id=226873
+
+Reviewed by Eric Carlson.
+
+In case software encoder is being created for baseline, we can use kVTVideoEncoderSpecification_RequiredLowLatency
+which provides better bitrate management than the regular SW encoder while still generating baseline content.
+We check whether SW encoder is created based on kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder.
+If property is unsupported or if its value is false, it means the encoder is software.
+
+* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-15  Youenn Fablet  
+
+Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder
+https://bugs.webkit.org/show_bug.cgi?id=226873
+
+Reviewed by Eric Carlson.
+
+In case software encoder is being created for baseline, we can use kVTVideoEncoderSpecification_RequiredLowLatency
+which provides better bitrate management than the regular SW encoder while still generating baseline content.
+We check whether SW encoder is created based on kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder.
+If property is unsupported or if its value is false, it means the encoder is software.
+
+* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
+
 2021-06-15  Alan Coon  
 
 Cherry-pick r278410. rdar://problem/79355285


Modified: branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (279152 => 279153)

--- branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm	2021-06-22 21:58:58 UTC (rev 279152)
+++ branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm	2021-06-22 22:00:49 UTC (rev 279153)
@@ -768,7 +768,27 @@
   CFBooleanRef hwaccl_enabled = nullptr;
   if (status == noErr) {
 auto result = VTSessionCopyProperty(_vtCompressionSession, kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder, nullptr, _enabled);
-_isUsingSoftwareEncoder = result == noErr ? !CFBooleanGetValue(hwaccl_enabled) : _width <= 480 && _height <= 480;
+_isUsingSoftwareEncoder = result == noErr ? !CFBooleanGetValue(hwaccl_enabled) : true;
+#if HAVE_VTB_REQUIREDLOWLATENCY
+if (_isUsingSoftwareEncoder && _isH264LowLatencyEncoderEnabled && _vtCompressionSession && !_useVCP) {
+  VTCompressionSessionInvalidate(_vtCompressionSession);
+  CFRelease(_vtCompressionSession);
+  _vtCompressionSession = nullptr;
+
+  CFDictionarySetValue(encoderSpecs, kVTVideoEncoderSpecification_RequiredLowLatency, kCFBooleanTrue);
+

[webkit-changes] [279152] branches/safari-611.3.8.1-branch/Source

2021-06-22 Thread repstein

Title: [279152] branches/safari-611.3.8.1-branch/Source








Revision 279152
Author repst...@apple.com
Date 2021-06-22 14:58:58 -0700 (Tue, 22 Jun 2021)


Log Message
Versioning.

WebKit-7611.3.8.1.1

Modified Paths

branches/safari-611.3.8.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.3.8.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.3.8.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.3.8.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.3.8.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.3.8.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.3.8.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.3.8.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279151 => 279152)

--- branches/safari-611.3.8.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-06-22 21:55:13 UTC (rev 279151)
+++ branches/safari-611.3.8.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-06-22 21:58:58 UTC (rev 279152)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 8;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.3.8.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279151 => 279152)

--- branches/safari-611.3.8.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-06-22 21:55:13 UTC (rev 279151)
+++ branches/safari-611.3.8.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-06-22 21:58:58 UTC (rev 279152)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 8;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279151 => 279152)

--- branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-06-22 21:55:13 UTC (rev 279151)
+++ branches/safari-611.3.8.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-06-22 21:58:58 UTC (rev 279152)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 8;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.3.8.1-branch/Source/WebCore/Configurations/Version.xcconfig (279151 => 279152)

--- branches/safari-611.3.8.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-06-22 21:55:13 UTC (rev 279151)
+++ branches/safari-611.3.8.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-06-22 21:58:58 UTC (rev 279152)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 8;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.3.8.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279151 => 279152)

--- branches/safari-611.3.8.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-06-22 21:55:13 UTC (rev 279151)
+++ branches/safari-611.3.8.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-06-22 21:58:58 UTC (rev 279152)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 8;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION =

[webkit-changes] [279151] trunk/Source/WebKit

2021-06-22 Thread jer . noble

Title: [279151] trunk/Source/WebKit








Revision 279151
Author jer.no...@apple.com
Date 2021-06-22 14:55:13 -0700 (Tue, 22 Jun 2021)


Log Message
Further unreviewed build fix after r279133: remove even more things.

* UIProcess/WebPageProxy.cpp:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (279150 => 279151)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 21:43:57 UTC (rev 279150)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 21:55:13 UTC (rev 279151)
@@ -1,5 +1,11 @@
 2021-06-22  Jer Noble  
 
+Further unreviewed build fix after r279133: remove even more things.
+
+* UIProcess/WebPageProxy.cpp:
+
+2021-06-22  Jer Noble  
+
 Unreviewed build fix after r279133: remove unnecessary includes and defines after upstreaming.
 
 * UIProcess/WebPageProxy.cpp:


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (279150 => 279151)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-06-22 21:43:57 UTC (rev 279150)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-06-22 21:55:13 UTC (rev 279151)
@@ -608,9 +608,6 @@
 
 websiteDataStore().networkProcess().send(Messages::NetworkProcess::RemoveWebPageNetworkParameters(sessionID(), m_identifier), 0);
 
-#if ENABLE(MEDIA_SESSION_COORDINATOR)
-WEBPAGEPROXY_DESTRUCTOR_WKCOORDINATOR_ADDITIONS
-#endif
 #if ENABLE(MEDIA_SESSION_COORDINATOR) && HAVE(GROUP_ACTIVITIES)
 GroupActivitiesSessionNotifier::sharedNotifier().removeWebPage(*this);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279150] branches/safari-611.3.8.1-branch/

2021-06-22 Thread repstein

Title: [279150] branches/safari-611.3.8.1-branch/








Revision 279150
Author repst...@apple.com
Date 2021-06-22 14:43:57 -0700 (Tue, 22 Jun 2021)


Log Message
New branch.

Added Paths

branches/safari-611.3.8.1-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279149] trunk/Tools

2021-06-22 Thread jbedard

Title: [279149] trunk/Tools








Revision 279149
Author jbed...@apple.com
Date 2021-06-22 14:25:36 -0700 (Tue, 22 Jun 2021)


Log Message
[results.webkit.org] XSS vulnerability in configuration
https://bugs.webkit.org/show_bug.cgi?id=227267


Reviewed by Dewei Zhu.

* Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Bump version.
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js: Escape configuration specification.
* Scripts/libraries/resultsdbpy/setup.py: Bump version.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js
trunk/Tools/Scripts/libraries/resultsdbpy/setup.py




Diff

Modified: trunk/Tools/ChangeLog (279148 => 279149)

--- trunk/Tools/ChangeLog	2021-06-22 21:25:02 UTC (rev 279148)
+++ trunk/Tools/ChangeLog	2021-06-22 21:25:36 UTC (rev 279149)
@@ -1,3 +1,15 @@
+2021-06-22  Jonathan Bedard  
+
+[results.webkit.org] XSS vulnerability in configuration
+https://bugs.webkit.org/show_bug.cgi?id=227267
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Bump version.
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js: Escape configuration specification.
+* Scripts/libraries/resultsdbpy/setup.py: Bump version.
+
 2021-06-22  Saam Barati  
 
 jitCompileAndSetHeuristics shouldn't return true when we fail to compile


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py (279148 => 279149)

--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py	2021-06-22 21:25:02 UTC (rev 279148)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py	2021-06-22 21:25:36 UTC (rev 279149)
@@ -44,7 +44,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(3, 0, 1)
+version = Version(3, 0, 2)
 
 import webkitflaskpy
 


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js (279148 => 279149)

--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js	2021-06-22 21:25:02 UTC (rev 279148)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js	2021-06-22 21:25:36 UTC (rev 279149)
@@ -22,7 +22,7 @@
 // THE POSSIBILITY OF SUCH DAMAGE.
 
 import {DOM, REF} from '/library/js/Ref.js';
-import {queryToParams, paramsToQuery, QueryModifier} from '/assets/js/common.js';
+import {queryToParams, paramsToQuery, QueryModifier, escapeHTML} from '/assets/js/common.js';
 import {CommitBank} from '/assets/js/commit.js';
 import {Configuration} from '/assets/js/configuration.js'
 
@@ -315,7 +315,7 @@
 });
 
 return `
-${option}
+${escapeHTML(option)}
 
 
 


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/setup.py (279148 => 279149)

--- trunk/Tools/Scripts/libraries/resultsdbpy/setup.py	2021-06-22 21:25:02 UTC (rev 279148)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/setup.py	2021-06-22 21:25:36 UTC (rev 279149)
@@ -30,7 +30,7 @@
 
 setup(
 name='resultsdbpy',
-version='3.0.1',
+version='3.0.2',
 description='Library for visualizing, processing and storing test results.',
 long_description=readme(),
 classifiers=[






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279148] trunk/Source/WebCore

2021-06-22 Thread drousso

Title: [279148] trunk/Source/WebCore








Revision 279148
Author drou...@apple.com
Date 2021-06-22 14:25:02 -0700 (Tue, 22 Jun 2021)


Log Message
REGRESSION: [iOS] ASSERTION FAILED: pixelBuffer->data().length() >= 4 under WebCore::sampleColor
https://bugs.webkit.org/show_bug.cgi?id=227256


Unreviewed, speculative internal test fix.


* page/PageColorSampler.cpp:
(WebCore::sampleColor):
It seems like sometimes the `PixelBuffer` can have a `length()` of `0`. Instead of only
having an `ASSERT` that there are enough items, actually early-return.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PageColorSampler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (279147 => 279148)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 21:20:43 UTC (rev 279147)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 21:25:02 UTC (rev 279148)
@@ -1,3 +1,16 @@
+2021-06-22  Devin Rousso  
+
+REGRESSION: [iOS] ASSERTION FAILED: pixelBuffer->data().length() >= 4 under WebCore::sampleColor
+https://bugs.webkit.org/show_bug.cgi?id=227256
+
+
+Unreviewed, speculative internal test fix.
+
+* page/PageColorSampler.cpp:
+(WebCore::sampleColor):
+It seems like sometimes the `PixelBuffer` can have a `length()` of `0`. Instead of only
+having an `ASSERT` that there are enough items, actually early-return.
+
 2021-06-22  Eric Carlson  
 
 [Cocoa] AVPlayer periodic time observer callback should use weakPtr


Modified: trunk/Source/WebCore/page/PageColorSampler.cpp (279147 => 279148)

--- trunk/Source/WebCore/page/PageColorSampler.cpp	2021-06-22 21:20:43 UTC (rev 279147)
+++ trunk/Source/WebCore/page/PageColorSampler.cpp	2021-06-22 21:25:02 UTC (rev 279148)
@@ -128,7 +128,8 @@
 if (!pixelBuffer)
 return std::nullopt;
 
-ASSERT(pixelBuffer->data().length() >= 4);
+if (pixelBuffer->data().length() < 4)
+return std::nullopt;
 
 auto snapshotData = pixelBuffer->data().data();
 return convertColor>(SRGBA { snapshotData[2], snapshotData[1], snapshotData[0], snapshotData[3] });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279147] trunk/Source/WebKit

2021-06-22 Thread jer . noble

Title: [279147] trunk/Source/WebKit








Revision 279147
Author jer.no...@apple.com
Date 2021-06-22 14:20:43 -0700 (Tue, 22 Jun 2021)


Log Message
Unreviewed build fix after r279133: remove unnecessary includes and defines after upstreaming.

* UIProcess/WebPageProxy.cpp:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (279146 => 279147)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 21:11:38 UTC (rev 279146)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 21:20:43 UTC (rev 279147)
@@ -1,3 +1,9 @@
+2021-06-22  Jer Noble  
+
+Unreviewed build fix after r279133: remove unnecessary includes and defines after upstreaming.
+
+* UIProcess/WebPageProxy.cpp:
+
 2021-06-22  Per Arne Vollan  
 
 [macOS] Deny mach-lookup to the service 'com.apple.print.normalizerd'


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (279146 => 279147)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-06-22 21:11:38 UTC (rev 279146)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-06-22 21:20:43 UTC (rev 279147)
@@ -310,14 +310,6 @@
 #include 
 #endif
 
-#if USE(APPLE_INTERNAL_SDK)
-#import 
-#else
-#define WEBPAGEPROXY_CONSTRUCTOR_WKCOORDINATOR_ADDITIONS
-#define WEBPAGEPROXY_DESTRUCTOR_WKCOORDINATOR_ADDITIONS
-#define WEBPAGEPROXY_DIDCOMMITLOADFORFRAME_WKCOORDINATOR_ADDITIONS
-#endif
-
 // This controls what strategy we use for mouse wheel coalescing.
 #define MERGE_WHEEL_EVENTS 1
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279146] trunk/Source/WebCore

2021-06-22 Thread eric . carlson

Title: [279146] trunk/Source/WebCore








Revision 279146
Author eric.carl...@apple.com
Date 2021-06-22 14:11:38 -0700 (Tue, 22 Jun 2021)


Log Message
[Cocoa] AVPlayer periodic time observer callback should use weakPtr
https://bugs.webkit.org/show_bug.cgi?id=227264
rdar://79269047

Reviewed by Jer Noble.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (279145 => 279146)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 21:07:14 UTC (rev 279145)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 21:11:38 UTC (rev 279146)
@@ -1,3 +1,14 @@
+2021-06-22  Eric Carlson  
+
+[Cocoa] AVPlayer periodic time observer callback should use weakPtr
+https://bugs.webkit.org/show_bug.cgi?id=227264
+rdar://79269047
+
+Reviewed by Jer Noble.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
+
 2021-06-22  Alan Bujtas  
 
 [RenderTreeBuilder] ASSERTION FAILED: m_renderer in FloatingObject::renderer()


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (279145 => 279146)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2021-06-22 21:07:14 UTC (rev 279145)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2021-06-22 21:11:38 UTC (rev 279146)
@@ -1088,8 +1088,10 @@
 #endif
 
 ASSERT(!m_currentTimeObserver);
-m_currentTimeObserver = [m_avPlayer addPeriodicTimeObserverForInterval:CMTimeMake(1, 10) queue:dispatch_get_main_queue() usingBlock:[this] (CMTime time) {
-currentMediaTimeDidChange(PAL::toMediaTime(time));
+auto weakThis = makeWeakPtr(*this);
+m_currentTimeObserver = [m_avPlayer addPeriodicTimeObserverForInterval:CMTimeMake(1, 10) queue:dispatch_get_main_queue() usingBlock:[weakThis] (CMTime time) {
+if (weakThis)
+weakThis->currentMediaTimeDidChange(PAL::toMediaTime(time));
 }];
 
 setDelayCallbacks(false);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279145] trunk

2021-06-22 Thread pvollan

Title: [279145] trunk








Revision 279145
Author pvol...@apple.com
Date 2021-06-22 14:07:14 -0700 (Tue, 22 Jun 2021)


Log Message
[macOS] Deny mach-lookup to the service 'com.apple.print.normalizerd'
https://bugs.webkit.org/show_bug.cgi?id=227248


Reviewed by Brent Fulgham.

Source/WebKit:

Deny mach-lookup to the service 'com.apple.print.normalizerd' in the WebKit processes on macOS.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
* UIProcess/WebPageProxy.cpp:
(WebKit::gpuMachServices):
* WebProcess/com.apple.WebProcess.sb.in:

LayoutTests:

Skip EPS test, which is failing when this service is unavailable.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
trunk/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/LayoutTests/ChangeLog (279144 => 279145)

--- trunk/LayoutTests/ChangeLog	2021-06-22 21:00:16 UTC (rev 279144)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 21:07:14 UTC (rev 279145)
@@ -1,3 +1,15 @@
+2021-06-22  Per Arne Vollan  
+
+[macOS] Deny mach-lookup to the service 'com.apple.print.normalizerd'
+https://bugs.webkit.org/show_bug.cgi?id=227248
+
+
+Reviewed by Brent Fulgham.
+
+Skip EPS test, which is failing when this service is unavailable.
+
+* platform/mac/TestExpectations:
+
 2021-06-22  Alan Bujtas  
 
 [RenderTreeBuilder] ASSERTION FAILED: m_renderer in FloatingObject::renderer()


Modified: trunk/LayoutTests/platform/mac/TestExpectations (279144 => 279145)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-06-22 21:00:16 UTC (rev 279144)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-06-22 21:07:14 UTC (rev 279145)
@@ -57,7 +57,7 @@
 fast/forms/search/search-results-hidden-crash.html [ Pass ]
 
 fast/url/user-visible [ Pass ]
-fast/images/eps-as-image.html [ Pass ]
+fast/images/eps-as-image.html [ Skip ]
 
 fast/text-autosizing/ios/programmatic-text-size-adjust.html [ Skip ]
 fast/text-autosizing/ios/text-size-adjust-inline-style.html [ Skip ]


Modified: trunk/Source/WebKit/ChangeLog (279144 => 279145)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 21:00:16 UTC (rev 279144)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 21:07:14 UTC (rev 279145)
@@ -1,3 +1,19 @@
+2021-06-22  Per Arne Vollan  
+
+[macOS] Deny mach-lookup to the service 'com.apple.print.normalizerd'
+https://bugs.webkit.org/show_bug.cgi?id=227248
+
+
+Reviewed by Brent Fulgham.
+
+Deny mach-lookup to the service 'com.apple.print.normalizerd' in the WebKit processes on macOS.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::gpuMachServices):
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2021-06-22  Fujii Hironori  
 
 [GLib] Rewrite NetworkCache::Data::adoptMap without FileSystem::MappedFileData::leakHandle and munmap


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (279144 => 279145)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-06-22 21:00:16 UTC (rev 279144)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-06-22 21:07:14 UTC (rev 279145)
@@ -486,7 +486,6 @@
 (xpc-service-name "com.apple.coremedia.videodecoder")
 (xpc-service-name "com.apple.coremedia.videoencoder")
 (xpc-service-name "com.apple.hiservices-xpcservice")
-(xpc-service-name "com.apple.print.normalizerd")
 )
 
 (allow mach-lookup


Modified: trunk/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (279144 => 279145)

--- trunk/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in	2021-06-22 21:00:16 UTC (rev 279144)
+++ trunk/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in	2021-06-22 21:07:14 UTC (rev 279145)
@@ -164,7 +164,6 @@
 (xpc-service-name "com.apple.coremedia.videoencoder")
 (xpc-service-name-regex #"\.apple-extension-service$")
 (xpc-service-name "com.apple.hiservices-xpcservice")
-(xpc-service-name "com.apple.print.normalizerd")
 )
 
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (279144 => 279145)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-06-22 21:00:16 UTC (rev 279144)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-06-22 21:07:14 UTC (rev 279145)
@@ -7954,7 +7954,6 @@
 "com.apple.MTLCompilerService"_s,
 #if PLATFORM(MAC) || PLATFORM(MACCATALYST)
 "com.apple.cvmsServ"_s,
-"com.apple.print.normalizerd"_s,
 #endif

[webkit-changes] [279144] branches/safari-612.1.18.1-branch/Source

2021-06-22 Thread rubent_22

Title: [279144] branches/safari-612.1.18.1-branch/Source








Revision 279144
Author rubent...@apple.com
Date 2021-06-22 14:00:16 -0700 (Tue, 22 Jun 2021)


Log Message
Versioning.

WebKit-7612.1.18.1.4

Modified Paths

branches/safari-612.1.18.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.18.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.18.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.18.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.18.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.18.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.18.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.18.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.18.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279143 => 279144)

--- branches/safari-612.1.18.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-06-22 20:33:10 UTC (rev 279143)
+++ branches/safari-612.1.18.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-06-22 21:00:16 UTC (rev 279144)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.18.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279143 => 279144)

--- branches/safari-612.1.18.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-06-22 20:33:10 UTC (rev 279143)
+++ branches/safari-612.1.18.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-06-22 21:00:16 UTC (rev 279144)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.18.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279143 => 279144)

--- branches/safari-612.1.18.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-06-22 20:33:10 UTC (rev 279143)
+++ branches/safari-612.1.18.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-06-22 21:00:16 UTC (rev 279144)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.18.1-branch/Source/WebCore/Configurations/Version.xcconfig (279143 => 279144)

--- branches/safari-612.1.18.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-06-22 20:33:10 UTC (rev 279143)
+++ branches/safari-612.1.18.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-06-22 21:00:16 UTC (rev 279144)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.18.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279143 => 279144)

--- branches/safari-612.1.18.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-06-22 20:33:10 UTC (rev 279143)
+++ branches/safari-612.1.18.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-06-22 21:00:16 UTC (rev 279144)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.18.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279143 => 279144)

--- branches/safari-612.1.18.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-06-22 20:33:10 UTC (rev 279143)
+++ branches/safari-612.1.18.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-06-22 21:00:16 UTC (rev 279144)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
 MICRO_VERSION = 1;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION =

[webkit-changes] [279143] trunk/Source/ThirdParty/ANGLE

2021-06-22 Thread dino

Title: [279143] trunk/Source/ThirdParty/ANGLE








Revision 279143
Author d...@apple.com
Date 2021-06-22 13:33:10 -0700 (Tue, 22 Jun 2021)


Log Message
[ANGLE] Support importing external MTLTextures
https://bugs.webkit.org/show_bug.cgi?id=226690

Reviewed by Tim Horton.

Support MTLTextures as GL textures.
Merge https://chromium-review.googlesource.com/c/angle/angle/+/2820178

* ANGLE.xcodeproj/project.pbxproj:
* extensions/EGL_ANGLE_metal_texture_client_buffer.txt: Added.
* include/EGL/eglext_angle.h:
* src/common/utilities.cpp:
(egl::IsExternalImageTarget):
* src/libANGLE/Caps.cpp:
(egl::DisplayExtensions::getStrings const):
* src/libANGLE/Caps.h:
* src/libANGLE/renderer/metal/BUILD.gn:
* src/libANGLE/renderer/metal/DisplayMtl.h:
* src/libANGLE/renderer/metal/DisplayMtl.mm:
(rx::DisplayMtl::createImage):
(rx::DisplayMtl::createExternalImageSibling):
(rx::DisplayMtl::generateExtensions const):
(rx::DisplayMtl::validateImageClientBuffer const):
(rx::DisplayMtl::initializeExtensions const):
* src/libANGLE/renderer/metal/ImageMtl.h: Added.
(rx::TextureImageSiblingMtl::getTexture const):
(rx::TextureImageSiblingMtl::getFormatMtl const):
(rx::ImageMtl::getTexture const):
(rx::ImageMtl::getImageTextureType const):
(rx::ImageMtl::getImageLevel const):
(rx::ImageMtl::getImageLayer const):
* src/libANGLE/renderer/metal/ImageMtl.mm: Added.
(rx::TextureImageSiblingMtl::TextureImageSiblingMtl):
(rx::TextureImageSiblingMtl::~TextureImageSiblingMtl):
(rx::TextureImageSiblingMtl::ValidateClientBuffer):
(rx::TextureImageSiblingMtl::initialize):
(rx::TextureImageSiblingMtl::initImpl):
(rx::TextureImageSiblingMtl::onDestroy):
(rx::TextureImageSiblingMtl::getFormat const):
(rx::TextureImageSiblingMtl::isRenderable const):
(rx::TextureImageSiblingMtl::isTexturable const):
(rx::TextureImageSiblingMtl::getSize const):
(rx::TextureImageSiblingMtl::getSamples const):
(rx::ImageMtl::ImageMtl):
(rx::ImageMtl::~ImageMtl):
(rx::ImageMtl::onDestroy):
(rx::ImageMtl::initialize):
(rx::ImageMtl::orphan):
* src/libANGLE/renderer/metal/RenderBufferMtl.mm:
(rx::RenderbufferMtl::setStorageEGLImageTarget):
* src/libANGLE/renderer/metal/TextureMtl.mm:
(rx::TextureMtl::setEGLImageTarget):
* src/libANGLE/renderer/metal/gen_mtl_format_table.py:
(gen_image_map_switch_mac_case.gen_format_assign_code):
(gen_image_mtl_to_angle_switch_string):
(main):
* src/libANGLE/renderer/metal/mtl_common.h:
* src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:
(rx::mtl::Format::MetalToAngleFormatID):
* src/libANGLE/renderer/metal/mtl_format_utils.h:
* src/libANGLE/validationEGL.cpp:
(egl::ValidateCreateImage):
* src/tests/BUILD.gn:
* src/tests/gl_tests/ImageTest.cpp:
(angle::TEST_P):
* src/tests/gl_tests/ImageTestMetal.mm: Added.
(angle::ScopeMetalTextureRef::ScopeMetalTextureRef):
(angle::ScopeMetalTextureRef::~ScopeMetalTextureRef):
(angle::ScopeMetalTextureRef::get const):
(angle::ScopeMetalTextureRef::operator id const):
(angle::ScopeMetalTextureRef::operator=):
(angle::ScopeMetalTextureRef::release):
(angle::CreateMetalTexture2D):
(angle::ImageTestMetal::ImageTestMetal):
(angle::ImageTestMetal::getMtlDevice):
(angle::ImageTestMetal::createMtlTexture2D):
(angle::ImageTestMetal::verifyResultsTexture):
(angle::ImageTestMetal::verifyResults2D):
(angle::ImageTestMetal::reinterpretHelper):
(angle::ImageTestMetal::hasImageNativeMetalTextureExt const):
(angle::ImageTestMetal::hasOESExt const):
(angle::ImageTestMetal::hasBaseExt const):
(angle::ImageTestMetal::sourceMetalTarget2D_helper):
(angle::TEST_P):

Modified Paths

trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/include/EGL/eglext_angle.h
trunk/Source/ThirdParty/ANGLE/src/common/utilities.cpp
trunk/Source/ThirdParty/ANGLE/src/libANGLE/Caps.cpp
trunk/Source/ThirdParty/ANGLE/src/libANGLE/Caps.h
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BUILD.gn
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.h
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/RenderBufferMtl.mm
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/gen_mtl_format_table.py
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_utils.h
trunk/Source/ThirdParty/ANGLE/src/libANGLE/validationEGL.cpp
trunk/Source/ThirdParty/ANGLE/src/tests/BUILD.gn
trunk/Source/ThirdParty/ANGLE/src/tests/gl_tests/ImageTest.cpp


Added Paths

trunk/Source/ThirdParty/ANGLE/extensions/EGL_ANGLE_metal_texture_client_buffer.txt
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ImageMtl.h
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ImageMtl.mm

[webkit-changes] [279142] trunk

2021-06-22 Thread zalan

Title: [279142] trunk








Revision 279142
Author za...@apple.com
Date 2021-06-22 13:26:10 -0700 (Tue, 22 Jun 2021)


Log Message
[RenderTreeBuilder] ASSERTION FAILED: m_renderer in FloatingObject::renderer()
https://bugs.webkit.org/show_bug.cgi?id=227260


Reviewed by Antti Koivisto.

Source/WebCore:

This is a very similar to webkit.org/b/224996, where moving subtrees around fails to invalidate floating object sets in sibling blocks.
(see the Changelog entry for more details on how sibling invalidation works).
In this case the anonymous parent block is destroyed as it is no longer needed (and we move all its descendants out first). However this
block has an intruding float and this float is also registered in the sibling blocks.

Test: fast/block/float-assert-when-anon-parent-is-destroyed.html

* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::moveChildren):
(WebCore::RenderTreeBuilder::removeFloatingObjects):
* rendering/updating/RenderTreeBuilder.h:
* rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::RenderTreeBuilder::Block::removeLeftoverAnonymousBlock):

LayoutTests:

* fast/block/float-assert-when-anon-parent-is-destroyed-expected.txt: Added.
* fast/block/float-assert-when-anon-parent-is-destroyed.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp


Added Paths

trunk/LayoutTests/fast/block/float-assert-when-anon-parent-is-destroyed-expected.txt
trunk/LayoutTests/fast/block/float-assert-when-anon-parent-is-destroyed.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279141 => 279142)

--- trunk/LayoutTests/ChangeLog	2021-06-22 20:13:52 UTC (rev 279141)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 20:26:10 UTC (rev 279142)
@@ -1,3 +1,14 @@
+2021-06-22  Alan Bujtas  
+
+[RenderTreeBuilder] ASSERTION FAILED: m_renderer in FloatingObject::renderer()
+https://bugs.webkit.org/show_bug.cgi?id=227260
+
+
+Reviewed by Antti Koivisto.
+
+* fast/block/float-assert-when-anon-parent-is-destroyed-expected.txt: Added.
+* fast/block/float-assert-when-anon-parent-is-destroyed.html: Added.
+
 2021-06-22  Arcady Goldmints-Orlov  
 
 [GLIB] Unreviewed test gardening, add timeouts in new test


Added: trunk/LayoutTests/fast/block/float-assert-when-anon-parent-is-destroyed-expected.txt (0 => 279142)

--- trunk/LayoutTests/fast/block/float-assert-when-anon-parent-is-destroyed-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/block/float-assert-when-anon-parent-is-destroyed-expected.txt	2021-06-22 20:26:10 UTC (rev 279142)
@@ -0,0 +1 @@
+


Added: trunk/LayoutTests/fast/block/float-assert-when-anon-parent-is-destroyed.html (0 => 279142)

--- trunk/LayoutTests/fast/block/float-assert-when-anon-parent-is-destroyed.html	(rev 0)
+++ trunk/LayoutTests/fast/block/float-assert-when-anon-parent-is-destroyed.html	2021-06-22 20:26:10 UTC (rev 279142)
@@ -0,0 +1,29 @@
+
+
+  html::before {
+content: '';
+  }
+  html {
+min-width: 10px;
+  }
+  body, div {
+padding-bottom: 5%;
+  }
+  div:first-child {
+float: right;
+  }
+
+
+
+  if (window.testRunner)
+testRunner.dumpAsText();
+  _onload_ = () => {
+let n0 = document.createElement('span');
+document.documentElement.appendChild(n0);
+n0.appendChild(document.createElement('div'));
+document.documentElement.appendChild(document.createElement('div'));
+document.documentElement.appendChild(document.createElement('span'));
+document.body.offsetTop;
+document.styleSheets[0].insertRule(`:first-of-type::first-letter { background: grey; }`);
+  };
+


Modified: trunk/Source/WebCore/ChangeLog (279141 => 279142)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 20:13:52 UTC (rev 279141)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 20:26:10 UTC (rev 279142)
@@ -1,3 +1,25 @@
+2021-06-22  Alan Bujtas  
+
+[RenderTreeBuilder] ASSERTION FAILED: m_renderer in FloatingObject::renderer()
+https://bugs.webkit.org/show_bug.cgi?id=227260
+
+
+Reviewed by Antti Koivisto.
+
+This is a very similar to webkit.org/b/224996, where moving subtrees around fails to invalidate floating object sets in sibling blocks.
+(see the Changelog entry for more details on how sibling invalidation works).
+In this case the anonymous parent block is destroyed as it is no longer needed (and we move all its descendants out first). However this
+block has an intruding float and this float is also registered in the sibling blocks. 
+
+Test: fast/block/float-assert-when-anon-parent-is-destroyed.html
+
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::moveChildren):
+

[webkit-changes] [279140] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc

2021-06-22 Thread alancoon

Title: [279140] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc








Revision 279140
Author alanc...@apple.com
Date 2021-06-22 13:13:48 -0700 (Tue, 22 Jun 2021)


Log Message
Cherry-pick r278906. rdar://problem/79581492

Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder
https://bugs.webkit.org/show_bug.cgi?id=226873

Reviewed by Eric Carlson.

In case software encoder is being created for baseline, we can use kVTVideoEncoderSpecification_RequiredLowLatency
which provides better bitrate management than the regular SW encoder while still generating baseline content.
We check whether SW encoder is created based on kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder.
If property is unsupported or if its value is false, it means the encoder is software.

* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm




Diff

Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog (279139 => 279140)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 20:08:37 UTC (rev 279139)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 20:13:48 UTC (rev 279140)
@@ -1,3 +1,38 @@
+2021-06-22  Russell Epstein  
+
+Cherry-pick r278906. rdar://problem/79581492
+
+Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder
+https://bugs.webkit.org/show_bug.cgi?id=226873
+
+Reviewed by Eric Carlson.
+
+In case software encoder is being created for baseline, we can use kVTVideoEncoderSpecification_RequiredLowLatency
+which provides better bitrate management than the regular SW encoder while still generating baseline content.
+We check whether SW encoder is created based on kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder.
+If property is unsupported or if its value is false, it means the encoder is software.
+
+* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-15  Youenn Fablet  
+
+Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder
+https://bugs.webkit.org/show_bug.cgi?id=226873
+
+Reviewed by Eric Carlson.
+
+In case software encoder is being created for baseline, we can use kVTVideoEncoderSpecification_RequiredLowLatency
+which provides better bitrate management than the regular SW encoder while still generating baseline content.
+We check whether SW encoder is created based on kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder.
+If property is unsupported or if its value is false, it means the encoder is software.
+
+* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
+
 2021-06-15  Alan Coon  
 
 Cherry-pick r278410. rdar://problem/79355285


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (279139 => 279140)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm	2021-06-22 20:08:37 UTC (rev 279139)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm	2021-06-22 20:13:48 UTC (rev 279140)
@@ -768,7 +768,27 @@
   CFBooleanRef hwaccl_enabled = nullptr;
   if (status == noErr) {
 auto result = VTSessionCopyProperty(_vtCompressionSession, kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder, nullptr, _enabled);
-_isUsingSoftwareEncoder = result == noErr ? !CFBooleanGetValue(hwaccl_enabled) : _width <= 480 && _height <= 480;
+_isUsingSoftwareEncoder = result == noErr ? !CFBooleanGetValue(hwaccl_enabled) : true;
+#if HAVE_VTB_REQUIREDLOWLATENCY
+if (_isUsingSoftwareEncoder && _isH264LowLatencyEncoderEnabled && _vtCompressionSession && !_useVCP) {
+  VTCompressionSessionInvalidate(_vtCompressionSession);
+  CFRelease(_vtCompressionSession);
+  _vtCompressionSession = nullptr;
+
+  CFDictionarySetValue(encoderSpecs, kVTVideoEncoderSpecification_RequiredLowLatency, kCFBooleanTrue);
+

[webkit-changes] [279141] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc

2021-06-22 Thread alancoon

Title: [279141] branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc








Revision 279141
Author alanc...@apple.com
Date 2021-06-22 13:13:52 -0700 (Tue, 22 Jun 2021)


Log Message
Cherry-pick r279101. rdar://problem/79474211

[Mac] libwebrtc CMBaseClass objects need alignment fixup
https://bugs.webkit.org/show_bug.cgi?id=227137


Reviewed by Youenn Fablet.

* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.

* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
Add static_asserts to ensure alignment and sizes are correct.

* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
(webrtc::createWebKitVP9Decoder): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp




Diff

Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog (279140 => 279141)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 20:13:48 UTC (rev 279140)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 20:13:52 UTC (rev 279141)
@@ -1,5 +1,46 @@
 2021-06-22  Russell Epstein  
 
+Cherry-pick r279101. rdar://problem/79474211
+
+[Mac] libwebrtc CMBaseClass objects need alignment fixup
+https://bugs.webkit.org/show_bug.cgi?id=227137
+
+
+Reviewed by Youenn Fablet.
+
+* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.
+
+* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
+(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
+Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
+Add static_asserts to ensure alignment and sizes are correct.
+
+* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
+(webrtc::createWebKitVP9Decoder): Ditto.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-21  Eric Carlson  
+
+[Mac] libwebrtc CMBaseClass objects need alignment fixup
+https://bugs.webkit.org/show_bug.cgi?id=227137
+
+
+Reviewed by Youenn Fablet.
+
+* Source/webrtc/sdk/WebKit/WebKitDecoder.h: Define CMBASE_OBJECT_NEEDS_ALIGNMENT.
+
+* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
+(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on Mac and
+Mac Catalyst when building for x86_64 so function pointers are naturally aligned.
+Add static_asserts to ensure alignment and sizes are correct.
+
+* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
+(webrtc::createWebKitVP9Decoder): Ditto.
+
+2021-06-22  Russell Epstein  
+
 Cherry-pick r278906. rdar://problem/79581492
 
 Enable kVTVideoEncoderSpecification_RequiredLowLatency in case of MacOS software encoder


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h (279140 => 279141)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-22 20:13:48 UTC (rev 279140)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.h	2021-06-22 20:13:52 UTC (rev 279141)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -25,6 +25,7 @@
 
 #pragma once
 
+#include 
 #include "WebKitUtilities.h"
 #include "api/video_codecs/video_decoder_factory.h"
 
@@ -32,6 +33,12 @@
 
 namespace webrtc {
 
+#if (TARGET_OS_OSX || TARGET_OS_MACCATALYST) && TARGET_CPU_X86_64
+#define CMBASE_OBJECT_NEEDS_ALIGNMENT 1
+#else
+#define CMBASE_OBJECT_NEEDS_ALIGNMENT 0
+#endif
+
 struct SdpVideoFormat;
 class VideoDecoderFactory;
 
@@ -46,7 +53,6 @@
 std::unique_ptr createWebKitDecoderFactory(WebKitH265, WebKitVP9, WebKitVP9VTB);
 void videoDecoderTaskComplete(void* callback, uint32_t timeStamp, CVPixelBufferRef, uint32_t timeStampRTP);
 
-
 using LocalDecoder = void*;
 using LocalDecoderCallback = void (^)(CVPixelBufferRef, uint32_t timeStamp, uint32_t

[webkit-changes] [279139] branches/safari-611.3.10.1-branch/Source

2021-06-22 Thread alancoon

Title: [279139] branches/safari-611.3.10.1-branch/Source








Revision 279139
Author alanc...@apple.com
Date 2021-06-22 13:08:37 -0700 (Tue, 22 Jun 2021)


Log Message
Versioning.

WebKit-7611.3.10.1.1

Modified Paths

branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279138 => 279139)

--- branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-06-22 20:07:26 UTC (rev 279138)
+++ branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-06-22 20:08:37 UTC (rev 279139)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279138 => 279139)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-06-22 20:07:26 UTC (rev 279138)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-06-22 20:08:37 UTC (rev 279139)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279138 => 279139)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-06-22 20:07:26 UTC (rev 279138)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-06-22 20:08:37 UTC (rev 279139)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig (279138 => 279139)

--- branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-06-22 20:07:26 UTC (rev 279138)
+++ branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-06-22 20:08:37 UTC (rev 279139)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279138 => 279139)

--- branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-06-22 20:07:26 UTC (rev 279138)
+++ branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-06-22 20:08:37 UTC (rev 279139)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION

[webkit-changes] [279138] trunk/Source/WebCore

2021-06-22 Thread jer . noble

Title: [279138] trunk/Source/WebCore








Revision 279138
Author jer.no...@apple.com
Date 2021-06-22 13:07:26 -0700 (Tue, 22 Jun 2021)


Log Message
Unreviewed tvOS build fix after r279119: add PLATFORM(IOS) guards to exclude tvOS and Catalyst builds.

* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::setEligibleForSmartRouting):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (279137 => 279138)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 19:47:57 UTC (rev 279137)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 20:07:26 UTC (rev 279138)
@@ -1,3 +1,10 @@
+2021-06-22  Jer Noble  
+
+Unreviewed tvOS build fix after r279119: add PLATFORM(IOS) guards to exclude tvOS and Catalyst builds.
+
+* platform/audio/ios/AudioSessionIOS.mm:
+(WebCore::setEligibleForSmartRouting):
+
 2021-06-22  Simon Fraser  
 
 REGRESSION (Safari 14): Submenus on https://codelearn.cat don't show


Modified: trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm (279137 => 279138)

--- trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2021-06-22 19:47:57 UTC (rev 279137)
+++ trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2021-06-22 20:07:26 UTC (rev 279138)
@@ -98,6 +98,7 @@
 
 static void setEligibleForSmartRouting(bool eligible)
 {
+#if PLATFORM(IOS)
 ASSERT(!isMainThread());
 
 auto *session = [PAL::getAVAudioSessionClass() sharedInstance];
@@ -111,6 +112,9 @@
 NSError *error = nil;
 if (![session setEligibleForBTSmartRoutingConsideration:eligible error:])
 RELEASE_LOG_ERROR(Media, "failed to set eligible to %d with error: %@", eligible, error.localizedDescription);
+#else
+UNUSED_PARAM(eligible);
+#endif
 }
 
 AudioSessionIOS::AudioSessionIOS()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279137] trunk/Source

2021-06-22 Thread Hironori . Fujii

Title: [279137] trunk/Source








Revision 279137
Author hironori.fu...@sony.com
Date 2021-06-22 12:47:57 -0700 (Tue, 22 Jun 2021)


Log Message
[GLib] Rewrite NetworkCache::Data::adoptMap without FileSystem::MappedFileData::leakHandle and munmap
https://bugs.webkit.org/show_bug.cgi?id=227017

Reviewed by Carlos Garcia Campos.

Source/WebKit:

FileSystem::MappedFileData class wraps file mapping APIs like mmap
and munmap in cross-platform manner. NetworkCache::Data::adoptMap
shouldn't use FileSystem::MappedFileData::leakHandle and munmap.

* NetworkProcess/cache/NetworkCacheDataGLib.cpp:
(WebKit::NetworkCache::MapWrapper::~MapWrapper):
(WebKit::NetworkCache::Data::adoptMap):

Source/WTF:

* wtf/FileSystem.h: MappedFileData::leakHandle is used only if PLATFORM(COCOA) now.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FileSystem.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (279136 => 279137)

--- trunk/Source/WTF/ChangeLog	2021-06-22 19:38:37 UTC (rev 279136)
+++ trunk/Source/WTF/ChangeLog	2021-06-22 19:47:57 UTC (rev 279137)
@@ -1,3 +1,12 @@
+2021-06-22  Fujii Hironori  
+
+[GLib] Rewrite NetworkCache::Data::adoptMap without FileSystem::MappedFileData::leakHandle and munmap
+https://bugs.webkit.org/show_bug.cgi?id=227017
+
+Reviewed by Carlos Garcia Campos.
+
+* wtf/FileSystem.h: MappedFileData::leakHandle is used only if PLATFORM(COCOA) now.
+
 2021-06-22  Saam Barati  
 
 jitCompileAndSetHeuristics shouldn't return true when we fail to compile


Modified: trunk/Source/WTF/wtf/FileSystem.h (279136 => 279137)

--- trunk/Source/WTF/wtf/FileSystem.h	2021-06-22 19:38:37 UTC (rev 279136)
+++ trunk/Source/WTF/wtf/FileSystem.h	2021-06-22 19:47:57 UTC (rev 279137)
@@ -225,7 +225,7 @@
 const void* data() const { return m_fileData; }
 unsigned size() const { return m_fileSize; }
 
-#if !OS(WINDOWS)
+#if PLATFORM(COCOA)
 void* leakHandle() { return std::exchange(m_fileData, nullptr); }
 #endif
 #if OS(WINDOWS)


Modified: trunk/Source/WebKit/ChangeLog (279136 => 279137)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 19:38:37 UTC (rev 279136)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 19:47:57 UTC (rev 279137)
@@ -1,3 +1,18 @@
+2021-06-22  Fujii Hironori  
+
+[GLib] Rewrite NetworkCache::Data::adoptMap without FileSystem::MappedFileData::leakHandle and munmap
+https://bugs.webkit.org/show_bug.cgi?id=227017
+
+Reviewed by Carlos Garcia Campos.
+
+FileSystem::MappedFileData class wraps file mapping APIs like mmap
+and munmap in cross-platform manner. NetworkCache::Data::adoptMap
+shouldn't use FileSystem::MappedFileData::leakHandle and munmap.
+
+* NetworkProcess/cache/NetworkCacheDataGLib.cpp:
+(WebKit::NetworkCache::MapWrapper::~MapWrapper):
+(WebKit::NetworkCache::Data::adoptMap):
+
 2021-06-07  Jer Noble  
 
 [Cocoa] Upstream GroupActivitiesCoordinator


Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp (279136 => 279137)

--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp	2021-06-22 19:38:37 UTC (rev 279136)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp	2021-06-22 19:47:57 UTC (rev 279137)
@@ -115,12 +115,10 @@
 
 ~MapWrapper()
 {
-munmap(map, size);
 FileSystem::closeFile(fileDescriptor);
 }
 
-void* map;
-size_t size;
+FileSystem::MappedFileData mappedFile;
 FileSystem::PlatformFileHandle fileDescriptor;
 };
 
@@ -132,10 +130,10 @@
 Data Data::adoptMap(FileSystem::MappedFileData&& mappedFile, FileSystem::PlatformFileHandle fd)
 {
 size_t size = mappedFile.size();
-void* map = mappedFile.leakHandle();
+const void* map = mappedFile.data();
 ASSERT(map);
 ASSERT(map != MAP_FAILED);
-MapWrapper* wrapper = new MapWrapper { map, size, fd };
+MapWrapper* wrapper = new MapWrapper { WTFMove(mappedFile), fd };
 return { adoptGRef(g_bytes_new_with_free_func(map, size, reinterpret_cast(deleteMapWrapper), wrapper)), fd };
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279136] branches/safari-611.3.10.1-branch/

2021-06-22 Thread repstein

Title: [279136] branches/safari-611.3.10.1-branch/








Revision 279136
Author repst...@apple.com
Date 2021-06-22 12:38:37 -0700 (Tue, 22 Jun 2021)


Log Message
New branch.

Added Paths

branches/safari-611.3.10.1-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279135] branches/safari-611.3.10.0-branch/

2021-06-22 Thread repstein

Title: [279135] branches/safari-611.3.10.0-branch/








Revision 279135
Author repst...@apple.com
Date 2021-06-22 12:38:22 -0700 (Tue, 22 Jun 2021)


Log Message
New branch.

Added Paths

branches/safari-611.3.10.0-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279134] trunk/Source/JavaScriptCore

2021-06-22 Thread commit-queue

Title: [279134] trunk/Source/_javascript_Core








Revision 279134
Author commit-qu...@webkit.org
Date 2021-06-22 11:53:40 -0700 (Tue, 22 Jun 2021)


Log Message
Add a new pattern to instruction selector to utilize SMADDL supported by ARM64
https://bugs.webkit.org/show_bug.cgi?id=227188

Patch by Yijia Huang  on 2021-06-22
Reviewed by Saam Barati.

Signed Multiply-Add Long(SMADDL), supported by ARM64, multiplies two 32-bit
register values, adds a 64-bit register value, and writes the result to the
64-bit destination register. The instruction selector can utilize this to
lowering certain patterns in B3 IR before further Air optimization.

Given the operation:

smaddl d, n, m, a

The equivalent patterns would be:

d = a + SExt32(n) * SExt32(m)
d = SExt32(n) * SExt32(m) + a

Given B3 IR:
Int @0 = ArgumentReg(%x0)
Int @1 = SExt32(Trunc(ArgumentReg(%x1)))
Int @2 = SExt32(Trunc(ArgumentReg(%x2)))
Int @3 = Mul(@1, @2)
Int @4 = Add(@0, @3)
Void@5 = Return(@4, Terminal)

Before Adding SMADDL:
// Old optimized AIR
SignExtend32ToPtr  %x1, %x1,   @1
SignExtend32ToPtr  %x2, %x2,   @2
MultiplyAdd64  %x1, %x2, %x0, %x0, @4
Ret64  %x0,@5

After Adding SMADDL:
// New optimized AIR
MultiplyAddSignExtend32 %x1, %x2, %x0, %x0, @8
Ret64   %x0,@9

* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::multiplyAddSignExtend32):
* assembler/testmasm.cpp:
(JSC::testMultiplyAddSignExtend32Left):
(JSC::testMultiplyAddSignExtend32Right):
* b3/B3LowerToAir.cpp:
* b3/air/AirOpcode.opcodes:
* b3/testb3.h:
* b3/testb3_2.cpp:
(testMulAddArg):
(testMulAddArgsLeft):
(testMulAddArgsRight):
(testMulAddSignExtend32ArgsLeft):
(testMulAddSignExtend32ArgsRight):
(testMulAddArgsLeft32):
(testMulAddArgsRight32):
* b3/testb3_3.cpp:
(addArgTests):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/assembler/testmasm.cpp
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/_javascript_Core/b3/testb3.h
trunk/Source/_javascript_Core/b3/testb3_2.cpp
trunk/Source/_javascript_Core/b3/testb3_3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279133 => 279134)

--- trunk/Source/_javascript_Core/ChangeLog	2021-06-22 18:49:09 UTC (rev 279133)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-06-22 18:53:40 UTC (rev 279134)
@@ -1,3 +1,63 @@
+2021-06-22  Yijia Huang  
+
+Add a new pattern to instruction selector to utilize SMADDL supported by ARM64
+https://bugs.webkit.org/show_bug.cgi?id=227188
+
+Reviewed by Saam Barati.
+
+Signed Multiply-Add Long(SMADDL), supported by ARM64, multiplies two 32-bit 
+register values, adds a 64-bit register value, and writes the result to the 
+64-bit destination register. The instruction selector can utilize this to 
+lowering certain patterns in B3 IR before further Air optimization. 
+
+Given the operation:
+
+smaddl d, n, m, a
+
+The equivalent patterns would be:
+
+d = a + SExt32(n) * SExt32(m)
+d = SExt32(n) * SExt32(m) + a
+
+Given B3 IR:
+Int @0 = ArgumentReg(%x0)
+Int @1 = SExt32(Trunc(ArgumentReg(%x1)))
+Int @2 = SExt32(Trunc(ArgumentReg(%x2)))
+Int @3 = Mul(@1, @2)
+Int @4 = Add(@0, @3)
+Void@5 = Return(@4, Terminal)
+
+Before Adding SMADDL:
+// Old optimized AIR
+SignExtend32ToPtr  %x1, %x1,   @1
+SignExtend32ToPtr  %x2, %x2,   @2
+MultiplyAdd64  %x1, %x2, %x0, %x0, @4
+Ret64  %x0,@5
+
+After Adding SMADDL:
+// New optimized AIR
+MultiplyAddSignExtend32 %x1, %x2, %x0, %x0, @8
+Ret64   %x0,@9
+
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::multiplyAddSignExtend32):
+* assembler/testmasm.cpp:
+(JSC::testMultiplyAddSignExtend32Left):
+(JSC::testMultiplyAddSignExtend32Right):
+* b3/B3LowerToAir.cpp:
+* b3/air/AirOpcode.opcodes:
+* b3/testb3.h:
+* b3/testb3_2.cpp:
+(testMulAddArg):
+(testMulAddArgsLeft):
+(testMulAddArgsRight):
+(testMulAddSignExtend32ArgsLeft):
+(testMulAddSignExtend32ArgsRight):
+(testMulAddArgsLeft32):
+(testMulAddArgsRight32):
+* b3/testb3_3.cpp:
+(addArgTests):
+
 2021-06-22  Saam Barati  
 
 jitCompileAndSetHeuristics shouldn't return true when we fail to compile


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h (279133 => 279134)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h	2021-06-22 18:49:09 UTC (rev 279133)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h	2021-06-22 18:53:40 UTC (rev 279134)
@@

[webkit-changes] [279133] trunk/Source/WebKit

2021-06-22 Thread jer . noble

Title: [279133] trunk/Source/WebKit








Revision 279133
Author jer.no...@apple.com
Date 2021-06-22 11:49:09 -0700 (Tue, 22 Jun 2021)


Log Message
[Cocoa] Upstream GroupActivitiesCoordinator
https://bugs.webkit.org/show_bug.cgi?id=226757

Reviewed by Eric Carlson.

Upstream the backing objects for a GroupActivities-based MediaSessionCoordinator.

* SourcesCocoa.txt:
* UIProcess/Cocoa/GroupActivities/GroupActivitiesCoordinator.h: Added.
* UIProcess/Cocoa/GroupActivities/GroupActivitiesCoordinator.mm: Added.
(-[WKGroupActivitiesCoordinatorDelegate initWithParent:]):
(-[WKGroupActivitiesCoordinatorDelegate playbackCoordinator:didIssuePlayCommand:completionHandler:]):
(-[WKGroupActivitiesCoordinatorDelegate playbackCoordinator:didIssuePauseCommand:completionHandler:]):
(-[WKGroupActivitiesCoordinatorDelegate playbackCoordinator:didIssueSeekCommand:completionHandler:]):
(-[WKGroupActivitiesCoordinatorDelegate playbackCoordinator:didIssueBufferingCommand:completionHandler:]):
(-[WKGroupActivitiesCoordinatorDelegate playbackCoordinator:didIssuePrepareTransitionCommand:]):
(WebKit::GroupActivitiesCoordinator::create):
(WebKit::GroupActivitiesCoordinator::GroupActivitiesCoordinator):
(WebKit::GroupActivitiesCoordinator::~GroupActivitiesCoordinator):
(WebKit::GroupActivitiesCoordinator::sessionStateChanged):
(WebKit::GroupActivitiesCoordinator::identifier const):
(WebKit::GroupActivitiesCoordinator::join):
(WebKit::GroupActivitiesCoordinator::leave):
(WebKit::GroupActivitiesCoordinator::seekTo):
(WebKit::GroupActivitiesCoordinator::play):
(WebKit::GroupActivitiesCoordinator::pause):
(WebKit::GroupActivitiesCoordinator::setTrack):
(WebKit::GroupActivitiesCoordinator::positionStateChanged):
(WebKit::GroupActivitiesCoordinator::readyStateChanged):
(WebKit::GroupActivitiesCoordinator::playbackStateChanged):
(WebKit::GroupActivitiesCoordinator::trackIdentifierChanged):
(WebKit::GroupActivitiesCoordinator::issuePlayCommand):
(WebKit::GroupActivitiesCoordinator::issuePauseCommand):
(WebKit::GroupActivitiesCoordinator::issueSeekCommand):
(WebKit::GroupActivitiesCoordinator::issueBufferingCommand):
(WebKit::GroupActivitiesCoordinator::issuePrepareTransitionCommand):
* UIProcess/Cocoa/GroupActivities/GroupActivitiesSession.h: Added.
(WebKit::GroupActivitiesSession::groupSession):
* UIProcess/Cocoa/GroupActivities/GroupActivitiesSession.mm: Added.
(WebKit::GroupActivitiesSession::create):
(WebKit::GroupActivitiesSession::GroupActivitiesSession):
(WebKit::GroupActivitiesSession::~GroupActivitiesSession):
(WebKit::GroupActivitiesSession::join):
(WebKit::GroupActivitiesSession::leave):
(WebKit::GroupActivitiesSession::state const):
(WebKit::GroupActivitiesSession::uuid const):
(WebKit::GroupActivitiesSession::fallbackURL const):
(WebKit::GroupActivitiesSession::addStateChangeObserver):
(WebKit::GroupActivitiesSession::addFallbackURLObserver):
* UIProcess/Cocoa/GroupActivities/GroupActivitiesSessionNotifier.h: Added.
* UIProcess/Cocoa/GroupActivities/GroupActivitiesSessionNotifier.mm: Added.
(WebKitSwiftLibrary):
(WebKit::GroupActivitiesSessionNotifier::sharedNotifier):
(WebKit::GroupActivitiesSessionNotifier::GroupActivitiesSessionNotifier):
(WebKit::GroupActivitiesSessionNotifier::sessionStateChanged):
(WebKit::GroupActivitiesSessionNotifier::addWebPage):
(WebKit::GroupActivitiesSessionNotifier::removeWebPage):
(WebKit::GroupActivitiesSessionNotifier::webPageURLChanged):
(WebKit::GroupActivitiesSessionNotifier::hasSessionForURL):
(WebKit::GroupActivitiesSessionNotifier::takeSessionForURL):
* UIProcess/Cocoa/GroupActivities/WKGroupSession.h: Added.
* UIProcess/Cocoa/GroupActivities/WKGroupSession.swift: Added.
(WKURLActivityWrapper.urlActivity):
(WKURLActivityWrapper.fallbackURL):
(WKGroupSessionWrapper.groupSession):
(WKGroupSessionWrapper.cancellables):
(WKGroupSessionWrapper.activity):
(WKGroupSessionWrapper.uuid):
(WKGroupSessionWrapper.wrapperSessionState(_:)):
(WKGroupSessionWrapper.state):
(WKGroupSessionWrapper.newActivityCallback):
(WKGroupSessionWrapper.stateChangedCallback):
(WKGroupSessionWrapper.join):
(WKGroupSessionWrapper.leave):
(WKGroupSessionWrapper.coordinate(_:)):
(WKGroupSessionWrapper.activityChanged(_:)):
(WKGroupSessionWrapper.stateChanged(_:)):
(WKGroupSessionObserver.newSessionCallback):
(WKGroupSessionObserver.cancellables):
(WKGroupSessionObserver.recievedSession(_:)):
* UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::didCommitLoadForFrame):
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/UIProcess/Cocoa/GroupActivities/

[webkit-changes] [279132] trunk/JSTests

2021-06-22 Thread sbarati

Title: [279132] trunk/JSTests








Revision 279132
Author sbar...@apple.com
Date 2021-06-22 11:48:07 -0700 (Tue, 22 Jun 2021)


Log Message
Don't assume stress/out-of-memory-while-constructing-BytecodeGenerator.js will OOM
https://bugs.webkit.org/show_bug.cgi?id=227263

Reviewed by Yusuke Suzuki.

* stress/out-of-memory-while-constructing-BytecodeGenerator.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/out-of-memory-while-constructing-BytecodeGenerator.js




Diff

Modified: trunk/JSTests/ChangeLog (279131 => 279132)

--- trunk/JSTests/ChangeLog	2021-06-22 18:44:45 UTC (rev 279131)
+++ trunk/JSTests/ChangeLog	2021-06-22 18:48:07 UTC (rev 279132)
@@ -1,5 +1,14 @@
 2021-06-22  Saam Barati  
 
+Don't assume stress/out-of-memory-while-constructing-BytecodeGenerator.js will OOM
+https://bugs.webkit.org/show_bug.cgi?id=227263
+
+Reviewed by Yusuke Suzuki.
+
+* stress/out-of-memory-while-constructing-BytecodeGenerator.js:
+
+2021-06-22  Saam Barati  
+
 Run detach-buffer-during-iteration for fewer iterations
 https://bugs.webkit.org/show_bug.cgi?id=227262
 


Modified: trunk/JSTests/stress/out-of-memory-while-constructing-BytecodeGenerator.js (279131 => 279132)

--- trunk/JSTests/stress/out-of-memory-while-constructing-BytecodeGenerator.js	2021-06-22 18:44:45 UTC (rev 279131)
+++ trunk/JSTests/stress/out-of-memory-while-constructing-BytecodeGenerator.js	2021-06-22 18:48:07 UTC (rev 279132)
@@ -29,5 +29,5 @@
 exception = e;
 }
 
-if (exception != "RangeError: Out of memory")
+if (exception && exception != "RangeError: Out of memory")
 throw "FAIL";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279131] trunk/LayoutTests

2021-06-22 Thread commit-queue

Title: [279131] trunk/LayoutTests








Revision 279131
Author commit-qu...@webkit.org
Date 2021-06-22 11:44:45 -0700 (Tue, 22 Jun 2021)


Log Message
[GLIB] Unreviewed test gardening, add timeouts in new test
https://bugs.webkit.org/show_bug.cgi?id=227258

media/media-source/media-source-has-audio-video.html and
media/media-source/media-source-seek-unbuffered.html
have timed on GTK and WPE since they were added.

Patch by Arcady Goldmints-Orlov  on 2021-06-22

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279130 => 279131)

--- trunk/LayoutTests/ChangeLog	2021-06-22 18:33:24 UTC (rev 279130)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 18:44:45 UTC (rev 279131)
@@ -1,3 +1,14 @@
+2021-06-22  Arcady Goldmints-Orlov  
+
+[GLIB] Unreviewed test gardening, add timeouts in new test
+https://bugs.webkit.org/show_bug.cgi?id=227258
+
+media/media-source/media-source-has-audio-video.html and
+media/media-source/media-source-seek-unbuffered.html
+have timed on GTK and WPE since they were added.
+
+* platform/glib/TestExpectations:
+
 2021-06-22  Simon Fraser  
 
 REGRESSION (Safari 14): Submenus on https://codelearn.cat don't show


Modified: trunk/LayoutTests/platform/glib/TestExpectations (279130 => 279131)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-06-22 18:33:24 UTC (rev 279130)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-06-22 18:44:45 UTC (rev 279131)
@@ -595,6 +595,9 @@
 
 webkit.org/b/199617 http/tests/media/hls/hls-video-resize.html [ Skip ]
 
+webkit.org/b/227258 media/media-source/media-source-has-audio-video.html [ Timeout ]
+webkit.org/b/227258 media/media-source/media-source-seek-unbuffered.html [ Timeout ]
+
 #
 # End of GStreamer-related bugs
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279130] trunk

2021-06-22 Thread simon . fraser

Title: [279130] trunk








Revision 279130
Author simon.fra...@apple.com
Date 2021-06-22 11:33:24 -0700 (Tue, 22 Jun 2021)


Log Message
REGRESSION (Safari 14): Submenus on https://codelearn.cat don't show
https://bugs.webkit.org/show_bug.cgi?id=225467


Reviewed by Alan Bujtas.
Source/WebCore:

RenderBox::requiresLayerWithScrollableArea() is called via RenderLayer::styleChanged()
which is before layout, yet requiresLayerWithScrollableArea() was consulting layout-dependent
state under hasHorizontalOverflow() || hasVerticalOverflow(). This resulted in composited
scrolling layers sticking around after overflow style changed from `scroll` to `visible`.

Fix by just removing the "has overflow" checks; we make RenderLayerScrollableArea
for any non-visible overflow anyway. scrollsOverflow() checks hasOverflowClip(),
so all we need is a hasOverflowClip() check.

Remove some redundant comments and add a FIXME about layers which get RenderLayerScrollableAreas
but don't need them.

Test: compositing/overflow/overflow-scroll-to-visible.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::requiresLayerWithScrollableArea const):

LayoutTests:

* compositing/overflow/overflow-scroll-to-visible-expected.html: Added.
* compositing/overflow/overflow-scroll-to-visible.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/compositing/overflow/overflow-scroll-to-visible-expected.html
trunk/LayoutTests/compositing/overflow/overflow-scroll-to-visible.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279129 => 279130)

--- trunk/LayoutTests/ChangeLog	2021-06-22 18:18:30 UTC (rev 279129)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 18:33:24 UTC (rev 279130)
@@ -1,3 +1,14 @@
+2021-06-22  Simon Fraser  
+
+REGRESSION (Safari 14): Submenus on https://codelearn.cat don't show
+https://bugs.webkit.org/show_bug.cgi?id=225467
+
+
+Reviewed by Alan Bujtas.
+
+* compositing/overflow/overflow-scroll-to-visible-expected.html: Added.
+* compositing/overflow/overflow-scroll-to-visible.html: Added.
+
 2021-06-22  Chris Dumez  
 
 CSSStyleDeclaration.getPropertyPriority() should return the empty string for invalid CSS properties


Added: trunk/LayoutTests/compositing/overflow/overflow-scroll-to-visible-expected.html (0 => 279130)

--- trunk/LayoutTests/compositing/overflow/overflow-scroll-to-visible-expected.html	(rev 0)
+++ trunk/LayoutTests/compositing/overflow/overflow-scroll-to-visible-expected.html	2021-06-22 18:33:24 UTC (rev 279130)
@@ -0,0 +1,29 @@
+ 
+
+
+
+.scroller {
+border: 1px solid black;
+margin: 10px;
+padding: 10px;
+overflow: visible;
+transform: translateZ(0px);
+}
+
+.box {
+position: absolute;
+width: 100px;
+height: 100px;
+border: 2px solid blue;
+background-color: green;
+padding: 10px;
+}
+
+
+
+
+You should see the entire green box below
+
+
+
+


Added: trunk/LayoutTests/compositing/overflow/overflow-scroll-to-visible.html (0 => 279130)

--- trunk/LayoutTests/compositing/overflow/overflow-scroll-to-visible.html	(rev 0)
+++ trunk/LayoutTests/compositing/overflow/overflow-scroll-to-visible.html	2021-06-22 18:33:24 UTC (rev 279130)
@@ -0,0 +1,45 @@
+ 
+
+
+
+.scroller {
+border: 1px solid black;
+margin: 10px;
+padding: 10px;
+overflow: scroll;
+transform: translateZ(0px);
+}
+
+.box {
+position: absolute;
+width: 100px;
+height: 100px;
+border: 2px solid blue;
+background-color: green;
+padding: 10px;
+}
+
+body.changed .scroller {
+overflow: visible;
+}
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+window.addEventListener('load', () => {
+requestAnimationFrame(() => {
+document.body.classList.add('changed');
+if (window.testRunner)
+testRunner.notifyDone();
+});
+}, false);
+
+
+
+
+You should see the entire green box below
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (279129 => 279130)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 18:18:30 UTC (rev 279129)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 18:33:24 UTC (rev 279130)
@@ -1,3 +1,28 @@
+2021-06-22  Simon Fraser  
+
+REGRESSION (Safari 14): Submenus on https://codelearn.cat don't show
+https://bugs.webkit.org/show_bug.cgi?id=225467
+
+
+Reviewed by Alan Bujtas.
+
+RenderBox::requiresLayerWithScrollableArea() is called

[webkit-changes] [279129] trunk/JSTests

2021-06-22 Thread sbarati

Title: [279129] trunk/JSTests








Revision 279129
Author sbar...@apple.com
Date 2021-06-22 11:18:30 -0700 (Tue, 22 Jun 2021)


Log Message
Run detach-buffer-during-iteration for fewer iterations
https://bugs.webkit.org/show_bug.cgi?id=227262

Reviewed by Yusuke Suzuki.

* stress/detach-buffer-during-iteration.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/detach-buffer-during-iteration.js




Diff

Modified: trunk/JSTests/ChangeLog (279128 => 279129)

--- trunk/JSTests/ChangeLog	2021-06-22 18:08:19 UTC (rev 279128)
+++ trunk/JSTests/ChangeLog	2021-06-22 18:18:30 UTC (rev 279129)
@@ -1,5 +1,14 @@
 2021-06-22  Saam Barati  
 
+Run detach-buffer-during-iteration for fewer iterations
+https://bugs.webkit.org/show_bug.cgi?id=227262
+
+Reviewed by Yusuke Suzuki.
+
+* stress/detach-buffer-during-iteration.js:
+
+2021-06-22  Saam Barati  
+
 Run microbenchmarks/interpreter-wasm under runDefault only
 https://bugs.webkit.org/show_bug.cgi?id=227261
 


Modified: trunk/JSTests/stress/detach-buffer-during-iteration.js (279128 => 279129)

--- trunk/JSTests/stress/detach-buffer-during-iteration.js	2021-06-22 18:08:19 UTC (rev 279128)
+++ trunk/JSTests/stress/detach-buffer-during-iteration.js	2021-06-22 18:18:30 UTC (rev 279129)
@@ -10,5 +10,5 @@
 }
 noInline(test);
 
-for (var i = 0; i < 1e6; i++)
+for (var i = 0; i < 1e4; i++)
   test();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279128] trunk/JSTests

2021-06-22 Thread sbarati

Title: [279128] trunk/JSTests








Revision 279128
Author sbar...@apple.com
Date 2021-06-22 11:08:19 -0700 (Tue, 22 Jun 2021)


Log Message
Run microbenchmarks/interpreter-wasm under runDefault only
https://bugs.webkit.org/show_bug.cgi?id=227261

Reviewed by Robin Morisset.

* microbenchmarks/interpreter-wasm.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/microbenchmarks/interpreter-wasm.js




Diff

Modified: trunk/JSTests/ChangeLog (279127 => 279128)

--- trunk/JSTests/ChangeLog	2021-06-22 18:04:57 UTC (rev 279127)
+++ trunk/JSTests/ChangeLog	2021-06-22 18:08:19 UTC (rev 279128)
@@ -1,5 +1,14 @@
 2021-06-22  Saam Barati  
 
+Run microbenchmarks/interpreter-wasm under runDefault only
+https://bugs.webkit.org/show_bug.cgi?id=227261
+
+Reviewed by Robin Morisset.
+
+* microbenchmarks/interpreter-wasm.js:
+
+2021-06-22  Saam Barati  
+
 jitCompileAndSetHeuristics shouldn't return true when we fail to compile
 https://bugs.webkit.org/show_bug.cgi?id=227155
 


Modified: trunk/JSTests/microbenchmarks/interpreter-wasm.js (279127 => 279128)

--- trunk/JSTests/microbenchmarks/interpreter-wasm.js	2021-06-22 18:04:57 UTC (rev 279127)
+++ trunk/JSTests/microbenchmarks/interpreter-wasm.js	2021-06-22 18:08:19 UTC (rev 279128)
@@ -1,3 +1,3 @@
 //@ skip if $architecture == "arm" or $architecture == "mips" or $model =~ /Apple Watch/
-//@ requireOptions("--useExecutableAllocationFuzz=false")
+//@ runDefault
 var Module=typeof Module!=="undefined"?Module:{};var moduleOverrides={};var key;for(key in Module){if(Module.hasOwnProperty(key)){moduleOverrides[key]=Module[key]}}var arguments_=[];var thisProgram="./this.program";var quit_=function(status,toThrow){throw toThrow};var ENVIRONMENT_IS_WEB=false;var ENVIRONMENT_IS_WORKER=false;var ENVIRONMENT_IS_NODE=false;var ENVIRONMENT_IS_SHELL=false;ENVIRONMENT_IS_WEB=typeof window==="object";ENVIRONMENT_IS_WORKER=typeof importScripts==="function";ENVIRONMENT_IS_NODE=typeof process==="object"& process.versions==="object"& process.versions.node==="string";ENVIRONMENT_IS_SHELL=!ENVIRONMENT_IS_WEB&&!ENVIRONMENT_IS_NODE&&!ENVIRONMENT_IS_WORKER;var scriptDirectory="";function locateFile(path){if(Module["locateFile"]){return Module["locateFile"](path,scriptDirectory)}return scriptDirector
 y+path}var read_,readAsync,readBinary,setWindowTitle;var nodeFS;var nodePath;if(ENVIRONMENT_IS_NODE){if(ENVIRONMENT_IS_WORKER){scriptDirectory=require("path").dirname(scriptDirectory)+"/"}else{scriptDirectory=__dirname+"/"}read_=function shell_read(filename,binary){if(!nodeFS)nodeFS=require("fs");if(!nodePath)nodePath=require("path");filename=nodePath["normalize"](filename);return nodeFS["readFileSync"](filename,binary?null:"utf8")};readBinary=function readBinary(filename){var ret=read_(filename,true);if(!ret.buffer){ret=new Uint8Array(ret)}assert(ret.buffer);return ret};if(process["argv"].length>1){thisProgram=process["argv"][1].replace(/\\/g,"/")}arguments_=process["argv"].slice(2);if(typeof module!=="undefined"){module["exports"]=Module}process["on"]("uncaughtException",function(ex){if(!(ex instanceof ExitStatus)){throw
  ex}});process["on"]("unhandledRejection",abort);quit_=function(status){process["exit"](status)};Module["inspect"]=function(){return"[Emscripten Module object]"}}else if(ENVIRONMENT_IS_SHELL){if(typeof read!="undefined"){read_=function shell_read(f){return read(f)}}readBinary=function readBinary(f){var data;if(typeof readbuffer==="function"){return new Uint8Array(readbuffer(f))}data="" data="" data};if(typeof scriptArgs!="undefined"){arguments_=scriptArgs}else if(typeof arguments!="undefined"){arguments_=arguments}if(typeof quit==="function"){quit_=function(status){quit(status)}}if(typeof print!=="undefined"){if(typeof console==="undefined")console={};console.log=print;console.warn=console.error=typeof printErr!=="undefined"?printErr:print}}else if(ENVIRONMENT_IS_WEB||ENVIRONMENT_IS_WORKER){i
 f(ENVIRONMENT_IS_WORKER){scriptDirectory=self.location.href}else if(document.currentScript){scriptDirectory=document.currentScript.src}if(scriptDirectory.indexOf("blob:")!==0){scriptDirectory=scriptDirectory.substr(0,scriptDirectory.lastIndexOf("/")+1)}else{scriptDirectory=""}{read_=function shell_read(url){var xhr=new XMLHttpRequest;xhr.open("GET",url,false);xhr.send(null);return xhr.responseText};if(ENVIRONMENT_IS_WORKER){readBinary=function readBinary(url){var xhr=new XMLHttpRequest;xhr.open("GET",url,false);xhr.responseType="arraybuffer";xhr.send(null);return new Uint8Array(xhr.response)}}readAsync=function readAsync(url,onload,onerror){var xhr=new XMLHttpRequest;xhr.open("GET",url,true);xhr.responseType="arraybuffer";xhr._onload_=function xhr_onload(){if(xhr.status==200||xhr.status==0&){onload(xhr.response);return}onerror()};xhr._onerror_=onerror;xhr.send(null)}}setWindowTitle=funct
 ion(title){document.title=title}}else{}var out=Module["print"]||console.log.bind(console);var

[webkit-changes] [279127] tags/Safari-611.3.10/

2021-06-22 Thread alancoon

Title: [279127] tags/Safari-611.3.10/








Revision 279127
Author alanc...@apple.com
Date 2021-06-22 11:04:57 -0700 (Tue, 22 Jun 2021)


Log Message
Tag Safari-611.3.10.

Added Paths

tags/Safari-611.3.10/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279126] trunk

2021-06-22 Thread sbarati

Title: [279126] trunk








Revision 279126
Author sbar...@apple.com
Date 2021-06-22 10:48:42 -0700 (Tue, 22 Jun 2021)


Log Message
jitCompileAndSetHeuristics shouldn't return true when we fail to compile
https://bugs.webkit.org/show_bug.cgi?id=227155

Reviewed by Tadeu Zagallo.

JSTests:

* microbenchmarks/interpreter-wasm.js:
* microbenchmarks/memcpy-wasm-large.js:
* microbenchmarks/memcpy-wasm-medium.js:
* microbenchmarks/memcpy-wasm-small.js:
* microbenchmarks/memcpy-wasm.js:
* stress/wasm-error-message-cross-threads.js:

Source/_javascript_Core:

jitCompileAndSetHeuristics should only return true when we've successfully
compiled a baseline JIT CodeBlock. However, with the rewrite to using a
unified JIT worklist, the code was changed to returning true when a
compilation finished, regardless of it being successful or not. This patch
fixes that error.

This bug was found by our existing executable allocation fuzzer, but at a low
hit rate. That fuzzer only ran a single test case. This patch also introduces
a new form of the executable fuzzer where we fail to allocate JIT code
randomly, and the crash manifests more reliably. And this patch also hooks
the new fuzzer into more JSC stress tests.

* dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
* jit/ExecutableAllocationFuzz.cpp:
(JSC::doExecutableAllocationFuzzing):
* jsc.cpp:
(runJSC):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/OptionsList.h:

Source/WTF:

* wtf/WeakRandom.h:

Tools:

* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/microbenchmarks/interpreter-wasm.js
trunk/JSTests/microbenchmarks/memcpy-wasm-large.js
trunk/JSTests/microbenchmarks/memcpy-wasm-medium.js
trunk/JSTests/microbenchmarks/memcpy-wasm-small.js
trunk/JSTests/microbenchmarks/memcpy-wasm.js
trunk/JSTests/stress/wasm-error-message-cross-threads.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGLICMPhase.cpp
trunk/Source/_javascript_Core/jit/ExecutableAllocationFuzz.cpp
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/OptionsList.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/WeakRandom.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/JSTests/ChangeLog (279125 => 279126)

--- trunk/JSTests/ChangeLog	2021-06-22 17:43:15 UTC (rev 279125)
+++ trunk/JSTests/ChangeLog	2021-06-22 17:48:42 UTC (rev 279126)
@@ -1,3 +1,17 @@
+2021-06-22  Saam Barati  
+
+jitCompileAndSetHeuristics shouldn't return true when we fail to compile
+https://bugs.webkit.org/show_bug.cgi?id=227155
+
+Reviewed by Tadeu Zagallo.
+
+* microbenchmarks/interpreter-wasm.js:
+* microbenchmarks/memcpy-wasm-large.js:
+* microbenchmarks/memcpy-wasm-medium.js:
+* microbenchmarks/memcpy-wasm-small.js:
+* microbenchmarks/memcpy-wasm.js:
+* stress/wasm-error-message-cross-threads.js:
+
 2021-06-22  Angelos Oikonomopoulos  
 
 Unskip stress/elidable-new-object-roflcopter-then-exit.js on MIPS/ARM


Modified: trunk/JSTests/microbenchmarks/interpreter-wasm.js (279125 => 279126)

--- trunk/JSTests/microbenchmarks/interpreter-wasm.js	2021-06-22 17:43:15 UTC (rev 279125)
+++ trunk/JSTests/microbenchmarks/interpreter-wasm.js	2021-06-22 17:48:42 UTC (rev 279126)
@@ -1,2 +1,3 @@
 //@ skip if $architecture == "arm" or $architecture == "mips" or $model =~ /Apple Watch/
+//@ requireOptions("--useExecutableAllocationFuzz=false")
 var Module=typeof Module!=="undefined"?Module:{};var moduleOverrides={};var key;for(key in Module){if(Module.hasOwnProperty(key)){moduleOverrides[key]=Module[key]}}var arguments_=[];var thisProgram="./this.program";var quit_=function(status,toThrow){throw toThrow};var ENVIRONMENT_IS_WEB=false;var ENVIRONMENT_IS_WORKER=false;var ENVIRONMENT_IS_NODE=false;var ENVIRONMENT_IS_SHELL=false;ENVIRONMENT_IS_WEB=typeof window==="object";ENVIRONMENT_IS_WORKER=typeof importScripts==="function";ENVIRONMENT_IS_NODE=typeof process==="object"& process.versions==="object"& process.versions.node==="string";ENVIRONMENT_IS_SHELL=!ENVIRONMENT_IS_WEB&&!ENVIRONMENT_IS_NODE&&!ENVIRONMENT_IS_WORKER;var scriptDirectory="";function locateFile(path){if(Module["locateFile"]){return Module["locateFile"](path,scriptDirectory)}return scriptDirector
 y+path}var read_,readAsync,readBinary,setWindowTitle;var nodeFS;var nodePath;if(ENVIRONMENT_IS_NODE){if(ENVIRONMENT_IS_WORKER){scriptDirectory=require("path").dirname(scriptDirectory)+"/"}else{scriptDirectory=__dirname+"/"}read_=function shell_read(filename,binary){if(!nodeFS)nodeFS=require("fs");if(!nodePath)nodePath=require("path");filename=nodePath["normalize"](filename);return nodeFS["readFileSync"](filename,binary?null:"utf8")};readBinary=function readBinary(filename){var ret=read_(filename,true);if(!ret.buffer){ret=new

[webkit-changes] [279125] trunk

2021-06-22 Thread cdumez

Title: [279125] trunk








Revision 279125
Author cdu...@apple.com
Date 2021-06-22 10:43:15 -0700 (Tue, 22 Jun 2021)


Log Message
CSSStyleDeclaration.getPropertyPriority() should return the empty string for invalid CSS properties
https://bugs.webkit.org/show_bug.cgi?id=227257

Reviewed by Geoffrey Garen.

Source/WebCore:

CSSStyleDeclaration.getPropertyPriority() should return the empty string for invalid CSS properties,
not null. Corresponding specification:
- https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue

Gecko and Blink match the specification here so changing our behavior improves compatibility.

Also use CSSOMString instead of DOMString in the CSSStyleDeclaration IDL to match the specification,
since I was modifying the IDL.

Test: fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
* css/CSSStyleDeclaration.idl:
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):

LayoutTests:

Add layout test coverage.

* fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property-expected.txt: Added.
* fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSStyleDeclaration.idl
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property-expected.txt
trunk/LayoutTests/fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279124 => 279125)

--- trunk/LayoutTests/ChangeLog	2021-06-22 17:36:55 UTC (rev 279124)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 17:43:15 UTC (rev 279125)
@@ -1,3 +1,15 @@
+2021-06-22  Chris Dumez  
+
+CSSStyleDeclaration.getPropertyPriority() should return the empty string for invalid CSS properties
+https://bugs.webkit.org/show_bug.cgi?id=227257
+
+Reviewed by Geoffrey Garen.
+
+Add layout test coverage.
+
+* fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property-expected.txt: Added.
+* fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property.html: Added.
+
 2021-06-22  Per Arne Vollan  
 
 [AppleWin] Update test expectations


Added: trunk/LayoutTests/fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property-expected.txt (0 => 279125)

--- trunk/LayoutTests/fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property-expected.txt	2021-06-22 17:43:15 UTC (rev 279125)
@@ -0,0 +1,11 @@
+Checks that CSSStyleDeclaration.getPropertyPriority() returns the empty string for invalid CSS properties.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS declaration.getPropertyPriority('invalidProperty') is ""
+PASS declaration.getPropertyPriority('margin') is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property.html (0 => 279125)

--- trunk/LayoutTests/fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property.html	(rev 0)
+++ trunk/LayoutTests/fast/css/CSSStyleDeclaration-getPropertyPriority-invalid-property.html	2021-06-22 17:43:15 UTC (rev 279125)
@@ -0,0 +1,13 @@
+
+
+
+
+description("Checks that CSSStyleDeclaration.getPropertyPriority() returns the empty string for invalid CSS properties.");
+
+var declaration = document.styleSheets[0].cssRules[0].style;
+shouldBeEqualToString("declaration.getPropertyPriority('invalidProperty')", "");
+shouldBeEqualToString("declaration.getPropertyPriority('margin')", "");
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (279124 => 279125)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 17:36:55 UTC (rev 279124)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 17:43:15 UTC (rev 279125)
@@ -1,3 +1,27 @@
+2021-06-22  Chris Dumez  
+
+CSSStyleDeclaration.getPropertyPriority() should return the empty string for invalid CSS properties
+https://bugs.webkit.org/show_bug.cgi?id=227257
+
+Reviewed by Geoffrey Garen.
+
+CSSStyleDeclaration.getPropertyPriority() should return the empty string for invalid CSS properties,
+not null. Corresponding specification:
+- https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue
+
+Gecko and Blink match the specification here so changing our behavior improves compatibility.
+
+Also use CSSOMString instead of DOMString in the CSSStyleDeclaration IDL to match the specification,
+since I was modifying the IDL.
+
+Test:

[webkit-changes] [279124] branches/safari-611-branch/Source/ThirdParty/libwebrtc

2021-06-22 Thread alancoon

Title: [279124] branches/safari-611-branch/Source/ThirdParty/libwebrtc








Revision 279124
Author alanc...@apple.com
Date 2021-06-22 10:36:55 -0700 (Tue, 22 Jun 2021)


Log Message
Revert r279011. rdar://problem/79474211

This reverts commit r279021.

Modified Paths

branches/safari-611-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-611-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp
branches/safari-611-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp




Diff

Modified: branches/safari-611-branch/Source/ThirdParty/libwebrtc/ChangeLog (279123 => 279124)

--- branches/safari-611-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 17:30:16 UTC (rev 279123)
+++ branches/safari-611-branch/Source/ThirdParty/libwebrtc/ChangeLog	2021-06-22 17:36:55 UTC (rev 279124)
@@ -1,36 +1,3 @@
-2021-06-17  Alan Coon  
-
-Cherry-pick r279011. rdar://problem/79474211
-
-[Mac] libwebrtc CMBaseClass objects need alignment fixup
-https://bugs.webkit.org/show_bug.cgi?id=227137
-
-Reviewed by Youenn Fablet.
-
-* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
-(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on x86_64
-so function pointers are naturally aligned. Add static_asserts to ensure alignment
-and sizes are correct.
-* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
-(webrtc::createWebKitVP9Decoder): Ditto.
-
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2021-06-17  Eric Carlson  
-
-[Mac] libwebrtc CMBaseClass objects need alignment fixup
-https://bugs.webkit.org/show_bug.cgi?id=227137
-
-Reviewed by Youenn Fablet.
-
-* Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
-(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on x86_64
-so function pointers are naturally aligned. Add static_asserts to ensure alignment
-and sizes are correct.
-* Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
-(webrtc::createWebKitVP9Decoder): Ditto.
-
 2021-06-15  Alan Coon  
 
 Cherry-pick r278410. rdar://problem/79355285


Modified: branches/safari-611-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp (279123 => 279124)

--- branches/safari-611-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp	2021-06-22 17:30:16 UTC (rev 279123)
+++ branches/safari-611-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp	2021-06-22 17:36:55 UTC (rev 279124)
@@ -47,34 +47,20 @@
 static void finalizeVP8Decoder(CMBaseObjectRef);
 static CFStringRef copyVP8DecoderDebugDescription(CMBaseObjectRef);
 
-#if defined(__x86_64__) || defined(_M_X64)
-constexpr size_t padSize = 4;
-#else
-constexpr size_t padSize = 0;
-#endif
+static const CMBaseClass WebKitVP8Decoder_BaseClass =
+{
+kCMBaseObject_ClassVersion_1,
+sizeof(WebKitVP8Decoder),
+nullptr, // Comparison by pointer equality
+invalidateVP8Decoder,
+finalizeVP8Decoder,
+copyVP8DecoderDebugDescription,
+nullptr, // CopyProperty
+nullptr, // SetProperty
+nullptr,
+nullptr
+};
 
-#pragma pack(push, 4)
-struct DecoderClass { uint8_t pad[padSize]; CMBaseClass alignedClass; } WebKitVP8Decoder_BaseClass { { }, {
-kCMBaseObject_ClassVersion_1,
-sizeof(WebKitVP8Decoder),
-nullptr, // Comparison by pointer equality
-invalidateVP8Decoder,
-finalizeVP8Decoder,
-copyVP8DecoderDebugDescription,
-nullptr, // CopyProperty
-nullptr, // SetProperty
-nullptr,
-nullptr
-} };
-#pragma pack(pop)
-
-#if defined(__x86_64__) || defined(_M_X64)
-static_assert(sizeof(WebKitVP8Decoder_BaseClass.alignedClass.version) != sizeof(void*), "CMBaseClass fixup is required on X86_64");
-#else
-static_assert(sizeof(WebKitVP8Decoder_BaseClass.alignedClass.version) == sizeof(void*), "CMBaseClass fixup only required on X86_64");
-#endif
-static_assert(alignof(DecoderClass) == 4, "CMBaseClass must have 4 byte alignment");
-
 static OSStatus startVP8DecoderSession(VTVideoDecoderRef, VTVideoDecoderSession, CMVideoFormatDescriptionRef);
 static OSStatus decodeVP8DecoderFrame(VTVideoDecoderRef, VTVideoDecoderFrame, CMSampleBufferRef, VTDecodeFrameFlags, VTDecodeInfoFlags*);
 
@@ -95,7 +81,7 @@
 
 static const VTVideoDecoderVTable WebKitVP8DecoderVTable =
 {
-{ nullptr, _BaseClass.alignedClass },
+{ nullptr, _BaseClass },
 _VideoDecoderClass
 };
 


Modified: branches/safari-611-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp (279123 => 279124)

--- branches/safari-611-branch/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp	2021-06-22 17:30:16 UTC (rev 279123)
+++

[webkit-changes] [279123] trunk/Source/WebCore

2021-06-22 Thread jya

Title: [279123] trunk/Source/WebCore








Revision 279123
Author j...@apple.com
Date 2021-06-22 10:30:16 -0700 (Tue, 22 Jun 2021)


Log Message
Remove unused method in AudioFileReader
https://bugs.webkit.org/show_bug.cgi?id=227208

Reviewed by Chris Dumez.

Remove two unused methods in AudioFileReader and their related constructors.

* platform/audio/AudioFileReader.h:
* platform/audio/cocoa/AudioFileReaderCocoa.cpp:
* platform/audio/cocoa/AudioFileReaderCocoa.h:
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::decodeAudioForBusCreation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/AudioFileReader.h
trunk/Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp
trunk/Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.h
trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (279122 => 279123)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 17:00:38 UTC (rev 279122)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 17:30:16 UTC (rev 279123)
@@ -1,3 +1,18 @@
+2021-06-22  Jean-Yves Avenard  
+
+Remove unused method in AudioFileReader
+https://bugs.webkit.org/show_bug.cgi?id=227208
+
+Reviewed by Chris Dumez.
+
+Remove two unused methods in AudioFileReader and their related constructors.
+
+* platform/audio/AudioFileReader.h:
+* platform/audio/cocoa/AudioFileReaderCocoa.cpp:
+* platform/audio/cocoa/AudioFileReaderCocoa.h:
+* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
+(WebCore::AudioFileReader::decodeAudioForBusCreation):
+
 2021-06-22  Jer Noble  
 
 [Cocoa] iOS device steals BT headphones from other devices during silent playback


Modified: trunk/Source/WebCore/platform/audio/AudioFileReader.h (279122 => 279123)

--- trunk/Source/WebCore/platform/audio/AudioFileReader.h	2021-06-22 17:00:38 UTC (rev 279122)
+++ trunk/Source/WebCore/platform/audio/AudioFileReader.h	2021-06-22 17:30:16 UTC (rev 279123)
@@ -26,8 +26,7 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef AudioFileReader_h
-#define AudioFileReader_h
+#pragma once
 
 #include 
 #include 
@@ -36,7 +35,6 @@
 
 class AudioBus;
 
-// For both create functions:
 // Pass in 0.0 for sampleRate to use the file's sample-rate, otherwise a sample-rate conversion to the requested
 // sampleRate will be made (if it doesn't already match the file's sample-rate).
 // The created buffer will have its sample-rate set correctly to the result.
@@ -43,11 +41,4 @@
 
 RefPtr createBusFromInMemoryAudioFile(const void* data, size_t dataSize, bool mixToMono, float sampleRate);
 
-RefPtr createBusFromAudioFile(const char* filePath, bool mixToMono, float sampleRate);
-
-// May pass in 0.0 for sampleRate in which case it will use the AudioBus's sampleRate   
-void writeBusToAudioFile(AudioBus* bus, const char* filePath, double fileSampleRate);
-
 } // namespace WebCore
-
-#endif // AudioFileReader_h


Modified: trunk/Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp (279122 => 279123)

--- trunk/Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp	2021-06-22 17:00:38 UTC (rev 279122)
+++ trunk/Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp	2021-06-22 17:30:16 UTC (rev 279123)
@@ -99,15 +99,6 @@
 return true;
 }
 
-AudioFileReader::AudioFileReader(const char* filePath)
-{
-auto filePathString = adoptCF(CFStringCreateWithCString(kCFAllocatorDefault, filePath, kCFStringEncodingUTF8));
-auto urlRef = adoptCF(CFURLCreateWithFileSystemPath(kCFAllocatorDefault, filePathString.get(), kCFURLPOSIXPathStyle, false));
-if (!urlRef)
-return;
-ExtAudioFileOpenURL(urlRef.get(), _extAudioFileRef);
-}
-
 AudioFileReader::AudioFileReader(const void* data, size_t dataSize)
 : m_data(data)
 , m_dataSize(dataSize)
@@ -270,12 +261,6 @@
 return audioBus;
 }
 
-RefPtr createBusFromAudioFile(const char* filePath, bool mixToMono, float sampleRate)
-{
-AudioFileReader reader(filePath);
-return reader.createBus(sampleRate, mixToMono);
-}
-
 RefPtr createBusFromInMemoryAudioFile(const void* data, size_t dataSize, bool mixToMono, float sampleRate)
 {
 AudioFileReader reader(data, dataSize);


Modified: trunk/Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.h (279122 => 279123)

--- trunk/Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.h	2021-06-22 17:00:38 UTC (rev 279122)
+++ trunk/Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.h	2021-06-22 17:30:16 UTC (rev 279123)
@@ -43,7 +43,6 @@
 
 class AudioFileReader {
 public:
-explicit AudioFileReader(const char* filePath);
 explicit AudioFileReader(const void* data, size_t dataSize);
 ~AudioFileReader();
 


Modified: trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp (279122 =>

[webkit-changes] [279122] trunk/Source/WebKit

2021-06-22 Thread peng . liu6

Title: [279122] trunk/Source/WebKit








Revision 279122
Author peng.l...@apple.com
Date 2021-06-22 10:00:38 -0700 (Tue, 22 Jun 2021)


Log Message
ASSERTION FAILED: videoFullscreenManager->client() == nullptr in WKFullScreenWindowController.mm
https://bugs.webkit.org/show_bug.cgi?id=227243

Reviewed by Eric Carlson.

`-[WKFullScreenWindowController windowDidExitFullScreen:]` needs to clear
its client like `-[WKFullScreenWindowController didExitPictureInPicture]` does.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController windowDidExitFullScreen:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (279121 => 279122)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 16:55:58 UTC (rev 279121)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 17:00:38 UTC (rev 279122)
@@ -1,3 +1,16 @@
+2021-06-22  Peng Liu  
+
+ASSERTION FAILED: videoFullscreenManager->client() == nullptr in WKFullScreenWindowController.mm
+https://bugs.webkit.org/show_bug.cgi?id=227243
+
+Reviewed by Eric Carlson.
+
+`-[WKFullScreenWindowController windowDidExitFullScreen:]` needs to clear
+its client like `-[WKFullScreenWindowController didExitPictureInPicture]` does.
+
+* UIProcess/mac/WKFullScreenWindowController.mm:
+(-[WKFullScreenWindowController windowDidExitFullScreen:]):
+
 2021-06-22  Truitt Savell  
 
 Unreviewed, reverting r279083.


Modified: trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm (279121 => 279122)

--- trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm	2021-06-22 16:55:58 UTC (rev 279121)
+++ trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm	2021-06-22 17:00:38 UTC (rev 279122)
@@ -698,6 +698,11 @@
 - (void)windowDidExitFullScreen:(NSNotification *)notification
 {
 [self finishedExitFullScreenAnimation:YES];
+
+if (auto* videoFullscreenManager = self._videoFullscreenManager) {
+ASSERT(videoFullscreenManager->client() == &_videoFullscreenManagerProxyClient);
+videoFullscreenManager->setClient(nullptr);
+}
 }
 
 - (NSWindow *)destinationWindowToExitFullScreenForWindow:(NSWindow *)window






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279121] branches/safari-611-branch/Source

2021-06-22 Thread alancoon

Title: [279121] branches/safari-611-branch/Source








Revision 279121
Author alanc...@apple.com
Date 2021-06-22 09:55:58 -0700 (Tue, 22 Jun 2021)


Log Message
Versioning.

WebKit-7611.3.10

Modified Paths

branches/safari-611-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279120 => 279121)

--- branches/safari-611-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-06-22 16:44:56 UTC (rev 279120)
+++ branches/safari-611-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-06-22 16:55:58 UTC (rev 279121)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279120 => 279121)

--- branches/safari-611-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-06-22 16:44:56 UTC (rev 279120)
+++ branches/safari-611-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-06-22 16:55:58 UTC (rev 279121)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279120 => 279121)

--- branches/safari-611-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-06-22 16:44:56 UTC (rev 279120)
+++ branches/safari-611-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-06-22 16:55:58 UTC (rev 279121)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebCore/Configurations/Version.xcconfig (279120 => 279121)

--- branches/safari-611-branch/Source/WebCore/Configurations/Version.xcconfig	2021-06-22 16:44:56 UTC (rev 279120)
+++ branches/safari-611-branch/Source/WebCore/Configurations/Version.xcconfig	2021-06-22 16:55:58 UTC (rev 279121)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279120 => 279121)

--- branches/safari-611-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-06-22 16:44:56 UTC (rev 279120)
+++ branches/safari-611-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-06-22 16:55:58 UTC (rev 279121)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279120 => 279121)

--- branches/safari-611-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-06-22 16:44:56 UTC (rev 279120)
+++ branches/safari-611-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-06-22 16:55:58 UTC (rev 279121)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebKit/Configurations/Version.xcconfig (279120 => 279121)

--- branches/safari-611-branch/Source/WebKit/Configurations/Version.xcconfig	2021-06-22 16:44:56 UTC (rev 279120)
+++ branches/safari-611-branch/Source/WebKit/Configurations/Version.xcconfig	2021-06-22 16:55:58 UTC (rev 279121)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 3;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (279120 => 279121)

--- branches/safari-611-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2021-06-22

[webkit-changes] [279120] trunk

2021-06-22 Thread tsavell

Title: [279120] trunk








Revision 279120
Author tsav...@apple.com
Date 2021-06-22 09:44:56 -0700 (Tue, 22 Jun 2021)


Log Message
Unreviewed, reverting r279083.

Broke Mac Builds

Reverted changeset:

"Migrate App Privacy Report code from WebKitAdditions"
https://bugs.webkit.org/show_bug.cgi?id=227045
https://commits.webkit.org/r279083

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformEnableCocoa.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (279119 => 279120)

--- trunk/Source/WTF/ChangeLog	2021-06-22 16:17:45 UTC (rev 279119)
+++ trunk/Source/WTF/ChangeLog	2021-06-22 16:44:56 UTC (rev 279120)
@@ -1,3 +1,15 @@
+2021-06-22  Truitt Savell  
+
+Unreviewed, reverting r279083.
+
+Broke Mac Builds
+
+Reverted changeset:
+
+"Migrate App Privacy Report code from WebKitAdditions"
+https://bugs.webkit.org/show_bug.cgi?id=227045
+https://commits.webkit.org/r279083
+
 2021-06-22  Kimmo Kinnunen  
 
 Functions dispatched to WorkQueue are sometimes destroyed in the calling thread due to block refcounting


Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (279119 => 279120)

--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2021-06-22 16:17:45 UTC (rev 279119)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2021-06-22 16:44:56 UTC (rev 279120)
@@ -699,8 +699,8 @@
 #define ENABLE_NOTIFY_FILTERING 1
 #endif
 
-#if !defined(ENABLE_APP_PRIVACY_REPORT) && PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15
-#define ENABLE_APP_PRIVACY_REPORT 1
+#if !defined(ENABLE_APP_BOUND_REQUESTS) && PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15
+#define ENABLE_APP_BOUND_REQUESTS 1
 #endif
 
 #if !defined(ENABLE_DESTINATION_COLOR_SPACE_DISPLAY_P3)


Modified: trunk/Source/WebKit/ChangeLog (279119 => 279120)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 16:17:45 UTC (rev 279119)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 16:44:56 UTC (rev 279120)
@@ -1,3 +1,15 @@
+2021-06-22  Truitt Savell  
+
+Unreviewed, reverting r279083.
+
+Broke Mac Builds
+
+Reverted changeset:
+
+"Migrate App Privacy Report code from WebKitAdditions"
+https://bugs.webkit.org/show_bug.cgi?id=227045
+https://commits.webkit.org/r279083
+
 2021-06-22  Kimmo Kinnunen  
 
 Functions dispatched to WorkQueue are sometimes destroyed in the calling thread due to block refcounting


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (279119 => 279120)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2021-06-22 16:17:45 UTC (rev 279119)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2021-06-22 16:44:56 UTC (rev 279120)
@@ -57,7 +57,8 @@
 #if USE(APPLE_INTERNAL_SDK)
 #import 
 #else
-static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest *) { };
+#define NETWORK_DATA_TASK_COCOA_ADDITIONS UNUSED_VARIABLE(pcmDataCarried);
+static WebCore::RegistrableDomain contextString(NSURLRequest *) { return { }; }
 #endif
 
 namespace WebKit {
@@ -337,31 +338,24 @@
 #endif
 restrictRequestReferrerToOriginIfNeeded(request);
 
-RetainPtr nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
-RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
+// FIXME: Once we are done with NETWORK_DATA_TASK_COCOA_ADDITIONS, make nsRequest a RetainPtr and get rid of protectedNSRequest and pcmDataCarried.
+NSURLRequest *nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
+auto pcmDataCarried = parameters.pcmDataCarried;
 
-#if ENABLE(APP_PRIVACY_REPORT)
-ALLOW_DEPRECATED_DECLARATIONS_BEGIN
-mutableRequest.get()._isNonAppInitiated = !request.isAppBound();
-ALLOW_DEPRECATED_DECLARATIONS_END
-#endif
+NETWORK_DATA_TASK_COCOA_ADDITIONS
 
-if (parameters.pcmDataCarried)
-processPCMRequest(*parameters.pcmDataCarried, mutableRequest.get());
+auto protectedNSRequest = retainPtr(nsRequest);
+m_session->appBoundNavigationTestingData().updateAppBoundNavigationTestingData(request, contextString(protectedNSRequest.get()));
 
-nsRequest = mutableRequest;
+applySniffingPoliciesAndBindRequestToInferfaceIfNeeded(protectedNSRequest, parameters.contentSniffingPolicy == WebCore::ContentSniffingPolicy::SniffContent && !url.isLocalFile(), parameters.contentEncodingSniffingPolicy == WebCore::ContentEncodingSniffingPolicy::Sniff);
 
-m_session->appBoundNavigationTestingData().updateAppBoundNavigationTestingData(request, request.firstPartyForCookies().isEmpty() ? WebCore::RegistrableDomain(request.url()) :

[webkit-changes] [279119] trunk/Source/WebCore

2021-06-22 Thread jer . noble

Title: [279119] trunk/Source/WebCore








Revision 279119
Author jer.no...@apple.com
Date 2021-06-22 09:17:45 -0700 (Tue, 22 Jun 2021)


Log Message
[Cocoa] iOS device steals BT headphones from other devices during silent playback
https://bugs.webkit.org/show_bug.cgi?id=227227


Reviewed by Eric Carlson.

Source/WebCore:

Explicitly disable smart routing when WebKit itself does not explicitly activate its AVAudioSession.
The audio session will be implicitly activated even for audio-less or silent media playback, and
this will prevent headsets from being "stolen" when that session is implicitly activated.

* platform/audio/ios/AudioSessionIOS.h:
* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::setEligibleForSmartRouting):
(WebCore::AudioSessionIOS::AudioSessionIOS):
(WebCore::AudioSessionIOS::tryToSetActiveInternal):

Source/WebCore/PAL:

* pal/spi/cocoa/AVFoundationSPI.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.h
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (279118 => 279119)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 16:16:18 UTC (rev 279118)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 16:17:45 UTC (rev 279119)
@@ -1,3 +1,21 @@
+2021-06-22  Jer Noble  
+
+[Cocoa] iOS device steals BT headphones from other devices during silent playback
+https://bugs.webkit.org/show_bug.cgi?id=227227
+
+
+Reviewed by Eric Carlson.
+
+Explicitly disable smart routing when WebKit itself does not explicitly activate its AVAudioSession.
+The audio session will be implicitly activated even for audio-less or silent media playback, and
+this will prevent headsets from being "stolen" when that session is implicitly activated.
+
+* platform/audio/ios/AudioSessionIOS.h:
+* platform/audio/ios/AudioSessionIOS.mm:
+(WebCore::setEligibleForSmartRouting):
+(WebCore::AudioSessionIOS::AudioSessionIOS):
+(WebCore::AudioSessionIOS::tryToSetActiveInternal):
+
 2021-06-22  Rob Buis  
 
 Make rendererIsEverNeeded check less strict


Modified: trunk/Source/WebCore/PAL/ChangeLog (279118 => 279119)

--- trunk/Source/WebCore/PAL/ChangeLog	2021-06-22 16:16:18 UTC (rev 279118)
+++ trunk/Source/WebCore/PAL/ChangeLog	2021-06-22 16:17:45 UTC (rev 279119)
@@ -1,3 +1,13 @@
+2021-06-22  Jer Noble  
+
+[Cocoa] iOS device steals BT headphones from other devices during silent playback
+https://bugs.webkit.org/show_bug.cgi?id=227227
+
+
+Reviewed by Eric Carlson.
+
+* pal/spi/cocoa/AVFoundationSPI.h:
+
 2021-06-20  Wenson Hsieh  
 
 [macOS] Rename WKVisualSearchPreviewController to WKQuickLookPreviewController


Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h (279118 => 279119)

--- trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h	2021-06-22 16:16:18 UTC (rev 279118)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h	2021-06-22 16:17:45 UTC (rev 279119)
@@ -393,6 +393,8 @@
 @interface AVAudioSession (AVAudioSessionPrivate)
 - (instancetype)initAuxiliarySession;
 @property (readonly) NSString* routingContextUID;
+@property (readonly) BOOL eligibleForBTSmartRoutingConsideration;
+- (BOOL)setEligibleForBTSmartRoutingConsideration:(BOOL)inValue error:(NSError **)outError;
 @end
 
 NS_ASSUME_NONNULL_END


Modified: trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.h (279118 => 279119)

--- trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.h	2021-06-22 16:16:18 UTC (rev 279118)
+++ trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.h	2021-06-22 16:17:45 UTC (rev 279119)
@@ -65,7 +65,7 @@
 void endInterruption(MayResume) final;
 
 AudioSession::CategoryType m_categoryOverride { AudioSession::CategoryType::None };
-RefPtr m_workQueue;
+Ref m_workQueue;
 RetainPtr m_interruptionObserverHelper;
 };
 


Modified: trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm (279118 => 279119)

--- trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2021-06-22 16:16:18 UTC (rev 279118)
+++ trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2021-06-22 16:17:45 UTC (rev 279119)
@@ -96,11 +96,34 @@
 
 namespace WebCore {
 
+static void setEligibleForSmartRouting(bool eligible)
+{
+ASSERT(!isMainThread());
+
+auto *session = [PAL::getAVAudioSessionClass() sharedInstance];
+if (![session respondsToSelector:@selector(setEligibleForBTSmartRoutingConsideration:error:)]
+|| ![session respondsToSelector:@selector(eligibleForBTSmartRoutingConsideration)])
+return;
+
+if (session.eligibleForBTSmartRoutingConsideration == eligible)
+return;
+
+NSError *error = nil;
+if (![session setEligibleForBTSmartRoutingConsideration:eligible error:])
+RELEASE_LOG_ERROR(Media,

[webkit-changes] [279118] trunk/Source/WebCore

2021-06-22 Thread commit-queue

Title: [279118] trunk/Source/WebCore








Revision 279118
Author commit-qu...@webkit.org
Date 2021-06-22 09:16:18 -0700 (Tue, 22 Jun 2021)


Log Message
Make rendererIsEverNeeded check less strict
https://bugs.webkit.org/show_bug.cgi?id=226791

Patch by Rob Buis  on 2021-06-22
Reviewed by Antti Koivisto.

Make rendererIsEverNeeded check less strict
in TreeResolver::resolveElement.

* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleTreeResolver.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (279117 => 279118)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 15:31:06 UTC (rev 279117)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 16:16:18 UTC (rev 279118)
@@ -1,3 +1,16 @@
+2021-06-22  Rob Buis  
+
+Make rendererIsEverNeeded check less strict
+https://bugs.webkit.org/show_bug.cgi?id=226791
+
+Reviewed by Antti Koivisto.
+
+Make rendererIsEverNeeded check less strict
+in TreeResolver::resolveElement.
+
+* style/StyleTreeResolver.cpp:
+(WebCore::Style::TreeResolver::resolveElement):
+
 2021-06-21  Yusuke Suzuki  
 
 Shrink sizeof(RegisteredEventListener)


Modified: trunk/Source/WebCore/style/StyleTreeResolver.cpp (279117 => 279118)

--- trunk/Source/WebCore/style/StyleTreeResolver.cpp	2021-06-22 15:31:06 UTC (rev 279117)
+++ trunk/Source/WebCore/style/StyleTreeResolver.cpp	2021-06-22 16:16:18 UTC (rev 279118)
@@ -207,7 +207,7 @@
 return { };
 }
 
-if (!element.rendererIsEverNeeded())
+if (!element.rendererIsEverNeeded() && !element.hasDisplayContents())
 return { };
 
 Styleable styleable { element, PseudoId::None };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279117] trunk/Source/WebCore

2021-06-22 Thread ysuzuki

Title: [279117] trunk/Source/WebCore








Revision 279117
Author ysuz...@apple.com
Date 2021-06-22 08:31:06 -0700 (Tue, 22 Jun 2021)


Log Message
Shrink sizeof(RegisteredEventListener)
https://bugs.webkit.org/show_bug.cgi?id=227230

Reviewed by Geoffrey Garen.

This patch changes the ordering of members of RegisteredEventListener to make it small from 24 to 16.

* dom/RegisteredEventListener.h:
(WebCore::RegisteredEventListener::RegisteredEventListener):
(): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/RegisteredEventListener.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (279116 => 279117)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 14:54:05 UTC (rev 279116)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 15:31:06 UTC (rev 279117)
@@ -1,3 +1,16 @@
+2021-06-21  Yusuke Suzuki  
+
+Shrink sizeof(RegisteredEventListener)
+https://bugs.webkit.org/show_bug.cgi?id=227230
+
+Reviewed by Geoffrey Garen.
+
+This patch changes the ordering of members of RegisteredEventListener to make it small from 24 to 16.
+
+* dom/RegisteredEventListener.h:
+(WebCore::RegisteredEventListener::RegisteredEventListener):
+(): Deleted.
+
 2021-06-22  Frédéric Wang  
 
 Nullptr crash in null ptr deref in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline


Modified: trunk/Source/WebCore/dom/RegisteredEventListener.h (279116 => 279117)

--- trunk/Source/WebCore/dom/RegisteredEventListener.h	2021-06-22 14:54:05 UTC (rev 279116)
+++ trunk/Source/WebCore/dom/RegisteredEventListener.h	2021-06-22 15:31:06 UTC (rev 279117)
@@ -2,7 +2,7 @@
  * Copyright (C) 2001 Peter Kelly (p...@post.com)
  * Copyright (C) 2001 Tobias Anton (an...@stud.fbi.fh-darmstadt.de)
  * Copyright (C) 2006 Samuel Weinig (sam.wei...@gmail.com)
- * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserved.
+ * Copyright (C) 2003-2021 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ -58,18 +58,19 @@
 
 private:
 RegisteredEventListener(Ref&& listener, const Options& options)
-: m_callback(WTFMove(listener))
-, m_useCapture(options.capture)
+: m_useCapture(options.capture)
 , m_isPassive(options.passive)
 , m_isOnce(options.once)
+, m_wasRemoved(false)
+, m_callback(WTFMove(listener))
 {
 }
 
+bool m_useCapture : 1;
+bool m_isPassive : 1;
+bool m_isOnce : 1;
+bool m_wasRemoved : 1;
 Ref m_callback;
-bool m_useCapture { false };
-bool m_isPassive { false };
-bool m_isOnce { false };
-bool m_wasRemoved { false };
 };
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279116] trunk/LayoutTests

2021-06-22 Thread pvollan

Title: [279116] trunk/LayoutTests








Revision 279116
Author pvol...@apple.com
Date 2021-06-22 07:54:05 -0700 (Tue, 22 Jun 2021)


Log Message
[AppleWin] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=226970

Unreviewed test gardening.


* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279115 => 279116)

--- trunk/LayoutTests/ChangeLog	2021-06-22 13:25:03 UTC (rev 279115)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 14:54:05 UTC (rev 279116)
@@ -1,3 +1,12 @@
+2021-06-22  Per Arne Vollan  
+
+[AppleWin] Update test expectations
+https://bugs.webkit.org/show_bug.cgi?id=226970
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2021-06-22  Frédéric Wang  
 
 Nullptr crash in null ptr deref in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline


Modified: trunk/LayoutTests/platform/win/TestExpectations (279115 => 279116)

--- trunk/LayoutTests/platform/win/TestExpectations	2021-06-22 13:25:03 UTC (rev 279115)
+++ trunk/LayoutTests/platform/win/TestExpectations	2021-06-22 14:54:05 UTC (rev 279116)
@@ -4644,6 +4644,7 @@
 webxr [ Skip ]
 
 # https://bugs.webkit.org/show_bug.cgi?id=226970
+fast/css/parse-border-image-repeat-null-crash.html [ Failure ]
 fast/workers/worker-multi-startup.html [ Pass Timeout ]
 fast/workers/worker-script-error.html [ Pass Timeout ]
 fetch/fetch-worker-crash.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279115] trunk

2021-06-22 Thread commit-queue

Title: [279115] trunk








Revision 279115
Author commit-qu...@webkit.org
Date 2021-06-22 06:25:03 -0700 (Tue, 22 Jun 2021)


Log Message
Functions dispatched to WorkQueue are sometimes destroyed in the calling thread due to block refcounting
https://bugs.webkit.org/show_bug.cgi?id=227160

Patch by Kimmo Kinnunen  on 2021-06-22
Reviewed by Antti Koivisto.

Source/WebKit:

As an example, remove one workaround mutability of dispatched function
and nullptr assignment that was needed for working around
WorkQueue::dispatch bug where the dispatched function was not always
destroyed in the queue.

* Shared/mac/MediaFormatReader/MediaTrackReader.cpp:
(WebKit::MediaTrackReader::finalize):

Source/WTF:

WorkQueue::dispatch Function bodies always execute in the thread of target
queue. However, sometimes the Function destruction would happen in the
dispatched-from thread. This is not what the WorkQueue::dispatch callers
expect.

Implement some of the WorkQueue::dispatch* in terms of dispatch_..._f()
variants which take a function and context pointer instead of a block.

Blocks are reference counted objects without the ability to pass the
ownership of the reference. For dispatch case, it means that caller will
need to hold the reference while dispatch_...() returns. In thread
contention cases the called block might complete and reference be
dropped in the thread of the queue before the dispatched-from thread
would drop its reference to the block. This would cause the dispatched
Function to be destroyed in the dispatched-from thread.

* wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::dispatchWorkItem):
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
(WTF::WorkQueue::dispatchSync):

Tools:

Test that the Function passed to WorkQueue::dispatch
is always destroyed in the WorkQueue. Test by using the
knowledge that WorkQueues use threads.
Start up many WorkQueues to create more thread contention
to ensure that the dispatched-from thread is sometimes not
run while the thread of the queue finishes processing
the dispatch.

* TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (279114 => 279115)

--- trunk/Source/WTF/ChangeLog	2021-06-22 13:01:51 UTC (rev 279114)
+++ trunk/Source/WTF/ChangeLog	2021-06-22 13:25:03 UTC (rev 279115)
@@ -1,3 +1,32 @@
+2021-06-22  Kimmo Kinnunen  
+
+Functions dispatched to WorkQueue are sometimes destroyed in the calling thread due to block refcounting
+https://bugs.webkit.org/show_bug.cgi?id=227160
+
+Reviewed by Antti Koivisto.
+
+WorkQueue::dispatch Function bodies always execute in the thread of target
+queue. However, sometimes the Function destruction would happen in the
+dispatched-from thread. This is not what the WorkQueue::dispatch callers
+expect.
+
+Implement some of the WorkQueue::dispatch* in terms of dispatch_..._f()
+variants which take a function and context pointer instead of a block.
+
+Blocks are reference counted objects without the ability to pass the
+ownership of the reference. For dispatch case, it means that caller will
+need to hold the reference while dispatch_...() returns. In thread
+contention cases the called block might complete and reference be
+dropped in the thread of the queue before the dispatched-from thread
+would drop its reference to the block. This would cause the dispatched
+Function to be destroyed in the dispatched-from thread.
+
+* wtf/cocoa/WorkQueueCocoa.cpp:
+(WTF::dispatchWorkItem):
+(WTF::WorkQueue::dispatch):
+(WTF::WorkQueue::dispatchAfter):
+(WTF::WorkQueue::dispatchSync):
+
 2021-06-21  Chris Dumez  
 
 Adjust `fetch` port blocking for ports 990, 989


Modified: trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp (279114 => 279115)

--- trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp	2021-06-22 13:01:51 UTC (rev 279114)
+++ trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp	2021-06-22 13:25:03 UTC (rev 279115)
@@ -31,23 +31,37 @@
 
 namespace WTF {
 
+namespace {
+
+struct DispatchWorkItem {
+WTF_MAKE_STRUCT_FAST_ALLOCATED;
+Ref m_workQueue;
+Function m_function;
+void operator()() { m_function(); }
+};
+
+}
+
+template static void dispatchWorkItem(void* dispatchContext)
+{
+T* item = reinterpret_cast(dispatchContext);
+(*item)();
+delete item;
+}
+
 void WorkQueue::dispatch(Function&& function)
 {
-dispatch_async(m_dispatchQueue.get(), makeBlockPtr([protectedThis = makeRef(*this), function = WTFMove(function)] {
-function();
-}).get());
+dispatch_async_f(m_dispatchQueue.get(), new DispatchWorkItem { makeRef(*this),

[webkit-changes] [279113] trunk/JSTests

2021-06-22 Thread angelos

Title: [279113] trunk/JSTests








Revision 279113
Author ange...@igalia.com
Date 2021-06-22 06:01:27 -0700 (Tue, 22 Jun 2021)


Log Message
Unskip microbenchmarks/redefine-property-data-dictionary.js on MIPS/ARM
https://bugs.webkit.org/show_bug.cgi?id=227252

Unreviewed gardening.

No failures on either platform after 100 iterations.


* microbenchmarks/redefine-property-data-dictionary.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/microbenchmarks/redefine-property-data-dictionary.js




Diff

Modified: trunk/JSTests/ChangeLog (279112 => 279113)

--- trunk/JSTests/ChangeLog	2021-06-22 12:50:08 UTC (rev 279112)
+++ trunk/JSTests/ChangeLog	2021-06-22 13:01:27 UTC (rev 279113)
@@ -1,5 +1,16 @@
 2021-06-22  Angelos Oikonomopoulos  
 
+Unskip microbenchmarks/redefine-property-data-dictionary.js on MIPS/ARM
+https://bugs.webkit.org/show_bug.cgi?id=227252
+
+Unreviewed gardening.
+
+No failures on either platform after 100 iterations.
+
+* microbenchmarks/redefine-property-data-dictionary.js:
+
+2021-06-22  Angelos Oikonomopoulos  
+
 Unskip stress/array-species-create-should-handle-masquerader.js on mips
 https://bugs.webkit.org/show_bug.cgi?id=227249
 


Modified: trunk/JSTests/microbenchmarks/redefine-property-data-dictionary.js (279112 => 279113)

--- trunk/JSTests/microbenchmarks/redefine-property-data-dictionary.js	2021-06-22 12:50:08 UTC (rev 279112)
+++ trunk/JSTests/microbenchmarks/redefine-property-data-dictionary.js	2021-06-22 13:01:27 UTC (rev 279113)
@@ -1,4 +1,3 @@
-//@ skip if $memoryLimited and ["arm", "mips"].include?($architecture)
 const obj = {};
 for (let i = 0; i < 100; ++i)
 obj["k" + i] = i;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279114] trunk/JSTests

2021-06-22 Thread angelos

Title: [279114] trunk/JSTests








Revision 279114
Author ange...@igalia.com
Date 2021-06-22 06:01:51 -0700 (Tue, 22 Jun 2021)


Log Message
Unskip stress/elidable-new-object-roflcopter-then-exit.js on MIPS/ARM
https://bugs.webkit.org/show_bug.cgi?id=227251

Unreviewed gardening.

No failures on either platform after 100 iterations.


* stress/elidable-new-object-roflcopter-then-exit.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/elidable-new-object-roflcopter-then-exit.js




Diff

Modified: trunk/JSTests/ChangeLog (279113 => 279114)

--- trunk/JSTests/ChangeLog	2021-06-22 13:01:27 UTC (rev 279113)
+++ trunk/JSTests/ChangeLog	2021-06-22 13:01:51 UTC (rev 279114)
@@ -1,5 +1,16 @@
 2021-06-22  Angelos Oikonomopoulos  
 
+Unskip stress/elidable-new-object-roflcopter-then-exit.js on MIPS/ARM
+https://bugs.webkit.org/show_bug.cgi?id=227251
+
+Unreviewed gardening.
+
+No failures on either platform after 100 iterations.
+
+* stress/elidable-new-object-roflcopter-then-exit.js:
+
+2021-06-22  Angelos Oikonomopoulos  
+
 Unskip microbenchmarks/redefine-property-data-dictionary.js on MIPS/ARM
 https://bugs.webkit.org/show_bug.cgi?id=227252
 


Modified: trunk/JSTests/stress/elidable-new-object-roflcopter-then-exit.js (279113 => 279114)

--- trunk/JSTests/stress/elidable-new-object-roflcopter-then-exit.js	2021-06-22 13:01:27 UTC (rev 279113)
+++ trunk/JSTests/stress/elidable-new-object-roflcopter-then-exit.js	2021-06-22 13:01:51 UTC (rev 279114)
@@ -1,4 +1,4 @@
-//@ skip if $architecture != "arm64" and $architecture != "x86-64"
+//@ skip if $architecture != "arm64" and $architecture != "x86-64" and $architecture != "mips" and $architecture != "arm"
 
 function sumOfArithSeries(limit) {
 return limit * (limit + 1) / 2;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279112] trunk/Tools

2021-06-22 Thread commit-queue

Title: [279112] trunk/Tools








Revision 279112
Author commit-qu...@webkit.org
Date 2021-06-22 05:50:08 -0700 (Tue, 22 Jun 2021)


Log Message
Test runner parses the names of value parametrised GTEST tests wrong
https://bugs.webkit.org/show_bug.cgi?id=227207

Patch by Kimmo Kinnunen  on 2021-06-22
Reviewed by Jonathan Bedard.

Fix the parsing of test names.
* Scripts/webkitpy/api_tests/manager_unittest.py:
Add a test for the parsing.

* Scripts/webkitpy/api_tests/manager.py:
(Manager._test_list_from_output):
Fix the test name parsing.
The name is printed as:
  ValueParametrizedTestsSupported/DogGreen  # GetParam() = (Dog, Green)

* TestWebKitAPI/Test.h:
(TestWebKitAPI::TestParametersToStringFormatter::operator() const):
Add a general-purpose formatter for all value-parametrized tests
to use.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/Misc/TestRunnerTests.cpp: Added.
(TestWebKitAPI::TEST_P):
Add a value-parametrized test testing the test runner.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/api_tests/manager.py
trunk/Tools/TestWebKitAPI/Test.h
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/Scripts/webkitpy/api_tests/manager_unittest.py
trunk/Tools/TestWebKitAPI/Tests/Misc/
trunk/Tools/TestWebKitAPI/Tests/Misc/TestRunnerTests.cpp




Diff

Modified: trunk/Tools/ChangeLog (279111 => 279112)

--- trunk/Tools/ChangeLog	2021-06-22 10:58:19 UTC (rev 279111)
+++ trunk/Tools/ChangeLog	2021-06-22 12:50:08 UTC (rev 279112)
@@ -1,3 +1,30 @@
+2021-06-22  Kimmo Kinnunen  
+
+Test runner parses the names of value parametrised GTEST tests wrong
+https://bugs.webkit.org/show_bug.cgi?id=227207
+
+Reviewed by Jonathan Bedard.
+
+Fix the parsing of test names.
+* Scripts/webkitpy/api_tests/manager_unittest.py:
+Add a test for the parsing.
+
+* Scripts/webkitpy/api_tests/manager.py:
+(Manager._test_list_from_output):
+Fix the test name parsing.
+The name is printed as:
+  ValueParametrizedTestsSupported/DogGreen  # GetParam() = (Dog, Green)
+
+* TestWebKitAPI/Test.h:
+(TestWebKitAPI::TestParametersToStringFormatter::operator() const):
+Add a general-purpose formatter for all value-parametrized tests
+to use.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/Misc/TestRunnerTests.cpp: Added.
+(TestWebKitAPI::TEST_P):
+Add a value-parametrized test testing the test runner.
+
 2021-06-21  Chris Dumez  
 
 [WK2] Don't process-swap on navigations within the same non-HTTP(s) protocol


Modified: trunk/Tools/Scripts/webkitpy/api_tests/manager.py (279111 => 279112)

--- trunk/Tools/Scripts/webkitpy/api_tests/manager.py	2021-06-22 10:58:19 UTC (rev 279111)
+++ trunk/Tools/Scripts/webkitpy/api_tests/manager.py	2021-06-22 12:50:08 UTC (rev 279112)
@@ -55,6 +55,7 @@
 result = []
 current_test_suite = None
 for line in output.split('\n'):
+line = line.split("#")[0]  # Value-parametrized tests contain #.
 striped_line = line.lstrip().rstrip()
 if not striped_line:
 continue


Added: trunk/Tools/Scripts/webkitpy/api_tests/manager_unittest.py (0 => 279112)

--- trunk/Tools/Scripts/webkitpy/api_tests/manager_unittest.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/api_tests/manager_unittest.py	2021-06-22 12:50:08 UTC (rev 279112)
@@ -0,0 +1,53 @@
+# Copyright (C) 2021 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+#notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+#notice, this list of conditions and the following disclaimer in the
+#documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+"""Unit tests for manager.py."""
+
+import unittest
+
+from

[webkit-changes] [279111] trunk/JSTests

2021-06-22 Thread angelos

Title: [279111] trunk/JSTests








Revision 279111
Author ange...@igalia.com
Date 2021-06-22 03:58:19 -0700 (Tue, 22 Jun 2021)


Log Message
Unskip stress/array-species-create-should-handle-masquerader.js on mips
https://bugs.webkit.org/show_bug.cgi?id=227249

Unreviewed gardening.

No failure after 60 iterations.


* stress/array-species-create-should-handle-masquerader.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/array-species-create-should-handle-masquerader.js




Diff

Modified: trunk/JSTests/ChangeLog (279110 => 279111)

--- trunk/JSTests/ChangeLog	2021-06-22 09:06:14 UTC (rev 279110)
+++ trunk/JSTests/ChangeLog	2021-06-22 10:58:19 UTC (rev 279111)
@@ -1,3 +1,14 @@
+2021-06-22  Angelos Oikonomopoulos  
+
+Unskip stress/array-species-create-should-handle-masquerader.js on mips
+https://bugs.webkit.org/show_bug.cgi?id=227249
+
+Unreviewed gardening.
+
+No failure after 60 iterations.
+
+* stress/array-species-create-should-handle-masquerader.js:
+
 2021-06-21  Ross Kirsling  
 
 [JSC] Add JIT ICs for `#x in obj` feature


Modified: trunk/JSTests/stress/array-species-create-should-handle-masquerader.js (279110 => 279111)

--- trunk/JSTests/stress/array-species-create-should-handle-masquerader.js	2021-06-22 09:06:14 UTC (rev 279110)
+++ trunk/JSTests/stress/array-species-create-should-handle-masquerader.js	2021-06-22 10:58:19 UTC (rev 279111)
@@ -1,5 +1,3 @@
-//@ skip if $architecture == "mips"
-
 function shouldThrow(func, errorMessage) {
 var errorThrown = false;
 var error = null;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279110] trunk

2021-06-22 Thread commit-queue

Title: [279110] trunk








Revision 279110
Author commit-qu...@webkit.org
Date 2021-06-22 02:06:14 -0700 (Tue, 22 Jun 2021)


Log Message
Nullptr crash in null ptr deref in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
https://bugs.webkit.org/show_bug.cgi?id=226799

Patch by Frédéric Wang  on 2021-06-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

Various places in ReplaceSelectionCommand::doApply() may execute mutation events and lead
to nodes being removed. This patch adds one more early return after the call to
makeInsertedContentRoundTrippableWithHTMLTreeBuilder() to ensure that the function
removeRedundantStylesAndKeepStyleSpanInline() is properly executed.

Test: fast/editing/paste-and-indent-microtask-crash.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

Add regression test.

* fast/editing/paste-and-indent-microtask-crash-expected.txt: Added.
* fast/editing/paste-and-indent-microtask-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp


Added Paths

trunk/LayoutTests/fast/editing/paste-and-indent-microtask-crash-expected.txt
trunk/LayoutTests/fast/editing/paste-and-indent-microtask-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279109 => 279110)

--- trunk/LayoutTests/ChangeLog	2021-06-22 08:37:12 UTC (rev 279109)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 09:06:14 UTC (rev 279110)
@@ -1,3 +1,15 @@
+2021-06-22  Frédéric Wang  
+
+Nullptr crash in null ptr deref in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
+https://bugs.webkit.org/show_bug.cgi?id=226799
+
+Reviewed by Ryosuke Niwa.
+
+Add regression test.
+
+* fast/editing/paste-and-indent-microtask-crash-expected.txt: Added.
+* fast/editing/paste-and-indent-microtask-crash.html: Added.
+
 2021-06-22  Arcady Goldmints-Orlov  
 
 [GLIB] Unreviewed test gardening. Update baselines after r278931.


Added: trunk/LayoutTests/fast/editing/paste-and-indent-microtask-crash-expected.txt (0 => 279110)

--- trunk/LayoutTests/fast/editing/paste-and-indent-microtask-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/editing/paste-and-indent-microtask-crash-expected.txt	2021-06-22 09:06:14 UTC (rev 279110)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: This test passes if it does not crash.
+
+


Added: trunk/LayoutTests/fast/editing/paste-and-indent-microtask-crash.html (0 => 279110)

--- trunk/LayoutTests/fast/editing/paste-and-indent-microtask-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/editing/paste-and-indent-microtask-crash.html	2021-06-22 09:06:14 UTC (rev 279110)
@@ -0,0 +1,23 @@
+
+  if (window.testRunner)
+testRunner.dumpAsText();
+  console.log("This test passes if it does not crash.")
+  _onload_ = () => {
+let h1 = document.createElement('h1');
+document.body.appendChild(h1);
+h1.appendChild(document.createElement('input'));
+h1.appendChild(document.createElement('div'));
+let h2 = document.createElement('h2');
+document.body.appendChild(h2);
+let h3 = document.createElement('h3');
+h2.appendChild(h3);
+document.execCommand('SelectAll');
+h3.appendChild(document.createElement('iframe'));
+queueMicrotask(() => {
+  document.execCommand('Indent');
+});
+document.designMode = 'on';
+document.execCommand('Copy');
+document.execCommand('Paste');
+  };
+


Modified: trunk/Source/WebCore/ChangeLog (279109 => 279110)

--- trunk/Source/WebCore/ChangeLog	2021-06-22 08:37:12 UTC (rev 279109)
+++ trunk/Source/WebCore/ChangeLog	2021-06-22 09:06:14 UTC (rev 279110)
@@ -1,3 +1,20 @@
+2021-06-22  Frédéric Wang  
+
+Nullptr crash in null ptr deref in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
+https://bugs.webkit.org/show_bug.cgi?id=226799
+
+Reviewed by Ryosuke Niwa.
+
+Various places in ReplaceSelectionCommand::doApply() may execute mutation events and lead
+to nodes being removed. This patch adds one more early return after the call to
+makeInsertedContentRoundTrippableWithHTMLTreeBuilder() to ensure that the function
+removeRedundantStylesAndKeepStyleSpanInline() is properly executed.
+
+Test: fast/editing/paste-and-indent-microtask-crash.html
+
+* editing/ReplaceSelectionCommand.cpp:
+(WebCore::ReplaceSelectionCommand::doApply):
+
 2021-06-22  Cathie Chen  
 
 Implement width and height attributes on source elements of 


Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp (279109 => 279110)

--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp	2021-06-22 08:37:12 UTC (rev 279109)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp	2021-06-22 09:06:14 UTC (rev 279110)
@@ -1355,6 +1355,8 @@

[webkit-changes] [279109] trunk/LayoutTests

2021-06-22 Thread commit-queue

Title: [279109] trunk/LayoutTests








Revision 279109
Author commit-qu...@webkit.org
Date 2021-06-22 01:37:12 -0700 (Tue, 22 Jun 2021)


Log Message
[GLIB] Unreviewed test gardening. Update baselines after r278931.
https://bugs.webkit.org/show_bug.cgi?id=227183

Patch by Arcady Goldmints-Orlov  on 2021-06-22

* platform/glib/tables/mozilla/bugs/bug106795-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug16252-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug1188-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug126742-expected.png:
* platform/wpe/tables/mozilla/bugs/bug126742-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug1318-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug16252-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug57828-2-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug82946-2-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/tables/mozilla/bugs/bug106795-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug16252-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt
trunk/LayoutTests/platform/wpe/tables/mozilla/bugs/bug1188-expected.txt
trunk/LayoutTests/platform/wpe/tables/mozilla/bugs/bug126742-expected.png
trunk/LayoutTests/platform/wpe/tables/mozilla/bugs/bug126742-expected.txt
trunk/LayoutTests/platform/wpe/tables/mozilla/bugs/bug1318-expected.txt
trunk/LayoutTests/platform/wpe/tables/mozilla/bugs/bug16252-expected.txt
trunk/LayoutTests/platform/wpe/tables/mozilla/bugs/bug57828-2-expected.txt
trunk/LayoutTests/platform/wpe/tables/mozilla/bugs/bug82946-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (279108 => 279109)

--- trunk/LayoutTests/ChangeLog	2021-06-22 08:06:05 UTC (rev 279108)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 08:37:12 UTC (rev 279109)
@@ -1,3 +1,19 @@
+2021-06-22  Arcady Goldmints-Orlov  
+
+[GLIB] Unreviewed test gardening. Update baselines after r278931.
+https://bugs.webkit.org/show_bug.cgi?id=227183
+
+* platform/glib/tables/mozilla/bugs/bug106795-expected.txt:
+* platform/gtk/tables/mozilla/bugs/bug16252-expected.txt:
+* platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt:
+* platform/wpe/tables/mozilla/bugs/bug1188-expected.txt:
+* platform/wpe/tables/mozilla/bugs/bug126742-expected.png:
+* platform/wpe/tables/mozilla/bugs/bug126742-expected.txt:
+* platform/wpe/tables/mozilla/bugs/bug1318-expected.txt:
+* platform/wpe/tables/mozilla/bugs/bug16252-expected.txt:
+* platform/wpe/tables/mozilla/bugs/bug57828-2-expected.txt:
+* platform/wpe/tables/mozilla/bugs/bug82946-2-expected.txt:
+
 2021-06-22  Cathie Chen  
 
 Implement width and height attributes on source elements of 


Modified: trunk/LayoutTests/platform/glib/tables/mozilla/bugs/bug106795-expected.txt (279108 => 279109)

--- trunk/LayoutTests/platform/glib/tables/mozilla/bugs/bug106795-expected.txt	2021-06-22 08:06:05 UTC (rev 279108)
+++ trunk/LayoutTests/platform/glib/tables/mozilla/bugs/bug106795-expected.txt	2021-06-22 08:37:12 UTC (rev 279109)
@@ -7,10 +7,10 @@
 RenderTableSection {TBODY} at (1,1) size 781x80
   RenderTableRow {TR} at (0,0) size 781x38
 RenderTableCell {TD} at (0,8) size 781x21 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
-  RenderBR {BR} at (1,1) size 0x18
+  RenderBR {BR} at (1,0) size 0x19
   RenderTableRow {TR} at (0,37) size 781x6
 RenderTableCell {TD} at (0,37) size 781x6 [border: (1px inset #808080)] [r=1 c=0 rs=1 cs=1]
   RenderImage {IMG} at (1,1) size 779x3
   RenderTableRow {TR} at (0,42) size 781x38
 RenderTableCell {TD} at (0,51) size 781x21 [bgcolor=#CC] [border: (1px inset #808080)] [r=2 c=0 rs=1 cs=1]
-  RenderBR {BR} at (1,1) size 0x18
+  RenderBR {BR} at (1,0) size 0x19


Modified: trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug16252-expected.txt (279108 => 279109)

--- trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug16252-expected.txt	2021-06-22 08:06:05 UTC (rev 279108)
+++ trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug16252-expected.txt	2021-06-22 08:37:12 UTC (rev 279109)
@@ -25,7 +25,7 @@
   text run at (2,2) width 245: "CHAMBERLAIN'S CAREER STATISTICS"
 RenderTableRow {TR} at (0,22) size 260x261
   RenderTableCell {TD} at (0,141) size 6x23 [bgcolor=#FF] [r=1 c=0 rs=1 cs=1]
-RenderBR {BR} at (2,2) size 0x18
+RenderBR {BR} at (2,1) size 0x19
   RenderTableCell {TD} at (6,22) size 254x261 [r=1 c=1 rs=1 cs=1]
 RenderTable {TABLE} at (2,2) size 250x240
   RenderTableSection {TBODY} at (0,0) size

[webkit-changes] [279108] trunk

2021-06-22 Thread cathiechen

Title: [279108] trunk








Revision 279108
Author cathiec...@igalia.com
Date 2021-06-22 01:06:05 -0700 (Tue, 22 Jun 2021)


Log Message
Implement width and height attributes on source elements of 
https://bugs.webkit.org/show_bug.cgi?id=222368

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/picture-aspect-ratio-expected.txt:

Source/WebCore:

According to [1], the source element supports dimension attributes. The img element can use the width
and height attributes of the source element to determine its rendered dimensions and aspect-ratio.
In order to implement this, add m_sourceElement to HTMLImageElement to indicate the source element that
is selected. Also add invalidateAttributeMapping() to synchronize with the changes of source's attributes
to the img element. Then add collectExtraStyleForPresentationalHints() to collect style from source attributes.

[1] https://html.spec.whatwg.org/#the-source-element

* dom/ElementData.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationalHintStyle): collectExtraStyleForPresentationalHints() when rebuild.
* dom/StyledElement.h:
(WebCore::StyledElement::collectExtraStyleForPresentationalHints): Add an interface to collect extra style from other elements.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::applyAspectRatioFromWidthAndHeightAttributesToStyle): Add width and height attributes as input variables.
* html/HTMLElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::collectPresentationalHintsForAttribute):
(WebCore::HTMLImageElement::collectExtraStyleForPresentationalHints): If source element has width or height attributes, apply them
to width, height and aspect-ratio of the style.
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Keep the source element.
(WebCore::HTMLImageElement::selectImageSource): Reset the source element to null if no candidate is found.
(WebCore::HTMLImageElement::sourceElement const):
(WebCore::HTMLImageElement::setSourceElement):
(WebCore::HTMLImageElement::invalidateAttributeMapping): Invalidate the presentationalHintStyle.
* html/HTMLImageElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::collectPresentationalHintsForAttribute):
* html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::sourceDimensionAttributesChanged): Call invalidateAttributeMapping if source element's attributes are changed.
* html/HTMLPictureElement.h:
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::attributeChanged): Call sourceDimensionAttributesChanged if width or height attributes are changed.
* html/HTMLSourceElement.h:
* html/HTMLSourceElement.idl:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::collectPresentationalHintsForAttribute):

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/picture-aspect-ratio-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ElementData.h
trunk/Source/WebCore/dom/StyledElement.cpp
trunk/Source/WebCore/dom/StyledElement.h
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLElement.h
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLImageElement.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLPictureElement.cpp
trunk/Source/WebCore/html/HTMLPictureElement.h
trunk/Source/WebCore/html/HTMLSourceElement.cpp
trunk/Source/WebCore/html/HTMLSourceElement.h
trunk/Source/WebCore/html/HTMLSourceElement.idl
trunk/Source/WebCore/html/HTMLVideoElement.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (279107 => 279108)

--- trunk/LayoutTests/ChangeLog	2021-06-22 07:56:27 UTC (rev 279107)
+++ trunk/LayoutTests/ChangeLog	2021-06-22 08:06:05 UTC (rev 279108)
@@ -1,3 +1,12 @@
+2021-06-22  Cathie Chen  
+
+Implement width and height attributes on source elements of 
+https://bugs.webkit.org/show_bug.cgi?id=222368
+
+Reviewed by Darin Adler.
+
+* TestExpectations:
+
 2021-06-21  Carlos Alberto Lopez Perez  
 
 [GLIB] Gardening of test failures.


Modified: trunk/LayoutTests/TestExpectations (279107 => 279108)

--- trunk/LayoutTests/TestExpectations	2021-06-22 07:56:27 UTC (rev 279107)
+++ trunk/LayoutTests/TestExpectations	2021-06-22 08:06:05 UTC (rev 279108)
@@ -1434,9 +1434,6 @@
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html [ Failure Pass ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/object-fallback-failed-cross-origin-navigation.sub.html [ Failure Pass ]
 
-# Newly importing aspect ratio test is flaky.

[webkit-changes] [279107] trunk/Source/JavaScriptCore

2021-06-22 Thread angelos

Title: [279107] trunk/Source/_javascript_Core








Revision 279107
Author ange...@igalia.com
Date 2021-06-22 00:56:27 -0700 (Tue, 22 Jun 2021)


Log Message
Properly set numFPRs on ARM with NEON/VFP_V3_D32
https://bugs.webkit.org/show_bug.cgi?id=227212

Reviewed by Filip Pizlo.

Don't hardcode the number of FP regs on ARMv7 to 16; when targetting a
CPU with NEON or VFP_V3_d32, the number of FP regs is 32.

This also reverts the recent change to add an extra word to RegisterSet
which essentially covered up for this mismatch. The reason this bug only
manifested on certain compiler versions was that GCC 8.4/8.5 where built using
our buildroot infrastructure, whereas the other GCC versions we tested with
were debian system toolchains, targetting a lowest common denominator.

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::std::initializer_list):
* jit/RegisterSet.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/jit/RegisterSet.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279106 => 279107)

--- trunk/Source/_javascript_Core/ChangeLog	2021-06-22 07:42:05 UTC (rev 279106)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-06-22 07:56:27 UTC (rev 279107)
@@ -1,3 +1,23 @@
+2021-06-22  Angelos Oikonomopoulos  
+
+Properly set numFPRs on ARM with NEON/VFP_V3_D32
+https://bugs.webkit.org/show_bug.cgi?id=227212
+
+Reviewed by Filip Pizlo.
+
+Don't hardcode the number of FP regs on ARMv7 to 16; when targetting a
+CPU with NEON or VFP_V3_d32, the number of FP regs is 32.
+
+This also reverts the recent change to add an extra word to RegisterSet
+which essentially covered up for this mismatch. The reason this bug only
+manifested on certain compiler versions was that GCC 8.4/8.5 where built using
+our buildroot infrastructure, whereas the other GCC versions we tested with
+were debian system toolchains, targetting a lowest common denominator.
+
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::std::initializer_list):
+* jit/RegisterSet.h:
+
 2021-06-21  Ross Kirsling  
 
 [JSC] Add JIT ICs for `#x in obj` feature


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (279106 => 279107)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2021-06-22 07:42:05 UTC (rev 279106)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2021-06-22 07:56:27 UTC (rev 279107)
@@ -28,6 +28,8 @@
 
 #if ENABLE(ASSEMBLER)
 
+#include 
+
 #include "ARMv7Assembler.h"
 #include "AbstractMacroAssembler.h"
 
@@ -43,9 +45,10 @@
 inline ARMRegisters::FPSingleRegisterID fpTempRegisterAsSingle() { return ARMRegisters::asSingle(fpTempRegister); }
 
 public:
-static constexpr unsigned numGPRs = 16;
-static constexpr unsigned numFPRs = 16;
-
+#define DUMMY_REGISTER_VALUE(id, name, r, cs) 0,
+static constexpr unsigned numGPRs = std::initializer_list({ FOR_EACH_GP_REGISTER(DUMMY_REGISTER_VALUE) }).size();
+static constexpr unsigned numFPRs = std::initializer_list({ FOR_EACH_FP_REGISTER(DUMMY_REGISTER_VALUE) }).size();
+#undef DUMMY_REGISTER_VALUE
 RegisterID scratchRegister() { return dataTempRegister; }
 
 MacroAssemblerARMv7()


Modified: trunk/Source/_javascript_Core/jit/RegisterSet.h (279106 => 279107)

--- trunk/Source/_javascript_Core/jit/RegisterSet.h	2021-06-22 07:42:05 UTC (rev 279106)
+++ trunk/Source/_javascript_Core/jit/RegisterSet.h	2021-06-22 07:56:27 UTC (rev 279107)
@@ -32,27 +32,10 @@
 #include "Reg.h"
 #include "TempRegisterSet.h"
 #include 
-#include 
 
 namespace JSC {
 
-#if CPU(ARM) && COMPILER(GCC)
-
-#if GCC_VERSION_AT_LEAST(8, 4, 0) && !GCC_VERSION_AT_LEAST(9, 0, 0)
-// GCC 8.4.0 and 8.5.0 seem to miscompile WTF:Bitmap::count code on
-// ARM, something that apparently was covered up by the extra
-// word. The issue seems to not manifest with GCC 8.3.0 and >9.
-// Temporarily cover up by adding back the + 1.
-#define REGISTERSET_BITMAP_SLACK 1
-#else
-#define REGISTERSET_BITMAP_SLACK 0
-#endif
-
-#else
-#define REGISTERSET_BITMAP_SLACK 0
-#endif
-
-typedef Bitmap RegisterBitmap;
+typedef Bitmap RegisterBitmap;
 class RegisterAtOffsetList;
 
 class RegisterSet {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279106] trunk/Source/WebKit

2021-06-22 Thread mmaxfield

Title: [279106] trunk/Source/WebKit








Revision 279106
Author mmaxfi...@apple.com
Date 2021-06-22 00:42:05 -0700 (Tue, 22 Jun 2021)


Log Message
[Cocoa] Force a copy of font data when receiving it from the untrusted web process
https://bugs.webkit.org/show_bug.cgi?id=227247


Reviewed by Maciej Stachowiak.

Sending a SharedBuffer across IPC is implemented by having the receiver map a shmem into its address space. On
the sender's side, the shmem still exists, and a compromised web process could scribble data into it after
sending it. So, when the GPU process receives the font data, we need to make a copy of it locally to make sure
the data can't change out from under us.

No new tests because there is no behavior change.

* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder>::decodePlatformData):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (279105 => 279106)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 06:41:14 UTC (rev 279105)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 07:42:05 UTC (rev 279106)
@@ -1,3 +1,21 @@
+2021-06-22  Myles C. Maxfield  
+
+[Cocoa] Force a copy of font data when receiving it from the untrusted web process
+https://bugs.webkit.org/show_bug.cgi?id=227247
+
+
+Reviewed by Maciej Stachowiak.
+
+Sending a SharedBuffer across IPC is implemented by having the receiver map a shmem into its address space. On
+the sender's side, the shmem still exists, and a compromised web process could scribble data into it after
+sending it. So, when the GPU process receives the font data, we need to make a copy of it locally to make sure
+the data can't change out from under us.
+
+No new tests because there is no behavior change.
+
+* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
+(IPC::ArgumentCoder>::decodePlatformData):
+
 2021-06-21  Said Abou-Hallawa  
 
 [GPU Process] RELEASE_ASSERT in RemoteResourceCacheProxy::didFinalizeRenderingUpdate() may fire if GPUP is relaunched


Modified: trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm (279105 => 279106)

--- trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm	2021-06-22 06:41:14 UTC (rev 279105)
+++ trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm	2021-06-22 07:42:05 UTC (rev 279106)
@@ -541,12 +541,15 @@
 if (!fontFaceData)
 return std::nullopt;
 
+// Upon receipt, copy the data for security, so the sender can't scribble over it while we're using it.
+auto localFontFaceData = WebCore::SharedBuffer::create(fontFaceData.value()->data(), fontFaceData.value()->size());
+
 std::optional itemInCollection;
 decoder >> itemInCollection;
 if (!itemInCollection)
 return std::nullopt;
 
-auto fontCustomPlatformData = createFontCustomPlatformData(*fontFaceData, *itemInCollection);
+auto fontCustomPlatformData = createFontCustomPlatformData(localFontFaceData, *itemInCollection);
 if (!fontCustomPlatformData)
 return std::nullopt;
 auto baseFontDescriptor = fontCustomPlatformData->fontDescriptor.get();
@@ -555,7 +558,7 @@
 auto fontDescriptor = adoptCF(CTFontDescriptorCreateCopyWithAttributes(baseFontDescriptor, attributes->get()));
 auto ctFont = adoptCF(CTFontCreateWithFontDescriptor(fontDescriptor.get(), *size, nullptr));
 
-auto creationData = WebCore::FontPlatformData::CreationData { *fontFaceData, *itemInCollection };
+auto creationData = WebCore::FontPlatformData::CreationData { localFontFaceData, *itemInCollection };
 return WebCore::FontPlatformData(ctFont.get(), *size, *syntheticBold, *syntheticOblique, *orientation, *widthVariant, *textRenderingMode, );
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279105] trunk

2021-06-22 Thread ross . kirsling

Title: [279105] trunk








Revision 279105
Author ross.kirsl...@sony.com
Date 2021-06-21 23:41:14 -0700 (Mon, 21 Jun 2021)


Log Message
[JSC] Add JIT ICs for `#x in obj` feature
https://bugs.webkit.org/show_bug.cgi?id=226146

Reviewed by Saam Barati.

JSTests:

* microbenchmarks/has-private-brand.js: Added.
* microbenchmarks/has-private-name.js: Added.

Source/_javascript_Core:

This patch implements JIT ICs for the new `#x in obj` feature and turns the feature on by default.
Implementation closely follows InByVal, though HasPrivateBrand has a few subtleties
(namely, it cannot be viewed in terms of a PropertySlot and should not be converted to InById).

Microbenchmarks:
has-private-name46.5777+-0.1374 ^  6.0589+-0.0296^ definitely 7.6875x faster
has-private-brand   25.8823+-0.0561 ^ 19.1509+-0.0447^ definitely 1.3515x faster

* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::reset):
* bytecode/StructureStubInfo.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInByAsMatchStructure):
(JSC::DFG::ByteCodeParser::handleInById):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInByVal):
(JSC::DFG::SpeculativeJIT::compileHasPrivate):
(JSC::DFG::SpeculativeJIT::compileHasPrivateName):
(JSC::DFG::SpeculativeJIT::compileHasPrivateBrand):
* dfg/DFGSpeculativeJIT.h:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITInlineCacheGenerator.cpp:
(JSC::JITInByValGenerator::JITInByValGenerator):
* jit/JITInlineCacheGenerator.h:
* jit/JITOperations.cpp:
(JSC::JSC_DEFINE_JIT_OPERATION):
* jit/JITOperations.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_in_by_val):
(JSC::JIT::emitHasPrivate):
(JSC::JIT::emitHasPrivateSlow):
(JSC::JIT::emit_op_has_private_name):
(JSC::JIT::emitSlow_op_has_private_name):
(JSC::JIT::emit_op_has_private_brand):
(JSC::JIT::emitSlow_op_has_private_brand):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_in_by_val):
(JSC::JIT::emitHasPrivate):
(JSC::JIT::emitHasPrivateSlow):
(JSC::JIT::emit_op_has_private_name):
(JSC::JIT::emitSlow_op_has_private_name):
(JSC::JIT::emit_op_has_private_brand):
(JSC::JIT::emitSlow_op_has_private_brand):
* jit/Repatch.cpp:
(JSC::appropriateOptimizingInByFunction):
(JSC::appropriateGenericInByFunction):
(JSC::tryCacheInBy):
(JSC::repatchInBy):
(JSC::tryCacheHasPrivateBrand):
(JSC::repatchHasPrivateBrand):
(JSC::resetInBy):
(JSC::resetHasPrivateBrand):
* jit/Repatch.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter.asm:
* runtime/CommonSlowPaths.cpp:
* runtime/CommonSlowPaths.h:
* runtime/OptionsList.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITInlineCacheGenerator.cpp
trunk/Source/_javascript_Core/jit/JITInlineCacheGenerator.h
trunk/Source/_javascript_Core/jit/JITOperations.cpp
trunk/Source/_javascript_Core/jit/JITOperations.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/jit/Repatch.h
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.h
trunk/Source/_javascript_Core/runtime/OptionsList.h


Added Paths

trunk/JSTests/microbenchmarks/has-private-brand.js
trunk/JSTests/microbenchmarks/has-private-name.js




Diff

Modified: trunk/JSTests/ChangeLog (279104 => 279105)

--- trunk/JSTests/ChangeLog	2021-06-22 06:08:29 UTC (rev 279104)
+++ trunk/JSTests/ChangeLog	2021-06-22 06:41:14 UTC (rev 279105)
@@ -1,3 +1,13 @@
+2021-06-21  Ross Kirsling  
+
+[JSC] Add JIT ICs for `#x in obj` feature
+https://bugs.webkit.org/show_bug.cgi?id=226146
+
+Reviewed by Saam Barati.
+
+* microbenchmarks/has-private-brand.js: Added.
+* microbenchmarks/has-private-name.js: Added.
+
 2021-06-21  Xan Lopez  
 
 [JSC] Fix consistency check during stack splitting in Wasm::LLIntGenerator::addLoop


Added: trunk/JSTests/microbenchmarks/has-private-brand.js (0 => 279105)

--- trunk/JSTests/microbenchmarks/has-private-brand.js	(rev

[webkit-changes] [279104] trunk/Source/WebKit

2021-06-22 Thread said

Title: [279104] trunk/Source/WebKit








Revision 279104
Author s...@apple.com
Date 2021-06-21 23:08:29 -0700 (Mon, 21 Jun 2021)


Log Message
[GPU Process] RELEASE_ASSERT in RemoteResourceCacheProxy::didFinalizeRenderingUpdate() may fire if GPUP is relaunched
https://bugs.webkit.org/show_bug.cgi?id=227229


Reviewed by Myles C. Maxfield.

1) Remove maximumUnusedFontCountToSkipRemoval because
   'unusedFontCount < maximumUnusedFontCountToSkipRemoval' can't be true
   since both unusedFontCount and maximumUnusedFontCountToSkipRemoval are
   unsigned and maximumUnusedFontCountToSkipRemoval is equal to zero.
   So they can only be equal and we can replace this by '!unusedFontCount'.

2) RemoteResourceCacheProxy::cacheFont() assumes if the font is cached in
   m_fontIdentifierToLastRenderingUpdateVersionMap then it is also cached
   in GPUP. We have to keep this assumption correct by removing the
   corresponding entries from m_fontIdentifierToLastRenderingUpdateVersionMap.

3) RemoteResourceCacheProxy::didFinalizeRenderingUpdate() needs to reset
   m_numberOfFontsUsedInCurrentRenderingUpdate and to increment
   m_currentRenderingUpdateVersion in all its code branches.

4) If the GPUP is relaunched, we need to set
   m_numberOfFontsUsedInCurrentRenderingUpdate to zero after we clear
   m_fontIdentifierToLastRenderingUpdateVersionMap. Otherwise the
   RELEASE_ASSERT in RemoteResourceCacheProxy::didFinalizeRenderingUpdate()
   will fire.

* WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::prepareForNextRenderingUpdate):
(WebKit::RemoteResourceCacheProxy::clearFontMap):
(WebKit::RemoteResourceCacheProxy::didFinalizeRenderingUpdate):
(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):
(WebKit::RemoteResourceCacheProxy::releaseMemory):
* WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (279103 => 279104)

--- trunk/Source/WebKit/ChangeLog	2021-06-22 04:57:23 UTC (rev 279103)
+++ trunk/Source/WebKit/ChangeLog	2021-06-22 06:08:29 UTC (rev 279104)
@@ -1,3 +1,40 @@
+2021-06-21  Said Abou-Hallawa  
+
+[GPU Process] RELEASE_ASSERT in RemoteResourceCacheProxy::didFinalizeRenderingUpdate() may fire if GPUP is relaunched
+https://bugs.webkit.org/show_bug.cgi?id=227229
+
+
+Reviewed by Myles C. Maxfield.
+
+1) Remove maximumUnusedFontCountToSkipRemoval because 
+   'unusedFontCount < maximumUnusedFontCountToSkipRemoval' can't be true
+   since both unusedFontCount and maximumUnusedFontCountToSkipRemoval are
+   unsigned and maximumUnusedFontCountToSkipRemoval is equal to zero.
+   So they can only be equal and we can replace this by '!unusedFontCount'.
+
+2) RemoteResourceCacheProxy::cacheFont() assumes if the font is cached in
+   m_fontIdentifierToLastRenderingUpdateVersionMap then it is also cached
+   in GPUP. We have to keep this assumption correct by removing the 
+   corresponding entries from m_fontIdentifierToLastRenderingUpdateVersionMap.
+
+3) RemoteResourceCacheProxy::didFinalizeRenderingUpdate() needs to reset
+   m_numberOfFontsUsedInCurrentRenderingUpdate and to increment 
+   m_currentRenderingUpdateVersion in all its code branches.
+
+4) If the GPUP is relaunched, we need to set 
+   m_numberOfFontsUsedInCurrentRenderingUpdate to zero after we clear
+   m_fontIdentifierToLastRenderingUpdateVersionMap. Otherwise the
+   RELEASE_ASSERT in RemoteResourceCacheProxy::didFinalizeRenderingUpdate()
+   will fire.
+
+* WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
+(WebKit::RemoteResourceCacheProxy::prepareForNextRenderingUpdate):
+(WebKit::RemoteResourceCacheProxy::clearFontMap):
+(WebKit::RemoteResourceCacheProxy::didFinalizeRenderingUpdate):
+(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):
+(WebKit::RemoteResourceCacheProxy::releaseMemory):
+* WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:
+
 2021-06-21  Wenson Hsieh  
 
 [macOS] [WebKitLegacy] Non-actionable "Look Up" action appears when right clicking images


Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp (279103 => 279104)

--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp	2021-06-22 04:57:23 UTC (rev 279103)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp	2021-06-22 06:08:29 UTC (rev 279104)
@@ -105,15 +105,16 @@
 void RemoteResourceCacheProxy::cacheFont(Font& font)
 {
 auto result = m_fontIdentifierToLastRenderingUpdateVersionMap.ensure(font.renderingResourceIdentifier(), [&] {
-return 0;
+

61 matches

Mail list logo