date:20210707

[webkit-changes] [279712] trunk/Source/WebCore

2021-07-07 Thread heycam

Title: [279712] trunk/Source/WebCore








Revision 279712
Author hey...@apple.com
Date 2021-07-07 23:53:01 -0700 (Wed, 07 Jul 2021)


Log Message
Add logging for GraphicsLayerCA::m_uncommittedChanges
https://bugs.webkit.org/show_bug.cgi?id=227783

Reviewed by Simon Fraser.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::layerChangeAsString):
(WebCore::GraphicsLayerCA::dumpLayerChangeFlags):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties const):
* platform/graphics/ca/GraphicsLayerCA.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (279711 => 279712)

--- trunk/Source/WebCore/ChangeLog	2021-07-08 06:46:49 UTC (rev 279711)
+++ trunk/Source/WebCore/ChangeLog	2021-07-08 06:53:01 UTC (rev 279712)
@@ -1,3 +1,16 @@
+2021-07-07  Cameron McCormack  
+
+Add logging for GraphicsLayerCA::m_uncommittedChanges
+https://bugs.webkit.org/show_bug.cgi?id=227783
+
+Reviewed by Simon Fraser.
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::layerChangeAsString):
+(WebCore::GraphicsLayerCA::dumpLayerChangeFlags):
+(WebCore::GraphicsLayerCA::dumpAdditionalProperties const):
+* platform/graphics/ca/GraphicsLayerCA.h:
+
 2021-07-07  John Wilander  
 
 PCM: Add error logging for CryptoKit operations


Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (279711 => 279712)

--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2021-07-08 06:46:49 UTC (rev 279711)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2021-07-08 06:53:01 UTC (rev 279712)
@@ -4133,6 +4133,80 @@
 }
 }
 
+const char* GraphicsLayerCA::layerChangeAsString(LayerChange layerChange)
+{
+switch (layerChange) {
+case LayerChange::NoChange: return ""; break;
+case LayerChange::NameChanged: return "NameChanged";
+case LayerChange::ChildrenChanged: return "ChildrenChanged";
+case LayerChange::GeometryChanged: return "GeometryChanged";
+case LayerChange::TransformChanged: return "TransformChanged";
+case LayerChange::ChildrenTransformChanged: return "ChildrenTransformChanged";
+case LayerChange::Preserves3DChanged: return "Preserves3DChanged";
+case LayerChange::MasksToBoundsChanged: return "MasksToBoundsChanged";
+case LayerChange::DrawsContentChanged: return "DrawsContentChanged";
+case LayerChange::BackgroundColorChanged: return "BackgroundColorChanged";
+case LayerChange::ContentsOpaqueChanged: return "ContentsOpaqueChanged";
+case LayerChange::BackfaceVisibilityChanged: return "BackfaceVisibilityChanged";
+case LayerChange::OpacityChanged: return "OpacityChanged";
+case LayerChange::AnimationChanged: return "AnimationChanged";
+case LayerChange::DirtyRectsChanged: return "DirtyRectsChanged";
+case LayerChange::ContentsImageChanged: return "ContentsImageChanged";
+case LayerChange::ContentsPlatformLayerChanged: return "ContentsPlatformLayerChanged";
+case LayerChange::ContentsColorLayerChanged: return "ContentsColorLayerChanged";
+case LayerChange::ContentsRectsChanged: return "ContentsRectsChanged";
+case LayerChange::MasksToBoundsRectChanged: return "MasksToBoundsRectChanged";
+case LayerChange::MaskLayerChanged: return "MaskLayerChanged";
+case LayerChange::ReplicatedLayerChanged: return "ReplicatedLayerChanged";
+case LayerChange::ContentsNeedsDisplay: return "ContentsNeedsDisplay";
+case LayerChange::AcceleratesDrawingChanged: return "AcceleratesDrawingChanged";
+case LayerChange::SupportsSubpixelAntialiasedTextChanged: return "SupportsSubpixelAntialiasedTextChanged";
+case LayerChange::ContentsScaleChanged: return "ContentsScaleChanged";
+case LayerChange::ContentsVisibilityChanged: return "ContentsVisibilityChanged";
+case LayerChange::CoverageRectChanged: return "CoverageRectChanged";
+case LayerChange::FiltersChanged: return "FiltersChanged";
+case LayerChange::BackdropFiltersChanged: return "BackdropFiltersChanged";
+case LayerChange::BackdropFiltersRectChanged: return "BackdropFiltersRectChanged";
+case LayerChange::TilingAreaChanged: return "TilingAreaChanged";
+case LayerChange::DebugIndicatorsChanged: return "DebugIndicatorsChanged";
+case LayerChange::CustomAppearanceChanged: return "CustomAppearanceChanged";
+case LayerChange::BlendModeChanged: return "BlendModeChanged";
+case LayerChange::ShapeChanged: return "ShapeChanged";
+case LayerChange::WindRuleChanged: return "WindRuleChanged";
+case LayerChange::UserInteractionEnabledChanged: return "UserInteractionEnabledChanged";
+case LayerChange::NeedsComputeVisibleAndCoverageRect: return "NeedsComputeVisibleAndCoverageRect";
+case LayerChange::EventRegionChanged: return "EventRegionChanged";

[webkit-changes] [279711] trunk

2021-07-07 Thread timothy_horton

Title: [279711] trunk








Revision 279711
Author timothy_hor...@apple.com
Date 2021-07-07 23:46:49 -0700 (Wed, 07 Jul 2021)


Log Message
Add WKHoverPlatter and some knobs to tweak its appearance
https://bugs.webkit.org/show_bug.cgi?id=227735


Reviewed by Sam Weinig.

Source/WebCore/PAL:

* pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

* Configurations/WebKit.xcconfig:
* Platform/spi/ios/PrototypeToolsSPI.h: Added.
* SourcesCocoa.txt:
* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView rootContentView]):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
Install and uninstall the platter alongside the gestures that drive it.

(-[WKContentView mouseGestureRecognizerChanged:]):
(-[WKContentView hoverGestureRecognizerChanged:]):
When the gesture recognizers fire, also update the hover point.

(-[WKContentView positionInformationForHoverPlatter:withRequest:completionHandler:]):
* UIProcess/ios/WKHoverPlatter.h: Added.
* UIProcess/ios/WKHoverPlatter.mm: Added.
(createBaseAnimation):
(addAnimation):
(setAdditionalPlatterLayerProperties):
(addAdditionalIncomingAnimations):
(addAdditionalDismissalAnimations):
(-[WKHoverPlatter initWithView:delegate:]):
(-[WKHoverPlatter invalidate]):
(-[WKHoverPlatter hoverPoint]):
(-[WKHoverPlatter setHoverPoint:]):
(-[WKHoverPlatter requestPositionInformationForCurrentHoverPoint]):
(-[WKHoverPlatter didReceivePositionInformation:]):
(-[WKHoverPlatter dismissPlatterWithAnimation:]):
(-[WKHoverPlatter didFinishAnimationForShadow:]):
(-[WKHoverPlatter clearLayers]):
Animate the platter in and out, and optionally between states, as the hover point moves.
Use the TextIndicator's geometry information, but not its snapshot; we use a
CAPortalLayer for the platter instead. A future patch will avoid taking the snapshot
entirely, since we call setHoverPoint (and thus generate a TextIndicator) a *lot*
when moving the mouse around, and all those snapshots add up.

* UIProcess/ios/WKHoverPlatterParameters.h: Added.
* UIProcess/ios/WKHoverPlatterParameters.mm: Added.
(-[PTSliderRow integerMinValue:maxValue:]):
(-[WKHoverPlatterParameters setDefaultValues]):
(+[WKHoverPlatterParameters settingsControllerModule]):
(+[WKHoverPlatterDomain rootSettings]):
(+[WKHoverPlatterDomain domainGroupName]):
(+[WKHoverPlatterDomain domainName]):
(+[WKHoverPlatterDomain rootSettingsClass]):
Add some knobs, with reasonable defaults, for experimentation.

* WebKit.xcodeproj/project.pbxproj:

WebKitLibraries:

* WebKitPrivateFrameworkStubs/appletvos/14/PrototypeTools.framework/PrototypeTools.tbd: Added.
* WebKitPrivateFrameworkStubs/appletvos/15/PrototypeTools.framework/PrototypeTools.tbd: Added.
* WebKitPrivateFrameworkStubs/iOS/14/PrototypeTools.framework/PrototypeTools.tbd: Added.
* WebKitPrivateFrameworkStubs/iOS/15/PrototypeTools.framework/PrototypeTools.tbd: Added.
* WebKitPrivateFrameworkStubs/watchos/7/PrototypeTools.framework/PrototypeTools.tbd: Added.
* WebKitPrivateFrameworkStubs/watchos/8/PrototypeTools.framework/PrototypeTools.tbd: Added.

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/ios/WKContentView.h
trunk/Source/WebKit/UIProcess/ios/WKContentView.mm
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/WebKitLibraries/ChangeLog


Added Paths

trunk/Source/WebKit/Platform/spi/ios/PrototypeToolsSPI.h
trunk/Source/WebKit/UIProcess/ios/WKHoverPlatter.h
trunk/Source/WebKit/UIProcess/ios/WKHoverPlatter.mm
trunk/Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.h
trunk/Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.mm
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/appletvos/14/PrototypeTools.framework/
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/appletvos/14/PrototypeTools.framework/PrototypeTools.tbd
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/appletvos/15/PrototypeTools.framework/
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/appletvos/15/PrototypeTools.framework/PrototypeTools.tbd
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/14/PrototypeTools.framework/
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/14/PrototypeTools.framework/PrototypeTools.tbd
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/15/PrototypeTools.framework/
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/15/PrototypeTools.framework/PrototypeTools.tbd
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/watchos/7/PrototypeTools.framework/
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/watchos/7/PrototypeTools.framework/PrototypeTools.tbd
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/watchos/8/Prot

[webkit-changes] [279710] trunk

2021-07-07 Thread wilander

Title: [279710] trunk








Revision 279710
Author wilan...@apple.com
Date 2021-07-07 22:09:53 -0700 (Wed, 07 Jul 2021)


Log Message
PCM: Add error logging for CryptoKit operations
https://bugs.webkit.org/show_bug.cgi?id=227731


Reviewed by Brent Fulgham.

Resolves three FIXMEs for error logging in PCM's CryptoKit operations.

Source/WebCore:

No new tests. Only added logging.

* loader/PrivateClickMeasurement.h:
* loader/cocoa/PrivateClickMeasurementCocoa.mm:
(WebCore::PrivateClickMeasurement::calculateAndUpdateSourceUnlinkableToken):
(WebCore::PrivateClickMeasurement::calculateAndUpdateSourceSecretToken):

Source/WebKit:

* NetworkProcess/PrivateClickMeasurementManager.cpp:
(WebKit::PrivateClickMeasurementManager::storeUnattributed):
(WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken):

Tools:

* TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:
(TestWebKitAPI::TEST):
Now expects an optional string instead of a bool from the function
calls which means EXPECT_TRUE has become EXPECT_FALSE. The optional
string is non-nullopt if it carries an error message.
* TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm:
(TestWebKitAPI::TEST):
Now expects an optional string instead of a bool from the function
calls which means EXPECT_TRUE has become EXPECT_FALSE. The optional
string is non-nullopt if it carries an error message.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/PrivateClickMeasurement.h
trunk/Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp
trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (279709 => 279710)

--- trunk/Source/WebCore/ChangeLog	2021-07-08 04:48:27 UTC (rev 279709)
+++ trunk/Source/WebCore/ChangeLog	2021-07-08 05:09:53 UTC (rev 279710)
@@ -1,3 +1,20 @@
+2021-07-07  John Wilander  
+
+PCM: Add error logging for CryptoKit operations
+https://bugs.webkit.org/show_bug.cgi?id=227731
+
+
+Reviewed by Brent Fulgham.
+
+Resolves three FIXMEs for error logging in PCM's CryptoKit operations.
+
+No new tests. Only added logging.
+
+* loader/PrivateClickMeasurement.h:
+* loader/cocoa/PrivateClickMeasurementCocoa.mm:
+(WebCore::PrivateClickMeasurement::calculateAndUpdateSourceUnlinkableToken):
+(WebCore::PrivateClickMeasurement::calculateAndUpdateSourceSecretToken):
+
 2021-07-07  Chris Dumez  
 
 Our structured cloning implementation does not encode all of RegExp's flags


Modified: trunk/Source/WebCore/loader/PrivateClickMeasurement.h (279709 => 279710)

--- trunk/Source/WebCore/loader/PrivateClickMeasurement.h	2021-07-08 04:48:27 UTC (rev 279709)
+++ trunk/Source/WebCore/loader/PrivateClickMeasurement.h	2021-07-08 05:09:53 UTC (rev 279710)
@@ -354,8 +354,8 @@
 };
 
 #if PLATFORM(COCOA)
-WEBCORE_EXPORT bool calculateAndUpdateSourceUnlinkableToken(const String& serverPublicKeyBase64URL);
-WEBCORE_EXPORT bool calculateAndUpdateSourceSecretToken(const String& serverResponseBase64URL);
+WEBCORE_EXPORT std::optional calculateAndUpdateSourceUnlinkableToken(const String& serverPublicKeyBase64URL);
+WEBCORE_EXPORT std::optional calculateAndUpdateSourceSecretToken(const String& serverResponseBase64URL);
 #endif
 
 void setSourceUnlinkableTokenValue(const String& value) { m_sourceUnlinkableToken.valueBase64URL = value; }


Modified: trunk/Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm (279709 => 279710)

--- trunk/Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm	2021-07-08 04:48:27 UTC (rev 279709)
+++ trunk/Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm	2021-07-08 05:09:53 UTC (rev 279710)
@@ -30,50 +30,56 @@
 
 namespace WebCore {
 
-bool PrivateClickMeasurement::calculateAndUpdateSourceUnlinkableToken(const String& serverPublicKeyBase64URL)
+std::optional PrivateClickMeasurement::calculateAndUpdateSourceUnlinkableToken(const String& serverPublicKeyBase64URL)
 {
 #if HAVE(RSA_BSSA)
 {
 auto serverPublicKeyData = base64URLDecode(serverPublicKeyBase64URL);
 if (!serverPublicKeyData)
-return false;
+return "Could not decode the source's public key data."_s;
 auto serverPublicKey = adoptNS([[NSData alloc] initWithBytes:serverPublicKeyData->data() length:serverPublicKeyData->size()]);
 
-// FIXME(222018): Check error.
-m_sourceUnlinkableToken.blinder = adoptNS([PAL::allocRSABSSATokenBlinderInstance() initWithPublicKey:serverPublicKey.get() error:nullptr]);
+NSError* nsError = 0;
+m_sourceUnlinkableToken.blinder = adoptNS([PAL::allocRSABSSATokenBlinderInstance() initWithPublicKey:serverPublicKey.get() error:&nsError]);

[webkit-changes] [279709] trunk/Source/JavaScriptCore

2021-07-07 Thread ysuzuki

Title: [279709] trunk/Source/_javascript_Core








Revision 279709
Author ysuz...@apple.com
Date 2021-07-07 21:48:27 -0700 (Wed, 07 Jul 2021)


Log Message
[JSC] Clean up RegExp flag code
https://bugs.webkit.org/show_bug.cgi?id=227786

Reviewed by Filip Pizlo.

I found a bug in regexpToSourceString (used for RegExp's dump code), and it motivates me to clean up
all RegExp flag handling code. We define RegExp flags as a macro and updating that macro updates all
RegExp flag handling code too.

* runtime/RegExp.cpp:
(JSC::RegExpFunctionalTestCollector::outputOneTest):
(JSC::regexpToSourceString):
* runtime/RegExp.h:
* runtime/RegExpPrototype.cpp:
(JSC::flagsString):
* yarr/YarrFlags.cpp:
(JSC::Yarr::parseFlags):
(JSC::Yarr::flagsString):
* yarr/YarrFlags.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h
trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp
trunk/Source/_javascript_Core/yarr/YarrFlags.cpp
trunk/Source/_javascript_Core/yarr/YarrFlags.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279708 => 279709)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-08 03:53:24 UTC (rev 279708)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-08 04:48:27 UTC (rev 279709)
@@ -1,3 +1,25 @@
+2021-07-07  Yusuke Suzuki  
+
+[JSC] Clean up RegExp flag code
+https://bugs.webkit.org/show_bug.cgi?id=227786
+
+Reviewed by Filip Pizlo.
+
+I found a bug in regexpToSourceString (used for RegExp's dump code), and it motivates me to clean up
+all RegExp flag handling code. We define RegExp flags as a macro and updating that macro updates all
+RegExp flag handling code too.
+
+* runtime/RegExp.cpp:
+(JSC::RegExpFunctionalTestCollector::outputOneTest):
+(JSC::regexpToSourceString):
+* runtime/RegExp.h:
+* runtime/RegExpPrototype.cpp:
+(JSC::flagsString):
+* yarr/YarrFlags.cpp:
+(JSC::Yarr::parseFlags):
+(JSC::Yarr::flagsString):
+* yarr/YarrFlags.h:
+
 2021-07-07  Saam Barati  
 
 JSArrayBufferView::byteOffsetConcurrently has a race when using PAC


Modified: trunk/Source/_javascript_Core/runtime/RegExp.cpp (279708 => 279709)

--- trunk/Source/_javascript_Core/runtime/RegExp.cpp	2021-07-08 03:53:24 UTC (rev 279708)
+++ trunk/Source/_javascript_Core/runtime/RegExp.cpp	2021-07-08 04:48:27 UTC (rev 279709)
@@ -51,21 +51,7 @@
 fputc('/', m_file);
 outputEscapedString(regExp->pattern(), true);
 fputc('/', m_file);
-if (regExp->global())
-fputc('g', m_file);
-if (regExp->ignoreCase())
-fputc('i', m_file);
-if (regExp->hasIndices())
-fputc('d', m_file);
-if (regExp->multiline())
-fputc('m', m_file);
-if (regExp->dotAll())
-fputc('s', m_file);
-if (regExp->unicode())
-fputc('u', m_file);
-if (regExp->sticky())
-fputc('y', m_file);
-fprintf(m_file, "\n");
+fprintf(m_file, "%s\n", Yarr::flagsString(regExp->flags()).data());
 }
 
 fprintf(m_file, " \"");
@@ -484,24 +470,7 @@
 
 static CString regexpToSourceString(const RegExp* regExp)
 {
-char postfix[7] = { '/', 0, 0, 0, 0, 0, 0 };
-int index = 1;
-if (regExp->global())
-postfix[index++] = 'g';
-if (regExp->ignoreCase())
-postfix[index++] = 'i';
-if (regExp->hasIndices())
-postfix[index] = 'd';
-if (regExp->multiline())
-postfix[index] = 'm';
-if (regExp->dotAll())
-postfix[index++] = 's';
-if (regExp->unicode())
-postfix[index++] = 'u';
-if (regExp->sticky())
-postfix[index++] = 'y';
-
-return toCString("/", regExp->pattern().impl(), postfix);
+return toCString("/", regExp->pattern().impl(), "/", Yarr::flagsString(regExp->flags()).data());
 }
 
 void RegExp::dumpToStream(const JSCell* cell, PrintStream& out)


Modified: trunk/Source/_javascript_Core/runtime/RegExp.h (279708 => 279709)

--- trunk/Source/_javascript_Core/runtime/RegExp.h	2021-07-08 03:53:24 UTC (rev 279708)
+++ trunk/Source/_javascript_Core/runtime/RegExp.h	2021-07-08 04:48:27 UTC (rev 279709)
@@ -57,14 +57,11 @@
 static size_t estimatedSize(JSCell*, VM&);
 JS_EXPORT_PRIVATE static void dumpToStream(const JSCell*, PrintStream&);
 
-bool global() const { return m_flags.contains(Yarr::Flags::Global); }
-bool ignoreCase() const { return m_flags.contains(Yarr::Flags::IgnoreCase); }
-bool multiline() const { return m_flags.contains(Yarr::Flags::Multiline); }
-bool sticky() const { return m_flags.contains(Yarr::Flags::Sticky); }
+OptionSet flags() const { return m_flags; }
+#define JSC_DEFINE_REGEXP_FLAG_ACCESSOR(key, name, lowerCaseName, index) bool lowerCaseName() const { return m_flags.contains(Yarr::Flags::name); }
+JSC_REGEXP_FLAGS(JSC_DEFINE_REGE

[webkit-changes] [279708] trunk/Source/WebKit

2021-07-07 Thread drousso

Title: [279708] trunk/Source/WebKit








Revision 279708
Author drou...@apple.com
Date 2021-07-07 20:53:24 -0700 (Wed, 07 Jul 2021)


Log Message
Extremely jumpy window resizing in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=167529


Reviewed by Tim Horton.

Instead of computing the `m_pendingTopContentInset` inside `updateContentInsetsIfAutomatic`,
wait to do it until we're actually dispatching the value to the WebProcess, as it's possible
for the former to happen while still inside a layout, which could result in the wrong value.

* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateContentInsetsIfAutomatic):
(WebKit::WebViewImpl::topContentInset const):
(WebKit::WebViewImpl::setTopContentInset):
(WebKit::WebViewImpl::scheduleSetTopContentInsetDispatch): Added.
(WebKit::WebViewImpl::dispatchSetTopContentInset):
Still keep `m_pendingTopContentInset` so that manual calls to `setTopContentInset` can also
be batched with `updateContentInsetsIfAutomatic`, each taking precedence over the other if
called later.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (279707 => 279708)

--- trunk/Source/WebKit/ChangeLog	2021-07-08 02:20:51 UTC (rev 279707)
+++ trunk/Source/WebKit/ChangeLog	2021-07-08 03:53:24 UTC (rev 279708)
@@ -1,3 +1,26 @@
+2021-07-07  Devin Rousso  
+
+Extremely jumpy window resizing in MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=167529
+
+
+Reviewed by Tim Horton.
+
+Instead of computing the `m_pendingTopContentInset` inside `updateContentInsetsIfAutomatic`,
+wait to do it until we're actually dispatching the value to the WebProcess, as it's possible
+for the former to happen while still inside a layout, which could result in the wrong value.
+
+* UIProcess/Cocoa/WebViewImpl.h:
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::updateContentInsetsIfAutomatic):
+(WebKit::WebViewImpl::topContentInset const):
+(WebKit::WebViewImpl::setTopContentInset):
+(WebKit::WebViewImpl::scheduleSetTopContentInsetDispatch): Added.
+(WebKit::WebViewImpl::dispatchSetTopContentInset):
+Still keep `m_pendingTopContentInset` so that manual calls to `setTopContentInset` can also
+be batched with `updateContentInsetsIfAutomatic`, each taking precedence over the other if
+called later.
+
 2021-07-07  Chris Dumez  
 
 Unreviewed follow-up to r279601 to address some assertions on the bots.


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h (279707 => 279708)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h	2021-07-08 02:20:51 UTC (rev 279707)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h	2021-07-08 03:53:24 UTC (rev 279708)
@@ -709,6 +709,8 @@
 
 bool supportsArbitraryLayoutModes() const;
 float intrinsicDeviceScaleFactor() const;
+
+void scheduleSetTopContentInsetDispatch();
 void dispatchSetTopContentInset();
 
 void postFakeMouseMovedEventForFlagsChangedEvent(NSEvent *);
@@ -768,8 +770,8 @@
 bool m_windowOcclusionDetectionEnabled { true };
 
 bool m_automaticallyAdjustsContentInsets { false };
-CGFloat m_pendingTopContentInset { 0 };
-bool m_didScheduleSetTopContentInset { false };
+std::optional m_pendingTopContentInset;
+bool m_didScheduleSetTopContentInsetDispatch { false };
 
 CGSize m_scrollOffsetAdjustment { 0, 0 };
 


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (279707 => 279708)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	2021-07-08 02:20:51 UTC (rev 279707)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	2021-07-08 03:53:24 UTC (rev 279708)
@@ -2014,21 +2014,14 @@
 if (!m_automaticallyAdjustsContentInsets)
 return;
 
-NSWindow *window = [m_view window];
-if ((window.styleMask & NSWindowStyleMaskFullSizeContentView) && !window.titlebarAppearsTransparent && ![m_view enclosingScrollView]) {
-NSRect contentLayoutRectInWebViewCoordinates = [m_view convertRect:window.contentLayoutRect fromView:nil];
-CGFloat newTopContentInset = std::max(contentLayoutRectInWebViewCoordinates.origin.y, 0);
-if (m_page->topContentInset() != newTopContentInset)
-setTopContentInset(newTopContentInset);
-} else
-setTopContentInset(0);
+m_pendingTopContentInset = std::nullopt;
+
+scheduleSetTopContentInsetDispatch();
 }
 
 CGFloat WebViewImpl::topContentInset() const
 {
-if (m_didScheduleSetTopContentInset)
-return m_pendingTopContentInset;
-return m_page->topContentInset();
+return m_pendingTopContentInset.value_or(m_page->topContentInset());
 }
 
 void WebViewImpl::setTopContentInset(CGFloat contentInset)
@@ -2035,10 +2028,15 @@
 {
 m_pendingTopContentInset = contentInset;

[webkit-changes] [279707] trunk/Source/JavaScriptCore

2021-07-07 Thread sbarati

Title: [279707] trunk/Source/_javascript_Core








Revision 279707
Author sbar...@apple.com
Date 2021-07-07 19:20:51 -0700 (Wed, 07 Jul 2021)


Log Message
JSArrayBufferView::byteOffsetConcurrently has a race when using PAC
https://bugs.webkit.org/show_bug.cgi?id=227765

Reviewed by Mark Lam.

We were calling JSArrayBufferView::vector(), which does PAC validation
using the length() of the array. However, this can race with JSArrayBufferView::detach,
which sets the length to zero, leading to sadness on the compiler thread.

* runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::vectorWithoutPACValidation const):
* runtime/JSArrayBufferViewInlines.h:
(JSC::JSArrayBufferView::byteOffsetImpl):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArrayBufferView.h
trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279706 => 279707)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-08 02:19:19 UTC (rev 279706)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-08 02:20:51 UTC (rev 279707)
@@ -1,3 +1,19 @@
+2021-07-07  Saam Barati  
+
+JSArrayBufferView::byteOffsetConcurrently has a race when using PAC
+https://bugs.webkit.org/show_bug.cgi?id=227765
+
+Reviewed by Mark Lam.
+
+We were calling JSArrayBufferView::vector(), which does PAC validation
+using the length() of the array. However, this can race with JSArrayBufferView::detach,
+which sets the length to zero, leading to sadness on the compiler thread.
+
+* runtime/JSArrayBufferView.h:
+(JSC::JSArrayBufferView::vectorWithoutPACValidation const):
+* runtime/JSArrayBufferViewInlines.h:
+(JSC::JSArrayBufferView::byteOffsetImpl):
+
 2021-07-07  Yusuke Suzuki  
 
 [JSC] Fix Object.assign fast path to accept undefined/null


Modified: trunk/Source/_javascript_Core/runtime/JSArrayBufferView.h (279706 => 279707)

--- trunk/Source/_javascript_Core/runtime/JSArrayBufferView.h	2021-07-08 02:19:19 UTC (rev 279706)
+++ trunk/Source/_javascript_Core/runtime/JSArrayBufferView.h	2021-07-08 02:20:51 UTC (rev 279707)
@@ -188,6 +188,7 @@
 
 bool hasVector() const { return !!m_vector; }
 void* vector() const { return m_vector.getMayBeNull(length()); }
+void* vectorWithoutPACValidation() const { return m_vector.getUnsafe(); }
 
 inline unsigned byteOffset();
 inline std::optional byteOffsetConcurrently();


Modified: trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h (279706 => 279707)

--- trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h	2021-07-08 02:19:19 UTC (rev 279706)
+++ trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h	2021-07-08 02:20:51 UTC (rev 279707)
@@ -97,7 +97,7 @@
 }
 
 ptrdiff_t delta =
-bitwise_cast(vector()) - static_cast(buffer->data());
+bitwise_cast(vectorWithoutPACValidation()) - static_cast(buffer->data());
 
 unsigned result = static_cast(delta);
 if (requester == Mutator)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279706] trunk

2021-07-07 Thread cdumez

Title: [279706] trunk








Revision 279706
Author cdu...@apple.com
Date 2021-07-07 19:19:19 -0700 (Wed, 07 Jul 2021)


Log Message
Our structured cloning implementation does not encode all of RegExp's flags
https://bugs.webkit.org/show_bug.cgi?id=227779

Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

Rebaseline WPT test.

* web-platform-tests/IndexedDB/structured-clone.any-expected.txt:

Source/WebCore:

Our structured cloning implementation does not encode all of RegExp's flags.
In particular, we are failing to encode the 'y', 'u', 's' and 'd' flags.

This is causing one of the checks to fail in WebKit on:
- http://wpt.live/IndexedDB/structured-clone.any.html?61-80

That subtest is passing in Firefox and Chrome.

Test: fast/dom/Window/post-message-regexp.html

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests:

Add layout test coverage.

* fast/dom/Window/post-message-regexp-expected.txt: Added.
* fast/dom/Window/post-message-regexp.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/messagechannel.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/window-postmessage.window-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/structured-clone/dedicated-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp


Added Paths

trunk/LayoutTests/fast/dom/Window/post-message-regexp-expected.txt
trunk/LayoutTests/fast/dom/Window/post-message-regexp.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279705 => 279706)

--- trunk/LayoutTests/ChangeLog	2021-07-08 01:46:07 UTC (rev 279705)
+++ trunk/LayoutTests/ChangeLog	2021-07-08 02:19:19 UTC (rev 279706)
@@ -1,3 +1,15 @@
+2021-07-07  Chris Dumez  
+
+Our structured cloning implementation does not encode all of RegExp's flags
+https://bugs.webkit.org/show_bug.cgi?id=227779
+
+Reviewed by Yusuke Suzuki.
+
+Add layout test coverage.
+
+* fast/dom/Window/post-message-regexp-expected.txt: Added.
+* fast/dom/Window/post-message-regexp.html: Added.
+
 2021-07-07  Alex Christensen  
 
 Only first set-cookie HTTP header in websocket http response is accepted


Added: trunk/LayoutTests/fast/dom/Window/post-message-regexp-expected.txt (0 => 279706)

--- trunk/LayoutTests/fast/dom/Window/post-message-regexp-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/Window/post-message-regexp-expected.txt	2021-07-08 02:19:19 UTC (rev 279706)
@@ -0,0 +1,24 @@
+Tests that our structured clone algorithm properly encodes all JS RegExp flags.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS event.data.toString() is "/(?:)/"
+PASS event.data.toString() is "/abc/"
+PASS event.data.toString() is "/abc/g"
+PASS event.data.toString() is "/abc/i"
+PASS event.data.toString() is "/abc/gi"
+PASS event.data.toString() is "/abc/m"
+PASS event.data.toString() is "/abc/gm"
+PASS event.data.toString() is "/abc/im"
+PASS event.data.toString() is "/abc/gim"
+PASS event.data.toString() is "/abc/s"
+PASS event.data.toString() is "/abc/u"
+PASS event.data.toString() is "/abc/y"
+PASS event.data.toString() is "/abc/d"
+PASS event.data.toString() is "/abc/gimsuy"
+PASS event.data.toString() is "/abc/dgimsuy"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/Window/post-message-regexp.html (0 => 279706)

--- trunk/LayoutTests/fast/dom/Window/post-message-regexp.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/Window/post-message-regexp.html	2021-07-08 02:19:19 UTC (rev 279706)
@@ -0,0 +1,39 @@
+
+
+
+
+description("Tests that our structured clone algorithm properly encodes all JS RegExp flags.");
+jsTestIsAsync = true;
+
+var tests = [
+  new RegExp(),
+  /abc/,
+  /abc/g,
+  /abc/i,
+  /abc/gi,
+  /abc/m,
+  /abc/mg,
+  /abc/mi,
+  /abc/mgi,
+  /abc/s,
+  /abc/u,
+  /abc/y,
+  /abc/d,
+  /abc/gimsuy,
+  /abc/gimsuyd,
+];
+
+let currentTest = 0;
+_onmessage_ = (_event) => {
+event = _event;
+shouldBeEqualToString("event.data.toString()", "" + tests[currentTest++].toString());
+if (currentTest >= tests.length)
+finishJSTest();
+};
+
+for (let test of tests)
+postMessage(test);
+
+
+


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279705 => 279706)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-08 01:46:07 UTC (rev 279705)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-08 02:19:19 UTC (rev 279706)
@@ -1,5 +1,16 @

[webkit-changes] [279705] trunk/LayoutTests

2021-07-07 Thread commit-queue

Title: [279705] trunk/LayoutTests








Revision 279705
Author commit-qu...@webkit.org
Date 2021-07-07 18:46:07 -0700 (Wed, 07 Jul 2021)


Log Message
Only first set-cookie HTTP header in websocket http response is accepted
https://bugs.webkit.org/show_bug.cgi?id=227739

Patch by Alex Christensen  on 2021-07-07
Reviewed by Geoffrey Garen.

Add a test to verify that this has been fixed.

* http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt: Added.
* http/tests/websocket/tests/hybi/multiple-set-cookies.html: Added.
* http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies.html
trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py




Diff

Modified: trunk/LayoutTests/ChangeLog (279704 => 279705)

--- trunk/LayoutTests/ChangeLog	2021-07-08 01:45:24 UTC (rev 279704)
+++ trunk/LayoutTests/ChangeLog	2021-07-08 01:46:07 UTC (rev 279705)
@@ -1,3 +1,18 @@
+2021-07-07  Alex Christensen  
+
+Only first set-cookie HTTP header in websocket http response is accepted
+https://bugs.webkit.org/show_bug.cgi?id=227739
+
+Reviewed by Geoffrey Garen.
+
+Add a test to verify that this has been fixed.
+
+* http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt: Added.
+* http/tests/websocket/tests/hybi/multiple-set-cookies.html: Added.
+* http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py: Added.
+(web_socket_do_extra_handshake):
+(web_socket_transfer_data):
+
 2021-07-07  Alan Bujtas  
 
 [LFC][IFC] Add support for partially trimmed trailing whitespace


Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt (0 => 279705)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt	2021-07-08 01:46:07 UTC (rev 279705)
@@ -0,0 +1,2 @@
+ALERT: a=b,c=d
+


Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies.html (0 => 279705)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies.html	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies.html	2021-07-08 01:46:07 UTC (rev 279705)
@@ -0,0 +1,27 @@
+
+
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+function runTest()
+{
+var ws = new WebSocket("ws://127.0.0.1:8880/websocket/tests/hybi/multiple_set_cookie");
+ws._onopen_ = function() {
+alert(document.cookie);
+if (window.testRunner) {
+testRunner.notifyDone();
+}
+}
+ws._onerror_ = function(error) {
+alert('error: ' + error);
+}
+}
+
+
+
+
+


Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py (0 => 279705)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py	2021-07-08 01:46:07 UTC (rev 279705)
@@ -0,0 +1,33 @@
+#
+# Copyright (C) 2021 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+#notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+#notice, this list of conditions and the following disclaimer in the
+#documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+# THE POSSIBILITY OF SUCH DAMAGE.
+#
+
+
+def web_socket_do_extra_handshake(request):
+request.extra_headers.append(('Set-Cookie', 'a=b'))
+request.extra_headers.append(('Set-Cookie', 'c=d'))
+
+
+def web_socket_transfer_data(request):
+pass

[webkit-changes] [279704] branches/safari-612.1.22.0-branch/Source

2021-07-07 Thread kocsen_chung

Title: [279704] branches/safari-612.1.22.0-branch/Source








Revision 279704
Author kocsen_ch...@apple.com
Date 2021-07-07 18:45:24 -0700 (Wed, 07 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.22.0.3

Modified Paths

branches/safari-612.1.22.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.22.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.22.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.22.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.22.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.22.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.22.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.22.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.22.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279703 => 279704)

--- branches/safari-612.1.22.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
+++ branches/safari-612.1.22.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:45:24 UTC (rev 279704)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279703 => 279704)

--- branches/safari-612.1.22.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
+++ branches/safari-612.1.22.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:45:24 UTC (rev 279704)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279703 => 279704)

--- branches/safari-612.1.22.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
+++ branches/safari-612.1.22.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:45:24 UTC (rev 279704)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.0-branch/Source/WebCore/Configurations/Version.xcconfig (279703 => 279704)

--- branches/safari-612.1.22.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
+++ branches/safari-612.1.22.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:45:24 UTC (rev 279704)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279703 => 279704)

--- branches/safari-612.1.22.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
+++ branches/safari-612.1.22.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:45:24 UTC (rev 279704)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279703 => 279704)

--- branches/safari-612.1.22.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
+++ branches/safari-612.1.22.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:45:24 UTC (rev 279704)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).

[webkit-changes] [279703] branches/safari-612.1.22.2-branch/Source

2021-07-07 Thread kocsen_chung

Title: [279703] branches/safari-612.1.22.2-branch/Source








Revision 279703
Author kocsen_ch...@apple.com
Date 2021-07-07 18:42:51 -0700 (Wed, 07 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.22.2.3

Modified Paths

branches/safari-612.1.22.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.22.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279702 => 279703)

--- branches/safari-612.1.22.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
+++ branches/safari-612.1.22.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279702 => 279703)

--- branches/safari-612.1.22.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
+++ branches/safari-612.1.22.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279702 => 279703)

--- branches/safari-612.1.22.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
+++ branches/safari-612.1.22.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/WebCore/Configurations/Version.xcconfig (279702 => 279703)

--- branches/safari-612.1.22.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
+++ branches/safari-612.1.22.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279702 => 279703)

--- branches/safari-612.1.22.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
+++ branches/safari-612.1.22.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279702 => 279703)

--- branches/safari-612.1.22.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
+++ branches/safari-612.1.22.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:42:51 UTC (rev 279703)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).

[webkit-changes] [279702] branches/safari-612.1.22.1-branch/Source

2021-07-07 Thread kocsen_chung

Title: [279702] branches/safari-612.1.22.1-branch/Source








Revision 279702
Author kocsen_ch...@apple.com
Date 2021-07-07 18:41:12 -0700 (Wed, 07 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.22.1.3

Modified Paths

branches/safari-612.1.22.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.22.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279701 => 279702)

--- branches/safari-612.1.22.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
+++ branches/safari-612.1.22.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279701 => 279702)

--- branches/safari-612.1.22.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
+++ branches/safari-612.1.22.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279701 => 279702)

--- branches/safari-612.1.22.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
+++ branches/safari-612.1.22.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/WebCore/Configurations/Version.xcconfig (279701 => 279702)

--- branches/safari-612.1.22.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
+++ branches/safari-612.1.22.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279701 => 279702)

--- branches/safari-612.1.22.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
+++ branches/safari-612.1.22.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279701 => 279702)

--- branches/safari-612.1.22.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
+++ branches/safari-612.1.22.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:41:12 UTC (rev 279702)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).

[webkit-changes] [279701] branches/safari-612.1.22.3-branch/Source

2021-07-07 Thread kocsen_chung

Title: [279701] branches/safari-612.1.22.3-branch/Source








Revision 279701
Author kocsen_ch...@apple.com
Date 2021-07-07 18:39:19 -0700 (Wed, 07 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.22.3.3

Modified Paths

branches/safari-612.1.22.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.22.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279700 => 279701)

--- branches/safari-612.1.22.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:39:09 UTC (rev 279700)
+++ branches/safari-612.1.22.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279700 => 279701)

--- branches/safari-612.1.22.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:39:09 UTC (rev 279700)
+++ branches/safari-612.1.22.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279700 => 279701)

--- branches/safari-612.1.22.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:39:09 UTC (rev 279700)
+++ branches/safari-612.1.22.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/WebCore/Configurations/Version.xcconfig (279700 => 279701)

--- branches/safari-612.1.22.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:39:09 UTC (rev 279700)
+++ branches/safari-612.1.22.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279700 => 279701)

--- branches/safari-612.1.22.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:39:09 UTC (rev 279700)
+++ branches/safari-612.1.22.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279700 => 279701)

--- branches/safari-612.1.22.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:39:09 UTC (rev 279700)
+++ branches/safari-612.1.22.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:39:19 UTC (rev 279701)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).

[webkit-changes] [279700] tags/Safari-612.1.22.3.2/

2021-07-07 Thread kocsen_chung

Title: [279700] tags/Safari-612.1.22.3.2/








Revision 279700
Author kocsen_ch...@apple.com
Date 2021-07-07 18:39:09 -0700 (Wed, 07 Jul 2021)


Log Message
Tag Safari-612.1.22.3.2.

Added Paths

tags/Safari-612.1.22.3.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279699] branches/safari-612.1.22.3-branch/Source

2021-07-07 Thread kocsen_chung

Title: [279699] branches/safari-612.1.22.3-branch/Source








Revision 279699
Author kocsen_ch...@apple.com
Date 2021-07-07 18:38:05 -0700 (Wed, 07 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.22.3.2

Modified Paths

branches/safari-612.1.22.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.22.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.22.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279698 => 279699)

--- branches/safari-612.1.22.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:35:44 UTC (rev 279698)
+++ branches/safari-612.1.22.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:38:05 UTC (rev 279699)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279698 => 279699)

--- branches/safari-612.1.22.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:35:44 UTC (rev 279698)
+++ branches/safari-612.1.22.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:38:05 UTC (rev 279699)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279698 => 279699)

--- branches/safari-612.1.22.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:35:44 UTC (rev 279698)
+++ branches/safari-612.1.22.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:38:05 UTC (rev 279699)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/WebCore/Configurations/Version.xcconfig (279698 => 279699)

--- branches/safari-612.1.22.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:35:44 UTC (rev 279698)
+++ branches/safari-612.1.22.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:38:05 UTC (rev 279699)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279698 => 279699)

--- branches/safari-612.1.22.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:35:44 UTC (rev 279698)
+++ branches/safari-612.1.22.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:38:05 UTC (rev 279699)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279698 => 279699)

--- branches/safari-612.1.22.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:35:44 UTC (rev 279698)
+++ branches/safari-612.1.22.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:38:05 UTC (rev 279699)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).

[webkit-changes] [279698] trunk

2021-07-07 Thread zalan

Title: [279698] trunk








Revision 279698
Author za...@apple.com
Date 2021-07-07 18:35:44 -0700 (Wed, 07 Jul 2021)


Log Message
[LFC][IFC] Add support for partially trimmed trailing whitespace
https://bugs.webkit.org/show_bug.cgi?id=227688

Reviewed by Antti Koivisto.

Source/WebCore:

This patch fixes the case when as a result of the partially trimmed overflow content,
we don't need to conditionally hang the trailing end anymore.

https://drafts.csswg.org/css-text-3/#valdef-white-space-pre
"If white-space is set to pre-wrap, the UA must (unconditionally)
...
It may also visually collapse the character advance widths of any that would otherwise overflow."

* layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::visuallyCollapsePreWrapOverflowContent):
(WebCore::Layout::Line::Run::removeTrailingWhitespace):
(WebCore::Layout::Line::Run::visuallyCollapseTrailingWhitespace):
* layout/formattingContexts/inline/InlineLine.h:

LayoutTests:

* TestExpectations: Progressions.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.h




Diff

Modified: trunk/LayoutTests/ChangeLog (279697 => 279698)

--- trunk/LayoutTests/ChangeLog	2021-07-08 01:35:19 UTC (rev 279697)
+++ trunk/LayoutTests/ChangeLog	2021-07-08 01:35:44 UTC (rev 279698)
@@ -1,3 +1,12 @@
+2021-07-07  Alan Bujtas  
+
+[LFC][IFC] Add support for partially trimmed trailing whitespace
+https://bugs.webkit.org/show_bug.cgi?id=227688
+
+Reviewed by Antti Koivisto.
+
+* TestExpectations: Progressions.
+
 2021-07-07  Chris Dumez  
 
 [WebCrypto] Support Elliptic Curve P-521 on Mac


Modified: trunk/LayoutTests/TestExpectations (279697 => 279698)

--- trunk/LayoutTests/TestExpectations	2021-07-08 01:35:19 UTC (rev 279697)
+++ trunk/LayoutTests/TestExpectations	2021-07-08 01:35:44 UTC (rev 279698)
@@ -2644,7 +2644,6 @@
 webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/tab-stop-threshold-002.html [ ImageOnlyFailure ]
 webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/line-edge-white-space-collapse-001.html [ ImageOnlyFailure ]
 webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/trailing-ideographic-space-003.html [ ImageOnlyFailure ]
-webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-002.html [ ImageOnlyFailure ]
 webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-014.html [ ImageOnlyFailure ]
 webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/text-space-trim-trim-inner-001.xht [ ImageOnlyFailure ]
 webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/trailing-ideographic-space-004.html [ ImageOnlyFailure ]
@@ -4384,7 +4383,6 @@
 webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-align-start.tentative.html [ ImageOnlyFailure ]
 webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-051.html [ ImageOnlyFailure ]
 webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-052.html [ ImageOnlyFailure ]
-webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-001.html [ ImageOnlyFailure ]
 webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/word-boundary/word-boundary-001.html [ ImageOnlyFailure ]
 webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/word-boundary/word-boundary-002.html [ ImageOnlyFailure ]
 webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/word-boundary/word-boundary-003.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/ios/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt (279697 => 279698)

--- trunk/LayoutTests/platform/ios/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt	2021-07-08 01:35:19 UTC (rev 279697)
+++ trunk/LayoutTests/platform/ios/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt	2021-07-08 01:35:44 UTC (rev 279698)
@@ -21,8 +21,8 @@
   RenderBlock {HR} at (0,92) size 784x2 [border: (1px inset #00)]
   RenderBlock {HR} at (0,198) size 784x2 [border: (1px inset #00)]
   RenderBlock {PRE} at (0,213) size 108x78 [border: (4px solid #FF)]
-RenderText {#text} at (4,4) size 94x70
-  text run at (4,4) width 86: "This   text "
+RenderText {#text} at (4,4) size 100x70
+  text run at (4,4) width 100: "This   text "
   text run at (4,18) width 71: "will wrap"
   text run at (74,18) width 1: " "
   text run at (4,32) width 94: "and   f

[webkit-changes] [279697] tags/Safari-612.1.22.1.2/

2021-07-07 Thread kocsen_chung

Title: [279697] tags/Safari-612.1.22.1.2/








Revision 279697
Author kocsen_ch...@apple.com
Date 2021-07-07 18:35:19 -0700 (Wed, 07 Jul 2021)


Log Message
Tag Safari-612.1.22.1.2.

Added Paths

tags/Safari-612.1.22.1.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279696] branches/safari-612.1.22.1-branch/Source

2021-07-07 Thread kocsen_chung

Title: [279696] branches/safari-612.1.22.1-branch/Source








Revision 279696
Author kocsen_ch...@apple.com
Date 2021-07-07 18:34:34 -0700 (Wed, 07 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.22.1.2

Modified Paths

branches/safari-612.1.22.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.22.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.22.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279695 => 279696)

--- branches/safari-612.1.22.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:31:15 UTC (rev 279695)
+++ branches/safari-612.1.22.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:34:34 UTC (rev 279696)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279695 => 279696)

--- branches/safari-612.1.22.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:31:15 UTC (rev 279695)
+++ branches/safari-612.1.22.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:34:34 UTC (rev 279696)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279695 => 279696)

--- branches/safari-612.1.22.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:31:15 UTC (rev 279695)
+++ branches/safari-612.1.22.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:34:34 UTC (rev 279696)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/WebCore/Configurations/Version.xcconfig (279695 => 279696)

--- branches/safari-612.1.22.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:31:15 UTC (rev 279695)
+++ branches/safari-612.1.22.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:34:34 UTC (rev 279696)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279695 => 279696)

--- branches/safari-612.1.22.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:31:15 UTC (rev 279695)
+++ branches/safari-612.1.22.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:34:34 UTC (rev 279696)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279695 => 279696)

--- branches/safari-612.1.22.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:31:15 UTC (rev 279695)
+++ branches/safari-612.1.22.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:34:34 UTC (rev 279696)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).

[webkit-changes] [279695] tags/Safari-612.1.22.2.2/

2021-07-07 Thread kocsen_chung

Title: [279695] tags/Safari-612.1.22.2.2/








Revision 279695
Author kocsen_ch...@apple.com
Date 2021-07-07 18:31:15 -0700 (Wed, 07 Jul 2021)


Log Message
Tag Safari-612.1.22.2.2.

Added Paths

tags/Safari-612.1.22.2.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279694] tags/Safari-612.1.22.2.2/

2021-07-07 Thread kocsen_chung

Title: [279694] tags/Safari-612.1.22.2.2/








Revision 279694
Author kocsen_ch...@apple.com
Date 2021-07-07 18:30:19 -0700 (Wed, 07 Jul 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-612.1.22.2.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279693] branches/safari-612.1.22.2-branch/Source

2021-07-07 Thread kocsen_chung

Title: [279693] branches/safari-612.1.22.2-branch/Source








Revision 279693
Author kocsen_ch...@apple.com
Date 2021-07-07 18:29:23 -0700 (Wed, 07 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.22.2.2

Modified Paths

branches/safari-612.1.22.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.22.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.22.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279692 => 279693)

--- branches/safari-612.1.22.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:25:03 UTC (rev 279692)
+++ branches/safari-612.1.22.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-08 01:29:23 UTC (rev 279693)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279692 => 279693)

--- branches/safari-612.1.22.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:25:03 UTC (rev 279692)
+++ branches/safari-612.1.22.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-08 01:29:23 UTC (rev 279693)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279692 => 279693)

--- branches/safari-612.1.22.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:25:03 UTC (rev 279692)
+++ branches/safari-612.1.22.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-08 01:29:23 UTC (rev 279693)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/WebCore/Configurations/Version.xcconfig (279692 => 279693)

--- branches/safari-612.1.22.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:25:03 UTC (rev 279692)
+++ branches/safari-612.1.22.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-08 01:29:23 UTC (rev 279693)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279692 => 279693)

--- branches/safari-612.1.22.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:25:03 UTC (rev 279692)
+++ branches/safari-612.1.22.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-08 01:29:23 UTC (rev 279693)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279692 => 279693)

--- branches/safari-612.1.22.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:25:03 UTC (rev 279692)
+++ branches/safari-612.1.22.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-08 01:29:23 UTC (rev 279693)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).

[webkit-changes] [279692] tags/Safari-612.1.22.2.2/

2021-07-07 Thread kocsen_chung

Title: [279692] tags/Safari-612.1.22.2.2/








Revision 279692
Author kocsen_ch...@apple.com
Date 2021-07-07 18:25:03 -0700 (Wed, 07 Jul 2021)


Log Message
Tag Safari-612.1.22.2.2.

Added Paths

tags/Safari-612.1.22.2.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279691] tags/Safari-612.1.22.0.2/

2021-07-07 Thread kocsen_chung

Title: [279691] tags/Safari-612.1.22.0.2/








Revision 279691
Author kocsen_ch...@apple.com
Date 2021-07-07 18:15:42 -0700 (Wed, 07 Jul 2021)


Log Message
Tag Safari-612.1.22.0.2.

Added Paths

tags/Safari-612.1.22.0.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279690] trunk

2021-07-07 Thread ysuzuki

Title: [279690] trunk








Revision 279690
Author ysuz...@apple.com
Date 2021-07-07 17:55:24 -0700 (Wed, 07 Jul 2021)


Log Message
[JSC] Fix Object.assign fast path to accept undefined/null
https://bugs.webkit.org/show_bug.cgi?id=227769
rdar://80264271

Reviewed by Saam Barati.

JSTests:

* stress/object-assign-undefined.js: Added.
(test):

Source/_javascript_Core:

Object.assign can accept undefined or null as a second (or latter) parameters.
If it is passed, the parameter is just ignored. Previous DFG / FTL optimization patch
does not handle this case.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectAssign):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileObjectAssign):
* runtime/ObjectConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* runtime/ObjectConstructorInlines.h:
(JSC::objectAssignFast):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/runtime/ObjectConstructor.cpp
trunk/Source/_javascript_Core/runtime/ObjectConstructorInlines.h


Added Paths

trunk/JSTests/stress/object-assign-undefined.js




Diff

Modified: trunk/JSTests/ChangeLog (279689 => 279690)

--- trunk/JSTests/ChangeLog	2021-07-08 00:53:54 UTC (rev 279689)
+++ trunk/JSTests/ChangeLog	2021-07-08 00:55:24 UTC (rev 279690)
@@ -1,3 +1,14 @@
+2021-07-07  Yusuke Suzuki  
+
+[JSC] Fix Object.assign fast path to accept undefined/null
+https://bugs.webkit.org/show_bug.cgi?id=227769
+rdar://80264271
+
+Reviewed by Saam Barati.
+
+* stress/object-assign-undefined.js: Added.
+(test):
+
 2021-07-06  Commit Queue  
 
 Unreviewed, reverting r279546, r279554, r279558 and r279567.


Added: trunk/JSTests/stress/object-assign-undefined.js (0 => 279690)

--- trunk/JSTests/stress/object-assign-undefined.js	(rev 0)
+++ trunk/JSTests/stress/object-assign-undefined.js	2021-07-08 00:55:24 UTC (rev 279690)
@@ -0,0 +1,14 @@
+function test(target, source)
+{
+Object.assign(target, source);
+}
+noInline(test);
+
+test({}, undefined);
+test({}, null);
+for (var i = 0; i < 1e4; ++i)
+test({}, {});
+test({}, undefined);
+test({}, null);
+for (var i = 0; i < 1e4; ++i)
+test({}, undefined);


Modified: trunk/Source/_javascript_Core/ChangeLog (279689 => 279690)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-08 00:53:54 UTC (rev 279689)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-08 00:55:24 UTC (rev 279690)
@@ -1,3 +1,31 @@
+2021-07-07  Yusuke Suzuki  
+
+[JSC] Fix Object.assign fast path to accept undefined/null
+https://bugs.webkit.org/show_bug.cgi?id=227769
+rdar://80264271
+
+Reviewed by Saam Barati.
+
+Object.assign can accept undefined or null as a second (or latter) parameters.
+If it is passed, the parameter is just ignored. Previous DFG / FTL optimization patch
+does not handle this case.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::fixupNode):
+* dfg/DFGOperations.cpp:
+(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileObjectAssign):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileObjectAssign):
+* runtime/ObjectConstructor.cpp:
+(JSC::JSC_DEFINE_HOST_FUNCTION):
+* runtime/ObjectConstructorInlines.h:
+(JSC::objectAssignFast):
+
 2021-07-07  Mark Lam  
 
 Heap::waitForCollector() needs to set m_mutatorDidRun.


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (279689 => 279690)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2021-07-08 00:53:54 UTC (rev 279689)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2021-07-08 00:55:24 UTC (rev 279690)
@@ -2943,10 +2943,7 @@
 Node* target = addToGraph(ToObject, OpInfo(errorStringIndex), OpInfo(SpecNone), get(virtualRegisterForArgumentIncludingThis(1, registerOffset)));
 m_exitOK = true;
 addToGraph(ExitOK);
-Node* source = addToGraph(ToObject, OpInfo(errorStringIndex), OpInfo(SpecNone), get(virtualRegisterForArgumentIncludingThis(2, registerOffset)));
-m_exitOK = true;
-addToGraph(ExitOK);
-addTo

[webkit-changes] [279689] trunk/Source/JavaScriptCore

2021-07-07 Thread mark . lam

Title: [279689] trunk/Source/_javascript_Core








Revision 279689
Author mark@apple.com
Date 2021-07-07 17:53:54 -0700 (Wed, 07 Jul 2021)


Log Message
Heap::waitForCollector() needs to set m_mutatorDidRun.
https://bugs.webkit.org/show_bug.cgi?id=227782
rdar://78326474

Reviewed by Saam Barati.

Heap::waitForCollector() is one of 2 clients of Heap::stopIfNecessarySlow(unsigned oldState).
The other client, Heap::stopIfNecessarySlow() sets m_mutatorDidRun to true after
calling Heap::stopIfNecessarySlow(unsigned oldState).  Heap::waitForCollector()
needs to do the same.  Constraint solvers rely on this.

Without this, one fall out we've seen is that DOMGCOutputConstraint fails to
visitOutputConstraints, and as a result, opaqueRoots may not get updated.  This
issue was caught by the GC verifier.

* heap/Heap.cpp:
(JSC::Heap::waitForCollector):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279688 => 279689)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-08 00:25:46 UTC (rev 279688)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-08 00:53:54 UTC (rev 279689)
@@ -1,3 +1,23 @@
+2021-07-07  Mark Lam  
+
+Heap::waitForCollector() needs to set m_mutatorDidRun.
+https://bugs.webkit.org/show_bug.cgi?id=227782
+rdar://78326474
+
+Reviewed by Saam Barati.
+
+Heap::waitForCollector() is one of 2 clients of Heap::stopIfNecessarySlow(unsigned oldState).
+The other client, Heap::stopIfNecessarySlow() sets m_mutatorDidRun to true after
+calling Heap::stopIfNecessarySlow(unsigned oldState).  Heap::waitForCollector()
+needs to do the same.  Constraint solvers rely on this.
+
+Without this, one fall out we've seen is that DOMGCOutputConstraint fails to
+visitOutputConstraints, and as a result, opaqueRoots may not get updated.  This
+issue was caught by the GC verifier.
+
+* heap/Heap.cpp:
+(JSC::Heap::waitForCollector):
+
 2021-07-07  Michael Saboff  
 
 fitcored crashes at _javascript_Core: JSC::Heap::releaseAccessSlow


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (279688 => 279689)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2021-07-08 00:25:46 UTC (rev 279688)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	2021-07-08 00:53:54 UTC (rev 279689)
@@ -1882,10 +1882,11 @@
 if (stopIfNecessarySlow(oldState))
 continue;
 
+m_mutatorDidRun = true;
 // FIXME: We wouldn't need this if stopIfNecessarySlow() had a mode where it knew to just
 // do the collection.
 relinquishConn();
-
+
 if (done) {
 clearMutatorWaiting(); // Clean up just in case.
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279687] trunk/Tools

2021-07-07 Thread wilander

Title: [279687] trunk/Tools








Revision 279687
Author wilan...@apple.com
Date 2021-07-07 17:09:12 -0700 (Wed, 07 Jul 2021)


Log Message
PCM: API test PrivateClickMeasurement.ValidBlindedSecret is failing on platforms with RSABSSA
https://bugs.webkit.org/show_bug.cgi?id=22


Reviewed by Kate Cheney.

* TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm:
(TestWebKitAPI::TEST):
   The test was looking for the value of JSON key "source_secret_token"
   which should be "source_unlinkable_token". This patch fixes that and
   renames the local variable accordingly.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm




Diff

Modified: trunk/Tools/ChangeLog (279686 => 279687)

--- trunk/Tools/ChangeLog	2021-07-07 23:57:58 UTC (rev 279686)
+++ trunk/Tools/ChangeLog	2021-07-08 00:09:12 UTC (rev 279687)
@@ -1,3 +1,17 @@
+2021-07-07  John Wilander  
+
+PCM: API test PrivateClickMeasurement.ValidBlindedSecret is failing on platforms with RSABSSA
+https://bugs.webkit.org/show_bug.cgi?id=22
+
+
+Reviewed by Kate Cheney.
+
+* TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm:
+(TestWebKitAPI::TEST):
+   The test was looking for the value of JSON key "source_secret_token"
+   which should be "source_unlinkable_token". This patch fixes that and
+   renames the local variable accordingly.
+
 2021-07-07  Ling Ho  
 
 Remove proxy server setting from Buildbot configuration


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm (279686 => 279687)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm	2021-07-07 23:57:58 UTC (rev 279686)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm	2021-07-08 00:09:12 UTC (rev 279687)
@@ -77,15 +77,15 @@
 
 // Continue the test.
 EXPECT_TRUE(pcm.calculateAndUpdateSourceUnlinkableToken(base64URLEncodeToString(nsSpkiData.bytes, nsSpkiData.length)));
-auto sourceSecretToken = pcm.tokenSignatureJSON();
-EXPECT_EQ(sourceSecretToken->asObject()->size(), 4ul);
-EXPECT_STREQ(sourceSecretToken->getString("source_engagement_type"_s).utf8().data(), "click");
-EXPECT_STREQ(sourceSecretToken->getString("source_nonce"_s).utf8().data(), "ABCDEFabcdef0123456789");
-EXPECT_FALSE(sourceSecretToken->getString("source_secret_token"_s).isEmpty());
-EXPECT_EQ(sourceSecretToken->getInteger("version"_s), 2);
+auto sourceUnlinkableToken = pcm.tokenSignatureJSON();
+EXPECT_EQ(sourceUnlinkableToken->asObject()->size(), 4ul);
+EXPECT_STREQ(sourceUnlinkableToken->getString("source_engagement_type"_s).utf8().data(), "click");
+EXPECT_STREQ(sourceUnlinkableToken->getString("source_nonce"_s).utf8().data(), "ABCDEFabcdef0123456789");
+EXPECT_FALSE(sourceUnlinkableToken->getString("source_unlinkable_token"_s).isEmpty());
+EXPECT_EQ(sourceUnlinkableToken->getInteger("version"_s), 2);
 
 // Generate the signature.
-auto blindedMessage = base64URLDecode(sourceSecretToken->getString("source_secret_token"_s));
+auto blindedMessage = base64URLDecode(sourceUnlinkableToken->getString("source_unlinkable_token"_s));
 
 auto blindedSignature = adoptNS([[NSMutableData alloc] initWithLength:modulusNBytes]);
 ccrsabssa_sign_blinded_message(ciphersuite, rsaPrivateKey, blindedMessage->data(), blindedMessage->size(), static_cast([blindedSignature mutableBytes]), [blindedSignature length], rng);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279686] trunk

2021-07-07 Thread cdumez

Title: [279686] trunk








Revision 279686
Author cdu...@apple.com
Date 2021-07-07 16:57:58 -0700 (Wed, 07 Jul 2021)


Log Message
[IndexedDB] Transaction should be inactive during structured clone
https://bugs.webkit.org/show_bug.cgi?id=227773

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

* web-platform-tests/IndexedDB/structured-clone-transaction-state.any-expected.txt:
* web-platform-tests/IndexedDB/structured-clone-transaction-state.any.worker-expected.txt:

Source/WebCore:

Transaction should be inactive during structured clone, as per:
- https://w3c.github.io/IndexedDB/#clone

Gecko and Blink match the specification.

No new tests, rebaselined existing tests.

* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::putOrAdd):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279685 => 279686)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 23:45:57 UTC (rev 279685)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 23:57:58 UTC (rev 279686)
@@ -1,5 +1,17 @@
 2021-07-07  Chris Dumez  
 
+[IndexedDB] Transaction should be inactive during structured clone
+https://bugs.webkit.org/show_bug.cgi?id=227773
+
+Reviewed by Geoffrey Garen.
+
+Rebaseline WPT tests now that more checks are passing.
+
+* web-platform-tests/IndexedDB/structured-clone-transaction-state.any-expected.txt:
+* web-platform-tests/IndexedDB/structured-clone-transaction-state.any.worker-expected.txt:
+
+2021-07-07  Chris Dumez  
+
 IDBObjectStore.keyPath should keep returning the same object
 https://bugs.webkit.org/show_bug.cgi?id=227770
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any-expected.txt (279685 => 279686)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any-expected.txt	2021-07-07 23:45:57 UTC (rev 279685)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any-expected.txt	2021-07-07 23:57:58 UTC (rev 279686)
@@ -1,11 +1,5 @@
 
-FAIL Transaction inactive during structured clone in IDBObjectStore.add() assert_throws_dom: transaction should not be active during structured clone function "() => {
-objectStore.get('key');
-  }" did not throw
-FAIL Transaction inactive during structured clone in IDBObjectStore.put() assert_throws_dom: transaction should not be active during structured clone function "() => {
-objectStore.get('key');
-  }" did not throw
-FAIL Transaction inactive during structured clone in IDBCursor.update() assert_throws_dom: transaction should not be active during structured clone function "() => {
-objectStore.get('key');
-  }" did not throw
+PASS Transaction inactive during structured clone in IDBObjectStore.add()
+PASS Transaction inactive during structured clone in IDBObjectStore.put()
+PASS Transaction inactive during structured clone in IDBCursor.update()
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any.worker-expected.txt (279685 => 279686)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any.worker-expected.txt	2021-07-07 23:45:57 UTC (rev 279685)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any.worker-expected.txt	2021-07-07 23:57:58 UTC (rev 279686)
@@ -1,11 +1,5 @@
 
-FAIL Transaction inactive during structured clone in IDBObjectStore.add() assert_throws_dom: transaction should not be active during structured clone function "() => {
-objectStore.get('key');
-  }" did not throw
-FAIL Transaction inactive during structured clone in IDBObjectStore.put() assert_throws_dom: transaction should not be active during structured clone function "() => {
-objectStore.get('key');
-  }" did not throw
-FAIL Transaction inactive during structured clone in IDBCursor.update() assert_throws_dom: transaction should not be active during structured clone function "() => {
-objectStore.get('key');
-  }" did not throw
+PASS Transaction inactive during structured clone in IDBObjectStore.add()
+PASS Transaction inactive during structured clone in IDBObjectStore.put()
+PASS Transaction inactive during structured clone in IDBCursor.update()
 


Modified: trunk/Source/WebCore/ChangeLog (279685 => 279686)

--- trunk/Source/WebCore/ChangeLog	2021-07-07 23:45:57 UTC (rev 279685)
+++ trunk/Source/WebC

[webkit-changes] [279685] trunk/Source/WebCore

2021-07-07 Thread heycam

Title: [279685] trunk/Source/WebCore








Revision 279685
Author hey...@apple.com
Date 2021-07-07 16:45:57 -0700 (Wed, 07 Jul 2021)


Log Message
Remove unused LayerChange::TilesAdded enum value
https://bugs.webkit.org/show_bug.cgi?id=227736

Reviewed by Simon Fraser.

* platform/graphics/ca/GraphicsLayerCA.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (279684 => 279685)

--- trunk/Source/WebCore/ChangeLog	2021-07-07 23:11:46 UTC (rev 279684)
+++ trunk/Source/WebCore/ChangeLog	2021-07-07 23:45:57 UTC (rev 279685)
@@ -1,3 +1,12 @@
+2021-07-07  Cameron McCormack  
+
+Remove unused LayerChange::TilesAdded enum value
+https://bugs.webkit.org/show_bug.cgi?id=227736
+
+Reviewed by Simon Fraser.
+
+* platform/graphics/ca/GraphicsLayerCA.h:
+
 2021-07-07  Chris Dumez  
 
 IDBObjectStore.keyPath should keep returning the same object


Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h (279684 => 279685)

--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h	2021-07-07 23:11:46 UTC (rev 279684)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h	2021-07-07 23:45:57 UTC (rev 279685)
@@ -560,23 +560,22 @@
 BackdropFiltersChanged  = 1LLU << 29,
 BackdropFiltersRectChanged  = 1LLU << 30,
 TilingAreaChanged   = 1LLU << 31,
-TilesAdded  = 1LLU << 32,
-DebugIndicatorsChanged  = 1LLU << 33,
-CustomAppearanceChanged = 1LLU << 34,
-BlendModeChanged= 1LLU << 35,
-ShapeChanged= 1LLU << 36,
-WindRuleChanged = 1LLU << 37,
-UserInteractionEnabledChanged   = 1LLU << 38,
-NeedsComputeVisibleAndCoverageRect  = 1LLU << 39,
-EventRegionChanged  = 1LLU << 40,
+DebugIndicatorsChanged  = 1LLU << 32,
+CustomAppearanceChanged = 1LLU << 33,
+BlendModeChanged= 1LLU << 34,
+ShapeChanged= 1LLU << 35,
+WindRuleChanged = 1LLU << 36,
+UserInteractionEnabledChanged   = 1LLU << 37,
+NeedsComputeVisibleAndCoverageRect  = 1LLU << 38,
+EventRegionChanged  = 1LLU << 39,
 #if ENABLE(SCROLLING_THREAD)
-ScrollingNodeChanged= 1LLU << 41,
+ScrollingNodeChanged= 1LLU << 40,
 #endif
 #if HAVE(CORE_ANIMATION_SEPARATED_LAYERS)
-SeparatedChanged= 1LLU << 42,
+SeparatedChanged= 1LLU << 41,
 #if HAVE(CORE_ANIMATION_SEPARATED_PORTALS)
-SeparatedPortalChanged  = 1LLU << 43,
-DescendentOfSeparatedPortalChanged  = 1LLU << 44,
+SeparatedPortalChanged  = 1LLU << 42,
+DescendentOfSeparatedPortalChanged  = 1LLU << 43,
 #endif
 #endif
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279684] trunk/LayoutTests

2021-07-07 Thread tsavell

Title: [279684] trunk/LayoutTests








Revision 279684
Author tsav...@apple.com
Date 2021-07-07 16:11:46 -0700 (Wed, 07 Jul 2021)


Log Message
[BigSur Release wk2 arm64 ] scrollbars/corner-resizer-window-inactive.html is a flaky image-only failure.
https://bugs.webkit.org/show_bug.cgi?id=227776

Unreviewed test gardening.

Patch by Eric Hutchison  on 2021-07-07

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279683 => 279684)

--- trunk/LayoutTests/ChangeLog	2021-07-07 23:00:36 UTC (rev 279683)
+++ trunk/LayoutTests/ChangeLog	2021-07-07 23:11:46 UTC (rev 279684)
@@ -1,3 +1,12 @@
+2021-07-07  Eric Hutchison  
+
+[BigSur Release wk2 arm64 ] scrollbars/corner-resizer-window-inactive.html is a flaky image-only failure.
+https://bugs.webkit.org/show_bug.cgi?id=227776
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-07-07  Yoshiaki Jitsukawa  
 
 [OpenSSL] Implement CryptoAlgorithmEC*


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (279683 => 279684)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-07 23:00:36 UTC (rev 279683)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-07 23:11:46 UTC (rev 279684)
@@ -1383,3 +1383,8 @@
 webkit.org/b/226054 [ BigSur Release ] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-encode-same-track-twice.https.html [ Pass Failure ]
 
 webkit.org/b/224085 fullscreen/full-screen-remove-ancestor.html [ Skip ]
+
+webkit.org/b/227776 [ BigSur Release arm64 ] scrollbars/corner-resizer-window-inactive.html [ Pass ImageOnlyFailure ]
+
+webkit.org/b/227776 [ Catalina Release ] scrollbars/corner-resizer-window-inactive.html [ Pass ImageOnlyFailure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279683] trunk

2021-07-07 Thread cdumez

Title: [279683] trunk








Revision 279683
Author cdu...@apple.com
Date 2021-07-07 16:00:36 -0700 (Wed, 07 Jul 2021)


Log Message
IDBObjectStore.keyPath should keep returning the same object
https://bugs.webkit.org/show_bug.cgi?id=227770

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

* web-platform-tests/IndexedDB/idbobjectstore_keyPath.any-expected.txt:
* web-platform-tests/IndexedDB/idbobjectstore_keyPath.any.worker-expected.txt:

Source/WebCore:

IDBObjectStore.keyPath should keep returning the same object to match other
browser engines (Gecko and Blink).

No new tests, rebaselined existing tests.

* Modules/indexeddb/IDBObjectStore.idl:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_keyPath.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_keyPath.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279682 => 279683)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 22:52:36 UTC (rev 279682)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 23:00:36 UTC (rev 279683)
@@ -1,3 +1,15 @@
+2021-07-07  Chris Dumez  
+
+IDBObjectStore.keyPath should keep returning the same object
+https://bugs.webkit.org/show_bug.cgi?id=227770
+
+Reviewed by Darin Adler.
+
+Rebaseline WPT tests that are now passing.
+
+* web-platform-tests/IndexedDB/idbobjectstore_keyPath.any-expected.txt:
+* web-platform-tests/IndexedDB/idbobjectstore_keyPath.any.worker-expected.txt:
+
 2021-07-07  Alex Christensen  
 
 DOMURL's href setter should use empty URL as base URL


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_keyPath.any-expected.txt (279682 => 279683)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_keyPath.any-expected.txt	2021-07-07 22:52:36 UTC (rev 279682)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_keyPath.any-expected.txt	2021-07-07 23:00:36 UTC (rev 279683)
@@ -1,3 +1,3 @@
 
-FAIL IDBObjectStore's keyPath attribute returns the same object. assert_equals: Same object instance is returned each time keyPath is inspected expected ["a", "b"] but got ["a", "b"]
+PASS IDBObjectStore's keyPath attribute returns the same object.
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_keyPath.any.worker-expected.txt (279682 => 279683)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_keyPath.any.worker-expected.txt	2021-07-07 22:52:36 UTC (rev 279682)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_keyPath.any.worker-expected.txt	2021-07-07 23:00:36 UTC (rev 279683)
@@ -1,3 +1,3 @@
 
-FAIL IDBObjectStore's keyPath attribute returns the same object. assert_equals: Same object instance is returned each time keyPath is inspected expected ["a", "b"] but got ["a", "b"]
+PASS IDBObjectStore's keyPath attribute returns the same object.
 


Modified: trunk/Source/WebCore/ChangeLog (279682 => 279683)

--- trunk/Source/WebCore/ChangeLog	2021-07-07 22:52:36 UTC (rev 279682)
+++ trunk/Source/WebCore/ChangeLog	2021-07-07 23:00:36 UTC (rev 279683)
@@ -1,3 +1,17 @@
+2021-07-07  Chris Dumez  
+
+IDBObjectStore.keyPath should keep returning the same object
+https://bugs.webkit.org/show_bug.cgi?id=227770
+
+Reviewed by Darin Adler.
+
+IDBObjectStore.keyPath should keep returning the same object to match other
+browser engines (Gecko and Blink).
+
+No new tests, rebaselined existing tests.
+
+* Modules/indexeddb/IDBObjectStore.idl:
+
 2021-07-07  Yoshiaki Jitsukawa  
 
 [OpenSSL] Implement CryptoAlgorithmEC*


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl (279682 => 279683)

--- trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl	2021-07-07 22:52:36 UTC (rev 279682)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl	2021-07-07 23:00:36 UTC (rev 279683)
@@ -35,7 +35,7 @@
 Exposed=(Window,Worker)
 ] interface IDBObjectStore {
 attribute DOMString name;
-readonly attribute IDBKeyPath? keyPath;
+[SameObject, CachedAttribute] readonly attribute IDBKeyPath? keyPath;
 readonly attribute DOMStringList indexNames;
 [SameObject] readonly attribute IDBTransaction transaction;
 readonly attribute boolean autoIncrement;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279682] trunk

2021-07-07 Thread yoshiaki . jitsukawa

Title: [279682] trunk








Revision 279682
Author yoshiaki.jitsuk...@sony.com
Date 2021-07-07 15:52:36 -0700 (Wed, 07 Jul 2021)


Log Message
[OpenSSL] Implement CryptoAlgorithmEC*
https://bugs.webkit.org/show_bug.cgi?id=227655

Reviewed by Don Olmstead.

Source/WebCore:

Implement elliptic curve support in WebCrypto. This patch enables ECDH
and ECDSA algorithms as well as EC key import, export, and generation.

Note that low level ASN1 API is used in CryptoKeyEC.cpp to import
public EC keys in the SPKI format because currently OpenSSL doesn't
have the Object ID of the ecDH algorithm and it fails to load ecDH
keys with d2iPUBKEY().

* crypto/keys/CryptoKeyEC.h:
* crypto/openssl/CryptoAlgorithmECDHOpenSSL.cpp:
(WebCore::CryptoAlgorithmECDH::platformDeriveBits):
* crypto/openssl/CryptoAlgorithmECDSAOpenSSL.cpp:
(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):
* crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* crypto/openssl/CryptoKeyECOpenSSL.cpp:
(WebCore::curveIdentifier):
(WebCore::curveSize):
(WebCore::createECKey):
(WebCore::verifyCurve):
(WebCore::CryptoKeyEC::keySizeInBits const):
(WebCore::CryptoKeyEC::platformSupportedCurve):
(WebCore::CryptoKeyEC::platformGeneratePair):
(WebCore::CryptoKeyEC::platformImportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPublic):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::ecPublicKeyIdentifier):
(WebCore::ecDHIdentifier):
(WebCore::supportedAlgorithmIdentifier):
(WebCore::CryptoKeyEC::platformImportSpki):
(WebCore::CryptoKeyEC::platformImportPkcs8):
(WebCore::CryptoKeyEC::platformExportRaw const):
(WebCore::CryptoKeyEC::platformAddFieldElements const):
(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):
* crypto/openssl/CryptoKeyRSAOpenSSL.cpp:
(WebCore::CryptoKeyRSA::importSpki):
(WebCore::CryptoKeyRSA::importPkcs8):
(WebCore::CryptoKeyRSA::exportSpki const):
(WebCore::CryptoKeyRSA::exportPkcs8 const):
(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::exportData const):
* crypto/openssl/OpenSSLCryptoUniquePtr.h:
(WebCore::OpenSSLCryptoPtrDeleter::operator() const):
(WebCore::OpenSSLCryptoPtrDeleter::operator() const):
(WebCore::OpenSSLCryptoPtrDeleter::operator() const):
(WebCore::OpenSSLCryptoPtrDeleter::operator() const):
* crypto/openssl/OpenSSLUtilities.cpp:
(WebCore::convertToBytes):
(WebCore::convertToBytesExpand):
(WebCore::convertToBigNumber):
* crypto/openssl/OpenSSLUtilities.h:

LayoutTests:

Update test expectations of wincairo to enable ec* tests.

* platform/wincairo/TestExpectations:

Add expected results thats support the P-521 elliptic curve. Generic test
results expect that P-521 is unsupported.

* platform/wincairo/crypto/subtle/ec-generate-key-malformed-parameters-expected.txt: Added.
* platform/wincairo/crypto/subtle/ecdh-derive-bits-length-limits-expected.txt: Added.
* platform/wincairo/crypto/subtle/ecdh-import-spki-key-ecdh-identifier-expected.txt: Added.

Use shouldRejectWithErrorName after r260579.

* crypto/subtle/ecdh-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey.html:
* crypto/subtle/ecdsa-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey.html
trunk/LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey.html
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/crypto/keys/CryptoKeyEC.h
trunk/Source/WebCore/crypto/openssl/CryptoAlgorithmECDHOpenSSL.cpp
trunk/Source/WebCore/crypto/openssl/CryptoAlgorithmECDSAOpenSSL.cpp
trunk/Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp
trunk/Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp
trunk/Source/WebCore/crypto/openssl/CryptoKeyRSAOpenSSL.cpp
trunk/Source/WebCore/crypto/openssl/OpenSSLCryptoUniquePtr.h
trunk/Source/WebCore/crypto/openssl/OpenSSLUtilities.cpp
trunk/Source/WebCore/crypto/openssl/OpenSSLUtilities.h


Added Paths

trunk/LayoutTests/platform/wincairo/crypto/subtle/ec-generate-key-malformed-parameters-expected.txt
trunk/LayoutTests/platform/wincairo/crypto/subtle/ecdh-derive-bits-length-limits-expected.txt
trunk/LayoutTests/platform/wincairo/crypto/subtle/ecdh-import-spki-key-ecdh-identifier-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (279681 => 279682)

--- trunk/LayoutTests/ChangeLog	2021-07-07 22:47:43 UTC (rev 279681)
+++ trunk/LayoutTests/ChangeLog	2021-07-07 22:52:36 UTC (rev 279682)
@@ -1,3 +1,26 @@
+2021-07-07  Yoshiaki Jitsukawa  
+
+[OpenSSL] Implement CryptoAlgorithmEC*
+https://bugs.webkit.org/show_bug.cgi?id=227655
+
+Reviewed by Don Olmstead.
+
+Update test expectations of wincairo to enable ec* tests.
+
+* platform/wincairo/

[webkit-changes] [279681] trunk

2021-07-07 Thread achristensen

Title: [279681] trunk








Revision 279681
Author achristen...@apple.com
Date 2021-07-07 15:47:43 -0700 (Wed, 07 Jul 2021)


Log Message
DOMURL's href setter should use empty URL as base URL
https://bugs.webkit.org/show_bug.cgi?id=227772

Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

* web-platform-tests/url/historical.any-expected.txt:
* web-platform-tests/url/historical.any.worker-expected.txt:

Source/WebCore:

This matches Chrome and Firefox.

* html/DOMURL.cpp:
(WebCore::DOMURL::setHref):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/historical.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/historical.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DOMURL.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279680 => 279681)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 22:45:11 UTC (rev 279680)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 22:47:43 UTC (rev 279681)
@@ -1,5 +1,15 @@
 2021-07-07  Alex Christensen  
 
+DOMURL's href setter should use empty URL as base URL
+https://bugs.webkit.org/show_bug.cgi?id=227772
+
+Reviewed by Yusuke Suzuki.
+
+* web-platform-tests/url/historical.any-expected.txt:
+* web-platform-tests/url/historical.any.worker-expected.txt:
+
+2021-07-07  Alex Christensen  
+
 URL host setter should pass host to URLParser instead of trying to encode it itself
 https://bugs.webkit.org/show_bug.cgi?id=227749
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/historical.any-expected.txt (279680 => 279681)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/historical.any-expected.txt	2021-07-07 22:45:11 UTC (rev 279680)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/historical.any-expected.txt	2021-07-07 22:47:43 UTC (rev 279681)
@@ -1,9 +1,7 @@
 
 PASS searchParams on location object
 PASS  and .searchParams should be undefined
-FAIL Setting URL's href attribute and base URLs assert_throws_js: function "function () {
-url.href = ""
-  }" did not throw
+PASS Setting URL's href attribute and base URLs
 PASS URL.domainToASCII should be undefined
 PASS URL.domainToUnicode should be undefined
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/historical.any.worker-expected.txt (279680 => 279681)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/historical.any.worker-expected.txt	2021-07-07 22:45:11 UTC (rev 279680)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/historical.any.worker-expected.txt	2021-07-07 22:47:43 UTC (rev 279681)
@@ -1,8 +1,6 @@
 
 PASS searchParams on location object
-FAIL Setting URL's href attribute and base URLs assert_throws_js: function "function () {
-url.href = ""
-  }" did not throw
+PASS Setting URL's href attribute and base URLs
 PASS URL.domainToASCII should be undefined
 PASS URL.domainToUnicode should be undefined
 


Modified: trunk/Source/WebCore/ChangeLog (279680 => 279681)

--- trunk/Source/WebCore/ChangeLog	2021-07-07 22:45:11 UTC (rev 279680)
+++ trunk/Source/WebCore/ChangeLog	2021-07-07 22:47:43 UTC (rev 279681)
@@ -1,3 +1,15 @@
+2021-07-07  Alex Christensen  
+
+DOMURL's href setter should use empty URL as base URL
+https://bugs.webkit.org/show_bug.cgi?id=227772
+
+Reviewed by Yusuke Suzuki.
+
+This matches Chrome and Firefox.
+
+* html/DOMURL.cpp:
+(WebCore::DOMURL::setHref):
+
 2021-07-07  Alan Bujtas  
 
 [LFC][IFC] Unexpected content wrap when the containing block width is fixed


Modified: trunk/Source/WebCore/html/DOMURL.cpp (279680 => 279681)

--- trunk/Source/WebCore/html/DOMURL.cpp	2021-07-07 22:45:11 UTC (rev 279680)
+++ trunk/Source/WebCore/html/DOMURL.cpp	2021-07-07 22:47:43 UTC (rev 279681)
@@ -75,7 +75,7 @@
 
 ExceptionOr DOMURL::setHref(const String& url)
 {
-URL completeURL { m_baseURL, url };
+URL completeURL { URL { }, url };
 if (!completeURL.isValid())
 return Exception { TypeError };
 m_url = WTFMove(completeURL);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279680] trunk

2021-07-07 Thread achristensen

Title: [279680] trunk








Revision 279680
Author achristen...@apple.com
Date 2021-07-07 15:45:11 -0700 (Wed, 07 Jul 2021)


Log Message
URL host setter should pass host to URLParser instead of trying to encode it itself
https://bugs.webkit.org/show_bug.cgi?id=227749

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/url/url-setters-a-area.window-expected.txt:
* web-platform-tests/url/url-setters.any-expected.txt:
* web-platform-tests/url/url-setters.any.worker-expected.txt:

Source/WTF:

For non-special schemes, the host is percent-encoded instead of punycode-encoded.
Allowing the URL parser to handle all input directly does the right thing for non-special schemes.

* wtf/URL.cpp:
(WTF::URL::setHost):
(WTF::URL::setHostAndPort):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URL.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279679 => 279680)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 22:21:50 UTC (rev 279679)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 22:45:11 UTC (rev 279680)
@@ -1,3 +1,14 @@
+2021-07-07  Alex Christensen  
+
+URL host setter should pass host to URLParser instead of trying to encode it itself
+https://bugs.webkit.org/show_bug.cgi?id=227749
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/url/url-setters-a-area.window-expected.txt:
+* web-platform-tests/url/url-setters.any-expected.txt:
+* web-platform-tests/url/url-setters.any.worker-expected.txt:
+
 2021-07-07  Chris Dumez  
 
 IDBIndex.keyPath should keep returning the same object


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt (279679 => 279680)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt	2021-07-07 22:21:50 UTC (rev 279679)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt	2021-07-07 22:45:11 UTC (rev 279680)
@@ -132,8 +132,8 @@
 PASS : Setting .host = '?'
 PASS : Setting .host = '@'
 PASS : Setting .host = '@'
-FAIL : Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://xn--zca/"
-FAIL : Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://xn--zca/"
+PASS : Setting .host = 'ß'
+PASS : Setting .host = 'ß'
 PASS : Setting .host = 'ß' IDNA Nontransitional_Processing
 PASS : Setting .host = 'ß' IDNA Nontransitional_Processing
 PASS : Setting .host = 'example.com' Cannot-be-a-base means no host


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt (279679 => 279680)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt	2021-07-07 22:21:50 UTC (rev 279679)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt	2021-07-07 22:45:11 UTC (rev 279680)
@@ -66,7 +66,7 @@
 PASS URL: Setting .host = '/'
 PASS URL: Setting .host = '?'
 PASS URL: Setting .host = '@'
-FAIL URL: Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://xn--zca/"
+PASS URL: Setting .host = 'ß'
 PASS URL: Setting .host = 'ß' IDNA Nontransitional_Processing
 PASS URL: Setting .host = 'example.com' Cannot-be-a-base means no host
 PASS URL: Setting .host = 'example.net' Cannot-be-a-base means no host


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt (279679 => 279680)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt	2021-07-07 22:21:50 UTC (rev 279679)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt	2021-07-07 22:45:11 UTC (rev 279680)
@@ -66,7 +66,7 @@
 PASS URL: Setting .host = '/'
 PASS URL: Setting .host = '?'
 PASS URL: Setting .host = '@'
-FAIL URL: Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://xn--zca/"
+PASS URL: Setting .host = 'ß'
 PASS URL: Setting .host = 'ß' IDNA Nontransitional_Processing
 PASS URL: Setting .host = 'example.com' Cannot-be-a-base means no host
 PASS URL: Setting .host = 'example.net' Cannot-be-a-base means no host


Modified: trunk/Source/WTF/ChangeLog (279679 => 279680)

--- trunk/Source/WTF/ChangeLog	2021-07-07 22:21:50 UTC (rev 279679)
+++ trunk/Source/WTF/ChangeLog	2021-07-07 22:45:11 UTC (rev 279680)
@@ -1,5 +1,19 @@
 2021-07-07  Alex Christensen  
 
+URL host setter should pass host to URLParser instead of trying to encode it itself
+https://bugs.webkit.org/show_bug.cgi?id=227749
+
+Reviewed by Chris Dumez.
+
+For non-special schemes, the host is percent-encoded instead of pu

[webkit-changes] [279679] trunk/Source/WebKit

2021-07-07 Thread cdumez

Title: [279679] trunk/Source/WebKit








Revision 279679
Author cdu...@apple.com
Date 2021-07-07 15:21:50 -0700 (Wed, 07 Jul 2021)


Log Message
Unreviewed follow-up to r279601 to address some assertions on the bots.

Because we call makeWeakPtr() on a ProcessAssertion from a background queue, we have to
make sure the ProcessAssertion's WeakPtrFactory gets initialized eagerly on the main
thread, to avoid races and assertions in debug.

* UIProcess/ProcessAssertion.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ProcessAssertion.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (279678 => 279679)

--- trunk/Source/WebKit/ChangeLog	2021-07-07 22:07:57 UTC (rev 279678)
+++ trunk/Source/WebKit/ChangeLog	2021-07-07 22:21:50 UTC (rev 279679)
@@ -1,5 +1,15 @@
 2021-07-07  Chris Dumez  
 
+Unreviewed follow-up to r279601 to address some assertions on the bots.
+
+Because we call makeWeakPtr() on a ProcessAssertion from a background queue, we have to
+make sure the ProcessAssertion's WeakPtrFactory gets initialized eagerly on the main
+thread, to avoid races and assertions in debug.
+
+* UIProcess/ProcessAssertion.h:
+
+2021-07-07  Chris Dumez  
+
 [ITP] Potential assertion hit in ResourceLoadStatisticsDatabaseStore::clearUserInteraction()
 https://bugs.webkit.org/show_bug.cgi?id=227763
 


Modified: trunk/Source/WebKit/UIProcess/ProcessAssertion.h (279678 => 279679)

--- trunk/Source/WebKit/UIProcess/ProcessAssertion.h	2021-07-07 22:07:57 UTC (rev 279678)
+++ trunk/Source/WebKit/UIProcess/ProcessAssertion.h	2021-07-07 22:21:50 UTC (rev 279679)
@@ -54,7 +54,7 @@
 FinishTaskUninterruptable,
 };
 
-class ProcessAssertion : public ThreadSafeRefCounted, public CanMakeWeakPtr {
+class ProcessAssertion : public ThreadSafeRefCounted, public CanMakeWeakPtr {
 WTF_MAKE_FAST_ALLOCATED;
 public:
 enum class Mode : bool { Sync, Async };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279678] trunk

2021-07-07 Thread zalan

Title: [279678] trunk








Revision 279678
Author za...@apple.com
Date 2021-07-07 15:07:57 -0700 (Wed, 07 Jul 2021)


Log Message
Source/WebCore:
[LFC][IFC] Unexpected content wrap when the containing block width is fixed
https://bugs.webkit.org/show_bug.cgi?id=227746

Reviewed by Antti Koivisto.

Test: fast/inline/inline-content-should-fit-the-line.html

While we resolved the relative Length value, the float -> LayoutUnit conversion implicitly floors the return value.
This flooring causes unexpected content wrap when the type we use for the measured width does not match the precision of the LayoutUnit.

* layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::processInlineContent):

LayoutTests:
[LFC][IFC] Unexpected content wrap when the containing block width is relative
https://bugs.webkit.org/show_bug.cgi?id=227746

Reviewed by Antti Koivisto.

* fast/inline/inline-content-should-fit-the-line-expected.html: Added.
* fast/inline/inline-content-should-fit-the-line.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/line-break-ch-unit-expected.txt
trunk/LayoutTests/platform/ios/css1/box_properties/padding-expected.txt
trunk/LayoutTests/platform/mac/css1/box_properties/width-expected.txt
trunk/LayoutTests/platform/mac/css1/color_and_background/background_position-expected.txt
trunk/LayoutTests/platform/mac/editing/inserting/typing-at-end-of-line-expected.txt
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.txt
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug4849-2-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp


Added Paths

trunk/LayoutTests/fast/inline/inline-content-should-fit-the-line-expected.html
trunk/LayoutTests/fast/inline/inline-content-should-fit-the-line.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279677 => 279678)

--- trunk/LayoutTests/ChangeLog	2021-07-07 21:55:26 UTC (rev 279677)
+++ trunk/LayoutTests/ChangeLog	2021-07-07 22:07:57 UTC (rev 279678)
@@ -1,5 +1,15 @@
 2021-07-07  Alan Bujtas  
 
+[LFC][IFC] Unexpected content wrap when the containing block width is relative
+https://bugs.webkit.org/show_bug.cgi?id=227746
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/inline-content-should-fit-the-line-expected.html: Added.
+* fast/inline/inline-content-should-fit-the-line.html: Added.
+
+2021-07-07  Alan Bujtas  
+
 [Legacy line layout] Inline content on subpixel position makes the table cell scroll
 https://bugs.webkit.org/show_bug.cgi?id=227594
 


Added: trunk/LayoutTests/fast/inline/inline-content-should-fit-the-line-expected.html (0 => 279678)

--- trunk/LayoutTests/fast/inline/inline-content-should-fit-the-line-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/inline/inline-content-should-fit-the-line-expected.html	2021-07-07 22:07:57 UTC (rev 279678)
@@ -0,0 +1,17 @@
+
+
+div {
+  width: 10ch;
+  background-color: green;
+  color: green;
+  font-family: Monospace;
+  white-space: nowrap;
+  margin-top: 1px;
+}
+
+should fit
+should fit
+should fit
+should fit
+should fit
+should fit


Added: trunk/LayoutTests/fast/inline/inline-content-should-fit-the-line.html (0 => 279678)

--- trunk/LayoutTests/fast/inline/inline-content-should-fit-the-line.html	(rev 0)
+++ trunk/LayoutTests/fast/inline/inline-content-should-fit-the-line.html	2021-07-07 22:07:57 UTC (rev 279678)
@@ -0,0 +1,17 @@
+
+
+div {
+  width: 10ch;
+  background-color: green;
+  color: green;
+  font-family: Monospace;
+  word-break: break-word;
+  margin-top: 1px;
+}
+
+should fit
+should fit
+should fit
+should fit
+should fit
+should fit


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/line-break-ch-unit-expected.txt (279677 => 279678)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/line-break-ch-unit-expected.txt	2021-07-07 21:55:26 UTC (rev 279677)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/line-break-ch-unit-expected.txt	2021-07-07 22:07:57 UTC (rev 279678)
@@ -1,101 +1,101 @@
 
-FAIL 3ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 4ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 5ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 6ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 7ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 8ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 9ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 10ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 11ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 12ch should fit assert_approx_equals: expected 10 +/- 1 but got 20
-FAIL 13ch should fit as

[webkit-changes] [279677] trunk/Source/JavaScriptCore

2021-07-07 Thread msaboff

Title: [279677] trunk/Source/_javascript_Core








Revision 279677
Author msab...@apple.com
Date 2021-07-07 14:55:26 -0700 (Wed, 07 Jul 2021)


Log Message
fitcored crashes at _javascript_Core: JSC::Heap::releaseAccessSlow
https://bugs.webkit.org/show_bug.cgi?id=227767

Reviewed by Geoffrey Garen.

Speculative fix for this crash.  We are crashing while destroying the VM as we are about to
release the JSLock.  In JSLock::willReleaseLock(), we release heap access.  Therefore we don't
need to release it again when undertaking the various shutdown steps in the VM destructor.

Added a new scope class that will only release and then acquire heap access if the caller
currently has heap access.

* heap/ReleaseHeapAccessScope.h:
(JSC::ReleaseHeapAccessIfNeededScope::ReleaseHeapAccessIfNeededScope):
(JSC::ReleaseHeapAccessIfNeededScope::~ReleaseHeapAccessIfNeededScope):
* jit/JITWorklist.cpp:
(JSC::JITWorklist::waitUntilAllPlansForVMAreReady):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/ReleaseHeapAccessScope.h
trunk/Source/_javascript_Core/jit/JITWorklist.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279676 => 279677)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-07 21:42:55 UTC (rev 279676)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-07 21:55:26 UTC (rev 279677)
@@ -1,3 +1,23 @@
+2021-07-07  Michael Saboff  
+
+fitcored crashes at _javascript_Core: JSC::Heap::releaseAccessSlow
+https://bugs.webkit.org/show_bug.cgi?id=227767
+
+Reviewed by Geoffrey Garen.
+
+Speculative fix for this crash.  We are crashing while destroying the VM as we are about to
+release the JSLock.  In JSLock::willReleaseLock(), we release heap access.  Therefore we don't
+need to release it again when undertaking the various shutdown steps in the VM destructor.
+
+Added a new scope class that will only release and then acquire heap access if the caller
+currently has heap access.
+
+* heap/ReleaseHeapAccessScope.h:
+(JSC::ReleaseHeapAccessIfNeededScope::ReleaseHeapAccessIfNeededScope):
+(JSC::ReleaseHeapAccessIfNeededScope::~ReleaseHeapAccessIfNeededScope):
+* jit/JITWorklist.cpp:
+(JSC::JITWorklist::waitUntilAllPlansForVMAreReady):
+
 2021-07-07  Yusuke Suzuki  
 
 [JSC] Do not allocate JITWorklist if JIT is disabled


Modified: trunk/Source/_javascript_Core/heap/ReleaseHeapAccessScope.h (279676 => 279677)

--- trunk/Source/_javascript_Core/heap/ReleaseHeapAccessScope.h	2021-07-07 21:42:55 UTC (rev 279676)
+++ trunk/Source/_javascript_Core/heap/ReleaseHeapAccessScope.h	2021-07-07 21:55:26 UTC (rev 279677)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -54,5 +54,26 @@
 Heap& m_heap;
 };
 
+class ReleaseHeapAccessIfNeededScope {
+public:
+ReleaseHeapAccessIfNeededScope(Heap& heap)
+: m_heap(heap)
+{
+hadHeapAccess = m_heap.hasAccess();
+if (hadHeapAccess)
+m_heap.releaseAccess();
+}
+
+~ReleaseHeapAccessIfNeededScope()
+{
+if (hadHeapAccess)
+m_heap.acquireAccess();
+}
+
+private:
+Heap& m_heap;
+bool hadHeapAccess { false };
+};
+
 } // namespace JSC
 


Modified: trunk/Source/_javascript_Core/jit/JITWorklist.cpp (279676 => 279677)

--- trunk/Source/_javascript_Core/jit/JITWorklist.cpp	2021-07-07 21:42:55 UTC (rev 279676)
+++ trunk/Source/_javascript_Core/jit/JITWorklist.cpp	2021-07-07 21:55:26 UTC (rev 279677)
@@ -173,7 +173,10 @@
 // the compiler and then it will be waiting for us to stop. That's a deadlock. We avoid that
 // deadlock by relinquishing our heap access, so that the collector pretends that we are stopped
 // even if we aren't.
-ReleaseHeapAccessScope releaseHeapAccessScope(vm.heap);
+// There can be the case where we already released heap access, for example when the VM is being
+// destroyed as a result of JSLock::unlock unlocking the last reference to the VM.
+// So we use a Release access scope that checks if we currently have access before releasing and later restoring.
+ReleaseHeapAccessIfNeededScope releaseHeapAccessScope(vm.heap);
 
 // Wait for all of the plans for the given VM to complete. The idea here
 // is that we want all of the caller VM's plans to be done. We don't care






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279676] trunk/Tools

2021-07-07 Thread lingho

Title: [279676] trunk/Tools








Revision 279676
Author lin...@apple.com
Date 2021-07-07 14:42:55 -0700 (Wed, 07 Jul 2021)


Log Message
Remove proxy server setting from Buildbot configuration
https://bugs.webkit.org/show_bug.cgi?id=227768

Reviewed by Aakash Jain.

* CISupport/build-webkit-org/steps.py:
(DownloadBuiltProduct.start):

Modified Paths

trunk/Tools/CISupport/build-webkit-org/steps.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (279675 => 279676)

--- trunk/Tools/CISupport/build-webkit-org/steps.py	2021-07-07 21:42:53 UTC (rev 279675)
+++ trunk/Tools/CISupport/build-webkit-org/steps.py	2021-07-07 21:42:55 UTC (rev 279676)
@@ -38,7 +38,6 @@
 print('ERROR: Please use Python 3. This code is not compatible with Python 2.')
 sys.exit(1)
 
-APPLE_WEBKIT_AWS_PROXY = "http://proxy01.webkit.org:3128"
 BUILD_WEBKIT_HOSTNAME = 'build.webkit.org'
 COMMITS_INFO_URL = 'https://commits.webkit.org/'
 CURRENT_HOSTNAME = socket.gethostname().strip()
@@ -402,8 +401,6 @@
 flunkOnFailure = False
 
 def start(self):
-if 'apple' in self.getProperty('buildername').lower():
-self.workerEnvironment['HTTPS_PROXY'] = APPLE_WEBKIT_AWS_PROXY  # curl env var to use a proxy
 return shell.ShellCommand.start(self)
 
 def evaluateCommand(self, cmd):


Modified: trunk/Tools/ChangeLog (279675 => 279676)

--- trunk/Tools/ChangeLog	2021-07-07 21:42:53 UTC (rev 279675)
+++ trunk/Tools/ChangeLog	2021-07-07 21:42:55 UTC (rev 279676)
@@ -1,3 +1,13 @@
+2021-07-07  Ling Ho  
+
+Remove proxy server setting from Buildbot configuration
+https://bugs.webkit.org/show_bug.cgi?id=227768
+
+Reviewed by Aakash Jain.
+
+* CISupport/build-webkit-org/steps.py:
+(DownloadBuiltProduct.start):
+
 2021-07-07  Aakash Jain  
 
 [build.webkit.org] Add unit-tests for RunWebKit1Tests






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279675] branches/safari-612.1.22.3-branch/Source/WebKit

2021-07-07 Thread rubent_22

Title: [279675] branches/safari-612.1.22.3-branch/Source/WebKit








Revision 279675
Author rubent...@apple.com
Date 2021-07-07 14:42:53 -0700 (Wed, 07 Jul 2021)


Log Message
Cherry-pick r279591. rdar://problem/80282911

Collect Accessibility preferences on a background queue
https://bugs.webkit.org/show_bug.cgi?id=227617


Reviewed by Brent Fulgham.

To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
and send them to the WebContent process(es).

* Shared/AccessibilityPreferences.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Shared/AccessibilityPreferences.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
(WebKit::WebProcessPool::registerNotificationObservers):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* UIProcess/WebProcessPool.h:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):
(WebKit::WebProcess::setMediaAccessibilityPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.22.3-branch/Source/WebKit/ChangeLog
branches/safari-612.1.22.3-branch/Source/WebKit/Shared/AccessibilityPreferences.cpp
branches/safari-612.1.22.3-branch/Source/WebKit/Shared/AccessibilityPreferences.h
branches/safari-612.1.22.3-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-612.1.22.3-branch/Source/WebKit/UIProcess/WebProcessPool.cpp
branches/safari-612.1.22.3-branch/Source/WebKit/UIProcess/WebProcessPool.h
branches/safari-612.1.22.3-branch/Source/WebKit/WebProcess/WebProcess.h
branches/safari-612.1.22.3-branch/Source/WebKit/WebProcess/WebProcess.messages.in
branches/safari-612.1.22.3-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-612.1.22.3-branch/Source/WebKit/ChangeLog (279674 => 279675)

--- branches/safari-612.1.22.3-branch/Source/WebKit/ChangeLog	2021-07-07 21:42:48 UTC (rev 279674)
+++ branches/safari-612.1.22.3-branch/Source/WebKit/ChangeLog	2021-07-07 21:42:53 UTC (rev 279675)
@@ -1,5 +1,68 @@
 2021-07-07  Ruben Turcios  
 
+Cherry-pick r279591. rdar://problem/80282911
+
+Collect Accessibility preferences on a background queue
+https://bugs.webkit.org/show_bug.cgi?id=227617
+
+
+Reviewed by Brent Fulgham.
+
+To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
+and send them to the WebContent process(es).
+
+* Shared/AccessibilityPreferences.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
+(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+(WebKit::WebProcess::setMediaAccessibilityPreferences):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-06  Per Arne  
+
+Collect Accessibility preferences on a background queue
+https://bugs.webkit.org/show_bug.cgi?id=227617
+
+
+Reviewed by Brent Fulgham.
+
+To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
+and send them to the WebContent process(es).
+
+* Shared/AccessibilityPreferences.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
+(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/Web

[webkit-changes] [279674] branches/safari-612.1.22.3-branch/Source/WebKit

2021-07-07 Thread rubent_22

Title: [279674] branches/safari-612.1.22.3-branch/Source/WebKit








Revision 279674
Author rubent...@apple.com
Date 2021-07-07 14:42:48 -0700 (Wed, 07 Jul 2021)


Log Message
Cherry-pick r279342. rdar://problem/80282911

Pass correct value of AX per app settings to the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=227441


Reviewed by Brent Fulgham.

Pass value of type AXValueState instead of a boolean value for per app AX settings.

* Shared/AccessibilityPreferences.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.22.3-branch/Source/WebKit/ChangeLog
branches/safari-612.1.22.3-branch/Source/WebKit/Shared/AccessibilityPreferences.h
branches/safari-612.1.22.3-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-612.1.22.3-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-612.1.22.3-branch/Source/WebKit/ChangeLog (279673 => 279674)

--- branches/safari-612.1.22.3-branch/Source/WebKit/ChangeLog	2021-07-07 21:35:19 UTC (rev 279673)
+++ branches/safari-612.1.22.3-branch/Source/WebKit/ChangeLog	2021-07-07 21:42:48 UTC (rev 279674)
@@ -1,3 +1,40 @@
+2021-07-07  Ruben Turcios  
+
+Cherry-pick r279342. rdar://problem/80282911
+
+Pass correct value of AX per app settings to the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=227441
+
+
+Reviewed by Brent Fulgham.
+
+Pass value of type AXValueState instead of a boolean value for per app AX settings.
+
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-28  Per Arne  
+
+Pass correct value of AX per app settings to the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=227441
+
+
+Reviewed by Brent Fulgham.
+
+Pass value of type AXValueState instead of a boolean value for per app AX settings.
+
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+
 2021-06-30  Alan Coon  
 
 Cherry-pick r279411. rdar://problem/79970312


Modified: branches/safari-612.1.22.3-branch/Source/WebKit/Shared/AccessibilityPreferences.h (279673 => 279674)

--- branches/safari-612.1.22.3-branch/Source/WebKit/Shared/AccessibilityPreferences.h	2021-07-07 21:35:19 UTC (rev 279673)
+++ branches/safari-612.1.22.3-branch/Source/WebKit/Shared/AccessibilityPreferences.h	2021-07-07 21:42:48 UTC (rev 279674)
@@ -31,15 +31,19 @@
 #include 
 #endif
 
+#if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
+#include "AccessibilitySupportSPI.h"
+#endif
+
 namespace WebKit {
 
 struct AccessibilityPreferences {
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
-bool reduceMotionEnabled { false };
-bool increaseButtonLegibility { false };
-bool enhanceTextLegibility { false };
-bool darkenSystemColors { false };
-bool invertColorsEnabled { false };
+AXValueState reduceMotionEnabled { AXValueStateEmpty };
+AXValueState increaseButtonLegibility { AXValueStateEmpty };
+AXValueState enhanceTextLegibility { AXValueStateEmpty };
+AXValueState darkenSystemColors { AXValueStateEmpty };
+AXValueState invertColorsEnabled { AXValueStateEmpty };
 #endif
 #if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 WebCore::CaptionUserPreferences::CaptionDisplayMode captionDisplayMode;
@@ -55,3 +59,19 @@
 static std::optional decode(Decoder&);
 };
 }
+
+#if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
+namespace WTF {
+
+template<> struct EnumTraits {
+using values = EnumValues<
+AXValueState,
+AXValueState::AXValueStateInvalid,
+AXValueState::AXValueStateEmpty,
+AXValueState::AXValueStateOff,
+AXValueState::AXValueStateOn
+>;
+};
+
+} // namespace WTF
+#endif


Modified: branches/safari-612.1.22.3-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (279673 => 279674)

--- branches/safari-612.1.22.3-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-07-07 21:35:19 UTC (rev 279673)
+++ branches/safari-612.1.22.3-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-07-07 21:42:48 UTC (rev 279674)
@@ -279,11 +279,11 @@
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
 auto appId = WebCore::

[webkit-changes] [279673] trunk

2021-07-07 Thread zalan

Title: [279673] trunk








Revision 279673
Author za...@apple.com
Date 2021-07-07 14:35:19 -0700 (Wed, 07 Jul 2021)


Log Message
[Legacy line layout] Inline content on subpixel position makes the table cell scroll
https://bugs.webkit.org/show_bug.cgi?id=227594


Reviewed by Simon Fraser.

Source/WebCore:

The root inlinebox is supposed to fit the [top, top + maxHeight] space as it is computed based
on the inline level boxes. However due to the integral rounding on the root inlinebox's logical top,
it may accidentally leak out of the containing block and trigger unintended layout overflow.
This patch ensures that we don't stretch the line (top/bottom) with the integral positioned root inlinebox.

Test: fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple.html

* rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::placeBoxesInBlockDirection):

LayoutTests:

* fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple-expected.html: Added.
* fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/fast/multicol/vertical-lr/float-multicol-expected.txt
trunk/LayoutTests/platform/ios/fast/multicol/vertical-lr/nested-columns-expected.txt
trunk/LayoutTests/platform/ios/fast/multicol/vertical-rl/float-multicol-expected.txt
trunk/LayoutTests/platform/ios/fast/table/border-collapsing/002-vertical-expected.txt
trunk/LayoutTests/platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt
trunk/LayoutTests/platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt
trunk/LayoutTests/platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt
trunk/LayoutTests/platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/LegacyInlineFlowBox.cpp


Added Paths

trunk/LayoutTests/fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple-expected.html
trunk/LayoutTests/fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279672 => 279673)

--- trunk/LayoutTests/ChangeLog	2021-07-07 21:35:07 UTC (rev 279672)
+++ trunk/LayoutTests/ChangeLog	2021-07-07 21:35:19 UTC (rev 279673)
@@ -1,3 +1,14 @@
+2021-07-07  Alan Bujtas  
+
+[Legacy line layout] Inline content on subpixel position makes the table cell scroll
+https://bugs.webkit.org/show_bug.cgi?id=227594
+
+
+Reviewed by Simon Fraser.
+
+* fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple-expected.html: Added.
+* fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple.html: Added.
+
 2021-07-07  Aditya Keerthi  
 
 [iOS] Inconsistent styling for input[type="submit"] and button[type="submit"]


Added: trunk/LayoutTests/fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple-expected.html (0 => 279673)

--- trunk/LayoutTests/fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple-expected.html	2021-07-07 21:35:19 UTC (rev 279673)
@@ -0,0 +1,17 @@
+
+
+
+table {
+  border-collapse:collapse;
+}
+
+td {
+  border: 1px solid green;
+  padding-bottom: 0;
+  overflow-y: hidden;
+  width: 300px;
+}
+
+
+PASS if no scrollbar
+


Added: trunk/LayoutTests/fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple.html (0 => 279673)

--- trunk/LayoutTests/fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple.html	(rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-root-inlinebox-integral-rounding-table-simple.html	2021-07-07 21:35:19 UTC (rev 279673)
@@ -0,0 +1,17 @@
+
+
+
+table {
+  border-collapse:collapse;
+}
+
+td {
+  border: 1px solid green;
+  padding-bottom: 0;
+  overflow-y: auto;
+  width: 300px;
+}
+
+
+PASS if no scrollbar
+


Modified: trunk/LayoutTests/platform/ios/fast/multicol/vertical-lr/float-multicol-expected.txt (279672 => 279673)

--- trunk/LayoutTests/platform/ios/fast/multicol/vertical-lr/float-multicol-expected.txt	2021-07-07 21:35:07 UTC (rev 279672)
+++ trunk/LayoutTests/platform/ios/fast/multicol/vertical-lr/float-multicol-expected.txt	2021-07-07 21:35:19 UTC (rev 279673)
@@ -133,7 +133,7 @@
   text run at (20,331) width 33: "Bugs"
   RenderBlock {DD} at (56,40) size 508x439
 RenderBlock {P} at (0,0) size 508x439
-  RenderText {#text} at (0,291) size 346x142
+  RenderText {#text} at (0,291) size 347x142
 text run at (0,291) width 44: "You've"
 text run at (20,291) width 48: "already"
 text run at (207,291) width 131: "downloaded a build."
@@ -147,12 +147,12 @@
 text run at (327,291) width 70: "build with "
 text run at (327,360) width 63: "Talkback,"
   RenderInline {EM} at (0,0) size 19x106
-RenderT

[webkit-changes] [279671] branches/safari-612.1.22.2-branch/Source/WebKit

2021-07-07 Thread rubent_22

Title: [279671] branches/safari-612.1.22.2-branch/Source/WebKit








Revision 279671
Author rubent...@apple.com
Date 2021-07-07 14:35:01 -0700 (Wed, 07 Jul 2021)


Log Message
Cherry-pick r279342. rdar://problem/80282781

Pass correct value of AX per app settings to the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=227441


Reviewed by Brent Fulgham.

Pass value of type AXValueState instead of a boolean value for per app AX settings.

* Shared/AccessibilityPreferences.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.22.2-branch/Source/WebKit/ChangeLog
branches/safari-612.1.22.2-branch/Source/WebKit/Shared/AccessibilityPreferences.h
branches/safari-612.1.22.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-612.1.22.2-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-612.1.22.2-branch/Source/WebKit/ChangeLog (279670 => 279671)

--- branches/safari-612.1.22.2-branch/Source/WebKit/ChangeLog	2021-07-07 21:15:30 UTC (rev 279670)
+++ branches/safari-612.1.22.2-branch/Source/WebKit/ChangeLog	2021-07-07 21:35:01 UTC (rev 279671)
@@ -1,3 +1,40 @@
+2021-07-07  Ruben Turcios  
+
+Cherry-pick r279342. rdar://problem/80282781
+
+Pass correct value of AX per app settings to the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=227441
+
+
+Reviewed by Brent Fulgham.
+
+Pass value of type AXValueState instead of a boolean value for per app AX settings.
+
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-28  Per Arne  
+
+Pass correct value of AX per app settings to the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=227441
+
+
+Reviewed by Brent Fulgham.
+
+Pass value of type AXValueState instead of a boolean value for per app AX settings.
+
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+
 2021-06-30  Alan Coon  
 
 Cherry-pick r279411. rdar://problem/79970312


Modified: branches/safari-612.1.22.2-branch/Source/WebKit/Shared/AccessibilityPreferences.h (279670 => 279671)

--- branches/safari-612.1.22.2-branch/Source/WebKit/Shared/AccessibilityPreferences.h	2021-07-07 21:15:30 UTC (rev 279670)
+++ branches/safari-612.1.22.2-branch/Source/WebKit/Shared/AccessibilityPreferences.h	2021-07-07 21:35:01 UTC (rev 279671)
@@ -31,15 +31,19 @@
 #include 
 #endif
 
+#if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
+#include "AccessibilitySupportSPI.h"
+#endif
+
 namespace WebKit {
 
 struct AccessibilityPreferences {
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
-bool reduceMotionEnabled { false };
-bool increaseButtonLegibility { false };
-bool enhanceTextLegibility { false };
-bool darkenSystemColors { false };
-bool invertColorsEnabled { false };
+AXValueState reduceMotionEnabled { AXValueStateEmpty };
+AXValueState increaseButtonLegibility { AXValueStateEmpty };
+AXValueState enhanceTextLegibility { AXValueStateEmpty };
+AXValueState darkenSystemColors { AXValueStateEmpty };
+AXValueState invertColorsEnabled { AXValueStateEmpty };
 #endif
 #if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 WebCore::CaptionUserPreferences::CaptionDisplayMode captionDisplayMode;
@@ -55,3 +59,19 @@
 static std::optional decode(Decoder&);
 };
 }
+
+#if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
+namespace WTF {
+
+template<> struct EnumTraits {
+using values = EnumValues<
+AXValueState,
+AXValueState::AXValueStateInvalid,
+AXValueState::AXValueStateEmpty,
+AXValueState::AXValueStateOff,
+AXValueState::AXValueStateOn
+>;
+};
+
+} // namespace WTF
+#endif


Modified: branches/safari-612.1.22.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (279670 => 279671)

--- branches/safari-612.1.22.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-07-07 21:15:30 UTC (rev 279670)
+++ branches/safari-612.1.22.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-07-07 21:35:01 UTC (rev 279671)
@@ -279,11 +279,11 @@
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
 auto appId = WebCore::

[webkit-changes] [279672] branches/safari-612.1.22.2-branch/Source/WebKit

2021-07-07 Thread rubent_22

Title: [279672] branches/safari-612.1.22.2-branch/Source/WebKit








Revision 279672
Author rubent...@apple.com
Date 2021-07-07 14:35:07 -0700 (Wed, 07 Jul 2021)


Log Message
Cherry-pick r279591. rdar://problem/80282781

Collect Accessibility preferences on a background queue
https://bugs.webkit.org/show_bug.cgi?id=227617


Reviewed by Brent Fulgham.

To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
and send them to the WebContent process(es).

* Shared/AccessibilityPreferences.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Shared/AccessibilityPreferences.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
(WebKit::WebProcessPool::registerNotificationObservers):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* UIProcess/WebProcessPool.h:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):
(WebKit::WebProcess::setMediaAccessibilityPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.22.2-branch/Source/WebKit/ChangeLog
branches/safari-612.1.22.2-branch/Source/WebKit/Shared/AccessibilityPreferences.cpp
branches/safari-612.1.22.2-branch/Source/WebKit/Shared/AccessibilityPreferences.h
branches/safari-612.1.22.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-612.1.22.2-branch/Source/WebKit/UIProcess/WebProcessPool.cpp
branches/safari-612.1.22.2-branch/Source/WebKit/UIProcess/WebProcessPool.h
branches/safari-612.1.22.2-branch/Source/WebKit/WebProcess/WebProcess.h
branches/safari-612.1.22.2-branch/Source/WebKit/WebProcess/WebProcess.messages.in
branches/safari-612.1.22.2-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-612.1.22.2-branch/Source/WebKit/ChangeLog (279671 => 279672)

--- branches/safari-612.1.22.2-branch/Source/WebKit/ChangeLog	2021-07-07 21:35:01 UTC (rev 279671)
+++ branches/safari-612.1.22.2-branch/Source/WebKit/ChangeLog	2021-07-07 21:35:07 UTC (rev 279672)
@@ -1,5 +1,68 @@
 2021-07-07  Ruben Turcios  
 
+Cherry-pick r279591. rdar://problem/80282781
+
+Collect Accessibility preferences on a background queue
+https://bugs.webkit.org/show_bug.cgi?id=227617
+
+
+Reviewed by Brent Fulgham.
+
+To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
+and send them to the WebContent process(es).
+
+* Shared/AccessibilityPreferences.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
+(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+(WebKit::WebProcess::setMediaAccessibilityPreferences):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-06  Per Arne  
+
+Collect Accessibility preferences on a background queue
+https://bugs.webkit.org/show_bug.cgi?id=227617
+
+
+Reviewed by Brent Fulgham.
+
+To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
+and send them to the WebContent process(es).
+
+* Shared/AccessibilityPreferences.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
+(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/Web

[webkit-changes] [279670] trunk/Source/WebKit

2021-07-07 Thread cdumez

Title: [279670] trunk/Source/WebKit








Revision 279670
Author cdu...@apple.com
Date 2021-07-07 14:15:30 -0700 (Wed, 07 Jul 2021)


Log Message
[ITP] Potential assertion hit in ResourceLoadStatisticsDatabaseStore::clearUserInteraction()
https://bugs.webkit.org/show_bug.cgi?id=227763


Reviewed by Darin Adler.

ResourceLoadStatisticsDatabaseStore::clearUserInteraction() was starting a SQLite transaction
but one of its callers already starts one, causing us to hit this assertion (recursive
transactions are not supported).

To address the issue, add an overload that takes in an SQLiteTransaction, when the call
site already started a transaction.

* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsDatabaseStore::logUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasHadUserInteraction):
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (279669 => 279670)

--- trunk/Source/WebKit/ChangeLog	2021-07-07 21:12:29 UTC (rev 279669)
+++ trunk/Source/WebKit/ChangeLog	2021-07-07 21:15:30 UTC (rev 279670)
@@ -1,3 +1,26 @@
+2021-07-07  Chris Dumez  
+
+[ITP] Potential assertion hit in ResourceLoadStatisticsDatabaseStore::clearUserInteraction()
+https://bugs.webkit.org/show_bug.cgi?id=227763
+
+
+Reviewed by Darin Adler.
+
+ResourceLoadStatisticsDatabaseStore::clearUserInteraction() was starting a SQLite transaction
+but one of its callers already starts one, causing us to hit this assertion (recursive
+transactions are not supported).
+
+To address the issue, add an overload that takes in an SQLiteTransaction, when the call
+site already started a transaction.
+
+* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess):
+(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccessInternal):
+(WebKit::ResourceLoadStatisticsDatabaseStore::logUserInteraction):
+(WebKit::ResourceLoadStatisticsDatabaseStore::clearUserInteraction):
+(WebKit::ResourceLoadStatisticsDatabaseStore::hasHadUserInteraction):
+* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
+
 2021-07-07  Christopher Reid  
 
 [PlayStation] Don't assume 4KB block size when estimating Network Cache disk usage


Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (279669 => 279670)

--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp	2021-07-07 21:12:29 UTC (rev 279669)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp	2021-07-07 21:15:30 UTC (rev 279670)
@@ -1622,7 +1622,7 @@
 ASSERT(subFrameStatus.first == AddedRecord::No);
 #if ASSERT_ENABLED
 if (!NetworkStorageSession::canRequestStorageAccessForLoginOrCompatibilityPurposesWithoutPriorUserInteraction(subFrameDomain, topFrameDomain))
-ASSERT(hasHadUserInteraction(subFrameDomain, OperatingDatesWindow::Long));
+ASSERT(hasHadUserInteraction(transaction, subFrameDomain, OperatingDatesWindow::Long));
 #endif
 insertDomainRelationshipList(transaction, storageAccessUnderTopFrameDomainsQuery, HashSet({ topFrameDomain }), *subFrameStatus.second);
 }
@@ -1652,7 +1652,7 @@
 ASSERT(subFrameStatus.first == AddedRecord::No);
 #if ASSERT_ENABLED
 if (!NetworkStorageSession::canRequestStorageAccessForLoginOrCompatibilityPurposesWithoutPriorUserInteraction(subFrameDomain, topFrameDomain))
-ASSERT(hasHadUserInteraction(subFrameDomain, OperatingDatesWindow::Long));
+ASSERT(hasHadUserInteraction(transaction, subFrameDomain, OperatingDatesWindow::Long));
 #endif
 ASSERT(hasUserGrantedStorageAccessThroughPrompt(*subFrameStatus.second, topFrameDomain) == StorageAccessPromptWasShown::Yes);
 #endif
@@ -1879,7 +1879,7 @@
 ITP_RELEASE_LOG_ERROR(m_sessionID, "%p - ResourceLoadStatisticsDatabaseStore::logUserInteraction was not completed due to failed insert attempt", this);
 return;
 }
-bool didHavePreviousUserInteraction = hasHadUserInteraction(domain, OperatingDatesWindow::Long);
+bool didHavePreviousUserInteraction = hasHadUserInteraction(transaction, domain, OperatingDatesWindow::Long);
 setUserInteraction(domain, true, WallTime::now());
 
 transaction.commit();
@@ -1897,7 +1897,15 @@
 
 SQLiteTrans

[webkit-changes] [279669] trunk

2021-07-07 Thread cdumez

Title: [279669] trunk








Revision 279669
Author cdu...@apple.com
Date 2021-07-07 14:12:29 -0700 (Wed, 07 Jul 2021)


Log Message
IDBIndex.keyPath should keep returning the same object
https://bugs.webkit.org/show_bug.cgi?id=227758

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

* web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt:
* web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt:

Source/WebCore:

IDBIndex.keyPath should keep returning the same object to match other browser
engines (Gecko and Blink).

No new tests, rebaselined existing tests.

* Modules/indexeddb/IDBIndex.idl:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279668 => 279669)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 21:12:29 UTC (rev 279669)
@@ -1,3 +1,15 @@
+2021-07-07  Chris Dumez  
+
+IDBIndex.keyPath should keep returning the same object
+https://bugs.webkit.org/show_bug.cgi?id=227758
+
+Reviewed by Geoffrey Garen.
+
+Rebaseline WPT tests that are now passing.
+
+* web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt:
+* web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt:
+
 2021-07-07  Alex Christensen  
 
 Allow setting empty hosts of URLs with non-special schemes


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt (279668 => 279669)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt	2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any-expected.txt	2021-07-07 21:12:29 UTC (rev 279669)
@@ -1,3 +1,3 @@
 
-FAIL IDBIndex's keyPath attribute returns the same object. assert_equals: Same object instance is returned each time keyPath is inspected expected ["a", "b"] but got ["a", "b"]
+PASS IDBIndex's keyPath attribute returns the same object.
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt (279668 => 279669)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt	2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_keyPath.any.worker-expected.txt	2021-07-07 21:12:29 UTC (rev 279669)
@@ -1,3 +1,3 @@
 
-FAIL IDBIndex's keyPath attribute returns the same object. assert_equals: Same object instance is returned each time keyPath is inspected expected ["a", "b"] but got ["a", "b"]
+PASS IDBIndex's keyPath attribute returns the same object.
 


Modified: trunk/Source/WebCore/ChangeLog (279668 => 279669)

--- trunk/Source/WebCore/ChangeLog	2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/Source/WebCore/ChangeLog	2021-07-07 21:12:29 UTC (rev 279669)
@@ -1,3 +1,17 @@
+2021-07-07  Chris Dumez  
+
+IDBIndex.keyPath should keep returning the same object
+https://bugs.webkit.org/show_bug.cgi?id=227758
+
+Reviewed by Geoffrey Garen.
+
+IDBIndex.keyPath should keep returning the same object to match other browser
+engines (Gecko and Blink).
+
+No new tests, rebaselined existing tests.
+
+* Modules/indexeddb/IDBIndex.idl:
+
 2021-07-07  Alex Christensen  
 
 Allow setting empty hosts of URLs with non-special schemes


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl (279668 => 279669)

--- trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl	2021-07-07 21:00:45 UTC (rev 279668)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl	2021-07-07 21:12:29 UTC (rev 279669)
@@ -36,7 +36,7 @@
 ] interface IDBIndex {
 attribute DOMString name;
 [SameObject] readonly attribute IDBObjectStore objectStore;
-readonly attribute IDBKeyPath? keyPath;
+[SameObject, CachedAttribute] readonly attribute IDBKeyPath keyPath;
 readonly attribute boolean multiEntry;
 readonly attribute boolean unique;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279668] branches/safari-612.1.22.1-branch/Source/WebKit

2021-07-07 Thread rubent_22

Title: [279668] branches/safari-612.1.22.1-branch/Source/WebKit








Revision 279668
Author rubent...@apple.com
Date 2021-07-07 14:00:45 -0700 (Wed, 07 Jul 2021)


Log Message
Cherry-pick r279591. rdar://problem/80282927

Collect Accessibility preferences on a background queue
https://bugs.webkit.org/show_bug.cgi?id=227617


Reviewed by Brent Fulgham.

To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
and send them to the WebContent process(es).

* Shared/AccessibilityPreferences.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Shared/AccessibilityPreferences.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
(WebKit::WebProcessPool::registerNotificationObservers):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* UIProcess/WebProcessPool.h:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):
(WebKit::WebProcess::setMediaAccessibilityPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.22.1-branch/Source/WebKit/ChangeLog
branches/safari-612.1.22.1-branch/Source/WebKit/Shared/AccessibilityPreferences.cpp
branches/safari-612.1.22.1-branch/Source/WebKit/Shared/AccessibilityPreferences.h
branches/safari-612.1.22.1-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-612.1.22.1-branch/Source/WebKit/UIProcess/WebProcessPool.cpp
branches/safari-612.1.22.1-branch/Source/WebKit/UIProcess/WebProcessPool.h
branches/safari-612.1.22.1-branch/Source/WebKit/WebProcess/WebProcess.h
branches/safari-612.1.22.1-branch/Source/WebKit/WebProcess/WebProcess.messages.in
branches/safari-612.1.22.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-612.1.22.1-branch/Source/WebKit/ChangeLog (279667 => 279668)

--- branches/safari-612.1.22.1-branch/Source/WebKit/ChangeLog	2021-07-07 21:00:40 UTC (rev 279667)
+++ branches/safari-612.1.22.1-branch/Source/WebKit/ChangeLog	2021-07-07 21:00:45 UTC (rev 279668)
@@ -1,5 +1,68 @@
 2021-07-07  Ruben Turcios  
 
+Cherry-pick r279591. rdar://problem/80282927
+
+Collect Accessibility preferences on a background queue
+https://bugs.webkit.org/show_bug.cgi?id=227617
+
+
+Reviewed by Brent Fulgham.
+
+To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
+and send them to the WebContent process(es).
+
+* Shared/AccessibilityPreferences.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
+(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+(WebKit::WebProcess::setMediaAccessibilityPreferences):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-06  Per Arne  
+
+Collect Accessibility preferences on a background queue
+https://bugs.webkit.org/show_bug.cgi?id=227617
+
+
+Reviewed by Brent Fulgham.
+
+To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
+and send them to the WebContent process(es).
+
+* Shared/AccessibilityPreferences.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
+(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/Web

[webkit-changes] [279667] branches/safari-612.1.22.1-branch/Source/WebKit

2021-07-07 Thread rubent_22

Title: [279667] branches/safari-612.1.22.1-branch/Source/WebKit








Revision 279667
Author rubent...@apple.com
Date 2021-07-07 14:00:40 -0700 (Wed, 07 Jul 2021)


Log Message
Cherry-pick r279342. rdar://problem/80282927

Pass correct value of AX per app settings to the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=227441


Reviewed by Brent Fulgham.

Pass value of type AXValueState instead of a boolean value for per app AX settings.

* Shared/AccessibilityPreferences.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.22.1-branch/Source/WebKit/ChangeLog
branches/safari-612.1.22.1-branch/Source/WebKit/Shared/AccessibilityPreferences.h
branches/safari-612.1.22.1-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-612.1.22.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-612.1.22.1-branch/Source/WebKit/ChangeLog (279666 => 279667)

--- branches/safari-612.1.22.1-branch/Source/WebKit/ChangeLog	2021-07-07 20:59:59 UTC (rev 279666)
+++ branches/safari-612.1.22.1-branch/Source/WebKit/ChangeLog	2021-07-07 21:00:40 UTC (rev 279667)
@@ -1,3 +1,40 @@
+2021-07-07  Ruben Turcios  
+
+Cherry-pick r279342. rdar://problem/80282927
+
+Pass correct value of AX per app settings to the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=227441
+
+
+Reviewed by Brent Fulgham.
+
+Pass value of type AXValueState instead of a boolean value for per app AX settings.
+
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-28  Per Arne  
+
+Pass correct value of AX per app settings to the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=227441
+
+
+Reviewed by Brent Fulgham.
+
+Pass value of type AXValueState instead of a boolean value for per app AX settings.
+
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+
 2021-06-30  Alan Coon  
 
 Cherry-pick r279411. rdar://problem/79970312


Modified: branches/safari-612.1.22.1-branch/Source/WebKit/Shared/AccessibilityPreferences.h (279666 => 279667)

--- branches/safari-612.1.22.1-branch/Source/WebKit/Shared/AccessibilityPreferences.h	2021-07-07 20:59:59 UTC (rev 279666)
+++ branches/safari-612.1.22.1-branch/Source/WebKit/Shared/AccessibilityPreferences.h	2021-07-07 21:00:40 UTC (rev 279667)
@@ -31,15 +31,19 @@
 #include 
 #endif
 
+#if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
+#include "AccessibilitySupportSPI.h"
+#endif
+
 namespace WebKit {
 
 struct AccessibilityPreferences {
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
-bool reduceMotionEnabled { false };
-bool increaseButtonLegibility { false };
-bool enhanceTextLegibility { false };
-bool darkenSystemColors { false };
-bool invertColorsEnabled { false };
+AXValueState reduceMotionEnabled { AXValueStateEmpty };
+AXValueState increaseButtonLegibility { AXValueStateEmpty };
+AXValueState enhanceTextLegibility { AXValueStateEmpty };
+AXValueState darkenSystemColors { AXValueStateEmpty };
+AXValueState invertColorsEnabled { AXValueStateEmpty };
 #endif
 #if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 WebCore::CaptionUserPreferences::CaptionDisplayMode captionDisplayMode;
@@ -55,3 +59,19 @@
 static std::optional decode(Decoder&);
 };
 }
+
+#if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
+namespace WTF {
+
+template<> struct EnumTraits {
+using values = EnumValues<
+AXValueState,
+AXValueState::AXValueStateInvalid,
+AXValueState::AXValueStateEmpty,
+AXValueState::AXValueStateOff,
+AXValueState::AXValueStateOn
+>;
+};
+
+} // namespace WTF
+#endif


Modified: branches/safari-612.1.22.1-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (279666 => 279667)

--- branches/safari-612.1.22.1-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-07-07 20:59:59 UTC (rev 279666)
+++ branches/safari-612.1.22.1-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-07-07 21:00:40 UTC (rev 279667)
@@ -279,11 +279,11 @@
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
 auto appId = WebCore::

[webkit-changes] [279666] trunk

2021-07-07 Thread achristensen

Title: [279666] trunk








Revision 279666
Author achristen...@apple.com
Date 2021-07-07 13:59:59 -0700 (Wed, 07 Jul 2021)


Log Message
Allow setting empty hosts of URLs with non-special schemes
https://bugs.webkit.org/show_bug.cgi?id=227752

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/url/url-setters-a-area.window-expected.txt:
* web-platform-tests/url/url-setters.any-expected.txt:
* web-platform-tests/url/url-setters.any.worker-expected.txt:

Source/WebCore:

asdf:/// is fine.
http:/// is not fine.

* html/URLDecomposition.cpp:
(WebCore::URLDecomposition::setHost):
(WebCore::URLDecomposition::setHostname):
(WebCore::URLDecomposition::hash const):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/URLDecomposition.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279665 => 279666)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 20:50:19 UTC (rev 279665)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 20:59:59 UTC (rev 279666)
@@ -1,5 +1,16 @@
 2021-07-07  Alex Christensen  
 
+Allow setting empty hosts of URLs with non-special schemes
+https://bugs.webkit.org/show_bug.cgi?id=227752
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/url/url-setters-a-area.window-expected.txt:
+* web-platform-tests/url/url-setters.any-expected.txt:
+* web-platform-tests/url/url-setters.any.worker-expected.txt:
+
+2021-07-07  Alex Christensen  
+
 URL path setter should add "./" before non-empty path and after empty host for URLs with non-special schemes
 https://bugs.webkit.org/show_bug.cgi?id=227750
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt (279665 => 279666)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt	2021-07-07 20:50:19 UTC (rev 279665)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt	2021-07-07 20:59:59 UTC (rev 279666)
@@ -148,8 +148,8 @@
 PASS : Setting .host = 'example.com:' Port number is unchanged if not specified
 PASS : Setting .host = '' The empty host is not valid for special schemes
 PASS : Setting .host = '' The empty host is not valid for special schemes
-FAIL : Setting .host = '' The empty host is OK for non-special schemes assert_equals: expected "view-source+http:///foo" but got "view-source+http://example.net/foo"
-FAIL : Setting .host = '' The empty host is OK for non-special schemes assert_equals: expected "view-source+http:///foo" but got "view-source+http://example.net/foo"
+PASS : Setting .host = '' The empty host is OK for non-special schemes
+PASS : Setting .host = '' The empty host is OK for non-special schemes
 PASS : Setting .host = 'example.net' Path-only URLs can gain a host
 PASS : Setting .host = 'example.net' Path-only URLs can gain a host
 PASS : Setting .host = '0x7F01:8080' IPv4 address syntax is normalized
@@ -232,8 +232,8 @@
 PASS : Setting .hostname = ' '
 PASS : Setting .hostname = '#'
 PASS : Setting .hostname = '#'
-FAIL : Setting .hostname = '/' assert_equals: expected "sc:///" but got "sc://x/"
-FAIL : Setting .hostname = '/' assert_equals: expected "sc:///" but got "sc://x/"
+PASS : Setting .hostname = '/'
+PASS : Setting .hostname = '/'
 PASS : Setting .hostname = '?'
 PASS : Setting .hostname = '?'
 PASS : Setting .hostname = '@'
@@ -246,8 +246,8 @@
 PASS : Setting .hostname = 'example.com'
 PASS : Setting .hostname = '' The empty host is not valid for special schemes
 PASS : Setting .hostname = '' The empty host is not valid for special schemes
-FAIL : Setting .hostname = '' The empty host is OK for non-special schemes assert_equals: expected "view-source+http:///foo" but got "view-source+http://example.net/foo"
-FAIL : Setting .hostname = '' The empty host is OK for non-special schemes assert_equals: expected "view-source+http:///foo" but got "view-source+http://example.net/foo"
+PASS : Setting .hostname = '' The empty host is OK for non-special schemes
+PASS : Setting .hostname = '' The empty host is OK for non-special schemes
 PASS : Setting .hostname = 'example.net' Path-only URLs can gain a host
 PASS : Setting .hostname = 'example.net' Path-only URLs can gain a host
 PASS : Setting .hostname = '0x7F01' IPv4 address syntax is normalized
@@ -290,8 +290,8 @@
 PASS : Setting .hostname = ''
 PASS : Setting .hostname = 'h' Drop /. from path
 PASS : Setting .hostname = 'h' Drop /. from path
-FAIL : Setting .hostname = '' assert_equals: expected "non-spec:p" but got "non-spec:/.//p"
-FAIL : Setting .hostname = '' assert_equals: expected "non-spec:/

[webkit-changes] [279665] trunk/Tools

2021-07-07 Thread aakash_jain

Title: [279665] trunk/Tools








Revision 279665
Author aakash_j...@apple.com
Date 2021-07-07 13:50:19 -0700 (Wed, 07 Jul 2021)


Log Message
[build.webkit.org] Add unit-tests for RunWebKit1Tests
https://bugs.webkit.org/show_bug.cgi?id=227658

Reviewed by Alexey Proskuryakov.

* CISupport/build-webkit-org/steps_unittest.py:

Modified Paths

trunk/Tools/CISupport/build-webkit-org/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/build-webkit-org/steps_unittest.py (279664 => 279665)

--- trunk/Tools/CISupport/build-webkit-org/steps_unittest.py	2021-07-07 20:39:26 UTC (rev 279664)
+++ trunk/Tools/CISupport/build-webkit-org/steps_unittest.py	2021-07-07 20:50:19 UTC (rev 279665)
@@ -911,6 +911,71 @@
 return self.runStep()
 
 
+class TestRunWebKit1Tests(BuildStepMixinAdditions, unittest.TestCase):
+def setUp(self):
+self.longMessage = True
+self.jsonFileName = 'layout-test-results/full_results.json'
+os.environ['RESULTS_SERVER_API_KEY'] = 'test-api-key'
+return self.setUpBuildStep()
+
+def tearDown(self):
+del os.environ['RESULTS_SERVER_API_KEY']
+return self.tearDownBuildStep()
+
+def configureStep(self):
+self.setupStep(RunWebKit1Tests())
+self.setProperty('buildername', 'Apple-iOS-14-Simulator-Debug-Build')
+self.setProperty('buildnumber', '101')
+self.setProperty('workername', 'bot100')
+
+def test_success(self):
+self.configureStep()
+self.setProperty('fullPlatform', 'ios-simulator')
+self.setProperty('configuration', 'debug')
+self.expectRemoteCommands(
+ExpectShell(
+workdir='wkdir',
+logEnviron=False,
+command=['python', './Tools/Scripts/run-webkit-tests', '--no-build', '--no-show-results',
+ '--no-new-test-results', '--clobber-old-results',
+ '--builder-name', 'Apple-iOS-14-Simulator-Debug-Build',
+ '--build-number', '101', '--buildbot-worker', 'bot100',
+ '--buildbot-master', CURRENT_HOSTNAME,
+ '--report', RESULTS_WEBKIT_URL,
+ '--exit-after-n-crashes-or-timeouts', '50',
+ '--exit-after-n-failures', '500',
+ '--debug', '--dump-render-tree', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
+env={'RESULTS_SERVER_API_KEY': 'test-api-key'}
+) + 0,
+)
+self.expectOutcome(result=SUCCESS, state_string='layout-tests')
+return self.runStep()
+
+def test_failure(self):
+self.configureStep()
+self.setProperty('fullPlatform', 'ios-14')
+self.setProperty('configuration', 'release')
+self.expectRemoteCommands(
+ExpectShell(
+workdir='wkdir',
+logEnviron=False,
+command=['python', './Tools/Scripts/run-webkit-tests', '--no-build', '--no-show-results',
+ '--no-new-test-results', '--clobber-old-results',
+ '--builder-name', 'Apple-iOS-14-Simulator-Debug-Build',
+ '--build-number', '101', '--buildbot-worker', 'bot100',
+ '--buildbot-master', CURRENT_HOSTNAME,
+ '--report', RESULTS_WEBKIT_URL,
+ '--exit-after-n-crashes-or-timeouts', '50',
+ '--exit-after-n-failures', '500',
+ '--release', '--dump-render-tree', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
+env={'RESULTS_SERVER_API_KEY': 'test-api-key'}
+) + ExpectShell.log('stdio', stdout='9 failures found.')
++ 2,
+)
+self.expectOutcome(result=FAILURE, state_string='layout-tests (failure)')
+return self.runStep()
+
+
 class TestRunJavaScriptCoreTests(BuildStepMixinAdditions, unittest.TestCase):
 def setUp(self):
 self.longMessage = True


Modified: trunk/Tools/ChangeLog (279664 => 279665)

--- trunk/Tools/ChangeLog	2021-07-07 20:39:26 UTC (rev 279664)
+++ trunk/Tools/ChangeLog	2021-07-07 20:50:19 UTC (rev 279665)
@@ -1,3 +1,12 @@
+2021-07-07  Aakash Jain  
+
+[build.webkit.org] Add unit-tests for RunWebKit1Tests
+https://bugs.webkit.org/show_bug.cgi?id=227658
+
+Reviewed by Alexey Proskuryakov.
+
+* CISupport/build-webkit-org/steps_unittest.py:
+
 2021-07-06  Harshil Ratnu  
 
 Add myself (Harshil Ratnu) to contributors.json






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279664] branches/safari-612.1.22.0-branch/Source/WebKit

2021-07-07 Thread rubent_22

Title: [279664] branches/safari-612.1.22.0-branch/Source/WebKit








Revision 279664
Author rubent...@apple.com
Date 2021-07-07 13:39:26 -0700 (Wed, 07 Jul 2021)


Log Message
Cherry-pick r279591. rdar://problem/80282918

Collect Accessibility preferences on a background queue
https://bugs.webkit.org/show_bug.cgi?id=227617


Reviewed by Brent Fulgham.

To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
and send them to the WebContent process(es).

* Shared/AccessibilityPreferences.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Shared/AccessibilityPreferences.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
(WebKit::WebProcessPool::registerNotificationObservers):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* UIProcess/WebProcessPool.h:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):
(WebKit::WebProcess::setMediaAccessibilityPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.22.0-branch/Source/WebKit/ChangeLog
branches/safari-612.1.22.0-branch/Source/WebKit/Shared/AccessibilityPreferences.cpp
branches/safari-612.1.22.0-branch/Source/WebKit/Shared/AccessibilityPreferences.h
branches/safari-612.1.22.0-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-612.1.22.0-branch/Source/WebKit/UIProcess/WebProcessPool.cpp
branches/safari-612.1.22.0-branch/Source/WebKit/UIProcess/WebProcessPool.h
branches/safari-612.1.22.0-branch/Source/WebKit/WebProcess/WebProcess.h
branches/safari-612.1.22.0-branch/Source/WebKit/WebProcess/WebProcess.messages.in
branches/safari-612.1.22.0-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-612.1.22.0-branch/Source/WebKit/ChangeLog (279663 => 279664)

--- branches/safari-612.1.22.0-branch/Source/WebKit/ChangeLog	2021-07-07 20:39:21 UTC (rev 279663)
+++ branches/safari-612.1.22.0-branch/Source/WebKit/ChangeLog	2021-07-07 20:39:26 UTC (rev 279664)
@@ -1,5 +1,68 @@
 2021-07-07  Ruben Turcios  
 
+Cherry-pick r279591. rdar://problem/80282918
+
+Collect Accessibility preferences on a background queue
+https://bugs.webkit.org/show_bug.cgi?id=227617
+
+
+Reviewed by Brent Fulgham.
+
+To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
+and send them to the WebContent process(es).
+
+* Shared/AccessibilityPreferences.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
+(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+(WebKit::WebProcess::setMediaAccessibilityPreferences):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-06  Per Arne  
+
+Collect Accessibility preferences on a background queue
+https://bugs.webkit.org/show_bug.cgi?id=227617
+
+
+Reviewed by Brent Fulgham.
+
+To avoid blocking the main thread of the UI process, collect Media Accessibility preferences on a background thread,
+and send them to the WebContent process(es).
+
+* Shared/AccessibilityPreferences.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
+(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/Web

[webkit-changes] [279663] branches/safari-612.1.22.0-branch/Source/WebKit

2021-07-07 Thread rubent_22

Title: [279663] branches/safari-612.1.22.0-branch/Source/WebKit








Revision 279663
Author rubent...@apple.com
Date 2021-07-07 13:39:21 -0700 (Wed, 07 Jul 2021)


Log Message
Cherry-pick r279342. rdar://problem/80282918

Pass correct value of AX per app settings to the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=227441


Reviewed by Brent Fulgham.

Pass value of type AXValueState instead of a boolean value for per app AX settings.

* Shared/AccessibilityPreferences.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.22.0-branch/Source/WebKit/ChangeLog
branches/safari-612.1.22.0-branch/Source/WebKit/Shared/AccessibilityPreferences.h
branches/safari-612.1.22.0-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-612.1.22.0-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-612.1.22.0-branch/Source/WebKit/ChangeLog (279662 => 279663)

--- branches/safari-612.1.22.0-branch/Source/WebKit/ChangeLog	2021-07-07 20:20:06 UTC (rev 279662)
+++ branches/safari-612.1.22.0-branch/Source/WebKit/ChangeLog	2021-07-07 20:39:21 UTC (rev 279663)
@@ -1,3 +1,40 @@
+2021-07-07  Ruben Turcios  
+
+Cherry-pick r279342. rdar://problem/80282918
+
+Pass correct value of AX per app settings to the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=227441
+
+
+Reviewed by Brent Fulgham.
+
+Pass value of type AXValueState instead of a boolean value for per app AX settings.
+
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-28  Per Arne  
+
+Pass correct value of AX per app settings to the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=227441
+
+
+Reviewed by Brent Fulgham.
+
+Pass value of type AXValueState instead of a boolean value for per app AX settings.
+
+* Shared/AccessibilityPreferences.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::accessibilityPreferences):
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+
 2021-06-30  Alan Coon  
 
 Cherry-pick r279411. rdar://problem/79970312


Modified: branches/safari-612.1.22.0-branch/Source/WebKit/Shared/AccessibilityPreferences.h (279662 => 279663)

--- branches/safari-612.1.22.0-branch/Source/WebKit/Shared/AccessibilityPreferences.h	2021-07-07 20:20:06 UTC (rev 279662)
+++ branches/safari-612.1.22.0-branch/Source/WebKit/Shared/AccessibilityPreferences.h	2021-07-07 20:39:21 UTC (rev 279663)
@@ -31,15 +31,19 @@
 #include 
 #endif
 
+#if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
+#include "AccessibilitySupportSPI.h"
+#endif
+
 namespace WebKit {
 
 struct AccessibilityPreferences {
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
-bool reduceMotionEnabled { false };
-bool increaseButtonLegibility { false };
-bool enhanceTextLegibility { false };
-bool darkenSystemColors { false };
-bool invertColorsEnabled { false };
+AXValueState reduceMotionEnabled { AXValueStateEmpty };
+AXValueState increaseButtonLegibility { AXValueStateEmpty };
+AXValueState enhanceTextLegibility { AXValueStateEmpty };
+AXValueState darkenSystemColors { AXValueStateEmpty };
+AXValueState invertColorsEnabled { AXValueStateEmpty };
 #endif
 #if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
 WebCore::CaptionUserPreferences::CaptionDisplayMode captionDisplayMode;
@@ -55,3 +59,19 @@
 static std::optional decode(Decoder&);
 };
 }
+
+#if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
+namespace WTF {
+
+template<> struct EnumTraits {
+using values = EnumValues<
+AXValueState,
+AXValueState::AXValueStateInvalid,
+AXValueState::AXValueStateEmpty,
+AXValueState::AXValueStateOff,
+AXValueState::AXValueStateOn
+>;
+};
+
+} // namespace WTF
+#endif


Modified: branches/safari-612.1.22.0-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (279662 => 279663)

--- branches/safari-612.1.22.0-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-07-07 20:20:06 UTC (rev 279662)
+++ branches/safari-612.1.22.0-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-07-07 20:39:21 UTC (rev 279663)
@@ -279,11 +279,11 @@
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
 auto appId = WebCore::

[webkit-changes] [279662] trunk

2021-07-07 Thread achristensen

Title: [279662] trunk








Revision 279662
Author achristen...@apple.com
Date 2021-07-07 13:20:06 -0700 (Wed, 07 Jul 2021)


Log Message
URL path setter should add "./" before non-empty path and after empty host for URLs with non-special schemes
https://bugs.webkit.org/show_bug.cgi?id=227750

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/url/url-setters-a-area.window-expected.txt:
* web-platform-tests/url/url-setters.any-expected.txt:
* web-platform-tests/url/url-setters.any.worker-expected.txt:

Source/WTF:

This is related to r267837 but in the path setter, too.
This helps preserve idempotence in parsed URLs.
This is an edge case that will rarely be hit in practice, but now the path setter matches the parser.

* wtf/URL.cpp:
(WTF::URL::setPath):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URL.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279661 => 279662)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 19:57:03 UTC (rev 279661)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-07 20:20:06 UTC (rev 279662)
@@ -1,3 +1,14 @@
+2021-07-07  Alex Christensen  
+
+URL path setter should add "./" before non-empty path and after empty host for URLs with non-special schemes
+https://bugs.webkit.org/show_bug.cgi?id=227750
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/url/url-setters-a-area.window-expected.txt:
+* web-platform-tests/url/url-setters.any-expected.txt:
+* web-platform-tests/url/url-setters.any.worker-expected.txt:
+
 2021-07-07  Chris Dumez  
 
 REGRESSION (r279427): [ Mac wk2 ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/import-css-module-basic.html is a flaky failure


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt (279661 => 279662)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt	2021-07-07 19:57:03 UTC (rev 279661)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt	2021-07-07 20:20:06 UTC (rev 279662)
@@ -378,8 +378,8 @@
 PASS : Setting .pathname = '/.//p' Serialize /. in path
 PASS : Setting .pathname = '/..//p'
 PASS : Setting .pathname = '/..//p'
-FAIL : Setting .pathname = '//p' assert_equals: expected "non-spec:/.//p" but got "non-spec://p"
-FAIL : Setting .pathname = '//p' assert_equals: expected "non-spec:/.//p" but got "non-spec://p"
+PASS : Setting .pathname = '//p'
+PASS : Setting .pathname = '//p'
 PASS : Setting .pathname = 'p' Drop /. from path
 PASS : Setting .pathname = 'p' Drop /. from path
 PASS : Setting .search = 'lang=fr'


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt (279661 => 279662)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt	2021-07-07 19:57:03 UTC (rev 279661)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt	2021-07-07 20:20:06 UTC (rev 279662)
@@ -189,7 +189,7 @@
 PASS URL: Setting .pathname = '//monkey/..//' File URLs and (back)slashes
 PASS URL: Setting .pathname = '/.//p' Serialize /. in path
 PASS URL: Setting .pathname = '/..//p'
-FAIL URL: Setting .pathname = '//p' assert_equals: expected "non-spec:/.//p" but got "non-spec://p"
+PASS URL: Setting .pathname = '//p'
 PASS URL: Setting .pathname = 'p' Drop /. from path
 PASS URL: Setting .search = 'lang=fr'
 PASS URL: Setting .search = 'lang=fr'


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt (279661 => 279662)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt	2021-07-07 19:57:03 UTC (rev 279661)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt	2021-07-07 20:20:06 UTC (rev 279662)
@@ -189,7 +189,7 @@
 PASS URL: Setting .pathname = '//monkey/..//' File URLs and (back)slashes
 PASS URL: Setting .pathname = '/.//p' Serialize /. in path
 PASS URL: Setting .pathname = '/..//p'
-FAIL URL: Setting .pathname = '//p' assert_equals: expected "non-spec:/.//p" but got "non-spec://p"
+PASS URL: Setting .pathname = '//p'
 PASS URL: Setting .pathname = 'p' Drop /. from path
 PASS URL: Setting .search = 'lang=fr'
 PASS URL: Setting .search = 'lang=fr'


Modified: trunk/Source/WTF/ChangeLog (279661 => 279662)

--- trunk/Source/WTF/ChangeLog	2021-07-07 19:57:03 UTC (rev 279661)
+++ trunk/Source/WTF/ChangeLog	2021-07-07 20:20:06 UTC (rev 279662)
@@ -1,3 +1,17 @@
+2021-07-07  Alex Christensen  
+
+URL path setter should add "

[webkit-changes] [279661] trunk/Source/WebCore

2021-07-07 Thread rniwa

Title: [279661] trunk/Source/WebCore








Revision 279661
Author rn...@webkit.org
Date 2021-07-07 12:57:03 -0700 (Wed, 07 Jul 2021)


Log Message
Deploy smart pointers in DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=227584

Reviewed by David Kilzer.

Deployed Ref/RefPtr in more places in DOMWindow.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::performance const):
(WebCore::DOMWindow::shouldHaveWebKitNamespaceForWorld):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::frameElement const):
(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::blur):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::print):
(WebCore::DOMWindow::stop):
(WebCore::DOMWindow::alert):
(WebCore::DOMWindow::confirmForBindings):
(WebCore::DOMWindow::prompt):
(WebCore::DOMWindow::outerHeight const):
(WebCore::DOMWindow::outerWidth const):
(WebCore::DOMWindow::innerHeight const):
(WebCore::DOMWindow::innerWidth const):
(WebCore::DOMWindow::screenX const):
(WebCore::DOMWindow::screenY const):
(WebCore::DOMWindow::scrollX const):
(WebCore::DOMWindow::scrollY const):
(WebCore::DOMWindow::closed const):
(WebCore::DOMWindow::name const):
(WebCore::DOMWindow::setName):
(WebCore::DOMWindow::setStatus):
(WebCore::DOMWindow::setDefaultStatus):
(WebCore::DOMWindow::opener const):
(WebCore::DOMWindow::disownOpener):
(WebCore::DOMWindow::parent const):
(WebCore::DOMWindow::top const):
(WebCore::DOMWindow::consumeTransientActivation):
(WebCore::DOMWindow::notifyActivated):
(WebCore::DOMWindow::getMatchedCSSRules const):
(WebCore::DOMWindow::scrollBy const):
(WebCore::DOMWindow::allowedToChangeWindowGeometry const):
(WebCore::DOMWindow::setTimeout):
(WebCore::DOMWindow::clearTimeout):
(WebCore::DOMWindow::setInterval):
(WebCore::DOMWindow::requestAnimationFrame):
(WebCore::DOMWindow::cancelAnimationFrame):
(WebCore::DOMWindow::createImageBitmap):
(WebCore::DOMWindow::isSecureContext const):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::startListeningForDeviceOrientationIfNecessary):
(WebCore::DOMWindow::startListeningForDeviceMotionIfNecessary):
(WebCore::DOMWindow::incrementScrollEventListenersCount):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::dispatchLoadEvent):
(WebCore::DOMWindow::removeAllEventListeners):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):
(WebCore::DOMWindow::showModalDialog):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (279660 => 279661)

--- trunk/Source/WebCore/ChangeLog	2021-07-07 19:54:06 UTC (rev 279660)
+++ trunk/Source/WebCore/ChangeLog	2021-07-07 19:57:03 UTC (rev 279661)
@@ -1,3 +1,66 @@
+2021-07-07  Ryosuke Niwa  
+
+Deploy smart pointers in DOMWindow
+https://bugs.webkit.org/show_bug.cgi?id=227584
+
+Reviewed by David Kilzer.
+
+Deployed Ref/RefPtr in more places in DOMWindow.
+
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::performance const):
+(WebCore::DOMWindow::shouldHaveWebKitNamespaceForWorld):
+(WebCore::DOMWindow::postMessage):
+(WebCore::DOMWindow::frameElement const):
+(WebCore::DOMWindow::focus):
+(WebCore::DOMWindow::blur):
+(WebCore::DOMWindow::close):
+(WebCore::DOMWindow::print):
+(WebCore::DOMWindow::stop):
+(WebCore::DOMWindow::alert):
+(WebCore::DOMWindow::confirmForBindings):
+(WebCore::DOMWindow::prompt):
+(WebCore::DOMWindow::outerHeight const):
+(WebCore::DOMWindow::outerWidth const):
+(WebCore::DOMWindow::innerHeight const):
+(WebCore::DOMWindow::innerWidth const):
+(WebCore::DOMWindow::screenX const):
+(WebCore::DOMWindow::screenY const):
+(WebCore::DOMWindow::scrollX const):
+(WebCore::DOMWindow::scrollY const):
+(WebCore::DOMWindow::closed const):
+(WebCore::DOMWindow::name const):
+(WebCore::DOMWindow::setName):
+(WebCore::DOMWindow::setStatus):
+(WebCore::DOMWindow::setDefaultStatus):
+(WebCore::DOMWindow::opener const):
+(WebCore::DOMWindow::disownOpener):
+(WebCore::DOMWindow::parent const):
+(WebCore::DOMWindow::top const):
+(WebCore::DOMWindow::consumeTransientActivation):
+(WebCore::DOMWindow::notifyActivated):
+(WebCore::DOMWindow::getMatchedCSSRules const):
+(WebCore::DOMWindow::scrollBy const):
+(WebCore::DOMWindow::allowedToChangeWindowGeometry const):
+(WebCore::DOMWindow::setTimeout):
+(WebCore::DOMWindow::clearTimeout):
+(WebCore::DOMWindow::setInterval):
+(WebCore::DOMWindow::requestAnimationFrame):
+(WebCore::DOMWindow::cancelAnimationFrame):
+(WebCore::DOMWindow::createImageBitmap):
+(WebCore::DOMWindow::isSecureContext const):
+(WebCore::DOMWindow::addEventListener):
+(WebCore::DOMWindow::startListeningForDeviceO

[webkit-changes] [279660] trunk/Source

2021-07-07 Thread chris . reid

Title: [279660] trunk/Source








Revision 279660
Author chris.r...@sony.com
Date 2021-07-07 12:54:06 -0700 (Wed, 07 Jul 2021)


Log Message
[PlayStation] Don't assume 4KB block size when estimating Network Cache disk usage
https://bugs.webkit.org/show_bug.cgi?id=227502

Reviewed by Chris Dumez.

Source/WebKit:

Network Cache disk usage can underestimate the real disk usage on platforms
with file blocks larger than 4 KB.
Adding call to FileSystem::getVolumeFileBlockSize to use the FileSystem's
block size in the estimation.

* NetworkProcess/cache/NetworkCacheStorage.cpp:
* NetworkProcess/cache/NetworkCacheStorage.h:

Source/WTF:

Add getVolumeFileBlockSize to fetch the block size from the filesystem.
Currently only implemented for Windows and POSIX filesystems.

* wtf/FileSystem.cpp:
* wtf/FileSystem.h:
* wtf/playstation/FileSystemPlayStation.cpp:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FileSystem.h
trunk/Source/WTF/wtf/glib/FileSystemGlib.cpp
trunk/Source/WTF/wtf/posix/FileSystemPOSIX.cpp
trunk/Source/WTF/wtf/win/FileSystemWin.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h




Diff

Modified: trunk/Source/WTF/ChangeLog (279659 => 279660)

--- trunk/Source/WTF/ChangeLog	2021-07-07 19:46:08 UTC (rev 279659)
+++ trunk/Source/WTF/ChangeLog	2021-07-07 19:54:06 UTC (rev 279660)
@@ -1,3 +1,17 @@
+2021-07-07  Christopher Reid  
+
+[PlayStation] Don't assume 4KB block size when estimating Network Cache disk usage
+https://bugs.webkit.org/show_bug.cgi?id=227502
+
+Reviewed by Chris Dumez.
+
+Add getVolumeFileBlockSize to fetch the block size from the filesystem.
+Currently only implemented for Windows and POSIX filesystems.
+
+* wtf/FileSystem.cpp:
+* wtf/FileSystem.h:
+* wtf/playstation/FileSystemPlayStation.cpp:
+
 2021-07-07  Alex Christensen  
 
 Use more Span


Modified: trunk/Source/WTF/wtf/FileSystem.h (279659 => 279660)

--- trunk/Source/WTF/wtf/FileSystem.h	2021-07-07 19:46:08 UTC (rev 279659)
+++ trunk/Source/WTF/wtf/FileSystem.h	2021-07-07 19:54:06 UTC (rev 279660)
@@ -123,6 +123,7 @@
 WTF_EXPORT_PRIVATE String pathFileName(const String&);
 WTF_EXPORT_PRIVATE String parentPath(const String&);
 WTF_EXPORT_PRIVATE std::optional volumeFreeSpace(const String&);
+WTF_EXPORT_PRIVATE std::optional volumeFileBlockSize(const String&);
 WTF_EXPORT_PRIVATE std::optional getFileDeviceId(const CString&);
 WTF_EXPORT_PRIVATE bool createSymbolicLink(const String& targetPath, const String& symbolicLinkPath);
 WTF_EXPORT_PRIVATE String createTemporaryZipArchive(const String& directory);


Modified: trunk/Source/WTF/wtf/glib/FileSystemGlib.cpp (279659 => 279660)

--- trunk/Source/WTF/wtf/glib/FileSystemGlib.cpp	2021-07-07 19:46:08 UTC (rev 279659)
+++ trunk/Source/WTF/wtf/glib/FileSystemGlib.cpp	2021-07-07 19:54:06 UTC (rev 279660)
@@ -246,6 +246,11 @@
 return g_file_info_get_attribute_uint32(fileInfo.get(), G_FILE_ATTRIBUTE_UNIX_DEVICE);
 }
 
+std::optional volumeFileBlockSize(const String&)
+{
+return std::nullopt;
+}
+
 #if USE(FILE_LOCK)
 bool lockFile(PlatformFileHandle handle, OptionSet lockMode)
 {


Modified: trunk/Source/WTF/wtf/posix/FileSystemPOSIX.cpp (279659 => 279660)

--- trunk/Source/WTF/wtf/posix/FileSystemPOSIX.cpp	2021-07-07 19:46:08 UTC (rev 279659)
+++ trunk/Source/WTF/wtf/posix/FileSystemPOSIX.cpp	2021-07-07 19:54:06 UTC (rev 279660)
@@ -184,6 +184,15 @@
 #endif
 }
 
+std::optional volumeFileBlockSize(const String& path)
+{
+struct statvfs fileStat;
+if (!statvfs(fileSystemRepresentation(path).data(), &fileStat))
+return fileStat.f_frsize;
+
+return std::nullopt;
+}
+
 #if !USE(CF)
 String stringFromFileSystemRepresentation(const char* path)
 {


Modified: trunk/Source/WTF/wtf/win/FileSystemWin.cpp (279659 => 279660)

--- trunk/Source/WTF/wtf/win/FileSystemWin.cpp	2021-07-07 19:46:08 UTC (rev 279659)
+++ trunk/Source/WTF/wtf/win/FileSystemWin.cpp	2021-07-07 19:54:06 UTC (rev 279660)
@@ -363,6 +363,15 @@
 });
 }
 
+std::optional volumeFileBlockSize(const String& path)
+{
+DWORD sectorsPerCluster, bytesPerSector, freeClusters, totalClusters;
+if (!GetDiskFreeSpaceW(path.wideCharacters().data(), §orsPerCluster, &bytesPerSector, &freeClusters, &totalClusters))
+return std::nullopt;
+
+return sectorsPerCluster * bytesPerSector;
+}
+
 MappedFileData::~MappedFileData()
 {
 if (m_fileData)


Modified: trunk/Source/WebKit/ChangeLog (279659 => 279660)

--- trunk/Source/WebKit/ChangeLog	2021-07-07 19:46:08 UTC (rev 279659)
+++ trunk/Source/WebKit/ChangeLog	2021-07-07 19:54:06 UTC (rev 279660)
@@ -1,3 +1,18 @@
+2021-07-07  Christopher Reid  
+
+[PlayStation] Don't assume 4KB block size when estimating Network Cache disk usage
+https://bugs.webkit.org/show_bug.cgi?id=227502
+
+Reviewed by Chris Dumez.
+
+Network Cac

[webkit-changes] [279659] trunk

2021-07-07 Thread akeerthi

Title: [279659] trunk








Revision 279659
Author akeer...@apple.com
Date 2021-07-07 12:46:08 -0700 (Wed, 07 Jul 2021)


Log Message
[iOS] Inconsistent styling for input[type="submit"] and button[type="submit"]
https://bugs.webkit.org/show_bug.cgi?id=227043


Reviewed by Wenson Hsieh.

Source/WebCore:

In iOS 15, submit buttons have a different appearance from standard
buttons, matching UIKit's "preferred" button style.

Previously, all buttons had the same styling, which meant that
input[type="submit"] and button[type="submit"] had the same
appearance by default. The changes made for iOS 15 were applied to
input[type="submit"], but not button[type="submit"], leading to
inconsistent styling.

Test: fast/forms/ios/form-control-refresh/button/button-type-submit.html

* css/html.css:

Ensure the different style applied to input[type="submit"] also applies
to button[type="submit"].

Additionally, apply the new style to button[type="menu"]. This type is
unsupported, but should have the same appearance as a submit button,
according to the button-type-menu-historical.html web platform test.

LayoutTests:

Added a reference test to verify that input[type="submit"] and
button[type="submit"] have the same appearance.

* fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html: Added.
* fast/forms/ios/form-control-refresh/button/button-type-submit.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css


Added Paths

trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/
trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html
trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279658 => 279659)

--- trunk/LayoutTests/ChangeLog	2021-07-07 19:43:49 UTC (rev 279658)
+++ trunk/LayoutTests/ChangeLog	2021-07-07 19:46:08 UTC (rev 279659)
@@ -1,3 +1,17 @@
+2021-07-07  Aditya Keerthi  
+
+[iOS] Inconsistent styling for input[type="submit"] and button[type="submit"]
+https://bugs.webkit.org/show_bug.cgi?id=227043
+
+
+Reviewed by Wenson Hsieh.
+
+Added a reference test to verify that input[type="submit"] and
+button[type="submit"] have the same appearance.
+
+* fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html: Added.
+* fast/forms/ios/form-control-refresh/button/button-type-submit.html: Added.
+
 2021-07-07  Commit Queue  
 
 Unreviewed, reverting r279271.


Added: trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html (0 => 279659)

--- trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html	2021-07-07 19:46:08 UTC (rev 279659)
@@ -0,0 +1,9 @@
+ 
+
+
+
+
+
+
+
+


Added: trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html (0 => 279659)

--- trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html	2021-07-07 19:46:08 UTC (rev 279659)
@@ -0,0 +1,9 @@
+ 
+
+
+
+
+
+Submit
+
+


Modified: trunk/Source/WebCore/ChangeLog (279658 => 279659)

--- trunk/Source/WebCore/ChangeLog	2021-07-07 19:43:49 UTC (rev 279658)
+++ trunk/Source/WebCore/ChangeLog	2021-07-07 19:46:08 UTC (rev 279659)
@@ -1,3 +1,31 @@
+2021-07-07  Aditya Keerthi  
+
+[iOS] Inconsistent styling for input[type="submit"] and button[type="submit"]
+https://bugs.webkit.org/show_bug.cgi?id=227043
+
+
+Reviewed by Wenson Hsieh.
+
+In iOS 15, submit buttons have a different appearance from standard
+buttons, matching UIKit's "preferred" button style.
+
+Previously, all buttons had the same styling, which meant that
+input[type="submit"] and button[type="submit"] had the same
+appearance by default. The changes made for iOS 15 were applied to
+input[type="submit"], but not button[type="submit"], leading to
+inconsistent styling.
+
+Test: fast/forms/ios/form-control-refresh/button/button-type-submit.html
+
+* css/html.css:
+
+Ensure the different style applied to input[type="submit"] also applies
+to button[type="submit"].
+
+Additionally, apply the new style to button[type="menu"]. This type is
+unsupported, but should have the same appearance as a submit button,
+according to the button-type-menu-historical.html web platform test.
+
 2021-07-07  Fujii Hironori  
 
 [Cairo] Merge PlatformContextCairo into GraphicsContextCairo


Modified: trunk/Source/WebCore/css/html.css (279658 => 279659)

--- trunk/Source/WebCore/css/html.css	2021-07-0

[webkit-changes] [279658] trunk/Source

2021-07-07 Thread Hironori . Fujii

Title: [279658] trunk/Source








Revision 279658
Author hironori.fu...@sony.com
Date 2021-07-07 12:43:49 -0700 (Wed, 07 Jul 2021)


Log Message
[Cairo] Merge PlatformContextCairo into GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=227721

Reviewed by Don Olmstead.

Source/WebCore:

PlatformContextCairo was introduced to separate Cairo specific
code from the platform-independent GraphicsContext class. However,
GraphicsContext is a abstract class since r278062. And,
GraphicsContextCairo is a Cairo specific concrete class.

Some modifications are needed to merge PlatformContextCairo into
GraphicsContextCairo. Renamed m_state to m_cairoState. Renamed
save() and restore() to saveInternal() and restoreInternal().

* platform/Cairo.cmake:
* platform/SourcesCairo.txt:
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawShadowLayerBuffer):
(WebCore::Cairo::drawShadowImage):
(WebCore::Cairo::fillShadowBuffer):
(WebCore::Cairo::drawPathShadow):
(WebCore::Cairo::fillCurrentCairoPath):
(WebCore::Cairo::drawGlyphsShadow):
(WebCore::Cairo::computeLineBoundsAndAntialiasingModeForText):
(WebCore::Cairo::State::setStrokeThickness):
(WebCore::Cairo::State::setStrokeStyle):
(WebCore::Cairo::State::setCompositeOperation):
(WebCore::Cairo::State::setShouldAntialias):
(WebCore::Cairo::State::setCTM):
(WebCore::Cairo::State::getCTM):
(WebCore::Cairo::State::getClipBounds):
(WebCore::Cairo::State::roundToDevicePixels):
(WebCore::Cairo::State::isAcceleratedContext):
(WebCore::Cairo::ShadowState::isRequired const):
(WebCore::Cairo::setLineCap):
(WebCore::Cairo::setLineDash):
(WebCore::Cairo::setLineJoin):
(WebCore::Cairo::setMiterLimit):
(WebCore::Cairo::fillRect):
(WebCore::Cairo::fillRoundedRect):
(WebCore::Cairo::fillRectWithRoundedHole):
(WebCore::Cairo::fillPath):
(WebCore::Cairo::strokeRect):
(WebCore::Cairo::strokePath):
(WebCore::Cairo::clearRect):
(WebCore::Cairo::drawGlyphs):
(WebCore::Cairo::drawPlatformImage):
(WebCore::Cairo::drawPattern):
(WebCore::Cairo::drawSurface):
(WebCore::Cairo::drawRect):
(WebCore::Cairo::drawLine):
(WebCore::Cairo::drawLinesForText):
(WebCore::Cairo::drawDotsForDocumentMarker):
(WebCore::Cairo::drawEllipse):
(WebCore::Cairo::drawFocusRing):
(WebCore::Cairo::save):
(WebCore::Cairo::restore):
(WebCore::Cairo::translate):
(WebCore::Cairo::rotate):
(WebCore::Cairo::scale):
(WebCore::Cairo::concatCTM):
(WebCore::Cairo::beginTransparencyLayer):
(WebCore::Cairo::endTransparencyLayer):
(WebCore::Cairo::clip):
(WebCore::Cairo::clipOut):
(WebCore::Cairo::clipPath):
(WebCore::Cairo::clipToImageBuffer):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/FontCairo.cpp:
* platform/graphics/cairo/GradientCairo.cpp:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContextCairo::GraphicsContextCairo):
(WebCore::GraphicsContextCairo::platformContext const):
(WebCore::GraphicsContextCairo::save):
(WebCore::GraphicsContextCairo::restore):
(WebCore::GraphicsContextCairo::drawRect):
(WebCore::GraphicsContextCairo::drawNativeImage):
(WebCore::GraphicsContextCairo::drawLine):
(WebCore::GraphicsContextCairo::drawEllipse):
(WebCore::GraphicsContextCairo::fillPath):
(WebCore::GraphicsContextCairo::strokePath):
(WebCore::GraphicsContextCairo::fillRect):
(WebCore::GraphicsContextCairo::clip):
(WebCore::GraphicsContextCairo::clipPath):
(WebCore::GraphicsContextCairo::clipToImageBuffer):
(WebCore::GraphicsContextCairo::drawFocusRing):
(WebCore::GraphicsContextCairo::drawLinesForText):
(WebCore::GraphicsContextCairo::drawDotsForDocumentMarker):
(WebCore::GraphicsContextCairo::roundToDevicePixels):
(WebCore::GraphicsContextCairo::translate):
(WebCore::GraphicsContextCairo::updateState):
(WebCore::GraphicsContextCairo::concatCTM):
(WebCore::GraphicsContextCairo::setCTM):
(WebCore::GraphicsContextCairo::beginTransparencyLayer):
(WebCore::GraphicsContextCairo::endTransparencyLayer):
(WebCore::GraphicsContextCairo::clearRect):
(WebCore::GraphicsContextCairo::strokeRect):
(WebCore::GraphicsContextCairo::setLineCap):
(WebCore::GraphicsContextCairo::setLineDash):
(WebCore::GraphicsContextCairo::setLineJoin):
(WebCore::GraphicsContextCairo::setMiterLimit):
(WebCore::GraphicsContextCairo::clipOut):
(WebCore::GraphicsContextCairo::rotate):
(WebCore::GraphicsContextCairo::scale):
(WebCore::GraphicsContextCairo::fillRoundedRectImpl):
(WebCore::GraphicsContextCairo::fillRectWithRoundedHole):
(WebCore::GraphicsContextCairo::drawPattern):
(WebCore::GraphicsContextCairo::drawGlyphs):
(WebCore::GraphicsContextCairo::cr const):
(WebCore::GraphicsContextCairo::layers):
(WebCore::GraphicsContextCairo::saveInternal):
(WebCore::GraphicsContextCairo::restoreInternal):
(WebCore::GraphicsContextCairo::pushImageMask):
(WebCore::GraphicsContextCairo::graphicsContextPrivate):
(WebCore::GraphicsContextCairo::~GraphicsContextCairo): Deleted.
* platform/graphics/cairo/GraphicsContextCairo.h:
* platform/graphics/cairo/GraphicsContextGLCairo.cpp:

[webkit-changes] [279657] trunk

2021-07-07 Thread commit-queue

Title: [279657] trunk








Revision 279657
Author commit-qu...@webkit.org
Date 2021-07-07 12:37:29 -0700 (Wed, 07 Jul 2021)


Log Message
Unreviewed, reverting r279271.
https://bugs.webkit.org/show_bug.cgi?id=227764

Gmail labels (folders) aren't visible on left side anymore

Reverted changeset:

"[css-flexbox] Do not clamp flex base size with
{min|max}-{height|width}"
https://bugs.webkit.org/show_bug.cgi?id=225590
https://commits.webkit.org/r279271

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (279656 => 279657)

--- trunk/LayoutTests/ChangeLog	2021-07-07 19:35:41 UTC (rev 279656)
+++ trunk/LayoutTests/ChangeLog	2021-07-07 19:37:29 UTC (rev 279657)
@@ -1,3 +1,17 @@
+2021-07-07  Commit Queue  
+
+Unreviewed, reverting r279271.
+https://bugs.webkit.org/show_bug.cgi?id=227764
+
+Gmail labels (folders) aren't visible on left side anymore
+
+Reverted changeset:
+
+"[css-flexbox] Do not clamp flex base size with
+{min|max}-{height|width}"
+https://bugs.webkit.org/show_bug.cgi?id=225590
+https://commits.webkit.org/r279271
+
 2021-07-07  Kyle Piddington  
 
 WebGL shader link error in iOS 15 beta: "Internal error compiling shader with Metal backend"


Modified: trunk/LayoutTests/TestExpectations (279656 => 279657)

--- trunk/LayoutTests/TestExpectations	2021-07-07 19:35:41 UTC (rev 279656)
+++ trunk/LayoutTests/TestExpectations	2021-07-07 19:37:29 UTC (rev 279657)
@@ -1305,7 +1305,6 @@
 webkit.org/b/136754 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-015.html [ ImageOnlyFailure ]
 webkit.org/b/136754 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-safe-overflow-position-001.html [ ImageOnlyFailure ]
 webkit.org/b/136754 imported/w3c/web-platform-tests/css/css-flexbox/percentage-max-height-002.html [ ImageOnlyFailure ]
-webkit.org/b/136754 imported/w3c/web-platform-tests/css/css-flexbox/percentage-max-height-003.html [ ImageOnlyFailure ]
 webkit.org/b/210243 imported/w3c/web-platform-tests/css/css-flexbox/percentage-size-quirks-002.html [ Failure ]
 webkit.org/b/136754 imported/w3c/web-platform-tests/css/css-flexbox/scrollbars-no-margin.html [ ImageOnlyFailure ]
 
@@ -4035,7 +4034,9 @@
 webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-srl-034.xht [ ImageOnlyFailure ]
 webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-srl-040.xht [ ImageOnlyFailure ]
 
+webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-012.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-015.html [ ImageOnlyFailure ]
+webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-007.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-010.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-002.html [ ImageOnlyFailure ]
 webkit.org/b/219343 imported/w3c/web-platform-tests/css/css-flexbox/aspect-ratio-intrinsic-size-004.html [ ImageOnlyFailure ]
@@ -4104,6 +4105,7 @@
 webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-1.html [ ImageOnlyFailure ]
 webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-2.html [ ImageOnlyFailure ]
 webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html [ ImageOnlyFailure ]
+webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-min-height-1.html [ ImageOnlyFailure ]
 
 # SVGs as flex items.
 webkit.org/b/221474 imported/w3c/web-platform-tests/css/css-flexbox/svg-root-as-flex-item-002.html [ ImageOnlyFailure ]


Modified: trunk/Source/WebCore/ChangeLog (279656 => 279657)

--- trunk/Source/WebCore/ChangeLog	2021-07-07 19:35:41 UTC (rev 279656)
+++ trunk/Source/WebCore/ChangeLog	2021-07-07 19:37:29 UTC (rev 279657)
@@ -1,3 +1,17 @@
+2021-07-07  Commit Queue  
+
+Unreviewed, reverting r279271.
+https://bugs.webkit.org/show_bug.cgi?id=227764
+
+Gmail labels (folders) aren't visible on left side anymore
+
+Reverted changeset:
+
+"[css-flexbox] Do not clamp flex base size with
+{min|max}-{height|width}"
+https://bugs.webkit.org/show_bug.cgi?id=225590
+https://commits.webkit.org/r279271
+
 2021-07-07  Alex Christensen  
 
 Use more Span


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (279656 => 279657)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2021-07-07 19:35:41 UTC (rev 279656)
+++ trunk/Source/WebCore

[webkit-changes] [279656] trunk

2021-07-07 Thread kpiddington

Title: [279656] trunk








Revision 279656
Author kpidding...@apple.com
Date 2021-07-07 12:35:41 -0700 (Wed, 07 Jul 2021)


Log Message
WebGL shader link error in iOS 15 beta: "Internal error compiling shader with Metal backend"
https://bugs.webkit.org/show_bug.cgi?id=227723

The sequence operator can be used to combine statements. Our initial
logic did not account for this.
Source/ThirdParty/ANGLE:

Reviewed by Dean Jackson.

* src/compiler/translator/TranslatorMetalDirect/SeparateCompoundExpressions.cpp:
(sh::Separator::isStandaloneExpr):

LayoutTests:

Reviewed by Dean Jackson.

* fast/canvas/webgl/shader-with-comma-op-expected.txt: Added.
* fast/canvas/webgl/shader-with-comma-op.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/SeparateCompoundExpressions.cpp


Added Paths

trunk/LayoutTests/fast/canvas/webgl/shader-with-comma-op-expected.txt
trunk/LayoutTests/fast/canvas/webgl/shader-with-comma-op.html




Diff

Modified: trunk/LayoutTests/ChangeLog (279655 => 279656)

--- trunk/LayoutTests/ChangeLog	2021-07-07 19:32:44 UTC (rev 279655)
+++ trunk/LayoutTests/ChangeLog	2021-07-07 19:35:41 UTC (rev 279656)
@@ -1,3 +1,16 @@
+2021-07-07  Kyle Piddington  
+
+WebGL shader link error in iOS 15 beta: "Internal error compiling shader with Metal backend"
+https://bugs.webkit.org/show_bug.cgi?id=227723
+
+The sequence operator can be used to combine statements. Our initial
+logic did not account for this. 
+
+Reviewed by Dean Jackson.
+
+* fast/canvas/webgl/shader-with-comma-op-expected.txt: Added.
+* fast/canvas/webgl/shader-with-comma-op.html: Added.
+
 2021-07-07  Arcady Goldmints-Orlov  
 
 [GLIB] Update test expectations after r279561


Added: trunk/LayoutTests/fast/canvas/webgl/shader-with-comma-op-expected.txt (0 => 279656)

--- trunk/LayoutTests/fast/canvas/webgl/shader-with-comma-op-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/shader-with-comma-op-expected.txt	2021-07-07 19:35:41 UTC (rev 279656)
@@ -0,0 +1,12 @@
+Tests compiling programs that use the 'sequence' operator..
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS getError was expected value: NO_ERROR : no error for using comma operator with void function
+PASS getError was expected value: NO_ERROR : no error for using comma operator with non-void  function
+PASS getError was expected value: NO_ERROR : no error for using comma operator with standard type
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/canvas/webgl/shader-with-comma-op.html (0 => 279656)

--- trunk/LayoutTests/fast/canvas/webgl/shader-with-comma-op.html	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/shader-with-comma-op.html	2021-07-07 19:35:41 UTC (rev 279656)
@@ -0,0 +1,60 @@
+
+
+
+
+
+
+
+
+
+
+