[webkit-changes] [280217] trunk/Source/WebKit

[drousso]

Title: [280217] trunk/Source/WebKit








Revision 280217
Author drou...@apple.com
Date 2021-07-22 20:20:56 -0700 (Thu, 22 Jul 2021)


Log Message
[Live Text] [iOS] Analysis should also search for any App Clip codes
https://bugs.webkit.org/show_bug.cgi?id=228207

Reviewed by Wenson Hsieh.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView imageAnalysisGestureDidBegin:]):
(-[WKContentView imageAnalysisGestureDidTimeOut:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (280216 => 280217)

--- trunk/Source/WebKit/ChangeLog	2021-07-23 03:17:51 UTC (rev 280216)
+++ trunk/Source/WebKit/ChangeLog	2021-07-23 03:20:56 UTC (rev 280217)
@@ -1,3 +1,14 @@
+2021-07-22  Devin Rousso  
+
+[Live Text] [iOS] Analysis should also search for any App Clip codes
+https://bugs.webkit.org/show_bug.cgi?id=228207
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView imageAnalysisGestureDidBegin:]):
+(-[WKContentView imageAnalysisGestureDidTimeOut:]):
+
 2021-07-22  Aditya Keerthi  
 
 [iOS] Unable to open arxiv links on Chrome


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (280216 => 280217)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2021-07-23 03:17:51 UTC (rev 280216)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2021-07-23 03:20:56 UTC (rev 280217)
@@ -10267,7 +10267,7 @@
 WebCore::ElementContext elementContext = *information.imageElementContext;
 
 auto requestForTextSelection = [strongSelf createImageAnalysisRequest:VKAnalysisTypeText image:image.get()];
-auto requestForContextMenu = [strongSelf createImageAnalysisRequest:VKAnalysisTypeVisualSearch | VKAnalysisTypeMachineReadableCode image:image.get()];
+auto requestForContextMenu = [strongSelf createImageAnalysisRequest:VKAnalysisTypeVisualSearch | VKAnalysisTypeMachineReadableCode | VKAnalysisTypeAppClip image:image.get()];
 
 auto textAnalysisStartTime = MonotonicTime::now();
 [[strongSelf imageAnalyzer] processRequest:requestForTextSelection.get() progressHandler:nil completionHandler:[requestIdentifier = WTFMove(requestIdentifier), weakSelf, elementContext, requestLocation, requestForContextMenu, gestureDeferralToken, textAnalysisStartTime] (VKImageAnalysis *result, NSError *error) mutable {
@@ -10320,7 +10320,7 @@
 UNUSED_PARAM(hasTextResults);
 #endif
 #if USE(UICONTEXTMENU)
-strongSelf->_contextMenuForMachineReadableCode = [result hasResultsForAnalysisTypes:VKAnalysisTypeMachineReadableCode] ? result.mrcMenu : nil;
+strongSelf->_contextMenuForMachineReadableCode = [result hasResultsForAnalysisTypes:VKAnalysisTypeMachineReadableCode | VKAnalysisTypeAppClip] ? result.mrcMenu : nil;
 #endif
 [strongSelf _invokeAllActionsToPerformAfterPendingImageAnalysis:WebKit::ProceedWithTextSelectionInImage::No];
 }];
@@ -10372,7 +10372,7 @@
 // making redundant image analysis requests for the same image data.
 
 auto visualSearchAnalysisStartTime = MonotonicTime::now();
-auto requestForContextMenu = [strongSelf createImageAnalysisRequest:VKAnalysisTypeVisualSearch | VKAnalysisTypeMachineReadableCode image:image.get()];
+auto requestForContextMenu = [strongSelf createImageAnalysisRequest:VKAnalysisTypeVisualSearch | VKAnalysisTypeMachineReadableCode | VKAnalysisTypeAppClip image:image.get()];
 [[strongSelf imageAnalyzer] processRequest:requestForContextMenu.get() progressHandler:nil completionHandler:[weakSelf, location, visualSearchAnalysisStartTime] (VKImageAnalysis *result, NSError *error) {
 auto strongSelf = weakSelf.get();
 if (!strongSelf)
@@ -10388,7 +10388,7 @@
 #endif
 
 #if USE(UICONTEXTMENU)
-strongSelf->_contextMenuForMachineReadableCode = [result hasResultsForAnalysisTypes:VKAnalysisTypeMachineReadableCode] ? result.mrcMenu : nil;
+strongSelf->_contextMenuForMachineReadableCode = [result hasResultsForAnalysisTypes:VKAnalysisTypeMachineReadableCode | VKAnalysisTypeAppClip] ? result.mrcMenu : nil;
 strongSelf->_contextMenuWasTriggeredByImageAnalysisTimeout = YES;
 [strongSelf->_contextMenuInteraction _presentMenuAtLocation:location];
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280216] trunk/JSTests

[sbarati]

Title: [280216] trunk/JSTests








Revision 280216
Author sbar...@apple.com
Date 2021-07-22 20:17:51 -0700 (Thu, 22 Jul 2021)


Log Message
JSTests/stress/test-out-of-memory shouldn't assume that we always OOM
https://bugs.webkit.org/show_bug.cgi?id=228213

Reviewed by Mark Lam.

* stress/test-out-of-memory.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/test-out-of-memory.js




Diff

Modified: trunk/JSTests/ChangeLog (280215 => 280216)

--- trunk/JSTests/ChangeLog	2021-07-23 03:17:00 UTC (rev 280215)
+++ trunk/JSTests/ChangeLog	2021-07-23 03:17:51 UTC (rev 280216)
@@ -1,3 +1,12 @@
+2021-07-22  Saam Barati  
+
+JSTests/stress/test-out-of-memory shouldn't assume that we always OOM
+https://bugs.webkit.org/show_bug.cgi?id=228213
+
+Reviewed by Mark Lam.
+
+* stress/test-out-of-memory.js:
+
 2021-07-22  Yusuke Suzuki  
 
 Reduce iteration of microbenchmarks/memcpy-typed-loop.js


Modified: trunk/JSTests/stress/test-out-of-memory.js (280215 => 280216)

--- trunk/JSTests/stress/test-out-of-memory.js	2021-07-23 03:17:00 UTC (rev 280215)
+++ trunk/JSTests/stress/test-out-of-memory.js	2021-07-23 03:17:51 UTC (rev 280216)
@@ -23,5 +23,5 @@
 exception = e;
 }
 
-if (exception != "RangeError: Out of memory")
+if (exception && exception != "RangeError: Out of memory")
 throw "FAILED";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280215] trunk/JSTests

[ysuzuki]

Title: [280215] trunk/JSTests








Revision 280215
Author ysuz...@apple.com
Date 2021-07-22 20:17:00 -0700 (Thu, 22 Jul 2021)


Log Message
Reduce iteration of microbenchmarks/memcpy-typed-loop.js
https://bugs.webkit.org/show_bug.cgi?id=228214

Reviewed by Saam Barati.

Observing frequent timeout (e.g. https://ews-build.webkit.org/#/builders/1/builds/44698).
We do not need to have such a large # of iterations.

* microbenchmarks/memcpy-typed-loop.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/microbenchmarks/memcpy-typed-loop.js




Diff

Modified: trunk/JSTests/ChangeLog (280214 => 280215)

--- trunk/JSTests/ChangeLog	2021-07-23 02:14:10 UTC (rev 280214)
+++ trunk/JSTests/ChangeLog	2021-07-23 03:17:00 UTC (rev 280215)
@@ -1,3 +1,15 @@
+2021-07-22  Yusuke Suzuki  
+
+Reduce iteration of microbenchmarks/memcpy-typed-loop.js
+https://bugs.webkit.org/show_bug.cgi?id=228214
+
+Reviewed by Saam Barati.
+
+Observing frequent timeout (e.g. https://ews-build.webkit.org/#/builders/1/builds/44698).
+We do not need to have such a large # of iterations.
+
+* microbenchmarks/memcpy-typed-loop.js:
+
 2021-07-22  Saam Barati  
 
 AirStackSlot's uint16_t byte size is too small


Modified: trunk/JSTests/microbenchmarks/memcpy-typed-loop.js (280214 => 280215)

--- trunk/JSTests/microbenchmarks/memcpy-typed-loop.js	2021-07-23 02:14:10 UTC (rev 280214)
+++ trunk/JSTests/microbenchmarks/memcpy-typed-loop.js	2021-07-23 03:17:00 UTC (rev 280215)
@@ -19,7 +19,8 @@
 arr1[i] = i
 }
 
-for (let i=0; i<1000; ++i) doTest(arr1, arr2)
+for (let i=0; i<1e4; ++i)
+doTest(arr1, arr2)
 
 arr2 = new Int32Array(arr1.length)
 doTest(arr1, arr2)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280214] trunk/Source/WebKit

[akeerthi]

Title: [280214] trunk/Source/WebKit








Revision 280214
Author akeer...@apple.com
Date 2021-07-22 19:14:10 -0700 (Thu, 22 Jul 2021)


Log Message
[iOS] Unable to open arxiv links on Chrome
https://bugs.webkit.org/show_bug.cgi?id=228205
rdar://78225849

Reviewed by Tim Horton.

-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:] currently
expects the width to be specified in pixels. However, the PDFKit SPI
used to snapshot a PDF expects a width in points. This led to WebKit
requesting extremely large snapshots, resulting in a crash in PDFKit.

To fix, use points instead of pixels in the PDF snapshotting path.
Also, ensure the scale factor of the returned image matches the
the scale used by PDFKit (the screen scale), as opposed to WebKit's
own "page" device scale factor, which can be overridden.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
* UIProcess/API/ios/WKWebViewIOS.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (280213 => 280214)

--- trunk/Source/WebKit/ChangeLog	2021-07-23 02:00:57 UTC (rev 280213)
+++ trunk/Source/WebKit/ChangeLog	2021-07-23 02:14:10 UTC (rev 280214)
@@ -1,3 +1,25 @@
+2021-07-22  Aditya Keerthi  
+
+[iOS] Unable to open arxiv links on Chrome
+https://bugs.webkit.org/show_bug.cgi?id=228205
+rdar://78225849
+
+Reviewed by Tim Horton.
+
+-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:] currently
+expects the width to be specified in pixels. However, the PDFKit SPI
+used to snapshot a PDF expects a width in points. This led to WebKit
+requesting extremely large snapshots, resulting in a crash in PDFKit.
+
+To fix, use points instead of pixels in the PDF snapshotting path.
+Also, ensure the scale factor of the returned image matches the
+the scale used by PDFKit (the screen scale), as opposed to WebKit's
+own "page" device scale factor, which can be overridden.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
+* UIProcess/API/ios/WKWebViewIOS.mm:
+
 2021-07-22  Brent Fulgham  
 
 REGRESSION (r278877) [Cocoa] WebAuthn stopped working for non-Safari browsers 


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (280213 => 280214)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2021-07-23 02:00:57 UTC (rev 280213)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2021-07-23 02:14:10 UTC (rev 280214)
@@ -1213,10 +1213,13 @@
 handler(image.get(), nil);
 });
 #else
-CGFloat deviceScale = _page->deviceScaleFactor();
+auto useIntrinsicDeviceScaleFactor = [[_customContentView class] web_requiresCustomSnapshotting];
+
+CGFloat deviceScale = useIntrinsicDeviceScaleFactor ? UIScreen.mainScreen.scale : _page->deviceScaleFactor();
+CGFloat imageWidth = useIntrinsicDeviceScaleFactor ? snapshotWidth : snapshotWidth * deviceScale;
 RetainPtr strongSelf = self;
-auto callSnapshotRect = [strongSelf, rectInViewCoordinates, snapshotWidth, deviceScale, handler] {
-[strongSelf _snapshotRect:rectInViewCoordinates intoImageOfWidth:(snapshotWidth * deviceScale) completionHandler:[strongSelf, handler, deviceScale](CGImageRef snapshotImage) {
+auto callSnapshotRect = [strongSelf, rectInViewCoordinates, imageWidth, deviceScale, handler] {
+[strongSelf _snapshotRect:rectInViewCoordinates intoImageOfWidth:imageWidth completionHandler:[strongSelf, handler, deviceScale](CGImageRef snapshotImage) {
 RetainPtr error;
 RetainPtr image;
 


Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (280213 => 280214)

--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm	2021-07-23 02:00:57 UTC (rev 280213)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm	2021-07-23 02:14:10 UTC (rev 280214)
@@ -3138,6 +3138,9 @@
 [_contentView updateSoftwareKeyboardSuppressionStateFromWebView];
 }
 
+// FIXME (): This method should be updated to take an image
+// width in points (for consistency) and a completion handler with a UIImage parameter
+// (to avoid redundant copies for PDFs), once it is no longer in use by internal clients.
 - (void)_snapshotRect:(CGRect)rectInViewCoordinates intoImageOfWidth:(CGFloat)imageWidth completionHandler:(void(^)(CGImageRef))completionHandler
 {
 if (_dynamicViewportUpdateMode != WebKit::DynamicViewportUpdateMode::NotResizing) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280213] trunk/Source/WebCore

[said]

Title: [280213] trunk/Source/WebCore








Revision 280213
Author s...@apple.com
Date 2021-07-22 19:00:57 -0700 (Thu, 22 Jul 2021)


Log Message
Unreviewed, reverting 280130.
https://bugs.webkit.org/show_bug.cgi?id=228212

Introduced MotionMark regression

Reverted changeset:


* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (280212 => 280213)

--- trunk/Source/WebCore/ChangeLog	2021-07-23 02:00:13 UTC (rev 280212)
+++ trunk/Source/WebCore/ChangeLog	2021-07-23 02:00:57 UTC (rev 280213)
@@ -1,3 +1,15 @@
+2021-07-22  Said Abou-Hallawa  
+
+Unreviewed, reverting 280130.
+https://bugs.webkit.org/show_bug.cgi?id=228212
+
+Introduced MotionMark regression
+
+Reverted changeset:
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::simplifiedLayout):
+
 2021-07-22  Chris Dumez  
 
 The network process fails to take a locked file assertion when executing a SQLiteStatement outside a transaction


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (280212 => 280213)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2021-07-23 02:00:13 UTC (rev 280212)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2021-07-23 02:00:57 UTC (rev 280213)
@@ -940,12 +940,8 @@
 // relative positioned container. So if we can have fixed pos objects in our positioned objects list check if any of them
 // are statically positioned and thus need to move with their absolute ancestors.
 bool canContainFixedPosObjects = canContainFixedPositionObjects();
-if (posChildNeedsLayout() || canContainFixedPosObjects) {
-// FIXME: Remove this early return once https://webkit.org/b/228125 is fixed.
-if (!hasPositionedObjects())
-return false;
+if (posChildNeedsLayout() || canContainFixedPosObjects)
 layoutPositionedObjects(false, !posChildNeedsLayout() && canContainFixedPosObjects);
-}
 
 // Recompute our overflow information.
 // FIXME: We could do better here by computing a temporary overflow object from layoutPositionedObjects and only






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280212] trunk/LayoutTests

[jenner]

Title: [280212] trunk/LayoutTests








Revision 280212
Author jen...@apple.com
Date 2021-07-22 19:00:13 -0700 (Thu, 22 Jul 2021)


Log Message
Batch add test expectations for Monterey on Open Source
https://bugs.webkit.org/show_bug.cgi?id=228200

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280211 => 280212)

--- trunk/LayoutTests/ChangeLog	2021-07-23 00:09:31 UTC (rev 280211)
+++ trunk/LayoutTests/ChangeLog	2021-07-23 02:00:13 UTC (rev 280212)
@@ -5,6 +5,16 @@
 
 Unreviewed test gardening.
 
+* platform/mac-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
+2021-07-22  Robert Jenner  
+
+Batch add test expectations for Monterey on Open Source
+https://bugs.webkit.org/show_bug.cgi?id=228200
+
+Unreviewed test gardening.
+
 * platform/mac-wk1/TestExpectations:
 * platform/mac/TestExpectations: Adjusting expectations for Monterey.
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (280211 => 280212)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-07-23 00:09:31 UTC (rev 280211)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-07-23 02:00:13 UTC (rev 280212)
@@ -2372,4 +2372,8 @@
 [ Monterey ] imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key.html [ Failure ]
 
 # rdar://77527267 REGRESSION: imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY.html is a constant timeout and is flaky crashing and text failing
-[ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-invalid-args.html [ Pass Failure Timeout ]
\ No newline at end of file
+[ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-invalid-args.html [ Pass Failure Timeout ]
+
+# webkit.org/b/228200 Setting multiple test expectations for Monetery on OpenSource:
+[ Monterey ] model-element/model-element-graphics-layers-opacity.html [ Pass Failure ]
+[ Monterey Debug arm64 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html [ Pass Failure Crash ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280211 => 280212)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-23 00:09:31 UTC (rev 280211)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-23 02:00:13 UTC (rev 280212)
@@ -1601,4 +1601,10 @@
 webkit.org/b/228087 media/video-seek-with-negative-playback.html [ Pass Failure ]
  
 # webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
-[ Monterey ] imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub.html [ Failure ]
\ No newline at end of file
+[ Monterey ] imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub.html [ Failure ]
+
+# webkit.org/b/228200 Setting multiple test expectations for Monetery on OpenSource:
+[ Monterey ] imported/w3c/web-platform-tests/service-workers/service-worker/import-scripts-cross-origin.https.html [ Failure ]
+[ Monterey ] model-element/model-element-source.html [ Pass Crash ]
+[ Monterey Release ] platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html [ Pass Crash ]
+[ Monterey Release ] media/media-fragments/TC0004.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280211] trunk/Source/WebCore

[cdumez]

Title: [280211] trunk/Source/WebCore








Revision 280211
Author cdu...@apple.com
Date 2021-07-22 17:09:31 -0700 (Thu, 22 Jul 2021)


Log Message
The network process fails to take a locked file assertion when executing a SQLiteStatement outside a transaction
https://bugs.webkit.org/show_bug.cgi?id=228194

Reviewed by Geoffrey Garen.

The network process fails to take a locked file assertion when executing a SQLiteStatement outside a transaction.
This means we may suspend in the middle of that statement and crash due to holding locked files.

To address this, we now make sure to bump the transaction count during the sqlite3_step() call if we're not
in the middle of a transaction and the current statement is not read-only (e.g. SELECT). Note that SQLite will
implicitly create a transaction for us in such cases.

* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::step):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (280210 => 280211)

--- trunk/Source/WebCore/ChangeLog	2021-07-23 00:08:14 UTC (rev 280210)
+++ trunk/Source/WebCore/ChangeLog	2021-07-23 00:09:31 UTC (rev 280211)
@@ -1,3 +1,20 @@
+2021-07-22  Chris Dumez  
+
+The network process fails to take a locked file assertion when executing a SQLiteStatement outside a transaction
+https://bugs.webkit.org/show_bug.cgi?id=228194
+
+Reviewed by Geoffrey Garen.
+
+The network process fails to take a locked file assertion when executing a SQLiteStatement outside a transaction.
+This means we may suspend in the middle of that statement and crash due to holding locked files.
+
+To address this, we now make sure to bump the transaction count during the sqlite3_step() call if we're not
+in the middle of a transaction and the current statement is not read-only (e.g. SELECT). Note that SQLite will
+implicitly create a transaction for us in such cases.
+
+* platform/sql/SQLiteStatement.cpp:
+(WebCore::SQLiteStatement::step):
+
 2021-07-22  Myles C. Maxfield  
 
 [Cocoa] ".SF Arabic" should not be able to be looked up by name (because it is dot-prefixed)


Modified: trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp (280210 => 280211)

--- trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp	2021-07-23 00:08:14 UTC (rev 280210)
+++ trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp	2021-07-23 00:09:31 UTC (rev 280211)
@@ -28,6 +28,7 @@
 
 #include "Logging.h"
 #include "SQLValue.h"
+#include "SQLiteDatabaseTracker.h"
 #include 
 #include 
 #include 
@@ -66,6 +67,12 @@
 {
 Locker databaseLock { m_database.databaseMutex() };
 
+// If we're not within a transaction and we call sqlite3_step(), SQLite will implicitly create a transaction for us.
+// In such case, we should bump our transaction count to reflect that.
+std::optional transactionCounter;
+if (!m_database.transactionInProgress() && !isReadOnly())
+transactionCounter.emplace();
+
 int error = sqlite3_step(m_statement);
 if (error != SQLITE_DONE && error != SQLITE_ROW)
 LOG(SQLDatabase, "sqlite3_step failed (%i)\nError - %s", error, sqlite3_errmsg(m_database.sqlite3Handle()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280209] branches/safari-612.1.25-branch/Source

[alancoon]

Title: [280209] branches/safari-612.1.25-branch/Source








Revision 280209
Author alanc...@apple.com
Date 2021-07-22 17:08:01 -0700 (Thu, 22 Jul 2021)


Log Message
Cherry-pick r280205. rdar://problem/80991517

REGRESSION (r278877) [Cocoa] WebAuthn stopped working for non-Safari browsers
https://bugs.webkit.org/show_bug.cgi?id=228116


Reviewed by Per Arne Vollan.

Source/WebKit:

We should not be using the PAC key to confirm a valid WebContent process is the source of
WebAuthn-related messages. Instead, we should confirm the message source is an Apple-signed
executable, and that the signining identity is for the WebContent process.

* Shared/Cocoa/CodeSigning.h: Renamed from Source/WebKit/Shared/mac/CodeSigning.h.
* Shared/Cocoa/CodeSigning.mm: Renamed from Source/WebKit/Shared/mac/CodeSigning.mm.
(WebKit::codeSigningIdentifier):
(WebKit::codeSigningIdentifierForCurrentProcess):
(WebKit::codeSigningIdentifierAndPlatformBinaryStatus): Added.
* Shared/Cocoa/XPCEndpoint.mm:
(WebKit::XPCEndpoint::XPCEndpoint): Update to use new method.
* SourcesCocoa.txt:
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::messageSourceIsValidWebContentProcess):
* UIProcess/WebProcessProxy.cpp:
(WebKit:WebProcessProxy::getWebAuthnProcessConnection): Update for new message check name.
* UIProcess/WebProcessProxy.h:
* WebKit.xcodeproj/project.pbxproj:

Source/WTF:

Add new SPI header for code signing features.

* WTF.xcodeproj/project.pbxproj:
* wtf/spi/cocoa/SecuritySPI.h: Move some SecTask calls out of PLATFORM(MAC).
* wtf/spi/darwin/CodeSignSPI.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.25-branch/Source/WTF/ChangeLog
branches/safari-612.1.25-branch/Source/WTF/WTF.xcodeproj/project.pbxproj
branches/safari-612.1.25-branch/Source/WTF/wtf/spi/cocoa/SecuritySPI.h
branches/safari-612.1.25-branch/Source/WebKit/ChangeLog
branches/safari-612.1.25-branch/Source/WebKit/Shared/Cocoa/XPCEndpoint.mm
branches/safari-612.1.25-branch/Source/WebKit/SourcesCocoa.txt
branches/safari-612.1.25-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
branches/safari-612.1.25-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp
branches/safari-612.1.25-branch/Source/WebKit/UIProcess/WebProcessProxy.h
branches/safari-612.1.25-branch/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm
branches/safari-612.1.25-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

branches/safari-612.1.25-branch/Source/WTF/wtf/spi/darwin/CodeSignSPI.h
branches/safari-612.1.25-branch/Source/WebKit/Shared/Cocoa/CodeSigning.h
branches/safari-612.1.25-branch/Source/WebKit/Shared/Cocoa/CodeSigning.mm


Removed Paths

branches/safari-612.1.25-branch/Source/WebKit/Shared/mac/CodeSigning.h
branches/safari-612.1.25-branch/Source/WebKit/Shared/mac/CodeSigning.mm




Diff

Modified: branches/safari-612.1.25-branch/Source/WTF/ChangeLog (280208 => 280209)

--- branches/safari-612.1.25-branch/Source/WTF/ChangeLog	2021-07-22 23:46:36 UTC (rev 280208)
+++ branches/safari-612.1.25-branch/Source/WTF/ChangeLog	2021-07-23 00:08:01 UTC (rev 280209)
@@ -1,3 +1,59 @@
+2021-07-22  Alan Coon  
+
+Cherry-pick r280205. rdar://problem/80991517
+
+REGRESSION (r278877) [Cocoa] WebAuthn stopped working for non-Safari browsers
+https://bugs.webkit.org/show_bug.cgi?id=228116
+
+
+Reviewed by Per Arne Vollan.
+
+Source/WebKit:
+
+We should not be using the PAC key to confirm a valid WebContent process is the source of
+WebAuthn-related messages. Instead, we should confirm the message source is an Apple-signed
+executable, and that the signining identity is for the WebContent process.
+
+* Shared/Cocoa/CodeSigning.h: Renamed from Source/WebKit/Shared/mac/CodeSigning.h.
+* Shared/Cocoa/CodeSigning.mm: Renamed from Source/WebKit/Shared/mac/CodeSigning.mm.
+(WebKit::codeSigningIdentifier):
+(WebKit::codeSigningIdentifierForCurrentProcess):
+(WebKit::codeSigningIdentifierAndPlatformBinaryStatus): Added.
+* Shared/Cocoa/XPCEndpoint.mm:
+(WebKit::XPCEndpoint::XPCEndpoint): Update to use new method.
+* SourcesCocoa.txt:
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::messageSourceIsValidWebContentProcess):
+* UIProcess/WebProcessProxy.cpp:
+(WebKit:WebProcessProxy::getWebAuthnProcessConnection): Update for new message check name.
+* UIProcess/WebProcessProxy.h:
+* WebKit.xcodeproj/project.pbxproj:
+
+Source/WTF:
+
+Add new SPI header for code signing features.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/spi/cocoa/SecuritySPI.h: Move some SecTask calls out of PLATFORM(MAC).
+* wtf/spi/darwin/CodeSignSPI.h: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280205 

[webkit-changes] [280210] trunk/LayoutTests

[jenner]

Title: [280210] trunk/LayoutTests








Revision 280210
Author jen...@apple.com
Date 2021-07-22 17:08:14 -0700 (Thu, 22 Jul 2021)


Log Message
Batch add test expectations for Monterey on Open Source
https://bugs.webkit.org/show_bug.cgi?id=228200

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:
* platform/mac/TestExpectations: Adjusting expectations for Monterey.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280209 => 280210)

--- trunk/LayoutTests/ChangeLog	2021-07-23 00:08:01 UTC (rev 280209)
+++ trunk/LayoutTests/ChangeLog	2021-07-23 00:08:14 UTC (rev 280210)
@@ -1,5 +1,15 @@
 2021-07-22  Robert Jenner  
 
+Batch add test expectations for Monterey on Open Source
+https://bugs.webkit.org/show_bug.cgi?id=228200
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac/TestExpectations: Adjusting expectations for Monterey.
+
+2021-07-22  Robert Jenner  
+
 [BigSur+ Wk2] imported/w3c/web-platform-t ests/media-source/mediasour ce-seek-during-pending-seek .html is a flakey failure
 https://bugs.webkit.org/show_bug.cgi?id=222183
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (280209 => 280210)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-07-23 00:08:01 UTC (rev 280209)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-07-23 00:08:14 UTC (rev 280210)
@@ -2369,4 +2369,7 @@
 webkit.org/b/227998 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-network-error.sub.html [ Pass Failure ]
 
 # webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
-[ Monterey ] imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key.html [ Failure ]
\ No newline at end of file
+[ Monterey ] imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key.html [ Failure ]
+
+# rdar://77527267 REGRESSION: imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY.html is a constant timeout and is flaky crashing and text failing
+[ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-invalid-args.html [ Pass Failure Timeout ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (280209 => 280210)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-07-23 00:08:01 UTC (rev 280209)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-07-23 00:08:14 UTC (rev 280210)
@@ -1268,7 +1268,6 @@
 # rdar://79973810 5 imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap* tests are consistently timing out.
 [ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-drawImage.html [ Timeout ]
 [ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY.html [ Timeout ]
-[ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-invalid-args.html [ Timeout ]
 [ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-serializable.html [ Timeout ]
 [ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-transfer.html [ Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280208] trunk/LayoutTests

[jenner]

Title: [280208] trunk/LayoutTests








Revision 280208
Author jen...@apple.com
Date 2021-07-22 16:46:36 -0700 (Thu, 22 Jul 2021)


Log Message
[BigSur+ Wk2] imported/w3c/web-platform-t ests/media-source/mediasour ce-seek-during-pending-seek .html is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=222183

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations: Including BigSur+ on existing expectations.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280207 => 280208)

--- trunk/LayoutTests/ChangeLog	2021-07-22 23:37:55 UTC (rev 280207)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 23:46:36 UTC (rev 280208)
@@ -1,5 +1,14 @@
 2021-07-22  Robert Jenner  
 
+[BigSur+ Wk2] imported/w3c/web-platform-t ests/media-source/mediasour ce-seek-during-pending-seek .html is a flakey failure
+https://bugs.webkit.org/show_bug.cgi?id=222183
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations: Including BigSur+ on existing expectations.
+
+2021-07-22  Robert Jenner  
+
 [ BigSur+ iOS Release wk2  ] 2 imported/w3c/web-platform-tests/webrtc are flakey text failures (223385)
 https://bugs.webkit.org/show_bug.cgi?id=223385
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280207 => 280208)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 23:37:55 UTC (rev 280207)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 23:46:36 UTC (rev 280208)
@@ -1402,7 +1402,7 @@
 
 webkit.org/b/09 inspector/debugger/async-stack-trace-basic.html [ Pass Timeout ]
 
-webkit.org/b/222183 [ BigSur ] imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Pass Failure ]
+webkit.org/b/222183 [ BigSur+ ] imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Pass Failure ]
 
 webkit.org/b/222365 inspector/dom/attributeModified.html [ Pass Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280207] trunk/LayoutTests

[jenner]

Title: [280207] trunk/LayoutTests








Revision 280207
Author jen...@apple.com
Date 2021-07-22 16:37:55 -0700 (Thu, 22 Jul 2021)


Log Message
[ BigSur+ iOS Release wk2  ] 2 imported/w3c/web-platform-tests/webrtc are flakey text failures (223385)
https://bugs.webkit.org/show_bug.cgi?id=223385

Unreviewed test gardening.

* platform/ios/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280206 => 280207)

--- trunk/LayoutTests/ChangeLog	2021-07-22 23:02:22 UTC (rev 280206)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 23:37:55 UTC (rev 280207)
@@ -1,3 +1,13 @@
+2021-07-22  Robert Jenner  
+
+[ BigSur+ iOS Release wk2  ] 2 imported/w3c/web-platform-tests/webrtc are flakey text failures (223385)
+https://bugs.webkit.org/show_bug.cgi?id=223385
+
+Unreviewed test gardening. 
+
+* platform/ios/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2021-07-22  Ayumi Kojima  
 
 [iOS] media/video-presentation-mode.html is a flaky timeout.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (280206 => 280207)

--- trunk/LayoutTests/platform/ios/TestExpectations	2021-07-22 23:02:22 UTC (rev 280206)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2021-07-22 23:37:55 UTC (rev 280207)
@@ -3391,3 +3391,7 @@
 
 # WebM is not supported on iOS
 http/tests/media/video-webm-stall.html [ Skip ]
+
+# webkit.org/b/223385 Two imported webrtc tests are flakey text failing on Release for BigSur+ and iOS 14
+[ Release ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-connectionSetup.html [ Pass Failure ]
+[ Release ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html [ Pass Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280206 => 280207)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 23:02:22 UTC (rev 280206)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 23:37:55 UTC (rev 280207)
@@ -1440,8 +1440,8 @@
 
 webkit.org/b/223293 media/media-fullscreen-return-to-inline.html [ Pass Failure Timeout ]
 
-# webkit.org/b/223385 Two imported webrtc tests are flakey text failing only on Apple Silicon
-[ arm64 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-connectionSetup.html [ Pass Failure ]
+# webkit.org/b/223385 Two imported webrtc tests are flakey text failing on Release for BigSur+ and iOS 14
+[ BigSur+ Release ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-connectionSetup.html [ Pass Failure ]
 
 webkit.org/b/223387 media/track/track-cue-css.html [ Pass ImageOnlyFailure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280206] trunk/LayoutTests

[ayumi_kojima]

Title: [280206] trunk/LayoutTests








Revision 280206
Author ayumi_koj...@apple.com
Date 2021-07-22 16:02:22 -0700 (Thu, 22 Jul 2021)


Log Message
[iOS] media/video-presentation-mode.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=228204

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280205 => 280206)

--- trunk/LayoutTests/ChangeLog	2021-07-22 22:58:08 UTC (rev 280205)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 23:02:22 UTC (rev 280206)
@@ -1,3 +1,12 @@
+2021-07-22  Ayumi Kojima  
+
+[iOS] media/video-presentation-mode.html is a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=228204
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-07-22  Robert Jenner  
 
 Batch add test expectations for Monterey on Open Source


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (280205 => 280206)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-22 22:58:08 UTC (rev 280205)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-22 23:02:22 UTC (rev 280206)
@@ -1406,6 +1406,8 @@
 webkit.org/b/228038 [ Debug ] media/modern-media-controls/mute-button/mute-button.html  [ Pass Crash ] 
 webkit.org/b/228038 [ Debug ] fast/mediastream/audio-bad-sampleRate.html  [ Pass Crash ] 
 
+webkit.org/b/228204 media/video-presentation-mode.html [ Pass Timeout ] 
+
 webkit.org/b/208656 storage/indexeddb/modern/transactions-stop-on-navigation.html [ Pass Failure ]
 
 webkit.org/b/208662 http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-by-default-src-star.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280205] trunk/Source

[bfulgham]

Title: [280205] trunk/Source








Revision 280205
Author bfulg...@apple.com
Date 2021-07-22 15:58:08 -0700 (Thu, 22 Jul 2021)


Log Message
REGRESSION (r278877) [Cocoa] WebAuthn stopped working for non-Safari browsers
https://bugs.webkit.org/show_bug.cgi?id=228116


Reviewed by Per Arne Vollan.

Source/WebKit:

We should not be using the PAC key to confirm a valid WebContent process is the source of
WebAuthn-related messages. Instead, we should confirm the message source is an Apple-signed
executable, and that the signining identity is for the WebContent process.

* Shared/Cocoa/CodeSigning.h: Renamed from Source/WebKit/Shared/mac/CodeSigning.h.
* Shared/Cocoa/CodeSigning.mm: Renamed from Source/WebKit/Shared/mac/CodeSigning.mm.
(WebKit::codeSigningIdentifier):
(WebKit::codeSigningIdentifierForCurrentProcess):
(WebKit::codeSigningIdentifierAndPlatformBinaryStatus): Added.
* Shared/Cocoa/XPCEndpoint.mm:
(WebKit::XPCEndpoint::XPCEndpoint): Update to use new method.
* SourcesCocoa.txt:
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::messageSourceIsValidWebContentProcess):
* UIProcess/WebProcessProxy.cpp:
(WebKit:WebProcessProxy::getWebAuthnProcessConnection): Update for new message check name.
* UIProcess/WebProcessProxy.h:
* WebKit.xcodeproj/project.pbxproj:

Source/WTF:

Add new SPI header for code signing features.

* WTF.xcodeproj/project.pbxproj:
* wtf/spi/cocoa/SecuritySPI.h: Move some SecTask calls out of PLATFORM(MAC).
* wtf/spi/darwin/CodeSignSPI.h: Added.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/spi/cocoa/SecuritySPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/XPCEndpoint.mm
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WTF/wtf/spi/darwin/CodeSignSPI.h
trunk/Source/WebKit/Shared/Cocoa/CodeSigning.h
trunk/Source/WebKit/Shared/Cocoa/CodeSigning.mm


Removed Paths

trunk/Source/WebKit/Shared/mac/CodeSigning.h
trunk/Source/WebKit/Shared/mac/CodeSigning.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (280204 => 280205)

--- trunk/Source/WTF/ChangeLog	2021-07-22 22:52:12 UTC (rev 280204)
+++ trunk/Source/WTF/ChangeLog	2021-07-22 22:58:08 UTC (rev 280205)
@@ -1,3 +1,17 @@
+2021-07-22  Brent Fulgham  
+
+REGRESSION (r278877) [Cocoa] WebAuthn stopped working for non-Safari browsers 
+https://bugs.webkit.org/show_bug.cgi?id=228116
+
+
+Reviewed by Per Arne Vollan.
+
+Add new SPI header for code signing features.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/spi/cocoa/SecuritySPI.h: Move some SecTask calls out of PLATFORM(MAC).
+* wtf/spi/darwin/CodeSignSPI.h: Added.
+
 2021-07-22  Saam Barati  
 
 Fix uses of Dependency::fence with respect to the compiler outsmarting us


Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (280204 => 280205)

--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2021-07-22 22:52:12 UTC (rev 280204)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2021-07-22 22:58:08 UTC (rev 280205)
@@ -451,6 +451,7 @@
 		795212021F42588800BD6421 /* SingleRootGraph.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SingleRootGraph.h; sourceTree = ""; };
 		7A05093D1FB9DCC500B33FB8 /* JSONValues.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSONValues.h; sourceTree = ""; };
 		7A05093E1FB9DCC500B33FB8 /* JSONValues.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSONValues.cpp; sourceTree = ""; };
+		7A4D4AAB26A8DEFC001182F1 /* CodeSignSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CodeSignSPI.h; sourceTree = ""; };
 		7A6EBA3220746C33004F9C44 /* MachSendRight.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MachSendRight.h; sourceTree = ""; };
 		7A6EBA3320746C34004F9C44 /* MachSendRight.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MachSendRight.cpp; sourceTree = ""; };
 		7AF023B32061E16C00A8EFD6 /* ProcessPrivilege.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ProcessPrivilege.h; sourceTree = ""; };
@@ -1520,6 +1521,7 @@
 		CE73E02319DCB7AB00580D5C /* darwin */ = {
 			isa = PBXGroup;
 			children = (
+7A4D4AAB26A8DEFC001182F1 /* CodeSignSPI.h */,
 14933E21228C22DF00F79E46 /* DataVaultSPI.h */,
 E431CC4A21187ADB000C8A07 /* DispatchSPI.h */,
 93DDE9311CDC052D00FD3491 /* dyldSPI.h */,


Modified: trunk/Source/WTF/wtf/spi/cocoa/SecuritySPI.h (280204 => 280205)

--- 

[webkit-changes] [280204] trunk/LayoutTests

[jenner]

Title: [280204] trunk/LayoutTests








Revision 280204
Author jen...@apple.com
Date 2021-07-22 15:52:12 -0700 (Thu, 22 Jul 2021)


Log Message
Batch add test expectations for Monterey on Open Source
https://bugs.webkit.org/show_bug.cgi?id=228200

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280203 => 280204)

--- trunk/LayoutTests/ChangeLog	2021-07-22 22:48:53 UTC (rev 280203)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 22:52:12 UTC (rev 280204)
@@ -1,3 +1,14 @@
+2021-07-22  Robert Jenner  
+
+Batch add test expectations for Monterey on Open Source
+https://bugs.webkit.org/show_bug.cgi?id=228200
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
 2021-07-22  Myles C. Maxfield  
 
 [Cocoa] ".SF Arabic" should not be able to be looked up by name (because it is dot-prefixed)


Modified: trunk/LayoutTests/platform/mac/TestExpectations (280203 => 280204)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-07-22 22:48:53 UTC (rev 280203)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-07-22 22:52:12 UTC (rev 280204)
@@ -2368,3 +2368,5 @@
 
 webkit.org/b/227998 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-network-error.sub.html [ Pass Failure ]
 
+# webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
+[ Monterey ] imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key.html [ Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (280203 => 280204)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-07-22 22:48:53 UTC (rev 280203)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-07-22 22:52:12 UTC (rev 280204)
@@ -1379,4 +1379,7 @@
 
 webkit.org/b/225470 [ BigSur Release ] svg/filters/feDiffuseLighting-bottomRightPixel.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/225420 [ BigSur Release ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-017.html [ Pass ImageOnlyFailure ]
\ No newline at end of file
+webkit.org/b/225420 [ BigSur Release ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-017.html [ Pass ImageOnlyFailure ]
+
+# webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
+[ Monterey ] webrtc/h264-high.html [ Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280203 => 280204)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 22:48:53 UTC (rev 280203)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 22:52:12 UTC (rev 280204)
@@ -1546,7 +1546,7 @@
 [ Monterey ] webrtc/h264-high.html [ Timeout ]
 
 # rdar://80346382 ([ Monterey Release wk2 arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html is a flaky crash)
-[ Monterey arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html [ Pass Failure Crash ]
+[ Monterey arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html [ Failure Crash ]
 
 # rdar://80333935 (REGRESSION: [ Monterey wk2 arm64 ] fast/animation/request-animation-frame-throttling-detached-iframe.html and request-animation-frame-throttling-lowPowerMode.html failing)
 [ Monterey arm64 ] fast/animation/request-animation-frame-throttling-detached-iframe.html [ Failure ]
@@ -1565,9 +1565,6 @@
 # rdar://80335452 ([ Monterey wk2 Release ] fast/scrolling/iframe-scrollable-after-back.html is a flaky timeout)
 [ Monterey ] fast/scrolling/iframe-scrollable-after-back.html [ Pass Timeout ]
 
-# rdar://80344138 ([ Monterey iOS wk2 ] imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key.html [ Failure ])
-[ Monterey ] imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key.html [ Failure ]
-
 webkit.org/b/224085 fullscreen/full-screen-remove-ancestor.html [ Skip ]
 
 webkit.org/b/227776 [ BigSur Release arm64 ] scrollbars/corner-resizer-window-inactive.html [ Pass ImageOnlyFailure ]
@@ -1602,4 +1599,6 @@
 webkit.org/b/228197 [ arm64 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html [ Pass Failure ]
 
 webkit.org/b/228087 media/video-seek-with-negative-playback.html [ Pass Failure ]
- 
\ No newline at end of file
+ 
+# webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
+[ Monterey ] imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub.html [ Failure ]
\ No newline at end of file

[webkit-changes] [280203] trunk/Source/WebKit

[bfulgham]

Title: [280203] trunk/Source/WebKit








Revision 280203
Author bfulg...@apple.com
Date 2021-07-22 15:48:53 -0700 (Thu, 22 Jul 2021)


Log Message
REGRESSION (r277873, r280105): [macOS] Correct two sandbox typos (228201)
https://bugs.webkit.org/show_bug.cgi?id=228201


Reviewed by Per Arne Vollan.

Correct two typos in the macOS Sandbox (WebContent process).

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (280202 => 280203)

--- trunk/Source/WebKit/ChangeLog	2021-07-22 22:45:52 UTC (rev 280202)
+++ trunk/Source/WebKit/ChangeLog	2021-07-22 22:48:53 UTC (rev 280203)
@@ -1,3 +1,15 @@
+2021-07-22  Brent Fulgham  
+
+REGRESSION (r277873, r280105): [macOS] Correct two sandbox typos (228201)
+https://bugs.webkit.org/show_bug.cgi?id=228201
+
+
+Reviewed by Per Arne Vollan.
+
+Correct two typos in the macOS Sandbox (WebContent process).
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2021-07-22  Brady Eidson  
 
 Revert part of r279089 that was done a little bit too early.


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (280202 => 280203)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2021-07-22 22:45:52 UTC (rev 280202)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2021-07-22 22:48:53 UTC (rev 280203)
@@ -1057,7 +1057,7 @@
 (home-subpath "/Library/Preferences/com.apple.universalaccess.plist")
 (home-subpath "/Library/Preferences/edu.mit.Kerberos.plist")
 (home-subpath "/Library/Preferences/pbs.plist")
-(home-regex "/Library/Preferences/ByHost/\.GlobalPreferences\..*\.plist$")
+(home-regex #"/Library/Preferences/ByHost/\.GlobalPreferences\..*\.plist$")
 )
 #endif
 
@@ -2150,7 +2150,7 @@
 )
 )
 
-(if (and (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") (defined? 'syscall-mach))
+(when (and (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") (defined? 'syscall-mach))
 (deny syscall-mach
 (machtrap-number
 MSC_mach_wait_until






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280202] trunk/Source/WebKit

[beidson]

Title: [280202] trunk/Source/WebKit








Revision 280202
Author beid...@apple.com
Date 2021-07-22 15:45:52 -0700 (Thu, 22 Jul 2021)


Log Message
Revert part of r279089 that was done a little bit too early.
 and https://bugs.webkit.org/show_bug.cgi?id=228174

Reviewed by Chris Dumez.

* Configurations/WebKit.xcconfig:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig




Diff

Modified: trunk/Source/WebKit/ChangeLog (280201 => 280202)

--- trunk/Source/WebKit/ChangeLog	2021-07-22 22:40:20 UTC (rev 280201)
+++ trunk/Source/WebKit/ChangeLog	2021-07-22 22:45:52 UTC (rev 280202)
@@ -1,3 +1,12 @@
+2021-07-22  Brady Eidson  
+
+Revert part of r279089 that was done a little bit too early.
+ and https://bugs.webkit.org/show_bug.cgi?id=228174
+
+Reviewed by Chris Dumez.
+
+* Configurations/WebKit.xcconfig:
+
 2021-07-22  Tim Horton  
 
 REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst


Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (280201 => 280202)

--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2021-07-22 22:40:20 UTC (rev 280201)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2021-07-22 22:45:52 UTC (rev 280202)
@@ -178,10 +178,10 @@
 INSTALLHDRS_SCRIPT_PHASE = YES;
 APPLY_RULES_IN_COPY_HEADERS = $(WK_USE_NEW_BUILD_SYSTEM);
 
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=macosx*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_MACOS_1300));
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_MACOS_BEFORE_1300 = YES;
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=iphone*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_IOS_16));
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_IOS_BEFORE_16 = YES;
+WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=macosx*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_MACOS_1200));
+WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_MACOS_BEFORE_1200 = YES;
+WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=iphone*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_IOS_15));
+WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_IOS_BEFORE_15 = YES;
 
 WK_RELOCATABLE_FRAMEWORK_LDFLAGS = $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS_$(WK_RELOCATABLE_FRAMEWORKS)_$(WK_PLATFORM_NAME));
 WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES_macosx = -Wl,-not_for_dyld_shared_cache;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280201] trunk

[mmaxfield]

Title: [280201] trunk








Revision 280201
Author mmaxfi...@apple.com
Date 2021-07-22 15:40:20 -0700 (Thu, 22 Jul 2021)


Log Message
[Cocoa] ".SF Arabic" should not be able to be looked up by name (because it is dot-prefixed)
https://bugs.webkit.org/show_bug.cgi?id=228018


Reviewed by Simon Fraser.

Source/WebCore:

Dot-prefixed font names are not supported. The supported way of using SF Arabic is to use
system-ui with Arabic text. It will fall back to SF Arabic.

Test: fast/text/sf-arabic-lookup-by-name.html

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::platformFontLookupWithFamily): Special case this font name, similar to how
we have other special cases for other dot-prefixed fonts. Ideally we would change this
check to just if the leading character is a dot, but that change would be too scary at
this point in the release cycle.

LayoutTests:

* fast/text/sf-arabic-lookup-by-name-expected.html: Added.
* fast/text/sf-arabic-lookup-by-name.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp


Added Paths

trunk/LayoutTests/fast/text/sf-arabic-lookup-by-name-expected.html
trunk/LayoutTests/fast/text/sf-arabic-lookup-by-name.html




Diff

Modified: trunk/LayoutTests/ChangeLog (280200 => 280201)

--- trunk/LayoutTests/ChangeLog	2021-07-22 22:11:13 UTC (rev 280200)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 22:40:20 UTC (rev 280201)
@@ -1,3 +1,14 @@
+2021-07-22  Myles C. Maxfield  
+
+[Cocoa] ".SF Arabic" should not be able to be looked up by name (because it is dot-prefixed)
+https://bugs.webkit.org/show_bug.cgi?id=228018
+
+
+Reviewed by Simon Fraser.
+
+* fast/text/sf-arabic-lookup-by-name-expected.html: Added.
+* fast/text/sf-arabic-lookup-by-name.html: Added.
+
 2021-07-22  Eric Hutchison  
 
 [BigSur Debug] imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.worker.html is a flaky failure.


Added: trunk/LayoutTests/fast/text/sf-arabic-lookup-by-name-expected.html (0 => 280201)

--- trunk/LayoutTests/fast/text/sf-arabic-lookup-by-name-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/sf-arabic-lookup-by-name-expected.html	2021-07-22 22:40:20 UTC (rev 280201)
@@ -0,0 +1,9 @@
+
+
+
+
+
+This test makes sure that the dot-prefixed SF Arabic cannot be looked up by name.
+
+
+


Added: trunk/LayoutTests/fast/text/sf-arabic-lookup-by-name.html (0 => 280201)

--- trunk/LayoutTests/fast/text/sf-arabic-lookup-by-name.html	(rev 0)
+++ trunk/LayoutTests/fast/text/sf-arabic-lookup-by-name.html	2021-07-22 22:40:20 UTC (rev 280201)
@@ -0,0 +1,9 @@
+
+
+
+
+
+This test makes sure that the dot-prefixed SF Arabic cannot be looked up by name.
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (280200 => 280201)

--- trunk/Source/WebCore/ChangeLog	2021-07-22 22:11:13 UTC (rev 280200)
+++ trunk/Source/WebCore/ChangeLog	2021-07-22 22:40:20 UTC (rev 280201)
@@ -1,3 +1,22 @@
+2021-07-22  Myles C. Maxfield  
+
+[Cocoa] ".SF Arabic" should not be able to be looked up by name (because it is dot-prefixed)
+https://bugs.webkit.org/show_bug.cgi?id=228018
+
+
+Reviewed by Simon Fraser.
+
+Dot-prefixed font names are not supported. The supported way of using SF Arabic is to use
+system-ui with Arabic text. It will fall back to SF Arabic.
+
+Test: fast/text/sf-arabic-lookup-by-name.html
+
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(WebCore::platformFontLookupWithFamily): Special case this font name, similar to how
+we have other special cases for other dot-prefixed fonts. Ideally we would change this
+check to just if the leading character is a dot, but that change would be too scary at
+this point in the release cycle.
+
 2021-07-22  Yusuke Suzuki  
 
 Rename AtomicHTMLToken to AtomHTMLToken


Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (280200 => 280201)

--- trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2021-07-22 22:11:13 UTC (rev 280200)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2021-07-22 22:40:20 UTC (rev 280201)
@@ -1110,8 +1110,9 @@
 if (equalLettersIgnoringASCIICase(family, ".applesystemuifontserif")
 || equalLettersIgnoringASCIICase(family, ".sf ns mono")
 || equalLettersIgnoringASCIICase(family, ".sf ui mono")
+|| equalLettersIgnoringASCIICase(family, ".sf arabic")
 || equalLettersIgnoringASCIICase(family, ".applesystemuifontrounded")) {
-// If you want to use these fonts, use ui-serif, ui-monospace, and ui-rounded.
+// If you want to use these fonts, use system-ui, ui-serif, ui-monospace, or ui-rounded.
 return { nullptr };
 }
 






___
webkit-changes mailing list

[webkit-changes] [280200] trunk/LayoutTests

[ehutchison]

Title: [280200] trunk/LayoutTests








Revision 280200
Author ehutchi...@apple.com
Date 2021-07-22 15:11:13 -0700 (Thu, 22 Jul 2021)


Log Message
[BigSur Debug] imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.worker.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=222385.

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280199 => 280200)

--- trunk/LayoutTests/ChangeLog	2021-07-22 22:07:52 UTC (rev 280199)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 22:11:13 UTC (rev 280200)
@@ -1,5 +1,14 @@
 2021-07-22  Eric Hutchison  
 
+[BigSur Debug] imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.worker.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=222385.
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2021-07-22  Eric Hutchison  
+
 [BigSur wk2 arm64] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html is a flaky failure.
 https://bugs.webkit.org/show_bug.cgi?id=228197.
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (280199 => 280200)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-07-22 22:07:52 UTC (rev 280199)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-07-22 22:11:13 UTC (rev 280200)
@@ -2364,5 +2364,7 @@
 
 webkit.org/b/228168 imported/w3c/web-platform-tests/webmessaging/broadcastchannel/blobs.html [ Pass Failure ]
 
+webkit.org/b/222385 imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.worker.html [ Pass Failure ]
+
 webkit.org/b/227998 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-network-error.sub.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280199] trunk/Source/WebCore

[ysuzuki]

Title: [280199] trunk/Source/WebCore








Revision 280199
Author ysuz...@apple.com
Date 2021-07-22 15:07:52 -0700 (Thu, 22 Jul 2021)


Log Message
Rename AtomicHTMLToken to AtomHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=228196

Reviewed by Geoffrey Garen.

We should rename AtomicHTMLToken to AtomHTMLToken as we did for AtomString (AtomicString => AtomString).

* WebCore.xcodeproj/project.pbxproj:
* html/parser/AtomHTMLToken.h: Renamed from Source/WebCore/html/parser/AtomicHTMLToken.h.
(WebCore::AtomHTMLToken::AtomHTMLToken):
(WebCore::AtomHTMLToken::type const):
(WebCore::AtomHTMLToken::name const):
(WebCore::AtomHTMLToken::setName):
(WebCore::AtomHTMLToken::selfClosing const):
(WebCore::AtomHTMLToken::attributes):
(WebCore::AtomHTMLToken::attributes const):
(WebCore::AtomHTMLToken::characters const):
(WebCore::AtomHTMLToken::charactersLength const):
(WebCore::AtomHTMLToken::charactersIsAll8BitData const):
(WebCore::AtomHTMLToken::comment const):
(WebCore::AtomHTMLToken::forceQuirks const):
(WebCore::AtomHTMLToken::publicIdentifier const):
(WebCore::AtomHTMLToken::systemIdentifier const):
(WebCore::AtomHTMLToken::initializeAttributes):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::setAttributes):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertHTMLElementOrFindCustomElementInterface):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
* html/parser/HTMLConstructionSite.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
* html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::HTMLStackItem):
(WebCore::HTMLStackItem::create):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::constructTree):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::shouldClose):
(WebCore::adjustSVGTagNameCase):
(WebCore::adjustAttributes):
(WebCore::adjustSVGAttributes):
(WebCore::adjustMathMLAttributes):
(WebCore::adjustForeignAttributes):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::insertGenericHTMLElement):
(WebCore::HTMLTreeBuilder::processTemplateStartTag):
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFileForInTemplateContents):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::insertPhoneNumberLink):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::hasAttribute):

[webkit-changes] [280198] trunk

[sbarati]

Title: [280198] trunk








Revision 280198
Author sbar...@apple.com
Date 2021-07-22 14:37:02 -0700 (Thu, 22 Jul 2021)


Log Message
AirStackSlot's uint16_t byte size is too small
https://bugs.webkit.org/show_bug.cgi?id=228193


Reviewed by Mark Lam.

JSTests:

* stress/stack-slot-needs-to-use-more-than-uint16.js: Added.

Source/_javascript_Core:

* b3/B3Procedure.cpp:
(JSC::B3::Procedure::addStackSlot):
* b3/B3Procedure.h:
* b3/air/AirCode.cpp:
(JSC::B3::Air::Code::addStackSlot):
* b3/air/AirCode.h:
* b3/air/AirStackSlot.cpp:
(JSC::B3::Air::StackSlot::StackSlot):
* b3/air/AirStackSlot.h:
(JSC::B3::Air::StackSlot::ensureSize):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
* ftl/FTLOutput.cpp:
(JSC::FTL::Output::lockedStackSlot):
* ftl/FTLOutput.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3Procedure.cpp
trunk/Source/_javascript_Core/b3/B3Procedure.h
trunk/Source/_javascript_Core/b3/air/AirCode.cpp
trunk/Source/_javascript_Core/b3/air/AirCode.h
trunk/Source/_javascript_Core/b3/air/AirStackSlot.cpp
trunk/Source/_javascript_Core/b3/air/AirStackSlot.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/ftl/FTLOutput.cpp
trunk/Source/_javascript_Core/ftl/FTLOutput.h


Added Paths

trunk/JSTests/stress/stack-slot-needs-to-use-more-than-uint16.js




Diff

Modified: trunk/JSTests/ChangeLog (280197 => 280198)

--- trunk/JSTests/ChangeLog	2021-07-22 21:30:12 UTC (rev 280197)
+++ trunk/JSTests/ChangeLog	2021-07-22 21:37:02 UTC (rev 280198)
@@ -1,3 +1,13 @@
+2021-07-22  Saam Barati  
+
+AirStackSlot's uint16_t byte size is too small
+https://bugs.webkit.org/show_bug.cgi?id=228193
+
+
+Reviewed by Mark Lam.
+
+* stress/stack-slot-needs-to-use-more-than-uint16.js: Added.
+
 2021-07-20  Yusuke Suzuki  
 
 [JSC] invalidParameterInstanceofSourceAppender should care direct call of Symbol.hasInstance


Added: trunk/JSTests/stress/stack-slot-needs-to-use-more-than-uint16.js (0 => 280198)

--- trunk/JSTests/stress/stack-slot-needs-to-use-more-than-uint16.js	(rev 0)
+++ trunk/JSTests/stress/stack-slot-needs-to-use-more-than-uint16.js	2021-07-22 21:37:02 UTC (rev 280198)
@@ -0,0 +1,8 @@
+//@ skip if $buildType == "debug"
+
+let script = '_,'.repeat(5000);
+script += '';
+let g = new Function(script, 'if (0) g();');
+for (let i = 0; i < 1000; ++i) {
+  g(0);
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (280197 => 280198)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-22 21:30:12 UTC (rev 280197)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-22 21:37:02 UTC (rev 280198)
@@ -1,5 +1,29 @@
 2021-07-22  Saam Barati  
 
+AirStackSlot's uint16_t byte size is too small
+https://bugs.webkit.org/show_bug.cgi?id=228193
+
+
+Reviewed by Mark Lam.
+
+* b3/B3Procedure.cpp:
+(JSC::B3::Procedure::addStackSlot):
+* b3/B3Procedure.h:
+* b3/air/AirCode.cpp:
+(JSC::B3::Air::Code::addStackSlot):
+* b3/air/AirCode.h:
+* b3/air/AirStackSlot.cpp:
+(JSC::B3::Air::StackSlot::StackSlot):
+* b3/air/AirStackSlot.h:
+(JSC::B3::Air::StackSlot::ensureSize):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::lower):
+* ftl/FTLOutput.cpp:
+(JSC::FTL::Output::lockedStackSlot):
+* ftl/FTLOutput.h:
+
+2021-07-22  Saam Barati  
+
 Fix uses of Dependency::fence with respect to the compiler outsmarting us
 https://bugs.webkit.org/show_bug.cgi?id=227757
 


Modified: trunk/Source/_javascript_Core/b3/B3Procedure.cpp (280197 => 280198)

--- trunk/Source/_javascript_Core/b3/B3Procedure.cpp	2021-07-22 21:30:12 UTC (rev 280197)
+++ trunk/Source/_javascript_Core/b3/B3Procedure.cpp	2021-07-22 21:37:02 UTC (rev 280198)
@@ -73,7 +73,7 @@
 return result;
 }
 
-Air::StackSlot* Procedure::addStackSlot(unsigned byteSize)
+Air::StackSlot* Procedure::addStackSlot(uint64_t byteSize)
 {
 return m_code->addStackSlot(byteSize, Air::StackSlotKind::Locked);
 }


Modified: trunk/Source/_javascript_Core/b3/B3Procedure.h (280197 => 280198)

--- trunk/Source/_javascript_Core/b3/B3Procedure.h	2021-07-22 21:30:12 UTC (rev 280197)
+++ trunk/Source/_javascript_Core/b3/B3Procedure.h	2021-07-22 21:37:02 UTC (rev 280198)
@@ -114,7 +114,7 @@
 setBlockOrderImpl(blocks);
 }
 
-JS_EXPORT_PRIVATE Air::StackSlot* addStackSlot(unsigned byteSize);
+JS_EXPORT_PRIVATE Air::StackSlot* addStackSlot(uint64_t byteSize);
 JS_EXPORT_PRIVATE Variable* addVariable(Type);
 
 JS_EXPORT_PRIVATE Type addTuple(Vector&& types);


Modified: trunk/Source/_javascript_Core/b3/air/AirCode.cpp (280197 => 280198)

--- trunk/Source/_javascript_Core/b3/air/AirCode.cpp	2021-07-22 21:30:12 UTC (rev 280197)
+++ trunk/Source/_javascript_Core/b3/air/AirCode.cpp	2021-07-22 21:37:02 UTC (rev 280198)
@@ 

[webkit-changes] [280197] trunk/LayoutTests

[ehutchison]

Title: [280197] trunk/LayoutTests








Revision 280197
Author ehutchi...@apple.com
Date 2021-07-22 14:30:12 -0700 (Thu, 22 Jul 2021)


Log Message
[BigSur wk2 arm64] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=228197.

Unreviewwed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280196 => 280197)

--- trunk/LayoutTests/ChangeLog	2021-07-22 20:59:06 UTC (rev 280196)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 21:30:12 UTC (rev 280197)
@@ -1,3 +1,12 @@
+2021-07-22  Eric Hutchison  
+
+[BigSur wk2 arm64] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=228197.
+
+Unreviewwed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-07-22  Truitt Savell  
 
 Migrate Monterey expectations to OpenSource and bump version numbers


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280196 => 280197)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 20:59:06 UTC (rev 280196)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 21:30:12 UTC (rev 280197)
@@ -1599,5 +1599,7 @@
 
 webkit.org/b/228189 http/tests/media/hls/hls-webvtt-seek-backwards.html [ Pass Timeout ]
 
+webkit.org/b/228197 [ arm64 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html [ Pass Failure ]
+
 webkit.org/b/228087 media/video-seek-with-negative-playback.html [ Pass Failure ]
  
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280195] trunk/Source

[sbarati]

Title: [280195] trunk/Source








Revision 280195
Author sbar...@apple.com
Date 2021-07-22 13:05:09 -0700 (Thu, 22 Jul 2021)


Log Message
Fix uses of Dependency::fence with respect to the compiler outsmarting us
https://bugs.webkit.org/show_bug.cgi?id=227757


Reviewed by Robin Morisset.

Source/_javascript_Core:

We were running into issues on arm64 with respect to the memory model
ordering of loads, and how the compiler optimized code around Dependency::fence.
The issue manifested as calls to isMarked incorrectly returning true.

To see the issue, let's consider a program like this:
a = load(p1)
b = load(p2)
if (a != b) return;
d = Dependency::fence(b)

At the point of defining the dependency, the compiler has proven
a == b. So, instead of building the dependency on the register used
for b, we end up using the register for a. So the actual compiled
code ends up with a dependency on load(p1), not load(p2).

To fix this, we end up adding a new API, Dependency::loadEndFence(pointer,
result), which is defined as:

template
static Dependency loadAndFence(T* pointer, T& output)
{
T value = *opaque(pointer);
Dependency dependency = Dependency::fence(value);
output = opaque(value);
return dependency;
}

The reason for this is that it split "b" in the above program into two values,
and the "b" the program compares against is not known to the compiler to be
the same value that we build a dependency on.

* heap/MarkedBlock.h:
(JSC::MarkedBlock::aboutToMark):
(JSC::MarkedBlock::isMarked):
* runtime/JSObject.cpp:
(JSC::JSObject::visitButterflyImpl):
* runtime/JSObject.h:
(JSC::JSObject::fencedButterfly):
* runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayEntry::getConcurrently):
(JSC::SparseArrayEntry::getConcurrently const): Deleted.
* runtime/SparseArrayValueMap.h:
* runtime/Structure.h:
(JSC::Structure::fencedIndexingMode):
* runtime/StructureIDBlob.h:
(JSC::StructureIDBlob::fencedIndexingModeIncludingHistory):

Source/WTF:

* wtf/Atomics.h:
(WTF::opaque):
(WTF::Dependency::loadAndFence):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MarkedBlock.h
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/SparseArrayValueMap.cpp
trunk/Source/_javascript_Core/runtime/Structure.h
trunk/Source/_javascript_Core/runtime/StructureIDBlob.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280194 => 280195)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-22 20:04:10 UTC (rev 280194)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-22 20:05:09 UTC (rev 280195)
@@ -1,3 +1,58 @@
+2021-07-22  Saam Barati  
+
+Fix uses of Dependency::fence with respect to the compiler outsmarting us
+https://bugs.webkit.org/show_bug.cgi?id=227757
+
+
+Reviewed by Robin Morisset.
+
+We were running into issues on arm64 with respect to the memory model
+ordering of loads, and how the compiler optimized code around Dependency::fence.
+The issue manifested as calls to isMarked incorrectly returning true.
+
+To see the issue, let's consider a program like this:
+a = load(p1)
+b = load(p2)
+if (a != b) return;
+d = Dependency::fence(b)
+
+At the point of defining the dependency, the compiler has proven
+a == b. So, instead of building the dependency on the register used
+for b, we end up using the register for a. So the actual compiled
+code ends up with a dependency on load(p1), not load(p2).
+
+To fix this, we end up adding a new API, Dependency::loadEndFence(pointer,
+result), which is defined as:
+
+template
+static Dependency loadAndFence(T* pointer, T& output)
+{
+T value = *opaque(pointer);
+Dependency dependency = Dependency::fence(value);
+output = opaque(value);
+return dependency;
+}
+
+The reason for this is that it split "b" in the above program into two values,
+and the "b" the program compares against is not known to the compiler to be
+the same value that we build a dependency on.
+
+* heap/MarkedBlock.h:
+(JSC::MarkedBlock::aboutToMark):
+(JSC::MarkedBlock::isMarked):
+* runtime/JSObject.cpp:
+(JSC::JSObject::visitButterflyImpl):
+* runtime/JSObject.h:
+(JSC::JSObject::fencedButterfly):
+* runtime/SparseArrayValueMap.cpp:
+(JSC::SparseArrayEntry::getConcurrently):
+(JSC::SparseArrayEntry::getConcurrently const): Deleted.
+* runtime/SparseArrayValueMap.h:
+* runtime/Structure.h:
+(JSC::Structure::fencedIndexingMode):
+* runtime/StructureIDBlob.h:
+(JSC::StructureIDBlob::fencedIndexingModeIncludingHistory):
+
 

[webkit-changes] [280194] trunk/Source/WTF

[ysuzuki]

Title: [280194] trunk/Source/WTF








Revision 280194
Author ysuz...@apple.com
Date 2021-07-22 13:04:10 -0700 (Thu, 22 Jul 2021)


Log Message
Unreviewed, follow-up after r280193
https://bugs.webkit.org/show_bug.cgi?id=228142

I accidentally reverted auto change when switching branches.

* wtf/text/AtomStringImpl.cpp:
(WTF::UCharBufferTranslator::equal):
(WTF::LCharBufferTranslator::equal):
(WTF::BufferFromStaticDataTranslator::equal):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/AtomStringImpl.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (280193 => 280194)

--- trunk/Source/WTF/ChangeLog	2021-07-22 19:18:45 UTC (rev 280193)
+++ trunk/Source/WTF/ChangeLog	2021-07-22 20:04:10 UTC (rev 280194)
@@ -1,5 +1,17 @@
 2021-07-22  Yusuke Suzuki  
 
+Unreviewed, follow-up after r280193
+https://bugs.webkit.org/show_bug.cgi?id=228142
+
+I accidentally reverted auto change when switching branches.
+
+* wtf/text/AtomStringImpl.cpp:
+(WTF::UCharBufferTranslator::equal):
+(WTF::LCharBufferTranslator::equal):
+(WTF::BufferFromStaticDataTranslator::equal):
+
+2021-07-22  Yusuke Suzuki  
+
 Micro-optimize innerHTML
 https://bugs.webkit.org/show_bug.cgi?id=228142
 


Modified: trunk/Source/WTF/wtf/text/AtomStringImpl.cpp (280193 => 280194)

--- trunk/Source/WTF/wtf/text/AtomStringImpl.cpp	2021-07-22 19:18:45 UTC (rev 280193)
+++ trunk/Source/WTF/wtf/text/AtomStringImpl.cpp	2021-07-22 20:04:10 UTC (rev 280194)
@@ -127,7 +127,7 @@
 
 static bool equal(PackedPtr const& str, const UCharBuffer& buf)
 {
-StringImpl* impl = str.get();
+auto* impl = str.get();
 if (impl->existingHash() != buf.hash)
 return false;
 return WTF::equal(impl, buf.characters, buf.length);
@@ -310,7 +310,7 @@
 
 static bool equal(PackedPtr const& str, const LCharBuffer& buf)
 {
-StringImpl* impl = str.get();
+auto* impl = str.get();
 if (impl->existingHash() != buf.hash)
 return false;
 return WTF::equal(impl, buf.characters, buf.length);
@@ -335,7 +335,7 @@
 
 static bool equal(PackedPtr const& str, const Buffer& buf)
 {
-StringImpl* impl = str.get();
+auto* impl = str.get();
 if (impl->existingHash() != buf.hash)
 return false;
 return WTF::equal(impl, buf.characters, buf.length);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280193] trunk

[ysuzuki]

Title: [280193] trunk








Revision 280193
Author ysuz...@apple.com
Date 2021-07-22 12:18:45 -0700 (Thu, 22 Jul 2021)


Log Message
Micro-optimize innerHTML
https://bugs.webkit.org/show_bug.cgi?id=228142

Reviewed by Simon Fraser.

Source/WebCore:

No behavior change.

This patch does some micro optimizations revealed by the profiler when running some of Speedometer2 tests which intensively use innerHTML.
This offers improvement in jQuery-TodoMVC and Vanilla-ES2015-Babel-Webpack-TodoMVC since both are super innerHTML heavy benchmarks.

--
|   subtest| ms  | ms  |  b / a   | pValue (significance using False Discovery Rate) |
--
| Elm-TodoMVC  |126.862500   |126.687500   |0.998621  | 0.673462 |
| VueJS-TodoMVC|27.775000|27.645833|0.995350  | 0.741588 |
| EmberJS-TodoMVC  |129.35   |129.129167   |0.998293  | 0.624196 |
| BackboneJS-TodoMVC   |51.129167|51.204167|1.001467  | 0.716622 |
| Preact-TodoMVC   |21.870833|21.337500|0.975614  | 0.217771 |
| AngularJS-TodoMVC|139.854167   |140.27   |1.002950  | 0.489838 |
| Vanilla-ES2015-TodoMVC   |69.229167|68.895833|0.995185  | 0.238772 |
| Inferno-TodoMVC  |68.391667|68.27|0.998172  | 0.762281 |
| Flight-TodoMVC   |77.979167|78.17|1.002404  | 0.710324 |
| Angular2-TypeScript-TodoMVC  |39.741667|39.97|1.005662  | 0.524123 |
| VanillaJS-TodoMVC|55.416667|55.512500|1.001729  | 0.781447 |
| jQuery-TodoMVC   |268.812500   |266.97   |0.993133  | 0.003384 (significant)   |
| EmberJS-Debug-TodoMVC|345.38   |345.662500   |1.000808  | 0.695259 |
| React-TodoMVC|90.679167|90.179167|0.994486  | 0.067477 |
| React-Redux-TodoMVC  |152.691667   |152.687500   |0.73  | 0.991207 |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |66.487500|65.729167|0.988594  | 0.000118 (significant)   |
--

a mean = 242.12319
b mean = 242.80485
pValue = 0.1992654128
(Bigger means are better.)
1.003 times better
Results ARE NOT significant

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertTextNode):
* html/parser/HTMLConstructionSite.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizerLoop): We do not need to call `shrinkToBestFit` in fragment parsing case since
we will discard HTMLToken soon.
* html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLPreloadScanner::scan):
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::clear): We found that these `clear` calls cause performance problem according to the Instruments: we
repeatedly use this Vector, and we repeatedly allocate and deallocate this Vector unnecessarily. We use `resize(0)` instead
to avoid this allocation and deallocation.
(WebCore::HTMLToken::shrinkToBestFit): But HTMLToken is kept so long, so at some point, we would like to make backing storage
small. So, we add shrinkToBestFit and we call it only after finishing batching of HTMLToken processing.
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
* html/parser/HTMLTokenizer.h:
(WebCore::HTMLTokenizer::shrinkToBestFit):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::characterPredicate):
(WebCore::HTMLTreeBuilder::insertPhoneNumberLink):
(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody):
(WebCore::HTMLTreeBuilder::defaultForInTableText):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processFakeCharacters): Deleted. It is dead code 

[webkit-changes] [280192] trunk/LayoutTests

[ayumi_kojima]

Title: [280192] trunk/LayoutTests








Revision 280192
Author ayumi_koj...@apple.com
Date 2021-07-22 12:13:01 -0700 (Thu, 22 Jul 2021)


Log Message
REGRESSION: [iOS] ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener().
https://bugs.webkit.org/show_bug.cgi?id=228038

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280191 => 280192)

--- trunk/LayoutTests/ChangeLog	2021-07-22 19:12:21 UTC (rev 280191)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 19:13:01 UTC (rev 280192)
@@ -1,3 +1,12 @@
+2021-07-22  Ayumi Kojima  
+
+REGRESSION: [iOS] ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener().
+https://bugs.webkit.org/show_bug.cgi?id=228038
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-07-22  Eric Hutchison  
 
 [Mac wk2] http/tests/media/hls/hls-webvtt-seek-backwards.html is a flaky timeout.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (280191 => 280192)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-22 19:12:21 UTC (rev 280191)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-22 19:13:01 UTC (rev 280192)
@@ -1398,6 +1398,14 @@
 
 webkit.org/b/208590 [ Debug ] fast/events/beforeunload-prompt.html [ Pass Crash ]
 
+webkit.org/b/228038 [ Debug ] fast/events/tabindex-focus-blur-all.html [ Pass Crash ]
+webkit.org/b/228038 [ Debug ] fast/mediastream/apply-constraints-video.html [ Pass Crash ]
+webkit.org/b/228038 media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html [ Pass Crash ]
+webkit.org/b/228038 [ Debug ] media/non-existent-video-playback-interrupted.html  [ Pass Crash ]
+webkit.org/b/228038 [ Debug ] media/media-can-play-av1.html  [ Pass Crash ] 
+webkit.org/b/228038 [ Debug ] media/modern-media-controls/mute-button/mute-button.html  [ Pass Crash ] 
+webkit.org/b/228038 [ Debug ] fast/mediastream/audio-bad-sampleRate.html  [ Pass Crash ] 
+
 webkit.org/b/208656 storage/indexeddb/modern/transactions-stop-on-navigation.html [ Pass Failure ]
 
 webkit.org/b/208662 http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-by-default-src-star.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280191] trunk/Source/JavaScriptCore

[keith_miller]

Title: [280191] trunk/Source/_javascript_Core








Revision 280191
Author keith_mil...@apple.com
Date 2021-07-22 12:12:21 -0700 (Thu, 22 Jul 2021)


Log Message
useProfiler option should automatically disable concurrent JIT
https://bugs.webkit.org/show_bug.cgi?id=228152

Reviewed by Saam Barati.

The bytecode profiler is not thread safe so we should have
recomputeDependentOptions() disable concurrent JIT. Also, fix the
jsc CLI to set the useProfiler option rather than have its own
state. Note, we call Options::setOption() rather than setting the
Options::useProfiler() option directly as setOption calls
recomputeDependentOptions() for us.

* jsc.cpp:
(CommandLine::parseArguments):
(runJSC):
* runtime/Options.cpp:
(JSC::Options::recomputeDependentOptions):
(JSC::Options::ensureOptionsAreCoherent):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/Options.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280190 => 280191)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-22 19:00:36 UTC (rev 280190)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-22 19:12:21 UTC (rev 280191)
@@ -1,3 +1,24 @@
+2021-07-22  Keith Miller  
+
+useProfiler option should automatically disable concurrent JIT
+https://bugs.webkit.org/show_bug.cgi?id=228152
+
+Reviewed by Saam Barati.
+
+The bytecode profiler is not thread safe so we should have
+recomputeDependentOptions() disable concurrent JIT. Also, fix the
+jsc CLI to set the useProfiler option rather than have its own
+state. Note, we call Options::setOption() rather than setting the
+Options::useProfiler() option directly as setOption calls
+recomputeDependentOptions() for us.
+
+* jsc.cpp:
+(CommandLine::parseArguments):
+(runJSC):
+* runtime/Options.cpp:
+(JSC::Options::recomputeDependentOptions):
+(JSC::Options::ensureOptionsAreCoherent):
+
 2021-07-21  Yijia Huang  
 
 Fix type check error in testb3


Modified: trunk/Source/_javascript_Core/jsc.cpp (280190 => 280191)

--- trunk/Source/_javascript_Core/jsc.cpp	2021-07-22 19:00:36 UTC (rev 280190)
+++ trunk/Source/_javascript_Core/jsc.cpp	2021-07-22 19:12:21 UTC (rev 280191)
@@ -429,7 +429,6 @@
 bool m_module { false };
 bool m_exitCode { false };
 bool m_destroyVM { false };
-bool m_profile { false };
 bool m_treatWatchdogExceptionAsSuccess { false };
 bool m_alwaysDumpUncaughtException { false };
 bool m_dumpMemoryFootprint { false };
@@ -3265,7 +3264,7 @@
 if (!strcmp(arg, "-p")) {
 if (++i == argc)
 printUsageStatement();
-m_profile = true;
+Options::setOption("useProfiler=1");
 m_profilerOutput = argv[i];
 continue;
 }
@@ -3454,9 +3453,6 @@
 JSLockHolder locker(vm);
 
 startTimeoutThreadIfNeeded(vm);
-if (options.m_profile && !vm.m_perBytecodeProfiler)
-vm.m_perBytecodeProfiler = makeUnique(vm);
-
 globalObject = GlobalObject::create(vm, GlobalObject::createStructure(vm, jsNull()), options.m_arguments);
 globalObject->setRemoteDebuggingEnabled(options.m_enableRemoteDebugging);
 func(vm, globalObject, success);
@@ -3478,7 +3474,7 @@
 printf("\n");
 }
 
-if (options.m_profile) {
+if (Options::useProfiler()) {
 JSLockHolder locker(vm);
 if (!vm.m_perBytecodeProfiler->save(options.m_profilerOutput.utf8().data()))
 fprintf(stderr, "could not save profiler output.\n");


Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (280190 => 280191)

--- trunk/Source/_javascript_Core/runtime/Options.cpp	2021-07-22 19:00:36 UTC (rev 280190)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2021-07-22 19:12:21 UTC (rev 280191)
@@ -508,6 +508,9 @@
 Options::useConcurrentJIT() = false;
 }
 
+if (Options::useProfiler())
+Options::useConcurrentJIT() = false;
+
 if (Options::alwaysUseShadowChicken())
 Options::maximumInliningDepth() = 1;
 
@@ -1037,6 +1040,10 @@
 coherent = false;
 dataLog("INCOHERENT OPTIONS: at least one of useWasmLLInt or useBBQJIT must be true\n");
 }
+if (useProfiler() && useConcurrentJIT()) {
+coherent = false;
+dataLogLn("Bytecode profiler is not concurrent JIT safe.");
+}
 if (!coherent)
 CRASH();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280190] trunk/Source/WebCore

[wenson_hsieh]

Title: [280190] trunk/Source/WebCore








Revision 280190
Author wenson_hs...@apple.com
Date 2021-07-22 12:00:36 -0700 (Thu, 22 Jul 2021)


Log Message
Rename EventHandler::m_textRecognitionHoverTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=228183
rdar://78933684

Reviewed by Tim Horton.

When upstreaming support for Live Text in WebKit, I accidentally renamed the method
`imageExtractionTimerFired()` to `m_textRecognitionHoverTimerFired()`.

* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::textRecognitionHoverTimerFired):
(WebCore::EventHandler::m_textRecognitionHoverTimerFired): Deleted.
* page/EventHandler.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (280189 => 280190)

--- trunk/Source/WebCore/ChangeLog	2021-07-22 18:26:36 UTC (rev 280189)
+++ trunk/Source/WebCore/ChangeLog	2021-07-22 19:00:36 UTC (rev 280190)
@@ -1,3 +1,20 @@
+2021-07-22  Wenson Hsieh  
+
+Rename EventHandler::m_textRecognitionHoverTimerFired()
+https://bugs.webkit.org/show_bug.cgi?id=228183
+rdar://78933684
+
+Reviewed by Tim Horton.
+
+When upstreaming support for Live Text in WebKit, I accidentally renamed the method
+`imageExtractionTimerFired()` to `m_textRecognitionHoverTimerFired()`.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::EventHandler):
+(WebCore::EventHandler::textRecognitionHoverTimerFired):
+(WebCore::EventHandler::m_textRecognitionHoverTimerFired): Deleted.
+* page/EventHandler.h:
+
 2021-07-22  Alex Christensen  
 
 XHR.send(Document) should replace mismatched surrogates with replacement character before sending


Modified: trunk/Source/WebCore/page/EventHandler.cpp (280189 => 280190)

--- trunk/Source/WebCore/page/EventHandler.cpp	2021-07-22 18:26:36 UTC (rev 280189)
+++ trunk/Source/WebCore/page/EventHandler.cpp	2021-07-22 19:00:36 UTC (rev 280190)
@@ -326,7 +326,7 @@
 : m_frame(frame)
 , m_hoverTimer(*this, ::hoverTimerFired)
 #if ENABLE(IMAGE_ANALYSIS)
-, m_textRecognitionHoverTimer(*this, ::m_textRecognitionHoverTimerFired, 250_ms)
+, m_textRecognitionHoverTimer(*this, ::textRecognitionHoverTimerFired, 250_ms)
 #endif
 , m_autoscrollController(makeUnique())
 #if !ENABLE(IOS_TOUCH_EVENTS)
@@ -3392,7 +3392,7 @@
 
 #if ENABLE(IMAGE_ANALYSIS)
 
-void EventHandler::m_textRecognitionHoverTimerFired()
+void EventHandler::textRecognitionHoverTimerFired()
 {
 if (!m_elementUnderMouse || !is(m_elementUnderMouse->renderer()))
 return;


Modified: trunk/Source/WebCore/page/EventHandler.h (280189 => 280190)

--- trunk/Source/WebCore/page/EventHandler.h	2021-07-22 18:26:36 UTC (rev 280189)
+++ trunk/Source/WebCore/page/EventHandler.h	2021-07-22 19:00:36 UTC (rev 280190)
@@ -393,7 +393,7 @@
 void hoverTimerFired();
 
 #if ENABLE(IMAGE_ANALYSIS)
-void m_textRecognitionHoverTimerFired();
+void textRecognitionHoverTimerFired();
 #endif
 
 bool logicalScrollOverflow(ScrollLogicalDirection, ScrollGranularity, Node* startingNode = nullptr);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280189] trunk/LayoutTests

[ehutchison]

Title: [280189] trunk/LayoutTests








Revision 280189
Author ehutchi...@apple.com
Date 2021-07-22 11:26:36 -0700 (Thu, 22 Jul 2021)


Log Message
[Mac wk2] http/tests/media/hls/hls-webvtt-seek-backwards.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=228189.

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280188 => 280189)

--- trunk/LayoutTests/ChangeLog	2021-07-22 18:18:39 UTC (rev 280188)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 18:26:36 UTC (rev 280189)
@@ -1,3 +1,12 @@
+2021-07-22  Eric Hutchison  
+
+[Mac wk2] http/tests/media/hls/hls-webvtt-seek-backwards.html is a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=228189.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-07-22  Sihui Liu  
 
 [macOS Debug] Layout Test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280188 => 280189)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 18:18:39 UTC (rev 280188)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-22 18:26:36 UTC (rev 280189)
@@ -1404,5 +1404,7 @@
 
 webkit.org/b/228030 inspector/canvas/setShaderProgramHighlighted.html [ Pass Failure Timeout ]
 
+webkit.org/b/228189 http/tests/media/hls/hls-webvtt-seek-backwards.html [ Pass Timeout ]
+
 webkit.org/b/228087 media/video-seek-with-negative-playback.html [ Pass Failure ]
  
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280188] tags/Safari-612.1.24.11.1/

[repstein]

Title: [280188] tags/Safari-612.1.24.11.1/








Revision 280188
Author repst...@apple.com
Date 2021-07-22 11:18:39 -0700 (Thu, 22 Jul 2021)


Log Message
Tag Safari-612.1.24.11.1.

Added Paths

tags/Safari-612.1.24.11.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280186] branches/safari-612.1.24.11-branch

[repstein]

Title: [280186] branches/safari-612.1.24.11-branch








Revision 280186
Author repst...@apple.com
Date 2021-07-22 11:10:43 -0700 (Thu, 22 Jul 2021)


Log Message
Cherry-pick r280050. rdar://problem/80851606

[JSC] InByStatus / InByVariant should visit CacheableIdentifier
https://bugs.webkit.org/show_bug.cgi?id=228088
rdar://80794604

Reviewed by Mark Lam.

JSTests:

* stress/in-by-variant-should-mark-cacheable-identifier.js: Added.
(foo):
(let.handler.has):

Source/_javascript_Core:

After r278445, InByVariant holds CacheableIdentifier. And this can have
String/Symbol cells if this variant is generated by in_by_val. In that
case, we must visit this cell as GetByStatus / GetByVariant are doing.

* bytecode/InByStatus.cpp:
(JSC::InByStatus::visitAggregateImpl):
* bytecode/InByStatus.h:
* bytecode/InByVariant.cpp:
(JSC::InByVariant::visitAggregateImpl):
* bytecode/InByVariant.h:
* bytecode/RecordedStatuses.cpp:
(JSC::RecordedStatuses::visitAggregateImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.24.11-branch/JSTests/ChangeLog
branches/safari-612.1.24.11-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/InByStatus.cpp
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/InByStatus.h
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/InByVariant.cpp
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/InByVariant.h
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/RecordedStatuses.cpp


Added Paths

branches/safari-612.1.24.11-branch/JSTests/stress/in-by-variant-should-mark-cacheable-identifier.js




Diff

Modified: branches/safari-612.1.24.11-branch/JSTests/ChangeLog (280185 => 280186)

--- branches/safari-612.1.24.11-branch/JSTests/ChangeLog	2021-07-22 18:10:39 UTC (rev 280185)
+++ branches/safari-612.1.24.11-branch/JSTests/ChangeLog	2021-07-22 18:10:43 UTC (rev 280186)
@@ -1,3 +1,48 @@
+2021-07-20  Ruben Turcios  
+
+Cherry-pick r280050. rdar://problem/80851606
+
+[JSC] InByStatus / InByVariant should visit CacheableIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=228088
+rdar://80794604
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* stress/in-by-variant-should-mark-cacheable-identifier.js: Added.
+(foo):
+(let.handler.has):
+
+Source/_javascript_Core:
+
+After r278445, InByVariant holds CacheableIdentifier. And this can have
+String/Symbol cells if this variant is generated by in_by_val. In that
+case, we must visit this cell as GetByStatus / GetByVariant are doing.
+
+* bytecode/InByStatus.cpp:
+(JSC::InByStatus::visitAggregateImpl):
+* bytecode/InByStatus.h:
+* bytecode/InByVariant.cpp:
+(JSC::InByVariant::visitAggregateImpl):
+* bytecode/InByVariant.h:
+* bytecode/RecordedStatuses.cpp:
+(JSC::RecordedStatuses::visitAggregateImpl):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-19  Yusuke Suzuki  
+
+[JSC] InByStatus / InByVariant should visit CacheableIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=228088
+rdar://80794604
+
+Reviewed by Mark Lam.
+
+* stress/in-by-variant-should-mark-cacheable-identifier.js: Added.
+(foo):
+(let.handler.has):
+
 2021-07-14  Keith Miller  
 
 Unreviewed, test gardening.


Added: branches/safari-612.1.24.11-branch/JSTests/stress/in-by-variant-should-mark-cacheable-identifier.js (0 => 280186)

--- branches/safari-612.1.24.11-branch/JSTests/stress/in-by-variant-should-mark-cacheable-identifier.js	(rev 0)
+++ branches/safari-612.1.24.11-branch/JSTests/stress/in-by-variant-should-mark-cacheable-identifier.js	2021-07-22 18:10:43 UTC (rev 280186)
@@ -0,0 +1,24 @@
+//@ runDefault("--slowPathAllocsBetweenGCs=13")
+function foo(object) {
+  'hello' in object;
+}
+
+let handler = {
+  has(_, keyArg) {
+keyArg in targetObject;
+  }
+};
+let targetObject = {};
+let proxy = new Proxy(targetObject, handler);
+for (let i = 0; i < 1; ++i) {
+  foo(proxy);
+}
+targetObject.hello = undefined;
+gc();
+for (let i = 0; i < 1; ++i) {
+  foo(proxy);
+}
+delete targetObject?.hello;
+for (let i = 0; i < 10; ++i) {
+  foo(proxy);
+}


Modified: branches/safari-612.1.24.11-branch/Source/_javascript_Core/ChangeLog (280185 => 280186)

--- branches/safari-612.1.24.11-branch/Source/_javascript_Core/ChangeLog	2021-07-22 18:10:39 UTC (rev 280185)
+++ branches/safari-612.1.24.11-branch/Source/_javascript_Core/ChangeLog	2021-07-22 18:10:43 UTC (rev 280186)
@@ -1,3 +1,57 @@
+2021-07-20  Ruben Turcios  
+
+Cherry-pick r280050. rdar://problem/80851606
+
+[JSC] 

[webkit-changes] [280187] branches/safari-612.1.24.11-branch/Source/JavaScriptCore

[repstein]

Title: [280187] branches/safari-612.1.24.11-branch/Source/_javascript_Core








Revision 280187
Author repst...@apple.com
Date 2021-07-22 11:10:47 -0700 (Thu, 22 Jul 2021)


Log Message
Cherry-pick r280066. rdar://problem/80851562

[JSC] StructureStubInfo's m_identifier should follow to the same protocol of inlineAccessBaseStructure
https://bugs.webkit.org/show_bug.cgi?id=228092

Reviewed by Saam Barati.

In r279813, we fixed a race condition related to inlineAccessBaseStructure: while we clear inlineAccessBaseStructure,
we still run code relying on this field's value until stub version of the code is generated. As a result,
we run the code which relies on the cells that are already collected. And we have the same problem with
m_identifier field too. This patch makes m_identifier follow to the same protocol of inlineAccessBaseStructure
so that we fix this race issue too: both fields will be alive until we switch to the code that are not relying on these
fields.

We also make inlineAccessBaseStructure to m_inlineAccessBaseStructure to easily find that this is member field.
And we also use setWithoutWriteBarrier for m_inlineAccessBaseStructure since we emit codeBlock->vm().heap.writeBarrier(codeBlock)
immediately after that.

* bytecode/AccessCase.cpp:
(JSC::AccessCase::fromStructureStubInfo):
* bytecode/GetByStatus.cpp:
(JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback):
* bytecode/InByStatus.cpp:
(JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initArrayLength):
(JSC::StructureStubInfo::initStringLength):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::initInByIdSelf):
(JSC::StructureStubInfo::addAccessCase):
(JSC::StructureStubInfo::reset):
(JSC::StructureStubInfo::visitAggregateImpl):
(JSC::StructureStubInfo::visitWeakReferences):
(JSC::StructureStubInfo::propagateTransitions):
(JSC::StructureStubInfo::setCacheType): Deleted.
* bytecode/StructureStubInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.24.11-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/AccessCase.cpp
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/GetByStatus.cpp
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/InByStatus.cpp
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/PutByIdStatus.cpp
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/StructureStubInfo.cpp
branches/safari-612.1.24.11-branch/Source/_javascript_Core/bytecode/StructureStubInfo.h




Diff

Modified: branches/safari-612.1.24.11-branch/Source/_javascript_Core/ChangeLog (280186 => 280187)

--- branches/safari-612.1.24.11-branch/Source/_javascript_Core/ChangeLog	2021-07-22 18:10:43 UTC (rev 280186)
+++ branches/safari-612.1.24.11-branch/Source/_javascript_Core/ChangeLog	2021-07-22 18:10:47 UTC (rev 280187)
@@ -1,5 +1,89 @@
 2021-07-20  Ruben Turcios  
 
+Cherry-pick r280066. rdar://problem/80851562
+
+[JSC] StructureStubInfo's m_identifier should follow to the same protocol of inlineAccessBaseStructure
+https://bugs.webkit.org/show_bug.cgi?id=228092
+
+Reviewed by Saam Barati.
+
+In r279813, we fixed a race condition related to inlineAccessBaseStructure: while we clear inlineAccessBaseStructure,
+we still run code relying on this field's value until stub version of the code is generated. As a result,
+we run the code which relies on the cells that are already collected. And we have the same problem with
+m_identifier field too. This patch makes m_identifier follow to the same protocol of inlineAccessBaseStructure
+so that we fix this race issue too: both fields will be alive until we switch to the code that are not relying on these
+fields.
+
+We also make inlineAccessBaseStructure to m_inlineAccessBaseStructure to easily find that this is member field.
+And we also use setWithoutWriteBarrier for m_inlineAccessBaseStructure since we emit codeBlock->vm().heap.writeBarrier(codeBlock)
+immediately after that.
+
+* bytecode/AccessCase.cpp:
+(JSC::AccessCase::fromStructureStubInfo):
+* bytecode/GetByStatus.cpp:
+(JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback):
+* bytecode/InByStatus.cpp:
+(JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):
+* bytecode/PutByIdStatus.cpp:
+(JSC::PutByIdStatus::computeForStubInfo):
+* bytecode/StructureStubInfo.cpp:
+(JSC::StructureStubInfo::initGetByIdSelf):
+(JSC::StructureStubInfo::initArrayLength):
+

[webkit-changes] [280185] branches/safari-612.1.24.11-branch/Source/WebKit

[repstein]

Title: [280185] branches/safari-612.1.24.11-branch/Source/WebKit








Revision 280185
Author repst...@apple.com
Date 2021-07-22 11:10:39 -0700 (Thu, 22 Jul 2021)


Log Message
Cherry-pick r280001. rdar://problem/80788656

macOS Safari network sessions not being marked as being from a browser
https://bugs.webkit.org/show_bug.cgi?id=228028


Reviewed by Brent Fulgham.

Move WebKitAdditions to open source to communicate full web browser
status to the networking stack. In the macOS case, we don't have
a full browser entitlement, so we should check for Safari.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::SessionWrapper::initialize):
The name com.apple.WebKit.InAppBrowser is not the most accurate name,
but changing it would require syncing with other parts of the network
stack. We should do this in a separate bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog
branches/safari-612.1.24.11-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog (280184 => 280185)

--- branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog	2021-07-22 18:06:14 UTC (rev 280184)
+++ branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog	2021-07-22 18:10:39 UTC (rev 280185)
@@ -1,3 +1,44 @@
+2021-07-19  Ruben Turcios  
+
+Cherry-pick r280001. rdar://problem/80788656
+
+macOS Safari network sessions not being marked as being from a browser
+https://bugs.webkit.org/show_bug.cgi?id=228028
+
+
+Reviewed by Brent Fulgham.
+
+Move WebKitAdditions to open source to communicate full web browser
+status to the networking stack. In the macOS case, we don't have
+a full browser entitlement, so we should check for Safari.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::SessionWrapper::initialize):
+The name com.apple.WebKit.InAppBrowser is not the most accurate name,
+but changing it would require syncing with other parts of the network
+stack. We should do this in a separate bug.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-16  Kate Cheney  
+
+macOS Safari network sessions not being marked as being from a browser
+https://bugs.webkit.org/show_bug.cgi?id=228028
+
+
+Reviewed by Brent Fulgham.
+
+Move WebKitAdditions to open source to communicate full web browser
+status to the networking stack. In the macOS case, we don't have
+a full browser entitlement, so we should check for Safari.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::SessionWrapper::initialize):
+The name com.apple.WebKit.InAppBrowser is not the most accurate name,
+but changing it would require syncing with other parts of the network
+stack. We should do this in a separate bug.
+
 2021-07-14  Jer Noble  
 
 Unreviewed build fix after r279912 (239661@main); Adopt HAVE(SYSTEM_STATUS) macro.


Modified: branches/safari-612.1.24.11-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (280184 => 280185)

--- branches/safari-612.1.24.11-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2021-07-22 18:06:14 UTC (rev 280184)
+++ branches/safari-612.1.24.11-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2021-07-22 18:10:39 UTC (rev 280185)
@@ -64,7 +64,6 @@
 #import 
 
 #if USE(APPLE_INTERNAL_SDK)
-#import 
 
 #if ENABLE(APP_PRIVACY_REPORT) && HAVE(SYMPTOMS_FRAMEWORK)
 #import 
@@ -83,7 +82,6 @@
 #endif
 
 #else
-#define NETWORK_SESSION_COCOA_ADDITIONS_1
 void WebKit::NetworkSessionCocoa::removeNetworkWebsiteData(std::optional, std::optional>&&, CompletionHandler&& completionHandler) { completionHandler(); }
 #endif
 
@@ -1185,9 +1183,14 @@
 void SessionWrapper::initialize(NSURLSessionConfiguration *configuration, NetworkSessionCocoa& networkSession, WebCore::StoredCredentialsPolicy storedCredentialsPolicy, NavigatingToAppBoundDomain isNavigatingToAppBoundDomain)
 {
 UNUSED_PARAM(isNavigatingToAppBoundDomain);
-#if PLATFORM(IOS_FAMILY)
-NETWORK_SESSION_COCOA_ADDITIONS_1
+
+auto isFullBrowser = isParentProcessAFullWebBrowser(networkSession.networkProcess());
+#if PLATFORM(MAC)
+isFullBrowser = WebCore::MacApplication::isSafari();
 #endif
+if (!configuration._sourceApplicationSecondaryIdentifier && isFullBrowser)
+configuration._sourceApplicationSecondaryIdentifier = @"com.apple.WebKit.InAppBrowser";
+
 delegate = adoptNS([[WKNetworkSessionDelegate alloc] initWithNetworkSession:networkSession wrapper:*this withCredentials:storedCredentialsPolicy == WebCore::StoredCredentialsPolicy::Use]);
 

[webkit-changes] [280184] branches/safari-612.1.24.11-branch/Source

[repstein]

Title: [280184] branches/safari-612.1.24.11-branch/Source








Revision 280184
Author repst...@apple.com
Date 2021-07-22 11:06:14 -0700 (Thu, 22 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.24.11.1

Modified Paths

branches/safari-612.1.24.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.24.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (280183 => 280184)

--- branches/safari-612.1.24.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-22 18:04:04 UTC (rev 280183)
+++ branches/safari-612.1.24.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-22 18:06:14 UTC (rev 280184)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 11;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.24.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (280183 => 280184)

--- branches/safari-612.1.24.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-22 18:04:04 UTC (rev 280183)
+++ branches/safari-612.1.24.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-22 18:06:14 UTC (rev 280184)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 11;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.24.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (280183 => 280184)

--- branches/safari-612.1.24.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-22 18:04:04 UTC (rev 280183)
+++ branches/safari-612.1.24.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-22 18:06:14 UTC (rev 280184)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 11;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.24.11-branch/Source/WebCore/Configurations/Version.xcconfig (280183 => 280184)

--- branches/safari-612.1.24.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-22 18:04:04 UTC (rev 280183)
+++ branches/safari-612.1.24.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-22 18:06:14 UTC (rev 280184)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 11;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.24.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (280183 => 280184)

--- branches/safari-612.1.24.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-22 18:04:04 UTC (rev 280183)
+++ branches/safari-612.1.24.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-22 18:06:14 UTC (rev 280184)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);

[webkit-changes] [280183] trunk/Source/WebKit

[timothy_horton]

Title: [280183] trunk/Source/WebKit








Revision 280183
Author timothy_hor...@apple.com
Date 2021-07-22 11:04:04 -0700 (Thu, 22 Jul 2021)


Log Message
REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst
https://bugs.webkit.org/show_bug.cgi?id=228181
rdar://80923581

Reviewed by Dan Bates.

* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
r279992 reorganized this code to determine the contents object and then
set it on the layer, instead of setting it directly; this means that the
lifetime of the contents object must be extended.

Interestingly, the common case (the CAMachPort case), as well as the
case I was actually adding in r279992 both were safe, because of the use
of autorelease. (macCatalyst uses IOSurface as layer contents directly,
without CAMachPort, so uses the one path that r279992 broke).

It is unnecessary to use autorelease; instead just store the contents
object in a RetainPtr until it is set.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (280182 => 280183)

--- trunk/Source/WebKit/ChangeLog	2021-07-22 17:53:43 UTC (rev 280182)
+++ trunk/Source/WebKit/ChangeLog	2021-07-22 18:04:04 UTC (rev 280183)
@@ -1,3 +1,25 @@
+2021-07-22  Tim Horton  
+
+REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst
+https://bugs.webkit.org/show_bug.cgi?id=228181
+rdar://80923581
+
+Reviewed by Dan Bates.
+
+* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
+r279992 reorganized this code to determine the contents object and then
+set it on the layer, instead of setting it directly; this means that the
+lifetime of the contents object must be extended.
+
+Interestingly, the common case (the CAMachPort case), as well as the
+case I was actually adding in r279992 both were safe, because of the use
+of autorelease. (macCatalyst uses IOSurface as layer contents directly,
+without CAMachPort, so uses the one path that r279992 broke).
+
+It is unnecessary to use autorelease; instead just store the contents
+object in a RetainPtr until it is set.
+
 2021-07-22  Megan Gardner  
 
 Avoid Quick Note overlay when scrolling to show a highlight


Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (280182 => 280183)

--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm	2021-07-22 17:53:43 UTC (rev 280182)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm	2021-07-22 18:04:04 UTC (rev 280183)
@@ -426,12 +426,12 @@
 ASSERT(m_bufferHandle);
 layer.contentsOpaque = m_isOpaque;
 
-id contents = nil;
+RetainPtr contents;
 WTF::switchOn(*m_bufferHandle,
 [&] (ShareableBitmap::Handle& handle) {
 ASSERT(m_type == Type::Bitmap);
 auto bitmap = ShareableBitmap::create(handle);
-contents = bitmap->makeCGImageCopy().bridgingAutorelease();
+contents = bitmap->makeCGImageCopy();
 },
 [&] (MachSendRight& machSendRight) {
 ASSERT(m_type == Type::IOSurface);
@@ -442,7 +442,7 @@
 break;
 }
 case RemoteLayerBackingStore::LayerContentsType::CAMachPort:
-contents = adoptCF(CAMachPortCreate(machSendRight.leakSendRight())).bridgingAutorelease();
+contents = adoptCF(CAMachPortCreate(machSendRight.leakSendRight()));
 break;
 }
 }
@@ -460,12 +460,12 @@
 return;
 [layer setValue:@1 forKeyPath:WKCGDisplayListEnabledKey];
 auto data = ""
-[(WKCompositingLayer *)layer _setWKContents:contents withDisplayList:data.get()];
+[(WKCompositingLayer *)layer _setWKContents:contents.get() withDisplayList:data.get()];
 return;
 }
 #endif
 
-layer.contents = contents;
+layer.contents = contents.get();
 }
 
 Vector> RemoteLayerBackingStore::takePendingFlushers()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280182] branches/safari-612.1.24.11-branch/

[repstein]

Title: [280182] branches/safari-612.1.24.11-branch/








Revision 280182
Author repst...@apple.com
Date 2021-07-22 10:53:43 -0700 (Thu, 22 Jul 2021)


Log Message
New branch.

Added Paths

branches/safari-612.1.24.11-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280181] trunk

[commit-queue]

Title: [280181] trunk








Revision 280181
Author commit-qu...@webkit.org
Date 2021-07-22 10:44:34 -0700 (Thu, 22 Jul 2021)


Log Message
XHR.send(Document) should replace mismatched surrogates with replacement character before sending
https://bugs.webkit.org/show_bug.cgi?id=228170

Patch by Alex Christensen  on 2021-07-22
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/xhr/send-entity-body-document-bogus-expected.txt:

Source/WebCore:

This matches the behavior of Chrome and Firefox.
Covered by a newly passing WPT test.

* bindings/js/JSDOMConvertStrings.cpp:
(WebCore::identifierToUSVString):
(WebCore::valueToUSVString):
(WebCore::stringToUSVString): Deleted.
* bindings/js/JSDOMConvertStrings.h:
* css/parser/CSSTokenizer.cpp:
(WebCore::preprocessString):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):

Source/WTF:

* wtf/text/WTFString.cpp:
(WTF::replaceUnpairedSurrogatesWithReplacementCharacter):
* wtf/text/WTFString.h:
Move from WebCore, rename as suggested, update spec link to one that works.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/send-entity-body-document-bogus-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/WTFString.cpp
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMConvertStrings.cpp
trunk/Source/WebCore/bindings/js/JSDOMConvertStrings.h
trunk/Source/WebCore/css/parser/CSSTokenizer.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (280180 => 280181)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-22 17:28:57 UTC (rev 280180)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-22 17:44:34 UTC (rev 280181)
@@ -1,3 +1,12 @@
+2021-07-22  Alex Christensen  
+
+XHR.send(Document) should replace mismatched surrogates with replacement character before sending
+https://bugs.webkit.org/show_bug.cgi?id=228170
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/xhr/send-entity-body-document-bogus-expected.txt:
+
 2021-07-22  Sihui Liu  
 
 [macOS Debug] Layout Test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/send-entity-body-document-bogus-expected.txt (280180 => 280181)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/send-entity-body-document-bogus-expected.txt	2021-07-22 17:28:57 UTC (rev 280180)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/send-entity-body-document-bogus-expected.txt	2021-07-22 17:44:34 UTC (rev 280181)
@@ -2,5 +2,5 @@
 PASS Serializing documents through XMLHttpRequest: ''
 PASS Serializing documents through XMLHttpRequest: ''
 PASS Serializing documents through XMLHttpRequest: ''
-FAIL Serializing documents through XMLHttpRequest: '' assert_equals: expected "" but got ""
+PASS Serializing documents through XMLHttpRequest: ''
 


Modified: trunk/Source/WTF/ChangeLog (280180 => 280181)

--- trunk/Source/WTF/ChangeLog	2021-07-22 17:28:57 UTC (rev 280180)
+++ trunk/Source/WTF/ChangeLog	2021-07-22 17:44:34 UTC (rev 280181)
@@ -1,3 +1,15 @@
+2021-07-22  Alex Christensen  
+
+XHR.send(Document) should replace mismatched surrogates with replacement character before sending
+https://bugs.webkit.org/show_bug.cgi?id=228170
+
+Reviewed by Chris Dumez.
+
+* wtf/text/WTFString.cpp:
+(WTF::replaceUnpairedSurrogatesWithReplacementCharacter):
+* wtf/text/WTFString.h:
+Move from WebCore, rename as suggested, update spec link to one that works.
+
 2021-07-22  Zan Dobersek  
 
 Add CPU(RISCV64)


Modified: trunk/Source/WTF/wtf/text/WTFString.cpp (280180 => 280181)

--- trunk/Source/WTF/wtf/text/WTFString.cpp	2021-07-22 17:28:57 UTC (rev 280180)
+++ trunk/Source/WTF/wtf/text/WTFString.cpp	2021-07-22 17:44:34 UTC (rev 280181)
@@ -863,6 +863,26 @@
 return nullString;
 }
 
+String replaceUnpairedSurrogatesWithReplacementCharacter(String&& string)
+{
+// Fast path for the case where there are no unpaired surrogates.
+if (!hasUnpairedSurrogate(string))
+return WTFMove(string);
+
+// Slow path: https://infra.spec.whatwg.org/#_javascript_-string-convert
+// Replaces unpaired surrogates with the replacement character.
+StringBuilder result;
+result.reserveCapacity(string.length());
+StringView view { string };
+for (auto codePoint : view.codePoints()) {
+if (U_IS_SURROGATE(codePoint))
+result.append(replacementCharacter);
+else
+result.appendCharacter(codePoint);
+}
+return result.toString();
+}
+
 } // namespace WTF
 
 #ifndef NDEBUG


Modified: trunk/Source/WTF/wtf/text/WTFString.h (280180 => 280181)

--- trunk/Source/WTF/wtf/text/WTFString.h	2021-07-22 17:28:57 UTC (rev 280180)
+++ trunk/Source/WTF/wtf/text/WTFString.h	2021-07-22 17:44:34 

[webkit-changes] [280180] trunk/Tools

[peng . liu6]

Title: [280180] trunk/Tools








Revision 280180
Author peng.l...@apple.com
Date 2021-07-22 10:28:57 -0700 (Thu, 22 Jul 2021)


Log Message
[ BigSur Debug ] TestWebKitAPI.GPUProcess.CrashWhilePlayingAudioViaCreateMediaElementSource is flaky, hitting ASSERTION FAILED: !isInRoutingArbitrationForToken(token)
https://bugs.webkit.org/show_bug.cgi?id=227728

Unreviewed API test gardening.


* TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm




Diff

Modified: trunk/Tools/ChangeLog (280179 => 280180)

--- trunk/Tools/ChangeLog	2021-07-22 17:18:20 UTC (rev 280179)
+++ trunk/Tools/ChangeLog	2021-07-22 17:28:57 UTC (rev 280180)
@@ -1,3 +1,13 @@
+2021-07-22  Peng Liu  
+
+[ BigSur Debug ] TestWebKitAPI.GPUProcess.CrashWhilePlayingAudioViaCreateMediaElementSource is flaky, hitting ASSERTION FAILED: !isInRoutingArbitrationForToken(token)
+https://bugs.webkit.org/show_bug.cgi?id=227728
+
+Unreviewed API test gardening.
+
+* TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
+(TEST):
+
 2021-07-22  Frédéric Wang  
 
 nullptr crash in ApplyStyleCommand::applyRelativeFontStyleChange


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm (280179 => 280180)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm	2021-07-22 17:18:20 UTC (rev 280179)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm	2021-07-22 17:28:57 UTC (rev 280180)
@@ -368,7 +368,8 @@
 EXPECT_EQ(webViewPID, [webView _webProcessIdentifier]);
 }
 
-TEST(GPUProcess, CrashWhilePlayingAudioViaCreateMediaElementSource)
+// FIXME: Re-enable this test once  is resolved
+TEST(GPUProcess, DISABLED_CrashWhilePlayingAudioViaCreateMediaElementSource)
 {
 auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
 WKPreferencesSetBoolValueForKeyForTesting((__bridge WKPreferencesRef)[configuration preferences], true, WKStringCreateWithUTF8CString("UseGPUProcessForMediaEnabled"));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280179] trunk/Source/WebCore

[vjaquez]

Title: [280179] trunk/Source/WebCore








Revision 280179
Author vjaq...@igalia.com
Date 2021-07-22 10:18:20 -0700 (Thu, 22 Jul 2021)


Log Message
Compilation error with gcc version 9.3.0 (Buildroot 2020.08-14-ge5a2a90)
https://bugs.webkit.org/show_bug.cgi?id=228184

Reviewed by Chris Dumez.

Turn destructors into virtual ones for RTCRtpReceiver and RTCRtpSender.

It seems that gcc doesn't create a virtual table for these classes, while clang does. That
would the cause, when compiling clang, ImplementationLacksVTable is not needed in the IDL
file. The approach for this fix to force the virtual table creation by turning destructors
into virtual.

No new tests needed.

* Modules/mediastream/RTCRtpReceiver.h:
* Modules/mediastream/RTCRtpSender.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h
trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (280178 => 280179)

--- trunk/Source/WebCore/ChangeLog	2021-07-22 17:07:21 UTC (rev 280178)
+++ trunk/Source/WebCore/ChangeLog	2021-07-22 17:18:20 UTC (rev 280179)
@@ -1,3 +1,22 @@
+2021-07-22  Víctor Manuel Jáquez Leal  
+
+Compilation error with gcc version 9.3.0 (Buildroot 2020.08-14-ge5a2a90)
+https://bugs.webkit.org/show_bug.cgi?id=228184
+
+Reviewed by Chris Dumez.
+
+Turn destructors into virtual ones for RTCRtpReceiver and RTCRtpSender.
+
+It seems that gcc doesn't create a virtual table for these classes, while clang does. That
+would the cause, when compiling clang, ImplementationLacksVTable is not needed in the IDL
+file. The approach for this fix to force the virtual table creation by turning destructors
+into virtual.
+
+No new tests needed.
+
+* Modules/mediastream/RTCRtpReceiver.h:
+* Modules/mediastream/RTCRtpSender.h:
+
 2021-07-22  Megan Gardner  
 
 Avoid Quick Note overlay when scrolling to show a highlight


Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h (280178 => 280179)

--- trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h	2021-07-22 17:07:21 UTC (rev 280178)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h	2021-07-22 17:18:20 UTC (rev 280179)
@@ -56,7 +56,7 @@
 {
 return adoptRef(*new RTCRtpReceiver(connection, WTFMove(track), WTFMove(backend)));
 }
-~RTCRtpReceiver();
+virtual ~RTCRtpReceiver();
 
 static std::optional getCapabilities(ScriptExecutionContext&, const String& kind);
 


Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.h (280178 => 280179)

--- trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.h	2021-07-22 17:07:21 UTC (rev 280178)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.h	2021-07-22 17:18:20 UTC (rev 280179)
@@ -58,7 +58,7 @@
 public:
 static Ref create(RTCPeerConnection&, Ref&&, std::unique_ptr&&);
 static Ref create(RTCPeerConnection&, String&& trackKind, std::unique_ptr&&);
-~RTCRtpSender();
+virtual ~RTCRtpSender();
 
 static std::optional getCapabilities(ScriptExecutionContext&, const String& kind);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280178] trunk/Source

[megan_gardner]

Title: [280178] trunk/Source








Revision 280178
Author megan_gard...@apple.com
Date 2021-07-22 10:07:21 -0700 (Thu, 22 Jul 2021)


Log Message
Avoid Quick Note overlay when scrolling to show a highlight
https://bugs.webkit.org/show_bug.cgi?id=228172

Reviewed by Wenson Hsieh and Tim Horton.

When scrolling to show the selected highlight after clicking on one in the QuickNote overlay,
make sure to avoid the Quick Note overlay, so that the user can actually see the highlight.
This required calculating more information about the selection rect for iOS, and also piping through
information to have the selection rect be the entire rect, rather that just the caret and the end of selection.

Source/WebCore:

* Modules/highlight/AppHighlightStorage.cpp:
(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):
* editing/Editor.cpp:
(WebCore::TemporarySelectionChange::setSelection):
* editing/Editor.h:
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::selectionBounds const):
* editing/FrameSelection.h:

Source/WebKit:

* Platform/spi/Cocoa/SynapseSPI.h:
* UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView adjustScrollRect:]):
(-[WKWebView _scrollToRect:origin:minimumScrollDistance:]):
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::appHighlightsNoteOverlayRect):
* UIProcess/WebPageProxy.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.cpp
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/editing/FrameSelection.cpp
trunk/Source/WebCore/editing/FrameSelection.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/SynapseSPI.h
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (280177 => 280178)

--- trunk/Source/WebCore/ChangeLog	2021-07-22 16:56:03 UTC (rev 280177)
+++ trunk/Source/WebCore/ChangeLog	2021-07-22 17:07:21 UTC (rev 280178)
@@ -1,3 +1,26 @@
+2021-07-22  Megan Gardner  
+
+Avoid Quick Note overlay when scrolling to show a highlight
+https://bugs.webkit.org/show_bug.cgi?id=228172
+
+Reviewed by Wenson Hsieh and Tim Horton.
+
+When scrolling to show the selected highlight after clicking on one in the QuickNote overlay,
+make sure to avoid the Quick Note overlay, so that the user can actually see the highlight. 
+This required calculating more information about the selection rect for iOS, and also piping through
+information to have the selection rect be the entire rect, rather that just the caret and the end of selection.
+
+* Modules/highlight/AppHighlightStorage.cpp:
+(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):
+* editing/Editor.cpp:
+(WebCore::TemporarySelectionChange::setSelection):
+* editing/Editor.h:
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::setSelection):
+(WebCore::FrameSelection::updateAndRevealSelection):
+(WebCore::FrameSelection::selectionBounds const):
+* editing/FrameSelection.h:
+
 2021-07-22  Sihui Liu  
 
 [macOS Debug] Layout Test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout.


Modified: trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.cpp (280177 => 280178)

--- trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.cpp	2021-07-22 16:56:03 UTC (rev 280177)
+++ trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.cpp	2021-07-22 17:07:21 UTC (rev 280178)
@@ -270,8 +270,8 @@
 auto textIndicator = TextIndicator::createWithRange(range.value(), { TextIndicatorOption::DoNotClipToVisibleRect }, WebCore::TextIndicatorPresentationTransition::Bounce);
 if (textIndicator)
 m_document->page()->chrome().client().setTextIndicator(textIndicator->data());
-
-TemporarySelectionChange selectionChange(*strongDocument, { range.value() }, { TemporarySelectionOption::DelegateMainFrameScroll, TemporarySelectionOption::SmoothScroll });
+
+TemporarySelectionChange selectionChange(*strongDocument, { range.value() }, { TemporarySelectionOption::DelegateMainFrameScroll, TemporarySelectionOption::SmoothScroll, TemporarySelectionOption::RevealSelectionBounds });
 }
 
 return true;


Modified: trunk/Source/WebCore/editing/Editor.cpp (280177 => 280178)

--- trunk/Source/WebCore/editing/Editor.cpp	2021-07-22 16:56:03 UTC (rev 280177)
+++ trunk/Source/WebCore/editing/Editor.cpp	2021-07-22 17:07:21 UTC (rev 280178)
@@ -269,6 +269,8 @@
 options.add(FrameSelection::DelegateMainFrameScroll);
 if (m_options & TemporarySelectionOption::SmoothScroll)
 options.add(FrameSelection::SmoothScroll);
+if 

[webkit-changes] [280177] branches/safari-612.1.25-branch/

[repstein]

Title: [280177] branches/safari-612.1.25-branch/








Revision 280177
Author repst...@apple.com
Date 2021-07-22 09:56:03 -0700 (Thu, 22 Jul 2021)


Log Message
New branch.

Added Paths

branches/safari-612.1.25-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280176] trunk

[sihui_liu]

Title: [280176] trunk








Revision 280176
Author sihui_...@apple.com
Date 2021-07-22 09:49:58 -0700 (Thu, 22 Jul 2021)


Log Message
[macOS Debug] Layout Test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=172044

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/IndexedDB/open-request-queue-expected.txt:

Source/WebCore:

We used to start handling delete request when there is still open request in flight. We should start a request
after previous requests are done, to match spec (https://www.w3.org/TR/IndexedDB/#delete-a-database) and other
browsers' behavior.

Updated and rebaselined existing tests.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::handleDatabaseOperations):
(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):

LayoutTests:

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
* storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt:
* storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
* storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-private-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt:
* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/intversion-long-queue-private-expected.txt:
* storage/indexeddb/modern/deletedatabase-2-private.html: Removed. This test checks if a delete request is
started when there are ongoing open requests. We are removing this behavior to match spec so we don't need to
keep the test.
* storage/indexeddb/modern/deletedatabase-2.html: Removed. Ditto.
* storage/indexeddb/modern/resources/deletedatabase-2.js: Removed. Ditto.
* storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:
(versionChangeCallback):
(deleteBlockedCallback):
* storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js:
(initiallyDeleted):
* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
(onOpenSuccess):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/open-request-queue-expected.txt
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt
trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt
trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt
trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt
trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt
trunk/LayoutTests/storage/indexeddb/intversion-long-queue-expected.txt
trunk/LayoutTests/storage/indexeddb/intversion-long-queue-private-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js
trunk/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js
trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp


Removed Paths

trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-private.html
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2.html
trunk/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js




Diff

Modified: trunk/LayoutTests/ChangeLog (280175 => 280176)

--- trunk/LayoutTests/ChangeLog	2021-07-22 16:37:56 UTC (rev 280175)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 16:49:58 UTC (rev 280176)
@@ -1,3 +1,34 @@
+2021-07-22  Sihui Liu  
+
+[macOS Debug] Layout Test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=172044
+
+Reviewed by Chris Dumez.
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
+* storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt:
+* storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
+* storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-private-expected.txt:
+* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:

[webkit-changes] [280175] trunk

[zalan]

Title: [280175] trunk








Revision 280175
Author za...@apple.com
Date 2021-07-22 09:37:56 -0700 (Thu, 22 Jul 2021)


Log Message
REGRESSION(r269745) Google Developers maps does not fully load
https://bugs.webkit.org/show_bug.cgi?id=228182


Reviewed by Antti Koivisto.

Source/WebCore:

IFC integration does not support cases when the inline level element stretches as the containing block size changes.
This should include both percent and calc width/height values.

Test: fast/inline/incorrect-sizing-with-calc.html

* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):

LayoutTests:

* fast/inline/incorrect-sizing-with-calc-expected.html: Added.
* fast/inline/incorrect-sizing-with-calc.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp


Added Paths

trunk/LayoutTests/fast/inline/incorrect-sizing-with-calc-expected.html
trunk/LayoutTests/fast/inline/incorrect-sizing-with-calc.html




Diff

Modified: trunk/LayoutTests/ChangeLog (280174 => 280175)

--- trunk/LayoutTests/ChangeLog	2021-07-22 16:27:33 UTC (rev 280174)
+++ trunk/LayoutTests/ChangeLog	2021-07-22 16:37:56 UTC (rev 280175)
@@ -1,3 +1,14 @@
+2021-07-22  Alan Bujtas  
+
+REGRESSION(r269745) Google Developers maps does not fully load
+https://bugs.webkit.org/show_bug.cgi?id=228182
+
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/incorrect-sizing-with-calc-expected.html: Added.
+* fast/inline/incorrect-sizing-with-calc.html: Added.
+
 2021-07-21  Sihui Liu  
 
 Update LayoutTests/TestExpectations for imported w3c IndexedDB tests


Added: trunk/LayoutTests/fast/inline/incorrect-sizing-with-calc-expected.html (0 => 280175)

--- trunk/LayoutTests/fast/inline/incorrect-sizing-with-calc-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/inline/incorrect-sizing-with-calc-expected.html	2021-07-22 16:37:56 UTC (rev 280175)
@@ -0,0 +1,11 @@
+
+
+div {
+  width: 50px;
+  height: 100px;
+  background-color: green;
+  border: 10px solid blue;
+  box-sizing: border-box;
+}
+
+
\ No newline at end of file


Added: trunk/LayoutTests/fast/inline/incorrect-sizing-with-calc.html (0 => 280175)

--- trunk/LayoutTests/fast/inline/incorrect-sizing-with-calc.html	(rev 0)
+++ trunk/LayoutTests/fast/inline/incorrect-sizing-with-calc.html	2021-07-22 16:37:56 UTC (rev 280175)
@@ -0,0 +1,39 @@
+
+
+div {
+  width: 50px;
+  height: 50px;
+  background-color: green;
+}
+
+iframe {
+  border: 10px solid blue;
+}
+
+.normal {
+  height: calc(100% - 20px);
+  width: calc(100% - 20px);
+}
+
+.min {
+  min-height: calc(100% - 20px);
+  min-width: calc(100% - 20px);
+  width: 30px;
+  height: 30px;
+}
+
+.max {
+  max-height: calc(100% - 20px);
+  max-width: calc(100% - 20px);
+}
+
+
+
+document.body.offsetHeight;
+let containers = document.getElementsByTagName("div");
+for (let container of containers)
+  container.style.height = "100px";
+


Modified: trunk/Source/WebCore/ChangeLog (280174 => 280175)

--- trunk/Source/WebCore/ChangeLog	2021-07-22 16:27:33 UTC (rev 280174)
+++ trunk/Source/WebCore/ChangeLog	2021-07-22 16:37:56 UTC (rev 280175)
@@ -1,3 +1,19 @@
+2021-07-22  Alan Bujtas  
+
+REGRESSION(r269745) Google Developers maps does not fully load
+https://bugs.webkit.org/show_bug.cgi?id=228182
+
+
+Reviewed by Antti Koivisto.
+
+IFC integration does not support cases when the inline level element stretches as the containing block size changes.
+This should include both percent and calc width/height values.
+
+Test: fast/inline/incorrect-sizing-with-calc.html
+
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::canUseForChild):
+
 2021-07-22  Frédéric Wang  
 
 nullptr crash in ApplyStyleCommand::applyRelativeFontStyleChange


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (280174 => 280175)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-07-22 16:27:33 UTC (rev 280174)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-07-22 16:37:56 UTC (rev 280175)
@@ -629,11 +629,11 @@
 auto isSupportedStyle = [] (const auto& style) {
 if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
 return false;
-if (style.width().isPercent() || style.height().isPercent())
+if (style.width().isPercentOrCalculated() || style.height().isPercentOrCalculated())
 return false;
-if (style.minWidth().isPercent() || style.maxWidth().isPercent())
+if (style.minWidth().isPercentOrCalculated() || style.maxWidth().isPercentOrCalculated())
 return false;
-if (style.minHeight().isPercent() || style.maxHeight().isPercent())
+

[webkit-changes] [280174] trunk

[commit-queue]

Title: [280174] trunk








Revision 280174
Author commit-qu...@webkit.org
Date 2021-07-22 09:27:33 -0700 (Thu, 22 Jul 2021)


Log Message
nullptr crash in ApplyStyleCommand::applyRelativeFontStyleChange
https://bugs.webkit.org/show_bug.cgi?id=223974

Patch by Frédéric Wang  on 2021-07-22
Reviewed by Darin Adler.

Source/WebCore:

WebCore::documentOrder does not handle well elements like  that contains a
shadow substree. This is causing assertion failures in debug build when setting start/end
selection and nullptr crashes in release build when trying to browse selection between these
start and end nodes. This patch fixes that issue by switching to shadow including tree order
for these particular cases. It introduces a generic treeOrder(a, b) function that
can be used for TreeType = ShadowIncludingTree as well as by WebCore::documentOrder.

* dom/Node.cpp: Explicitly instantiate commonInclusiveAncestor so that it can be used
by WebCore::treeOrder.
* dom/Position.cpp: Explicitly instantiate templates.
(WebCore::treeOrder): Convert documentOrder to a template parametrized by TreeType.
(WebCore::documentOrder): Implement it with treeOrder.
* dom/Position.h: Delcare new template.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::updateStartEnd): Use treeOrder.
(WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
* editing/VisiblePosition.cpp:
(WebCore::documentOrder): Use treeOrder.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents): Use treeOrder.
(WebCore::VisibleSelection::setWithoutValidation): Ditto.

Tools:

* TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Update FIXME.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/dom/Position.h
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp
trunk/Source/WebCore/editing/VisiblePosition.cpp
trunk/Source/WebCore/editing/VisibleSelection.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (280173 => 280174)

--- trunk/Source/WebCore/ChangeLog	2021-07-22 11:48:39 UTC (rev 280173)
+++ trunk/Source/WebCore/ChangeLog	2021-07-22 16:27:33 UTC (rev 280174)
@@ -1,3 +1,32 @@
+2021-07-22  Frédéric Wang  
+
+nullptr crash in ApplyStyleCommand::applyRelativeFontStyleChange
+https://bugs.webkit.org/show_bug.cgi?id=223974
+
+Reviewed by Darin Adler.
+
+WebCore::documentOrder does not handle well elements like  that contains a
+shadow substree. This is causing assertion failures in debug build when setting start/end
+selection and nullptr crashes in release build when trying to browse selection between these
+start and end nodes. This patch fixes that issue by switching to shadow including tree order
+for these particular cases. It introduces a generic treeOrder(a, b) function that
+can be used for TreeType = ShadowIncludingTree as well as by WebCore::documentOrder.
+
+* dom/Node.cpp: Explicitly instantiate commonInclusiveAncestor so that it can be used
+by WebCore::treeOrder.
+* dom/Position.cpp: Explicitly instantiate templates.
+(WebCore::treeOrder): Convert documentOrder to a template parametrized by TreeType.
+(WebCore::documentOrder): Implement it with treeOrder.
+* dom/Position.h: Delcare new template.
+* editing/ApplyStyleCommand.cpp:
+(WebCore::ApplyStyleCommand::updateStartEnd): Use treeOrder.
+(WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
+* editing/VisiblePosition.cpp:
+(WebCore::documentOrder): Use treeOrder.
+* editing/VisibleSelection.cpp:
+(WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents): Use treeOrder.
+(WebCore::VisibleSelection::setWithoutValidation): Ditto.
+
 2021-07-22  Martin Robinson  
 
 [css-scroll-snap] Pass the full target point when selecting a snap offset


Modified: trunk/Source/WebCore/dom/Node.cpp (280173 => 280174)

--- trunk/Source/WebCore/dom/Node.cpp	2021-07-22 11:48:39 UTC (rev 280173)
+++ trunk/Source/WebCore/dom/Node.cpp	2021-07-22 16:27:33 UTC (rev 280174)
@@ -2684,6 +2684,7 @@
 
 template Node* commonInclusiveAncestor(const Node&, const Node&);
 template Node* commonInclusiveAncestor(const Node&, const Node&);
+template Node* commonInclusiveAncestor(const Node&, const Node&);
 
 static bool isSiblingSubsequent(const Node& siblingA, const Node& siblingB)
 {


Modified: trunk/Source/WebCore/dom/Position.cpp (280173 => 280174)

--- trunk/Source/WebCore/dom/Position.cpp	2021-07-22 11:48:39 UTC (rev 280173)
+++ trunk/Source/WebCore/dom/Position.cpp	2021-07-22 16:27:33 UTC (rev 280174)
@@ -1609,7 +1609,7 @@
 return BoundaryPoint { container.releaseNonNull(), static_cast(position.computeOffsetInContainerNode()) };
 }
 
-PartialOrdering documentOrder(const Position& a, const Position& b)
+template 

[webkit-changes] [280173] trunk/Source/WTF

[commit-queue]

Title: [280173] trunk/Source/WTF








Revision 280173
Author commit-qu...@webkit.org
Date 2021-07-22 04:48:39 -0700 (Thu, 22 Jul 2021)


Log Message
Add CPU(RISCV64)
https://bugs.webkit.org/show_bug.cgi?id=228178

Patch by Zan Dobersek  on 2021-07-22
Reviewed by Adrian Perez de Castro.

Detect when compiling for the RISC-V 64-bit architecture and define
the WTF_CPU_RISCV64 macro under that condition, enabling use of
CPU(RISCV64) build guards.

* wtf/PageBlock.h: Use 4 kB as the page size ceiling for CPU(RISCV64).
* wtf/PlatformCPU.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PageBlock.h
trunk/Source/WTF/wtf/PlatformCPU.h




Diff

Modified: trunk/Source/WTF/ChangeLog (280172 => 280173)

--- trunk/Source/WTF/ChangeLog	2021-07-22 10:54:07 UTC (rev 280172)
+++ trunk/Source/WTF/ChangeLog	2021-07-22 11:48:39 UTC (rev 280173)
@@ -1,3 +1,17 @@
+2021-07-22  Zan Dobersek  
+
+Add CPU(RISCV64)
+https://bugs.webkit.org/show_bug.cgi?id=228178
+
+Reviewed by Adrian Perez de Castro.
+
+Detect when compiling for the RISC-V 64-bit architecture and define
+the WTF_CPU_RISCV64 macro under that condition, enabling use of
+CPU(RISCV64) build guards.
+
+* wtf/PageBlock.h: Use 4 kB as the page size ceiling for CPU(RISCV64).
+* wtf/PlatformCPU.h:
+
 2021-07-21  Miguel Gomez  
 
 [GTK][WPE] Allow the user to configure the MemoryPressureHandler inside the web process


Modified: trunk/Source/WTF/wtf/PageBlock.h (280172 => 280173)

--- trunk/Source/WTF/wtf/PageBlock.h	2021-07-22 10:54:07 UTC (rev 280172)
+++ trunk/Source/WTF/wtf/PageBlock.h	2021-07-22 11:48:39 UTC (rev 280173)
@@ -48,7 +48,7 @@
 constexpr size_t CeilingOnPageSize = 16 * KB;
 #elif CPU(PPC) || CPU(PPC64) || CPU(PPC64LE) || CPU(UNKNOWN)
 constexpr size_t CeilingOnPageSize = 64 * KB;
-#elif OS(WINDOWS) || CPU(X86) || CPU(X86_64) || CPU(ARM) || CPU(ARM64)
+#elif OS(WINDOWS) || CPU(X86) || CPU(X86_64) || CPU(ARM) || CPU(ARM64) || CPU(RISCV64)
 constexpr size_t CeilingOnPageSize = 4 * KB;
 #else
 #error Must set CeilingOnPageSize in PageBlock.h when adding a new CPU architecture!


Modified: trunk/Source/WTF/wtf/PlatformCPU.h (280172 => 280173)

--- trunk/Source/WTF/wtf/PlatformCPU.h	2021-07-22 10:54:07 UTC (rev 280172)
+++ trunk/Source/WTF/wtf/PlatformCPU.h	2021-07-22 11:48:39 UTC (rev 280173)
@@ -277,6 +277,14 @@
 
 #endif /* ARM */
 
+/* CPU(RISCV64) - RISC-V 64-bit */
+#ifdefined(__riscv) \
+&& defined(__riscv_xlen) \
+&& (__riscv_xlen == 64)
+#define WTF_CPU_RISCV64 1
+#define WTF_CPU_KNOWN 1
+#endif
+
 #if !CPU(KNOWN)
 #define WTF_CPU_UNKNOWN 1
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280172] trunk

[philn]

Title: [280172] trunk








Revision 280172
Author ph...@webkit.org
Date 2021-07-22 03:54:07 -0700 (Thu, 22 Jul 2021)


Log Message
[GLib] Expose API to access/modify capture devices states
https://bugs.webkit.org/show_bug.cgi?id=227902

Reviewed by Carlos Garcia Campos.

Source/WebKit:

Introduce new GLib API (and corresponding GObject properties):

webkit_web_view_get_camera_capture_state
webkit_web_view_get_microphone_capture_state
webkit_web_view_set_camera_capture_state
webkit_web_view_set_microphone_capture_state
webkit_web_view_get_display_capture_state
webkit_web_view_set_display_capture_state
webkit_user_media_permission_is_for_display_device

This can be useful in Web browsers willing to indicate the status of the capture devices
currently in use by the WebView.

Covered by API tests.

* UIProcess/API/glib/WebKitUIClient.cpp:
* UIProcess/API/glib/WebKitUserMediaPermissionRequest.cpp:
(webkit_user_media_permission_is_for_display_device):
* UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewMediaCaptureStateDidChange):
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkitWebViewConfigureMediaCapture):
(webkit_web_view_get_camera_capture_state):
(webkit_web_view_set_camera_capture_state):
(webkit_web_view_get_microphone_capture_state):
(webkit_web_view_set_microphone_capture_state):
(webkit_web_view_get_display_capture_state):
(webkit_web_view_set_display_capture_state):
* UIProcess/API/glib/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/WebKitUserMediaPermissionRequest.h:
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
* UIProcess/API/wpe/WebKitUserMediaPermissionRequest.h:
* UIProcess/API/wpe/WebKitWebView.h:
* UIProcess/API/wpe/docs/wpe-1.0-sections.txt:

Tools:

The GTK MiniBrowser is now able to show media capture indicators, through the URI entry. A
new API test was added, checking support for getDisplayMedia().

* MiniBrowser/gtk/BrowserTab.c:
(decidePermissionRequest):
* MiniBrowser/gtk/BrowserWindow.c:
(webViewMediaCaptureStateChanged):
(webViewUriEntryIconPressed):
(browserWindowSwitchTab):
* TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
(testWebViewUserMediaPermissionRequests):
(testWebViewAudioOnlyUserMediaPermissionRequests):
(testWebViewDisplayUserMediaPermissionRequests):
(beforeAll):
* TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
(displayCaptureChanged):
(WebViewTest::waitUntilDisplayCaptureStateChangedTo):
(microphoneCaptureChanged):
(WebViewTest::waitUntilMicrophoneCaptureStateChangedTo):
(cameraCaptureChanged):
(WebViewTest::waitUntilCameraCaptureStateChangedTo):
* TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitUserMediaPermissionRequest.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h
trunk/Source/WebKit/UIProcess/API/gtk/WebKitUserMediaPermissionRequest.h
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit/UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt
trunk/Source/WebKit/UIProcess/API/wpe/WebKitUserMediaPermissionRequest.h
trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebView.h
trunk/Source/WebKit/UIProcess/API/wpe/docs/wpe-1.0-sections.txt
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserTab.c
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp
trunk/Tools/flatpak/flatpakutils.py




Diff

Modified: trunk/Source/WebKit/ChangeLog (280171 => 280172)

--- trunk/Source/WebKit/ChangeLog	2021-07-22 09:00:27 UTC (rev 280171)
+++ trunk/Source/WebKit/ChangeLog	2021-07-22 10:54:07 UTC (rev 280172)
@@ -1,3 +1,48 @@
+2021-07-22  Philippe Normand  
+
+[GLib] Expose API to access/modify capture devices states
+https://bugs.webkit.org/show_bug.cgi?id=227902
+
+Reviewed by Carlos Garcia Campos.
+
+Introduce new GLib API (and corresponding GObject properties):
+
+webkit_web_view_get_camera_capture_state
+webkit_web_view_get_microphone_capture_state
+webkit_web_view_set_camera_capture_state
+webkit_web_view_set_microphone_capture_state
+webkit_web_view_get_display_capture_state
+webkit_web_view_set_display_capture_state
+webkit_user_media_permission_is_for_display_device
+
+This can be useful in Web browsers willing to indicate the status of the capture devices
+currently in use by the WebView.
+
+Covered by API tests.
+
+* UIProcess/API/glib/WebKitUIClient.cpp:
+* UIProcess/API/glib/WebKitUserMediaPermissionRequest.cpp:
+(webkit_user_media_permission_is_for_display_device):
+* UIProcess/API/glib/WebKitWebView.cpp:
+(webkitWebViewMediaCaptureStateDidChange):
+(webkitWebViewSetProperty):
+ 

[webkit-changes] [280171] trunk/Source

[mrobinson]

Title: [280171] trunk/Source








Revision 280171
Author mrobin...@webkit.org
Date 2021-07-22 02:00:27 -0700 (Thu, 22 Jul 2021)


Log Message
[css-scroll-snap] Pass the full target point when selecting a snap offset
https://bugs.webkit.org/show_bug.cgi?id=228023

Reviewed by Frédéric Wang.

Source/WebCore:

Pass the full proposed destination scroll offset when calling closestSnapOffset. For
now, only the component in the scroll direction is used, but eventually the other
component will be used to avoid snapping to snap areas that are entirely off the screen.

No new tests. This change is simply a refactor in preparation for a behavior
change and shouldn't change behavior itself.

* page/scrolling/ScrollSnapOffsetsInfo.cpp:
(WebCore::closestSnapOffsetWithInfoAndAxis):
(WebCore::LayoutScrollSnapOffsetsInfo::closestSnapOffset const):
(WebCore::FloatScrollSnapOffsetsInfo::closestSnapOffset const):
* page/scrolling/ScrollSnapOffsetsInfo.h:
* page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::handleWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::adjustScrollOffsetForSnappingIfNeeded):
* platform/ScrollAnimator.h:
* platform/ScrollController.cpp:
(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset):
(WebCore::ScrollController::adjustScrollDestination):
(WebCore::ScrollController::updateActiveScrollSnapIndexForClientOffset):
(WebCore::ScrollController::resnapAfterLayout):
* platform/ScrollController.h:
* platform/ScrollSnapAnimatorState.cpp:
(WebCore::ScrollSnapAnimatorState::setupAnimationForState):
(WebCore::ScrollSnapAnimatorState::targetOffsetForStartOffset const):
* platform/ScrollSnapAnimatorState.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::doPostThumbMoveSnapping):

Source/WebKit:

* UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
* UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::adjustTargetContentOffsetForSnapping):
(WebKit::RemoteScrollingCoordinatorProxy::closestSnapOffsetForMainFrameScrolling const):
* UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp
trunk/Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.h
trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/ScrollAnimator.h
trunk/Source/WebCore/platform/ScrollController.cpp
trunk/Source/WebCore/platform/ScrollController.h
trunk/Source/WebCore/platform/ScrollSnapAnimatorState.cpp
trunk/Source/WebCore/platform/ScrollSnapAnimatorState.h
trunk/Source/WebCore/platform/ScrollableArea.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (280170 => 280171)

--- trunk/Source/WebCore/ChangeLog	2021-07-22 03:19:39 UTC (rev 280170)
+++ trunk/Source/WebCore/ChangeLog	2021-07-22 09:00:27 UTC (rev 280171)
@@ -1,3 +1,41 @@
+2021-07-22  Martin Robinson  
+
+[css-scroll-snap] Pass the full target point when selecting a snap offset
+https://bugs.webkit.org/show_bug.cgi?id=228023
+
+Reviewed by Frédéric Wang.
+
+Pass the full proposed destination scroll offset when calling closestSnapOffset. For
+now, only the component in the scroll direction is used, but eventually the other
+component will be used to avoid snapping to snap areas that are entirely off the screen.
+
+No new tests. This change is simply a refactor in preparation for a behavior
+change and shouldn't change behavior itself.
+
+* page/scrolling/ScrollSnapOffsetsInfo.cpp:
+(WebCore::closestSnapOffsetWithInfoAndAxis):
+(WebCore::LayoutScrollSnapOffsetsInfo::closestSnapOffset const):
+(WebCore::FloatScrollSnapOffsetsInfo::closestSnapOffset const):
+* page/scrolling/ScrollSnapOffsetsInfo.h:
+* page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:
+(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::handleWheelEvent):
+* platform/ScrollAnimator.cpp:
+(WebCore::ScrollAnimator::scroll):
+(WebCore::ScrollAnimator::adjustScrollOffsetForSnappingIfNeeded):
+* platform/ScrollAnimator.h:
+* platform/ScrollController.cpp:
+(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset):
+(WebCore::ScrollController::adjustScrollDestination):
+