[webkit-changes] [280376] trunk/Source/WebCore

2021-07-27 Thread jh718 . park 
Title: [280376] trunk/Source/WebCore








Revision 280376
Author jh718.p...@samsung.com
Date 2021-07-27 22:55:23 -0700 (Tue, 27 Jul 2021)


Log Message
Unreviewed. Remove the build warning below since r280332.
warning: redundant move in return statement [-Wredundant-move]

No new tests, no new behaviors.

* html/DOMFormData.cpp:
(WebCore::DOMFormData::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DOMFormData.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (280375 => 280376)

--- trunk/Source/WebCore/ChangeLog	2021-07-28 04:35:15 UTC (rev 280375)
+++ trunk/Source/WebCore/ChangeLog	2021-07-28 05:55:23 UTC (rev 280376)
@@ -1,3 +1,13 @@
+2021-07-27  Joonghun Park  
+
+Unreviewed. Remove the build warning below since r280332.
+warning: redundant move in return statement [-Wredundant-move]
+
+No new tests, no new behaviors.
+
+* html/DOMFormData.cpp:
+(WebCore::DOMFormData::create):
+
 2021-07-27  Devin Rousso  
 
 [Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed


Modified: trunk/Source/WebCore/html/DOMFormData.cpp (280375 => 280376)

--- trunk/Source/WebCore/html/DOMFormData.cpp	2021-07-28 04:35:15 UTC (rev 280375)
+++ trunk/Source/WebCore/html/DOMFormData.cpp	2021-07-28 05:55:23 UTC (rev 280376)
@@ -45,7 +45,7 @@
 {
 auto formData = adoptRef(*new DOMFormData);
 if (!form)
-return WTFMove(formData);
+return formData;
 
 auto result = form->constructEntryList(WTFMove(formData), nullptr, HTMLFormElement::IsMultipartForm::Yes);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280375] trunk/LayoutTests

2021-07-27 Thread sihui_liu 
Title: [280375] trunk/LayoutTests








Revision 280375
Author sihui_...@apple.com
Date 2021-07-27 21:35:15 -0700 (Tue, 27 Jul 2021)


Log Message
Update platform specific TestExpectations for imported IndexedDB tests
https://bugs.webkit.org/show_bug.cgi?id=228241

Reviewed by Alex Christensen.

Update LayoutTests/TestExpectations based on latest test results as we have fixed some existing issues, and
these tests should not fail now.

* platform/ios-device/TestExpectations:
* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-wk2/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-device/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280374 => 280375)

--- trunk/LayoutTests/ChangeLog	2021-07-28 03:56:44 UTC (rev 280374)
+++ trunk/LayoutTests/ChangeLog	2021-07-28 04:35:15 UTC (rev 280375)
@@ -1,3 +1,21 @@
+2021-07-27  Sihui Liu  
+
+Update platform specific TestExpectations for imported IndexedDB tests
+https://bugs.webkit.org/show_bug.cgi?id=228241
+
+Reviewed by Alex Christensen.
+
+Update LayoutTests/TestExpectations based on latest test results as we have fixed some existing issues, and
+these tests should not fail now.
+
+* platform/ios-device/TestExpectations:
+* platform/ios-simulator-wk2/TestExpectations:
+* platform/ios-wk2/TestExpectations:
+* platform/ios/TestExpectations:
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
 2021-07-27  Devin Rousso  
 
 [Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed


Modified: trunk/LayoutTests/platform/ios/TestExpectations (280374 => 280375)

--- trunk/LayoutTests/platform/ios/TestExpectations	2021-07-28 03:56:44 UTC (rev 280374)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2021-07-28 04:35:15 UTC (rev 280375)
@@ -3144,8 +3144,6 @@
 webkit.org/b/206897 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--auto-32px--nonpercent-width-percent-height-viewbox.html [ Skip ]
 webkit.org/b/206897 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--auto-32px--nonpercent-width-omitted-height.html [ Skip ]
 
-webkit.org/b/207057 imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm [ Pass Failure ]
-
 webkit.org/b/207225 imported/w3c/web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https.html [ Pass Failure ]
 
 # Locale-specific shaping is only enabled on certain OSes.


Modified: trunk/LayoutTests/platform/ios-device/TestExpectations (280374 => 280375)

--- trunk/LayoutTests/platform/ios-device/TestExpectations	2021-07-28 03:56:44 UTC (rev 280374)
+++ trunk/LayoutTests/platform/ios-device/TestExpectations	2021-07-28 04:35:15 UTC (rev 280375)
@@ -58,7 +58,6 @@
 http/tests/preload/onload_event.html [ Skip ]
 http/tests/websocket/tests/hybi/multiple-connections.html [ Skip ]
 
-imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm [ Failure ]
 imported/w3c/web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001.html [ Failure ]
 imported/w3c/web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks.html [ Failure ]
 imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html [ Failure ]
@@ -67,7 +66,6 @@
 imported/blink/compositing/child-transform-layer-with-foreground-layer.html [ ImageOnlyFailure ]
 imported/blink/fast/canvas/canvas-unbalanced-save.html [ ImageOnlyFailure ]
 
-imported/w3c/web-platform-tests/IndexedDB/idbcursor-update-exception-order.htm [ Skip ]
 imported/w3c/web-platform-tests/xhr/send-redirect-bogus-sync.htm [ Skip ]
 imported/w3c/web-platform-tests/xhr/send-send.htm [ Skip ]
 imported/w3c/web-platform-tests/cssom/ttwf-cssom-document-extension.html [ Skip ]


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (280374 => 280375)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2021-07-28 03:56:44 UTC (rev 280374)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2021-07-28 04:35:15 UTC (rev 280375)
@@ -53,8 +53,6 @@
 
 webkit.org/b/197207 http/wpt/resource-timing/rt-resources-per-frame.html [ Pass Failure ]
 
-imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm [ Slow ]
-
 webkit.org/b/172001 scrollingcoordinator/ios/sync-layer-positions-after-scroll.html [ Pass

[webkit-changes] [280374] trunk

2021-07-27 Thread drousso 
Title: [280374] trunk








Revision 280374
Author drou...@apple.com
Date 2021-07-27 20:56:44 -0700 (Tue, 27 Jul 2021)


Log Message
[Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed
https://bugs.webkit.org/show_bug.cgi?id=228310


Reviewed by Wenson Hsieh.

Source/WebCore:

Test: media/modern-media-controls/overflow-support/button-state.html

* page/ContextMenuController.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::didDismissContextMenu): Added.
* page/ContextMenuProvider.h:
(WebCore::ContextMenuProvider::didDismissContextMenu): Added.
Add plumbing from WebKit to the `ContextMenuProvider` for when the contextmenu is dismissed.

* Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsContextMenuProvider::didDismissContextMenu): Added.
When the contextmenu is dismissed, invoke the callback provided to `MediaControlsHost::showMediaControlsContextMenu`
as that's the signal to the `MediaController` that the contextmenu interaction is over,
which adjusts the `on` state of the `Button`.

Source/WebKit:

Pipe along the `-[NSMenuDelegate menuDidClose:]` signal to the WebProcess so the `WebCore::ContextMenuProvider`
can handle it if needed.

* UIProcess/WebContextMenuProxy.cpp:
(WebKit::WebContextMenuProxy::useContextMenuItems):
* UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKMenuDelegate menuWillOpen:]):
(-[WKMenuDelegate menuDidClose:]):

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::didShowContextMenu):
(WebKit::WebPageProxy::didDismissContextMenu): Added.

* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):

* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::startWaitingForContextMenuToShow): Added.
(WebKit::WebPage::contextMenuShowing): Deleted.
(WebKit::WebPage::contextMenuHidden): Deleted.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didShowContextMenu): Added.
(WebKit::WebPage::didDismissContextMenu): Added.
(WebKit::WebPage::mouseEvent):
Drive-by: Rename `m_contextMenuShowing` to `m_waitingForContextMenuToShow` for clarity.

Tools:

* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dismissActiveMenu]):
(-[TestRunnerWKWebView immediatelyDismissContextMenuIfNeeded]):
(-[TestRunnerWKWebView _dismissAllContextMenuInteractions]): Added.

LayoutTests:

* media/modern-media-controls/overflow-support/button-state.html: Added.
* media/modern-media-controls/overflow-support/button-state-expected.txt: Added.

* media/modern-media-controls/overflow-support/playback-speed.html:
* media/modern-media-controls/tracks-support/click-track-in-contextmenu.html:
Adjust how these tests wait for and dismiss the contextmenu.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/overflow-support/playback-speed.html
trunk/LayoutTests/media/modern-media-controls/tracks-support/click-track-in-contextmenu.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
trunk/Source/WebCore/page/ContextMenuController.cpp
trunk/Source/WebCore/page/ContextMenuController.h
trunk/Source/WebCore/page/ContextMenuProvider.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebContextMenuProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
trunk/Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm


Added Paths

trunk/LayoutTests/media/modern-media-controls/overflow-support/button-state-expected.txt
trunk/LayoutTests/media/modern-media-controls/overflow-support/button-state.html




Diff

Modified: trunk/LayoutTests/ChangeLog (280373 => 280374)

--- trunk/LayoutTests/ChangeLog	2021-07-28 03:02:11 UTC (rev 280373)
+++ trunk/LayoutTests/ChangeLog	2021-07-28 03:56:44 UTC (rev 280374)
@@ -1,3 +1,18 @@
+2021-07-27  Devin Rousso  
+
+[Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed
+https://bugs.webkit.org/show_bug.cgi?id=228310
+
+
+Reviewed by Wenson Hsieh.
+
+* media/modern-media-controls/overflow-support/button-state.html: Added.
+* media/modern-media-controls/overflow-support/button-state-expected.txt: Added.
+
+* media/modern-media-controls/overflow-support/playback-speed.html:
+* media/modern-media-controls/tracks-support/click-track-in-contextmenu.html:
+Adjust how these tests wait for and dismiss the contextmenu.
+
 2021-07-27  Amir Mark Jr  
 
 [LayoutTests] Delete unused LayoutTests/inspector resources


Added:

[webkit-changes] [280373] tags/Safari-612.1.24.11.6/

2021-07-27 Thread repstein 
Title: [280373] tags/Safari-612.1.24.11.6/








Revision 280373
Author repst...@apple.com
Date 2021-07-27 20:02:11 -0700 (Tue, 27 Jul 2021)


Log Message
Tag Safari-612.1.24.11.6.

Added Paths

tags/Safari-612.1.24.11.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280372] branches/safari-612.1.24.11-branch/Source/WebKit

2021-07-27 Thread repstein 
Title: [280372] branches/safari-612.1.24.11-branch/Source/WebKit








Revision 280372
Author repst...@apple.com
Date 2021-07-27 20:01:10 -0700 (Tue, 27 Jul 2021)


Log Message
Cherry-pick r280351. rdar://problem/81196087

The bundle path of downlevel Safari is wrong
https://bugs.webkit.org/show_bug.cgi?id=228339

Reviewed by Jer Noble.

Fix the bundle path. The correct path is "/Library/Apple/System/Library/StagedFrameworks/Safari".

* Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
(WebKit::isFeatureFlagEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog
branches/safari-612.1.24.11-branch/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm




Diff

Modified: branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog (280371 => 280372)

--- branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog	2021-07-28 02:58:57 UTC (rev 280371)
+++ branches/safari-612.1.24.11-branch/Source/WebKit/ChangeLog	2021-07-28 03:01:10 UTC (rev 280372)
@@ -1,3 +1,32 @@
+2021-07-27  Alan Coon  
+
+Cherry-pick r280351. rdar://problem/81196087
+
+The bundle path of downlevel Safari is wrong
+https://bugs.webkit.org/show_bug.cgi?id=228339
+
+Reviewed by Jer Noble.
+
+Fix the bundle path. The correct path is "/Library/Apple/System/Library/StagedFrameworks/Safari".
+
+* Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
+(WebKit::isFeatureFlagEnabled):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-27  Peng Liu  
+
+The bundle path of downlevel Safari is wrong
+https://bugs.webkit.org/show_bug.cgi?id=228339
+
+Reviewed by Jer Noble.
+
+Fix the bundle path. The correct path is "/Library/Apple/System/Library/StagedFrameworks/Safari".
+
+* Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
+(WebKit::isFeatureFlagEnabled):
+
 2021-07-23  Alan Coon  
 
 Cherry-pick r280274. rdar://problem/81044139


Modified: branches/safari-612.1.24.11-branch/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm (280371 => 280372)

--- branches/safari-612.1.24.11-branch/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm	2021-07-28 02:58:57 UTC (rev 280371)
+++ branches/safari-612.1.24.11-branch/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm	2021-07-28 03:01:10 UTC (rev 280372)
@@ -40,7 +40,7 @@
 // Because of , WebKit has to parse the feature flags plist file
 bool isFeatureFlagEnabled(const String& featureName)
 {
-BOOL isWebKitBundleFromStagedFramework = [[[NSBundle mainBundle] bundlePath] hasPrefix:@"/Library/Apple/System/Library/StagedFrameworks/WebKit"];
+BOOL isWebKitBundleFromStagedFramework = [[[NSBundle mainBundle] bundlePath] hasPrefix:@"/Library/Apple/System/Library/StagedFrameworks/Safari"];
 
 if (!isWebKitBundleFromStagedFramework)
 return _os_feature_enabled_impl("WebKit", (const char*)featureName.utf8().data());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280371] branches/safari-612.1.24.11-branch/Source

2021-07-27 Thread repstein 
Title: [280371] branches/safari-612.1.24.11-branch/Source








Revision 280371
Author repst...@apple.com
Date 2021-07-27 19:58:57 -0700 (Tue, 27 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.24.11.6

Modified Paths

branches/safari-612.1.24.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.24.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.24.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (280370 => 280371)

--- branches/safari-612.1.24.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-28 02:32:49 UTC (rev 280370)
+++ branches/safari-612.1.24.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-28 02:58:57 UTC (rev 280371)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 11;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (280370 => 280371)

--- branches/safari-612.1.24.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-28 02:32:49 UTC (rev 280370)
+++ branches/safari-612.1.24.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-28 02:58:57 UTC (rev 280371)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 11;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (280370 => 280371)

--- branches/safari-612.1.24.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-28 02:32:49 UTC (rev 280370)
+++ branches/safari-612.1.24.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-28 02:58:57 UTC (rev 280371)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 11;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.11-branch/Source/WebCore/Configurations/Version.xcconfig (280370 => 280371)

--- branches/safari-612.1.24.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-28 02:32:49 UTC (rev 280370)
+++ branches/safari-612.1.24.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-28 02:58:57 UTC (rev 280371)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 11;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (280370 => 280371)

--- branches/safari-612.1.24.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-28 02:32:49 UTC (rev 280370)
+++ branches/safari-612.1.24.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-28 02:58:57 UTC (rev 280371)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 11;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (280370 => 280371)

--- branches/safari-612.1.24.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-28 02:32:49 UTC (rev 280370)
+++ branches/safari-612.1.24.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-28 02:58:57 UTC (rev 280371)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 11;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION =

[webkit-changes] [280370] trunk/Source/JavaScriptCore

2021-07-27 Thread pangle 
Title: [280370] trunk/Source/_javascript_Core








Revision 280370
Author pan...@apple.com
Date 2021-07-27 19:32:49 -0700 (Tue, 27 Jul 2021)


Log Message
Web Inspector: [Cocoa] "RemoteInspector XPC connection to relay failed." messages are confusing in StdErr
https://bugs.webkit.org/show_bug.cgi?id=228303

Reviewed by Darin Adler.

Remove overly verbose and confusing `WTFLogAlways` messages added in r278413, which can confuse applications
listening to stderr of a process using _javascript_Core.

* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::xpcConnectionFailed):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280369 => 280370)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-28 02:20:42 UTC (rev 280369)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-28 02:32:49 UTC (rev 280370)
@@ -1,3 +1,16 @@
+2021-07-27  Patrick Angle  
+
+Web Inspector: [Cocoa] "RemoteInspector XPC connection to relay failed." messages are confusing in StdErr
+https://bugs.webkit.org/show_bug.cgi?id=228303
+
+Reviewed by Darin Adler.
+
+Remove overly verbose and confusing `WTFLogAlways` messages added in r278413, which can confuse applications
+listening to stderr of a process using _javascript_Core.
+
+* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
+(Inspector::RemoteInspector::xpcConnectionFailed):
+
 2021-07-27  Alexey Shvayka  
 
 ProxyObject callees should be skipped during Function.prototype.caller resolution


Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm (280369 => 280370)

--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm	2021-07-28 02:20:42 UTC (rev 280369)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm	2021-07-28 02:32:49 UTC (rev 280370)
@@ -373,13 +373,10 @@
 // The XPC connection will close itself.
 m_relayConnection = nullptr;
 
-if (!m_shouldReconnectToRelayOnFailure) {
-WTFLogAlways("RemoteInspector XPC connection to relay failed.");
+if (!m_shouldReconnectToRelayOnFailure)
 return;
-}
 
 m_shouldReconnectToRelayOnFailure = false;
-WTFLogAlways("RemoteInspector XPC connection to relay failed, reconnecting in 1 second...");
 
 // Schedule setting up a new connection, since we currently are holding a lock needed to create a new connection.
 dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 1 * NSEC_PER_SEC), dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280369] trunk/Source/WebCore

2021-07-27 Thread rniwa 
Title: [280369] trunk/Source/WebCore








Revision 280369
Author rn...@webkit.org
Date 2021-07-27 19:20:42 -0700 (Tue, 27 Jul 2021)


Log Message
[macOS] Stop away unpaired surrogate pair in findNextWordFromIndex:forward:
https://bugs.webkit.org/show_bug.cgi?id=228496

Reviewed by Darin Adler.

Replace unpaired surrogate pairs with the replacement character before calling findNextWordFromIndex:forward:

* platform/text/mac/TextBoundaries.mm:
(WebCore::findNextWordFromIndex):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/mac/TextBoundaries.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (280368 => 280369)

--- trunk/Source/WebCore/ChangeLog	2021-07-28 01:38:05 UTC (rev 280368)
+++ trunk/Source/WebCore/ChangeLog	2021-07-28 02:20:42 UTC (rev 280369)
@@ -1,3 +1,15 @@
+2021-07-27  Ryosuke Niwa  
+
+[macOS] Stop away unpaired surrogate pair in findNextWordFromIndex:forward:
+https://bugs.webkit.org/show_bug.cgi?id=228496
+
+Reviewed by Darin Adler.
+
+Replace unpaired surrogate pairs with the replacement character before calling findNextWordFromIndex:forward:
+
+* platform/text/mac/TextBoundaries.mm:
+(WebCore::findNextWordFromIndex):
+
 2021-07-27  Myles C. Maxfield  
 
 [GPU Process] Code cleanup after r280356


Modified: trunk/Source/WebCore/platform/text/mac/TextBoundaries.mm (280368 => 280369)

--- trunk/Source/WebCore/platform/text/mac/TextBoundaries.mm	2021-07-28 01:38:05 UTC (rev 280368)
+++ trunk/Source/WebCore/platform/text/mac/TextBoundaries.mm	2021-07-28 02:20:42 UTC (rev 280369)
@@ -231,9 +231,13 @@
 int findNextWordFromIndex(StringView text, int position, bool forward)
 {   
 #if USE(APPKIT)
+String textWithoutUnpairedSurrogates;
+if (hasUnpairedSurrogate(text)) {
+textWithoutUnpairedSurrogates = replaceUnpairedSurrogatesWithReplacementCharacter(text.toStringWithoutCopying());
+text = textWithoutUnpairedSurrogates;
+}
 auto attributedString = adoptNS([[NSAttributedString alloc] initWithString:text.createNSStringWithoutCopying().get()]);
-int result = [attributedString nextWordFromIndex:position forward:forward];
-return result;
+return [attributedString nextWordFromIndex:position forward:forward];
 #else
 // This very likely won't behave exactly like the non-iPhone version, but it works
 // for the contexts in which it is used on iPhone, and in the future will be






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280368] trunk/LayoutTests

2021-07-27 Thread amir_mark 
Title: [280368] trunk/LayoutTests








Revision 280368
Author amir_m...@apple.com
Date 2021-07-27 18:38:05 -0700 (Tue, 27 Jul 2021)


Log Message
[LayoutTests] Delete unused LayoutTests/inspector resources
https://bugs.webkit.org/show_bug.cgi?id=226800

Reviewed by Jonathan Bedard.

* inspector/console/resources/errors.css: Removed.
* inspector/dom/resources/highlight-iframe.html: Removed.
* inspector/network/resources/data-intercepted.json: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/inspector/console/resources/errors.css
trunk/LayoutTests/inspector/dom/resources/highlight-iframe.html
trunk/LayoutTests/inspector/network/resources/data-intercepted.json




Diff

Modified: trunk/LayoutTests/ChangeLog (280367 => 280368)

--- trunk/LayoutTests/ChangeLog	2021-07-28 01:25:32 UTC (rev 280367)
+++ trunk/LayoutTests/ChangeLog	2021-07-28 01:38:05 UTC (rev 280368)
@@ -1,3 +1,14 @@
+2021-07-27  Amir Mark Jr  
+
+[LayoutTests] Delete unused LayoutTests/inspector resources
+https://bugs.webkit.org/show_bug.cgi?id=226800
+
+Reviewed by Jonathan Bedard.
+
+* inspector/console/resources/errors.css: Removed.
+* inspector/dom/resources/highlight-iframe.html: Removed.
+* inspector/network/resources/data-intercepted.json: Removed.
+
 2021-07-27  Alexey Shvayka  
 
 ProxyObject callees should be skipped during Function.prototype.caller resolution


Deleted: trunk/LayoutTests/inspector/console/resources/errors.css (280367 => 280368)

--- trunk/LayoutTests/inspector/console/resources/errors.css	2021-07-28 01:25:32 UTC (rev 280367)
+++ trunk/LayoutTests/inspector/console/resources/errors.css	2021-07-28 01:38:05 UTC (rev 280368)
@@ -1,7 +0,0 @@
-div { * color: red; } div { * color: red; }
-
-div {
-*
-color:
-red;
-}


Deleted: trunk/LayoutTests/inspector/dom/resources/highlight-iframe.html (280367 => 280368)

--- trunk/LayoutTests/inspector/dom/resources/highlight-iframe.html	2021-07-28 01:25:32 UTC (rev 280367)
+++ trunk/LayoutTests/inspector/dom/resources/highlight-iframe.html	2021-07-28 01:38:05 UTC (rev 280368)
@@ -1,8 +0,0 @@
-
-
-
-
-
-
-
-
\ No newline at end of file


Deleted: trunk/LayoutTests/inspector/network/resources/data-intercepted.json (280367 => 280368)

--- trunk/LayoutTests/inspector/network/resources/data-intercepted.json	2021-07-28 01:25:32 UTC (rev 280367)
+++ trunk/LayoutTests/inspector/network/resources/data-intercepted.json	2021-07-28 01:38:05 UTC (rev 280368)
@@ -1 +0,0 @@
-intercepted request
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280367] trunk/LayoutTests

2021-07-27 Thread jenner 
Title: [280367] trunk/LayoutTests








Revision 280367
Author jen...@apple.com
Date 2021-07-27 18:25:32 -0700 (Tue, 27 Jul 2021)


Log Message
Revert "Batch add test expectations for Monterey and iOS on Open Source"

This reverts commit 0b351bd1e35436f327b82ef38626748dba4b6bb6.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/ios-14-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (280366 => 280367)

--- trunk/LayoutTests/ChangeLog	2021-07-28 00:55:24 UTC (rev 280366)
+++ trunk/LayoutTests/ChangeLog	2021-07-28 01:25:32 UTC (rev 280367)
@@ -58,16 +58,6 @@
 
 * platform/mac-wk1/TestExpectations:
 
-2021-07-27  Robert Jenner  
-
-Batch add test expectations for Monterey and iOS on Open Source
-https://bugs.webkit.org/show_bug.cgi?id=228200
-
-Uneviewed test gardening.
-
-* platform/ios-14-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt: Added.
-* platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt: Added.
-
 2021-07-27  Ayumi Kojima  
 
 [ iOS Release ] imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getContributingSources.https.html is a flaky failure.


Deleted: trunk/LayoutTests/platform/ios-14-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt (280366 => 280367)

--- trunk/LayoutTests/platform/ios-14-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt	2021-07-28 00:55:24 UTC (rev 280366)
+++ trunk/LayoutTests/platform/ios-14-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt	2021-07-28 01:25:32 UTC (rev 280367)
@@ -1,9 +0,0 @@
-
-PASS Style attribute should create CSS declaration block based on its content
-FAIL Changes to style attribute should reflect on CSS declaration block assert_equals: CSS declaration block after removing the style attribute expected "" but got "z-index: 21;"
-PASS Changes to CSS declaration block should reflect on style attribute
-PASS Changes to CSS declaration block should queue mutation record for style attribute
-PASS Removing non-existing property or setting invalid value on CSS declaration block shouldn't queue mutation record
-PASS Changes to CSS declaration block after a base URL change
-FAIL Expansion of all:unset and all:revert treated identically assert_equals: expected "color: unset; color-scheme: unset; display: unset; font-family: unset; font-feature-settings: unset; font-optical-sizing: unset; font-size: unset; font-stretch: unset; font-style: unset; font-synthesis: unset; font-variant-alternates: unset; font-variant-caps: unset; font-variant-east-asian: unset; font-variant-ligatures: unset; font-variant-numeric: unset; font-variant-position: unset; font-variation-settings: unset; font-weight: unset; text-rendering: unset; writing-mode: unset; zoom: unset; -webkit-font-kerning: unset; -webkit-font-smoothing: unset; -webkit-locale: unset; -webkit-text-orientation: unset; -webkit-text-size-adjust: unset; -webkit-text-zoom: unset; align-content: unset; align-items: unset; align-self: unset; alignment-baseline: unset; alt: unset; animation: unset unset unset unset unset unset unset unset; background-attachment: unset; background-blend-mode: unset; background
 -clip: unset; background-color: unset; background-image: unset; background-origin: unset; background-size: unset; baseline-shift: unset; block-size: unset; border-block-end-color: unset; border-block-end-style: unset; border-block-end-width: unset; border-block-start-color: unset; border-block-start-style: unset; border-block-start-width: unset; border: unset unset unset; border-bottom-right-radius: unset; border-collapse: unset; border-image-outset: unset; border-image-repeat: unset; border-image-slice: unset; border-image-source: unset; border-image-width: unset; border-inline-end-color: unset; border-inline-end-style: unset; border-inline-end-width: unset; border-inline-start-color: unset; border-inline-start-style: unset; border-inline-start-width: unset; border-top-left-radius: unset; border-top-right-radius: unset; bottom: unset; box-shadow: unset; box-sizing: unset; break-after: unset; break-before: unset; break-inside: unset; buffered-rendering: unset; caption-side: unset; c
 aret-color: unset; clear: unset; clip: unset; clip-path: unset; clip-rule: unset; color-interpolation: unset; color-interpolation-filters: unset; color-profile: unset; color-rendering: unset; column-count: unset; column-fill: unset; column-gap: unset; column-rule-color: unset; column-rule-style: unset; column-rule-width: unset; column-span: unset; column-width: unset; content: unset; counter-increment: unset; counter-reset: unset; cursor: unset; cx:

[webkit-changes] [280366] trunk/Tools

2021-07-27 Thread dpino 
Title: [280366] trunk/Tools








Revision 280366
Author dp...@igalia.com
Date 2021-07-27 17:55:24 -0700 (Tue, 27 Jul 2021)


Log Message
[GTK][WPE] Fix wrong path to GLIB dependencies introduced in r280354.

Unreviewed follow-up fix.

* gtk/dependencies/apt:
* gtk/dependencies/dnf:
* gtk/dependencies/pacman:
* wpe/dependencies/apt:
* wpe/dependencies/dnf:
* wpe/dependencies/pacman:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/dependencies/apt
trunk/Tools/gtk/dependencies/dnf
trunk/Tools/gtk/dependencies/pacman
trunk/Tools/wpe/dependencies/apt
trunk/Tools/wpe/dependencies/dnf
trunk/Tools/wpe/dependencies/pacman




Diff

Modified: trunk/Tools/ChangeLog (280365 => 280366)

--- trunk/Tools/ChangeLog	2021-07-28 00:47:02 UTC (rev 280365)
+++ trunk/Tools/ChangeLog	2021-07-28 00:55:24 UTC (rev 280366)
@@ -1,3 +1,16 @@
+2021-07-27  Diego Pino Garcia  
+
+[GTK][WPE] Fix wrong path to GLIB dependencies introduced in r280354.
+
+Unreviewed follow-up fix.
+
+* gtk/dependencies/apt:
+* gtk/dependencies/dnf:
+* gtk/dependencies/pacman:
+* wpe/dependencies/apt:
+* wpe/dependencies/dnf:
+* wpe/dependencies/pacman:
+
 2021-07-27  Jonathan Bedard  
 
 [build.webkit.org] Simulator temp files filling up disk


Modified: trunk/Tools/gtk/dependencies/apt (280365 => 280366)

--- trunk/Tools/gtk/dependencies/apt	2021-07-28 00:47:02 UTC (rev 280365)
+++ trunk/Tools/gtk/dependencies/apt	2021-07-28 00:55:24 UTC (rev 280366)
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-source "$(dirname "$0")/../../glib/dependencies/apt"
+source "$(dirname "$0")/../glib/dependencies/apt"
 
 # If the package $1 is available, prints it. Otherwise prints $2.
 # Useful for handling when a package is renamed on new versions of Debian/Ubuntu.


Modified: trunk/Tools/gtk/dependencies/dnf (280365 => 280366)

--- trunk/Tools/gtk/dependencies/dnf	2021-07-28 00:47:02 UTC (rev 280365)
+++ trunk/Tools/gtk/dependencies/dnf	2021-07-28 00:55:24 UTC (rev 280366)
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-source "$(dirname "$0")/../../glib/dependencies/dnf"
+source "$(dirname "$0")/../glib/dependencies/dnf"
 
 PACKAGES+=(
 # These are dependencies necessary for building WebKitGTK.


Modified: trunk/Tools/gtk/dependencies/pacman (280365 => 280366)

--- trunk/Tools/gtk/dependencies/pacman	2021-07-28 00:47:02 UTC (rev 280365)
+++ trunk/Tools/gtk/dependencies/pacman	2021-07-28 00:55:24 UTC (rev 280366)
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-source "$(dirname "$0")/../../glib/dependencies/pacman"
+source "$(dirname "$0")/../glib/dependencies/pacman"
 
 PACKAGES+=(
 # These are dependencies necessary for building WebKitGTK.


Modified: trunk/Tools/wpe/dependencies/apt (280365 => 280366)

--- trunk/Tools/wpe/dependencies/apt	2021-07-28 00:47:02 UTC (rev 280365)
+++ trunk/Tools/wpe/dependencies/apt	2021-07-28 00:55:24 UTC (rev 280366)
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-source "$(dirname "$0")/../../glib/dependencies/apt"
+source "$(dirname "$0")/../glib/dependencies/apt"
 
 # If the package $1 is available, prints it. Otherwise prints $2.
 # Useful for handling when a package is renamed on new versions of Debian/Ubuntu.


Modified: trunk/Tools/wpe/dependencies/dnf (280365 => 280366)

--- trunk/Tools/wpe/dependencies/dnf	2021-07-28 00:47:02 UTC (rev 280365)
+++ trunk/Tools/wpe/dependencies/dnf	2021-07-28 00:55:24 UTC (rev 280366)
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-source "$(dirname "$0")/../../glib/dependencies/dnf"
+source "$(dirname "$0")/../glib/dependencies/dnf"
 
 PACKAGES+=(
 # These are dependencies necessary for building WebKitWPE.


Modified: trunk/Tools/wpe/dependencies/pacman (280365 => 280366)

--- trunk/Tools/wpe/dependencies/pacman	2021-07-28 00:47:02 UTC (rev 280365)
+++ trunk/Tools/wpe/dependencies/pacman	2021-07-28 00:55:24 UTC (rev 280366)
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-source "$(dirname "$0")/../../glib/dependencies/pacman"
+source "$(dirname "$0")/../glib/dependencies/pacman"
 
 PACKAGES+=(
 # These are dependencies necessary for building WPE.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280365] trunk/Tools

2021-07-27 Thread jbedard 
Title: [280365] trunk/Tools








Revision 280365
Author jbed...@apple.com
Date 2021-07-27 17:47:02 -0700 (Tue, 27 Jul 2021)


Log Message
[build.webkit.org] Simulator temp files filling up disk
https://bugs.webkit.org/show_bug.cgi?id=228335


Reviewed by Aakash Jain.

* CISupport/kill-old-processes:
(main): Delete stale simulator files.

Modified Paths

trunk/Tools/CISupport/kill-old-processes
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/kill-old-processes (280364 => 280365)

--- trunk/Tools/CISupport/kill-old-processes	2021-07-28 00:21:05 UTC (rev 280364)
+++ trunk/Tools/CISupport/kill-old-processes	2021-07-28 00:47:02 UTC (rev 280365)
@@ -172,6 +172,8 @@
 os.system("xcrun simctl shutdown booted")
 # Kill all instances of python executing run-webkit-tests
 os.system("ps aux | grep -E '.+/Python .+(run_webkit_tests|run-webkit-tests|mod_pywebsocket)' | grep -v grep | awk '{print $2}' | xargs kill")
+# Remove stale simulator temp files
+os.system('find /private/var/folders -name "Deleting-*" -maxdepth 4 -exec sudo rm -rf {} +')
 elif sys.platform == 'cygwin' or sys.platform == 'win32':
 for task in tasksToKill + tasksToKillWin:
 os.system("taskkill /t /f /im " + task)


Modified: trunk/Tools/ChangeLog (280364 => 280365)

--- trunk/Tools/ChangeLog	2021-07-28 00:21:05 UTC (rev 280364)
+++ trunk/Tools/ChangeLog	2021-07-28 00:47:02 UTC (rev 280365)
@@ -1,3 +1,14 @@
+2021-07-27  Jonathan Bedard  
+
+[build.webkit.org] Simulator temp files filling up disk
+https://bugs.webkit.org/show_bug.cgi?id=228335
+
+
+Reviewed by Aakash Jain.
+
+* CISupport/kill-old-processes:
+(main): Delete stale simulator files.
+
 2021-07-27  Aakash Jain  
 
 Add .gitignore file for CISupport






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280364] trunk

2021-07-27 Thread shvaikalesh 
Title: [280364] trunk








Revision 280364
Author shvaikal...@gmail.com
Date 2021-07-27 17:21:05 -0700 (Tue, 27 Jul 2021)


Log Message
ProxyObject callees should be skipped during Function.prototype.caller resolution
https://bugs.webkit.org/show_bug.cgi?id=228341

Reviewed by Yusuke Suzuki.

Source/_javascript_Core:

Just like a bound function, a Proxy with nullish "apply" handler merely forwards
[[Call]] to its target [1], without pushing onto the execution context stack.
This fact is also noted in Function.prototype.{caller,arguments} reflection proposal [2].

This patch aligns JSC with V8 and SpiderMonkey if Proxy's "apply" handler is userland
or nullish. However, since JSC implements proper tail calls, `Function.prototype.caller`
result is divergent from other engines if the handler is `Reflect.apply`, which performs
a tail call that gets optimized away [2] (unless called by another Proxy).

[1]: https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-call-thisargument-argumentslist (step 8)
[2]: https://github.com/claudepache/es-legacy-function-reflection/blob/master/spec.md#get-functionprototypecaller (see notes)

* runtime/FunctionPrototype.cpp:
(JSC::RetrieveCallerFunctionFunctor::operator() const):

LayoutTests:

* js/caller-property-expected.txt:
* js/script-tests/caller-property.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/caller-property-expected.txt
trunk/LayoutTests/js/script-tests/caller-property.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/FunctionPrototype.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (280363 => 280364)

--- trunk/LayoutTests/ChangeLog	2021-07-28 00:12:30 UTC (rev 280363)
+++ trunk/LayoutTests/ChangeLog	2021-07-28 00:21:05 UTC (rev 280364)
@@ -1,3 +1,13 @@
+2021-07-27  Alexey Shvayka  
+
+ProxyObject callees should be skipped during Function.prototype.caller resolution
+https://bugs.webkit.org/show_bug.cgi?id=228341
+
+Reviewed by Yusuke Suzuki.
+
+* js/caller-property-expected.txt:
+* js/script-tests/caller-property.js:
+
 2021-07-27  Eric Hutchison  
 
 [BigSur wk2 Debug arm64] fast/text/emoji-overlap.html is a flaky image-only failure.


Modified: trunk/LayoutTests/js/caller-property-expected.txt (280363 => 280364)

--- trunk/LayoutTests/js/caller-property-expected.txt	2021-07-28 00:12:30 UTC (rev 280363)
+++ trunk/LayoutTests/js/caller-property-expected.txt	2021-07-28 00:21:05 UTC (rev 280364)
@@ -18,6 +18,13 @@
 PASS strictCaller(boundStrictCallee) threw exception TypeError: 'arguments', 'callee', and 'caller' cannot be accessed in this context..
 PASS strictTailCaller(boundNonStrictCallee) is null
 PASS strictTailCaller(boundStrictCallee) threw exception TypeError: 'arguments', 'callee', and 'caller' cannot be accessed in this context..
+PASS nonStrictCaller(new Proxy(nonStrictCallee, {})) is nonStrictCaller
+PASS nonStrictCaller(new Proxy(nonStrictCallee, {}).bind()) is nonStrictCaller
+PASS nonStrictCaller(new Proxy(new Proxy(nonStrictCallee, {}), {})) is nonStrictCaller
+PASS nonStrictCaller(new Proxy(boundNonStrictCallee, {})) is nonStrictCaller
+PASS nonStrictCaller(new Proxy(nonStrictCallee, Reflect)) is nonStrictCaller
+PASS nonStrictCaller(new Proxy(new Proxy(nonStrictCallee, Reflect), {})) is nonStrictCaller
+PASS nonStrictCaller(new Proxy(new Proxy(nonStrictCallee, {}), Reflect)) is null
 PASS nonStrictGetter(nonStrictAccessor) threw exception TypeError: 'arguments', 'callee', and 'caller' cannot be accessed in this context..
 PASS nonStrictGetter(strictAccessor) threw exception TypeError: 'arguments', 'callee', and 'caller' cannot be accessed in this context..
 PASS strictGetter(nonStrictAccessor) threw exception TypeError: 'arguments', 'callee', and 'caller' cannot be accessed in this context..


Modified: trunk/LayoutTests/js/script-tests/caller-property.js (280363 => 280364)

--- trunk/LayoutTests/js/script-tests/caller-property.js	2021-07-28 00:12:30 UTC (rev 280363)
+++ trunk/LayoutTests/js/script-tests/caller-property.js	2021-07-28 00:21:05 UTC (rev 280364)
@@ -43,6 +43,15 @@
 shouldBe("strictTailCaller(boundNonStrictCallee)", "null");
 shouldThrow("strictTailCaller(boundStrictCallee)");
 
+shouldBe("nonStrictCaller(new Proxy(nonStrictCallee, {}))", "nonStrictCaller");
+shouldBe("nonStrictCaller(new Proxy(nonStrictCallee, {}).bind())", "nonStrictCaller");
+shouldBe("nonStrictCaller(new Proxy(new Proxy(nonStrictCallee, {}), {}))", "nonStrictCaller");
+shouldBe("nonStrictCaller(new Proxy(boundNonStrictCallee, {}))", "nonStrictCaller");
+
+shouldBe("nonStrictCaller(new Proxy(nonStrictCallee, Reflect))", "nonStrictCaller"); // tail call
+shouldBe("nonStrictCaller(new Proxy(new Proxy(nonStrictCallee, Reflect), {}))", "nonStrictCaller"); // tail call
+shouldBe("nonStrictCaller(new Proxy(new Proxy(nonStrictCallee, {}), Reflect))", "null"); // no tail call in Proxy's [[Call]]
+
 // Check that .caller throws as

[webkit-changes] [280363] trunk/LayoutTests

2021-07-27 Thread ehutchison 
Title: [280363] trunk/LayoutTests








Revision 280363
Author ehutchi...@apple.com
Date 2021-07-27 17:12:30 -0700 (Tue, 27 Jul 2021)


Log Message
[BigSur wk2 Debug arm64] fast/text/emoji-overlap.html is a flaky image-only failure.
https://bugs.webkit.org/show_bug.cgi?id=228528.

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280362 => 280363)

--- trunk/LayoutTests/ChangeLog	2021-07-27 23:59:01 UTC (rev 280362)
+++ trunk/LayoutTests/ChangeLog	2021-07-28 00:12:30 UTC (rev 280363)
@@ -1,3 +1,12 @@
+2021-07-27  Eric Hutchison  
+
+[BigSur wk2 Debug arm64] fast/text/emoji-overlap.html is a flaky image-only failure.
+https://bugs.webkit.org/show_bug.cgi?id=228528.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-07-27  Robert Jenner  
 
 Batch add test expectations for Monterey and iOS on Open Source


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280362 => 280363)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-27 23:59:01 UTC (rev 280362)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-28 00:12:30 UTC (rev 280363)
@@ -1611,6 +1611,8 @@
 
 webkit.org/b/228337 [ BigSur Release Debug arm64 ] fast/selectors/selection-window-inactive-stroke-color.html [ Pass ImageOnlyFailure ]
 
+webkit.org/b/228528 [ BigSur Debug arm64 ] fast/text/emoji-overlap.html [ Pass ImageOnlyFailure ]
+
 # webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
 [ Monterey ] imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280362] trunk/Tools

2021-07-27 Thread aakash_jain 
Title: [280362] trunk/Tools








Revision 280362
Author aakash_j...@apple.com
Date 2021-07-27 16:59:01 -0700 (Tue, 27 Jul 2021)


Log Message
Add .gitignore file for CISupport
https://bugs.webkit.org/show_bug.cgi?id=228113

Reviewed by Jonathan Bedard.

* CISupport/.gitignore: Added.

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/CISupport/.gitignore




Diff

Added: trunk/Tools/CISupport/.gitignore (0 => 280362)

--- trunk/Tools/CISupport/.gitignore	(rev 0)
+++ trunk/Tools/CISupport/.gitignore	2021-07-27 23:59:01 UTC (rev 280362)
@@ -0,0 +1,9 @@
+http.log*
+ews.log*
+ews_console.log*
+twistd.log*
+twistd.pid
+state.sqlite
+passwords.json
+public_html/
+workers/


Modified: trunk/Tools/ChangeLog (280361 => 280362)

--- trunk/Tools/ChangeLog	2021-07-27 23:48:49 UTC (rev 280361)
+++ trunk/Tools/ChangeLog	2021-07-27 23:59:01 UTC (rev 280362)
@@ -1,3 +1,12 @@
+2021-07-27  Aakash Jain  
+
+Add .gitignore file for CISupport
+https://bugs.webkit.org/show_bug.cgi?id=228113
+
+Reviewed by Jonathan Bedard.
+
+* CISupport/.gitignore: Added.
+
 2021-07-27  Diego Pino Garcia  
 
 [GTK][WPE] Move WebKitGTK and WPE dependency packages to a common GLIB list






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280361] trunk/Source

2021-07-27 Thread mmaxfield 
Title: [280361] trunk/Source








Revision 280361
Author mmaxfi...@apple.com
Date 2021-07-27 16:48:49 -0700 (Tue, 27 Jul 2021)


Log Message
[GPU Process] Code cleanup after r280356
https://bugs.webkit.org/show_bug.cgi?id=228495

Reviewed by Wenson Hsieh.

Source/WebCore:

3 things:
1. Rename cacheNativeImage()/cacheFont() to recordNativeImageUse()/recordFontUse() since it does more
   than caching now
2. Mark overridden functions as final in RemoteImageBufferProxy because no class inherits from it
3. Remove unnecessary WebCore:: where it isn't necessary

No new tests because there is no behavior change.

* platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::putPixelBuffer):
(WebCore::DisplayList::Recorder::recordNativeImageUse):
(WebCore::DisplayList::Recorder::appendStateChangeItem):
(WebCore::DisplayList::Recorder::appendDrawGlyphsItemWithCachedFont):
(WebCore::DisplayList::Recorder::drawImageBuffer):
(WebCore::DisplayList::Recorder::drawNativeImage):
(WebCore::DisplayList::Recorder::drawPattern):
(WebCore::DisplayList::Recorder::cacheNativeImage): Deleted.
* platform/graphics/displaylists/DisplayListRecorder.h:
(WebCore::DisplayList::Recorder::Delegate::recordNativeImageUse):
(WebCore::DisplayList::Recorder::Delegate::recordFontUse):
(WebCore::DisplayList::Recorder::Delegate::cacheNativeImage): Deleted.
(WebCore::DisplayList::Recorder::Delegate::cacheFont): Deleted.

Source/WebKit:

* WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
(WebKit::RemoteImageBufferProxy::putPixelBuffer):
* WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::recordNativeImageUse):
(WebKit::RemoteResourceCacheProxy::recordFontUse):
(WebKit::RemoteResourceCacheProxy::cacheNativeImage): Deleted.
(WebKit::RemoteResourceCacheProxy::cacheFont): Deleted.
* WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (280360 => 280361)

--- trunk/Source/WebCore/ChangeLog	2021-07-27 23:45:49 UTC (rev 280360)
+++ trunk/Source/WebCore/ChangeLog	2021-07-27 23:48:49 UTC (rev 280361)
@@ -1,5 +1,35 @@
 2021-07-27  Myles C. Maxfield  
 
+[GPU Process] Code cleanup after r280356
+https://bugs.webkit.org/show_bug.cgi?id=228495
+
+Reviewed by Wenson Hsieh.
+
+3 things:
+1. Rename cacheNativeImage()/cacheFont() to recordNativeImageUse()/recordFontUse() since it does more
+   than caching now
+2. Mark overridden functions as final in RemoteImageBufferProxy because no class inherits from it
+3. Remove unnecessary WebCore:: where it isn't necessary
+
+No new tests because there is no behavior change.
+
+* platform/graphics/displaylists/DisplayListRecorder.cpp:
+(WebCore::DisplayList::Recorder::putPixelBuffer):
+(WebCore::DisplayList::Recorder::recordNativeImageUse):
+(WebCore::DisplayList::Recorder::appendStateChangeItem):
+(WebCore::DisplayList::Recorder::appendDrawGlyphsItemWithCachedFont):
+(WebCore::DisplayList::Recorder::drawImageBuffer):
+(WebCore::DisplayList::Recorder::drawNativeImage):
+(WebCore::DisplayList::Recorder::drawPattern):
+(WebCore::DisplayList::Recorder::cacheNativeImage): Deleted.
+* platform/graphics/displaylists/DisplayListRecorder.h:
+(WebCore::DisplayList::Recorder::Delegate::recordNativeImageUse):
+(WebCore::DisplayList::Recorder::Delegate::recordFontUse):
+(WebCore::DisplayList::Recorder::Delegate::cacheNativeImage): Deleted.
+(WebCore::DisplayList::Recorder::Delegate::cacheFont): Deleted.
+
+2021-07-27  Myles C. Maxfield  
+
 [GPU Process] Start tracking resource uses for NativeImages and Fonts
 https://bugs.webkit.org/show_bug.cgi?id=228224
 


Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp (280360 => 280361)

--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp	2021-07-27 23:45:49 UTC (rev 280360)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp	2021-07-27 23:48:49 UTC (rev 280361)
@@ -71,7 +71,7 @@
 append(outputFormat, sourceRect);
 }
 
-void Recorder::putPixelBuffer(const WebCore::PixelBuffer& pixelBuffer, const WebCore::IntRect& srcRect, const WebCore::IntPoint& destPoint, WebCore::AlphaPremultiplication destFormat)
+void Recorder::putPixelBuffer(const PixelBuffer& pixelBuffer, const IntRect& srcRect, const IntPoint& destPoint, AlphaPremultiplication

[webkit-changes] [280360] trunk/LayoutTests

2021-07-27 Thread jenner 
Title: [280360] trunk/LayoutTests








Revision 280360
Author jen...@apple.com
Date 2021-07-27 16:45:49 -0700 (Tue, 27 Jul 2021)


Log Message
Batch add test expectations for Monterey and iOS on Open Source
https://bugs.webkit.org/show_bug.cgi?id=228200

Unreviewed test gardening.

* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (280359 => 280360)

--- trunk/LayoutTests/ChangeLog	2021-07-27 23:30:41 UTC (rev 280359)
+++ trunk/LayoutTests/ChangeLog	2021-07-27 23:45:49 UTC (rev 280360)
@@ -1,3 +1,12 @@
+2021-07-27  Robert Jenner  
+
+Batch add test expectations for Monterey and iOS on Open Source
+https://bugs.webkit.org/show_bug.cgi?id=228200
+
+Unreviewed test gardening.
+
+* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
+
 2021-07-27  Aditya Keerthi  
 
 [iOS] REGRESSION: Tapping a  element does not show a menu on many websites


Modified: trunk/LayoutTests/platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt (280359 => 280360)

--- trunk/LayoutTests/platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt	2021-07-27 23:30:41 UTC (rev 280359)
+++ trunk/LayoutTests/platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt	2021-07-27 23:45:49 UTC (rev 280360)
@@ -15,10 +15,10 @@
 RenderText {#text} at (639,21) size 137x12
   text run at (639,21) width 137 RTL: "\x{628}\x{62F}\x{621} \x{627}\x{644}\x{62A}\x{62D}\x{642}\x{64A}\x{642} \x{641}\x{64A} \x{62A}\x{62D}\x{637}\x{645} \x{627}\x{644}\x{637}\x{627}\x{626}\x{631}\x{629} \x{627}\x{644}\x{627}\x{633}\x{628}\x{627}\x{646}\x{64A}\x{629}"
   RenderBlock {DIV} at (0,84) size 784x50 [bgcolor=#D3D3D3]
-RenderInline {SPAN} at (0,0) size 137x17 [color=#FF] [border: (1px solid #008000) none (1px solid #FF) none]
-  RenderText {#text} at (639,9) size 137x15
-text run at (639,9) width 137 RTL: "\x{628}\x{62F}\x{621} \x{627}\x{644}\x{645}\x{64D} \x{641}\x{64A} \x{62A}\x{62D}\x{637}\x{645} \x{644}\x{62C}\x{645}\x{64E}\x{651}\x{644} \x{627}\x{644}\x{627}\x{633}\x{628}\x{627}\x{646}\x{64A}\x{629}"
-RenderBR {BR} at (639,8) size 1x15
+RenderInline {SPAN} at (0,0) size 136x17 [color=#FF] [border: (1px solid #008000) none (1px solid #FF) none]
+  RenderText {#text} at (640,9) size 136x15
+text run at (640,9) width 136 RTL: "\x{628}\x{62F}\x{621} \x{627}\x{644}\x{645}\x{64D} \x{641}\x{64A} \x{62A}\x{62D}\x{637}\x{645} \x{644}\x{62C}\x{645}\x{64E}\x{651}\x{644} \x{627}\x{644}\x{627}\x{633}\x{628}\x{627}\x{646}\x{64A}\x{629}"
+RenderBR {BR} at (640,8) size 1x15
 RenderText {#text} at (612,26) size 164x15
   text run at (612,26) width 164 RTL: "\x{628}\x{62F}\x{621} \x{627}\x{644}\x{62A}\x{62D}\x{642}\x{64A}\x{642} \x{641}\x{64A} \x{62A}\x{62D}\x{637}\x{645} \x{627}\x{644}\x{637}\x{627}\x{626}\x{631}\x{629} \x{627}\x{644}\x{627}\x{633}\x{628}\x{627}\x{646}\x{64A}\x{629}"
   RenderBlock {DIV} at (0,142) size 784x56 [bgcolor=#D3D3D3]
@@ -29,23 +29,23 @@
 RenderText {#text} at (585,29) size 191x18
   text run at (585,29) width 191 RTL: "\x{628}\x{62F}\x{621} \x{627}\x{644}\x{62A}\x{62D}\x{642}\x{64A}\x{642} \x{641}\x{64A} \x{62A}\x{62D}\x{637}\x{645} \x{627}\x{644}\x{637}\x{627}\x{626}\x{631}\x{629} \x{627}\x{644}\x{627}\x{633}\x{628}\x{627}\x{646}\x{64A}\x{629}"
   RenderBlock {DIV} at (0,206) size 784x80 [bgcolor=#D3D3D3]
-RenderInline {SPAN} at (0,0) size 273x31 [color=#FF] [border: (1px solid #008000) none (1px solid #FF) none]
-  RenderText {#text} at (503,9) size 273x29
-text run at (503,9) width 273 RTL: "\x{628}\x{62F}\x{621} \x{627}\x{644}\x{645}\x{64D} \x{641}\x{64A} \x{62A}\x{62D}\x{637}\x{645} \x{644}\x{62C}\x{645}\x{64E}\x{651}\x{644} \x{627}\x{644}\x{627}\x{633}\x{628}\x{627}\x{646}\x{64A}\x{629}"
-RenderBR {BR} at (503,8) size 1x29
+RenderInline {SPAN} at (0,0) size 272x31 [color=#FF] [border: (1px solid #008000) none (1px solid #FF) none]
+  RenderText {#text} at (504,9) size 272x29
+text run at (504,9) width 272 RTL: "\x{628}\x{62F}\x{621} \x{627}\x{644}\x{645}\x{64D} \x{641}\x{64A} \x{62A}\x{62D}\x{637}\x{645} \x{644}\x{62C}\x{645}\x{64E}\x{651}\x{644} \x{627}\x{644}\x{627}\x{633}\x{628}\x{627}\x{646}\x{64A}\x{629}"
+RenderBR {BR} at (504,8) size 1x29
 RenderText {#text} at (448,41) size 328x29
   text run at (448,41) width 328 RTL: "\x{628}\x{62F}\x{621} \x{627}\x{644}\x{62A}\x{62D}\x{642}\x{64A}\x{642} \x{641}\x{64A}

[webkit-changes] [280359] trunk

2021-07-27 Thread akeerthi 
Title: [280359] trunk








Revision 280359
Author akeer...@apple.com
Date 2021-07-27 16:30:41 -0700 (Tue, 27 Jul 2021)


Log Message
[iOS] REGRESSION: Tapping a  element does not show a menu on many websites
https://bugs.webkit.org/show_bug.cgi?id=228340
rdar://77137768

Reviewed by Wenson Hsieh.

Source/WebKit:

Many sites add a touchend event listener to their select elements, that
is responsible for focusing the element. With the introduction of
asynchronous touch events, the single tap gesture recognizer can be
deferred to the point it occurs after the UIProcess is notified that an
element has been focused. This is problematic, since the UIProcess
creates and displays inputs peripherals in response to element focus,
but the gesture recognizer can dismiss presented peripherals via
`-[WKFormPeripheral endEditing]`. Consequently, many sites immediately
display and dismiss the input peripheral.

To fix, only call `-[WKFormPeripheral endEditing]` if the peripheral
was already being displayed once the tap gesture began. This ensures we
do not immediately display and dismiss peripherals.

Note that with the redesigned form controls, the call to `endEditing` is
unnecessary, as the presented views handle their own dismissal. However,
the logic is still needed for the old select control (using a keyboard
input view), to commit value changes. The old control is displayed on
apps linked against iOS 13 or earlier. This behavior is tested in
fast/forms/ios/select-picker-change-and-focus-another-select.html.

Test: fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _singleTapIdentified:]):
(-[WKContentView _singleTapRecognized:]):
* UIProcess/ios/forms/WKFormPeripheral.h:
* UIProcess/ios/forms/WKFormPeripheralBase.h:

LayoutTests:

Added a test to verify that tapping a select element, that focuses itself
inside a touchend listener, displays a menu.

* fast/forms/ios/form-control-refresh/select/focus-select-in-touchend-expected.txt: Added.
* fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/forms/WKFormPeripheral.h
trunk/Source/WebKit/UIProcess/ios/forms/WKFormPeripheralBase.h


Added Paths

trunk/LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend-expected.txt
trunk/LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html




Diff

Modified: trunk/LayoutTests/ChangeLog (280358 => 280359)

--- trunk/LayoutTests/ChangeLog	2021-07-27 23:19:32 UTC (rev 280358)
+++ trunk/LayoutTests/ChangeLog	2021-07-27 23:30:41 UTC (rev 280359)
@@ -1,3 +1,17 @@
+2021-07-27  Aditya Keerthi  
+
+[iOS] REGRESSION: Tapping a  element does not show a menu on many websites
+https://bugs.webkit.org/show_bug.cgi?id=228340
+rdar://77137768
+
+Reviewed by Wenson Hsieh.
+
+Added a test to verify that tapping a select element, that focuses itself
+inside a touchend listener, displays a menu.
+
+* fast/forms/ios/form-control-refresh/select/focus-select-in-touchend-expected.txt: Added.
+* fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html: Added.
+
 2021-07-27  Ayumi Kojima  
 
 [ iOS ] media/track/track-in-band-duplicate-tracks-when-source-changes.html is a flaky timeout.


Added: trunk/LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend-expected.txt (0 => 280359)

--- trunk/LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend-expected.txt	2021-07-27 23:30:41 UTC (rev 280359)
@@ -0,0 +1,11 @@
+This test verifies that a dropdown menu is displayed, and can be interacted with, after tapping on a select element that focuses itself inside a touchend listener.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS select.value is "January"
+PASS select.value is "April"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html (0 => 280359)

--- trunk/LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html	2021-07-27 23:30:41 UTC (rev 280359)
@@ -0,0 +1,44 @@
+ 
+
+
+
+
+
+