[webkit-changes] [280510] trunk/LayoutTests

[sihui_liu]

Title: [280510] trunk/LayoutTests








Revision 280510
Author sihui_...@apple.com
Date 2021-07-30 23:41:34 -0700 (Fri, 30 Jul 2021)


Log Message
[ macOS wk2 ARM 64 ] storage/indexeddb/IDBObject-leak.html is a flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=223453


Reviewed by Youenn Fablet.

As _javascript_Core uses conservative GC, transaction may be still be alive after one gc call, so we should invoke
gc multiple times.

Also, this patch renames IDBObject-leak.html to database-transaction-cycle.html to better indicate what it is
testing.

* TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/wk2/TestExpectations:
* storage/indexeddb/IDBObject-leak-expected.txt: Removed.
* storage/indexeddb/IDBObject-leak.html: Removed.
* storage/indexeddb/database-transaction-cycle-expected.txt: Added.
* storage/indexeddb/database-transaction-cycle.html: Added.
* storage/indexeddb/resources/database-transaction-cycle-iframe.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations


Added Paths

trunk/LayoutTests/storage/indexeddb/database-transaction-cycle-expected.txt
trunk/LayoutTests/storage/indexeddb/database-transaction-cycle.html
trunk/LayoutTests/storage/indexeddb/resources/database-transaction-cycle-iframe.html


Removed Paths

trunk/LayoutTests/storage/indexeddb/IDBObject-leak-expected.txt
trunk/LayoutTests/storage/indexeddb/IDBObject-leak.html




Diff

Modified: trunk/LayoutTests/ChangeLog (280509 => 280510)

--- trunk/LayoutTests/ChangeLog	2021-07-31 06:07:09 UTC (rev 280509)
+++ trunk/LayoutTests/ChangeLog	2021-07-31 06:41:34 UTC (rev 280510)
@@ -1,3 +1,26 @@
+2021-07-30  Sihui Liu  
+
+[ macOS wk2 ARM 64 ] storage/indexeddb/IDBObject-leak.html is a flakey text failure
+https://bugs.webkit.org/show_bug.cgi?id=223453
+
+
+Reviewed by Youenn Fablet.
+
+As _javascript_Core uses conservative GC, transaction may be still be alive after one gc call, so we should invoke
+gc multiple times.
+
+Also, this patch renames IDBObject-leak.html to database-transaction-cycle.html to better indicate what it is
+testing.
+
+* TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* platform/wk2/TestExpectations:
+* storage/indexeddb/IDBObject-leak-expected.txt: Removed.
+* storage/indexeddb/IDBObject-leak.html: Removed.
+* storage/indexeddb/database-transaction-cycle-expected.txt: Added.
+* storage/indexeddb/database-transaction-cycle.html: Added.
+* storage/indexeddb/resources/database-transaction-cycle-iframe.html: Added.
+
 2021-07-30  Rob Buis  
 
 [css-overflow] Implement clip value for overflow


Modified: trunk/LayoutTests/TestExpectations (280509 => 280510)

--- trunk/LayoutTests/TestExpectations	2021-07-31 06:07:09 UTC (rev 280509)
+++ trunk/LayoutTests/TestExpectations	2021-07-31 06:41:34 UTC (rev 280510)
@@ -186,7 +186,7 @@
 http/tests/navigation/process-swap-window-open.html [ Skip ]
 http/tests/navigation/useragent-reload.py [ Skip ]
 storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Skip ]
-storage/indexeddb/IDBObject-leak.html [ Skip ]
+storage/indexeddb/database-transaction-cycle.html [ Skip ]
 fast/forms/call-text-did-change-in-text-field-when-typing.html [ Skip ]
 http/tests/in-app-browser-privacy/ [ Skip ]
 fast/speechrecognition/permission-error.html [ Skip ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280509 => 280510)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-31 06:07:09 UTC (rev 280509)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-31 06:41:34 UTC (rev 280510)
@@ -111,6 +111,8 @@
 fast/forms/file/entries-api/image-transcode-open-panel.html [ Pass ]
 fast/forms/file/entries-api/image-no-transcode-open-panel.html [ Pass ]
 
+storage/indexeddb/database-transaction-cycle.html [ Pass ]
+
 #//
 # End platform-specific directories.
 #//
@@ -1382,8 +1384,6 @@
 
 webkit.org/b/223383 compositing/video/video-border-radius.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/223453 [ arm64 ] storage/indexeddb/IDBObject-leak.html [ Pass Failure ]
-
 webkit.org/b/223462 [ Debug arm64 ] imported/w3c/web-platform-tests/mediacapture-streams/GUM-optional-constraint.https.html [ Pass Crash ]
 
 webkit.org/b/223486 [ arm64 ] inspector/css/modify-inline-style.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/wk2/TestExpectations (280509 => 280510)

--- trunk/LayoutTests/platform/wk2/TestExpectations	2021-07-31 06:07:09 UTC (rev 280509)
+++ trunk/LayoutTests/platform/wk2/TestExpectations	2021-07-31 06:41:34 UTC (rev 280510)
@@ -793,7 +793,6 @@
 
 http/tests/navigation/use

[webkit-changes] [280509] trunk

[commit-queue]

Title: [280509] trunk








Revision 280509
Author commit-qu...@webkit.org
Date 2021-07-30 23:07:09 -0700 (Fri, 30 Jul 2021)


Log Message
[css-overflow] Implement clip value for overflow
https://bugs.webkit.org/show_bug.cgi?id=198230

Patch by Rob Buis  on 2021-07-30
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-overflow/overflow-clip-hit-testing-expected.txt: Added.
* web-platform-tests/css/css-overflow/overflow-clip-scroll-size-expected.txt: Added.
* web-platform-tests/css/css-overflow/parsing/overflow-computed-expected.txt:
* web-platform-tests/css/css-overflow/parsing/overflow-valid-expected.txt:

Source/WebCore:

Implement overflow: clip. Parsing is like the other
overflow values but special logic is added to handle
the case where only one of overflow-x/overflow-y uses
'clip' [1]. Also adjusts code that computes layout and
visual overflow to take overflow: clip into account.

This matches Chrome and Firefox.

[1] https://drafts.csswg.org/css-overflow/#propdef-overflow-x

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator Overflow const):
* css/CSSProperties.json:
* css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):
* css/parser/CSSParserContext.h:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
* page/FrameView.cpp: handle scrollbars
on viewport element same as overflow: hidden.
(WebCore::FrameView::applyOverflowToViewport):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::scrollWidth const): overflow clip
forbids all scrolling.
(WebCore::RenderBox::scrollHeight const): Ditto.
(WebCore::RenderBox::setScrollLeft): Ditto.
(WebCore::RenderBox::setScrollTop): Ditto.
(WebCore::RenderBox::setScrollPosition): Ditto.
(WebCore::RenderBox::requiresLayerWithScrollableArea const): do
not create layer with scrollable area for overflow: clip.
(WebCore::RenderBox::canBeProgramaticallyScrolled const): overflow clip
forbids all scrolling.
(WebCore::RenderBox::scrollPosition const): overflow clip
forbids all scrolling.
(WebCore::RenderBox::overflowClipRect const): only clip the rect horizontally
for overflow-x: clip and only vertically for overflow-y: clip.
(WebCore::RenderBox::createsNewFormattingContext const): do
not create formatting context for overflow: clip.
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::layoutOverflowRectForPropagation const):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingScrollableContainerForSnapping const):
* rendering/RenderObject.h: Add helper method that excludes overflow-x/y: clip.
(WebCore::RenderObject::hasPotentiallyScrollableOverflow const):
* rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* rendering/style/RenderStyleConstants.h:
* style/StyleAdjuster.cpp: Add special logic is to handle the case where only
one of overflow-x/overflow-y uses 'clip'.
(WebCore::Style::Adjuster::adjust const):

Source/WTF:

Add preference for overflow: clip support.

* Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/parsing/overflow-computed-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/parsing/overflow-valid-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/parser/CSSParserContext.cpp
trunk/Source/WebCore/css/parser/CSSParserContext.h
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.cpp
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/style/StyleAdjuster.cpp


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-hit-testing-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-scroll-size-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (280508 => 280509)

--- trunk/LayoutTests/ChangeLog	2021-07-31 04:46:30 UTC (rev 280508)
+++ trunk/LayoutTests/ChangeLog	2021-07-31 06:07:09 UTC (rev 280509)
@@ -1,3 +1,12 @@
+2021-07-30  Rob Buis  
+
+[css-overflow] Implement clip value for overflow
+https://bugs.webkit.org/show_bug.cgi?id=198230
+
+Reviewed by Simon Fraser.
+
+* TestExpectations:
+
 2021-07-30  Chris Dumez  
 
 Add initial supp

[webkit-changes] [280508] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [280508] trunk/Source/_javascript_Core








Revision 280508
Author ysuz...@apple.com
Date 2021-07-30 21:46:30 -0700 (Fri, 30 Jul 2021)


Log Message
[JSC] branchTest8 should not emit tst for Zero/NonZero cases
https://bugs.webkit.org/show_bug.cgi?id=228674

Reviewed by Mark Lam.

Previously, branchTest8(NonZero, BaseIndex) emits `tst` instruction
unnecessarily. This is because the mask is truncated into 8bit, which
makes branchTest32 (which is internally used in branchTest8) emits tst.
We observed many unnecessary tst in YarrJIT.

This patch removes this unnecessary truncation since Zero/NonZero does
not care high bits of mask in branchTest8. This is ok because the
ResultCondition version of mask8OnCondition() is always used to generate
a mask that is only used against a value that is loaded with
MacroAssemblerHelpers::load8OnCondition(). For Zero/NonZero conditions,
load8OnCondition() will always zero fill the upper bytes. The 0 filled
upper bytes will not affect the result of a branch on zero or branch on
not zero.

Before:
   0x10a8068b0:ldrb w16, [x7, x6]
   0x10a8068b4:tst  w16, #0xff
   0x10a8068b8:b.ne   0x10a8068cc

After:
   0x1070068b0:ldrb w16, [x7, x6]
   0x1070068b4:cbnz w16, 0x1070068c8

* assembler/MacroAssemblerHelpers.h:
(JSC::MacroAssemblerHelpers::mask8OnCondition):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerHelpers.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280507 => 280508)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-31 01:40:05 UTC (rev 280507)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-31 04:46:30 UTC (rev 280508)
@@ -1,3 +1,36 @@
+2021-07-30  Yusuke Suzuki  
+
+[JSC] branchTest8 should not emit tst for Zero/NonZero cases
+https://bugs.webkit.org/show_bug.cgi?id=228674
+
+Reviewed by Mark Lam.
+
+Previously, branchTest8(NonZero, BaseIndex) emits `tst` instruction
+unnecessarily. This is because the mask is truncated into 8bit, which
+makes branchTest32 (which is internally used in branchTest8) emits tst.
+We observed many unnecessary tst in YarrJIT.
+
+This patch removes this unnecessary truncation since Zero/NonZero does
+not care high bits of mask in branchTest8. This is ok because the
+ResultCondition version of mask8OnCondition() is always used to generate
+a mask that is only used against a value that is loaded with
+MacroAssemblerHelpers::load8OnCondition(). For Zero/NonZero conditions,
+load8OnCondition() will always zero fill the upper bytes. The 0 filled
+upper bytes will not affect the result of a branch on zero or branch on
+not zero.
+
+Before:
+   0x10a8068b0:ldrb w16, [x7, x6]
+   0x10a8068b4:tst  w16, #0xff
+   0x10a8068b8:b.ne   0x10a8068cc
+
+After:
+   0x1070068b0:ldrb w16, [x7, x6]
+   0x1070068b4:cbnz w16, 0x1070068c8
+
+* assembler/MacroAssemblerHelpers.h:
+(JSC::MacroAssemblerHelpers::mask8OnCondition):
+
 2021-07-30  Robin Morisset  
 
 Improve OSR entry into Wasm loops with arguments


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerHelpers.h (280507 => 280508)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerHelpers.h	2021-07-31 01:40:05 UTC (rev 280507)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerHelpers.h	2021-07-31 04:46:30 UTC (rev 280508)
@@ -113,6 +113,12 @@
 template
 inline typename MacroAssemblerType::TrustedImm32 mask8OnCondition(MacroAssemblerType&, typename MacroAssemblerType::ResultCondition cond, typename MacroAssemblerType::TrustedImm32 value)
 {
+// If condition is Zero or NonZero, upper bits are unrelated.
+// Since branchTest32 handles -1 in an optimized manner, we keep -1 as is instead of converting it to 255.
+if (cond == MacroAssemblerType::Zero || cond == MacroAssemblerType::NonZero) {
+if (value.m_value == -1)
+return value;
+}
 if (isUnsigned(cond))
 return typename MacroAssemblerType::TrustedImm32(static_cast(value.m_value));
 ASSERT_WITH_MESSAGE(cond != MacroAssemblerType::Overflow, "Overflow is not used for 8bit test operations.");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280507] trunk

[rmorisset]

Title: [280507] trunk








Revision 280507
Author rmoris...@apple.com
Date 2021-07-30 18:40:05 -0700 (Fri, 30 Jul 2021)


Log Message
Improve OSR entry into Wasm loops with arguments
https://bugs.webkit.org/show_bug.cgi?id=228595

Reviewed by Yusuke Suzuki.

JSTests:

Just a straightforward test that counts to 1M in a loop, to exercise both OSR entry and a loop with an argument at the same time.
100k iterations was not enough to reliably complete an OSR entry.

* wasm/stress/osr-entry-with-loop-arguments.js: Added.
(async test):

Source/_javascript_Core:

This patch has two parts:
- improve the Wasm OSR code to fully support loop arguments (just some plumbing to make sure that the right values are propagated)
- improve the B3 validator to fix a hole I noticed while writing the first part: we were not detecting code that introduce Upsilons in the wrong blocks.
  Naturally, this caused hard to debug issues, as B3 has no well-defined semantics for a Phi that is reached before the corresponding Upsilon(s).

* b3/B3Validate.cpp:
* wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck):
(JSC::Wasm::AirIRGenerator::addLoop):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck):
(JSC::Wasm::B3IRGenerator::addLoop):
* wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::addLoop):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3Validate.cpp
trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
trunk/Source/_javascript_Core/wasm/WasmLLIntGenerator.cpp


Added Paths

trunk/JSTests/wasm/stress/osr-entry-with-loop-arguments.js




Diff

Modified: trunk/JSTests/ChangeLog (280506 => 280507)

--- trunk/JSTests/ChangeLog	2021-07-31 01:36:50 UTC (rev 280506)
+++ trunk/JSTests/ChangeLog	2021-07-31 01:40:05 UTC (rev 280507)
@@ -1,3 +1,16 @@
+2021-07-30  Robin Morisset  
+
+Improve OSR entry into Wasm loops with arguments
+https://bugs.webkit.org/show_bug.cgi?id=228595
+
+Reviewed by Yusuke Suzuki.
+
+Just a straightforward test that counts to 1M in a loop, to exercise both OSR entry and a loop with an argument at the same time.
+100k iterations was not enough to reliably complete an OSR entry.
+
+* wasm/stress/osr-entry-with-loop-arguments.js: Added.
+(async test):
+
 2021-07-30  Tadeu Zagallo  
 
 putInlineFastReplacingStaticPropertyIfNeeded should handle custom values


Added: trunk/JSTests/wasm/stress/osr-entry-with-loop-arguments.js (0 => 280507)

--- trunk/JSTests/wasm/stress/osr-entry-with-loop-arguments.js	(rev 0)
+++ trunk/JSTests/wasm/stress/osr-entry-with-loop-arguments.js	2021-07-31 01:40:05 UTC (rev 280507)
@@ -0,0 +1,29 @@
+import * as assert from '../assert.js';
+import { instantiate } from "../wabt-wrapper.js";
+
+let wat = `
+(module
+  (func (export "test") (param $countArg i32) (result i32) (local $result i32)
+i32.const 0
+(loop (param i32) (result i32)
+  i32.const 1
+  i32.add
+  local.tee $result
+  local.get $result
+  local.get $countArg
+  i32.lt_u
+  br_if 0
+)
+  )
+)
+`;
+
+async function test() {
+let instance = await instantiate(wat);
+
+let result = instance.exports.test(100);
+if (result !== 100)
+throw new Error("Expected 10, but got: " + result);
+}
+
+assert.asyncTest(test());


Modified: trunk/Source/_javascript_Core/ChangeLog (280506 => 280507)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-31 01:36:50 UTC (rev 280506)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-31 01:40:05 UTC (rev 280507)
@@ -1,3 +1,25 @@
+2021-07-30  Robin Morisset  
+
+Improve OSR entry into Wasm loops with arguments
+https://bugs.webkit.org/show_bug.cgi?id=228595
+
+Reviewed by Yusuke Suzuki.
+
+This patch has two parts:
+- improve the Wasm OSR code to fully support loop arguments (just some plumbing to make sure that the right values are propagated)
+- improve the B3 validator to fix a hole I noticed while writing the first part: we were not detecting code that introduce Upsilons in the wrong blocks.
+  Naturally, this caused hard to debug issues, as B3 has no well-defined semantics for a Phi that is reached before the corresponding Upsilon(s).
+
+* b3/B3Validate.cpp:
+* wasm/WasmAirIRGenerator.cpp:
+(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck):
+(JSC::Wasm::AirIRGenerator::addLoop):
+* wasm/WasmB3IRGenerator.cpp:
+(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck):
+(JSC::Wasm::B3IRGenerator::addLoop):
+* wasm/WasmLLIntGenerator.cpp:
+(JSC::Wasm::LLIntGenerator::addLoop):
+
 2021-07-30  Philip Chimento  
 
 [JSC] Rename Temporal.now to Temporal.Now


Modified: trunk/Source/_javascript_Core/b3/B3Validate.cpp (280506 => 280507)

--- 

[webkit-changes] [280506] trunk/Source/JavaScriptCore

[commit-queue]

Title: [280506] trunk/Source/_javascript_Core








Revision 280506
Author commit-qu...@webkit.org
Date 2021-07-30 18:36:50 -0700 (Fri, 30 Jul 2021)


Log Message
[JSC] Rename Temporal.now to Temporal.Now
https://bugs.webkit.org/show_bug.cgi?id=228658

Patch by Philip Chimento  on 2021-07-30
Reviewed by Yusuke Suzuki.

See https://github.com/tc39/proposal-temporal/pull/1645. In the July
2021 meeting TC39 achieved consensus to rename Temporal.now to
Temporal.Now since it is a namespace.

* runtime/TemporalNow.cpp: Change Now[@@toStringTag] accordingly.
* runtime/TemporalObject.cpp: Rename now property to Now.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/TemporalNow.cpp
trunk/Source/_javascript_Core/runtime/TemporalObject.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280505 => 280506)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-31 01:33:44 UTC (rev 280505)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-31 01:36:50 UTC (rev 280506)
@@ -1,3 +1,17 @@
+2021-07-30  Philip Chimento  
+
+[JSC] Rename Temporal.now to Temporal.Now
+https://bugs.webkit.org/show_bug.cgi?id=228658
+
+Reviewed by Yusuke Suzuki.
+
+See https://github.com/tc39/proposal-temporal/pull/1645. In the July
+2021 meeting TC39 achieved consensus to rename Temporal.now to
+Temporal.Now since it is a namespace.
+
+* runtime/TemporalNow.cpp: Change Now[@@toStringTag] accordingly.
+* runtime/TemporalObject.cpp: Rename now property to Now.
+
 2021-07-30  Tadeu Zagallo  
 
 putInlineFastReplacingStaticPropertyIfNeeded should handle custom values


Modified: trunk/Source/_javascript_Core/runtime/TemporalNow.cpp (280505 => 280506)

--- trunk/Source/_javascript_Core/runtime/TemporalNow.cpp	2021-07-31 01:33:44 UTC (rev 280505)
+++ trunk/Source/_javascript_Core/runtime/TemporalNow.cpp	2021-07-31 01:36:50 UTC (rev 280506)
@@ -29,7 +29,7 @@
 
 STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE(TemporalNow);
 
-const ClassInfo TemporalNow::s_info = { "Temporal.now", &Base::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(TemporalNow) };
+const ClassInfo TemporalNow::s_info = { "Temporal.Now", &Base::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(TemporalNow) };
 
 TemporalNow::TemporalNow(VM& vm, Structure* structure)
 : Base(vm, structure)


Modified: trunk/Source/_javascript_Core/runtime/TemporalObject.cpp (280505 => 280506)

--- trunk/Source/_javascript_Core/runtime/TemporalObject.cpp	2021-07-31 01:33:44 UTC (rev 280505)
+++ trunk/Source/_javascript_Core/runtime/TemporalObject.cpp	2021-07-31 01:36:50 UTC (rev 280506)
@@ -45,7 +45,7 @@
 
 /* Source for TemporalObject.lut.h
 @begin temporalObjectTable
-  nowcreateNowObject DontEnum|PropertyCallback
+  NowcreateNowObject DontEnum|PropertyCallback
 @end
 */
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280505] trunk

[tzagallo]

Title: [280505] trunk








Revision 280505
Author tzaga...@apple.com
Date 2021-07-30 18:33:44 -0700 (Fri, 30 Jul 2021)


Log Message
putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
https://bugs.webkit.org/show_bug.cgi?id=227963

Reviewed by Alexey Shvayka.

JSTests:

* stress/reflect-set-custom-value.js:

Source/_javascript_Core:

Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called when the
target property of the receiver is a custom value and isn't reified. The previous test case was expanded to
test both the reified and non-reified cases.

* runtime/JSObject.cpp:
(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
* tools/JSDollarVM.cpp:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/reflect-set-custom-value.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/tools/JSDollarVM.cpp




Diff

Modified: trunk/JSTests/ChangeLog (280504 => 280505)

--- trunk/JSTests/ChangeLog	2021-07-31 00:07:37 UTC (rev 280504)
+++ trunk/JSTests/ChangeLog	2021-07-31 01:33:44 UTC (rev 280505)
@@ -1,3 +1,12 @@
+2021-07-30  Tadeu Zagallo  
+
+putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
+https://bugs.webkit.org/show_bug.cgi?id=227963
+
+Reviewed by Alexey Shvayka.
+
+* stress/reflect-set-custom-value.js:
+
 2021-07-29  Tadeu Zagallo  
 
 definePropertyOnReceiver should check if receiver canPerformFastPutInline


Modified: trunk/JSTests/stress/reflect-set-custom-value.js (280504 => 280505)

--- trunk/JSTests/stress/reflect-set-custom-value.js	2021-07-31 00:07:37 UTC (rev 280504)
+++ trunk/JSTests/stress/reflect-set-custom-value.js	2021-07-31 01:33:44 UTC (rev 280505)
@@ -1,3 +1,14 @@
-const testGetterSetter = $vm.createCustomTestGetterSetter();
-Reflect.set({}, 'customValue', 'foo', testGetterSetter);
-testGetterSetter.customValue = 42;
+{
+// reified
+const testGetterSetter = $vm.createCustomTestGetterSetter();
+Reflect.set({}, 'customValue', 'foo', testGetterSetter);
+testGetterSetter.customValue = 42;
+}
+
+{
+// non-reified
+let tester = $vm.createStaticCustomValue();
+Reflect.set({}, "testStaticValueSetFlag", 'foo', tester);
+if (!tester.testStaticValueSetterCalled)
+throw new Error('Custom value overriden');
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (280504 => 280505)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-31 00:07:37 UTC (rev 280504)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-31 01:33:44 UTC (rev 280505)
@@ -1,3 +1,19 @@
+2021-07-30  Tadeu Zagallo  
+
+putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
+https://bugs.webkit.org/show_bug.cgi?id=227963
+
+Reviewed by Alexey Shvayka.
+
+Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
+custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called when the
+target property of the receiver is a custom value and isn't reified. The previous test case was expanded to
+test both the reified and non-reified cases.
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
+* tools/JSDollarVM.cpp:
+
 2021-07-30  Yusuke Suzuki  
 
 Unreviewed, fix wrong access width


Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (280504 => 280505)

--- trunk/Source/_javascript_Core/runtime/JSObject.cpp	2021-07-31 00:07:37 UTC (rev 280504)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp	2021-07-31 01:33:44 UTC (rev 280505)
@@ -936,9 +936,13 @@
 // FIXME: For an accessor with setter, the error message is misleading.
 return typeError(globalObject, scope, slot.isStrictMode(), ReadonlyPropertyWriteError);
 }
+if (entry->value->attributes() & PropertyAttribute::CustomValue) {
+PutValueFunc customSetter = entry->value->propertyPutter();
+if (customSetter)
+RELEASE_AND_RETURN(scope, customSetter(structure->globalObject(), JSValue::encode(this), JSValue::encode(value), propertyName));
+}
 // Avoid PutModePut because it fails for non-extensible structures.
-ASSERT(!(entry->value->attributes() & PropertyAttribute::CustomValue));
-putDirect(vm, propertyName, value, attributesForStructure(entry->value->attributes()), slot);
+putDirect(vm, propertyName, value, attributesForStructure(entry->value->attributes()) & ~PropertyAttribute::CustomValue, slot);
 return true;
 }
 }


Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (280504 => 280505

[webkit-changes] [280503] trunk/LayoutTests

[ayumi_kojima]

Title: [280503] trunk/LayoutTests








Revision 280503
Author ayumi_koj...@apple.com
Date 2021-07-30 16:57:59 -0700 (Fri, 30 Jul 2021)


Log Message
[ iOS ] http/wpt/service-workers/navigation-redirect-main-frame.https.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=228670

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280502 => 280503)

--- trunk/LayoutTests/ChangeLog	2021-07-30 23:08:15 UTC (rev 280502)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 23:57:59 UTC (rev 280503)
@@ -1,3 +1,12 @@
+2021-07-30  Ayumi Kojima  
+
+[ iOS ] http/wpt/service-workers/navigation-redirect-main-frame.https.html is a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=228670
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-07-30  Chris Dumez  
 
 Unreviewed, reverting r280482.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (280502 => 280503)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-30 23:08:15 UTC (rev 280502)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-30 23:57:59 UTC (rev 280503)
@@ -1882,6 +1882,8 @@
 
 webkit.org/b/215351 http/wpt/service-workers/module-meta-url-fragment.https.html [ Pass Failure ]
 
+webkit.org/b/228670 http/wpt/service-workers/navigation-redirect-main-frame.https.html [ Pass Timeout ]
+
 webkit.org/b/228165 http/wpt/webrtc/transfer-datachannel-service-worker.https.html [ Pass Failure ]
 
 webkit.org/b/215398 [ Release ] imported/w3c/web-platform-tests/css/css-images/idlharness.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280502] trunk

[cdumez]

Title: [280502] trunk








Revision 280502
Author cdu...@apple.com
Date 2021-07-30 16:08:15 -0700 (Fri, 30 Jul 2021)


Log Message
Unreviewed, reverting r280482.

Will take a more conservative approach

Reverted changeset:

"HTMLElement.innerText setter should convert new lines to
"
https://bugs.webkit.org/show_bug.cgi?id=228605
https://commits.webkit.org/r280482

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/mac/pseudo-element-text-markers-expected.txt
trunk/LayoutTests/editing/pasteboard/smart-paste-paragraph-003-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-and-outertext-properties/innertext-setter-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-idl-attribute/setter-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/innerText/setter-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/textarea-scrollbar-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/textarea-scrolled-type-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/textarea-width-expected.txt
trunk/LayoutTests/platform/ios-wk2/editing/input/reveal-caret-of-multiline-input-expected.txt
trunk/LayoutTests/platform/ios-wk2/fast/forms/textarea-scroll-height-expected.txt
trunk/LayoutTests/platform/ios-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt
trunk/LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-scroll-height-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-scrollbar-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-width-expected.txt
trunk/LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt
trunk/LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt
trunk/LayoutTests/platform/mac/http/tests/navigation/_javascript_link-frames-expected.txt
trunk/LayoutTests/platform/mac-catalina/editing/input/reveal-caret-of-multiline-input-expected.txt
trunk/LayoutTests/platform/mac-catalina/fast/forms/basic-textareas-quirks-expected.txt
trunk/LayoutTests/platform/mac-catalina/fast/parser/open-comment-in-textarea-expected.txt
trunk/LayoutTests/platform/mac-catalina/http/tests/navigation/_javascript_link-frames-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLElement.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (280501 => 280502)

--- trunk/LayoutTests/ChangeLog	2021-07-30 23:04:07 UTC (rev 280501)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 23:08:15 UTC (rev 280502)
@@ -1,3 +1,16 @@
+2021-07-30  Chris Dumez  
+
+Unreviewed, reverting r280482.
+
+Will take a more conservative approach
+
+Reverted changeset:
+
+"HTMLElement.innerText setter should convert new lines to
+"
+https://bugs.webkit.org/show_bug.cgi?id=228605
+https://commits.webkit.org/r280482
+
 2021-07-30  Jean-Yves Avenard  
 
 REGRESSION (r274460?): Infinite recursion on fullscreen/full-screen-remove-ancestor.html in WTR::InjectedBundlePage::closeFullScreen


Modified: trunk/LayoutTests/accessibility/mac/pseudo-element-text-markers-expected.txt (280501 => 280502)

--- trunk/LayoutTests/accessibility/mac/pseudo-element-text-markers-expected.txt	2021-07-30 23:04:07 UTC (rev 280501)
+++ trunk/LayoutTests/accessibility/mac/pseudo-element-text-markers-expected.txt	2021-07-30 23:08:15 UTC (rev 280502)
@@ -27,16 +27,17 @@
 AXRole: AXStaticText AXValue: ".
 AXRole: AXGroup AXValue:
 AXRole: AXStaticText AXValue: AXRole: AXScrollArea AXValue:
-AXRole: AXStaticText AXValue: AXRole: AXWebArea AXValue:
-AXRole: AXStaticText AXValue: AXRole: AXGroup AXValue:
-AXRole: AXStaticText AXValue: AXRole: AXStaticText AXValue: Hello
-AXRole: AXStaticText AXValue: AXRole: AXGroup AXValue:
-AXRole: AXStaticText AXValue: AXRole: AXStaticText AXValue: This tests that the pseudo element style:body:before is accessible via the accessibility tree but not via TextMarkers.
-AXRole: AXStaticText AXValue: AXRole: AXGroup AXValue:
-AXRole: AXStaticText AXValue: AXRole: AXStaticText AXValue: On success, you will see a series of "
-AXRole: AXStaticText AXValue: AXRole: AXStaticText AXValue: PASS
-AXRole: AXStaticText AXValue: AXRole: AXStaticText AXValue: " messages, followed by "
-AXRole: AXStaticText AXValue: AXRole: AXStaticText AXValue: TEST COMPLETE
-AXRole: AXStaticText AXValue: AXRole: AXStaticText AXValue: ".
-AXRole: AXStaticText AXValue: AXRole: AXGroup AXValue:
+AXRole: AXWebArea AXValue:
+AXRole: AXGroup AXValue:
+AXRole: AXStaticText AXValue: Hello
+AXRole: AXGroup AXValue:
+AXRole: AXStaticText AXValue: This tests that the pseudo element style:body:before is accessible via the a

[webkit-changes] [280501] trunk/Source/WebCore

[commit-queue]

Title: [280501] trunk/Source/WebCore








Revision 280501
Author commit-qu...@webkit.org
Date 2021-07-30 16:04:07 -0700 (Fri, 30 Jul 2021)


Log Message
Add spacebar functionality for macOS smooth scrolling
https://bugs.webkit.org/show_bug.cgi?id=228155

Patch by Dana Estra  on 2021-07-30
Reviewed by Tim Horton.

Fixed bug that was causing spacebar events to return false from beginKeyboardScrollGesture.

Manually tested on webpage.

* platform/KeyboardScrollingAnimator.cpp:
(WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (280500 => 280501)

--- trunk/Source/WebCore/ChangeLog	2021-07-30 22:38:29 UTC (rev 280500)
+++ trunk/Source/WebCore/ChangeLog	2021-07-30 23:04:07 UTC (rev 280501)
@@ -1,3 +1,17 @@
+2021-07-30  Dana Estra  
+
+Add spacebar functionality for macOS smooth scrolling
+https://bugs.webkit.org/show_bug.cgi?id=228155
+
+Reviewed by Tim Horton.
+
+Fixed bug that was causing spacebar events to return false from beginKeyboardScrollGesture.
+
+Manually tested on webpage.
+
+* platform/KeyboardScrollingAnimator.cpp:
+(WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):
+
 2021-07-30  Chris Dumez  
 
 Unreviewed follow-up to r280491 to address review feedback from Darin Adler.


Modified: trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp (280500 => 280501)

--- trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp	2021-07-30 22:38:29 UTC (rev 280500)
+++ trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp	2021-07-30 23:04:07 UTC (rev 280501)
@@ -230,7 +230,7 @@
 
 m_currentKeyboardScroll = scroll;
 
-if (event.type() != eventNames().keydownEvent)
+if (!(event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent))
 return false;
 
 if (m_scrollTriggeringKeyIsPressed)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280500] trunk

[jya]

Title: [280500] trunk








Revision 280500
Author j...@apple.com
Date 2021-07-30 15:38:29 -0700 (Fri, 30 Jul 2021)


Log Message
REGRESSION (r274460?): Infinite recursion on fullscreen/full-screen-remove-ancestor.html in WTR::InjectedBundlePage::closeFullScreen
https://bugs.webkit.org/show_bug.cgi?id=224085
rdar://75576840

Reviewed by Eric Carlson.

Source/WebKit:

WebFullScreenManager::close() is used to cleanup a transient error when exiting or
attempting to exit fullscreen; it then calls InjectedBundleXXX::closeFullScreen().
It is possible for the injected bundle's closeFullScreen() to attempt to exit full
screen mode again.
Rather than making the bundle responsible for doing the right thing, we add a
workaround in the fullscreen manager to ensure no recursion is happening.

Covered by existing test.

* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::close):
* WebProcess/FullScreen/WebFullScreenManager.h: Make close() method private

LayoutTests:

* platform/mac-wk2/TestExpectations: re-enable test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h




Diff

Modified: trunk/LayoutTests/ChangeLog (280499 => 280500)

--- trunk/LayoutTests/ChangeLog	2021-07-30 22:29:52 UTC (rev 280499)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 22:38:29 UTC (rev 280500)
@@ -1,3 +1,13 @@
+2021-07-30  Jean-Yves Avenard  
+
+REGRESSION (r274460?): Infinite recursion on fullscreen/full-screen-remove-ancestor.html in WTR::InjectedBundlePage::closeFullScreen
+https://bugs.webkit.org/show_bug.cgi?id=224085
+rdar://75576840
+
+Reviewed by Eric Carlson.
+
+* platform/mac-wk2/TestExpectations: re-enable test.
+
 2021-07-30  Ayumi Kojima  
 
 [ iPad ] fast/canvas/canvas-color-space-display-p3.html is failing.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280499 => 280500)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-30 22:29:52 UTC (rev 280499)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-30 22:38:29 UTC (rev 280500)
@@ -1500,8 +1500,6 @@
 # rdar://80335452 ([ Monterey wk2 Release ] fast/scrolling/iframe-scrollable-after-back.html is a flaky timeout)
 [ Monterey ] fast/scrolling/iframe-scrollable-after-back.html [ Pass Timeout ]
 
-webkit.org/b/224085 fullscreen/full-screen-remove-ancestor.html [ Skip ]
-
 webkit.org/b/227776 [ BigSur Release arm64 ] scrollbars/corner-resizer-window-inactive.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/227776 [ Catalina Release ] scrollbars/corner-resizer-window-inactive.html [ Pass ImageOnlyFailure ]


Modified: trunk/Source/WebKit/ChangeLog (280499 => 280500)

--- trunk/Source/WebKit/ChangeLog	2021-07-30 22:29:52 UTC (rev 280499)
+++ trunk/Source/WebKit/ChangeLog	2021-07-30 22:38:29 UTC (rev 280500)
@@ -1,3 +1,24 @@
+2021-07-30  Jean-Yves Avenard  
+
+REGRESSION (r274460?): Infinite recursion on fullscreen/full-screen-remove-ancestor.html in WTR::InjectedBundlePage::closeFullScreen
+https://bugs.webkit.org/show_bug.cgi?id=224085
+rdar://75576840
+
+Reviewed by Eric Carlson.
+
+WebFullScreenManager::close() is used to cleanup a transient error when exiting or
+attempting to exit fullscreen; it then calls InjectedBundleXXX::closeFullScreen().
+It is possible for the injected bundle's closeFullScreen() to attempt to exit full
+screen mode again.
+Rather than making the bundle responsible for doing the right thing, we add a
+workaround in the fullscreen manager to ensure no recursion is happening.
+
+Covered by existing test.
+
+* WebProcess/FullScreen/WebFullScreenManager.cpp:
+(WebKit::WebFullScreenManager::close):
+* WebProcess/FullScreen/WebFullScreenManager.h: Make close() method private
+
 2021-07-30  Tim Horton  
 
 Accessibility code logs to stderr in many layout test runs


Modified: trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp (280499 => 280500)

--- trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp	2021-07-30 22:29:52 UTC (rev 280499)
+++ trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp	2021-07-30 22:38:29 UTC (rev 280500)
@@ -263,8 +263,12 @@
 
 void WebFullScreenManager::close()
 {
+if (m_closing)
+return;
+m_closing = true;
 LOG(Fullscreen, "WebFullScreenManager %p close()", this);
 m_page->injectedBundleFullScreenClient().closeFullScreen(m_page.get());
+m_closing = false;
 }
 
 void WebFullScreenManager::saveScrollPosition()


Modified: trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h (280499 => 280500)

--- trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h	2021-07-30 22:29:52 UTC (rev 280499)
+++ trunk/Source/

[webkit-changes] [280499] trunk/LayoutTests

[ayumi_kojima]

Title: [280499] trunk/LayoutTests








Revision 280499
Author ayumi_koj...@apple.com
Date 2021-07-30 15:29:52 -0700 (Fri, 30 Jul 2021)


Log Message
[ iPad ] fast/canvas/canvas-color-space-display-p3.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=228663

Unreviewed test gardening.

* platform/ipad/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ipad/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280498 => 280499)

--- trunk/LayoutTests/ChangeLog	2021-07-30 22:03:41 UTC (rev 280498)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 22:29:52 UTC (rev 280499)
@@ -1,5 +1,14 @@
 2021-07-30  Ayumi Kojima  
 
+[ iPad ] fast/canvas/canvas-color-space-display-p3.html is failing.
+https://bugs.webkit.org/show_bug.cgi?id=228663
+
+Unreviewed test gardening.
+
+* platform/ipad/TestExpectations:
+
+2021-07-30  Ayumi Kojima  
+
 [ iOS Debug ] fast/events/tabindex-focus-blur-all.html is failing.
 https://bugs.webkit.org/show_bug.cgi?id=228659
 


Modified: trunk/LayoutTests/platform/ipad/TestExpectations (280498 => 280499)

--- trunk/LayoutTests/platform/ipad/TestExpectations	2021-07-30 22:03:41 UTC (rev 280498)
+++ trunk/LayoutTests/platform/ipad/TestExpectations	2021-07-30 22:29:52 UTC (rev 280499)
@@ -67,3 +67,5 @@
 media/remove-video-element-in-pip-from-document.html [ Pass ]
 
 webkit.org/b/228622 [ Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html [ Crash ]
+
+webkit.org/b/228663 fast/canvas/canvas-color-space-display-p3.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280498] trunk/Source/WebCore

[cdumez]

Title: [280498] trunk/Source/WebCore








Revision 280498
Author cdu...@apple.com
Date 2021-07-30 15:03:41 -0700 (Fri, 30 Jul 2021)


Log Message
Unreviewed follow-up to r280491 to address review feedback from Darin Adler.

Use URL::isBlankURL() instead of a case-sensitive match for aboutBlankURL().

* dom/Document.cpp:
(WebCore::Document::updateBaseURL):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (280497 => 280498)

--- trunk/Source/WebCore/ChangeLog	2021-07-30 21:35:35 UTC (rev 280497)
+++ trunk/Source/WebCore/ChangeLog	2021-07-30 22:03:41 UTC (rev 280498)
@@ -1,3 +1,12 @@
+2021-07-30  Chris Dumez  
+
+Unreviewed follow-up to r280491 to address review feedback from Darin Adler.
+
+Use URL::isBlankURL() instead of a case-sensitive match for aboutBlankURL().
+
+* dom/Document.cpp:
+(WebCore::Document::updateBaseURL):
+
 2021-07-30  Dana Estra  
 
 Add key-driven smooth scrolling to macOS


Modified: trunk/Source/WebCore/dom/Document.cpp (280497 => 280498)

--- trunk/Source/WebCore/dom/Document.cpp	2021-07-30 21:35:35 UTC (rev 280497)
+++ trunk/Source/WebCore/dom/Document.cpp	2021-07-30 22:03:41 UTC (rev 280498)
@@ -3419,7 +3419,7 @@
 // and DOM 3 Core does not specify how it should be resolved.
 m_baseURL = URL({ }, documentURI());
 
-if (m_baseURL == aboutBlankURL()) {
+if (m_baseURL.isAboutBlank()) {
 auto* creator = parentDocument();
 if (!creator && frame() && frame()->loader().opener())
 creator = frame()->loader().opener()->document();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280497] trunk/LayoutTests

[ayumi_kojima]

Title: [280497] trunk/LayoutTests








Revision 280497
Author ayumi_koj...@apple.com
Date 2021-07-30 14:35:35 -0700 (Fri, 30 Jul 2021)


Log Message
[ iOS Debug ] fast/events/tabindex-focus-blur-all.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=228659

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280496 => 280497)

--- trunk/LayoutTests/ChangeLog	2021-07-30 21:16:42 UTC (rev 280496)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 21:35:35 UTC (rev 280497)
@@ -1,5 +1,14 @@
 2021-07-30  Ayumi Kojima  
 
+[ iOS Debug ] fast/events/tabindex-focus-blur-all.html is failing.
+https://bugs.webkit.org/show_bug.cgi?id=228659
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-07-30  Ayumi Kojima  
+
 REGRESSION (r275641): [ iPad Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html is asserting.
 https://bugs.webkit.org/show_bug.cgi?id=228622
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (280496 => 280497)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-30 21:16:42 UTC (rev 280496)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-30 21:35:35 UTC (rev 280497)
@@ -1411,7 +1411,6 @@
 
 webkit.org/b/208590 [ Debug ] fast/events/beforeunload-prompt.html [ Pass Crash ]
 
-webkit.org/b/228038 [ Debug ] fast/events/tabindex-focus-blur-all.html [ Pass Crash ]
 webkit.org/b/228038 [ Debug ] fast/mediastream/apply-constraints-video.html [ Pass Crash ]
 webkit.org/b/228038 media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html [ Pass Crash ]
 webkit.org/b/228038 [ Debug ] media/non-existent-video-playback-interrupted.html  [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280496] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [280496] trunk/Source/_javascript_Core








Revision 280496
Author ysuz...@apple.com
Date 2021-07-30 14:16:42 -0700 (Fri, 30 Jul 2021)


Log Message
Unreviewed, fix wrong access width
https://bugs.webkit.org/show_bug.cgi?id=228301
rdar://81341472

* yarr/YarrJIT.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280495 => 280496)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-30 20:58:39 UTC (rev 280495)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-30 21:16:42 UTC (rev 280496)
@@ -1,3 +1,11 @@
+2021-07-30  Yusuke Suzuki  
+
+Unreviewed, fix wrong access width
+https://bugs.webkit.org/show_bug.cgi?id=228301
+rdar://81341472
+
+* yarr/YarrJIT.cpp:
+
 2021-07-30  Yijia Huang  
 
 Add Pre/Post-Indexed Address Mode to Air for ARM64


Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (280495 => 280496)

--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2021-07-30 20:58:39 UTC (rev 280495)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2021-07-30 21:16:42 UTC (rev 280496)
@@ -2412,7 +2412,7 @@
 auto loopHead = label();
 readCharacter(m_checkedOffset - endIndex + 1, regT0);
 and32(TrustedImm32(BoyerMooreBitmap::mapMask), regT0, regT0);
-auto matched = branchTest32(NonZero, BaseIndex(regT1, regT0, TimesOne));
+auto matched = branchTest8(NonZero, BaseIndex(regT1, regT0, TimesOne));
 op.m_jumps.append(jumpIfNoAvailableInput(endIndex - beginIndex));
 jump().linkTo(loopHead, this);
 matched.link(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280495] trunk/LayoutTests

[ayumi_kojima]

Title: [280495] trunk/LayoutTests








Revision 280495
Author ayumi_koj...@apple.com
Date 2021-07-30 13:58:39 -0700 (Fri, 30 Jul 2021)


Log Message
REGRESSION (r275641): [ iPad Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html is asserting.
https://bugs.webkit.org/show_bug.cgi?id=228622

Unreviewed test gardening.

* platform/ipad/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ipad/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280494 => 280495)

--- trunk/LayoutTests/ChangeLog	2021-07-30 20:46:26 UTC (rev 280494)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 20:58:39 UTC (rev 280495)
@@ -1,5 +1,14 @@
 2021-07-30  Ayumi Kojima  
 
+REGRESSION (r275641): [ iPad Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html is asserting.
+https://bugs.webkit.org/show_bug.cgi?id=228622
+
+Unreviewed test gardening.
+
+* platform/ipad/TestExpectations:
+
+2021-07-30  Ayumi Kojima  
+
 [ iPad ] Rebaselining fast/dom/collection-iterators.html.
 https://bugs.webkit.org/show_bug.cgi?id=228657
 


Modified: trunk/LayoutTests/platform/ipad/TestExpectations (280494 => 280495)

--- trunk/LayoutTests/platform/ipad/TestExpectations	2021-07-30 20:46:26 UTC (rev 280494)
+++ trunk/LayoutTests/platform/ipad/TestExpectations	2021-07-30 20:58:39 UTC (rev 280495)
@@ -65,3 +65,5 @@
 
 media/picture-in-picture [ Pass ]
 media/remove-video-element-in-pip-from-document.html [ Pass ]
+
+webkit.org/b/228622 [ Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html [ Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280494] trunk/LayoutTests

[ayumi_kojima]

Title: [280494] trunk/LayoutTests








Revision 280494
Author ayumi_koj...@apple.com
Date 2021-07-30 13:46:26 -0700 (Fri, 30 Jul 2021)


Log Message
[ iPad ] Rebaselining fast/dom/collection-iterators.html.
https://bugs.webkit.org/show_bug.cgi?id=228657

Unreviewed test gardening.

* platform/ipad/fast/dom/collection-iterators-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/ipad/fast/dom/collection-iterators-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (280493 => 280494)

--- trunk/LayoutTests/ChangeLog	2021-07-30 20:44:47 UTC (rev 280493)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 20:46:26 UTC (rev 280494)
@@ -1,3 +1,12 @@
+2021-07-30  Ayumi Kojima  
+
+[ iPad ] Rebaselining fast/dom/collection-iterators.html.
+https://bugs.webkit.org/show_bug.cgi?id=228657
+
+Unreviewed test gardening.
+
+* platform/ipad/fast/dom/collection-iterators-expected.txt: Added.
+
 2021-07-30  Chris Dumez  
 
 Document's fallback base URL should be deduced from its creator when URL is about:blank


Added: trunk/LayoutTests/platform/ipad/fast/dom/collection-iterators-expected.txt (0 => 280494)

--- trunk/LayoutTests/platform/ipad/fast/dom/collection-iterators-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ipad/fast/dom/collection-iterators-expected.txt	2021-07-30 20:46:26 UTC (rev 280494)
@@ -0,0 +1,18 @@
+--- /Volumes/Data/worker/ipados-simulator-14-debug-tests-wk2/build/layout-test-results/fast/dom/collection-iterators-expected.txt
 /Volumes/Data/worker/ipados-simulator-14-debug-tests-wk2/build/layout-test-results/fast/dom/collection-iterators-actual.txt
+@@ -129,6 +129,15 @@
+ PASS 'forEach' in obj is false
+ PASS 'values' in obj is false
+ 
++* SourceBufferList
++PASS obj.__proto__ is SourceBufferList.prototype
++PASS Symbol.iterator in obj is true
++PASS for..of did not throw an exception
++PASS 'entries' in obj is false
++PASS 'keys' in obj is false
++PASS 'forEach' in obj is false
++PASS 'values' in obj is false
++
+ * StyleSheetList
+ PASS obj.__proto__ is StyleSheetList.prototype
+ PASS Symbol.iterator in obj is true






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280493] trunk/Source/JavaScriptCore

[yijia_huang]

Title: [280493] trunk/Source/_javascript_Core








Revision 280493
Author yijia_hu...@apple.com
Date 2021-07-30 13:44:47 -0700 (Fri, 30 Jul 2021)


Log Message
Add Pre/Post-Indexed Address Mode to Air for ARM64
https://bugs.webkit.org/show_bug.cgi?id=228047

Reviewed by Phil Pizlo.

Pre-indexed addressing means that the address is the sum of the value in the 64-bit base register
and an offset, and the address is then written back to the base register. And post-indexed
addressing means that the address is the value in the 64-bit base register, and the sum of the
address and the offset is then written back to the base register. They are relatively common for
loops to iterate over an array by increasing/decreasing a pointer into the array at each iteration.
With such an addressing mode, the instruction selector can merge the increment and access the array.

#
## Pre-Index Address Mode For Load ##
#

LDR Wt, [Xn, #imm]!

In B3 Reduction Strength, since we have this reduction rule:
Turn this: Load(Add(address, offset1), offset = offset2)
Into this: Load(address, offset = offset1 + offset2)

Then, the equivalent pattern is:
address = Add(base, offset)
...
memory = Load(base, offset)

First, we convert it to the canonical form:
address = Add(base, offset)
newMemory = Load(base, offset) // move the memory to just after the address
...
memory = Identity(newMemory)

Next, lower to Air:
Move %base, %address
Move (%address, prefix(offset)), %newMemory

##
## Post-Index Address Mode For Load ##
##

LDR Wt, [Xn], #imm

Then, the equivalent pattern is:
memory = Load(base, 0)
...
address = Add(base, offset)

First, we convert it to the canonical form:
newOffset = Constant
newAddress = Add(base, offset)
memory = Load(base, 0) // move the offset and address to just before the memory
...
offset = Identity(newOffset)
address = Identity(newAddress)

Next, lower to Air:
Move %base, %newAddress
Move (%newAddress, postfix(offset)), %memory

#
## Pattern Match Algorithm ##
#

To detect the pattern for prefix/postfix increment address is tricky due to the structure in B3 IR. The
algorithm used in this patch is to collect the first valid values (add/load), then search for any
paired value (load/add) to match all of them. In worst case, the runtime complexity is O(n^2)
when n is the number of all values.

After collecting two sets of candidates, we match the prefix incremental address first since it seems
more beneficial to the compiler (shown in the next section). And then, go for the postfix one.

##
## Test for Pre/Post-Increment Address Mode ##
##

Given Loop with Pre-Increment:
int64_t ldr_pre(int64_t *p) {
int64_t res = 0;
while (res < 10)
res += *++p;
return res;
}

B3 IR:
--
BB#0: ; frequency = 1.00
Int64 b@0 = Const64(0)
Int64 b@2 = ArgumentReg(%x0)
Void b@20 = Upsilon($0(b@0), ^18, WritesLocalState)
Void b@21 = Upsilon(b@2, ^19, WritesLocalState)
Void b@4 = Jump(Terminal)
Successors: #1
BB#1: ; frequency = 1.00
Predecessors: #0, #2
Int64 b@18 = Phi(ReadsLocalState)
Int64 b@19 = Phi(ReadsLocalState)
Int64 b@7 = Const64(10)
Int32 b@8 = AboveEqual(b@18, $10(b@7))
Void b@9 = Branch(b@8, Terminal)
Successors: Then:#3, Else:#2
BB#2: ; frequency = 1.00
Predecessors: #1
Int64 b@10 = Const64(8)
Int64 b@11 = Add(b@19, $8(b@10))
Int64 b@13 = Load(b@11, ControlDependent|Reads:Top)
Int64 b@14 = Add(b@18, b@13)
Void b@22 = Upsilon(b@14, ^18, WritesLocalState)
Void b@23 = Upsilon(b@11, ^19, WritesLocalState)
Void b@16 = Jump(Terminal)
Successors: #1
BB#3: ; frequency = 1.00
Predecessors: #1
Void b@17 = Return(b@18, Terminal)
Variables:
Int64 var0
Int64 var1
--

W/O Pre-Increment Address Mode:
--
...
BB#2: ; frequency = 1.00
Predecessors: #1
Move $8, %x3, $8(b@12)
Add64 $8, %x0, %x1, b@11
Move (%x0,%x3), %x0, b@13
Add64 %x0, %x2, %x2, b@14
Move %x1, %x0, b@23
Jump b@16
Successors: #1
...
--

W/ Pre-Increment Address Mode:
--
...
BB#2: ; frequency = 1.00
Predecessors: #1
MoveWithIncrement64 (%x0,Pre($8)), %x2, b@13
Add64 %x2, %x1, %x1, b@14
Jump b@16
Successors: #1
...
--

Given Loop with Post-Increment:
int64_t ldr_pre(int64_t *p) {
int64_t res = 0;
while (res < 10)
res += *p++;
return

[webkit-changes] [280492] trunk/Source/WebCore

[commit-queue]

Title: [280492] trunk/Source/WebCore








Revision 280492
Author commit-qu...@webkit.org
Date 2021-07-30 13:26:51 -0700 (Fri, 30 Jul 2021)


Log Message
Add key-driven smooth scrolling to macOS
https://bugs.webkit.org/show_bug.cgi?id=228009

Patch by Dana Estra  on 2021-07-30
Reviewed by Tim Horton.

Cause keyboard scroll event to trigger start of smooth scroll animation, using same physics implementation as iOS smooth scrolling.

No tests yet.

* WebCore.xcodeproj/project.pbxproj:
* dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::scrollDistance):
(WebCore::EventHandler::stopKeyboardScrolling):
(WebCore::EventHandler::startKeyboardScrolling):
* platform/KeyboardScrollingAnimator.cpp: Added.
* platform/KeyboardScrollingAnimator.h: Added.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::startAnimationCallback):
* platform/ScrollAnimator.h:
* platform/ScrollController.cpp:
(WebCore::ScrollController::animationCallback):
(WebCore::ScrollController::startOrStopAnimationCallbacks):
(WebCore::ScrollController::beginKeyboardScrolling):
(WebCore::ScrollController::stopKeyboardScrolling):
(WebCore::ScrollController::setIsAnimatingKeyboardScrolling):
(WebCore::ScrollController::updateKeyboardScrollingAnimatingState):
* platform/ScrollController.h:
(WebCore::ScrollControllerClient::updateKeyboardScrollPosition):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/ScrollAnimator.h
trunk/Source/WebCore/platform/ScrollController.cpp
trunk/Source/WebCore/platform/ScrollController.h


Added Paths

trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp
trunk/Source/WebCore/platform/KeyboardScrollingAnimator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (280491 => 280492)

--- trunk/Source/WebCore/ChangeLog	2021-07-30 20:25:46 UTC (rev 280491)
+++ trunk/Source/WebCore/ChangeLog	2021-07-30 20:26:51 UTC (rev 280492)
@@ -1,3 +1,37 @@
+2021-07-30  Dana Estra  
+
+Add key-driven smooth scrolling to macOS
+https://bugs.webkit.org/show_bug.cgi?id=228009
+
+Reviewed by Tim Horton.
+
+Cause keyboard scroll event to trigger start of smooth scroll animation, using same physics implementation as iOS smooth scrolling.
+
+No tests yet.
+
+* WebCore.xcodeproj/project.pbxproj:
+* dom/Node.cpp:
+(WebCore::Node::defaultEventHandler):
+* page/EventHandler.cpp:
+(WebCore::EventHandler::defaultKeyboardEventHandler):
+(WebCore::EventHandler::scrollDistance):
+(WebCore::EventHandler::stopKeyboardScrolling):
+(WebCore::EventHandler::startKeyboardScrolling):
+* platform/KeyboardScrollingAnimator.cpp: Added.
+* platform/KeyboardScrollingAnimator.h: Added.
+* platform/ScrollAnimator.cpp:
+(WebCore::ScrollAnimator::startAnimationCallback):
+* platform/ScrollAnimator.h:
+* platform/ScrollController.cpp:
+(WebCore::ScrollController::animationCallback):
+(WebCore::ScrollController::startOrStopAnimationCallbacks):
+(WebCore::ScrollController::beginKeyboardScrolling):
+(WebCore::ScrollController::stopKeyboardScrolling):
+(WebCore::ScrollController::setIsAnimatingKeyboardScrolling):
+(WebCore::ScrollController::updateKeyboardScrollingAnimatingState):
+* platform/ScrollController.h:
+(WebCore::ScrollControllerClient::updateKeyboardScrollPosition):
+
 2021-07-30  Chris Dumez  
 
 Document's fallback base URL should be deduced from its creator when URL is about:blank


Modified: trunk/Source/WebCore/Sources.txt (280491 => 280492)

--- trunk/Source/WebCore/Sources.txt	2021-07-30 20:25:46 UTC (rev 280491)
+++ trunk/Source/WebCore/Sources.txt	2021-07-30 20:26:51 UTC (rev 280492)
@@ -1745,6 +1745,7 @@
 platform/FileMonitor.cpp
 platform/FileStream.cpp
 platform/FrameRateMonitor.cpp
+platform/KeyboardScrollingAnimator.cpp
 platform/LayoutUnit.cpp
 platform/LegacySchemeRegistry.cpp
 platform/Length.cpp


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (280491 => 280492)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-07-30 20:25:46 UTC (rev 280491)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-07-30 20:26:51 UTC (rev 280492)
@@ -673,6 +673,7 @@
 		1F8756B21E22C3350042C40D /* WebSQLiteDatabaseTrackerClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1F8756B11E22BEEF0042C40D /* WebSQLiteDatabaseTrackerClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		1FAFBF1915A5FA7400083A20 /* UTIUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 1FAFBF1615A5FA5200083A20 /* UTIUti

[webkit-changes] [280491] trunk

[cdumez]

Title: [280491] trunk








Revision 280491
Author cdu...@apple.com
Date 2021-07-30 13:25:46 -0700 (Fri, 30 Jul 2021)


Log Message
Document's fallback base URL should be deduced from its creator when URL is about:blank
https://bugs.webkit.org/show_bug.cgi?id=228624

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that one more check is passing.

* web-platform-tests/html/infrastructure/urls/terminology-0/document-base-url-expected.txt:

Source/WebCore:

Document's fallback base URL should be deduced from its creator when URL is about:blank:
- https://html.spec.whatwg.org/multipage/urls-and-fetching.html#fallback-base-url

Chrome and Firefox match the specification here.

Tests: http/tests/dom/iframe-no-src-local-origin-allow.html
   http/tests/dom/iframe-no-src-set-location.html

* dom/Document.cpp:
(WebCore::Document::updateBaseURL):

LayoutTests:

Update existing tests to reflect behavior change. I have verified that those tests were failing in Firefox & Chrome and
are now passing in those browsers.

* http/tests/dom/iframe-no-src-local-origin-allow-expected.txt: Renamed from LayoutTests/fast/frames/iframe-no-src-local-origin-allow-expected.txt.
* http/tests/dom/iframe-no-src-local-origin-allow.html: Renamed from LayoutTests/fast/frames/iframe-no-src-local-origin-allow.html.
* http/tests/dom/iframe-no-src-set-location-expected.txt: Renamed from LayoutTests/fast/frames/iframe-no-src-set-location-expected.txt.
* http/tests/dom/iframe-no-src-set-location.html: Renamed from LayoutTests/fast/frames/iframe-no-src-set-location.html.
* http/tests/dom/resources/iframe-no-src-set-location-pass.html: Renamed from LayoutTests/fast/frames/resources/iframe-no-src-set-location-pass.html.
* http/tests/security/aboutBlank/security-context-expected.txt:
* http/tests/security/aboutBlank/security-context-grandchildren-expected.txt:
* http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt:
* http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt:
* http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt:
* http/tests/security/aboutBlank/security-context-window-open-expected.txt:
* http/tests/security/aboutBlank/security-context-with-base-tag-expected.txt:
* http/tests/security/aboutBlank/security-context-write-expected.txt:
* http/tests/security/aboutBlank/security-context-writeln-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/open-invalid-url.html
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-expected.txt
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-expected.txt
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-window-open-expected.txt
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-with-base-tag-expected.txt
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-write-expected.txt
trunk/LayoutTests/http/tests/security/aboutBlank/security-context-writeln-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/terminology-0/document-base-url-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp


Added Paths

trunk/LayoutTests/http/tests/dom/iframe-no-src-local-origin-allow-expected.txt
trunk/LayoutTests/http/tests/dom/iframe-no-src-local-origin-allow.html
trunk/LayoutTests/http/tests/dom/iframe-no-src-set-location-expected.txt
trunk/LayoutTests/http/tests/dom/iframe-no-src-set-location.html
trunk/LayoutTests/http/tests/dom/resources/iframe-no-src-set-location-pass.html


Removed Paths

trunk/LayoutTests/fast/frames/iframe-no-src-local-origin-allow-expected.txt
trunk/LayoutTests/fast/frames/iframe-no-src-local-origin-allow.html
trunk/LayoutTests/fast/frames/iframe-no-src-set-location-expected.txt
trunk/LayoutTests/fast/frames/iframe-no-src-set-location.html
trunk/LayoutTests/fast/frames/resources/iframe-no-src-set-location-pass.html




Diff

Modified: trunk/LayoutTests/ChangeLog (280490 => 280491)

--- trunk/LayoutTests/ChangeLog	2021-07-30 19:49:26 UTC (rev 280490)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 20:25:46 UTC (rev 280491)
@@ -1,5 +1,30 @@
 2021-07-30  Chris Dumez  
 
+Document's fallback base URL should be deduced from its creator when URL is about:blank
+https://bugs.webkit.org/show_bug.cgi?id=228624
+
+Reviewed by Geoffrey Garen.
+
+Update existing tests to reflect behavior change. I have verified that those tests were failing in Firefox & Chrome and
+are now passing in those browsers

[webkit-changes] [280490] trunk/Source/WebKit

[timothy_horton]

Title: [280490] trunk/Source/WebKit








Revision 280490
Author timothy_hor...@apple.com
Date 2021-07-30 12:49:26 -0700 (Fri, 30 Jul 2021)


Log Message
Accessibility code logs to stderr in many layout test runs
https://bugs.webkit.org/show_bug.cgi?id=228653

Reviewed by Wenson Hsieh.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):
r279342 accidentally landed a WTFLogAlways in a common codepath. Remove it.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (280489 => 280490)

--- trunk/Source/WebKit/ChangeLog	2021-07-30 18:56:07 UTC (rev 280489)
+++ trunk/Source/WebKit/ChangeLog	2021-07-30 19:49:26 UTC (rev 280490)
@@ -1,3 +1,14 @@
+2021-07-30  Tim Horton  
+
+Accessibility code logs to stderr in many layout test runs
+https://bugs.webkit.org/show_bug.cgi?id=228653
+
+Reviewed by Wenson Hsieh.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::accessibilityPreferencesDidChange):
+r279342 accidentally landed a WTFLogAlways in a common codepath. Remove it.
+
 2021-07-30  Youenn Fablet  
 
 softlink nw_parameters_allow_sharing_port_with_listener


Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (280489 => 280490)

--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2021-07-30 18:56:07 UTC (rev 280489)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2021-07-30 19:49:26 UTC (rev 280490)
@@ -1066,7 +1066,6 @@
 #if HAVE(PER_APP_ACCESSIBILITY_PREFERENCES)
 auto appID = CFSTR("com.apple.WebKit.WebContent");
 auto reduceMotionEnabled = preferences.reduceMotionEnabled;
-WTFLogAlways("AX: reduce motion: %d", (int)reduceMotionEnabled);
 if (_AXSReduceMotionEnabledApp(appID) != reduceMotionEnabled)
 _AXSSetReduceMotionEnabledApp(reduceMotionEnabled, appID);
 auto increaseButtonLegibility = preferences.increaseButtonLegibility;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280489] trunk/Source/JavaScriptCore

[shvaikalesh]

Title: [280489] trunk/Source/_javascript_Core








Revision 280489
Author shvaikal...@gmail.com
Date 2021-07-30 11:56:07 -0700 (Fri, 30 Jul 2021)


Log Message
REGRESSION (r280460): 42 JSC test failures on Debug arm64 with ASSERTION FAILED: !m_needExceptionCheck
https://bugs.webkit.org/show_bug.cgi?id=228652

Unreviewed unchecked exception fix.

Release scope before calling RegExpGlobalData::getBackref().


* runtime/RegExpConstructor.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280488 => 280489)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-30 18:49:47 UTC (rev 280488)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-30 18:56:07 UTC (rev 280489)
@@ -1,3 +1,15 @@
+2021-07-30  Alexey Shvayka  
+
+REGRESSION (r280460): 42 JSC test failures on Debug arm64 with ASSERTION FAILED: !m_needExceptionCheck
+https://bugs.webkit.org/show_bug.cgi?id=228652
+
+Unreviewed unchecked exception fix.
+
+Release scope before calling RegExpGlobalData::getBackref().
+
+* runtime/RegExpConstructor.cpp:
+(JSC::JSC_DEFINE_CUSTOM_GETTER):
+
 2021-07-30  Yusuke Suzuki  
 
 [JSC] Use UCPURegister argument to remove zero extension in JIT code


Modified: trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp (280488 => 280489)

--- trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp	2021-07-30 18:49:47 UTC (rev 280488)
+++ trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp	2021-07-30 18:56:07 UTC (rev 280489)
@@ -100,7 +100,7 @@
 return throwVMTypeError(globalObject, scope, "RegExp.$N getters require RegExp constructor as |this|"_s);
 unsigned N = propertyName.uid()->at(1) - '0';
 ASSERT(N >= 1 && N <= 9);
-return JSValue::encode(globalObject->regExpGlobalData().getBackref(globalObject, N));
+RELEASE_AND_RETURN(scope, JSValue::encode(globalObject->regExpGlobalData().getBackref(globalObject, N)));
 }
 
 JSC_DEFINE_CUSTOM_GETTER(regExpConstructorInput, (JSGlobalObject* globalObject, EncodedJSValue thisValue, PropertyName))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280488] trunk

[jer . noble]

Title: [280488] trunk








Revision 280488
Author jer.no...@apple.com
Date 2021-07-30 11:49:47 -0700 (Fri, 30 Jul 2021)


Log Message
[Cocoa] Remove support for AVAssetImageGenerator
https://bugs.webkit.org/show_bug.cgi?id=228560

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

The 2x2-green.mp4 file fails to decode as its natural size is too small for the system decoder to handle. Replace with
a media file of more reasonable size.

* web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html:
* web-platform-tests/html/semantics/embedded-content/media-elements/video_loop_base.html:
* web-platform-tests/media/16x16-green.mp4: Added.

Source/WebCore:

AVAssetImageGenerator is used when there is not yet an available image from AVPlayerItemVideoOutput.
However, AVAssetImageGenerator is a synchronous API call; if data for the current time is not available,
the generator will cause a request for that data to be issued, and if the main thread is blocked in a
synchronous call to the generator, that request can never be completed, causing a deadlock.

Instead, always block moving to a readyState >= HAVE_CURRENT_DATA until either the AVPlayerLayer or
the AVPlayerItemVideoOutput report having an available frame. This prevents clients from attempting
to paint until a frame is available, and ensures that we will always have an available frame for
painting, removing the need for the synchronous generator call.

To ensure the readyState is updated when AVPlayerItemVideoOutput has an available image, register
with the output at creation time for a notification as soon as an image is available. And in the existing
delegate object, send a message back to the MediaPlayerPrivateAVFoundationObjC when that occurs.

No tests needed; this should reduce flakiness of existing tests and cause no regression in behavior.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
(-[WebCoreAVFPullDelegate setParent:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator): Deleted.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyImageGenerator): Deleted.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator): Deleted.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect): Deleted.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/video_loop_base.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/media/16x16-green.mp4




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (280487 => 280488)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-30 18:25:33 UTC (rev 280487)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-30 18:49:47 UTC (rev 280488)
@@ -1,3 +1,17 @@
+2021-07-30  Jer Noble  
+
+[Cocoa] Remove support for AVAssetImageGenerator
+https://bugs.webkit.org/show_bug.cgi?id=228560
+
+Reviewed by Eric Carlson.
+
+The 2x2-green.mp4 file fails to decode as its natural size is too small for the system decoder to handle. Replace with
+a media file of more reasonable size.
+
+* web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html:
+* web-platform-tests/html/semantics/embedded-content/media-elements/video_loop_base.html:
+* web-platform-tests/media/16x16-green.mp4: Added.
+
 2021-07-30  Chris Dumez  
 
 HTMLElement.innerText setter should convert new lines to 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html (280487 => 280488)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering

[webkit-changes] [280487] tags/Safari-612.1.26/

[repstein]

Title: [280487] tags/Safari-612.1.26/








Revision 280487
Author repst...@apple.com
Date 2021-07-30 11:25:33 -0700 (Fri, 30 Jul 2021)


Log Message
Tag Safari-612.1.26.

Added Paths

tags/Safari-612.1.26/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280486] branches/safari-612.1.26-branch/Source/WebKit

[repstein]

Title: [280486] branches/safari-612.1.26-branch/Source/WebKit








Revision 280486
Author repst...@apple.com
Date 2021-07-30 11:13:48 -0700 (Fri, 30 Jul 2021)


Log Message
Cherry-pick r280433. rdar://problem/81334141

The bundle path of downlevel Safari is wrong
https://bugs.webkit.org/show_bug.cgi?id=228339

Reviewed by Tim Horton.

Use the same approach as `isSystemWebKit` to check whether the WebKit bundle
is from the staged framework.

* Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
(WebKit::isFeatureFlagEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.26-branch/Source/WebKit/ChangeLog
branches/safari-612.1.26-branch/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm




Diff

Modified: branches/safari-612.1.26-branch/Source/WebKit/ChangeLog (280485 => 280486)

--- branches/safari-612.1.26-branch/Source/WebKit/ChangeLog	2021-07-30 18:13:44 UTC (rev 280485)
+++ branches/safari-612.1.26-branch/Source/WebKit/ChangeLog	2021-07-30 18:13:48 UTC (rev 280486)
@@ -1,5 +1,36 @@
 2021-07-30  Russell Epstein  
 
+Cherry-pick r280433. rdar://problem/81334141
+
+The bundle path of downlevel Safari is wrong
+https://bugs.webkit.org/show_bug.cgi?id=228339
+
+Reviewed by Tim Horton.
+
+Use the same approach as `isSystemWebKit` to check whether the WebKit bundle
+is from the staged framework.
+
+* Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
+(WebKit::isFeatureFlagEnabled):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-29  Peng Liu  
+
+The bundle path of downlevel Safari is wrong
+https://bugs.webkit.org/show_bug.cgi?id=228339
+
+Reviewed by Tim Horton.
+
+Use the same approach as `isSystemWebKit` to check whether the WebKit bundle
+is from the staged framework.
+
+* Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
+(WebKit::isFeatureFlagEnabled):
+
+2021-07-30  Russell Epstein  
+
 Cherry-pick r280424. rdar://problem/81334136
 
 [macOS Catalina] Some feature preferences have wrong default values


Modified: branches/safari-612.1.26-branch/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm (280485 => 280486)

--- branches/safari-612.1.26-branch/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm	2021-07-30 18:13:44 UTC (rev 280485)
+++ branches/safari-612.1.26-branch/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm	2021-07-30 18:13:48 UTC (rev 280486)
@@ -40,7 +40,10 @@
 // Because of , WebKit has to parse the feature flags plist file
 bool isFeatureFlagEnabled(const String& featureName)
 {
-BOOL isWebKitBundleFromStagedFramework = [[[NSBundle mainBundle] bundlePath] hasPrefix:@"/Library/Apple/System/Library/StagedFrameworks/Safari"];
+static bool isWebKitBundleFromStagedFramework = [] {
+NSBundle *webkit2Bundle = [NSBundle bundleForClass:NSClassFromString(@"WKWebView")];
+return [webkit2Bundle.bundlePath hasPrefix:@"/Library/Apple/System/Library/StagedFrameworks/Safari/"];
+}();
 
 if (!isWebKitBundleFromStagedFramework)
 return _os_feature_enabled_impl("WebKit", (const char*)featureName.utf8().data());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280485] branches/safari-612.1.26-branch/Source/WebKit

[repstein]

Title: [280485] branches/safari-612.1.26-branch/Source/WebKit








Revision 280485
Author repst...@apple.com
Date 2021-07-30 11:13:44 -0700 (Fri, 30 Jul 2021)


Log Message
Cherry-pick r280424. rdar://problem/81334136

[macOS Catalina] Some feature preferences have wrong default values
https://bugs.webkit.org/show_bug.cgi?id=228564

Reviewed by Tim Horton.

When `HAVE(SYSTEM_FEATURE_FLAGS)` is false, we still need to enable
some features by default.

This patch makes sure the following features are enabled by default
on macOS (consistent with the properties in WebKit-macos.plist):
- async_frame_and_overflow_scrolling
- gpu_process_canvas_rendering
- gpu_process_media
- gpu_process_webrtc
- incremental_pdf
- vp9_decoder
- webm_format_reader
- webm_parser

* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
(WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
(WebKit::defaultUseGPUProcessForMediaEnabled):
(WebKit::defaultCaptureAudioInGPUProcessEnabled):
(WebKit::defaultCaptureVideoInGPUProcessEnabled):
(WebKit::defaultWebRTCCodecsInGPUProcess):
(WebKit::defaultIncrementalPDFEnabled):
(WebKit::defaultWebMFormatReaderEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.26-branch/Source/WebKit/ChangeLog
branches/safari-612.1.26-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp




Diff

Modified: branches/safari-612.1.26-branch/Source/WebKit/ChangeLog (280484 => 280485)

--- branches/safari-612.1.26-branch/Source/WebKit/ChangeLog	2021-07-30 18:08:21 UTC (rev 280484)
+++ branches/safari-612.1.26-branch/Source/WebKit/ChangeLog	2021-07-30 18:13:44 UTC (rev 280485)
@@ -1,3 +1,70 @@
+2021-07-30  Russell Epstein  
+
+Cherry-pick r280424. rdar://problem/81334136
+
+[macOS Catalina] Some feature preferences have wrong default values
+https://bugs.webkit.org/show_bug.cgi?id=228564
+
+Reviewed by Tim Horton.
+
+When `HAVE(SYSTEM_FEATURE_FLAGS)` is false, we still need to enable
+some features by default.
+
+This patch makes sure the following features are enabled by default
+on macOS (consistent with the properties in WebKit-macos.plist):
+- async_frame_and_overflow_scrolling
+- gpu_process_canvas_rendering
+- gpu_process_media
+- gpu_process_webrtc
+- incremental_pdf
+- vp9_decoder
+- webm_format_reader
+- webm_parser
+
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
+(WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
+(WebKit::defaultUseGPUProcessForMediaEnabled):
+(WebKit::defaultCaptureAudioInGPUProcessEnabled):
+(WebKit::defaultCaptureVideoInGPUProcessEnabled):
+(WebKit::defaultWebRTCCodecsInGPUProcess):
+(WebKit::defaultIncrementalPDFEnabled):
+(WebKit::defaultWebMFormatReaderEnabled):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-29  Peng Liu  
+
+[macOS Catalina] Some feature preferences have wrong default values
+https://bugs.webkit.org/show_bug.cgi?id=228564
+
+Reviewed by Tim Horton.
+
+When `HAVE(SYSTEM_FEATURE_FLAGS)` is false, we still need to enable
+some features by default.
+
+This patch makes sure the following features are enabled by default
+on macOS (consistent with the properties in WebKit-macos.plist):
+- async_frame_and_overflow_scrolling
+- gpu_process_canvas_rendering
+- gpu_process_media
+- gpu_process_webrtc
+- incremental_pdf
+- vp9_decoder
+- webm_format_reader
+- webm_parser
+
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
+(WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
+(WebKit::defaultUseGPUProcessForMediaEnabled):
+(WebKit::defaultCaptureAudioInGPUProcessEnabled):
+(WebKit::defaultCaptureVideoInGPUProcessEnabled):
+(WebKit::defaultWebRTCCodecsInGPUProcess):
+(WebKit::defaultIncrementalPDFEnabled):
+(WebKit::defaultWebMFormatReaderEnabled):
+
 2021-07-28  Jean-Yves Avenard  
 
 [WebAudio] Add webm/opus container support


Modified: branches/safari-612.1.26-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (280484 => 280485)

--- branches/safari-612.1.26-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-07-30 18:08:21 UTC (rev 280484)
+++ branches/safari-612.1.26-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-07-30 18:13:44 UTC (rev 280485)
@@ -149,29 +149,41 @@
 
 bool defaultUse

[webkit-changes] [280484] trunk/Source/WebKit

[youenn]

Title: [280484] trunk/Source/WebKit








Revision 280484
Author you...@apple.com
Date 2021-07-30 11:08:21 -0700 (Fri, 30 Jul 2021)


Log Message
softlink nw_parameters_allow_sharing_port_with_listener
https://bugs.webkit.org/show_bug.cgi?id=228636

Reviewed by Eric Carlson.

* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
(WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection):
This helps compiling/running WebKit on older OSes.
Also make use of nw_endpoint_create_host_with_numeric_port to remove the need for string to int conversion.
* Platform/spi/Cocoa/NWParametersSPI.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm
trunk/Source/WebKit/Platform/spi/Cocoa/NWParametersSPI.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (280483 => 280484)

--- trunk/Source/WebKit/ChangeLog	2021-07-30 17:46:35 UTC (rev 280483)
+++ trunk/Source/WebKit/ChangeLog	2021-07-30 18:08:21 UTC (rev 280484)
@@ -1,5 +1,18 @@
 2021-07-30  Youenn Fablet  
 
+softlink nw_parameters_allow_sharing_port_with_listener
+https://bugs.webkit.org/show_bug.cgi?id=228636
+
+Reviewed by Eric Carlson.
+
+* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
+(WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection):
+This helps compiling/running WebKit on older OSes.
+Also make use of nw_endpoint_create_host_with_numeric_port to remove the need for string to int conversion.
+* Platform/spi/Cocoa/NWParametersSPI.h:
+
+2021-07-30  Youenn Fablet  
+
 Attribute nw connections to the source application
 https://bugs.webkit.org/show_bug.cgi?id=228641
 


Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm (280483 => 280484)

--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm	2021-07-30 17:46:35 UTC (rev 280483)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm	2021-07-30 18:08:21 UTC (rev 280484)
@@ -45,6 +45,9 @@
 SOFT_LINK_CLASS(libnetworkextension, NEHelperTrackerAppInfoRef)
 SOFT_LINK_CLASS(libnetworkextension, NEHelperTrackerDomainContextRef)
 SOFT_LINK(libnetworkextension, NEHelperTrackerGetDisposition, NEHelperTrackerDisposition_t*, (NEHelperTrackerAppInfoRef *app_info_ref, CFArrayRef domains, NEHelperTrackerDomainContextRef *trackerDomainContextRef, CFIndex *trackerDomainIndex), (app_info_ref, domains, trackerDomainContextRef, trackerDomainIndex))
+
+SOFT_LINK_LIBRARY_OPTIONAL(libnetwork)
+SOFT_LINK_OPTIONAL(libnetwork, nw_parameters_allow_sharing_port_with_listener, void, __cdecl, (nw_parameters_t, nw_listener_t))
 #endif
 
 namespace WebKit {
@@ -169,7 +172,7 @@
 auto hostAddress = address.ipaddr().ToString();
 if (address.ipaddr().IsNil())
 hostAddress = address.hostname();
-auto localEndpoint = adoptNS(nw_endpoint_create_host(hostAddress.c_str(), "0"));
+auto localEndpoint = adoptNS(nw_endpoint_create_host_with_numeric_port(hostAddress.c_str(), 0));
 m_address = { nw_endpoint_get_hostname(localEndpoint.get()), nw_endpoint_get_port(localEndpoint.get()) };
 nw_parameters_set_local_endpoint(parameters.get(), localEndpoint.get());
 }
@@ -288,15 +291,16 @@
 auto hostAddress = m_address.ipaddr().ToString();
 if (m_address.ipaddr().IsNil())
 hostAddress = m_address.hostname();
-#if defined(NW_HAS_SHARE_LISTENER_PORT) && NW_HAS_SHARE_LISTENER_PORT
-nw_parameters_allow_sharing_port_with_listener(parameters.get(), m_nwListener.get());
-auto portString = String::number(m_address.port());
-auto portValue = portString.utf8().data();
-#else
-// rdar://80176676: we workaround local loop port reuse by using 0 instead of m_address.port().
-auto portValue = "0";
+
+// rdar://80176676: we workaround local loop port reuse by using 0 instead of m_address.port() when nw_parameters_allow_sharing_port_with_listener is not available.
+uint16_t port = 0;
+#if HAVE(NWPARAMETERS_TRACKER_API)
+if (nw_parameters_allow_sharing_port_with_listenerPtr()) {
+nw_parameters_allow_sharing_port_with_listenerPtr()(parameters.get(), m_nwListener.get());
+port = m_address.port();
+}
 #endif
-auto localEndpoint = adoptNS(nw_endpoint_create_host(hostAddress.c_str(), portValue));
+auto localEndpoint = adoptNS(nw_endpoint_create_host_with_numeric_port(hostAddress.c_str(), port));
 nw_parameters_set_local_endpoint(parameters.get(), localEndpoint.get());
 }
 configureParameters(parameters.get(), remoteAddress.family() == AF_INET ? nw_ip_version_4 : nw_ip_version_6);


Modified: trunk/Source/WebKit/Platform/spi/Cocoa/NWParametersSPI.h (280483 => 280484)

--- trunk/Source/WebKit/Platform/spi/Cocoa/NWParametersSPI.h	2021-07-30 17:46:35 UTC (rev 280483)
+++ trunk/Source/WebKit/Platform/spi/Cocoa/NWParametersSPI.h	2021-07-3

[webkit-changes] [280483] trunk/Tools

[jbedard]

Title: [280483] trunk/Tools








Revision 280483
Author jbed...@apple.com
Date 2021-07-30 10:46:35 -0700 (Fri, 30 Jul 2021)


Log Message
[git-webkit] Forward errors from log and blame
https://bugs.webkit.org/show_bug.cgi?id=228621


Rubber-stamped by Aakash Jain.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
(FilteredCommand.main): If the exit code is non-zero, print all errors.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py




Diff

Modified: trunk/Tools/ChangeLog (280482 => 280483)

--- trunk/Tools/ChangeLog	2021-07-30 17:46:30 UTC (rev 280482)
+++ trunk/Tools/ChangeLog	2021-07-30 17:46:35 UTC (rev 280483)
@@ -1,5 +1,18 @@
 2021-07-30  Jonathan Bedard  
 
+[git-webkit] Forward errors from log and blame
+https://bugs.webkit.org/show_bug.cgi?id=228621
+
+
+Rubber-stamped by Aakash Jain.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
+(FilteredCommand.main): If the exit code is non-zero, print all errors.
+
+2021-07-30  Jonathan Bedard  
+
 [git-webkit] Not all platforms support more -F
 https://bugs.webkit.org/show_bug.cgi?id=228619
 


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (280482 => 280483)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-07-30 17:46:30 UTC (rev 280482)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-07-30 17:46:35 UTC (rev 280483)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='1.0.3',
+version='1.0.4',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (280482 => 280483)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-07-30 17:46:30 UTC (rev 280482)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-07-30 17:46:35 UTC (rev 280483)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(1, 0, 3)
+version = Version(1, 0, 4)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('monotonic', Version(1, 5)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py (280482 => 280483)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py	2021-07-30 17:46:30 UTC (rev 280482)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py	2021-07-30 17:46:35 UTC (rev 280483)
@@ -256,5 +256,7 @@
 line = log_output.stdout.readline()
 
 finally:
+if not log_output.returncode:
+sys.stderr.write(log_output.stderr.read())
 log_output.kill()
 return log_output.returncode






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280482] trunk

[cdumez]

Title: [280482] trunk








Revision 280482
Author cdu...@apple.com
Date 2021-07-30 10:46:30 -0700 (Fri, 30 Jul 2021)


Log Message
HTMLElement.innerText setter should convert new lines to 
https://bugs.webkit.org/show_bug.cgi?id=228605

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaselined WPT tests that are now passing. Note that those were failing in WebKit but passing in Firefox
and Chrome.

* web-platform-tests/html/dom/elements/the-innertext-and-outertext-properties/innertext-setter-expected.txt:
* web-platform-tests/html/dom/elements/the-innertext-idl-attribute/setter-expected.txt:
* web-platform-tests/innerText/setter-expected.txt:

Source/WebCore:

HTMLElement.innerText setter should convert new lines to :
- https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute:dom-innertext-3
- https://html.spec.whatwg.org/multipage/dom.html#rendered-text-fragment

Our innerText setter had some logic that was specific to form elements and specific render
styles that wasn't part of the specification. It was causing us to not replace the new lines
with  in some cases. I dropped this logic to align with Blink and Gecko, as those are
passing the same WPT tests.

No new tests, rebaselined existing tests.

* html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerText):

LayoutTests:

Rebaseline a few tests that changed output.

* editing/pasteboard/smart-paste-paragraph-003-expected.txt:
* platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:
* platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
* platform/mac/fast/forms/textarea-scroll-height-expected.txt:
* platform/mac/fast/forms/textarea-scrollbar-expected.txt:
* platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
* platform/mac/fast/forms/textarea-width-expected.txt:
* platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
* platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
* platform/mac/http/tests/navigation/_javascript_link-frames-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/mac/pseudo-element-text-markers-expected.txt
trunk/LayoutTests/editing/pasteboard/smart-paste-paragraph-003-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-and-outertext-properties/innertext-setter-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-idl-attribute/setter-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/innerText/setter-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/textarea-scrollbar-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/textarea-scrolled-type-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/textarea-width-expected.txt
trunk/LayoutTests/platform/ios-wk2/editing/input/reveal-caret-of-multiline-input-expected.txt
trunk/LayoutTests/platform/ios-wk2/fast/forms/textarea-scroll-height-expected.txt
trunk/LayoutTests/platform/ios-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt
trunk/LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-scroll-height-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-scrollbar-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-width-expected.txt
trunk/LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt
trunk/LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt
trunk/LayoutTests/platform/mac/http/tests/navigation/_javascript_link-frames-expected.txt
trunk/LayoutTests/platform/mac-catalina/editing/input/reveal-caret-of-multiline-input-expected.txt
trunk/LayoutTests/platform/mac-catalina/fast/forms/basic-textareas-quirks-expected.txt
trunk/LayoutTests/platform/mac-catalina/fast/parser/open-comment-in-textarea-expected.txt
trunk/LayoutTests/platform/mac-catalina/http/tests/navigation/_javascript_link-frames-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLElement.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (280481 => 280482)

--- trunk/LayoutTests/ChangeLog	2021-07-30 17:30:58 UTC (rev 280481)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 17:46:30 UTC (rev 280482)
@@ -1,3 +1,23 @@
+2021-07-30  Chris Dumez  
+
+HTMLElement.innerText setter should convert new lines to 
+https://bugs.webkit.org/show_bug.cgi?id=228605
+
+Reviewed by Sam Weinig.
+
+Rebaseline a few tests that changed output.
+
+* editing/pasteboard/smart-paste-paragraph-003-expected.txt:
+* platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:
+* platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
+ 

[webkit-changes] [280481] trunk/Source/WebKit

[youenn]

Title: [280481] trunk/Source/WebKit








Revision 280481
Author you...@apple.com
Date 2021-07-30 10:30:58 -0700 (Fri, 30 Jul 2021)


Log Message
Attribute nw connections to the source application
https://bugs.webkit.org/show_bug.cgi?id=228641


Reviewed by Alex Christensen.

Add source application token for every nw connection/listener, like done for WebSocket or NSURLSession tasks.
This will allow the nw layer to do custom processing based on the application doing the loads.
Introduce an audit_token_t getter on NetworkProcess.

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::sourceApplicationAuditData const):
(WebKit::NetworkProcess::sourceApplicationAuditToken const):
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::NetworkRTCProvider):
* NetworkProcess/webrtc/NetworkRTCProvider.h:
(WebKit::NetworkRTCProvider::sourceApplicationAuditToken const):
* NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:
(WebKit::NetworkRTCTCPSocketCocoa::NetworkRTCTCPSocketCocoa):
* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
(WebKit::NetworkRTCUDPSocketCocoaConnections::NetworkRTCUDPSocketCocoaConnections):
(WebKit::NetworkRTCUDPSocketCocoaConnections::configureParameters):
* Platform/spi/Cocoa/NWParametersSPI.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm
trunk/Source/WebKit/Platform/spi/Cocoa/NWParametersSPI.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (280480 => 280481)

--- trunk/Source/WebKit/ChangeLog	2021-07-30 17:02:17 UTC (rev 280480)
+++ trunk/Source/WebKit/ChangeLog	2021-07-30 17:30:58 UTC (rev 280481)
@@ -1,3 +1,29 @@
+2021-07-30  Youenn Fablet  
+
+Attribute nw connections to the source application
+https://bugs.webkit.org/show_bug.cgi?id=228641
+
+
+Reviewed by Alex Christensen.
+
+Add source application token for every nw connection/listener, like done for WebSocket or NSURLSession tasks.
+This will allow the nw layer to do custom processing based on the application doing the loads.
+Introduce an audit_token_t getter on NetworkProcess.
+
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::NetworkProcess::sourceApplicationAuditData const):
+(WebKit::NetworkProcess::sourceApplicationAuditToken const):
+* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
+(WebKit::NetworkRTCProvider::NetworkRTCProvider):
+* NetworkProcess/webrtc/NetworkRTCProvider.h:
+(WebKit::NetworkRTCProvider::sourceApplicationAuditToken const):
+* NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:
+(WebKit::NetworkRTCTCPSocketCocoa::NetworkRTCTCPSocketCocoa):
+* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
+(WebKit::NetworkRTCUDPSocketCocoaConnections::NetworkRTCUDPSocketCocoaConnections):
+(WebKit::NetworkRTCUDPSocketCocoaConnections::configureParameters):
+* Platform/spi/Cocoa/NWParametersSPI.h:
+
 2021-07-29  Myles C. Maxfield  
 
 Stop building WebGPU and the WHLSL compiler to decrease binary size


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (280480 => 280481)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h	2021-07-30 17:02:17 UTC (rev 280480)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h	2021-07-30 17:30:58 UTC (rev 280481)
@@ -197,6 +197,7 @@
 
 #if PLATFORM(COCOA)
 RetainPtr sourceApplicationAuditData() const;
+std::optional sourceApplicationAuditToken() const;
 #endif
 #if PLATFORM(COCOA) || USE(SOUP)
 HashSet hostNamesWithHSTSCache(PAL::SessionID) const;


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (280480 => 280481)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm	2021-07-30 17:02:17 UTC (rev 280480)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm	2021-07-30 17:30:58 UTC (rev 280481)
@@ -109,15 +109,22 @@
 RetainPtr NetworkProcess::sourceApplicationAuditData() const
 {
 #if USE(SOURCE_APPLICATION_AUDIT_DATA)
+if (auto auditToken = sourceApplicationAuditToken())
+return adoptCF(CFDataCreate(nullptr, (const UInt8*)&*auditToken, sizeof(*auditToken)));
+#endif
+
+return nullptr;
+}
+
+std::optional NetworkProcess::sourceApplicationAuditToken() const
+{
+#if USE(SOURCE_APPLICATION_AUDIT_DATA)
 ASSERT(parentProcessConnection());
 if (!parentProcessConnection())
-return nullptr;
-std::optional auditToken = parentProcessConnection()->getAuditToken();
-if (!auditToken)
-return nullptr;
-return adoptCF(CFDataCreate(nullptr, (const UInt8*)&*auditToken, si

[webkit-changes] [280480] trunk/LayoutTests

[sihui_liu]

Title: [280480] trunk/LayoutTests








Revision 280480
Author sihui_...@apple.com
Date 2021-07-30 10:02:17 -0700 (Fri, 30 Jul 2021)


Log Message
Layout Test imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html is a Flaky Failure
https://bugs.webkit.org/show_bug.cgi?id=201481


Reviewed by Youenn Fablet.

The test always passes now according to recent results, but it is shown as failed as TEXT because of the
expectation.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280479 => 280480)

--- trunk/LayoutTests/ChangeLog	2021-07-30 16:41:37 UTC (rev 280479)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 17:02:17 UTC (rev 280480)
@@ -1,3 +1,16 @@
+2021-07-30  Sihui Liu  
+
+Layout Test imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html is a Flaky Failure
+https://bugs.webkit.org/show_bug.cgi?id=201481
+
+
+Reviewed by Youenn Fablet.
+
+The test always passes now according to recent results, but it is shown as failed as TEXT because of the
+expectation.
+
+* platform/mac/TestExpectations:
+
 2021-07-30  Chris Dumez  
 
 Clicking an HTMLLinkElement should not trigger a navigation


Modified: trunk/LayoutTests/platform/mac/TestExpectations (280479 => 280480)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-07-30 16:41:37 UTC (rev 280479)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-07-30 17:02:17 UTC (rev 280480)
@@ -1602,8 +1602,6 @@
 
 webkit.org/b/205729 webrtc/captureCanvas-webrtc.html [ Pass Failure ]
 
-webkit.org/b/201481 imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html [ Pass Failure ]
-
 webkit.org/b/206604 animations/animation-welcome-safari.html [ Pass Failure ]
 
 webkit.org/b/207062 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280479] trunk

[cdumez]

Title: [280479] trunk








Revision 280479
Author cdu...@apple.com
Date 2021-07-30 09:41:37 -0700 (Fri, 30 Jul 2021)


Log Message
Clicking an HTMLLinkElement should not trigger a navigation
https://bugs.webkit.org/show_bug.cgi?id=228618

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

* web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub-expected.txt:

Source/WebCore:

Clicking an HTMLLinkElement should not trigger a navigation because HTMLLinkElement has no activation
behavior as per the HTML specification:
- https://html.spec.whatwg.org/multipage/semantics.html#htmllinkelement

Firefox and Chrome follow the specification here.

No new tests, updated/rebaselined existing tests.

* html/HTMLLinkElement.cpp:
* html/HTMLLinkElement.h:

LayoutTests:

Update existing tests to reflect behavior change. I verified that the tests were failing
in both Firefox and Chrome prior to me updating them.

* fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt:
* fast/dom/html-link-element-activation-behavior-on-element-click.html:
* fast/dom/html-link-element-activation-behavior-on-mouse-click-expected.txt:
* fast/dom/html-link-element-activation-behavior-on-mouse-click.html:
* fast/dom/resources/html-link-element-activation-behavior-on-element-click-step1.html:
* fast/dom/resources/html-link-element-activation-behavior-on-mouse-click-step1.html:
* fast/dom/resources/html-link-element-activation-behavior-target.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt
trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click.html
trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-mouse-click-expected.txt
trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-mouse-click.html
trunk/LayoutTests/fast/dom/resources/html-link-element-activation-behavior-on-element-click-step1.html
trunk/LayoutTests/fast/dom/resources/html-link-element-activation-behavior-on-mouse-click-step1.html
trunk/LayoutTests/fast/dom/resources/html-link-element-activation-behavior-target.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLLinkElement.cpp
trunk/Source/WebCore/html/HTMLLinkElement.h




Diff

Modified: trunk/LayoutTests/ChangeLog (280478 => 280479)

--- trunk/LayoutTests/ChangeLog	2021-07-30 16:35:11 UTC (rev 280478)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 16:41:37 UTC (rev 280479)
@@ -1,3 +1,21 @@
+2021-07-30  Chris Dumez  
+
+Clicking an HTMLLinkElement should not trigger a navigation
+https://bugs.webkit.org/show_bug.cgi?id=228618
+
+Reviewed by Sam Weinig.
+
+Update existing tests to reflect behavior change. I verified that the tests were failing
+in both Firefox and Chrome prior to me updating them.
+
+* fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt:
+* fast/dom/html-link-element-activation-behavior-on-element-click.html:
+* fast/dom/html-link-element-activation-behavior-on-mouse-click-expected.txt:
+* fast/dom/html-link-element-activation-behavior-on-mouse-click.html:
+* fast/dom/resources/html-link-element-activation-behavior-on-element-click-step1.html:
+* fast/dom/resources/html-link-element-activation-behavior-on-mouse-click-step1.html:
+* fast/dom/resources/html-link-element-activation-behavior-target.html:
+
 2021-07-30  Dean Jackson  
 
 [Media Controls] Add an option for having no scrubber on the time control and parameterize margin


Modified: trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt (280478 => 280479)

--- trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt	2021-07-30 16:35:11 UTC (rev 280478)
+++ trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt	2021-07-30 16:41:37 UTC (rev 280479)
@@ -1,4 +1,4 @@
-This tests html link element activation behavior on DOM click
+This tests that html link element has no activation behavior on DOM click.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 


Modified: trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click.html (280478 => 280479)

--- trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click.html	2021-07-30 16:35:11 UTC (rev 280478)
+++ trunk/LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click.html	2021-07-30 16:41:37 UTC (rev 280479)
@@ -7,7 +7,7 @@
 
  
-description("This tests html link element activation behavior on DOM click");

[webkit-changes] [280478] trunk/Tools

[jbedard]

Title: [280478] trunk/Tools








Revision 280478
Author jbed...@apple.com
Date 2021-07-30 09:35:11 -0700 (Fri, 30 Jul 2021)


Log Message
[git-webkit] Not all platforms support more -F
https://bugs.webkit.org/show_bug.cgi?id=228619


Reviewed by Aakash Jain.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
(FilteredCommand.pager): Only pass -F to more on Darwin.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py




Diff

Modified: trunk/Tools/ChangeLog (280477 => 280478)

--- trunk/Tools/ChangeLog	2021-07-30 16:21:43 UTC (rev 280477)
+++ trunk/Tools/ChangeLog	2021-07-30 16:35:11 UTC (rev 280478)
@@ -1,3 +1,16 @@
+2021-07-30  Jonathan Bedard  
+
+[git-webkit] Not all platforms support more -F
+https://bugs.webkit.org/show_bug.cgi?id=228619
+
+
+Reviewed by Aakash Jain.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
+(FilteredCommand.pager): Only pass -F to more on Darwin.
+
 2021-07-29  Carlos Alberto Lopez Perez  
 
 [WPE][GTK] build broken with python2 after r280382


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (280477 => 280478)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-07-30 16:21:43 UTC (rev 280477)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-07-30 16:35:11 UTC (rev 280478)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='1.0.2',
+version='1.0.3',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (280477 => 280478)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-07-30 16:21:43 UTC (rev 280477)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-07-30 16:35:11 UTC (rev 280478)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(1, 0, 2)
+version = Version(1, 0, 3)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('monotonic', Version(1, 5)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py (280477 => 280478)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py	2021-07-30 16:21:43 UTC (rev 280477)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py	2021-07-30 16:35:11 UTC (rev 280478)
@@ -21,6 +21,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import os
+import platform
 import re
 import subprocess
 import sys
@@ -120,7 +121,7 @@
 stdout=subprocess.PIPE,
 stderr=subprocess.PIPE,
 )
-more = subprocess.Popen([which('more'), '-F'], stdin=child.stdout)
+more = subprocess.Popen([which('more')] + ['-F'] if platform.system() == 'Darwin' else [], stdin=child.stdout)
 
 try:
 while more.poll() is None and not child.poll():






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280477] trunk

[dino]

Title: [280477] trunk








Revision 280477
Author d...@apple.com
Date 2021-07-30 09:21:43 -0700 (Fri, 30 Jul 2021)


Log Message
[Media Controls] Add an option for having no scrubber on the time control and parameterize margin
https://bugs.webkit.org/show_bug.cgi?id=228633
rdar://81314458

Reviewed by Tim Horton.

Source/WebCore:

Add support for a scrubber bar that does not have a knob (or, to be clear, an
invisible knob). While here, move the constant for the margin into a custom
CSS property so it can be easily overridden.

* Modules/modern-media-controls/controls/media-controls.css:
(*): Add --scrubber-margin custom property.
* Modules/modern-media-controls/controls/slider.css:
(.slider > .custom-slider > .knob.none): Add style for a "none" knob.
* Modules/modern-media-controls/controls/slider.js:
(Slider.prototype.commit): Support "none".
* Modules/modern-media-controls/controls/time-control.js: Get the margin from
the new custom property.
(TimeControl.prototype.get minimumWidth):
(TimeControl.prototype.get idealMinimumWidth):
(TimeControl.prototype.layout):
(TimeControl.prototype._performIdealLayout):

LayoutTests:

Make sure the TimeControls element is in the document so its computed style
can be read.

* media/modern-media-controls/time-control/time-control.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/time-control/time-control.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css
trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.css
trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js
trunk/Source/WebCore/Modules/modern-media-controls/controls/time-control.js




Diff

Modified: trunk/LayoutTests/ChangeLog (280476 => 280477)

--- trunk/LayoutTests/ChangeLog	2021-07-30 15:47:54 UTC (rev 280476)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 16:21:43 UTC (rev 280477)
@@ -1,3 +1,16 @@
+2021-07-30  Dean Jackson  
+
+[Media Controls] Add an option for having no scrubber on the time control and parameterize margin
+https://bugs.webkit.org/show_bug.cgi?id=228633
+rdar://81314458
+
+Reviewed by Tim Horton.
+
+Make sure the TimeControls element is in the document so its computed style
+can be read.
+
+* media/modern-media-controls/time-control/time-control.html:
+
 2021-07-30  Eric Hutchison  
 
 [ BigSur Release wk2 arm64] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-unsafe-none-to-same-origin.https.html.


Modified: trunk/LayoutTests/media/modern-media-controls/time-control/time-control.html (280476 => 280477)

--- trunk/LayoutTests/media/modern-media-controls/time-control/time-control.html	2021-07-30 15:47:54 UTC (rev 280476)
+++ trunk/LayoutTests/media/modern-media-controls/time-control/time-control.html	2021-07-30 16:21:43 UTC (rev 280477)
@@ -6,6 +6,7 @@
 description("Testing the TimeControl class.");
 
 const timeControl = new TimeControl({ layoutTraits: new MacOSLayoutTraits(LayoutTraits.Mode.Inline) });
+document.body.appendChild(timeControl.element);
 
 shouldBeEqualToString("timeControl.element.localName", "div");
 shouldBeEqualToString("timeControl.element.className", "time-control");
@@ -87,6 +88,8 @@
 
 debug("");
 
+timeControl.element.remove();
+
 
 

[webkit-changes] [280476] trunk

[cdumez]

Title: [280476] trunk








Revision 280476
Author cdu...@apple.com
Date 2021-07-30 08:47:54 -0700 (Fri, 30 Jul 2021)


Log Message
postMessage() should throw if any duplicate transferable is found in transferList
https://bugs.webkit.org/show_bug.cgi?id=228608

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

* web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt:

Source/WebCore:

postMessage() should throw if any duplicate transferable is found in transferList:
- https://html.spec.whatwg.org/multipage/structured-data.html#structuredserializewithtransfer (Step 2.3)

No new tests, rebaselined existing test.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):

Modified Paths

trunk/LayoutTests/fast/canvas/webgl/arraybuffer-transfer-of-control.html
trunk/LayoutTests/fast/events/message-port-multi-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp




Diff

Modified: trunk/LayoutTests/fast/canvas/webgl/arraybuffer-transfer-of-control.html (280475 => 280476)

--- trunk/LayoutTests/fast/canvas/webgl/arraybuffer-transfer-of-control.html	2021-07-30 15:25:52 UTC (rev 280475)
+++ trunk/LayoutTests/fast/canvas/webgl/arraybuffer-transfer-of-control.html	2021-07-30 15:47:54 UTC (rev 280476)
@@ -333,17 +333,8 @@
 name: "transfer list multiple",
 send: function(name) {
 var buffer = createBuffer(arraySize);
-wrapSend(name, { buffer : buffer }, [buffer,buffer]);
-assertBufferClosed(name, buffer);
-wrapFailSend(name, [buffer], [buffer]);
-wrapFailSend(name, [], [buffer]);
-var buffer2 = createBuffer(arraySize);
-wrapFailSend(name, [], [buffer2, buffer]);
-checkBuffer(name, buffer2, arraySize);
-wrapFailSend(name, [], [buffer, buffer2]);
-checkBuffer(name, buffer2, arraySize);
-wrapFailSend(name, [buffer2], [buffer2, buffer]);
-checkBuffer(name, buffer2, arraySize);
+wrapFailSend(name, { buffer : buffer }, [buffer,buffer]);
+wrapSend(name, { buffer : buffer }, [buffer]);
 },
 test: function (name, e) {
 return checkBuffer(name, e.data.buffer, arraySize);


Modified: trunk/LayoutTests/fast/events/message-port-multi-expected.txt (280475 => 280476)

--- trunk/LayoutTests/fast/events/message-port-multi-expected.txt	2021-07-30 15:25:52 UTC (rev 280475)
+++ trunk/LayoutTests/fast/events/message-port-multi-expected.txt	2021-07-30 15:47:54 UTC (rev 280476)
@@ -7,7 +7,7 @@
 PASS channel.port1.postMessage("entangled port", [channel.port2]) threw exception DataCloneError: The object can not be cloned..
 PASS channel.port1.postMessage("null port", [channel3.port1, null, channel3.port2]) threw exception TypeError: Type error.
 PASS channel.port1.postMessage("notAPort", [channel3.port1, {}, channel3.port2]) threw exception DataCloneError: The object can not be cloned..
-PASS channel.port1.postMessage("duplicate port", [channel3.port1, channel3.port1]) threw exception DataCloneError: The object can not be cloned..
+PASS channel.port1.postMessage("duplicate port", [channel3.port1, channel3.port1]) threw exception DataCloneError: Duplicate transferable for structured clone.
 PASS channel.port1.postMessage("notAnArray", "foo") threw exception TypeError: Type error.
 PASS channel.port1.postMessage("notASequence", [{length: 3}]) threw exception DataCloneError: The object can not be cloned..
 PASS channel.port1.postMessage("largeSequence", largePortArray) threw exception TypeError: Type error.


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (280475 => 280476)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-30 15:25:52 UTC (rev 280475)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-30 15:47:54 UTC (rev 280476)
@@ -1,3 +1,14 @@
+2021-07-30  Chris Dumez  
+
+postMessage() should throw if any duplicate transferable is found in transferList
+https://bugs.webkit.org/show_bug.cgi?id=228608
+
+Reviewed by Youenn Fablet.
+
+Rebaseline WPT test now that more checks are passing.
+
+* web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt:
+
 2021-07-28  Sihui Liu  
 
 Implement IDBTransaction.durability


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt (280475 => 280476)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt	2021-07-30 15:25:52 UTC (rev 280475)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of

[webkit-changes] [280475] trunk/LayoutTests

[ehutchison]

Title: [280475] trunk/LayoutTests








Revision 280475
Author ehutchi...@apple.com
Date 2021-07-30 08:25:52 -0700 (Fri, 30 Jul 2021)


Log Message
[ BigSur Release wk2 arm64] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-unsafe-none-to-same-origin.https.html.
https://bugs.webkit.org/show_bug.cgi?id=228644.

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280474 => 280475)

--- trunk/LayoutTests/ChangeLog	2021-07-30 15:02:27 UTC (rev 280474)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 15:25:52 UTC (rev 280475)
@@ -1,5 +1,14 @@
 2021-07-30  Eric Hutchison  
 
+[ BigSur Release wk2 arm64] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-unsafe-none-to-same-origin.https.html.
+https://bugs.webkit.org/show_bug.cgi?id=228644.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2021-07-30  Eric Hutchison  
+
 Updated test expectations for imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html.
 https://bugs.webkit.org/show_bug.cgi?id=228197.
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280474 => 280475)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-30 15:02:27 UTC (rev 280474)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-30 15:25:52 UTC (rev 280475)
@@ -1536,6 +1536,8 @@
 
 webkit.org/b/228591 fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html [ Pass Failure ]
 
+webkit.org/b/228644 [ BigSur Release arm64 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-unsafe-none-to-same-origin.https.html [ Pass Failure ]
+
 # webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
 [ Monterey ] imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280474] trunk/LayoutTests

[ehutchison]

Title: [280474] trunk/LayoutTests








Revision 280474
Author ehutchi...@apple.com
Date 2021-07-30 08:02:27 -0700 (Fri, 30 Jul 2021)


Log Message
Updated test expectations for imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html.
https://bugs.webkit.org/show_bug.cgi?id=228197.

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280473 => 280474)

--- trunk/LayoutTests/ChangeLog	2021-07-30 14:52:43 UTC (rev 280473)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 15:02:27 UTC (rev 280474)
@@ -1,5 +1,15 @@
 2021-07-30  Eric Hutchison  
 
+Updated test expectations for imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html.
+https://bugs.webkit.org/show_bug.cgi?id=228197.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
+2021-07-30  Eric Hutchison  
+
 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-unsafe-none.https.html is a flaky failure .
 https://bugs.webkit.org/show_bug.cgi?id=228642.
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (280473 => 280474)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-07-30 14:52:43 UTC (rev 280473)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-07-30 15:02:27 UTC (rev 280474)
@@ -2322,5 +2322,7 @@
 
 webkit.org/b/228642 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-unsafe-none.https.html [ Pass Failure ]
 
+webkit.org/b/228197 [ BigSur+ ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html [ Pass Failure ]
+
 webkit.org/b/228396 fast/speechsynthesis/speech-synthesis-speak-empty-string.html [ Pass Failure ]
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280473 => 280474)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-30 14:52:43 UTC (rev 280473)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-30 15:02:27 UTC (rev 280474)
@@ -1520,8 +1520,6 @@
 
 webkit.org/b/228189 http/tests/media/hls/hls-webvtt-seek-backwards.html [ Pass Timeout ]
 
-webkit.org/b/228197 [ arm64 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/header-parsing.https.html [ Pass Failure ]
-
 webkit.org/b/228087 media/video-seek-with-negative-playback.html [ Pass Failure ]
 
 webkit.org/b/228248 fast/selectors/selection-window-inactive.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280473] trunk/LayoutTests

[ehutchison]

Title: [280473] trunk/LayoutTests








Revision 280473
Author ehutchi...@apple.com
Date 2021-07-30 07:52:43 -0700 (Fri, 30 Jul 2021)


Log Message
imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-unsafe-none.https.html is a flaky failure .
https://bugs.webkit.org/show_bug.cgi?id=228642.

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (280472 => 280473)

--- trunk/LayoutTests/ChangeLog	2021-07-30 14:00:57 UTC (rev 280472)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 14:52:43 UTC (rev 280473)
@@ -1,5 +1,14 @@
 2021-07-30  Eric Hutchison  
 
+imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-unsafe-none.https.html is a flaky failure .
+https://bugs.webkit.org/show_bug.cgi?id=228642.
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2021-07-30  Eric Hutchison  
+
 [Mac Debug] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/dedicated-worker.tentative.https.html is a flaky failure.
 https://bugs.webkit.org/show_bug.cgi?id=228640.
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (280472 => 280473)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-07-30 14:00:57 UTC (rev 280472)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-07-30 14:52:43 UTC (rev 280473)
@@ -2320,5 +2320,7 @@
 
 webkit.org/b/228640 [ Debug ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/dedicated-worker.tentative.https.html [ Pass Failure ]
 
+webkit.org/b/228642 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-unsafe-none.https.html [ Pass Failure ]
+
 webkit.org/b/228396 fast/speechsynthesis/speech-synthesis-speak-empty-string.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280471] trunk

[commit-queue]

Title: [280471] trunk








Revision 280471
Author commit-qu...@webkit.org
Date 2021-07-30 02:09:44 -0700 (Fri, 30 Jul 2021)


Log Message
[AspectRatio] Fix replaced-element-034.html
https://bugs.webkit.org/show_bug.cgi?id=228223

Patch by Rob Buis  on 2021-07-30
Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

Fix replaced-element-034.html by making hasReplacedLogicalHeight
return false for *-content when aspect-ratio is provided and relying
on computeReplacedLogicalHeight to take aspect-ratio into account.

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::hasReplacedLogicalHeight const):

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderReplaced.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (280470 => 280471)

--- trunk/LayoutTests/ChangeLog	2021-07-30 08:41:25 UTC (rev 280470)
+++ trunk/LayoutTests/ChangeLog	2021-07-30 09:09:44 UTC (rev 280471)
@@ -1,3 +1,12 @@
+2021-07-30  Rob Buis  
+
+[AspectRatio] Fix replaced-element-034.html
+https://bugs.webkit.org/show_bug.cgi?id=228223
+
+Reviewed by Manuel Rego Casasnovas.
+
+* TestExpectations:
+
 2021-07-29  Tomoki Imai  
 
 Missing playing events when the ready state becomes HAVE_FUTURE_DATA/HAVE_ENOUGH_DATA from HAVE_METADATA state


Modified: trunk/LayoutTests/TestExpectations (280470 => 280471)

--- trunk/LayoutTests/TestExpectations	2021-07-30 08:41:25 UTC (rev 280470)
+++ trunk/LayoutTests/TestExpectations	2021-07-30 09:09:44 UTC (rev 280471)
@@ -4713,7 +4713,6 @@
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-022.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-025.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-026.html [ ImageOnlyFailure ]
-webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-034.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-001.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-002.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-003.html [ ImageOnlyFailure ]


Modified: trunk/Source/WebCore/ChangeLog (280470 => 280471)

--- trunk/Source/WebCore/ChangeLog	2021-07-30 08:41:25 UTC (rev 280470)
+++ trunk/Source/WebCore/ChangeLog	2021-07-30 09:09:44 UTC (rev 280471)
@@ -1,3 +1,17 @@
+2021-07-30  Rob Buis  
+
+[AspectRatio] Fix replaced-element-034.html
+https://bugs.webkit.org/show_bug.cgi?id=228223
+
+Reviewed by Manuel Rego Casasnovas.
+
+Fix replaced-element-034.html by making hasReplacedLogicalHeight
+return false for *-content when aspect-ratio is provided and relying
+on computeReplacedLogicalHeight to take aspect-ratio into account.
+
+* rendering/RenderReplaced.cpp:
+(WebCore::RenderReplaced::hasReplacedLogicalHeight const):
+
 2021-07-29  Tomoki Imai  
 
 Missing playing events when the ready state becomes HAVE_FUTURE_DATA/HAVE_ENOUGH_DATA from HAVE_METADATA state


Modified: trunk/Source/WebCore/rendering/RenderReplaced.cpp (280470 => 280471)

--- trunk/Source/WebCore/rendering/RenderReplaced.cpp	2021-07-30 08:41:25 UTC (rev 280470)
+++ trunk/Source/WebCore/rendering/RenderReplaced.cpp	2021-07-30 09:09:44 UTC (rev 280471)
@@ -363,7 +363,7 @@
 return !hasAutoHeightOrContainingBlockWithAutoHeight();
 
 if (style().logicalHeight().isIntrinsic())
-return true;
+return !style().hasAspectRatio();
 
 return false;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280470] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [280470] trunk/Source/_javascript_Core








Revision 280470
Author ysuz...@apple.com
Date 2021-07-30 01:41:25 -0700 (Fri, 30 Jul 2021)


Log Message
[JSC] Use UCPURegister argument to remove zero extension in JIT code
https://bugs.webkit.org/show_bug.cgi?id=228625

Reviewed by Robin Morisset.

Yarr JIT code emits zeroExtend32ToWord for some arguments, but this is not necessary if
argument is defined as UCPURegister. In that case, caller guarantees that top 32bits are
cleared.

* yarr/YarrJIT.cpp:
* yarr/YarrJIT.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp
trunk/Source/_javascript_Core/yarr/YarrJIT.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280469 => 280470)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-30 08:29:29 UTC (rev 280469)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-30 08:41:25 UTC (rev 280470)
@@ -1,3 +1,17 @@
+2021-07-30  Yusuke Suzuki  
+
+[JSC] Use UCPURegister argument to remove zero extension in JIT code
+https://bugs.webkit.org/show_bug.cgi?id=228625
+
+Reviewed by Robin Morisset.
+
+Yarr JIT code emits zeroExtend32ToWord for some arguments, but this is not necessary if
+argument is defined as UCPURegister. In that case, caller guarantees that top 32bits are
+cleared.
+
+* yarr/YarrJIT.cpp:
+* yarr/YarrJIT.h:
+
 2021-07-29  Myles C. Maxfield  
 
 Stop building WebGPU and the WHLSL compiler to decrease binary size


Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (280469 => 280470)

--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2021-07-30 08:29:29 UTC (rev 280469)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2021-07-30 08:41:25 UTC (rev 280470)
@@ -3972,9 +3972,6 @@
 push(X86Registers::r14);
 push(X86Registers::r15);
 }
-// The ABI doesn't guarantee the upper bits are zero on unsigned arguments, so clear them ourselves.
-zeroExtend32ToWord(index, index);
-zeroExtend32ToWord(length, length);
 #if OS(WINDOWS)
 if (m_compileMode == JITCompileMode::IncludeSubpatterns)
 loadPtr(Address(X86Registers::ebp, 6 * sizeof(void*)), output);
@@ -3991,10 +3988,6 @@
 move(TrustedImm32(0xd800), leadingSurrogateTag);
 move(TrustedImm32(0xdc00), trailingSurrogateTag);
 }
-
-// The ABI doesn't guarantee the upper bits are zero on unsigned arguments, so clear them ourselves.
-zeroExtend32ToWord(index, index);
-zeroExtend32ToWord(length, length);
 #elif CPU(ARM_THUMB2)
 push(ARMRegisters::r4);
 push(ARMRegisters::r5);


Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.h (280469 => 280470)

--- trunk/Source/_javascript_Core/yarr/YarrJIT.h	2021-07-30 08:29:29 UTC (rev 280469)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.h	2021-07-30 08:41:25 UTC (rev 280470)
@@ -103,7 +103,7 @@
 };
 
 #if CPU(ARM64E)
-extern "C" EncodedMatchResult vmEntryToYarrJIT(const void* input, unsigned start, unsigned length, int* output, MatchingContextHolder* matchingContext, const void* codePtr);
+extern "C" EncodedMatchResult vmEntryToYarrJIT(const void* input, UCPURegister start, UCPURegister length, int* output, MatchingContextHolder* matchingContext, const void* codePtr);
 extern "C" void vmEntryToYarrJITAfter(void);
 #endif
 
@@ -111,10 +111,10 @@
 WTF_MAKE_FAST_ALLOCATED;
 WTF_MAKE_NONCOPYABLE(YarrCodeBlock);
 
-using YarrJITCode8 = EncodedMatchResult (*)(const LChar* input, unsigned start, unsigned length, int* output, MatchingContextHolder& matchingContext) YARR_CALL;
-using YarrJITCode16 = EncodedMatchResult (*)(const UChar* input, unsigned start, unsigned length, int* output, MatchingContextHolder& matchingContext) YARR_CALL;
-using YarrJITCodeMatchOnly8 = EncodedMatchResult (*)(const LChar* input, unsigned start, unsigned length, void*, MatchingContextHolder& matchingContext) YARR_CALL;
-using YarrJITCodeMatchOnly16 = EncodedMatchResult (*)(const UChar* input, unsigned start, unsigned length, void*, MatchingContextHolder& matchingContext) YARR_CALL;
+using YarrJITCode8 = EncodedMatchResult (*)(const LChar* input, UCPURegister start, UCPURegister length, int* output, MatchingContextHolder& matchingContext) YARR_CALL;
+using YarrJITCode16 = EncodedMatchResult (*)(const UChar* input, UCPURegister start, UCPURegister length, int* output, MatchingContextHolder& matchingContext) YARR_CALL;
+using YarrJITCodeMatchOnly8 = EncodedMatchResult (*)(const LChar* input, UCPURegister start, UCPURegister length, void*, MatchingContextHolder& matchingContext) YARR_CALL;
+using YarrJITCodeMatchOnly16 = EncodedMatchResult (*)(const UChar* input, UCPURegister start, UCPURegister length, void*, MatchingContextHolder& matchingContext) YARR_CALL;
 
 public:
 YarrCodeBlock() = default;






___
webkit-changes mailing li

[webkit-changes] [280469] trunk

[aperez]

Title: [280469] trunk








Revision 280469
Author ape...@igalia.com
Date 2021-07-30 01:29:29 -0700 (Fri, 30 Jul 2021)


Log Message
[CMake] Fix fallback methods in the libgcrypt find module
https://bugs.webkit.org/show_bug.cgi?id=228581

Reviewed by Carlos Alberto Lopez Perez.

* Source/cmake/FindLibGcrypt.cmake: Make sure to use the libgcrypt-config script as
first fallback if libgcrypt.pc is not present, and fix the regexp used as last fallback
that checks the version from the gcrypt.h header as last fallback to only include digits
and periods.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/FindLibGcrypt.cmake




Diff

Modified: trunk/ChangeLog (280468 => 280469)

--- trunk/ChangeLog	2021-07-30 06:43:48 UTC (rev 280468)
+++ trunk/ChangeLog	2021-07-30 08:29:29 UTC (rev 280469)
@@ -1,3 +1,15 @@
+2021-07-30  Adrian Perez de Castro  
+
+[CMake] Fix fallback methods in the libgcrypt find module
+https://bugs.webkit.org/show_bug.cgi?id=228581
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* Source/cmake/FindLibGcrypt.cmake: Make sure to use the libgcrypt-config script as
+first fallback if libgcrypt.pc is not present, and fix the regexp used as last fallback
+that checks the version from the gcrypt.h header as last fallback to only include digits
+and periods.
+
 2021-07-29  Myles C. Maxfield  
 
 Stop building WebGPU and the WHLSL compiler to decrease binary size


Modified: trunk/Source/cmake/FindLibGcrypt.cmake (280468 => 280469)

--- trunk/Source/cmake/FindLibGcrypt.cmake	2021-07-30 06:43:48 UTC (rev 280468)
+++ trunk/Source/cmake/FindLibGcrypt.cmake	2021-07-30 08:29:29 UTC (rev 280469)
@@ -47,7 +47,9 @@
 pkg_check_modules(PC_GPGERROR QUIET gpg-error)
 set(LibGcrypt_COMPILE_OPTIONS ${PC_GCRYPT_CFLAGS_OTHER} ${PC_GPGERROR_CFLAGS_OTHER})
 set(LibGcrypt_VERSION ${PC_GCRYPT_VERSION})
-elseif (LIBGCRYPTCONFIG_SCRIPT)
+endif ()
+
+if (LIBGCRYPTCONFIG_SCRIPT AND NOT PC_GCRYPT)
 execute_process(
 COMMAND "${LIBGCRYPTCONFIG_SCRIPT}" --prefix
 RESULT_VARIABLE CONFIGSCRIPT_RESULT
@@ -105,8 +107,8 @@
 )
 
 if (LibGcrypt_INCLUDE_DIR AND NOT LibGcrypt_VERSION)
-file(STRINGS ${LIBGCRYPT_INCLUDE_DIR}/gcrypt.h GCRYPT_H REGEX "^#define GCRYPT_VERSION ")
-string(REGEX REPLACE "^#define GCRYPT_VERSION \"(.*)\".*$" "\\1" LibGcrypt_VERSION "${GCRYPT_H}")
+file(STRINGS ${LibGcrypt_INCLUDE_DIR}/gcrypt.h GCRYPT_H REGEX "^#define GCRYPT_VERSION ")
+string(REGEX REPLACE "^#define GCRYPT_VERSION \"([0-9.]\+)[^\"]*\".*$" "\\1" LibGcrypt_VERSION "${GCRYPT_H}")
 endif ()
 
 include(FindPackageHandleStandardArgs)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes