date:20210821

[webkit-changes] [281391] branches/safari-611.3.10.1-branch/Source

2021-08-21 Thread kocsen_chung

Title: [281391] branches/safari-611.3.10.1-branch/Source








Revision 281391
Author kocsen_ch...@apple.com
Date 2021-08-21 22:52:17 -0700 (Sat, 21 Aug 2021)


Log Message
Versioning.

WebKit-7611.3.10.1.7

Modified Paths

branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.3.10.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281390 => 281391)

--- branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
+++ branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-22 05:52:17 UTC (rev 281391)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281390 => 281391)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-22 05:52:17 UTC (rev 281391)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281390 => 281391)

--- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
+++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-22 05:52:17 UTC (rev 281391)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig (281390 => 281391)

--- branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
+++ branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-22 05:52:17 UTC (rev 281391)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281390 => 281391)

--- branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
+++ branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-22 05:52:17 UTC (rev 281391)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281390 => 281391)

--- branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
+++ branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-22 05:52:17 UTC (rev 281391)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION =

[webkit-changes] [281390] branches/safari-611.3.10.0-branch/Source

2021-08-21 Thread kocsen_chung

Title: [281390] branches/safari-611.3.10.0-branch/Source








Revision 281390
Author kocsen_ch...@apple.com
Date 2021-08-21 22:46:32 -0700 (Sat, 21 Aug 2021)


Log Message
Versioning.

WebKit-7611.4.0.2

Modified Paths

branches/safari-611.3.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.3.10.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.3.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.3.10.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.3.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.3.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.3.10.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.3.10.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.3.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281389 => 281390)

--- branches/safari-611.3.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-22 05:41:27 UTC (rev 281389)
+++ branches/safari-611.3.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 4;
 TINY_VERSION = 0;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.3.10.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281389 => 281390)

--- branches/safari-611.3.10.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-22 05:41:27 UTC (rev 281389)
+++ branches/safari-611.3.10.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 4;
 TINY_VERSION = 0;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.3.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281389 => 281390)

--- branches/safari-611.3.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-22 05:41:27 UTC (rev 281389)
+++ branches/safari-611.3.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 4;
 TINY_VERSION = 0;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.3.10.0-branch/Source/WebCore/Configurations/Version.xcconfig (281389 => 281390)

--- branches/safari-611.3.10.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-22 05:41:27 UTC (rev 281389)
+++ branches/safari-611.3.10.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 4;
 TINY_VERSION = 0;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.3.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281389 => 281390)

--- branches/safari-611.3.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-22 05:41:27 UTC (rev 281389)
+++ branches/safari-611.3.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 4;
 TINY_VERSION = 0;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.3.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281389 => 281390)

--- branches/safari-611.3.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-22 05:41:27 UTC (rev 281389)
+++ branches/safari-611.3.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 4;
 TINY_VERSION = 0;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.3.10.0-branch/Source/WebKit/Configurations/Version.xcconfig (281389 => 281390)

--- branches/safari-611.3.10.0-branch/Source/WebKit/Configurations/Version.xcconfig	2021-08-22 05:41:27 UTC (rev 281389)
+++ branches/safari-611.3.10.0-branch/Source/WebKit/Configurations/Version.xcconfig	2021-08-22 05:46:32 UTC (rev 281390)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 4;
 TINY_VERSION = 0;
-MICRO_VERSION = 1;

[webkit-changes] [281389] trunk

2021-08-21 Thread mmaxfield

Title: [281389] trunk








Revision 281389
Author mmaxfi...@apple.com
Date 2021-08-21 22:41:27 -0700 (Sat, 21 Aug 2021)


Log Message
overwriteCodePoint() in createAndFillGlyphPage() is wrong
https://bugs.webkit.org/show_bug.cgi?id=215643


Reviewed by Alan Bujtas.

Source/WebCore:

The CSS spec says that certain characters have to be invisible. Previously, we were doing this
by just treating these characters as if they were the zero width space character. However, this
is wrong for 2 reasons:

1. If the primary font supports the desired character but doesn't support the zero width space
   character, we'll fallback past it and trigger a download for secondary fonts until
   we find one that supports the ZWS character (which the page didn't even ask for!)
2. Shaping is Turing-complete, and expects that the correct glyphIDs are fed into the shaper.
   We can't just arbitrarily swap out glyphIDs before shaping just because we feel like it.

Instead, the solution is to handle these invisible characters after font fallback, and after
shaping. This patch does it just like we handle adding letter-spacing, word-spacing, and
justification after shaping - by iterating over the glyphs output by the shaper and seeing if
any need to be adjusted.

This patch also includes a fix for the situation where the glyph buffer might be left in an
inconsistent state, where the array of glyphs is shorter than the array of characters -
this new codepath added in this patch revealed this existing problem, and fixes it here too.

Test: fast/text/zwj-ligature.html

* platform/graphics/Font.cpp:
(WebCore::createAndFillGlyphPage):
(WebCore::overrideControlCharacters): Deleted.
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::glyphAt const):
(WebCore::GlyphBuffer::deleteGlyphWithoutAffectingSize):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyCSSVisibilityRules):
(WebCore::WidthIterator::advance):
* platform/graphics/WidthIterator.h:

Source/WTF:

* wtf/unicode/CharacterNames.h:

LayoutTests:

* fast/text/resources/Ahem-GSUB-ligatures.ttf: Added.
* fast/text/zwj-ligature-expected.html: Added.
* fast/text/zwj-ligature.html: Added.
* platform/mac/fast/text/format-control-expected.txt: Progression! A new ligature is formed that wasn't formed before.
  Also, this ligature is formed in both Chrome and Firefox, so we match them now.
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/text/format-control-expected.txt
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/unicode/CharacterNames.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Font.cpp
trunk/Source/WebCore/platform/graphics/GlyphBuffer.h
trunk/Source/WebCore/platform/graphics/WidthIterator.cpp
trunk/Source/WebCore/platform/graphics/WidthIterator.h


Added Paths

trunk/LayoutTests/fast/text/resources/Ahem-GSUB-ligatures.ttf
trunk/LayoutTests/fast/text/zwj-ligature-expected.html
trunk/LayoutTests/fast/text/zwj-ligature.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281388 => 281389)

--- trunk/LayoutTests/ChangeLog	2021-08-22 04:28:58 UTC (rev 281388)
+++ trunk/LayoutTests/ChangeLog	2021-08-22 05:41:27 UTC (rev 281389)
@@ -1,3 +1,18 @@
+2021-08-21  Myles C. Maxfield  
+
+overwriteCodePoint() in createAndFillGlyphPage() is wrong
+https://bugs.webkit.org/show_bug.cgi?id=215643
+
+
+Reviewed by Alan Bujtas.
+
+* fast/text/resources/Ahem-GSUB-ligatures.ttf: Added.
+* fast/text/zwj-ligature-expected.html: Added.
+* fast/text/zwj-ligature.html: Added.
+* platform/mac/fast/text/format-control-expected.txt: Progression! A new ligature is formed that wasn't formed before.
+  Also, this ligature is formed in both Chrome and Firefox, so we match them now.
+* platform/win/TestExpectations:
+
 2021-08-21  Alan Bujtas  
 
 [LFC][IFC] Add support for -webkit-text-security: disc


Added: trunk/LayoutTests/fast/text/resources/Ahem-GSUB-ligatures.ttf (0 => 281389)

--- trunk/LayoutTests/fast/text/resources/Ahem-GSUB-ligatures.ttf	(rev 0)
+++ trunk/LayoutTests/fast/text/resources/Ahem-GSUB-ligatures.ttf	2021-08-22 05:41:27 UTC (rev 281389)
@@ -0,0 +1,47 @@
+ÀÀÀÀÀ\x80ÀÀ@GSUB\xB2\xA2\xB4\xA0ÀÀÀ\xCCÀÀÀ^OS/2sf\xF8ÀÀ,ÀÀÀ`cmap9\x96U\xEEÀÀ\x8CÀÀgaspÀÀ	ÀÀ\x98ÀÀÀglyf0*	\xFDÀÀ\xA8ÀÀ\xA8head\xDBPÍµÀÀ!PÀÀÀ6hhea
+7ÀÀ!\x88ÀÀÀ$hmtx+ÀÀ!\xACÀÀXloca\xBEÔ¸7ÀÀ&ÀÀ.maxpÀ	ÀÀ(4ÀÀÀ nameM\xDAcÀÀ(TÀÀ1\xAEpostc\xA1[#ÀÀZÀÀÀÀÀÀ
+ÀÀ,ÀDFLTÀÀÀÀÀÀÀÀÀÀÀÀligaÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀ
+ÀÀÀÀÀÀ#À$ÀÀÀÀ
+ÀRÀÀ$ÀRÀÀÀÀÀ\xD6\x90ÀÀÀ\xBC\x8AÀÀÀ\x8F\xBC\x8AÀÀ\xC5À2ÀÀÀÀÀÀÀÀÀÀ\x80ÀÀ\xAFÀ HÀÀÀÀÀÀÀÀW3C À@À \xFE\xFF \xFF8ÀÀ

[webkit-changes] [281388] trunk/Source/WebCore

2021-08-21 Thread zalan

Title: [281388] trunk/Source/WebCore








Revision 281388
Author za...@apple.com
Date 2021-08-21 21:28:58 -0700 (Sat, 21 Aug 2021)


Log Message
[LFC][Integration] Do not create an InlineFormattingContext object for constructing display lines and runs
https://bugs.webkit.org/show_bug.cgi?id=228061

Reviewed by Sam Weinig.

We've got all we need in the inlineFormattingState object.

* layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
* layout/integration/LayoutIntegrationInlineContentBuilder.h:
* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::constructContent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281387 => 281388)

--- trunk/Source/WebCore/ChangeLog	2021-08-22 04:24:30 UTC (rev 281387)
+++ trunk/Source/WebCore/ChangeLog	2021-08-22 04:28:58 UTC (rev 281388)
@@ -1,5 +1,22 @@
 2021-08-21  Alan Bujtas  
 
+[LFC][Integration] Do not create an InlineFormattingContext object for constructing display lines and runs
+https://bugs.webkit.org/show_bug.cgi?id=228061
+
+Reviewed by Sam Weinig.
+
+We've got all we need in the inlineFormattingState object.
+
+* layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
+(WebCore::LayoutIntegration::InlineContentBuilder::build const):
+(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
+(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
+* layout/integration/LayoutIntegrationInlineContentBuilder.h:
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::constructContent):
+
+2021-08-21  Alan Bujtas  
+
 [LFC][IFC] Add support for -webkit-text-security: disc
 https://bugs.webkit.org/show_bug.cgi?id=229047
 


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp (281387 => 281388)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp	2021-08-22 04:24:30 UTC (rev 281387)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp	2021-08-22 04:28:58 UTC (rev 281388)
@@ -164,13 +164,12 @@
 {
 }
 
-void InlineContentBuilder::build(const Layout::InlineFormattingContext& inlineFormattingContext, InlineContent& inlineContent) const
+void InlineContentBuilder::build(const Layout::InlineFormattingState& inlineFormattingState, InlineContent& inlineContent) const
 {
-auto& inlineFormattingState = inlineFormattingContext.formattingState();
 auto lineLevelVisualAdjustmentsForRuns = computeLineLevelVisualAdjustmentsForRuns(inlineFormattingState);
-createDisplayLineRuns(inlineFormattingState, inlineContent, lineLevelVisualAdjustmentsForRuns);
-createDisplayNonRootInlineBoxes(inlineFormattingContext, inlineContent);
-createDisplayLines(inlineFormattingState, inlineContent, lineLevelVisualAdjustmentsForRuns);
+createDisplayLineRuns(inlineFormattingState.lines(), inlineFormattingState.lineRuns(), inlineContent, lineLevelVisualAdjustmentsForRuns);
+createDisplayNonRootInlineBoxes(inlineFormattingState, inlineContent);
+createDisplayLines(inlineFormattingState.lines(), inlineContent, lineLevelVisualAdjustmentsForRuns);
 }
 
 InlineContentBuilder::LineLevelVisualAdjustmentsForRunsList InlineContentBuilder::computeLineLevelVisualAdjustmentsForRuns(const Layout::InlineFormattingState& inlineFormattingState) const
@@ -218,12 +217,10 @@
 return lineLevelVisualAdjustmentsForRuns;
 }
 
-void InlineContentBuilder::createDisplayLineRuns(const Layout::InlineFormattingState& inlineFormattingState, InlineContent& inlineContent, const LineLevelVisualAdjustmentsForRunsList& lineLevelVisualAdjustmentsForRuns) const
+void InlineContentBuilder::createDisplayLineRuns(const Layout::InlineLines& lines, const Layout::InlineLineRuns& lineRuns, InlineContent& inlineContent, const LineLevelVisualAdjustmentsForRunsList& lineLevelVisualAdjustmentsForRuns) const
 {
-auto& runList = inlineFormattingState.lineRuns();
-if (runList.isEmpty())
+if (lineRuns.isEmpty())
 return;
-auto& lines = inlineFormattingState.lines();
 
 #if PROCESS_BIDI_CONTENT
 BidiResolver bidiResolver;
@@ -230,8 +227,8 @@
 // FIXME: Add support for override.
 bidiResolver.setStatus(BidiStatus(m_layoutState.root().style().direction(), false));
 // FIXME: Grab the nested isolates from the previous line.
-

[webkit-changes] [281387] trunk

2021-08-21 Thread zalan

Title: [281387] trunk








Revision 281387
Author za...@apple.com
Date 2021-08-21 21:24:30 -0700 (Sat, 21 Aug 2021)


Log Message
[LFC][IFC] Add support for -webkit-text-security: disc
https://bugs.webkit.org/show_bug.cgi?id=229047

Reviewed by Antti Koivisto.
Source/WebCore:

The disc glyph affects layout, so let's replace the text before we start measuring the inline content.

* layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTree):
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForStyle):
* layout/integration/LayoutIntegrationCoverage.h:

LayoutTests:

Let's dump the actual disc characters.

* platform/ios-simulator/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt:
* platform/ios/fast/css/text-overflow-input-expected.txt:
* platform/ios/fast/forms/basic-inputs-expected.txt:
* platform/ios/fast/forms/input-value-expected.txt:
* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt:
* platform/mac/fast/forms/basic-inputs-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/basic-inputs-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/input-value-expected.txt
trunk/LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt
trunk/LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/input-value-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (281386 => 281387)

--- trunk/LayoutTests/ChangeLog	2021-08-22 03:31:33 UTC (rev 281386)
+++ trunk/LayoutTests/ChangeLog	2021-08-22 04:24:30 UTC (rev 281387)
@@ -1,5 +1,23 @@
 2021-08-21  Alan Bujtas  
 
+[LFC][IFC] Add support for -webkit-text-security: disc
+https://bugs.webkit.org/show_bug.cgi?id=229047
+
+Reviewed by Antti Koivisto.
+
+Let's dump the actual disc characters.
+
+* platform/ios-simulator/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt:
+* platform/ios/fast/css/text-overflow-input-expected.txt:
+* platform/ios/fast/forms/basic-inputs-expected.txt:
+* platform/ios/fast/forms/input-value-expected.txt:
+* platform/mac/fast/css/text-overflow-input-expected.txt:
+* platform/mac/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt:
+* platform/mac/fast/forms/basic-inputs-expected.txt:
+* platform/mac/fast/forms/input-value-expected.txt:
+
+2021-08-21  Alan Bujtas  
+
 [IFC][Integration] Enable modern line layout for placeholder elements
 https://bugs.webkit.org/show_bug.cgi?id=228887
 


Modified: trunk/LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt (281386 => 281387)

--- trunk/LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt	2021-08-22 03:31:33 UTC (rev 281386)
+++ trunk/LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt	2021-08-22 04:24:30 UTC (rev 281387)
@@ -151,7 +151,7 @@
 layer at (17,102) size 142x14 backgroundClip at (17,102) size 141x14 clip at (17,102) size 141x14 scrollWidth 387
   RenderBlock {DIV} at (0,0) size 142x14
 RenderText {#text} at (0,0) size 385x14
-  text run at (0,0) width 385: "\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}\x{25CF}"
+  text run at (0,0) width 385:

[webkit-changes] [281386] trunk

2021-08-21 Thread zalan

Title: [281386] trunk








Revision 281386
Author za...@apple.com
Date 2021-08-21 20:31:33 -0700 (Sat, 21 Aug 2021)


Log Message
[IFC][Integration] Enable modern line layout for placeholder elements
https://bugs.webkit.org/show_bug.cgi?id=228887

Reviewed by Antti Koivisto.

Source/WebCore:

Apparently placeholders don't do strange things anymore (this check is originated in SLL).

* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

LayoutTests:

* platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h




Diff

Modified: trunk/LayoutTests/ChangeLog (281385 => 281386)

--- trunk/LayoutTests/ChangeLog	2021-08-22 03:26:31 UTC (rev 281385)
+++ trunk/LayoutTests/ChangeLog	2021-08-22 03:31:33 UTC (rev 281386)
@@ -1,3 +1,12 @@
+2021-08-21  Alan Bujtas  
+
+[IFC][Integration] Enable modern line layout for placeholder elements
+https://bugs.webkit.org/show_bug.cgi?id=228887
+
+Reviewed by Antti Koivisto.
+
+* platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt:
+
 2021-08-21  Per Arne  
 
 [Win] The layout test fast/visual-viewport/resize-event-fired-window-resized.html is a flaky timeout


Modified: trunk/LayoutTests/platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt (281385 => 281386)

--- trunk/LayoutTests/platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt	2021-08-22 03:26:31 UTC (rev 281385)
+++ trunk/LayoutTests/platform/ios-wk2/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt	2021-08-22 03:31:33 UTC (rev 281386)
@@ -18,8 +18,8 @@
   (rect 16.50 55.50 37 17)
   (rect 13.50 54 43 20)
   (rect 16.50 57 37 14)
-  (rect 13.50 54 26 20)
-  (rect 16.50 57 20 14)
+  (rect 33.50 54 23 20)
+  (rect 36.50 57 17 14)
   (rect 13.50 54 43 20)
   (rect 16.50 57 37 14)
 )


Modified: trunk/Source/WebCore/ChangeLog (281385 => 281386)

--- trunk/Source/WebCore/ChangeLog	2021-08-22 03:26:31 UTC (rev 281385)
+++ trunk/Source/WebCore/ChangeLog	2021-08-22 03:31:33 UTC (rev 281386)
@@ -1,3 +1,15 @@
+2021-08-21  Alan Bujtas  
+
+[IFC][Integration] Enable modern line layout for placeholder elements
+https://bugs.webkit.org/show_bug.cgi?id=228887
+
+Reviewed by Antti Koivisto.
+
+Apparently placeholders don't do strange things anymore (this check is originated in SLL).
+
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
+
 2021-08-21  Sihui Liu  
 
 IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (281385 => 281386)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-08-22 03:26:31 UTC (rev 281385)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-08-22 03:31:33 UTC (rev 281386)
@@ -111,9 +111,6 @@
 case AvoidanceReason::FlowHasLineClamp:
 stream << "-webkit-line-clamp";
 break;
-case AvoidanceReason::FlowParentIsPlaceholderElement:
-stream << "placeholder element";
-break;
 case AvoidanceReason::FlowHasNonSupportedChild:
 stream << "unsupported child renderer";
 break;
@@ -737,9 +734,6 @@
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasTextOverflow, reasons, includeReasons);
 if (!flow.parent()->style().lineClamp().isNone())
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasLineClamp, reasons, includeReasons);
-// FIXME: Placeholders do something strange.
-if (is(*flow.parent()) && downcast(*flow.parent()).textFormControlElement().placeholderElement())
-SET_REASON_AND_RETURN_IF_NEEDED(FlowParentIsPlaceholderElement, reasons, includeReasons);
 // This currently covers #text, #text and mutiple (sibling) RenderText cases.
 // The #text case is also popular and should be relatively easy to cover.
 for (auto walker = InlineWalker(const_cast(flow)); !walker.atEnd(); walker.advance()) {


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h (281385 => 281386)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h	2021-08-22 03:26:31 UTC (rev 281385)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h	2021-08-22 03:31:33 UTC (rev 281386)
@@ -44,7 +44,7 @@
 FlowIsPaginated  = 1LLU  << 4,
 FlowHasTextOverflow  = 1LLU  << 5,
 FlowHasLineClamp = 1LLU  << 6,
-FlowParentIsPlaceholderElement

[webkit-changes] [281385] trunk/LayoutTests

2021-08-21 Thread pvollan

Title: [281385] trunk/LayoutTests








Revision 281385
Author pvol...@apple.com
Date 2021-08-21 20:26:31 -0700 (Sat, 21 Aug 2021)


Log Message
[Win] The layout test fast/visual-viewport/resize-event-fired-window-resized.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=229379

Unreviewed test gardening.


* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281384 => 281385)

--- trunk/LayoutTests/ChangeLog	2021-08-22 01:33:10 UTC (rev 281384)
+++ trunk/LayoutTests/ChangeLog	2021-08-22 03:26:31 UTC (rev 281385)
@@ -1,5 +1,14 @@
 2021-08-21  Per Arne  
 
+[Win] The layout test fast/visual-viewport/resize-event-fired-window-resized.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=229379
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
+2021-08-21  Per Arne  
+
 [Win] The layout test http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is timing out
 https://bugs.webkit.org/show_bug.cgi?id=229372
 


Modified: trunk/LayoutTests/platform/win/TestExpectations (281384 => 281385)

--- trunk/LayoutTests/platform/win/TestExpectations	2021-08-22 01:33:10 UTC (rev 281384)
+++ trunk/LayoutTests/platform/win/TestExpectations	2021-08-22 03:26:31 UTC (rev 281385)
@@ -4687,3 +4687,5 @@
 webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]
 
 webkit.org/b/229372 http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html [ Skip ]
+
+webkit.org/b/229379 fast/visual-viewport/resize-event-fired-window-resized.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281384] trunk/Source

2021-08-21 Thread sihui_liu

Title: [281384] trunk/Source








Revision 281384
Author sihui_...@apple.com
Date 2021-08-21 18:33:10 -0700 (Sat, 21 Aug 2021)


Log Message
IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.

Reviewed by Brady Eidson.

* wtf/CrossThreadTask.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CrossThreadTask.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (281383 => 281384)

--- trunk/Source/WTF/ChangeLog	2021-08-22 00:26:53 UTC (rev 281383)
+++ trunk/Source/WTF/ChangeLog	2021-08-22 01:33:10 UTC (rev 281384)
@@ -1,3 +1,14 @@
+2021-08-21  Sihui Liu  
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.
+
+Reviewed by Brady Eidson.
+
+* wtf/CrossThreadTask.h:
+
 2021-08-20  Mark Lam  
 
 Make ptrTagName and tagForPtr WTF_EXPORT_PRIVATE.


Modified: trunk/Source/WTF/wtf/CrossThreadTask.h (281383 => 281384)

--- trunk/Source/WTF/wtf/CrossThreadTask.h	2021-08-22 00:26:53 UTC (rev 281383)
+++ trunk/Source/WTF/wtf/CrossThreadTask.h	2021-08-22 01:33:10 UTC (rev 281384)
@@ -87,7 +87,7 @@
 callMemberFunctionForCrossThreadTaskImpl(object, function, std::forward(args), ArgsIndicies());
 }
 
-template, T>::value, int>::type = 0, typename... Parameters, typename... Arguments>
+template::value, int>::type = 0, typename... Parameters, typename... Arguments>
 CrossThreadTask createCrossThreadTask(T& callee, void (T::*method)(Parameters...), const Arguments&... arguments)
 {
 return CrossThreadTask([callee = makeRefPtr(), method, arguments = std::make_tuple(crossThreadCopy(arguments)...)]() mutable {
@@ -95,7 +95,7 @@
 });
 }
 
-template, T>::value, int>::type = 0, typename... Parameters, typename... Arguments>
+template::value, int>::type = 0, typename... Parameters, typename... Arguments>
 CrossThreadTask createCrossThreadTask(T& callee, void (T::*method)(Parameters...), const Arguments&... arguments)
 {
 return CrossThreadTask([callee = , method, arguments = std::make_tuple(crossThreadCopy(arguments)...)]() mutable {


Modified: trunk/Source/WebCore/ChangeLog (281383 => 281384)

--- trunk/Source/WebCore/ChangeLog	2021-08-22 00:26:53 UTC (rev 281383)
+++ trunk/Source/WebCore/ChangeLog	2021-08-22 01:33:10 UTC (rev 281384)
@@ -1,3 +1,16 @@
+2021-08-21  Sihui Liu  
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Reviewed by Brady Eidson.
+
+Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
+created internally.
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::dispatchEvent):
+
 2021-08-21  Zalan Bujtas  
 
 [IFC][Integration] Group non-standard CSS properties


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (281383 => 281384)

--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2021-08-22 00:26:53 UTC (rev 281383)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2021-08-22 01:33:10 UTC (rev 281384)
@@ -308,7 +308,8 @@
 else if (m_transaction && !m_transaction->didDispatchAbortOrCommit())
 targets = { this, m_transaction.get(), _transaction->database() };
 
-m_hasPendingActivity = false;
+if (event.isTrusted())
+m_hasPendingActivity = false;
 
 {
 TransactionActivator activator(m_transaction.get());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281383] trunk

2021-08-21 Thread ysuzuki

Title: [281383] trunk








Revision 281383
Author ysuz...@apple.com
Date 2021-08-21 17:26:53 -0700 (Sat, 21 Aug 2021)


Log Message
[JSC] Remove Intl runtime feature flags for already shipped ones
https://bugs.webkit.org/show_bug.cgi?id=229371

Reviewed by Ross Kirsling.

JSTests:

* stress/intl-datetimeformat-day-period.js:
* test262/config.yaml:

Source/_javascript_Core:

Since they are already shipped, we should remove these runtime flags.

* builtins/DatePrototype.js:
(globalPrivate.toDateTimeOptionsAnyAll):
(globalPrivate.toDateTimeOptionsTimeTime):
* bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
* bytecode/BytecodeIntrinsicRegistry.h:
* runtime/IntlDateTimeFormat.cpp:
(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::resolvedOptions const):
* runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototype::finishCreation):
* runtime/OptionsList.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/intl-datetimeformat-day-period.js
trunk/JSTests/test262/config.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/DatePrototype.js
trunk/Source/_javascript_Core/bytecode/BytecodeIntrinsicRegistry.cpp
trunk/Source/_javascript_Core/bytecode/BytecodeIntrinsicRegistry.h
trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp
trunk/Source/_javascript_Core/runtime/IntlDateTimeFormatPrototype.cpp
trunk/Source/_javascript_Core/runtime/OptionsList.h




Diff

Modified: trunk/JSTests/ChangeLog (281382 => 281383)

--- trunk/JSTests/ChangeLog	2021-08-21 23:01:13 UTC (rev 281382)
+++ trunk/JSTests/ChangeLog	2021-08-22 00:26:53 UTC (rev 281383)
@@ -1,5 +1,15 @@
 2021-08-21  Yusuke Suzuki  
 
+[JSC] Remove Intl runtime feature flags for already shipped ones
+https://bugs.webkit.org/show_bug.cgi?id=229371
+
+Reviewed by Ross Kirsling.
+
+* stress/intl-datetimeformat-day-period.js:
+* test262/config.yaml:
+
+2021-08-21  Yusuke Suzuki  
+
 [JSC] Intl.DisplayNames v2
 https://bugs.webkit.org/show_bug.cgi?id=227832
 


Modified: trunk/JSTests/stress/intl-datetimeformat-day-period.js (281382 => 281383)

--- trunk/JSTests/stress/intl-datetimeformat-day-period.js	2021-08-21 23:01:13 UTC (rev 281382)
+++ trunk/JSTests/stress/intl-datetimeformat-day-period.js	2021-08-22 00:26:53 UTC (rev 281383)
@@ -1,5 +1,3 @@
-//@ runDefault("--useIntlDateTimeFormatDayPeriod=1")
-
 function shouldBe(actual, expected) {
 if (actual !== expected)
 throw new Error(`expected ${expected} but got ${actual}`);


Modified: trunk/JSTests/test262/config.yaml (281382 => 281383)

--- trunk/JSTests/test262/config.yaml	2021-08-21 23:01:13 UTC (rev 281382)
+++ trunk/JSTests/test262/config.yaml	2021-08-22 00:26:53 UTC (rev 281383)
@@ -10,7 +10,6 @@
   class-static-fields-private: usePrivateStaticClassFields
   class-static-methods-private: usePrivateMethods
   error-cause: useErrorCause
-  Intl.DateTimeFormat-dayPeriod: useIntlDateTimeFormatDayPeriod
   SharedArrayBuffer: useSharedArrayBuffer
   Atomics: useSharedArrayBuffer
   Array.prototype.at: useAtMethod


Modified: trunk/Source/_javascript_Core/ChangeLog (281382 => 281383)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-21 23:01:13 UTC (rev 281382)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-22 00:26:53 UTC (rev 281383)
@@ -1,5 +1,28 @@
 2021-08-21  Yusuke Suzuki  
 
+[JSC] Remove Intl runtime feature flags for already shipped ones
+https://bugs.webkit.org/show_bug.cgi?id=229371
+
+Reviewed by Ross Kirsling.
+
+Since they are already shipped, we should remove these runtime flags.
+
+* builtins/DatePrototype.js:
+(globalPrivate.toDateTimeOptionsAnyAll):
+(globalPrivate.toDateTimeOptionsTimeTime):
+* bytecode/BytecodeIntrinsicRegistry.cpp:
+(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
+* bytecode/BytecodeIntrinsicRegistry.h:
+* runtime/IntlDateTimeFormat.cpp:
+(JSC::toDateTimeOptionsAnyDate):
+(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
+(JSC::IntlDateTimeFormat::resolvedOptions const):
+* runtime/IntlDateTimeFormatPrototype.cpp:
+(JSC::IntlDateTimeFormatPrototype::finishCreation):
+* runtime/OptionsList.h:
+
+2021-08-21  Yusuke Suzuki  
+
 [JSC] Intl.DisplayNames v2
 https://bugs.webkit.org/show_bug.cgi?id=227832
 


Modified: trunk/Source/_javascript_Core/builtins/DatePrototype.js (281382 => 281383)

--- trunk/Source/_javascript_Core/builtins/DatePrototype.js	2021-08-21 23:01:13 UTC (rev 281382)
+++ trunk/Source/_javascript_Core/builtins/DatePrototype.js	2021-08-22 00:26:53 UTC (rev 281383)
@@ -45,7 +45,7 @@
 options.year === @undefined &&
 options.month === @undefined &&
 options.day === @undefined &&
-(!@useIntlDateTimeFormatDayPeriod ||

[webkit-changes] [281382] trunk/Source/WebCore

2021-08-21 Thread zalan

Title: [281382] trunk/Source/WebCore








Revision 281382
Author za...@apple.com
Date 2021-08-21 16:01:13 -0700 (Sat, 21 Aug 2021)


Log Message
[IFC][Integration] Group non-standard CSS properties
https://bugs.webkit.org/show_bug.cgi?id=228855


Reviewed by Antti Koivisto.

List of unsupported non-standard CSS properties (consider it a priority list).

* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForStyle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281381 => 281382)

--- trunk/Source/WebCore/ChangeLog	2021-08-21 22:34:46 UTC (rev 281381)
+++ trunk/Source/WebCore/ChangeLog	2021-08-21 23:01:13 UTC (rev 281382)
@@ -1,3 +1,16 @@
+2021-08-21  Zalan Bujtas  
+
+[IFC][Integration] Group non-standard CSS properties
+https://bugs.webkit.org/show_bug.cgi?id=228855
+
+
+Reviewed by Antti Koivisto.
+
+List of unsupported non-standard CSS properties (consider it a priority list).
+
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::canUseForStyle):
+
 2021-08-21  Per Arne  
 
 [Win] Crash under FontCache::lastResortFallbackFont


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (281381 => 281382)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-08-21 22:34:46 UTC (rev 281381)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-08-21 23:01:13 UTC (rev 281382)
@@ -510,8 +510,6 @@
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasTextOverflow, reasons, includeReasons);
 if (!style.isLeftToRightDirection())
 SET_REASON_AND_RETURN_IF_NEEDED(FlowIsNotLTR, reasons, includeReasons);
-if (!(style.lineBoxContain().contains(LineBoxContain::Block)))
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasLineBoxContainProperty, reasons, includeReasons);
 if (style.writingMode() != WritingMode::TopToBottom)
 SET_REASON_AND_RETURN_IF_NEEDED(FlowIsNotTopToBottom, reasons, includeReasons);
 if (style.unicodeBidi() != UBNormal)
@@ -518,10 +516,6 @@
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonNormalUnicodeBiDi, reasons, includeReasons);
 if (style.rtlOrdering() != Order::Logical)
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasRTLOrdering, reasons, includeReasons);
-if (style.lineAlign() != LineAlign::None)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasLineAlignEdges, reasons, includeReasons);
-if (style.lineSnap() != LineSnap::None)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasLineSnap, reasons, includeReasons);
 if (style.textEmphasisFill() != TextEmphasisFill::Filled || style.textEmphasisMark() != TextEmphasisMark::None)
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasTextEmphasisFillOrMark, reasons, includeReasons);
 if (style.textShadow())
@@ -534,14 +528,22 @@
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasTextCombine, reasons, includeReasons);
 if (style.backgroundClip() == FillBox::Text)
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasTextFillBox, reasons, includeReasons);
-if (style.borderFit() == BorderFit::Lines)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasBorderFitLines, reasons, includeReasons);
-if (style.lineBreak() == LineBreak::AfterWhiteSpace)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasAfterWhiteSpaceLineBreak, reasons, includeReasons);
 // Special handling of text-security:disc is not yet implemented in the simple line layout code path.
 // See RenderBlock::updateSecurityDiscCharacters.
 if (style.textSecurity() != TextSecurity::None)
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasTextSecurity, reasons, includeReasons);
+
+// These are non-standard properties.
+if (style.lineBreak() == LineBreak::AfterWhiteSpace)
+SET_REASON_AND_RETURN_IF_NEEDED(FlowHasAfterWhiteSpaceLineBreak, reasons, includeReasons);
+if (!(style.lineBoxContain().contains(LineBoxContain::Block)))
+SET_REASON_AND_RETURN_IF_NEEDED(FlowHasLineBoxContainProperty, reasons, includeReasons);
+if (style.lineAlign() != LineAlign::None)
+SET_REASON_AND_RETURN_IF_NEEDED(FlowHasLineAlignEdges, reasons, includeReasons);
+if (style.lineSnap() != LineSnap::None)
+SET_REASON_AND_RETURN_IF_NEEDED(FlowHasLineSnap, reasons, includeReasons);
+if (style.borderFit() == BorderFit::Lines)
+SET_REASON_AND_RETURN_IF_NEEDED(FlowHasBorderFitLines, reasons, includeReasons);
 return reasons;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281381] trunk/LayoutTests

2021-08-21 Thread pvollan

Title: [281381] trunk/LayoutTests








Revision 281381
Author pvol...@apple.com
Date 2021-08-21 15:34:46 -0700 (Sat, 21 Aug 2021)


Log Message
[Win] The layout test http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=229372

Unreviewed test gardening.


* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281380 => 281381)

--- trunk/LayoutTests/ChangeLog	2021-08-21 22:04:40 UTC (rev 281380)
+++ trunk/LayoutTests/ChangeLog	2021-08-21 22:34:46 UTC (rev 281381)
@@ -1,3 +1,12 @@
+2021-08-21  Per Arne  
+
+[Win] The layout test http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is timing out
+https://bugs.webkit.org/show_bug.cgi?id=229372
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2021-08-21  Myles C. Maxfield  
 
 [Cocoa] Single characters don't get shaped in the fast text codepath


Modified: trunk/LayoutTests/platform/win/TestExpectations (281380 => 281381)

--- trunk/LayoutTests/platform/win/TestExpectations	2021-08-21 22:04:40 UTC (rev 281380)
+++ trunk/LayoutTests/platform/win/TestExpectations	2021-08-21 22:34:46 UTC (rev 281381)
@@ -4685,3 +4685,5 @@
 accessibility/element-line-rects-and-text.html [ Skip ]
 
 webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]
+
+webkit.org/b/229372 http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281380] trunk/Source

2021-08-21 Thread pvollan

Title: [281380] trunk/Source








Revision 281380
Author pvol...@apple.com
Date 2021-08-21 15:04:40 -0700 (Sat, 21 Aug 2021)


Log Message
[Win] Crash under FontCache::lastResortFallbackFont
https://bugs.webkit.org/show_bug.cgi?id=228186

Reviewed by Myles C. Maxfield.

Source/WebCore:

Add null check to resolve crash in FontCache::lastResortFallbackFont. Additionally, return early in BitmapImage::getHBITMAPOfSize
when the bits per pixel in the bitmap is of unexpected size, since that will cause a crash under this function. This can happen
if an event is being handled while already in the Windows paint handler.

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::lastResortFallbackFont):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::CGContextWithHDC):
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):

Source/WebKitLegacy/win:

Add null check for bitmapDC. Proceeding without a valid bitmapDC will cause a crash. When painting is being done while already in the Windows paint handler,
we can end up with a bitmapDC which is null.

* WebView.cpp:
(WebView::paintIntoBackingStore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp
trunk/Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp
trunk/Source/WebCore/platform/graphics/win/ImageCGWin.cpp
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281379 => 281380)

--- trunk/Source/WebCore/ChangeLog	2021-08-21 19:19:56 UTC (rev 281379)
+++ trunk/Source/WebCore/ChangeLog	2021-08-21 22:04:40 UTC (rev 281380)
@@ -1,3 +1,21 @@
+2021-08-21  Per Arne  
+
+[Win] Crash under FontCache::lastResortFallbackFont
+https://bugs.webkit.org/show_bug.cgi?id=228186
+
+Reviewed by Myles C. Maxfield.
+
+Add null check to resolve crash in FontCache::lastResortFallbackFont. Additionally, return early in BitmapImage::getHBITMAPOfSize
+when the bits per pixel in the bitmap is of unexpected size, since that will cause a crash under this function. This can happen
+if an event is being handled while already in the Windows paint handler.
+
+* platform/graphics/win/FontCacheWin.cpp:
+(WebCore::FontCache::lastResortFallbackFont):
+* platform/graphics/win/GraphicsContextCGWin.cpp:
+(WebCore::CGContextWithHDC):
+* platform/graphics/win/ImageCGWin.cpp:
+(WebCore::BitmapImage::getHBITMAPOfSize):
+
 2021-08-21  Myles C. Maxfield  
 
 [Cocoa] Single characters don't get shaped in the fast text codepath


Modified: trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp (281379 => 281380)

--- trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp	2021-08-21 19:19:56 UTC (rev 281379)
+++ trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp	2021-08-21 22:04:40 UTC (rev 281380)
@@ -420,8 +420,11 @@
 }
 });
 
-if (!fallbackFontName.get().isEmpty())
-return *fontForFamily(fontDescription, fallbackFontName);
+if (!fallbackFontName.get().isEmpty()) {
+auto fallbackFont = fontForFamily(fontDescription, fallbackFontName);
+if (fallbackFont)
+return *fallbackFont;
+}
 
 auto hFont = adoptGDIObject(static_cast(GetStockObject(DEFAULT_GUI_FONT)));
 FontPlatformData platformData(WTFMove(hFont), fontDescription.computedPixelSize(), false, false, false);


Modified: trunk/Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp (281379 => 281380)

--- trunk/Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp	2021-08-21 19:19:56 UTC (rev 281379)
+++ trunk/Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp	2021-08-21 22:04:40 UTC (rev 281380)
@@ -51,8 +51,10 @@
 // exit gracefully and look at it later:
 //  https://bugs.webkit.org/show_bug.cgi?id=52041   
 // ASSERT(bitmapBits.bitsPerPixel() == 32);
-if (pixelData.bitsPerPixel() != 32)
+if (pixelData.bitsPerPixel() != 32) {
+fprintf(stderr, "Invalid bits per pixel requested: %d hdc = %p", pixelData.bitsPerPixel(), hdc);
 return 0;
+}
 
 CGBitmapInfo bitmapInfo = kCGBitmapByteOrder32Little | (hasAlpha ? kCGImageAlphaPremultipliedFirst : kCGImageAlphaNoneSkipFirst);
 auto context = adoptCF(CGBitmapContextCreate(pixelData.buffer(), pixelData.size().width(), pixelData.size().height(), 8, pixelData.bytesPerRow(), sRGBColorSpaceRef(), bitmapInfo));


Modified: trunk/Source/WebCore/platform/graphics/win/ImageCGWin.cpp (281379 => 281380)

--- trunk/Source/WebCore/platform/graphics/win/ImageCGWin.cpp	2021-08-21 19:19:56 UTC (rev 281379)
+++ trunk/Source/WebCore/platform/graphics/win/ImageCGWin.cpp	2021-08-21 22:04:40 UTC (rev 281380)
@@ -68,6 +68,9 @@
 GetObject(bmp, sizeof(BITMAP), );
 
 ASSERT(bmpInfo.bmBitsPixel == 32);
+if (bmpInfo.bmBitsPixel != 32)
+return false;
+
 int bufferSize =

[webkit-changes] [281379] trunk/Tools

2021-08-21 Thread jbedard

Title: [281379] trunk/Tools








Revision 281379
Author jbed...@apple.com
Date 2021-08-21 12:19:56 -0700 (Sat, 21 Aug 2021)


Log Message
[git-webkit] Add pull-request command (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=229089


Reviewed by Dewei Zhu.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version, export pull-request.
* Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:
(PullRequest.State):
(PullRequest.create_body): Create pull-request body from commits and comment.
(PullRequest.parse_body): Turn a body from a pull-request into a comment string and partial commits.
(PullRequest.__init__):
(PullRequest.__repr__):
* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
(TestPullRequest):
(TestPullRequest.test_representation):
(TestPullRequest.test_create_body_single):
(TestPullRequest.test_parse_body_single):
(TestPullRequest.test_create_body_multiple):
(TestPullRequest.test_parse_body_multiple):
(TestPullRequest.test_create_body_empty):
(TestPullRequest.test_parse_body_empty):
(TestPullRequest.test_create_body_comment):
(TestPullRequest.test_parse_body_single):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py


Added Paths

trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (281378 => 281379)

--- trunk/Tools/ChangeLog	2021-08-21 19:18:51 UTC (rev 281378)
+++ trunk/Tools/ChangeLog	2021-08-21 19:19:56 UTC (rev 281379)
@@ -1,3 +1,31 @@
+2021-08-21  Jonathan Bedard  
+
+[git-webkit] Add pull-request command (Part 3)
+https://bugs.webkit.org/show_bug.cgi?id=229089
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version, export pull-request.
+* Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:
+(PullRequest.State):
+(PullRequest.create_body): Create pull-request body from commits and comment.
+(PullRequest.parse_body): Turn a body from a pull-request into a comment string and partial commits.
+(PullRequest.__init__):
+(PullRequest.__repr__):
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
+(TestPullRequest):
+(TestPullRequest.test_representation):
+(TestPullRequest.test_create_body_single):
+(TestPullRequest.test_parse_body_single):
+(TestPullRequest.test_create_body_multiple):
+(TestPullRequest.test_parse_body_multiple):
+(TestPullRequest.test_create_body_empty):
+(TestPullRequest.test_parse_body_empty):
+(TestPullRequest.test_create_body_comment):
+(TestPullRequest.test_parse_body_single):
+
 2021-08-21  Myles C. Maxfield  
 
 [Cocoa] Single characters don't get shaped in the fast text codepath


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (281378 => 281379)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-08-21 19:18:51 UTC (rev 281378)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-08-21 19:19:56 UTC (rev 281379)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='1.1.6',
+version='1.1.7',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (281378 => 281379)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-08-21 19:18:51 UTC (rev 281378)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-08-21 19:19:56 UTC (rev 281379)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(1, 1, 6)
+version = Version(1, 1, 7)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('monotonic', Version(1, 5)))
@@ -55,6 +55,7 @@
 
 from webkitscmpy.contributor import Contributor
 from webkitscmpy.commit import Commit
+from webkitscmpy.pull_request import PullRequest
 from webkitscmpy.scm_base import ScmBase
 
 from webkitscmpy import local


Added: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py (0 => 281379)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py	(rev 0)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py	2021-08-21 19:19:56 UTC (rev 281379)
@@ -0,0 +1,77 @@
+# Copyright (C) 2021 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+#

[webkit-changes] [281378] trunk

2021-08-21 Thread mmaxfield

Title: [281378] trunk








Revision 281378
Author mmaxfi...@apple.com
Date 2021-08-21 12:18:51 -0700 (Sat, 21 Aug 2021)


Log Message
[Cocoa] Single characters don't get shaped in the fast text codepath
https://bugs.webkit.org/show_bug.cgi?id=186804

Reviewed by Alan Bujtas.

Source/WebCore:

Previously, single characters weren't shaped in the fast text codepath,
because shaping in the fast text codepath was just for kerning and
ligatures. Kerning didn't need to shape individual characters because
kerning only applies to pairs of characters, and ligatures didn't need
to shape individual characters because two characters are required to
form a ligature. However, now that we want to replace the complex text
codepath with a new-and-improved fast text codepath, we have to perform
all shaping in the fast text codepath, regardless of how many characters
are present.

Test: fast/text/single-character-shaping.html

* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::commitCurrentFontRange):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::shouldApplyFontTransforms const): Deleted.
* platform/graphics/WidthIterator.h:
* platform/graphics/coretext/FontCoreText.cpp:
(WebCore::Font::applyTransforms): Keep kerning disabled for single glyphs,
because of performance. This will be able to be removed when rdar://82195405
is fixed.
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):

Tools:

Huge thanks to Laurence Penney to contributing this test font!!!

* Scripts/webkitpy/common/config/contributors.json:

LayoutTests:

Huge thanks to Laurence Penney to contributing this test font!!!

* fast/text/resources/UniversTofu-GSUB-rvrn.ttf: Added. The license is Apache 2.0.
* fast/text/single-character-shaping-expected.html: Added.
* fast/text/single-character-shaping.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/WidthIterator.cpp
trunk/Source/WebCore/platform/graphics/WidthIterator.h
trunk/Source/WebCore/platform/graphics/coretext/FontCoreText.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json


Added Paths

trunk/LayoutTests/fast/text/resources/UniversTofu-GSUB-rvrn.ttf
trunk/LayoutTests/fast/text/single-character-shaping-expected.html
trunk/LayoutTests/fast/text/single-character-shaping.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281377 => 281378)

--- trunk/LayoutTests/ChangeLog	2021-08-21 18:19:40 UTC (rev 281377)
+++ trunk/LayoutTests/ChangeLog	2021-08-21 19:18:51 UTC (rev 281378)
@@ -1,3 +1,16 @@
+2021-08-21  Myles C. Maxfield  
+
+[Cocoa] Single characters don't get shaped in the fast text codepath
+https://bugs.webkit.org/show_bug.cgi?id=186804
+
+Reviewed by Alan Bujtas.
+
+Huge thanks to Laurence Penney to contributing this test font!!!
+
+* fast/text/resources/UniversTofu-GSUB-rvrn.ttf: Added. The license is Apache 2.0.
+* fast/text/single-character-shaping-expected.html: Added.
+* fast/text/single-character-shaping.html: Added.
+
 2021-08-21  Yusuke Suzuki  
 
 [JSC] Enable Array#findLast method


Added: trunk/LayoutTests/fast/text/resources/UniversTofu-GSUB-rvrn.ttf (0 => 281378)

--- trunk/LayoutTests/fast/text/resources/UniversTofu-GSUB-rvrn.ttf	(rev 0)
+++ trunk/LayoutTests/fast/text/resources/UniversTofu-GSUB-rvrn.ttf	2021-08-21 19:18:51 UTC (rev 281378)
@@ -0,0 +1,24 @@
+ÀÀÀÀÀ\x80ÀÀpDSIGÀÀÀÀÀ4ÀÀÀGSUB@D\xDF\xDEÀÀTÀÀ0OS/2hg\xBCÀÀxÀÀÀ`STAT\xF0\xF9\xDD\xF6ÀÀ\x84ÀÀÀ$cmaps\xD0ÀÀ\xD0ÀÀÀZfvar\xF6\xDE\xFFÀÀ\xA8ÀÀÀ8glyfI8\xC7\xE1ÀÀ\xB8ÀÀÀ\xECgvarT32DÀÀ\xE0ÀÀTheadOL\xB0ÀÀÀ\xFCÀÀÀ6hhea\xF2ÀÀ4ÀÀÀ$hmtx\x83+À\xE9ÀÀ\xD8ÀÀÀ\xF8loca\xE4\xE4ÀÀ,ÀÀÀ\x8AmaxpÀ\xB5À6ÀÀXÀÀÀ name\x96o\xCFDÀÀ\xA4ÀÀ\xFFpost5\x8Dz$ÀÀ\xA4ÀÀÀ\xB0ÀÀÀÀÀÀ\xC1\xFEt_<\xF5À\xE8ÀÀÀÀ\xD6\xF2f2ÀÀÀÀ\xD6\xF2\xA2\xE6ÀK\xFF\xF8\xBCÀÀÀÀÀÀÀÀÀÀÀÀÀ\xE8\xFF8ÀÀXÀÀÀKÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀ8ÀÀÀÀDÀÀÀÀÀÀÀÀÀÀÀÀÀdÀÀÀÀÀÀÀW\x90ÀÀ\x8AXÀÀÀK\x8AXÀÀ^À2,ÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀUKWNÀ@À Àz \xFF8À\xC8\xE8À\xC8ÀÀÀÀÀÀÀ\xF4\xBCÀÀÀ ÀSÀKXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀ
 XÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀXÀÀMÀSXÀÀXÀÀXÀÀXÀÀXÀÀSÀKXÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀÀFÀÀÀÀÀÀÀ À.À9ÀZÀz\xFF\xFFÀÀÀ

[webkit-changes] [281377] trunk/Source/WebCore

2021-08-21 Thread zalan

Title: [281377] trunk/Source/WebCore








Revision 281377
Author za...@apple.com
Date 2021-08-21 11:19:40 -0700 (Sat, 21 Aug 2021)


Log Message
[IFC][Integration] Add painting support for vertical text content
https://bugs.webkit.org/show_bug.cgi?id=228940

Reviewed by Antti Koivisto.

Translate the logical layout coordinates to physical paint coordinates by taking the writing mode into account.
(e.g. writing-mode: vertical-rl;
  run logical rect: [0, 0][20x18]
  in a flipped block box: [10, 10][100x50]
  with the paint offset: [8, 8]

  translates to: [90, 8][20x18]
)

* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::paintTextRunUsingPhysicalCoordinates):
* layout/integration/LayoutIntegrationLineLayout.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (281376 => 281377)

--- trunk/Source/WebCore/ChangeLog	2021-08-21 18:15:15 UTC (rev 281376)
+++ trunk/Source/WebCore/ChangeLog	2021-08-21 18:19:40 UTC (rev 281377)
@@ -1,3 +1,24 @@
+2021-08-21  Alan Bujtas  
+
+[IFC][Integration] Add painting support for vertical text content
+https://bugs.webkit.org/show_bug.cgi?id=228940
+
+Reviewed by Antti Koivisto.
+
+Translate the logical layout coordinates to physical paint coordinates by taking the writing mode into account.
+(e.g. writing-mode: vertical-rl;
+  run logical rect: [0, 0][20x18]
+  in a flipped block box: [10, 10][100x50]
+  with the paint offset: [8, 8]
+
+  translates to: [90, 8][20x18]
+)
+
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::paint):
+(WebCore::LayoutIntegration::LineLayout::paintTextRunUsingPhysicalCoordinates):
+* layout/integration/LayoutIntegrationLineLayout.h:
+
 2021-08-21  Zalan Bujtas  
 
 [IFC][Integration] Do not scan the content for overflowing glyph when line-box-contain is set to glyph


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (281376 => 281377)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2021-08-21 18:15:15 UTC (rev 281376)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2021-08-21 18:19:40 UTC (rev 281377)
@@ -454,71 +454,17 @@
 if (paintInfo.phase != PaintPhase::Foreground && paintInfo.phase != PaintPhase::EventRegion)
 return;
 
-auto& inlineContent = *m_inlineContent;
-float deviceScaleFactor = flow().document().deviceScaleFactor();
-
 auto paintRect = paintInfo.rect;
 paintRect.moveBy(-paintOffset);
 
-for (auto& run : inlineContent.runsForRect(paintRect)) {
-if (!run.textContent()) {
-auto& renderer = m_boxTree.rendererForLayoutBox(run.layoutBox());
-if (renderer.isReplaced() && is(renderer)) {
-auto& renderBox = downcast(renderer);
-if (renderBox.hasSelfPaintingLayer())
-continue;
-if (!paintInfo.shouldPaintWithinRoot(renderBox))
-continue;
+for (auto& run : m_inlineContent->runsForRect(paintRect)) {
+if (run.textContent())
+paintTextRunUsingPhysicalCoordinates(paintInfo, paintOffset, m_inlineContent->lineForRun(run), run);
+else if (auto& renderer = m_boxTree.rendererForLayoutBox(run.layoutBox()); is(renderer) && renderer.isReplaced()) {
+auto& renderBox = downcast(renderer);
+if (!renderBox.hasSelfPaintingLayer() && paintInfo.shouldPaintWithinRoot(renderBox))
 renderBox.paintAsInlineBlock(paintInfo, paintOffset);
-}
-continue;
 }
-
-auto& textContent = *run.textContent();
-if (!textContent.length())
-continue;
-
-auto& style = run.style();
-if (style.visibility() != Visibility::Visible)
-continue;
-
-auto rect = FloatRect { run.rect() };
-auto visualOverflowRect = FloatRect { run.inkOverflow() };
-if (paintRect.y() > visualOverflowRect.maxY() || paintRect.maxY() < visualOverflowRect.y())
-continue;
-
-if (paintInfo.eventRegionContext) {
-if (style.pointerEvents() != PointerEvents::None) {
-visualOverflowRect.moveBy(paintOffset);
-paintInfo.eventRegionContext->unite(enclosingIntRect(visualOverflowRect), style);
-}
-continue;
-}
-
-auto& line = inlineContent.lineForRun(run);
-auto expansion = run.expansion();
-// TextRun expects the xPos to be adjusted with the aligment offset (e.g. when the line is center aligned
-// and the run starts at 100px, due to the

[webkit-changes] [281376] trunk/Source

2021-08-21 Thread simon . fraser

Title: [281376] trunk/Source








Revision 281376
Author simon.fra...@apple.com
Date 2021-08-21 11:15:15 -0700 (Sat, 21 Aug 2021)


Log Message
Use MediaKeySystemRequestIdentifier, rather than mysterious uint64_t values, in WebKit
https://bugs.webkit.org/show_bug.cgi?id=229310

Reviewed by Youenn Fablet.

WebCore already had an ObjectIdentifer<> type for media system key requests, MediaKeySystemRequestIdentifier.
Use it in the WebKit layer.

* Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
(headers_for_type):
* UIProcess/MediaKeySystemPermissionRequestManagerProxy.cpp:
(WebKit::MediaKeySystemPermissionRequestManagerProxy::denyRequest):
(WebKit::MediaKeySystemPermissionRequestManagerProxy::grantRequest):
(WebKit::MediaKeySystemPermissionRequestManagerProxy::createRequestForFrame):
* UIProcess/MediaKeySystemPermissionRequestManagerProxy.h:
* UIProcess/MediaKeySystemPermissionRequestProxy.cpp:
(WebKit::MediaKeySystemPermissionRequestProxy::MediaKeySystemPermissionRequestProxy):
* UIProcess/MediaKeySystemPermissionRequestProxy.h:
(WebKit::MediaKeySystemPermissionRequestProxy::create):
(WebKit::MediaKeySystemPermissionRequestProxy::mediaKeySystemID const):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestMediaKeySystemPermissionForFrame):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp:
(WebKit::MediaKeySystemPermissionRequestManager::sendMediaKeySystemRequest):
(WebKit::MediaKeySystemPermissionRequestManager::mediaKeySystemWasGranted):
(WebKit::MediaKeySystemPermissionRequestManager::mediaKeySystemWasDenied):
* WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mediaKeySystemWasGranted):
(WebKit::WebPage::mediaKeySystemWasDenied):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Modified Paths

trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/UIProcess/MediaKeySystemPermissionRequestManagerProxy.cpp
trunk/Source/WebKit/UIProcess/MediaKeySystemPermissionRequestManagerProxy.h
trunk/Source/WebKit/UIProcess/MediaKeySystemPermissionRequestProxy.cpp
trunk/Source/WebKit/UIProcess/MediaKeySystemPermissionRequestProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp
trunk/Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in


Added Paths

trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequestIdentifier.h




Diff

Modified: trunk/Source/WebCore/Headers.cmake (281375 => 281376)

--- trunk/Source/WebCore/Headers.cmake	2021-08-21 16:17:02 UTC (rev 281375)
+++ trunk/Source/WebCore/Headers.cmake	2021-08-21 18:15:15 UTC (rev 281376)
@@ -27,6 +27,7 @@
 Modules/encryptedmedia/MediaKeySystemClient.h
 Modules/encryptedmedia/MediaKeySystemController.h
 Modules/encryptedmedia/MediaKeySystemRequest.h
+Modules/encryptedmedia/MediaKeySystemRequestIdentifier.h
 
 Modules/fetch/FetchBodyConsumer.h
 Modules/fetch/FetchBodySource.h


Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h (281375 => 281376)

--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h	2021-08-21 16:17:02 UTC (rev 281375)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h	2021-08-21 18:15:15 UTC (rev 281376)
@@ -29,6 +29,7 @@
 #include "ActiveDOMObject.h"
 #include "IDLTypes.h"
 #include "JSDOMPromiseDeferred.h"
+#include "MediaKeySystemRequestIdentifier.h"
 #include 
 #include 
 #include 
@@ -41,9 +42,6 @@
 
 template  class DOMPromiseDeferred;
 
-enum MediaKeySystemRequestIdentifierType { };
-using MediaKeySystemRequestIdentifier = ObjectIdentifier;
-
 class MediaKeySystemRequest : public RefCounted, public ActiveDOMObject {
 public:
 WEBCORE_EXPORT static Ref create(Document&, const String& keySystem, Ref&&);


Added: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequestIdentifier.h (0 => 281376)

--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequestIdentifier.h	(rev 0)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequestIdentifier.h	2021-08-21 18:15:15 UTC (rev 281376)
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2021 Apple Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1.  Redistributions of

[webkit-changes] [281375] trunk

2021-08-21 Thread ysuzuki

Title: [281375] trunk








Revision 281375
Author ysuz...@apple.com
Date 2021-08-21 09:17:02 -0700 (Sat, 21 Aug 2021)


Log Message
[JSC] Intl.DisplayNames v2
https://bugs.webkit.org/show_bug.cgi?id=227832

Reviewed by Ross Kirsling.

JSTests:

* stress/intl-displaynames-v2.js: Added.
(shouldBe):
(shouldThrow):
(vm.icuVersion):
* stress/intl-displaynames.js:
(vm.icuVersion):
* test262/config.yaml:
* test262/expectations.yaml:

Source/_javascript_Core:

This patch implements Intl.DisplayNames v2[1].
Newly added names are calendar names and date time field names.
For the language name, language display option is added.

[1]: https://github.com/tc39/intl-displaynames-v2

* runtime/CommonIdentifiers.h:
* runtime/IntlCache.cpp:
(JSC::IntlCache::getFieldDisplayName):
* runtime/IntlCache.h:
* runtime/IntlDisplayNames.cpp:
(JSC::IntlDisplayNames::initializeDisplayNames):
(JSC::IntlDisplayNames::of const):
(JSC::IntlDisplayNames::resolvedOptions const):
(JSC::IntlDisplayNames::typeString):
(JSC::IntlDisplayNames::languageDisplayString):
* runtime/IntlDisplayNames.h:
* runtime/IntlObject.cpp:
(JSC::isUnicodeLocaleIdentifierType):
(JSC::canonicalizeUnicodeLocaleID):
(JSC::canonicalizeLocaleList):
(JSC::defaultLocale):
(JSC::mapBCP47ToICUCalendarKeyword):
(JSC::mapICUCollationKeywordToBCP47):
(JSC::canonicalizeLanguageTag): Deleted.
* runtime/IntlObject.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/intl-displaynames.js
trunk/JSTests/test262/config.yaml
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/CommonIdentifiers.h
trunk/Source/_javascript_Core/runtime/IntlCache.cpp
trunk/Source/_javascript_Core/runtime/IntlCache.h
trunk/Source/_javascript_Core/runtime/IntlDisplayNames.cpp
trunk/Source/_javascript_Core/runtime/IntlDisplayNames.h
trunk/Source/_javascript_Core/runtime/IntlObject.cpp
trunk/Source/_javascript_Core/runtime/IntlObject.h


Added Paths

trunk/JSTests/stress/intl-displaynames-v2.js




Diff

Modified: trunk/JSTests/ChangeLog (281374 => 281375)

--- trunk/JSTests/ChangeLog	2021-08-21 14:33:08 UTC (rev 281374)
+++ trunk/JSTests/ChangeLog	2021-08-21 16:17:02 UTC (rev 281375)
@@ -1,5 +1,21 @@
 2021-08-21  Yusuke Suzuki  
 
+[JSC] Intl.DisplayNames v2
+https://bugs.webkit.org/show_bug.cgi?id=227832
+
+Reviewed by Ross Kirsling.
+
+* stress/intl-displaynames-v2.js: Added.
+(shouldBe):
+(shouldThrow):
+(vm.icuVersion):
+* stress/intl-displaynames.js:
+(vm.icuVersion):
+* test262/config.yaml:
+* test262/expectations.yaml:
+
+2021-08-21  Yusuke Suzuki  
+
 [JSC] Intl Locale Info
 https://bugs.webkit.org/show_bug.cgi?id=227830
 


Added: trunk/JSTests/stress/intl-displaynames-v2.js (0 => 281375)

--- trunk/JSTests/stress/intl-displaynames-v2.js	(rev 0)
+++ trunk/JSTests/stress/intl-displaynames-v2.js	2021-08-21 16:17:02 UTC (rev 281375)
@@ -0,0 +1,121 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+function shouldThrow(func, errorMessage) {
+var errorThrown = false;
+var error = null;
+try {
+func();
+} catch (e) {
+errorThrown = true;
+error = e;
+}
+if (!errorThrown)
+throw new Error('not thrown');
+if (String(error) !== errorMessage)
+throw new Error(`bad error: ${String(error)}`);
+}
+
+if ($vm.icuVersion() >= 61) {
+{
+let displayNames = new Intl.DisplayNames(undefined, {type: 'calendar'});
+shouldThrow(() => {
+displayNames.of('');
+}, `RangeError: argument is not a calendar code`);
+shouldThrow(() => {
+displayNames.of('-');
+}, `RangeError: argument is not a calendar code`);
+shouldThrow(() => {
+displayNames.of('a-');
+}, `RangeError: argument is not a calendar code`);
+shouldThrow(() => {
+displayNames.of('_');
+}, `RangeError: argument is not a calendar code`);
+shouldThrow(() => {
+displayNames.of('a_');
+}, `RangeError: argument is not a calendar code`); }
+{
+let dn = new Intl.DisplayNames("en", {type: "calendar"})
+shouldBe(dn.of("roc"), "Minguo Calendar");
+shouldBe(dn.of("persian"), "Persian Calendar");
+shouldBe(dn.of("gregory"), "Gregorian Calendar");
+shouldBe(dn.of("ethioaa"), "Ethiopic Amete Alem Calendar");
+shouldBe(dn.of("japanese"), "Japanese Calendar");
+shouldBe(dn.of("dangi"), "Dangi Calendar");
+shouldBe(dn.of("chinese"), "Chinese Calendar");
+}
+{
+let dn = new Intl.DisplayNames("zh", {type: "calendar"})
+shouldBe(dn.of("roc"), "民国纪年");
+shouldBe(dn.of("persian"), "波斯历");
+shouldBe(dn.of("gregory"), "公历");
+shouldBe(dn.of("ethioaa"), "埃塞俄比亚阿米特阿莱姆日历");
+

[webkit-changes] [281374] trunk

2021-08-21 Thread ysuzuki

Title: [281374] trunk








Revision 281374
Author ysuz...@apple.com
Date 2021-08-21 07:33:08 -0700 (Sat, 21 Aug 2021)


Log Message
[JSC] Intl Locale Info
https://bugs.webkit.org/show_bug.cgi?id=227830

Reviewed by Ross Kirsling.

JSTests:

* stress/intl-locale-info.js: Added.
(shouldBe):
(throw.new.Error):
(let.enGB.new.Intl.Locale.shouldBe):
(let.l.new.Intl.Locale.shouldBe):
* test262/config.yaml:

Source/_javascript_Core:

This patch implements Intl.Locale's extension (Intl Locale Info proposal)[1], which is already stage 3.
Intl.Locale#{calendars,collations,hourCycles,numberingSystems,timeZones} can return array of preferred
configuration for the given locale. And Intl.Locale#textInfo can return text layout direction and Intl.Locale#weekInfo
can return weekday information (e.g. when weekend starts).

[1]: https://github.com/tc39/proposal-intl-locale-info

* runtime/IntlLocale.cpp:
(JSC::createArrayFromStringVector):
(JSC::IntlLocale::calendars):
(JSC::IntlLocale::collations):
(JSC::IntlLocale::hourCycles):
(JSC::IntlLocale::numberingSystems):
(JSC::IntlLocale::timeZones):
(JSC::IntlLocale::textInfo):
(JSC::IntlLocale::weekInfo):
* runtime/IntlLocale.h:
* runtime/IntlLocalePrototype.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/config.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/IntlCollator.cpp
trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp
trunk/Source/_javascript_Core/runtime/IntlLocale.cpp
trunk/Source/_javascript_Core/runtime/IntlLocale.h
trunk/Source/_javascript_Core/runtime/IntlLocalePrototype.cpp
trunk/Source/_javascript_Core/runtime/IntlObject.cpp
trunk/Source/_javascript_Core/runtime/IntlObject.h


Added Paths

trunk/JSTests/stress/intl-locale-info.js




Diff

Modified: trunk/JSTests/ChangeLog (281373 => 281374)

--- trunk/JSTests/ChangeLog	2021-08-21 13:49:32 UTC (rev 281373)
+++ trunk/JSTests/ChangeLog	2021-08-21 14:33:08 UTC (rev 281374)
@@ -1,5 +1,19 @@
 2021-08-21  Yusuke Suzuki  
 
+[JSC] Intl Locale Info
+https://bugs.webkit.org/show_bug.cgi?id=227830
+
+Reviewed by Ross Kirsling.
+
+* stress/intl-locale-info.js: Added.
+(shouldBe):
+(throw.new.Error):
+(let.enGB.new.Intl.Locale.shouldBe):
+(let.l.new.Intl.Locale.shouldBe):
+* test262/config.yaml:
+
+2021-08-21  Yusuke Suzuki  
+
 [JSC] Extend Intl TimeZoneName Option
 https://bugs.webkit.org/show_bug.cgi?id=227831
 


Added: trunk/JSTests/stress/intl-locale-info.js (0 => 281374)

--- trunk/JSTests/stress/intl-locale-info.js	(rev 0)
+++ trunk/JSTests/stress/intl-locale-info.js	2021-08-21 14:33:08 UTC (rev 281374)
@@ -0,0 +1,106 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error(`expected ${expected} but got ${actual}`);
+}
+
+{
+let he = new Intl.Locale("he")
+shouldBe(JSON.stringify(he.weekInfo), `{"firstDay":7,"weekendStart":5,"weekendEnd":6,"minimalDays":1}`);
+let af = new Intl.Locale("af")
+shouldBe(JSON.stringify(af.weekInfo), `{"firstDay":7,"weekendStart":6,"weekendEnd":7,"minimalDays":1}`);
+let enGB = new Intl.Locale("en-GB")
+shouldBe(JSON.stringify(enGB.weekInfo), `{"firstDay":1,"weekendStart":6,"weekendEnd":7,"minimalDays":4}`);
+}
+{
+let l = new Intl.Locale("ar")
+shouldBe(JSON.stringify(l.textInfo), `{"direction":"rtl"}`);
+}
+{
+let locale = new Intl.Locale("ar")
+shouldBe(JSON.stringify(locale.calendars), `["gregory","coptic","islamic","islamicc","islamic-tbla"]`);
+shouldBe(JSON.stringify(locale.collations), `["compat","emoji","eor"]`);
+shouldBe(JSON.stringify(locale.hourCycles), `["h12"]`);
+let ns = JSON.stringify(locale.numberingSystems);
+shouldBe(ns === `["arab"]` || ns === `["latn"]`, true);
+shouldBe(locale.timeZones, undefined);
+}
+{
+let locale = new Intl.Locale("ar-EG")
+shouldBe(JSON.stringify(locale.calendars), `["gregory","coptic","islamic","islamicc","islamic-tbla"]`);
+shouldBe(JSON.stringify(locale.collations), `["compat","emoji","eor"]`);
+shouldBe(JSON.stringify(locale.hourCycles), `["h12"]`);
+shouldBe(JSON.stringify(locale.numberingSystems), `["arab"]`);
+shouldBe(JSON.stringify(locale.timeZones), `["Africa/Cairo"]`);
+}
+{
+let locale = new Intl.Locale("ar-SA")
+shouldBe(JSON.stringify(locale.calendars), `["islamic-umalqura","islamic-rgsa","islamic","gregory"]`);
+shouldBe(JSON.stringify(locale.collations), `["compat","emoji","eor"]`);
+shouldBe(JSON.stringify(locale.hourCycles), `["h12"]`);
+shouldBe(JSON.stringify(locale.numberingSystems), `["arab"]`);
+shouldBe(JSON.stringify(locale.timeZones), `["Asia/Riyadh"]`);
+}
+{
+let locale = new Intl.Locale("ja")
+shouldBe(JSON.stringify(locale.calendars), `["gregory","japanese"]`);
+shouldBe(JSON.stringify(locale.collations), `["unihan","emoji","eor"]`);
+

[webkit-changes] [281373] trunk/Source/WebCore

2021-08-21 Thread zalan

Title: [281373] trunk/Source/WebCore








Revision 281373
Author za...@apple.com
Date 2021-08-21 06:49:32 -0700 (Sat, 21 Aug 2021)


Log Message
[IFC][Integration] Do not scan the content for overflowing glyph when line-box-contain is set to glyph
https://bugs.webkit.org/show_bug.cgi?id=228895


Reviewed by Antti Koivisto.

This is in preparation for removing content scanning completely.

* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForText):
(WebCore::LayoutIntegration::canUseForFontAndText):
* layout/integration/LayoutIntegrationCoverage.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (281372 => 281373)

--- trunk/Source/WebCore/ChangeLog	2021-08-21 13:42:48 UTC (rev 281372)
+++ trunk/Source/WebCore/ChangeLog	2021-08-21 13:49:32 UTC (rev 281373)
@@ -1,5 +1,21 @@
 2021-08-21  Zalan Bujtas  
 
+[IFC][Integration] Do not scan the content for overflowing glyph when line-box-contain is set to glyph
+https://bugs.webkit.org/show_bug.cgi?id=228895
+
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for removing content scanning completely. 
+
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::printReason):
+(WebCore::LayoutIntegration::canUseForText):
+(WebCore::LayoutIntegration::canUseForFontAndText):
+* layout/integration/LayoutIntegrationCoverage.h:
+
+2021-08-21  Zalan Bujtas  
+
 Fix spelling: MidWorkdBreak -> MidWordBreak
 
 Unreviewed.


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (281372 => 281373)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-08-21 13:42:48 UTC (rev 281372)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-08-21 13:49:32 UTC (rev 281373)
@@ -204,8 +204,8 @@
 case AvoidanceReason::FlowChildIsSelected:
 stream << "selected content";
 break;
-case AvoidanceReason::FlowFontHasOverflowGlyph:
-stream << "-webkit-line-box-contain: glyphs with overflowing text.";
+case AvoidanceReason::FlowHasLineBoxContainGlyphs:
+stream << "-webkit-line-box-contain: glyphs";
 break;
 case AvoidanceReason::FlowTextHasSurrogatePair:
 stream << "surrogate pair";
@@ -436,18 +436,10 @@
 }
 
 template 
-static OptionSet canUseForText(const CharacterType* text, unsigned length, const FontCascade& fontCascade, std::optional lineHeightConstraint, IncludeReasons includeReasons)
+static OptionSet canUseForText(const CharacterType* text, unsigned length, const FontCascade& fontCascade, IncludeReasons includeReasons)
 {
 OptionSet reasons;
 auto& primaryFont = fontCascade.primaryFont();
-auto& fontMetrics = primaryFont.fontMetrics();
-auto availableSpaceForGlyphAscent = fontMetrics.ascent();
-auto availableSpaceForGlyphDescent = fontMetrics.descent();
-if (lineHeightConstraint) {
-auto lineHeightPadding = *lineHeightConstraint - fontMetrics.height();
-availableSpaceForGlyphAscent += lineHeightPadding / 2;
-availableSpaceForGlyphDescent += lineHeightPadding / 2;
-}
 
 for (unsigned i = 0; i < length; ++i) {
 auto character = text[i];
@@ -458,21 +450,15 @@
 auto glyphData = fontCascade.glyphDataForCharacter(character, false);
 if (!glyphData.isValid() || glyphData.font != )
 SET_REASON_AND_RETURN_IF_NEEDED(FlowPrimaryFontIsInsufficient, reasons, includeReasons);
-
-if (lineHeightConstraint) {
-auto bounds = primaryFont.boundsForGlyph(glyphData.glyph);
-if (ceilf(-bounds.y()) > availableSpaceForGlyphAscent || ceilf(bounds.maxY()) > availableSpaceForGlyphDescent)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowFontHasOverflowGlyph, reasons, includeReasons);
-}
 }
 return reasons;
 }
 
-static OptionSet canUseForText(StringView text, const FontCascade& fontCascade, std::optional lineHeightConstraint, IncludeReasons includeReasons)
+static OptionSet canUseForText(StringView text, const FontCascade& fontCascade, IncludeReasons includeReasons)
 {
 if (text.is8Bit())
-return canUseForText(text.characters8(), text.length(), fontCascade, lineHeightConstraint, includeReasons);
-return canUseForText(text.characters16(), text.length(), fontCascade, lineHeightConstraint, includeReasons);
+return canUseForText(text.characters8(), text.length(), fontCascade, includeReasons);
+return canUseForText(text.characters16(), text.length(), fontCascade, includeReasons);
 }
 
 static OptionSet canUseForFontAndText(const RenderBoxModelObject& container, IncludeReasons includeReasons)
@@ -483,9 +469,8 @@

[webkit-changes] [281372] trunk/Source/WebCore

2021-08-21 Thread zalan

Title: [281372] trunk/Source/WebCore








Revision 281372
Author za...@apple.com
Date 2021-08-21 06:42:48 -0700 (Sat, 21 Aug 2021)


Log Message
Fix spelling: MidWorkdBreak -> MidWordBreak

Unreviewed.


* layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::tryBreakingTextRun const):
* layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::midWordBreak):
(WebCore::Layout::TextUtil::midWorkdBreak): Deleted.
* layout/formattingContexts/inline/text/TextUtil.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (281371 => 281372)

--- trunk/Source/WebCore/ChangeLog	2021-08-21 13:02:32 UTC (rev 281371)
+++ trunk/Source/WebCore/ChangeLog	2021-08-21 13:42:48 UTC (rev 281372)
@@ -1,3 +1,16 @@
+2021-08-21  Zalan Bujtas  
+
+Fix spelling: MidWorkdBreak -> MidWordBreak
+
+Unreviewed.
+
+* layout/formattingContexts/inline/InlineContentBreaker.cpp:
+(WebCore::Layout::InlineContentBreaker::tryBreakingTextRun const):
+* layout/formattingContexts/inline/text/TextUtil.cpp:
+(WebCore::Layout::TextUtil::midWordBreak):
+(WebCore::Layout::TextUtil::midWorkdBreak): Deleted.
+* layout/formattingContexts/inline/text/TextUtil.h:
+
 2021-08-21  Youenn Fablet  
 
 Prevent AudioSession category from moving out of PlayAndRecord too quickly


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp (281371 => 281372)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp	2021-08-21 13:02:32 UTC (rev 281371)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp	2021-08-21 13:42:48 UTC (rev 281372)
@@ -459,7 +459,7 @@
 auto availableWidthExcludingHyphen = *availableWidth - hyphenWidth;
 if (availableWidthExcludingHyphen <= 0 || !enoughWidthForHyphenation(availableWidthExcludingHyphen, fontCascade.pixelSize()))
 return { };
-leftSideLength = TextUtil::midWorkdBreak(inlineTextItem, overflowingRun.logicalWidth, availableWidthExcludingHyphen, logicalLeft).length;
+leftSideLength = TextUtil::midWordBreak(inlineTextItem, overflowingRun.logicalWidth, availableWidthExcludingHyphen, logicalLeft).length;
 }
 if (leftSideLength < limitBefore)
 return { };
@@ -493,8 +493,8 @@
 // Fast path for cases when there's no room at all. The content is breakable but we don't have space for it.
 return { };
 }
-auto midWorkdBreak = TextUtil::midWorkdBreak(inlineTextItem, overflowingRun.logicalWidth, *availableWidth, logicalLeft);
-return { midWorkdBreak.length, midWorkdBreak.logicalWidth };
+auto midWordBreak = TextUtil::midWordBreak(inlineTextItem, overflowingRun.logicalWidth, *availableWidth, logicalLeft);
+return { midWordBreak.length, midWordBreak.logicalWidth };
 };
 // With arbitrary breaking there's always a valid breaking position (even if it is before the first position).
 return tryBreakingAtArbitraryPosition();


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp (281371 => 281372)

--- trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp	2021-08-21 13:02:32 UTC (rev 281371)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp	2021-08-21 13:42:48 UTC (rev 281372)
@@ -84,7 +84,7 @@
 return std::isnan(width) ? 0.0f : std::isinf(width) ? maxInlineLayoutUnit() : width;
 }
 
-TextUtil::MidWorkdBreak TextUtil::midWorkdBreak(const InlineTextItem& inlineTextItem, InlineLayoutUnit textWidth, InlineLayoutUnit availableWidth, InlineLayoutUnit contentLogicalLeft)
+TextUtil::MidWordBreak TextUtil::midWordBreak(const InlineTextItem& inlineTextItem, InlineLayoutUnit textWidth, InlineLayoutUnit availableWidth, InlineLayoutUnit contentLogicalLeft)
 {
 ASSERT(availableWidth >= 0);
 auto startPosition = inlineTextItem.start();


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h (281371 => 281372)

--- trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h	2021-08-21 13:02:32 UTC (rev 281371)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h	2021-08-21 13:42:48 UTC (rev 281372)
@@ -46,12 +46,12 @@
 static InlineLayoutUnit width(const InlineTextItem&, unsigned from, unsigned to, InlineLayoutUnit contentLogicalLeft);
 static InlineLayoutUnit width(const InlineTextBox&, unsigned from, unsigned to, InlineLayoutUnit contentLogicalLeft);
 
-struct MidWorkdBreak {
+struct

[webkit-changes] [281371] trunk

2021-08-21 Thread ysuzuki

Title: [281371] trunk








Revision 281371
Author ysuz...@apple.com
Date 2021-08-21 06:02:32 -0700 (Sat, 21 Aug 2021)


Log Message
[JSC] Extend Intl TimeZoneName Option
https://bugs.webkit.org/show_bug.cgi?id=227831

Reviewed by Ross Kirsling.

JSTests:

* stress/intl-extended-timezone-names.js: Added.
(shouldBe):
(timeZoneTest):
* test262/config.yaml:

Source/_javascript_Core:

https://github.com/tc39/proposal-intl-extend-timezonename

This patch implements Extend Intl TimeZoneName proposal, which adds "shortOffset", "longOffset", "shortGeneric", "longGeneric"
timeZoneName variants.

* runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::timeZoneNameString):
* runtime/IntlDateTimeFormat.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/config.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp
trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.h


Added Paths

trunk/JSTests/stress/intl-extended-timezone-names.js




Diff

Modified: trunk/JSTests/ChangeLog (281370 => 281371)

--- trunk/JSTests/ChangeLog	2021-08-21 12:28:04 UTC (rev 281370)
+++ trunk/JSTests/ChangeLog	2021-08-21 13:02:32 UTC (rev 281371)
@@ -1,5 +1,17 @@
 2021-08-21  Yusuke Suzuki  
 
+[JSC] Extend Intl TimeZoneName Option
+https://bugs.webkit.org/show_bug.cgi?id=227831
+
+Reviewed by Ross Kirsling.
+
+* stress/intl-extended-timezone-names.js: Added.
+(shouldBe):
+(timeZoneTest):
+* test262/config.yaml:
+
+2021-08-21  Yusuke Suzuki  
+
 [JSC] Enable Array#findLast method
 https://bugs.webkit.org/show_bug.cgi?id=229355
 


Added: trunk/JSTests/stress/intl-extended-timezone-names.js (0 => 281371)

--- trunk/JSTests/stress/intl-extended-timezone-names.js	(rev 0)
+++ trunk/JSTests/stress/intl-extended-timezone-names.js	2021-08-21 13:02:32 UTC (rev 281371)
@@ -0,0 +1,75 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error("bad value: " + actual);
+}
+
+let timeZoneNames = ["short", "long", "shortOffset", "longOffset", "shortGeneric", "longGeneric"];
+let date = new Date(1625939282389);
+
+function timeZoneTest(date, locale, expectedSet, timeZone = "America/Los_Angeles")
+{
+timeZoneNames.forEach(function(timeZoneName) {
+let formatter = new Intl.DateTimeFormat(locale, {
+year: "numeric",
+month: "numeric",
+day: "numeric",
+hour: "2-digit",
+minute: "2-digit",
+second: "2-digit",
+timeZone,
+timeZoneName
+});
+let actual = formatter.format(date);
+// print(`${timeZoneName}: "${actual}",`);
+let expected = expectedSet[timeZoneName];
+if (Array.isArray(expected))
+shouldBe(expected.includes(actual), true);
+else
+shouldBe(actual, expected);
+});
+}
+
+timeZoneTest(date, "en", {
+short: "7/10/2021, 10:48:02 AM PDT",
+long: "7/10/2021, 10:48:02 AM Pacific Daylight Time",
+shortOffset: "7/10/2021, 10:48:02 AM GMT-7",
+longOffset: "7/10/2021, 10:48:02 AM GMT-07:00",
+shortGeneric: "7/10/2021, 10:48:02 AM PT",
+longGeneric: "7/10/2021, 10:48:02 AM Pacific Time",
+});
+
+timeZoneTest(date, "en", {
+short: "7/10/2021, 11:18:02 PM GMT+5:30",
+long: "7/10/2021, 11:18:02 PM India Standard Time",
+shortOffset: "7/10/2021, 11:18:02 PM GMT+5:30",
+longOffset: "7/10/2021, 11:18:02 PM GMT+05:30",
+shortGeneric: "7/10/2021, 11:18:02 PM India Time",
+longGeneric: "7/10/2021, 11:18:02 PM India Standard Time",
+}, "Asia/Calcutta");
+
+timeZoneTest(date, "zh-Hant", {
+short: ["2021/7/10 PDT 上午10:48:02", "2021/7/10 上午10:48:02 [PDT]"],
+long: ["2021/7/10 太平洋夏令時間 上午10:48:02", "2021/7/10 上午10:48:02 [太平洋夏令時間]"],
+shortOffset: ["2021/7/10 GMT-7 上午10:48:02", "2021/7/10 上午10:48:02 [GMT-7]"],
+longOffset: ["2021/7/10 GMT-07:00 上午10:48:02", "2021/7/10 上午10:48:02 [GMT-07:00]"],
+shortGeneric: ["2021/7/10 PT 上午10:48:02", "2021/7/10 上午10:48:02 [PT]"],
+longGeneric: ["2021/7/10 太平洋時間 上午10:48:02", "2021/7/10 上午10:48:02 [太平洋時間]"],
+});
+
+timeZoneTest(date, "ja-JP", {
+short: "2021/7/10 10:48:02 GMT-7",
+long: "2021/7/10 10時48分02秒 アメリカ太平洋夏時間",
+shortOffset: "2021/7/10 10時48分02秒 GMT-7",
+longOffset: "2021/7/10 10時48分02秒 GMT-07:00",
+shortGeneric: "2021/7/10 10:48:02 ロサンゼルス時間",
+longGeneric: "2021/7/10 10:48:02 アメリカ太平洋時間",
+});
+
+timeZoneTest(date, "ja-JP", {
+short: "2021/7/11 02:48:02 JST",
+long: "2021/7/11 02時48分02秒 日本標準時",
+shortOffset: "2021/7/11 02時48分02秒 GMT+9",
+longOffset: "2021/7/11 02時48分02秒 GMT+09:00",
+shortGeneric: "2021/7/11 02:48:02 JST",
+longGeneric: "2021/7/11 02:48:02 日本標準時",
+}, "Asia/Tokyo");


Modified: trunk/JSTests/test262/config.yaml

[webkit-changes] [281370] trunk/Source/JavaScriptCore

2021-08-21 Thread ysuzuki

Title: [281370] trunk/Source/_javascript_Core








Revision 281370
Author ysuz...@apple.com
Date 2021-08-21 05:28:04 -0700 (Sat, 21 Aug 2021)


Log Message
[JSC] Enable String,TypedArray#at
https://bugs.webkit.org/show_bug.cgi?id=229354

Reviewed by Saam Barati.

Enable String and TypedArray's `at` method.

* runtime/OptionsList.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/OptionsList.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (281369 => 281370)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-21 12:10:09 UTC (rev 281369)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-21 12:28:04 UTC (rev 281370)
@@ -1,5 +1,16 @@
 2021-08-21  Yusuke Suzuki  
 
+[JSC] Enable String,TypedArray#at
+https://bugs.webkit.org/show_bug.cgi?id=229354
+
+Reviewed by Saam Barati.
+
+Enable String and TypedArray's `at` method.
+
+* runtime/OptionsList.h:
+
+2021-08-21  Yusuke Suzuki  
+
 [JSC] Enable Array#findLast method
 https://bugs.webkit.org/show_bug.cgi?id=229355
 


Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (281369 => 281370)

--- trunk/Source/_javascript_Core/runtime/OptionsList.h	2021-08-21 12:10:09 UTC (rev 281369)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h	2021-08-21 12:28:04 UTC (rev 281370)
@@ -544,7 +544,7 @@
 v(Bool, useWeakRefs, true, Normal, "Expose the WeakRef constructor.") \
 v(Bool, useIntlDateTimeFormatDayPeriod, true, Normal, "Expose the Intl.DateTimeFormat dayPeriod feature.") \
 v(Bool, useIntlDateTimeFormatRangeToParts, true, Normal, "Expose the Intl.DateTimeFormat#formatRangeToParts feature.") \
-v(Bool, useAtMethod, false, Normal, "Expose the at() method on Array, %TypedArray%, and String.") \
+v(Bool, useAtMethod, true, Normal, "Expose the at() method on Array, %TypedArray%, and String.") \
 v(Bool, useErrorCause, true, Normal, "Allow a cause to be provided when constructing an Error, _NativeError_, or AggregateError.") \
 v(Bool, useSharedArrayBuffer, false, Normal, nullptr) \
 v(Bool, useTopLevelAwait, true, Normal, "allow the await keyword at the top level of a module.") \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281369] trunk

2021-08-21 Thread ysuzuki

Title: [281369] trunk








Revision 281369
Author ysuz...@apple.com
Date 2021-08-21 05:10:09 -0700 (Sat, 21 Aug 2021)


Log Message
[JSC] Enable Array#findLast method
https://bugs.webkit.org/show_bug.cgi?id=229355

Reviewed by Saam Barati.

JSTests:

* stress/unscopables.js:

Source/_javascript_Core:

This patch enables Array#findLast and Array#findLastIndex methods.

* runtime/ArrayPrototype.cpp: Order of unscopables is alphabet ordering (https://tc39.es/ecma262/#sec-array.prototype-@@unscopables)
(JSC::ArrayPrototype::finishCreation):
* runtime/OptionsList.h:

LayoutTests:

* inspector/model/remote-object-get-properties-expected.txt:
* js/Object-getOwnPropertyNames-expected.txt:
* js/array-unscopables-properties-expected.txt:
* js/script-tests/Object-getOwnPropertyNames.js:
* js/script-tests/array-unscopables-properties.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/unscopables.js
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt
trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt
trunk/LayoutTests/js/array-unscopables-properties-expected.txt
trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js
trunk/LayoutTests/js/script-tests/array-unscopables-properties.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
trunk/Source/_javascript_Core/runtime/OptionsList.h




Diff

Modified: trunk/JSTests/ChangeLog (281368 => 281369)

--- trunk/JSTests/ChangeLog	2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/JSTests/ChangeLog	2021-08-21 12:10:09 UTC (rev 281369)
@@ -1,3 +1,12 @@
+2021-08-21  Yusuke Suzuki  
+
+[JSC] Enable Array#findLast method
+https://bugs.webkit.org/show_bug.cgi?id=229355
+
+Reviewed by Saam Barati.
+
+* stress/unscopables.js:
+
 2021-08-17  Mikhail R. Gadelha  
 
 Unreviewed. Skip failing MIPS tests


Modified: trunk/JSTests/stress/unscopables.js (281368 => 281369)

--- trunk/JSTests/stress/unscopables.js	2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/JSTests/stress/unscopables.js	2021-08-21 12:10:09 UTC (rev 281369)
@@ -11,7 +11,7 @@
 
 test(typeof unscopables, "object");
 test(unscopables.__proto__, undefined);
-test(String(Object.keys(unscopables).sort()), "at,copyWithin,entries,fill,find,findIndex,flat,flatMap,includes,keys,values");
+test(String(Object.keys(unscopables).sort()), "at,copyWithin,entries,fill,find,findIndex,findLast,findLastIndex,flat,flatMap,includes,keys,values");
 }());
 
 (function () {


Modified: trunk/LayoutTests/ChangeLog (281368 => 281369)

--- trunk/LayoutTests/ChangeLog	2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/ChangeLog	2021-08-21 12:10:09 UTC (rev 281369)
@@ -1,3 +1,16 @@
+2021-08-21  Yusuke Suzuki  
+
+[JSC] Enable Array#findLast method
+https://bugs.webkit.org/show_bug.cgi?id=229355
+
+Reviewed by Saam Barati.
+
+* inspector/model/remote-object-get-properties-expected.txt:
+* js/Object-getOwnPropertyNames-expected.txt:
+* js/array-unscopables-properties-expected.txt:
+* js/script-tests/Object-getOwnPropertyNames.js:
+* js/script-tests/array-unscopables-properties.js:
+
 2021-08-21  Youenn Fablet  
 
 Prevent AudioSession category from moving out of PlayAndRecord too quickly


Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (281368 => 281369)

--- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt	2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt	2021-08-21 12:10:09 UTC (rev 281369)
@@ -82,7 +82,9 @@
 keys
 entries
 find
+findLast
 findIndex
+findLastIndex
 includes
 copyWithin
 at
@@ -136,7 +138,9 @@
 keys
 entries
 find
+findLast
 findIndex
+findLastIndex
 includes
 copyWithin
 at
@@ -175,7 +179,9 @@
 keys
 entries
 find
+findLast
 findIndex
+findLastIndex
 includes
 copyWithin
 at
@@ -214,7 +220,9 @@
 keys
 entries
 find
+findLast
 findIndex
+findLastIndex
 includes
 copyWithin
 at


Modified: trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt (281368 => 281369)

--- trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt	2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt	2021-08-21 12:10:09 UTC (rev 281369)
@@ -47,7 +47,7 @@
 PASS getSortedOwnPropertyNames(Function) is ['length', 'name', 'prototype']
 PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']
 PASS getSortedOwnPropertyNames(Array) is ['from', 'isArray', 'length', 'name', 'of', 'prototype']
-PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin',

[webkit-changes] [281368] trunk/Tools

2021-08-21 Thread commit-queue

Title: [281368] trunk/Tools








Revision 281368
Author commit-qu...@webkit.org
Date 2021-08-21 00:56:13 -0700 (Sat, 21 Aug 2021)


Log Message
[GLIB] Do not assume log success in apply-build-revision-to-files
https://bugs.webkit.org/show_bug.cgi?id=229335

Patch by Daniel Kolesa  on 2021-08-21
Reviewed by Philippe Normand.

If the origin reference does not exist for any reason, this will
fail the build. Since we have no reference point, just assume
unknown like if it wasn't a git repo.

* glib/apply-build-revision-to-files.py:
(get_build_revision):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/glib/apply-build-revision-to-files.py




Diff

Modified: trunk/Tools/ChangeLog (281367 => 281368)

--- trunk/Tools/ChangeLog	2021-08-21 07:01:21 UTC (rev 281367)
+++ trunk/Tools/ChangeLog	2021-08-21 07:56:13 UTC (rev 281368)
@@ -1,3 +1,17 @@
+2021-08-21  Daniel Kolesa  
+
+[GLIB] Do not assume log success in apply-build-revision-to-files
+https://bugs.webkit.org/show_bug.cgi?id=229335
+
+Reviewed by Philippe Normand.
+
+If the origin reference does not exist for any reason, this will
+fail the build. Since we have no reference point, just assume
+unknown like if it wasn't a git repo.
+
+* glib/apply-build-revision-to-files.py:
+(get_build_revision):
+
 2021-08-20  Jonathan Bedard  
 
 [git-webkit] Add pull-request command (Part 2)


Modified: trunk/Tools/glib/apply-build-revision-to-files.py (281367 => 281368)

--- trunk/Tools/glib/apply-build-revision-to-files.py	2021-08-21 07:01:21 UTC (rev 281367)
+++ trunk/Tools/glib/apply-build-revision-to-files.py	2021-08-21 07:56:13 UTC (rev 281368)
@@ -37,7 +37,13 @@
 revision = "r%s" % contents.decode('utf-8').strip()
 break
 elif os.path.isdir('.git'):
-commit_message = subprocess.check_output(("git", "log", "-1", "--pretty=%B", "origin/HEAD"), stderr=devnull)
+try:
+commit_message = subprocess.check_output(("git", "log", "-1", "--pretty=%B", "origin/HEAD"), stderr=devnull)
+except subprocess.CalledProcessError:
+# This may happen with shallow checkouts whose HEAD has been
+# modified; there is no origin reference anymore, and git
+# will fail - let's pretend that this is not a repo at all
+commit_message = ""
 # Commit messages tend to be huge and the metadata we're looking
 # for is at the very end. Also a spoofed 'Canonical link' mention
 # could appear early on. So make sure we get the right metadata by






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281367] trunk

2021-08-21 Thread youenn

Title: [281367] trunk








Revision 281367
Author you...@apple.com
Date 2021-08-21 00:01:21 -0700 (Sat, 21 Aug 2021)


Log Message
Prevent AudioSession category from moving out of PlayAndRecord too quickly
https://bugs.webkit.org/show_bug.cgi?id=229327


Reviewed by Eric Carlson.

Source/WebCore:

If category is PlayAndRecord, we stick to PlayAndRecord until audio is no longer playing at which point we
transition to whatever category is most appropriate.
Introduce PlatformMediaSession::isPlaying in addition to canProduceAudio to compute whether audio is being played.

Test: http/tests/media/media-stream/audio-capture-and-category.https.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::isPlaying const):
* Modules/webaudio/AudioContext.h:
* html/HTMLMediaElement.h:
* platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::isPlaying const):
* platform/audio/PlatformMediaSession.h:
(WebCore::PlatformMediaSessionClient::isPlaying const):
* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::updateSessionState):

LayoutTests:

* http/tests/media/media-stream/audio-capture-and-category.https-expected.txt: Added.
* http/tests/media/media-stream/audio-capture-and-category.https.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
trunk/Source/WebCore/Modules/webaudio/AudioContext.h
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSession.h
trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm


Added Paths

trunk/LayoutTests/http/tests/media/media-stream/audio-capture-and-category.https-expected.txt
trunk/LayoutTests/http/tests/media/media-stream/audio-capture-and-category.https.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281366 => 281367)

--- trunk/LayoutTests/ChangeLog	2021-08-21 06:10:53 UTC (rev 281366)
+++ trunk/LayoutTests/ChangeLog	2021-08-21 07:01:21 UTC (rev 281367)
@@ -1,3 +1,14 @@
+2021-08-21  Youenn Fablet  
+
+Prevent AudioSession category from moving out of PlayAndRecord too quickly
+https://bugs.webkit.org/show_bug.cgi?id=229327
+
+
+Reviewed by Eric Carlson.
+
+* http/tests/media/media-stream/audio-capture-and-category.https-expected.txt: Added.
+* http/tests/media/media-stream/audio-capture-and-category.https.html: Added.
+
 2021-08-20  Commit Queue  
 
 Unreviewed, reverting r281343.


Added: trunk/LayoutTests/http/tests/media/media-stream/audio-capture-and-category.https-expected.txt (0 => 281367)

--- trunk/LayoutTests/http/tests/media/media-stream/audio-capture-and-category.https-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/media/media-stream/audio-capture-and-category.https-expected.txt	2021-08-21 07:01:21 UTC (rev 281367)
@@ -0,0 +1,4 @@
+
+
+PASS Validate audio session category is set to PlayAndRecord after frame stopped capturing but continued playing audio
+


Added: trunk/LayoutTests/http/tests/media/media-stream/audio-capture-and-category.https.html (0 => 281367)

--- trunk/LayoutTests/http/tests/media/media-stream/audio-capture-and-category.https.html	(rev 0)
+++ trunk/LayoutTests/http/tests/media/media-stream/audio-capture-and-category.https.html	2021-08-21 07:01:21 UTC (rev 281367)
@@ -0,0 +1,63 @@
+
+
+
+
+
+
+
+