[webkit-changes] [283098] trunk
Title: [283098] trunk Revision 283098 Author ysuz...@apple.com Date 2021-09-26 22:02:37 -0700 (Sun, 26 Sep 2021) Log Message [JSC] Optimize PutByVal with for-in https://bugs.webkit.org/show_bug.cgi?id=230801 Reviewed by Saam Barati. JSTests: * stress/for-in-sentinel.js: Added. (shouldBe): (test): Source/_javascript_Core: We found that some of Speedometer2 subtests are heavily using for-in with PutByVal or the other DFG nodes. And we also found that we are using polluted non-good type for the property names from for-in: String | Other. The reason is that we are returning null when op_enumerator_next finishes instead of string. And this design forces DFG and FTL to return null from EnumeratorNextUpdatePropertyName at the end of iteration. This pollutes the type of property names as String | Other instead of String, and leading to suboptimal DFG nodes. In this patch, we add special sentinel string in vm.smallString.sentinelString(). We know that this string cell pointer will be never returned from EnumeratorNextUpdatePropertyName in the normal for-in iteration. This is easy since we are always allocating a JSString when creating JSPropertyNameEnumerator. So this string cell (not the content) is always different from pre-allocated vm.smallString.sentinelString(). So, we use this special string pointer as a sentinel instead of null so that we can avoid polluting return type of EnumeratorNextUpdatePropertyName. To check the sentinel in LLInt / Baseline, this patch adds jeq_ptr, which performs cell pointer comparison and do not check string content equality. We do not need to have an implementation in DFG since we already have CompareEqPtr for existing jneq_ptr bytecode. We also clean up DFG operation related to PutByVal. -- | subtest| ms | ms | b / a | pValue (significance using False Discovery Rate) | -- | Elm-TodoMVC |116.01 |112.701667 |0.971482 | 0.00 (significant) | | VueJS-TodoMVC|22.995000|23.02|1.001232 | 0.907086 | | EmberJS-TodoMVC |125.498333 |125.525000 |1.000212 | 0.932546 | | BackboneJS-TodoMVC |45.70|45.975000|1.006018 | 0.084799 | | Preact-TodoMVC |16.681667|16.61|0.995704 | 0.722758 | | AngularJS-TodoMVC|123.75 |123.74 |0.999892 | 0.971431 | | Vanilla-ES2015-TodoMVC |61.255000|61.38|1.002041 | 0.300654 | | Inferno-TodoMVC |58.646667|58.948333|1.005144 | 0.267611 | | Flight-TodoMVC |73.28|72.801667|0.993427 | 0.207389 | | Angular2-TypeScript-TodoMVC |39.746667|40.015000|1.006751 | 0.449821 | | VanillaJS-TodoMVC|50.096667|49.82|0.994544 | 0.162020 | | jQuery-TodoMVC |212.87 |213.196667 |1.001535 | 0.371944 | | EmberJS-Debug-TodoMVC|331.878333 |332.71 |1.002506 | 0.094499 | | React-TodoMVC|83.078333|82.726667|0.995767 | 0.076143 | | React-Redux-TodoMVC |136.018333 |133.935000 |0.984683 | 0.00 (significant) | | Vanilla-ES2015-Babel-Webpack-TodoMVC |59.74|59.64|0.998326 | 0.393671 | -- a mean = 271.75873 b mean = 272.45804 pValue = 0.0263030803 (Bigger means are better.) 1.003 times better Results ARE significant * builtins/BuiltinNames.h: * bytecode/BytecodeList.rb: * bytecode/BytecodeUseDef.cpp: (JSC::computeUsesForBytecodeIndexImpl): (JSC::computeDefsForBytecodeIndexImpl): * bytecode/LinkTimeConstant.h: * bytecode/Opcode.h: (JSC::isBranch): * bytecode/PreciseJumpTargetsInlines.h: * bytecompiler/BytecodeGenerator.cpp: (JSC::GenericLabel::setLocation): (JSC::BytecodeGenerator::emitJumpIfSentinelString): * bytecompiler/BytecodeGenerator.h: * bytecompiler/NodesCodegen.cpp:
[webkit-changes] [283097] trunk
Title: [283097] trunk Revision 283097 Author j...@apple.com Date 2021-09-26 21:40:08 -0700 (Sun, 26 Sep 2021) Log Message [MSE] appending to the source buffer will not throw when the source buffer is full. https://bugs.webkit.org/show_bug.cgi?id=230672 rdar://problem/83496195 Reviewed by Eric Carlson. Source/WebCore: Tests: media/media-source/media-source-append-buffer-full-quota-exceeded-error.html * platform/graphics/PlatformTimeRanges.cpp: (WebCore::PlatformTimeRanges::findWithEpsilon): add method. (WebCore::PlatformTimeRanges::copyWithEpsilon const): add method. * platform/graphics/PlatformTimeRanges.h: * platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::evictCodedFrames): LayoutTests: * media/media-source/media-source-append-buffer-full-quota-exceeded-error-expected.txt: * media/media-source/media-source-append-buffer-full-quota-exceeded-error.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error-expected.txt trunk/LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/PlatformTimeRanges.cpp trunk/Source/WebCore/platform/graphics/PlatformTimeRanges.h trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.cpp Diff Modified: trunk/LayoutTests/ChangeLog (283096 => 283097) --- trunk/LayoutTests/ChangeLog 2021-09-27 04:25:46 UTC (rev 283096) +++ trunk/LayoutTests/ChangeLog 2021-09-27 04:40:08 UTC (rev 283097) @@ -1,3 +1,14 @@ +2021-09-26 Jean-Yves Avenard + +[MSE] appending to the source buffer will not throw when the source buffer is full. +https://bugs.webkit.org/show_bug.cgi?id=230672 +rdar://problem/83496195 + +Reviewed by Eric Carlson. + +* media/media-source/media-source-append-buffer-full-quota-exceeded-error-expected.txt: +* media/media-source/media-source-append-buffer-full-quota-exceeded-error.html: + 2021-09-26 Lauro Moura [WPE] Rebaseline a number of text-only failures Modified: trunk/LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error-expected.txt (283096 => 283097) --- trunk/LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error-expected.txt 2021-09-27 04:25:46 UTC (rev 283096) +++ trunk/LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error-expected.txt 2021-09-27 04:40:08 UTC (rev 283097) @@ -30,5 +30,302 @@ EXPECTED (exception != 'QuotaExceededError: The quota has been exceeded.') OK Appending PTS=13-15 EXPECTED (exception == 'QuotaExceededError: The quota has been exceeded.') OK +EVENT(updateend) +Appending PTS=0 +EVENT(updateend) +Appending PTS=1 +EVENT(updateend) +Appending PTS=2 +EVENT(updateend) +Appending PTS=3 +EVENT(updateend) +Appending PTS=4 +EVENT(updateend) +Appending PTS=5 +EVENT(updateend) +Appending PTS=6 +EVENT(updateend) +Appending PTS=7 +EVENT(updateend) +Appending PTS=8 +EVENT(updateend) +Appending PTS=9 +EVENT(updateend) +Appending PTS=10 +EVENT(updateend) +Appending PTS=11 +EVENT(updateend) +Appending PTS=12 +EVENT(updateend) +Appending PTS=13 +EVENT(updateend) +Appending PTS=14 +EVENT(updateend) +Appending PTS=15 +EVENT(updateend) +Appending PTS=16 +EVENT(updateend) +Appending PTS=17 +EVENT(updateend) +Appending PTS=18 +EVENT(updateend) +Appending PTS=19 +EVENT(updateend) +Appending PTS=20 +EVENT(updateend) +Appending PTS=21 +EVENT(updateend) +Appending PTS=22 +EVENT(updateend) +Appending PTS=23 +EVENT(updateend) +Appending PTS=24 +EVENT(updateend) +Appending PTS=25 +EVENT(updateend) +Appending PTS=26 +EVENT(updateend) +Appending PTS=27 +EVENT(updateend) +Appending PTS=28 +EVENT(updateend) +Appending PTS=29 +EVENT(updateend) +Appending PTS=30 +EVENT(updateend) +Appending PTS=31 +EVENT(updateend) +Appending PTS=32 +EVENT(updateend) +Appending PTS=33 +EVENT(updateend) +Appending PTS=34 +EVENT(updateend) +Appending PTS=35 +EVENT(updateend) +Appending PTS=36 +EVENT(updateend) +Appending PTS=37 +EVENT(updateend) +Appending PTS=38 +EVENT(updateend) +Appending PTS=39 +EVENT(updateend) +Appending PTS=40 +EVENT(updateend) +Appending PTS=41 +EVENT(updateend) +Appending PTS=42 +EXPECTED (exception == 'QuotaExceededError: The quota has been exceeded.') OK +EXPECTED (1 == '1') OK +EVENT(updateend) +Appending PTS=0.002 +EVENT(updateend) +Appending PTS=1.002 +EVENT(updateend) +Appending PTS=2.002 +EVENT(updateend) +Appending PTS=3.002 +EVENT(updateend) +Appending PTS=4.002 +EVENT(updateend) +Appending PTS=5.002 +EVENT(updateend) +Appending PTS=6.002 +EVENT(updateend) +Appending PTS=7.002 +EVENT(updateend) +Appending PTS=8.002 +EVENT(updateend) +Appending PTS=9.002 +EVENT(updateend) +Appending PTS=10.002 +EVENT(updateend) +Appending PTS=11.002 +EVENT(updateend) +Appending PTS=12.002 +EVENT(updateend) +Appending PTS=13.002 +EVENT(updateend) +Appending PTS=14.002 +EVENT(updateend)
[webkit-changes] [283096] trunk
Title: [283096] trunk
Revision 283096
Author commit-qu...@webkit.org
Date 2021-09-26 21:25:46 -0700 (Sun, 26 Sep 2021)
Log Message
Unreviewed, reverting r283095.
https://bugs.webkit.org/show_bug.cgi?id=230815
We should land the original patch since this does not work
with bytecode cache
Reverted changeset:
"[JSC] Optimize PutByVal with for-in"
https://bugs.webkit.org/show_bug.cgi?id=230801
https://commits.webkit.org/r283095
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/BuiltinNames.h
trunk/Source/_javascript_Core/bytecode/BytecodeList.rb
trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.cpp
trunk/Source/_javascript_Core/bytecode/Opcode.h
trunk/Source/_javascript_Core/bytecode/PreciseJumpTargetsInlines.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/SmallStrings.cpp
trunk/Source/_javascript_Core/runtime/SmallStrings.h
Removed Paths
trunk/JSTests/stress/for-in-sentinel.js
Diff
Modified: trunk/JSTests/ChangeLog (283095 => 283096)
--- trunk/JSTests/ChangeLog 2021-09-27 04:14:23 UTC (rev 283095)
+++ trunk/JSTests/ChangeLog 2021-09-27 04:25:46 UTC (rev 283096)
@@ -1,3 +1,17 @@
+2021-09-26 Commit Queue
+
+Unreviewed, reverting r283095.
+https://bugs.webkit.org/show_bug.cgi?id=230815
+
+We should land the original patch since this does not work
+with bytecode cache
+
+Reverted changeset:
+
+"[JSC] Optimize PutByVal with for-in"
+https://bugs.webkit.org/show_bug.cgi?id=230801
+https://commits.webkit.org/r283095
+
2021-09-26 Yusuke Suzuki
[JSC] Optimize PutByVal with for-in
Deleted: trunk/JSTests/stress/for-in-sentinel.js (283095 => 283096)
--- trunk/JSTests/stress/for-in-sentinel.js 2021-09-27 04:14:23 UTC (rev 283095)
+++ trunk/JSTests/stress/for-in-sentinel.js 2021-09-27 04:25:46 UTC (rev 283096)
@@ -1,22 +0,0 @@
-function shouldBe(actual, expected) {
-if (actual !== expected)
-throw new Error('bad value: ' + actual);
-}
-
-var object = {
-$: 32,
-test: 33,
-hey: 34,
-};
-
-function test(object) {
-var count = 0;
-for (var i in object) {
-++count;
-}
-return count;
-}
-noInline(test);
-
-for (var i = 0; i < 1e6; ++i)
-shouldBe(test(object), 3);
Modified: trunk/Source/_javascript_Core/ChangeLog (283095 => 283096)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-27 04:14:23 UTC (rev 283095)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-27 04:25:46 UTC (rev 283096)
@@ -1,3 +1,17 @@
+2021-09-26 Commit Queue
+
+Unreviewed, reverting r283095.
+https://bugs.webkit.org/show_bug.cgi?id=230815
+
+We should land the original patch since this does not work
+with bytecode cache
+
+Reverted changeset:
+
+"[JSC] Optimize PutByVal with for-in"
+https://bugs.webkit.org/show_bug.cgi?id=230801
+https://commits.webkit.org/r283095
+
2021-09-26 Yusuke Suzuki
[JSC] Optimize PutByVal with for-in
Modified: trunk/Source/_javascript_Core/builtins/BuiltinNames.h (283095 => 283096)
--- trunk/Source/_javascript_Core/builtins/BuiltinNames.h 2021-09-27 04:14:23 UTC (rev 283095)
+++ trunk/Source/_javascript_Core/builtins/BuiltinNames.h 2021-09-27 04:25:46 UTC (rev 283096)
@@ -182,7 +182,7 @@
macro(createPrivateSymbol) \
macro(entries) \
macro(outOfLineReactionCounts) \
-macro(emptyPropertyNameEnumerator) \
+macro(emptyPropertyNameEnumerator)
namespace Symbols {
Modified: trunk/Source/_javascript_Core/bytecode/BytecodeList.rb (283095 => 283096)
--- trunk/Source/_javascript_Core/bytecode/BytecodeList.rb 2021-09-27 04:14:23 UTC (rev 283095)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeList.rb 2021-09-27 04:25:46 UTC (rev 283096)
@@ -762,13 +762,6 @@
targetLabel: BoundLabel,
}
-op :jeq_ptr,
-args: {
-value:
[webkit-changes] [283095] trunk
Title: [283095] trunk Revision 283095 Author ysuz...@apple.com Date 2021-09-26 21:14:23 -0700 (Sun, 26 Sep 2021) Log Message [JSC] Optimize PutByVal with for-in https://bugs.webkit.org/show_bug.cgi?id=230801 Reviewed by Saam Barati. JSTests: * stress/for-in-sentinel.js: Added. (shouldBe): (test): Source/_javascript_Core: We found that some of Speedometer2 subtests are heavily using for-in with PutByVal or the other DFG nodes. And we also found that we are using polluted non-good type for the property names from for-in: String | Other. The reason is that we are returning null when op_enumerator_next finishes instead of string. And this design forces DFG and FTL to return null from EnumeratorNextUpdatePropertyName at the end of iteration. This pollutes the type of property names as String | Other instead of String, and leading to suboptimal DFG nodes. In this patch, we add special sentinel string in vm.smallString.sentinelString(). We know that this string cell pointer will be never returned from EnumeratorNextUpdatePropertyName in the normal for-in iteration. This is easy since we are always allocating a JSString when creating JSPropertyNameEnumerator. So this string cell (not the content) is always different from pre-allocated vm.smallString.sentinelString(). So, we use this special string pointer as a sentinel instead of null so that we can avoid polluting return type of EnumeratorNextUpdatePropertyName. To check the sentinel in LLInt / Baseline, this patch adds jeq_ptr, which performs cell pointer comparison and do not check string content equality. We do not need to have an implementation in DFG since we already have CompareEqPtr for existing jneq_ptr bytecode. We also clean up DFG operation related to PutByVal. -- | subtest| ms | ms | b / a | pValue (significance using False Discovery Rate) | -- | Elm-TodoMVC |116.01 |112.701667 |0.971482 | 0.00 (significant) | | VueJS-TodoMVC|22.995000|23.02|1.001232 | 0.907086 | | EmberJS-TodoMVC |125.498333 |125.525000 |1.000212 | 0.932546 | | BackboneJS-TodoMVC |45.70|45.975000|1.006018 | 0.084799 | | Preact-TodoMVC |16.681667|16.61|0.995704 | 0.722758 | | AngularJS-TodoMVC|123.75 |123.74 |0.999892 | 0.971431 | | Vanilla-ES2015-TodoMVC |61.255000|61.38|1.002041 | 0.300654 | | Inferno-TodoMVC |58.646667|58.948333|1.005144 | 0.267611 | | Flight-TodoMVC |73.28|72.801667|0.993427 | 0.207389 | | Angular2-TypeScript-TodoMVC |39.746667|40.015000|1.006751 | 0.449821 | | VanillaJS-TodoMVC|50.096667|49.82|0.994544 | 0.162020 | | jQuery-TodoMVC |212.87 |213.196667 |1.001535 | 0.371944 | | EmberJS-Debug-TodoMVC|331.878333 |332.71 |1.002506 | 0.094499 | | React-TodoMVC|83.078333|82.726667|0.995767 | 0.076143 | | React-Redux-TodoMVC |136.018333 |133.935000 |0.984683 | 0.00 (significant) | | Vanilla-ES2015-Babel-Webpack-TodoMVC |59.74|59.64|0.998326 | 0.393671 | -- a mean = 271.75873 b mean = 272.45804 pValue = 0.0263030803 (Bigger means are better.) 1.003 times better Results ARE significant * builtins/BuiltinNames.h: * bytecode/BytecodeList.rb: * bytecode/BytecodeUseDef.cpp: (JSC::computeUsesForBytecodeIndexImpl): (JSC::computeDefsForBytecodeIndexImpl): * bytecode/LinkTimeConstant.h: * bytecode/Opcode.h: (JSC::isBranch): * bytecode/PreciseJumpTargetsInlines.h: * bytecompiler/BytecodeGenerator.cpp: (JSC::GenericLabel::setLocation): (JSC::BytecodeGenerator::emitJumpIfSentinelString): * bytecompiler/BytecodeGenerator.h: * bytecompiler/NodesCodegen.cpp:
[webkit-changes] [283094] trunk/LayoutTests
Title: [283094] trunk/LayoutTests Revision 283094 Author lmo...@igalia.com Date 2021-09-26 20:01:05 -0700 (Sun, 26 Sep 2021) Log Message [WPE] Rebaseline a number of text-only failures Unreviewed test gardening. Most are 1-pixel differences after some recent LFC-related commits. * platform/glib/fast/css/getComputedStyle/computed-style-font-family-expected.txt: * platform/glib/fast/encoding/charset-replacement-expected.txt: * platform/wpe/TestExpectations: * platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: * platform/wpe/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: * platform/wpe/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: * platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: * platform/wpe/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: * platform/wpe/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: * platform/wpe/css2.1/t0905-c414-flt-02-c-expected.txt: * platform/wpe/css2.1/t0905-c414-flt-03-c-expected.txt: * platform/wpe/css2.1/t0905-c414-flt-04-c-expected.txt: * platform/wpe/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: * platform/wpe/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: * platform/wpe/css2.1/t0905-c5525-fltblck-01-d-expected.txt: * platform/wpe/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: * platform/wpe/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: * platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: * platform/wpe/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: * platform/wpe/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: * platform/wpe/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: * platform/wpe/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: * platform/wpe/css2.1/t090501-c414-flt-01-b-expected.txt: * platform/wpe/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt: * platform/wpe/css2.1/t1202-counter-04-b-expected.txt: * platform/wpe/css2.1/t1202-counter-09-b-expected.txt: * platform/wpe/css2.1/t1202-counters-04-b-expected.txt: * platform/wpe/css2.1/t1202-counters-09-b-expected.txt: * platform/wpe/fast/attachment/attachment-select-on-click-expected.txt: * platform/wpe/fast/attachment/attachment-select-on-click-inside-user-select-all-expected.txt: * platform/wpe/fast/borders/rtl-border-05-expected.txt: * platform/wpe/fast/css/font-face-implicit-local-font-expected.txt: * platform/wpe/fast/css/font-face-locally-installed-expected.txt: * platform/wpe/fast/css/font-face-opentype-expected.txt: * platform/wpe/fast/css/font-face-unicode-range-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-font-family-expected.txt trunk/LayoutTests/platform/glib/fast/encoding/charset-replacement-expected.txt trunk/LayoutTests/platform/wpe/TestExpectations trunk/LayoutTests/platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5519-brdr-r-00-a-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5519-brdr-r-01-e-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5521-brdr-l-00-a-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5521-brdr-l-01-e-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c414-flt-02-c-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c414-flt-03-c-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c414-flt-04-c-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltblck-01-d-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-flthw-00-c-g-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltwrap-00-b-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0905-c5526-flthw-00-c-g-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t090501-c414-flt-01-b-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t1202-counter-04-b-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t1202-counter-09-b-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t1202-counters-04-b-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t1202-counters-09-b-expected.txt trunk/LayoutTests/platform/wpe/fast/attachment/attachment-select-on-click-expected.txt trunk/LayoutTests/platform/wpe/fast/attachment/attachment-select-on-click-inside-user-select-all-expected.txt trunk/LayoutTests/platform/wpe/fast/borders/rtl-border-05-expected.txt trunk/LayoutTests/platform/wpe/fast/css/font-face-implicit-local-font-expected.txt
[webkit-changes] [283093] trunk/LayoutTests/imported/w3c
Title: [283093] trunk/LayoutTests/imported/w3c Revision 283093 Author hey...@apple.com Date 2021-09-26 19:46:34 -0700 (Sun, 26 Sep 2021) Log Message Remove canvas HitRegions tests https://bugs.webkit.org/show_bug.cgi?id=230809 Reviewed by Alan Bujtas. These were removed upstream in https://github.com/web-platform-tests/wpt/pull/30850. * web-platform-tests/html/canvas/element/hit-regions/addHitRegions-NotSupportedError-01-expected.txt: Removed. * web-platform-tests/html/canvas/element/hit-regions/addHitRegions-NotSupportedError-01.html: Removed. * web-platform-tests/html/canvas/element/hit-regions/hitregions-members-exist-expected.txt: Removed. * web-platform-tests/html/canvas/element/hit-regions/hitregions-members-exist.html: Removed. * web-platform-tests/html/canvas/element/hit-regions/w3c-import.log: Removed. * web-platform-tests/html/canvas/element/manual/hit-regions/addHitRegions-NotSupportedError-01-expected.txt: Removed. * web-platform-tests/html/canvas/element/manual/hit-regions/addHitRegions-NotSupportedError-01.html: Removed. * web-platform-tests/html/canvas/element/manual/hit-regions/hitregions-members-exist-expected.txt: Removed. * web-platform-tests/html/canvas/element/manual/hit-regions/hitregions-members-exist.html: Removed. * web-platform-tests/html/canvas/element/manual/hit-regions/w3c-import.log: Removed. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog Removed Paths trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/hit-regions/ trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/hit-regions/ Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (283092 => 283093) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-27 01:28:28 UTC (rev 283092) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-27 02:46:34 UTC (rev 283093) @@ -1,3 +1,25 @@ +2021-09-26 Cameron McCormack + +Remove canvas HitRegions tests +https://bugs.webkit.org/show_bug.cgi?id=230809 + + +Reviewed by Alan Bujtas. + +These were removed upstream in +https://github.com/web-platform-tests/wpt/pull/30850. + +* web-platform-tests/html/canvas/element/hit-regions/addHitRegions-NotSupportedError-01-expected.txt: Removed. +* web-platform-tests/html/canvas/element/hit-regions/addHitRegions-NotSupportedError-01.html: Removed. +* web-platform-tests/html/canvas/element/hit-regions/hitregions-members-exist-expected.txt: Removed. +* web-platform-tests/html/canvas/element/hit-regions/hitregions-members-exist.html: Removed. +* web-platform-tests/html/canvas/element/hit-regions/w3c-import.log: Removed. +* web-platform-tests/html/canvas/element/manual/hit-regions/addHitRegions-NotSupportedError-01-expected.txt: Removed. +* web-platform-tests/html/canvas/element/manual/hit-regions/addHitRegions-NotSupportedError-01.html: Removed. +* web-platform-tests/html/canvas/element/manual/hit-regions/hitregions-members-exist-expected.txt: Removed. +* web-platform-tests/html/canvas/element/manual/hit-regions/hitregions-members-exist.html: Removed. +* web-platform-tests/html/canvas/element/manual/hit-regions/w3c-import.log: Removed. + 2021-09-25 Myles C. Maxfield Test palette animations ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283092] trunk/LayoutTests
Title: [283092] trunk/LayoutTests Revision 283092 Author lmo...@igalia.com Date 2021-09-26 18:28:28 -0700 (Sun, 26 Sep 2021) Log Message [GLIB] Update baselines after 242013@main Unreviewed test gardening. These tests were updated to use the application bundle ID, which is not used by the GLIB ports. * platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-null-content-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-wrong-content-type-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt: Added. * platform/glib/http/tests/privateClickMeasurement/store-private-click-measurement-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/glib/http/tests/contentextensions/ trunk/LayoutTests/platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/ trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-null-content-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-wrong-content-type-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/store-private-click-measurement-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (283091 => 283092) --- trunk/LayoutTests/ChangeLog 2021-09-26 21:38:01 UTC (rev 283091) +++ trunk/LayoutTests/ChangeLog 2021-09-27 01:28:28 UTC (rev 283092) @@ -1,3 +1,27 @@ +2021-09-26 Lauro Moura + +[GLIB] Update baselines after 242013@main + +Unreviewed test gardening. + +These tests were updated to use the application bundle ID, which is +not used by the GLIB ports. + +* platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt: Added. +* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt: Added. +* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt: Added. +* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt: Added. +*
[webkit-changes] [283091] trunk/LayoutTests
Title: [283091] trunk/LayoutTests Revision 283091 Author ehutchi...@apple.com Date 2021-09-26 14:38:01 -0700 (Sun, 26 Sep 2021) Log Message [ Catalina Debug wk1 EWS ] media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html is a flay crash. https://bugs.webkit.org/show_bug.cgi?id=230808. Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283090 => 283091) --- trunk/LayoutTests/ChangeLog 2021-09-26 21:23:21 UTC (rev 283090) +++ trunk/LayoutTests/ChangeLog 2021-09-26 21:38:01 UTC (rev 283091) @@ -1,5 +1,14 @@ 2021-09-26 Eric Hutchison +[ Catalina Debug wk1 EWS ] media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html is a flay crash. +https://bugs.webkit.org/show_bug.cgi?id=230808. + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + +2021-09-26 Eric Hutchison + [ Catalina Debug wk1 EWS ] Media tests flakily crashing. https://bugs.webkit.org/show_bug.cgi?id=230807. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (283090 => 283091) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-09-26 21:23:21 UTC (rev 283090) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-09-26 21:38:01 UTC (rev 283091) @@ -1458,3 +1458,5 @@ webkit.org/b/230807 [ Catalina Debug ] media/media-source/media-source-append-before-last-range-no-quota-exceeded.html [ Pass Crash ] webkit.org/b/230807 [ Catalina Debug ] media/media-source/media-source-remove.html [ Pass Crash ] + +webkit.org/b/230808 [ Catalina Debug ] media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283090] trunk/LayoutTests
Title: [283090] trunk/LayoutTests Revision 283090 Author ehutchi...@apple.com Date 2021-09-26 14:23:21 -0700 (Sun, 26 Sep 2021) Log Message [ Catalina Debug wk1 EWS ] Media tests flakily crashing. https://bugs.webkit.org/show_bug.cgi?id=230807. Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283089 => 283090) --- trunk/LayoutTests/ChangeLog 2021-09-26 21:20:52 UTC (rev 283089) +++ trunk/LayoutTests/ChangeLog 2021-09-26 21:23:21 UTC (rev 283090) @@ -1,3 +1,12 @@ +2021-09-26 Eric Hutchison + +[ Catalina Debug wk1 EWS ] Media tests flakily crashing. +https://bugs.webkit.org/show_bug.cgi?id=230807. + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2021-09-26 Antti Koivisto Line iterator firstRun/lastRun may return runs from wrong lines Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (283089 => 283090) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-09-26 21:20:52 UTC (rev 283089) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-09-26 21:23:21 UTC (rev 283090) @@ -1455,3 +1455,6 @@ [ Catalina Debug ] webgl/2.0.0/conformance/rendering/draw-elements-out-of-bounds.html [ Pass Timeout ] webkit.org/b/230777 [ Catalina Debug ] transitions/transition-end-event-destroy-renderer.html [ Pass Crash ] + +webkit.org/b/230807 [ Catalina Debug ] media/media-source/media-source-append-before-last-range-no-quota-exceeded.html [ Pass Crash ] +webkit.org/b/230807 [ Catalina Debug ] media/media-source/media-source-remove.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283088] trunk/Source/JavaScriptCore
Title: [283088] trunk/Source/_javascript_Core Revision 283088 Author sbar...@apple.com Date 2021-09-26 10:23:15 -0700 (Sun, 26 Sep 2021) Log Message Make byte codes with arithmetic profiles switch to using an index instead of a pointer in metadata https://bugs.webkit.org/show_bug.cgi?id=230798 Reviewed by Yusuke Suzuki. This patch makes each bytecode that uses a BinaryArithProfile/UnaryArithProfile have an index into a table instead of storing a pointer to the profile in its metadata. Then, we can just load the profile using the index in the bytecode, which saves memory. * bytecode/BytecodeList.rb: * bytecode/CodeBlock.cpp: (JSC::CodeBlock::finishCreation): (JSC::CodeBlock::binaryArithProfileForPC): (JSC::CodeBlock::unaryArithProfileForPC): * bytecode/UnlinkedCodeBlock.cpp: (JSC::UnlinkedCodeBlock::allocateSharedProfiles): * bytecode/UnlinkedCodeBlock.h: * bytecode/UnlinkedCodeBlockGenerator.cpp: (JSC::UnlinkedCodeBlockGenerator::finalize): * bytecode/UnlinkedCodeBlockGenerator.h: (JSC::UnlinkedCodeBlockGenerator::addBinaryArithProfile): (JSC::UnlinkedCodeBlockGenerator::addUnaryArithProfile): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitUnaryOp): (JSC::BytecodeGenerator::emitInc): (JSC::BytecodeGenerator::emitDec): * bytecompiler/BytecodeGenerator.h: * jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_sub): * llint/LowLevelInterpreter.asm: * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: * runtime/CommonSlowPaths.cpp: (JSC::updateArithProfileForUnaryArithOp): (JSC::JSC_DEFINE_COMMON_SLOW_PATH): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/BytecodeList.rb trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlockGenerator.cpp trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlockGenerator.h trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h trunk/Source/_javascript_Core/jit/JITArithmetic.cpp trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm trunk/Source/_javascript_Core/offlineasm/cloop.rb trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (283087 => 283088) --- trunk/Source/_javascript_Core/ChangeLog 2021-09-26 13:47:42 UTC (rev 283087) +++ trunk/Source/_javascript_Core/ChangeLog 2021-09-26 17:23:15 UTC (rev 283088) @@ -1,3 +1,45 @@ +2021-09-26 Saam Barati + +Make byte codes with arithmetic profiles switch to using an index instead of a pointer in metadata +https://bugs.webkit.org/show_bug.cgi?id=230798 + +Reviewed by Yusuke Suzuki. + +This patch makes each bytecode that uses a BinaryArithProfile/UnaryArithProfile +have an index into a table instead of storing a pointer to the profile in its metadata. +Then, we can just load the profile using the index in the bytecode, which saves memory. + +* bytecode/BytecodeList.rb: +* bytecode/CodeBlock.cpp: +(JSC::CodeBlock::finishCreation): +(JSC::CodeBlock::binaryArithProfileForPC): +(JSC::CodeBlock::unaryArithProfileForPC): +* bytecode/UnlinkedCodeBlock.cpp: +(JSC::UnlinkedCodeBlock::allocateSharedProfiles): +* bytecode/UnlinkedCodeBlock.h: +* bytecode/UnlinkedCodeBlockGenerator.cpp: +(JSC::UnlinkedCodeBlockGenerator::finalize): +* bytecode/UnlinkedCodeBlockGenerator.h: +(JSC::UnlinkedCodeBlockGenerator::addBinaryArithProfile): +(JSC::UnlinkedCodeBlockGenerator::addUnaryArithProfile): +* bytecompiler/BytecodeGenerator.cpp: +(JSC::BytecodeGenerator::emitUnaryOp): +(JSC::BytecodeGenerator::emitInc): +(JSC::BytecodeGenerator::emitDec): +* bytecompiler/BytecodeGenerator.h: +* jit/JITArithmetic.cpp: +(JSC::JIT::emit_op_negate): +(JSC::JIT::emit_op_add): +(JSC::JIT::emit_op_div): +(JSC::JIT::emit_op_mul): +(JSC::JIT::emit_op_sub): +* llint/LowLevelInterpreter.asm: +* llint/LowLevelInterpreter32_64.asm: +* llint/LowLevelInterpreter64.asm: +* runtime/CommonSlowPaths.cpp: +(JSC::updateArithProfileForUnaryArithOp): +(JSC::JSC_DEFINE_COMMON_SLOW_PATH): + 2021-09-25 Saam Barati Build an unlinked baseline JIT Modified: trunk/Source/_javascript_Core/bytecode/BytecodeList.rb (283087 => 283088) --- trunk/Source/_javascript_Core/bytecode/BytecodeList.rb 2021-09-26 13:47:42 UTC (rev 283087) +++
[webkit-changes] [283087] trunk
Title: [283087] trunk
Revision 283087
Author an...@apple.com
Date 2021-09-26 06:47:42 -0700 (Sun, 26 Sep 2021)
Log Message
Line iterator firstRun/lastRun may return runs from wrong lines
https://bugs.webkit.org/show_bug.cgi?id=230770
Reviewed by Alan Bujtas.
Source/WebCore:
In some situation line iterator firstRun/lastRun could return runs from different lines.
This could lead to inconsistencies like firstRun being non-null while lastRun is null.
Test: editing/iterator-line-start-end.html
* layout/integration/LayoutIntegrationLineIteratorModernPath.h:
(WebCore::LayoutIntegration::LineIteratorModernPath::firstRun const):
(WebCore::LayoutIntegration::LineIteratorModernPath::lastRun const):
Take care to only return runs from this line.
LayoutTests:
* editing/iterator-line-start-end-expected.txt: Added.
* editing/iterator-line-start-end.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h
Added Paths
trunk/LayoutTests/editing/iterator-line-start-end-expected.txt
trunk/LayoutTests/editing/iterator-line-start-end.html
Diff
Modified: trunk/LayoutTests/ChangeLog (283086 => 283087)
--- trunk/LayoutTests/ChangeLog 2021-09-26 06:21:43 UTC (rev 283086)
+++ trunk/LayoutTests/ChangeLog 2021-09-26 13:47:42 UTC (rev 283087)
@@ -1,3 +1,14 @@
+2021-09-26 Antti Koivisto
+
+Line iterator firstRun/lastRun may return runs from wrong lines
+https://bugs.webkit.org/show_bug.cgi?id=230770
+
+
+Reviewed by Alan Bujtas.
+
+* editing/iterator-line-start-end-expected.txt: Added.
+* editing/iterator-line-start-end.html: Added.
+
2021-09-23 Tim Nguyen
Make inert nodes invisible to hit testing
Added: trunk/LayoutTests/editing/iterator-line-start-end-expected.txt (0 => 283087)
--- trunk/LayoutTests/editing/iterator-line-start-end-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/iterator-line-start-end-expected.txt 2021-09-26 13:47:42 UTC (rev 283087)
@@ -0,0 +1,3 @@
+
+This test passes if it doesn't crash
+x x
Added: trunk/LayoutTests/editing/iterator-line-start-end.html (0 => 283087)
--- trunk/LayoutTests/editing/iterator-line-start-end.html (rev 0)
+++ trunk/LayoutTests/editing/iterator-line-start-end.html 2021-09-26 13:47:42 UTC (rev 283087)
@@ -0,0 +1,9 @@
+
+This test passes if it doesn't crash
+x x
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.execCommand("selectAll");
+
Modified: trunk/Source/WebCore/ChangeLog (283086 => 283087)
--- trunk/Source/WebCore/ChangeLog 2021-09-26 06:21:43 UTC (rev 283086)
+++ trunk/Source/WebCore/ChangeLog 2021-09-26 13:47:42 UTC (rev 283087)
@@ -1,3 +1,22 @@
+2021-09-26 Antti Koivisto
+
+Line iterator firstRun/lastRun may return runs from wrong lines
+https://bugs.webkit.org/show_bug.cgi?id=230770
+
+
+Reviewed by Alan Bujtas.
+
+In some situation line iterator firstRun/lastRun could return runs from different lines.
+This could lead to inconsistencies like firstRun being non-null while lastRun is null.
+
+Test: editing/iterator-line-start-end.html
+
+* layout/integration/LayoutIntegrationLineIteratorModernPath.h:
+(WebCore::LayoutIntegration::LineIteratorModernPath::firstRun const):
+(WebCore::LayoutIntegration::LineIteratorModernPath::lastRun const):
+
+Take care to only return runs from this line.
+
2021-09-25 Alan Bujtas
Fix win build.
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h (283086 => 283087)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h 2021-09-26 06:21:43 UTC (rev 283086)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h 2021-09-26 13:47:42 UTC (rev 283087)
@@ -102,7 +102,7 @@
return { *m_inlineContent };
auto runIterator = RunIteratorModernPath { *m_inlineContent, line().firstBoxIndex() };
if (runIterator.box().isInlineBox())
-runIterator.traverseNextLeaf();
+runIterator.traverseNextOnLine();
return runIterator;
}
@@ -113,7 +113,7 @@
return { *m_inlineContent };
auto runIterator = RunIteratorModernPath { *m_inlineContent, line().firstBoxIndex() + boxCount - 1 };
if (runIterator.box().isInlineBox())
-runIterator.traversePreviousLeaf();
+
[webkit-changes] [283086] trunk/LayoutTests/imported/w3c
Title: [283086] trunk/LayoutTests/imported/w3c Revision 283086 Author mmaxfi...@apple.com Date 2021-09-25 23:21:43 -0700 (Sat, 25 Sep 2021) Log Message Test palette animations https://bugs.webkit.org/show_bug.cgi?id=230677 Fix palette animations tests after r283077. Unreviewed. * web-platform-tests/css/css-fonts/animations/font-palette-animation-2-expected.html: * web-platform-tests/css/css-fonts/animations/font-palette-animation-2.html: * web-platform-tests/css/css-fonts/animations/font-palette-animation-3-expected-mismatch.html: * web-platform-tests/css/css-fonts/animations/font-palette-animation-3.html: * web-platform-tests/css/css-fonts/animations/font-palette-animation-expected.html: * web-platform-tests/css/css-fonts/animations/font-palette-animation.html: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-2-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-2.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-3-expected-mismatch.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-3.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (283085 => 283086) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-26 04:31:22 UTC (rev 283085) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-26 06:21:43 UTC (rev 283086) @@ -4,6 +4,23 @@ https://bugs.webkit.org/show_bug.cgi?id=230677 +Fix palette animations tests after r283077. + +Unreviewed. + +* web-platform-tests/css/css-fonts/animations/font-palette-animation-2-expected.html: +* web-platform-tests/css/css-fonts/animations/font-palette-animation-2.html: +* web-platform-tests/css/css-fonts/animations/font-palette-animation-3-expected-mismatch.html: +* web-platform-tests/css/css-fonts/animations/font-palette-animation-3.html: +* web-platform-tests/css/css-fonts/animations/font-palette-animation-expected.html: +* web-platform-tests/css/css-fonts/animations/font-palette-animation.html: + +2021-09-25 Myles C. Maxfield + +Test palette animations +https://bugs.webkit.org/show_bug.cgi?id=230677 + + Reviewed by Simon Fraser. These are being upstreamed at https://github.com/web-platform-tests/wpt/pull/30955. Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-2-expected.html (283085 => 283086) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-2-expected.html 2021-09-26 04:31:22 UTC (rev 283085) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-2-expected.html 2021-09-26 06:21:43 UTC (rev 283086) @@ -8,7 +8,7 @@
