[webkit-changes] [284306] trunk
Title: [284306] trunk
Revision 284306
Author basuke.suz...@sony.com
Date 2021-10-15 22:31:25 -0700 (Fri, 15 Oct 2021)
Log Message
Add flag to turn off Iso heap
https://bugs.webkit.org/show_bug.cgi?id=231823
Reviewed by Yusuke Suzuki.
.:
Added USE_ISO_MALLOC feature flags which is on by default for most platforms.
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/WebKitFeatures.cmake:
Source/WTF:
If this flag is off, then all allocations are replaced with FastMalloc.
* wtf/IsoMalloc.h:
* wtf/IsoMallocInlines.h:
* wtf/PlatformUse.h:
Tools:
Added --(no-)iso-malloc feature flag for cmake build.
* Scripts/webkitperl/FeatureList.pm:
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/IsoMalloc.h
trunk/Source/WTF/wtf/IsoMallocInlines.h
trunk/Source/WTF/wtf/PlatformUse.h
trunk/Source/cmake/OptionsPlayStation.cmake
trunk/Source/cmake/WebKitFeatures.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
Diff
Modified: trunk/ChangeLog (284305 => 284306)
--- trunk/ChangeLog 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/ChangeLog 2021-10-16 05:31:25 UTC (rev 284306)
@@ -1,3 +1,15 @@
+2021-10-15 Basuke Suzuki
+
+Add flag to turn off Iso heap
+https://bugs.webkit.org/show_bug.cgi?id=231823
+
+Reviewed by Yusuke Suzuki.
+
+Added USE_ISO_MALLOC feature flags which is on by default for most platforms.
+
+* Source/cmake/OptionsPlayStation.cmake:
+* Source/cmake/WebKitFeatures.cmake:
+
2021-10-15 Ross Kirsling
Realize Mac CMake build of WebCore and WebKit
Modified: trunk/Source/WTF/ChangeLog (284305 => 284306)
--- trunk/Source/WTF/ChangeLog 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/WTF/ChangeLog 2021-10-16 05:31:25 UTC (rev 284306)
@@ -1,3 +1,16 @@
+2021-10-15 Basuke Suzuki
+
+Add flag to turn off Iso heap
+https://bugs.webkit.org/show_bug.cgi?id=231823
+
+Reviewed by Yusuke Suzuki.
+
+If this flag is off, then all allocations are replaced with FastMalloc.
+
+* wtf/IsoMalloc.h:
+* wtf/IsoMallocInlines.h:
+* wtf/PlatformUse.h:
+
2021-10-15 Ross Kirsling
Realize Mac CMake build of WebCore and WebKit
Modified: trunk/Source/WTF/wtf/IsoMalloc.h (284305 => 284306)
--- trunk/Source/WTF/wtf/IsoMalloc.h 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/WTF/wtf/IsoMalloc.h 2021-10-16 05:31:25 UTC (rev 284306)
@@ -26,8 +26,9 @@
#pragma once
#include
+#include
-#if (USE(SYSTEM_MALLOC))
+#if USE(SYSTEM_MALLOC) || !USE(ISO_MALLOC)
#include
Modified: trunk/Source/WTF/wtf/IsoMallocInlines.h (284305 => 284306)
--- trunk/Source/WTF/wtf/IsoMallocInlines.h 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/WTF/wtf/IsoMallocInlines.h 2021-10-16 05:31:25 UTC (rev 284306)
@@ -25,8 +25,10 @@
#pragma once
-#if (USE(SYSTEM_MALLOC))
+#include
+#if USE(SYSTEM_MALLOC) || !USE(ISO_MALLOC)
+
#include
#define WTF_MAKE_ISO_ALLOCATED_INLINE(name) WTF_MAKE_FAST_ALLOCATED
Modified: trunk/Source/WTF/wtf/PlatformUse.h (284305 => 284306)
--- trunk/Source/WTF/wtf/PlatformUse.h 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/WTF/wtf/PlatformUse.h 2021-10-16 05:31:25 UTC (rev 284306)
@@ -355,3 +355,7 @@
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12
#define USE_VORBIS_AUDIOCOMPONENT_WORKAROUND 1
#endif
+
+#if !defined(USE_ISO_MALLOC)
+#define USE_ISO_MALLOC 1
+#endif
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (284305 => 284306)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2021-10-16 05:31:25 UTC (rev 284306)
@@ -36,6 +36,9 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DFG_JIT PRIVATE OFF)
+# Don't use IsoMalloc
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_ISO_MALLOC PRIVATE OFF)
+
# Enabled features
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE ON)
Modified: trunk/Source/cmake/WebKitFeatures.cmake (284305 => 284306)
--- trunk/Source/cmake/WebKitFeatures.cmake 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2021-10-16 05:31:25 UTC (rev 284306)
@@ -235,6 +235,7 @@
WEBKIT_OPTION_DEFINE(ENABLE_WEBXR "Toggle WebXR support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_WIRELESS_PLAYBACK_TARGET "Toggle wireless playback target support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_XSLT "Toggle XSLT support" PRIVATE ON)
+WEBKIT_OPTION_DEFINE(USE_ISO_MALLOC "Toggle IsoMalloc support" PRIVATE ON)
WEBKIT_OPTION_DEFINE(USE_SYSTEM_MALLOC "Toggle system allocator instead of WebKit's custom allocator" PRIVATE ${USE_SYSTEM_MALLOC_DEFAULT})
WEBKIT_OPTION_CONFLICT(ENABLE_JIT ENABLE_C_LOOP)
Modified: trunk/Tools/ChangeLog (284305 => 284306)
--- trunk/Tools/ChangeLog 2021-10-16 04:38:16
[webkit-changes] [284305] trunk/Source/bmalloc
Title: [284305] trunk/Source/bmalloc
Revision 284305
Author ysuz...@apple.com
Date 2021-10-15 21:38:16 -0700 (Fri, 15 Oct 2021)
Log Message
[libpas] Enable libpas on macOS
https://bugs.webkit.org/show_bug.cgi?id=231815
Reviewed by Saam Barati.
Enabling libpas on x64 macOS. Previously, we enabled it only on AppleSilicon.
This helps stressing libpas on fuzzers more. And it offers large performance
improvement.
1. Speedometer2 is 2.1% improved on low-end macOS (MBA8,2) and 1.7% improved on high-end macOS (MBP14,1).
2. JetStream2 is neutral on both.
* bmalloc/BPlatform.h:
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/BPlatform.h
Diff
Modified: trunk/Source/bmalloc/ChangeLog (284304 => 284305)
--- trunk/Source/bmalloc/ChangeLog 2021-10-16 04:11:59 UTC (rev 284304)
+++ trunk/Source/bmalloc/ChangeLog 2021-10-16 04:38:16 UTC (rev 284305)
@@ -1,3 +1,19 @@
+2021-10-15 Yusuke Suzuki
+
+[libpas] Enable libpas on macOS
+https://bugs.webkit.org/show_bug.cgi?id=231815
+
+Reviewed by Saam Barati.
+
+Enabling libpas on x64 macOS. Previously, we enabled it only on AppleSilicon.
+This helps stressing libpas on fuzzers more. And it offers large performance
+improvement.
+
+1. Speedometer2 is 2.1% improved on low-end macOS (MBA8,2) and 1.7% improved on high-end macOS (MBP14,1).
+2. JetStream2 is neutral on both.
+
+* bmalloc/BPlatform.h:
+
2021-10-14 Yusuke Suzuki
[libpas] Use `enum { ... }` instead of `static const size_t` for constant values used for array size
Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (284304 => 284305)
--- trunk/Source/bmalloc/bmalloc/BPlatform.h 2021-10-16 04:11:59 UTC (rev 284304)
+++ trunk/Source/bmalloc/bmalloc/BPlatform.h 2021-10-16 04:38:16 UTC (rev 284305)
@@ -311,7 +311,7 @@
/* BENABLE(LIBPAS) is enabling libpas build. But this does not mean we use libpas for bmalloc replacement. */
#if !defined(BENABLE_LIBPAS)
-#if BCPU(ARM64) && BOS(MAC)
+#if BOS(MAC)
#define BENABLE_LIBPAS 1
#else
#define BENABLE_LIBPAS 0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284304] trunk
Title: [284304] trunk
Revision 284304
Author achristen...@apple.com
Date 2021-10-15 21:11:59 -0700 (Fri, 15 Oct 2021)
Log Message
Start using adattributiond on iOS
https://bugs.webkit.org/show_bug.cgi?id=231829
Reviewed by Brady Eidson.
Source/WebKit:
This makes one small change to use adattributiond on iOS by default instead of the network process.
The rest of this patch is to keep the tests doing what they used to.
* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:
(WKWebsiteDataStoreConfigurationCopyPCMMachServiceName):
(WKWebsiteDataStoreConfigurationSetPCMMachServiceName):
* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:
* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
(TestWebKitAPI::configurationWithoutUsingDaemon):
(TestWebKitAPI::webViewWithoutUsingDaemon):
(TestWebKitAPI::runBasicPCMTest):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:
(webViewWithResourceLoadStatisticsEnabledInNetworkProcess):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::configureWebsiteDataStoreTemporaryDirectories):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284303 => 284304)
--- trunk/Source/WebKit/ChangeLog 2021-10-16 03:17:19 UTC (rev 284303)
+++ trunk/Source/WebKit/ChangeLog 2021-10-16 04:11:59 UTC (rev 284304)
@@ -1,5 +1,22 @@
2021-10-15 Alex Christensen
+Start using adattributiond on iOS
+https://bugs.webkit.org/show_bug.cgi?id=231829
+
+Reviewed by Brady Eidson.
+
+This makes one small change to use adattributiond on iOS by default instead of the network process.
+The rest of this patch is to keep the tests doing what they used to.
+
+* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:
+(WKWebsiteDataStoreConfigurationCopyPCMMachServiceName):
+(WKWebsiteDataStoreConfigurationSetPCMMachServiceName):
+* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:
+* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
+(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
+
+2021-10-15 Alex Christensen
+
Use attributedBundleIdentifier instead of applicationBundleIdentifier when present for handling PCM attribution
https://bugs.webkit.org/show_bug.cgi?id=231827
Modified: trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp (284303 => 284304)
--- trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp 2021-10-16 03:17:19 UTC (rev 284303)
+++ trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp 2021-10-16 04:11:59 UTC (rev 284304)
@@ -179,3 +179,13 @@
{
WebKit::toImpl(configuration)->setStaleWhileRevalidateEnabled(enabled);
}
+
+WKStringRef WKWebsiteDataStoreConfigurationCopyPCMMachServiceName(WKWebsiteDataStoreConfigurationRef configuration)
+{
+return WebKit::toCopiedAPI(WebKit::toImpl(configuration)->pcmMachServiceName());
+}
+
+void WKWebsiteDataStoreConfigurationSetPCMMachServiceName(WKWebsiteDataStoreConfigurationRef configuration, WKStringRef name)
+{
+WebKit::toImpl(configuration)->setPCMMachServiceName(name ? WebKit::toImpl(name)->string() : String());
+}
Modified: trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h (284303 => 284304)
--- trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h 2021-10-16 03:17:19 UTC (rev 284303)
+++ trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h 2021-10-16 04:11:59 UTC (rev 284304)
@@ -78,6 +78,9 @@
WK_EXPORT bool WKWebsiteDataStoreConfigurationGetStaleWhileRevalidateEnabled(WKWebsiteDataStoreConfigurationRef configuration);
WK_EXPORT void WKWebsiteDataStoreConfigurationSetStaleWhileRevalidateEnabled(WKWebsiteDataStoreConfigurationRef configuration, bool enabled);
+WK_EXPORT WKStringRef WKWebsiteDataStoreConfigurationCopyPCMMachServiceName(WKWebsiteDataStoreConfigurationRef configuration);
+WK_EXPORT void WKWebsiteDataStoreConfigurationSetPCMMachServiceName(WKWebsiteDataStoreConfigurationRef configuration, WKStringRef name);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp (284303 => 284304)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp 2021-10-16 03:17:19 UTC (rev 284303)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp 2021-10-16 04:11:59 UTC (rev 284304)
@@ -51,7 +51,9 @@
[webkit-changes] [284303] trunk
Title: [284303] trunk
Revision 284303
Author an...@apple.com
Date 2021-10-15 20:17:19 -0700 (Fri, 15 Oct 2021)
Log Message
[LFC][Integration] Enable inline boxes with borders
https://bugs.webkit.org/show_bug.cgi?id=231562
Reviewed by Alan Bujtas.
Source/WebCore:
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForRenderInlineChild):
* layout/integration/LayoutIntegrationCoverage.h:
LayoutTests:
* fast/css/pseudo-first-line-border-width-expected.txt:
* fast/text/apply-start-width-after-skipped-text-expected.txt:
* platform/ios/fast/borders/border-image-outset-split-inline-expected.txt:
* platform/ios/fast/css/pseudo-first-line-border-width-expected.txt:
* platform/mac/fast/borders/border-image-outset-split-inline-expected.txt:
* platform/mac/fast/text/basic/015-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/pseudo-first-line-border-width-expected.txt
trunk/LayoutTests/fast/text/apply-start-width-after-skipped-text-expected.txt
trunk/LayoutTests/platform/ios/fast/backgrounds/border-radius-split-background-expected.txt
trunk/LayoutTests/platform/ios/fast/backgrounds/border-radius-split-background-image-expected.txt
trunk/LayoutTests/platform/ios/fast/borders/border-image-outset-split-inline-expected.txt
trunk/LayoutTests/platform/ios/fast/borders/border-styles-split-expected.txt
trunk/LayoutTests/platform/ios/fast/css/pseudo-first-line-border-width-expected.txt
trunk/LayoutTests/platform/mac/fast/backgrounds/border-radius-split-background-expected.txt
trunk/LayoutTests/platform/mac/fast/backgrounds/border-radius-split-background-image-expected.txt
trunk/LayoutTests/platform/mac/fast/borders/border-image-outset-split-inline-expected.txt
trunk/LayoutTests/platform/mac/fast/borders/border-styles-split-expected.txt
trunk/LayoutTests/platform/mac/fast/text/basic/015-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
Diff
Modified: trunk/LayoutTests/ChangeLog (284302 => 284303)
--- trunk/LayoutTests/ChangeLog 2021-10-16 03:03:52 UTC (rev 284302)
+++ trunk/LayoutTests/ChangeLog 2021-10-16 03:17:19 UTC (rev 284303)
@@ -1,3 +1,17 @@
+2021-10-15 Antti Koivisto
+
+[LFC][Integration] Enable inline boxes with borders
+https://bugs.webkit.org/show_bug.cgi?id=231562
+
+Reviewed by Alan Bujtas.
+
+* fast/css/pseudo-first-line-border-width-expected.txt:
+* fast/text/apply-start-width-after-skipped-text-expected.txt:
+* platform/ios/fast/borders/border-image-outset-split-inline-expected.txt:
+* platform/ios/fast/css/pseudo-first-line-border-width-expected.txt:
+* platform/mac/fast/borders/border-image-outset-split-inline-expected.txt:
+* platform/mac/fast/text/basic/015-expected.txt:
+
2021-10-15 Commit Queue
Unreviewed, reverting r284245.
Modified: trunk/LayoutTests/fast/css/pseudo-first-line-border-width-expected.txt (284302 => 284303)
--- trunk/LayoutTests/fast/css/pseudo-first-line-border-width-expected.txt 2021-10-16 03:03:52 UTC (rev 284302)
+++ trunk/LayoutTests/fast/css/pseudo-first-line-border-width-expected.txt 2021-10-16 03:17:19 UTC (rev 284303)
@@ -1,8 +1,8 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x540
- RenderBlock {HTML} at (0,0) size 800x540
-RenderBody {BODY} at (8,8) size 784x432
+layer at (0,0) size 800x450
+ RenderBlock {HTML} at (0,0) size 800x450
+RenderBody {BODY} at (8,8) size 784x342
RenderBlock {DIV} at (0,0) size 784x32
RenderText {#text} at (0,0) size 144x16
text run at (0,0) width 144: "Test for "
@@ -10,13 +10,13 @@
RenderText {#text} at (144,0) size 736x32
text run at (144,0) width 592: "https://bugs.webkit.org/show_bug.cgi?"
text run at (0,16) width 128: "id=79526"
- RenderBlock {P} at (0,132) size 784x300
-RenderText {#text} at (0,72) size 350x10
- text run at (0,72) width 350: "A green 10px border on the left of "
-RenderInline {SPAN} at (0,0) size 500x228 [border: none (100px solid #008000)]
- RenderText {#text} at (360,72) size 50x10
-text run at (360,72) width 50: "this,"
- RenderBR {BR} at (410,0) size 0x100
- RenderText {#text} at (0,100) size 500x200
-text run at (0,100) width 400: "is a"
-text run at (0,200) width 500: "pass."
+ RenderBlock {P} at (0,132) size 784x210
+RenderText {#text} at (0,0) size 350x10
+ text run at (0,0) width 350: "A green 10px border on the left of "
+RenderInline {SPAN} at (0,0) size 500x210 [border: none (100px solid #008000)]
+ RenderText {#text} at (450,0) size 50x10
+text run at (450,0) width 50: "this,"
+ RenderBR {BR} at
[webkit-changes] [284302] trunk/Source/WebCore
Title: [284302] trunk/Source/WebCore
Revision 284302
Author simon.fra...@apple.com
Date 2021-10-15 20:03:52 -0700 (Fri, 15 Oct 2021)
Log Message
Rename some keyboard-scrolling-related functions on ScrollingEffectsController for clarity
https://bugs.webkit.org/show_bug.cgi?id=231842
Reviewed by Beth Dakin.
Rename beginKeyboardScrolling/stopKeyboardScrolling to willBegin and didStop to make
it clear that they are responding to KeyboardScrollingAnimator state changes.
Add the imperative ScrollingEffectsController::stopKeyboardScrolling() which will get
hooked up soon.
* platform/KeyboardScrollingAnimator.cpp:
(WebCore::KeyboardScrollingAnimator::updateKeyboardScrollPosition):
(WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):
* platform/ScrollingEffectsController.cpp:
(WebCore::ScrollingEffectsController::willBeginKeyboardScrolling):
(WebCore::ScrollingEffectsController::didStopKeyboardScrolling):
(WebCore::ScrollingEffectsController::stopKeyboardScrolling):
(WebCore::ScrollingEffectsController::beginKeyboardScrolling): Deleted.
* platform/ScrollingEffectsController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp
trunk/Source/WebCore/platform/ScrollingEffectsController.cpp
trunk/Source/WebCore/platform/ScrollingEffectsController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (284301 => 284302)
--- trunk/Source/WebCore/ChangeLog 2021-10-16 02:59:03 UTC (rev 284301)
+++ trunk/Source/WebCore/ChangeLog 2021-10-16 03:03:52 UTC (rev 284302)
@@ -1,3 +1,26 @@
+2021-10-15 Simon Fraser
+
+Rename some keyboard-scrolling-related functions on ScrollingEffectsController for clarity
+https://bugs.webkit.org/show_bug.cgi?id=231842
+
+Reviewed by Beth Dakin.
+
+Rename beginKeyboardScrolling/stopKeyboardScrolling to willBegin and didStop to make
+it clear that they are responding to KeyboardScrollingAnimator state changes.
+
+Add the imperative ScrollingEffectsController::stopKeyboardScrolling() which will get
+hooked up soon.
+
+* platform/KeyboardScrollingAnimator.cpp:
+(WebCore::KeyboardScrollingAnimator::updateKeyboardScrollPosition):
+(WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):
+* platform/ScrollingEffectsController.cpp:
+(WebCore::ScrollingEffectsController::willBeginKeyboardScrolling):
+(WebCore::ScrollingEffectsController::didStopKeyboardScrolling):
+(WebCore::ScrollingEffectsController::stopKeyboardScrolling):
+(WebCore::ScrollingEffectsController::beginKeyboardScrolling): Deleted.
+* platform/ScrollingEffectsController.h:
+
2021-10-15 Commit Queue
Unreviewed, reverting r284245.
Modified: trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp (284301 => 284302)
--- trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp 2021-10-16 02:59:03 UTC (rev 284301)
+++ trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp 2021-10-16 03:03:52 UTC (rev 284302)
@@ -140,7 +140,7 @@
m_scrollAnimator.scrollToPositionWithoutAnimation(newPosition);
if (!m_scrollTriggeringKeyIsPressed && m_velocity.diagonalLengthSquared() < 1) {
-m_scrollController.stopKeyboardScrolling();
+m_scrollController.didStopKeyboardScrolling();
m_velocity = { };
}
}
@@ -279,7 +279,7 @@
m_scrollTriggeringKeyIsPressed = true;
m_idealPositionForMinimumTravel = m_scrollAnimator.currentPosition() + m_currentKeyboardScroll->offset;
-m_scrollController.beginKeyboardScrolling();
+m_scrollController.willBeginKeyboardScrolling();
return true;
}
Modified: trunk/Source/WebCore/platform/ScrollingEffectsController.cpp (284301 => 284302)
--- trunk/Source/WebCore/platform/ScrollingEffectsController.cpp 2021-10-16 02:59:03 UTC (rev 284301)
+++ trunk/Source/WebCore/platform/ScrollingEffectsController.cpp 2021-10-16 03:03:52 UTC (rev 284302)
@@ -84,12 +84,12 @@
m_isRunningAnimatingCallback = false;
}
-void ScrollingEffectsController::beginKeyboardScrolling()
+void ScrollingEffectsController::willBeginKeyboardScrolling()
{
setIsAnimatingKeyboardScrolling(true);
}
-void ScrollingEffectsController::stopKeyboardScrolling()
+void ScrollingEffectsController::didStopKeyboardScrolling()
{
setIsAnimatingKeyboardScrolling(false);
}
@@ -168,6 +168,14 @@
startOrStopAnimationCallbacks();
}
+void ScrollingEffectsController::stopKeyboardScrolling()
+{
+if (!m_isAnimatingKeyboardScrolling)
+return;
+
+m_client.keyboardScrollingAnimator()->handleKeyUpEvent();
+}
+
void ScrollingEffectsController::contentsSizeChanged()
{
if (m_currentAnimation)
Modified: trunk/Source/WebCore/platform/ScrollingEffectsController.h (284301 => 284302)
--- trunk/Source/WebCore/platform/ScrollingEffectsController.h 2021-10-16 02:59:03 UTC (rev 284301)
+++
[webkit-changes] [284301] trunk
Title: [284301] trunk
Revision 284301
Author achristen...@apple.com
Date 2021-10-15 19:59:03 -0700 (Fri, 15 Oct 2021)
Log Message
Use attributedBundleIdentifier instead of applicationBundleIdentifier when present for handling PCM attribution
https://bugs.webkit.org/show_bug.cgi?id=231827
Reviewed by Brady Eidson.
Source/WebKit:
This is the same identifier that SafariViewController uses in _setEphemeralUIEventAttribution:forApplicationWithBundleID:
If we don't do this, then SafariViewController looks in the database for PCMs from com.apple.SafariViewService and doesn't find any and doesn't send any reports.
* NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::attributedBundleIdentifier):
* NetworkProcess/NetworkDataTask.h:
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::attributedBundleIdentifier):
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::handlePrivateClickMeasurementConversion):
* NetworkProcess/NetworkSession.h:
* UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _addEventAttributionWithSourceID:destinationURL:sourceDescription:purchaser:reportEndpoint:optionalNonce:applicationBundleID:ephemeral:]):
(-[WKWebView _addEventAttributionWithSourceID:destinationURL:sourceDescription:purchaser:reportEndpoint:optionalNonce:applicationBundleID:]): Deleted.
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
(TestWebKitAPI::runBasicPCMTest):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp
trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h
trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoad.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSession.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284300 => 284301)
--- trunk/Source/WebKit/ChangeLog 2021-10-16 01:43:14 UTC (rev 284300)
+++ trunk/Source/WebKit/ChangeLog 2021-10-16 02:59:03 UTC (rev 284301)
@@ -1,3 +1,30 @@
+2021-10-15 Alex Christensen
+
+Use attributedBundleIdentifier instead of applicationBundleIdentifier when present for handling PCM attribution
+https://bugs.webkit.org/show_bug.cgi?id=231827
+
+Reviewed by Brady Eidson.
+
+This is the same identifier that SafariViewController uses in _setEphemeralUIEventAttribution:forApplicationWithBundleID:
+If we don't do this, then SafariViewController looks in the database for PCMs from com.apple.SafariViewService and doesn't find any and doesn't send any reports.
+
+* NetworkProcess/NetworkDataTask.cpp:
+(WebKit::NetworkDataTask::attributedBundleIdentifier):
+* NetworkProcess/NetworkDataTask.h:
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::attributedBundleIdentifier):
+* NetworkProcess/NetworkLoad.h:
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
+* NetworkProcess/NetworkResourceLoader.h:
+* NetworkProcess/NetworkSession.cpp:
+(WebKit::NetworkSession::handlePrivateClickMeasurementConversion):
+* NetworkProcess/NetworkSession.h:
+* UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
+* UIProcess/API/Cocoa/WKWebViewTesting.mm:
+(-[WKWebView _addEventAttributionWithSourceID:destinationURL:sourceDescription:purchaser:reportEndpoint:optionalNonce:applicationBundleID:ephemeral:]):
+(-[WKWebView _addEventAttributionWithSourceID:destinationURL:sourceDescription:purchaser:reportEndpoint:optionalNonce:applicationBundleID:]): Deleted.
+
2021-10-15 Per Arne Vollan
[macOS] Add telemetry for system calls in WP
Modified: trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp (284300 => 284301)
--- trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp 2021-10-16 01:43:14 UTC (rev 284300)
+++ trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp 2021-10-16 02:59:03 UTC (rev 284301)
@@ -175,4 +175,11 @@
#endif
}
+String NetworkDataTask::attributedBundleIdentifier(WebPageProxyIdentifier pageID)
+{
+if (auto* session = networkSession())
+return session->attributedBundleIdentifierFromPageIdentifier(pageID);
+return { };
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h (284300 => 284301)
---
[webkit-changes] [284300] trunk/Source/WebKit
Title: [284300] trunk/Source/WebKit Revision 284300 Author pvol...@apple.com Date 2021-10-15 18:43:14 -0700 (Fri, 15 Oct 2021) Log Message [macOS] Add telemetry for system calls in WP https://bugs.webkit.org/show_bug.cgi?id=231836 Reviewed by Brent Fulgham. Add telemetry for system calls in WP to understand in which context they are being used. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (284299 => 284300) --- trunk/Source/WebKit/ChangeLog 2021-10-16 00:49:33 UTC (rev 284299) +++ trunk/Source/WebKit/ChangeLog 2021-10-16 01:43:14 UTC (rev 284300) @@ -1,3 +1,15 @@ +2021-10-15 Per Arne Vollan + +[macOS] Add telemetry for system calls in WP +https://bugs.webkit.org/show_bug.cgi?id=231836 + + +Reviewed by Brent Fulgham. + +Add telemetry for system calls in WP to understand in which context they are being used. + +* WebProcess/com.apple.WebProcess.sb.in: + 2021-10-15 Ross Kirsling Realize Mac CMake build of WebCore and WebKit Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (284299 => 284300) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-10-16 00:49:33 UTC (rev 284299) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-10-16 01:43:14 UTC (rev 284300) @@ -1862,179 +1862,182 @@ (when (defined? 'syscall-unix) (deny syscall-unix (with send-signal SIGKILL)) +(allow syscall-unix (syscall-number +SYS___disable_threadsignal +SYS___mac_syscall +SYS___pthread_sigmask +SYS___semwait_signal +SYS_access +SYS_bsdthread_create +SYS_bsdthread_ctl +SYS_bsdthread_terminate +SYS_csrctl +SYS_exit +SYS_faccessat ;; +SYS_fcntl +SYS_fcntl_nocancel +SYS_fgetxattr +SYS_fileport_makefd +SYS_flock +SYS_fsgetpath +SYS_fstat64 +SYS_fstatat64 +SYS_fstatfs64 +SYS_ftruncate +SYS_getattrlist +SYS_getattrlistbulk +SYS_getaudit_addr +SYS_getdirentries64 +SYS_getentropy +SYS_geteuid +SYS_getfsstat64 +SYS_getgid +SYS_gethostuuid +SYS_getrlimit +SYS_getrusage +SYS_gettimeofday +SYS_getuid +SYS_getxattr +SYS_issetugid +SYS_kdebug_trace +SYS_kdebug_trace64 +SYS_kdebug_trace_string ;; Needed for performance sampling, see . +SYS_kevent_id +SYS_kevent_qos +SYS_kqueue_workloop_ctl ;; +SYS_listxattr +SYS_lseek +SYS_lstat64 +SYS_madvise +SYS_mincore +SYS_mkdir +SYS_mmap +SYS_mprotect +SYS_msync +SYS_munmap +SYS_pathconf +SYS_pread +SYS_psynch_cvbroad +SYS_psynch_cvclrprepost +SYS_psynch_cvsignal +SYS_psynch_cvwait +SYS_psynch_mutexdrop +SYS_psynch_mutexwait +SYS_psynch_rw_unlock +SYS_psynch_rw_wrlock +SYS_read +SYS_read_nocancel +SYS_readlink +SYS_rename +SYS_sendto +SYS_sigaltstack +SYS_sigprocmask +SYS_socket +SYS_stat64 +SYS_statfs64 +SYS_thread_selfid +SYS_ulock_wait +SYS_ulock_wake +SYS_umask +SYS_work_interval_ctl +SYS_workq_kernreturn)) + (allow syscall-unix -(syscall-number SYS___disable_threadsignal) -(syscall-number SYS___mac_syscall) -(syscall-number SYS___pthread_kill) -(syscall-number SYS___pthread_markcancel) -(syscall-number SYS___pthread_sigmask) -(syscall-number SYS___semwait_signal) -(syscall-number SYS___semwait_signal_nocancel) -(syscall-number SYS_abort_with_payload) -(syscall-number SYS_access) -(syscall-number SYS_bsdthread_create) -(syscall-number SYS_bsdthread_ctl) -(syscall-number SYS_bsdthread_terminate) -(syscall-number SYS_change_fdguard_np) -(syscall-number SYS_chmod) -(syscall-number SYS_chmod_extended) -(syscall-number SYS_close) -(syscall-number SYS_close_nocancel) -(syscall-number SYS_connect) -(syscall-number SYS_connect_nocancel) -(syscall-number SYS_connectx) -(syscall-number SYS_csops) -(syscall-number SYS_csops_audittoken) -(syscall-number SYS_csrctl) -(syscall-number SYS_dup) -(syscall-number SYS_exit) -(syscall-number SYS_faccessat) ;; -(syscall-number SYS_fchmod) -(syscall-number SYS_fcntl) -(syscall-number SYS_fcntl_nocancel) -(syscall-number SYS_fgetattrlist) ;; -(syscall-number SYS_fgetxattr) -(syscall-number SYS_fileport_makefd) -
[webkit-changes] [284299] trunk
Title: [284299] trunk Revision 284299 Author commit-qu...@webkit.org Date 2021-10-15 17:49:33 -0700 (Fri, 15 Oct 2021) Log Message Unreviewed, reverting r284245. https://bugs.webkit.org/show_bug.cgi?id=231848 Caused Reverted changeset: "AX: WebKit should not expose redundant AXGroups with missing role when the label is the same as the contents" https://bugs.webkit.org/show_bug.cgi?id=169924 https://commits.webkit.org/r284245 Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm Removed Paths trunk/LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt trunk/LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html Diff Modified: trunk/LayoutTests/ChangeLog (284298 => 284299) --- trunk/LayoutTests/ChangeLog 2021-10-16 00:44:06 UTC (rev 284298) +++ trunk/LayoutTests/ChangeLog 2021-10-16 00:49:33 UTC (rev 284299) @@ -1,3 +1,17 @@ +2021-10-15 Commit Queue + +Unreviewed, reverting r284245. +https://bugs.webkit.org/show_bug.cgi?id=231848 + +Caused + +Reverted changeset: + +"AX: WebKit should not expose redundant AXGroups with missing +role when the label is the same as the contents" +https://bugs.webkit.org/show_bug.cgi?id=169924 +https://commits.webkit.org/r284245 + 2021-10-15 Robert Jenner REBASELINE: fast/text/capitalize-boundaries.html is a constant text failure Deleted: trunk/LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt (284298 => 284299) --- trunk/LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt 2021-10-16 00:44:06 UTC (rev 284298) +++ trunk/LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt 2021-10-16 00:49:33 UTC (rev 284299) @@ -1,30 +0,0 @@ -This test ensures WebKit ignores groups with redundant accessibility text. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS !ariaLabelGroup is true -PASS !titleGroup is true -PASS !ariaLabelDiv is true -PASS !titleDiv is true -PASS typeof clickHandlerGroup is 'object' -PASS typeof clickHandlerDiv is 'object' -PASS resultElement.role is 'AXRole: AXStaticText' -PASS resultElement.stringValue is 'AXValue: Blue cheese' -PASS resultElement.role is 'AXRole: AXStaticText' -PASS resultElement.stringValue is 'AXValue: Oranges' -PASS contentContainer.childrenCount is 6 -PASS contentContainer.childAtIndex(0).stringValue is 'AXValue: Blue cheese' -PASS contentContainer.childAtIndex(0).role is 'AXRole: AXStaticText' -PASS contentContainer.childAtIndex(1).stringValue is 'AXValue: Oranges' -PASS contentContainer.childAtIndex(1).role is 'AXRole: AXStaticText' -PASS contentContainer.childAtIndex(2).role is 'AXRole: AXGroup' -PASS contentContainer.childAtIndex(3).stringValue is 'AXValue: Jello' -PASS contentContainer.childAtIndex(3).role is 'AXRole: AXStaticText' -PASS contentContainer.childAtIndex(4).stringValue is 'AXValue: Broccoli' -PASS contentContainer.childAtIndex(4).role is 'AXRole: AXStaticText' -PASS contentContainer.childAtIndex(5).role is 'AXRole: AXGroup' -PASS successfullyParsed is true - -TEST COMPLETE - Deleted: trunk/LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html (284298 => 284299) --- trunk/LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html 2021-10-16 00:44:06 UTC (rev 284298) +++ trunk/LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html 2021-10-16 00:49:33 UTC (rev 284299) @@ -1,94 +0,0 @@ - - - - - - -- -- --Blue cheese -- --Oranges -- --Group click handler -- - --Jello -- --Broccoli -- --Div click handler --