date:20211020

[webkit-changes] [284588] trunk

2021-10-20 Thread commit-queue

Title: [284588] trunk








Revision 284588
Author commit-qu...@webkit.org
Date 2021-10-20 17:03:30 -0700 (Wed, 20 Oct 2021)


Log Message
URLParser should reject hosts with C0 control characters or U+007F
https://bugs.webkit.org/show_bug.cgi?id=232034

Patch by Alex Christensen  on 2021-10-20
Reviewed by Tim Horton.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-origin-expected.txt:
* web-platform-tests/url/a-element-origin-xhtml-expected.txt:
* web-platform-tests/url/failure-expected.txt:
* web-platform-tests/url/resources/urltestdata.json:
* web-platform-tests/url/url-character-sets.any-expected.txt: Added.
* web-platform-tests/url/url-character-sets.any.html: Added.
* web-platform-tests/url/url-character-sets.any.js: Added.
(cp.test):
* web-platform-tests/url/url-character-sets.any.worker-expected.txt: Added.
* web-platform-tests/url/url-character-sets.any.worker.html: Added.
* web-platform-tests/url/url-origin.any-expected.txt:
* web-platform-tests/url/url-origin.any.worker-expected.txt:
* web-platform-tests/url/url-setters-stripping.any.js:

Source/WTF:

This matches Chrome and Firefox and was proposed to the standard at
https://github.com/whatwg/url/issues/627

* wtf/URLParser.cpp:
(WTF::isC0Control):
(WTF::isForbiddenHostCodePoint):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/failure-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-stripping.any.js
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URLParser.cpp


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-character-sets.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-character-sets.any.html
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-character-sets.any.js
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-character-sets.any.worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-character-sets.any.worker.html




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284587 => 284588)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-10-21 00:02:20 UTC (rev 284587)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-10-21 00:03:30 UTC (rev 284588)
@@ -1,3 +1,24 @@
+2021-10-20  Alex Christensen  
+
+URLParser should reject hosts with C0 control characters or U+007F
+https://bugs.webkit.org/show_bug.cgi?id=232034
+
+Reviewed by Tim Horton.
+
+* web-platform-tests/url/a-element-origin-expected.txt:
+* web-platform-tests/url/a-element-origin-xhtml-expected.txt:
+* web-platform-tests/url/failure-expected.txt:
+* web-platform-tests/url/resources/urltestdata.json:
+* web-platform-tests/url/url-character-sets.any-expected.txt: Added.
+* web-platform-tests/url/url-character-sets.any.html: Added.
+* web-platform-tests/url/url-character-sets.any.js: Added.
+(cp.test):
+* web-platform-tests/url/url-character-sets.any.worker-expected.txt: Added.
+* web-platform-tests/url/url-character-sets.any.worker.html: Added.
+* web-platform-tests/url/url-origin.any-expected.txt:
+* web-platform-tests/url/url-origin.any.worker-expected.txt:
+* web-platform-tests/url/url-setters-stripping.any.js:
+
 2021-10-20  Youenn Fablet  
 
 Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt (284587 => 284588)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt	2021-10-21 00:02:20 UTC (rev 284587)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt	2021-10-21 00:03:30 UTC (rev 284588)
@@ -264,8 +264,6 @@
 PASS Parsing origin:  against 
 PASS Parsing origin:  against 
 PASS Parsing origin:  against 
-PASS Parsing origin:  against 
-PASS Parsing origin:  against 
 PASS Parsing origin:  against 
 PASS Parsing origin:  against 
 PASS Parsing origin:  against 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt (284587 => 284588)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt	2021-10-21 00:02:20 UTC (rev 284587)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt	2021-10-21 00:03:30 UTC (rev 284588)
@@ -264,8 +264,6 @@
 PASS Parsing origin:  against 
 PASS Parsing origin:  against 
 PASS

[webkit-changes] [284586] tags/Safari-613.1.6/

2021-10-20 Thread repstein

Title: [284586] tags/Safari-613.1.6/








Revision 284586
Author repst...@apple.com
Date 2021-10-20 17:01:44 -0700 (Wed, 20 Oct 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-613.1.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284587] tags/Safari-613.1.6/

2021-10-20 Thread repstein

Title: [284587] tags/Safari-613.1.6/








Revision 284587
Author repst...@apple.com
Date 2021-10-20 17:02:20 -0700 (Wed, 20 Oct 2021)


Log Message
Tag Safari-613.1.6.

Added Paths

tags/Safari-613.1.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284585] trunk/Source/JavaScriptCore

2021-10-20 Thread ysuzuki

Title: [284585] trunk/Source/_javascript_Core








Revision 284585
Author ysuz...@apple.com
Date 2021-10-20 17:00:20 -0700 (Wed, 20 Oct 2021)


Log Message
[JSC] ArithAbs should care about INT32_MIN
https://bugs.webkit.org/show_bug.cgi?id=232051
rdar://84338648

Reviewed by Michael Saboff.

ArithAbs (without overflow check) can return negative value if the input is INT32_MIN with Int32Use.

* dfg/DFGIntegerRangeOptimizationPhase.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (284584 => 284585)

--- trunk/Source/_javascript_Core/ChangeLog	2021-10-20 23:51:58 UTC (rev 284584)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-21 00:00:20 UTC (rev 284585)
@@ -1,3 +1,15 @@
+2021-10-20  Yusuke Suzuki  
+
+[JSC] ArithAbs should care about INT32_MIN
+https://bugs.webkit.org/show_bug.cgi?id=232051
+rdar://84338648
+
+Reviewed by Michael Saboff.
+
+ArithAbs (without overflow check) can return negative value if the input is INT32_MIN with Int32Use.
+
+* dfg/DFGIntegerRangeOptimizationPhase.cpp:
+
 2021-10-20  Justin Michaud  
 
 We should watch isHavingABadTime if we read from the structureCache


Modified: trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp (284584 => 284585)

--- trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp	2021-10-20 23:51:58 UTC (rev 284584)
+++ trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp	2021-10-21 00:00:20 UTC (rev 284585)
@@ -1400,7 +1400,25 @@
 case ArithAbs: {
 if (node->child1().useKind() != Int32Use)
 break;
-setRelationship(Relationship(node, m_zero, Relationship::GreaterThan, -1));
+
+// If ArithAbs cares about overflow, then INT32_MIN input will cause OSR exit.
+// Thus we can safely say `x >= 0`.
+if (shouldCheckOverflow(node->arithMode())) {
+setRelationship(Relationship(node, m_zero, Relationship::GreaterThan, -1));
+break;
+}
+
+// If ArithAbs does not care about overflow, it can return INT32_MIN if the input is INT32_MIN.
+// If minValue is not INT32_MIN, we can still say it is `x >= 0`.
+int minValue = std::numeric_limits::min();
+auto iter = m_relationships.find(node->child1().node());
+if (iter != m_relationships.end()) {
+for (Relationship relationship : iter->value)
+minValue = std::max(minValue, relationship.minValueOfLeft());
+}
+
+if (minValue > std::numeric_limits::min())
+setRelationship(Relationship(node, m_zero, Relationship::GreaterThan, -1));
 break;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284584] branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/ graphics/RemoteImageBufferProxy.h

2021-10-20 Thread repstein

Title: [284584] branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h








Revision 284584
Author repst...@apple.com
Date 2021-10-20 16:51:58 -0700 (Wed, 20 Oct 2021)


Log Message
Unreviewed buld fix.

RemoteRenderingBackendProxy.cpp:81:34: error: use of undeclared identifier 'makeWeakPtr'

Modified Paths

branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h




Diff

Modified: branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h (284583 => 284584)

--- branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h	2021-10-20 23:08:19 UTC (rev 284583)
+++ branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h	2021-10-20 23:51:58 UTC (rev 284584)
@@ -40,6 +40,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace WebKit {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284583] tags/Safari-613.1.6/

2021-10-20 Thread repstein

Title: [284583] tags/Safari-613.1.6/








Revision 284583
Author repst...@apple.com
Date 2021-10-20 16:08:19 -0700 (Wed, 20 Oct 2021)


Log Message
Tag Safari-613.1.6.

Added Paths

tags/Safari-613.1.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284582] trunk/Source/WebKit

2021-10-20 Thread pvollan

Title: [284582] trunk/Source/WebKit








Revision 284582
Author pvol...@apple.com
Date 2021-10-20 16:07:14 -0700 (Wed, 20 Oct 2021)


Log Message
Launch Services database is not always sent to GPUP
https://bugs.webkit.org/show_bug.cgi?id=232047


Reviewed by Brent Fulgham.

Currently, the XPC endpoint for receiving the Launch Services database is being sent to GPUP in GPUProcessProxy::addSession.
If GPUP has not finished launching at that point, the endpoint will not be sent on the first page load. This is addressed by
sending the XPC endpoint in GPUProcessProxy::didFinishLaunching, since the XPC connection over which the XPC endpoint is
being sent is available then.

* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::didFinishLaunching):
(WebKit::GPUProcessProxy::addSession):
* UIProcess/GPU/GPUProcessProxy.h:
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::sendNetworkProcessXPCEndpointToProcess const):
* UIProcess/WebsiteData/WebsiteDataStore.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (284581 => 284582)

--- trunk/Source/WebKit/ChangeLog	2021-10-20 23:05:19 UTC (rev 284581)
+++ trunk/Source/WebKit/ChangeLog	2021-10-20 23:07:14 UTC (rev 284582)
@@ -1,3 +1,24 @@
+2021-10-20  Per Arne Vollan 
+
+Launch Services database is not always sent to GPUP
+https://bugs.webkit.org/show_bug.cgi?id=232047
+
+
+Reviewed by Brent Fulgham.
+
+Currently, the XPC endpoint for receiving the Launch Services database is being sent to GPUP in GPUProcessProxy::addSession.
+If GPUP has not finished launching at that point, the endpoint will not be sent on the first page load. This is addressed by
+sending the XPC endpoint in GPUProcessProxy::didFinishLaunching, since the XPC connection over which the XPC endpoint is
+being sent is available then.
+
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::didFinishLaunching):
+(WebKit::GPUProcessProxy::addSession):
+* UIProcess/GPU/GPUProcessProxy.h:
+* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
+(WebKit::WebsiteDataStore::sendNetworkProcessXPCEndpointToProcess const):
+* UIProcess/WebsiteData/WebsiteDataStore.h:
+
 2021-10-20  John Pascoe  
 
 Fix crash when calling setUsernameForLocalCredentialWithID


Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp (284581 => 284582)

--- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp	2021-10-20 23:05:19 UTC (rev 284581)
+++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp	2021-10-20 23:07:14 UTC (rev 284582)
@@ -432,6 +432,14 @@
 if (xpc_connection_t connection = this->connection()->xpcConnection())
 m_throttler.didConnectToProcess(xpc_connection_get_pid(connection));
 #endif
+
+#if PLATFORM(COCOA)
+auto it = m_sessionIDs.begin();
+if (it != m_sessionIDs.end()) {
+auto webSiteDataStore = WebsiteDataStore::existingDataStoreForSessionID(*m_sessionIDs.begin());
+m_hasSentLaunchServicesDatabase = webSiteDataStore->sendNetworkProcessXPCEndpointToProcess(*this);
+}
+#endif
 }
 
 void GPUProcessProxy::updateProcessAssertion()
@@ -498,7 +506,8 @@
 m_sessionIDs.add(store.sessionID());
 
 #if PLATFORM(COCOA)
-store.sendNetworkProcessXPCEndpointToProcess(*this);
+if (!m_hasSentLaunchServicesDatabase)
+m_hasSentLaunchServicesDatabase = store.sendNetworkProcessXPCEndpointToProcess(*this);
 #endif
 }
 


Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h (284581 => 284582)

--- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h	2021-10-20 23:05:19 UTC (rev 284581)
+++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h	2021-10-20 23:07:14 UTC (rev 284582)
@@ -146,6 +146,7 @@
 bool m_hasSentTCCDSandboxExtension { false };
 bool m_hasSentCameraSandboxExtension { false };
 bool m_hasSentMicrophoneSandboxExtension { false };
+bool m_hasSentLaunchServicesDatabase { false };
 #endif
 HashSet m_sessionIDs;
 };


Modified: trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm (284581 => 284582)

--- trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm	2021-10-20 23:05:19 UTC (rev 284581)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm	2021-10-20 23:07:14 UTC (rev 284582)
@@ -598,17 +598,18 @@
 return WTF::hasEntitlement(networkProcess().connection()->xpcConnection(), entitlement.utf8().data());
 }
 
-void WebsiteDataStore::sendNetworkProcessXPCEndpointToProcess(AuxiliaryProcessProxy& process) const
+bool WebsiteDataStore::sendNetworkProcessXPCEndpointToProcess(AuxiliaryProcessProxy& process)

[webkit-changes] [284581] releases/WebKitGTK/webkit-2.32/Source/WebKit

2021-10-20 Thread aperez

Title: [284581] releases/WebKitGTK/webkit-2.32/Source/WebKit








Revision 284581
Author ape...@igalia.com
Date 2021-10-20 16:05:19 -0700 (Wed, 20 Oct 2021)


Log Message
Merge r284451 - Update seccomp filters with latest changes from flatpak
https://bugs.webkit.org/show_bug.cgi?id=231479

Patch by Michael Catanzaro  on 2021-10-19
Reviewed by Adrian Perez de Castro.

Additionally, let's fix a minor inconsistency in our error-handling code: all but one of
our codepaths carefully free and close resources, but the process is about to crash so
there's not really any reason to do so. The code is slightly simpler if we don't bother.

The seemingly-extraneous include order changes are required to placate the style checker.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::seccompStrerror):
(WebKit::setupSeccomp):
* UIProcess/Launcher/glib/Syscalls.h: Added.

Modified Paths

releases/WebKitGTK/webkit-2.32/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.32/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp


Added Paths

releases/WebKitGTK/webkit-2.32/Source/WebKit/UIProcess/Launcher/glib/Syscalls.h




Diff

Modified: releases/WebKitGTK/webkit-2.32/Source/WebKit/ChangeLog (284580 => 284581)

--- releases/WebKitGTK/webkit-2.32/Source/WebKit/ChangeLog	2021-10-20 23:05:13 UTC (rev 284580)
+++ releases/WebKitGTK/webkit-2.32/Source/WebKit/ChangeLog	2021-10-20 23:05:19 UTC (rev 284581)
@@ -1,3 +1,21 @@
+2021-10-19  Michael Catanzaro  
+
+Update seccomp filters with latest changes from flatpak
+https://bugs.webkit.org/show_bug.cgi?id=231479
+
+Reviewed by Adrian Perez de Castro.
+
+Additionally, let's fix a minor inconsistency in our error-handling code: all but one of
+our codepaths carefully free and close resources, but the process is about to crash so
+there's not really any reason to do so. The code is slightly simpler if we don't bother.
+
+The seemingly-extraneous include order changes are required to placate the style checker.
+
+* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+(WebKit::seccompStrerror):
+(WebKit::setupSeccomp):
+* UIProcess/Launcher/glib/Syscalls.h: Added.
+
 2021-09-17  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.32.4 release


Modified: releases/WebKitGTK/webkit-2.32/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (284580 => 284581)

--- releases/WebKitGTK/webkit-2.32/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2021-10-20 23:05:13 UTC (rev 284580)
+++ releases/WebKitGTK/webkit-2.32/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2021-10-20 23:05:19 UTC (rev 284581)
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -32,6 +33,12 @@
 #include 
 #include 
 
+#if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
+#include 
+#endif
+
+#include "Syscalls.h"
+
 #if PLATFORM(GTK)
 #include "WaylandCompositor.h"
 #endif
@@ -42,14 +49,8 @@
 #define BASE_DIRECTORY "wpe"
 #endif
 
-#include 
+#if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
 
-#ifndef MFD_ALLOW_SEALING
-
-#if HAVE(LINUX_MEMFD_H)
-
-#include 
-
 // These defines were added in glibc 2.27, the same release that added memfd_create.
 // But the kernel added all of this in Linux 3.17. So it's totally safe for us to
 // depend on, as long as we define it all ourselves. Remove this once we depend on
@@ -67,10 +68,8 @@
 {
 return syscall(__NR_memfd_create, name, flags);
 }
-#endif // #if HAVE(LINUX_MEMFD_H)
+#endif // #if !defined(MFD_ALLOW_SEALING) && HAVE(LINUX_MEMFD_H)
 
-#endif // #ifndef MFD_ALLOW_SEALING
-
 namespace WebKit {
 using namespace WebCore;
 
@@ -596,6 +595,28 @@
 }
 }
 
+// Translate a libseccomp error code into an error message. libseccomp
+// mostly returns negative errno values such as -ENOMEM, but some
+// standard errno values are used for non-standard purposes where their
+// strerror() would be misleading.
+static const char* seccompStrerror(int negativeErrno)
+{
+RELEASE_ASSERT_WITH_MESSAGE(negativeErrno < 0, "Non-negative error value from libseccomp?");
+RELEASE_ASSERT_WITH_MESSAGE(negativeErrno > INT_MIN, "Out of range error value from libseccomp?");
+
+switch (negativeErrno) {
+case -EDOM:
+return "Architecture-specific failure";
+case -EFAULT:
+return "Internal libseccomp failure (unknown syscall?)";
+case -ECANCELED:
+return "System failure beyond the control of libseccomp";
+}
+
+// e.g. -ENOMEM: the result of strerror() is good enough
+return g_strerror(-negativeErrno);
+}
+
 static int setupSeccomp()
 {
 // NOTE: This is shared code (flatpak-run.c - LGPLv2.1+)
@@ -623,6 +644,10 @@
 //in common/flatpak-run.c
 //  https://git.gnome.org/browse/linux-user-chroot
 //in src/setup-seccomp.c
+//
+// Other useful resources:
+//

[webkit-changes] [284580] releases/WebKitGTK/webkit-2.32/Source

2021-10-20 Thread aperez

Title: [284580] releases/WebKitGTK/webkit-2.32/Source








Revision 284580
Author ape...@igalia.com
Date 2021-10-20 16:05:13 -0700 (Wed, 20 Oct 2021)


Log Message
Merge r281384 - IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
https://bugs.webkit.org/show_bug.cgi?id=229375

Source/WebCore:

Reviewed by Brady Eidson.

Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
created internally.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):

Source/WTF:

Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.

Reviewed by Brady Eidson.

* wtf/CrossThreadTask.h:

Modified Paths

releases/WebKitGTK/webkit-2.32/Source/WTF/ChangeLog
releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog




Diff

Modified: releases/WebKitGTK/webkit-2.32/Source/WTF/ChangeLog (284579 => 284580)

--- releases/WebKitGTK/webkit-2.32/Source/WTF/ChangeLog	2021-10-20 23:04:53 UTC (rev 284579)
+++ releases/WebKitGTK/webkit-2.32/Source/WTF/ChangeLog	2021-10-20 23:05:13 UTC (rev 284580)
@@ -1,3 +1,14 @@
+2021-08-21  Sihui Liu  
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Protect callee in CrossThreadTask if it inherits from ThreadSafeRefCounted.
+
+Reviewed by Brady Eidson.
+
+* wtf/CrossThreadTask.h:
+
 2021-05-28  Alex Christensen  
 
 Punycode encode U+0BE6 when not in context of other Tamil characters


Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (284579 => 284580)

--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog	2021-10-20 23:04:53 UTC (rev 284579)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog	2021-10-20 23:05:13 UTC (rev 284580)
@@ -1,3 +1,16 @@
+2021-08-21  Sihui Liu  
+
+IndexedDB: crash when triggering IDBOpenRequest completion back on a worker thread
+https://bugs.webkit.org/show_bug.cgi?id=229375
+
+Reviewed by Brady Eidson.
+
+Client may dispatch custom events to an IDBRequest, and we should only change request state based on events
+created internally.
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::dispatchEvent):
+
 2021-07-12  Chris Dumez  
 
 Unreviewed, partial revert of r279661 to address crashes on iOS Debug.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284579] releases/WebKitGTK/webkit-2.32/Source/WebCore

2021-10-20 Thread aperez

Title: [284579] releases/WebKitGTK/webkit-2.32/Source/WebCore








Revision 284579
Author ape...@igalia.com
Date 2021-10-20 16:04:53 -0700 (Wed, 20 Oct 2021)


Log Message
Merge r279832 - Unreviewed, partial revert of r279661 to address crashes on iOS Debug.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):

Modified Paths

releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.32/Source/WebCore/page/DOMWindow.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (284578 => 284579)

--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog	2021-10-20 22:34:18 UTC (rev 284578)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog	2021-10-20 23:04:53 UTC (rev 284579)
@@ -1,3 +1,10 @@
+2021-07-12  Chris Dumez  
+
+Unreviewed, partial revert of r279661 to address crashes on iOS Debug.
+
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::removeAllEventListeners):
+
 2021-08-31  Antti Koivisto  
 
 REGRESSION (r272900): wpt.fyi loading performance is very slow (regressed, and slower than other browsers)


Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/page/DOMWindow.cpp (284578 => 284579)

--- releases/WebKitGTK/webkit-2.32/Source/WebCore/page/DOMWindow.cpp	2021-10-20 22:34:18 UTC (rev 284578)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/page/DOMWindow.cpp	2021-10-20 23:04:53 UTC (rev 284579)
@@ -2340,7 +2340,7 @@
 #endif
 
 #if ENABLE(TOUCH_EVENTS)
-if (RefPtr document = this->document())
+if (auto* document = this->document())
 document->didRemoveEventTargetNode(*document);
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284578] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284578] trunk/LayoutTests








Revision 284578
Author ayumi_koj...@apple.com
Date 2021-10-20 15:34:18 -0700 (Wed, 20 Oct 2021)


Log Message
[ macOS ] imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=223804

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284577 => 284578)

--- trunk/LayoutTests/ChangeLog	2021-10-20 22:15:24 UTC (rev 284577)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 22:34:18 UTC (rev 284578)
@@ -1,3 +1,12 @@
+2021-10-20  Ayumi Kojima  
+
+[ macOS ] imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=223804
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2021-10-20  Alan Bujtas  
 
 [TestExpectation] Re-group css-text WPT failures


Modified: trunk/LayoutTests/platform/mac/TestExpectations (284577 => 284578)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-10-20 22:15:24 UTC (rev 284577)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-10-20 22:34:18 UTC (rev 284578)
@@ -2294,6 +2294,8 @@
 
 webkit.org/b/222385 imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.worker.html [ Pass Failure ]
 
+webkit.org/b/223804 imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.html [ Pass Failure ]
+
 webkit.org/b/227998 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-network-error.sub.html [ Pass Failure ]
 
 webkit.org/b/228311 imported/w3c/web-platform-tests/css/css-scoping/css-scoping-shadow-dynamic-remove-style-detached.html [ Pass Failure Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284577] trunk/LayoutTests

2021-10-20 Thread zalan

Title: [284577] trunk/LayoutTests








Revision 284577
Author za...@apple.com
Date 2021-10-20 15:15:24 -0700 (Wed, 20 Oct 2021)


Log Message
[TestExpectation] Re-group css-text WPT failures
https://bugs.webkit.org/show_bug.cgi?id=232027

Reviewed by Antti Koivisto.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284576 => 284577)

--- trunk/LayoutTests/ChangeLog	2021-10-20 22:08:45 UTC (rev 284576)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 22:15:24 UTC (rev 284577)
@@ -1,3 +1,12 @@
+2021-10-20  Alan Bujtas  
+
+[TestExpectation] Re-group css-text WPT failures
+https://bugs.webkit.org/show_bug.cgi?id=232027
+
+Reviewed by Antti Koivisto.
+
+* TestExpectations:
+
 2021-10-20  Beth Dakin   and Dana Estra 
 
 macOS key-driven smooth scrolling does not stop when focus changes


Modified: trunk/LayoutTests/TestExpectations (284576 => 284577)

--- trunk/LayoutTests/TestExpectations	2021-10-20 22:08:45 UTC (rev 284576)
+++ trunk/LayoutTests/TestExpectations	2021-10-20 22:15:24 UTC (rev 284577)
@@ -2540,11 +2540,72 @@
 
 http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-iframe-report-only.html [ Pass Failure ]
 
-# Imported css-text test suite from WPT
+# css-text start
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-001.html [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-003.html [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-004.html [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-005.html [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-010.html [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-first-001.xht [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-force-end-001.xht [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-last-001.xht [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-001.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-010.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-inline-010.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-011.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-012.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-none-013.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-out-of-flow-001.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-out-of-flow-002.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-shaping-001.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-shaping-002.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-span-002.html [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-001.html [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-002.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-003.xht [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-004.xht [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-005.xht [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-nesting-001.html [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-nesting-002.html [ ImageOnlyFailure ]
+webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-end-of-line-001.html [ ImageOnlyFailure ]
+webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-nesting-003.xht [ ImageOnlyFailure ]
+webkit.org/b/214290

[webkit-changes] [284576] trunk/Source/JavaScriptCore

2021-10-20 Thread justin_michaud

Title: [284576] trunk/Source/_javascript_Core








Revision 284576
Author justin_mich...@apple.com
Date 2021-10-20 15:08:45 -0700 (Wed, 20 Oct 2021)


Log Message
We should watch isHavingABadTime if we read from the structureCache
https://bugs.webkit.org/show_bug.cgi?id=232019

Reviewed by Yusuke Suzuki.

We should lock the structure cache when we clear it, and the compiler thread should
watch isHavingABadTime in the case that the cache might get cleared.

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::haveABadTime):
* runtime/StructureCache.cpp:
(JSC::StructureCache::clear):
* runtime/StructureCache.h:
(JSC::StructureCache::clear): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/StructureCache.cpp
trunk/Source/_javascript_Core/runtime/StructureCache.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (284575 => 284576)

--- trunk/Source/_javascript_Core/ChangeLog	2021-10-20 21:50:18 UTC (rev 284575)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-20 22:08:45 UTC (rev 284576)
@@ -1,3 +1,24 @@
+2021-10-20  Justin Michaud  
+
+We should watch isHavingABadTime if we read from the structureCache
+https://bugs.webkit.org/show_bug.cgi?id=232019
+
+Reviewed by Yusuke Suzuki.
+
+We should lock the structure cache when we clear it, and the compiler thread should
+watch isHavingABadTime in the case that the cache might get cleared.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+* dfg/DFGConstantFoldingPhase.cpp:
+(JSC::DFG::ConstantFoldingPhase::foldConstants):
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::haveABadTime):
+* runtime/StructureCache.cpp:
+(JSC::StructureCache::clear):
+* runtime/StructureCache.h:
+(JSC::StructureCache::clear): Deleted.
+
 2021-10-20  Michael Saboff  
 
 Add missing overflow checks to DFGIntegerRangeOptimizationPhase::isEquivalentTo()


Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (284575 => 284576)

--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2021-10-20 21:50:18 UTC (rev 284575)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2021-10-20 22:08:45 UTC (rev 284576)
@@ -3126,8 +3126,19 @@
 Structure* structure = nullptr;
 if (base.isNull())
 structure = globalObject->nullPrototypeObjectStructure();
-else if (base.isObject())
-structure = m_vm.structureCache.emptyObjectStructureConcurrently(globalObject, base.getObject(), JSFinalObject::defaultInlineCapacity());
+else if (base.isObject()) {
+// Having a bad time clears the structureCache, and so it should invalidate this structure.
+bool isHavingABadTime = globalObject->isHavingABadTime();
+WTF::loadLoadFence();
+if (!isHavingABadTime)
+m_graph.watchpoints().addLazily(globalObject->havingABadTimeWatchpoint());
+// Normally, we would always install a watchpoint. In this case, however, if we haveABadTime, we
+// still want to optimize. There is no watchpoint for that case though, so we need to make sure this load
+// does not get hoisted above the check.
+WTF::loadLoadFence();
+structure = m_vm.structureCache
+.emptyObjectStructureConcurrently(globalObject, base.getObject(), JSFinalObject::defaultInlineCapacity());
+}
 
 if (structure) {
 m_state.setShouldTryConstantFolding(true);


Modified: trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp (284575 => 284576)

--- trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp	2021-10-20 21:50:18 UTC (rev 284575)
+++ trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp	2021-10-20 22:08:45 UTC (rev 284576)
@@ -841,8 +841,19 @@
 Structure* structure = nullptr;
 if (base.isNull())
 structure = globalObject->nullPrototypeObjectStructure();
-else if (base.isObject())
-structure = globalObject->vm().structureCache.emptyObjectStructureConcurrently(globalObject, base.getObject(), JSFinalObject::defaultInlineCapacity());
+else if (base.isObject()) {
+// Having a bad time clears the structureCache, and so it should invalidate this

[webkit-changes] [284575] trunk

2021-10-20 Thread commit-queue

Title: [284575] trunk








Revision 284575
Author commit-qu...@webkit.org
Date 2021-10-20 14:50:18 -0700 (Wed, 20 Oct 2021)


Log Message
macOS key-driven smooth scrolling does not stop when focus changes
https://bugs.webkit.org/show_bug.cgi?id=228302

Patch by Beth Dakin   and Dana Estra  on 2021-10-20
Reviewed by Simon Fraser.

Source/WebCore:

Call stopKeyboardScrollAnimation() on the old FrameView after changing Frame focus.
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedFrame):

Call stopKeyboardScrollAnimation() when the window visibility / active state changes.
* page/Page.cpp:
(WebCore::Page::setActivityState):
(WebCore::Page::stopKeyboardScrollAnimation):
* page/Page.h:

Plumbing to get to ScrollingEffectsController, which can invoke keyUp.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::stopKeyboardScrollAnimation):
* platform/ScrollAnimator.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::stopKeyboardScrollAnimation):
* platform/ScrollableArea.h:

Tools:

This patch adds support for rawKeyUp and rawKeyDown to the macOS versions of WKTR and DRT.

* DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController initialize]):
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController rawKeyDown:withModifiers:withLocation:]):
(-[EventSendingController rawKeyDownWrapper:withModifiers:withLocation:]):
(-[EventSendingController rawKeyUp:withModifiers:withLocation:]):
(-[EventSendingController rawKeyUpWrapper:withModifiers:withLocation:]):
* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::createRawKeyDownMessageBody):
(WTR::createRawKeyUpMessageBody):
(WTR::EventSendingController::rawKeyDown):
(WTR::EventSendingController::rawKeyUp):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
(WTR::EventSenderProxy::rawKeyDown):
(WTR::EventSenderProxy::rawKeyUp):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveRawKeyDownMessageFromInjectedBundle):
(WTR::TestController::didReceiveRawKeyUpMessageFromInjectedBundle):
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::rawKeyDown):
(WTR::EventSenderProxy::rawKeyUp):
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::rawKeyDown):
(WTR::EventSenderProxy::rawKeyUp):
* WebKitTestRunner/win/EventSenderProxyWin.cpp:
(WTR::EventSenderProxy::rawKeyDown):
(WTR::EventSenderProxy::rawKeyUp):
* WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
(WTR::EventSenderProxy::rawKeyDown):
(WTR::EventSenderProxy::rawKeyUp):

LayoutTests:

EventHandlerDrivenSmoothKeyboardScrollingEnabled keys are WK2 only right now, so skip the new
test in general.
* TestExpectations:

New test that verifies this bug is resolved.
* fast/scrolling/unfocusing-page-while-keyboard-scrolling-expected.txt: Added.
* fast/scrolling/unfocusing-page-while-keyboard-scrolling.html: Added.

Do run the test for mac-wk2. rawKeyDown / rawKeyUp are currently not implemented
elsewhere.
* platform/mac-wk2/TestExpectations:

New support for rawKeyDown in order to simulate holding the key down.
* resources/ui-helper.js:
(window.UIHelper.rawKeyDown):
(window.UIHelper.rawKeyUp):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/resources/ui-helper.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FocusController.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/ScrollAnimator.h
trunk/Source/WebCore/platform/ScrollableArea.cpp
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/EventSendingController.mm
trunk/Tools/WebKitTestRunner/EventSenderProxy.h
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.h
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp
trunk/Tools/WebKitTestRunner/mac/EventSenderProxy.mm
trunk/Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp
trunk/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp


Added Paths

trunk/LayoutTests/fast/scrolling/unfocusing-page-while-keyboard-scrolling-expected.txt
trunk/LayoutTests/fast/scrolling/unfocusing-page-while-keyboard-scrolling.html

[webkit-changes] [284574] trunk/Source/WebKit

2021-10-20 Thread commit-queue

Title: [284574] trunk/Source/WebKit








Revision 284574
Author commit-qu...@webkit.org
Date 2021-10-20 14:49:11 -0700 (Wed, 20 Oct 2021)


Log Message
Fix crash when calling setUsernameForLocalCredentialWithID
https://bugs.webkit.org/show_bug.cgi?id=231986


Patch by John Pascoe  on 2021-10-20
Reviewed by David Kilzer.

Using a copy here results in a crash when the NSData deallocs because the
[NSData dataWithBytesNoCopy] was used a buffer that was not allocated with malloc.
This is fixed by instead using [NSData initWithBytes] and RetainPtr.

* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (284573 => 284574)

--- trunk/Source/WebKit/ChangeLog	2021-10-20 21:45:13 UTC (rev 284573)
+++ trunk/Source/WebKit/ChangeLog	2021-10-20 21:49:11 UTC (rev 284574)
@@ -1,3 +1,18 @@
+2021-10-20  John Pascoe  
+
+Fix crash when calling setUsernameForLocalCredentialWithID
+https://bugs.webkit.org/show_bug.cgi?id=231986
+
+
+Reviewed by David Kilzer.
+
+Using a copy here results in a crash when the NSData deallocs because the
+[NSData dataWithBytesNoCopy] was used a buffer that was not allocated with malloc.
+This is fixed by instead using [NSData initWithBytes] and RetainPtr.
+
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
+(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]):
+
 2021-10-20  Alex Christensen  
 
 Remove com.apple.webkit.adattributiond.plist from build temporarily


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm (284573 => 284574)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm	2021-10-20 21:45:13 UTC (rev 284573)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm	2021-10-20 21:49:11 UTC (rev 284574)
@@ -337,10 +337,11 @@
 return;
 }
 auto updatedTag = cbor::CBORWriter::write(cbor::CBORValue(WTFMove(updatedUserMap)));
-auto secAttrApplicationTag = [NSData dataWithBytesNoCopy:updatedTag->data() length:updatedTag->size()];
 
+auto secAttrApplicationTag = adoptNS([[NSData alloc] initWithBytes:updatedTag->data() length:updatedTag->size()]);
+
 NSDictionary *updateParams = @{
-(__bridge id)kSecAttrApplicationTag: secAttrApplicationTag,
+(__bridge id)kSecAttrApplicationTag: secAttrApplicationTag.get(),
 };
 
 [query setDictionary:@{






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284573] trunk/Source/JavaScriptCore

2021-10-20 Thread msaboff

Title: [284573] trunk/Source/_javascript_Core








Revision 284573
Author msab...@apple.com
Date 2021-10-20 14:45:13 -0700 (Wed, 20 Oct 2021)


Log Message
Add missing overflow checks to DFGIntegerRangeOptimizationPhase::isEquivalentTo()
https://bugs.webkit.org/show_bug.cgi?id=232024

Reviewed by Tadeu Zagallo.

Added overflow check before comparing for equality.

* dfg/DFGIntegerRangeOptimizationPhase.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (284572 => 284573)

--- trunk/Source/_javascript_Core/ChangeLog	2021-10-20 21:42:35 UTC (rev 284572)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-20 21:45:13 UTC (rev 284573)
@@ -1,3 +1,14 @@
+2021-10-20  Michael Saboff  
+
+Add missing overflow checks to DFGIntegerRangeOptimizationPhase::isEquivalentTo()
+https://bugs.webkit.org/show_bug.cgi?id=232024
+
+Reviewed by Tadeu Zagallo.
+
+Added overflow check before comparing for equality.
+
+* dfg/DFGIntegerRangeOptimizationPhase.cpp:
+
 2021-10-20  Michael Catanzaro  
 
 Do not use strerror()


Modified: trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp (284572 => 284573)

--- trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp	2021-10-20 21:42:35 UTC (rev 284572)
+++ trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp	2021-10-20 21:45:13 UTC (rev 284573)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015-2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -228,8 +228,17 @@
 if (*this == other)
 return true;
 
-if (m_right->isInt32Constant() && other.m_right->isInt32Constant())
-return (m_right->asInt32() + m_offset) == (other.m_right->asInt32() + other.m_offset);
+if (m_right->isInt32Constant() && other.m_right->isInt32Constant()) {
+int thisRight = m_right->asInt32();
+int otherRight = other.m_right->asInt32();
+
+if (sumOverflows(thisRight, m_offset))
+return false;
+if (sumOverflows(otherRight, other.m_offset))
+return false;
+
+return (thisRight + m_offset) == (otherRight + other.m_offset);
+}
 return false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284572] trunk/LayoutTests

2021-10-20 Thread ehutchison

Title: [284572] trunk/LayoutTests








Revision 284572
Author ehutchi...@apple.com
Date 2021-10-20 14:42:35 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS15 EWS ] http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=232048.

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284571 => 284572)

--- trunk/LayoutTests/ChangeLog	2021-10-20 21:39:45 UTC (rev 284571)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 21:42:35 UTC (rev 284572)
@@ -1,3 +1,12 @@
+2021-10-20  Eric Hutchison  
+
+[ iOS15 EWS ] http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html is crashing.
+https://bugs.webkit.org/show_bug.cgi?id=232048.
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-10-20  Ayumi Kojima  
 
 [ BigSure wk1 Debug ] fast/selectors/pseudo-element-inside-any.html is a flaky crash.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284571 => 284572)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 21:39:45 UTC (rev 284571)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 21:42:35 UTC (rev 284572)
@@ -2235,3 +2235,4 @@
 
 webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ]
 
+webkit.org/b/232048 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284571] branches/safari-613.1.6-branch/Source/WebKit

2021-10-20 Thread repstein

Title: [284571] branches/safari-613.1.6-branch/Source/WebKit








Revision 284571
Author repst...@apple.com
Date 2021-10-20 14:39:45 -0700 (Wed, 20 Oct 2021)


Log Message
Cherry-pick r284570. rdar://problem/84479714

Remove com.apple.webkit.adattributiond.plist from build temporarily
https://bugs.webkit.org/show_bug.cgi?id=232045

Reviewed by Tim Horton.

There are some problems with the internal verifiers that will take some time to resolve.
Until they are resolved, don't install the plist and don't tell the network process to connect to the daemon registered by the plist.

* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.6-branch/Source/WebKit/ChangeLog
branches/safari-613.1.6-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp
branches/safari-613.1.6-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: branches/safari-613.1.6-branch/Source/WebKit/ChangeLog (284570 => 284571)

--- branches/safari-613.1.6-branch/Source/WebKit/ChangeLog	2021-10-20 21:35:45 UTC (rev 284570)
+++ branches/safari-613.1.6-branch/Source/WebKit/ChangeLog	2021-10-20 21:39:45 UTC (rev 284571)
@@ -1,5 +1,39 @@
 2021-10-20  Alan Coon  
 
+Cherry-pick r284570. rdar://problem/84479714
+
+Remove com.apple.webkit.adattributiond.plist from build temporarily
+https://bugs.webkit.org/show_bug.cgi?id=232045
+
+Reviewed by Tim Horton.
+
+There are some problems with the internal verifiers that will take some time to resolve.
+Until they are resolved, don't install the plist and don't tell the network process to connect to the daemon registered by the plist.
+
+* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
+(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
+* WebKit.xcodeproj/project.pbxproj:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-20  Alex Christensen  
+
+Remove com.apple.webkit.adattributiond.plist from build temporarily
+https://bugs.webkit.org/show_bug.cgi?id=232045
+
+Reviewed by Tim Horton.
+
+There are some problems with the internal verifiers that will take some time to resolve.
+Until they are resolved, don't install the plist and don't tell the network process to connect to the daemon registered by the plist.
+
+* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
+(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
+* WebKit.xcodeproj/project.pbxproj:
+
+2021-10-20  Alan Coon  
+
 Revert r284079. rdar://problem/84478842
 
 2021-10-19  Alan Coon  


Modified: branches/safari-613.1.6-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp (284570 => 284571)

--- branches/safari-613.1.6-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp	2021-10-20 21:35:45 UTC (rev 284570)
+++ branches/safari-613.1.6-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp	2021-10-20 21:39:45 UTC (rev 284571)
@@ -51,9 +51,6 @@
 #if ENABLE(ARKIT_INLINE_PREVIEW)
 setModelElementCacheDirectory(WebsiteDataStore::defaultModelElementCacheDirectory());
 #endif
-#if PLATFORM(IOS)
-setPCMMachServiceName("com.apple.webkit.adattributiond.service");
-#endif
 }
 }
 


Modified: branches/safari-613.1.6-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj (284570 => 284571)

--- branches/safari-613.1.6-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2021-10-20 21:35:45 UTC (rev 284570)
+++ branches/safari-613.1.6-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2021-10-20 21:39:45 UTC (rev 284571)
@@ -14541,7 +14541,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if [[ \"${WK_PLATFORM_NAME}\" == iphoneos ]]; then\nDAEMON_PLIST_SOURCE=\"${SRCROOT}/Shared/EntryPointUtilities/Cocoa/Daemon/com.apple.webkit.adattributiond.plist\"\nDAEMON_PLIST_DESTINATION=\"${DSTROOT}/System/Library/LaunchDaemons/com.apple.webkit.adattributiond.plist\"\necho \"copying adattributiond plist\"\necho plutil -convert binary1 -o \"${DAEMON_PLIST_DESTINATION}\" \"${DAEMON_PLIST_SOURCE}\"\nplutil -convert binary1 -o \"${DAEMON_PLIST_DESTINATION}\" \"${DAEMON_PLIST_SOURCE}\"\nelse\necho \"not copying adattributiond plist\"\nfi\n";
+			shellScript = "echo \"not copying adattributiond plist\"\n";
 		};
 		E1AC2E2C20F7B95800B0897D /* Unlock Keychain */ = {
 			isa = PBXShellScriptBuildPhase;






___
webkit-changes mailing list

[webkit-changes] [284570] trunk/Source/WebKit

2021-10-20 Thread achristensen

Title: [284570] trunk/Source/WebKit








Revision 284570
Author achristen...@apple.com
Date 2021-10-20 14:35:45 -0700 (Wed, 20 Oct 2021)


Log Message
Remove com.apple.webkit.adattributiond.plist from build temporarily
https://bugs.webkit.org/show_bug.cgi?id=232045

Reviewed by Tim Horton.

There are some problems with the internal verifiers that will take some time to resolve.
Until they are resolved, don't install the plist and don't tell the network process to connect to the daemon registered by the plist.

* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (284569 => 284570)

--- trunk/Source/WebKit/ChangeLog	2021-10-20 21:32:07 UTC (rev 284569)
+++ trunk/Source/WebKit/ChangeLog	2021-10-20 21:35:45 UTC (rev 284570)
@@ -1,3 +1,17 @@
+2021-10-20  Alex Christensen  
+
+Remove com.apple.webkit.adattributiond.plist from build temporarily
+https://bugs.webkit.org/show_bug.cgi?id=232045
+
+Reviewed by Tim Horton.
+
+There are some problems with the internal verifiers that will take some time to resolve.
+Until they are resolved, don't install the plist and don't tell the network process to connect to the daemon registered by the plist.
+
+* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
+(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
+* WebKit.xcodeproj/project.pbxproj:
+
 2021-10-20  Brady Eidson  
 
 Factor out some Notifications-specific messages from WebPageProxy messages


Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp (284569 => 284570)

--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp	2021-10-20 21:32:07 UTC (rev 284569)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp	2021-10-20 21:35:45 UTC (rev 284570)
@@ -51,9 +51,6 @@
 #if ENABLE(ARKIT_INLINE_PREVIEW)
 setModelElementCacheDirectory(WebsiteDataStore::defaultModelElementCacheDirectory());
 #endif
-#if PLATFORM(IOS)
-setPCMMachServiceName("com.apple.webkit.adattributiond.service");
-#endif
 }
 }
 


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (284569 => 284570)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2021-10-20 21:32:07 UTC (rev 284569)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2021-10-20 21:35:45 UTC (rev 284570)
@@ -14566,7 +14566,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if [[ \"${WK_PLATFORM_NAME}\" == iphoneos ]]; then\nDAEMON_PLIST_SOURCE=\"${SRCROOT}/Shared/EntryPointUtilities/Cocoa/Daemon/com.apple.webkit.adattributiond.plist\"\nDAEMON_PLIST_DESTINATION=\"${DSTROOT}/System/Library/LaunchDaemons/com.apple.webkit.adattributiond.plist\"\necho \"copying adattributiond plist\"\necho plutil -convert binary1 -o \"${DAEMON_PLIST_DESTINATION}\" \"${DAEMON_PLIST_SOURCE}\"\nplutil -convert binary1 -o \"${DAEMON_PLIST_DESTINATION}\" \"${DAEMON_PLIST_SOURCE}\"\nelse\necho \"not copying adattributiond plist\"\nfi\n";
+			shellScript = "echo \"not copying adattributiond plist\"\n";
 		};
 		E1AC2E2C20F7B95800B0897D /* Unlock Keychain */ = {
 			isa = PBXShellScriptBuildPhase;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284569] branches/safari-613.1.6-branch/Source/WebKit

2021-10-20 Thread repstein

Title: [284569] branches/safari-613.1.6-branch/Source/WebKit








Revision 284569
Author repst...@apple.com
Date 2021-10-20 14:32:07 -0700 (Wed, 20 Oct 2021)


Log Message
Revert r284079. rdar://problem/84478842

Modified Paths

branches/safari-613.1.6-branch/Source/WebKit/ChangeLog
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/cocoa/GPUProcessCocoa.mm
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackendCreationParameters.h
branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h
branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h
branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in
branches/safari-613.1.6-branch/Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp




Diff

Modified: branches/safari-613.1.6-branch/Source/WebKit/ChangeLog (284568 => 284569)

--- branches/safari-613.1.6-branch/Source/WebKit/ChangeLog	2021-10-20 21:26:04 UTC (rev 284568)
+++ branches/safari-613.1.6-branch/Source/WebKit/ChangeLog	2021-10-20 21:32:07 UTC (rev 284569)
@@ -1,3 +1,7 @@
+2021-10-20  Alan Coon  
+
+Revert r284079. rdar://problem/84478842
+
 2021-10-19  Alan Coon  
 
 Cherry-pick r284489. rdar://problem/84439180


Modified: branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp (284568 => 284569)

--- branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2021-10-20 21:26:04 UTC (rev 284568)
+++ branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2021-10-20 21:32:07 UTC (rev 284569)
@@ -481,10 +481,10 @@
 }
 #endif
 
-void GPUConnectionToWebProcess::createRenderingBackend(RemoteRenderingBackendCreationParameters&& creationParameters, IPC::StreamConnectionBuffer&& streamBuffer)
+void GPUConnectionToWebProcess::createRenderingBackend(RemoteRenderingBackendCreationParameters&& creationParameters)
 {
 auto addResult = m_remoteRenderingBackendMap.ensure(creationParameters.identifier, [&]() {
-return IPC::ScopedActiveMessageReceiveQueue { RemoteRenderingBackend::create(*this, WTFMove(creationParameters), WTFMove(streamBuffer)) };
+return IPC::ScopedActiveMessageReceiveQueue { RemoteRenderingBackend::create(*this, WTFMove(creationParameters)) };
 });
 ASSERT_UNUSED(addResult, addResult.isNewEntry);
 }


Modified: branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h (284568 => 284569)

--- branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h	2021-10-20 21:26:04 UTC (rev 284568)
+++ branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h	2021-10-20 21:32:07 UTC (rev 284569)
@@ -187,7 +187,7 @@
 RemoteMediaRecorderManager& mediaRecorderManager();
 #endif
 
-void createRenderingBackend(RemoteRenderingBackendCreationParameters&&, IPC::StreamConnectionBuffer&&);
+void createRenderingBackend(RemoteRenderingBackendCreationParameters&&);
 void releaseRenderingBackend(RenderingBackendIdentifier);
 
 #if ENABLE(WEBGL)


Modified: branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in (284568 => 284569)

--- branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in	2021-10-20 21:26:04 UTC (rev 284568)
+++ branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in	2021-10-20 21:32:07 UTC (rev 284569)
@@ -23,7 +23,7 @@
 #if ENABLE(GPU_PROCESS)
 
 messages -> GPUConnectionToWebProcess WantsDispatchMessage {
-void CreateRenderingBackend(struct WebKit::RemoteRenderingBackendCreationParameters creationParameters, IPC::StreamConnectionBuffer streamBuffer)
+void CreateRenderingBackend(struct WebKit::RemoteRenderingBackendCreationParameters creationParameters)
 void ReleaseRenderingBackend(WebKit::RenderingBackendIdentifier renderingBackendIdentifier)
 #if ENABLE(WEBGL)
 void CreateGraphicsContextGL(struct WebCore::GraphicsContextGLAttributes attributes,

[webkit-changes] [284568] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284568] trunk/LayoutTests








Revision 284568
Author ayumi_koj...@apple.com
Date 2021-10-20 14:26:04 -0700 (Wed, 20 Oct 2021)


Log Message
[ BigSure wk1 Debug ] fast/selectors/pseudo-element-inside-any.html is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=232046.

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284567 => 284568)

--- trunk/LayoutTests/ChangeLog	2021-10-20 21:13:11 UTC (rev 284567)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 21:26:04 UTC (rev 284568)
@@ -1,5 +1,14 @@
 2021-10-20  Ayumi Kojima  
 
+[ BigSure wk1 Debug ] fast/selectors/pseudo-element-inside-any.html is a flaky crash.
+https://bugs.webkit.org/show_bug.cgi?id=232046.
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
+2021-10-20  Ayumi Kojima  
+
 [ macOS wk1 ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus.html is a flaky failure.
 https://bugs.webkit.org/show_bug.cgi?id=232042
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (284567 => 284568)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-10-20 21:13:11 UTC (rev 284567)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-10-20 21:26:04 UTC (rev 284568)
@@ -753,6 +753,8 @@
 
 webkit.org/b/230062 fast/text/FontFaceSet-check-after-style-update.html [ Pass Failure ]
 
+webkit.org/b/232046 [ BigSur Debug ] fast/selectors/pseudo-element-inside-any.html [ Pass Crash ]
+
 # Skip anything related to WebAuthN
 http/wpt/credential-management/ [ Skip ]
 http/wpt/webauthn/ [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284567] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284567] trunk/LayoutTests








Revision 284567
Author ayumi_koj...@apple.com
Date 2021-10-20 14:13:11 -0700 (Wed, 20 Oct 2021)


Log Message
[ macOS wk1 ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=232042

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284566 => 284567)

--- trunk/LayoutTests/ChangeLog	2021-10-20 21:07:20 UTC (rev 284566)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 21:13:11 UTC (rev 284567)
@@ -1,5 +1,14 @@
 2021-10-20  Ayumi Kojima  
 
+[ macOS wk1 ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=232042
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
+2021-10-20  Ayumi Kojima  
+
 [ iOS macOS wk2 ]webanimations/marker-opacity-animation-no-effect.html is a flaky image failure.
 https://bugs.webkit.org/show_bug.cgi?id=232040
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (284566 => 284567)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-10-20 21:07:20 UTC (rev 284566)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-10-20 21:13:11 UTC (rev 284567)
@@ -768,7 +768,9 @@
 
 webkit.org/b/231918 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus-multiple-times.html [ Pass Failure ]
 webkit.org/b/231918 imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/focus-autofocus.html [ Pass Failure ]
- 
+
+webkit.org/b/232042 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus.html [ Pass Failure ] 
+
 webkit.org/b/184569 [ Debug ] animations/missing-from-to.html [ Skip ]
 
 webkit.org/b/184458 media/remote-control-command-is-user-gesture.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284566] trunk/Source/WebCore

2021-10-20 Thread Hironori . Fujii

Title: [284566] trunk/Source/WebCore








Revision 284566
Author hironori.fu...@sony.com
Date 2021-10-20 14:07:20 -0700 (Wed, 20 Oct 2021)


Log Message
The code decoding std::optional can't be compiled by PlayStation due to the ImagePaintingOptions template constructor
https://bugs.webkit.org/show_bug.cgi?id=231980

Reviewed by Ross Kirsling.

PlayStation clang can't compile the following code.
> std::optional val;
> decoder >> val;

It reports the following error.
> include\type_traits:3825:31: error: no member named 'value' in 'std::is_convertible &, WebCore::ImagePaintingOptions>'

* platform/graphics/ImagePaintingOptions.h:
(WebCore::ImagePaintingOptions::ImagePaintingOptions): Use SFINAE
for the first template constructor not to conflict with the second
one.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (284565 => 284566)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 20:57:36 UTC (rev 284565)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 21:07:20 UTC (rev 284566)
@@ -1,3 +1,22 @@
+2021-10-20  Fujii Hironori  
+
+The code decoding std::optional can't be compiled by PlayStation due to the ImagePaintingOptions template constructor
+https://bugs.webkit.org/show_bug.cgi?id=231980
+
+Reviewed by Ross Kirsling.
+
+PlayStation clang can't compile the following code.
+> std::optional val;
+> decoder >> val;
+
+It reports the following error.
+> include\type_traits:3825:31: error: no member named 'value' in 'std::is_convertible &, WebCore::ImagePaintingOptions>'
+
+* platform/graphics/ImagePaintingOptions.h:
+(WebCore::ImagePaintingOptions::ImagePaintingOptions): Use SFINAE
+for the first template constructor not to conflict with the second
+one.
+
 2021-10-20  Sihui Liu  
 
 Remove useless definition from IDBDatabase.idl


Modified: trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h (284565 => 284566)

--- trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h	2021-10-20 20:57:36 UTC (rev 284565)
+++ trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h	2021-10-20 21:07:20 UTC (rev 284566)
@@ -32,10 +32,10 @@
 namespace WebCore {
 
 struct ImagePaintingOptions {
-template
-ImagePaintingOptions(Options... options)
+template, ImagePaintingOptions>>>
+ImagePaintingOptions(First first, Rest... rest)
 {
-setOption(options...);
+setOption(first, rest...);
 }
 
 template






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284565] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284565] trunk/LayoutTests








Revision 284565
Author ayumi_koj...@apple.com
Date 2021-10-20 13:57:36 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS macOS wk2 ]webanimations/marker-opacity-animation-no-effect.html is a flaky image failure.
https://bugs.webkit.org/show_bug.cgi?id=232040

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284564 => 284565)

--- trunk/LayoutTests/ChangeLog	2021-10-20 20:32:37 UTC (rev 284564)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 20:57:36 UTC (rev 284565)
@@ -1,3 +1,13 @@
+2021-10-20  Ayumi Kojima  
+
+[ iOS macOS wk2 ]webanimations/marker-opacity-animation-no-effect.html is a flaky image failure.
+https://bugs.webkit.org/show_bug.cgi?id=232040
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2021-10-20  Eric Hutchison  
 
 [ iOS15 gpuprocess ] 2 css/color-filter tests are image-only failing.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284564 => 284565)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 20:32:37 UTC (rev 284564)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 20:57:36 UTC (rev 284565)
@@ -2058,6 +2058,8 @@
 webanimations/transform-property-and-transform-animation-with-delay-on-forced-layer.html [ Pass ]
 webanimations/translate-property-and-translate-animation-with-delay-on-forced-layer.html [ Pass ]
 
+webkit.org/b/232040 webanimations/marker-opacity-animation-no-effect.html [ Pass ImageOnlyFailure ]
+
 imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-pause-resume.tentative.html [ Pass Failure ]
 [ Release ] imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events.html [ Pass Failure ]
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284564 => 284565)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-10-20 20:32:37 UTC (rev 284564)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-10-20 20:57:36 UTC (rev 284565)
@@ -1347,6 +1347,8 @@
 webanimations/scale-property-and-scale-animation-with-delay-on-forced-layer.html [ Pass ]
 webanimations/transform-property-and-transform-animation-with-delay-on-forced-layer.html [ Pass ]
 
+webkit.org/b/232040 webanimations/marker-opacity-animation-no-effect.html [ Pass ImageOnlyFailure ]
+
 webkit.org/b/221847 platform/mac/media/encrypted-media/fps-encrypted-event.html [ Pass Timeout ]
 
 webkit.org/b/221857 fast/selectors/text-field-selection-window-inactive-text-shadow.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284564] trunk/Source/WebKit

2021-10-20 Thread beidson

Title: [284564] trunk/Source/WebKit








Revision 284564
Author beid...@apple.com
Date 2021-10-20 13:32:37 -0700 (Wed, 20 Oct 2021)


Log Message
Factor out some Notifications-specific messages from WebPageProxy messages
https://bugs.webkit.org/show_bug.cgi?id=232021

Reviewed by Alex Christensen.

In a future patch, there will be a runtime switch where WebContent sometimes sends these Notification
related messages to an objecting in Networking, and othertimes sends them to a WebPageProxy in the UIProcess.

To accomodate this switch, let's split them out into their own Notifications specific object and messages.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Sources.txt:
* WebKit.xcodeproj/project.pbxproj:

* Shared/Notifications/NotificationManagerMessageHandler.h: Added.
* Shared/Notifications/NotificationManagerMessageHandler.messages.in: Added.

* UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp: Added.
(WebKit::WebNotificationManagerMessageHandler::WebNotificationManagerMessageHandler):
(WebKit::WebNotificationManagerMessageHandler::showNotification):
(WebKit::WebNotificationManagerMessageHandler::cancelNotification):
(WebKit::WebNotificationManagerMessageHandler::clearNotifications):
(WebKit::WebNotificationManagerMessageHandler::didDestroyNotification):
* UIProcess/Notifications/WebNotificationManagerMessageHandler.h: Added.

* UIProcess/WebPageProxy.cpp:
(WebKit::m_notificationManagerMessageHandler):
(WebKit::WebPageProxy::addAllMessageReceivers):
(WebKit::WebPageProxy::removeAllMessageReceivers):
(WebKit::WebPageProxy::launchProcess):
(WebKit::WebPageProxy::swapToProvisionalPage):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::m_limitsNavigationsToAppBoundDomains): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):

Modified Paths

trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/DerivedSources-input.xcfilelist
trunk/Source/WebKit/DerivedSources-output.xcfilelist
trunk/Source/WebKit/DerivedSources.make
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp


Added Paths

trunk/Source/WebKit/Shared/Notifications/
trunk/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h
trunk/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h




Diff

Modified: trunk/Source/WebKit/CMakeLists.txt (284563 => 284564)

--- trunk/Source/WebKit/CMakeLists.txt	2021-10-20 19:55:36 UTC (rev 284563)
+++ trunk/Source/WebKit/CMakeLists.txt	2021-10-20 20:32:37 UTC (rev 284564)
@@ -44,6 +44,7 @@
 "${WEBKIT_DIR}/Shared/Databases/IndexedDB"
 "${WEBKIT_DIR}/Shared/FileAPI"
 "${WEBKIT_DIR}/Shared/Gamepad"
+"${WEBKIT_DIR}/Shared/Notifications"
 "${WEBKIT_DIR}/Shared/Plugins"
 "${WEBKIT_DIR}/Shared/Plugins/Netscape"
 "${WEBKIT_DIR}/Shared/Plugins/Netscape/x11"
@@ -192,6 +193,8 @@
 
 Shared/Authentication/AuthenticationManager
 
+Shared/Notifications/NotificationManagerMessageHandler
+
 Shared/Plugins/NPObjectMessageReceiver
 
 UIProcess/DrawingAreaProxy


Modified: trunk/Source/WebKit/ChangeLog (284563 => 284564)

--- trunk/Source/WebKit/ChangeLog	2021-10-20 19:55:36 UTC (rev 284563)
+++ trunk/Source/WebKit/ChangeLog	2021-10-20 20:32:37 UTC (rev 284564)
@@ -1,3 +1,51 @@
+2021-10-20  Brady Eidson  
+
+Factor out some Notifications-specific messages from WebPageProxy messages
+https://bugs.webkit.org/show_bug.cgi?id=232021
+
+Reviewed by Alex Christensen.
+
+In a future patch, there will be a runtime switch where WebContent sometimes sends these Notification
+related messages to an objecting in Networking, and othertimes sends them to a WebPageProxy in the UIProcess.
+
+To accomodate this switch, let's split them out into their own Notifications specific object and messages.
+
+* CMakeLists.txt:
+* DerivedSources-input.xcfilelist:
+* DerivedSources-output.xcfilelist:
+* DerivedSources.make:
+* Sources.txt:
+* WebKit.xcodeproj/project.pbxproj:
+
+* Shared/Notifications/NotificationManagerMessageHandler.h: Added.
+* Shared/Notifications/NotificationManagerMessageHandler.messages.in: Added.

[webkit-changes] [284563] trunk/LayoutTests

2021-10-20 Thread ehutchison

Title: [284563] trunk/LayoutTests








Revision 284563
Author ehutchi...@apple.com
Date 2021-10-20 12:55:36 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS15 gpuprocess ] 2 css/color-filter tests are image-only failing.
https://bugs.webkit.org/show_bug.cgi?id=232030.

Unreviewed test gardening.

* gpu-process/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284562 => 284563)

--- trunk/LayoutTests/ChangeLog	2021-10-20 19:40:43 UTC (rev 284562)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 19:55:36 UTC (rev 284563)
@@ -1,5 +1,14 @@
 2021-10-20  Eric Hutchison  
 
+[ iOS15 gpuprocess ] 2 css/color-filter tests are image-only failing.
+https://bugs.webkit.org/show_bug.cgi?id=232030.
+
+Unreviewed test gardening.
+
+* gpu-process/TestExpectations:
+
+2021-10-20  Eric Hutchison  
+
 [ iOS15 GPUProcess ] Multiple compositing tests are constant image-only failures.
 https://bugs.webkit.org/show_bug.cgi?id=232022.
 


Modified: trunk/LayoutTests/gpu-process/TestExpectations (284562 => 284563)

--- trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 19:40:43 UTC (rev 284562)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 19:55:36 UTC (rev 284563)
@@ -32,4 +32,7 @@
 
 [ iOS ] css3/color-filters/color-filter-composition-underline-color.html [ ImageOnlyFailure ]
 [ iOS ] css3/color-filters/color-filter-sepia.html [ Pass ImageOnlyFailure ]
+[ iOS ] fast/borders/hidpi-border-clipping-right-after-move.html [ ImageOnlyFailure ]
+[ iOS ] fast/css/content-counter-010.htm [ ImageOnlyFailure ]
 
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284562] trunk/LayoutTests

2021-10-20 Thread ehutchison

Title: [284562] trunk/LayoutTests








Revision 284562
Author ehutchi...@apple.com
Date 2021-10-20 12:40:43 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS15 GPUProcess ] Multiple compositing tests are constant image-only failures.
https://bugs.webkit.org/show_bug.cgi?id=232022.

Unreviewed test gardening.

* gpu-process/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284561 => 284562)

--- trunk/LayoutTests/ChangeLog	2021-10-20 19:24:53 UTC (rev 284561)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 19:40:43 UTC (rev 284562)
@@ -1,5 +1,14 @@
 2021-10-20  Eric Hutchison  
 
+[ iOS15 GPUProcess ] Multiple compositing tests are constant image-only failures.
+https://bugs.webkit.org/show_bug.cgi?id=232022.
+
+Unreviewed test gardening.
+
+* gpu-process/TestExpectations:
+
+2021-10-20  Eric Hutchison  
+
 [ iOS15 gpuprocess ] 2 css/color-filter tests are image-only failing.
 https://bugs.webkit.org/show_bug.cgi?id=232030.
 


Modified: trunk/LayoutTests/gpu-process/TestExpectations (284561 => 284562)

--- trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 19:24:53 UTC (rev 284561)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 19:40:43 UTC (rev 284562)
@@ -26,6 +26,9 @@
 
 [ iOS ] compositing/shared-backing/sharing-child-contributes-to-overlap.html [ ImageOnlyFailure ]
 [ iOS ] compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html [ ImageOnlyFailure ]
+[ iOS ] compositing/layer-creation/overlap-in-scroller.html [ ImageOnlyFailure ]
+[ iOS ] compositing/show-composited-iframe-on-back-button.html [ Pass ImageOnlyFailure ]
+[ iOS ] compositing/scrolling/async-overflow-scrolling/hidden-relative-layer-content-in-scroller.html [ ImageOnlyFailure ]
 
 [ iOS ] css3/color-filters/color-filter-composition-underline-color.html [ ImageOnlyFailure ]
 [ iOS ] css3/color-filters/color-filter-sepia.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284561] trunk/LayoutTests

2021-10-20 Thread ehutchison

Title: [284561] trunk/LayoutTests








Revision 284561
Author ehutchi...@apple.com
Date 2021-10-20 12:24:53 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS15 gpuprocess ] 2 css/color-filter tests are image-only failing.
https://bugs.webkit.org/show_bug.cgi?id=232030.

Unreviewed test gardening.

* gpu-process/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284560 => 284561)

--- trunk/LayoutTests/ChangeLog	2021-10-20 19:01:07 UTC (rev 284560)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 19:24:53 UTC (rev 284561)
@@ -1,5 +1,14 @@
 2021-10-20  Eric Hutchison  
 
+[ iOS15 gpuprocess ] 2 css/color-filter tests are image-only failing.
+https://bugs.webkit.org/show_bug.cgi?id=232030.
+
+Unreviewed test gardening.
+
+* gpu-process/TestExpectations:
+
+2021-10-20  Eric Hutchison  
+
 Update test expectations for compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html.
 https://bugs.webkit.org/show_bug.cgi?id=232022.
 


Modified: trunk/LayoutTests/gpu-process/TestExpectations (284560 => 284561)

--- trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 19:01:07 UTC (rev 284560)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 19:24:53 UTC (rev 284561)
@@ -27,3 +27,6 @@
 [ iOS ] compositing/shared-backing/sharing-child-contributes-to-overlap.html [ ImageOnlyFailure ]
 [ iOS ] compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html [ ImageOnlyFailure ]
 
+[ iOS ] css3/color-filters/color-filter-composition-underline-color.html [ ImageOnlyFailure ]
+[ iOS ] css3/color-filters/color-filter-sepia.html [ Pass ImageOnlyFailure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284560] trunk/LayoutTests

2021-10-20 Thread ehutchison

Title: [284560] trunk/LayoutTests








Revision 284560
Author ehutchi...@apple.com
Date 2021-10-20 12:01:07 -0700 (Wed, 20 Oct 2021)


Log Message
Update test expectations for compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html.
https://bugs.webkit.org/show_bug.cgi?id=232022.

Unreviewed test gardening.

* gpu-process/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284559 => 284560)

--- trunk/LayoutTests/ChangeLog	2021-10-20 18:59:22 UTC (rev 284559)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 19:01:07 UTC (rev 284560)
@@ -1,3 +1,12 @@
+2021-10-20  Eric Hutchison  
+
+Update test expectations for compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html.
+https://bugs.webkit.org/show_bug.cgi?id=232022.
+
+Unreviewed test gardening.
+
+* gpu-process/TestExpectations:
+
 2021-10-20  Ayumi Kojima  
 
 [ iOS macOS wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html is a flaky failure.


Modified: trunk/LayoutTests/gpu-process/TestExpectations (284559 => 284560)

--- trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 18:59:22 UTC (rev 284559)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 19:01:07 UTC (rev 284560)
@@ -25,3 +25,5 @@
 fast/canvas/webgl/lose-context-on-timeout.html [ Slow Pass ]
 
 [ iOS ] compositing/shared-backing/sharing-child-contributes-to-overlap.html [ ImageOnlyFailure ]
+[ iOS ] compositing/scrolling/async-overflow-scrolling/overflow-scroll-paint-order-sibling.html [ ImageOnlyFailure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284559] trunk/Source/WebKitLegacy/ios

2021-10-20 Thread ddkilzer

Title: [284559] trunk/Source/WebKitLegacy/ios








Revision 284559
Author ddkil...@apple.com
Date 2021-10-20 11:59:22 -0700 (Wed, 20 Oct 2021)


Log Message
WebPDFViewPlaceholder should use a weak delegate


Reviewed by Tim Horton.

* WebView/WebPDFViewPlaceholder.h:
(WebPDFViewPlaceholder.delegate):
- Mark property as `weak` instead of `assign`.
* WebView/WebPDFViewPlaceholder.mm:
(WebPDFViewPlaceholder._dataSource):
(WebPDFViewPlaceholder._delegate):
- Mark instance variables as as `_weak` to match `delegate`
  property and based on comment for `_dataSource`.

Modified Paths

trunk/Source/WebKitLegacy/ios/ChangeLog
trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.h
trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm




Diff

Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (284558 => 284559)

--- trunk/Source/WebKitLegacy/ios/ChangeLog	2021-10-20 18:56:38 UTC (rev 284558)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog	2021-10-20 18:59:22 UTC (rev 284559)
@@ -1,3 +1,19 @@
+2021-10-20  David Kilzer  
+
+WebPDFViewPlaceholder should use a weak delegate
+
+
+Reviewed by Tim Horton.
+
+* WebView/WebPDFViewPlaceholder.h:
+(WebPDFViewPlaceholder.delegate):
+- Mark property as `weak` instead of `assign`.
+* WebView/WebPDFViewPlaceholder.mm:
+(WebPDFViewPlaceholder._dataSource):
+(WebPDFViewPlaceholder._delegate):
+- Mark instance variables as as `_weak` to match `delegate`
+  property and based on comment for `_dataSource`.
+
 2021-10-13  Alex Christensen  
 
 Remove WTF::Variant and WTF::get


Modified: trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.h (284558 => 284559)

--- trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.h	2021-10-20 18:56:38 UTC (rev 284558)
+++ trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.h	2021-10-20 18:59:22 UTC (rev 284559)
@@ -51,7 +51,7 @@
  @property delegate
  @abstract A delegate object conforming to WebPDFViewPlaceholderDelegate that will be informed about various state changes.
  */
-@property (assign) NSObject *delegate;
+@property (weak) NSObject *delegate;
 
 /*!
  @property pageRects


Modified: trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm (284558 => 284559)

--- trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm	2021-10-20 18:56:38 UTC (rev 284558)
+++ trunk/Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm	2021-10-20 18:59:22 UTC (rev 284559)
@@ -102,9 +102,9 @@
 NSArray *_pageRects;
 NSArray *_pageYOrigins;
 CGPDFDocumentRef _document;
-WebDataSource *_dataSource; // weak to prevent cycles.
+__weak WebDataSource *_dataSource; // Weak to prevent cycles.
 
-NSObject *_delegate;
+__weak NSObject *_delegate;
 
 BOOL _didFinishLoad;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284558] trunk/Source/WebKit

2021-10-20 Thread ddkilzer

Title: [284558] trunk/Source/WebKit








Revision 284558
Author ddkil...@apple.com
Date 2021-10-20 11:56:38 -0700 (Wed, 20 Oct 2021)


Log Message
WebKit Objective-C classes should use weak delegates



Reviewed by Brent Fulgham.

* UIProcess/API/Cocoa/WKConnection.h:
* UIProcess/API/Cocoa/WKProcessGroup.h:
* UIProcess/API/mac/WKScrollViewMac.h:
- Change `delegate` property from `assign` to `weak` to document
  that WeakObjCPtr<> is used to store the value.

* UIProcess/ios/forms/WKFileUploadPanel.h:
- Change `delegate` property from `assign` to `weak` to make the
  instance variable weak.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.h
trunk/Source/WebKit/UIProcess/API/mac/WKScrollViewMac.h
trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (284557 => 284558)

--- trunk/Source/WebKit/ChangeLog	2021-10-20 18:51:34 UTC (rev 284557)
+++ trunk/Source/WebKit/ChangeLog	2021-10-20 18:56:38 UTC (rev 284558)
@@ -1,3 +1,21 @@
+2021-10-20  David Kilzer  
+
+WebKit Objective-C classes should use weak delegates
+
+
+
+Reviewed by Brent Fulgham.
+
+* UIProcess/API/Cocoa/WKConnection.h:
+* UIProcess/API/Cocoa/WKProcessGroup.h:
+* UIProcess/API/mac/WKScrollViewMac.h:
+- Change `delegate` property from `assign` to `weak` to document
+  that WeakObjCPtr<> is used to store the value.
+
+* UIProcess/ios/forms/WKFileUploadPanel.h:
+- Change `delegate` property from `assign` to `weak` to make the
+  instance variable weak.
+
 2021-10-20  Said Abou-Hallawa  
 
 [iOS] Ensure the CA transaction has been synchronously committed before snapshotting it


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.h (284557 => 284558)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.h	2021-10-20 18:51:34 UTC (rev 284557)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.h	2021-10-20 18:56:38 UTC (rev 284558)
@@ -41,6 +41,6 @@
 
 - (void)sendMessageWithName:(NSString *)messageName body:(id)messageBody;
 
-@property (assign) id  delegate;
+@property (nonatomic, weak) id  delegate;
 
 @end


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.h (284557 => 284558)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.h	2021-10-20 18:51:34 UTC (rev 284557)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.h	2021-10-20 18:56:38 UTC (rev 284558)
@@ -52,6 +52,6 @@
 
 #pragma mark Delegates
 
-@property (assign) id  delegate;
+@property (nonatomic, weak) id  delegate;
 
 @end


Modified: trunk/Source/WebKit/UIProcess/API/mac/WKScrollViewMac.h (284557 => 284558)

--- trunk/Source/WebKit/UIProcess/API/mac/WKScrollViewMac.h	2021-10-20 18:51:34 UTC (rev 284557)
+++ trunk/Source/WebKit/UIProcess/API/mac/WKScrollViewMac.h	2021-10-20 18:56:38 UTC (rev 284558)
@@ -37,7 +37,7 @@
 
 @interface WKScrollView : NSScrollView
 
-@property (assign, nonatomic) id  delegate;
+@property (weak, nonatomic) id  delegate;
 @property (readonly, nonatomic) CGPoint contentOffset;
 
 @end


Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h (284557 => 284558)

--- trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h	2021-10-20 18:51:34 UTC (rev 284557)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h	2021-10-20 18:56:38 UTC (rev 284558)
@@ -39,7 +39,7 @@
 }
 
 @interface WKFileUploadPanel : UIViewController
-@property (nonatomic, assign) id  delegate;
+@property (nonatomic, weak) id  delegate;
 - (instancetype)initWithView:(WKContentView *)view;
 - (void)presentWithParameters:(API::OpenPanelParameters*)parameters resultListener:(WebKit::WebOpenPanelResultListenerProxy*)listener;
 - (void)dismiss;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284557] trunk/Tools

2021-10-20 Thread achristensen

Title: [284557] trunk/Tools








Revision 284557
Author achristen...@apple.com
Date 2021-10-20 11:51:34 -0700 (Wed, 20 Oct 2021)


Log Message
REGRESSION (r284418): [iOS] TestWebKitAPI.HSTS.Basic, TestWebKitAPI.HSTS.CrossOriginRedirect, TestWebKitAPI.HSTS.ThirdParty, and TestWebKitAPI.WebKit.RedirectToPlaintextHTTPSUpgrade timing out
https://bugs.webkit.org/show_bug.cgi?id=232003

Reviewed by Chris Dumez.

I observed that sometimes the framer's nw_framer_input_handler_t is called after calling nw_framer_pass_through_input.
To fix this, I instead call nw_framer_deliver_input_no_copy myself to pass through the data inside my nw_framer_input_handler_t.

* TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST):
* TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::proxyDefinition):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm




Diff

Modified: trunk/Tools/ChangeLog (284556 => 284557)

--- trunk/Tools/ChangeLog	2021-10-20 18:50:14 UTC (rev 284556)
+++ trunk/Tools/ChangeLog	2021-10-20 18:51:34 UTC (rev 284557)
@@ -1,3 +1,24 @@
+2021-10-20  Alex Christensen  
+
+REGRESSION (r284418): [iOS] TestWebKitAPI.HSTS.Basic, TestWebKitAPI.HSTS.CrossOriginRedirect, TestWebKitAPI.HSTS.ThirdParty, and TestWebKitAPI.WebKit.RedirectToPlaintextHTTPSUpgrade timing out
+https://bugs.webkit.org/show_bug.cgi?id=232003
+
+Reviewed by Chris Dumez.
+
+I observed that sometimes the framer's nw_framer_input_handler_t is called after calling nw_framer_pass_through_input.
+To fix this, I instead call nw_framer_deliver_input_no_copy myself to pass through the data inside my nw_framer_input_handler_t.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
+(TEST):
+* TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
+(TEST):
+* TestWebKitAPI/cocoa/HTTPServer.mm:
+(TestWebKitAPI::proxyDefinition):
+
 2021-10-20  Roy Reapor  
 
 Benchmarks harness could fail if pyobjc-core module is upgraded without upgrading other pyobjc-frameworks


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm (284556 => 284557)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm	2021-10-20 18:50:14 UTC (rev 284556)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm	2021-10-20 18:51:34 UTC (rev 284557)
@@ -494,8 +494,6 @@
 TestWebKitAPI::Util::run();
 }
 
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=232003 Make this test stop timing out on iOS.
-#if PLATFORM(MAC)
 TEST(WebKit, RedirectToPlaintextHTTPSUpgrade)
 {
 using namespace TestWebKitAPI;
@@ -517,4 +515,3 @@
 [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"https://download/originalRequest"]]];
 EXPECT_WK_STREQ([webView _test_waitForAlert], "success!");
 }
-#endif // PLATFORM(MAC)


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm (284556 => 284557)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm	2021-10-20 18:50:14 UTC (rev 284556)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm	2021-10-20 18:51:34 UTC (rev 284557)
@@ -58,8 +58,6 @@
 return { WTFMove(webView), WTFMove(delegate) };
 }
 
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=232003 Make this test stop timing out on iOS.
-#if PLATFORM(MAC)
 static HTTPServer hstsServer()
 {
 return HTTPServer({{ "/", {{{"Strict-Transport-Security" , "max-age=31536000"}}, "" }}}, HTTPServer::Protocol::HttpsProxy);
@@ -140,7 +138,6 @@
 EXPECT_WK_STREQ(webView.get().URL.absoluteString, "https://example.com/");
 EXPECT_EQ(httpServer.totalRequests(), 1u);
 }
-#endif // PLATFORM(MAC)
 
 #endif // HAVE(CFNETWORK_NSURLSESSION_HSTS_WITH_UNTRUSTED_ROOT)
 


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm (284556 => 284557)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm	2021-10-20 18:50:14 UTC (rev 284556)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm	2021-10-20 18:51:34 UTC (rev 284557)
@@ -73,8 +73,6 @@
 
 namespace TestWebKitAPI {
 
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=231396 Make this not time out on iOS bots.
-#if PLATFORM(MAC)
 TEST(WebKit, HTTPSProxy)
 {
 HTTPServer server(HTTPServer::respondWithOK, HTTPServer::Protocol::HttpsProxy);
@@ -92,7 +90,6 @@

[webkit-changes] [284556] trunk/Tools

2021-10-20 Thread commit-queue

Title: [284556] trunk/Tools








Revision 284556
Author commit-qu...@webkit.org
Date 2021-10-20 11:50:14 -0700 (Wed, 20 Oct 2021)


Log Message
Benchmarks harness could fail if pyobjc-core module is upgraded without upgrading other pyobjc-frameworks
https://bugs.webkit.org/show_bug.cgi?id=231983

Patch by Roy Reapor  on 2021-10-20
Reviewed by Jonathan Bedard.

* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.prepare_env): Use autoinstalled Quartz module
(OSXBrowserDriver._terminate_processes):  Use autoinstalled AppKit module

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py


Added Paths

trunk/Tools/Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py




Diff

Modified: trunk/Tools/ChangeLog (284555 => 284556)

--- trunk/Tools/ChangeLog	2021-10-20 18:42:14 UTC (rev 284555)
+++ trunk/Tools/ChangeLog	2021-10-20 18:50:14 UTC (rev 284556)
@@ -1,3 +1,14 @@
+2021-10-20  Roy Reapor  
+
+Benchmarks harness could fail if pyobjc-core module is upgraded without upgrading other pyobjc-frameworks
+https://bugs.webkit.org/show_bug.cgi?id=231983
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
+(OSXBrowserDriver.prepare_env): Use autoinstalled Quartz module
+(OSXBrowserDriver._terminate_processes):  Use autoinstalled AppKit module
+
 2021-10-20  Alex Christensen  
 
 Fix iOS build after r284539


Added: trunk/Tools/Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py (0 => 284556)

--- trunk/Tools/Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py	2021-10-20 18:50:14 UTC (rev 284556)
@@ -0,0 +1,40 @@
+# Copyright (C) 2020-2021 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+#notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+#notice, this list of conditions and the following disclaimer in the
+#documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import objc
+
+from webkitscmpy import AutoInstall, Package, Version
+
+pyobjc_core_version = Version.from_string(objc.__version__)
+AutoInstall.register(Package('Cocoa', pyobjc_core_version, pypi_name='pyobjc-framework-Cocoa'))
+AutoInstall.register(Package('Quartz', pyobjc_core_version, pypi_name='pyobjc-framework-Quartz'))
+
+# Modules from pyobjc-framework-Cocoa
+# Note, the module (`import_name`) provided to `AutoInstall.register`
+# must be imported first. This triggers the package install if necessary.
+Cocoa = __import__('Cocoa')
+AppKit = __import__('AppKit')
+CoreFoundation = __import__('CoreFoundation')
+Foundation = __import__('Foundation')
+
+# Module from pyobjc-framework-Quartz
+Quartz = __import__('Quartz')


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py (284555 => 284556)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py	2021-10-20 18:42:14 UTC (rev 284555)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py	2021-10-20 18:50:14 UTC (rev 284556)
@@ -21,8 +21,8 @@
 
 def prepare_env(self, config):
 self.close_browsers()
-from Quartz import CGWarpMouseCursorPosition
-CGWarpMouseCursorPosition((10, 0))
+from webkitpy.autoinstalled.pyobjc_frameworks import Quartz
+Quartz.CGWarpMouseCursorPosition((10, 0))
 self.updated_dock_animation_defaults = write_defaults('com.apple.dock', 'launchanim', False)
 if self.updated_dock_animation_defaults:
 self._terminate_processes('Dock', 'com.apple.dock')
@@ -61,9 +61,9 @@
 
 @classmethod
 def _terminate_processes(cls, process_name, bundle_id):
-from AppKit import NSRunningApplication
+from

[webkit-changes] [284555] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284555] trunk/LayoutTests








Revision 284555
Author ayumi_koj...@apple.com
Date 2021-10-20 11:42:14 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS macOS wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=232028

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284554 => 284555)

--- trunk/LayoutTests/ChangeLog	2021-10-20 18:35:32 UTC (rev 284554)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 18:42:14 UTC (rev 284555)
@@ -1,3 +1,13 @@
+2021-10-20  Ayumi Kojima  
+
+[ iOS macOS wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=232028
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2021-10-20  Eric Hutchison  
 
 [ iOS15 GPUProcess ] compositing/shared-backing/sharing-child-contributes-to-overlap.html is a constant image-only failure.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284554 => 284555)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 18:35:32 UTC (rev 284554)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 18:42:14 UTC (rev 284555)
@@ -1174,6 +1174,8 @@
 
 webkit.org/b/230407 imported/w3c/web-platform-tests/html/dom/idlharness.https.html [ Pass Failure ]
 
+webkit.org/b/232028 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html [ Pass Failure ]
+
 # Newly imported WPT tests that are timing out on iOS.
 imported/w3c/web-platform-tests/html/semantics/forms/the-button-element/button-activate-keyup-prevented.html [ Skip ]
 imported/w3c/web-platform-tests/uievents/click/auxclick_event.html [ Skip ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284554 => 284555)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-10-20 18:35:32 UTC (rev 284554)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-10-20 18:42:14 UTC (rev 284555)
@@ -1236,6 +1236,8 @@
 
 webkit.org/b/230691 [ Release ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-unsafe-none-to-unsafe-none.https.html [ Pass Failure ]
 
+webkit.org/b/232028 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html [ Pass Failure ]
+
 webkit.org/b/230113 [ BigSur+ Debug arm64 ] svg/animations/animate-elem-14-t-drt.html [ Pass Crash ]
 
 # rdar://66806059 (REGRESSION (20A2321a-20A2348b): 4 fast hidpi tests are a flaky image failure)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284554] trunk/LayoutTests

2021-10-20 Thread ehutchison

Title: [284554] trunk/LayoutTests








Revision 284554
Author ehutchi...@apple.com
Date 2021-10-20 11:35:32 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS15 GPUProcess ] compositing/shared-backing/sharing-child-contributes-to-overlap.html is a constant image-only failure.
https://bugs.webkit.org/show_bug.cgi?id=232022.

Unreviewed test gardening.

* gpu-process/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284553 => 284554)

--- trunk/LayoutTests/ChangeLog	2021-10-20 18:31:00 UTC (rev 284553)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 18:35:32 UTC (rev 284554)
@@ -1,5 +1,14 @@
 2021-10-20  Eric Hutchison  
 
+[ iOS15 GPUProcess ] compositing/shared-backing/sharing-child-contributes-to-overlap.html is a constant image-only failure.
+https://bugs.webkit.org/show_bug.cgi?id=232022.
+
+Unreviewed test gardening.
+
+* gpu-process/TestExpectations:
+
+2021-10-20  Eric Hutchison  
+
 Unreviewed, reverting r284551.
 
 TestExpectations file not recognized


Modified: trunk/LayoutTests/gpu-process/TestExpectations (284553 => 284554)

--- trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 18:31:00 UTC (rev 284553)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2021-10-20 18:35:32 UTC (rev 284554)
@@ -23,3 +23,5 @@
 
 fast/canvas/webgl/lose-context-on-timeout-async.html [ Slow Pass ]
 fast/canvas/webgl/lose-context-on-timeout.html [ Slow Pass ]
+
+[ iOS ] compositing/shared-backing/sharing-child-contributes-to-overlap.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284553] trunk/LayoutTests

2021-10-20 Thread ehutchison

Title: [284553] trunk/LayoutTests








Revision 284553
Author ehutchi...@apple.com
Date 2021-10-20 11:31:00 -0700 (Wed, 20 Oct 2021)


Log Message
Unreviewed, reverting r284551.

TestExpectations file not recognized

Reverted changeset:

https://commits.webkit.org/r284551

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/gpu-process/iOS/




Diff

Modified: trunk/LayoutTests/ChangeLog (284552 => 284553)

--- trunk/LayoutTests/ChangeLog	2021-10-20 18:19:55 UTC (rev 284552)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 18:31:00 UTC (rev 284553)
@@ -1,3 +1,13 @@
+2021-10-20  Eric Hutchison  
+
+Unreviewed, reverting r284551.
+
+TestExpectations file not recognized
+
+Reverted changeset:
+
+https://commits.webkit.org/r284551
+
 2021-10-20  Ayumi Kojima  
 
 [ iOS Release ] media/media-can-play-mpeg-audio.html is a flaky failure.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284552] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284552] trunk/LayoutTests








Revision 284552
Author ayumi_koj...@apple.com
Date 2021-10-20 11:19:55 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS Release ] media/media-can-play-mpeg-audio.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=232025

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284551 => 284552)

--- trunk/LayoutTests/ChangeLog	2021-10-20 18:19:55 UTC (rev 284551)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 18:19:55 UTC (rev 284552)
@@ -1,3 +1,12 @@
+2021-10-20  Ayumi Kojima  
+
+[ iOS Release ] media/media-can-play-mpeg-audio.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=232025
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-10-20  Rob Buis  
 
 Fix percentages on orthogonal replaced children


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284551 => 284552)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 18:19:55 UTC (rev 284551)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 18:19:55 UTC (rev 284552)
@@ -1375,6 +1375,8 @@
 
 webkit.org/b/228171 media/media-usage-state-private-browsing.html [ Pass Crash ]
 
+webkit.org/b/232025 [ Release ] media/media-can-play-mpeg-audio.html [ Pass Failure ]
+
 #  [ iOS ] Layout Test fast/css-custom-paint/simple-hidpi.html is a Flaky Failure (203637)
 webkit.org/b/203637 fast/css-custom-paint/simple-hidpi.html [ Pass ImageOnlyFailure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284551] trunk/LayoutTests/gpu-process

2021-10-20 Thread ehutchison

Title: [284551] trunk/LayoutTests/gpu-process








Revision 284551
Author ehutchi...@apple.com
Date 2021-10-20 11:19:55 -0700 (Wed, 20 Oct 2021)


Log Message
Created TestExpectations document for gpuprocess/iOS and updated.
https://bugs.webkit.org/show_bug.cgi?id=232022.

Unreviewed test gardening.

* gpu-process/iOS/TestExpectations: Added.

Added Paths

trunk/LayoutTests/gpu-process/iOS/
trunk/LayoutTests/gpu-process/iOS/TestExpectations




Diff

Added: trunk/LayoutTests/gpu-process/iOS/TestExpectations (0 => 284551)

--- trunk/LayoutTests/gpu-process/iOS/TestExpectations	(rev 0)
+++ trunk/LayoutTests/gpu-process/iOS/TestExpectations	2021-10-20 18:19:55 UTC (rev 284551)
@@ -0,0 +1 @@
+compositing/shared-backing/sharing-child-contributes-to-overlap.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284550] trunk/Source/WebCore

2021-10-20 Thread sihui_liu

Title: [284550] trunk/Source/WebCore








Revision 284550
Author sihui_...@apple.com
Date 2021-10-20 10:52:13 -0700 (Wed, 20 Oct 2021)


Log Message
Remove useless definition from IDBDatabase.idl
https://bugs.webkit.org/show_bug.cgi?id=231997

Reviewed by Chris Dumez.

DOMStringList is also iterable in WebKit now, so we don't need to keep this definition for compatibility (see
https://github.com/w3c/IndexedDB/issues/85#issuecomment-272587319).

Covered by existing test storage/indexeddb/transaction-basics.html, which verifies that DOMStringList can be
argument for IDBDatabase.transaction().

* Modules/indexeddb/IDBDatabase.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (284549 => 284550)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 17:51:29 UTC (rev 284549)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 17:52:13 UTC (rev 284550)
@@ -1,5 +1,20 @@
 2021-10-20  Sihui Liu  
 
+Remove useless definition from IDBDatabase.idl
+https://bugs.webkit.org/show_bug.cgi?id=231997
+
+Reviewed by Chris Dumez.
+
+DOMStringList is also iterable in WebKit now, so we don't need to keep this definition for compatibility (see
+https://github.com/w3c/IndexedDB/issues/85#issuecomment-272587319).
+
+Covered by existing test storage/indexeddb/transaction-basics.html, which verifies that DOMStringList can be 
+argument for IDBDatabase.transaction().
+
+* Modules/indexeddb/IDBDatabase.idl:
+
+2021-10-20  Sihui Liu  
+
 Share code between JSDOMIterator and JSDOMAsyncIterator
 https://bugs.webkit.org/show_bug.cgi?id=231437
 


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl (284549 => 284550)

--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl	2021-10-20 17:51:29 UTC (rev 284549)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl	2021-10-20 17:52:13 UTC (rev 284550)
@@ -44,10 +44,6 @@
 attribute EventHandler onclose;
 attribute EventHandler onerror;
 attribute EventHandler onversionchange;
-
-// Non-standard: This is not part of the spec, but is needed for compatibility.
-// See https://github.com/w3c/IndexedDB/issues/85
-IDBTransaction transaction(DOMStringList storeNames, optional IDBTransactionMode mode = "readonly");
 };
 
 dictionary IDBObjectStoreParameters {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284549] trunk/Source/WebCore

2021-10-20 Thread sihui_liu

Title: [284549] trunk/Source/WebCore








Revision 284549
Author sihui_...@apple.com
Date 2021-10-20 10:51:29 -0700 (Wed, 20 Oct 2021)


Log Message
Share code between JSDOMIterator and JSDOMAsyncIterator
https://bugs.webkit.org/show_bug.cgi?id=231437


Reviewed by Youenn Fablet.

* bindings/js/JSDOMAsyncIterator.h:
(WebCore::jsPair): Deleted.
(WebCore::iteratorCreate): Deleted.
* bindings/js/JSFileSystemDirectoryHandleIterator.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMAsyncIterator.h
trunk/Source/WebCore/bindings/js/JSFileSystemDirectoryHandleIterator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (284548 => 284549)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 17:35:18 UTC (rev 284548)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 17:51:29 UTC (rev 284549)
@@ -1,3 +1,16 @@
+2021-10-20  Sihui Liu  
+
+Share code between JSDOMIterator and JSDOMAsyncIterator
+https://bugs.webkit.org/show_bug.cgi?id=231437
+
+
+Reviewed by Youenn Fablet.
+
+* bindings/js/JSDOMAsyncIterator.h:
+(WebCore::jsPair): Deleted.
+(WebCore::iteratorCreate): Deleted.
+* bindings/js/JSFileSystemDirectoryHandleIterator.h:
+
 2021-10-20  Rob Buis  
 
 Fix percentages on orthogonal replaced children


Modified: trunk/Source/WebCore/bindings/js/JSDOMAsyncIterator.h (284548 => 284549)

--- trunk/Source/WebCore/bindings/js/JSDOMAsyncIterator.h	2021-10-20 17:35:18 UTC (rev 284548)
+++ trunk/Source/WebCore/bindings/js/JSDOMAsyncIterator.h	2021-10-20 17:51:29 UTC (rev 284549)
@@ -26,6 +26,7 @@
 #pragma once
 
 #include "JSDOMConvert.h"
+#include "JSDOMIterator.h"
 #include "JSDOMPromise.h"
 #include "JSDOMPromiseDeferred.h"
 #include <_javascript_Core/AsyncIteratorPrototype.h>
@@ -37,19 +38,6 @@
 
 namespace WebCore {
 
-void addValueIterableMethods(JSC::JSGlobalObject&, JSC::JSObject&);
-
-enum class JSDOMAsyncIteratorType { Set, Map };
-
-// struct IteratorTraits {
-// static constexpr JSDOMAsyncIteratorType type = [Map|Set];
-// using KeyType = [IDLType|void];
-// using ValueType = [IDLType];
-// };
-
-template using EnableIfMap = typename std::enable_if::type;
-template using EnableIfSet = typename std::enable_if::type;
-
 // https://webidl.spec.whatwg.org/#es-asynchronous-iterator-prototype-object
 template class JSDOMAsyncIteratorPrototype final : public JSC::JSNonFinalObject {
 public:
@@ -89,8 +77,6 @@
 void finishCreation(JSC::VM&, JSC::JSGlobalObject*);
 };
 
-using IterationKind = JSC::IterationKind;
-
 template class JSDOMAsyncIteratorBase : public JSDOMObject {
 public:
 using Base = JSDOMObject;
@@ -132,30 +118,6 @@
 RefPtr m_ongoingPromise;
 };
 
-inline JSC::JSValue jsPair(JSC::JSGlobalObject&, JSDOMGlobalObject& globalObject, JSC::JSValue value1, JSC::JSValue value2)
-{
-JSC::MarkedArgumentBuffer arguments;
-arguments.append(value1);
-arguments.append(value2);
-ASSERT(!arguments.hasOverflowed());
-return constructArray(, static_cast(nullptr), arguments);
-}
-
-template
-inline JSC::JSValue jsPair(JSC::JSGlobalObject& lexicalGlobalObject, JSDOMGlobalObject& globalObject, const T& value1, const U& value2)
-{
-return jsPair(lexicalGlobalObject, globalObject, toJS(lexicalGlobalObject, globalObject, value1), toJS(lexicalGlobalObject, globalObject, value2));
-}
-
-template JSC::JSValue iteratorCreate(typename JSIterator::Wrapper&, IterationKind);
-
-template JSC::JSValue iteratorCreate(typename JSIterator::Wrapper& thisObject, IterationKind kind)
-{
-ASSERT(thisObject.globalObject());
-JSDOMGlobalObject& globalObject = *thisObject.globalObject();
-return JSIterator::create(globalObject.vm(), getDOMStructure(globalObject.vm(), globalObject), thisObject, kind);
-}
-
 template
 inline EnableIfMap convertToJS(JSC::JSGlobalObject& globalObject, JSDOMGlobalObject& domGlobalObject, IteratorValue& value, IteratorTraits, IterationKind kind)
 {


Modified: trunk/Source/WebCore/bindings/js/JSFileSystemDirectoryHandleIterator.h (284548 => 284549)

--- trunk/Source/WebCore/bindings/js/JSFileSystemDirectoryHandleIterator.h	2021-10-20 17:35:18 UTC (rev 284548)
+++ trunk/Source/WebCore/bindings/js/JSFileSystemDirectoryHandleIterator.h	2021-10-20 17:51:29 UTC (rev 284549)
@@ -34,7 +34,7 @@
 class FileSystemHandle;
 
 struct JSFileSystemDirectoryHandleIteratorTraits {
-static constexpr JSDOMAsyncIteratorType type = JSDOMAsyncIteratorType::Map;
+static constexpr JSDOMIteratorType type = JSDOMIteratorType::Map;
 using KeyType = IDLByteString;
 using ValueType = IDLInterface;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284548] trunk

2021-10-20 Thread commit-queue

Title: [284548] trunk








Revision 284548
Author commit-qu...@webkit.org
Date 2021-10-20 10:35:18 -0700 (Wed, 20 Oct 2021)


Log Message
Fix percentages on orthogonal replaced children
https://bugs.webkit.org/show_bug.cgi?id=46496

Patch by Rob Buis  on 2021-10-20
Reviewed by Darin Adler.

Source/WebCore:

Modify computeReplacedLogicalWidthUsing to make it aware of the orthogonal flow case
when dealing with calc/percentages.

This patch also removes an outdated comment from computeReplacedLogicalHeightUsing.

Test: imported/w3c/web-platform-tests/wpt/css/css-writing-modes/sizing-percentages-replaced-orthogonal-001.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (284547 => 284548)

--- trunk/LayoutTests/ChangeLog	2021-10-20 17:30:32 UTC (rev 284547)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 17:35:18 UTC (rev 284548)
@@ -1,3 +1,12 @@
+2021-10-20  Rob Buis  
+
+Fix percentages on orthogonal replaced children
+https://bugs.webkit.org/show_bug.cgi?id=46496
+
+Reviewed by Darin Adler.
+
+* TestExpectations:
+
 2021-10-20  Ayumi Kojima  
 
 [ iOS ] imported/w3c/web-platform-tests/html/canvas/element/manual tests, fast/canvas/canvas-createPattern-video-modify.html and media/video-canvas-createPattern.html are failing.


Modified: trunk/LayoutTests/TestExpectations (284547 => 284548)

--- trunk/LayoutTests/TestExpectations	2021-10-20 17:30:32 UTC (rev 284547)
+++ trunk/LayoutTests/TestExpectations	2021-10-20 17:35:18 UTC (rev 284548)
@@ -4104,7 +4104,6 @@
 webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/sizing-orthogonal-percentage-margin-006.html [ ImageOnlyFailure ]
 webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/sizing-orthogonal-percentage-margin-007.html [ ImageOnlyFailure ]
 webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/sizing-orthogonal-percentage-margin-008.html [ ImageOnlyFailure ]
-webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/sizing-percentages-replaced-orthogonal-001.html [ ImageOnlyFailure ]
 webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/table-cell-001.html [ ImageOnlyFailure ]
 webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/table-cell-002.html [ ImageOnlyFailure ]
 webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/table-column-order-002.xht [ ImageOnlyFailure ]


Modified: trunk/Source/WebCore/ChangeLog (284547 => 284548)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 17:30:32 UTC (rev 284547)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 17:35:18 UTC (rev 284548)
@@ -1,3 +1,21 @@
+2021-10-20  Rob Buis  
+
+Fix percentages on orthogonal replaced children
+https://bugs.webkit.org/show_bug.cgi?id=46496
+
+Reviewed by Darin Adler.
+
+Modify computeReplacedLogicalWidthUsing to make it aware of the orthogonal flow case
+when dealing with calc/percentages.
+
+This patch also removes an outdated comment from computeReplacedLogicalHeightUsing.
+
+Test: imported/w3c/web-platform-tests/wpt/css/css-writing-modes/sizing-percentages-replaced-orthogonal-001.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeReplacedLogicalWidthUsing const):
+(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
+
 2021-10-20  Ross Kirsling  
 
 Mac CMake build should not need to include iOS headers


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (284547 => 284548)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2021-10-20 17:30:32 UTC (rev 284547)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2021-10-20 17:35:18 UTC (rev 284548)
@@ -3325,17 +3325,20 @@
 case LengthType::FillAvailable:
 case LengthType::Percent:
 case LengthType::Calculated: {
-// FIXME: containingBlockLogicalWidthForContent() is wrong if the replaced element's block-flow is perpendicular to the
-// containing block's block-flow.
-// https://bugs.webkit.org/show_bug.cgi?id=46496
-const LayoutUnit cw = isOutOfFlowPositioned() ? containingBlockLogicalWidthForPositioned(downcast(*container())) : containingBlockLogicalWidthForContent();
+LayoutUnit containerWidth;
+if (isOutOfFlowPositioned())
+containerWidth = containingBlockLogicalWidthForPositioned(downcast(*container()));
+else if (isHorizontalWritingMode() == containingBlock()->isHorizontalWritingMode())
+containerWidth = containingBlockLogicalWidthForContent();
+else
+containerWidth =

[webkit-changes] [284546] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284546] trunk/LayoutTests








Revision 284546
Author ayumi_koj...@apple.com
Date 2021-10-20 10:30:06 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS ] imported/w3c/web-platform-tests/html/canvas/element/manual tests, fast/canvas/canvas-createPattern-video-modify.html and media/video-canvas-createPattern.html are failing.
https://bugs.webkit.org/show_bug.cgi?id=231959

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284545 => 284546)

--- trunk/LayoutTests/ChangeLog	2021-10-20 17:26:12 UTC (rev 284545)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 17:30:06 UTC (rev 284546)
@@ -1,5 +1,14 @@
 2021-10-20  Ayumi Kojima  
 
+[ iOS ] imported/w3c/web-platform-tests/html/canvas/element/manual tests, fast/canvas/canvas-createPattern-video-modify.html and media/video-canvas-createPattern.html are failing.
+https://bugs.webkit.org/show_bug.cgi?id=231959
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-10-20  Ayumi Kojima  
+
 [ iOS Debug ] http/tests/xmlhttprequest tests are flaky timing out.
 https://bugs.webkit.org/show_bug.cgi?id=232017
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284545 => 284546)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 17:26:12 UTC (rev 284545)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 17:30:06 UTC (rev 284546)
@@ -2094,8 +2094,8 @@
 
 webkit.org/b/227762 imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/document-with-fragment-valid.html [ Pass Failure ]
 
-webkit.org/b/231959 [ Release ] imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html [ Failure ]
-webkit.org/b/231959 [ Release ] imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html [ Failure ]
+webkit.org/b/231959 imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html [ Failure ]
+webkit.org/b/231959 imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html [ Failure ]
 
 webkit.org/b/226789 imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284547] trunk/Source/WebKit

2021-10-20 Thread said

Title: [284547] trunk/Source/WebKit








Revision 284547
Author s...@apple.com
Date 2021-10-20 10:30:32 -0700 (Wed, 20 Oct 2021)


Log Message
[iOS] Ensure the CA transaction has been synchronously committed before snapshotting it
https://bugs.webkit.org/show_bug.cgi?id=230085


Reviewed by Tim Horton.

Because committing the CA transaction may be an asynchronous operation,
we need to ensure the CALayer is fully updated before snapshotting it.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _snapshotRectAfterScreenUpdates:rectInViewCoordinates:intoImageOfWidth:completionHandler:]):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (284546 => 284547)

--- trunk/Source/WebKit/ChangeLog	2021-10-20 17:30:06 UTC (rev 284546)
+++ trunk/Source/WebKit/ChangeLog	2021-10-20 17:30:32 UTC (rev 284547)
@@ -1,3 +1,21 @@
+2021-10-20  Said Abou-Hallawa  
+
+[iOS] Ensure the CA transaction has been synchronously committed before snapshotting it
+https://bugs.webkit.org/show_bug.cgi?id=230085
+
+
+Reviewed by Tim Horton.
+
+Because committing the CA transaction may be an asynchronous operation,
+we need to ensure the CALayer is fully updated before snapshotting it.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+* UIProcess/API/ios/WKWebViewIOS.mm:
+(-[WKWebView _snapshotRectAfterScreenUpdates:rectInViewCoordinates:intoImageOfWidth:completionHandler:]):
+(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
+
 2021-10-20  Ross Kirsling  
 
 Mac CMake build should not need to include iOS headers


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (284546 => 284547)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2021-10-20 17:30:06 UTC (rev 284546)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2021-10-20 17:30:32 UTC (rev 284547)
@@ -1222,8 +1222,9 @@
 CGFloat deviceScale = useIntrinsicDeviceScaleFactor ? UIScreen.mainScreen.scale : _page->deviceScaleFactor();
 CGFloat imageWidth = useIntrinsicDeviceScaleFactor ? snapshotWidth : snapshotWidth * deviceScale;
 RetainPtr strongSelf = self;
-auto callSnapshotRect = [strongSelf, rectInViewCoordinates, imageWidth, deviceScale, handler] {
-[strongSelf _snapshotRect:rectInViewCoordinates intoImageOfWidth:imageWidth completionHandler:[strongSelf, handler, deviceScale](CGImageRef snapshotImage) {
+BOOL afterScreenUpdates = snapshotConfiguration && snapshotConfiguration.afterScreenUpdates;
+auto callSnapshotRect = [strongSelf, afterScreenUpdates, rectInViewCoordinates, imageWidth, deviceScale, handler] {
+[strongSelf _snapshotRectAfterScreenUpdates:afterScreenUpdates rectInViewCoordinates:rectInViewCoordinates intoImageOfWidth:imageWidth completionHandler:[strongSelf, handler, deviceScale](CGImageRef snapshotImage) {
 RetainPtr error;
 RetainPtr image;
 


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h (284546 => 284547)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h	2021-10-20 17:30:06 UTC (rev 284546)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h	2021-10-20 17:30:32 UTC (rev 284547)
@@ -491,6 +491,7 @@
 - (void)_endAnimatedResize;
 - (void)_resizeWhileHidingContentWithUpdates:(void (^)(void))updateBlock;
 
+- (void)_snapshotRectAfterScreenUpdates:(BOOL)afterScreenUpdates rectInViewCoordinates:(CGRect)rectInViewCoordinates intoImageOfWidth:(CGFloat)imageWidth completionHandler:(void(^)(CGImageRef))completionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA));
 - (void)_snapshotRect:(CGRect)rectInViewCoordinates intoImageOfWidth:(CGFloat)imageWidth completionHandler:(void(^)(CGImageRef))completionHandler;
 
 - (void)_overrideLayoutParametersWithMinimumLayoutSize:(CGSize)minimumLayoutSize maximumUnobscuredSizeOverride:(CGSize)maximumUnobscuredSizeOverride WK_API_AVAILABLE(ios(9_0));


Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (284546 => 284547)

--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm	2021-10-20 17:30:06 UTC (rev 284546)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm	2021-10-20 17:30:32 UTC (rev 284547)
@@ -3189,12 +3189,12 @@
 // FIXME (): This method should be updated to take an image
 // width in points (for consistency) and a completion handler with a UIImage parameter
 // (to avoid redundant copies for PDFs), once it is no longer in use by

[webkit-changes] [284545] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284545] trunk/LayoutTests








Revision 284545
Author ayumi_koj...@apple.com
Date 2021-10-20 10:26:12 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS Debug ] http/tests/xmlhttprequest tests are flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=232017

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284544 => 284545)

--- trunk/LayoutTests/ChangeLog	2021-10-20 17:22:08 UTC (rev 284544)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 17:26:12 UTC (rev 284545)
@@ -1,3 +1,12 @@
+2021-10-20  Ayumi Kojima  
+
+[ iOS Debug ] http/tests/xmlhttprequest tests are flaky timing out.
+https://bugs.webkit.org/show_bug.cgi?id=232017
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-10-20  Antti Koivisto  
 
 fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html is failing


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284544 => 284545)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 17:22:08 UTC (rev 284544)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 17:26:12 UTC (rev 284545)
@@ -1247,6 +1247,9 @@
 
 webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]
 
+webkit.org/b/232017 [ Debug ] http/tests/xmlhttprequest/xhr-and-parse-large-document.html [ Slow ]
+webkit.org/b/232017 [ Debug ] http/tests/xmlhttprequest/xhr-large-document.html [ Slow ]
+
 webkit.org/b/171830 [ Debug ] http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
 
 webkit.org/b/230522 http/tests/websocket/tests/hybi/alert-in-event-handler.html [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284544] trunk/Source

2021-10-20 Thread ross . kirsling

Title: [284544] trunk/Source








Revision 284544
Author ross.kirsl...@sony.com
Date 2021-10-20 10:22:08 -0700 (Wed, 20 Oct 2021)


Log Message
Mac CMake build should not need to include iOS headers
https://bugs.webkit.org/show_bug.cgi?id=231998

Reviewed by Alex Christensen.

Source/WebCore:

* PlatformMac.cmake:
* platform/ios/WebItemProviderPasteboard.h:

Source/WebCore/PAL:

* pal/PlatformMac.cmake:

Source/WebKit:

* GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm:
* PlatformMac.cmake:
* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode const):
(WebKit::RemoteLayerTreeTransaction::decode):
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* UIProcess/API/Cocoa/WKWebViewTesting.mm:
* UIProcess/Cocoa/UIDelegate.mm:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/PlatformMac.cmake
trunk/Source/WebCore/PlatformMac.cmake
trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm
trunk/Source/WebKit/PlatformMac.cmake
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (284543 => 284544)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 17:18:12 UTC (rev 284543)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 17:22:08 UTC (rev 284544)
@@ -1,3 +1,13 @@
+2021-10-20  Ross Kirsling  
+
+Mac CMake build should not need to include iOS headers
+https://bugs.webkit.org/show_bug.cgi?id=231998
+
+Reviewed by Alex Christensen.
+
+* PlatformMac.cmake:
+* platform/ios/WebItemProviderPasteboard.h:
+
 2021-10-20  Antti Koivisto  
 
 fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html is failing


Modified: trunk/Source/WebCore/PAL/ChangeLog (284543 => 284544)

--- trunk/Source/WebCore/PAL/ChangeLog	2021-10-20 17:18:12 UTC (rev 284543)
+++ trunk/Source/WebCore/PAL/ChangeLog	2021-10-20 17:22:08 UTC (rev 284544)
@@ -1,3 +1,12 @@
+2021-10-20  Ross Kirsling  
+
+Mac CMake build should not need to include iOS headers
+https://bugs.webkit.org/show_bug.cgi?id=231998
+
+Reviewed by Alex Christensen.
+
+* pal/PlatformMac.cmake:
+
 2021-10-19  David Kilzer  
 
 REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a private header


Modified: trunk/Source/WebCore/PAL/pal/PlatformMac.cmake (284543 => 284544)

--- trunk/Source/WebCore/PAL/pal/PlatformMac.cmake	2021-10-20 17:18:12 UTC (rev 284543)
+++ trunk/Source/WebCore/PAL/pal/PlatformMac.cmake	2021-10-20 17:22:08 UTC (rev 284544)
@@ -21,8 +21,6 @@
 cocoa/UsageTrackingSoftLink.h
 cocoa/VisionKitCoreSoftLink.h
 
-ios/SystemStatusSoftLink.h
-
 mac/DataDetectorsSoftLink.h
 mac/LookupSoftLink.h
 mac/QuickLookUISoftLink.h
@@ -97,9 +95,6 @@
 spi/cocoa/WebFilterEvaluatorSPI.h
 spi/cocoa/pthreadSPI.h
 
-spi/ios/DataDetectorsUISPI.h
-spi/ios/GraphicsServicesSPI.h
-
 spi/mac/CoreUISPI.h
 spi/mac/DataDetectorsSPI.h
 spi/mac/HIServicesSPI.h


Modified: trunk/Source/WebCore/PlatformMac.cmake (284543 => 284544)

--- trunk/Source/WebCore/PlatformMac.cmake	2021-10-20 17:18:12 UTC (rev 284543)
+++ trunk/Source/WebCore/PlatformMac.cmake	2021-10-20 17:22:08 UTC (rev 284544)
@@ -93,7 +93,6 @@
 "${WEBCORE_DIR}/bridge/objc"
 "${WEBCORE_DIR}/crypto/mac"
 "${WEBCORE_DIR}/editing/cocoa"
-"${WEBCORE_DIR}/editing/ios"
 "${WEBCORE_DIR}/editing/mac"
 "${WEBCORE_DIR}/html/shadow/cocoa"
 "${WEBCORE_DIR}/layout/tableformatting"
@@ -134,7 +133,6 @@
 "${WEBCORE_DIR}/platform/mediastream/mac"
 "${WEBCORE_DIR}/platform/network/cocoa"
 "${WEBCORE_DIR}/platform/network/cf"
-"${WEBCORE_DIR}/platform/network/ios"
 "${WEBCORE_DIR}/platform/network/mac"
 "${WEBCORE_DIR}/platform/text/cf"
 "${WEBCORE_DIR}/platform/text/cocoa"
@@ -142,7 +140,6 @@
 "${WEBCORE_DIR}/platform/spi/cf"
 "${WEBCORE_DIR}/platform/spi/cg"
 "${WEBCORE_DIR}/platform/spi/cocoa"
-"${WEBCORE_DIR}/platform/spi/ios"

[webkit-changes] [284543] trunk

2021-10-20 Thread commit-queue

Title: [284543] trunk








Revision 284543
Author commit-qu...@webkit.org
Date 2021-10-20 10:18:12 -0700 (Wed, 20 Oct 2021)


Log Message
Add ObjC as supported .clang-format language
https://bugs.webkit.org/show_bug.cgi?id=230401

Patch by Kimmo Kinnunen  on 2021-10-20
Reviewed by Jonathan Bedard.

Add ObjC and change few properties useful
for ObjC formatting.

* .clang-format:

Modified Paths

trunk/.clang-format
trunk/ChangeLog




Diff

Modified: trunk/.clang-format (284542 => 284543)

--- trunk/.clang-format	2021-10-20 17:14:10 UTC (rev 284542)
+++ trunk/.clang-format	2021-10-20 17:18:12 UTC (rev 284543)
@@ -1,5 +1,4 @@
 ---
-Language:Cpp
 # BasedOnStyle:  WebKit
 AccessModifierOffset: -4
 AlignAfterOpenBracket: DontAlign
@@ -62,10 +61,14 @@
   - Regex:   '^"config\.h"'
 Priority:-1
   # The main header for a source file automatically gets category 0
+  - Regex:   '^<.*SoftLink.h>'
+Priority:4
+  - Regex:   '^".*SoftLink.h"'
+Priority:3
+  - Regex:   '^<.*>'
+Priority:2
   - Regex:   '.*'
 Priority:1
-  - Regex:   '^<.*\.h>'
-Priority:2
 IncludeIsMainRegex: '(Test)?$'
 IndentCaseLabels: false
 IndentWidth: 4
@@ -106,5 +109,7 @@
 Standard:Cpp11
 TabWidth:8
 UseTab:  Never
+---
+Language: ObjC
+PointerAlignment: Right
 ...
-


Modified: trunk/ChangeLog (284542 => 284543)

--- trunk/ChangeLog	2021-10-20 17:14:10 UTC (rev 284542)
+++ trunk/ChangeLog	2021-10-20 17:18:12 UTC (rev 284543)
@@ -1,3 +1,15 @@
+2021-10-20  Kimmo Kinnunen  
+
+Add ObjC as supported .clang-format language
+https://bugs.webkit.org/show_bug.cgi?id=230401
+
+Reviewed by Jonathan Bedard.
+
+Add ObjC and change few properties useful
+for ObjC formatting.
+
+* .clang-format:
+
 2021-10-20  Carlos Garcia Campos  
 
 [WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284542] trunk

2021-10-20 Thread antti

Title: [284542] trunk








Revision 284542
Author an...@apple.com
Date 2021-10-20 10:14:10 -0700 (Wed, 20 Oct 2021)


Log Message
fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html is failing
https://bugs.webkit.org/show_bug.cgi?id=232008
rdar://84276269

Reviewed by Alan Bujtas.

Source/WebCore:

Other browsers and WPT tests imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-003.html
and imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-004.html agree with our new painting
behavior. Change the test instead of changing the behavior back.

Also fix the legacy line layout to have the same painting behavior.

* layout/integration/InlineIteratorLine.cpp:
(WebCore::InlineIterator::Line::blockDirectionPointInLine const):

Fix to use selectionTopForHitTesting as the point needs to be within the hittable line.

* rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::selectionTop const):

For consistency also make the legacy selection painting behavior match.

LayoutTests:

* fast/block/line-layout/selection-highlight-overlap.html:

Adopt to the updated legacy behavior.

* fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html:

Change the test so it isn't affected by the behavior change.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/block/line-layout/selection-highlight-overlap-expected.html
trunk/LayoutTests/fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/InlineIteratorLine.cpp
trunk/Source/WebCore/rendering/LegacyRootInlineBox.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (284541 => 284542)

--- trunk/LayoutTests/ChangeLog	2021-10-20 17:11:41 UTC (rev 284541)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 17:14:10 UTC (rev 284542)
@@ -1,3 +1,19 @@
+2021-10-20  Antti Koivisto  
+
+fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=232008
+rdar://84276269
+
+Reviewed by Alan Bujtas.
+
+* fast/block/line-layout/selection-highlight-overlap.html:
+
+Adopt to the updated legacy behavior.
+
+* fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html:
+
+Change the test so it isn't affected by the behavior change.
+
 2021-10-20  Ayumi Kojima  
 
 Regression (r282211): [ macOS wk2 ] css3/filters/blur-various-radii.html is a flaky image failure.


Modified: trunk/LayoutTests/fast/block/line-layout/selection-highlight-overlap-expected.html (284541 => 284542)

--- trunk/LayoutTests/fast/block/line-layout/selection-highlight-overlap-expected.html	2021-10-20 17:11:41 UTC (rev 284541)
+++ trunk/LayoutTests/fast/block/line-layout/selection-highlight-overlap-expected.html	2021-10-20 17:14:10 UTC (rev 284542)
@@ -3,8 +3,12 @@
 div { outline: 1px dashed green; }
 div > div { outline: initial; background-color: rgba(0, 0, 255, .4); }
 
+
+
+
 
-
+
+
 
 
 


Modified: trunk/LayoutTests/fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html (284541 => 284542)

--- trunk/LayoutTests/fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html	2021-10-20 17:11:41 UTC (rev 284541)
+++ trunk/LayoutTests/fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html	2021-10-20 17:14:10 UTC (rev 284542)
@@ -33,17 +33,17 @@
 let image = document.querySelector("img");
 internals.installImageOverlay(image, [
 {
-topLeft : new DOMPointReadOnly(0.5, 1.5),
-topRight : new DOMPointReadOnly(1.5, 0.5),
-bottomRight : new DOMPointReadOnly(2, 1),
-bottomLeft : new DOMPointReadOnly(1, 2),
+topLeft : new DOMPointReadOnly(0.55, 1.55),
+topRight : new DOMPointReadOnly(1.55, 0.55),
+bottomRight : new DOMPointReadOnly(2.05, 1.05),
+bottomLeft : new DOMPointReadOnly(1.05, 2.05),
 children: [
 {
 text : "hello",
-topLeft : new DOMPointReadOnly(0.5, 1.5),
-topRight : new DOMPointReadOnly(1.5, 0.5),
-bottomRight : new DOMPointReadOnly(2, 1),
-bottomLeft : new DOMPointReadOnly(1, 2),
+topLeft : new DOMPointReadOnly(0.55, 1.55),
+topRight : new DOMPointReadOnly(1.55, 0.55),
+bottomRight : new DOMPointReadOnly(2.05, 1.05),
+bottomLeft : new DOMPointReadOnly(1.05, 2.05),
 }
 ]
 }
@@ -53,4 +53,4 @@
 });
 
 
-
\ No newline at end of file
+


Modified: trunk/Source/WebCore/ChangeLog (284541 => 284542)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 17:11:41 UTC (rev 284541)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 17:14:10 UTC (rev

[webkit-changes] [284541] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284541] trunk/LayoutTests








Revision 284541
Author ayumi_koj...@apple.com
Date 2021-10-20 10:11:41 -0700 (Wed, 20 Oct 2021)


Log Message
Regression (r282211): [ macOS wk2 ] css3/filters/blur-various-radii.html is a flaky image failure.
https://bugs.webkit.org/show_bug.cgi?id=231090

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284540 => 284541)

--- trunk/LayoutTests/ChangeLog	2021-10-20 16:37:01 UTC (rev 284540)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 17:11:41 UTC (rev 284541)
@@ -1,5 +1,14 @@
 2021-10-20  Ayumi Kojima  
 
+Regression (r282211): [ macOS wk2 ] css3/filters/blur-various-radii.html is a flaky image failure.
+https://bugs.webkit.org/show_bug.cgi?id=231090
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2021-10-20  Ayumi Kojima  
+
 [ iOS ] fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in tests are a flaky timeout.
 https://bugs.webkit.org/show_bug.cgi?id=230959
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284540 => 284541)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-10-20 16:37:01 UTC (rev 284540)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-10-20 17:11:41 UTC (rev 284541)
@@ -1660,8 +1660,6 @@
 
 webkit.org/b/230504 [ Catalina BigSur Release ] css3/masking/reference-clip-path-animate-transform-repaint.html [ Pass Failure ]
 
-webkit.org/b/231090 css3/filters/blur-various-radii.html [ Pass ImageOnlyFailure ]
-
 webkit.org/b/230514 [ Catalina BigSur Release ] imported/w3c/web-platform-tests/html/webappapis/structured-clone/structured-clone.any.html [ Pass Crash ]
 
 webkit.org/b/230518 [ Catalina Release ]  accessibility/mac/button-shouldnot-have-axvalue.html [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284540] trunk/Tools

2021-10-20 Thread achristensen

Title: [284540] trunk/Tools








Revision 284540
Author achristen...@apple.com
Date 2021-10-20 09:37:01 -0700 (Wed, 20 Oct 2021)


Log Message
Fix iOS build after r284539
https://bugs.webkit.org/show_bug.cgi?id=232003

* TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm




Diff

Modified: trunk/Tools/ChangeLog (284539 => 284540)

--- trunk/Tools/ChangeLog	2021-10-20 16:34:16 UTC (rev 284539)
+++ trunk/Tools/ChangeLog	2021-10-20 16:37:01 UTC (rev 284540)
@@ -1,5 +1,12 @@
 2021-10-20  Alex Christensen  
 
+Fix iOS build after r284539
+https://bugs.webkit.org/show_bug.cgi?id=232003
+
+* TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
+
+2021-10-20  Alex Christensen  
+
 Skip timing out tests on iOS while I investigate.
 https://bugs.webkit.org/show_bug.cgi?id=232003
 


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm (284539 => 284540)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm	2021-10-20 16:34:16 UTC (rev 284539)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm	2021-10-20 16:37:01 UTC (rev 284540)
@@ -58,13 +58,13 @@
 return { WTFMove(webView), WTFMove(delegate) };
 }
 
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=232003 Make this test stop timing out on iOS.
+#if PLATFORM(MAC)
 static HTTPServer hstsServer()
 {
 return HTTPServer({{ "/", {{{"Strict-Transport-Security" , "max-age=31536000"}}, "" }}}, HTTPServer::Protocol::HttpsProxy);
 }
 
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=232003 Make this test stop timing out on iOS.
-#if PLATFORM(MAC)
 TEST(HSTS, Basic)
 {
 auto httpsServer = hstsServer();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284539] trunk/Tools

2021-10-20 Thread achristensen

Title: [284539] trunk/Tools








Revision 284539
Author achristen...@apple.com
Date 2021-10-20 09:34:16 -0700 (Wed, 20 Oct 2021)


Log Message
Skip timing out tests on iOS while I investigate.
https://bugs.webkit.org/show_bug.cgi?id=232003

These tests are clearly timing out on iOS, but it'll take more than an hour or so to investigate.
Keep the bots green while I look into a better solution.

* TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
* TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm




Diff

Modified: trunk/Tools/ChangeLog (284538 => 284539)

--- trunk/Tools/ChangeLog	2021-10-20 16:04:15 UTC (rev 284538)
+++ trunk/Tools/ChangeLog	2021-10-20 16:34:16 UTC (rev 284539)
@@ -1,3 +1,14 @@
+2021-10-20  Alex Christensen  
+
+Skip timing out tests on iOS while I investigate.
+https://bugs.webkit.org/show_bug.cgi?id=232003
+
+These tests are clearly timing out on iOS, but it'll take more than an hour or so to investigate.
+Keep the bots green while I look into a better solution.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
+* TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
+
 2021-10-20  Michael Catanzaro  
 
 Do not use strerror()


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm (284538 => 284539)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm	2021-10-20 16:04:15 UTC (rev 284538)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm	2021-10-20 16:34:16 UTC (rev 284539)
@@ -494,6 +494,8 @@
 TestWebKitAPI::Util::run();
 }
 
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=232003 Make this test stop timing out on iOS.
+#if PLATFORM(MAC)
 TEST(WebKit, RedirectToPlaintextHTTPSUpgrade)
 {
 using namespace TestWebKitAPI;
@@ -515,3 +517,4 @@
 [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"https://download/originalRequest"]]];
 EXPECT_WK_STREQ([webView _test_waitForAlert], "success!");
 }
+#endif // PLATFORM(MAC)


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm (284538 => 284539)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm	2021-10-20 16:04:15 UTC (rev 284538)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm	2021-10-20 16:34:16 UTC (rev 284539)
@@ -63,6 +63,8 @@
 return HTTPServer({{ "/", {{{"Strict-Transport-Security" , "max-age=31536000"}}, "" }}}, HTTPServer::Protocol::HttpsProxy);
 }
 
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=232003 Make this test stop timing out on iOS.
+#if PLATFORM(MAC)
 TEST(HSTS, Basic)
 {
 auto httpsServer = hstsServer();
@@ -138,6 +140,7 @@
 EXPECT_WK_STREQ(webView.get().URL.absoluteString, "https://example.com/");
 EXPECT_EQ(httpServer.totalRequests(), 1u);
 }
+#endif // PLATFORM(MAC)
 
 #endif // HAVE(CFNETWORK_NSURLSESSION_HSTS_WITH_UNTRUSTED_ROOT)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284538] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284538] trunk/LayoutTests








Revision 284538
Author ayumi_koj...@apple.com
Date 2021-10-20 09:04:15 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS ] fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in tests are a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=230959

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284537 => 284538)

--- trunk/LayoutTests/ChangeLog	2021-10-20 15:51:56 UTC (rev 284537)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 16:04:15 UTC (rev 284538)
@@ -1,5 +1,14 @@
 2021-10-20  Ayumi Kojima  
 
+[ iOS ] fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in tests are a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=230959
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-10-20  Ayumi Kojima  
+
 [ iOS 15 ] fast/scrolling/ios/scroll-snap-with-relayouts tests are flaky failing.
 https://bugs.webkit.org/show_bug.cgi?id=232014
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284537 => 284538)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 15:51:56 UTC (rev 284537)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 16:04:15 UTC (rev 284538)
@@ -1916,6 +1916,7 @@
 webkit.org/b/214512 imported/w3c/web-platform-tests/css/geometry/DOMMatrix2DInit-validate-fixup.html [ Pass Failure ]
 
 webkit.org/b/230959 fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-overflow.html [ Pass Timeout ]
+webkit.org/b/230959 fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-main-frame.html [ Pass Timeout ]
 
 webkit.org/b/214598 fast/scrolling/ios/autoscroll-input-when-very-zoomed.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284537] trunk/LayoutTests

2021-10-20 Thread ayumi_kojima

Title: [284537] trunk/LayoutTests








Revision 284537
Author ayumi_koj...@apple.com
Date 2021-10-20 08:51:56 -0700 (Wed, 20 Oct 2021)


Log Message
[ iOS 15 ] fast/scrolling/ios/scroll-snap-with-relayouts tests are flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=232014

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (284536 => 284537)

--- trunk/LayoutTests/ChangeLog	2021-10-20 15:25:44 UTC (rev 284536)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 15:51:56 UTC (rev 284537)
@@ -1,3 +1,12 @@
+2021-10-20  Ayumi Kojima  
+
+[ iOS 15 ] fast/scrolling/ios/scroll-snap-with-relayouts tests are flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=232014
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-10-20  John Pascoe  
 
 WebAuthn] Obtain consent to create new credential when platform authenticator in excludedCredentials


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284536 => 284537)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 15:25:44 UTC (rev 284536)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-10-20 15:51:56 UTC (rev 284537)
@@ -1923,6 +1923,9 @@
 
 webkit.org/b/231641 fast/scrolling/ios/scroll-snap-with-momentum-scroll-in-overflow-scroll-area.html [ Pass Failure ]
 
+webkit.org/b/232014 fast/scrolling/ios/scroll-snap-with-relayouts-vertical.html [ Pass Failure ]
+webkit.org/b/232014 fast/scrolling/ios/scroll-snap-with-relayouts-horizontal.html [ Pass Failure ]
+
 webkit.org/b/230988 [ Debug ] fast/selectors/is-backtracking.html [ Timeout ]
 webkit.org/b/230988 [ Debug ] fast/selectors/matches-backtracking.html [ Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284536] trunk/Source

2021-10-20 Thread antti

Title: [284536] trunk/Source








Revision 284536
Author an...@apple.com
Date 2021-10-20 08:25:44 -0700 (Wed, 20 Oct 2021)


Log Message
Don't re-evaluate viewport dependent media queries if the viewport doesn't change
https://bugs.webkit.org/show_bug.cgi?id=231949
rdar://77240171

Reviewed by Alan Bujtas.

Source/WebCore:

If there are many viewport dependent rules (some pages have thousands) re-evaluating can take a while.
It is currently done unconditionally before layout.

* css/MediaQueryEvaluator.cpp:
(WebCore::mediaQueryViewportStateForDocument):
* css/MediaQueryEvaluator.h:
* style/StyleScope.cpp:
(WebCore::Style::Scope::evaluateMediaQueriesForViewportChange):

Save the viewport state so we can test if anything that affects media query results has changed since the last time.

* style/StyleScope.h:

Source/WebKit:

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::handlePreferenceChange):

Remember to signal accessibility settings change on this code path too.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/MediaQueryEvaluator.cpp
trunk/Source/WebCore/css/MediaQueryEvaluator.h
trunk/Source/WebCore/style/StyleScope.cpp
trunk/Source/WebCore/style/StyleScope.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (284535 => 284536)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 15:24:03 UTC (rev 284535)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 15:25:44 UTC (rev 284536)
@@ -1,3 +1,24 @@
+2021-10-20  Antti Koivisto  
+
+Don't re-evaluate viewport dependent media queries if the viewport doesn't change
+https://bugs.webkit.org/show_bug.cgi?id=231949
+rdar://77240171
+
+Reviewed by Alan Bujtas.
+
+If there are many viewport dependent rules (some pages have thousands) re-evaluating can take a while.
+It is currently done unconditionally before layout.
+
+* css/MediaQueryEvaluator.cpp:
+(WebCore::mediaQueryViewportStateForDocument):
+* css/MediaQueryEvaluator.h:
+* style/StyleScope.cpp:
+(WebCore::Style::Scope::evaluateMediaQueriesForViewportChange):
+
+Save the viewport state so we can test if anything that affects media query results has changed since the last time.
+
+* style/StyleScope.h:
+
 2021-10-20  Yusuke Suzuki  
 
 AudioArray should ensure 32byte alignment


Modified: trunk/Source/WebCore/css/MediaQueryEvaluator.cpp (284535 => 284536)

--- trunk/Source/WebCore/css/MediaQueryEvaluator.cpp	2021-10-20 15:24:03 UTC (rev 284535)
+++ trunk/Source/WebCore/css/MediaQueryEvaluator.cpp	2021-10-20 15:25:44 UTC (rev 284536)
@@ -110,6 +110,12 @@
 ;
 }
 
+MediaQueryViewportState mediaQueryViewportStateForDocument(const Document& document)
+{
+// These things affect evaluation of viewport dependent media queries.
+return { document.view()->layoutSize(), document.frame()->pageZoomFactor(), document.printing() };
+}
+
 MediaQueryEvaluator::MediaQueryEvaluator(bool mediaFeatureResult)
 : m_fallbackResult(mediaFeatureResult)
 {


Modified: trunk/Source/WebCore/css/MediaQueryEvaluator.h (284535 => 284536)

--- trunk/Source/WebCore/css/MediaQueryEvaluator.h	2021-10-20 15:24:03 UTC (rev 284535)
+++ trunk/Source/WebCore/css/MediaQueryEvaluator.h	2021-10-20 15:25:44 UTC (rev 284536)
@@ -27,6 +27,7 @@
 
 #pragma once
 
+#include "IntSize.h"
 #include "MediaQueryExpression.h"
 #include 
 
@@ -55,6 +56,10 @@
 bool isEmpty() const { return viewport.isEmpty() && appearance.isEmpty() && accessibilitySettings.isEmpty(); }
 };
 
+using MediaQueryViewportState = std::tuple;
+
+MediaQueryViewportState mediaQueryViewportStateForDocument(const Document&);
+
 // Some of the constructors are used for cases where the device characteristics are not known.
 // These  can be used to prune the loading of stylesheets to only those which are not already known to not match.
 


Modified: trunk/Source/WebCore/style/StyleScope.cpp (284535 => 284536)

--- trunk/Source/WebCore/style/StyleScope.cpp	2021-10-20 15:24:03 UTC (rev 284535)
+++ trunk/Source/WebCore/style/StyleScope.cpp	2021-10-20 15:25:44 UTC (rev 284536)
@@ -655,6 +655,13 @@
 
 void Scope::evaluateMediaQueriesForViewportChange()
 {
+auto viewportState = mediaQueryViewportStateForDocument(m_document);
+
+if (m_viewportStateOnPreviousMediaQueryEvaluation && *m_viewportStateOnPreviousMediaQueryEvaluation == viewportState)
+return;
+// This doesn't need to be invalidated as any changes to the rules will compute their media queries to correct values.
+m_viewportStateOnPreviousMediaQueryEvaluation = viewportState;
+
 evaluateMediaQueries([] (Resolver& resolver) {
 return resolver.evaluateDynamicMediaQueries();
 });


Modified: trunk/Source/WebCore/style/StyleScope.h (284535 => 284536)

--- trunk/Source/WebCore/style/StyleScope.h	2021-10-20 15:24:03 UTC (rev 284535)
+++

[webkit-changes] [284535] trunk/Source/WebCore

2021-10-20 Thread ysuzuki

Title: [284535] trunk/Source/WebCore








Revision 284535
Author ysuz...@apple.com
Date 2021-10-20 08:24:03 -0700 (Wed, 20 Oct 2021)


Log Message
AudioArray should ensure 32byte alignment
https://bugs.webkit.org/show_bug.cgi?id=232011

Reviewed by Eric Carlson.

When enabling libpas on x86[1], we observed occasional test failure in webaudio/AudioNode/tail-processing.html test.
We found that while the input & kernel has the exact same values, vDSP_conv in WebAudio DirectConvolver.cpp generates
slightly different outputs (like a error)! This is because vDSP_conv is switching underlying implementation based on
input & kernel alignments: AVX2 implementation requires 32byte alignment while SSE implementation requires 16byte alignment.
And unfortunately, these implementation has very slightly different results.

Previously we are setting 16byte alignment in bmalloc in AudioArray. But luckily, in many cases, it was getting 32byte
alignment. So we are always taking AVX2 implementation and the result can be identical if the input is the same.
However, by switching to libpas, AudioArray can get 16byte aligned (but 32byte aligned) memory actually, and in that
case, we use different implementation in vDSP_conv. So the result now depends on what alignment the allocated AudioArray gets.
The test is running the same kernel to the same input independently, and comparing the outputs. It should be identical,
however, if one gets 16byte aligned array while the other gets 32byte aligned array, then the result will be different,
which is the observed failure.

We use 32byte alignment, which is our vectorized math's maximum alignment requirement to ensure the result is deterministic
and not depending on the allocated array's alignment.

[1]: https://bugs.webkit.org/show_bug.cgi?id=231815

* platform/audio/AudioArray.h:
(WebCore::AudioArray::resize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/AudioArray.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (284534 => 284535)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 15:20:20 UTC (rev 284534)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 15:24:03 UTC (rev 284535)
@@ -1,3 +1,32 @@
+2021-10-20  Yusuke Suzuki  
+
+AudioArray should ensure 32byte alignment
+https://bugs.webkit.org/show_bug.cgi?id=232011
+
+Reviewed by Eric Carlson.
+
+When enabling libpas on x86[1], we observed occasional test failure in webaudio/AudioNode/tail-processing.html test.
+We found that while the input & kernel has the exact same values, vDSP_conv in WebAudio DirectConvolver.cpp generates
+slightly different outputs (like a error)! This is because vDSP_conv is switching underlying implementation based on
+input & kernel alignments: AVX2 implementation requires 32byte alignment while SSE implementation requires 16byte alignment.
+And unfortunately, these implementation has very slightly different results.
+
+Previously we are setting 16byte alignment in bmalloc in AudioArray. But luckily, in many cases, it was getting 32byte
+alignment. So we are always taking AVX2 implementation and the result can be identical if the input is the same.
+However, by switching to libpas, AudioArray can get 16byte aligned (but 32byte aligned) memory actually, and in that
+case, we use different implementation in vDSP_conv. So the result now depends on what alignment the allocated AudioArray gets.
+The test is running the same kernel to the same input independently, and comparing the outputs. It should be identical,
+however, if one gets 16byte aligned array while the other gets 32byte aligned array, then the result will be different,
+which is the observed failure.
+
+We use 32byte alignment, which is our vectorized math's maximum alignment requirement to ensure the result is deterministic
+and not depending on the allocated array's alignment.
+
+[1]: https://bugs.webkit.org/show_bug.cgi?id=231815
+
+* platform/audio/AudioArray.h:
+(WebCore::AudioArray::resize):
+
 2021-10-20  Simon Fraser  
 
 Make ScrollingStateTreeAsTextBehavior an enum class for use with OptionSet<>


Modified: trunk/Source/WebCore/platform/audio/AudioArray.h (284534 => 284535)

--- trunk/Source/WebCore/platform/audio/AudioArray.h	2021-10-20 15:20:20 UTC (rev 284534)
+++ trunk/Source/WebCore/platform/audio/AudioArray.h	2021-10-20 15:24:03 UTC (rev 284535)
@@ -58,7 +58,10 @@
 return;
 
 Checked initialSize = sizeof(T) * n;
-const size_t alignment = 16;
+// Accelerate.framework behaves differently based on input vector alignment. And each implementation
+// has very small difference in output! We ensure 32byte alignment so that we will always take the most
+// optimized implementation if possible, which makes the result deterministic.
+constexpr size_t alignment = 32;

[webkit-changes] [284534] trunk/Source/WebCore

2021-10-20 Thread simon . fraser

Title: [284534] trunk/Source/WebCore








Revision 284534
Author simon.fra...@apple.com
Date 2021-10-20 08:20:20 -0700 (Wed, 20 Oct 2021)


Log Message
Make ScrollingStateTreeAsTextBehavior an enum class for use with OptionSet<>
https://bugs.webkit.org/show_bug.cgi?id=232002

Reviewed by Alan Bujtas.

Make ScrollingStateTreeAsTextBehavior an enum class, and replace ScrollingStateTreeAsTextBehavior
with OptionSet.

* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText const):
(WebCore::AsyncScrollingCoordinator::scrollingTreeAsText const):
* page/scrolling/AsyncScrollingCoordinator.h:
(WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText):
(WebCore::AsyncScrollingCoordinator::scrollingTreeAsText):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollingStateTreeAsText const):
(WebCore::ScrollingCoordinator::scrollingTreeAsText const):
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::scrollingStateTreeAsText):
(WebCore::ScrollingCoordinator::scrollingTreeAsText):
* page/scrolling/ScrollingCoordinatorTypes.h:
* page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::dumpProperties const):
* page/scrolling/ScrollingStateFixedNode.h:
* page/scrolling/ScrollingStateFrameHostingNode.cpp:
(WebCore::ScrollingStateFrameHostingNode::dumpProperties const):
* page/scrolling/ScrollingStateFrameHostingNode.h:
* page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties const):
* page/scrolling/ScrollingStateFrameScrollingNode.h:
* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::dumpProperties const):
(WebCore::ScrollingStateNode::dump const):
(WebCore::ScrollingStateNode::scrollingStateTreeAsText const):
* page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::scrollingStateTreeAsText):
* page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp:
(WebCore::ScrollingStateOverflowScrollProxyNode::dumpProperties const):
* page/scrolling/ScrollingStateOverflowScrollProxyNode.h:
* page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
(WebCore::ScrollingStateOverflowScrollingNode::dumpProperties const):
* page/scrolling/ScrollingStateOverflowScrollingNode.h:
* page/scrolling/ScrollingStatePositionedNode.cpp:
(WebCore::ScrollingStatePositionedNode::dumpProperties const):
* page/scrolling/ScrollingStatePositionedNode.h:
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::dumpProperties const):
* page/scrolling/ScrollingStateScrollingNode.h:
* page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::dumpProperties const):
* page/scrolling/ScrollingStateStickyNode.h:
* page/scrolling/ScrollingStateTree.cpp:
(showScrollingStateTree):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitTreeState):
(WebCore::ScrollingTree::scrollingTreeAsText):
* page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::scrollingTreeAsText):
* page/scrolling/ScrollingTreeFrameHostingNode.cpp:
(WebCore::ScrollingTreeFrameHostingNode::dumpProperties const):
* page/scrolling/ScrollingTreeFrameHostingNode.h:
* page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
(WebCore::ScrollingTreeFrameScrollingNode::dumpProperties const):
* page/scrolling/ScrollingTreeFrameScrollingNode.h:
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::dumpProperties const):
(WebCore::ScrollingTreeNode::dump const):
* page/scrolling/ScrollingTreeNode.h:
* page/scrolling/ScrollingTreeOverflowScrollingNode.cpp:
(WebCore::ScrollingTreeOverflowScrollingNode::dumpProperties const):
* page/scrolling/ScrollingTreeOverflowScrollingNode.h:
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::dumpProperties const):
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/cocoa/ScrollingTreeFixedNode.h:
* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::dumpProperties const):
* page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h:
* page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.mm:
(WebCore::ScrollingTreeOverflowScrollProxyNode::dumpProperties const):
* page/scrolling/cocoa/ScrollingTreePositionedNode.h:
* page/scrolling/cocoa/ScrollingTreePositionedNode.mm:
(WebCore::ScrollingTreePositionedNode::dumpProperties const):
* page/scrolling/cocoa/ScrollingTreeStickyNode.h:
* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::dumpProperties const):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeStateIfNeeded):
* page/scrolling/nicosia/ScrollingTreeFixedNode.cpp:
(WebCore::ScrollingTreeFixedNode::dumpProperties const):
* page/scrolling/nicosia/ScrollingTreeFixedNode.h:
* page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.cpp:
(WebCore::ScrollingTreeOverflowScrollProxyNode::dumpProperties const):
*

[webkit-changes] [284533] trunk

2021-10-20 Thread commit-queue

Title: [284533] trunk








Revision 284533
Author commit-qu...@webkit.org
Date 2021-10-20 08:04:26 -0700 (Wed, 20 Oct 2021)


Log Message
Do not use strerror()
https://bugs.webkit.org/show_bug.cgi?id=231913

Patch by Michael Catanzaro  on 2021-10-20
Reviewed by Chris Dumez.

Source/bmalloc:

* libpas/src/libpas/pas_page_malloc.c:
(pas_page_malloc_commit):

Source/_javascript_Core:

* API/JSScript.mm:
(-[JSScript writeCache:]):
* API/tests/testapi.mm:
(resolvePathToScripts):
* jsc.cpp:
* runtime/BytecodeCacheError.cpp:
(JSC::BytecodeCacheError::StandardError::message const):
* tools/FunctionAllowlist.cpp:
(JSC::FunctionAllowlist::FunctionAllowlist):
* tools/FunctionOverrides.cpp:
(JSC::FunctionOverrides::parseOverridesInFile):
* wasm/WasmMemory.cpp:
(JSC::Wasm::MemoryHandle::~MemoryHandle):
(JSC::Wasm::Memory::tryCreate):
(JSC::Wasm::Memory::growShared):
(JSC::Wasm::Memory::grow):

Source/WebKit:

* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::readyReadHandler):
(IPC::Connection::sendOutputMessage):
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::allocate):
* Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::setAndSerializeSandboxParameters):
(WebKit::sandboxDataVaultParentDirectory):
(WebKit::ensureSandboxCacheDirectory):
(WebKit::tryApplyCachedSandbox):
(WebKit::applySandbox):

Source/WTF:

Add a new safeStrerror function that we can use without worrying about thread safety.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/SafeStrerror.cpp: Added.
(WTF::safeStrerror):
* wtf/SafeStrerror.h: Added.
* wtf/linux/RealTimeThreads.cpp:
(WTF::RealTimeThreads::promoteThreadToRealTime):
* wtf/playstation/FileSystemPlayStation.cpp:
(WTF::FileSystemImpl::deleteFile):
* wtf/posix/FileSystemPOSIX.cpp:
(WTF::FileSystemImpl::deleteFile):
* wtf/posix/ThreadingPOSIX.cpp:
(WTF::Thread::establishHandle):
* wtf/threads/Signals.cpp:
(WTF::jscSignalHandler):

Tools:

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/Tests/WTF/SafeStrerror.cpp: Added.
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/_javascript_Core/API/JSScript.mm
trunk/Source/_javascript_Core/API/tests/testapi.mm
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/BytecodeCacheError.cpp
trunk/Source/_javascript_Core/tools/FunctionAllowlist.cpp
trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp
trunk/Source/_javascript_Core/wasm/WasmMemory.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WTF/wtf/linux/RealTimeThreads.cpp
trunk/Source/WTF/wtf/playstation/FileSystemPlayStation.cpp
trunk/Source/WTF/wtf/posix/FileSystemPOSIX.cpp
trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp
trunk/Source/WTF/wtf/threads/Signals.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp
trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/CMakeLists.txt


Added Paths

trunk/Source/WTF/wtf/SafeStrerror.cpp
trunk/Source/WTF/wtf/SafeStrerror.h
trunk/Tools/TestWebKitAPI/Tests/WTF/SafeStrerror.cpp




Diff

Modified: trunk/Source/_javascript_Core/API/JSScript.mm (284532 => 284533)

--- trunk/Source/_javascript_Core/API/JSScript.mm	2021-10-20 15:01:41 UTC (rev 284532)
+++ trunk/Source/_javascript_Core/API/JSScript.mm	2021-10-20 15:04:26 UTC (rev 284533)
@@ -40,6 +40,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -304,7 +305,7 @@
 const char* tempFileName = [cachePathString stringByAppendingString:@".tmp"].UTF8String;
 int fd = open(cacheFileName, O_CREAT | O_WRONLY | O_EXLOCK | O_NONBLOCK, 0600);
 if (fd == -1) {
-error = makeString("Could not open or lock the bytecode cache file. It's likely another VM or process is already using it. Error: ", strerror(errno));
+error = makeString("Could not open or lock the bytecode cache file. It's likely another VM or process is already using it. Error: ", safeStrerror(errno).data());
 return NO;
 }
 
@@ -314,7 +315,7 @@
 
 int tempFD = open(tempFileName, O_CREAT | O_RDWR | O_EXLOCK | O_NONBLOCK, 0600);
 if (tempFD == -1) {
-error = makeString("Could not open or lock the bytecode cache temp file. Error: ", strerror(errno));
+error = makeString("Could not open or lock the bytecode cache temp file. Error: ", safeStrerror(errno).data());
 return NO;
 }
 


Modified: trunk/Source/_javascript_Core/API/tests/testapi.mm (284532 => 284533)

--- trunk/Source/_javascript_Core/API/tests/testapi.mm	2021-10-20 15:01:41 UTC (rev 284532)
+++ trunk/Source/_javascript_Core/API/tests/testapi.mm	2021-10-20 15:04:26 UTC (rev 284533)
@@ -39,6 +39,7 @@
 #import "JSWrapperMapTests.h"
 #import "Regress141275.h"
 #import "Regress141809.h"
+#import 
 #import 
 
 
@@

[webkit-changes] [284532] trunk

2021-10-20 Thread commit-queue

Title: [284532] trunk








Revision 284532
Author commit-qu...@webkit.org
Date 2021-10-20 08:01:41 -0700 (Wed, 20 Oct 2021)


Log Message
Source/WebKit:
[WebAuthn] Obtain consent to create new credential when platform authenticator in excludedCredentials
https://bugs.webkit.org/show_bug.cgi?id=219813


Patch by John Pascoe  on 2021-10-20
Reviewed by Brent Fulgham.

Currently, whenever the platform authenticator is within excludedCredentials during makeCredential we
always return NotAllowedError and merely flash a consent screen. This does not match the spec per Step 3.1
of makeCredential (https://w3c.github.io/webauthn/#sctn-op-make-cred). Instead, we should always obtain consent
and return a different error depending on consent was obtained.

A fixme to add this was inadvertently removed in https://bugs.webkit.org/attachment.cgi?id=393180=""

Added api test TestWebKitAPI.WebAuthenticationPanel.LADuplicateCredentialWithConsent

* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::makeCredential):

Tools:
[WebAuthn] Obtain consent to create new credential when platform authenticator in excludedCredentials
https://bugs.webkit.org/show_bug.cgi?id=219813


Patch by John Pascoe  on 2021-10-20
Reviewed by Brent Fulgham.

Currently, whenever the platform authenticator is within excludedCredentials during makeCredential we
always return NotAllowedError and merely flash a consent screen. This does not match the spec per Step 3.1
of makeCredential (https://w3c.github.io/webauthn/#sctn-op-make-cred). Instead, we should always obtain consent
and return a different error depending on consent was obtained.

This adds a test to confirm a different path is taken whenever consent is obtained.

* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):

LayoutTests:
WebAuthn] Obtain consent to create new credential when platform authenticator in excludedCredentials
https://bugs.webkit.org/show_bug.cgi?id=219813


Patch by John Pascoe  on 2021-10-20
Reviewed by Brent Fulgham.

Modify layout tests to reflect different exception returned when consent is provided

* http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html:
* http/wpt/webauthn/public-key-credential-create-failure-local.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local.https.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (284531 => 284532)

--- trunk/LayoutTests/ChangeLog	2021-10-20 14:49:25 UTC (rev 284531)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 15:01:41 UTC (rev 284532)
@@ -1,3 +1,16 @@
+2021-10-20  John Pascoe  
+
+WebAuthn] Obtain consent to create new credential when platform authenticator in excludedCredentials
+https://bugs.webkit.org/show_bug.cgi?id=219813
+
+
+Reviewed by Brent Fulgham.
+
+Modify layout tests to reflect different exception returned when consent is provided
+
+* http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html:
+* http/wpt/webauthn/public-key-credential-create-failure-local.https.html:
+
 2021-10-20  Alan Bujtas  
 
 [LFC][IFC] Sometimes "arbitrary mid work break" does not mean "any position"


Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html (284531 => 284532)

--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html	2021-10-20 14:49:25 UTC (rev 284531)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html	2021-10-20 15:01:41 UTC (rev 284532)
@@ -50,7 +50,7 @@
 };
 if (window.testRunner)
 testRunner.addTestKeyToKeychain(privateKeyBase64, testRpId, testUserEntityBundleBase64);
-return promiseRejects(t, "NotAllowedError", navigator.credentials.create(options), "Operation timed out.").then(() => {
+return promiseRejects(t, "InvalidStateError", navigator.credentials.create(options), "At least one credential matches an entry of the excludeCredentials list in the platform attached authenticator.").then(() => {
 if (window.testRunner)
 testRunner.cleanUpKeychain(testRpId, credentialIDBase64);
 });
@@ -84,7 +84,7 @@
 };
 if (window.testRunner)
 testRunner.addTestKeyToKeychain(privateKeyBase64, testRpId, testUserEntityBundleBase64);
-return promiseRejects(t, "NotAllowedError", navigator.credentials.create(options), "Operation timed out.").then(() => {
+return promiseRejects(t, "InvalidStateError",

[webkit-changes] [284531] trunk/Source/JavaScriptCore

2021-10-20 Thread commit-queue

Title: [284531] trunk/Source/_javascript_Core








Revision 284531
Author commit-qu...@webkit.org
Date 2021-10-20 07:49:25 -0700 (Wed, 20 Oct 2021)


Log Message
Suppress a -Wreturn-type warning
https://bugs.webkit.org/show_bug.cgi?id=229681


Unreviewed.

Patch by Michael Catanzaro  on 2021-10-20

* wasm/WasmFormat.h:
(JSC::Wasm::typeToString):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmFormat.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (284530 => 284531)

--- trunk/Source/_javascript_Core/ChangeLog	2021-10-20 13:52:56 UTC (rev 284530)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-20 14:49:25 UTC (rev 284531)
@@ -1,3 +1,14 @@
+2021-10-20  Michael Catanzaro  
+
+Suppress a -Wreturn-type warning
+https://bugs.webkit.org/show_bug.cgi?id=229681
+
+
+Unreviewed.
+
+* wasm/WasmFormat.h:
+(JSC::Wasm::typeToString):
+
 2021-10-19  Tadeu Zagallo  
 
 Address post-landing feedback to wasm exceptions


Modified: trunk/Source/_javascript_Core/wasm/WasmFormat.h (284530 => 284531)

--- trunk/Source/_javascript_Core/wasm/WasmFormat.h	2021-10-20 13:52:56 UTC (rev 284530)
+++ trunk/Source/_javascript_Core/wasm/WasmFormat.h	2021-10-20 14:49:25 UTC (rev 284531)
@@ -90,6 +90,8 @@
 }
 
 #undef TYPE_CASE
+
+RELEASE_ASSERT_NOT_REACHED();
 }
 
 inline bool isSubtype(Type sub, Type parent)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284530] trunk

2021-10-20 Thread zalan

Title: [284530] trunk








Revision 284530
Author za...@apple.com
Date 2021-10-20 06:52:56 -0700 (Wed, 20 Oct 2021)


Log Message
[LFC][IFC] Sometimes "arbitrary mid work break" does not mean "any position"
https://bugs.webkit.org/show_bug.cgi?id=232001

Reviewed by Antti Koivisto.

Source/WebCore:

Add a partial (and oversimplified) (XB/XA) type of line breaking for word-break: break-all.
This is governed by https://unicode.org/reports/tr14/.
We should really implement something similar to Blink's kBreakAllLineBreakClassTable (which is based on WebKit's lineBreakTable).

* layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::midWordBreak):
(WebCore::Layout::InlineContentBreaker::tryBreakingTextRun const):

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (284529 => 284530)

--- trunk/LayoutTests/ChangeLog	2021-10-20 13:34:05 UTC (rev 284529)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 13:52:56 UTC (rev 284530)
@@ -1,3 +1,12 @@
+2021-10-20  Alan Bujtas  
+
+[LFC][IFC] Sometimes "arbitrary mid work break" does not mean "any position"
+https://bugs.webkit.org/show_bug.cgi?id=232001
+
+Reviewed by Antti Koivisto.
+
+* TestExpectations:
+
 2021-10-20  Youenn Fablet  
 
 Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support


Modified: trunk/LayoutTests/TestExpectations (284529 => 284530)

--- trunk/LayoutTests/TestExpectations	2021-10-20 13:34:05 UTC (rev 284529)
+++ trunk/LayoutTests/TestExpectations	2021-10-20 13:52:56 UTC (rev 284530)
@@ -2626,15 +2626,8 @@
 webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-003.html [ ImageOnlyFailure ]
 webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-002.html [ ImageOnlyFailure ]
 
-webkit.org/b/197409 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-016.html [ ImageOnlyFailure ]
-webkit.org/b/197409 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-019.html [ ImageOnlyFailure ]
-webkit.org/b/197411 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-018.html [ ImageOnlyFailure ]
-webkit.org/b/197411 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-021.html [ ImageOnlyFailure ]
-webkit.org/b/197411 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-022.html [ ImageOnlyFailure ]
 webkit.org/b/197430 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-023.html [ ImageOnlyFailure ]
 webkit.org/b/197430 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html [ ImageOnlyFailure ]
-webkit.org/b/197430 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-026.html [ ImageOnlyFailure ]
-webkit.org/b/197430 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-027.html [ ImageOnlyFailure ]
 
 
 ### START OF display: contents failures


Modified: trunk/Source/WebCore/ChangeLog (284529 => 284530)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 13:34:05 UTC (rev 284529)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 13:52:56 UTC (rev 284530)
@@ -1,3 +1,18 @@
+2021-10-20  Alan Bujtas  
+
+[LFC][IFC] Sometimes "arbitrary mid work break" does not mean "any position"
+https://bugs.webkit.org/show_bug.cgi?id=232001
+
+Reviewed by Antti Koivisto.
+
+Add a partial (and oversimplified) (XB/XA) type of line breaking for word-break: break-all.
+This is governed by https://unicode.org/reports/tr14/.
+We should really implement something similar to Blink's kBreakAllLineBreakClassTable (which is based on WebKit's lineBreakTable).
+
+* layout/formattingContexts/inline/InlineContentBreaker.cpp:
+(WebCore::Layout::midWordBreak):
+(WebCore::Layout::InlineContentBreaker::tryBreakingTextRun const):
+
 2021-10-20  Carlos Garcia Campos  
 
 AX: Build with isolated tree enable is broken since r284075


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp (284529 => 284530)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp	2021-10-20 13:34:05 UTC (rev 284529)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp	2021-10-20 13:52:56 UTC (rev 284530)
@@ -297,6 +297,46 @@
 return TextUtil::isWrappingAllowed(run.style);
 }
 
+static TextUtil::MidWordBreak midWordBreak(const InlineContentBreaker::ContinuousContent::Run& textRun, InlineLayoutUnit runLogicalLeft, InlineLayoutUnit availableWidth)
+{
+auto& inlineTextItem =

[webkit-changes] [284529] trunk/Source/WebCore

2021-10-20 Thread carlosgc

Title: [284529] trunk/Source/WebCore








Revision 284529
Author carlo...@webkit.org
Date 2021-10-20 06:34:05 -0700 (Wed, 20 Oct 2021)


Log Message
AX: Build with isolated tree enable is broken since r284075
https://bugs.webkit.org/show_bug.cgi?id=231667


Reviewed by Andres Gonzalez.

The problem seems to be that AXPropertyValueVariant contains the same type twice (in 64 bit systems) AXID
(size_t -> long unsigned int) and uint64_t -> long unsigned int. That's actually allowed but makes the access
ambiguous. Since uint64_t is only used for SessionID, we can explicitly use SessionID instead.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sessionID const):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityObjectInterface.h:
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::sessionID const):
(WebCore::AXIsolatedObject::sessionIDAttributeValue const):
* accessibility/isolatedtree/AXIsolatedObject.h:
* accessibility/isolatedtree/AXIsolatedTree.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (284528 => 284529)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 13:26:22 UTC (rev 284528)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 13:34:05 UTC (rev 284529)
@@ -1,3 +1,28 @@
+2021-10-20  Carlos Garcia Campos  
+
+AX: Build with isolated tree enable is broken since r284075
+https://bugs.webkit.org/show_bug.cgi?id=231667
+
+
+Reviewed by Andres Gonzalez.
+
+The problem seems to be that AXPropertyValueVariant contains the same type twice (in 64 bit systems) AXID
+(size_t -> long unsigned int) and uint64_t -> long unsigned int. That's actually allowed but makes the access
+ambiguous. Since uint64_t is only used for SessionID, we can explicitly use SessionID instead.
+
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::sessionID const):
+* accessibility/AccessibilityObject.h:
+* accessibility/AccessibilityObjectInterface.h:
+* accessibility/isolatedtree/AXIsolatedObject.cpp:
+(WebCore::AXIsolatedObject::initializeAttributeData):
+(WebCore::AXIsolatedObject::sessionID const):
+(WebCore::AXIsolatedObject::sessionIDAttributeValue const):
+* accessibility/isolatedtree/AXIsolatedObject.h:
+* accessibility/isolatedtree/AXIsolatedTree.h:
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
 2021-10-20  Youenn Fablet  
 
 Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support


Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (284528 => 284529)

--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp	2021-10-20 13:26:22 UTC (rev 284528)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp	2021-10-20 13:34:05 UTC (rev 284529)
@@ -84,6 +84,7 @@
 #include "TextIterator.h"
 #include "UserGestureIndicator.h"
 #include "VisibleUnits.h"
+#include 
 #include 
 #include 
 #include 
@@ -3469,13 +3470,13 @@
 return String();
 }
 
-uint64_t AccessibilityObject::sessionID() const
+PAL::SessionID AccessibilityObject::sessionID() const
 {
 if (auto* document = topDocument()) {
 if (auto* page = document->page())
-return page->sessionID().toUInt64();
+return page->sessionID();
 }
-return 0;
+return PAL::SessionID(PAL::SessionID::SessionConstants::HashTableEmptyValueID);
 }
 
 String AccessibilityObject::tagName() const


Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (284528 => 284529)

--- trunk/Source/WebCore/accessibility/AccessibilityObject.h	2021-10-20 13:26:22 UTC (rev 284528)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h	2021-10-20 13:34:05 UTC (rev 284529)
@@ -761,7 +761,7 @@
 void clearIsIgnoredFromParentData() override { m_isIgnoredFromParentData = { }; }
 void setIsIgnoredFromParentDataForChild(AXCoreObject*) override;
 
-uint64_t sessionID() const override;
+PAL::SessionID sessionID() const override;
 String documentURI() const override;
 String documentEncoding() const override;
 AccessibilityChildrenVector documentLinks() override { return

[webkit-changes] [284528] trunk

2021-10-20 Thread youenn

Title: [284528] trunk








Revision 284528
Author you...@apple.com
Date 2021-10-20 06:26:22 -0700 (Wed, 20 Oct 2021)


Log Message
Add support for requestVideoFrameCallback API and MediaStreamTrack-based backend support
https://bugs.webkit.org/show_bug.cgi?id=231803

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* resources/import-expectations.json:
* web-platform-tests/video-rvfc/META.yml: Added.
* web-platform-tests/video-rvfc/README.md: Added.
* web-platform-tests/video-rvfc/idlharness.window-expected.txt: Added.
* web-platform-tests/video-rvfc/idlharness.window.html: Added.
* web-platform-tests/video-rvfc/idlharness.window.js: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-before-xr-session.https-expected.txt: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-before-xr-session.https.html: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-dom-expected.txt: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-dom.html: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-during-xr-session.https-expected.txt: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-during-xr-session.https.html: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-expected.txt: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-parallel-expected.txt: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-parallel.html: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-repeating-expected.txt: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-repeating.html: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-webrtc.https-expected.txt: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback-webrtc.https.html: Added.
* web-platform-tests/video-rvfc/request-video-frame-callback.html: Added.
* web-platform-tests/video-rvfc/w3c-import.log: Added.

Source/WebCore:

Update WebIDL to expose https://wicg.github.io/video-rvfc/ API.
Put them behind a runtime flag.

Add support for the algorithms, including the integration with the 'update the rendering' algorithm.
Add initial support for video elements backed by MediaStream content.
We expose a limited set of metadata currently, follow-up patches should add support for other video backends and more metadata.
This support should still enable to optimize a bit MediaStreamTrack -> canvas pipelines.

Tests: fast/mediastream/getUserMedia-rvfc.html
   imported/w3c/web-platform-tests/video-rvfc/idlharness.window.html
   imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-before-xr-session.https.html
   imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-dom.html
   imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-during-xr-session.https.html
   imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-parallel.html
   imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-repeating.html
   imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-webrtc.https.html
   imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback.html
   webrtc/peerConnection-rvfc.html

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Headers.cmake:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
* dom/Document.h:
* html/HTMLMediaElement.h:
* html/HTMLVideoElement+RequestVideoFrameCallback.idl: Added.
* html/HTMLVideoElement.cpp:
* html/HTMLVideoElement.h:
* html/VideoFrameMetadata.idl: Added.
* html/VideoFrameRequestCallback.h: Added.
* html/VideoFrameRequestCallback.idl: Added.
* page/Page.cpp:
* page/Page.h:
* platform/VideoFrameMetadata.h: Added.
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

Source/WebKit:

Add temporary getter/setter of rvfc feature flag.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetRequestVideoFrameCallbackEnabled):
(WKPreferencesGetRequestVideoFrameCallbackEnabled):
* UIProcess/API/C/WKPreferencesRef.h:

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

Disable rvfc on tests by default until we implement rvfc for usual video streaming.
WebRTC tests enable rvfc themselves.

* DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

* TestExpectations:
* fast/mediastream/getUserMedia-rvfc-expected.txt: Added.
* fast/mediastream/getUserMedia-rvfc.html: Added.
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
*

[webkit-changes] [284527] trunk

2021-10-20 Thread carlosgc

Title: [284527] trunk








Revision 284527
Author carlo...@webkit.org
Date 2021-10-20 06:14:23 -0700 (Wed, 20 Oct 2021)


Log Message
[WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
https://bugs.webkit.org/show_bug.cgi?id=222860

Reviewed by Don Olmstead.

.:

* Source/cmake/OptionsWPE.cmake:

Source/bmalloc:

* bmalloc/AvailableMemory.h: Export memoryStatus.

Source/WebKit:

* PlatformWPE.cmake:

Tools:

* TestRunnerShared/CMakeLists.txt:
* TestWebKitAPI/PlatformWPE.cmake:
* TestWebKitAPI/glib/CMakeLists.txt:
* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/PlatformWPE.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/AvailableMemory.h
trunk/Source/cmake/OptionsWPE.cmake
trunk/Tools/ChangeLog
trunk/Tools/TestRunnerShared/CMakeLists.txt
trunk/Tools/TestWebKitAPI/PlatformWPE.cmake
trunk/Tools/TestWebKitAPI/glib/CMakeLists.txt
trunk/Tools/WebKitTestRunner/CMakeLists.txt
trunk/Tools/WebKitTestRunner/PlatformGTK.cmake
trunk/Tools/WebKitTestRunner/PlatformWPE.cmake
trunk/Tools/WebKitTestRunner/PlatformWin.cmake




Diff

Modified: trunk/ChangeLog (284526 => 284527)

--- trunk/ChangeLog	2021-10-20 10:18:22 UTC (rev 284526)
+++ trunk/ChangeLog	2021-10-20 13:14:23 UTC (rev 284527)
@@ -1,3 +1,12 @@
+2021-10-20  Carlos Garcia Campos  
+
+[WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
+https://bugs.webkit.org/show_bug.cgi?id=222860
+
+Reviewed by Don Olmstead.
+
+* Source/cmake/OptionsWPE.cmake:
+
 2021-10-19  Ross Kirsling  
 
 [CMake] Align OptionsMac with Xcode build


Modified: trunk/Source/WebKit/ChangeLog (284526 => 284527)

--- trunk/Source/WebKit/ChangeLog	2021-10-20 10:18:22 UTC (rev 284526)
+++ trunk/Source/WebKit/ChangeLog	2021-10-20 13:14:23 UTC (rev 284527)
@@ -1,5 +1,14 @@
 2021-10-20  Carlos Garcia Campos  
 
+[WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
+https://bugs.webkit.org/show_bug.cgi?id=222860
+
+Reviewed by Don Olmstead.
+
+* PlatformWPE.cmake:
+
+2021-10-20  Carlos Garcia Campos  
+
 [GTK][WPE] UserInteractive threads are not Real-time in Linux
 https://bugs.webkit.org/show_bug.cgi?id=220115
 


Modified: trunk/Source/WebKit/PlatformWPE.cmake (284526 => 284527)

--- trunk/Source/WebKit/PlatformWPE.cmake	2021-10-20 10:18:22 UTC (rev 284526)
+++ trunk/Source/WebKit/PlatformWPE.cmake	2021-10-20 13:14:23 UTC (rev 284527)
@@ -448,6 +448,7 @@
 
 set(qtwpe_INCLUDE_DIRECTORIES
 $
+${_javascript_CoreGLib_FRAMEWORK_HEADERS_DIR}
 ${CMAKE_BINARY_DIR}
 ${GLIB_INCLUDE_DIRS}
 ${Qt5_INCLUDE_DIRS}


Modified: trunk/Source/bmalloc/ChangeLog (284526 => 284527)

--- trunk/Source/bmalloc/ChangeLog	2021-10-20 10:18:22 UTC (rev 284526)
+++ trunk/Source/bmalloc/ChangeLog	2021-10-20 13:14:23 UTC (rev 284527)
@@ -1,3 +1,12 @@
+2021-10-20  Carlos Garcia Campos  
+
+[WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
+https://bugs.webkit.org/show_bug.cgi?id=222860
+
+Reviewed by Don Olmstead.
+
+* bmalloc/AvailableMemory.h: Export memoryStatus.
+
 2021-10-16  Commit Queue  
 
 Unreviewed, reverting r284305.


Modified: trunk/Source/bmalloc/bmalloc/AvailableMemory.h (284526 => 284527)

--- trunk/Source/bmalloc/bmalloc/AvailableMemory.h	2021-10-20 10:18:22 UTC (rev 284526)
+++ trunk/Source/bmalloc/bmalloc/AvailableMemory.h	2021-10-20 13:14:23 UTC (rev 284527)
@@ -44,7 +44,7 @@
 double percentAvailableMemoryInUse;
 };
 
-MemoryStatus memoryStatus();
+BEXPORT MemoryStatus memoryStatus();
 
 inline size_t memoryFootprint()
 {


Modified: trunk/Source/cmake/OptionsWPE.cmake (284526 => 284527)

--- trunk/Source/cmake/OptionsWPE.cmake	2021-10-20 10:18:22 UTC (rev 284526)
+++ trunk/Source/cmake/OptionsWPE.cmake	2021-10-20 13:14:23 UTC (rev 284527)
@@ -146,6 +146,13 @@
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0)
 endif ()
 
+set(CMAKE_C_VISIBILITY_PRESET hidden)
+set(CMAKE_CXX_VISIBILITY_PRESET hidden)
+set(CMAKE_VISIBILITY_INLINES_HIDDEN ON)
+set(bmalloc_LIBRARY_TYPE OBJECT)
+set(WTF_LIBRARY_TYPE OBJECT)
+set(_javascript_Core_LIBRARY_TYPE OBJECT)
+
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.
 set(LIB_INSTALL_DIR "${CMAKE_INSTALL_FULL_LIBDIR}" CACHE PATH "Absolute path to library installation directory")


Modified: trunk/Tools/ChangeLog (284526 => 284527)

--- trunk/Tools/ChangeLog	2021-10-20 10:18:22 UTC (rev 284526)
+++ trunk/Tools/ChangeLog	2021-10-20 13:14:23 UTC (rev 284527)
@@ -1,3 +1,16 @@
+2021-10-20  Carlos Garcia Campos  
+
+[WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
+https://bugs.webkit.org/show_bug.cgi?id=222860
+
+Reviewed by Don Olmstead.
+
+*

[webkit-changes] [284526] releases/WebKitGTK/webkit-2.34/Source/WebKit

2021-10-20 Thread aperez

Title: [284526] releases/WebKitGTK/webkit-2.34/Source/WebKit








Revision 284526
Author ape...@igalia.com
Date 2021-10-20 03:18:22 -0700 (Wed, 20 Oct 2021)


Log Message
Merge r284521 - REGRESSION(r276635): [GTK] local HTML file is downloaded instead of displayed if any application has ever called g_desktop_app_info_set_as_default_for_extension(info, "html")
https://bugs.webkit.org/show_bug.cgi?id=230797

Patch by Michael Catanzaro  on 2021-10-20
Reviewed by Carlos Garcia Campos.

Let's revert this change. Disabling content sniffing prevents WebKit from distinguishing
between different content types with the same file extension, which is something it needs
to be able to do. In this bug report, it is conflating text/html with
application/x-extension-html, but it could just as well confuse text/html with
application/xhtml+xml, causing rendering issues. I don't think we can remove the content
sniffing.

* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::didGetFileInfo):

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (284525 => 284526)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2021-10-20 08:26:42 UTC (rev 284525)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2021-10-20 10:18:22 UTC (rev 284526)
@@ -1,3 +1,20 @@
+2021-10-20  Michael Catanzaro  
+
+REGRESSION(r276635): [GTK] local HTML file is downloaded instead of displayed if any application has ever called g_desktop_app_info_set_as_default_for_extension(info, "html")
+https://bugs.webkit.org/show_bug.cgi?id=230797
+
+Reviewed by Carlos Garcia Campos.
+
+Let's revert this change. Disabling content sniffing prevents WebKit from distinguishing
+between different content types with the same file extension, which is something it needs
+to be able to do. In this bug report, it is conflating text/html with
+application/x-extension-html, but it could just as well confuse text/html with
+application/xhtml+xml, causing rendering issues. I don't think we can remove the content
+sniffing.
+
+* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
+(WebKit::NetworkDataTaskSoup::didGetFileInfo):
+
 2021-10-13  Adrian Perez de Castro  
 
 [GTK] Opening emoji chooser crashes UI process with GTK 3.24.30


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp (284525 => 284526)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp	2021-10-20 08:26:42 UTC (rev 284525)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp	2021-10-20 10:18:22 UTC (rev 284526)
@@ -1676,12 +1676,11 @@
 m_response.setMimeType("text/html");
 m_response.setExpectedContentLength(-1);
 } else {
-// Guess mime-type from URL path and fall-back to mime-type detected by Gio/shared-mime-info otherwise.
-auto mimeType = MIMETypeRegistry::mimeTypeForPath(m_response.url().path().toString());
-if (mimeType == defaultMIMEType())
-mimeType = extractMIMETypeFromMediaType(g_file_info_get_content_type(info));
-
-m_response.setMimeType(mimeType);
+const gchar* contentType = g_file_info_get_content_type(info);
+m_response.setMimeType(extractMIMETypeFromMediaType(contentType));
+m_response.setTextEncodingName(extractCharsetFromMediaType(contentType));
+if (m_response.mimeType().isEmpty())
+m_response.setMimeType(MIMETypeRegistry::mimeTypeForPath(m_response.url().path().toString()));
 m_response.setExpectedContentLength(g_file_info_get_size(info));
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284525] trunk/Source

2021-10-20 Thread carlosgc

Title: [284525] trunk/Source








Revision 284525
Author carlo...@webkit.org
Date 2021-10-20 01:26:42 -0700 (Wed, 20 Oct 2021)


Log Message
[GTK][WPE] UserInteractive threads are not Real-time in Linux
https://bugs.webkit.org/show_bug.cgi?id=220115

Reviewed by Michael Catanzaro.

Source/WebKit:

Enable real time threads in the web process only when there's a visible page.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::removeWebPage):
(WebKit::WebProcess::pageActivityStateDidChange):
(WebKit::WebProcess::platformInitializeProcess): Deleted.
* WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeProcess):
* WebProcess/playstation/WebProcessPlayStation.cpp:
(WebKit::WebProcess::platformInitializeProcess):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformInitializeProcess):

Source/WTF:

Add RealTimeThreads singleton to register real time threads.

* wtf/PlatformGTK.cmake:
* wtf/PlatformJSCOnly.cmake:
* wtf/PlatformWPE.cmake:
* wtf/Threading.cpp:
(WTF::Thread::setCurrentThreadIsUserInteractive):
* wtf/generic/WorkQueueGeneric.cpp:
(WTF::WorkQueueBase::platformInitialize):
* wtf/linux/RealTimeThreads.cpp: Added.
(WTF::RealTimeThreads::singleton):
(WTF::RealTimeThreads::RealTimeThreads):
(WTF::RealTimeThreads::registerThread):
(WTF::RealTimeThreads::setEnabled):
(WTF::RealTimeThreads::promoteThreadToRealTime):
(WTF::RealTimeThreads::demoteThreadFromRealTime):
(WTF::RealTimeThreads::demoteAllThreadsFromRealTime):
(WTF::isRunningInSandbox):
(WTF::realTimeKitGetProperty):
(WTF::RealTimeThreads::realTimeKitMakeThreadRealTime):
(WTF::RealTimeThreads::scheduleDiscardRealTimeKitProxy):
(WTF::RealTimeThreads::discardRealTimeKitProxyTimerFired):
* wtf/linux/RealTimeThreads.h: Added.
* wtf/posix/ThreadingPOSIX.cpp:
(WTF::schedPolicy):
(WTF::Thread::establishHandle):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformGTK.cmake
trunk/Source/WTF/wtf/PlatformJSCOnly.cmake
trunk/Source/WTF/wtf/PlatformWPE.cmake
trunk/Source/WTF/wtf/Threading.cpp
trunk/Source/WTF/wtf/generic/WorkQueueGeneric.cpp
trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp
trunk/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp
trunk/Source/WebKit/WebProcess/win/WebProcessWin.cpp


Added Paths

trunk/Source/WTF/wtf/linux/RealTimeThreads.cpp
trunk/Source/WTF/wtf/linux/RealTimeThreads.h




Diff

Modified: trunk/Source/WTF/ChangeLog (284524 => 284525)

--- trunk/Source/WTF/ChangeLog	2021-10-20 08:24:27 UTC (rev 284524)
+++ trunk/Source/WTF/ChangeLog	2021-10-20 08:26:42 UTC (rev 284525)
@@ -1,3 +1,37 @@
+2021-10-20  Carlos Garcia Campos  
+
+[GTK][WPE] UserInteractive threads are not Real-time in Linux
+https://bugs.webkit.org/show_bug.cgi?id=220115
+
+Reviewed by Michael Catanzaro.
+
+Add RealTimeThreads singleton to register real time threads.
+
+* wtf/PlatformGTK.cmake:
+* wtf/PlatformJSCOnly.cmake:
+* wtf/PlatformWPE.cmake:
+* wtf/Threading.cpp:
+(WTF::Thread::setCurrentThreadIsUserInteractive):
+* wtf/generic/WorkQueueGeneric.cpp:
+(WTF::WorkQueueBase::platformInitialize):
+* wtf/linux/RealTimeThreads.cpp: Added.
+(WTF::RealTimeThreads::singleton):
+(WTF::RealTimeThreads::RealTimeThreads):
+(WTF::RealTimeThreads::registerThread):
+(WTF::RealTimeThreads::setEnabled):
+(WTF::RealTimeThreads::promoteThreadToRealTime):
+(WTF::RealTimeThreads::demoteThreadFromRealTime):
+(WTF::RealTimeThreads::demoteAllThreadsFromRealTime):
+(WTF::isRunningInSandbox):
+(WTF::realTimeKitGetProperty):
+(WTF::RealTimeThreads::realTimeKitMakeThreadRealTime):
+(WTF::RealTimeThreads::scheduleDiscardRealTimeKitProxy):
+(WTF::RealTimeThreads::discardRealTimeKitProxyTimerFired):
+* wtf/linux/RealTimeThreads.h: Added.
+* wtf/posix/ThreadingPOSIX.cpp:
+(WTF::schedPolicy):
+(WTF::Thread::establishHandle):
+
 2021-10-19  Yusuke Suzuki  
 
 Remove old GCC workaround for Allocator


Modified: trunk/Source/WTF/wtf/PlatformGTK.cmake (284524 => 284525)

--- trunk/Source/WTF/wtf/PlatformGTK.cmake	2021-10-20 08:24:27 UTC (rev 284524)
+++ trunk/Source/WTF/wtf/PlatformGTK.cmake	2021-10-20 08:26:42 UTC (rev 284525)
@@ -11,6 +11,8 @@
 glib/Sandbox.h
 glib/SocketConnection.h
 glib/WTFGType.h
+
+linux/RealTimeThreads.h
 )
 
 if (CMAKE_SYSTEM_NAME MATCHES "Linux")
@@ -52,6 +54,7 @@
 list(APPEND WTF_SOURCES
 linux/CurrentProcessMemoryStatus.cpp
 linux/MemoryFootprintLinux.cpp
+linux/RealTimeThreads.cpp
 
 unix/MemoryPressureHandlerUnix.cpp
 )


Modified: trunk/Source/WTF/wtf/PlatformJSCOnly.cmake (284524 => 284525)

--- trunk/Source/WTF/wtf/PlatformJSCOnly.cmake	2021-10-20

[webkit-changes] [284524] trunk/Source/WebCore

2021-10-20 Thread carlosgc

Title: [284524] trunk/Source/WebCore








Revision 284524
Author carlo...@webkit.org
Date 2021-10-20 01:24:27 -0700 (Wed, 20 Oct 2021)


Log Message
AX: Make indexForVisiblePosition consistent with visiblePositionForIndex
https://bugs.webkit.org/show_bug.cgi?id=231950

Reviewed by Andres Gonzalez.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition const): Use the same early return checks of
visiblePositionForIndex and remove the requirement of node being the highest editable root.
* editing/Editing.cpp:
(WebCore::indexForVisiblePosition): Return early if given position is null.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/editing/Editing.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (284523 => 284524)

--- trunk/Source/WebCore/ChangeLog	2021-10-20 08:13:27 UTC (rev 284523)
+++ trunk/Source/WebCore/ChangeLog	2021-10-20 08:24:27 UTC (rev 284524)
@@ -1,3 +1,16 @@
+2021-10-20  Carlos Garcia Campos  
+
+AX: Make indexForVisiblePosition consistent with visiblePositionForIndex
+https://bugs.webkit.org/show_bug.cgi?id=231950
+
+Reviewed by Andres Gonzalez.
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::indexForVisiblePosition const): Use the same early return checks of
+visiblePositionForIndex and remove the requirement of node being the highest editable root.
+* editing/Editing.cpp:
+(WebCore::indexForVisiblePosition): Return early if given position is null.
+
 2021-10-20  Youenn Fablet  
 
 WebRTC p2p call, VP9-SVC only low layer decoded on receiver side


Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (284523 => 284524)

--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2021-10-20 08:13:27 UTC (rev 284523)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2021-10-20 08:24:27 UTC (rev 284524)
@@ -2147,20 +2147,19 @@
 
 int AccessibilityRenderObject::indexForVisiblePosition(const VisiblePosition& position) const
 {
+if (!m_renderer)
+return 0;
+
 if (isNativeTextControl())
 return downcast(*m_renderer).textFormControlElement().indexForVisiblePosition(position);
 
-if (!isTextControl())
+if (!allowsTextRanges() && !is(*m_renderer))
 return 0;
-
+
 Node* node = m_renderer->node();
 if (!node)
 return 0;
 
-Position indexPosition = position.deepEquivalent();
-if (indexPosition.isNull() || highestEditableRoot(indexPosition, HasEditableAXRole) != node)
-return 0;
-
 #if USE(ATK)
 // We need to consider replaced elements for GTK, as they will be
 // presented with the 'object replacement character' (0xFFFC).


Modified: trunk/Source/WebCore/editing/Editing.cpp (284523 => 284524)

--- trunk/Source/WebCore/editing/Editing.cpp	2021-10-20 08:13:27 UTC (rev 284523)
+++ trunk/Source/WebCore/editing/Editing.cpp	2021-10-20 08:24:27 UTC (rev 284524)
@@ -996,6 +996,9 @@
 // FIXME: Merge this function with the one above.
 int indexForVisiblePosition(Node& node, const VisiblePosition& visiblePosition, bool forSelectionPreservation)
 {
+if (visiblePosition.isNull())
+return 0;
+
 auto range = makeSimpleRange(makeBoundaryPointBeforeNodeContents(node), visiblePosition);
 TextIteratorBehaviors behaviors;
 if (forSelectionPreservation)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284523] trunk

2021-10-20 Thread youenn

Title: [284523] trunk








Revision 284523
Author you...@apple.com
Date 2021-10-20 01:13:27 -0700 (Wed, 20 Oct 2021)


Log Message
WebRTC p2p call, VP9-SVC only low layer decoded on receiver side
https://bugs.webkit.org/show_bug.cgi?id=231071


Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

In case VP9 SVC is used, fallback to software decoder for now.

* Source/webrtc/sdk/WebKit/WebKitDecoder.mm:

Source/WebCore:

Add Internals API to check whether VP9 VTB is used or not.

Test: webrtc/vp9-svc.html

* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/RTCPeerConnection.cpp:
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
* Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
* Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* webrtc/vp9-svc-expected.txt: Added.
* webrtc/vp9-svc.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Added Paths

trunk/LayoutTests/webrtc/vp9-svc-expected.txt
trunk/LayoutTests/webrtc/vp9-svc.html




Diff

Modified: trunk/LayoutTests/ChangeLog (284522 => 284523)

--- trunk/LayoutTests/ChangeLog	2021-10-20 08:08:55 UTC (rev 284522)
+++ trunk/LayoutTests/ChangeLog	2021-10-20 08:13:27 UTC (rev 284523)
@@ -1,3 +1,14 @@
+2021-10-20  Youenn Fablet  
+
+WebRTC p2p call, VP9-SVC only low layer decoded on receiver side
+https://bugs.webkit.org/show_bug.cgi?id=231071
+
+
+Reviewed by Eric Carlson.
+
+* webrtc/vp9-svc-expected.txt: Added.
+* webrtc/vp9-svc.html: Added.
+
 2021-10-20  John Cunningham  
 
 Avoid null pointer dereference when creating ImageBitmap from a null image.


Added: trunk/LayoutTests/webrtc/vp9-svc-expected.txt (0 => 284523)

--- trunk/LayoutTests/webrtc/vp9-svc-expected.txt	(rev 0)
+++ trunk/LayoutTests/webrtc/vp9-svc-expected.txt	2021-10-20 08:13:27 UTC (rev 284523)
@@ -0,0 +1,5 @@
+
+
+PASS Use VP9 without SVC
+PASS Use VP9 with SVC
+


Added: trunk/LayoutTests/webrtc/vp9-svc.html (0 => 284523)

--- trunk/LayoutTests/webrtc/vp9-svc.html	(rev 0)
+++ trunk/LayoutTests/webrtc/vp9-svc.html	2021-10-20 08:13:27 UTC (rev 284523)
@@ -0,0 +1,85 @@
+
+
+
+
+VP9 SVC in WebRTC
+
+
+
+