[webkit-changes] [285620] trunk

[drousso]

Title: [285620] trunk








Revision 285620
Author drou...@apple.com
Date 2021-11-10 22:12:07 -0800 (Wed, 10 Nov 2021)


Log Message
REGRESSION(r283863): `` with a long `action` do not render correctly
https://bugs.webkit.org/show_bug.cgi?id=232645


Reviewed by Myles C. Maxfield.

Source/WebCore:

Unlike the `DisplayList` concept in WebCore, when using `CGContextDelegateRef` (which is
what `DrawGlyphsRecorder` uses on Cocoa platforms) the callbacks for each action are only
told about the current state of all-the-things at the time of that action, not each of the
corresponding API-level calls that resulted in that final state (e.g. where `DisplayList`
would see separate `scale` and `rotate` calls, `CGContextDelegateRef` would only be able to
get the final calculated CTM). In order for `DrawGlyphsRecorder` to (re)generate WebCore
calls, it needs to have information about the starting state of the `CGContext` before any
actions are performed so it can at least derive some diff/idea of what happened.

This is further complicated by the fact that when drawing text CG separates the state of
all-the-things into two: the CTM and the text matrix. WebKit does not have this separation,
however, so it needs to combine the two into a single CTM, but only when dealing with text.

A new path (`drawNativeText`) was added in r283863 that allows `DrawGlyphsRecorder` to be
used directly with native text-related objects (e.g. `CTLineRef`) instead of objects/data
derived in WebCore. A result of this on Cocoa platforms is that now a single `drawNativeText`
can result in multiple `recordDrawGlyphs` invocations if the `CTLineRef` contains multiple
"groupings" of glyphs to draw (e.g. if a line is truncated with a "..." in the middle then
the three groups will be the remaining text before, the "..." and the remaining text after).

AFAICT before this new path it was never the case that the text matrix had a translate, only
rotate/skew/etc., meaning that when `DrawGlyphsRecorder` needed to convert from the CG's
computed glyph positions back into WebCore's glyph advances it could use the text matrix
since there would be no translation. With this new path, however, if a `drawNativeText` call
results in multiple `recordDrawGlyphs` then there will be a translation in the text matrix
to account for that. As such, we end up double counting the text matrix: once when we
(re)generate the CTM to give to WebCore and _again_ when we (re)compute the WebCore advances.

Since we've already counted the text matrix once, we don't need to do it again. Also, by
this point we've already modified WebCore's CTM, so we only really need to account for the
difference from the original position when we first called `drawNativeText`. As such, we
just need invert what was used to generate CG positions from WebCore advances.

Note that in the name of expediently fixing a regression, this change only considers
horizontal text as `` are never drawn vertically. Fixing vertical text will be
done in a followup .

Test: fast/attachment/attachment-truncated-action.html

* platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:
(WebCore::DrawGlyphsRecorder::recordDrawGlyphs):

* platform/graphics/FontCascade.h:
* platform/graphics/coretext/FontCascadeCoreText.cpp:
(WebCore::fillVectorWithHorizontalGlyphPositions):
(WebCore::fillVectorWithVerticalGlyphPositions):
Add a comment indicating the related nature of these functions with `DrawGlyphsRecorder::recordDrawGlyphs`.
Drive-by: `fillVectorWithHorizontalGlyphPositions` is only called by this class, so don't export it.

LayoutTests:

* fast/attachment/attachment-truncated-action.html: Added.
* fast/attachment/attachment-truncated-action-expected-mismatch.html: Added.

* TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.h
trunk/Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp
trunk/Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp


Added Paths

trunk/LayoutTests/fast/attachment/attachment-truncated-action-expected-mismatch.html
trunk/LayoutTests/fast/attachment/attachment-truncated-action.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285619 => 285620)

--- trunk/LayoutTests/ChangeLog	2021-11-11 05:03:15 UTC (rev 285619)
+++ trunk/LayoutTests/ChangeLog	2021-11-11 06:12:07 UTC (rev 285620)
@@ -1,3 +1,17 @@
+2021-11-10  Devin Rousso  
+
+REGRESSION(r283863): `` with a long `action` do not render correctly
+https://bugs.webkit.org/show_bug.cgi?id=232645
+
+
+Reviewed by Myles C. Maxfield.
+
+* fast/attachment/attachment-truncated-action.html: Added.
+* fast/attachment/attachment-truncated-action-expected-mismatch.html: Added.
+
+* TestExpectations:
+* platform/ios/TestExpectations:
+
 2021-11-10  Said 

[webkit-changes] [285619] trunk

[cdumez]

Title: [285619] trunk








Revision 285619
Author cdu...@apple.com
Date 2021-11-10 21:03:15 -0800 (Wed, 10 Nov 2021)


Log Message
We should not kill all WebContent processes whenever the WebAuthn process crashes
https://bugs.webkit.org/show_bug.cgi?id=232970


Reviewed by Geoff Garen.

Source/WebKit:

We should not kill all WebContent processes whenever the WebAuthn process crashes. This is overly aggressive. We should
instead do like for the network process and have the WebProcess re-initiate the connection to the WebAuthn process when
it's gone.

No new tests, updated existing API test.

* UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp:
(WebKit::WebAuthnProcessProxy::webAuthnProcessCrashed):
Do not terminate all WebProcesses when the WebAuthn process crashes.

* WebProcess/WebAuthentication/WebAuthnProcessConnection.cpp:
(WebKit::WebAuthnProcessConnection::didClose):
Make sure we call WebProcess::webAuthnProcessConnectionClosed() when the WebProcess
loses its connection to the WebAuthn process. This makes sure we clear m_webAuthnProcessConnection
and properly re-initiate a new WebAuthn process connection the next time WebProcess::ensureWebAuthnProcessConnection()
is called.

Tools:

Update API test coverage to reflect behavior change.

* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp
trunk/Source/WebKit/WebProcess/WebAuthentication/WebAuthnProcessConnection.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (285618 => 285619)

--- trunk/Source/WebKit/ChangeLog	2021-11-11 04:31:07 UTC (rev 285618)
+++ trunk/Source/WebKit/ChangeLog	2021-11-11 05:03:15 UTC (rev 285619)
@@ -1,3 +1,28 @@
+2021-11-10  Chris Dumez  
+
+We should not kill all WebContent processes whenever the WebAuthn process crashes
+https://bugs.webkit.org/show_bug.cgi?id=232970
+
+
+Reviewed by Geoff Garen.
+
+We should not kill all WebContent processes whenever the WebAuthn process crashes. This is overly aggressive. We should
+instead do like for the network process and have the WebProcess re-initiate the connection to the WebAuthn process when
+it's gone.
+
+No new tests, updated existing API test.
+
+* UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp:
+(WebKit::WebAuthnProcessProxy::webAuthnProcessCrashed):
+Do not terminate all WebProcesses when the WebAuthn process crashes.
+
+* WebProcess/WebAuthentication/WebAuthnProcessConnection.cpp:
+(WebKit::WebAuthnProcessConnection::didClose):
+Make sure we call WebProcess::webAuthnProcessConnectionClosed() when the WebProcess
+loses its connection to the WebAuthn process. This makes sure we clear m_webAuthnProcessConnection
+and properly re-initiate a new WebAuthn process connection the next time WebProcess::ensureWebAuthnProcessConnection()
+is called.
+
 2021-11-10  J Pascoe  
 
 [WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's ClientDataJson generation 


Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp (285618 => 285619)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp	2021-11-11 04:31:07 UTC (rev 285618)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp	2021-11-11 05:03:15 UTC (rev 285619)
@@ -127,8 +127,6 @@
 
 void WebAuthnProcessProxy::webAuthnProcessCrashed()
 {
-for (auto& processPool : WebProcessPool::allProcessPools())
-processPool->terminateAllWebContentProcesses();
 sharedProcess() = nullptr;
 }
 


Modified: trunk/Source/WebKit/WebProcess/WebAuthentication/WebAuthnProcessConnection.cpp (285618 => 285619)

--- trunk/Source/WebKit/WebProcess/WebAuthentication/WebAuthnProcessConnection.cpp	2021-11-11 04:31:07 UTC (rev 285618)
+++ trunk/Source/WebKit/WebProcess/WebAuthentication/WebAuthnProcessConnection.cpp	2021-11-11 05:03:15 UTC (rev 285619)
@@ -48,6 +48,7 @@
 
 void WebAuthnProcessConnection::didClose(IPC::Connection&)
 {
+WebProcess::singleton().webAuthnProcessConnectionClosed(this);
 }
 
 void WebAuthnProcessConnection::didReceiveInvalidMessage(IPC::Connection&, IPC::MessageName)


Modified: trunk/Tools/ChangeLog (285618 => 285619)

--- trunk/Tools/ChangeLog	2021-11-11 04:31:07 UTC (rev 285618)
+++ trunk/Tools/ChangeLog	2021-11-11 05:03:15 UTC (rev 285619)
@@ -1,3 +1,16 @@
+2021-11-10  Chris Dumez  
+
+We should not kill all WebContent processes whenever the WebAuthn process crashes
+https://bugs.webkit.org/show_bug.cgi?id=232970
+
+
+Reviewed by Geoff Garen.
+
+Update API test coverage to reflect behavior change.
+
+* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
+   

[webkit-changes] [285618] trunk

[said]

Title: [285618] trunk








Revision 285618
Author s...@apple.com
Date 2021-11-10 20:31:07 -0800 (Wed, 10 Nov 2021)


Log Message
[GPU Process] Make CSSFilter be a composite of FilterFunctions
https://bugs.webkit.org/show_bug.cgi?id=232469
rdar://85047148

Reviewed by Simon Fraser.

Source/WebCore:

In this patch, the CSS reference filter is built as an SVGFilter and it
is kept as a FilterFunction in the CSSFilter functions' list. The Filter
associated with the FilterEffects of the referenced filter will be an
SVGFilter instead of the root CSSFilter. This will allow having color
spacing for the referenced filters different from the color spacing of
CSSFilter.

Also this patch makes a single function for building the primitives of
the SVGFilter instead of having two functions.

To allow operating through the SVGFilter as a FilterFunction owned by
CSSFilter, the SVGFilter will have a pointer to its lastEffect.

* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
* platform/graphics/filters/Filter.h:
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::collectEffects): Deleted.
(WebCore::FilterEffect::totalNumberOfEffectInputs const): Deleted.
* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::numberOfEffectInputs const):
(WebCore::FilterEffect::setMaxEffectRect):
(WebCore::FilterEffect::outsets const): Deleted.
* platform/graphics/filters/FilterFunction.h:
(WebCore::FilterFunction::outsets const):
(WebCore::FilterFunction::clearResult):
* rendering/CSSFilter.cpp:
(WebCore::CSSFilter::create):
(WebCore::CSSFilter::CSSFilter):
(WebCore::m_hasFilterThatShouldBeRestrictedBySecurityOrigin):
(WebCore::createBlurEffect):
(WebCore::createBrightnessEffect):
(WebCore::createContrastEffect):
(WebCore::createDropShadowEffect):
(WebCore::createGrayScaleEffect):
(WebCore::createHueRotateEffect):
(WebCore::createInvertEffect):
(WebCore::createOpacityEffect):
(WebCore::createSaturateEffect):
(WebCore::createSepiaEffect):
(WebCore::createSVGFilter):
(WebCore::setupLastEffectProperties):
(WebCore::CSSFilter::buildFilterFunctions):
(WebCore::CSSFilter::inputContext):
(WebCore::CSSFilter::allocateBackingStoreIfNeeded):
(WebCore::CSSFilter::lastEffect):
(WebCore::CSSFilter::determineFilterPrimitiveSubregion):
(WebCore::CSSFilter::clearIntermediateResults):
(WebCore::CSSFilter::apply):
(WebCore::CSSFilter::output):
(WebCore::CSSFilter::setSourceImageRect):
(WebCore::CSSFilter::outputRect):
(WebCore::CSSFilter::outsets const):
(WebCore::m_sourceGraphic): Deleted.
(WebCore::CSSFilter::buildReferenceFilter): Deleted.
(WebCore::CSSFilter::build): Deleted.
(WebCore::CSSFilter::output const): Deleted.
(WebCore::CSSFilter::setMaxEffectRects): Deleted.
(WebCore::CSSFilter::outputRect const): Deleted.
* rendering/CSSFilter.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFilters):
* rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::buildFilter):
(WebCore::RenderLayerFilters::beginFilterEffect):
(WebCore::RenderLayerFilters::applyFilterEffect):
* rendering/RenderLayerFilters.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::buildPrimitives const): Deleted.
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):
* svg/graphics/filters/SVGFilter.cpp:
(WebCore::SVGFilter::create):
(WebCore::SVGFilter::outsets const):
(WebCore::SVGFilter::clearResult):
* svg/graphics/filters/SVGFilter.h:
* svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::setupBuiltinEffects):
(WebCore::colorInterpolationForElement):
(WebCore::collectEffects):
(WebCore::totalNumberFilterEffects):
(WebCore::SVGFilterBuilder::buildFilterEffects):
(WebCore::SVGFilterBuilder::SVGFilterBuilder): Deleted.
* svg/graphics/filters/SVGFilterBuilder.h:

LayoutTests:

Unskip filter hidpi layout tests.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFilterImageValue.cpp
trunk/Source/WebCore/platform/graphics/filters/Filter.h
trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp
trunk/Source/WebCore/platform/graphics/filters/FilterEffect.h
trunk/Source/WebCore/platform/graphics/filters/FilterFunction.h
trunk/Source/WebCore/rendering/CSSFilter.cpp
trunk/Source/WebCore/rendering/CSSFilter.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerFilters.cpp
trunk/Source/WebCore/rendering/RenderLayerFilters.h
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
trunk/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
trunk/Source/WebCore/svg/graphics/filters/SVGFilter.cpp
trunk/Source/WebCore/svg/graphics/filters/SVGFilter.h
trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp
trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h




Diff

Modified: trunk/LayoutTests/ChangeLog (285617 => 285618)

--- trunk/LayoutTests/Chang

[webkit-changes] [285617] trunk

[j_pascoe]

Title: [285617] trunk








Revision 285617
Author j_pas...@apple.com
Date 2021-11-10 18:52:01 -0800 (Wed, 10 Nov 2021)


Log Message
[WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's ClientDataJson generation
https://bugs.webkit.org/show_bug.cgi?id=232965


Reviewed by Brent Fulgham.

Source/WebCore:

The _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator use different methods of generating
clientDataJson, which results in strings with the keys in a different order. This change abstracts
the clientDataJson generation out of AuthenticatorCoordinator and into WebAuthenticationUtils.

* Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):
(WebCore::AuthenticatorCoordinatorInternal::produceClientDataJson): Deleted.
(WebCore::AuthenticatorCoordinatorInternal::produceClientDataJsonHash): Deleted.
* Modules/webauthn/WebAuthenticationUtils.cpp:
(WebCore::buildClientDataJson):
(WebCore::buildClientDataJsonHash):
* Modules/webauthn/WebAuthenticationUtils.h:

Source/WebKit:

The _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator use different methods of generating
clientDataJson, which results in strings with the keys in a different order. This causes problems
because when generating asserts via ASC ui, the hash signed and the client data json used to generate
that hash are different from the client data json returned to js.

* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(produceClientDataJson):

Tools:

Update api tests to reflect different clientDataJson format from WebAuthenticationUtils

* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (285616 => 285617)

--- trunk/Source/WebCore/ChangeLog	2021-11-11 02:20:02 UTC (rev 285616)
+++ trunk/Source/WebCore/ChangeLog	2021-11-11 02:52:01 UTC (rev 285617)
@@ -1,3 +1,25 @@
+2021-11-10  J Pascoe  
+
+[WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's ClientDataJson generation 
+https://bugs.webkit.org/show_bug.cgi?id=232965
+
+
+Reviewed by Brent Fulgham.
+
+The _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator use different methods of generating
+clientDataJson, which results in strings with the keys in a different order. This change abstracts
+the clientDataJson generation out of AuthenticatorCoordinator and into WebAuthenticationUtils.
+
+* Modules/webauthn/AuthenticatorCoordinator.cpp:
+(WebCore::AuthenticatorCoordinator::create const):
+(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):
+(WebCore::AuthenticatorCoordinatorInternal::produceClientDataJson): Deleted.
+(WebCore::AuthenticatorCoordinatorInternal::produceClientDataJsonHash): Deleted.
+* Modules/webauthn/WebAuthenticationUtils.cpp:
+(WebCore::buildClientDataJson):
+(WebCore::buildClientDataJsonHash):
+* Modules/webauthn/WebAuthenticationUtils.h:
+
 2021-11-10  Tim Nguyen  
 
 Remove non-standard -webkit-border-fit CSS property


Modified: trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp (285616 => 285617)

--- trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp	2021-11-11 02:20:02 UTC (rev 285616)
+++ trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp	2021-11-11 02:52:01 UTC (rev 285617)
@@ -41,43 +41,15 @@
 #include "PublicKeyCredentialRequestOptions.h"
 #include "RegistrableDomain.h"
 #include "LegacySchemeRegistry.h"
-#include "SecurityOrigin.h"
 #include "WebAuthenticationConstants.h"
+#include "WebAuthenticationUtils.h"
 #include 
-#include 
 #include 
-#include 
 
 namespace WebCore {
 
 namespace AuthenticatorCoordinatorInternal {
 
-// FIXME(181948): Add token binding ID.
-static Ref produceClientDataJson(ClientDataType type, const BufferSource& challenge, const SecurityOrigin& origin)
-{
-auto object = JSON::Object::create();
-switch (type) {
-case ClientDataType::Create:
-object->setString("type"_s, "webauthn.create"_s);
-break;
-case ClientDataType::Get:
-object->setString("type"_s, "webauthn.get"_s);
-break;
-}
-object->setString("challenge"_s, base64URLEncodeToString(challenge.data(), challenge.length()));
-object->setString("origin"_s, origin.toRawString());
-
-auto utf8JSONString = object->toJSONString().utf8();
- 

[webkit-changes] [285616] tags/Safari-613.1.8/

[alancoon]

Title: [285616] tags/Safari-613.1.8/








Revision 285616
Author alanc...@apple.com
Date 2021-11-10 18:20:02 -0800 (Wed, 10 Nov 2021)


Log Message
Tag Safari-613.1.8.

Added Paths

tags/Safari-613.1.8/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285615] trunk

[ntim]

Title: [285615] trunk








Revision 285615
Author n...@apple.com
Date 2021-11-10 16:47:14 -0800 (Wed, 10 Nov 2021)


Log Message
Remove non-standard -webkit-border-fit CSS property
https://bugs.webkit.org/show_bug.cgi?id=229564

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator BorderFit const): Deleted.
* css/CSSProperties.json:
* css/CSSValueKeywords.in:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::adjustForBorderFit const): Deleted.
(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded): Deleted.
* rendering/RenderBlockFlow.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInFragment const):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
* rendering/style/RenderStyle.cpp:
(WebCore::rareNonInheritedDataChangeRequiresRepaint):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::borderFit const): Deleted.
(WebCore::RenderStyle::setBorderFit): Deleted.
(WebCore::RenderStyle::initialBorderFit): Deleted.
* rendering/style/RenderStyleConstants.cpp:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

Source/WebInspectorUI:

* UserInterface/Models/CSSKeywordCompletions.js:

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

Remove relevant tests and update test expectations.

* TestExpectations:
* fast/block/border-fit-with-right-alignment-expected.html: Removed.
* fast/block/border-fit-with-right-alignment.html: Removed.
* fast/borders/border-fit-2-expected.txt: Removed.
* fast/borders/border-fit-2.html: Removed.
* fast/borders/border-fit-expected.txt: Removed.
* fast/borders/border-fit.html: Removed.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:
* fast/multicol/widow-relayout-with-border-fit-expected.txt: Removed.
* fast/multicol/widow-relayout-with-border-fit.html: Removed.
* fast/repaint/border-fit-lines-expected.html: Removed.
* fast/repaint/border-fit-lines.html: Removed.
* platform/glib/fast/borders/border-fit-expected.txt: Removed.
* platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/glib/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/fast/borders/border-fit-2-expected.png: Removed.
* platform/gtk/fast/borders/border-fit-expected.png: Removed.
* platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* platform/ios/TestExpectations:
* platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* platform/ios/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/fast/borders/border-fit-2-expected.png: Removed.
* platform/mac/fast/borders/border-fit-expected.png: Removed.
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/win/fast/borders/border-fit-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt
trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/platform/glib/svg/css/getComputedStyle-basic-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-

[webkit-changes] [285614] tags/Safari-613.1.7.1/

[alancoon]

Title: [285614] tags/Safari-613.1.7.1/








Revision 285614
Author alanc...@apple.com
Date 2021-11-10 16:45:20 -0800 (Wed, 10 Nov 2021)


Log Message
Tag Safari-613.1.7.1.

Added Paths

tags/Safari-613.1.7.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285613] tags/Safari-613.1.7.1/

[alancoon]

Title: [285613] tags/Safari-613.1.7.1/








Revision 285613
Author alanc...@apple.com
Date 2021-11-10 16:45:13 -0800 (Wed, 10 Nov 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-613.1.7.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285612] trunk/Source/WebKit

[pvollan]

Title: [285612] trunk/Source/WebKit








Revision 285612
Author pvol...@apple.com
Date 2021-11-10 16:26:20 -0800 (Wed, 10 Nov 2021)


Log Message
Block sandbox access to consume mach extensions
https://bugs.webkit.org/show_bug.cgi?id=232254


Reviewed by Brent Fulgham.

Block sandbox access to consume mach extensions that are not issued by WebKit.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
trunk/Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (285611 => 285612)

--- trunk/Source/WebKit/ChangeLog	2021-11-11 00:19:23 UTC (rev 285611)
+++ trunk/Source/WebKit/ChangeLog	2021-11-11 00:26:20 UTC (rev 285612)
@@ -1,3 +1,19 @@
+2021-11-10  Per Arne Vollan 
+
+Block sandbox access to consume mach extensions
+https://bugs.webkit.org/show_bug.cgi?id=232254
+
+
+Reviewed by Brent Fulgham.
+
+Block sandbox access to consume mach extensions that are not issued by WebKit.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+* WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2021-11-10  Devin Rousso  
 
 Unreviewed internal build fix after r285444


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (285611 => 285612)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-11 00:19:23 UTC (rev 285611)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-11 00:26:20 UTC (rev 285612)
@@ -617,7 +617,6 @@
 (apply-write-and-issue-extension allow path-filter))
 (read-only-and-issue-extensions (extension "com.apple.app-sandbox.read"))
 (read-write-and-issue-extensions (extension "com.apple.app-sandbox.read-write"))
-(allow mach-lookup (with telemetry) (extension "com.apple.app-sandbox.mach")) ;; FIXME: Should be removed when  is fixed.
 
 ;; Allow the OpenGL Profiler to attach.
 (allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$"))
@@ -842,7 +841,6 @@
 (shared-preferences-read "com.apple.cmio")
 (shared-preferences-read "com.apple.coremedia")
 (allow file-read* (subpath "/Library/CoreMediaIO/Plug-Ins/DAL"))
-(allow mach-lookup (with telemetry) (extension "com.apple.app-sandbox.mach"))
 (allow mach-lookup (with telemetry)
 (global-name "com.apple.cmio.AppleCameraAssistant")
 (global-name "com.apple.cmio.registerassistantservice")


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (285611 => 285612)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-11 00:19:23 UTC (rev 285611)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-11 00:26:20 UTC (rev 285612)
@@ -177,7 +177,6 @@
 (allow user-preference-read
 (preference-domain "com.apple.coremedia"))
 (allow file-read* (with telemetry) (subpath "/Library/CoreMediaIO/Plug-Ins/DAL"))
-(allow mach-lookup (with telemetry) (extension "com.apple.app-sandbox.mach"))
 (allow device-camera))
 
 ;; Support incoming video connections


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (285611 => 285612)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-11-11 00:19:23 UTC (rev 285611)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-11-11 00:26:20 UTC (rev 285612)
@@ -185,7 +185,6 @@
 (allow user-preference-read
 (preference-domain "com.apple.coremedia"))
 (allow file-read* (subpath "/Library/CoreMediaIO/Plug-Ins/DAL"))
-(allow mach-lookup (extension "com.apple.app-sandbox.mach"))
 (allow device-camera))
 )
 


Modified: trunk/Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in (285611 => 285612)

--- trunk/Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in	2021-11-11 00:19:23 UTC (rev 285611)
+++ trunk/Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in	2021-11-11 00:26:20 UTC (rev 285612)
@@ -321,7 +321,6 @@
 (apply-write-and-issue-extension allow 

[webkit-changes] [285611] trunk/Source/WebKit

[drousso]

Title: [285611] trunk/Source/WebKit








Revision 285611
Author drou...@apple.com
Date 2021-11-10 16:19:23 -0800 (Wed, 10 Nov 2021)


Log Message
Unreviewed internal build fix after r285444

* Platform/spi/Cocoa/AppleMediaServicesUISPI.h:
Make sure that `AppleMediaServicesSPI.h` is always included.

* Platform/spi/Cocoa/AppleMediaServicesSPI.h:
Add missing `;`.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/AppleMediaServicesSPI.h
trunk/Source/WebKit/Platform/spi/Cocoa/AppleMediaServicesUISPI.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (285610 => 285611)

--- trunk/Source/WebKit/ChangeLog	2021-11-11 00:14:36 UTC (rev 285610)
+++ trunk/Source/WebKit/ChangeLog	2021-11-11 00:19:23 UTC (rev 285611)
@@ -1,5 +1,15 @@
 2021-11-10  Devin Rousso  
 
+Unreviewed internal build fix after r285444
+
+* Platform/spi/Cocoa/AppleMediaServicesUISPI.h:
+Make sure that `AppleMediaServicesSPI.h` is always included.
+
+* Platform/spi/Cocoa/AppleMediaServicesSPI.h:
+Add missing `;`.
+
+2021-11-10  Devin Rousso  
+
 Add support for marking an `` as being autofilled with obscured content
 https://bugs.webkit.org/show_bug.cgi?id=232903
 


Modified: trunk/Source/WebKit/Platform/spi/Cocoa/AppleMediaServicesSPI.h (285610 => 285611)

--- trunk/Source/WebKit/Platform/spi/Cocoa/AppleMediaServicesSPI.h	2021-11-11 00:14:36 UTC (rev 285610)
+++ trunk/Source/WebKit/Platform/spi/Cocoa/AppleMediaServicesSPI.h	2021-11-11 00:19:23 UTC (rev 285611)
@@ -39,6 +39,8 @@
 
 #else // if !USE(APPLE_INTERNAL_SDK)
 
+NS_ASSUME_NONNULL_BEGIN
+
 @interface AMSPromise : NSObject
 - (void)addFinishBlock:(void(^)(ResultType _Nullable result, NSError * _Nullable error))finishBlock;
 @end
@@ -64,11 +66,17 @@
 - (BOOL)cancel;
 @end
 
+NS_ASSUME_NONNULL_END
+
 #endif // !USE(APPLE_INTERNAL_SDK)
 
+NS_ASSUME_NONNULL_BEGIN
+
 @interface AMSEngagementRequest (Staging_84159382)
-- (instancetype)initWithRequestDictionary:(NSDictionary *)dictionary
+- (instancetype)initWithRequestDictionary:(NSDictionary *)dictionary;
 @property (NS_NONATOMIC_IOSONLY, strong, nullable) NSURL *originatingURL;
 @end
 
+NS_ASSUME_NONNULL_END
+
 #endif // ENABLE(APPLE_PAY_AMS_UI)


Modified: trunk/Source/WebKit/Platform/spi/Cocoa/AppleMediaServicesUISPI.h (285610 => 285611)

--- trunk/Source/WebKit/Platform/spi/Cocoa/AppleMediaServicesUISPI.h	2021-11-11 00:14:36 UTC (rev 285610)
+++ trunk/Source/WebKit/Platform/spi/Cocoa/AppleMediaServicesUISPI.h	2021-11-11 00:19:23 UTC (rev 285611)
@@ -27,6 +27,8 @@
 
 #if ENABLE(APPLE_PAY_AMS_UI)
 
+#include "AppleMediaServicesSPI.h"
+
 #if USE(APPLE_INTERNAL_SDK)
 
 #import 
@@ -33,7 +35,7 @@
 
 #else // if !USE(APPLE_INTERNAL_SDK)
 
-#include "AppleMediaServicesSPI.h"
+NS_ASSUME_NONNULL_BEGIN
 
 #if PLATFORM(IOS_FAMILY)
 OBJC_CLASS UIViewController;
@@ -49,6 +51,8 @@
 - (AMSPromise *)presentEngagement;
 @end
 
+NS_ASSUME_NONNULL_END
+
 #endif // !USE(APPLE_INTERNAL_SDK)
 
 #endif // ENABLE(APPLE_PAY_AMS_UI)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285610] trunk

[drousso]

Title: [285610] trunk








Revision 285610
Author drou...@apple.com
Date 2021-11-10 16:14:36 -0800 (Wed, 10 Nov 2021)


Log Message
Add support for marking an `` as being autofilled with obscured content
https://bugs.webkit.org/show_bug.cgi?id=232903


Reviewed by Aditya Keerthi.

Source/WebCore:

Test: fast/forms/auto-fill-button/input-auto-filled-and-obscured.html

* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isAutoFilledAndObscured const): Added.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::setAutoFilledAndObscured): Added.
Add a new boolean state member that is used by injected bundle code (and tests).

* css/CSSSelector.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* css/SelectorCheckerTestFunctions.h:
(WebCore::isAutofilledAndObscured): Added.
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION):
(WebCore::SelectorCompiler::addPseudoClassType):
Create a new `-webkit-autofill-and-obscured` pseudo-class.

* css/html.css:
(input:-webkit-autofill-and-obscured): Added.
(input:-webkit-autofill, input:-webkit-autofill-strong-password, input:-webkit-autofill-strong-password-viewable, input:-webkit-autofill-and-obscured): Renamed from `input:-webkit-autofill, input:-webkit-autofill-strong-password, input:-webkit-autofill-strong-password-viewable`.
Use `-webkit-autofill-and-obscured` to change the `` text into non-interactable discs.

* testing/Internals.idl:
* testing/Internals.h:
* testing/Internals.cpp:
(WebCore::Internals::setAutoFilledAndObscured): Added.

Source/WebKit:

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutoFilledAndObscured const): Added.
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutoFilledAndObscured): Added.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
(-[WKWebProcessPlugInNodeHandle HTMLInputElementIsAutoFilledAndObscured]): Added.
(-[WKWebProcessPlugInNodeHandle setHTMLInputElementIsAutoFilledAndObscured:]): Added.
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleSetHTMLInputElementAutoFilledAndObscured): Added.
Expose a way to get/set the CSS `-webkit-autofill-and-obscured` pseudo-class on an ``.

LayoutTests:

* fast/forms/auto-fill-button/input-auto-filled-and-obscured.html: Added.
* fast/forms/auto-fill-button/input-auto-filled-and-obscured-expected.html: Added.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSSelector.cpp
trunk/Source/WebCore/css/CSSSelector.h
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h
trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h
trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h
trunk/Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h


Added Paths

trunk/LayoutTests/fast/forms/auto-fill-button/input-auto-filled-and-obscured-expected.html
trunk/LayoutTests/fast/forms/auto-fill-button/input-auto-filled-and-obscured.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285609 => 285610)

--- trunk/LayoutTests/ChangeLog	2021-11-11 00:03:06 UTC (rev 285609)
+++ trunk/LayoutTests/ChangeLog	2021-11-11 00:14:36 UTC (rev 285610)
@@ -1,3 +1,16 @@
+2021-11-10  Devin Rousso  
+
+Add support for marking an `` as being autofilled with obscured content
+https://bugs.webkit.org/show_bug.cgi?id=232903
+
+
+Reviewed by Aditya Keerthi.
+
+* fast/forms/auto-fill-button/input-auto-filled-and-obscured.html: Added.
+* fast/forms/auto-fill-button/input-auto-filled-and-obscured-expected.html: Added.
+
+* platform/win/TestExpectations:
+
 2021-11-10  Wenson Hsieh  
 
 Refactor some image overlay logic t

[webkit-changes] [285609] trunk

[wenson_hsieh]

Title: [285609] trunk








Revision 285609
Author wenson_hs...@apple.com
Date 2021-11-10 16:03:06 -0800 (Wed, 10 Nov 2021)


Log Message
Refactor some image overlay logic to work with built-in media controls
https://bugs.webkit.org/show_bug.cgi?id=232899
rdar://83173597

Reviewed by Antoine Quint and Tim Horton.

Source/WebCore:

Make various minor adjustments to allow built-in modern media controls to play well with image overlay content.
See below for more details.

* Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::mediaControlsContainerClassName):
* Modules/mediacontrols/MediaControlsHost.h:

Add a helper function to grab the "media-controls-container" class name, which is used for the `div` element
containing built-in modern media controls. This is used below to identify existing media control container
elements when determining where to inject the image overlay root container.

* Modules/mediacontrols/MediaControlsHost.idl:
* Modules/modern-media-controls/controls/controls-bar.css:
(.controls-bar):

Z-order the media controls bar (which contains all interactible media control elements) above any image overlay
content that may coexist in the same shadow root.

* Modules/modern-media-controls/controls/media-controls.css:
(:host):

Remove `-webkit-user-select: none;` here. This was added to prevent the iOS magnifier UI from showing up when
long pressing inside a video element; we can achieve the same effect without applying this property over the
entire host element by instead changing selection logic in WebKit2.

(.media-controls):

Push the `-webkit-user-select: none;` property down into the media control children, instead of on
`.media-controls` itself.

(.media-controls > *):
* Modules/modern-media-controls/media/media-controller.js:
(MediaController):

Change this to ask for `mediaControlsContainerClassName` from the host, instead of hard-coding it to
"media-controls-container". From code inspection, there does not seem to be any codepath that passes in an
undefined `host`, except for the modern media controls layout tests (which still pass after this adjustment).

* html/HTMLElement.cpp:
(WebCore::HTMLElement::isImageOverlayText):
(WebCore::HTMLElement::removeImageOverlaySoonIfNeeded):

Adjust these helper methods to work in the case where the image overlay container is hosted underneath the media
controls container.

(WebCore::HTMLElement::updateWithTextRecognitionResult):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::playInternal):

If needed, remove the image overlay when seeking or playing media.

Source/WebKit:

See WebCore/ChangeLog for more details.

* Shared/ios/InteractionInformationAtPosition.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(canAttemptTextRecognitionForNonImageElements):

Add a new WebKitAdditions integration point.

(-[WKContentView imageAnalysisGestureDidBegin:]):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::selectionPositionInformation):

Adjust for the changes to the built-in media controls stylesheet by adding logic to prevent the magnifier from
showing up when long pressing (or long pressing inside) video elements on iOS.

LayoutTests:

Adjust a modern media controls test, such that it no longer verifies that the `-webkit-user-select` CSS property
is none on an audio element; in lieu of this, we add a new layout test in `editing/selection` to verify that
long pressing over the timestamp of an audio element does not trigger text selection.

* editing/selection/ios/do-not-allow-text-selection-in-audio-element-expected.txt: Added.
* editing/selection/ios/do-not-allow-text-selection-in-audio-element.html: Added.
* media/modern-media-controls/audio/audio-controls-styles-expected.txt:
* media/modern-media-controls/audio/audio-controls-styles.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles-expected.txt
trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-styles.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
trunk/Source/WebCore/Modules/modern-media-controls/controls/controls-bar.css
trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css
trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm


Added Paths

trunk/LayoutTests/editing/selection/ios/do-not-allow-text-selection-in-audio-element-expected.txt
trunk/LayoutTests/editing/selection/ios/do-not-allow-text-selection-in-a

[webkit-changes] [285608] trunk/Tools

[mmaxfield]

Title: [285608] trunk/Tools








Revision 285608
Author mmaxfi...@apple.com
Date 2021-11-10 14:49:56 -0800 (Wed, 10 Nov 2021)


Log Message
[Cocoa] Build WebGPU on our bots
https://bugs.webkit.org/show_bug.cgi?id=232924

Reviewed by Dean Jackson and Alex Christensen.

Simply tell the build script about the existence of WebGPU.

* Scripts/build-webkit:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/Tools/ChangeLog (285607 => 285608)

--- trunk/Tools/ChangeLog	2021-11-10 20:50:30 UTC (rev 285607)
+++ trunk/Tools/ChangeLog	2021-11-10 22:49:56 UTC (rev 285608)
@@ -1,3 +1,14 @@
+2021-11-10  Myles C. Maxfield  
+
+[Cocoa] Build WebGPU on our bots
+https://bugs.webkit.org/show_bug.cgi?id=232924
+
+Reviewed by Dean Jackson and Alex Christensen.
+
+Simply tell the build script about the existence of WebGPU.
+
+* Scripts/build-webkit:
+
 2021-11-10  Commit Queue  
 
 Unreviewed, reverting r285603.


Modified: trunk/Tools/Scripts/build-webkit (285607 => 285608)

--- trunk/Tools/Scripts/build-webkit	2021-11-10 20:50:30 UTC (rev 285607)
+++ trunk/Tools/Scripts/build-webkit	2021-11-10 22:49:56 UTC (rev 285608)
@@ -192,8 +192,14 @@
 my $productDir = productDir();
 
 # Check that all the project directories are there.
-my @projects = ("Source/_javascript_Core", "Source/WebCore", "Source/WebKitLegacy");
+my @projects = ("Source/_javascript_Core");
+if (isAppleCocoaWebKit()) {
+push @projects, ("Source/WebGPU");
+}
+push @projects, ("Source/WebCore");
+push @projects, ("Source/WebKitLegacy");
 
+
 # Build WTF as a separate static library on ports which support it.
 splice @projects, 0, 0, "Source/WTF" if isAppleWebKit() or isWinCairo() or isFTW();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285607] trunk/Tools

[commit-queue]

Title: [285607] trunk/Tools








Revision 285607
Author commit-qu...@webkit.org
Date 2021-11-10 12:50:30 -0800 (Wed, 10 Nov 2021)


Log Message
Unreviewed, reverting r285603.
https://bugs.webkit.org/show_bug.cgi?id=232963

broke the watchOS build

Reverted changeset:

"[Cocoa] Build WebGPU on our bots"
https://bugs.webkit.org/show_bug.cgi?id=232924
https://commits.webkit.org/r285603

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/Tools/ChangeLog (285606 => 285607)

--- trunk/Tools/ChangeLog	2021-11-10 20:30:06 UTC (rev 285606)
+++ trunk/Tools/ChangeLog	2021-11-10 20:50:30 UTC (rev 285607)
@@ -1,3 +1,16 @@
+2021-11-10  Commit Queue  
+
+Unreviewed, reverting r285603.
+https://bugs.webkit.org/show_bug.cgi?id=232963
+
+broke the watchOS build
+
+Reverted changeset:
+
+"[Cocoa] Build WebGPU on our bots"
+https://bugs.webkit.org/show_bug.cgi?id=232924
+https://commits.webkit.org/r285603
+
 2021-11-10  Myles C. Maxfield  
 
 [Cocoa] Build WebGPU on our bots


Modified: trunk/Tools/Scripts/build-webkit (285606 => 285607)

--- trunk/Tools/Scripts/build-webkit	2021-11-10 20:30:06 UTC (rev 285606)
+++ trunk/Tools/Scripts/build-webkit	2021-11-10 20:50:30 UTC (rev 285607)
@@ -243,7 +243,6 @@
 if (portName() eq Mac or portName() eq iOS) {
 splice @projects, 0, 0, ("Source/ThirdParty/libwebrtc");
 }
-splice @projects, 0, 0, ("Source/WebGPU");
 
 push @projects, ("Source/WebKit");
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285606] trunk/Source/WebKit

[pvollan]

Title: [285606] trunk/Source/WebKit








Revision 285606
Author pvol...@apple.com
Date 2021-11-10 12:30:06 -0800 (Wed, 10 Nov 2021)


Log Message
[macOS][GPUP] Remove access to sysctl properties
https://bugs.webkit.org/show_bug.cgi?id=232329


Reviewed by Darin Adler.

Based on telemetry, remove access to unused sysctl properties in the GPU process' sandbox on macOS.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (285605 => 285606)

--- trunk/Source/WebKit/ChangeLog	2021-11-10 20:26:27 UTC (rev 285605)
+++ trunk/Source/WebKit/ChangeLog	2021-11-10 20:30:06 UTC (rev 285606)
@@ -1,3 +1,15 @@
+2021-11-10  Per Arne Vollan 
+
+[macOS][GPUP] Remove access to sysctl properties
+https://bugs.webkit.org/show_bug.cgi?id=232329
+
+
+Reviewed by Darin Adler.
+
+Based on telemetry, remove access to unused sysctl properties in the GPU process' sandbox on macOS.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+
 2021-11-10  Chris Dumez  
 
 Add basic support for launching CaptivePortalMode WebProcesses


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (285605 => 285606)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-10 20:26:27 UTC (rev 285605)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-10 20:30:06 UTC (rev 285606)
@@ -155,68 +155,33 @@
 (allow process-info-setcontrol (target self))
 (allow process-codesigning-status*)
 
-(deny sysctl*)
+(deny sysctl* (with telemetry))
 (allow sysctl-read (with telemetry)
 (sysctl-name
-"hw.activecpu" ;; 
-"hw.availcpu"
-"hw.byteorder"
-"hw.busfrequency"
-"hw.busfrequency_max"
-"hw.cacheconfig" ;; 
-"hw.cachelinesize" ;; 
-"hw.cachesize" ;; 
-"hw.cpufamily" ;; 
-"hw.cpufrequency"
-"hw.cpufrequency_max"
+"hw.activecpu"
+"hw.cachelinesize"
+"hw.cpufamily"
 "hw.cpusubfamily"
 "hw.cputhreadtype"
 "hw.cputype"
-"hw.l1dcachesize" ;; 
-"hw.l1icachesize" ;; 
-"hw.l2cachesize" ;; 
-"hw.l3cachesize" ;; 
-"hw.logicalcpu" ;; 
-"hw.logicalcpu_max" ;; 
-"hw.machine"
+"hw.l2cachesize"
+"hw.logicalcpu"
+"hw.logicalcpu_max"
 "hw.memsize"
 "hw.model"
 "hw.ncpu"
-"hw.nperflevels" ;; 
-"hw.pagesize" ;; 
-"hw.pagesize_compat" ;; 
-"hw.physicalcpu" ;; 
-"hw.physicalcpu_max" ;; 
-"hw.tbfrequency"
-"hw.tbfrequency_compat"
+"hw.physicalcpu"
+"hw.physicalcpu_max"
 "hw.vectorunit"
-"kern.bootargs" ;; 
 "kern.hostname"
 "kern.hv_vmm_present"
 "kern.maxfilesperproc"
-"kern.memorystatus_level"
-"kern.osproductversion" ;; 
-"kern.osrelease"
-"kern.ostype"
-"kern.osvariant_status"
-"kern.osversion"
-"kern.safeboot"
-"kern.version"
-"machdep.cpu.brand_string"
-"security.mac.sandbox.sentinel"
-"sysctl.name2oid"
-"kern.tcsm_enable"
-"kern.tcsm_available"
-"vm.footprint_suspend")
-(sysctl-name-prefix "net.routetable")
+"kern.osproductversion"
+"kern.osrelease")
 (sysctl-name-prefix "hw.optional.") ;; 
 (sysctl-name-prefix "hw.perflevel") ;; 
 )
 
-(allow sysctl-write (with telemetry)
-(sysctl-name
-"kern.tcsm_enable"))
-
 (deny iokit-get-properties)
 (allow iokit-get-properties
 (iokit-property "AAPL,LCD-PowerState-ON") ;; 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285605] trunk/Source/WebInspectorUI

[ap]

Title: [285605] trunk/Source/WebInspectorUI








Revision 285605
Author a...@apple.com
Date 2021-11-10 12:26:27 -0800 (Wed, 10 Nov 2021)


Log Message
WebInspectorUI needs to support InstallAPI
https://bugs.webkit.org/show_bug.cgi?id=232955

Reviewed by BJ Burg.

* Configurations/WebInspectorUIFramework.xcconfig:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (285604 => 285605)

--- trunk/Source/WebInspectorUI/ChangeLog	2021-11-10 20:10:04 UTC (rev 285604)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-11-10 20:26:27 UTC (rev 285605)
@@ -1,3 +1,12 @@
+2021-11-10  Alexey Proskuryakov  
+
+WebInspectorUI needs to support InstallAPI
+https://bugs.webkit.org/show_bug.cgi?id=232955
+
+Reviewed by BJ Burg.
+
+* Configurations/WebInspectorUIFramework.xcconfig:
+
 2021-11-09  Razvan Caliman  
 
 Web Inspector: Add script to update CSSDocumentation.js


Modified: trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig (285604 => 285605)

--- trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig	2021-11-10 20:10:04 UTC (rev 285604)
+++ trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig	2021-11-10 20:26:27 UTC (rev 285605)
@@ -33,4 +33,6 @@
 _javascript_CORE_PRIVATE_HEADERS_DIR_Production_COCOA_TOUCH_NO = $(SDKROOT)$(PRODUCTION_FRAMEWORKS_DIR)/_javascript_Core.framework/PrivateHeaders;
 _javascript_CORE_PRIVATE_HEADERS_engineering = $(BUILT_PRODUCTS_DIR)/_javascript_Core.framework/PrivateHeaders;
 
+SUPPORTS_TEXT_BASED_API = YES;
+
 SKIP_INSTALL[sdk=iphone*] = YES;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285604] trunk

[graouts]

Title: [285604] trunk








Revision 285604
Author grao...@webkit.org
Date 2021-11-10 12:10:04 -0800 (Wed, 10 Nov 2021)


Log Message
The cssText property for a computed style should return an empty string
https://bugs.webkit.org/show_bug.cgi?id=232943

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:

Source/WebCore:

See https://github.com/w3c/csswg-drafts/issues/1033. This was an annoying test to fail because the output
would require a rebaseline every time we'd change something visible in the computed style.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssText const):

LayoutTests:

Remove all platform-specific expectations for the WPT css/cssom/cssstyledeclaration-csstext.html since the
assertion that would fail differently on various platforms now passes everywhere.

* platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Removed Paths

trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (285603 => 285604)

--- trunk/LayoutTests/ChangeLog	2021-11-10 19:53:07 UTC (rev 285603)
+++ trunk/LayoutTests/ChangeLog	2021-11-10 20:10:04 UTC (rev 285604)
@@ -1,3 +1,18 @@
+2021-11-10  Antoine Quint  
+
+The cssText property for a computed style should return an empty string
+https://bugs.webkit.org/show_bug.cgi?id=232943
+
+Reviewed by Antti Koivisto.
+
+Remove all platform-specific expectations for the WPT css/cssom/cssstyledeclaration-csstext.html since the
+assertion that would fail differently on various platforms now passes everywhere.
+
+* platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
+* platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
+* platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
+* platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
+
 2021-11-10  Said Abou-Hallawa  
 
 [GPU Process] Make SVGFilter and CSSFilter work in the same coordinates system


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285603 => 285604)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-10 19:53:07 UTC (rev 285603)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-10 20:10:04 UTC (rev 285604)
@@ -1,3 +1,12 @@
+2021-11-10  Antoine Quint  
+
+The cssText property for a computed style should return an empty string
+https://bugs.webkit.org/show_bug.cgi?id=232943
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
+
 2021-11-10  Rob Buis  
 
 [css-contain] Support contain:paint


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt (285603 => 285604)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt	2021-11-10 19:53:07 UTC (rev 285603)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt	2021-11-10 20:10:04 UTC (rev 285604)
@@ -9,5 +9,5 @@
 PASS invalid property does not appear
 FAIL Shorthands aren't serialized if there are other properties with different logical groups in between assert_equals: expected "margin-top: 10px; margin-right: 10px; margin-left: 10px; margin-inline-start: 10px; margin-block: 10px; margin-inline-end: 10px; margin-bottom: 10px;" but got "margin: 10px; margin-inline: 10px; margin-block: 10px;"
 PASS Shorthands _are_ serialized if there are no other properties with different logical groups in between
-FAIL cssText on computed style declaration returns the empty string assert_equals: cssText is empty expected "" but got "accent-color: auto; align-content: normal; ali

[webkit-changes] [285603] trunk/Tools

[mmaxfield]

Title: [285603] trunk/Tools








Revision 285603
Author mmaxfi...@apple.com
Date 2021-11-10 11:53:07 -0800 (Wed, 10 Nov 2021)


Log Message
[Cocoa] Build WebGPU on our bots
https://bugs.webkit.org/show_bug.cgi?id=232924

Reviewed by Dean Jackson.

Simply tell the build script about the existence of WebGPU.

* Scripts/build-webkit:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/Tools/ChangeLog (285602 => 285603)

--- trunk/Tools/ChangeLog	2021-11-10 19:40:14 UTC (rev 285602)
+++ trunk/Tools/ChangeLog	2021-11-10 19:53:07 UTC (rev 285603)
@@ -1,3 +1,14 @@
+2021-11-10  Myles C. Maxfield  
+
+[Cocoa] Build WebGPU on our bots
+https://bugs.webkit.org/show_bug.cgi?id=232924
+
+Reviewed by Dean Jackson.
+
+Simply tell the build script about the existence of WebGPU.
+
+* Scripts/build-webkit:
+
 2021-11-10  Alex Christensen  
 
 Implement serialization and deserialization of redirect and modify headers actions for WKContentRuleList


Modified: trunk/Tools/Scripts/build-webkit (285602 => 285603)

--- trunk/Tools/Scripts/build-webkit	2021-11-10 19:40:14 UTC (rev 285602)
+++ trunk/Tools/Scripts/build-webkit	2021-11-10 19:53:07 UTC (rev 285603)
@@ -243,6 +243,7 @@
 if (portName() eq Mac or portName() eq iOS) {
 splice @projects, 0, 0, ("Source/ThirdParty/libwebrtc");
 }
+splice @projects, 0, 0, ("Source/WebGPU");
 
 push @projects, ("Source/WebKit");
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285602] trunk/Source/WebCore

[zalan]

Title: [285602] trunk/Source/WebCore








Revision 285602
Author za...@apple.com
Date 2021-11-10 11:40:14 -0800 (Wed, 10 Nov 2021)


Log Message
[LFC][IFC] ubidi expects non-preserved new lines as whitespace characters
https://bugs.webkit.org/show_bug.cgi?id=232921

Reviewed by Antti Koivisto.

* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::replaceNonPreservedNewLineCharactersAndAppend):
(WebCore::Layout::buildBidiParagraph):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285601 => 285602)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 19:37:36 UTC (rev 285601)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 19:40:14 UTC (rev 285602)
@@ -1,3 +1,14 @@
+2021-11-10  Alan Bujtas  
+
+[LFC][IFC] ubidi expects non-preserved new lines as whitespace characters
+https://bugs.webkit.org/show_bug.cgi?id=232921
+
+Reviewed by Antti Koivisto.
+
+* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
+(WebCore::Layout::replaceNonPreservedNewLineCharactersAndAppend):
+(WebCore::Layout::buildBidiParagraph):
+
 2021-11-10  Alex Christensen  
 
 Implement serialization and deserialization of redirect and modify headers actions for WKContentRuleList


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp (285601 => 285602)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-10 19:37:36 UTC (rev 285601)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-10 19:40:14 UTC (rev 285602)
@@ -139,6 +139,38 @@
 }
 }
 
+static void replaceNonPreservedNewLineCharactersAndAppend(const InlineTextBox& inlineTextBox, StringBuilder& paragraphContentBuilder)
+{
+// ubidi prefers non-preserved new lines as whitespace characters.
+if (TextUtil::shouldPreserveNewline(inlineTextBox))
+return paragraphContentBuilder.append(inlineTextBox.content());
+
+auto textContent = inlineTextBox.content();
+auto contentLength = textContent.length();
+auto needsUnicodeHandling = !textContent.is8Bit();
+size_t nonReplacedContentStartPosition = 0;
+for (size_t position = 0; position < contentLength;) {
+auto startPosition = position;
+auto isNewLineCharacter = [&] {
+if (needsUnicodeHandling) {
+UChar32 character;
+U16_NEXT(textContent.characters16(), position, contentLength, character);
+return character == newlineCharacter;
+}
+return textContent[position++] == newlineCharacter;
+};
+if (!isNewLineCharacter())
+continue;
+
+if (nonReplacedContentStartPosition < startPosition)
+paragraphContentBuilder.append(textContent.substring(nonReplacedContentStartPosition, startPosition - nonReplacedContentStartPosition));
+paragraphContentBuilder.append(space);
+nonReplacedContentStartPosition = position;
+}
+if (nonReplacedContentStartPosition < contentLength)
+paragraphContentBuilder.append(textContent.right(contentLength - nonReplacedContentStartPosition));
+}
+
 using InlineItemOffsetList = Vector>;
 static inline void buildBidiParagraph(const InlineItems& inlineItems,  StringBuilder& paragraphContentBuilder, InlineItemOffsetList& inlineItemOffsetList)
 {
@@ -151,7 +183,7 @@
 if (inlineItem.isText()) {
 if (lastInlineTextBox != &layoutBox) {
 inlineTextBoxOffset = paragraphContentBuilder.length();
-paragraphContentBuilder.append(downcast(layoutBox).content());
+replaceNonPreservedNewLineCharactersAndAppend(downcast(layoutBox), paragraphContentBuilder);
 lastInlineTextBox = &layoutBox;
 }
 inlineItemOffsetList.uncheckedAppend({ inlineTextBoxOffset + downcast(inlineItem).start() });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285601] trunk

[commit-queue]

Title: [285601] trunk








Revision 285601
Author commit-qu...@webkit.org
Date 2021-11-10 11:37:36 -0800 (Wed, 10 Nov 2021)


Log Message
Coding style for inner namespaces is should be simplified to not indented
https://bugs.webkit.org/show_bug.cgi?id=232073

Patch by Kimmo Kinnunen  on 2021-11-10
Reviewed by Antti Koivisto.

.:

* .clang-format:
Do not indent contents of inner namespaces, match current code.

Websites/webkit.org:

* code-style.md:
Simplify coding style to match the existing code: contents of inner namespaces
should not be indented.

Modified Paths

trunk/.clang-format
trunk/ChangeLog
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/code-style.md




Diff

Modified: trunk/.clang-format (285600 => 285601)

--- trunk/.clang-format	2021-11-10 19:37:32 UTC (rev 285600)
+++ trunk/.clang-format	2021-11-10 19:37:36 UTC (rev 285601)
@@ -79,7 +79,7 @@
 MacroBlockBegin: ''
 MacroBlockEnd:   ''
 MaxEmptyLinesToKeep: 1
-NamespaceIndentation: Inner
+NamespaceIndentation: None
 ObjCBlockIndentWidth: 4
 ObjCSpaceAfterProperty: true
 ObjCSpaceBeforeProtocolList: true


Modified: trunk/ChangeLog (285600 => 285601)

--- trunk/ChangeLog	2021-11-10 19:37:32 UTC (rev 285600)
+++ trunk/ChangeLog	2021-11-10 19:37:36 UTC (rev 285601)
@@ -1,3 +1,13 @@
+2021-11-10  Kimmo Kinnunen  
+
+Coding style for inner namespaces is should be simplified to not indented
+https://bugs.webkit.org/show_bug.cgi?id=232073
+
+Reviewed by Antti Koivisto.
+
+* .clang-format:
+Do not indent contents of inner namespaces, match current code.
+
 2021-11-09  J Pascoe  
 
 Add j_pascoe to contributors.json


Modified: trunk/Websites/webkit.org/ChangeLog (285600 => 285601)

--- trunk/Websites/webkit.org/ChangeLog	2021-11-10 19:37:32 UTC (rev 285600)
+++ trunk/Websites/webkit.org/ChangeLog	2021-11-10 19:37:36 UTC (rev 285601)
@@ -1,3 +1,14 @@
+2021-11-10  Kimmo Kinnunen  
+
+Coding style for inner namespaces is should be simplified to not indented
+https://bugs.webkit.org/show_bug.cgi?id=232073
+
+Reviewed by Antti Koivisto.
+
+* code-style.md:
+Simplify coding style to match the existing code: contents of inner namespaces
+should not be indented.
+
 2021-11-04  Ryan Haddad  
 
 Add Monterey to WebKit Build Archives page


Modified: trunk/Websites/webkit.org/code-style.md (285600 => 285601)

--- trunk/Websites/webkit.org/code-style.md	2021-11-10 19:37:32 UTC (rev 285600)
+++ trunk/Websites/webkit.org/code-style.md	2021-11-10 19:37:36 UTC (rev 285601)
@@ -22,7 +22,7 @@
 }
 ```
 
-[](#indentation-namespace) The contents of an outermost `namespace` block (and any nested namespaces with the same scope) should not be indented. The contents of other nested namespaces should be indented.
+[](#indentation-namespace) The contents of namespaces should not be indented.
 
 ## Right:
 
@@ -36,7 +36,12 @@
 };
 
 namespace NestedNamespace {
+
+class OtherDocument {
+OtherDocument();
 ...
+};
+
 }
 
 } // namespace WebCore
@@ -49,9 +54,31 @@
 ...
 }
 
+namespace NestedNamespace {
+
+OtherDocument::OtherDocument()
+{
+...
+}
+
+} // namespace NestedNamespace
+
 } // namespace WebCore
 ```
 
+## Right:
+
+```cpp
+// PrivateClickMeasurementDatabase.h
+namespace WebKit::PCM {
+
+class Database {
+...
+};
+
+} // namespace WebKit::PCM
+```
+
 ## Wrong:
 
 ```cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285600] branches/safari-612-branch/Source

[alancoon]

Title: [285600] branches/safari-612-branch/Source








Revision 285600
Author alanc...@apple.com
Date 2021-11-10 11:37:32 -0800 (Wed, 10 Nov 2021)


Log Message
Cherry-pick r285236. rdar://problem/83950623

This reverts r285508.

Modified Paths

branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h
branches/safari-612-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm




Diff

Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (285599 => 285600)

--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-11-10 19:30:13 UTC (rev 285599)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-11-10 19:37:32 UTC (rev 285600)
@@ -1,3 +1,51 @@
+2021-11-08  Kocsen Chung  
+
+Cherry-pick r285236. rdar://problem/83950623
+
+AX: WKAccessibilityWebPageObjectMac.mm should expose accessibilityChildrenInNavigationOrder and NSAccessibilityChildrenInNavigationOrderAttribute
+https://bugs.webkit.org/show_bug.cgi?id=232654
+
+Patch by Tyler Wilcock  on 2021-11-03
+Reviewed by Chris Fleizach.
+
+Some clients expect accessibilityChildrenInNavigationOrder and
+NSAccessibilityChildrenInNavigationOrderAttribute to be available,
+and WKAccessibilityWebPageObjectMac didn't expose them.
+
+Source/WebCore:
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.h:
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+Move #define NSAccessibilityChildrenInNavigationOrderAttribute to
+header so it can be used in the WebKit layer.
+
+Source/WebKit:
+
+* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
+(-[WKAccessibilityWebPageObject accessibilityChildrenInNavigationOrder]): Added.
+(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
+Handle NSAccessibilityChildrenInNavigationOrderAttribute.
+(-[WKAccessibilityWebPageObject accessibilityAttributeNames:]):
+Add NSAccessibilityChildrenInNavigationOrderAttribute.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-11-03  Tyler Wilcock  
+
+AX: WKAccessibilityWebPageObjectMac.mm should expose accessibilityChildrenInNavigationOrder and NSAccessibilityChildrenInNavigationOrderAttribute
+https://bugs.webkit.org/show_bug.cgi?id=232654
+
+Reviewed by Chris Fleizach.
+
+Some clients expect accessibilityChildrenInNavigationOrder and
+NSAccessibilityChildrenInNavigationOrderAttribute to be available,
+and WKAccessibilityWebPageObjectMac didn't expose them.
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.h:
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+Move #define NSAccessibilityChildrenInNavigationOrderAttribute to
+header so it can be used in the WebKit layer.
+
 2021-11-09  Alan Coon  
 
 Cherry-pick r285389. rdar://problem/84380291


Modified: branches/safari-612-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h (285599 => 285600)

--- branches/safari-612-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h	2021-11-10 19:30:13 UTC (rev 285599)
+++ branches/safari-612-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h	2021-11-10 19:37:32 UTC (rev 285600)
@@ -37,6 +37,10 @@
 #define NSAccessibilityPrimaryScreenHeightAttribute @"_AXPrimaryScreenHeight"
 #endif
 
+#ifndef NSAccessibilityChildrenInNavigationOrderAttribute
+#define NSAccessibilityChildrenInNavigationOrderAttribute @"AXChildrenInNavigationOrder"
+#endif
+
 @interface WebAccessibilityObjectWrapper : WebAccessibilityObjectWrapperBase
 
 // FIXME: Remove these methods since clients should not need to call them and hence should not be exposed in the public interface.


Modified: branches/safari-612-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (285599 => 285600)

--- branches/safari-612-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2021-11-10 19:30:13 UTC (rev 285599)
+++ branches/safari-612-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2021-11-10 19:37:32 UTC (rev 285600)
@@ -150,10 +150,6 @@
 #define NSAccessibilityBlockQuoteLevelAttribute @"AXBlockQuoteLevel"
 #endif
 
-#ifndef NSAccessibilityChildrenInNavigationOrderAttribute
-#define NSAccessibilityChildrenInNavigationOrderAttribute @"AXChildrenInNavigationOrder"
-#endif
-
 #ifndef NSAccessibilityAccessKeyAttribute
 #define NSAccessibilityAccessKeyAttribute @"AXAccessKey"
 #endif


Modified: branches/safari-612-branch/Source/WebKit/ChangeLog (285599 => 285600)

--- branches/safari-612-bra

[webkit-changes] [285599] trunk

[commit-queue]

Title: [285599] trunk








Revision 285599
Author commit-qu...@webkit.org
Date 2021-11-10 11:30:13 -0800 (Wed, 10 Nov 2021)


Log Message
Implement serialization and deserialization of redirect and modify headers actions for WKContentRuleList
https://bugs.webkit.org/show_bug.cgi?id=232901

Patch by Alex Christensen  on 2021-11-10
Reviewed by Timothy Hatcher.

Source/WebCore:

I serialized each type so that the first 4 bytes are the total serialized length of that type.
The next time we increment CurrentContentRuleListFileVersion I intend to do that for all existing action serializations.

I used UTF-8 encoding on disk because I anticipate most of the use here will be ASCII because the strings will
either go into URLs or into HTTP headers, both of which use only 8-bit characters when actually used.

URLTransformActions will likely have many cases that don't have all fields, so I optimized by adding one byte
with 8 booleans indicating whether the field is present or not.  This way, I don't need 32 bytes of 0's for the
unused fields' serializations.

Future optimization can be done by adding WTF::String::utf8Length() and WTF::String::utf8EncodeIntoBuffer(Span)
but that will just reduce copies and allocations during compiling, not the serialized format.

Another future optimization that could be done is to use null terminated strings instead of a 4 byte size before each string.
That would reduce the binary size considerably.

* contentextensions/ContentExtensionActions.cpp:
(WebCore::ContentExtensions::append):
(WebCore::ContentExtensions::uncheckedAppend):
(WebCore::ContentExtensions::deserializeLength):
(WebCore::ContentExtensions::deserializeUTF8String):
(WebCore::ContentExtensions::writeLengthToVectorAtOffset):
(WebCore::ContentExtensions::ModifyHeadersAction::serialize const):
(WebCore::ContentExtensions::ModifyHeadersAction::deserialize):
(WebCore::ContentExtensions::ModifyHeadersAction::serializedLength):
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::serialize const):
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::deserialize):
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::serializedLength):
(WebCore::ContentExtensions::RedirectAction::serialize const):
(WebCore::ContentExtensions::RedirectAction::deserialize):
(WebCore::ContentExtensions::RedirectAction::serializedLength):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::serialize const):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::deserialize):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::serializedLength):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::serialize const):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::deserialize):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::serializedLength):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::QueryKeyValue::serialize const):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::QueryKeyValue::deserialize):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::QueryKeyValue::serializedLength):
* contentextensions/ContentExtensionActions.h:
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::AppendOperation::isolatedCopy const): Deleted.
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::AppendOperation::operator== const): Deleted.
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::SetOperation::isolatedCopy const): Deleted.
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::SetOperation::operator== const): Deleted.
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::RemoveOperation::isolatedCopy const): Deleted.
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::RemoveOperation::operator== const): Deleted.
(WebCore::ContentExtensions::RedirectAction::ExtensionPathAction::isolatedCopy const): Deleted.
(WebCore::ContentExtensions::RedirectAction::ExtensionPathAction::operator== const): Deleted.
(WebCore::ContentExtensions::RedirectAction::RegexSubstitutionAction::isolatedCopy const): Deleted.
(WebCore::ContentExtensions::RedirectAction::RegexSubstitutionAction::operator== const): Deleted.
(WebCore::ContentExtensions::RedirectAction::URLAction::isolatedCopy const): Deleted.
(WebCore::ContentExtensions::RedirectAction::URLAction::operator== const): Deleted.

Tools:

* TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/ContentExtensionActions.cpp
trunk/Source/WebCore/contentextensions/ContentExtensionActions.h
trunk/Tools/ChangeLog

[webkit-changes] [285598] branches/safari-612-branch

[alancoon]

Title: [285598] branches/safari-612-branch








Revision 285598
Author alanc...@apple.com
Date 2021-11-10 11:23:20 -0800 (Wed, 10 Nov 2021)


Log Message
Revert r285519. rdar://problem/83971417

This reverts r285519.

Modified Paths

branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/platform/RuntimeApplicationChecks.cpp
branches/safari-612-branch/Source/WebCore/platform/RuntimeApplicationChecks.h
branches/safari-612-branch/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm
branches/safari-612-branch/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h
branches/safari-612-branch/Tools/ChangeLog
branches/safari-612-branch/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig
branches/safari-612-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Removed Paths

branches/safari-612-branch/Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLOpenGLCocoa.mm
branches/safari-612-branch/Tools/TestWebKitAPI/WebCoreUtilities.h




Diff

Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (285597 => 285598)

--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-11-10 19:21:17 UTC (rev 285597)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-11-10 19:23:20 UTC (rev 285598)
@@ -393,93 +393,6 @@
 
 2021-11-09  Alan Coon  
 
-Apply patch. rdar://problem/83971417
-
-2021-10-26  Russell Epstein  
-
-Cherry-pick r284669. rdar://problem/83971417
-
-WebGL low-power and high-performance contexts should use different ANGLE Metal EGLDisplays
-https://bugs.webkit.org/show_bug.cgi?id=231012
-
-
-Patch by Kimmo Kinnunen  on 2021-10-22
-Reviewed by Dean Jackson.
-
-Source/WebCore:
-
-Use per-power preference EGLDisplay when creating Metal
-contexts.
-
-Adds a new API test.
-
-* platform/RuntimeApplicationChecks.cpp:
-(WebCore::setAuxiliaryProcessTypeForTesting):
-* platform/RuntimeApplicationChecks.h:
-Add a test function to reset the process type after test has set a specific type and then
-run to completion. process for the duration of the test. The volatile context flag in
-GraphicsContextGLOpenGL depends on condition isWebProcess || isGPUProcess.
-* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
-(WebCore::GraphicsContextGLOpenGL::releaseThreadResources):
-* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
-(WebCore::initializeEGLDisplay):
-(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
-(WebCore::GraphicsContextGLOpenGL::setContextVisibility):
-(WebCore::GraphicsContextGLOpenGL::displayWasReconfigured):
-* platform/graphics/opengl/GraphicsContextGLOpenGL.h:
-
-Tools:
-
-Add a API test to test GraphicsContextGLOpenGL
-Cocoa implementation regarding the bug where
-the GraphicsContextGLOpenGL instances would use
-the GPU that was selected by the first instance.
-
-* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
-* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
-* TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLOpenGLCocoa.mm: Added.
-(TestWebKitAPI::WebCore::TestedGraphicsContextGLOpenGL::create):
-(TestWebKitAPI::WebCore::TestedGraphicsContextGLOpenGL::TestedGraphicsContextGLOpenGL):
-(TestWebKitAPI::hasMultipleGPUs):
-(TestWebKitAPI::TEST):
-* TestWebKitAPI/WebCoreUtilities.h: Added.
-(TestWebKitAPI::ScopedSetAuxiliaryProcessTypeForTesting::ScopedSetAuxiliaryProcessTypeForTesting):
-(TestWebKitAPI::ScopedSetAuxiliaryProcessTypeForTesting::~ScopedSetAuxiliaryProcessTypeForTesting):
-Add a utility state setter to set the process type for the
-duration of a test.
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2021-10-22  Kimmo Kinnunen  
-
-WebGL low-power and high-performance contexts should use different ANGLE Metal EGLDisplays
-https://bugs.webkit.org/show_bug.cgi?id=231012
-
-
-Reviewed by Dean Jackson.
-
-Use per-power preference EGLDisplay when creating Metal
-contexts.
-
-Adds a new API test.
-
-* platform/RuntimeApplicationChecks.cpp:
-(WebCore::setAuxiliaryProcessTypeForTesting):
-* platform/RuntimeApplicationChecks.h:
-Add a test function to reset the process type after test has set a specific type and then
-run to completion. process for the duration of the test. The volatile context flag in
-GraphicsContextGLOpenGL depends on co

[webkit-changes] [285597] trunk

[said]

Title: [285597] trunk








Revision 285597
Author s...@apple.com
Date 2021-11-10 11:21:17 -0800 (Wed, 10 Nov 2021)


Log Message
[GPU Process] Make SVGFilter and CSSFilter work in the same coordinates system
https://bugs.webkit.org/show_bug.cgi?id=232457
rdar://85035379

Reviewed by Simon Fraser.

Source/WebCore:

Currently SVGFilter sets the following members of Filter

1. AffineTransform m_absoluteTransform: this is the scaling part from the
   transformation from the target element to the outermost coordinate system
2. FloatSize m_filterResolution: this is the clamping scale if the size
   of the result ImageBuffers exceeds MaxClampedArea

And the CSSFilter sets the following member of Filter:

1. float m_filterScale: this is the document().deviceScaleFactor()

The discrepancy happens also when creating the result ImageBuffers. For
SVGFilter, we create them with scaleFactor = 1. This means the logicalSize
of the ImageBuffer is equal to its backendSize. But for CSSFilter we
create them with scaleFactor = m_filterScale. This means the logicalSize
!= backendSize in this case.

We need to unify the coordinates system for both filters. We need also to
replace the three members by a single FloatSize called "m_filterScale".

* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
* platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:
(WebCore::FilterEffectRendererCoreImage::renderToImageBuffer):
(WebCore::FilterEffectRendererCoreImage::destRect const):
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::platformApplySoftware):
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::platformApplySoftware):
* platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::determineAbsolutePaintRect):
(WebCore::FEDropShadow::platformApplySoftware):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::platformApplySoftware):
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::determineAbsolutePaintRect):
(WebCore::FEMorphology::platformApplySoftware):
* platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::determineAbsolutePaintRect):
(WebCore::FEOffset::platformApplySoftware):
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::platformApplySoftware):
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::platformApplySoftware):
* platform/graphics/filters/Filter.h:
(WebCore::Filter::filterScale const):
(WebCore::Filter::setFilterScale):
(WebCore::Filter::sourceImageRect const):
(WebCore::Filter::setSourceImageRect):
(WebCore::Filter::filterRegion const):
(WebCore::Filter::setFilterRegion):
(WebCore::Filter::scaledByFilterScale const):
(WebCore::Filter::sourceImage):
(WebCore::Filter::setSourceImage):
(WebCore::Filter::Filter):
(WebCore::Filter::filterResolution const): Deleted.
(WebCore::Filter::setFilterResolution): Deleted.
(WebCore::Filter::absoluteTransform const): Deleted.
(WebCore::Filter::isSVGFilter const): Deleted.
(WebCore::Filter::isCSSFilter const): Deleted.
(WebCore::Filter::scaledByFilterResolution const): Deleted.
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::determineFilterPrimitiveSubregion):
(WebCore::FilterEffect::apply):
(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::unmultipliedResult):
(WebCore::FilterEffect::premultipliedResult):
(WebCore::FilterEffect::copyImageBytes const):
(WebCore::FilterEffect::convertPixelBufferToColorSpace):
(WebCore::FilterEffect::convertImageBufferToColorSpace):
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::determineAbsolutePaintRect):
* rendering/CSSFilter.cpp:
(WebCore::CSSFilter::create):
(WebCore::CSSFilter::CSSFilter):
(WebCore::CSSFilter::buildReferenceFilter):
(WebCore::CSSFilter::build):
(WebCore::CSSFilter::allocateBackingStoreIfNeeded):
(WebCore::CSSFilter::determineFilterPrimitiveSubregion):
(WebCore::CSSFilter::clearIntermediateResults):
(WebCore::CSSFilter::setSourceImageRect):
(WebCore::CSSFilter::outputRect const):
* rendering/CSSFilter.h:
* rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::buildFilter):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::platformApplySoftware):
* svg/graphics/filters/SVGFilter.cpp:
(WebCore::SVGFilter::SVGFilter):
(WebCor

[webkit-changes] [285596] branches/safari-612-branch/Source

[alancoon]

Title: [285596] branches/safari-612-branch/Source








Revision 285596
Author alanc...@apple.com
Date 2021-11-10 11:15:14 -0800 (Wed, 10 Nov 2021)


Log Message
Remove conflict files that should not have been checked in. rdar://problem/83430097

Removed Paths

branches/safari-612-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp.orig
branches/safari-612-branch/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm.orig




Diff

Deleted: branches/safari-612-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp.orig (285595 => 285596)

--- branches/safari-612-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp.orig	2021-11-10 19:15:12 UTC (rev 285595)
+++ branches/safari-612-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp.orig	2021-11-10 19:15:14 UTC (rev 285596)
@@ -1,336 +0,0 @@
-/*
- * Copyright (C) 2018 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "WebPreferencesDefaultValues.h"
-
-#include 
-#include 
-
-#if PLATFORM(COCOA)
-#include 
-#include 
-#include 
-#endif
-
-#if ENABLE(MEDIA_SESSION_COORDINATOR)
-#import 
-#endif
-
-namespace WebKit {
-
-#if !PLATFORM(COCOA)
-bool isFeatureFlagEnabled(const char*, bool defaultValue)
-{
-return defaultValue;
-}
-#endif
-
-#if PLATFORM(IOS_FAMILY)
-
-bool defaultPassiveTouchListenersAsDefaultOnDocument()
-{
-static bool result = linkedOnOrAfter(WebCore::SDKVersion::FirstThatDefaultsToPassiveTouchListenersOnDocument);
-return result;
-}
-
-bool defaultCSSOMViewScrollingAPIEnabled()
-{
-static bool result = WebCore::IOSApplication::isIMDb() && applicationSDKVersion() < DYLD_IOS_VERSION_13_0;
-return !result;
-}
-
-#endif
-
-#if PLATFORM(MAC)
-
-bool defaultPassiveWheelListenersAsDefaultOnDocument()
-{
-static bool result = linkedOnOrAfter(WebCore::SDKVersion::FirstThatDefaultsToPassiveWheelListenersOnDocument);
-return result;
-}
-
-bool defaultWheelEventGesturesBecomeNonBlocking()
-{
-static bool result = linkedOnOrAfter(WebCore::SDKVersion::FirstThatAllowsWheelEventGesturesToBecomeNonBlocking);
-return result;
-}
-
-#endif
-
-#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
-
-bool defaultDisallowSyncXHRDuringPageDismissalEnabled()
-{
-#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
-if (CFPreferencesGetAppBooleanValue(CFSTR("allowDeprecatedSynchronousXMLHttpRequestDuringUnload"), CFSTR("com.apple.WebKit"), nullptr)) {
-WTFLogAlways("Allowing synchronous XHR during page unload due to managed preference");
-return false;
-}
-#elif PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST) && !PLATFORM(WATCHOS)
-if (allowsDeprecatedSynchronousXMLHttpRequestDuringUnload()) {
-WTFLogAlways("Allowing synchronous XHR during page unload due to managed preference");
-return false;
-}
-#endif
-return true;
-}
-
-#endif
-
-#if PLATFORM(MAC)
-
-bool defaultAppleMailPaginationQuirkEnabled()
-{
-return WebCore::MacApplication::isAppleMail();
-}
-
-#endif
-
-static bool defaultAsyncFrameAndOverflowScrollingEnabled()
-{
-#if PLATFORM(IOS_FAMILY)
-return true;
-#endif
-
-#if PLATFORM(MAC)
-bool defaultValue = true;
-#else
-bool defaultValue = false;
-#endif
-
-return isFeatureFlagEnabled("async_frame_and_overflow_scrolling", defaultValue);
-}
-
-bool defaultAsyncFrameScrollingEnabled()
-{
-#if USE(NICOSIA)
-return true;
-#endif
-
-return defaultAsyncFrameAndOverflowScrollingEnabled();
-}
-
-bool defaultAsyncOverflowScrollingEnabled()
-{
-return defaultAsyncFrameAndOverflowScrollingEnabled();
-}
-
-bool defaultOfflineWebApplicationCacheEnabled()
-{
-#if PLATFORM(COCOA)
-static bool newSDK = linkedOnOrAfter(WebCore::SDKVe

[webkit-changes] [285595] branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/ios/ WebPageIOS.mm

[alancoon]

Title: [285595] branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm








Revision 285595
Author alanc...@apple.com
Date 2021-11-10 11:15:12 -0800 (Wed, 10 Nov 2021)


Log Message
Unreviewed build fix. rdar://83863266

Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2919:31: error: no member named 'userSelectIncludingInert' in 'WebCore::RenderStyle'

Modified Paths

branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (285594 => 285595)

--- branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2021-11-10 19:14:25 UTC (rev 285594)
+++ branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2021-11-10 19:15:12 UTC (rev 285595)
@@ -2916,7 +2916,7 @@
 auto* renderer = hitNode->renderer();
 
 info.selectability = ([&] {
-if (renderer->style().userSelectIncludingInert() == UserSelect::None)
+if (renderer->style().userSelect() == UserSelect::None)
 return InteractionInformationAtPosition::Selectability::UnselectableDueToUserSelectNone;
 
 if (is(*hitNode)) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285594] trunk

[cdumez]

Title: [285594] trunk








Revision 285594
Author cdu...@apple.com
Date 2021-11-10 11:14:25 -0800 (Wed, 10 Nov 2021)


Log Message
Add basic support for launching CaptivePortalMode WebProcesses
https://bugs.webkit.org/show_bug.cgi?id=232737


Reviewed by Brent Fulgham.

Source/WebKit:

Add new `WKWebpagePreferences.captivePortalModeEnabled` API to allow clients apps to opt in or
out of captive portal mode for each navigation (WKWebpagePreferences is passed with the navigation
policy decision). For setting the default state of this setting, the client can set
`WebWebViewConfiguration.defaultWebpagePreferences.captivePortalModeEnabled` (will impact all views
using this configuration).

Note that both this property can only be set by apps with the browser entitlement on iOS (no
restriction on macOS). On iOS, the default value of WKWebpagePreferences.captivePortalModeEnabled
depends on the corresponding system setting. For now, this is simulated by a NSUserDefault but it
will eventually come from somewhere else (TCC?).

Whenever transitioning in or out of captive portal mode, we process-swap on navigation policy
decision. Whenever captive portal mode is enabled, we turn off JIT, generational and concurrent GC
in the WebProcess, as soon as it launches.

Covered by new API tests.

* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
* UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::captivePortalModeEnabled const):
* UIProcess/API/APIPageConfiguration.h:
* UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::copy const):
(API::WebsitePolicies::captivePortalModeEnabled const):
* UIProcess/API/APIWebsitePolicies.h:
* UIProcess/API/Cocoa/WKWebpagePreferences.h:
* UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences setCaptivePortalModeEnabled:]):
(-[WKWebpagePreferences captivePortalModeEnabled]):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::captivePortalModeEnabledBySystem):
* UIProcess/Launcher/ProcessLauncher.h:
(WebKit::ProcessLauncher::Client::shouldEnableCaptivePortalMode const):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::findReusableSuspendedPageProcess):
* UIProcess/SuspendedPageProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcess):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):
(WebKit::WebPageProxy::isJITEnabled):
(WebKit::WebPageProxy::shouldEnableCaptivePortalMode const):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::takeProcess):
* UIProcess/WebProcessCache.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::tryTakePrewarmedProcess):
(WebKit::WebProcessPool::prewarmProcess):
(WebKit::WebProcessPool::processForRegistrableDomain):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):
(WebKit::captivePortalModeEnabledBySystem):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::createForServiceWorkers):
(WebKit::WebProcessProxy::WebProcessProxy):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::captivePortalMode const):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h
trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h
trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp
trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebProcessCache.cpp
trunk/Source/WebKit/UIProcess/WebProcessCache.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (285593 => 285594)

--- trunk/Source/WebKit/ChangeLog	2021-11-10 19:04:38

[webkit-changes] [285593] trunk/Source/WebKit

[pvollan]

Title: [285593] trunk/Source/WebKit








Revision 285593
Author pvol...@apple.com
Date 2021-11-10 11:04:38 -0800 (Wed, 10 Nov 2021)


Log Message
[iOS][GPUP] Remove sandbox read access to files
https://bugs.webkit.org/show_bug.cgi?id=232389


Reviewed by Brent Fulgham.

Based on telemetry, remove read access to files in the GPU process' sandbox on iOS.
This patch also adds some new telemetry for rules related to reading of files.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (285592 => 285593)

--- trunk/Source/WebKit/ChangeLog	2021-11-10 18:54:59 UTC (rev 285592)
+++ trunk/Source/WebKit/ChangeLog	2021-11-10 19:04:38 UTC (rev 285593)
@@ -1,3 +1,16 @@
+2021-11-10  Per Arne Vollan 
+
+[iOS][GPUP] Remove sandbox read access to files
+https://bugs.webkit.org/show_bug.cgi?id=232389
+
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, remove read access to files in the GPU process' sandbox on iOS.
+This patch also adds some new telemetry for rules related to reading of files.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
 2021-11-10  Darin Adler  
 
 [CF] Reduce duplication and unneeded buffer allocations and copying in URL code, also remove unused methods and functions


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (285592 => 285593)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-10 18:54:59 UTC (rev 285592)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-10 19:04:38 UTC (rev 285593)
@@ -45,16 +45,6 @@
 (extension-class "com.apple.app-sandbox.read")
 (apply require-any filters
 
-(define-once (allow-read-write-and-issue-generic-extensions . filters)
-(allow file-read* file-write* (with telemetry)
-   (apply require-any filters))
-(allow file-read-metadata
-   (apply require-any filters))
-(allow file-issue-extension
-(require-all
-(extension-class "com.apple.app-sandbox.read-write" "com.apple.app-sandbox.read")
-(apply require-any filters
-
 (define-once (managed-configuration-read-public)
 (allow file-read* (with telemetry)
(well-known-system-group-container-subpath "/systemgroup.com.apple.configurationprofiles/Library/ConfigurationProfiles/PublicInfo")
@@ -61,22 +51,6 @@
(front-user-home-subpath "/Library/ConfigurationProfiles/PublicInfo")
(front-user-home-subpath "/Library/UserConfigurationProfiles/PublicInfo")))
 
-(define-once (managed-configuration-read . files)
-(if (null? files)
-(allow file-read* (with telemetry)
-   (well-known-system-group-container-subpath "/systemgroup.com.apple.configurationprofiles/Library/ConfigurationProfiles")
-   (front-user-home-subpath "/Library/ConfigurationProfiles")
-   (front-user-home-subpath "/Library/UserConfigurationProfiles"))
-(for-each
-(lambda (file)
-(allow file-read* (with telemetry)
-(well-known-system-group-container-literal
-(string-append "/systemgroup.com.apple.configurationprofiles/Library/ConfigurationProfiles/" file))
-(front-user-home-literal
-(string-append "/Library/ConfigurationProfiles/" file)
-(string-append "/Library/UserConfigurationProfiles/" file
-files)))
-
 (define-once (allow-preferences-common)
 (allow file-read-metadata
(home-literal "")
@@ -115,7 +89,6 @@
   (extension "com.apple.assets.read"
 ;; 
 ;; 
-(allow file-read* (with telemetry) asset-access-filter)
 (if (memq 'with-media-playback options)
 (play-media asset-access-filter
 
@@ -171,7 +144,7 @@
 )
 
 ;; AVF needs to see these network preferences:
-(allow file-read* (with telemetry)
+(allow file-read*
 (literal "/private/var/preferences/com.apple.networkd.plist"))
 
 ;; Required by the MediaPlayer framework.
@@ -231,12 +204,6 @@
 ;; 
 (mobile-preferences-read "com.apple.mediaaccessibility"))
 
-(define-once (url-translation)
-;; For translating http:// & https:// URLs referencing itms:// URLs.
-;; 
-(allow file-read* (with telemetry)
-   (home-literal "/Library/Caches/com.apple.itunesstored/url-resolution.plist")))
-
 ;;;
 ;;; Declare that the application uses the OpenGL, Metal, and CoreML hardware & frameworks.
 ;;;
@@ -314,10 +281,6 @@
 (deny file-read* file-write*
   (vnode-type BLOCK-DEVICE CHARACTER-DEVICE))
 
-(allow file-read* file-write-data (with telemetry)
-   (literal "/dev/null")
-   (lit

[webkit-changes] [285592] trunk

[sbarati]

Title: [285592] trunk








Revision 285592
Author sbar...@apple.com
Date 2021-11-10 10:54:59 -0800 (Wed, 10 Nov 2021)


Log Message
in_by_val should not constant fold to in_by_id when the property is a property index
https://bugs.webkit.org/show_bug.cgi?id=232753

Reviewed by Yusuke Suzuki.

JSTests:

* stress/dont-in-by-id-when-index-2.js: Added.
(assert):
(main.v179):
(main.async v244):
(main):
* stress/dont-in-by-id-when-index.js: Added.
(assert):
(test):

Source/_javascript_Core:

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* dfg/DFGValidate.cpp:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGValidate.cpp


Added Paths

trunk/JSTests/stress/dont-in-by-id-when-index-2.js
trunk/JSTests/stress/dont-in-by-id-when-index.js




Diff

Modified: trunk/JSTests/ChangeLog (285591 => 285592)

--- trunk/JSTests/ChangeLog	2021-11-10 18:46:31 UTC (rev 285591)
+++ trunk/JSTests/ChangeLog	2021-11-10 18:54:59 UTC (rev 285592)
@@ -1,3 +1,19 @@
+2021-11-10  Saam Barati  
+
+in_by_val should not constant fold to in_by_id when the property is a property index
+https://bugs.webkit.org/show_bug.cgi?id=232753
+
+Reviewed by Yusuke Suzuki.
+
+* stress/dont-in-by-id-when-index-2.js: Added.
+(assert):
+(main.v179):
+(main.async v244):
+(main):
+* stress/dont-in-by-id-when-index.js: Added.
+(assert):
+(test):
+
 2021-11-10  Xan Lopez  
 
 [JSC][32bit] Unskip JSTests/stress/json-stringify-string-builder-overflow.js


Added: trunk/JSTests/stress/dont-in-by-id-when-index-2.js (0 => 285592)

--- trunk/JSTests/stress/dont-in-by-id-when-index-2.js	(rev 0)
+++ trunk/JSTests/stress/dont-in-by-id-when-index-2.js	2021-11-10 18:54:59 UTC (rev 285592)
@@ -0,0 +1,37 @@
+//@ runDefault("--validateOptions=true", "--useConcurrentJIT=false", "--useConcurrentGC=false", "--thresholdForJITSoon=10", "--thresholdForJITAfterWarmUp=10", "--thresholdForOptimizeAfterWarmUp=100", "--thresholdForOptimizeAfterLongWarmUp=100", "--thresholdForOptimizeSoon=100", "--thresholdForFTLOptimizeAfterWarmUp=1000", "--thresholdForFTLOptimizeSoon=1000", "--validateBCE=true", "--useFTLJIT=0")
+
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+function main() {
+let v249;
+
+const v178 = [];
+
+v179 = class V179 {
+constructor(v181,v182,v183) {
+}
+};
+
+const v195 = [v178,v179,1];
+const v203 = {};
+const v204 = [v179,v195];
+const v205 = v204.toLocaleString();
+
+for (const v223 of v205) {
+const v232 = {};
+v232[v223] = "number";
+
+async function v244() {
+v249 = "1" in v232;
+const v250 = 0;
+}
+v244();
+}
+
+assert(v249 === true);
+}
+
+main();


Added: trunk/JSTests/stress/dont-in-by-id-when-index.js (0 => 285592)

--- trunk/JSTests/stress/dont-in-by-id-when-index.js	(rev 0)
+++ trunk/JSTests/stress/dont-in-by-id-when-index.js	2021-11-10 18:54:59 UTC (rev 285592)
@@ -0,0 +1,15 @@
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+function test(obj) {
+return "1" in obj;
+}
+noInline(test);
+
+let o = [10, {}];
+
+for (let i = 0; i < 1; ++i) {
+assert(test(o) === true);
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (285591 => 285592)

--- trunk/Source/_javascript_Core/ChangeLog	2021-11-10 18:46:31 UTC (rev 285591)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-11-10 18:54:59 UTC (rev 285592)
@@ -1,3 +1,16 @@
+2021-11-10  Saam Barati  
+
+in_by_val should not constant fold to in_by_id when the property is a property index
+https://bugs.webkit.org/show_bug.cgi?id=232753
+
+Reviewed by Yusuke Suzuki.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+* dfg/DFGConstantFoldingPhase.cpp:
+(JSC::DFG::ConstantFoldingPhase::foldConstants):
+* dfg/DFGValidate.cpp:
+
 2021-11-09  Commit Queue  
 
 Unreviewed, reverting r285246.


Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (285591 => 285592)

--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2021-11-10 18:46:31 UTC (rev 285591)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2021-11-10 18:54:59 UTC (rev 285592)
@@ -4248,7 +4248,7 @@
 if (JSValue constant = property.value()) {
 if (constant.isString()) {
 JSString* string = asString(constant);
-if (CacheableIdentifier::isCacheableIdentifierCell(string))
+if (CacheableIdentifier::isCache

[webkit-changes] [285591] trunk/LayoutTests

[commit-queue]

Title: [285591] trunk/LayoutTests








Revision 285591
Author commit-qu...@webkit.org
Date 2021-11-10 10:46:31 -0800 (Wed, 10 Nov 2021)


Log Message
[JSC][ARMv7] Unskip LayoutTests/js/script-tests/stack-overflow-regexp.js
https://bugs.webkit.org/show_bug.cgi?id=232945

Unreviewed gardening.

This test no longer seems flaky on ARMv7. Remove architecture specific
skip condition.

Patch by Geza Lore  on 2021-11-10

* js/script-tests/stack-overflow-regexp.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/stack-overflow-regexp.js




Diff

Modified: trunk/LayoutTests/ChangeLog (285590 => 285591)

--- trunk/LayoutTests/ChangeLog	2021-11-10 18:45:19 UTC (rev 285590)
+++ trunk/LayoutTests/ChangeLog	2021-11-10 18:46:31 UTC (rev 285591)
@@ -1,3 +1,15 @@
+2021-11-10  Geza Lore  
+
+[JSC][ARMv7] Unskip LayoutTests/js/script-tests/stack-overflow-regexp.js
+https://bugs.webkit.org/show_bug.cgi?id=232945
+
+Unreviewed gardening.
+
+This test no longer seems flaky on ARMv7. Remove architecture specific
+skip condition.
+
+* js/script-tests/stack-overflow-regexp.js:
+
 2021-11-10  Tyler Wilcock  
 
 AX: Make ancestor computation cheaper by setting flags upon child insertion


Modified: trunk/LayoutTests/js/script-tests/stack-overflow-regexp.js (285590 => 285591)

--- trunk/LayoutTests/js/script-tests/stack-overflow-regexp.js	2021-11-10 18:45:19 UTC (rev 285590)
+++ trunk/LayoutTests/js/script-tests/stack-overflow-regexp.js	2021-11-10 18:46:31 UTC (rev 285591)
@@ -1,5 +1,4 @@
-// https://bugs.webkit.org/show_bug.cgi?id=190755
-//@ skip if ($architecture == "arm" and $hostOS == "linux") || $memoryLimited
+//@ skip if $memoryLimited
 //  
 description('Test that we do not overflow the stack while handling regular expressions');
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285590] trunk/PerformanceTests

[ysuzuki]

Title: [285590] trunk/PerformanceTests








Revision 285590
Author ysuz...@apple.com
Date 2021-11-10 10:45:19 -0800 (Wed, 10 Nov 2021)


Log Message
Unreviewed, fix broken test
https://bugs.webkit.org/show_bug.cgi?id=232949

useGrouping: 'false' is no longer allowed according to the spec.

* Intl/numberformat-format-all-options.html:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Intl/numberformat-format-all-options.html




Diff

Modified: trunk/PerformanceTests/ChangeLog (285589 => 285590)

--- trunk/PerformanceTests/ChangeLog	2021-11-10 18:43:54 UTC (rev 285589)
+++ trunk/PerformanceTests/ChangeLog	2021-11-10 18:45:19 UTC (rev 285590)
@@ -1,3 +1,12 @@
+2021-11-10  Yusuke Suzuki  
+
+Unreviewed, fix broken test
+https://bugs.webkit.org/show_bug.cgi?id=232949
+
+useGrouping: 'false' is no longer allowed according to the spec.
+
+* Intl/numberformat-format-all-options.html:
+
 2021-10-14  Myles C. Maxfield  
 
 All the SDKVariant.xcconfig files should match


Modified: trunk/PerformanceTests/Intl/numberformat-format-all-options.html (285589 => 285590)

--- trunk/PerformanceTests/Intl/numberformat-format-all-options.html	2021-11-10 18:43:54 UTC (rev 285589)
+++ trunk/PerformanceTests/Intl/numberformat-format-all-options.html	2021-11-10 18:45:19 UTC (rev 285590)
@@ -8,7 +8,7 @@
 style: 'currency',
 currency: 'AUD',
 currencyDisplay: 'name',
-useGrouping: 'false',
+useGrouping: true,
 minimumIntegerDigits: 2,
 minimumFractionDigits: 2,
 maximumFractionDigits: 2
@@ -21,4 +21,4 @@
 format.format(count++);
 }});
 
-
\ No newline at end of file
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285588] trunk

[darin]

Title: [285588] trunk








Revision 285588
Author da...@apple.com
Date 2021-11-10 09:55:40 -0800 (Wed, 10 Nov 2021)


Log Message
[CF] Reduce duplication and unneeded buffer allocations and copying in URL code, also remove unused methods and functions
https://bugs.webkit.org/show_bug.cgi?id=232220

Reviewed by Alex Christensen.

Source/WebKit:

* Shared/API/c/cf/WKURLCF.mm:
(WKURLCreateWithCFURL): Use bytesAsString, saving creation and destruction
of a CString each time this is called.

* Shared/Cocoa/ArgumentCodersCocoa.mm:
(-[WKSecureCodingURLWrapper encodeWithCoder:]): Use bytesAsVector.

* Shared/Cocoa/WKNSURLExtras.h: Removed unused methods
+[NSURL _web_URLWithWTFString:relativeToURL:] and
-[NSURL _web_originalDataAsWTFString].

* Shared/Cocoa/WKNSURLExtras.mm:
(+[NSURL _web_URLWithWTFString:relativeToURL:]): Deleted.
(-[NSURL _web_originalDataAsWTFString]): Deleted.

* Shared/Cocoa/WKNSURLRequest.mm:
(-[WKNSURLRequest URL]): Removed unneeded call to +[NSURL _web_URLWithWTFString:]
because this code is converting a WTF::URL to an NSURL, which can use the conversion
operator in the WTF::URL class.

* Shared/cf/ArgumentCodersCF.cpp:
(IPC::ArgumentCoder::encode): Use bytesAsVector.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]):
Use bytesAsString and bridge_cast.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]): Ditto.
(setUpPagePolicyClient): Removed unneeded call to +[NSURL _web_URLWithWTFString:]
because this code is converting a WTF::URL to an NSURL, which can use the conversion
operator in the WTF::URL class.

* UIProcess/Cocoa/LegacyDownloadClient.mm:
(WebKit::LegacyDownloadClient::willSendRequest): Removed unneeded call to
+[NSURL _web_URLWithWTFString:] because this code is converting a WTF::URL to an NSURL,
which can use the conversion operator in the WTF::URL class.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame URL]): Ditto.

Source/WebKitLegacy/mac:

* Misc/WebNSURLExtras.h: Tweaked comments a bit. No need to say methods are "new", since
that won't be true in the future. Removed unused methods
+[NSURL _web_URLWithUserTypedString:relativeToURL:],
+[NSURL _webkit_URLWithUserTypedString:relativeToURL:],
+[NSURL _web_URLWithData:], +[NSURL _web_URLWithData:relatveToURL:].
Wanted to remove even more nearly unused methods: many were used only
inside the WebKit project, in legacy plug-in code, and some seemed unused,
but it wasn't easy for me to quickly verify that.

* Misc/WebNSURLExtras.mm: Removed "using namespace WebCore" and
"using namespace WTF".
(+[NSURL _web_URLWithUserTypedString:relativeToURL:]): Deleted.
(+[NSURL _web_URLWithUserTypedString:]): Use WTF prefix explicitly.
(+[NSURL _webkit_URLWithUserTypedString:relativeToURL:]): Deleted.
(+[NSURL _webkit_URLWithUserTypedString:]): Use WTF prefix explicitly.
(+[NSURL _web_URLWithDataAsString:]): Removed special case for nil since the code
will do the right thing with nil without an explicit check.
(+[NSURL _web_URLWithDataAsString:relativeToURL]): Ditto. Also formatted the code
as a one-liner.
(+[NSURL _web_URLWithData:]): Deleted.
(+[NSURL _web_URLWithData:relativeToURL:]): Deleted.
(-[NSURL _web_originalData]): Use WTF prefix explicitly.
(-[NSURL _web_originalDataAsString]): Ditto.
(-[NSURL _web_isEmpty]): Use bridge_cast and make code style checker happy by using
"!" instead of "== 0".
(-[NSURL _web_URLCString]): Use WTF prefix explicitly.
(-[NSURL _webkit_canonicalize]): Use WebCore prefix explicitly.
(-[NSURL _webkit_URLByRemovingFragment]): Use WTF prefix explicitly.
(-[NSURL _web_schemeSeparatorWithoutColon]): Deleted.
(-[NSURL _web_dataForURLComponentType:]): Deleted.
(-[NSURL _web_hostData]): Use WTF prefix explicitly. Rearranged for clarity and
slightly improved efficiency as well.
(-[NSString _web_isUserVisibleURL]): Use WTF prefix explicitly.
(-[NSString _webkit_stringByReplacingValidPercentEscapes]): Use WebCore prefix
explicitly.
(-[NSString _web_decodeHostName]): Use WTF prefix explicitly.
(-[NSString _web_encodeHostName]): Ditto.
(-[NSString _webkit_decodeHostName]): Ditto.
(-[NSString _webkit_encodeHostName]): Ditto.

Source/WTF:

* wtf/URL.h: Removed unneeded includes. Use default instead of { }
for empty destructor. Added emptyCFURL function.

* wtf/cf/CFURLExtras.cpp:
(WTF::bytesAsCFData): Added. Replaces originalURLData from NSURLExtras.mm,
but with a simpler implementation and more error checking. Here it's also
alongside the other nearly identical functions.
(WTF::bytesAsString): Added. Replaces getURLBytes for callers that are
going to turn the bytes into a WTF::String. Before this patch, the callers
were converting from CFURLRef to WTF::CString and then to WTF::String, so
this eliminates the malloc/free pair for CString.
(WTF::bytesAsVector): Added. Replaces getURLBytes using

[webkit-changes] [285587] trunk/Source/WebCore

[cdumez]

Title: [285587] trunk/Source/WebCore








Revision 285587
Author cdu...@apple.com
Date 2021-11-10 09:51:15 -0800 (Wed, 10 Nov 2021)


Log Message
imported/w3c/web-platform-tests/webmessaging/broadcastchannel/workers.html is flaky crashing in debug
https://bugs.webkit.org/show_bug.cgi?id=232920

Reviewed by Alex Christensen.

When WorkerGlobalScope::postTask() gets called, the task may get destroyed on the worker thread, without
getting executed in the case where the worker thread is about to exit. This was causing trouble in
BroadcastChannel::dispatchMessageTo() where we were calling WorkerGlobalScope::postTask() and capturing
a CallbackAggregator. We were relying on the task actually executing to dispatch the CallbackAggregator
back to the maint thread so that the completion handler is always called on the main thread.

To address the issue, we now capture a WTF::ScopeExit which calls the completion handler on the main
thread upon destruction. This way, the completion handler will always get called on the main thread,
no matter what.

* dom/BroadcastChannel.cpp:
(WebCore::BroadcastChannel::dispatchMessageTo):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/BroadcastChannel.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285586 => 285587)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 17:42:35 UTC (rev 285586)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 17:51:15 UTC (rev 285587)
@@ -1,3 +1,23 @@
+2021-11-10  Chris Dumez  
+
+imported/w3c/web-platform-tests/webmessaging/broadcastchannel/workers.html is flaky crashing in debug
+https://bugs.webkit.org/show_bug.cgi?id=232920
+
+Reviewed by Alex Christensen.
+
+When WorkerGlobalScope::postTask() gets called, the task may get destroyed on the worker thread, without
+getting executed in the case where the worker thread is about to exit. This was causing trouble in
+BroadcastChannel::dispatchMessageTo() where we were calling WorkerGlobalScope::postTask() and capturing
+a CallbackAggregator. We were relying on the task actually executing to dispatch the CallbackAggregator
+back to the maint thread so that the completion handler is always called on the main thread.
+
+To address the issue, we now capture a WTF::ScopeExit which calls the completion handler on the main
+thread upon destruction. This way, the completion handler will always get called on the main thread,
+no matter what.
+
+* dom/BroadcastChannel.cpp:
+(WebCore::BroadcastChannel::dispatchMessageTo):
+
 2021-11-10  Enrique Ocaña González  
 
 [GTK] Layout Test media/video-seek-with-negative-playback.html timeouts on the release bot.


Modified: trunk/Source/WebCore/dom/BroadcastChannel.cpp (285586 => 285587)

--- trunk/Source/WebCore/dom/BroadcastChannel.cpp	2021-11-10 17:42:35 UTC (rev 285586)
+++ trunk/Source/WebCore/dom/BroadcastChannel.cpp	2021-11-10 17:51:15 UTC (rev 285587)
@@ -38,6 +38,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace WebCore {
 
@@ -208,12 +209,15 @@
 void BroadcastChannel::dispatchMessageTo(BroadcastChannelIdentifier channelIdentifier, Ref&& message, CompletionHandler&& completionHandler)
 {
 ASSERT(isMainThread());
+auto completionHandlerCallingScope = makeScopeExit([completionHandler = WTFMove(completionHandler)]() mutable {
+callOnMainThread(WTFMove(completionHandler));
+});
+
 auto contextIdentifier = channelToContextIdentifier().get(channelIdentifier);
 if (!contextIdentifier)
-return completionHandler();
+return;
 
-auto callbackAggregator = CallbackAggregator::create(WTFMove(completionHandler));
-ScriptExecutionContext::ensureOnContextThread(contextIdentifier, [channelIdentifier, message = WTFMove(message), callbackAggregator = WTFMove(callbackAggregator)](auto&) mutable {
+ScriptExecutionContext::ensureOnContextThread(contextIdentifier, [channelIdentifier, message = WTFMove(message), completionHandlerCallingScope = WTFMove(completionHandlerCallingScope)](auto&) mutable {
 RefPtr channel;
 {
 Locker locker { allBroadcastChannelsLock };
@@ -221,8 +225,6 @@
 }
 if (channel)
 channel->dispatchMessage(WTFMove(message));
-
-callOnMainThread([callbackAggregator = WTFMove(callbackAggregator)] { });
 });
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285586] trunk

[eocanha]

Title: [285586] trunk








Revision 285586
Author eoca...@igalia.com
Date 2021-11-10 09:42:35 -0800 (Wed, 10 Nov 2021)


Log Message
[GTK] Layout Test media/video-seek-with-negative-playback.html timeouts on the release bot.
https://bugs.webkit.org/show_bug.cgi?id=135086

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

In some specific cases, an EOS GstEvent can happen right before a seek. The event is translated
by playbin as an EOS GstMessage and posted to the bus, waiting to be forwarded to the main thread.
The EOS message (now irrelevant after the seek) is received and processed right after the seek,
causing the termination of the media at the player private and upper levels. This can even happen
after the seek has completed (m_isSeeking already false).

This patch detects that condition by ensuring that the playback is coherent with the EOS message,
that is, if we're still playing somewhere inside the playable ranges, there should be no EOS at
all. If that's the case, it's considered to be one of those spureous EOS and is ignored.

Live streams (infinite duration) are special and we still have to detect legitimate EOS there, so
this message bailout isn't done in those cases.

Also refactored the code that queries the position to the sinks.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Ignore EOS message if the playback position is inside the playback limits when they're finite. Refactored sink position query code as gstreamerPositionFromSinks().
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Added gstreamerPositionFromSinks().

LayoutTests:

* platform/glib/TestExpectations: Unskipped test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h




Diff

Modified: trunk/LayoutTests/ChangeLog (285585 => 285586)

--- trunk/LayoutTests/ChangeLog	2021-11-10 17:41:49 UTC (rev 285585)
+++ trunk/LayoutTests/ChangeLog	2021-11-10 17:42:35 UTC (rev 285586)
@@ -1,3 +1,12 @@
+2021-11-10  Enrique Ocaña González  
+
+[GTK] Layout Test media/video-seek-with-negative-playback.html timeouts on the release bot.
+https://bugs.webkit.org/show_bug.cgi?id=135086
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+* platform/glib/TestExpectations: Unskipped test.
+
 2021-11-10  Rob Buis  
 
 [css-contain] Support contain:paint


Modified: trunk/LayoutTests/platform/glib/TestExpectations (285585 => 285586)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-11-10 17:41:49 UTC (rev 285585)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-11-10 17:42:35 UTC (rev 285586)
@@ -2341,7 +2341,6 @@
 
 webkit.org/b/108925 http/tests/media/video-play-stall.html [ Failure Timeout ]
 
-webkit.org/b/135086 media/video-seek-with-negative-playback.html [ Timeout Pass ]
 webkit.org/b/137698 media/video-controls-drag.html [ Timeout ]
 webkit.org/b/141959 http/tests/media/clearkey/clear-key-hls-aes128.html [ Crash Timeout ]
 webkit.org/b/142489 http/tests/media/video-play-waiting.html [ Timeout ]


Modified: trunk/Source/WebCore/ChangeLog (285585 => 285586)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 17:41:49 UTC (rev 285585)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 17:42:35 UTC (rev 285586)
@@ -1,3 +1,28 @@
+2021-11-10  Enrique Ocaña González  
+
+[GTK] Layout Test media/video-seek-with-negative-playback.html timeouts on the release bot.
+https://bugs.webkit.org/show_bug.cgi?id=135086
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+In some specific cases, an EOS GstEvent can happen right before a seek. The event is translated
+by playbin as an EOS GstMessage and posted to the bus, waiting to be forwarded to the main thread.
+The EOS message (now irrelevant after the seek) is received and processed right after the seek,
+causing the termination of the media at the player private and upper levels. This can even happen
+after the seek has completed (m_isSeeking already false).
+
+This patch detects that condition by ensuring that the playback is coherent with the EOS message,
+that is, if we're still playing somewhere inside the playable ranges, there should be no EOS at
+all. If that's the case, it's considered to be one of those spureous EOS and is ignored.
+
+Live streams (infinite duration) are special and we still have to detect legitimate EOS there, so
+this message bailout isn't done in those cases.
+
+Also refactored the code that queries the position to the sinks.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Ignore EOS message if the playback position is inside the playback limits when they're finite. Refactored sink position query code as gstreamerPositionFromSinks().
+* pl

[webkit-changes] [285585] trunk/Source/WebKit

[commit-queue]

Title: [285585] trunk/Source/WebKit








Revision 285585
Author commit-qu...@webkit.org
Date 2021-11-10 09:41:49 -0800 (Wed, 10 Nov 2021)


Log Message
[macOS] Unable to build WebKit with multiple users in the same machine, webpushd uses /tmp/WebKit.dst
https://bugs.webkit.org/show_bug.cgi?id=232940

Patch by Alex Christensen  on 2021-11-10
Reviewed by Alexey Proskuryakov.

* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (285584 => 285585)

--- trunk/Source/WebKit/ChangeLog	2021-11-10 17:32:43 UTC (rev 285584)
+++ trunk/Source/WebKit/ChangeLog	2021-11-10 17:41:49 UTC (rev 285585)
@@ -1,3 +1,12 @@
+2021-11-10  Alex Christensen  
+
+[macOS] Unable to build WebKit with multiple users in the same machine, webpushd uses /tmp/WebKit.dst
+https://bugs.webkit.org/show_bug.cgi?id=232940
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.xcodeproj/project.pbxproj:
+
 2021-11-10  Jer Noble  
 
 [iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (285584 => 285585)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2021-11-10 17:32:43 UTC (rev 285584)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2021-11-10 17:41:49 UTC (rev 285585)
@@ -13999,7 +13999,7 @@
 		};
 		DFD03A29270D5F57001A996E /* Copy Daemon Plists */ = {
 			isa = PBXShellScriptBuildPhase;
-			buildActionMask = 12;
+			buildActionMask = 8;
 			files = (
 			);
 			inputFileListPaths = (
@@ -14013,7 +14013,7 @@
 			outputPaths = (
 "$(DSTROOT)/System/Library/LaunchDaemons/com.apple.webkit.adattributiond.plist",
 			);
-			runOnlyForDeploymentPostprocessing = 0;
+			runOnlyForDeploymentPostprocessing = 1;
 			shellPath = /bin/sh;
 			shellScript = "if [[ \"${WK_PLATFORM_NAME}\" == iphoneos ]]; then\nADATTRIBUTIOND_PLIST_SOURCE=\"${SRCROOT}/Shared/EntryPointUtilities/Cocoa/Daemon/com.apple.webkit.adattributiond.plist\"\nADATTRIBUTIOND_PLIST_DESTINATION=\"${DSTROOT}/System/Library/LaunchDaemons/com.apple.webkit.adattributiond.plist\"\necho \"copying adattributiond plist\"\necho plutil -convert binary1 -o \"${ADATTRIBUTIOND_PLIST_DESTINATION}\" \"${ADATTRIBUTIOND_PLIST_SOURCE}\"\nplutil -convert binary1 -o \"${ADATTRIBUTIOND_PLIST_DESTINATION}\" \"${ADATTRIBUTIOND_PLIST_SOURCE}\"\nelse\necho \"not copying adattributiond plist\"\nfi\n\nif [[ \"${WK_PLATFORM_NAME}\" == iphoneos || \"${WK_PLATFORM_NAME}\" == macosx ]]; then\nWEBPUSHD_PLIST_SOURCE=\"${SRCROOT}/webpushd/com.apple.webkit.webpushd.plist\"\nWEBPUSHD_PLIST_DESTINATION=\"$
 {DSTROOT}/System/Library/LaunchDaemons/com.apple.webkit.webpushd.plist\"\necho \"copying webpushd plist\"\necho plutil -convert binary1 -o \"${WEBPUSHD_PLIST_DESTINATION}\" \"${WEBPUSHD_PLIST_SOURCE}\"\nplutil -convert binary1 -o \"${WEBPUSHD_PLIST_DESTINATION}\" \"${WEBPUSHD_PLIST_SOURCE}\"\nelse\necho \"not copying webpushd plist\"\nfi\n";
 		};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285584] trunk/Source

[jer . noble]

Title: [285584] trunk/Source








Revision 285584
Author jer.no...@apple.com
Date 2021-11-10 09:32:43 -0800 (Wed, 10 Nov 2021)


Log Message
[iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
https://bugs.webkit.org/show_bug.cgi?id=232909


Reviewed by Eric Carlson.

Source/WebCore:

* platform/audio/AudioSession.h:
* platform/audio/ios/AudioSessionIOS.h:
* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSessionIOS::setPresentingProcesses):

Source/WebCore/PAL:

* pal/spi/cocoa/AVFoundationSPI.h:

Source/WebKit:

When a page is loaded through SafariViewService, the UIProcess is SVS, but the "presenting"
application is the client of SafariViewController. To further compliate things, multiple apps
all using a SafariViewController will use a singleton SafariViewService application. When such
an application goes to the background while playing audio, the audio subsystem will keep the
UIProcess from suspending, but not the presenting application. The audio subsystem will see
that the presenting application has become suspended, and will interrupt audio playback.

Opt into a AVAudioSession behavior where a client can provide an array of audit tokens for
those processes which are "presenting" the audio playback to the user. This will include the
UIProcess, but also the process which is hosting the SafariViewController. The audio subsystem
will keep the processes in that list from becoming suspended during audio playback.

Since there may be different clients of SafariViewService existing simultaneously, only include
those presenting application tokens whose WebContent processes require an "active" audio session.

* GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
* GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::presentingApplicationAuditToken const):
* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::audioSessionManager const):
* GPUProcess/media/RemoteAudioSessionProxy.cpp:
(WebKit::RemoteAudioSessionProxy::tryToSetActive):
* GPUProcess/media/RemoteAudioSessionProxy.h:
(WebKit::RemoteAudioSessionProxy::gpuConnectionToWebProcess const):
* GPUProcess/media/RemoteAudioSessionProxyManager.cpp:
(WebKit::RemoteAudioSessionProxyManager::RemoteAudioSessionProxyManager):
(WebKit::RemoteAudioSessionProxyManager::updatePresentingProcesses):
* GPUProcess/media/RemoteAudioSessionProxyManager.h:
* Scripts/process-entitlements.sh:
* Shared/GPUProcessConnectionParameters.h:
(WebKit::GPUProcessConnectionParameters::encode const):
(WebKit::GPUProcessConnectionParameters::decode):
* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
* UIProcess/API/APIProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration setPresentingApplicationProcessToken:]):
(-[_WKProcessPoolConfiguration presentingApplicationProcessToken]):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getGPUProcessConnection):
* WebProcess/GPU/GPUProcessConnection.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h
trunk/Source/WebCore/platform/audio/AudioSession.h
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.h
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h
trunk/Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.h
trunk/Source/WebKit/Scripts/process-entitlements.sh
trunk/Source/WebKit/Shared/GPUProcessConnectionParameters.h
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnection.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285583 => 285584)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 17:24:42 UTC (rev 285583)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 17:32:43 UTC (rev 285584)
@@ -1,3 +1,16 @@
+2021-11-10  Jer Noble  
+
+[iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
+https://bugs.webkit.org/show_bug.cgi?id=232909
+
+
+Reviewed by Eric Carlson.
+
+* platform/audio/AudioSession.h:
+* platform/audio/ios/AudioSessionIOS.h:
+* platform/audio/ios/AudioSessionIOS.mm:
+(WebCore::AudioSessionIOS::setPr

[webkit-changes] [285583] trunk

[commit-queue]

Title: [285583] trunk








Revision 285583
Author commit-qu...@webkit.org
Date 2021-11-10 09:24:42 -0800 (Wed, 10 Nov 2021)


Log Message
[css-contain] Support contain:paint
https://bugs.webkit.org/show_bug.cgi?id=224742

Patch by Rob Buis  on 2021-11-10
Reviewed by Alan Bujtas.

LayoutTests/imported/w3c:

Adjust test expectation now that contain: strict is supported.

* web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt:

Source/WebCore:

This patch implements paint containment as specified[1].

It adds shouldApplyPaintContainment to check whether the element applies for paint containment. Is so, then:
- an independent formatting context is established.
- an absolute positioning and fixed positioning containing block is established.
- a stacking context is created.
- implements clipping on the overflow clip edge.

This patch also adds effectiveOverflowX/effectiveOverflowY on RenderElement to take
the effect of paint containment on overflow-x/y into account.

[1] https://drafts.csswg.org/css-contain-2/#paint-containment

* page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::applyPaginationToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const):
(WebCore::RenderBox::constrainLogicalHeightByMinMax const):
(WebCore::RenderBox::createsNewFormattingContext const):
(WebCore::RenderBox::addOverflowFromChild):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::updateFromStyle):
* rendering/RenderElement.cpp:
(WebCore::includeNonFixedHeight):
(WebCore::RenderElement::effectiveOverflowX const):
(WebCore::RenderElement::effectiveOverflowY const):
* rendering/RenderElement.h:
(WebCore::RenderElement::effectiveOverflowInlineDirection const):
(WebCore::RenderElement::effectiveOverflowBlockDirection const):
(WebCore::RenderElement::canContainFixedPositionObjects const):
(WebCore::RenderElement::canContainAbsolutelyPositionedObjects const):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisOverflowForChild const):
(WebCore::RenderFlexibleBox::crossAxisOverflowForChild const):
* rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::overflowRectForFragmentedFlowPortion):
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
(WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant):
(WebCore::RenderLayer::setAncestorChainHasVisibleDescendant):
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setPaintContainmentApplies):
(WebCore::shouldApplyPaintContainment):
* rendering/RenderObject.h:
(WebCore::RenderObject::paintContainmentApplies const):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::overflowY const):
(WebCore::RenderStyle::containsPaint const):
(WebCore::RenderStyle::overflowInlineDirection const): Deleted.
(WebCore::RenderStyle::overflowBlockDirection const): Deleted.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::shouldApplyViewportClip const):

LayoutTests:

Unskip tests that pass now.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFragmentContainer.cpp
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (285582 => 285583)

--- trunk/LayoutTests/ChangeLog	2021-11-10 17:15:29 UTC (rev 285582)
+++ trunk/LayoutTests/ChangeLog	2021-11-10 17:24:42 UTC (rev 285583)
@@ -1,3 +1,14 @@
+2021-11-10  Rob Buis  
+
+[css-contain] Support contain:paint
+https://bugs.webkit.org/show_bug.cgi?id=224742
+
+Reviewed by Alan Bujtas.
+
+Unskip tests that pass now.
+
+* TestExpectations:
+
 2021-11-10  Enrique Ocaña González  
 
 [Media] Make currentTime compliant with the spec when readyState is HAVE_NOTHING


Modified: trunk/LayoutTests/TestExpec

[webkit-changes] [285582] trunk/Source/WebKit

[pvollan]

Title: [285582] trunk/Source/WebKit








Revision 285582
Author pvol...@apple.com
Date 2021-11-10 09:15:29 -0800 (Wed, 10 Nov 2021)


Log Message
[iOS][GPUP] Remove access to sysctl properties
https://bugs.webkit.org/show_bug.cgi?id=232821


Reviewed by Brent Fulgham.

Based on telemetry, remove access to unused sysctl properties in the GPU process' sandbox on iOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (285581 => 285582)

--- trunk/Source/WebKit/ChangeLog	2021-11-10 17:12:43 UTC (rev 285581)
+++ trunk/Source/WebKit/ChangeLog	2021-11-10 17:15:29 UTC (rev 285582)
@@ -1,5 +1,17 @@
 2021-11-10  Per Arne Vollan 
 
+[iOS][GPUP] Remove access to sysctl properties
+https://bugs.webkit.org/show_bug.cgi?id=232821
+
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, remove access to unused sysctl properties in the GPU process' sandbox on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
+2021-11-10  Per Arne Vollan 
+
 [iOS][GPUP] Remove access to mach-register
 https://bugs.webkit.org/show_bug.cgi?id=232442
 


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (285581 => 285582)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-10 17:12:43 UTC (rev 285581)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-10 17:15:29 UTC (rev 285582)
@@ -270,7 +270,7 @@
 (iokit-property "MetalPluginName")
 )
 
-(allow sysctl-read (with telemetry)
+(allow sysctl-read
 (sysctl-name #"kern.bootsessionuuid"))
 
 (allow mach-lookup (with telemetry)
@@ -526,7 +526,7 @@
   "sysctl.proc_native"))
 
 (with-filter (system-attribute apple-internal)
-(allow sysctl-read sysctl-write (with telemetry)
+(allow sysctl-read sysctl-write
(sysctl-name "vm.footprint_suspend"))
 (allow nvram-get (with telemetry) (nvram-variable "emu")) ;; 
 )
@@ -653,54 +653,23 @@
 ;;; End UIKit-apps.sb content
 ;;;
 
-(deny sysctl*)
+(deny sysctl* (with telemetry))
 (allow sysctl-read (with telemetry)
 (sysctl-name
 "hw.activecpu"
-"hw.availcpu"
-"hw.cacheconfig" ;; 
 "hw.cachelinesize"
-"hw.cachesize" ;; 
-"hw.cpufamily" ;; 
-"hw.cpusubfamily"
-"hw.cputhreadtype"
-"hw.cputype"
-"hw.l1dcachesize" ;; 
-"hw.l1icachesize" ;; 
 "hw.l2cachesize"
-"hw.l3cachesize" ;; 
-"hw.logicalcpu"
 "hw.logicalcpu_max"
-"hw.ncpu"
-"hw.nperflevels" ;; 
-"hw.pagesize" ;; 
 "hw.machine"
 "hw.memsize"
 "hw.model"
-"hw.ncpu"
-"hw.nperflevels"
-"hw.pagesize" ;; 
 "hw.pagesize_compat"
-"hw.physicalcpu"
 "hw.physicalcpu_max"
-"hw.physmem" ;; 
 "hw.product" ;; 
-"hw.vectorunit" ;; 
-"kern.bootargs"
-"kern.hostname"
-"kern.hv_vmm_present"
-"kern.memorystatus_level"
 "kern.osproductversion"
-"kern.osrelease"
 "kern.osvariant_status"
-"kern.osversion"
 "kern.secure_kernel"
-"kern.version"
-"sysctl.name2oid"
-"vm.footprint_suspend")
-(sysctl-name-prefix "hw.optional.") ;; 
-(sysctl-name-prefix "hw.perflevel") ;; 
-)
+"vm.footprint_suspend"))
 
 (allow iokit-get-properties
 (iokit-property "AAPL,DisplayPipe")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285581] trunk/Source/WebKit

[pvollan]

Title: [285581] trunk/Source/WebKit








Revision 285581
Author pvol...@apple.com
Date 2021-11-10 09:12:43 -0800 (Wed, 10 Nov 2021)


Log Message
[iOS][GPUP] Remove access to mach-register
https://bugs.webkit.org/show_bug.cgi?id=232442


Reviewed by Darin Adler.

Based on telemetry, remove access to mach-register in the GPU process' sandbox on iOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (285580 => 285581)

--- trunk/Source/WebKit/ChangeLog	2021-11-10 17:09:59 UTC (rev 285580)
+++ trunk/Source/WebKit/ChangeLog	2021-11-10 17:12:43 UTC (rev 285581)
@@ -1,5 +1,17 @@
 2021-11-10  Per Arne Vollan 
 
+[iOS][GPUP] Remove access to mach-register
+https://bugs.webkit.org/show_bug.cgi?id=232442
+
+
+Reviewed by Darin Adler.
+
+Based on telemetry, remove access to mach-register in the GPU process' sandbox on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
+2021-11-10  Per Arne Vollan 
+
 [iOS][GPUP] Block access to mapping of executables
 https://bugs.webkit.org/show_bug.cgi?id=232824
 


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (285580 => 285581)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-10 17:09:59 UTC (rev 285580)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-10 17:12:43 UTC (rev 285581)
@@ -215,8 +215,6 @@
 )
 
 (define-once (accessibility-support)
-(allow mach-register (with telemetry)
-(local-name "com.apple.iphone.axserver"))
 (mobile-preferences-read "com.apple.Accessibility")
 
 ;; 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285580] trunk/Source/WebKit

[pvollan]

Title: [285580] trunk/Source/WebKit








Revision 285580
Author pvol...@apple.com
Date 2021-11-10 09:09:59 -0800 (Wed, 10 Nov 2021)


Log Message
[iOS][GPUP] Block access to mapping of executables
https://bugs.webkit.org/show_bug.cgi?id=232824


Reviewed by Brent Fulgham.

Block access to mapping of certain executables in the GPU process on iOS.
These changes are based on collected telemetry.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (285579 => 285580)

--- trunk/Source/WebKit/ChangeLog	2021-11-10 17:06:12 UTC (rev 285579)
+++ trunk/Source/WebKit/ChangeLog	2021-11-10 17:09:59 UTC (rev 285580)
@@ -1,5 +1,18 @@
 2021-11-10  Per Arne Vollan 
 
+[iOS][GPUP] Block access to mapping of executables
+https://bugs.webkit.org/show_bug.cgi?id=232824
+
+
+Reviewed by Brent Fulgham.
+
+Block access to mapping of certain executables in the GPU process on iOS.
+These changes are based on collected telemetry.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
+2021-11-10  Per Arne Vollan 
+
 [macOS][GPUP] Remove access to IOKit classes
 https://bugs.webkit.org/show_bug.cgi?id=232308
 


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (285579 => 285580)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-10 17:06:12 UTC (rev 285579)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-10 17:09:59 UTC (rev 285580)
@@ -437,7 +437,6 @@
(home-literal "/Library/Caches/powerlog.launchd"))
 
 (allow-read-and-issue-generic-extensions (executable-bundle))
-(allow file-map-executable (with telemetry) (executable-bundle))
 
 ;; 
 (deny file-read-data file-issue-extension file-map-executable
@@ -824,9 +823,6 @@
 (deny file-write-create (vnode-type SYMLINK))
 (deny file-read-xattr file-write-xattr (xattr-prefix "com.apple.security.private."))
 
-;; Allow loading injected bundles.
-(allow file-map-executable (with telemetry))
-
 ;; Allow ManagedPreference access
 (allow file-read* (with telemetry) (literal "/private/var/Managed Preferences/mobile/com.apple.webcontentfilter.plist"))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285579] trunk/Source/WebKit

[pvollan]

Title: [285579] trunk/Source/WebKit








Revision 285579
Author pvol...@apple.com
Date 2021-11-10 09:06:12 -0800 (Wed, 10 Nov 2021)


Log Message
[macOS][GPUP] Remove access to IOKit classes
https://bugs.webkit.org/show_bug.cgi?id=232308


Reviewed by Brent Fulgham.

Based on telemetry, remove access to unused IOKit classes in the GPU process' sandbox on macOS.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (285578 => 285579)

--- trunk/Source/WebKit/ChangeLog	2021-11-10 17:05:31 UTC (rev 285578)
+++ trunk/Source/WebKit/ChangeLog	2021-11-10 17:06:12 UTC (rev 285579)
@@ -1,3 +1,15 @@
+2021-11-10  Per Arne Vollan 
+
+[macOS][GPUP] Remove access to IOKit classes
+https://bugs.webkit.org/show_bug.cgi?id=232308
+
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, remove access to unused IOKit classes in the GPU process' sandbox on macOS.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+
 2021-11-10  Youenn Fablet  
 
 Update libwebrtc to M96


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (285578 => 285579)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-10 17:05:31 UTC (rev 285578)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-10 17:06:12 UTC (rev 285579)
@@ -110,11 +110,11 @@
 ;; OpenCL
 (allow iokit-open (with telemetry)
 (iokit-connection "IOAccelerator")
-(iokit-registry-entry-class "IOAccelerationUserClient")
-(iokit-registry-entry-class "IOSurfaceRootUserClient")
-(iokit-registry-entry-class "IOSurfaceSendRight"))
+(iokit-registry-entry-class "IOSurfaceRootUserClient"))
+(deny iokit-open (with telemetry)
+(iokit-registry-entry-class "IOAccelerationUserClient"))
 ;; CoreVideo CVCGDisplayLink
-(allow iokit-open (with telemetry)
+(deny iokit-open (with telemetry)
 (iokit-registry-entry-class "IOFramebufferSharedUserClient"))
 
 ;; These are needed for Encrypted Media on some hardware (MacMini8,1 for example)
@@ -124,12 +124,12 @@
 )
 
 ;; QuartzCore
-(allow iokit-open (with telemetry)
+(deny iokit-open (with telemetry)
 (iokit-registry-entry-class "AGPMClient")
 (iokit-registry-entry-class "AppleGraphicsControlClient")
 (iokit-registry-entry-class "AppleGraphicsPolicyClient"))
 ;; OpenGL
-(allow iokit-open (with telemetry)
+(deny iokit-open (with telemetry)
 (iokit-registry-entry-class "AppleMGPUPowerControlClient"))
 ;; GPU bundles
 (allow file-read* (with telemetry)
@@ -665,9 +665,7 @@
 
 ;; IOKit user clients
 (allow iokit-open (with telemetry)
-(iokit-user-client-class "AppleMultitouchDeviceUserClient")
 (iokit-user-client-class "AppleUpstreamUserClient")
-(iokit-user-client-class "IOHIDParamUserClient")
 (iokit-user-client-class "RootDomainUserClient")
 (iokit-user-client-class "IOAudioControlUserClient")
 (iokit-user-client-class "IOAudioEngineUserClient")
@@ -674,6 +672,10 @@
 ;; Following is needed due to  && 
 (iokit-user-client-class "AudioAUUC"))
 
+(deny iokit-open (with telemetry)
+(iokit-user-client-class "AppleMultitouchDeviceUserClient")
+(iokit-user-client-class "IOHIDParamUserClient"))
+
 ;; Audio
 (allow ipc-posix-shm-read* ipc-posix-shm-write-data
 (ipc-posix-name-prefix "AudioIO"))
@@ -898,7 +900,7 @@
 )
 #endif
 )
-(allow iokit-open (with telemetry)
+(deny iokit-open (with telemetry)
 ;; QuickTimeUSBVDCDigitizer
 (iokit-user-client-class "IOUSBDeviceUserClientV2")
 (iokit-user-client-class "IOUSBInterfaceUserClientV2"))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285578] trunk/JSTests

[commit-queue]

Title: [285578] trunk/JSTests








Revision 285578
Author commit-qu...@webkit.org
Date 2021-11-10 09:05:31 -0800 (Wed, 10 Nov 2021)


Log Message
[JSC][32bit] Unskip JSTests/stress/json-stringify-string-builder-overflow.js
https://bugs.webkit.org/show_bug.cgi?id=232944

Unreviewed gardening.

This seems to survive 1000 iterations on both armv7 and mips
hw. Remove the arch-specific skips leaving the memory limited
ones.

Patch by Xan Lopez  on 2021-11-10

* stress/json-stringify-string-builder-overflow.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/json-stringify-string-builder-overflow.js




Diff

Modified: trunk/JSTests/ChangeLog (285577 => 285578)

--- trunk/JSTests/ChangeLog	2021-11-10 15:55:12 UTC (rev 285577)
+++ trunk/JSTests/ChangeLog	2021-11-10 17:05:31 UTC (rev 285578)
@@ -1,3 +1,16 @@
+2021-11-10  Xan Lopez  
+
+[JSC][32bit] Unskip JSTests/stress/json-stringify-string-builder-overflow.js
+https://bugs.webkit.org/show_bug.cgi?id=232944
+
+Unreviewed gardening.
+
+This seems to survive 1000 iterations on both armv7 and mips
+hw. Remove the arch-specific skips leaving the memory limited
+ones.
+
+* stress/json-stringify-string-builder-overflow.js:
+
 2021-11-09  Saam Barati  
 
 When inlining NewSymbol in the DFG don't universally call ToString on the input


Modified: trunk/JSTests/stress/json-stringify-string-builder-overflow.js (285577 => 285578)

--- trunk/JSTests/stress/json-stringify-string-builder-overflow.js	2021-11-10 15:55:12 UTC (rev 285577)
+++ trunk/JSTests/stress/json-stringify-string-builder-overflow.js	2021-11-10 17:05:31 UTC (rev 285578)
@@ -1,6 +1,5 @@
 //@ slow!
 //@ skip if $memoryLimited
-//@ skip if $architecture != "arm64" and $architecture != "x86-64"
 //@ runDefault if !$memoryLimited
 
 var longString = "x".repeat(2 ** 30);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285576] trunk/Source

[youenn]

Title: [285576] trunk/Source








Revision 285576
Author you...@apple.com
Date 2021-11-10 07:47:05 -0800 (Wed, 10 Nov 2021)


Log Message
[iOS] Add audio gain in case category switches to PlayAndRecord
https://bugs.webkit.org/show_bug.cgi?id=232941


Reviewed by Eric Carlson.

Source/WebCore:

Add a audio category change observer.
Observer needs to be in the process where the actual iOS shared audio session is living (GPUProcess typically).
Manually tested.

* WebCore.xcodeproj/project.pbxproj:
* platform/audio/cocoa/AudioSampleBufferList.h:
* platform/audio/ios/AudioSessionIOS.h:
* platform/audio/ios/AudioSessionIOS.mm:

Source/WebKit:

In case of PlayAndRecord, apply a static gain of 5 to audio rendered from MediaStreamTracks.
For that purpose, observe changes to the AudioSession category and react upon it.

* GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::Unit):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::start):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::render):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::categoryDidChange):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/audio/cocoa/AudioSampleBufferList.h
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.h
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285575 => 285576)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 15:11:20 UTC (rev 285575)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 15:47:05 UTC (rev 285576)
@@ -1,3 +1,20 @@
+2021-11-10  Youenn Fablet  
+
+[iOS] Add audio gain in case category switches to PlayAndRecord
+https://bugs.webkit.org/show_bug.cgi?id=232941
+
+
+Reviewed by Eric Carlson.
+
+Add a audio category change observer.
+Observer needs to be in the process where the actual iOS shared audio session is living (GPUProcess typically).
+Manually tested.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/audio/cocoa/AudioSampleBufferList.h:
+* platform/audio/ios/AudioSessionIOS.h:
+* platform/audio/ios/AudioSessionIOS.mm:
+
 2021-11-10  Tim Nguyen  
 
 Migrate DialogElementEnabled from RuntimeFlags to Settings


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (285575 => 285576)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-11-10 15:11:20 UTC (rev 285575)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-11-10 15:47:05 UTC (rev 285576)
@@ -4409,7 +4409,7 @@
 		CD336F6217F9F64700DDDCD0 /* AVTrackPrivateAVFObjCImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = CD336F6017F9F64700DDDCD0 /* AVTrackPrivateAVFObjCImpl.h */; };
 		CD336F6417FA0A4D00DDDCD0 /* VideoTrackPrivateAVF.h in Headers */ = {isa = PBXBuildFile; fileRef = CD336F6317FA0A4D00DDDCD0 /* VideoTrackPrivateAVF.h */; };
 		CD336F6817FA0AC600DDDCD0 /* VideoTrackPrivateAVFObjC.h in Headers */ = {isa = PBXBuildFile; fileRef = CD336F6617FA0AC600DDDCD0 /* VideoTrackPrivateAVFObjC.h */; };
-		CD36C1622607E78600C8C529 /* AudioSessionIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = CD36C1612607E78600C8C529 /* AudioSessionIOS.h */; };
+		CD36C1622607E78600C8C529 /* AudioSessionIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = CD36C1612607E78600C8C529 /* AudioSessionIOS.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		CD36C16B260A65CC00C8C529 /* SharedRoutingArbitrator.h in Headers */ = {isa = PBXBuildFile; fileRef = CD36C168260A63D300C8C529 /* SharedRoutingArbitrator.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		CD3A495F17A9D01B00274E42 /* MediaSource.h in Headers */ = {isa = PBXBuildFile; fileRef = CD3A495617A9D01B00274E42 /* MediaSource.h */; };
 		CD3A496217A9D01B00274E42 /* SourceBuffer.h in Headers */ = {isa = PBXBuildFile; fileRef = CD3A495917A9D01B00274E42 /* SourceBuffer.h */; };


Modified: trunk/Source/WebCore/platform/audio/cocoa/AudioSampleBufferList.h (285575 => 285576)

--- trunk/Source/WebCore/platform/audio/cocoa/AudioSampleBufferList.h	2021-11-10 15:11:20 UTC (rev 285575)
+++ trunk/Source/WebCore/platform/audio/cocoa/AudioSampleBufferList.h	2021-11-10 15:47:05 UTC (rev 285576)
@@ -45,7 +45,7 @@
 
 static inline size_t audioBufferListSizeForStream(const CAAudioStreamDescription&);
 
-static void applyGain(AudioBufferList&, float, AudioStreamDescription::PCMFormat);
+WEBCORE_EXPORT static void applyGain(AudioBufferList&, float, AudioStreamDescription::PCMFormat);
 void applyGain(float);
 
 OSStatus copyFrom(const AudioSampleBufferList&, size_t count = SIZE_MAX);


Modified: trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.

[webkit-changes] [285575] trunk/Source

[ntim]

Title: [285575] trunk/Source








Revision 285575
Author n...@apple.com
Date 2021-11-10 07:11:20 -0800 (Wed, 10 Nov 2021)


Log Message
Migrate DialogElementEnabled from RuntimeFlags to Settings
https://bugs.webkit.org/show_bug.cgi?id=232926

Reviewed by Youenn Fablet.

Source/WebCore:

* html/HTMLDialogElement.idl:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formMethod const):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::parseAttribute):
(WebCore::HTMLFormElement::method const):
* html/HTMLTagNames.in:
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::Attributes::methodString):
(WebCore::FormSubmission::Attributes::parseMethodType):
(WebCore::FormSubmission::Attributes::updateMethodType):
(WebCore::FormSubmission::create):
* loader/FormSubmission.h:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled const): Deleted.
* style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

Source/WebKit:

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDialogElementEnabled): Deleted.
(WKPreferencesGetDialogElementEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences dialogElementEnabled]): Deleted.
(-[WebPreferences setDialogElementEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLDialogElement.idl
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
trunk/Source/WebCore/html/HTMLFormElement.cpp
trunk/Source/WebCore/html/HTMLTagNames.in
trunk/Source/WebCore/loader/FormSubmission.cpp
trunk/Source/WebCore/loader/FormSubmission.h
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebCore/style/UserAgentStyle.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h




Diff

Modified: trunk/Source/WTF/ChangeLog (285574 => 285575)

--- trunk/Source/WTF/ChangeLog	2021-11-10 14:40:24 UTC (rev 285574)
+++ trunk/Source/WTF/ChangeLog	2021-11-10 15:11:20 UTC (rev 285575)
@@ -1,3 +1,12 @@
+2021-11-10  Tim Nguyen  
+
+Migrate DialogElementEnabled from RuntimeFlags to Settings
+https://bugs.webkit.org/show_bug.cgi?id=232926
+
+Reviewed by Youenn Fablet.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+
 2021-11-10  Antti Koivisto  
 
 Hasher should be able to hash pointers


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (285574 => 285575)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-11-10 14:40:24 UTC (rev 285574)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-11-10 15:11:20 UTC (rev 285575)
@@ -440,8 +440,6 @@
   type: bool
   humanReadableName: "Dialog Element"
   humanReadableDescription: "Enable the Dialog Element"
-  webKitLegacyPreferenceKey: WebKitDialogElementEnabledPreferenceKey
-  webcoreBinding: RuntimeEnabledFeatures
   defaultValue:
 WebKitLegacy:
   default: true


Modified: trunk/Source/WebCore/ChangeLog (285574 => 285575)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 14:40:24 UTC (rev 285574)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 15:11:20 UTC (rev 285575)
@@ -1,3 +1,30 @@
+2021-11-10  Tim Nguyen  
+
+Migrate DialogElementEnabled from RuntimeFlags to Settings
+https://bugs.webkit.org/show_bug.cgi?id=232926
+
+Reviewed by Youenn Fablet.
+
+* html/HTMLDialogElement.idl:
+* html/HTMLFormControlElement.cpp:
+(WebCore::HTMLFormControlElement::formMethod const):
+* html/HTMLFormElement.cpp:
+(WebCore::HTMLFormElement::submit):
+(WebCore::HTMLFormElement::parseAttribute):
+(WebCore::HTMLFormElement::method const):
+* html/HTMLTagNames.in:
+* loader/FormSubmission.cpp:
+(WebCore::FormSubmission::Attributes::methodString):
+(WebCore::FormSubmission::Attributes::parseMethodType):
+(WebCore::FormSubmission::Attributes::updateMethodType):
+(WebCore::FormSubmission::create):
+* loader/FormSubmission.h:
+* page/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled): Deleted.
+(WebCore::RuntimeEnabledFeatures::dialogElementEnabled const): Deleted.
+* style/UserAgen

[webkit-changes] [285574] trunk/Source/WebCore

[antti]

Title: [285574] trunk/Source/WebCore








Revision 285574
Author an...@apple.com
Date 2021-11-10 06:40:24 -0800 (Wed, 10 Nov 2021)


Log Message
Use Hasher for hashing MatchResult for MatchedDeclarationsCache
https://bugs.webkit.org/show_bug.cgi?id=232930

Reviewed by Kimmo Kinnunen.

We currently use hashMemory over a Vector. This works correctly only as long as
the MatchedProperties struct is fully packed. Any unitilized memory in the struct leads to badness.

* WebCore.xcodeproj/project.pbxproj:
* style/ElementRuleCollector.h:
(WebCore::Style::MatchResult::operator== const): Deleted.
(WebCore::Style::MatchResult::operator!= const): Deleted.
(WebCore::Style::MatchResult::isEmpty const): Deleted.
(WebCore::Style::operator==): Deleted.
(WebCore::Style::operator!=): Deleted.

Move MatchResult to a file of its own.

* style/MatchResult.h: Added.
(WebCore::Style::MatchResult::isEmpty const):
(WebCore::Style::operator==):
(WebCore::Style::operator!=):
(WebCore::Style::add):

Implement Hasher functions for the types.

* style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::computeHash):

use WTF::computeHash

* style/MatchedDeclarationsCache.h:
* style/PageRuleCollector.h:
* style/PropertyCascade.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/style/ElementRuleCollector.h
trunk/Source/WebCore/style/MatchedDeclarationsCache.cpp
trunk/Source/WebCore/style/MatchedDeclarationsCache.h
trunk/Source/WebCore/style/PageRuleCollector.h
trunk/Source/WebCore/style/PropertyCascade.h


Added Paths

trunk/Source/WebCore/style/MatchResult.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285573 => 285574)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 14:31:47 UTC (rev 285573)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 14:40:24 UTC (rev 285574)
@@ -1,3 +1,40 @@
+2021-11-10  Antti Koivisto  
+
+Use Hasher for hashing MatchResult for MatchedDeclarationsCache
+https://bugs.webkit.org/show_bug.cgi?id=232930
+
+Reviewed by Kimmo Kinnunen.
+
+We currently use hashMemory over a Vector. This works correctly only as long as
+the MatchedProperties struct is fully packed. Any unitilized memory in the struct leads to badness.
+
+* WebCore.xcodeproj/project.pbxproj:
+* style/ElementRuleCollector.h:
+(WebCore::Style::MatchResult::operator== const): Deleted.
+(WebCore::Style::MatchResult::operator!= const): Deleted.
+(WebCore::Style::MatchResult::isEmpty const): Deleted.
+(WebCore::Style::operator==): Deleted.
+(WebCore::Style::operator!=): Deleted.
+
+Move MatchResult to a file of its own.
+
+* style/MatchResult.h: Added.
+(WebCore::Style::MatchResult::isEmpty const):
+(WebCore::Style::operator==):
+(WebCore::Style::operator!=):
+(WebCore::Style::add):
+
+Implement Hasher functions for the types.
+
+* style/MatchedDeclarationsCache.cpp:
+(WebCore::Style::MatchedDeclarationsCache::computeHash):
+
+use WTF::computeHash
+
+* style/MatchedDeclarationsCache.h:
+* style/PageRuleCollector.h:
+* style/PropertyCascade.h:
+
 2021-11-10  Enrique Ocaña González  
 
 [Media] Make currentTime compliant with the spec when readyState is HAVE_NOTHING


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (285573 => 285574)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-11-10 14:31:47 UTC (rev 285573)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-11-10 14:40:24 UTC (rev 285574)
@@ -5267,6 +5267,7 @@
 		E446143C0CD689CC00FADA75 /* JSHTMLSourceElement.h in Headers */ = {isa = PBXBuildFile; fileRef = E4B423720CBFB6E000AF2ECE /* JSHTMLSourceElement.h */; };
 		E44614520CD68A3500FADA75 /* RenderVideo.h in Headers */ = {isa = PBXBuildFile; fileRef = E4B41E340CBFB60900AF2ECE /* RenderVideo.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		E447F5B3266CF63D00133F00 /* TextBoxSelectableRange.h in Headers */ = {isa = PBXBuildFile; fileRef = E447F5B1266CF63D00133F00 /* TextBoxSelectableRange.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		E44A0256273AE0C000993A56 /* MatchResult.h in Headers */ = {isa = PBXBuildFile; fileRef = E44A0254273AE0BF00993A56 /* MatchResult.h */; };
 		E44B4BB4141650D7002B1D8B /* SelectorChecker.h in Headers */ = {isa = PBXBuildFile; fileRef = E44B4BB2141650D7002B1D8B /* SelectorChecker.h */; };
 		E44FA1851BCA6B5A0091B6EF /* ComposedTreeIterator.h in Headers */ = {isa = PBXBuildFile; fileRef = E44FA1841BCA6B5A0091B6EF /* ComposedTreeIterator.h */; };
 		E451C6312394027900993190 /* LayoutUnits.h in Headers */ = {isa = PBXBuildFile; fileRef = 6F73918C2106CEDD006AF262 /* LayoutUnits.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -16872,6 +16873,7 @@
 		E44614120CD6826900FADA75 /* JSTimeRanges.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcec

[webkit-changes] [285573] trunk/Tools

[commit-queue]

Title: [285573] trunk/Tools








Revision 285573
Author commit-qu...@webkit.org
Date 2021-11-10 06:31:47 -0800 (Wed, 10 Nov 2021)


Log Message
[GLib] apply-build-revision fails when git-svn is not installed
https://bugs.webkit.org/show_bug.cgi?id=232929

Patch by Philippe Normand  on 2021-11-10
Reviewed by Michael Catanzaro.

Attempt to get the build revision from the git log if the git-svn call failed, either
because git-svn is not installed or the metadata in .git/svn is incomplete.

* glib/apply-build-revision-to-files.py:
(get_revision_from_most_recent_git_commit):
(get_build_revision):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/glib/apply-build-revision-to-files.py




Diff

Modified: trunk/Tools/ChangeLog (285572 => 285573)

--- trunk/Tools/ChangeLog	2021-11-10 12:49:25 UTC (rev 285572)
+++ trunk/Tools/ChangeLog	2021-11-10 14:31:47 UTC (rev 285573)
@@ -1,3 +1,17 @@
+2021-11-10  Philippe Normand  
+
+[GLib] apply-build-revision fails when git-svn is not installed
+https://bugs.webkit.org/show_bug.cgi?id=232929
+
+Reviewed by Michael Catanzaro.
+
+Attempt to get the build revision from the git log if the git-svn call failed, either
+because git-svn is not installed or the metadata in .git/svn is incomplete.
+
+* glib/apply-build-revision-to-files.py:
+(get_revision_from_most_recent_git_commit):
+(get_build_revision):
+
 2021-11-10  Antti Koivisto  
 
 Hasher should be able to hash pointers


Modified: trunk/Tools/glib/apply-build-revision-to-files.py (285572 => 285573)

--- trunk/Tools/glib/apply-build-revision-to-files.py	2021-11-10 12:49:25 UTC (rev 285572)
+++ trunk/Tools/glib/apply-build-revision-to-files.py	2021-11-10 14:31:47 UTC (rev 285573)
@@ -24,38 +24,51 @@
 from urlparse import urlparse
 
 
+def get_revision_from_most_recent_git_commit():
+with open(os.devnull, 'w') as devnull:
+try:
+commit_message = subprocess.check_output(("git", "log", "-1", "--pretty=%B", "origin/HEAD"), stderr=devnull)
+except subprocess.CalledProcessError:
+# This may happen with shallow checkouts whose HEAD has been
+# modified; there is no origin reference anymore, and git
+# will fail - let's pretend that this is not a repo at all
+return None
+
+# Commit messages tend to be huge and the metadata we're looking
+# for is at the very end. Also a spoofed 'Canonical link' mention
+# could appear early on. So make sure we get the right metadata by
+# reversing the contents. And this is a micro-optimization as well.
+for line in reversed(commit_message.splitlines()):
+parsed = line.split(b':')
+key = parsed[0]
+contents = b':'.join(parsed[1:])
+if key == b'Canonical link':
+url = ""
+revision = urlparse(url).path[1:]  # strip leading /
+return revision
+return None
+
 def get_build_revision():
 revision = "unknown"
 with open(os.devnull, 'w') as devnull:
 gitsvn = os.path.join('.git', 'svn')
 if os.path.isdir(gitsvn) and os.listdir(gitsvn):
-for line in subprocess.check_output(("git", "svn", "info"), stderr=devnull).splitlines():
-parsed = line.split(b':')
-key = parsed[0]
-contents = b':'.join(parsed[1:])
-if key == b'Revision':
-revision = "r%s" % contents.decode('utf-8').strip()
-break
-elif os.path.isdir('.git'):
 try:
-commit_message = subprocess.check_output(("git", "log", "-1", "--pretty=%B", "origin/HEAD"), stderr=devnull)
+for line in subprocess.check_output(("git", "svn", "info"), stderr=devnull).splitlines():
+parsed = line.split(b':')
+key = parsed[0]
+contents = b':'.join(parsed[1:])
+if key == b'Revision':
+revision = "r%s" % contents.decode('utf-8').strip()
+break
 except subprocess.CalledProcessError:
-# This may happen with shallow checkouts whose HEAD has been
-# modified; there is no origin reference anymore, and git
-# will fail - let's pretend that this is not a repo at all
-commit_message = ""
-# Commit messages tend to be huge and the metadata we're looking
-# for is at the very end. Also a spoofed 'Canonical link' mention
-# could appear early on. So make sure we get the right metadata by
-# reversing the contents. And this is a micro-optimization as well.
-for line in reversed(commit_message.splitlines()):
-parsed = line.split(b':')
-key = parsed[0]
-contents = b':'.join(parsed[1:])
-   

[webkit-changes] [285572] trunk

[antti]

Title: [285572] trunk








Revision 285572
Author an...@apple.com
Date 2021-11-10 04:49:25 -0800 (Wed, 10 Nov 2021)


Log Message
Hasher should be able to hash pointers
https://bugs.webkit.org/show_bug.cgi?id=232927

Reviewed by Kimmo Kinnunen.

Source/WTF:

* wtf/Hasher.h:
(WTF::add):

Tools:

* TestWebKitAPI/Tests/WTF/Hasher.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Hasher.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (285571 => 285572)

--- trunk/Source/WTF/ChangeLog	2021-11-10 11:36:04 UTC (rev 285571)
+++ trunk/Source/WTF/ChangeLog	2021-11-10 12:49:25 UTC (rev 285572)
@@ -1,3 +1,13 @@
+2021-11-10  Antti Koivisto  
+
+Hasher should be able to hash pointers
+https://bugs.webkit.org/show_bug.cgi?id=232927
+
+Reviewed by Kimmo Kinnunen.
+
+* wtf/Hasher.h:
+(WTF::add):
+
 2021-11-09  Chris Dumez  
 
 [macOS] Enable NSURLSession partitioning based on first-party domain at CFNetwork level


Modified: trunk/Source/WTF/wtf/Hasher.h (285571 => 285572)

--- trunk/Source/WTF/wtf/Hasher.h	2021-11-10 11:36:04 UTC (rev 285571)
+++ trunk/Source/WTF/wtf/Hasher.h	2021-11-10 12:49:25 UTC (rev 285572)
@@ -96,6 +96,11 @@
 add(hasher, bitwise_cast(number));
 }
 
+template inline void add(Hasher& hasher, T* ptr)
+{
+add(hasher, bitwise_cast(ptr));
+}
+
 inline void add(Hasher& hasher, const String& string)
 {
 // Chose to hash the characters here. Assuming this is better than hashing the possibly-already-computed hash of the characters.


Modified: trunk/Tools/ChangeLog (285571 => 285572)

--- trunk/Tools/ChangeLog	2021-11-10 11:36:04 UTC (rev 285571)
+++ trunk/Tools/ChangeLog	2021-11-10 12:49:25 UTC (rev 285572)
@@ -1,3 +1,13 @@
+2021-11-10  Antti Koivisto  
+
+Hasher should be able to hash pointers
+https://bugs.webkit.org/show_bug.cgi?id=232927
+
+Reviewed by Kimmo Kinnunen.
+
+* TestWebKitAPI/Tests/WTF/Hasher.cpp:
+(TestWebKitAPI::TEST):
+
 2021-11-09  Commit Queue  
 
 Unreviewed, reverting r285536.


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp (285571 => 285572)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp	2021-11-10 11:36:04 UTC (rev 285571)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp	2021-11-10 12:49:25 UTC (rev 285572)
@@ -189,6 +189,17 @@
 EXPECT_EQ(1652352321U, computeHash(std::make_pair(std::make_pair(1, 2), std::make_pair(3, 4;
 }
 
+TEST(WTF, Hasher_pointer)
+{
+char* nullPtr = nullptr;
+char* _onePtr_ = nullPtr + 1;
+char* ffPtr = nullPtr + 0xff;
+
+EXPECT_EQ(computeHash(static_cast(0)), computeHash(nullPtr));
+EXPECT_EQ(computeHash(static_cast(0x1)), computeHash(onePtr));
+EXPECT_EQ(computeHash(static_cast(0xff)), computeHash(ffPtr));
+}
+
 struct HasherAddCustom1 { };
 
 void add(Hasher& hasher, const HasherAddCustom1&)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285571] trunk

[eocanha]

Title: [285571] trunk








Revision 285571
Author eoca...@igalia.com
Date 2021-11-10 03:36:04 -0800 (Wed, 10 Nov 2021)


Log Message
[Media] Make currentTime compliant with the spec when readyState is HAVE_NOTHING
https://bugs.webkit.org/show_bug.cgi?id=229605
Source/WebCore:

Reviewed by Xabier Rodriguez-Calvar.

Covered by LayoutTests/media/video-seek-have-nothing.html.

Added an internal defaultPlaybackPosition in HTMLMediaElement when currentTime changes
are done when readyState is still HAVE_NOTHING, as mandated by the spec[1] since late
2011: https://html.spec.whatwg.org/#current-playback-position

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState): Seek to defaultPlaybackPosition (and reset it)  when readyState increases to HAVE_METADATA.
(WebCore::HTMLMediaElement::currentMediaTime const): Return defaultPlaybackPosition when higher than zero.
(WebCore::HTMLMediaElement::setCurrentTimeForBindings): Store the new currentTime in defaultPlaybackPosition when changed during a HAVE_NOTHING readyState.
* html/HTMLMediaElement.h: Added m_defaultPlaybackStartPosition private attribute.

LayoutTests:

Reviewed by Xabier Rodriguez-Calvar.

New test that checks that changes in currentTime done while on readyState=HAVE_NOTHING
are recorded and trigger a seek as soon as readyState increases to HAVE_METADATA or above.

* media/video-seek-have-nothing-expected.txt: Added.
* media/video-seek-have-nothing.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h


Added Paths

trunk/LayoutTests/media/video-seek-have-nothing-expected.txt
trunk/LayoutTests/media/video-seek-have-nothing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285570 => 285571)

--- trunk/LayoutTests/ChangeLog	2021-11-10 09:42:52 UTC (rev 285570)
+++ trunk/LayoutTests/ChangeLog	2021-11-10 11:36:04 UTC (rev 285571)
@@ -1,3 +1,16 @@
+2021-11-10  Enrique Ocaña González  
+
+[Media] Make currentTime compliant with the spec when readyState is HAVE_NOTHING
+https://bugs.webkit.org/show_bug.cgi?id=229605
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+New test that checks that changes in currentTime done while on readyState=HAVE_NOTHING
+are recorded and trigger a seek as soon as readyState increases to HAVE_METADATA or above.
+
+* media/video-seek-have-nothing-expected.txt: Added.
+* media/video-seek-have-nothing.html: Added.
+
 2021-11-10  Tim Nguyen  
 
 Fix crash in GraphicsContextCG::endTransparencyLayer


Added: trunk/LayoutTests/media/video-seek-have-nothing-expected.txt (0 => 285571)

--- trunk/LayoutTests/media/video-seek-have-nothing-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/video-seek-have-nothing-expected.txt	2021-11-10 11:36:04 UTC (rev 285571)
@@ -0,0 +1,19 @@
+Test that we can change currentTime when readyState is HAVE_NOTHING, the new value is returned, and a seek is done when readyState increases to HAVE_METADATA.
+
+
+EXPECTED (video.readyState == '0') OK
+EXPECTED (video.currentTime == '0') OK
+RUN(video.currentTime = 2)
+EXPECTED (video.readyState == '0') OK
+EXPECTED (video.currentTime == '2') OK
+EVENT(loadedmetadata)
+EXPECTED (video.readyState >= video.HAVE_METADATA == 'true') OK
+EVENT(seeked)
+RUN(video.play())
+EVENT(playing)
+EXPECTED (video.readyState >= video.HAVE_CURRENT_DATA == 'true') OK
+EVENT(timeupdate)
+EXPECTED (video.currentTime > 2 == 'true') OK
+EXPECTED (video.readyState >= video.HAVE_FUTURE_DATA == 'true') OK
+END OF TEST
+


Added: trunk/LayoutTests/media/video-seek-have-nothing.html (0 => 285571)

--- trunk/LayoutTests/media/video-seek-have-nothing.html	(rev 0)
+++ trunk/LayoutTests/media/video-seek-have-nothing.html	2021-11-10 11:36:04 UTC (rev 285571)
@@ -0,0 +1,47 @@
+
+
+
+
+function start()
+{
+findMediaElement();
+
+waitForEventOnce('loadedmetadata', function() {
+testExpected('video.readyState >= video.HAVE_METADATA', true);
+});
+waitForEventOnce('seeked', function() {
+// FIXME: This check sometimes fails on the mac-wk2-stress EWS.
+// testExpected('video.currentTime', 2);
+waitForEventOnce('playing', function() {
+testExpected('video.readyState >= video.HAVE_CURRENT_DATA', true);
+waitForEventOnce('timeupdate', function() {
+testExpected('video.currentTime > 2', true);
+testExpected('video.readyState >= video.HAVE_FUTURE_DATA', true);
+endTest();
+});
+});
+run('video.play()');
+});
+
+video.src = "" 'content/test');
+te

[webkit-changes] [285570] trunk

[ntim]

Title: [285570] trunk








Revision 285570
Author n...@apple.com
Date 2021-11-10 01:42:52 -0800 (Wed, 10 Nov 2021)


Log Message
Fix crash in GraphicsContextCG::endTransparencyLayer
https://bugs.webkit.org/show_bug.cgi?id=230230

Reviewed by Myles C. Maxfield.

Source/WebCore:

The crash was due to unbalanced calls to begin and end transparency layers.

A branch handling ancestors of transparent layers that are transform root needed to be
aware of the top layer. Opacity on ancestors don't affect top layer elements so calling
`beginTransparencyLayers` on `parent()` is incorrect.

Also fix `transparentPaintingAncestor()` to be top layer aware to avoid flickering layers
while scrolling.

Test: fast/layers/top-layer-ancestor-opacity-and-transform-crash.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::transparentPaintingAncestor):
(WebCore::RenderLayer::paintLayerWithEffects):

LayoutTests:

* fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt: Added.
* fast/layers/top-layer-ancestor-opacity-and-transform-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt
trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285569 => 285570)

--- trunk/LayoutTests/ChangeLog	2021-11-10 09:30:27 UTC (rev 285569)
+++ trunk/LayoutTests/ChangeLog	2021-11-10 09:42:52 UTC (rev 285570)
@@ -1,5 +1,15 @@
 2021-11-10  Tim Nguyen  
 
+Fix crash in GraphicsContextCG::endTransparencyLayer
+https://bugs.webkit.org/show_bug.cgi?id=230230
+
+Reviewed by Myles C. Maxfield.
+
+* fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt: Added.
+* fast/layers/top-layer-ancestor-opacity-and-transform-crash.html: Added.
+
+2021-11-10  Tim Nguyen  
+
 Enable dialog tests on Windows
 https://bugs.webkit.org/show_bug.cgi?id=232911
 


Added: trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt (0 => 285570)

--- trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt	2021-11-10 09:42:52 UTC (rev 285570)
@@ -0,0 +1 @@
+PASS if this doesn't crash


Added: trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash.html (0 => 285570)

--- trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash.html	2021-11-10 09:42:52 UTC (rev 285570)
@@ -0,0 +1,9 @@
+
+* { opacity: 0.1; translate: 1px; }
+
+PASS if this doesn't crash
+
+document.querySelector("dialog").showModal();
+if (testRunner)
+testRunner.dumpAsText();
+


Modified: trunk/Source/WebCore/ChangeLog (285569 => 285570)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 09:30:27 UTC (rev 285569)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 09:42:52 UTC (rev 285570)
@@ -1,5 +1,27 @@
 2021-11-10  Tim Nguyen  
 
+Fix crash in GraphicsContextCG::endTransparencyLayer
+https://bugs.webkit.org/show_bug.cgi?id=230230
+
+Reviewed by Myles C. Maxfield.
+
+The crash was due to unbalanced calls to begin and end transparency layers.
+
+A branch handling ancestors of transparent layers that are transform root needed to be
+aware of the top layer. Opacity on ancestors don't affect top layer elements so calling
+`beginTransparencyLayers` on `parent()` is incorrect.
+
+Also fix `transparentPaintingAncestor()` to be top layer aware to avoid flickering layers
+while scrolling.
+
+Test: fast/layers/top-layer-ancestor-opacity-and-transform-crash.html
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::transparentPaintingAncestor):
+(WebCore::RenderLayer::paintLayerWithEffects):
+
+2021-11-10  Tim Nguyen  
+
 Enable dialog tests on Windows
 https://bugs.webkit.org/show_bug.cgi?id=232911
 


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (285569 => 285570)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2021-11-10 09:30:27 UTC (rev 285569)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2021-11-10 09:42:52 UTC (rev 285570)
@@ -2078,9 +2078,9 @@
 if (isComposited())
 return nullptr;
 
-for (RenderLayer* curr = parent(); curr; curr = curr->parent()) {
+for (RenderLayer* curr = stackingContext(); curr; curr = curr->stackingContext()) {
 if (curr->isComposited())
-return nullptr;
+break;
 if (curr->isTransparent())
 return curr;
 }
@@ -3050,7 +3050,8 @@
 // If we have a transparenc

[webkit-changes] [285569] trunk

[ntim]

Title: [285569] trunk








Revision 285569
Author n...@apple.com
Date 2021-11-10 01:30:27 -0800 (Wed, 10 Nov 2021)


Log Message
Enable dialog tests on Windows
https://bugs.webkit.org/show_bug.cgi?id=232911

Reviewed by Youenn Fablet.

The runtime flag sometimes seems to be off for Windows, change the member in
RuntimeEnabledFeatures.h and re-enable tests.

Source/WebCore:

* page/RuntimeEnabledFeatures.h:

LayoutTests:

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h




Diff

Modified: trunk/LayoutTests/ChangeLog (285568 => 285569)

--- trunk/LayoutTests/ChangeLog	2021-11-10 08:48:57 UTC (rev 285568)
+++ trunk/LayoutTests/ChangeLog	2021-11-10 09:30:27 UTC (rev 285569)
@@ -1,3 +1,15 @@
+2021-11-10  Tim Nguyen  
+
+Enable dialog tests on Windows
+https://bugs.webkit.org/show_bug.cgi?id=232911
+
+Reviewed by Youenn Fablet.
+
+The runtime flag sometimes seems to be off for Windows, change the member in
+RuntimeEnabledFeatures.h and re-enable tests.
+
+* platform/win/TestExpectations:
+
 2021-11-10  Arcady Goldmints-Orlov  
 
 [GLIB] Update test expectations and baselines after r284521


Modified: trunk/LayoutTests/platform/win/TestExpectations (285568 => 285569)

--- trunk/LayoutTests/platform/win/TestExpectations	2021-11-10 08:48:57 UTC (rev 285568)
+++ trunk/LayoutTests/platform/win/TestExpectations	2021-11-10 09:30:27 UTC (rev 285569)
@@ -1251,8 +1251,6 @@
 # These test fail due to 'notifyDone' not being executed.
 webkit.org/b/121509 editing/spelling/grammar-paste.html [ Skip ]
 
-webkit.org/b/231962 editing/selection/modal-dialog-select-paragraph.html [ Failure ]
-
 ## Command enabling
 editing/execCommand/enabling-and-selection-2.html [ Failure ]
 webkit.org/b/101539 editing/execCommand/switch-list-type-with-orphaned-li.html [ Failure ]
@@ -3643,9 +3641,6 @@
 # Only Mac has implemented DictionaryLookup
 fast/layers/prevent-hit-test-during-layout.html [ Skip ]
 
-# Dialog showModal is disabled on Windows
-fast/layers/render-layer-rebuild-z-order-lists.html [ Skip ]
-
 # webrtc not supported
 imported/w3c/web-platform-tests/webrtc [ Skip ]
 webrtc [ Skip ]
@@ -4649,8 +4644,6 @@
 
 webkit.org/b/227896 fast/text/pua-charactersTreatedAsSpace.html [ ImageOnlyFailure ]
 
-webkit.org/b/227802 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-display-none.html [ ImageOnlyFailure ]
-
 webkit.org/b/228110 fast/forms/basic-selects.html [ Skip ]
 webkit.org/b/228110 fast/forms/indeterminate.html [ Skip ]
 


Modified: trunk/Source/WebCore/ChangeLog (285568 => 285569)

--- trunk/Source/WebCore/ChangeLog	2021-11-10 08:48:57 UTC (rev 285568)
+++ trunk/Source/WebCore/ChangeLog	2021-11-10 09:30:27 UTC (rev 285569)
@@ -1,3 +1,15 @@
+2021-11-10  Tim Nguyen  
+
+Enable dialog tests on Windows
+https://bugs.webkit.org/show_bug.cgi?id=232911
+
+Reviewed by Youenn Fablet.
+
+The runtime flag sometimes seems to be off for Windows, change the member in
+RuntimeEnabledFeatures.h and re-enable tests.
+
+* page/RuntimeEnabledFeatures.h:
+
 2021-11-10  Manuel Rego Casasnovas  
 
 Wavy decorations don't cover the whole line length


Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (285568 => 285569)

--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2021-11-10 08:48:57 UTC (rev 285568)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2021-11-10 09:30:27 UTC (rev 285569)
@@ -292,7 +292,7 @@
 bool m_attrStyleEnabled { false };
 bool m_webAPIStatisticsEnabled { false };
 bool m_syntheticEditingCommandsEnabled { true };
-bool m_dialogElementEnabled { false };
+bool m_dialogElementEnabled { true };
 bool m_webSQLEnabled { false };
 bool m_keygenElementEnabled { false };
 bool m_pageAtRuleSupportEnabled { false };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285568] trunk/LayoutTests

[commit-queue]

Title: [285568] trunk/LayoutTests








Revision 285568
Author commit-qu...@webkit.org
Date 2021-11-10 00:48:57 -0800 (Wed, 10 Nov 2021)


Log Message
[GLIB] Update test expectations and baselines after r284521
https://bugs.webkit.org/show_bug.cgi?id=232913

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov  on 2021-11-10

* platform/glib/TestExpectations:
* platform/glib/svg/foreignObject/background-render-phase-expected.txt: Added.
* platform/glib/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
* platform/glib/svg/wicd/sizing-flakiness-expected.txt: Added.
* platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/wpe/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
trunk/LayoutTests/platform/wpe/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt


Added Paths

trunk/LayoutTests/platform/glib/svg/foreignObject/background-render-phase-expected.txt
trunk/LayoutTests/platform/glib/svg/foreignObject/multiple-foreign-objects-expected.txt
trunk/LayoutTests/platform/glib/svg/wicd/sizing-flakiness-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (285567 => 285568)

--- trunk/LayoutTests/ChangeLog	2021-11-10 08:38:18 UTC (rev 285567)
+++ trunk/LayoutTests/ChangeLog	2021-11-10 08:48:57 UTC (rev 285568)
@@ -1,3 +1,17 @@
+2021-11-10  Arcady Goldmints-Orlov  
+
+[GLIB] Update test expectations and baselines after r284521
+https://bugs.webkit.org/show_bug.cgi?id=232913
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+* platform/glib/svg/foreignObject/background-render-phase-expected.txt: Added.
+* platform/glib/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
+* platform/glib/svg/wicd/sizing-flakiness-expected.txt: Added.
+* platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
+* platform/wpe/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
+
 2021-11-10  Sihui Liu  
 
 Perform FileSystemSyncAccessHandle operations in web process


Modified: trunk/LayoutTests/platform/glib/TestExpectations (285567 => 285568)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-11-10 08:38:18 UTC (rev 285567)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-11-10 08:48:57 UTC (rev 285568)
@@ -2493,11 +2493,13 @@
 webkit.org/b/232386 editing/deleting/move-nodes-001.html [ Failure ]
 webkit.org/b/232386 editing/selection/doubleclick-japanese-text.html [ Failure ]
 webkit.org/b/232386 fast/backgrounds/background-inherit-color-bug.html [ Failure ]
+webkit.org/b/232386 fast/block/basic/minheight.html [ Failure ]
 webkit.org/b/232386 fast/block/float/031.html [ Failure ]
 webkit.org/b/232386 fast/block/float/033.html [ Failure ]
 webkit.org/b/232386 fast/block/float/clear-element-too-wide-for-containing-block.html [ Failure ]
 webkit.org/b/232386 fast/block/margin-collapse/100.html [ Failure ]
 webkit.org/b/232386 fast/block/margin-collapse/102.html [ Failure ]
+webkit.org/b/232386 fast/borders/border-radius-different-width-001.html [ Failure ]
 webkit.org/b/232386 fast/box-sizing/panels-one.html [ Failure ]
 webkit.org/b/232386 fast/box-sizing/panels-two.html [ Failure ]
 webkit.org/b/232386 fast/css-generated-content/010.html [ Failure ]
@@ -2516,6 +2518,7 @@
 webkit.org/b/232386 fast/css/link-alternate-stylesheet-4.html [ Failure ]
 webkit.org/b/232386 fast/css/link-alternate-stylesheet-5.html [ Failure ]
 webkit.org/b/232386 fast/css/nested-rounded-corners.html [ Failure ]
+webkit.org/b/232386 fast/css/xml-lang-ignored-in-html.html [ Failure ]
 webkit.org/b/232386 fast/css3-text/css3-word-spacing-percentage/word-spacing-crash.html [ Failure ]
 webkit.org/b/232386 fast/dom/client-width-height.html [ Failure ]
 webkit.org/b/232386 fast/dom/createAttribute-exception.html [ Failure ]
@@ -2524,7 +2527,13 @@
 webkit.org/b/232386 fast/dom/replaced-image-map.html [ Failure ]
 webkit.org/b/232386 fast/dom/rtl-scroll-to-leftmost-and-resize.html [ Failure ]
 webkit.org/b/232386 fast/dom/xml-parser-entity-in-attribute-value.html [ Failure ]
+webkit.org/b/232386 fast/dom/XMLSerializer-element-empty-namespace.html [ Failure ]
+webkit.org/b/232386 fast/dom/XMLSerializer-xml-namespace.html [ Failure ]
+webkit.org/b/232386 fast/dom/attribute-case-sensitivity.html [ Failure ]
 webkit.org/b/232386 fast/encoding/hanarei-blog32-fc2-com.html [ Failure ]
+webkit.org/b/232386 fast/encoding/pseudo-xml-3.html [ Failure ]
+webkit.org/b/232386 fast/encoding/pseudo-xml-4.html [ Failure ]
+webkit.org/b/232386 fast/encoding/pseudo-xml.html [ Failure ]
 webkit.org/b/232386 fast/encoding/yahoo-mail.html [ Failure ]
 webkit.org/b/232386 fast/events/dragging-mou

[webkit-changes] [285567] trunk

[rego]

Title: [285567] trunk








Revision 285567
Author r...@igalia.com
Date 2021-11-10 00:38:18 -0800 (Wed, 10 Nov 2021)


Log Message
Wavy decorations don't cover the whole line length
https://bugs.webkit.org/show_bug.cgi?id=232663

Reviewed by Myles C. Maxfield.

LayoutTests/imported/w3c:

Import WPT tests from https://github.com/web-platform-tests/wpt/pull/31540.

* web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001-expected-mismatch.html: Added.
* web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001.html: Added.
* web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001-expected-mismatch.html: Added.
* web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001.html: Added.
* web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001-expected-mismatch.html: Added.
* web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001.html: Added.
* web-platform-tests/css/css-text-decor/w3c-import.log:

Source/WebCore:

We have a problem with wavy decorations, because we are only painting
whole waves. Which means that, sometimes, the last part of the line
is not covered by the wavy decorations.

To fix this we're modifying strokeWavyTextDecoration() method.
We paint 2 extra waves before and after the line width,
and we clip the wavy text decoration to match the line's width.

This patch also removes adjustStepToDecorationLength() as the method
was wrong (e.g. passing 40px length and 10px step, it'd modify the step
to be 10.75px which makes no sense).
Apart from that, as we're now clipping the wave to the text line,
this adjustment is no longer needed.

Tests: imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001.html
   imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001.html
   imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001.html

* rendering/TextDecorationPainter.cpp:
(WebCore::strokeWavyTextDecoration):
(WebCore::adjustStepToDecorationLength): Deleted.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/TextDecorationPainter.cpp


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001-expected-mismatch.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001-expected-mismatch.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001-expected-mismatch.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001.html




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285566 => 285567)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-10 08:20:30 UTC (rev 285566)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-10 08:38:18 UTC (rev 285567)
@@ -1,3 +1,20 @@
+2021-11-10  Manuel Rego Casasnovas  
+
+Wavy decorations don't cover the whole line length
+https://bugs.webkit.org/show_bug.cgi?id=232663
+
+Reviewed by Myles C. Maxfield.
+
+Import WPT tests from https://github.com/web-platform-tests/wpt/pull/31540.
+
+* web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001-expected-mismatch.html: Added.
+* web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001.html: Added.
+* web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001-expected-mismatch.html: Added.
+* web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001.html: Added.
+* web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001-expected-mismatch.html: Added.
+* web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001.html: Added.
+* web-platform-tests/css/css-text-decor/w3c-import.log:
+
 2021-11-09  Ben Nham  
 
 Add support for PushSubscriptionChangeEvent


Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-dec

[webkit-changes] [285566] trunk

[sihui_liu]

Title: [285566] trunk








Revision 285566
Author sihui_...@apple.com
Date 2021-11-10 00:20:30 -0800 (Wed, 10 Nov 2021)


Log Message
Perform FileSystemSyncAccessHandle operations in web process
https://bugs.webkit.org/show_bug.cgi?id=232146


Reviewed by Youenn Fablet.

Source/WebCore:

truncate(), getSize() and flush() operations are now performed on a global WorkQueue in web process.

* Modules/filesystemaccess/FileSystemFileHandle.cpp:
(WebCore::FileSystemFileHandle::getSize): Deleted.
(WebCore::FileSystemFileHandle::truncate): Deleted.
(WebCore::FileSystemFileHandle::flush): Deleted.
* Modules/filesystemaccess/FileSystemFileHandle.h:
* Modules/filesystemaccess/FileSystemStorageConnection.h:
* Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp:
(WebCore::FileSystemSyncAccessHandle::~FileSystemSyncAccessHandle):
(WebCore::FileSystemSyncAccessHandle::truncate):
(WebCore::FileSystemSyncAccessHandle::getSize):
(WebCore::FileSystemSyncAccessHandle::flush):
(WebCore::FileSystemSyncAccessHandle::close):
(WebCore::FileSystemSyncAccessHandle::closeInternal):
(WebCore::FileSystemSyncAccessHandle::closeBackend):
(WebCore::FileSystemSyncAccessHandle::read):
(WebCore::FileSystemSyncAccessHandle::write):
(WebCore::FileSystemSyncAccessHandle::completePromise):
* Modules/filesystemaccess/FileSystemSyncAccessHandle.h:
(): Deleted.
* Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp:
(WebCore::WorkerFileSystemStorageConnection::completeIntegerCallback): Deleted.
(WebCore::WorkerFileSystemStorageConnection::getSize): Deleted.
(WebCore::WorkerFileSystemStorageConnection::truncate): Deleted.
(WebCore::WorkerFileSystemStorageConnection::flush): Deleted.
* Modules/filesystemaccess/WorkerFileSystemStorageConnection.h:
* workers/WorkerGlobalScope.cpp:
(WebCore::sharedFileSystemStorageQueue):
(WebCore::WorkerGlobalScope::postFileSystemStorageTask):
* workers/WorkerGlobalScope.h:

Source/WebKit:

Network process no longer needs to hold open file handle for FileSystemSyncAccessHandle. Now it creates an open
file handle, pass it to web process and close it.

* NetworkProcess/storage/FileSystemStorageError.h:
(WebKit::convertToException):
* NetworkProcess/storage/FileSystemStorageHandle.cpp:
(WebKit::FileSystemStorageHandle::createSyncAccessHandle):
(WebKit::FileSystemStorageHandle::close):
(WebKit::FileSystemStorageHandle::move):
(WebKit::FileSystemStorageHandle::~FileSystemStorageHandle): Deleted.
(WebKit::FileSystemStorageHandle::getSize): Deleted.
(WebKit::FileSystemStorageHandle::truncate): Deleted.
(WebKit::FileSystemStorageHandle::flush): Deleted.
* NetworkProcess/storage/FileSystemStorageHandle.h:
(): Deleted.
* NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::createSyncAccessHandle):
(WebKit::NetworkStorageManager::getSizeForAccessHandle): Deleted.
(WebKit::NetworkStorageManager::truncateForAccessHandle): Deleted.
(WebKit::NetworkStorageManager::flushForAccessHandle): Deleted.
* NetworkProcess/storage/NetworkStorageManager.h:
* NetworkProcess/storage/NetworkStorageManager.messages.in:
* Platform/IPC/SharedFileHandle.cpp:
(IPC::SharedFileHandle::close):
* Platform/IPC/SharedFileHandle.h:
* WebProcess/WebCoreSupport/WebFileSystemStorageConnection.cpp:
(WebKit::WebFileSystemStorageConnection::getSize): Deleted.
(WebKit::WebFileSystemStorageConnection::truncate): Deleted.
(WebKit::WebFileSystemStorageConnection::flush): Deleted.
* WebProcess/WebCoreSupport/WebFileSystemStorageConnection.h:

LayoutTests:

* storage/filesystemaccess/handle-move-worker-expected.txt:
* storage/filesystemaccess/resources/handle-move.js:
(async test):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/filesystemaccess/handle-move-worker-expected.txt
trunk/LayoutTests/storage/filesystemaccess/resources/handle-move.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp
trunk/Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.h
trunk/Source/WebCore/Modules/filesystemaccess/FileSystemStorageConnection.h
trunk/Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp
trunk/Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h
trunk/Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp
trunk/Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.h
trunk/Source/WebCore/workers/WorkerGlobalScope.cpp
trunk/Source/WebCore/workers/WorkerGlobalScope.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h
trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp
trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.h
trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in
trunk/Source/WebKit/Platform/IPC/SharedFileHandle.cpp
trunk/Source/