[webkit-changes] [286590] trunk/Source/WebKit
Title: [286590] trunk/Source/WebKit Revision 286590 Author pvol...@apple.com Date 2021-12-06 23:30:07 -0800 (Mon, 06 Dec 2021) Log Message [iOS] Remove mach service extensions for the WebContent process https://bugs.webkit.org/show_bug.cgi?id=232952 Reviewed by Brent Fulgham. Remove mach service extensions for the WebContent process, which we think are no longer needed, based on local testing. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): (WebKit::nonBrowserServices): Deleted. * UIProcess/WebPageProxy.cpp: (WebKit::attachmentElementServices): * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp trunk/Source/WebKit/Shared/WebProcessCreationParameters.h trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Diff Modified: trunk/Source/WebKit/ChangeLog (286589 => 286590) --- trunk/Source/WebKit/ChangeLog 2021-12-07 07:19:06 UTC (rev 286589) +++ trunk/Source/WebKit/ChangeLog 2021-12-07 07:30:07 UTC (rev 286590) @@ -1,3 +1,26 @@ +2021-12-06 Per Arne + +[iOS] Remove mach service extensions for the WebContent process +https://bugs.webkit.org/show_bug.cgi?id=232952 + + +Reviewed by Brent Fulgham. + +Remove mach service extensions for the WebContent process, which we think are no longer needed, based on local testing. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: +* Shared/WebProcessCreationParameters.cpp: +(WebKit::WebProcessCreationParameters::encode const): +(WebKit::WebProcessCreationParameters::decode): +* Shared/WebProcessCreationParameters.h: +* UIProcess/Cocoa/WebProcessPoolCocoa.mm: +(WebKit::WebProcessPool::platformInitializeWebProcess): +(WebKit::nonBrowserServices): Deleted. +* UIProcess/WebPageProxy.cpp: +(WebKit::attachmentElementServices): +* WebProcess/cocoa/WebProcessCocoa.mm: +(WebKit::WebProcess::platformInitializeWebProcess): + 2021-12-06 Patrick Angle [Cocoa] Web Inspector: Unify Grid overlay drawing code Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (286589 => 286590) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-12-07 07:19:06 UTC (rev 286589) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-12-07 07:30:07 UTC (rev 286590) @@ -1123,10 +1123,7 @@ (require-all (extension "com.apple.webkit.extension.mach") (global-name -"com.apple.PowerManagement.control" -"com.apple.frontboard.systemappservices" "com.apple.iconservices" -"com.apple.lsd.open" ) ) ) Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp (286589 => 286590) --- trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2021-12-07 07:19:06 UTC (rev 286589) +++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2021-12-07 07:30:07 UTC (rev 286590) @@ -171,7 +171,6 @@ #endif #if PLATFORM(IOS_FAMILY) -encoder << dynamicMachExtensionHandles; encoder << dynamicIOKitExtensionHandles; #endif @@ -485,12 +484,6 @@ #endif #if PLATFORM(IOS_FAMILY) -std::optional> dynamicMachExtensionHandles; -decoder >> dynamicMachExtensionHandles; -if (!dynamicMachExtensionHandles) -return false; -parameters.dynamicMachExtensionHandles = WTFMove(*dynamicMachExtensionHandles); - std::optional> dynamicIOKitExtensionHandles; decoder >> dynamicIOKitExtensionHandles; if (!dynamicIOKitExtensionHandles) Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.h (286589 => 286590) --- trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2021-12-07 07:19:06 UTC (rev 286589) +++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2021-12-07 07:30:07 UTC (rev 286590) @@ -209,7 +209,6 @@ #endif #if PLATFORM(IOS_FAMILY) -Vector dynamicMachExtensionHandles; Vector dynamicIOKitExtensionHandles; #endif Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (286589 => 286590) --- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2021-12-07 07:19:06 UTC (rev 286589) +++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2021-12-07 07:30:07 UTC (rev 286590) @@ -282,20
[webkit-changes] [286589] trunk
Title: [286589] trunk Revision 286589 Author s...@apple.com Date 2021-12-06 23:19:06 -0800 (Mon, 06 Dec 2021) Log Message [GPU Process] [Filters] Make FilterEffect::externalRepresentation() and its overridable functions work iteratively https://bugs.webkit.org/show_bug.cgi?id=233893 Reviewed by Cameron McCormack. Source/WebCore: This is a step towards removing the inputEffect() from FilterEffect. -- The enum FliterEffect::RepresentationType is replaced by FilterRepresentation. -- CSSFilter calls its functions from left to right to dump their externalRepresentation. -- SVGFilter uses its _expression_ to dump its graph of FilterEffects. -- Since SourceAlpha is a built-in effect it does not need to dump SourceGraphic as its input. * platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::externalRepresentation const): * platform/graphics/filters/FEBlend.h: * platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::externalRepresentation const): * platform/graphics/filters/FEColorMatrix.h: * platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::externalRepresentation const): * platform/graphics/filters/FEComponentTransfer.h: * platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::externalRepresentation const): * platform/graphics/filters/FEComposite.h: * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::externalRepresentation const): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::externalRepresentation const): * platform/graphics/filters/FEDiffuseLighting.h: * platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::externalRepresentation const): * platform/graphics/filters/FEDisplacementMap.h: * platform/graphics/filters/FEDropShadow.cpp: (WebCore::FEDropShadow::externalRepresentation const): * platform/graphics/filters/FEDropShadow.h: * platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::externalRepresentation const): * platform/graphics/filters/FEFlood.h: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::externalRepresentation const): * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FEMerge.cpp: (WebCore::FEMerge::externalRepresentation const): * platform/graphics/filters/FEMerge.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::externalRepresentation const): * platform/graphics/filters/FEMorphology.h: * platform/graphics/filters/FEOffset.cpp: (WebCore::FEOffset::externalRepresentation const): * platform/graphics/filters/FEOffset.h: * platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::externalRepresentation const): * platform/graphics/filters/FESpecularLighting.h: * platform/graphics/filters/FETile.cpp: (WebCore::FETile::externalRepresentation const): * platform/graphics/filters/FETile.h: * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::externalRepresentation const): * platform/graphics/filters/FETurbulence.h: * platform/graphics/filters/Filter.h: * platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::externalRepresentation const): (WebCore::operator<<): * platform/graphics/filters/FilterEffect.h: * platform/graphics/filters/FilterFunction.h: * platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::externalRepresentation const): * platform/graphics/filters/SourceAlpha.h: * platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::externalRepresentation const): * platform/graphics/filters/SourceGraphic.h: * rendering/CSSFilter.cpp: (WebCore::CSSFilter::externalRepresentation const): * rendering/CSSFilter.h: * rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): * svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::externalRepresentation const): * svg/graphics/filters/SVGFEImage.h: * svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::externalRepresentation const): * svg/graphics/filters/SVGFilter.h: * svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::effectGeometryFlagsForElement): (WebCore::SVGFilterBuilder::buildFilterEffects): (WebCore::SVGFilterBuilder::buildEffectExpression const): (WebCore::SVGFilterBuilder::buildExpression const): (WebCore::boundarySetFlagsForElement): Deleted. * svg/graphics/filters/SVGFilterBuilder.h: * svg/graphics/filters/SVGFilterExpression.h: LayoutTests: Add missing closing quotations in the expected results of some of the filter layout tests. * svg/filters/feDropShadow-expected.txt: * svg/filters/feDropShadow-subregion-expected.txt: * svg/filters/feDropShadow-zero-deviation-expected.txt: * svg/repaint/filter-child-repaint-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/svg/filters/feDropShadow-expected.txt trunk/LayoutTests/svg/filters/feDropShadow-subregion-expected.txt
[webkit-changes] [286588] trunk/Source
Title: [286588] trunk/Source Revision 286588 Author pan...@apple.com Date 2021-12-06 22:20:45 -0800 (Mon, 06 Dec 2021) Log Message [Cocoa] Web Inspector: Unify Grid overlay drawing code https://bugs.webkit.org/show_bug.cgi?id=233773 Reviewed by Devin Rousso. Source/WebCore: Expose InspectorOverlay::drawGridOverlay as a static method so that it can be used for iOS overlay drawing and clean up other related drawing methods to be private static instead of instance methods or public static methods. * inspector/InspectorOverlay.cpp: (WebCore::drawLayoutHatching): (WebCore::fontForLayoutLabel): (WebCore::backgroundPathForLayoutLabel): (WebCore::expectedSizeForLayoutLabel): (WebCore::drawLayoutLabel): (WebCore::InspectorOverlay::drawLayoutHatching): Deleted. (WebCore::InspectorOverlay::fontForLayoutLabel): Deleted. (WebCore::InspectorOverlay::backgroundPathForLayoutLabel): Deleted. (WebCore::InspectorOverlay::drawLayoutLabel): Deleted. * inspector/InspectorOverlay.h: Source/WebKit: Remove the (almost) 1-to-1 duplicated logic currently being used to turn Grid Overlays into a layer hierarchy and instead use a graphics context to draw the overlays straight into the view to take advantage of the existing drawing code we use for macOS in WebCore::InspectorOverlay. To accommodate this, we now correctly set the content scale factor of the view itself (so that our drawing does not appear blurry) and set the frame of the view equal to the current visible portion of the parent scroll view, which helps us to avoid having an incredibly large graphics context to draw into (which we would if the view's frame was just set to match the frame of the webpage's view). This frame will not always be the same size, such as when zooming in where less of the frame is visible. Combined with the current content scale, this actually means that on zoom the effective number of pixels that need to be drawn is consistent. * UIProcess/Inspector/ios/WKInspectorHighlightView.h: * UIProcess/Inspector/ios/WKInspectorHighlightView.mm: (-[WKInspectorHighlightView initWithFrame:]): - Explicitly set this view to be non-opaque so that page content can be seen below this view. This wasn't previously necessary because the bounds of this view were a zero-rect, which meant the background was never painted. (-[WKInspectorHighlightView _removeAllLayers]): (-[WKInspectorHighlightView _createLayers:]): - Because the view's frame origin is now offset, we need to create the node highlight layers offset by the negation of the frame's origin so that they still line up correctly with page content. (-[WKInspectorHighlightView drawRect:]): (-[WKInspectorHighlightView update:scale:frame:]): (-[WKInspectorHighlightView _createGridOverlayLayers:scale:]): Deleted. (createLayoutHatchingLayer): Deleted. (createLayoutLabelLayer): Deleted. (-[WKInspectorHighlightView _createGridOverlayLayer:scale:]): Deleted. (-[WKInspectorHighlightView update:scale:]): Deleted. * UIProcess/ios/WKContentView.mm: (-[WKContentView _showInspectorHighlight:]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorOverlay.cpp trunk/Source/WebCore/inspector/InspectorOverlay.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Inspector/ios/WKInspectorHighlightView.h trunk/Source/WebKit/UIProcess/Inspector/ios/WKInspectorHighlightView.mm trunk/Source/WebKit/UIProcess/ios/WKContentView.mm Diff Modified: trunk/Source/WebCore/ChangeLog (286587 => 286588) --- trunk/Source/WebCore/ChangeLog 2021-12-07 05:52:22 UTC (rev 286587) +++ trunk/Source/WebCore/ChangeLog 2021-12-07 06:20:45 UTC (rev 286588) @@ -1,3 +1,25 @@ +2021-12-06 Patrick Angle + +[Cocoa] Web Inspector: Unify Grid overlay drawing code +https://bugs.webkit.org/show_bug.cgi?id=233773 + +Reviewed by Devin Rousso. + +Expose InspectorOverlay::drawGridOverlay as a static method so that it can be used for iOS overlay drawing and +clean up other related drawing methods to be private static instead of instance methods or public static methods. + +* inspector/InspectorOverlay.cpp: +(WebCore::drawLayoutHatching): +(WebCore::fontForLayoutLabel): +(WebCore::backgroundPathForLayoutLabel): +(WebCore::expectedSizeForLayoutLabel): +(WebCore::drawLayoutLabel): +(WebCore::InspectorOverlay::drawLayoutHatching): Deleted. +(WebCore::InspectorOverlay::fontForLayoutLabel): Deleted. +(WebCore::InspectorOverlay::backgroundPathForLayoutLabel): Deleted. +(WebCore::InspectorOverlay::drawLayoutLabel): Deleted. +* inspector/InspectorOverlay.h: + 2021-12-06 Chris Dumez 's range should be reversible Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (286587 => 286588) --- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2021-12-07 05:52:22 UTC (rev 286587) +++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2021-12-07 06:20:45 UTC (rev 286588)
[webkit-changes] [286587] trunk/Source/bmalloc
Title: [286587] trunk/Source/bmalloc Revision 286587 Author fpi...@apple.com Date 2021-12-06 21:52:22 -0800 (Mon, 06 Dec 2021) Log Message [libpas] Clean up what the machine code looks like under LTO https://bugs.webkit.org/show_bug.cgi?id=233909 Reviewed by Yusuke Suzuki. During the very painful perf burndown of libpas that got it to be a progression (rather than a regression) versus bmalloc, I found that certain key fast paths - like fastMalloc and fastFree - perform better when they do not have a stack frame. For this to happen, they must only make tail calls. Sadly, LTO was inlining a slow path into fastFree (i.e. pas_deallocate), and this slow path had an assertion, and the call to pas_assertion_failed was not a tail call. This fixes the problem comprehensively: - We now compile pas_assertion_failed as a breakpoint, just like WebKit would do. This is better for code size and maybe it could sometimes be better for performance. - The slow path that was getting inlined is now marked PAS_NEVER_INLINE. - Inspecting the machine code, I found a couple other slow paths that were being inlined in a bunch of places, and also marked them NEVER_INLINE. If my past experiences are right, this could be a tiny speed-up on malloc-heavy workloads. * libpas/src/libpas/pas_lock.c: (pas_lock_lock_slow): * libpas/src/libpas/pas_lock.h: * libpas/src/libpas/pas_monotonic_time.c: (get_timebase_info_slow): (get_timebase_info): * libpas/src/libpas/pas_thread_local_cache.c: (pas_thread_local_cache_append_deallocation_slow): * libpas/src/libpas/pas_thread_local_cache.h: * libpas/src/libpas/pas_utils.c: * libpas/src/libpas/pas_utils.h: (pas_assertion_failed): (pas_assertion_failed_noreturn_silencer): Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/libpas/src/libpas/pas_lock.c trunk/Source/bmalloc/libpas/src/libpas/pas_lock.h trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.h trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h Diff Modified: trunk/Source/bmalloc/ChangeLog (286586 => 286587) --- trunk/Source/bmalloc/ChangeLog 2021-12-07 04:12:27 UTC (rev 286586) +++ trunk/Source/bmalloc/ChangeLog 2021-12-07 05:52:22 UTC (rev 286587) @@ -1,3 +1,43 @@ +2021-12-06 Filip Pizlo + +[libpas] Clean up what the machine code looks like under LTO +https://bugs.webkit.org/show_bug.cgi?id=233909 + +Reviewed by Yusuke Suzuki. + +During the very painful perf burndown of libpas that got it to be a progression (rather than a +regression) versus bmalloc, I found that certain key fast paths - like fastMalloc and fastFree - perform +better when they do not have a stack frame. For this to happen, they must only make tail calls. + +Sadly, LTO was inlining a slow path into fastFree (i.e. pas_deallocate), and this slow path had an +assertion, and the call to pas_assertion_failed was not a tail call. + +This fixes the problem comprehensively: + +- We now compile pas_assertion_failed as a breakpoint, just like WebKit would do. This is better for + code size and maybe it could sometimes be better for performance. + +- The slow path that was getting inlined is now marked PAS_NEVER_INLINE. + +- Inspecting the machine code, I found a couple other slow paths that were being inlined in a bunch of + places, and also marked them NEVER_INLINE. + +If my past experiences are right, this could be a tiny speed-up on malloc-heavy workloads. + +* libpas/src/libpas/pas_lock.c: +(pas_lock_lock_slow): +* libpas/src/libpas/pas_lock.h: +* libpas/src/libpas/pas_monotonic_time.c: +(get_timebase_info_slow): +(get_timebase_info): +* libpas/src/libpas/pas_thread_local_cache.c: +(pas_thread_local_cache_append_deallocation_slow): +* libpas/src/libpas/pas_thread_local_cache.h: +* libpas/src/libpas/pas_utils.c: +* libpas/src/libpas/pas_utils.h: +(pas_assertion_failed): +(pas_assertion_failed_noreturn_silencer): + 2021-12-06 Yusuke Suzuki [libpas] Set pthread_setspecific with marker in TLS destructor to detect TLS is destroyed Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_lock.c (286586 => 286587) --- trunk/Source/bmalloc/libpas/src/libpas/pas_lock.c 2021-12-07 04:12:27 UTC (rev 286586) +++ trunk/Source/bmalloc/libpas/src/libpas/pas_lock.c 2021-12-07 05:52:22 UTC (rev 286587) @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020 Apple Inc. All rights reserved. + * Copyright (c) 2020-2021 Apple Inc. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -31,7 +31,7 @@ #if PAS_USE_SPINLOCKS -void
[webkit-changes] [286586] trunk/LayoutTests
Title: [286586] trunk/LayoutTests Revision 286586 Author lmo...@igalia.com Date 2021-12-06 20:12:27 -0800 (Mon, 06 Dec 2021) Log Message [GLIB] Small gardening Unreviewed test gardening. * platform/glib/TestExpectations: * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (286585 => 286586) --- trunk/LayoutTests/ChangeLog 2021-12-07 03:40:42 UTC (rev 286585) +++ trunk/LayoutTests/ChangeLog 2021-12-07 04:12:27 UTC (rev 286586) @@ -1,3 +1,12 @@ +2021-12-06 Lauro Moura + +[GLIB] Small gardening + +Unreviewed test gardening. + +* platform/glib/TestExpectations: +* platform/wpe/TestExpectations: + 2021-12-06 Arcady Goldmints-Orlov [GTK][WPE] Mathml asserts with invisible operators Modified: trunk/LayoutTests/platform/glib/TestExpectations (286585 => 286586) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-12-07 03:40:42 UTC (rev 286585) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-12-07 04:12:27 UTC (rev 286586) @@ -792,6 +792,8 @@ webkit.org/b/233731 fast/mediastream/getDisplayMedia-size.html [ Failure ] +webkit.org/b/233836 http/tests/media/media-blocked-by-willsendrequest.html [ Timeout ] + # # End of GStreamer-related bugs # Modified: trunk/LayoutTests/platform/wpe/TestExpectations (286585 => 286586) --- trunk/LayoutTests/platform/wpe/TestExpectations 2021-12-07 03:40:42 UTC (rev 286585) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-12-07 04:12:27 UTC (rev 286586) @@ -269,6 +269,9 @@ webkit.org/b/220614 imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath.svg [ Failure Pass ] webkit.org/b/222895 imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size.svg [ Failure Pass ] +# UIScriptController +webkit.org/b/205159 fast/scrolling/overflow-scroll-past-max.html [ Crash ] + # WebGL webkit.org/b/213203 webgl/1.0.3/conformance/rendering/multisample-corruption.html [ Failure Timeout ] @@ -916,7 +919,6 @@ webkit.org/b/212202 fast/scrolling/arrow-key-scroll-in-rtl-document.html [ Timeout ] webkit.org/b/212202 fast/scrolling/iframe-scrollable-after-back.html [ Timeout ] -webkit.org/b/212202 fast/scrolling/overflow-scroll-past-max.html [ Timeout ] webkit.org/b/212202 fast/scrolling/programmatic-scroll-to-zero-zero.html [ Timeout ] webkit.org/b/212202 fast/scrolling/rtl-point-in-iframe.html [ Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286585] trunk/Source/WebKit
Title: [286585] trunk/Source/WebKit
Revision 286585
Author lmo...@igalia.com
Date 2021-12-06 19:40:42 -0800 (Mon, 06 Dec 2021)
Log Message
REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
https://bugs.webkit.org/show_bug.cgi?id=233881
Reviewed by Don Olmstead.
Build fix. Covered by existing tests
The previous approach of this patch created the links to the header
derived sources into the target webkit2/ folder, which in turn was a
link to /Source/WebKit/UIProcess/API/gtk. So it ended up
actually creating the links inside the Source directory.
This commit instead links a different webkit2/ folder from the
generated webkit folder for the WebKitGTK/WPE derived sources headers.
* PlatformGTK.cmake:
* PlatformWPE.cmake:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
Diff
Modified: trunk/Source/WebKit/ChangeLog (286584 => 286585)
--- trunk/Source/WebKit/ChangeLog 2021-12-07 01:57:44 UTC (rev 286584)
+++ trunk/Source/WebKit/ChangeLog 2021-12-07 03:40:42 UTC (rev 286585)
@@ -1,3 +1,23 @@
+2021-12-06 Lauro Moura
+
+REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
+https://bugs.webkit.org/show_bug.cgi?id=233881
+
+Reviewed by Don Olmstead.
+
+Build fix. Covered by existing tests
+
+The previous approach of this patch created the links to the header
+derived sources into the target webkit2/ folder, which in turn was a
+link to /Source/WebKit/UIProcess/API/gtk. So it ended up
+actually creating the links inside the Source directory.
+
+This commit instead links a different webkit2/ folder from the
+generated webkit folder for the WebKitGTK/WPE derived sources headers.
+
+* PlatformGTK.cmake:
+* PlatformWPE.cmake:
+
2021-12-06 Brady Eidson
webpushd/webpushtool debugging additions
Modified: trunk/Source/WebKit/PlatformGTK.cmake (286584 => 286585)
--- trunk/Source/WebKit/PlatformGTK.cmake 2021-12-07 01:57:44 UTC (rev 286584)
+++ trunk/Source/WebKit/PlatformGTK.cmake 2021-12-07 03:40:42 UTC (rev 286585)
@@ -875,21 +875,11 @@
COMMAND ln -n -s -f ${WEBKIT_DIR}/UIProcess/API/gtk ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2
)
add_custom_command(
-OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
-DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitEnumTypes.h
-COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitEnumTypes.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
+OUTPUT ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit2
+DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit
+COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit2
)
add_custom_command(
-OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
-DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitWebProcessEnumTypes.h
-COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitWebProcessEnumTypes.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
-)
-add_custom_command(
-OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
-DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitVersion.h
-COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitVersion.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
-)
-add_custom_command(
OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
DEPENDS ${WEBKIT_DIR}/UIProcess/API/gtk${GTK_API_VERSION}
COMMAND ln -n -s -f ${WEBKIT_DIR}/UIProcess/API/gtk${GTK_API_VERSION} ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
@@ -906,9 +896,7 @@
)
add_custom_target(WebKit-fake-api-headers
DEPENDS ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2
-${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
-${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
-${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
+${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit2
${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-webextension/webkit2
${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-webextension/webkitdom
Modified: trunk/Source/WebKit/PlatformWPE.cmake (286584 => 286585)
--- trunk/Source/WebKit/PlatformWPE.cmake 2021-12-07 01:57:44 UTC (rev 286584)
+++ trunk/Source/WebKit/PlatformWPE.cmake 2021-12-07 03:40:42 UTC (rev 286585)
@@ -55,6 +55,12 @@
)
add_custom_command(
+OUTPUT ${DERIVED_SOURCES_WPE_API_DIR}/webkit2
+DEPENDS ${DERIVED_SOURCES_WPE_API_DIR}/webkit
+COMMAND ln -n -s -f ${DERIVED_SOURCES_WPE_API_DIR}/webkit ${DERIVED_SOURCES_WPE_API_DIR}/webkit2
+)
+
[webkit-changes] [286584] trunk/LayoutTests
Title: [286584] trunk/LayoutTests Revision 286584 Author commit-qu...@webkit.org Date 2021-12-06 17:57:44 -0800 (Mon, 06 Dec 2021) Log Message [GTK][WPE] Mathml asserts with invisible operators https://bugs.webkit.org/show_bug.cgi?id=215217 Unreviewed test gardening. Remove test failures from expectations as the assert was removed. Patch by Arcady Goldmints-Orlov on 2021-12-06 * platform/glib/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (286583 => 286584) --- trunk/LayoutTests/ChangeLog 2021-12-07 01:52:17 UTC (rev 286583) +++ trunk/LayoutTests/ChangeLog 2021-12-07 01:57:44 UTC (rev 286584) @@ -1,5 +1,16 @@ 2021-12-06 Arcady Goldmints-Orlov +[GTK][WPE] Mathml asserts with invisible operators +https://bugs.webkit.org/show_bug.cgi?id=215217 + +Unreviewed test gardening. + +Remove test failures from expectations as the assert was removed. + +* platform/glib/TestExpectations: + +2021-12-06 Arcady Goldmints-Orlov + [GLIB] Update test expectations and baselines. Unreviewed test gardening. https://bugs.webkit.org/show_bug.cgi?id=233898 Modified: trunk/LayoutTests/platform/glib/TestExpectations (286583 => 286584) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-12-07 01:52:17 UTC (rev 286583) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-12-07 01:57:44 UTC (rev 286584) @@ -851,25 +851,6 @@ # MathML-related bugs # -webkit.org/b/215217 [ Debug ] mathml/opentype/munderover-layout-resize.html [ Crash ] -webkit.org/b/215217 [ Debug ] mathml/presentation/mo-invisible.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005.html [ Crash ] -webkit.org/b/215217 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006.html [ Crash ] - webkit.org/b/216871 imported/w3c/web-platform-tests/mathml/relations/css-styling/color-004.tentative.html [ ImageOnlyFailure ] webkit.org/b/227122 imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286583] trunk/LayoutTests
Title: [286583] trunk/LayoutTests Revision 286583 Author commit-qu...@webkit.org Date 2021-12-06 17:52:17 -0800 (Mon, 06 Dec 2021) Log Message [GLIB] Update test expectations and baselines. Unreviewed test gardening. https://bugs.webkit.org/show_bug.cgi?id=233898 Patch by Arcady Goldmints-Orlov on 2021-12-06 * platform/glib/TestExpectations: * platform/gtk/TestExpectations: * platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (286582 => 286583) --- trunk/LayoutTests/ChangeLog 2021-12-07 01:19:58 UTC (rev 286582) +++ trunk/LayoutTests/ChangeLog 2021-12-07 01:52:17 UTC (rev 286583) @@ -1,3 +1,13 @@ +2021-12-06 Arcady Goldmints-Orlov + +[GLIB] Update test expectations and baselines. Unreviewed test gardening. +https://bugs.webkit.org/show_bug.cgi?id=233898 + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: +* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: + 2021-12-06 Chris Dumez 's range should be reversible Modified: trunk/LayoutTests/platform/glib/TestExpectations (286582 => 286583) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-12-07 01:19:58 UTC (rev 286582) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-12-07 01:52:17 UTC (rev 286583) @@ -609,6 +609,11 @@ webkit.org/b/233827 imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-rotate-slerp.html [ ImageOnlyFailure Pass ] +webkit.org/b/223884 imported/w3c/web-platform-tests/css/css-values/ic-unit-013.html [ ImageOnlyFailure ] + +webkit.org/b/233897 imported/w3c/web-platform-tests/css/motion/offset-distance-002.html [ ImageOnlyFailure ] +webkit.org/b/233897 imported/w3c/web-platform-tests/css/motion/offset-distance-003.html [ ImageOnlyFailure ] + # # End of CSS-related bugs # @@ -1121,7 +1126,6 @@ webkit.org/b/129958 svg/clip-path/mask-nested-clip-path-007.svg [ ImageOnlyFailure ] webkit.org/b/129958 svg/clip-path/mask-nested-clip-path-008.svg [ ImageOnlyFailure ] webkit.org/b/129958 svg/clip-path/mask-nested-clip-path-009.svg [ ImageOnlyFailure ] -webkit.org/b/129958 svg/clip-path/mask-nested-clip-path-010.svg [ ImageOnlyFailure ] webkit.org/b/129958 svg/clip-path/mask-objectboundingbox-content-clip-transform.svg [ ImageOnlyFailure ] webkit.org/b/129958 svg/clip-path/mask-objectboundingbox-content-clip.svg [ ImageOnlyFailure ] webkit.org/b/129958 svg/clip-path/mask-userspaceonuse-content-clip-transform.svg [ ImageOnlyFailure ] @@ -1347,8 +1351,6 @@ webkit.org/b/219825 [ Release ] webrtc/sframe-keys.html [ Skip ] webkit.org/b/219825 [ Debug ] webrtc/sframe-keys.html [ Failure ] -webkit.org/b/222794 webrtc/multi-video.html [ Failure ] - webkit.org/b/224074 webrtc/concurrentVideoPlayback.html [ Timeout Pass ] webkit.org/b/206656 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-removetrack.https.html [ Crash Failure Timeout ] @@ -1363,6 +1365,8 @@ webkit.org/b/233740 webrtc/vp9-svc.html [ Timeout ] webkit.org/b/233740 webrtc/vp9.html [ Timeout ] +webkit.org/b/233879 fast/mediastream/get-display-media-settings.html [ Failure ] + # # End of WebRTC-related bugs # @@ -2504,6 +2508,7 @@ webkit.org/b/231818 imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-getSize.https.tentative.worker.html [ Failure ] webkit.org/b/231818 imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker.html [ Failure ] webkit.org/b/231818 imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-truncate.https.tentative.worker.html [ Failure ] +webkit.org/b/231818 storage/filesystemaccess/file-handle-getfile-worker.html [ Failure ]
[webkit-changes] [286582] trunk/Tools
Title: [286582] trunk/Tools
Revision 286582
Author wilan...@apple.com
Date 2021-12-06 17:19:58 -0800 (Mon, 06 Dec 2021)
Log Message
Add WebCore::RegistrableDomain tests for duplicate sub domains
https://bugs.webkit.org/show_bug.cgi?id=233902
Unreviewed expansion of the RegistrableDomain.MatchesURLs API test.
https://bugs.webkit.org/show_bug.cgi?id=20 claims that duplicate sub domains
such as news.news.example.com causes WebKit's RegistrableDomain matching to fail
and treat same-site content as cross-site. This patch add tests of such duplicate
sub domains.
* TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp
Diff
Modified: trunk/Tools/ChangeLog (286581 => 286582)
--- trunk/Tools/ChangeLog 2021-12-07 01:15:26 UTC (rev 286581)
+++ trunk/Tools/ChangeLog 2021-12-07 01:19:58 UTC (rev 286582)
@@ -1,3 +1,19 @@
+2021-12-06 John Wilander
+
+Add WebCore::RegistrableDomain tests for duplicate sub domains
+https://bugs.webkit.org/show_bug.cgi?id=233902
+
+
+Unreviewed expansion of the RegistrableDomain.MatchesURLs API test.
+
+https://bugs.webkit.org/show_bug.cgi?id=20 claims that duplicate sub domains
+such as news.news.example.com causes WebKit's RegistrableDomain matching to fail
+and treat same-site content as cross-site. This patch add tests of such duplicate
+sub domains.
+
+* TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
+(TestWebKitAPI::TEST):
+
2021-12-06 Brady Eidson
webpushd/webpushtool debugging additions
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp (286581 => 286582)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp 2021-12-07 01:15:26 UTC (rev 286581)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp 2021-12-07 01:19:58 UTC (rev 286582)
@@ -58,13 +58,19 @@
URL webkitURL { URL(), "https://webkit.org" };
URL webkitURLWithPath { URL(), "https://webkit.org/road/to/nowhere/" };
URL webkitSubdomainURL { URL(), "https://sub.domain.webkit.org" };
+URL webkitOtherSubdomainURL { URL(), "https://sub.other.webkit.org" };
+URL webkitDuplicateSubdomainURL { URL(), "https://domain.domain.webkit.org" };
URL webkitSubdomainURLWithPath { URL(), "https://sub.domain.webkit.org/road/to/nowhere/" };
RegistrableDomain webkitDomain { webkitURL };
+RegistrableDomain webkitSubdomain { webkitSubdomainURL };
ASSERT_TRUE(webkitDomain.matches(webkitURL));
ASSERT_TRUE(webkitDomain.matches(webkitURLWithPath));
ASSERT_TRUE(webkitDomain.matches(webkitSubdomainURL));
+ASSERT_TRUE(webkitDomain.matches(webkitDuplicateSubdomainURL));
ASSERT_TRUE(webkitDomain.matches(webkitSubdomainURLWithPath));
+ASSERT_TRUE(webkitSubdomain.matches(webkitOtherSubdomainURL));
+ASSERT_TRUE(webkitSubdomain.matches(webkitDuplicateSubdomainURL));
URL localhostURL { URL(), "http://localhost" };
URL localhostURLWithPath { URL(), "http://localhost/road/to/nowhere/" };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286581] trunk
Title: [286581] trunk
Revision 286581
Author cdu...@apple.com
Date 2021-12-06 17:15:26 -0800 (Mon, 06 Dec 2021)
Log Message
's range should be reversible
https://bugs.webkit.org/show_bug.cgi?id=233835
Reviewed by Darin Adler.
Source/WebCore:
's range should be reversible when checking for overflow / underflow:
- https://html.spec.whatwg.org/#has-a-periodic-domain
No new tests, rebaselined existing tests.
* html/InputType.cpp:
(WebCore::InputType::rangeUnderflow const):
(WebCore::InputType::rangeOverflow const):
* html/StepRange.cpp:
(WebCore::StepRange::StepRange):
* html/StepRange.h:
(WebCore::StepRange::isReversible const):
* html/TimeInputType.cpp:
(WebCore::TimeInputType::createStepRange const):
LayoutTests:
Rebaseline WPT tests that are now passing.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow-expected.txt
trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow.html
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt
trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt
trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/StepRange.cpp
trunk/Source/WebCore/html/StepRange.h
trunk/Source/WebCore/html/TimeInputType.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (286580 => 286581)
--- trunk/LayoutTests/ChangeLog 2021-12-07 01:13:33 UTC (rev 286580)
+++ trunk/LayoutTests/ChangeLog 2021-12-07 01:15:26 UTC (rev 286581)
@@ -1,3 +1,15 @@
+2021-12-06 Chris Dumez
+
+'s range should be reversible
+https://bugs.webkit.org/show_bug.cgi?id=233835
+
+Reviewed by Darin Adler.
+
+Rebaseline WPT tests that are now passing.
+
+* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
+* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
+
2021-12-06 Ryan Haddad
[ iOS ] imported/w3c/web-platform-tests/content-security-policy/worker-src/service-* tests are consistently failing
Modified: trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow-expected.txt (286580 => 286581)
--- trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow-expected.txt 2021-12-07 01:13:33 UTC (rev 286580)
+++ trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow-expected.txt 2021-12-07 01:15:26 UTC (rev 286581)
@@ -13,7 +13,8 @@
PASS The value "13:16" overflows the maximum value "13:15".
PASS The value "23:59:59.999" overflows the maximum value "13:16".
PASS The value "13:16" overflows the maximum value "12:00".
-PASS The value "23:59:59.999" overflows the maximum value "13:16" when disabled.
+PASS The value "23:59:59.999" doesn't overflow the maximum value "13:16" when disabled.
+PASS The value "13:17:59.999" overflows the maximum value "13:16" when disabled.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow.html (286580 => 286581)
--- trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow.html 2021-12-07 01:13:33 UTC (rev 286580)
+++ trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow.html 2021-12-07 01:15:26 UTC (rev 286581)
@@ -66,7 +66,8 @@
checkOverflow('13:16', '12:00');
// Disabled
-checkOverflow('23:59:59.999', '13:16', true);
+checkNotOverflow('23:59:59.999', '13:16', true);
+checkOverflow('13:17:59.999', '13:16', true);
[webkit-changes] [286580] trunk/Source/JavaScriptCore
Title: [286580] trunk/Source/_javascript_Core
Revision 286580
Author keith_mil...@apple.com
Date 2021-12-06 17:13:33 -0800 (Mon, 06 Dec 2021)
Log Message
TypeInfo should be materializable from Structures as a single load.
https://bugs.webkit.org/show_bug.cgi?id=233875
Reviewed by Mark Lam.
This is mostly just the members of Structure and JSCell so that
JSType and InlineTypeFlags are at the end of the JSCell header.
* assembler/testmasm.cpp:
(JSC::testBranchIfType):
(JSC::testBranchIfNotType):
* ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
* runtime/JSCell.h:
* runtime/JSCellInlines.h:
(JSC::JSCell::JSCell):
* runtime/Structure.h:
(JSC::Structure::typeInfo const):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/testmasm.cpp
trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSCellInlines.h
trunk/Source/_javascript_Core/runtime/Structure.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (286579 => 286580)
--- trunk/Source/_javascript_Core/ChangeLog 2021-12-07 00:38:11 UTC (rev 286579)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-12-07 01:13:33 UTC (rev 286580)
@@ -1,3 +1,24 @@
+2021-12-06 Keith Miller
+
+TypeInfo should be materializable from Structures as a single load.
+https://bugs.webkit.org/show_bug.cgi?id=233875
+
+Reviewed by Mark Lam.
+
+This is mostly just the members of Structure and JSCell so that
+JSType and InlineTypeFlags are at the end of the JSCell header.
+
+* assembler/testmasm.cpp:
+(JSC::testBranchIfType):
+(JSC::testBranchIfNotType):
+* ftl/FTLAbstractHeapRepository.cpp:
+(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
+* runtime/JSCell.h:
+* runtime/JSCellInlines.h:
+(JSC::JSCell::JSCell):
+* runtime/Structure.h:
+(JSC::Structure::typeInfo const):
+
2021-12-06 Mark Lam
Remove unneeded virtual allocator methods from Subspace.
Modified: trunk/Source/_javascript_Core/assembler/testmasm.cpp (286579 => 286580)
--- trunk/Source/_javascript_Core/assembler/testmasm.cpp 2021-12-07 00:38:11 UTC (rev 286579)
+++ trunk/Source/_javascript_Core/assembler/testmasm.cpp 2021-12-07 01:13:33 UTC (rev 286580)
@@ -5613,6 +5613,7 @@
struct CellLike {
uint32_t structureID;
uint8_t indexingType;
+uint8_t cellState;
JSType type;
};
CHECK_EQ(JSCell::typeInfoTypeOffset(), OBJECT_OFFSETOF(CellLike, type));
@@ -5647,6 +5648,7 @@
struct CellLike {
uint32_t structureID;
uint8_t indexingType;
+uint8_t cellState;
JSType type;
};
CHECK_EQ(JSCell::typeInfoTypeOffset(), OBJECT_OFFSETOF(CellLike, type));
Modified: trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp (286579 => 286580)
--- trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp 2021-12-07 00:38:11 UTC (rev 286579)
+++ trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp 2021-12-07 01:13:33 UTC (rev 286580)
@@ -78,9 +78,9 @@
// Make sure that our explicit assumptions about the StructureIDBlob match reality.
RELEASE_ASSERT(!(JSCell_indexingTypeAndMisc.offset() & (sizeof(int32_t) - 1)));
-RELEASE_ASSERT(JSCell_indexingTypeAndMisc.offset() + 1 == JSCell_typeInfoType.offset());
-RELEASE_ASSERT(JSCell_indexingTypeAndMisc.offset() + 2 == JSCell_typeInfoFlags.offset());
-RELEASE_ASSERT(JSCell_indexingTypeAndMisc.offset() + 3 == JSCell_cellState.offset());
+RELEASE_ASSERT(JSCell_indexingTypeAndMisc.offset() + 1 == JSCell_cellState.offset());
+RELEASE_ASSERT(JSCell_indexingTypeAndMisc.offset() + 2 == JSCell_typeInfoType.offset());
+RELEASE_ASSERT(JSCell_indexingTypeAndMisc.offset() + 3 == JSCell_typeInfoFlags.offset());
JSCell_structureID.changeParent(_header);
JSCell_usefulBytes.changeParent(_header);
Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (286579 => 286580)
--- trunk/Source/_javascript_Core/runtime/JSCell.h 2021-12-07 00:38:11 UTC (rev 286579)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h 2021-12-07 01:13:33 UTC (rev 286580)
@@ -266,9 +266,9 @@
StructureID m_structureID;
IndexingType m_indexingTypeAndMisc; // DO NOT store to this field. Always CAS.
+CellState m_cellState;
JSType m_type;
TypeInfo::InlineTypeFlags m_flags;
-CellState m_cellState;
};
class JSCellLock : public JSCell {
Modified: trunk/Source/_javascript_Core/runtime/JSCellInlines.h (286579 => 286580)
--- trunk/Source/_javascript_Core/runtime/JSCellInlines.h 2021-12-07 00:38:11 UTC (rev 286579)
+++ trunk/Source/_javascript_Core/runtime/JSCellInlines.h 2021-12-07 01:13:33 UTC (rev 286580)
@@ -58,9 +58,9 @@
inline JSCell::JSCell(VM&, Structure* structure)
:
[webkit-changes] [286579] trunk
Title: [286579] trunk
Revision 286579
Author beid...@apple.com
Date 2021-12-06 16:38:11 -0800 (Mon, 06 Dec 2021)
Log Message
webpushd/webpushtool debugging additions
https://bugs.webkit.org/show_bug.cgi?id=233864
Reviewed by Alex Christensen.
Source/WebKit:
Covered by API tests.
This patch:
- Teaches webpushtool the ability to wait for a reconnect after losing its connection
- Starts actually broadcasting meaningful debug messages from webpushd
* webpushd/AppBundleRequest.mm:
(WebPushD::AppBundleRequest::start):
(WebPushD::AppBundlePermissionsRequest::didCheckForExistingBundle):
(WebPushD::AppBundlePermissionsRequest::didCreateAppBundle):
(WebPushD::AppBundleDeletionRequest::didDeleteExistingBundleWithError):
* webpushd/PushClientConnection.h:
* webpushd/PushClientConnection.mm:
(WebPushD::ClientConnection::setDebugModeIsEnabled):
(WebPushD::ClientConnection::broadcastDebugMessage):
(WebPushD::ClientConnection::connectionClosed):
* webpushd/WebPushDaemon.mm:
(WebPushD::Daemon::connectionAdded):
* webpushd/webpushtool/WebPushToolConnection.h:
* webpushd/webpushtool/WebPushToolConnection.mm:
(WebPushTool::Connection::create):
(WebPushTool::Connection::Connection):
(WebPushTool::Connection::connectToService):
(WebPushTool::Connection::connectionDropped):
* webpushd/webpushtool/WebPushToolMain.mm:
(printUsageAndTerminate):
(main):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::TEST): Adapt to debug message changes.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/webpushd/AppBundleRequest.mm
trunk/Source/WebKit/webpushd/PushClientConnection.h
trunk/Source/WebKit/webpushd/PushClientConnection.mm
trunk/Source/WebKit/webpushd/WebPushDaemon.mm
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (286578 => 286579)
--- trunk/Source/WebKit/ChangeLog 2021-12-07 00:36:58 UTC (rev 286578)
+++ trunk/Source/WebKit/ChangeLog 2021-12-07 00:38:11 UTC (rev 286579)
@@ -1,3 +1,42 @@
+2021-12-06 Brady Eidson
+
+webpushd/webpushtool debugging additions
+https://bugs.webkit.org/show_bug.cgi?id=233864
+
+Reviewed by Alex Christensen.
+
+Covered by API tests.
+
+This patch:
+- Teaches webpushtool the ability to wait for a reconnect after losing its connection
+- Starts actually broadcasting meaningful debug messages from webpushd
+
+* webpushd/AppBundleRequest.mm:
+(WebPushD::AppBundleRequest::start):
+(WebPushD::AppBundlePermissionsRequest::didCheckForExistingBundle):
+(WebPushD::AppBundlePermissionsRequest::didCreateAppBundle):
+(WebPushD::AppBundleDeletionRequest::didDeleteExistingBundleWithError):
+
+* webpushd/PushClientConnection.h:
+* webpushd/PushClientConnection.mm:
+(WebPushD::ClientConnection::setDebugModeIsEnabled):
+(WebPushD::ClientConnection::broadcastDebugMessage):
+(WebPushD::ClientConnection::connectionClosed):
+
+* webpushd/WebPushDaemon.mm:
+(WebPushD::Daemon::connectionAdded):
+
+* webpushd/webpushtool/WebPushToolConnection.h:
+* webpushd/webpushtool/WebPushToolConnection.mm:
+(WebPushTool::Connection::create):
+(WebPushTool::Connection::Connection):
+(WebPushTool::Connection::connectToService):
+(WebPushTool::Connection::connectionDropped):
+
+* webpushd/webpushtool/WebPushToolMain.mm:
+(printUsageAndTerminate):
+(main):
+
2021-12-06 Chris Dumez
Regression(r286505) imported/w3c/web-platform-tests/html/cross-origin-opener-policy/_javascript_-url.https.html is a flaky crash
Modified: trunk/Source/WebKit/webpushd/AppBundleRequest.mm (286578 => 286579)
--- trunk/Source/WebKit/webpushd/AppBundleRequest.mm 2021-12-07 00:36:58 UTC (rev 286578)
+++ trunk/Source/WebKit/webpushd/AppBundleRequest.mm 2021-12-07 00:38:11 UTC (rev 286579)
@@ -47,6 +47,8 @@
{
ASSERT(m_connection);
+m_connection->broadcastDebugMessage(makeString("Starting ", transactionDescription(), " request for origin ", m_originString));
+
m_transaction = adoptOSObject(os_transaction_create(transactionDescription()));
if (m_connection->useMockBundlesForTesting())
@@ -91,6 +93,8 @@
{
ASSERT_UNUSED(bundle, == m_appBundle.get());
+m_connection->broadcastDebugMessage(makeString("Origin ", m_originString, " app bundle request: didCheckForExistingBundle - ", exists == PushAppBundleExists::Yes ? "Exists" : "Does not exist"));
+
if (exists == PushAppBundleExists::Yes)
return callCompletionHandlerAndCleanup(true);
@@ -101,6 +105,8 @@
{
ASSERT_UNUSED(bundle, == m_appBundle.get());
+
[webkit-changes] [286578] trunk/Source/WebCore
Title: [286578] trunk/Source/WebCore Revision 286578 Author s...@apple.com Date 2021-12-06 16:36:58 -0800 (Mon, 06 Dec 2021) Log Message [GPU Process] Make FilterEffect calculate the primitive subregion only when needed https://bugs.webkit.org/show_bug.cgi?id=232705 rdar://85290142 Reviewed by Cameron McCormack. In this patch: 1. resultColorSpace() will return colorSpace() from a FilterImageVector instead of returning the resultColorSpace() of the FilterEffect. 2. Filter::clampFilterRegionIfNeeded() will clamp the filterRegion() instead of clamping the maxEffectRect of the lastEffect() since all the primitiveSubregions and the imageRects have to clipped to the filterRegion(). 3. determineFilterPrimitiveSubregion() is replaced by calculatePrimitiveSubregion() which will calculate the primitiveSubregion from a FilterImageVector and an optional FilterEffectGeometry. 4. Many of FilterEffects are made protected instead of having them public. 5. SVGFilterExpression will be defined as a Vector of SVGFilterExpressionTerm which is a struct of FilterEffect and optional FilterEffectGeometry. 6. SVGFilter will replace the members whose types are FilterEffectVector and FilterEffectGeometryMap with a single member of type SVGFilterExpression. * Headers.cmake: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::resultColorSpace const): * platform/graphics/filters/FEDisplacementMap.h: * platform/graphics/filters/Filter.cpp: (WebCore::Filter::clampFilterRegionIfNeeded): * platform/graphics/filters/Filter.h: (WebCore::Filter::effectGeometry const): Deleted. * platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculatePrimitiveSubregion const): (WebCore::FilterEffect::apply): (WebCore::FilterEffect::externalRepresentation const): (WebCore::FilterEffect::determineFilterPrimitiveSubregion): Deleted. * platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::resultColorSpace const): (WebCore::FilterEffect::filterPrimitiveSubregion const): Deleted. (WebCore::FilterEffect::setFilterPrimitiveSubregion): Deleted. * platform/graphics/filters/FilterFunction.h: (WebCore::FilterFunction::apply): * svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::create): (WebCore::SVGFilter::supportsCoreImageRendering const): (WebCore::SVGFilter::lastEffect const): (WebCore::SVGFilter::apply): (WebCore::SVGFilter::clearResult): (WebCore::SVGFilter::effectGeometry const): Deleted. * svg/graphics/filters/SVGFilter.h: * svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::effectGeometry const): (WebCore::SVGFilterBuilder::buildEffectExpression const): (WebCore::SVGFilterBuilder::buildExpression const): (WebCore::buildEffectExpression): Deleted. * svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::takeEffectGeometryMap): Deleted. * svg/graphics/filters/SVGFilterExpression.h: Added. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/filters/FEDisplacementMap.cpp trunk/Source/WebCore/platform/graphics/filters/FEDisplacementMap.h trunk/Source/WebCore/platform/graphics/filters/Filter.cpp trunk/Source/WebCore/platform/graphics/filters/Filter.h trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp trunk/Source/WebCore/platform/graphics/filters/FilterEffect.h trunk/Source/WebCore/platform/graphics/filters/FilterFunction.h trunk/Source/WebCore/svg/graphics/filters/SVGFilter.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilter.h trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h Added Paths trunk/Source/WebCore/svg/graphics/filters/SVGFilterExpression.h Diff Modified: trunk/Source/WebCore/ChangeLog (286577 => 286578) --- trunk/Source/WebCore/ChangeLog 2021-12-07 00:36:31 UTC (rev 286577) +++ trunk/Source/WebCore/ChangeLog 2021-12-07 00:36:58 UTC (rev 286578) @@ -1,3 +1,70 @@ +2021-12-06 Said Abou-Hallawa + +[GPU Process] Make FilterEffect calculate the primitive subregion only when needed +https://bugs.webkit.org/show_bug.cgi?id=232705 +rdar://85290142 + +Reviewed by Cameron McCormack. + +In this patch: + +1. resultColorSpace() will return colorSpace() from a FilterImageVector + instead of returning the resultColorSpace() of the FilterEffect. + +2. Filter::clampFilterRegionIfNeeded() will clamp the filterRegion() + instead of clamping the maxEffectRect of the lastEffect() since all + the primitiveSubregions and the imageRects have to clipped to the + filterRegion(). + +3. determineFilterPrimitiveSubregion() is replaced by calculatePrimitiveSubregion() + which will calculate the primitiveSubregion from a FilterImageVector + and an optional
[webkit-changes] [286577] trunk/LayoutTests
Title: [286577] trunk/LayoutTests Revision 286577 Author ryanhad...@apple.com Date 2021-12-06 16:36:31 -0800 (Mon, 06 Dec 2021) Log Message [ iOS ] imported/w3c/web-platform-tests/content-security-policy/worker-src/service-* tests are consistently failing https://bugs.webkit.org/show_bug.cgi?id=229875 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Add DumpJSConsoleLogInStdErr to address consistent failures. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (286576 => 286577) --- trunk/LayoutTests/ChangeLog 2021-12-07 00:18:20 UTC (rev 286576) +++ trunk/LayoutTests/ChangeLog 2021-12-07 00:36:31 UTC (rev 286577) @@ -1,3 +1,12 @@ +2021-12-06 Ryan Haddad + +[ iOS ] imported/w3c/web-platform-tests/content-security-policy/worker-src/service-* tests are consistently failing +https://bugs.webkit.org/show_bug.cgi?id=229875 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: Add DumpJSConsoleLogInStdErr to address consistent failures. + 2021-12-06 Sam Weinig [CSS Color 5] Update color-mix() to support srgb-linear and alpha premultiplication Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (286576 => 286577) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-12-07 00:18:20 UTC (rev 286576) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-12-07 00:36:31 UTC (rev 286577) @@ -1410,10 +1410,10 @@ webkit.org/b/205216 imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html [ Pass Failure DumpJSConsoleLogInStdErr ] -webkit.org/b/229875 imported/w3c/web-platform-tests/content-security-policy/worker-src/service-fallback.https.sub.html [ Pass Failure ] -webkit.org/b/229875 imported/w3c/web-platform-tests/content-security-policy/worker-src/service-list.https.sub.html [ Pass Failure ] -webkit.org/b/229875 imported/w3c/web-platform-tests/content-security-policy/worker-src/service-none.https.sub.html [ Pass Failure ] -webkit.org/b/229875 imported/w3c/web-platform-tests/content-security-policy/worker-src/service-self.https.sub.html [ Pass Failure ] +webkit.org/b/229875 imported/w3c/web-platform-tests/content-security-policy/worker-src/service-fallback.https.sub.html [ Pass Failure DumpJSConsoleLogInStdErr ] +webkit.org/b/229875 imported/w3c/web-platform-tests/content-security-policy/worker-src/service-list.https.sub.html [ Pass Failure DumpJSConsoleLogInStdErr ] +webkit.org/b/229875 imported/w3c/web-platform-tests/content-security-policy/worker-src/service-none.https.sub.html [ Pass Failure DumpJSConsoleLogInStdErr ] +webkit.org/b/229875 imported/w3c/web-platform-tests/content-security-policy/worker-src/service-self.https.sub.html [ Pass Failure DumpJSConsoleLogInStdErr ] webkit.org/b/190852 imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286576] trunk/Tools
Title: [286576] trunk/Tools Revision 286576 Author jbed...@apple.com Date 2021-12-06 16:18:20 -0800 (Mon, 06 Dec 2021) Log Message [reporelaypy] Add implementation of commits.webkit.org https://bugs.webkit.org/show_bug.cgi?id=233734 Reviewed by Dewei Zhu. As commits.webkit.org becomes more important to WebKit development, we need to apply our normal robust testing and review to the code backing it. * Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Add entrypoint to library. * Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py: Added. (Checkout): Abstraction managing local repository checkout. * Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py: Added. (Redirector): Generates redirects for certain SCM services. (CheckoutRoute): http routes returning information based on a checkout. * Tools/Scripts/libraries/reporelaypy/reporelaypy/database.py: Added. (Database): A connection to a true Redis or TinyRedis database. * Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py: (CheckoutUnittest): * Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py: Added. (RedirectorUnittest): (CheckoutRouteUnittest): * Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/database_unittest.py: Added. (DatabaseUnittest): * Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py: Copied from Tools/Scripts/libraries/webkitflaskpy/setup.py. (health): * Tools/Scripts/libraries/reporelaypy/run: Added. * Tools/Scripts/libraries/reporelaypy/setup.py: Added. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Bump version. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: (FlaskTestCase.run_with_mock_webserver.decorator.real_method): (FlaskRequestsResponse): Moved to webkitflaskpy. * Tools/Scripts/libraries/webkitflaskpy/setup.py: Bump version, update library description. * Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py: Bump version. * Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/mock_app.py: Added. (mock_app): Setup a flask app for testing. * Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/response.py: Added. (Response): Move FlaskRequestsResponse to more generic location. * Tools/Scripts/webkitpy/__init__.py: Include reporelaypy for testing. * Tools/Scripts/webkitpy/test/main.py: (main): Include reporelaypy for testing. (Tester._run_tests): Ditto. Canonical link: https://commits.webkit.org/244901@main Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/flask_testcase.py trunk/Tools/Scripts/libraries/resultsdbpy/setup.py trunk/Tools/Scripts/libraries/webkitflaskpy/setup.py trunk/Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py trunk/Tools/Scripts/webkitpy/__init__.py trunk/Tools/Scripts/webkitpy/test/main.py Added Paths trunk/Tools/Scripts/libraries/reporelaypy/ trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/ trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/database.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/ trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/database_unittest.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py trunk/Tools/Scripts/libraries/reporelaypy/run trunk/Tools/Scripts/libraries/reporelaypy/setup.py trunk/Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/mock_app.py trunk/Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/response.py Diff Modified: trunk/Tools/ChangeLog (286575 => 286576) --- trunk/Tools/ChangeLog 2021-12-07 00:06:10 UTC (rev 286575) +++ trunk/Tools/ChangeLog 2021-12-07 00:18:20 UTC (rev 286576) @@ -1,3 +1,48 @@ +2021-12-04 Jonathan Bedard + +[reporelaypy] Add implementation of commits.webkit.org +https://bugs.webkit.org/show_bug.cgi?id=233734 + + +Reviewed by Dewei Zhu. + +As commits.webkit.org becomes more important to WebKit development, we need to apply +our normal robust testing and review to the code backing it. + +* Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Add entrypoint to library. +* Scripts/libraries/reporelaypy/reporelaypy/checkout.py: Added. +(Checkout): Abstraction managing local repository checkout. +* Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py: Added. +(Redirector): Generates redirects for certain SCM services. +(CheckoutRoute): http routes returning information based on a checkout. +*
[webkit-changes] [286575] branches/safari-612-branch
Title: [286575] branches/safari-612-branch Revision 286575 Author ryanhad...@apple.com Date 2021-12-06 16:06:10 -0800 (Mon, 06 Dec 2021) Log Message Unreviewed, fix the debug build. Modified Paths branches/safari-612-branch/Source/WebCore/ChangeLog branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp branches/safari-612-branch/Tools/ChangeLog branches/safari-612-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm Diff Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (286574 => 286575) --- branches/safari-612-branch/Source/WebCore/ChangeLog 2021-12-06 23:37:28 UTC (rev 286574) +++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-12-07 00:06:10 UTC (rev 286575) @@ -1,3 +1,10 @@ +2021-12-06 Ryan Haddad + +Unreviewed, fix the debug build. + +* platform/graphics/cocoa/FontCacheCoreText.cpp: +(WebCore::variationAxes): + 2021-12-02 Alan Coon Revert r286394. rdar://problem/83070565 Modified: branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (286574 => 286575) --- branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2021-12-06 23:37:28 UTC (rev 286574) +++ branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2021-12-07 00:06:10 UTC (rev 286575) @@ -302,7 +302,10 @@ #if defined(HAVE_CTFontCopyVariationAxesInternal) // This macro is defined inside CoreText, not WebKit. if (shouldLocalizeAxisNames == ShouldLocalizeAxisNames::Yes) return adoptCF(CTFontCopyVariationAxes(font)); +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wunguarded-availability-new" return adoptCF(CTFontCopyVariationAxesInternal(font)); +#pragma clang diagnostic pop #else UNUSED_PARAM(shouldLocalizeAxisNames); return adoptCF(CTFontCopyVariationAxes(font)); Modified: branches/safari-612-branch/Tools/ChangeLog (286574 => 286575) --- branches/safari-612-branch/Tools/ChangeLog 2021-12-06 23:37:28 UTC (rev 286574) +++ branches/safari-612-branch/Tools/ChangeLog 2021-12-07 00:06:10 UTC (rev 286575) @@ -1,3 +1,9 @@ +2021-12-06 Ryan Haddad + +Unreviewed, fix the debug build. + +* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: + 2021-12-03 Russell Epstein Cherry-pick r286505. rdar://problem/85918531 Modified: branches/safari-612-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm (286574 => 286575) --- branches/safari-612-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm 2021-12-06 23:37:28 UTC (rev 286574) +++ branches/safari-612-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm 2021-12-07 00:06:10 UTC (rev 286575) @@ -28,6 +28,7 @@ #if ENABLE(WEB_AUTHN) +#import "HTTPServer.h" #import "PlatformUtilities.h" #import "TCPServer.h" #import "TestWKWebView.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286574] trunk/Source/WebKit
Title: [286574] trunk/Source/WebKit
Revision 286574
Author cdu...@apple.com
Date 2021-12-06 15:37:28 -0800 (Mon, 06 Dec 2021)
Log Message
Regression(r286505) imported/w3c/web-platform-tests/html/cross-origin-opener-policy/_javascript_-url.https.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=233874
Reviewed by Darin Adler.
r286505 fixed ProvisionalPageProxy so that ProvisionalPageProxy::m_provisionalLoadURL gets properly initialized when the
ProvisionalPageProxy gets constructed *after* the provisional load has already started (COOP proces-swap case). One side
effect of this though is that ProvisionalPageProxy::cancel() no longer returns early and will try to notify the client
that the provisional load failed, dereferencing m_mainFrame in doing so. In the event where the main frame has not yet
been created in the new provisional process, this would do a null-dereference of m_mainFrame.
To address the issue, we now early return in ProvisionalPageProxy::cancel() if m_isProcessSwappingOnNavigationResponse
is true (i.e. The ProvisionalPageProxy was created after the provisional load had started). In such situations, we
don't want to ProvisionalPageProxy to be the one notifying the client of the provisional load failure anyway. The reason
is that there is still a provisional load going on in the committed process/page.
No new tests, covered by existing test that is flakily crashing.
* UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::cancel):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (286573 => 286574)
--- trunk/Source/WebKit/ChangeLog 2021-12-06 22:53:46 UTC (rev 286573)
+++ trunk/Source/WebKit/ChangeLog 2021-12-06 23:37:28 UTC (rev 286574)
@@ -1,3 +1,26 @@
+2021-12-06 Chris Dumez
+
+Regression(r286505) imported/w3c/web-platform-tests/html/cross-origin-opener-policy/_javascript_-url.https.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=233874
+
+Reviewed by Darin Adler.
+
+r286505 fixed ProvisionalPageProxy so that ProvisionalPageProxy::m_provisionalLoadURL gets properly initialized when the
+ProvisionalPageProxy gets constructed *after* the provisional load has already started (COOP proces-swap case). One side
+effect of this though is that ProvisionalPageProxy::cancel() no longer returns early and will try to notify the client
+that the provisional load failed, dereferencing m_mainFrame in doing so. In the event where the main frame has not yet
+been created in the new provisional process, this would do a null-dereference of m_mainFrame.
+
+To address the issue, we now early return in ProvisionalPageProxy::cancel() if m_isProcessSwappingOnNavigationResponse
+is true (i.e. The ProvisionalPageProxy was created after the provisional load had started). In such situations, we
+don't want to ProvisionalPageProxy to be the one notifying the client of the provisional load failure anyway. The reason
+is that there is still a provisional load going on in the committed process/page.
+
+No new tests, covered by existing test that is flakily crashing.
+
+* UIProcess/ProvisionalPageProxy.cpp:
+(WebKit::ProvisionalPageProxy::cancel):
+
2021-12-06 Ryan Haddad
REGRESSION (r286507): [macOS] Many file system access layout tests became flaky failures
Modified: trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp (286573 => 286574)
--- trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp 2021-12-06 22:53:46 UTC (rev 286573)
+++ trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp 2021-12-06 23:37:28 UTC (rev 286574)
@@ -143,9 +143,9 @@
void ProvisionalPageProxy::cancel()
{
// If the provisional load started, then indicate that it failed due to cancellation by calling didFailProvisionalLoadForFrame().
-if (m_provisionalLoadURL.isEmpty())
+if (m_provisionalLoadURL.isEmpty() || m_isProcessSwappingOnNavigationResponse)
return;
-
+
ASSERT(m_process->state() == WebProcessProxy::State::Running);
PROVISIONALPAGEPROXY_RELEASE_LOG(ProcessSwapping, "cancel: Simulating a didFailProvisionalLoadForFrame");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286573] trunk/Source/bmalloc
Title: [286573] trunk/Source/bmalloc Revision 286573 Author ysuz...@apple.com Date 2021-12-06 14:53:46 -0800 (Mon, 06 Dec 2021) Log Message [libpas] Set pthread_setspecific with marker in TLS destructor to detect TLS is destroyed https://bugs.webkit.org/show_bug.cgi?id=233851 Reviewed by Mark Lam. TLS has lifetime problem that, 1. TLS is destroyed 2. The other TLS is destroyed, and the destructor is called 3. The destructor touches (1)'s TLS, then revive TLS of (1) (e.g. libpas's thread local cache). To handle these cases, pthread library (libc) repeatedly calls destructor PAS_THREAD_LOCAL_CACHE_DESTROYED times so that we clean up revived TLS again. By using this mechanism, we can emulate pthread_self_is_exiting_np so that we can avoid reviving TLS. 1. When destroying TLS, we set a marker (PAS_THREAD_LOCAL_CACHE_DESTROYED in this case) in TLS. 2. During the other destructor calls, we can detect that TLS is destroyed by checking pthread_getspecific(...) == PAS_THREAD_LOCAL_CACHE_DESTROYED. 3. We repeatedly calls the destructor of TLS, but every time, we set PAS_THREAD_LOCAL_CACHE_DESTROYED. So after PAS_THREAD_LOCAL_CACHE_DESTROYED times, it is left, and we achieve the goal (1) offering the way to detect the destroyed TLS and (2) avoiding reviving of TLS. This patch implements it when pthread_self_is_exiting_np does not exist. * libpas/src/libpas/pas_segregated_page_inlines.h: (pas_segregated_page_switch_lock_with_mode): * libpas/src/libpas/pas_thread_local_cache.c: (destructor): (pas_thread_local_cache_create): (pas_thread_local_cache_destroy): (pas_thread_local_cache_get_local_allocator_slow): (pas_thread_local_cache_for_all): * libpas/src/libpas/pas_thread_local_cache.h: (pas_thread_local_cache_try_get_impl): (pas_thread_local_cache_try_get): (pas_thread_local_cache_can_set): (pas_thread_local_cache_set_impl): (pas_thread_local_cache_set): (pas_thread_local_cache_is_guaranteed_to_destruct): Deleted. * libpas/src/libpas/pas_try_reallocate.h: (pas_try_reallocate): * libpas/src/libpas/pas_utils.h: * libpas/src/test/IsoHeapPageSharingTests.cpp: (std::addAllTests): * libpas/src/test/IsoHeapPartialAndBaselineTests.cpp: (addIsoHeapPartialAndBaselineTests): Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_page_inlines.h trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.h trunk/Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h trunk/Source/bmalloc/libpas/src/test/IsoHeapPageSharingTests.cpp trunk/Source/bmalloc/libpas/src/test/IsoHeapPartialAndBaselineTests.cpp Diff Modified: trunk/Source/bmalloc/ChangeLog (286572 => 286573) --- trunk/Source/bmalloc/ChangeLog 2021-12-06 22:50:39 UTC (rev 286572) +++ trunk/Source/bmalloc/ChangeLog 2021-12-06 22:53:46 UTC (rev 286573) @@ -1,3 +1,52 @@ +2021-12-06 Yusuke Suzuki + +[libpas] Set pthread_setspecific with marker in TLS destructor to detect TLS is destroyed +https://bugs.webkit.org/show_bug.cgi?id=233851 + +Reviewed by Mark Lam. + +TLS has lifetime problem that, + +1. TLS is destroyed +2. The other TLS is destroyed, and the destructor is called +3. The destructor touches (1)'s TLS, then revive TLS of (1) (e.g. libpas's thread local cache). + +To handle these cases, pthread library (libc) repeatedly calls destructor PAS_THREAD_LOCAL_CACHE_DESTROYED times +so that we clean up revived TLS again. + +By using this mechanism, we can emulate pthread_self_is_exiting_np so that we can avoid reviving TLS. + +1. When destroying TLS, we set a marker (PAS_THREAD_LOCAL_CACHE_DESTROYED in this case) in TLS. +2. During the other destructor calls, we can detect that TLS is destroyed by checking pthread_getspecific(...) == PAS_THREAD_LOCAL_CACHE_DESTROYED. +3. We repeatedly calls the destructor of TLS, but every time, we set PAS_THREAD_LOCAL_CACHE_DESTROYED. + So after PAS_THREAD_LOCAL_CACHE_DESTROYED times, it is left, and we achieve the goal (1) offering the way to + detect the destroyed TLS and (2) avoiding reviving of TLS. + +This patch implements it when pthread_self_is_exiting_np does not exist. + +* libpas/src/libpas/pas_segregated_page_inlines.h: +(pas_segregated_page_switch_lock_with_mode): +* libpas/src/libpas/pas_thread_local_cache.c: +(destructor): +(pas_thread_local_cache_create): +(pas_thread_local_cache_destroy): +(pas_thread_local_cache_get_local_allocator_slow): +(pas_thread_local_cache_for_all): +* libpas/src/libpas/pas_thread_local_cache.h: +(pas_thread_local_cache_try_get_impl): +(pas_thread_local_cache_try_get): +(pas_thread_local_cache_can_set): +(pas_thread_local_cache_set_impl): +(pas_thread_local_cache_set): +
[webkit-changes] [286572] trunk/Source/JavaScriptCore
Title: [286572] trunk/Source/_javascript_Core Revision 286572 Author mark@apple.com Date 2021-12-06 14:50:39 -0800 (Mon, 06 Dec 2021) Log Message Remove unneeded virtual allocator methods from Subspace. https://bugs.webkit.org/show_bug.cgi?id=233891 rdar://86117970 Reviewed by Yusuke Suzuki. Since the virtual allocate() and allocateFor() methods are now deleted, we can also rename the inline allocateNonVirtual() and allocatorForNonVirtual() methods to simply allocate() and allocateFor(). Similarly, rename allocatorForNonVirtualConcurrently() to allocatorForConcurrently(). There are 2 places that still invokes the non-inline version of CompleteSubspace::allocatorFor(). For this reason, we introduce a CompleteSubsace::allocatorForNonInline() to keep the linkage the same. There's a chance that the compiler/linker may already inline the method in 1 or both of these places, but we'll offer allocatorForNonInline() to keep the code expressing the same thing and let the compiler/linker decide whether to inline it or not just as before. This is purely a re-factoring patch. There are no behavior changes, except for the removal of those 2 entries from the vtbls. * bytecode/AccessCase.cpp: (JSC::AccessCase::generateImpl): * bytecode/ObjectAllocationProfileInlines.h: (JSC::ObjectAllocationProfileBase::initializeProfile): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::emitAllocateRawObject): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileMakeRope): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): * heap/CompleteSubspace.cpp: (JSC::CompleteSubspace::allocatorForNonInline): (JSC::CompleteSubspace::tryAllocateSlow): (JSC::CompleteSubspace::allocatorFor): Deleted. (JSC::CompleteSubspace::allocate): Deleted. * heap/CompleteSubspace.h: (JSC::CompleteSubspace::allocatorFor): (JSC::CompleteSubspace::allocatorForNonVirtual): Deleted. * heap/CompleteSubspaceInlines.h: (JSC::CompleteSubspace::allocate): (JSC::CompleteSubspace::allocateNonVirtual): Deleted. * heap/IsoSubspace.cpp: (JSC::IsoSubspace::allocatorFor): Deleted. (JSC::IsoSubspace::allocate): Deleted. * heap/IsoSubspace.h: (JSC::IsoSubspace::allocatorFor): (JSC::IsoSubspace::allocatorForNonVirtual): Deleted. * heap/IsoSubspaceInlines.h: (JSC::IsoSubspace::allocate): (JSC::IsoSubspace::allocateNonVirtual): Deleted. * heap/Subspace.h: * jit/AssemblyHelpers.h: (JSC::AssemblyHelpers::emitAllocateJSObjectWithKnownSize): * runtime/ButterflyInlines.h: (JSC::Butterfly::tryCreateUninitialized): (JSC::Butterfly::createUninitialized): (JSC::Butterfly::tryCreate): (JSC::Butterfly::growArrayRight): (JSC::Butterfly::reallocArrayRightIfPossible): * runtime/DirectArguments.cpp: (JSC::DirectArguments::overrideThings): * runtime/GenericArgumentsInlines.h: (JSC::GenericArguments::initModifiedArgumentsDescriptor): * runtime/HashMapImpl.h: (JSC::HashMapBuffer::create): * runtime/JSArray.cpp: (JSC::JSArray::tryCreateUninitializedRestricted): * runtime/JSArray.h: (JSC::JSArray::tryCreate): * runtime/JSArrayBufferView.cpp: (JSC::JSArrayBufferView::ConstructionContext::ConstructionContext): * runtime/JSBigInt.cpp: (JSC::JSBigInt::createWithLength): * runtime/JSCellInlines.h: (JSC::allocatorForConcurrently): (JSC::tryAllocateCellHelper): (JSC::allocatorForNonVirtualConcurrently): Deleted. * runtime/JSPropertyNameEnumerator.cpp: (JSC::JSPropertyNameEnumerator::create): * runtime/ScopedArguments.cpp: (JSC::ScopedArguments::createUninitialized): * runtime/StructureChain.cpp: (JSC::StructureChain::create): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/AccessCase.cpp trunk/Source/_javascript_Core/bytecode/ObjectAllocationProfileInlines.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp trunk/Source/_javascript_Core/heap/CompleteSubspace.cpp trunk/Source/_javascript_Core/heap/CompleteSubspace.h trunk/Source/_javascript_Core/heap/CompleteSubspaceInlines.h trunk/Source/_javascript_Core/heap/IsoSubspace.cpp trunk/Source/_javascript_Core/heap/IsoSubspace.h trunk/Source/_javascript_Core/heap/IsoSubspaceInlines.h trunk/Source/_javascript_Core/heap/Subspace.h trunk/Source/_javascript_Core/jit/AssemblyHelpers.h trunk/Source/_javascript_Core/runtime/ButterflyInlines.h trunk/Source/_javascript_Core/runtime/DirectArguments.cpp trunk/Source/_javascript_Core/runtime/GenericArgumentsInlines.h trunk/Source/_javascript_Core/runtime/HashMapImpl.h trunk/Source/_javascript_Core/runtime/JSArray.cpp trunk/Source/_javascript_Core/runtime/JSArray.h trunk/Source/_javascript_Core/runtime/JSArrayBufferView.cpp trunk/Source/_javascript_Core/runtime/JSBigInt.cpp trunk/Source/_javascript_Core/runtime/JSCellInlines.h trunk/Source/_javascript_Core/runtime/JSPropertyNameEnumerator.cpp trunk/Source/_javascript_Core/runtime/ScopedArguments.cpp trunk/Source/_javascript_Core/runtime/StructureChain.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (286571 =>
[webkit-changes] [286571] releases/WPE WebKit/webkit-2.34.2/
Title: [286571] releases/WPE WebKit/webkit-2.34.2/ Revision 286571 Author ape...@igalia.com Date 2021-12-06 14:24:49 -0800 (Mon, 06 Dec 2021) Log Message WPE WebKit 2.34.2 Added Paths releases/WPE WebKit/webkit-2.34.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286570] releases/WebKitGTK/webkit-2.34
Title: [286570] releases/WebKitGTK/webkit-2.34 Revision 286570 Author ape...@igalia.com Date 2021-12-06 14:23:20 -0800 (Mon, 06 Dec 2021) Log Message Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.2 release .: * Source/cmake/OptionsWPE.cmake: Bump version numbers. Source/WebKit: * wpe/NEWS: Add release notes for 2.34.2. Modified Paths releases/WebKitGTK/webkit-2.34/ChangeLog releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog releases/WebKitGTK/webkit-2.34/Source/WebKit/wpe/NEWS releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsWPE.cmake Diff Modified: releases/WebKitGTK/webkit-2.34/ChangeLog (286569 => 286570) --- releases/WebKitGTK/webkit-2.34/ChangeLog 2021-12-06 22:17:05 UTC (rev 286569) +++ releases/WebKitGTK/webkit-2.34/ChangeLog 2021-12-06 22:23:20 UTC (rev 286570) @@ -1,3 +1,9 @@ +2021-11-24 Adrian Perez de Castro + +Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.2 release + +* Source/cmake/OptionsWPE.cmake: Bump version numbers. + 2021-11-24 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.34.2 release Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (286569 => 286570) --- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog 2021-12-06 22:17:05 UTC (rev 286569) +++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog 2021-12-06 22:23:20 UTC (rev 286570) @@ -1,3 +1,9 @@ +2021-11-24 Adrian Perez de Castro + +Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.2 release + +* wpe/NEWS: Add release notes for 2.34.2. + 2021-11-24 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.34.2 release Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/wpe/NEWS (286569 => 286570) --- releases/WebKitGTK/webkit-2.34/Source/WebKit/wpe/NEWS 2021-12-06 22:17:05 UTC (rev 286569) +++ releases/WebKitGTK/webkit-2.34/Source/WebKit/wpe/NEWS 2021-12-06 22:23:20 UTC (rev 286570) @@ -1,4 +1,13 @@ = +WPE WebKit 2.34.2 += + +What's new in WPE WebKit 2.34.2? + + - Fix scrolling issues when pressing Home and PgDown keys. + - Fix the build with video disabled. + += WPE WebKit 2.34.1 = Modified: releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsWPE.cmake (286569 => 286570) --- releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsWPE.cmake 2021-12-06 22:17:05 UTC (rev 286569) +++ releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsWPE.cmake 2021-12-06 22:23:20 UTC (rev 286570) @@ -1,7 +1,7 @@ include(GNUInstallDirs) include(VersioningUtils) -SET_PROJECT_VERSION(2 34 1) +SET_PROJECT_VERSION(2 34 2) set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string") @@ -143,9 +143,9 @@ endif () if (WPE_API_VERSION VERSION_EQUAL "1.0") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 19 3 16) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 19 4 16) else () -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 1 0) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 2 0) endif () # These are shared variables, but we special case their definition so that we can use the ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286569] trunk
Title: [286569] trunk Revision 286569 Author ryanhad...@apple.com Date 2021-12-06 14:17:05 -0800 (Mon, 06 Dec 2021) Log Message REGRESSION (r286507): [macOS] Many file system access layout tests became flaky failures https://bugs.webkit.org/show_bug.cgi?id=233892 Unreviewed, revert r286507. Source/WebCore: * Modules/filesystemaccess/FileSystemStorageConnection.h: Source/WebKit: * CMakeLists.txt: * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::monitoredDataTypes): * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::fetchWebsiteData): (WebKit::NetworkProcess::deleteWebsiteData): (WebKit::NetworkProcess::deleteWebsiteDataForOrigins): (WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains): (WebKit::NetworkProcess::registrableDomainsWithWebsiteData): * NetworkProcess/storage/FileSystemStorageHandle.h: (WebKit::FileSystemStorageHandle::activeSyncAccessHandle const): Deleted. * NetworkProcess/storage/FileSystemStorageManager.cpp: (WebKit::FileSystemStorageManager::~FileSystemStorageManager): (WebKit::FileSystemStorageManager::close): Deleted. * NetworkProcess/storage/FileSystemStorageManager.h: * NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::originPath): (WebKit::NetworkStorageManager::localOriginStorageManager): (WebKit::readOriginFromFile): Deleted. (WebKit::writeOriginToFileIfNecessary): Deleted. (WebKit::deleteOriginFileIfNecessary): Deleted. (WebKit::originDirectoryPath): Deleted. (WebKit::originFilePath): Deleted. (WebKit::NetworkStorageManager::removeOriginStorageManagerIfPossible): Deleted. (WebKit::toWebsiteDataType): Deleted. (WebKit::NetworkStorageManager::forEachOriginDirectory): Deleted. (WebKit::NetworkStorageManager::fetchDataFromDisk): Deleted. (WebKit::NetworkStorageManager::fetchData): Deleted. (WebKit::NetworkStorageManager::deleteDataOnDisk): Deleted. (WebKit::NetworkStorageManager::deleteData): Deleted. (WebKit::NetworkStorageManager::deleteDataModifiedSince): Deleted. (WebKit::NetworkStorageManager::deleteDataForRegistrableDomains): Deleted. * NetworkProcess/storage/NetworkStorageManager.h: * NetworkProcess/storage/OriginStorageManager.cpp: (WebKit::OriginStorageManager::StorageBucket::typeStoragePath const): (WebKit::OriginStorageManager::StorageBucket::fileSystemStorageManager): (WebKit::OriginStorageManager::OriginStorageManager): (WebKit::OriginStorageManager::StorageBucket::toStorageIdentifier): Deleted. (WebKit::OriginStorageManager::StorageBucket::isActive): Deleted. (WebKit::OriginStorageManager::StorageBucket::deleteData): Deleted. (WebKit::OriginStorageManager::StorageBucket::deleteFileSystemStorageData): Deleted. (WebKit::OriginStorageManager::isActive): Deleted. (WebKit::OriginStorageManager::deleteData): Deleted. * NetworkProcess/storage/OriginStorageManager.h: * Shared/WebsiteData/WebsiteData.cpp: (WebKit::WebsiteData::ownerProcess): * Shared/WebsiteData/WebsiteDataType.h: * UIProcess/API/Cocoa/WKWebsiteDataRecord.mm: (dataTypesToString): * UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h: (WebKit::toWebsiteDataType): (WebKit::toWKWebsiteDataTypes): * UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h: * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (+[WKWebsiteDataStore _allWebsiteDataTypesIncludingPrivate]): * WebKit.xcodeproj/project.pbxproj: * WebProcess/Network/NetworkProcessConnection.cpp: (WebKit::NetworkProcessConnection::didReceiveMessage): * WebProcess/WebCoreSupport/WebFileSystemStorageConnection.messages.in: Removed. Source/WTF: * wtf/FileSystem.cpp: (WTF::FileSystemImpl::readEntireFile): Deleted. (WTF::FileSystemImpl::deleteAllFilesModifiedSince): Deleted. * wtf/FileSystem.h: Tools: * TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/FileSystem.cpp trunk/Source/WTF/wtf/FileSystem.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/filesystemaccess/FileSystemStorageConnection.h trunk/Source/WebKit/CMakeLists.txt trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/DerivedSources-input.xcfilelist trunk/Source/WebKit/DerivedSources-output.xcfilelist trunk/Source/WebKit/DerivedSources.make trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.h trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageManager.cpp trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageManager.h trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.h trunk/Source/WebKit/Shared/WebsiteData/WebsiteData.cpp
[webkit-changes] [286567] trunk/Source/WebKit
Title: [286567] trunk/Source/WebKit
Revision 286567
Author mark@apple.com
Date 2021-12-06 13:36:19 -0800 (Mon, 06 Dec 2021)
Log Message
Reverting local test code that should not have been landed.
Not reviewed.
* UIProcess/Cocoa/ModelElementControllerCocoa.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (286566 => 286567)
--- trunk/Source/WebKit/ChangeLog 2021-12-06 21:31:41 UTC (rev 286566)
+++ trunk/Source/WebKit/ChangeLog 2021-12-06 21:36:19 UTC (rev 286567)
@@ -1,3 +1,11 @@
+2021-12-06 Mark Lam
+
+Reverting local test code that should not have been landed.
+
+Not reviewed.
+
+* UIProcess/Cocoa/ModelElementControllerCocoa.mm:
+
2021-12-06 Tim Horton
Momentum Event Dispatcher: Momentum phase runs backwards with natural scrolling disabled
Modified: trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm (286566 => 286567)
--- trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-12-06 21:31:41 UTC (rev 286566)
+++ trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-12-06 21:36:19 UTC (rev 286567)
@@ -233,13 +233,6 @@
#if ENABLE(ARKIT_INLINE_PREVIEW)
-#undef ENABLE_ARKIT_INLINE_PREVIEW_CAMERA_TRANSFORM // mlam HACK
-#undef ENABLE_ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL // mlam HACK
-#undef ENABLE_ARKIT_INLINE_PREVIEW_AUDIO_CONTROL // mlam HACK
-#undef HAVE_ASV_INLINE_PREVIEW_CAMERA_CONTROL // mlam HACK
-#undef HAVE_ASV_INLINE_PREVIEW_ANIMATION_CONTROL // mlam HACK
-#undef HAVE_ASV_INLINE_PREVIEW_AUDIO_CONTROL // mlam HACK
-
static bool previewHasCameraSupport(ASVInlinePreview *preview)
{
#if ENABLE(ARKIT_INLINE_PREVIEW_CAMERA_TRANSFORM)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286566] trunk/Source/WebKit
Title: [286566] trunk/Source/WebKit
Revision 286566
Author timothy_hor...@apple.com
Date 2021-12-06 13:31:41 -0800 (Mon, 06 Dec 2021)
Log Message
Momentum Event Dispatcher: Momentum phase runs backwards with natural scrolling disabled
https://bugs.webkit.org/show_bug.cgi?id=233894
Reviewed by Simon Fraser.
* WebProcess/WebPage/MomentumEventDispatcher.cpp:
(WebKit::MomentumEventDispatcher::consumeDeltaForCurrentTime):
Only flip the deltas if the trackpad is configured to use "natural"
scrolling (in which "directionInvertedFromDevice" is true).
(WebKit::MomentumEventDispatcher::computeNextDelta):
Fix initial queue state logging to log both axes before setting the "did log" bit.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (286565 => 286566)
--- trunk/Source/WebKit/ChangeLog 2021-12-06 21:15:39 UTC (rev 286565)
+++ trunk/Source/WebKit/ChangeLog 2021-12-06 21:31:41 UTC (rev 286566)
@@ -1,3 +1,19 @@
+2021-12-06 Tim Horton
+
+Momentum Event Dispatcher: Momentum phase runs backwards with natural scrolling disabled
+https://bugs.webkit.org/show_bug.cgi?id=233894
+
+
+Reviewed by Simon Fraser.
+
+* WebProcess/WebPage/MomentumEventDispatcher.cpp:
+(WebKit::MomentumEventDispatcher::consumeDeltaForCurrentTime):
+Only flip the deltas if the trackpad is configured to use "natural"
+scrolling (in which "directionInvertedFromDevice" is true).
+
+(WebKit::MomentumEventDispatcher::computeNextDelta):
+Fix initial queue state logging to log both axes before setting the "did log" bit.
+
2021-12-06 Brady Eidson
Put webpushd code in WebKit.framework.
Modified: trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp (286565 => 286566)
--- trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp 2021-12-06 21:15:39 UTC (rev 286565)
+++ trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp 2021-12-06 21:31:41 UTC (rev 286566)
@@ -306,7 +306,10 @@
m_currentGesture.currentOffset += delta;
-return -delta;
+if (m_currentGesture.initiatingEvent->directionInvertedFromDevice())
+delta.scale(-1);
+
+return delta;
}
void MomentumEventDispatcher::displayWasRefreshed(WebCore::PlatformDisplayID displayID, const WebCore::DisplayUpdate&)
@@ -478,10 +481,8 @@
float averageDelta = totalDelta / count;
#if ENABLE(MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING)
-if (!m_currentGesture.didLogInitialQueueState) {
+if (!m_currentGesture.didLogInitialQueueState)
RELEASE_LOG(ScrollAnimations, "MomentumEventDispatcher initial historical deltas: average delta %f, average time %fms, event count %d", averageDelta, averageFrameIntervalMS, count);
-m_currentGesture.didLogInitialQueueState = true;
-}
#endif
constexpr float velocityGainA = fromFixedPoint(2.f);
@@ -502,6 +503,10 @@
accelerateAxis(m_deltaHistoryY, quantizedUnacceleratedDelta.height())
);
+#if ENABLE(MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING)
+m_currentGesture.didLogInitialQueueState = true;
+#endif
+
return { unacceleratedDelta, acceleratedDelta };
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286565] trunk/Source
Title: [286565] trunk/Source
Revision 286565
Author simon.fra...@apple.com
Date 2021-12-06 13:15:39 -0800 (Mon, 06 Dec 2021)
Log Message
Add a call to os_signpost to tag a momentum scroll animation
https://bugs.webkit.org/show_bug.cgi?id=233885
Reviewed by Tim Horton.
Source/WebCore:
Use the momentum "Began" and "Ended" events to mark the start/end of a momentum scroll
as an animation via os_signost.
Put the code in ScrollingEffectsController rather than MomentumEventDispatcher so that
non-generated momentum gets marked too.
* platform/mac/ScrollingEffectsController.mm:
(WebCore::ScrollingEffectsController::handleWheelEvent):
Source/WTF:
* wtf/SystemTracing.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/SystemTracing.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm
Diff
Modified: trunk/Source/WTF/ChangeLog (286564 => 286565)
--- trunk/Source/WTF/ChangeLog 2021-12-06 21:06:11 UTC (rev 286564)
+++ trunk/Source/WTF/ChangeLog 2021-12-06 21:15:39 UTC (rev 286565)
@@ -1,3 +1,12 @@
+2021-12-06 Simon Fraser
+
+Add a call to os_signpost to tag a momentum scroll animation
+https://bugs.webkit.org/show_bug.cgi?id=233885
+
+Reviewed by Tim Horton.
+
+* wtf/SystemTracing.h:
+
2021-12-06 Antoine Quint
[Web Animations] Add a way to run scripted animations
Modified: trunk/Source/WTF/wtf/SystemTracing.h (286564 => 286565)
--- trunk/Source/WTF/wtf/SystemTracing.h 2021-12-06 21:06:11 UTC (rev 286564)
+++ trunk/Source/WTF/wtf/SystemTracing.h 2021-12-06 21:15:39 UTC (rev 286565)
@@ -196,6 +196,7 @@
WTF_EXPORT_PRIVATE os_log_t WTFSignpostLogHandle();
WTF_EXTERN_C_END
+// These macros only emit signposts on internal builds when WEBKIT_SIGNPOSTS_ENABLED is set.
#define WTFEmitSignpost(pointer, name, ...) \
WTFEmitSignpostWithFunction(os_signpost_event_emit, (pointer), name, ##__VA_ARGS__)
@@ -214,6 +215,21 @@
} \
} while (0)
+// These macros emit signposts on all builds.
+#define WTFEmitSignpostAlways(name, format, ...) \
+do { os_signpost_event_emit(WTFSignpostLogHandle(), OS_SIGNPOST_ID_EXCLUSIVE, name, format, ##__VA_ARGS__); } } while (0)
+
+#define WTFBeginSignpostIntervalAlways(name, format, ...) \
+do { os_signpost_interval_begin(WTFSignpostLogHandle(), OS_SIGNPOST_ID_EXCLUSIVE, name, format, ##__VA_ARGS__); } while (0)
+
+#define WTF_OS_SIGNPOST_ANIMATION_INTERVAL_TAG "isAnimation=YES"
+
+#define WTFBeginAnimationSignpostIntervalAlways(name, format, ...) \
+do { os_signpost_interval_begin(WTFSignpostLogHandle(), OS_SIGNPOST_ID_EXCLUSIVE, name, format " " WTF_OS_SIGNPOST_ANIMATION_INTERVAL_TAG, ##__VA_ARGS__); } while (0)
+
+#define WTFEndSignpostIntervalAlways(name, format, ...) \
+do { os_signpost_interval_end(WTFSignpostLogHandle(), OS_SIGNPOST_ID_EXCLUSIVE, name, format, ##__VA_ARGS__); } while (0)
+
#else
#define WTFEmitSignpost(pointer, name, ...) do { } while (0)
@@ -220,4 +236,9 @@
#define WTFBeginSignpost(pointer, name, ...) do { } while (0)
#define WTFEndSignpost(pointer, name, ...) do { } while (0)
+#define WTFEmitSignpostAlways(name, format, ...) do { } while (0)
+#define WTFBeginSignpostIntervalAlways(name, format, ...) do { } while (0)
+#define WTFBeginAnimationSignpostIntervalAlways(name, format, ...) do { } while (0)
+#define WTFEndSignpostIntervalAlways(name, format, ...) do { } while (0)
+
#endif
Modified: trunk/Source/WebCore/ChangeLog (286564 => 286565)
--- trunk/Source/WebCore/ChangeLog 2021-12-06 21:06:11 UTC (rev 286564)
+++ trunk/Source/WebCore/ChangeLog 2021-12-06 21:15:39 UTC (rev 286565)
@@ -1,3 +1,19 @@
+2021-12-06 Simon Fraser
+
+Add a call to os_signpost to tag a momentum scroll animation
+https://bugs.webkit.org/show_bug.cgi?id=233885
+
+Reviewed by Tim Horton.
+
+Use the momentum "Began" and "Ended" events to mark the start/end of a momentum scroll
+as an animation via os_signost.
+
+Put the code in ScrollingEffectsController rather than MomentumEventDispatcher so that
+non-generated momentum gets marked too.
+
+* platform/mac/ScrollingEffectsController.mm:
+(WebCore::ScrollingEffectsController::handleWheelEvent):
+
2021-12-06 Devin Rousso
Change IDL `Date` to be backed by `WallTime` to avoid confusion when converting to native dates
Modified: trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm (286564 => 286565)
--- trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm 2021-12-06 21:06:11 UTC (rev 286564)
+++ trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm 2021-12-06 21:15:39 UTC (rev 286565)
@@ -34,6 +34,7 @@
#import
#import
#import
+#import
#import
#if PLATFORM(MAC)
@@ -177,6 +178,10 @@
delta = deltaAlignedToDominantAxis(delta);
auto momentumPhase = wheelEvent.momentumPhase();
+
+if (momentumPhase == PlatformWheelEventPhase::Began)
+
[webkit-changes] [286564] trunk/Source/WebKit
Title: [286564] trunk/Source/WebKit
Revision 286564
Author beid...@apple.com
Date 2021-12-06 13:06:11 -0800 (Mon, 06 Dec 2021)
Log Message
Put webpushd code in WebKit.framework.
https://bugs.webkit.org/show_bug.cgi?id=233886
Reviewed by Alex Christensen.
This fixes some build/mastering/linking issues.
* Configurations/webpushd.xcconfig:
* Shared/API/Cocoa/WKMain.h:
* Shared/API/Cocoa/WKMain.mm:
(WKWebPushDaemonMain):
* WebKit.xcodeproj/project.pbxproj:
* webpushd/WebPushDaemonMain.h: Copied from Source/WebKit/Shared/API/Cocoa/WKMain.mm.
* webpushd/WebPushDaemonMain.mm:
(WebKit::WebPushDaemonMain):
(main): Deleted.
* webpushd/webpushd.cpp: Copied from Source/WebKit/Shared/API/Cocoa/WKMain.mm.
(main):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/webpushd.xcconfig
trunk/Source/WebKit/Shared/API/Cocoa/WKMain.h
trunk/Source/WebKit/Shared/API/Cocoa/WKMain.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/webpushd/WebPushDaemonMain.mm
Added Paths
trunk/Source/WebKit/webpushd/WebPushDaemonMain.h
trunk/Source/WebKit/webpushd/webpushd.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (286563 => 286564)
--- trunk/Source/WebKit/ChangeLog 2021-12-06 21:03:27 UTC (rev 286563)
+++ trunk/Source/WebKit/ChangeLog 2021-12-06 21:06:11 UTC (rev 286564)
@@ -1,3 +1,24 @@
+2021-12-06 Brady Eidson
+
+Put webpushd code in WebKit.framework.
+https://bugs.webkit.org/show_bug.cgi?id=233886
+
+Reviewed by Alex Christensen.
+
+This fixes some build/mastering/linking issues.
+
+* Configurations/webpushd.xcconfig:
+* Shared/API/Cocoa/WKMain.h:
+* Shared/API/Cocoa/WKMain.mm:
+(WKWebPushDaemonMain):
+* WebKit.xcodeproj/project.pbxproj:
+* webpushd/WebPushDaemonMain.h: Copied from Source/WebKit/Shared/API/Cocoa/WKMain.mm.
+* webpushd/WebPushDaemonMain.mm:
+(WebKit::WebPushDaemonMain):
+(main): Deleted.
+* webpushd/webpushd.cpp: Copied from Source/WebKit/Shared/API/Cocoa/WKMain.mm.
+(main):
+
2021-12-06 Brent Fulgham
REGRESSION (r286527): Three API tests crashing under WebKit::ProcessLauncher::launchProcess()
Modified: trunk/Source/WebKit/Configurations/webpushd.xcconfig (286563 => 286564)
--- trunk/Source/WebKit/Configurations/webpushd.xcconfig 2021-12-06 21:03:27 UTC (rev 286563)
+++ trunk/Source/WebKit/Configurations/webpushd.xcconfig 2021-12-06 21:06:11 UTC (rev 286564)
@@ -25,7 +25,7 @@
PRODUCT_NAME = webpushd;
-OTHER_LDFLAGS = -l WTF -framework Foundation -framework CoreFoundation;
+OTHER_LDFLAGS = -framework WebKit;
LIBRARY_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR);
WK_PROCESSED_XCENT_FILE=$(TEMP_FILE_DIR)/$(FULL_PRODUCT_NAME).entitlements
Modified: trunk/Source/WebKit/Shared/API/Cocoa/WKMain.h (286563 => 286564)
--- trunk/Source/WebKit/Shared/API/Cocoa/WKMain.h 2021-12-06 21:03:27 UTC (rev 286563)
+++ trunk/Source/WebKit/Shared/API/Cocoa/WKMain.h 2021-12-06 21:06:11 UTC (rev 286564)
@@ -34,6 +34,7 @@
WK_EXPORT int WKXPCServiceMain(int argc, const char** argv) WK_API_AVAILABLE(macos(10.15), ios(13.0));
WK_EXPORT int WKAdAttributionDaemonMain(int argc, const char** argv) WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+WK_EXPORT int WKWebPushDaemonMain(int argc, const char** argv) WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
#ifdef __cplusplus
}
Modified: trunk/Source/WebKit/Shared/API/Cocoa/WKMain.mm (286563 => 286564)
--- trunk/Source/WebKit/Shared/API/Cocoa/WKMain.mm 2021-12-06 21:03:27 UTC (rev 286563)
+++ trunk/Source/WebKit/Shared/API/Cocoa/WKMain.mm 2021-12-06 21:06:11 UTC (rev 286564)
@@ -27,6 +27,7 @@
#import "WKMain.h"
#import "PCMDaemonEntryPoint.h"
+#import "WebPushDaemonMain.h"
#import "XPCServiceEntryPoint.h"
int WKXPCServiceMain(int argc, const char** argv)
@@ -38,3 +39,8 @@
{
return WebKit::PCMDaemonMain(argc, argv);
}
+
+int WKWebPushDaemonMain(int argc, const char** argv)
+{
+return WebKit::WebPushDaemonMain(argc, argv);
+}
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (286563 => 286564)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-12-06 21:03:27 UTC (rev 286563)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-12-06 21:06:11 UTC (rev 286564)
@@ -967,8 +967,6 @@
5129EB1223D0DE7B00AF1CD7 /* ContentWorldShared.h in Headers */ = {isa = PBXBuildFile; fileRef = 5129EB1123D0DE7800AF1CD7 /* ContentWorldShared.h */; };
512CD6982721EFC800F7F8EC /* WebPushDaemonConnection.h in Headers */ = {isa = PBXBuildFile; fileRef = 512CD6972721EFC300F7F8EC /* WebPushDaemonConnection.h */; };
512CD69A2721F0A900F7F8EC /* WebPushDaemonConstants.h in Headers */ = {isa = PBXBuildFile; fileRef = 512CD6992721F04900F7F8EC /* WebPushDaemonConstants.h */; };
- 512CD69F2723393A00F7F8EC /* WebPushDaemon.h in Headers */ = {isa = PBXBuildFile; fileRef = 512CD69D2723393A00F7F8EC /* WebPushDaemon.h */; };
-
[webkit-changes] [286563] trunk/Source/WebKit
Title: [286563] trunk/Source/WebKit
Revision 286563
Author bfulg...@apple.com
Date 2021-12-06 13:03:27 -0800 (Mon, 06 Dec 2021)
Log Message
REGRESSION (r286527): Three API tests crashing under WebKit::ProcessLauncher::launchProcess()
https://bugs.webkit.org/show_bug.cgi?id=233882
Reviewed by Brent Fulgham.
Correct the eventHandler to capture the process name, rather than using a raw pointer to the character string.
* UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (286562 => 286563)
--- trunk/Source/WebKit/ChangeLog 2021-12-06 21:01:35 UTC (rev 286562)
+++ trunk/Source/WebKit/ChangeLog 2021-12-06 21:03:27 UTC (rev 286563)
@@ -1,3 +1,16 @@
+2021-12-06 Brent Fulgham
+
+REGRESSION (r286527): Three API tests crashing under WebKit::ProcessLauncher::launchProcess()
+https://bugs.webkit.org/show_bug.cgi?id=233882
+
+
+Reviewed by Brent Fulgham.
+
+Correct the eventHandler to capture the process name, rather than using a raw pointer to the character string.
+
+* UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
+(WebKit::ProcessLauncher::launchProcess):
+
2021-12-06 Per Arne Vollan
[iOS][WP] Block access to unused IOKit class
Modified: trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm (286562 => 286563)
--- trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm 2021-12-06 21:01:35 UTC (rev 286562)
+++ trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm 2021-12-06 21:03:27 UTC (rev 286563)
@@ -239,7 +239,7 @@
xpc_dictionary_set_value(bootstrapMessage.get(), "extra-initialization-data", extraInitializationData.get());
-auto errorHandlerImpl = [weakProcessLauncher = WeakPtr { *this }, listeningPort, name] (xpc_object_t event) {
+auto errorHandlerImpl = [weakProcessLauncher = WeakPtr { *this }, listeningPort, logName = String(name)] (xpc_object_t event) {
ASSERT(!event || xpc_get_type(event) == XPC_TYPE_ERROR);
auto processLauncher = weakProcessLauncher.get();
@@ -250,10 +250,13 @@
return;
#if ERROR_DISABLED
-UNUSED_PARAM(name);
+UNUSED_PARAM(logName);
#endif
-LOG_ERROR("Error while launching %s: %s", name, xpc_dictionary_get_string(event, XPC_ERROR_KEY_DESCRIPTION));
+if (event)
+LOG_ERROR("Error while launching %s: %s", logName.utf8().data(), xpc_dictionary_get_string(event, XPC_ERROR_KEY_DESCRIPTION));
+else
+LOG_ERROR("Error while launching %s: No xpc_object_t event available.", logName.utf8().data());
#if ASSERT_ENABLED
mach_port_urefs_t sendRightCount = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286562] trunk/PerformanceTests
Title: [286562] trunk/PerformanceTests
Revision 286562
Author commit-qu...@webkit.org
Date 2021-12-06 13:01:35 -0800 (Mon, 06 Dec 2021)
Log Message
[RAMification] Add support for dumping smaps rollups on Linux
https://bugs.webkit.org/show_bug.cgi?id=233867
Patch by Zan Dobersek on 2021-12-06
Reviewed by Yusuke Suzuki.
Add the option to dump smaps rollup after the end of each RAMification
test case. This mirrors the vmmap functionality and is implemented
alongside that option.
Once the jsc binary is left idle after the test case run, the
smaps_rollup output for the given jsc process is collected from the
proc filesystem. This material is then printed out after the test
is done, following the memory footprint dump.
For now this prefers the smaps_rollup instead of the complete smaps.
In this form, it already gives a good insight into the balance between
the proportional and residential set size amounts. Complete smaps could
be beneficial later, especially if we can implement differentiation
between allocations of different types and/or purposes.
* JetStream2/RAMification.py:
(parseArgs):
(BaseRunner.__init__):
(BaseRunner.getResults):
(LocalRunner.runOneTest):
(main):
(main.runTestList):
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/JetStream2/RAMification.py
Diff
Modified: trunk/PerformanceTests/ChangeLog (286561 => 286562)
--- trunk/PerformanceTests/ChangeLog 2021-12-06 20:52:54 UTC (rev 286561)
+++ trunk/PerformanceTests/ChangeLog 2021-12-06 21:01:35 UTC (rev 286562)
@@ -1,3 +1,33 @@
+2021-12-06 Zan Dobersek
+
+[RAMification] Add support for dumping smaps rollups on Linux
+https://bugs.webkit.org/show_bug.cgi?id=233867
+
+Reviewed by Yusuke Suzuki.
+
+Add the option to dump smaps rollup after the end of each RAMification
+test case. This mirrors the vmmap functionality and is implemented
+alongside that option.
+
+Once the jsc binary is left idle after the test case run, the
+smaps_rollup output for the given jsc process is collected from the
+proc filesystem. This material is then printed out after the test
+is done, following the memory footprint dump.
+
+For now this prefers the smaps_rollup instead of the complete smaps.
+In this form, it already gives a good insight into the balance between
+the proportional and residential set size amounts. Complete smaps could
+be beneficial later, especially if we can implement differentiation
+between allocations of different types and/or purposes.
+
+* JetStream2/RAMification.py:
+(parseArgs):
+(BaseRunner.__init__):
+(BaseRunner.getResults):
+(LocalRunner.runOneTest):
+(main):
+(main.runTestList):
+
2021-11-21 Cathie Chen
[Performance test][css-contain] Add case to test contain: layout inside a complex document
Modified: trunk/PerformanceTests/JetStream2/RAMification.py (286561 => 286562)
--- trunk/PerformanceTests/JetStream2/RAMification.py 2021-12-06 20:52:54 UTC (rev 286561)
+++ trunk/PerformanceTests/JetStream2/RAMification.py 2021-12-06 21:01:35 UTC (rev 286562)
@@ -43,7 +43,7 @@
footprintRE = re.compile(r"Current Footprint: (\d+(?:.\d+)?)")
peakFootprintRE = re.compile(r"Peak Footprint: (\d+(?:.\d+)?)")
-TestResult = collections.namedtuple("TestResult", ["name", "returnCode", "footprint", "peakFootprint", "vmmapOutput"])
+TestResult = collections.namedtuple("TestResult", ["name", "returnCode", "footprint", "peakFootprint", "vmmapOutput", "smapsOutput"])
ramification_dir = os.path.abspath(os.path.dirname(os.path.realpath(__file__)))
@@ -121,6 +121,7 @@
parser.add_argument("-n", "--run-no-jit", dest="runNoJITTests", nargs="?", const=True, default=None, type=optStrToBool, metavar="true / false", help="Run no JIT tests [default]")
parser.add_argument("-o", "--output", dest="jsonFilename", type=str, default=None, metavar="JSON-output-file", help="Path to JSON output")
parser.add_argument("-m", "--vmmap", dest="takeVmmap", action="" default=False, help="Take a vmmap after each test")
+parser.add_argument("--smaps", dest="takeSmaps", action="" default=False, help="Take a smaps rollup after each test")
args = parser.parse_args()
@@ -147,7 +148,8 @@
def __init__(self, args):
self.rootDir = args.testDir
self.environmentVars = {}
-self.vmmapOutput = ""
+self.vmmapOutput = "" if args.takeVmmap else None
+self.smapsOutput = "" if args.takeSmaps else None
def setup(self):
pass
@@ -180,7 +182,7 @@
self.returnCode = returnCode
def getResults(self):
-return TestResult(name=self.testName, returnCode=self.returnCode, footprint=self.footprint, peakFootprint=self.peakFootprint, vmmapOutput=self.vmmapOutput)
+return TestResult(name=self.testName, returnCode=self.returnCode, footprint=self.footprint,
[webkit-changes] [286561] branches/safari-613.1.11-branch/
Title: [286561] branches/safari-613.1.11-branch/ Revision 286561 Author repst...@apple.com Date 2021-12-06 12:52:54 -0800 (Mon, 06 Dec 2021) Log Message New branch. Added Paths branches/safari-613.1.11-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286560] trunk/Source
Title: [286560] trunk/Source Revision 286560 Author drou...@apple.com Date 2021-12-06 12:04:24 -0800 (Mon, 06 Dec 2021) Log Message Change IDL `Date` to be backed by `WallTime` to avoid confusion when converting to native dates https://bugs.webkit.org/show_bug.cgi?id=233781 Reviewed by Darin Adler. JS `Date` is milliseconds-based, but some native dates (e.g. `NSDate`) are seconds-based. `WallTime` will help avoid confusion since not a generic type (e.g. `double`) and instead has explicitly defined conversion methods to seconds, milliseconds, etc.. Source/WebCore: * bindings/IDLTypes.h: (WebCore::IDLDate::nullValue): (WebCore::IDLDate::isNullValue): (WebCore::IDLDate::extractValueFromNullable): * bindings/js/JSDOMConvertDate.h: (WebCore::Converter::convert): (WebCore::JSConverter::convert): * bindings/js/JSDOMConvertDate.cpp: (WebCore::jsDate): (WebCore::valueToDate): * Modules/applepay/ApplePayLineItem.h: (WebCore::ApplePayLineItem::decode): * Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm: (WebCore::toDate): * bindings/js/IDBBindingUtilities.cpp: (WebCore::get): (WebCore::toJS): (WebCore::createIDBKeyFromValue): * html/BaseDateAndTimeInputType.h: * html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::valueAsDate const): (WebCore::DateTimeLocalInputType::setValueAsDate const): * html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::valueAsDate const): (WebCore::BaseDateAndTimeInputType::setValueAsDate const): * html/DateTimeLocalInputType.h: * html/HTMLInputElement.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate const): (WebCore::HTMLInputElement::setValueAsDate): * html/InputType.h: * html/InputType.cpp: (WebCore::InputType::valueAsDate const): (WebCore::InputType::setValueAsDate const): * html/MonthInputType.h: * html/MonthInputType.cpp: (WebCore::MonthInputType::valueAsDate const): * html/HTMLMediaElement.h: * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::getStartDate const): This also fixes an apparently longstanding bug in that `MediaTime::toDouble` is apparently a seconds-based value, so this is the one case that doesn't need `Seconds::fromMilliseconds`. Source/WebKitLegacy/mac: * DOM/DOMInternal.h: (kit): (core): * DOM/DOMHTMLMediaElement.mm: (-[DOMHTMLMediaElement getStartDate]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/applepay/ApplePayLineItem.h trunk/Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm trunk/Source/WebCore/bindings/IDLTypes.h trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp trunk/Source/WebCore/bindings/js/JSDOMConvertDate.cpp trunk/Source/WebCore/bindings/js/JSDOMConvertDate.h trunk/Source/WebCore/html/BaseDateAndTimeInputType.cpp trunk/Source/WebCore/html/BaseDateAndTimeInputType.h trunk/Source/WebCore/html/DateTimeLocalInputType.cpp trunk/Source/WebCore/html/DateTimeLocalInputType.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/html/InputType.cpp trunk/Source/WebCore/html/InputType.h trunk/Source/WebCore/html/MonthInputType.cpp trunk/Source/WebCore/html/MonthInputType.h trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/DOM/DOMHTMLMediaElement.mm trunk/Source/WebKitLegacy/mac/DOM/DOMInternal.h Diff Modified: trunk/Source/WebCore/ChangeLog (286559 => 286560) --- trunk/Source/WebCore/ChangeLog 2021-12-06 20:02:14 UTC (rev 286559) +++ trunk/Source/WebCore/ChangeLog 2021-12-06 20:04:24 UTC (rev 286560) @@ -1,3 +1,59 @@ +2021-12-06 Devin Rousso + +Change IDL `Date` to be backed by `WallTime` to avoid confusion when converting to native dates +https://bugs.webkit.org/show_bug.cgi?id=233781 + +Reviewed by Darin Adler. + +JS `Date` is milliseconds-based, but some native dates (e.g. `NSDate`) are seconds-based. +`WallTime` will help avoid confusion since not a generic type (e.g. `double`) and instead +has explicitly defined conversion methods to seconds, milliseconds, etc.. + +* bindings/IDLTypes.h: +(WebCore::IDLDate::nullValue): +(WebCore::IDLDate::isNullValue): +(WebCore::IDLDate::extractValueFromNullable): +* bindings/js/JSDOMConvertDate.h: +(WebCore::Converter::convert): +(WebCore::JSConverter::convert): +* bindings/js/JSDOMConvertDate.cpp: +(WebCore::jsDate): +(WebCore::valueToDate): + +* Modules/applepay/ApplePayLineItem.h: +(WebCore::ApplePayLineItem::decode): +* Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm: +(WebCore::toDate): +* bindings/js/IDBBindingUtilities.cpp: +(WebCore::get): +(WebCore::toJS): +(WebCore::createIDBKeyFromValue): +* html/BaseDateAndTimeInputType.h: +* html/DateTimeLocalInputType.cpp: +
[webkit-changes] [286559] branches/safari-613.1.10-branch/Source
Title: [286559] branches/safari-613.1.10-branch/Source Revision 286559 Author repst...@apple.com Date 2021-12-06 12:02:14 -0800 (Mon, 06 Dec 2021) Log Message Versioning. WebKit-7613.1.10.2 Modified Paths branches/safari-613.1.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig (286558 => 286559) --- branches/safari-613.1.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-12-06 19:45:45 UTC (rev 286558) +++ branches/safari-613.1.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-12-06 20:02:14 UTC (rev 286559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (286558 => 286559) --- branches/safari-613.1.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-12-06 19:45:45 UTC (rev 286558) +++ branches/safari-613.1.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-12-06 20:02:14 UTC (rev 286559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (286558 => 286559) --- branches/safari-613.1.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-12-06 19:45:45 UTC (rev 286558) +++ branches/safari-613.1.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-12-06 20:02:14 UTC (rev 286559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.10-branch/Source/WebCore/Configurations/Version.xcconfig (286558 => 286559) --- branches/safari-613.1.10-branch/Source/WebCore/Configurations/Version.xcconfig 2021-12-06 19:45:45 UTC (rev 286558) +++ branches/safari-613.1.10-branch/Source/WebCore/Configurations/Version.xcconfig 2021-12-06 20:02:14 UTC (rev 286559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (286558 => 286559) --- branches/safari-613.1.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-12-06 19:45:45 UTC (rev 286558) +++ branches/safari-613.1.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-12-06 20:02:14 UTC (rev 286559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.10-branch/Source/WebGPU/Configurations/Version.xcconfig (286558 => 286559) --- branches/safari-613.1.10-branch/Source/WebGPU/Configurations/Version.xcconfig 2021-12-06 19:45:45 UTC (rev 286558) +++ branches/safari-613.1.10-branch/Source/WebGPU/Configurations/Version.xcconfig 2021-12-06 20:02:14 UTC (rev 286559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.10-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (286558 => 286559) --- branches/safari-613.1.10-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-12-06 19:45:45 UTC (rev 286558) +++ branches/safari-613.1.10-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-12-06 20:02:14 UTC (rev 286559) @@ -1,7 +1,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10;
[webkit-changes] [286558] trunk
Title: [286558] trunk Revision 286558 Author pan...@apple.com Date 2021-12-06 11:45:45 -0800 (Mon, 06 Dec 2021) Log Message Web Inspector: Support Cascade Layers in the Styles sidebar https://bugs.webkit.org/show_bug.cgi?id=233208 Reviewed by Devin Rousso. Source/_javascript_Core: Add new values to `CSS.Grouping`'s `type` enum for cascade layers and make the `text` optional since an anonymous layer will not have a name or other text. * inspector/protocol/CSS.json: Source/WebCore: Test: inspector/css/getMatchedStylesForNodeLayerGrouping.html Add support for parsing and grouping CSS `@layer` rules in `InspectorStyleSheet` to the existing paths for handling other groupings so that the frontend is made aware of rules wrapped inside a layer or multiple layers. * Headers.cmake: * WebCore.xcodeproj/project.pbxproj: - CompiledSelector.h needs to be exported as a private header to include in WebKitLegacy's build, since it is imported by StyleRule.h, which is now imported by CSSImportRule.h, which is imported in WebKitLegacy. * css/CSSImportRule.cpp: (WebCore::CSSImportRule::cascadeLayerName const): * css/CSSImportRule.h: * css/CSSLayerRule.cpp: (WebCore::CSSLayerRule::cssText const): (WebCore::CSSLayerRule::layerName const): (WebCore::CSSLayerRule::stringFromCascadeLayerName): * css/CSSLayerRule.h: * inspector/InspectorStyleSheet.cpp: (flattenSourceData): (WebCore::asCSSRuleList): (WebCore::buildArrayForGroupings): * style/InspectorCSSOMWrappers.cpp: (WebCore::Style::InspectorCSSOMWrappers::collect): Source/WebInspectorUI: * UserInterface/Models/CSSGrouping.js: (WI.CSSGrouping): (WI.CSSGrouping.prototype.get isLayer): (WI.CSSGrouping.prototype.get prefix): - Update `CSSGrouping` to support `@layer` rules, and make `text` optional for a grouping, since anonymous layers will not have a name. * UserInterface/Models/CSSStyleDeclaration.js: (WI.CSSStyleDeclaration.prototype.generateFormattedText): - Ensure that spacing remains correct and "null" isn't shown for groupings without text. * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: (WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout): - When merging layer groups, ensure that a "." is used as a separator, and that each group has a name (to prevent having a hanging period or the "null" text appearing). LayoutTests: Add new test cases for `CSS.getMatchesStyleForNode` to make sure that layer groupings are correctly determined, and that rules nested in `@layer` rules and `@import layer()`s are correctly represented and sorted by the order they are applied to an element. * inspector/css/getMatchedStylesForNode-expected.txt: - Re-baseline to account for change in order of CSSGrouping properties in the protocol due to `text` now being optional. * inspector/css/getMatchedStylesForNodeLayerGrouping-expected.txt: Added. * inspector/css/getMatchedStylesForNodeLayerGrouping.html: Added. * inspector/css/resources/external-layers.css: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/css/getMatchedStylesForNode-expected.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/protocol/CSS.json trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/css/CSSImportRule.cpp trunk/Source/WebCore/css/CSSImportRule.h trunk/Source/WebCore/css/CSSLayerRule.cpp trunk/Source/WebCore/css/CSSLayerRule.h trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp trunk/Source/WebCore/style/InspectorCSSOMWrappers.cpp trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/CSSGrouping.js trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js Added Paths trunk/LayoutTests/inspector/css/getMatchedStylesForNodeLayerGrouping-expected.txt trunk/LayoutTests/inspector/css/getMatchedStylesForNodeLayerGrouping.html trunk/LayoutTests/inspector/css/resources/external-layers.css Diff Modified: trunk/LayoutTests/ChangeLog (286557 => 286558) --- trunk/LayoutTests/ChangeLog 2021-12-06 19:45:31 UTC (rev 286557) +++ trunk/LayoutTests/ChangeLog 2021-12-06 19:45:45 UTC (rev 286558) @@ -1,3 +1,21 @@ +2021-12-06 Patrick Angle + +Web Inspector: Support Cascade Layers in the Styles sidebar +https://bugs.webkit.org/show_bug.cgi?id=233208 + +Reviewed by Devin Rousso. + +Add new test cases for `CSS.getMatchesStyleForNode` to make sure that layer groupings are correctly determined, +and that rules nested in `@layer` rules and `@import layer()`s are correctly represented and sorted by the order +they are applied to an element. + +* inspector/css/getMatchedStylesForNode-expected.txt: +- Re-baseline to account for change in order of CSSGrouping properties in the protocol due to `text` now being +optional. +*
[webkit-changes] [286557] trunk/Source/WebKit
Title: [286557] trunk/Source/WebKit Revision 286557 Author pvol...@apple.com Date 2021-12-06 11:45:31 -0800 (Mon, 06 Dec 2021) Log Message [iOS][WP] Block access to unused IOKit class https://bugs.webkit.org/show_bug.cgi?id=233866 Reviewed by Brent Fulgham. Block access to IOKit class IOMobileFramebufferUserClient in the WebContent process' sandbox on iOS, which is unused according to telemetry. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * UIProcess/WebPageProxy.cpp: (WebKit::gpuIOKitClasses): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (286556 => 286557) --- trunk/Source/WebKit/ChangeLog 2021-12-06 19:45:01 UTC (rev 286556) +++ trunk/Source/WebKit/ChangeLog 2021-12-06 19:45:31 UTC (rev 286557) @@ -1,3 +1,18 @@ +2021-12-06 Per Arne Vollan + +[iOS][WP] Block access to unused IOKit class +https://bugs.webkit.org/show_bug.cgi?id=233866 + + +Reviewed by Brent Fulgham. + +Block access to IOKit class IOMobileFramebufferUserClient in the WebContent process' sandbox on iOS, +which is unused according to telemetry. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: +* UIProcess/WebPageProxy.cpp: +(WebKit::gpuIOKitClasses): + 2021-12-06 Matt Gilligan [iOS] Allow WKWebView clients to override undoManager Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (286556 => 286557) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-12-06 19:45:01 UTC (rev 286556) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-12-06 19:45:31 UTC (rev 286557) @@ -92,30 +92,12 @@ domains)) (define-once (framebuffer-access) -(allow iokit-open -(require-all -(extension "com.apple.webkit.extension.iokit") -(iokit-user-client-class "IOMobileFramebufferUserClient") -) -(when (defined? 'iokit-external-method) -(apply-message-filter -(deny (with telemetry) -iokit-async-external-method -iokit-external-method -iokit-external-trap) -(allow (with telemetry) iokit-external-method -(iokit-method-number -8 -28 -) -) -) -) -) +(deny iokit-open (with telemetry-backtrace) +(iokit-user-client-class "IOMobileFramebufferUserClient")) ; IOMobileFramebuffer (with-filter (iokit-registry-entry-class "IOMobileFramebuffer") -(allow iokit-get-properties +(allow iokit-get-properties (with telemetry) (iokit-property "AppleTV" "DisplayPipePlaneBaseAlignment" "DisplayPipeStrideRequirements" Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (286556 => 286557) --- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-12-06 19:45:01 UTC (rev 286556) +++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-12-06 19:45:31 UTC (rev 286557) @@ -8052,8 +8052,10 @@ "IOAudioEngineUserClient"_s, "IOSurfaceRootUserClient"_s, #endif -#if (PLATFORM(MAC) && CPU(ARM64)) || PLATFORM(IOS_FAMILY) +#if PLATFORM(MAC) && CPU(ARM64) "IOMobileFramebufferUserClient"_s, +#endif +#if PLATFORM(MAC) && CPU(ARM64) || PLATFORM(IOS_FAMILY) "IOSurfaceAcceleratorClient"_s, #endif }); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286556] trunk/Source/WebCore
Title: [286556] trunk/Source/WebCore
Revision 286556
Author wenson_hs...@apple.com
Date 2021-12-06 11:45:01 -0800 (Mon, 06 Dec 2021)
Log Message
Unreviewed, add some missing #includes in WebCore
Add several missing `#include`-s, which currently aren't causing any issues due to unified sources (but will
once I introduce several new source files in `WebCore/Modules` in a future patch).
* Modules/web-locks/WebLockRegistry.cpp:
* page/Page.cpp:
* page/PageConfiguration.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/web-locks/WebLockRegistry.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/PageConfiguration.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (286555 => 286556)
--- trunk/Source/WebCore/ChangeLog 2021-12-06 19:30:57 UTC (rev 286555)
+++ trunk/Source/WebCore/ChangeLog 2021-12-06 19:45:01 UTC (rev 286556)
@@ -1,3 +1,14 @@
+2021-12-06 Wenson Hsieh
+
+Unreviewed, add some missing #includes in WebCore
+
+Add several missing `#include`-s, which currently aren't causing any issues due to unified sources (but will
+once I introduce several new source files in `WebCore/Modules` in a future patch).
+
+* Modules/web-locks/WebLockRegistry.cpp:
+* page/Page.cpp:
+* page/PageConfiguration.h:
+
2021-12-06 Antoine Quint
[Web Animations] Add a way to run scripted animations
Modified: trunk/Source/WebCore/Modules/web-locks/WebLockRegistry.cpp (286555 => 286556)
--- trunk/Source/WebCore/Modules/web-locks/WebLockRegistry.cpp 2021-12-06 19:30:57 UTC (rev 286555)
+++ trunk/Source/WebCore/Modules/web-locks/WebLockRegistry.cpp 2021-12-06 19:45:01 UTC (rev 286556)
@@ -26,6 +26,7 @@
#include "WebLockRegistry.h"
#include "Exception.h"
+#include "WebLockManager.h"
#include "WebLockManagerSnapshot.h"
#include
#include
Modified: trunk/Source/WebCore/page/Page.cpp (286555 => 286556)
--- trunk/Source/WebCore/page/Page.cpp 2021-12-06 19:30:57 UTC (rev 286555)
+++ trunk/Source/WebCore/page/Page.cpp 2021-12-06 19:45:01 UTC (rev 286556)
@@ -26,6 +26,7 @@
#include "AppHighlightStorage.h"
#include "ApplicationCacheStorage.h"
#include "AuthenticatorCoordinator.h"
+#include "AuthenticatorCoordinatorClient.h"
#include "BackForwardCache.h"
#include "BackForwardClient.h"
#include "BackForwardController.h"
@@ -138,6 +139,7 @@
#include "SharedBuffer.h"
#include "SocketProvider.h"
#include "SpeechRecognitionProvider.h"
+#include "SpeechSynthesisClient.h"
#include "StorageArea.h"
#include "StorageNamespace.h"
#include "StorageNamespaceProvider.h"
@@ -159,6 +161,7 @@
#include "VisitedLinkStore.h"
#include "VoidCallback.h"
#include "WebCoreJSClientData.h"
+#include "WebLockRegistry.h"
#include "WheelEventDeltaFilter.h"
#include "WheelEventTestMonitor.h"
#include "Widget.h"
Modified: trunk/Source/WebCore/page/PageConfiguration.h (286555 => 286556)
--- trunk/Source/WebCore/page/PageConfiguration.h 2021-12-06 19:30:57 UTC (rev 286555)
+++ trunk/Source/WebCore/page/PageConfiguration.h 2021-12-06 19:45:01 UTC (rev 286556)
@@ -38,6 +38,10 @@
#include "ApplicationManifest.h"
#endif
+#if ENABLE(DEVICE_ORIENTATION)
+#include "DeviceOrientationUpdateProvider.h"
+#endif
+
namespace WebCore {
class AlternativeTextClient;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286555] trunk
Title: [286555] trunk
Revision 286555
Author grao...@webkit.org
Date 2021-12-06 11:30:57 -0800 (Mon, 06 Dec 2021)
Log Message
[Web Animations] Add a way to run scripted animations
https://bugs.webkit.org/show_bug.cgi?id=233869
rdar://85983542
Reviewed by Dean Jackson.
Source/WebCore:
Tests: webanimations/custom-effect/custom-effect.html
webanimations/custom-effect/document-timeline-animate.html
This patch adds two new Web-exposed features to allow authors to write callback-based animations
leveraging the full power of the Web Animations model.
First, we add a new AnimationEffect subclass which wraps a callback to be executed on every tick
of the associated animation's timeline: CustomEffect. It can be constructed by providing a JS function
as its first parameter, and either a number or a dictionary to provide timing properties for the effect.
This is similar to how KeyframeEffect will accept a keyframes object and then timing data. The callback
is provided the effect progress as its sole parameter. Web authors can use this new interface as follows:
const animation = new Animation;
animation.effect = new CustomEffect(progress => { … }, 1000);
animation.play();
Second, to make starting callback-based animations more straightforward and in a very similar fashion
to how keyframe animations can be initiated on an element using Element.animate(), we introduce a new
animate() method on DocumentTimeline, allowing the previous exmaple to be written as:
const animation = document.timeline.animate(progress => { … }, 1000);
This simple approach allows Web authors to move past the simple use of requestAnimationFrame() and harness
the Web Animations timing model which will let them pause and resume animations, seek them, control their
playback rate, apply easing, respond to the "finished" promise, etc.
The code itself is very simple, CustomEffect is simply an AnimationEffect subclass that indicates that it's
always interested in scheduling updates while active using the ticksContinouslyWhileActive() method. This
means that all the scheduling logic contained in WebAnimation and AnimationEffect applies, allowing callbacks
to not be fired when the animation is paused or when the page is suspended, or fired sparingly when a steps()
timing function is specified.
* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Headers.cmake:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* animation/AnimationEffect.h:
(WebCore::AnimationEffect::isCustomEffect const):
* animation/CustomAnimationOptions.h: Added.
* animation/CustomAnimationOptions.idl: Added.
* animation/CustomEffect.cpp: Added.
(WebCore::CustomEffect::create):
(WebCore::CustomEffect::CustomEffect):
(WebCore::CustomEffect::animationDidTick):
* animation/CustomEffect.h: Added.
(WebCore::CustomEffect::~CustomEffect):
* animation/CustomEffect.idl: Added.
* animation/CustomEffectCallback.h: Added.
* animation/CustomEffectCallback.idl: Added.
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::animate):
* animation/DocumentTimeline.h:
* animation/DocumentTimeline.idl:
* bindings/js/WebCoreBuiltinNames.h:
Source/WTF:
Add a new experimental feature for the CustomEffect interface.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
LayoutTests:
Add tests for the new CustomEffect interface and the document.timeline.animate() method.
These are written using WPT libraries such that they may be upstreamed to the WPT repository
in the future if and when the CustomEffect interface is standardized.
* platform/win/TestExpectations:
* webanimations/custom-effect/custom-effect-expected.txt: Added.
* webanimations/custom-effect/custom-effect.html: Added.
* webanimations/custom-effect/document-timeline-animate-expected.txt: Added.
* webanimations/custom-effect/document-timeline-animate.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources-input.xcfilelist
trunk/Source/WebCore/DerivedSources-output.xcfilelist
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/animation/AnimationEffect.h
trunk/Source/WebCore/animation/DocumentTimeline.cpp
trunk/Source/WebCore/animation/DocumentTimeline.h
trunk/Source/WebCore/animation/DocumentTimeline.idl
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
Added Paths
trunk/LayoutTests/webanimations/custom-effect/
trunk/LayoutTests/webanimations/custom-effect/custom-effect-expected.txt
trunk/LayoutTests/webanimations/custom-effect/custom-effect.html
trunk/LayoutTests/webanimations/custom-effect/document-timeline-animate-expected.txt
[webkit-changes] [286554] trunk
Title: [286554] trunk Revision 286554 Author jon...@apple.com Date 2021-12-06 11:22:54 -0800 (Mon, 06 Dec 2021) Log Message Update GPU Process feature flags https://bugs.webkit.org/show_bug.cgi?id=232547 rdar://83905400 Reviewed by Wenson Hsieh. Source/WTF: Move features enabled by default to internal. DOM and WebGL are experimental. * Scripts/Preferences/WebPreferencesExperimental.yaml: * Scripts/Preferences/WebPreferencesInternal.yaml: Tools: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): Update features that are set when using `run-webkit-tests --use-gpu-process`. * WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): Turn off DOM Rendering on layout test bots for the time being. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py trunk/Tools/WebKitTestRunner/TestOptions.cpp Diff Modified: trunk/Source/WTF/ChangeLog (286553 => 286554) --- trunk/Source/WTF/ChangeLog 2021-12-06 19:13:26 UTC (rev 286553) +++ trunk/Source/WTF/ChangeLog 2021-12-06 19:22:54 UTC (rev 286554) @@ -1,3 +1,16 @@ +2021-12-06 Jon Lee + +Update GPU Process feature flags +https://bugs.webkit.org/show_bug.cgi?id=232547 +rdar://83905400 + +Reviewed by Wenson Hsieh. + +Move features enabled by default to internal. DOM and WebGL are experimental. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: +* Scripts/Preferences/WebPreferencesInternal.yaml: + 2021-12-06 Nikolas Zimmermann [LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effect Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (286553 => 286554) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-12-06 19:13:26 UTC (rev 286553) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-12-06 19:22:54 UTC (rev 286554) @@ -361,17 +361,6 @@ WebCore: default: false -CaptureVideoInGPUProcessEnabled: - type: bool - humanReadableName: "GPU Process: Video Capture" - humanReadableDescription: "Enable video capture in GPU Process" - webcoreBinding: none - condition: ENABLE(MEDIA_STREAM) - exposed: [ WebKit ] - defaultValue: -WebKit: - default: WebKit::defaultCaptureVideoInGPUProcessEnabled() - ContactPickerAPIEnabled: type: bool humanReadableName: "Contact Picker API" @@ -1372,28 +1361,17 @@ WebKit: default: true -UseGPUProcessForCanvasRenderingEnabled: +UseGPUProcessForDOMRenderingEnabled: type: bool - humanReadableName: "GPU Process: Canvas Rendering" - humanReadableDescription: "Enable canvas rendering in GPU Process" + humanReadableName: "GPU Process: DOM Rendering" + humanReadableDescription: "Enable DOM rendering in GPU Process" webcoreBinding: none - condition: ENABLE(GPU_PROCESS) && !(PLATFORM(GTK) || PLATFORM(WPE)) + condition: ENABLE(GPU_PROCESS) exposed: [ WebKit ] defaultValue: WebKit: - default: defaultUseGPUProcessForCanvasRenderingEnabled() + default: defaultUseGPUProcessForDOMRenderingEnabled() -UseGPUProcessForMediaEnabled: - type: bool - humanReadableName: "GPU Process: Media" - humanReadableDescription: "Do all media loading and playback in the GPU Process" - webcoreBinding: none - condition: ENABLE(GPU_PROCESS) && !USE(GSTREAMER) - exposed: [ WebKit ] - defaultValue: -WebKit: - default: WebKit::defaultUseGPUProcessForMediaEnabled() - UseGPUProcessForWebGLEnabled: type: bool humanReadableName: "GPU Process: WebGL" @@ -1640,20 +1618,6 @@ WebCore: default: false -# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely. -WebRTCPlatformCodecsInGPUProcessEnabled: - type: bool - humanReadableName: "WebRTC Platform Codecs in GPU Process" - humanReadableDescription: "Enable WebRTC Platform Codecs in GPU Process" - condition: ENABLE(WEB_RTC) - defaultValue: -WebKitLegacy: - default: false -WebKit: - default: WebKit::defaultWebRTCCodecsInGPUProcess() -WebCore: - default: false - WebRTCPlatformTCPSocketsEnabled: type: bool humanReadableName: "WebRTC Platform TCP Sockets" Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (286553 => 286554) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-12-06 19:13:26 UTC (rev 286553) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-12-06 19:22:54 UTC (rev 286554) @@ -154,6 +154,17 @@ WebKit: default: WebKit::defaultCaptureAudioInUIProcessEnabled() +CaptureVideoInGPUProcessEnabled: + type: bool + humanReadableName: "GPU Process: Video Capture" + humanReadableDescription: "Enable video capture in GPU Process" + webcoreBinding:
[webkit-changes] [286553] trunk
Title: [286553] trunk
Revision 286553
Author commit-qu...@webkit.org
Date 2021-12-06 11:13:26 -0800 (Mon, 06 Dec 2021)
Log Message
Null check in shouldUseBreakElement
https://bugs.webkit.org/show_bug.cgi?id=229275
Patch by Rob Buis on 2021-12-06
Reviewed by Ryosuke Niwa.
Source/WebCore:
Need to null check node in shouldUseBreakElement.
Also bail out early in InsertLineBreakCommand::doApply
in case position is not editable.
Test: editing/execCommand/insert-line-break-crash.html
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::shouldUseBreakElement):
(WebCore::InsertLineBreakCommand::doApply):
LayoutTests:
* editing/execCommand/insert-line-break-crash-expected.txt: Added.
* editing/execCommand/insert-line-break-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/InsertLineBreakCommand.cpp
Added Paths
trunk/LayoutTests/editing/execCommand/insert-line-break-crash-expected.txt
trunk/LayoutTests/editing/execCommand/insert-line-break-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (286552 => 286553)
--- trunk/LayoutTests/ChangeLog 2021-12-06 19:00:25 UTC (rev 286552)
+++ trunk/LayoutTests/ChangeLog 2021-12-06 19:13:26 UTC (rev 286553)
@@ -1,3 +1,13 @@
+2021-12-06 Rob Buis
+
+Null check in shouldUseBreakElement
+https://bugs.webkit.org/show_bug.cgi?id=229275
+
+Reviewed by Ryosuke Niwa.
+
+* editing/execCommand/insert-line-break-crash-expected.txt: Added.
+* editing/execCommand/insert-line-break-crash.html: Added.
+
2021-12-06 Tadeu Zagallo
Restore navigator.hardwareConcurrency
Added: trunk/LayoutTests/editing/execCommand/insert-line-break-crash-expected.txt (0 => 286553)
--- trunk/LayoutTests/editing/execCommand/insert-line-break-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/execCommand/insert-line-break-crash-expected.txt 2021-12-06 19:13:26 UTC (rev 286553)
@@ -0,0 +1 @@
+Test passes if it does not crash.
Added: trunk/LayoutTests/editing/execCommand/insert-line-break-crash.html (0 => 286553)
--- trunk/LayoutTests/editing/execCommand/insert-line-break-crash.html (rev 0)
+++ trunk/LayoutTests/editing/execCommand/insert-line-break-crash.html 2021-12-06 19:13:26 UTC (rev 286553)
@@ -0,0 +1,22 @@
+
+ if (window.testRunner)
+window.testRunner.dumpAsText();
+ _onload_ = () => {
+document.designMode = 'on';
+document.execCommand('SelectAll');
+getSelection().modify('move', 'right', 'word');
+queueMicrotask(() => {
+ document.execCommand('Delete');
+ document.write("Test passes if it does not crash.");
+});
+document.execCommand('InsertLineBreak');
+ };
+
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (286552 => 286553)
--- trunk/Source/WebCore/ChangeLog 2021-12-06 19:00:25 UTC (rev 286552)
+++ trunk/Source/WebCore/ChangeLog 2021-12-06 19:13:26 UTC (rev 286553)
@@ -1,3 +1,20 @@
+2021-12-06 Rob Buis
+
+Null check in shouldUseBreakElement
+https://bugs.webkit.org/show_bug.cgi?id=229275
+
+Reviewed by Ryosuke Niwa.
+
+Need to null check node in shouldUseBreakElement.
+Also bail out early in InsertLineBreakCommand::doApply
+in case position is not editable.
+
+Test: editing/execCommand/insert-line-break-crash.html
+
+* editing/InsertLineBreakCommand.cpp:
+(WebCore::InsertLineBreakCommand::shouldUseBreakElement):
+(WebCore::InsertLineBreakCommand::doApply):
+
2021-12-06 Tadeu Zagallo
Restore navigator.hardwareConcurrency
Modified: trunk/Source/WebCore/editing/InsertLineBreakCommand.cpp (286552 => 286553)
--- trunk/Source/WebCore/editing/InsertLineBreakCommand.cpp 2021-12-06 19:00:25 UTC (rev 286552)
+++ trunk/Source/WebCore/editing/InsertLineBreakCommand.cpp 2021-12-06 19:13:26 UTC (rev 286553)
@@ -60,7 +60,7 @@
// the input element, and in that case we need to check the input element's
// parent's renderer.
auto* node = position.parentAnchoredEquivalent().deprecatedNode();
-return node->renderer() && !node->renderer()->style().preserveNewline();
+return node && node->renderer() && !node->renderer()->style().preserveNewline();
}
void InsertLineBreakCommand::doApply()
@@ -81,6 +81,9 @@
position = positionAvoidingSpecialElementBoundary(position);
position = positionOutsideTabSpan(position);
+if (!isEditablePosition(position))
+return;
+
RefPtr nodeToInsert;
if (shouldUseBreakElement(position))
nodeToInsert = HTMLBRElement::create(document());
@@ -91,7 +94,7 @@
if (isEndOfParagraph(caret) && !lineBreakExistsAtVisiblePosition(caret)) {
bool needExtraLineBreak = !is(*position.deprecatedNode()) && !is(*position.deprecatedNode());
-
+
insertNodeAt(*nodeToInsert, position);
if
[webkit-changes] [286552] trunk
Title: [286552] trunk
Revision 286552
Author commit-qu...@webkit.org
Date 2021-12-06 11:00:25 -0800 (Mon, 06 Dec 2021)
Log Message
[iOS] Allow WKWebView clients to override undoManager
https://bugs.webkit.org/show_bug.cgi?id=233297
Patch by Matt Gilligan on 2021-12-06
Reviewed by Wenson Hsieh.
Source/WebKit:
Move WKContentView's undoManager up the responder chain to WKWebView so web view
subclasses can customize the undo manager used when WKContentView is first responder.
Test: KeyboardInputTests.OverrideUndoManager
* UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView undoManager]):
Return the undo manager provided by _contentView when it is current.
* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView undoManagerForWebView]):
Provide the view's undo manager via this property so that -undoManager will look up the
responder chain to WKWebView.
(-[WKContentView undoManager]): Deleted.
Tools:
* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(-[CustomUndoManagerWebView undoManager]):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
trunk/Source/WebKit/UIProcess/ios/WKContentView.h
trunk/Source/WebKit/UIProcess/ios/WKContentView.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (286551 => 286552)
--- trunk/Source/WebKit/ChangeLog 2021-12-06 18:49:35 UTC (rev 286551)
+++ trunk/Source/WebKit/ChangeLog 2021-12-06 19:00:25 UTC (rev 286552)
@@ -1,3 +1,28 @@
+2021-12-06 Matt Gilligan
+
+[iOS] Allow WKWebView clients to override undoManager
+https://bugs.webkit.org/show_bug.cgi?id=233297
+
+
+Reviewed by Wenson Hsieh.
+
+Move WKContentView's undoManager up the responder chain to WKWebView so web view
+subclasses can customize the undo manager used when WKContentView is first responder.
+
+Test: KeyboardInputTests.OverrideUndoManager
+
+* UIProcess/API/ios/WKWebViewIOS.mm:
+(-[WKWebView undoManager]):
+Return the undo manager provided by _contentView when it is current.
+
+* UIProcess/ios/WKContentView.h:
+* UIProcess/ios/WKContentView.mm:
+(-[WKContentView undoManagerForWebView]):
+Provide the view's undo manager via this property so that -undoManager will look up the
+responder chain to WKWebView.
+
+(-[WKContentView undoManager]): Deleted.
+
2021-12-06 Lauro Moura
REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (286551 => 286552)
--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2021-12-06 18:49:35 UTC (rev 286551)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2021-12-06 19:00:25 UTC (rev 286552)
@@ -318,6 +318,14 @@
return [super resignFirstResponder];
}
+- (NSUndoManager *)undoManager
+{
+if (self._currentContentView == _contentView)
+return [_contentView undoManagerForWebView];
+
+return [super undoManager];
+}
+
FOR_EACH_WKCONTENTVIEW_ACTION(FORWARD_ACTION_TO_WKCONTENTVIEW)
- (BOOL)canPerformAction:(SEL)action withSender:(id)sender
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentView.h (286551 => 286552)
--- trunk/Source/WebKit/UIProcess/ios/WKContentView.h 2021-12-06 18:49:35 UTC (rev 286551)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentView.h 2021-12-06 19:00:25 UTC (rev 286552)
@@ -71,6 +71,7 @@
@property (nonatomic, readonly, getter=isResigningFirstResponder) BOOL resigningFirstResponder;
@property (nonatomic) BOOL sizeChangedSinceLastVisibleContentRectUpdate;
@property (nonatomic, readonly) UIInterfaceOrientation interfaceOrientation;
+@property (nonatomic, readonly) NSUndoManager *undoManagerForWebView;
- (instancetype)initWithFrame:(CGRect)frame processPool:(NakedRef)processPool configuration:(Ref&&)configuration webView:(WKWebView *)webView;
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentView.mm (286551 => 286552)
--- trunk/Source/WebKit/UIProcess/ios/WKContentView.mm 2021-12-06 18:49:35 UTC (rev 286551)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentView.mm 2021-12-06 19:00:25 UTC (rev 286552)
@@ -562,7 +562,7 @@
[self _didEndScrollingOrZooming];
}
-- (NSUndoManager *)undoManager
+- (NSUndoManager *)undoManagerForWebView
{
if (self.focusedElementInformation.shouldSynthesizeKeyEventsForEditing && self.hasHiddenContentEditable) {
if (!_quirkyUndoManager)
Modified: trunk/Tools/ChangeLog (286551 => 286552)
--- trunk/Tools/ChangeLog 2021-12-06 18:49:35 UTC (rev 286551)
+++ trunk/Tools/ChangeLog 2021-12-06 19:00:25 UTC (rev 286552)
@@ -1,3 +1,15 @@
+2021-12-06 Matt Gilligan
+
+[iOS] Allow WKWebView clients to override undoManager
+https://bugs.webkit.org/show_bug.cgi?id=233297
+
+
+Reviewed by Wenson Hsieh.
+
+*
[webkit-changes] [286551] tags/Safari-613.1.10.1/
Title: [286551] tags/Safari-613.1.10.1/ Revision 286551 Author repst...@apple.com Date 2021-12-06 10:49:35 -0800 (Mon, 06 Dec 2021) Log Message Tag Safari-613.1.10.1. Added Paths tags/Safari-613.1.10.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286550] trunk
Title: [286550] trunk Revision 286550 Author tzaga...@apple.com Date 2021-12-06 10:46:03 -0800 (Mon, 06 Dec 2021) Log Message Restore navigator.hardwareConcurrency https://bugs.webkit.org/show_bug.cgi?id=233381 Reviewed by Saam Barati. LayoutTests/imported/w3c: * web-platform-tests/html/dom/idlharness.https-expected.txt: * web-platform-tests/html/dom/idlharness.worker-expected.txt: * web-platform-tests/workers/WorkerNavigator-hardware-concurrency.any.worker-expected.txt: Source/WebCore: Navigator.hardwareConcurrency was removed in r219379, but it is now used by emscripten to implement std::thread::hardware_concurrency() Test: fast/dom/navigator-hardwareConcurrency.html * page/Navigator.idl: * page/NavigatorBase.cpp: (WebCore::NavigatorBase::hardwareConcurrency): * page/NavigatorBase.h: * page/WorkerNavigator.idl: LayoutTests: * fast/dom/Window/resources/window-property-collector.js: (emitExpectedResult): * fast/dom/navigator-detached-no-crash-expected.txt: * fast/dom/navigator-hardwareConcurrency-expected.txt: Added. * fast/dom/navigator-hardwareConcurrency.html: Added. * fast/workers/resources/worker-navigator.js: * fast/workers/worker-navigator-expected.txt: * platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: * platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt: * platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt: * platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: * platform/win/fast/dom/navigator-detached-no-crash-expected.txt: * platform/wincairo/fast/dom/navigator-detached-no-crash-expected.txt: * platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/resources/window-property-collector.js trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/fast/workers/resources/worker-navigator.js trunk/LayoutTests/fast/workers/worker-navigator-expected.txt trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/WorkerNavigator-hardware-concurrency.any.worker-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt trunk/LayoutTests/platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt trunk/LayoutTests/platform/mac/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt trunk/LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt trunk/LayoutTests/platform/win/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/wincairo/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Navigator.idl trunk/Source/WebCore/page/NavigatorBase.cpp trunk/Source/WebCore/page/NavigatorBase.h trunk/Source/WebCore/page/WorkerNavigator.idl Added Paths trunk/LayoutTests/fast/dom/navigator-hardwareConcurrency-expected.txt trunk/LayoutTests/fast/dom/navigator-hardwareConcurrency.html Diff Modified: trunk/LayoutTests/ChangeLog (286549 => 286550) --- trunk/LayoutTests/ChangeLog 2021-12-06 18:40:13 UTC (rev 286549) +++ trunk/LayoutTests/ChangeLog 2021-12-06 18:46:03 UTC (rev 286550) @@ -1,3 +1,33 @@ +2021-12-06 Tadeu Zagallo + +Restore navigator.hardwareConcurrency +https://bugs.webkit.org/show_bug.cgi?id=233381 + + +Reviewed by Saam
[webkit-changes] [286549] trunk/Source/WebKit
Title: [286549] trunk/Source/WebKit
Revision 286549
Author lmo...@igalia.com
Date 2021-12-06 10:40:13 -0800 (Mon, 06 Dec 2021)
Log Message
REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
https://bugs.webkit.org/show_bug.cgi?id=233881
Reviewed by Žan Doberšek.
Build fix. Covered by exiting tests.
* PlatformGTK.cmake: Add symbolic links for the public generated like
we do for the regular headers. It happened to work before because they
were created already in a webkit2 folder.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
Diff
Modified: trunk/Source/WebKit/ChangeLog (286548 => 286549)
--- trunk/Source/WebKit/ChangeLog 2021-12-06 18:35:05 UTC (rev 286548)
+++ trunk/Source/WebKit/ChangeLog 2021-12-06 18:40:13 UTC (rev 286549)
@@ -1,3 +1,16 @@
+2021-12-06 Lauro Moura
+
+REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
+https://bugs.webkit.org/show_bug.cgi?id=233881
+
+Reviewed by Žan Doberšek.
+
+Build fix. Covered by exiting tests.
+
+* PlatformGTK.cmake: Add symbolic links for the public generated like
+we do for the regular headers. It happened to work before because they
+were created already in a webkit2 folder.
+
2021-12-06 Alex Christensen
WKWebpagePreferences._activeContentRuleListActionPatterns should be an NSDictionary of identifier to allowed patterns
Modified: trunk/Source/WebKit/PlatformGTK.cmake (286548 => 286549)
--- trunk/Source/WebKit/PlatformGTK.cmake 2021-12-06 18:35:05 UTC (rev 286548)
+++ trunk/Source/WebKit/PlatformGTK.cmake 2021-12-06 18:40:13 UTC (rev 286549)
@@ -875,6 +875,21 @@
COMMAND ln -n -s -f ${WEBKIT_DIR}/UIProcess/API/gtk ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2
)
add_custom_command(
+OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
+DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitEnumTypes.h
+COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitEnumTypes.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
+)
+add_custom_command(
+OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
+DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitWebProcessEnumTypes.h
+COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitWebProcessEnumTypes.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
+)
+add_custom_command(
+OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
+DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitVersion.h
+COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitVersion.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
+)
+add_custom_command(
OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
DEPENDS ${WEBKIT_DIR}/UIProcess/API/gtk${GTK_API_VERSION}
COMMAND ln -n -s -f ${WEBKIT_DIR}/UIProcess/API/gtk${GTK_API_VERSION} ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
@@ -891,6 +906,9 @@
)
add_custom_target(WebKit-fake-api-headers
DEPENDS ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2
+${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
+${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
+${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-webextension/webkit2
${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-webextension/webkitdom
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286548] branches/safari-613.1.10-branch/Source
Title: [286548] branches/safari-613.1.10-branch/Source Revision 286548 Author repst...@apple.com Date 2021-12-06 10:35:05 -0800 (Mon, 06 Dec 2021) Log Message Versioning. WebKit-7613.1.10.1 Modified Paths branches/safari-613.1.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.10-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig (286547 => 286548) --- branches/safari-613.1.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-12-06 18:27:41 UTC (rev 286547) +++ branches/safari-613.1.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-12-06 18:35:05 UTC (rev 286548) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.1.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (286547 => 286548) --- branches/safari-613.1.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-12-06 18:27:41 UTC (rev 286547) +++ branches/safari-613.1.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-12-06 18:35:05 UTC (rev 286548) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.1.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (286547 => 286548) --- branches/safari-613.1.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-12-06 18:27:41 UTC (rev 286547) +++ branches/safari-613.1.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-12-06 18:35:05 UTC (rev 286548) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.1.10-branch/Source/WebCore/Configurations/Version.xcconfig (286547 => 286548) --- branches/safari-613.1.10-branch/Source/WebCore/Configurations/Version.xcconfig 2021-12-06 18:27:41 UTC (rev 286547) +++ branches/safari-613.1.10-branch/Source/WebCore/Configurations/Version.xcconfig 2021-12-06 18:35:05 UTC (rev 286548) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.1.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (286547 => 286548) --- branches/safari-613.1.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-12-06 18:27:41 UTC (rev 286547) +++ branches/safari-613.1.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-12-06 18:35:05 UTC (rev 286548) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version
[webkit-changes] [286547] trunk/Tools
Title: [286547] trunk/Tools
Revision 286547
Author wenson_hs...@apple.com
Date 2021-12-06 10:27:41 -0800 (Mon, 06 Dec 2021)
Log Message
[iOS] AppHighlights.AppHighlightCreateAndRestoreAndScroll is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=233828
Reviewed by Tim Horton.
This test began to sometimes fail on iOS 15 API test runners in EWS after enabling `APP_HIGHLIGHTS` in non-
internal builds. Make this test more robust by waiting for scrolling to the restored highlight.
* TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm
Diff
Modified: trunk/Tools/ChangeLog (286546 => 286547)
--- trunk/Tools/ChangeLog 2021-12-06 18:20:43 UTC (rev 286546)
+++ trunk/Tools/ChangeLog 2021-12-06 18:27:41 UTC (rev 286547)
@@ -1,3 +1,16 @@
+2021-12-06 Wenson Hsieh
+
+[iOS] AppHighlights.AppHighlightCreateAndRestoreAndScroll is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=233828
+
+Reviewed by Tim Horton.
+
+This test began to sometimes fail on iOS 15 API test runners in EWS after enabling `APP_HIGHLIGHTS` in non-
+internal builds. Make this test more robust by waiting for scrolling to the restored highlight.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm:
+(TestWebKitAPI::TEST):
+
2021-12-06 Alex Christensen
WKWebpagePreferences._activeContentRuleListActionPatterns should be an NSDictionary of identifier to allowed patterns
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm (286546 => 286547)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm 2021-12-06 18:20:43 UTC (rev 286546)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm 2021-12-06 18:27:41 UTC (rev 286547)
@@ -108,9 +108,9 @@
[webViewRestore _restoreAndScrollToAppHighlight:[highlight highlight]];
TestWebKitAPI::Util::waitForConditionWithLogging([&] () -> bool {
-return [webViewRestore stringByEvaluatingJavaScript:@"internals.numberOfAppHighlights()"].intValue == 1;
-}, 2, @"Expected Highlights to be populated.");
-EXPECT_NE(0, [[webViewRestore objectByEvaluatingJavaScript:@"pageYOffset"] floatValue]);
+return [webViewRestore stringByEvaluatingJavaScript:@"internals.numberOfAppHighlights()"].intValue == 1
+&& [[webViewRestore objectByEvaluatingJavaScript:@"pageYOffset"] floatValue] > 0;
+}, 2, @"Expected Highlights to be populated and the page to scroll.");
}
TEST(AppHighlights, AppHighlightRestoreFailure)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286546] trunk
Title: [286546] trunk Revision 286546 Author s...@apple.com Date 2021-12-06 10:20:43 -0800 (Mon, 06 Dec 2021) Log Message [GPU Process] (REGRESSION r285597): Set the filterRegion of the CSSFilter after it is created https://bugs.webkit.org/show_bug.cgi?id=233849 Reviewed by Cameron McCormack. Source/WebCore: In this patch: 1. sourceImageRect is no longer passed as an argument to SVGFilter. It should be passed only when SVGFilter::apply() is called. 2. CSSFilter::create() will create and build the FilterFunctions from the FilterOperations. So we have to pass the targetBoundingBox since the FilterEffects will need it when calculating the outsets. 3. The steps in RenderLayerFilters::beginFilterEffect() are: a) Recreate the CSSFilter if the targetBoundingBox changes. b) Calculate the filterRegion = targetBoundingBox + outsets c) Clamp the filterRegion if needed. This will change the filterScale. d) Set sourceImageRect = filterRegion. e) Recreate the sourceImage if needed. f) setup the context for drawing the target renderer. 4. Managing the targetBoundingBox and the filterRegion is moved from CSSFilter to RenderLayerFilters. * css/CSSFilterImageValue.cpp: (WebCore::CSSFilterImageValue::image): * platform/graphics/filters/Filter.cpp: (WebCore::Filter::Filter): * platform/graphics/filters/Filter.h: (WebCore::Filter::Filter): * rendering/CSSFilter.cpp: (WebCore::CSSFilter::create): (WebCore::CSSFilter::CSSFilter): (WebCore::createSVGFilter): (WebCore::CSSFilter::buildFilterFunctions): (WebCore::CSSFilter::apply): (WebCore::CSSFilter::setFilterRegion): (WebCore::m_hasFilterThatShouldBeRestrictedBySecurityOrigin): Deleted. (WebCore::CSSFilter::updateBackingStoreRect): Deleted. (WebCore::CSSFilter::computeSourceImageRectForDirtyRect): Deleted. (WebCore::CSSFilter::setSourceImageRect): Deleted. * rendering/CSSFilter.h: * rendering/RenderLayerFilters.cpp: (WebCore::RenderLayerFilters::buildFilter): (WebCore::RenderLayerFilters::allocateBackingStoreIfNeeded): (WebCore::RenderLayerFilters::beginFilterEffect): (WebCore::RenderLayerFilters::applyFilterEffect): (WebCore::RenderLayerFilters::allocateBackingStore): Deleted. * rendering/RenderLayerFilters.h: * rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): * rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): * svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::create): (WebCore::SVGFilter::SVGFilter): * svg/graphics/filters/SVGFilter.h: LayoutTests: Unskip layout tests which were skipped in r285597. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSFilterImageValue.cpp trunk/Source/WebCore/platform/graphics/filters/Filter.cpp trunk/Source/WebCore/platform/graphics/filters/Filter.h trunk/Source/WebCore/rendering/CSSFilter.cpp trunk/Source/WebCore/rendering/CSSFilter.h trunk/Source/WebCore/rendering/RenderLayerFilters.cpp trunk/Source/WebCore/rendering/RenderLayerFilters.h trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp trunk/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilter.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilter.h Diff Modified: trunk/LayoutTests/ChangeLog (286545 => 286546) --- trunk/LayoutTests/ChangeLog 2021-12-06 17:46:01 UTC (rev 286545) +++ trunk/LayoutTests/ChangeLog 2021-12-06 18:20:43 UTC (rev 286546) @@ -1,3 +1,14 @@ +2021-12-06 Said Abou-Hallawa + +[GPU Process] (REGRESSION r285597): Set the filterRegion of the CSSFilter after it is created +https://bugs.webkit.org/show_bug.cgi?id=233849 + +Reviewed by Cameron McCormack. + +Unskip layout tests which were skipped in r285597. + +* TestExpectations: + 2021-12-04 Antoine Quint CSS animation sorting may crash due to AnimationList copy upon CSS Animation removal Modified: trunk/LayoutTests/TestExpectations (286545 => 286546) --- trunk/LayoutTests/TestExpectations 2021-12-06 17:46:01 UTC (rev 286545) +++ trunk/LayoutTests/TestExpectations 2021-12-06 18:20:43 UTC (rev 286546) @@ -5163,19 +5163,3 @@ imported/blink/plugins [ Skip ] js/dom/reflect-set-onto-dom.html [ Skip ] userscripts/user-script-plugin-document.html [ Skip ] - -# These filter related failures should be fixed once webkit.org/b/232705 is resolved -webkit.org/b/232705 compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html [ Skip ] -webkit.org/b/232705 compositing/filters/sw-shadow-overlaps-hw-layer.html [ Skip ] -webkit.org/b/232705 compositing/filters/sw-shadow-overlaps-hw-shadow.html [ Skip ] -webkit.org/b/232705 css3/filters/effect-reference-delete.html [ Skip ] -webkit.org/b/232705 css3/filters/svg-blur-filter-clipped.html [ Skip ] -webkit.org/b/232705 fast/filter-image/background-filter-image.html [ Skip ] -webkit.org/b/232705
[webkit-changes] [286545] trunk
Title: [286545] trunk
Revision 286545
Author commit-qu...@webkit.org
Date 2021-12-06 09:46:01 -0800 (Mon, 06 Dec 2021)
Log Message
WKWebpagePreferences._activeContentRuleListActionPatterns should be an NSDictionary of identifier to allowed patterns
https://bugs.webkit.org/show_bug.cgi?id=233842
Patch by Alex Christensen on 2021-12-06
Reviewed by Timothy Hatcher.
Source/WebCore:
There's no need for nil to match everything because a pattern can be written to quickly match everything.
There is a need for different extensions (with different identifiers) to have different active action permissions, though.
* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::setActiveContentRuleListActionPatterns):
(WebCore::DocumentLoader::allowsActiveContentRuleListActionsForURL const):
* loader/DocumentLoader.h:
Source/WebKit:
* Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::decode):
* Shared/WebsitePoliciesData.h:
* UIProcess/API/APIWebsitePolicies.h:
* UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _setActiveContentRuleListActionPatterns:]):
(-[WKWebpagePreferences _activeContentRuleListActionPatterns]):
* UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
(navigationDelegateAllowingActiveActionsOnTestHost):
(TEST_F):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentLoader.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebsitePoliciesData.cpp
trunk/Source/WebKit/Shared/WebsitePoliciesData.h
trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (286544 => 286545)
--- trunk/Source/WebCore/ChangeLog 2021-12-06 17:20:08 UTC (rev 286544)
+++ trunk/Source/WebCore/ChangeLog 2021-12-06 17:46:01 UTC (rev 286545)
@@ -1,3 +1,21 @@
+2021-12-06 Alex Christensen
+
+WKWebpagePreferences._activeContentRuleListActionPatterns should be an NSDictionary of identifier to allowed patterns
+https://bugs.webkit.org/show_bug.cgi?id=233842
+
+Reviewed by Timothy Hatcher.
+
+There's no need for nil to match everything because a pattern can be written to quickly match everything.
+There is a need for different extensions (with different identifiers) to have different active action permissions, though.
+
+* contentextensions/ContentExtensionsBackend.cpp:
+(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::DocumentLoader):
+(WebCore::DocumentLoader::setActiveContentRuleListActionPatterns):
+(WebCore::DocumentLoader::allowsActiveContentRuleListActionsForURL const):
+* loader/DocumentLoader.h:
+
2021-12-06 Antoine Quint
Clean up virtual methods on AnimationEffect
Modified: trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.cpp (286544 => 286545)
--- trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.cpp 2021-12-06 17:20:08 UTC (rev 286544)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.cpp 2021-12-06 17:46:01 UTC (rev 286545)
@@ -228,11 +228,11 @@
}, [&](const IgnorePreviousRulesAction&) {
RELEASE_ASSERT_NOT_REACHED();
}, [&] (const ModifyHeadersAction& action) {
-if (initiatingDocumentLoader.allowsActiveContentRuleListActionsForURL(url))
+if (initiatingDocumentLoader.allowsActiveContentRuleListActionsForURL(contentRuleListIdentifier, url))
results.summary.modifyHeadersActions.append(action);
}, [&] (const RedirectAction& redirectAction) {
-if (initiatingDocumentLoader.allowsActiveContentRuleListActionsForURL(url))
-results.summary.redirectActions.append({ redirectAction, m_contentExtensions.get(actionsFromContentRuleList.contentRuleListIdentifier)->extensionBaseURL() });
+if (initiatingDocumentLoader.allowsActiveContentRuleListActionsForURL(contentRuleListIdentifier, url))
+results.summary.redirectActions.append({ redirectAction, m_contentExtensions.get(contentRuleListIdentifier)->extensionBaseURL() });
}), action.data());
}
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (286544 => 286545)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp
[webkit-changes] [286544] trunk/Source/WebCore
Title: [286544] trunk/Source/WebCore Revision 286544 Author grao...@webkit.org Date 2021-12-06 09:20:08 -0800 (Mon, 06 Dec 2021) Log Message Clean up virtual methods on AnimationEffect https://bugs.webkit.org/show_bug.cgi?id=233868 Reviewed by Simon Fraser. To this day, the only concrete subclass of AnimationEffect has been KeyframeEffect. Soon, we'll introduce another concrete subclass for callback-based animations leveraging the Web Animations mode: CustomEffect. To prepare for this new class, we clean up the virtual methods on AnimationEffect such that they make a bit more sense: - much of the implementation of timeToNextTick() is brought from KeyframeEffect to AnimationEffect to account for the cases which are purely based on timing properties shared by any potential AnimationEffect subclass, - we add a new ticksContinouslyWhileActive() method which allows subclasses to indicate whether they require continuous scheduling while active, which is true for KeyframeEffect unless it has no keyframes, no CSS properties set on its keyframes or is running fully accelerated, - much of the implementation of setAnimation() is brought from KeyframeEffect to AnimationEffect since updating the relevance of the animation based on a change of effect should apply to any AnimationEffect, - the apply() and invalidate() methods are moved from AnimationEffect to KeyframeEffect alone since they really are specific to KeyframeEffect's interaction with style resolution, - all the other virtual methods on AnimationEffect have stub implementations such that new subclasses only need to override them as required: animationDidTick(), animationDidPlay(), animationDidChangeTimingProperties(), animationWasCanceled(), animationSuspensionStateDidChange(bool) and animationTimelineDidChange(AnimationTimeline*). * animation/AnimationEffect.cpp: (WebCore::AnimationEffect::setAnimation): (WebCore::AnimationEffect::timeToNextTick const): * animation/AnimationEffect.h: (WebCore::AnimationEffect::animationDidTick): (WebCore::AnimationEffect::animationDidPlay): (WebCore::AnimationEffect::animationDidChangeTimingProperties): (WebCore::AnimationEffect::animationWasCanceled): (WebCore::AnimationEffect::animationSuspensionStateDidChange): (WebCore::AnimationEffect::animationTimelineDidChange): (WebCore::AnimationEffect::ticksContinouslyWhileActive const): (WebCore::AnimationEffect::setAnimation): Deleted. (WebCore::AnimationEffect::timeToNextTick const): Deleted. * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::setAnimation): (WebCore::KeyframeEffect::ticksContinouslyWhileActive const): (WebCore::KeyframeEffect::timeToNextTick const): * animation/KeyframeEffect.h: * animation/WebAnimation.cpp: (WebCore::WebAnimation::invalidateEffect): (WebCore::WebAnimation::resolve): (WebCore::WebAnimation::timeToNextTick const): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/AnimationEffect.cpp trunk/Source/WebCore/animation/AnimationEffect.h trunk/Source/WebCore/animation/KeyframeEffect.cpp trunk/Source/WebCore/animation/KeyframeEffect.h trunk/Source/WebCore/animation/WebAnimation.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (286543 => 286544) --- trunk/Source/WebCore/ChangeLog 2021-12-06 14:35:01 UTC (rev 286543) +++ trunk/Source/WebCore/ChangeLog 2021-12-06 17:20:08 UTC (rev 286544) @@ -1,3 +1,57 @@ +2021-12-06 Antoine Quint + +Clean up virtual methods on AnimationEffect +https://bugs.webkit.org/show_bug.cgi?id=233868 + +Reviewed by Simon Fraser. + +To this day, the only concrete subclass of AnimationEffect has been KeyframeEffect. Soon, we'll introduce +another concrete subclass for callback-based animations leveraging the Web Animations mode: CustomEffect. +To prepare for this new class, we clean up the virtual methods on AnimationEffect such that they make a +bit more sense: + +- much of the implementation of timeToNextTick() is brought from KeyframeEffect to AnimationEffect to +account for the cases which are purely based on timing properties shared by any potential AnimationEffect +subclass, + +- we add a new ticksContinouslyWhileActive() method which allows subclasses to indicate whether they require +continuous scheduling while active, which is true for KeyframeEffect unless it has no keyframes, no CSS +properties set on its keyframes or is running fully accelerated, + +- much of the implementation of setAnimation() is brought from KeyframeEffect to AnimationEffect since +updating the relevance of the animation based on a change of effect should apply to any AnimationEffect, + +- the apply() and invalidate() methods are moved from AnimationEffect to KeyframeEffect alone since they +really are specific to KeyframeEffect's interaction with style resolution, + +- all the other virtual methods on AnimationEffect have stub implementations such
[webkit-changes] [286543] trunk/Source
Title: [286543] trunk/Source
Revision 286543
Author zimmerm...@webkit.org
Date 2021-12-06 06:35:01 -0800 (Mon, 06 Dec 2021)
Log Message
[LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effect
https://bugs.webkit.org/show_bug.cgi?id=233871
Reviewed by Rob Buis.
Toggling "Enable layer-based SVG engine" in e.g. MiniBrowser or from JS has no immediate effect.
A relayout is not enough: a full style / render tree rebuild is needed.
Source/WebCore:
Covered by existing tests.
* page/SettingsBase.cpp:
(WebCore::SettingsBase::layerBasedSVGEngineEnabledChanged): Rebuild style / renderers upon changes.
* page/SettingsBase.h:
Source/WTF:
* Scripts/Preferences/WebPreferencesInternal.yaml: When "LayerBasedSVGEngineEnabled" changes call
WebCore::SettingsBase::layerBasedSVGEngineEnabledChanged() to assure the switch from legacy to
LBSE engine and vice-versa is live and doesn't need reloads to take effect.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/SettingsBase.cpp
trunk/Source/WebCore/page/SettingsBase.h
Diff
Modified: trunk/Source/WTF/ChangeLog (286542 => 286543)
--- trunk/Source/WTF/ChangeLog 2021-12-06 14:28:26 UTC (rev 286542)
+++ trunk/Source/WTF/ChangeLog 2021-12-06 14:35:01 UTC (rev 286543)
@@ -1,3 +1,17 @@
+2021-12-06 Nikolas Zimmermann
+
+[LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effect
+https://bugs.webkit.org/show_bug.cgi?id=233871
+
+Reviewed by Rob Buis.
+
+Toggling "Enable layer-based SVG engine" in e.g. MiniBrowser or from JS has no immediate effect.
+A relayout is not enough: a full style / render tree rebuild is needed.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml: When "LayerBasedSVGEngineEnabled" changes call
+WebCore::SettingsBase::layerBasedSVGEngineEnabledChanged() to assure the switch from legacy to
+LBSE engine and vice-versa is live and doesn't need reloads to take effect.
+
2021-12-06 Youenn Fablet
Enable NavigationPreloadManager by default
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (286542 => 286543)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-12-06 14:28:26 UTC (rev 286542)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-12-06 14:35:01 UTC (rev 286543)
@@ -450,7 +450,7 @@
humanReadableName: "Layer-based SVG Engine (LBSE)"
humanReadableDescription: "Enable next-generation layer-based SVG Engine (LBSE)"
condition: ENABLE(LAYER_BASED_SVG_ENGINE)
- webcoreOnChange: setNeedsRelayoutAllFrames
+ webcoreOnChange: layerBasedSVGEngineEnabledChanged
defaultValue:
WebCore:
default: false
Modified: trunk/Source/WebCore/ChangeLog (286542 => 286543)
--- trunk/Source/WebCore/ChangeLog 2021-12-06 14:28:26 UTC (rev 286542)
+++ trunk/Source/WebCore/ChangeLog 2021-12-06 14:35:01 UTC (rev 286543)
@@ -1,5 +1,21 @@
2021-12-06 Nikolas Zimmermann
+[LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effect
+https://bugs.webkit.org/show_bug.cgi?id=233871
+
+Reviewed by Rob Buis.
+
+Toggling "Enable layer-based SVG engine" in e.g. MiniBrowser or from JS has no immediate effect.
+A relayout is not enough: a full style / render tree rebuild is needed.
+
+Covered by existing tests.
+
+* page/SettingsBase.cpp:
+(WebCore::SettingsBase::layerBasedSVGEngineEnabledChanged): Rebuild style / renderers upon changes.
+* page/SettingsBase.h:
+
+2021-12-06 Nikolas Zimmermann
+
[LBSE] Add RenderObject::isSVGRootOrLegacySVGRoot() helper
https://bugs.webkit.org/show_bug.cgi?id=233870
Modified: trunk/Source/WebCore/page/SettingsBase.cpp (286542 => 286543)
--- trunk/Source/WebCore/page/SettingsBase.cpp 2021-12-06 14:28:26 UTC (rev 286542)
+++ trunk/Source/WebCore/page/SettingsBase.cpp 2021-12-06 14:35:01 UTC (rev 286543)
@@ -308,6 +308,29 @@
#endif
+#if ENABLE(LAYER_BASED_SVG_ENGINE)
+
+void SettingsBase::layerBasedSVGEngineEnabledChanged()
+{
+if (!m_page)
+return;
+
+for (auto* frame = _page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+auto* document = frame->document();
+if (!document)
+continue;
+
+auto* documentElement = document->documentElement();
+if (!documentElement)
+continue;
+
+documentElement->invalidateStyleAndRenderersForSubtree();
+document->scheduleFullStyleRebuild();
+}
+}
+
+#endif
+
void SettingsBase::userStyleSheetLocationChanged()
{
if (m_page)
Modified: trunk/Source/WebCore/page/SettingsBase.h (286542 => 286543)
--- trunk/Source/WebCore/page/SettingsBase.h 2021-12-06 14:28:26 UTC (rev 286542)
+++ trunk/Source/WebCore/page/SettingsBase.h 2021-12-06 14:35:01 UTC (rev 286543)
@@ -139,6
[webkit-changes] [286542] trunk/Source/WebCore
Title: [286542] trunk/Source/WebCore Revision 286542 Author zimmerm...@webkit.org Date 2021-12-06 06:28:26 -0800 (Mon, 06 Dec 2021) Log Message [LBSE] Add RenderObject::isSVGRootOrLegacySVGRoot() helper https://bugs.webkit.org/show_bug.cgi?id=233870 Reviewed by Rob Buis. Preparations to begin a new RenderSVGRoot implementation for the layer-based SVG engine (LBSE). Add a helper function to identify either legacy SVG or LBSE root render objects (LegacyRenderSVGRoot and the upcoming RenderSVGRoot). Covered by existing tests, no change in behavior. * accessibility/AXObjectCache.cpp: (WebCore::createFromRenderer): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::boundingBoxRect const): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): * dom/Element.cpp: (WebCore::Element::boundingAbsoluteRectWithoutLayout): * inspector/InspectorOverlay.cpp: (WebCore::buildRendererHighlight): * layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForChild): * rendering/RenderGeometryMap.cpp: (WebCore::canMapBetweenRenderersViaLayers): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::calculateClipRects const): * rendering/RenderLayer.h: (WebCore::RenderLayer::canUseOffsetFromAncestor const): * rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): * rendering/RenderObject.h: (WebCore::RenderObject::isLegacySVGRoot const): (WebCore::RenderObject::isSVGRootOrLegacySVGRoot const): * rendering/RenderReplaced.cpp: (WebCore::hasIntrinsicSize): * rendering/RenderView.cpp: (WebCore::RenderView::layout): * rendering/svg/LegacyRenderSVGRoot.h: * rendering/svg/SVGRenderSupport.cpp: (WebCore::layoutSizeOfNearestViewportChanged): * rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::prepareToRenderSVGContent): (WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem): * rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::reportVisuallyNonEmptyContent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/inspector/InspectorOverlay.cpp trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp trunk/Source/WebCore/rendering/RenderGeometryMap.cpp trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderReplaced.cpp trunk/Source/WebCore/rendering/RenderView.cpp trunk/Source/WebCore/rendering/svg/LegacyRenderSVGRoot.h trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (286541 => 286542) --- trunk/Source/WebCore/ChangeLog 2021-12-06 08:13:26 UTC (rev 286541) +++ trunk/Source/WebCore/ChangeLog 2021-12-06 14:28:26 UTC (rev 286542) @@ -1,3 +1,54 @@ +2021-12-06 Nikolas Zimmermann + +[LBSE] Add RenderObject::isSVGRootOrLegacySVGRoot() helper +https://bugs.webkit.org/show_bug.cgi?id=233870 + +Reviewed by Rob Buis. + +Preparations to begin a new RenderSVGRoot implementation for the +layer-based SVG engine (LBSE). + +Add a helper function to identify either legacy SVG or LBSE root +render objects (LegacyRenderSVGRoot and the upcoming RenderSVGRoot). + +Covered by existing tests, no change in behavior. + +* accessibility/AXObjectCache.cpp: +(WebCore::createFromRenderer): +* accessibility/AccessibilityRenderObject.cpp: +(WebCore::AccessibilityRenderObject::boundingBoxRect const): +(WebCore::AccessibilityRenderObject::determineAccessibilityRole): +* dom/Element.cpp: +(WebCore::Element::boundingAbsoluteRectWithoutLayout): +* inspector/InspectorOverlay.cpp: +(WebCore::buildRendererHighlight): +* layout/integration/LayoutIntegrationCoverage.cpp: +(WebCore::LayoutIntegration::canUseForChild): +* rendering/RenderGeometryMap.cpp: +(WebCore::canMapBetweenRenderersViaLayers): +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::beginTransparencyLayers): +(WebCore::RenderLayer::calculateClipRects const): +* rendering/RenderLayer.h: +(WebCore::RenderLayer::canUseOffsetFromAncestor const): +* rendering/RenderObject.cpp: +(WebCore::objectIsRelayoutBoundary): +* rendering/RenderObject.h: +(WebCore::RenderObject::isLegacySVGRoot const): +(WebCore::RenderObject::isSVGRootOrLegacySVGRoot const): +* rendering/RenderReplaced.cpp: +(WebCore::hasIntrinsicSize): +*
[webkit-changes] [286541] trunk/Source/WebCore
Title: [286541] trunk/Source/WebCore Revision 286541 Author an...@apple.com Date 2021-12-06 00:13:26 -0800 (Mon, 06 Dec 2021) Log Message [LFC][Integration] Use end bits in text box iterator https://bugs.webkit.org/show_bug.cgi?id=233858 Reviewed by Alan Bujtas. Make text box traversal work correctly in bidi context where encountering a different layout box does not necessarily mean there are no further text boxes for the layout box. * layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::computeIsFirstIsLastBoxForInlineContent): Set the bits for all box types. * layout/formattingContexts/inline/display/InlineDisplayBox.h: (WebCore::InlineDisplay::Box::Box): (WebCore::InlineDisplay::Box::isTextOrSoftLineBreak const): (WebCore::InlineDisplay::Box::isFirstForLayoutBox const): (WebCore::InlineDisplay::Box::isLastForLayoutBox const): (WebCore::InlineDisplay::Box::setIsFirstForLayoutBox): (WebCore::InlineDisplay::Box::setIsLastForLayoutBox): (WebCore::InlineDisplay::Box::isFirstBox const): Deleted. (WebCore::InlineDisplay::Box::isLastBox const): Deleted. (WebCore::InlineDisplay::Box::setIsLastBox): Deleted. (WebCore::InlineDisplay::Box::setIsFirstBox): Deleted. Renamed for clarity and correctness. * layout/integration/InlineIteratorBoxModernPath.h: (WebCore::InlineIterator::BoxModernPath::isText const): (WebCore::InlineIterator::BoxModernPath::traverseNextTextBox): Use the isLastForLayoutBox bit to end the traversal. (WebCore::InlineIterator::BoxModernPath::traverseNextInlineBox): (WebCore::InlineIterator::BoxModernPath::traversePreviousInlineBox): (WebCore::InlineIterator::BoxModernPath::traverseNextWithSameLayoutBox): (WebCore::InlineIterator::BoxModernPath::traversePreviousWithSameLayoutBox): Factor into helpers. * layout/integration/InlineIteratorTextBox.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h trunk/Source/WebCore/layout/integration/InlineIteratorBoxModernPath.h trunk/Source/WebCore/layout/integration/InlineIteratorTextBox.h trunk/Source/WebCore/layout/integration/LayoutIntegrationPagination.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (286540 => 286541) --- trunk/Source/WebCore/ChangeLog 2021-12-06 08:13:05 UTC (rev 286540) +++ trunk/Source/WebCore/ChangeLog 2021-12-06 08:13:26 UTC (rev 286541) @@ -1,3 +1,48 @@ +2021-12-06 Antti Koivisto + +[LFC][Integration] Use end bits in text box iterator +https://bugs.webkit.org/show_bug.cgi?id=233858 + +Reviewed by Alan Bujtas. + +Make text box traversal work correctly in bidi context where encountering a different +layout box does not necessarily mean there are no further text boxes for the layout box. + +* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp: +(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): +(WebCore::Layout::InlineDisplayContentBuilder::computeIsFirstIsLastBoxForInlineContent): + +Set the bits for all box types. + +* layout/formattingContexts/inline/display/InlineDisplayBox.h: +(WebCore::InlineDisplay::Box::Box): +(WebCore::InlineDisplay::Box::isTextOrSoftLineBreak const): +(WebCore::InlineDisplay::Box::isFirstForLayoutBox const): +(WebCore::InlineDisplay::Box::isLastForLayoutBox const): +(WebCore::InlineDisplay::Box::setIsFirstForLayoutBox): +(WebCore::InlineDisplay::Box::setIsLastForLayoutBox): +(WebCore::InlineDisplay::Box::isFirstBox const): Deleted. +(WebCore::InlineDisplay::Box::isLastBox const): Deleted. +(WebCore::InlineDisplay::Box::setIsLastBox): Deleted. +(WebCore::InlineDisplay::Box::setIsFirstBox): Deleted. + +Renamed for clarity and correctness. + +* layout/integration/InlineIteratorBoxModernPath.h: +(WebCore::InlineIterator::BoxModernPath::isText const): +(WebCore::InlineIterator::BoxModernPath::traverseNextTextBox): + +Use the isLastForLayoutBox bit to end the traversal. + +(WebCore::InlineIterator::BoxModernPath::traverseNextInlineBox): +(WebCore::InlineIterator::BoxModernPath::traversePreviousInlineBox): +(WebCore::InlineIterator::BoxModernPath::traverseNextWithSameLayoutBox): +(WebCore::InlineIterator::BoxModernPath::traversePreviousWithSameLayoutBox): + +Factor into helpers. + +* layout/integration/InlineIteratorTextBox.h: + 2021-12-05 Said Abou-Hallawa [GPU Process] Add the encoding/decoding for Filter and FilterEffect Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp (286540 => 286541) ---
[webkit-changes] [286540] trunk/Source/WTF
Title: [286540] trunk/Source/WTF Revision 286540 Author you...@apple.com Date 2021-12-06 00:13:05 -0800 (Mon, 06 Dec 2021) Log Message Enable NavigationPreloadManager by default https://bugs.webkit.org/show_bug.cgi?id=233755 Reviewed by Chris Dumez. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (286539 => 286540) --- trunk/Source/WTF/ChangeLog 2021-12-06 08:05:45 UTC (rev 286539) +++ trunk/Source/WTF/ChangeLog 2021-12-06 08:13:05 UTC (rev 286540) @@ -1,3 +1,12 @@ +2021-12-06 Youenn Fablet + +Enable NavigationPreloadManager by default +https://bugs.webkit.org/show_bug.cgi?id=233755 + +Reviewed by Chris Dumez. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2021-12-05 Simon Fraser Add trace points for generated momentum events Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (286539 => 286540) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-12-06 08:05:45 UTC (rev 286539) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-12-06 08:13:05 UTC (rev 286540) @@ -1265,11 +1265,11 @@ condition: ENABLE(SERVICE_WORKER) defaultValue: WebCore: - default: false + default: true WebKitLegacy: default: false WebKit: - default: false + default: true SharedWorkerEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286539] trunk/Source/ThirdParty/libwebrtc
Title: [286539] trunk/Source/ThirdParty/libwebrtc
Revision 286539
Author you...@apple.com
Date 2021-12-06 00:05:45 -0800 (Mon, 06 Dec 2021)
Log Message
Close WebRTC allocation sequence shared socket in case of sequence network failure
https://bugs.webkit.org/show_bug.cgi?id=233808
Reviewed by Geoffrey Garen.
* Source/webrtc/p2p/client/basic_port_allocator.cc:
* Source/webrtc/p2p/client/basic_port_allocator.h:
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.h
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (286538 => 286539)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-12-06 05:49:52 UTC (rev 286538)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-12-06 08:05:45 UTC (rev 286539)
@@ -1,3 +1,13 @@
+2021-12-06 Youenn Fablet
+
+Close WebRTC allocation sequence shared socket in case of sequence network failure
+https://bugs.webkit.org/show_bug.cgi?id=233808
+
+Reviewed by Geoffrey Garen.
+
+* Source/webrtc/p2p/client/basic_port_allocator.cc:
+* Source/webrtc/p2p/client/basic_port_allocator.h:
+
2021-11-22 Youenn Fablet
Remove h264_bitstream_parser spurious logging
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.cc (286538 => 286539)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.cc 2021-12-06 05:49:52 UTC (rev 286538)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.cc 2021-12-06 08:05:45 UTC (rev 286539)
@@ -1272,9 +1272,22 @@
relay_ports_.clear();
}
+#if defined(WEBRTC_WEBKIT_BUILD)
+void AllocationSequence::set_network_failed()
+{
+ network_failed_ = true;
+ if (udp_socket_) {
+udp_socket_->SetError(ENETDOWN);
+udp_socket_->Close();
+ }
+}
+#endif
+
void AllocationSequence::OnNetworkFailed() {
RTC_DCHECK(!network_failed_);
- network_failed_ = true;
+#if defined(WEBRTC_WEBKIT_BUILD)
+ set_network_failed();
+#endif
// Stop the allocation sequence if its network failed.
Stop();
}
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.h (286538 => 286539)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.h 2021-12-06 05:49:52 UTC (rev 286538)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.h 2021-12-06 08:05:45 UTC (rev 286539)
@@ -355,7 +355,11 @@
rtc::Network* network() const { return network_; }
bool network_failed() const { return network_failed_; }
+#if defined(WEBRTC_WEBKIT_BUILD)
+ void set_network_failed();
+#else
void set_network_failed() { network_failed_ = true; }
+#endif
// Disables the phases for a new sequence that this one already covers for an
// equivalent network setup.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
