[webkit-changes] [287013] trunk

[wilander]

Title: [287013] trunk








Revision 287013
Author wilan...@apple.com
Date 2021-12-13 23:56:44 -0800 (Mon, 13 Dec 2021)


Log Message
PCM: Remove old DB update and migration code, and add a unit test for destination token DB columns
https://bugs.webkit.org/show_bug.cgi?id=234281


Reviewed by Alex Christensen and Kate Cheney.

Source/WebKit:

WebKit::Database::needsUpdatedSchema() in PrivateClickMeasurement.cpp has a comment saying it
should be removed late 2021. WebKit::DatabaseUtilities::migrateDataToNewTablesIfNecessary()
returns directly if WebKit::Database::needsUpdatedSchema() returns false so always returning
false for WebKit::Database::needsUpdatedSchema() in PrivateClickMeasurement.cpp effectively
disables WebKit::DatabaseUtilities::migrateDataToNewTablesIfNecessary() for PCM.

New unit/API test PrivateClickMeasurement.MigrateWithDestinationToken added.

* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:
(WebKit::PCM::Database::Database):
No longer calls the deleted DatabaseUtilities::migrateDataToNewTablesIfNecessary().
(WebKit::PCM::Database::attributionToStringForTesting const):
Now outputs destination token info.
(WebKit::PCM::Database::needsUpdatedSchema): Deleted.
* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h:
needsUpdatedSchema() now always returns false.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:
(addAttributedPCMv5):
(pollUntilPCMIsMigrated):
Now takes a parameter UsingDestinationToken and handles its expectation
accordingly.
(TEST):
New test PrivateClickMeasurement.MigrateWithDestinationToken.

LayoutTests:

These expect files are just updated with destination token dump output.

* http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt:
* http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt:
* http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt:
* http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt:
* http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt:
* http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt:
* http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt:
* http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt:
* http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt:
* http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt
trunk/LayoutTests/http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-expected.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (287012 => 287013)

--- trunk/LayoutTests/ChangeLog	2021-12-14 07:07:39 UTC (rev 287012)
+++ trunk/LayoutTests/ChangeLog	2021-12-14 07:56:44 UTC (rev 287013)
@@ -1,3 +1,24 @@
+2021-12-13  John Wilander  
+
+PCM: Remove old DB update and migration code, and add a unit test for destination token DB columns
+https://bugs.webkit.org/show_bug.cgi?id=234281
+
+
+Reviewed by Alex Christensen and Kate Cheney.
+
+These expect files are just updated with destination token dump output.
+
+* http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt:
+ 

[webkit-changes] [287012] trunk/Source/JavaScriptCore

[sbarati]

Title: [287012] trunk/Source/_javascript_Core








Revision 287012
Author sbar...@apple.com
Date 2021-12-13 23:07:39 -0800 (Mon, 13 Dec 2021)


Log Message
WasmB3IRGenerator should estimate static execution counts
https://bugs.webkit.org/show_bug.cgi?id=234284

Reviewed by Filip Pizlo.

This enables the register allocator to make better decisions.

* _javascript_Core.xcodeproj/project.pbxproj:
* Sources.txt:
* b3/B3BasicBlock.h:
(JSC::B3::BasicBlock::setFrequency):
* b3/B3EstimateStaticExecutionCounts.cpp: Added.
(JSC::B3::estimateStaticExecutionCounts):
* b3/B3EstimateStaticExecutionCounts.h: Added.
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::parseAndCompile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/Sources.txt
trunk/Source/_javascript_Core/b3/B3BasicBlock.h
trunk/Source/_javascript_Core/b3/B3Procedure.h
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp


Added Paths

trunk/Source/_javascript_Core/b3/B3EstimateStaticExecutionCounts.cpp
trunk/Source/_javascript_Core/b3/B3EstimateStaticExecutionCounts.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (287011 => 287012)

--- trunk/Source/_javascript_Core/ChangeLog	2021-12-14 04:55:38 UTC (rev 287011)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-12-14 07:07:39 UTC (rev 287012)
@@ -1,3 +1,22 @@
+2021-12-13  Saam Barati  
+
+WasmB3IRGenerator should estimate static execution counts
+https://bugs.webkit.org/show_bug.cgi?id=234284
+
+Reviewed by Filip Pizlo.
+
+This enables the register allocator to make better decisions.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* Sources.txt:
+* b3/B3BasicBlock.h:
+(JSC::B3::BasicBlock::setFrequency):
+* b3/B3EstimateStaticExecutionCounts.cpp: Added.
+(JSC::B3::estimateStaticExecutionCounts):
+* b3/B3EstimateStaticExecutionCounts.h: Added.
+* wasm/WasmB3IRGenerator.cpp:
+(JSC::Wasm::parseAndCompile):
+
 2021-12-13  Brady Eidson  
 
 Teach webpushtool to register and "host" the daemon.


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (287011 => 287012)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2021-12-14 04:55:38 UTC (rev 287011)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2021-12-14 07:07:39 UTC (rev 287012)
@@ -906,6 +906,8 @@
 		52CD0F5E2242F569004A18A5 /* _javascript_Core.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 932F5BD90822A1C700736975 /* _javascript_Core.framework */; };
 		52CD0F682242F71C004A18A5 /* testdfg.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 52CD0F672242F71C004A18A5 /* testdfg.cpp */; };
 		52DD000826E039B90054E408 /* BaselineJITCode.h in Headers */ = {isa = PBXBuildFile; fileRef = 52DD000626E039B30054E408 /* BaselineJITCode.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		52E65A1C27682760002B4C0A /* B3EstimateStaticExecutionCounts.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 52E65A1A27682760002B4C0A /* B3EstimateStaticExecutionCounts.cpp */; };
+		52E65A1E27682771002B4C0A /* B3EstimateStaticExecutionCounts.h in Headers */ = {isa = PBXBuildFile; fileRef = 52E65A1B27682760002B4C0A /* B3EstimateStaticExecutionCounts.h */; };
 		52EED7942492B870008F4C93 /* FunctionAllowlist.h in Headers */ = {isa = PBXBuildFile; fileRef = 52EED7932492B868008F4C93 /* FunctionAllowlist.h */; };
 		52F6C35E1E71EB080081F4CC /* WebAssemblyWrapperFunction.h in Headers */ = {isa = PBXBuildFile; fileRef = 52F6C35C1E71EB080081F4CC /* WebAssemblyWrapperFunction.h */; };
 		530A66B91FA3E78B0026A545 /* UnifiedSource3-mm.mm in Sources */ = {isa = PBXBuildFile; fileRef = 530A66B11FA3E77A0026A545 /* UnifiedSource3-mm.mm */; };
@@ -3717,6 +3719,8 @@
 		52D1308F221CE03A009C836C /* foo.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode._javascript_; path = foo.js; sourceTree = ""; };
 		52DD000626E039B30054E408 /* BaselineJITCode.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BaselineJITCode.h; sourceTree = ""; };
 		52DD000726E039B40054E408 /* BaselineJITCode.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = BaselineJITCode.cpp; sourceTree = ""; };
+		52E65A1A27682760002B4C0A /* B3EstimateStaticExecutionCounts.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = B3EstimateStaticExecutionCounts.cpp; path = b3/B3EstimateStaticExecutionCounts.cpp; sourceTree = ""; };
+		52E65A1B27682760002B4C0A /* B3EstimateStaticExecutionCounts.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = B3EstimateStaticExecutionCounts.h; path = b3/B3EstimateStaticExecutionCounts.h; sourceTree = ""; };
 		52EED7922492B868008F4C93 /* FunctionAllowlist.cpp */ = {isa = PBXFileReference; lastKnownFileType = 

[webkit-changes] [287011] trunk/Source/WebCore

[katherine_cheney]

Title: [287011] trunk/Source/WebCore








Revision 287011
Author katherine_che...@apple.com
Date 2021-12-13 20:55:38 -0800 (Mon, 13 Dec 2021)


Log Message
WebContent process crashes at ContentSecurityPolicySourceList::matchesAll
https://bugs.webkit.org/show_bug.cgi?id=234288
rdar://problem/86438924

Reviewed by Simon Fraser.

* page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScript const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (287010 => 287011)

--- trunk/Source/WebCore/ChangeLog	2021-12-14 04:26:34 UTC (rev 287010)
+++ trunk/Source/WebCore/ChangeLog	2021-12-14 04:55:38 UTC (rev 287011)
@@ -1,3 +1,14 @@
+2021-12-13  Kate Cheney  
+
+WebContent process crashes at ContentSecurityPolicySourceList::matchesAll
+https://bugs.webkit.org/show_bug.cgi?id=234288
+rdar://problem/86438924
+
+Reviewed by Simon Fraser.
+
+* page/csp/ContentSecurityPolicyDirectiveList.cpp:
+(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScript const):
+
 2021-12-13  Alex Christensen  
 
 Allow WKContentRuleList to run regexes on current frame's URL, not just top frame's URL


Modified: trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp (287010 => 287011)

--- trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp	2021-12-14 04:26:34 UTC (rev 287010)
+++ trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp	2021-12-14 04:55:38 UTC (rev 287011)
@@ -391,7 +391,7 @@
 {
 auto* operativeDirective = this->operativeDirective(m_scriptSrc.get(), ContentSecurityPolicyDirectiveNames::scriptSrcElem);
 
-if (operativeDirective->containsAllHashes(subResourceIntegrityDigests))
+if (!operativeDirective || operativeDirective->containsAllHashes(subResourceIntegrityDigests))
 return nullptr;
 
 if (checkSource(operativeDirective, url, didReceiveRedirectResponse))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287009] trunk

[beidson]

Title: [287009] trunk








Revision 287009
Author beid...@apple.com
Date 2021-12-13 20:23:27 -0800 (Mon, 13 Dec 2021)


Log Message
Teach webpushtool to register and "host" the daemon.
https://bugs.webkit.org/show_bug.cgi?id=234265

Reviewed by Tim Horton.

Source/_javascript_Core:

* inspector/ConsoleMessage.h: Remove `using JSC::MessageType` because it makes it hard for others
  to also have a `MessageType` type.
* inspector/JSGlobalObjectConsoleClient.h:
* runtime/ConsoleTypes.h:

Source/WebCore:

* page/PageConsoleClient.h:

Source/WebKit:

Covered by API tests verifying hosting mode operation.

As various engineers work on various parts of the project, it's become apparent that it's super useful
to have a tool handle the "setting up" of the daemon itself, to avoid launchctl, etc.

Implement that, as well as a few other niceties found while testing.

* Configurations/webpushtool.xcconfig:
* Resources/webpushtool.entitlements:

* Shared/Daemon/DaemonUtilities.mm:
(WebKit::startListeningForMachServiceConnections):

* webpushd/AppBundleRequest.mm:
(WebPushD::AppBundleRequest::start):

* webpushd/PushClientConnection.h:
* webpushd/PushClientConnection.mm:
(WebPushD::ClientConnection::setHostAppAuditTokenData):
(WebPushD::ClientConnection::broadcastDebugMessage):

* webpushd/WebPushDaemon.h:
* webpushd/WebPushDaemon.mm:
(WebPushD::Daemon::broadcastAllConnectionIdentities):

* webpushd/webpushtool/WebPushToolConnection.h:
* webpushd/webpushtool/WebPushToolConnection.mm:
(WebPushTool::Connection::connectToService):
(WebPushTool::Connection::connectionDropped):

* webpushd/webpushtool/WebPushToolMain.mm:
(printUsageAndTerminate):
(registerDaemonWithLaunchD):
(main):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::shouldSetupWebPushD): Add a command line argument to skip the "install the daemon" step,
  so an engineer can handle that part themselves.
(TestWebKitAPI::setUpTestWebPushD):
(TestWebKitAPI::cleanUpTestWebPushD):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/ConsoleMessage.h
trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.h
trunk/Source/_javascript_Core/runtime/ConsoleTypes.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PageConsoleClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/webpushtool.xcconfig
trunk/Source/WebKit/Resources/webpushtool.entitlements
trunk/Source/WebKit/Shared/Daemon/DaemonUtilities.mm
trunk/Source/WebKit/webpushd/AppBundleRequest.mm
trunk/Source/WebKit/webpushd/PushClientConnection.h
trunk/Source/WebKit/webpushd/PushClientConnection.mm
trunk/Source/WebKit/webpushd/WebPushDaemon.h
trunk/Source/WebKit/webpushd/WebPushDaemon.mm
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (287008 => 287009)

--- trunk/Source/_javascript_Core/ChangeLog	2021-12-14 03:28:24 UTC (rev 287008)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-12-14 04:23:27 UTC (rev 287009)
@@ -1,3 +1,15 @@
+2021-12-13  Brady Eidson  
+
+Teach webpushtool to register and "host" the daemon.
+https://bugs.webkit.org/show_bug.cgi?id=234265
+
+Reviewed by Tim Horton.
+
+* inspector/ConsoleMessage.h: Remove `using JSC::MessageType` because it makes it hard for others
+  to also have a `MessageType` type.
+* inspector/JSGlobalObjectConsoleClient.h:
+* runtime/ConsoleTypes.h:
+
 2021-12-13  Saam Barati  
 
 Roll back r286345, r286387, r286471, r286667, r286849


Modified: trunk/Source/_javascript_Core/inspector/ConsoleMessage.h (287008 => 287009)

--- trunk/Source/_javascript_Core/inspector/ConsoleMessage.h	2021-12-14 03:28:24 UTC (rev 287008)
+++ trunk/Source/_javascript_Core/inspector/ConsoleMessage.h	2021-12-14 04:23:27 UTC (rev 287009)
@@ -43,6 +43,8 @@
 class JSGlobalObject;
 }
 
+using JSC::MessageType;
+
 namespace Inspector {
 
 class ConsoleFrontendDispatcher;


Modified: trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.h (287008 => 287009)

--- trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.h	2021-12-14 03:28:24 UTC (rev 287008)
+++ trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.h	2021-12-14 04:23:27 UTC (rev 287009)
@@ -29,6 +29,8 @@
 #include 
 #include 
 
+using JSC::MessageType;
+
 namespace Inspector {
 
 class InspectorConsoleAgent;


Modified: trunk/Source/_javascript_Core/runtime/ConsoleTypes.h (287008 => 287009)

--- trunk/Source/_javascript_Core/runtime/ConsoleTypes.h	2021-12-14 03:28:24 UTC (rev 287008)
+++ trunk/Source/_javascript_Core/runtime/ConsoleTypes.h	2021-12-14 04:23:27 UTC (rev 287009)
@@ -115,5 +115,4 @@
 } // namespace WTF
 
 using JSC::MessageSource;

[webkit-changes] [287006] branches/safari-613.1.11-branch/Source/JavaScriptCore

[repstein]

Title: [287006] branches/safari-613.1.11-branch/Source/_javascript_Core








Revision 287006
Author repst...@apple.com
Date 2021-12-13 19:28:00 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286667. rdar://problem/86445989

[JSC] Introduce WriteBarrierStructureID
https://bugs.webkit.org/show_bug.cgi?id=233918

Reviewed by Mark Lam.

This patch adds WriteBarrierStructureID class, which is similar to WriteBarrier, but internally,
it holds StructureID, so sizeof(WriteBarrierStructureID) is 4. This class is useful to use StructureID for
memory saving while keeping WriteBarrier's useful features (automatically inserts write-barrier when
setting etc.). This also paves the way to introducing DOMStructures array with WriteBarrierStructureID instead
of costly HashMap>.

* bytecode/AccessCase.cpp:
(JSC::AccessCase::AccessCase):
(JSC::AccessCase::forEachDependentCell const):
(JSC::AccessCase::dump const):
(JSC::AccessCase::propagateTransitions const):
(JSC::AccessCase::canBeShared):
* bytecode/AccessCase.h:
(JSC::AccessCase::structure const):
(JSC::AccessCase::newStructure const):
(JSC::AccessCase::hash const):
(JSC::AccessCase::AccessCase):
* bytecode/CheckPrivateBrandStatus.cpp:
(JSC::CheckPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):
* bytecode/DeleteByStatus.cpp:
(JSC::DeleteByStatus::computeForStubInfoWithoutExitSiteFeedback):
* bytecode/GetByStatus.cpp:
(JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback):
* bytecode/InByStatus.cpp:
(JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):
* bytecode/InlineAccess.cpp:
(JSC::InlineAccess::rewireStubAsJumpInAccess):
(JSC::InlineAccess::resetStubAsJumpInAccess):
* bytecode/InstanceOfStatus.cpp:
(JSC::InstanceOfStatus::computeForStubInfo):
* bytecode/InternalFunctionAllocationProfile.h:
(JSC::InternalFunctionAllocationProfile::offsetOfStructureID):
(JSC::InternalFunctionAllocationProfile::structure):
(JSC::InternalFunctionAllocationProfile::clear):
(JSC::InternalFunctionAllocationProfile::visitAggregate):
(JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase):
(JSC::InternalFunctionAllocationProfile::offsetOfStructure): Deleted.
* bytecode/PutByStatus.cpp:
(JSC::PutByStatus::computeForStubInfo):
* bytecode/SetPrivateBrandStatus.cpp:
(JSC::SetPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::initInByIdSelf):
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::addAccessCase):
(JSC::StructureStubInfo::reset):
(JSC::StructureStubInfo::visitAggregateImpl):
(JSC::StructureStubInfo::visitWeakReferences):
(JSC::StructureStubInfo::propagateTransitions):
(JSC::StructureStubInfo::summary const):
(JSC::StructureStubInfo::containsPC const):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::inlineAccessBaseStructure):
(JSC::StructureStubInfo::offsetOfByIdSelfOffset):
(JSC::StructureStubInfo::offsetOfInlineAccessBaseStructureID):
(JSC::StructureStubInfo::offsetOfInlineAccessBaseStructure): Deleted.
* dfg/DFGSpeculativeJIT.cpp:
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
* heap/AbstractSlotVisitor.h:
* heap/AbstractSlotVisitorInlines.h:
(JSC::AbstractSlotVisitor::append):
(JSC::AbstractSlotVisitor::appendHidden):
* heap/SlotVisitor.h:
* heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendHidden):
* jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitNonNullDecodeStructureID):
(JSC::AssemblyHelpers::emitLoadStructure):
* jit/AssemblyHelpers.h:
* jit/JITInlineCacheGenerator.cpp:
(JSC::generateGetByIdInlineAccess):
(JSC::JITPutByIdGenerator::generateBaselineDataICFastPath):
(JSC::JITInByIdGenerator::generateBaselineDataICFastPath):
* runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::visitChildrenImpl):
* runtime/FunctionExecutable.h:
* runtime/FunctionRareData.cpp:
(JSC::FunctionRareData::visitChildrenImpl):
* runtime/FunctionRareData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildrenImpl):
* runtime/JSGlobalObject.h:
* runtime/JSPropertyNameEnumerator.cpp:
(JSC::JSPropertyNameEnumerator::JSPropertyNameEnumerator):
(JSC::JSPropertyNameEnumerator::visitChildrenImpl):
* runtime/JSPropertyNameEnumerator.h:
* runtime/StructureRareData.cpp:
(JSC::StructureRareData::StructureRareData):
* 

[webkit-changes] [287007] branches/safari-613.1.11-branch/Source/WTF

[repstein]

Title: [287007] branches/safari-613.1.11-branch/Source/WTF








Revision 287007
Author repst...@apple.com
Date 2021-12-13 19:28:02 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286849. rdar://problem/86445989

Reduce maximum mmap size for Structure regions to help placate ios
https://bugs.webkit.org/show_bug.cgi?id=234091

Reviewed by Saam Barati.

Use mach_vm_map since that supports memory alignement so we don't have to map 2x desired address space then free then trim.

* wtf/PlatformHave.h:
* wtf/posix/OSAllocatorPOSIX.cpp:
(WTF::OSAllocator::reserveUncommittedAligned):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.11-branch/Source/WTF/ChangeLog
branches/safari-613.1.11-branch/Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp




Diff

Modified: branches/safari-613.1.11-branch/Source/WTF/ChangeLog (287006 => 287007)

--- branches/safari-613.1.11-branch/Source/WTF/ChangeLog	2021-12-14 03:28:00 UTC (rev 287006)
+++ branches/safari-613.1.11-branch/Source/WTF/ChangeLog	2021-12-14 03:28:02 UTC (rev 287007)
@@ -1,3 +1,34 @@
+2021-12-13  Russell Epstein  
+
+Cherry-pick r286849. rdar://problem/86445989
+
+Reduce maximum mmap size for Structure regions to help placate ios
+https://bugs.webkit.org/show_bug.cgi?id=234091
+
+Reviewed by Saam Barati.
+
+Use mach_vm_map since that supports memory alignement so we don't have to map 2x desired address space then free then trim.
+
+* wtf/PlatformHave.h:
+* wtf/posix/OSAllocatorPOSIX.cpp:
+(WTF::OSAllocator::reserveUncommittedAligned):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-10  Keith Miller  
+
+Reduce maximum mmap size for Structure regions to help placate ios
+https://bugs.webkit.org/show_bug.cgi?id=234091
+
+Reviewed by Saam Barati.
+
+Use mach_vm_map since that supports memory alignement so we don't have to map 2x desired address space then free then trim.
+
+* wtf/PlatformHave.h:
+* wtf/posix/OSAllocatorPOSIX.cpp:
+(WTF::OSAllocator::reserveUncommittedAligned):
+
 2021-12-03  Chris Dumez  
 
 [WK2] Turn on Web Locks API support


Modified: branches/safari-613.1.11-branch/Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp (287006 => 287007)

--- branches/safari-613.1.11-branch/Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp	2021-12-14 03:28:00 UTC (rev 287006)
+++ branches/safari-613.1.11-branch/Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp	2021-12-14 03:28:02 UTC (rev 287007)
@@ -44,6 +44,10 @@
 #endif // OS(DARWIN)
 #endif // ENABLE(JIT_CAGE)
 
+#if OS(DARWIN)
+#include 
+#endif
+
 namespace WTF {
 
 void* OSAllocator::reserveUncommitted(size_t bytes, Usage usage, bool writable, bool executable, bool jitCageEnabled, bool includesGuardPages)
@@ -73,11 +77,36 @@
 return result;
 }
 
-
-// FIXME: Make a smarter version of this for Linux flavors that have aligned mmap.
 void* OSAllocator::reserveUncommittedAligned(size_t bytes, Usage usage, bool writable, bool executable, bool jitCageEnabled, bool includesGuardPages)
 {
 ASSERT(hasOneBitSet(bytes) && bytes >= pageSize());
+
+#if PLATFORM(MAC) || USE(APPLE_INTERNAL_SDK)
+UNUSED_PARAM(usage); // Not supported for mach API.
+ASSERT_UNUSED(includesGuardPages, !includesGuardPages);
+ASSERT_UNUSED(jitCageEnabled, !jitCageEnabled); // Not supported for mach API.
+vm_prot_t protections = VM_PROT_READ;
+if (writable)
+protections |= VM_PROT_WRITE;
+if (executable)
+protections |= VM_PROT_EXECUTE;
+
+const vm_inherit_t childProcessInheritance = VM_INHERIT_DEFAULT;
+const bool copy = false;
+const int flags = VM_FLAGS_ANYWHERE;
+
+void* aligned = nullptr;
+kern_return_t result = mach_vm_map(mach_task_self(), reinterpret_cast(), bytes, bytes - 1, flags, MEMORY_OBJECT_NULL, 0, copy, protections, protections, childProcessInheritance);
+RELEASE_ASSERT(result == KERN_SUCCESS, result, bytes);
+#if HAVE(MADV_FREE_REUSE)
+if (aligned) {
+// To support the "reserve then commit" model, we have to initially decommit.
+while (madvise(aligned, bytes, MADV_FREE_REUSABLE) == -1 && errno == EAGAIN) { }
+}
+#endif
+
+return aligned;
+#else
 // Double the size so we can ensure enough mapped memory to get an aligned start.
 size_t mappedSize = bytes * 2;
 char* mapped = reinterpret_cast(reserveUncommitted(mappedSize, usage, writable, executable, jitCageEnabled, includesGuardPages));
@@ -95,6 +124,7 @@
 releaseDecommitted(alignedEnd, rightExtra);
 
 return aligned;
+#endif
 }
 
 void* OSAllocator::reserveAndCommit(size_t bytes, Usage usage, bool writable, bool executable, bool jitCageEnabled, bool includesGuardPages)






___
webkit-changes 

[webkit-changes] [287005] branches/safari-613.1.11-branch/Source/JavaScriptCore

[repstein]

Title: [287005] branches/safari-613.1.11-branch/Source/_javascript_Core








Revision 287005
Author repst...@apple.com
Date 2021-12-13 19:27:51 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286597. rdar://problem/86445989

Unreviewed, reverting r286502 and r286580.
https://bugs.webkit.org/show_bug.cgi?id=233930

Speedometer2 0.7% regression

Reverted changesets:

"Remove StructureIDBlob"
https://bugs.webkit.org/show_bug.cgi?id=233723
https://commits.webkit.org/r286502

"TypeInfo should be materializable from Structures as a single
load."
https://bugs.webkit.org/show_bug.cgi?id=233875
https://commits.webkit.org/r286580

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.11-branch/Source/_javascript_Core/CMakeLists.txt
branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.1.11-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
branches/safari-613.1.11-branch/Source/_javascript_Core/assembler/testmasm.cpp
branches/safari-613.1.11-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp
branches/safari-613.1.11-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
branches/safari-613.1.11-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
branches/safari-613.1.11-branch/Source/_javascript_Core/jit/AssemblyHelpers.h
branches/safari-613.1.11-branch/Source/_javascript_Core/jit/JITPropertyAccess.cpp
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/JSCell.h
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/JSCellInlines.h
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/Structure.cpp
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/Structure.h
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureInlines.h
branches/safari-613.1.11-branch/Source/_javascript_Core/tools/VMInspectorInlines.h


Added Paths

branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureIDBlob.h




Diff

Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/CMakeLists.txt (287004 => 287005)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/CMakeLists.txt	2021-12-14 03:27:46 UTC (rev 287004)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/CMakeLists.txt	2021-12-14 03:27:51 UTC (rev 287005)
@@ -1186,6 +1186,7 @@
 runtime/StructureCache.h
 runtime/StructureChain.h
 runtime/StructureID.h
+runtime/StructureIDBlob.h
 runtime/StructureInlines.h
 runtime/StructureRareData.h
 runtime/StructureRareDataInlines.h


Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog (287004 => 287005)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog	2021-12-14 03:27:46 UTC (rev 287004)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog	2021-12-14 03:27:51 UTC (rev 287005)
@@ -1,5 +1,45 @@
 2021-12-13  Russell Epstein  
 
+Cherry-pick r286597. rdar://problem/86445989
+
+Unreviewed, reverting r286502 and r286580.
+https://bugs.webkit.org/show_bug.cgi?id=233930
+
+Speedometer2 0.7% regression
+
+Reverted changesets:
+
+"Remove StructureIDBlob"
+https://bugs.webkit.org/show_bug.cgi?id=233723
+https://commits.webkit.org/r286502
+
+"TypeInfo should be materializable from Structures as a single
+load."
+https://bugs.webkit.org/show_bug.cgi?id=233875
+https://commits.webkit.org/r286580
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-07  Commit Queue  
+
+Unreviewed, reverting r286502 and r286580.
+https://bugs.webkit.org/show_bug.cgi?id=233930
+
+Speedometer2 0.7% regression
+
+Reverted changesets:
+
+"Remove StructureIDBlob"
+https://bugs.webkit.org/show_bug.cgi?id=233723
+https://commits.webkit.org/r286502
+
+"TypeInfo should be materializable from Structures as a single
+load."
+https://bugs.webkit.org/show_bug.cgi?id=233875
+https://commits.webkit.org/r286580
+
+2021-12-13  Russell Epstein  
+
 Cherry-pick r286580. rdar://problem/86445989
 
 TypeInfo should be materializable from Structures as a single load.


Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (287004 => 287005)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2021-12-14 03:27:46 UTC (rev 287004)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2021-12-14 03:27:51 UTC (rev 287005)
@@ -852,6 +852,7 @@
 		2A4BB7F318A41179008A0FCD /* JSManagedValueInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 

[webkit-changes] [287004] branches/safari-613.1.11-branch/Source/JavaScriptCore

[repstein]

Title: [287004] branches/safari-613.1.11-branch/Source/_javascript_Core








Revision 287004
Author repst...@apple.com
Date 2021-12-13 19:27:46 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286580. rdar://problem/86445989

TypeInfo should be materializable from Structures as a single load.
https://bugs.webkit.org/show_bug.cgi?id=233875

Reviewed by Mark Lam.

This is mostly just the members of Structure and JSCell so that
JSType and InlineTypeFlags are at the end of the JSCell header.

* assembler/testmasm.cpp:
(JSC::testBranchIfType):
(JSC::testBranchIfNotType):
* ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
* runtime/JSCell.h:
* runtime/JSCellInlines.h:
(JSC::JSCell::JSCell):
* runtime/Structure.h:
(JSC::Structure::typeInfo const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.1.11-branch/Source/_javascript_Core/assembler/testmasm.cpp
branches/safari-613.1.11-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/JSCell.h
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/JSCellInlines.h
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/Structure.h




Diff

Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog (287003 => 287004)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog	2021-12-14 03:27:43 UTC (rev 287003)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog	2021-12-14 03:27:46 UTC (rev 287004)
@@ -1,3 +1,50 @@
+2021-12-13  Russell Epstein  
+
+Cherry-pick r286580. rdar://problem/86445989
+
+TypeInfo should be materializable from Structures as a single load.
+https://bugs.webkit.org/show_bug.cgi?id=233875
+
+Reviewed by Mark Lam.
+
+This is mostly just the members of Structure and JSCell so that
+JSType and InlineTypeFlags are at the end of the JSCell header.
+
+* assembler/testmasm.cpp:
+(JSC::testBranchIfType):
+(JSC::testBranchIfNotType):
+* ftl/FTLAbstractHeapRepository.cpp:
+(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
+* runtime/JSCell.h:
+* runtime/JSCellInlines.h:
+(JSC::JSCell::JSCell):
+* runtime/Structure.h:
+(JSC::Structure::typeInfo const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-06  Keith Miller  
+
+TypeInfo should be materializable from Structures as a single load.
+https://bugs.webkit.org/show_bug.cgi?id=233875
+
+Reviewed by Mark Lam.
+
+This is mostly just the members of Structure and JSCell so that
+JSType and InlineTypeFlags are at the end of the JSCell header.
+
+* assembler/testmasm.cpp:
+(JSC::testBranchIfType):
+(JSC::testBranchIfNotType):
+* ftl/FTLAbstractHeapRepository.cpp:
+(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
+* runtime/JSCell.h:
+* runtime/JSCellInlines.h:
+(JSC::JSCell::JSCell):
+* runtime/Structure.h:
+(JSC::Structure::typeInfo const):
+
 2021-12-03  Keith Miller  
 
 Remove StructureIDBlob


Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/assembler/testmasm.cpp (287003 => 287004)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/assembler/testmasm.cpp	2021-12-14 03:27:43 UTC (rev 287003)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/assembler/testmasm.cpp	2021-12-14 03:27:46 UTC (rev 287004)
@@ -5613,6 +5613,7 @@
 struct CellLike {
 uint32_t structureID;
 uint8_t indexingType;
+uint8_t cellState;
 JSType type;
 };
 CHECK_EQ(JSCell::typeInfoTypeOffset(), OBJECT_OFFSETOF(CellLike, type));
@@ -5647,6 +5648,7 @@
 struct CellLike {
 uint32_t structureID;
 uint8_t indexingType;
+uint8_t cellState;
 JSType type;
 };
 CHECK_EQ(JSCell::typeInfoTypeOffset(), OBJECT_OFFSETOF(CellLike, type));


Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp (287003 => 287004)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp	2021-12-14 03:27:43 UTC (rev 287003)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp	2021-12-14 03:27:46 UTC (rev 287004)
@@ -78,9 +78,9 @@
 
 // Make sure that our explicit assumptions about the StructureIDBlob match reality.
 RELEASE_ASSERT(!(JSCell_indexingTypeAndMisc.offset() & (sizeof(int32_t) - 1)));
-RELEASE_ASSERT(JSCell_indexingTypeAndMisc.offset() 

[webkit-changes] [287003] branches/safari-613.1.11-branch/Source/JavaScriptCore

[repstein]

Title: [287003] branches/safari-613.1.11-branch/Source/_javascript_Core








Revision 287003
Author repst...@apple.com
Date 2021-12-13 19:27:43 -0800 (Mon, 13 Dec 2021)


Log Message
Revert "Revert r286382. rdar://problem/86408710"

This reverts commit r286996.

Modified Paths

branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureChain.cpp




Diff

Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog (287002 => 287003)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog	2021-12-14 02:42:38 UTC (rev 287002)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog	2021-12-14 03:27:43 UTC (rev 287003)
@@ -1,7 +1,3 @@
-2021-12-13  Alan Coon  
-
-Revert r286382. rdar://problem/86408710
-
 2021-12-03  Keith Miller  
 
 Remove StructureIDBlob


Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureChain.cpp (287002 => 287003)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureChain.cpp	2021-12-14 02:42:38 UTC (rev 287002)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureChain.cpp	2021-12-14 03:27:43 UTC (rev 287003)
@@ -49,6 +49,7 @@
 ++size; // Sentinel nullptr.
 size_t bytes = Checked(size) * sizeof(StructureID);
 void* vector = vm.jsValueGigacageAuxiliarySpace().allocateNonVirtual(vm, bytes, nullptr, AllocationFailureMode::Assert);
+static_assert(!StructureID().bits(), "Make sure the value we're going to memcpy below matches the default StructureID");
 memset(vector, 0, bytes);
 StructureChain* chain = new (NotNull, allocateCell(vm)) StructureChain(vm, vm.structureChainStructure.get(), static_cast(vector));
 chain->finishCreation(vm, head);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287002] trunk

[j_pascoe]

Title: [287002] trunk








Revision 287002
Author j_pas...@apple.com
Date 2021-12-13 18:42:38 -0800 (Mon, 13 Dec 2021)


Log Message
Unreviewed, reverting r286993.
https://bugs.webkit.org/show_bug.cgi?id=234283

Reverted changeset:

"[WebAuthn] Allow same-site, cross-origin iframe get()"
https://bugs.webkit.org/show_bug.cgi?id=234180
https://commits.webkit.org/r286993

Patch by Commit Queue  on 2021-12-13

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html
trunk/LayoutTests/http/wpt/webauthn/resources/util.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp
trunk/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h
trunk/Source/WebCore/html/FeaturePolicy.cpp
trunk/Source/WebCore/html/FeaturePolicy.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm


Removed Paths

trunk/LayoutTests/http/wpt/webauthn/resources/samesite-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (287001 => 287002)

--- trunk/LayoutTests/ChangeLog	2021-12-14 02:20:20 UTC (rev 287001)
+++ trunk/LayoutTests/ChangeLog	2021-12-14 02:42:38 UTC (rev 287002)
@@ -1,3 +1,15 @@
+2021-12-13  Commit Queue  
+
+Unreviewed, reverting r286993.
+https://bugs.webkit.org/show_bug.cgi?id=234283
+
+
+Reverted changeset:
+
+"[WebAuthn] Allow same-site, cross-origin iframe get()"
+https://bugs.webkit.org/show_bug.cgi?id=234180
+https://commits.webkit.org/r286993
+
 2021-12-13  Christopher Reid  
 
 [Curl] Improve curl's cookie conformance in WPT


Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt (287001 => 287002)

--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt	2021-12-14 02:20:20 UTC (rev 287001)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt	2021-12-14 02:42:38 UTC (rev 287002)
@@ -2,7 +2,4 @@
 
 PASS Tests that a frame that doesn't share the same origin with all its ancestors could not access the API.
 PASS Tests that a frame that doesn't share the same origin with all its ancestors could not access the API. 2
-PASS Tests that a frame that is same-site, cross-origin without publickey-credentials-get feature policy cannot use get().
-PASS Tests that a frame that is same-site, cross-origin with publickey-credentials-get feature policy can use get().
-PASS Tests that a frame that is cross-origin, NOT same-site  with publickey-credentials-get feature policy cannot use get().
 


Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html (287001 => 287002)

--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html	2021-12-14 02:20:20 UTC (rev 287001)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html	2021-12-14 02:42:38 UTC (rev 287002)
@@ -22,24 +22,6 @@
 assert_equals(message.data, "PASS.");
 });
 }, "Tests that a frame that doesn't share the same origin with all its ancestors could not access the API. 2");
-
-promise_test(t => {
-return withSameSiteIframe("samesite-iframe.html").then((message) => {
-assert_equals(message.data, "Throw NotAllowedError: The origin of the document is not the same as its ancestors.");
-});
-}, "Tests that a frame that is same-site, cross-origin without publickey-credentials-get feature policy cannot use get().");
-
-promise_test(t => {
-return withSameSiteIframe("samesite-iframe.html", "publickey-credentials-get").then((message) => {
-assert_equals(message.data, "PASS!");
-});
-}, "Tests that a frame that is same-site, cross-origin with publickey-credentials-get feature policy can use get().");
-
-promise_test(t => {
-return withCrossOriginIframe("samesite-iframe.html", "publickey-credentials-get").then((message) => {
-assert_equals(message.data, "Throw NotAllowedError: The origin of the document is not the same as its ancestors.");
-});
-}, "Tests that 

[webkit-changes] [287001] tags/Safari-613.1.11.5/

[repstein]

Title: [287001] tags/Safari-613.1.11.5/








Revision 287001
Author repst...@apple.com
Date 2021-12-13 18:20:20 -0800 (Mon, 13 Dec 2021)


Log Message
Tag Safari-613.1.11.5.

Added Paths

tags/Safari-613.1.11.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287000] trunk

[chris . reid]

Title: [287000] trunk








Revision 287000
Author chris.r...@sony.com
Date 2021-12-13 17:52:38 -0800 (Mon, 13 Dec 2021)


Log Message
[Curl] Improve curl's cookie conformance in WPT
https://bugs.webkit.org/show_bug.cgi?id=232722

Reviewed by Fujii Hironori.

Source/WebCore:

Fix some cases where CookieJarDB differs from WPT expectations.

* platform/network/curl/CookieJarDB.cpp:
__Secure and __Host prefixes are now stricter.
Don't allow empty cookies to be set.
* platform/network/curl/CookieUtil.cpp:
Empty paths should override previous paths in the cookie list.
* platform/network/curl/NetworkStorageSessionCurl.cpp:

Tools:

* WebKitTestRunner/TestController.cpp: Use a unique cookie file for each test on windows

LayoutTests:

Add baseline for wpt cookie tests on wincairo

* platform/wincairo/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp
trunk/Source/WebCore/platform/network/curl/CookieUtil.cpp
trunk/Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp


Added Paths

trunk/LayoutTests/platform/wincairo/imported/
trunk/LayoutTests/platform/wincairo/imported/w3c/
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/attributes/
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/attributes/invalid-expected.txt
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/attributes/max-age-expected.txt
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/name/
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/name/name-expected.txt
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/ordering/
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/ordering/ordering.sub-expected.txt
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/path/
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/path/match-expected.txt
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/samesite/
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/samesite/about-blank-subresource.https-expected.txt
trunk/LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (286999 => 287000)

--- trunk/LayoutTests/ChangeLog	2021-12-14 01:50:21 UTC (rev 286999)
+++ trunk/LayoutTests/ChangeLog	2021-12-14 01:52:38 UTC (rev 287000)
@@ -1,3 +1,14 @@
+2021-12-13  Christopher Reid  
+
+[Curl] Improve curl's cookie conformance in WPT
+https://bugs.webkit.org/show_bug.cgi?id=232722
+
+Reviewed by Fujii Hironori.
+
+Add baseline for wpt cookie tests on wincairo
+
+* platform/wincairo/TestExpectations:
+
 2021-12-13  Robert Jenner  
 
 [ iOS ] 8 imported/w3c/web-platform-tests/fetch/api (layout-tests) are flaky text failures


Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (286999 => 287000)

--- trunk/LayoutTests/platform/wincairo/TestExpectations	2021-12-14 01:50:21 UTC (rev 286999)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations	2021-12-14 01:52:38 UTC (rev 287000)
@@ -1427,6 +1427,35 @@
 storage/indexeddb/modern/aborted-put.html [ Timeout Pass ]
 [ Debug ] storage/indexeddb/modern/index-rename-1.html [ Skip ]
 
+# Flaky values in WPT cookie expectations
+imported/w3c/web-platform-tests/cookies/prefix/__secure.header.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/samesite-none-secure/cookies-without-samesite-must-be-secure.https.tentative.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/samesite/iframe.document.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/samesite/multiple-samesite-attributes.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/samesite/sandbox-iframe-nested.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/samesite/sandbox-iframe-subresource.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/samesite/setcookie-lax.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/samesite/setcookie-navigation.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/schemeful-same-site/schemeful-iframe-subresource.tentative.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/schemeful-same-site/schemeful-navigation.tentative.html [ Pass Failure ]
+imported/w3c/web-platform-tests/cookies/schemeful-same-site/schemeful-subresource.tentative.html [ Pass Failure ]
+
+# WPT diff failures that 

[webkit-changes] [286999] trunk/Source/WebKit

[timothy_horton]

Title: [286999] trunk/Source/WebKit








Revision 286999
Author timothy_hor...@apple.com
Date 2021-12-13 17:50:21 -0800 (Mon, 13 Dec 2021)


Log Message
Momentum Event Dispatcher: Excessive "kick" at the beginning of scrolling (especially on 60fps displays)
https://bugs.webkit.org/show_bug.cgi?id=234279


Reviewed by Simon Fraser.

* WebProcess/WebPage/MomentumEventDispatcher.cpp:
(WebKit::MomentumEventDispatcher::handleWheelEvent):
(WebKit::MomentumEventDispatcher::didStartMomentumPhase):
Instead of back-dating the animation to try to acquire a momentum-start
delta, pass the one we got from the event through, and start the animation
curve at momentum-start time. Also, critically, inset ourselves along
the curve by the amount of that initial delta (since the time starts now).

Tested at both 60fps and 120fps, this significantly smooths out the
transition from fingers-down phase to the generated momentum phase,
avoiding the overly large initial delta.

* WebProcess/WebPage/MomentumEventDispatcher.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp
trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (286998 => 286999)

--- trunk/Source/WebKit/ChangeLog	2021-12-14 01:38:11 UTC (rev 286998)
+++ trunk/Source/WebKit/ChangeLog	2021-12-14 01:50:21 UTC (rev 286999)
@@ -1,3 +1,25 @@
+2021-12-13  Tim Horton  
+
+Momentum Event Dispatcher: Excessive "kick" at the beginning of scrolling (especially on 60fps displays)
+https://bugs.webkit.org/show_bug.cgi?id=234279
+
+
+Reviewed by Simon Fraser.
+
+* WebProcess/WebPage/MomentumEventDispatcher.cpp:
+(WebKit::MomentumEventDispatcher::handleWheelEvent):
+(WebKit::MomentumEventDispatcher::didStartMomentumPhase):
+Instead of back-dating the animation to try to acquire a momentum-start
+delta, pass the one we got from the event through, and start the animation
+curve at momentum-start time. Also, critically, inset ourselves along
+the curve by the amount of that initial delta (since the time starts now).
+
+Tested at both 60fps and 120fps, this significantly smooths out the
+transition from fingers-down phase to the generated momentum phase,
+avoiding the overly large initial delta.
+
+* WebProcess/WebPage/MomentumEventDispatcher.h:
+
 2021-12-13  J Pascoe  
 
 [WebAuthn] Allow same-site, cross-origin iframe get()


Modified: trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp (286998 => 286999)

--- trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp	2021-12-14 01:38:11 UTC (rev 286998)
+++ trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp	2021-12-14 01:50:21 UTC (rev 286999)
@@ -100,9 +100,6 @@
 #endif
 }
 
-if (event.phase() == WebWheelEvent::PhaseEnded)
-m_lastEndedEventTimestamp = event.ioHIDEventTimestamp();
-
 if (eventShouldStartSyntheticMomentumPhase(pageIdentifier, event))
 didStartMomentumPhase(pageIdentifier, event);
 
@@ -190,13 +187,11 @@
 
 tracePoint(SyntheticMomentumStart);
 
-auto momentumStartInterval = event.ioHIDEventTimestamp() - m_lastEndedEventTimestamp;
-
 m_currentGesture.active = true;
 m_currentGesture.pageIdentifier = pageIdentifier;
 m_currentGesture.initiatingEvent = event;
 m_currentGesture.currentOffset = { };
-m_currentGesture.startTime = MonotonicTime::now() - momentumStartInterval;
+m_currentGesture.startTime = MonotonicTime::now();
 m_currentGesture.displayNominalFrameRate = displayProperties->nominalFrameRate;
 m_currentGesture.accelerationCurve = [&] () -> std::optional {
 auto curveIterator = m_accelerationCurves.find(m_currentGesture.pageIdentifier);
@@ -213,7 +208,12 @@
 float idealCurveMultiplier = m_currentGesture.accelerationCurve->frameRate() / idealCurveFrameRate;
 buildOffsetTableWithInitialDelta(*event.rawPlatformDelta() * idealCurveMultiplier);
 
-dispatchSyntheticMomentumEvent(WebWheelEvent::PhaseBegan, consumeDeltaForCurrentTime());
+WebCore::FloatSize consumedDelta = event.delta();
+if (m_currentGesture.initiatingEvent->directionInvertedFromDevice())
+consumedDelta.scale(-1);
+m_currentGesture.currentOffset += consumedDelta;
+
+dispatchSyntheticMomentumEvent(WebWheelEvent::PhaseBegan, event.delta());
 }
 
 void MomentumEventDispatcher::didEndMomentumPhase()


Modified: trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h (286998 => 286999)

--- trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h	2021-12-14 01:38:11 UTC (rev 286998)
+++ trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h	2021-12-14 01:50:21 UTC (rev 286999)
@@ -123,7 +123,6 @@
 HistoricalDeltas m_deltaHistoryY;
 
 std::optional m_lastScrollTimestamp;
-WallTime m_lastEndedEventTimestamp;
 

[webkit-changes] [286998] trunk/JSTests

[ysuzuki]

Title: [286998] trunk/JSTests








Revision 286998
Author ysuz...@apple.com
Date 2021-12-13 17:38:11 -0800 (Mon, 13 Dec 2021)


Log Message
[JSC] Update Intl tests based on ICU 69~
https://bugs.webkit.org/show_bug.cgi?id=234276

Reviewed by Mark Lam.

Rebaseline Intl tests based on ICU 69~'s CLDR update.

* stress/array-toLocaleString.js:
* stress/date-toLocaleString.js:
* stress/intl-canonical-locale-alias-mapping.js:
(Intl.getCanonicalLocales):
* stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js:
(vm.icuVersion):
* stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js:
* stress/intl-datetimeformat.js:
* stress/intl-enumeration.js:
* stress/intl-locale-info.js:
(shouldBe):
* stress/intl-locale.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/array-toLocaleString.js
trunk/JSTests/stress/date-toLocaleString.js
trunk/JSTests/stress/intl-canonical-locale-alias-mapping.js
trunk/JSTests/stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js
trunk/JSTests/stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js
trunk/JSTests/stress/intl-datetimeformat.js
trunk/JSTests/stress/intl-enumeration.js
trunk/JSTests/stress/intl-locale-info.js
trunk/JSTests/stress/intl-locale.js




Diff

Modified: trunk/JSTests/ChangeLog (286997 => 286998)

--- trunk/JSTests/ChangeLog	2021-12-14 01:06:05 UTC (rev 286997)
+++ trunk/JSTests/ChangeLog	2021-12-14 01:38:11 UTC (rev 286998)
@@ -1,3 +1,25 @@
+2021-12-13  Yusuke Suzuki  
+
+[JSC] Update Intl tests based on ICU 69~
+https://bugs.webkit.org/show_bug.cgi?id=234276
+
+Reviewed by Mark Lam.
+
+Rebaseline Intl tests based on ICU 69~'s CLDR update.
+
+* stress/array-toLocaleString.js:
+* stress/date-toLocaleString.js:
+* stress/intl-canonical-locale-alias-mapping.js:
+(Intl.getCanonicalLocales):
+* stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js:
+(vm.icuVersion):
+* stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js:
+* stress/intl-datetimeformat.js:
+* stress/intl-enumeration.js:
+* stress/intl-locale-info.js:
+(shouldBe):
+* stress/intl-locale.js:
+
 2021-12-10  Yusuke Suzuki  
 
 Unreviewed, we may not throw an stack overflow error


Modified: trunk/JSTests/stress/array-toLocaleString.js (286997 => 286998)

--- trunk/JSTests/stress/array-toLocaleString.js	2021-12-14 01:06:05 UTC (rev 286997)
+++ trunk/JSTests/stress/array-toLocaleString.js	2021-12-14 01:38:11 UTC (rev 286998)
@@ -38,4 +38,4 @@
 
 // Test that parameters are passed through properly.
 shouldThrow(() => [ new Date ].toLocaleString('i'), RangeError);
-shouldBe([ new Date(NaN), new Date(0) ].toLocaleString('zh-Hans-CN-u-nu-hanidec', { timeZone: 'UTC' }), 'Invalid Date,一九七〇/一/一 上午一二:〇〇:〇〇');
+shouldBe([ new Date(NaN), new Date(0) ].toLocaleString('zh-Hans-CN-u-nu-hanidec', { timeZone: 'UTC' }), $vm.icuVersion() >= 69 ? 'Invalid Date,一九七〇/一/一 〇〇:〇〇:〇〇' : 'Invalid Date,一九七〇/一/一 上午一二:〇〇:〇〇');


Modified: trunk/JSTests/stress/date-toLocaleString.js (286997 => 286998)

--- trunk/JSTests/stress/date-toLocaleString.js	2021-12-14 01:06:05 UTC (rev 286997)
+++ trunk/JSTests/stress/date-toLocaleString.js	2021-12-14 01:38:11 UTC (rev 286998)
@@ -44,8 +44,8 @@
 // Test for DateTimeFormat behavior.
 // Test that locale parameter is passed through properly.
 shouldThrow(() => new Date().toLocaleString('i'), RangeError);
-shouldBe(new Date(0).toLocaleString('zh-Hans-CN-u-nu-hanidec', { timeZone: 'UTC' }), '一九七〇/一/一 上午一二:〇〇:〇〇');
-shouldBe(new Date(0).toLocaleString('zh-Hans-CN', { timeZone: 'UTC', numberingSystem: 'hanidec' }), '一九七〇/一/一 上午一二:〇〇:〇〇');
+shouldBe(new Date(0).toLocaleString('zh-Hans-CN-u-nu-hanidec', { timeZone: 'UTC' }), $vm.icuVersion() >= 69 ? '一九七〇/一/一 〇〇:〇〇:〇〇' : '一九七〇/一/一 上午一二:〇〇:〇〇');
+shouldBe(new Date(0).toLocaleString('zh-Hans-CN', { timeZone: 'UTC', numberingSystem: 'hanidec' }), $vm.icuVersion() >= 69 ? '一九七〇/一/一 〇〇:〇〇:〇〇' : '一九七〇/一/一 上午一二:〇〇:〇〇');
 shouldBe(new Date(0).toLocaleString('en-u-ca-chinese', { timeZone: 'UTC', year: 'numeric' }), '1969(ji-you)');
 shouldBe(new Date(0).toLocaleString('en', { timeZone: 'UTC', year: 'numeric', calendar: 'chinese' }), '1969(ji-you)');
 
@@ -124,8 +124,8 @@
 // Test for DateTimeFormat behavior.
 // Test that locale parameter is passed through properly.
 shouldThrow(() => new Date().toLocaleTimeString('i'), RangeError);
-shouldBe(new Date(0).toLocaleTimeString('zh-Hans-CN-u-nu-hanidec', { timeZone: 'UTC' }), "上午一二:〇〇:〇〇");
-shouldBe(new Date(0).toLocaleTimeString('zh-Hans-CN', { timeZone: 'UTC', numberingSystem: 'hanidec' }), "上午一二:〇〇:〇〇");
+shouldBe(new Date(0).toLocaleTimeString('zh-Hans-CN-u-nu-hanidec', { timeZone: 'UTC' }), $vm.icuVersion() >= 69 ? "〇〇:〇〇:〇〇" : "上午一二:〇〇:〇〇");
+shouldBe(new Date(0).toLocaleTimeString('zh-Hans-CN', { timeZone: 'UTC', numberingSystem: 'hanidec' }), $vm.icuVersion() >= 69 ? "〇〇:〇〇:〇〇" : 

[webkit-changes] [286997] trunk/LayoutTests

[jenner]

Title: [286997] trunk/LayoutTests








Revision 286997
Author jen...@apple.com
Date 2021-12-13 17:06:05 -0800 (Mon, 13 Dec 2021)


Log Message
[ iOS ] 8 imported/w3c/web-platform-tests/fetch/api (layout-tests) are flaky text failures
https://bugs.webkit.org/show_bug.cgi?id=234278

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (286996 => 286997)

--- trunk/LayoutTests/ChangeLog	2021-12-14 01:00:15 UTC (rev 286996)
+++ trunk/LayoutTests/ChangeLog	2021-12-14 01:06:05 UTC (rev 286997)
@@ -1,3 +1,12 @@
+2021-12-13  Robert Jenner  
+
+[ iOS ] 8 imported/w3c/web-platform-tests/fetch/api (layout-tests) are flaky text failures
+https://bugs.webkit.org/show_bug.cgi?id=234278
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-12-13  J Pascoe  
 
 [WebAuthn] Allow same-site, cross-origin iframe get()


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (286996 => 286997)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-12-14 01:00:15 UTC (rev 286996)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-12-14 01:06:05 UTC (rev 286997)
@@ -2252,4 +2252,14 @@
 
 # webkit.org/b/234090 The two folloing tests are constant failures on iOS15 and EWS
 media/track/track-webvtt-no-snap-to-lines-overlap.html [ ImageOnlyFailure ]
-media/track/track-webvtt-snap-to-lines-left-right.html [ ImageOnlyFailure ]
\ No newline at end of file
+media/track/track-webvtt-snap-to-lines-left-right.html [ ImageOnlyFailure ]
+
+# webkit.org/b/234278 The following 8 tests are flakey failures on iOS 15
+imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-frame.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-iframe.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/fetch/api/request/request-reset-attributes.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286996] branches/safari-613.1.11-branch/Source/JavaScriptCore

[repstein]

Title: [286996] branches/safari-613.1.11-branch/Source/_javascript_Core








Revision 286996
Author repst...@apple.com
Date 2021-12-13 17:00:15 -0800 (Mon, 13 Dec 2021)


Log Message
Revert r286382. rdar://problem/86408710

Modified Paths

branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureChain.cpp




Diff

Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog (286995 => 286996)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog	2021-12-14 00:44:36 UTC (rev 286995)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/ChangeLog	2021-12-14 01:00:15 UTC (rev 286996)
@@ -1,3 +1,7 @@
+2021-12-13  Alan Coon  
+
+Revert r286382. rdar://problem/86408710
+
 2021-12-03  Keith Miller  
 
 Remove StructureIDBlob


Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureChain.cpp (286995 => 286996)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureChain.cpp	2021-12-14 00:44:36 UTC (rev 286995)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/runtime/StructureChain.cpp	2021-12-14 01:00:15 UTC (rev 286996)
@@ -49,7 +49,6 @@
 ++size; // Sentinel nullptr.
 size_t bytes = Checked(size) * sizeof(StructureID);
 void* vector = vm.jsValueGigacageAuxiliarySpace().allocateNonVirtual(vm, bytes, nullptr, AllocationFailureMode::Assert);
-static_assert(!StructureID().bits(), "Make sure the value we're going to memcpy below matches the default StructureID");
 memset(vector, 0, bytes);
 StructureChain* chain = new (NotNull, allocateCell(vm)) StructureChain(vm, vm.structureChainStructure.get(), static_cast(vector));
 chain->finishCreation(vm, head);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286995] branches/safari-613.1.11-branch/Source

[repstein]

Title: [286995] branches/safari-613.1.11-branch/Source








Revision 286995
Author repst...@apple.com
Date 2021-12-13 16:44:36 -0800 (Mon, 13 Dec 2021)


Log Message
Versioning.

WebKit-7613.1.11.5

Modified Paths

branches/safari-613.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (286994 => 286995)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-12-14 00:27:48 UTC (rev 286994)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-12-14 00:44:36 UTC (rev 286995)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (286994 => 286995)

--- branches/safari-613.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-12-14 00:27:48 UTC (rev 286994)
+++ branches/safari-613.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-12-14 00:44:36 UTC (rev 286995)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (286994 => 286995)

--- branches/safari-613.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-12-14 00:27:48 UTC (rev 286994)
+++ branches/safari-613.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-12-14 00:44:36 UTC (rev 286995)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/WebCore/Configurations/Version.xcconfig (286994 => 286995)

--- branches/safari-613.1.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-12-14 00:27:48 UTC (rev 286994)
+++ branches/safari-613.1.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-12-14 00:44:36 UTC (rev 286995)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (286994 => 286995)

--- branches/safari-613.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-12-14 00:27:48 UTC (rev 286994)
+++ branches/safari-613.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-12-14 00:44:36 UTC (rev 286995)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig (286994 => 286995)

--- branches/safari-613.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig	2021-12-14 00:27:48 UTC (rev 286994)
+++ branches/safari-613.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig	2021-12-14 00:44:36 UTC (rev 286995)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (286994 => 286995)

--- branches/safari-613.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-12-14 00:27:48 UTC (rev 286994)
+++ branches/safari-613.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-12-14 00:44:36 UTC (rev 286995)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;

[webkit-changes] [286993] trunk

[j_pascoe]

Title: [286993] trunk








Revision 286993
Author j_pas...@apple.com
Date 2021-12-13 15:58:25 -0800 (Mon, 13 Dec 2021)


Log Message
[WebAuthn] Allow same-site, cross-origin iframe get()
https://bugs.webkit.org/show_bug.cgi?id=234180
rdar://85161142

Reviewed by Brent Fulgham.

Source/WebCore:

The Web Authentication level 2 specifies a feature policy to allow get calls in
cross-origin i-frames. This patch implements this feature policy partially. Only
same-site, cross-origin i-frames are supported instead. This is for tracking prevention
purposes. https://w3c.github.io/webauthn/#sctn-iframe-guidance

This patch also starts passing ClientDataJSON hashes to ASC to avoid the situation
where WebKit includes crossOrigin or other fields in ClientDataJSON that ASC is
unaware of when generating ClientDataJSON.

Added layout test cases for same-site, cross-origin get calls.

* Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
(WebCore::doesHaveSameSiteAsAncestors):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):
* Modules/webauthn/WebAuthenticationUtils.cpp:
(WebCore::buildClientDataJson):
* Modules/webauthn/WebAuthenticationUtils.h:
* html/FeaturePolicy.cpp:
(WebCore::policyTypeName):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):
* html/FeaturePolicy.h:

Source/WebKit:

The Web Authentication level 2 specifies a feature policy to allow get calls in
cross-origin i-frames. This patch implements this feature policy partially. Only
same-site, cross-origin i-frames are supported instead. This is for tracking prevention
purposes. https://w3c.github.io/webauthn/#sctn-iframe-guidance

This patch also starts passing ClientDataJSON hashes to ASC to avoid the situation
where WebKit includes crossOrigin or other fields in ClientDataJSON that ASC is
unaware of when generating ClientDataJSON.

Added layout test cases for same-site, cross-origin get calls.

* Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(produceClientDataJson):
* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::configureRegistrationRequestContext):
(WebKit::configurationAssertionRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::contextForRequest):

LayoutTests:

Add layout test for WebAuthn get assertions on cross-site, same-sites i-frames with
publickey-credentials-get feature policy.

* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt:
* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
* http/wpt/webauthn/resources/util.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html
trunk/LayoutTests/http/wpt/webauthn/resources/util.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp
trunk/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h
trunk/Source/WebCore/html/FeaturePolicy.cpp
trunk/Source/WebCore/html/FeaturePolicy.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm


Added Paths

trunk/LayoutTests/http/wpt/webauthn/resources/samesite-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (286992 => 286993)

--- trunk/LayoutTests/ChangeLog	2021-12-13 23:56:13 UTC (rev 286992)
+++ trunk/LayoutTests/ChangeLog	2021-12-13 23:58:25 UTC (rev 286993)
@@ -1,3 +1,18 @@
+2021-12-13  J Pascoe  
+
+[WebAuthn] Allow same-site, cross-origin iframe get()
+https://bugs.webkit.org/show_bug.cgi?id=234180
+rdar://85161142
+
+Reviewed by Brent Fulgham.
+
+Add layout test for WebAuthn get assertions on cross-site, same-sites i-frames with
+publickey-credentials-get feature policy.
+
+* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt:
+* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
+* http/wpt/webauthn/resources/util.js:
+
 2021-12-13  Ryan Haddad  
 
 Unreviewed test gardening for rdar://80334322, rebaseline tests for Monterey.


Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt (286992 => 286993)

--- 

[webkit-changes] [286992] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [286992] trunk/Source/_javascript_Core








Revision 286992
Author ysuz...@apple.com
Date 2021-12-13 15:56:13 -0800 (Mon, 13 Dec 2021)


Log Message
[JSC] Use FixedVector for wasm exception in Wasm::Instance
https://bugs.webkit.org/show_bug.cgi?id=234224

Reviewed by Saam Barati.

Since we know # of exception tags when instantiating Wasm::Instance,
we can use FixedVector instead of Vector. This is the same to Table,
Functions etc.

We also remove Wasm::Tag::m_id. Since we do not copy Wasm::Tag and
we always allocate Wasm::Tag from heap, we can just use pointer
comparison. Then, we do not need to have this m_id.

* wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::setTag):
(JSC::Wasm::Instance::addTag): Deleted.
* wasm/WasmInstance.h:
* wasm/WasmModuleInformation.h:
(JSC::Wasm::ModuleInformation::internalExceptionCount const):
* wasm/WasmTag.cpp:
* wasm/WasmTag.h:
(JSC::Wasm::Tag::create): Deleted.
(JSC::Wasm::Tag::parameterCount const): Deleted.
(JSC::Wasm::Tag::parameter const): Deleted.
(JSC::Wasm::Tag::operator== const): Deleted.
(JSC::Wasm::Tag::operator!= const): Deleted.
(JSC::Wasm::Tag::signature const): Deleted.
(JSC::Wasm::Tag::Tag): Deleted.
* wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::initializeImportsAndExports):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmInstance.cpp
trunk/Source/_javascript_Core/wasm/WasmInstance.h
trunk/Source/_javascript_Core/wasm/WasmModuleInformation.h
trunk/Source/_javascript_Core/wasm/WasmTag.cpp
trunk/Source/_javascript_Core/wasm/WasmTag.h
trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (286991 => 286992)

--- trunk/Source/_javascript_Core/ChangeLog	2021-12-13 23:49:02 UTC (rev 286991)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-12-13 23:56:13 UTC (rev 286992)
@@ -1,3 +1,37 @@
+2021-12-13  Yusuke Suzuki  
+
+[JSC] Use FixedVector for wasm exception in Wasm::Instance
+https://bugs.webkit.org/show_bug.cgi?id=234224
+
+Reviewed by Saam Barati.
+
+Since we know # of exception tags when instantiating Wasm::Instance,
+we can use FixedVector instead of Vector. This is the same to Table,
+Functions etc.
+
+We also remove Wasm::Tag::m_id. Since we do not copy Wasm::Tag and
+we always allocate Wasm::Tag from heap, we can just use pointer
+comparison. Then, we do not need to have this m_id.
+
+* wasm/WasmInstance.cpp:
+(JSC::Wasm::Instance::Instance):
+(JSC::Wasm::Instance::setTag):
+(JSC::Wasm::Instance::addTag): Deleted.
+* wasm/WasmInstance.h:
+* wasm/WasmModuleInformation.h:
+(JSC::Wasm::ModuleInformation::internalExceptionCount const):
+* wasm/WasmTag.cpp:
+* wasm/WasmTag.h:
+(JSC::Wasm::Tag::create): Deleted.
+(JSC::Wasm::Tag::parameterCount const): Deleted.
+(JSC::Wasm::Tag::parameter const): Deleted.
+(JSC::Wasm::Tag::operator== const): Deleted.
+(JSC::Wasm::Tag::operator!= const): Deleted.
+(JSC::Wasm::Tag::signature const): Deleted.
+(JSC::Wasm::Tag::Tag): Deleted.
+* wasm/js/WebAssemblyModuleRecord.cpp:
+(JSC::WebAssemblyModuleRecord::initializeImportsAndExports):
+
 2021-12-13  waddlesplash  
 
 ExecutableAllocator: Do not store things in g_config when USE(SYSTEM_MALLOC).


Modified: trunk/Source/_javascript_Core/wasm/WasmInstance.cpp (286991 => 286992)

--- trunk/Source/_javascript_Core/wasm/WasmInstance.cpp	2021-12-13 23:49:02 UTC (rev 286991)
+++ trunk/Source/_javascript_Core/wasm/WasmInstance.cpp	2021-12-13 23:56:13 UTC (rev 286992)
@@ -58,6 +58,7 @@
 , m_numImportFunctions(m_module->moduleInformation().importFunctionCount())
 , m_passiveElements(m_module->moduleInformation().elementCount())
 , m_passiveDataSegments(m_module->moduleInformation().dataSegmentsCount())
+, m_tags(m_module->moduleInformation().exceptionIndexSpaceSize())
 {
 for (unsigned i = 0; i < m_numImportFunctions; ++i)
 new (importFunctionInfo(i)) ImportFunctionInfo();
@@ -300,16 +301,11 @@
 m_linkedGlobals.set(i, WTFMove(global));
 }
 
-void Instance::addTag(const Tag& tag)
+void Instance::setTag(unsigned index, Ref&& tag)
 {
-m_tags.append(Ref { tag });
+m_tags[index] = WTFMove(tag);
 }
 
-void Instance::addTag(Ref&& tag)
-{
-m_tags.append(WTFMove(tag));
-}
-
 } } // namespace JSC::Wasm
 
 #endif // ENABLE(WEBASSEMBLY)


Modified: trunk/Source/_javascript_Core/wasm/WasmInstance.h (286991 => 286992)

--- trunk/Source/_javascript_Core/wasm/WasmInstance.h	2021-12-13 23:49:02 UTC (rev 286991)
+++ trunk/Source/_javascript_Core/wasm/WasmInstance.h	2021-12-13 23:56:13 UTC (rev 286992)
@@ -209,9 +209,8 @@
 m_storeTopCallFrame(callFrame);
 }
 
-void addTag(const Tag&);
-void addTag(Ref&&);
 const Tag& tag(unsigned i) 

[webkit-changes] [286991] branches/safari-612-branch/Source/WebKit

[alancoon]

Title: [286991] branches/safari-612-branch/Source/WebKit








Revision 286991
Author alanc...@apple.com
Date 2021-12-13 15:49:02 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286919. rdar://problem/86247557

Momentum Event Dispatcher: Tail frames are the wrong velocity if momentum event dispatch rate doesn't match screen refresh rate
https://bugs.webkit.org/show_bug.cgi?id=234168


Reviewed by Simon Fraser.

In r286671, I scaled the tail frames into the momentum event disaptch
rate, but they are actually always dispatched at display refresh
frequency. In many cases these things are the same, but in some
cases can differ (most commonly a 120Hz display with 60Hz event dispatch),
so to always have the tail move at the right rate, scale into the display
refresh rate instead).

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowScreenDidChange):
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::pageScreenDidChange):
* WebProcess/WebPage/EventDispatcher.h:
* WebProcess/WebPage/EventDispatcher.messages.in:
* WebProcess/WebPage/MomentumEventDispatcher.cpp:
(WebKit::MomentumEventDispatcher::didStartMomentumPhase):
(WebKit::MomentumEventDispatcher::displayProperties const):
(WebKit::MomentumEventDispatcher::startDisplayLink):
(WebKit::MomentumEventDispatcher::stopDisplayLink):
(WebKit::MomentumEventDispatcher::pageScreenDidChange):
(WebKit::MomentumEventDispatcher::displayWasRefreshed):
(WebKit::MomentumEventDispatcher::displayID const): Deleted.
* WebProcess/WebPage/MomentumEventDispatcher.h:
Plumb and store the nominal display refresh rate.

(WebKit::MomentumEventDispatcher::buildOffsetTableWithInitialDelta):
Scale the tail frames from the 60Hz ideal rate into the display refresh
rate, instead of the event dispatch rate.

Incoming events still scale *in* from the event dispatch rate, since
that's... the rate they come at.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/EventDispatcher.h
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/EventDispatcher.messages.in
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h




Diff

Modified: branches/safari-612-branch/Source/WebKit/ChangeLog (286990 => 286991)

--- branches/safari-612-branch/Source/WebKit/ChangeLog	2021-12-13 23:45:36 UTC (rev 286990)
+++ branches/safari-612-branch/Source/WebKit/ChangeLog	2021-12-13 23:49:02 UTC (rev 286991)
@@ -1,5 +1,88 @@
 2021-12-13  Alan Coon  
 
+Cherry-pick r286919. rdar://problem/86247557
+
+Momentum Event Dispatcher: Tail frames are the wrong velocity if momentum event dispatch rate doesn't match screen refresh rate
+https://bugs.webkit.org/show_bug.cgi?id=234168
+
+
+Reviewed by Simon Fraser.
+
+In r286671, I scaled the tail frames into the momentum event disaptch
+rate, but they are actually always dispatched at display refresh
+frequency. In many cases these things are the same, but in some
+cases can differ (most commonly a 120Hz display with 60Hz event dispatch),
+so to always have the tail move at the right rate, scale into the display
+refresh rate instead).
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::windowScreenDidChange):
+* WebProcess/WebPage/EventDispatcher.cpp:
+(WebKit::EventDispatcher::pageScreenDidChange):
+* WebProcess/WebPage/EventDispatcher.h:
+* WebProcess/WebPage/EventDispatcher.messages.in:
+* WebProcess/WebPage/MomentumEventDispatcher.cpp:
+(WebKit::MomentumEventDispatcher::didStartMomentumPhase):
+(WebKit::MomentumEventDispatcher::displayProperties const):
+(WebKit::MomentumEventDispatcher::startDisplayLink):
+(WebKit::MomentumEventDispatcher::stopDisplayLink):
+(WebKit::MomentumEventDispatcher::pageScreenDidChange):
+(WebKit::MomentumEventDispatcher::displayWasRefreshed):
+(WebKit::MomentumEventDispatcher::displayID const): Deleted.
+* WebProcess/WebPage/MomentumEventDispatcher.h:
+Plumb and store the nominal display refresh rate.
+
+(WebKit::MomentumEventDispatcher::buildOffsetTableWithInitialDelta):
+Scale the tail frames from the 60Hz ideal rate into the display refresh
+rate, instead of the event dispatch rate.
+
+Incoming events still scale *in* from the event dispatch rate, since
+that's... the rate they come at.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286919 

[webkit-changes] [286990] trunk/LayoutTests

[ryanhaddad]

Title: [286990] trunk/LayoutTests








Revision 286990
Author ryanhad...@apple.com
Date 2021-12-13 15:45:36 -0800 (Mon, 13 Dec 2021)


Log Message
Unreviewed test gardening for rdar://80334322, rebaseline tests for Monterey.

* platform/mac-bigsur/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
* platform/mac-bigsur/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
* platform/mac-wk1/TestExpectations:
* platform/mac/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
* platform/mac/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations


Added Paths

trunk/LayoutTests/platform/mac/fast/events/wheel/
trunk/LayoutTests/platform/mac/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt
trunk/LayoutTests/platform/mac/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt
trunk/LayoutTests/platform/mac-bigsur/fast/events/
trunk/LayoutTests/platform/mac-bigsur/fast/events/wheel/
trunk/LayoutTests/platform/mac-bigsur/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt
trunk/LayoutTests/platform/mac-bigsur/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (286989 => 286990)

--- trunk/LayoutTests/ChangeLog	2021-12-13 23:41:49 UTC (rev 286989)
+++ trunk/LayoutTests/ChangeLog	2021-12-13 23:45:36 UTC (rev 286990)
@@ -1,5 +1,15 @@
 2021-12-13  Ryan Haddad  
 
+Unreviewed test gardening for rdar://80334322, rebaseline tests for Monterey.
+
+* platform/mac-bigsur/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
+* platform/mac-bigsur/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
+* platform/mac-wk1/TestExpectations:
+* platform/mac/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
+* platform/mac/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
+
+2021-12-13  Ryan Haddad  
+
 LFC][IFC] Add partial unicode-bidi support on inline level boxes
 https://bugs.webkit.org/show_bug.cgi?id=234196
 


Added: trunk/LayoutTests/platform/mac/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt (0 => 286990)

--- trunk/LayoutTests/platform/mac/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt	2021-12-13 23:45:36 UTC (rev 286990)
@@ -0,0 +1,3 @@
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."
+window.scrollX: -120
+window.scrollY: 80


Added: trunk/LayoutTests/platform/mac/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt (0 => 286990)

--- trunk/LayoutTests/platform/mac/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt	2021-12-13 23:45:36 UTC (rev 286990)
@@ -0,0 +1,3 @@
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."
+window.scrollX: 80
+window.scrollY: -120


Added: trunk/LayoutTests/platform/mac-bigsur/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt (0 => 286990)

--- trunk/LayoutTests/platform/mac-bigsur/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-bigsur/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt	2021-12-13 23:45:36 UTC (rev 286990)
@@ -0,0 +1,3 @@
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non 

[webkit-changes] [286989] branches/safari-612-branch/Source/WebCore/page/scrolling/ ScrollingTreeScrollingNode.h

[alancoon]

Title: [286989] branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h








Revision 286989
Author alanc...@apple.com
Date 2021-12-13 15:41:49 -0800 (Mon, 13 Dec 2021)


Log Message
Unreviewed build fix. rdar://problem/86385697

./page/scrolling/ThreadedScrollingTree.cpp:452:19: error: 'updateScrollPositionAtLastDisplayRefresh' is a protected member of 'WebCore::ScrollingTreeScrollingNode'

Modified Paths

branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h




Diff

Modified: branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h (286988 => 286989)

--- branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h	2021-12-13 23:31:19 UTC (rev 286988)
+++ branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h	2021-12-13 23:41:49 UTC (rev 286989)
@@ -45,6 +45,7 @@
 friend class ScrollingTreeScrollingNodeDelegateMac;
 #endif
 friend class ScrollingTree;
+friend class ThreadedScrollingTree;
 
 public:
 virtual ~ScrollingTreeScrollingNode();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286988] trunk

[commit-queue]

Title: [286988] trunk








Revision 286988
Author commit-qu...@webkit.org
Date 2021-12-13 15:31:19 -0800 (Mon, 13 Dec 2021)


Log Message
A FormData constructed in the form's submit event listener shouldn't include the submitter
https://bugs.webkit.org/show_bug.cgi?id=234069

Patch by Andreu Botella  on 2021-12-13
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt:

Source/WebCore:

In the HTML spec, the "construct the entry list" algorithm takes an optional `submitter`
argument which it uses to determine whether a button should be included in the entry list.
The FormData constructor calls it with no optional arguments, so `new FormData(form)` should
never contain any buttons.

In WebKit, however, if a `FormData` object is constructed in the form's `submit` event
listener, it will contain the submitter button, if the form submission wasn't implicit. This
is because whether a form control is the submitter is tracked on the control, and activating
it sets that state for the duration of the form submission algorithm.

However, the form submission algorithm also sets a submitter's state, to deal with implicit
submissions. This is set only for the duration of the "construct the entry list" call, and
so there is no need to set the state when activating the button.

Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set.html

* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::defaultEventHandler):
* html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent):
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::handleDOMActivateEvent):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLButtonElement.cpp
trunk/Source/WebCore/html/ImageInputType.cpp
trunk/Source/WebCore/html/SubmitInputType.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (286987 => 286988)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-12-13 23:14:37 UTC (rev 286987)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-12-13 23:31:19 UTC (rev 286988)
@@ -1,3 +1,12 @@
+2021-12-13  Andreu Botella  
+
+A FormData constructed in the form's submit event listener shouldn't include the submitter
+https://bugs.webkit.org/show_bug.cgi?id=234069
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt:
+
 2021-12-13  Antti Koivisto  
 
 [CSS Cascade Layers] Layers specified in import rules can not be reordered on media query evaluation


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt (286987 => 286988)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt	2021-12-13 23:14:37 UTC (rev 286987)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt	2021-12-13 23:31:19 UTC (rev 286988)
@@ -21,5 +21,5 @@
 PASS "formData" IDL attribute should have entries for form-associated elements in the first event handler, and the second handler can read entries set by the first handler.
 PASS Entries added to "formData" IDL attribute should be submitted.
 PASS Entries added to the "formdata" IDL attribute shouldn't be newline normalized in the resulting FormData
-FAIL The constructed FormData object should not contain an entry for the submit button that was used to submit the form. assert_false: expected false got true
+PASS The constructed FormData object should not contain an entry for the submit button that was used to submit the form.
 


Modified: trunk/Source/WebCore/ChangeLog (286987 => 286988)

--- trunk/Source/WebCore/ChangeLog	2021-12-13 23:14:37 UTC (rev 286987)
+++ trunk/Source/WebCore/ChangeLog	2021-12-13 23:31:19 UTC (rev 286988)
@@ -1,3 +1,33 @@
+2021-12-13  Andreu Botella  
+
+A FormData constructed in the form's submit event listener shouldn't include the submitter
+https://bugs.webkit.org/show_bug.cgi?id=234069
+
+Reviewed by Chris Dumez.
+
+In the HTML spec, the "construct the entry list" algorithm takes an optional `submitter`
+argument which it uses to determine whether a button should be included in the entry list.
+The FormData constructor calls it with no optional arguments, so `new FormData(form)` should
+never contain any buttons.
+
+In WebKit, however, if a `FormData` object is constructed in the form's `submit` event
+listener, it will contain the submitter button, if the form submission wasn't implicit. This
+is because 

[webkit-changes] [286987] trunk/Source/WTF

[graouts]

Title: [286987] trunk/Source/WTF








Revision 286987
Author grao...@webkit.org
Date 2021-12-13 15:14:37 -0800 (Mon, 13 Dec 2021)


Log Message
CustomEffect and animation frame rate should be disabled by default in STP
https://bugs.webkit.org/show_bug.cgi?id=234251

Reviewed by Dean Jackson.

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml




Diff

Modified: trunk/Source/WTF/ChangeLog (286986 => 286987)

--- trunk/Source/WTF/ChangeLog	2021-12-13 23:01:31 UTC (rev 286986)
+++ trunk/Source/WTF/ChangeLog	2021-12-13 23:14:37 UTC (rev 286987)
@@ -1,3 +1,12 @@
+2021-12-13  Antoine Quint  
+
+CustomEffect and animation frame rate should be disabled by default in STP
+https://bugs.webkit.org/show_bug.cgi?id=234251
+
+Reviewed by Dean Jackson.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+
 2021-12-13  Chris Dumez  
 
 Unreviewed build fix after r286971.


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (286986 => 286987)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-12-13 23:01:31 UTC (rev 286986)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-12-13 23:14:37 UTC (rev 286987)
@@ -1503,7 +1503,6 @@
 WebKitLegacy:
   default: false
 WebKit:
-  "ENABLE(EXPERIMENTAL_FEATURES)" : true
   default: false
 WebCore:
   default: false
@@ -1516,7 +1515,6 @@
 WebKitLegacy:
   default: false
 WebKit:
-  "ENABLE(EXPERIMENTAL_FEATURES)" : true
   default: false
 WebCore:
   default: false






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286986] trunk/Source/WTF

[cdumez]

Title: [286986] trunk/Source/WTF








Revision 286986
Author cdu...@apple.com
Date 2021-12-13 15:01:31 -0800 (Mon, 13 Dec 2021)


Log Message
Unreviewed build fix after r286971.

* wtf/spi/darwin/dyldSPI.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h




Diff

Modified: trunk/Source/WTF/ChangeLog (286985 => 286986)

--- trunk/Source/WTF/ChangeLog	2021-12-13 22:51:23 UTC (rev 286985)
+++ trunk/Source/WTF/ChangeLog	2021-12-13 23:01:31 UTC (rev 286986)
@@ -1,5 +1,11 @@
 2021-12-13  Chris Dumez  
 
+Unreviewed build fix after r286971.
+
+* wtf/spi/darwin/dyldSPI.h:
+
+2021-12-13  Chris Dumez  
+
 Regression(r283565) Unable to report private messages as Spam in Twitter app
 https://bugs.webkit.org/show_bug.cgi?id=234253
 


Modified: trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h (286985 => 286986)

--- trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h	2021-12-13 22:51:23 UTC (rev 286985)
+++ trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h	2021-12-13 23:01:31 UTC (rev 286986)
@@ -73,6 +73,10 @@
 #define DYLD_IOS_VERSION_15_0 0x000f
 #endif
 
+#ifndef DYLD_IOS_VERSION_15_4
+#define DYLD_IOS_VERSION_15_4 0x000f0400
+#endif
+
 #ifndef DYLD_IOS_VERSION_16_0
 #define DYLD_IOS_VERSION_16_0 0x0010
 #endif
@@ -109,6 +113,10 @@
 #define DYLD_MACOSX_VERSION_12_00 0x000c
 #endif
 
+#ifndef DYLD_MACOSX_VERSION_12_3
+#define DYLD_MACOSX_VERSION_12_3 0x000c0300
+#endif
+
 #ifndef DYLD_MACOSX_VERSION_13_0
 #define DYLD_MACOSX_VERSION_13_0 0x000d
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286985] trunk/Source/WebInspectorUI

[drousso]

Title: [286985] trunk/Source/WebInspectorUI








Revision 286985
Author drou...@apple.com
Date 2021-12-13 14:51:23 -0800 (Mon, 13 Dec 2021)


Log Message
Web Inspector: remove coloring of Web Inspector area in dock icons
https://bugs.webkit.org/show_bug.cgi?id=234262

Reviewed by Patrick Angle.

It looks too strong/bold and draws way too much attention. It also doesn't match the styling
of other nearby icons.

* UserInterface/Images/DockBottom.svg:
* UserInterface/Images/DockLeft.svg:
* UserInterface/Images/DockRight.svg:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Images/DockBottom.svg
trunk/Source/WebInspectorUI/UserInterface/Images/DockLeft.svg
trunk/Source/WebInspectorUI/UserInterface/Images/DockRight.svg




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (286984 => 286985)

--- trunk/Source/WebInspectorUI/ChangeLog	2021-12-13 22:50:09 UTC (rev 286984)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-12-13 22:51:23 UTC (rev 286985)
@@ -1,3 +1,17 @@
+2021-12-13  Devin Rousso  
+
+Web Inspector: remove coloring of Web Inspector area in dock icons
+https://bugs.webkit.org/show_bug.cgi?id=234262
+
+Reviewed by Patrick Angle.
+
+It looks too strong/bold and draws way too much attention. It also doesn't match the styling
+of other nearby icons.
+
+* UserInterface/Images/DockBottom.svg:
+* UserInterface/Images/DockLeft.svg:
+* UserInterface/Images/DockRight.svg:
+
 2021-12-13  Elliott Williams  
 
 Deployment target for macOS 11+ does not follow minor version bumps


Modified: trunk/Source/WebInspectorUI/UserInterface/Images/DockBottom.svg (286984 => 286985)

--- trunk/Source/WebInspectorUI/UserInterface/Images/DockBottom.svg	2021-12-13 22:50:09 UTC (rev 286984)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/DockBottom.svg	2021-12-13 22:51:23 UTC (rev 286985)
@@ -2,5 +2,5 @@
 
 
 
-
+
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Images/DockLeft.svg (286984 => 286985)

--- trunk/Source/WebInspectorUI/UserInterface/Images/DockLeft.svg	2021-12-13 22:50:09 UTC (rev 286984)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/DockLeft.svg	2021-12-13 22:51:23 UTC (rev 286985)
@@ -1,6 +1,6 @@
 
 
 
-
+
 
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Images/DockRight.svg (286984 => 286985)

--- trunk/Source/WebInspectorUI/UserInterface/Images/DockRight.svg	2021-12-13 22:50:09 UTC (rev 286984)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/DockRight.svg	2021-12-13 22:51:23 UTC (rev 286985)
@@ -2,5 +2,5 @@
 
 
 
-
+
 
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286984] branches/safari-612-branch/Source/WebCore

[alancoon]

Title: [286984] branches/safari-612-branch/Source/WebCore








Revision 286984
Author alanc...@apple.com
Date 2021-12-13 14:50:09 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286907. rdar://problem/86307593

[Cocoa] -[AVPlayerItem liveUpdateInterval] can hang the main thread for ~60ms
https://bugs.webkit.org/show_bug.cgi?id=234131

Reviewed by Eric Carlson.

Direct property access of AVFoundation objects can take tens of milliseconds to return
a value, even for simple properties. This impacts scrolling responsiveness.

-liveUpdateInterval is not KVO-observable, but only changes when -seekableTimeRanges does
as well. Query and cache that property during KVO of -seekableTimeRanges.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesLastModifiedTime const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::liveUpdateInterval const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (286983 => 286984)

--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-13 22:34:44 UTC (rev 286983)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-13 22:50:09 UTC (rev 286984)
@@ -1,5 +1,49 @@
 2021-12-13  Alan Coon  
 
+Cherry-pick r286907. rdar://problem/86307593
+
+[Cocoa] -[AVPlayerItem liveUpdateInterval] can hang the main thread for ~60ms
+https://bugs.webkit.org/show_bug.cgi?id=234131
+
+Reviewed by Eric Carlson.
+
+Direct property access of AVFoundation objects can take tens of milliseconds to return
+a value, even for simple properties. This impacts scrolling responsiveness.
+
+-liveUpdateInterval is not KVO-observable, but only changes when -seekableTimeRanges does
+as well. Query and cache that property during KVO of -seekableTimeRanges.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesLastModifiedTime const):
+(WebCore::MediaPlayerPrivateAVFoundationObjC::liveUpdateInterval const):
+(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
+(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-11  Jer Noble  
+
+[Cocoa] -[AVPlayerItem liveUpdateInterval] can hang the main thread for ~60ms
+https://bugs.webkit.org/show_bug.cgi?id=234131
+
+Reviewed by Eric Carlson.
+
+Direct property access of AVFoundation objects can take tens of milliseconds to return
+a value, even for simple properties. This impacts scrolling responsiveness.
+
+-liveUpdateInterval is not KVO-observable, but only changes when -seekableTimeRanges does
+as well. Query and cache that property during KVO of -seekableTimeRanges.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesLastModifiedTime const):
+(WebCore::MediaPlayerPrivateAVFoundationObjC::liveUpdateInterval const):
+(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
+(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
+
+2021-12-13  Alan Coon  
+
 Cherry-pick r286905. rdar://problem/86235740
 
 Scrolling can drop frames when CoreAnimation commits take a long time


Modified: branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h (286983 => 286984)

--- branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h	2021-12-13 22:34:44 UTC (rev 286983)
+++ branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h	2021-12-13 22:50:09 UTC (rev 286984)
@@ -50,6 +50,7 @@
 
 typedef struct CGImage *CGImageRef;
 typedef 

[webkit-changes] [286982] trunk/Source/WebCore

[commit-queue]

Title: [286982] trunk/Source/WebCore








Revision 286982
Author commit-qu...@webkit.org
Date 2021-12-13 14:32:42 -0800 (Mon, 13 Dec 2021)


Log Message
Unreviewed, reverting r283354.
https://bugs.webkit.org/show_bug.cgi?id=234273

causes missing content with clip-path

Reverted changeset:

"[Performance] Optimize
RenderLayer::clipCrossesPaintingBoundary"
https://bugs.webkit.org/show_bug.cgi?id=230885
https://commits.webkit.org/r283354

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (286981 => 286982)

--- trunk/Source/WebCore/ChangeLog	2021-12-13 22:19:24 UTC (rev 286981)
+++ trunk/Source/WebCore/ChangeLog	2021-12-13 22:32:42 UTC (rev 286982)
@@ -1,3 +1,17 @@
+2021-12-13  Commit Queue  
+
+Unreviewed, reverting r283354.
+https://bugs.webkit.org/show_bug.cgi?id=234273
+
+causes missing content with clip-path
+
+Reverted changeset:
+
+"[Performance] Optimize
+RenderLayer::clipCrossesPaintingBoundary"
+https://bugs.webkit.org/show_bug.cgi?id=230885
+https://commits.webkit.org/r283354
+
 2021-12-13  Alejandro G. Castro  
 
 [GTK] Fix ANGLE compilation


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (286981 => 286982)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2021-12-13 22:19:24 UTC (rev 286981)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2021-12-13 22:32:42 UTC (rev 286982)
@@ -1935,19 +1935,18 @@
 return nullptr;
 }
 
-static RenderLayer* repaintTargetForLayer(const RenderLayer& layer)
+RenderLayer* RenderLayer::enclosingCompositingLayerForRepaint(IncludeSelfOrNot includeSelf) const
 {
-if (compositedWithOwnBackingStore(layer))
-return const_cast();
+auto repaintTargetForLayer = [](const RenderLayer& layer) -> RenderLayer* {
+if (compositedWithOwnBackingStore(layer))
+return const_cast();
+
+if (layer.paintsIntoProvidedBacking())
+return layer.backingProviderLayer();
+
+return nullptr;
+};
 
-if (layer.paintsIntoProvidedBacking())
-return layer.backingProviderLayer();
-
-return nullptr;
-}
-
-RenderLayer* RenderLayer::enclosingCompositingLayerForRepaint(IncludeSelfOrNot includeSelf) const
-{
 RenderLayer* repaintTarget = nullptr;
 if (includeSelf == IncludeSelf && (repaintTarget = repaintTargetForLayer(*this)))
 return repaintTarget;
@@ -1960,18 +1959,6 @@
 return nullptr;
 }
 
-bool RenderLayer::sharesCompositingLayerForRepaint(const RenderLayer& otherLayer) const
-{
-if (repaintTargetForLayer(*this))
-return false;
-
-const RenderLayer* paintParent = paintOrderParent();
-if ( == paintParent)
-return true;
-auto* otherPaintParent = otherLayer.paintOrderParent();
-return paintParent == otherPaintParent || this == otherPaintParent;
-}
-
 RenderLayer* RenderLayer::enclosingFilterLayer(IncludeSelfOrNot includeSelf) const
 {
 const RenderLayer* curr = (includeSelf == IncludeSelf) ? this : parent();
@@ -4469,11 +4456,8 @@
 
 bool RenderLayer::clipCrossesPaintingBoundary() const
 {
-auto* parentLayer = parent();
-if (!sharesCompositingLayerForRepaint(*parentLayer))
-return true;
-
-return parentLayer->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers);
+return parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers)
+|| parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();
 }
 
 void RenderLayer::calculateClipRects(const ClipRectsContext& clipRectsContext, ClipRects& clipRects) const


Modified: trunk/Source/WebCore/rendering/RenderLayer.h (286981 => 286982)

--- trunk/Source/WebCore/rendering/RenderLayer.h	2021-12-13 22:19:24 UTC (rev 286981)
+++ trunk/Source/WebCore/rendering/RenderLayer.h	2021-12-13 22:32:42 UTC (rev 286982)
@@ -587,7 +587,6 @@
 // Enclosing compositing layer; if includeSelf is true, may return this.
 RenderLayer* enclosingCompositingLayer(IncludeSelfOrNot = IncludeSelf) const;
 RenderLayer* enclosingCompositingLayerForRepaint(IncludeSelfOrNot = IncludeSelf) const;
-bool sharesCompositingLayerForRepaint(const RenderLayer& otherLayer) const;
 // Ancestor compositing layer, excluding this.
 RenderLayer* ancestorCompositingLayer() const { return enclosingCompositingLayer(ExcludeSelf); }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286981] trunk/LayoutTests

[ryanhaddad]

Title: [286981] trunk/LayoutTests








Revision 286981
Author ryanhad...@apple.com
Date 2021-12-13 14:19:24 -0800 (Mon, 13 Dec 2021)


Log Message
LFC][IFC] Add partial unicode-bidi support on inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=234196

Unreviewed test gardening.

* platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Rebaseline test for iOS.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (286980 => 286981)

--- trunk/LayoutTests/ChangeLog	2021-12-13 22:04:49 UTC (rev 286980)
+++ trunk/LayoutTests/ChangeLog	2021-12-13 22:19:24 UTC (rev 286981)
@@ -1,3 +1,12 @@
+2021-12-13  Ryan Haddad  
+
+LFC][IFC] Add partial unicode-bidi support on inline level boxes
+https://bugs.webkit.org/show_bug.cgi?id=234196
+
+Unreviewed test gardening.
+
+* platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Rebaseline test for iOS.
+
 2021-12-13  Robert Jenner  
 
 REGRESSION (r286259): [ BigSur+ wk1 ] 2X imported/w3c/web-platform-tests/speech-api/SpeechSynthesis (layout-tests) are constant text failures


Modified: trunk/LayoutTests/platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt (286980 => 286981)

--- trunk/LayoutTests/platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt	2021-12-13 22:04:49 UTC (rev 286980)
+++ trunk/LayoutTests/platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt	2021-12-13 22:19:24 UTC (rev 286981)
@@ -86,25 +86,22 @@
 RenderText {#text} at (0,0) size 50x19
   text run at (0,0) width 50 RTL: "\x{5D3}\x{5D4}\x{5D5}([\x{202A}\x{202C}\x{5D0}\x{5D1}\x{5D2}"
   RenderBlock {P} at (0,444) size 784x20
-RenderText {#text} at (0,0) size 30x19
-  text run at (0,0) width 19 RTL: "\x{5D3}\x{5D4}\x{5D5}"
-  text run at (18,0) width 12: "(["
-RenderInline {SPAN} at (0,0) size 1x19
-RenderText {#text} at (29,0) size 21x19
-  text run at (29,0) width 21 RTL: "\x{5D0}\x{5D1}\x{5D2}"
+RenderText {#text} at (20,0) size 30x19
+  text run at (20,0) width 30 RTL: "\x{5D3}\x{5D4}\x{5D5}(["
+RenderInline {SPAN} at (0,0) size 0x19
+RenderText {#text} at (0,0) size 21x19
+  text run at (0,0) width 21 RTL: "\x{5D0}\x{5D1}\x{5D2}"
   RenderBlock {P} at (0,480) size 784x20
-RenderText {#text} at (0,0) size 30x19
-  text run at (0,0) width 19 RTL: "\x{5D3}\x{5D4}\x{5D5}"
-  text run at (18,0) width 12: "(["
-RenderInline {SPAN} at (0,0) size 1x19
-  RenderInline {SPAN} at (0,0) size 1x19
-RenderText {#text} at (29,0) size 21x19
-  text run at (29,0) width 21 RTL: "\x{5D0}\x{5D1}\x{5D2}"
+RenderText {#text} at (20,0) size 30x19
+  text run at (20,0) width 30 RTL: "\x{5D3}\x{5D4}\x{5D5}(["
+RenderInline {SPAN} at (0,0) size 0x19
+  RenderInline {SPAN} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 21x19
+  text run at (0,0) width 21 RTL: "\x{5D0}\x{5D1}\x{5D2}"
   RenderBlock {P} at (0,516) size 784x20
-RenderText {#text} at (0,0) size 30x19
-  text run at (0,0) width 19 RTL: "\x{5D3}\x{5D4}\x{5D5}"
-  text run at (18,0) width 12: "(["
-RenderInline {SPAN} at (0,0) size 21x19
-  RenderInline {SPAN} at (0,0) size 1x19
-RenderText {#text} at (29,0) size 21x19
-  text run at (29,0) width 21 RTL: "\x{5D0}\x{5D1}\x{5D2}"
+RenderText {#text} at (20,0) size 30x19
+  text run at (20,0) width 30 RTL: "\x{5D3}\x{5D4}\x{5D5}(["
+RenderInline {SPAN} at (0,0) size 0x19
+  RenderInline {SPAN} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 21x19
+  text run at (0,0) width 21 RTL: "\x{5D0}\x{5D1}\x{5D2}"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286980] trunk/LayoutTests

[jenner]

Title: [286980] trunk/LayoutTests








Revision 286980
Author jen...@apple.com
Date 2021-12-13 14:04:49 -0800 (Mon, 13 Dec 2021)


Log Message
REGRESSION (r286259): [ BigSur+ wk1 ] 2X imported/w3c/web-platform-tests/speech-api/SpeechSynthesis (layout-tests) are constant text failures
https://bugs.webkit.org/show_bug.cgi?id=234105

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (286979 => 286980)

--- trunk/LayoutTests/ChangeLog	2021-12-13 21:21:07 UTC (rev 286979)
+++ trunk/LayoutTests/ChangeLog	2021-12-13 22:04:49 UTC (rev 286980)
@@ -1,3 +1,12 @@
+2021-12-13  Robert Jenner  
+
+REGRESSION (r286259): [ BigSur+ wk1 ] 2X imported/w3c/web-platform-tests/speech-api/SpeechSynthesis (layout-tests) are constant text failures
+https://bugs.webkit.org/show_bug.cgi?id=234105
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-12-13  Youenn Fablet  
 
 FetchResponse::clone should use the relevant realm for the cloned response


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (286979 => 286980)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-12-13 21:21:07 UTC (rev 286979)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-12-13 22:04:49 UTC (rev 286980)
@@ -1525,3 +1525,7 @@
 
 # The DocumentTimeline.maximumFrameRate property which this test is about is only available in WK2.
 webanimations/frame-rate/document-timeline-maximum-frame-rate.html [ Skip ]
+
+# webkit.org/b/234105 Skip 2 imported/w3c/web-platform-tests/speech-api/SpeechSynthesis in mac wk1. 
+[ Catalina+ ] imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events.html [ Skip ]
+[ Catalina+ ] imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-pause-resume.tentative.html [ Skip ] 
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286979] trunk/Source/WebKit

[pvollan]

Title: [286979] trunk/Source/WebKit








Revision 286979
Author pvol...@apple.com
Date 2021-12-13 13:21:07 -0800 (Mon, 13 Dec 2021)


Log Message
[WP][iOS] Add access to required system call
https://bugs.webkit.org/show_bug.cgi?id=234232


Reviewed by Brent Fulgham.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (286978 => 286979)

--- trunk/Source/WebKit/ChangeLog	2021-12-13 21:16:28 UTC (rev 286978)
+++ trunk/Source/WebKit/ChangeLog	2021-12-13 21:21:07 UTC (rev 286979)
@@ -1,3 +1,13 @@
+2021-12-13  Per Arne Vollan  
+
+[WP][iOS] Add access to required system call
+https://bugs.webkit.org/show_bug.cgi?id=234232
+
+
+Reviewed by Brent Fulgham.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
 2021-12-13  Chris Dumez  
 
 Regression(r283565) Unable to report private messages as Spam in Twitter app


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (286978 => 286979)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-13 21:16:28 UTC (rev 286978)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-13 21:21:07 UTC (rev 286979)
@@ -1307,6 +1307,7 @@
 SYS_socket
 SYS_thread_selfusage
 SYS_unlink
+SYS_write
 SYS_writev))
 
 (define (syscall-unix-rarely-in-use-need-backtrace)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286978] trunk/Source

[commit-queue]

Title: [286978] trunk/Source








Revision 286978
Author commit-qu...@webkit.org
Date 2021-12-13 13:16:28 -0800 (Mon, 13 Dec 2021)


Log Message
[GTK] Fix ANGLE compilation
https://bugs.webkit.org/show_bug.cgi?id=233327

Patch by Alejandro G. Castro  on 2021-12-13
Reviewed by Kenneth Russell.

Source/ThirdParty/ANGLE:

There is a define with a typo in the name and activating EGL and
X11 does not work at the same time.

* PlatformGTK.cmake:

Source/WebCore:

No tests required.

Fixed the issues to make the engine work with -DUSE_ANGLE_WEBGL=ON
defined.

* platform/graphics/GLContext.cpp:
(WebCore::initializeOpenGLShimsIfNeeded): In case of GTK and WPE
initially we are going to keep TextureMapper using system GL
libraries, even when we are using ANGLE for WebGL, so we need the
shims definitions.
* platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:
(Nicosia::GCGLLayer::swapBuffersIfNeeded): We need to allocate and
update the layer buffer in the compositor thread to make sure it
is handled in just one thread.

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/PlatformGTK.cmake
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GLContext.cpp
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h
trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp
trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (286977 => 286978)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-13 20:57:05 UTC (rev 286977)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-13 21:16:28 UTC (rev 286978)
@@ -1,3 +1,15 @@
+2021-12-13  Alejandro G. Castro  
+
+[GTK] Fix ANGLE compilation
+https://bugs.webkit.org/show_bug.cgi?id=233327
+
+Reviewed by Kenneth Russell.
+
+There is a define with a typo in the name and activating EGL and
+X11 does not work at the same time.
+
+* PlatformGTK.cmake:
+
 2021-12-13  Kyle Piddington  
 
 [MacCatalyst] fix iOSMac after refactor in r286899


Modified: trunk/Source/ThirdParty/ANGLE/PlatformGTK.cmake (286977 => 286978)

--- trunk/Source/ThirdParty/ANGLE/PlatformGTK.cmake	2021-12-13 20:57:05 UTC (rev 286977)
+++ trunk/Source/ThirdParty/ANGLE/PlatformGTK.cmake	2021-12-13 21:16:28 UTC (rev 286978)
@@ -48,10 +48,6 @@
 list(APPEND GTK_ANGLE_DEFINITIONS ANGLE_USE_X11)
 endif ()
 
-if (ENABLE_WAYLAND_TARGET)
-list(APPEND GKT_ANGLE_DEFINITIONS WL_EGL_PLATFORM)
-endif ()
-
 # Allow building ANGLE on platforms which may not provide X11 headers.
 if (NOT GTK_ANGLE_DEFINITIONS)
 list(APPEND GTK_ANGLE_DEFINITIONS USE_SYSTEM_EGL)


Modified: trunk/Source/WebCore/ChangeLog (286977 => 286978)

--- trunk/Source/WebCore/ChangeLog	2021-12-13 20:57:05 UTC (rev 286977)
+++ trunk/Source/WebCore/ChangeLog	2021-12-13 21:16:28 UTC (rev 286978)
@@ -1,3 +1,25 @@
+2021-12-13  Alejandro G. Castro  
+
+[GTK] Fix ANGLE compilation
+https://bugs.webkit.org/show_bug.cgi?id=233327
+
+Reviewed by Kenneth Russell.
+
+No tests required.
+
+Fixed the issues to make the engine work with -DUSE_ANGLE_WEBGL=ON
+defined.
+
+* platform/graphics/GLContext.cpp:
+(WebCore::initializeOpenGLShimsIfNeeded): In case of GTK and WPE
+initially we are going to keep TextureMapper using system GL
+libraries, even when we are using ANGLE for WebGL, so we need the
+shims definitions.
+* platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:
+(Nicosia::GCGLLayer::swapBuffersIfNeeded): We need to allocate and
+update the layer buffer in the compositor thread to make sure it
+is handled in just one thread.
+
 2021-12-13  Antti Koivisto  
 
 [CSS Cascade Layers] Layers specified in import rules can not be reordered on media query evaluation


Modified: trunk/Source/WebCore/platform/graphics/GLContext.cpp (286977 => 286978)

--- trunk/Source/WebCore/platform/graphics/GLContext.cpp	2021-12-13 20:57:05 UTC (rev 286977)
+++ trunk/Source/WebCore/platform/graphics/GLContext.cpp	2021-12-13 21:16:28 UTC (rev 286978)
@@ -58,7 +58,7 @@
 
 static bool initializeOpenGLShimsIfNeeded()
 {
-#if USE(OPENGL_ES) || USE(LIBEPOXY) || USE(ANGLE)
+#if USE(OPENGL_ES) || USE(LIBEPOXY) || (USE(ANGLE) && !(PLATFORM(GTK) || PLATFORM(WPE)))
 return true;
 #else
 static bool initialized = false;


Modified: trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h (286977 => 286978)

--- trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h	2021-12-13 20:57:05 UTC (rev 286977)
+++ trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h	2021-12-13 21:16:28 UTC (rev 286978)
@@ -42,6 +42,7 @@
 
 #if USE(NICOSIA)
 namespace Nicosia {
+class GCGLANGLELayer;
 class GCGLLayer;
 }
 #endif
@@ -445,7 +446,7 @@
 GCGLuint m_intermediateTexture 

[webkit-changes] [286977] branches/safari-612-branch/Source

[alancoon]

Title: [286977] branches/safari-612-branch/Source








Revision 286977
Author alanc...@apple.com
Date 2021-12-13 12:57:05 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286905. rdar://problem/86235740

Scrolling can drop frames when CoreAnimation commits take a long time
https://bugs.webkit.org/show_bug.cgi?id=234160


Reviewed by Tim Horton.

In r261985 I added a mechanism that has the scrolling thread wait for the main thread to
finish a rendering update, and, if the main thread fails to complete in time, then the
scrolling thread commits. This allows for scrolling synchronization when the main thread is
responsive, but smooth scrolling when the main thread is busy.

However, r261985 only waits for WebKit work to finish; what we really care about is whether
the main thread completes its CA commit in time (because that determines whether the scroll
shows on the screen).

So plumb through pre-/post-commit hooks from TiledCoreAnimationDrawingArea, which already
had them for inspector instrumentation. Then have ThreadedScrollingTree notify
m_stateCondition in didCompletePlatformRenderingUpdate(), instead of
didCompleteRenderingUpdate().
Source/WebCore:

Also, now we can call the inspector hooks from Page, rather than out in TiledCoreAnimationDrawingArea.

* page/Page.cpp:
(WebCore::Page::willStartPlatformRenderingUpdate):
(WebCore::Page::didCompletePlatformRenderingUpdate):
* page/Page.h:
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::willStartPlatformRenderingUpdate):
(WebCore::ScrollingCoordinator::didCompletePlatformRenderingUpdate):
* page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::didCompletePlatformRenderingUpdate):
(WebCore::ThreadedScrollingTree::didCompleteRenderingUpdate): Deleted.
* page/scrolling/ThreadedScrollingTree.h:
* page/scrolling/mac/ScrollingCoordinatorMac.h:
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::didCompletePlatformRenderingUpdate):

Source/WebKit:

Also, now we can call the inspector hooks from Page, rather than out in TiledCoreAnimationDrawingArea.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willStartPlatformRenderingUpdate):
(WebKit::WebPage::didCompletePlatformRenderingUpdate):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/page/Page.cpp
branches/safari-612-branch/Source/WebCore/page/Page.h
branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingCoordinator.h
branches/safari-612-branch/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp
branches/safari-612-branch/Source/WebCore/page/scrolling/ThreadedScrollingTree.h
branches/safari-612-branch/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h
branches/safari-612-branch/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm
branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/WebPage.h
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (286976 => 286977)

--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-13 20:57:00 UTC (rev 286976)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-13 20:57:05 UTC (rev 286977)
@@ -1,5 +1,99 @@
 2021-12-13  Alan Coon  
 
+Cherry-pick r286905. rdar://problem/86235740
+
+Scrolling can drop frames when CoreAnimation commits take a long time
+https://bugs.webkit.org/show_bug.cgi?id=234160
+
+
+Reviewed by Tim Horton.
+
+In r261985 I added a mechanism that has the scrolling thread wait for the main thread to
+finish a rendering update, and, if the main thread fails to complete in time, then the
+scrolling thread commits. This allows for scrolling synchronization when the main thread is
+responsive, but smooth scrolling when the main thread is busy.
+
+However, r261985 only waits for WebKit work to finish; what we really care about is whether
+the main thread completes its CA commit in time (because that determines whether the scroll
+shows on the screen).
+
+So plumb through pre-/post-commit hooks from TiledCoreAnimationDrawingArea, which already
+had them for inspector instrumentation. Then have ThreadedScrollingTree notify
+m_stateCondition in didCompletePlatformRenderingUpdate(), instead of
+didCompleteRenderingUpdate().
+

[webkit-changes] [286976] branches/safari-612-branch/Source/WebKit

[alancoon]

Title: [286976] branches/safari-612-branch/Source/WebKit








Revision 286976
Author alanc...@apple.com
Date 2021-12-13 12:57:00 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286834. rdar://problem/86427901

Inspector "composite" events are all very short
https://bugs.webkit.org/show_bug.cgi?id=234114


Reviewed by Tim Horton.

The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
time to include painting so use kCATransactionPhasePreLayout.

* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: branches/safari-612-branch/Source/WebKit/ChangeLog (286975 => 286976)

--- branches/safari-612-branch/Source/WebKit/ChangeLog	2021-12-13 20:56:57 UTC (rev 286975)
+++ branches/safari-612-branch/Source/WebKit/ChangeLog	2021-12-13 20:57:00 UTC (rev 286976)
@@ -1,5 +1,42 @@
 2021-12-13  Alan Coon  
 
+Cherry-pick r286834. rdar://problem/86235740
+
+Inspector "composite" events are all very short
+https://bugs.webkit.org/show_bug.cgi?id=234114
+
+
+Reviewed by Tim Horton.
+
+The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
+time to include painting so use kCATransactionPhasePreLayout.
+
+* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
+(WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-09  Simon Fraser  
+
+Inspector "composite" events are all very short
+https://bugs.webkit.org/show_bug.cgi?id=234114
+
+
+Reviewed by Tim Horton.
+
+The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
+time to include painting so use kCATransactionPhasePreLayout.
+
+* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
+(WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
+
+2021-12-13  Alan Coon  
+
 Cherry-pick r286858. rdar://problem/86423741
 
 Use simpler idioms for std::less and std::greater possible in modern C++


Modified: branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm (286975 => 286976)

--- branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm	2021-12-13 20:56:57 UTC (rev 286975)
+++ branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm	2021-12-13 20:57:00 UTC (rev 286976)
@@ -293,7 +293,7 @@
 if (Frame* coreFrame = retainedPage->mainFrame())
 corePage->inspectorController().willComposite(*coreFrame);
 }
-} forPhase:kCATransactionPhasePreCommit];
+} forPhase:kCATransactionPhasePreLayout];
 
 [CATransaction addCommitHandler:[retainedPage = makeRefPtr(_webPage)] {
 if (Page* corePage = retainedPage->corePage()) {


Modified: branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (286975 => 286976)

--- branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2021-12-13 20:56:57 UTC (rev 286975)
+++ branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2021-12-13 20:57:00 UTC (rev 286976)
@@ -426,7 +426,7 @@
 if (Frame* coreFrame = retainedPage->mainFrame())
 corePage->inspectorController().willComposite(*coreFrame);
 }
-} forPhase:kCATransactionPhasePreCommit];
+} forPhase:kCATransactionPhasePreLayout];
 
 [CATransaction addCommitHandler:[retainedPage = makeRefPtr(_webPage)] {
 if (Page* corePage = retainedPage->corePage()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286975] branches/safari-612-branch/Source/WebCore

[alancoon]

Title: [286975] branches/safari-612-branch/Source/WebCore








Revision 286975
Author alanc...@apple.com
Date 2021-12-13 12:56:57 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286932. rdar://problem/86385697

Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
https://bugs.webkit.org/show_bug.cgi?id=234213

Reviewed by Tim Horton.

On a page where CA commits on the main thread take a long time (e.g. because of expensive
painting), it's possible that the main thread has updated the scrolling layer position, and
then the scrolling thread detects that the commit is taking a long time and attempts to
trigger its own commit, but because the layer position property doesn't change, no commit
occurs.

Work around this by setting the layer position to 0,0 and back when we're on the scrolling
thread. Only do this if the scroll position changed since the last display refresh to avoid
triggering redundant commits.

Ideally we'd traverse the scrolling tree and do this for every scrolling node, but scrolling
trees can get large so for now just apply this to the root node.

* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateScrollPositionAtLastDisplayRefresh):
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):
(WebCore::ThreadedScrollingTree::storeScrollPositionsAtLastDisplayRefresh):
* page/scrolling/ThreadedScrollingTree.h:
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionScrollingLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp
branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
branches/safari-612-branch/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp
branches/safari-612-branch/Source/WebCore/page/scrolling/ThreadedScrollingTree.h
branches/safari-612-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm




Diff

Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (286974 => 286975)

--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-13 20:56:53 UTC (rev 286974)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-13 20:56:57 UTC (rev 286975)
@@ -1,5 +1,69 @@
 2021-12-13  Alan Coon  
 
+Cherry-pick r286932. rdar://problem/86385697
+
+Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
+https://bugs.webkit.org/show_bug.cgi?id=234213
+
+Reviewed by Tim Horton.
+
+On a page where CA commits on the main thread take a long time (e.g. because of expensive
+painting), it's possible that the main thread has updated the scrolling layer position, and
+then the scrolling thread detects that the commit is taking a long time and attempts to
+trigger its own commit, but because the layer position property doesn't change, no commit
+occurs.
+
+Work around this by setting the layer position to 0,0 and back when we're on the scrolling
+thread. Only do this if the scroll position changed since the last display refresh to avoid
+triggering redundant commits.
+
+Ideally we'd traverse the scrolling tree and do this for every scrolling node, but scrolling
+trees can get large so for now just apply this to the root node.
+
+* page/scrolling/ScrollingTreeScrollingNode.cpp:
+(WebCore::ScrollingTreeScrollingNode::updateScrollPositionAtLastDisplayRefresh):
+* page/scrolling/ScrollingTreeScrollingNode.h:
+* page/scrolling/ThreadedScrollingTree.cpp:
+(WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):
+(WebCore::ThreadedScrollingTree::storeScrollPositionsAtLastDisplayRefresh):
+* page/scrolling/ThreadedScrollingTree.h:
+* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionScrollingLayers):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-12  Simon Fraser  
+
+Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
+https://bugs.webkit.org/show_bug.cgi?id=234213
+
+Reviewed by Tim Horton.
+
+On a page where CA commits on the main thread take a long time (e.g. because of expensive
+painting), it's possible that the main thread has updated the scrolling layer position, and
+then the scrolling thread detects that the commit is taking a 

[webkit-changes] [286973] branches/safari-612-branch/Source/WebKit

[alancoon]

Title: [286973] branches/safari-612-branch/Source/WebKit








Revision 286973
Author alanc...@apple.com
Date 2021-12-13 12:56:48 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286900. rdar://problem/86344954

Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher
https://bugs.webkit.org/show_bug.cgi?id=234189


Reviewed by Simon Fraser.

* Shared/mac/ScrollingAccelerationCurveMac.mm:
(WebKit::fromIOHIDDevice):
Fix the FIXME here about the additional fallback values; it turns out
Magic Mouse is one device that does not have a value for
kIOHIDScrollAccelerationTypeKey, so we need the full fallback chain to support it.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendWheelEvent):
Un-wrapping this optional results in losing the engaged state, and sending
a garbage ScrollingAccelerationCurve across the wire.
The message argument is also an optional, so just pass it along.

The result of this bug was that if you had ever used a device with a curve
for a given page, and then used a device with no curve, MomentumEventDispatcher
would have a garbage curve (from this message trying to "unset" the optional),
and a garbage curve results in chaotic scrolling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm
branches/safari-612-branch/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: branches/safari-612-branch/Source/WebKit/ChangeLog (286972 => 286973)

--- branches/safari-612-branch/Source/WebKit/ChangeLog	2021-12-13 20:38:56 UTC (rev 286972)
+++ branches/safari-612-branch/Source/WebKit/ChangeLog	2021-12-13 20:56:48 UTC (rev 286973)
@@ -1,3 +1,58 @@
+2021-12-13  Alan Coon  
+
+Cherry-pick r286900. rdar://problem/86344954
+
+Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher
+https://bugs.webkit.org/show_bug.cgi?id=234189
+
+
+Reviewed by Simon Fraser.
+
+* Shared/mac/ScrollingAccelerationCurveMac.mm:
+(WebKit::fromIOHIDDevice):
+Fix the FIXME here about the additional fallback values; it turns out
+Magic Mouse is one device that does not have a value for
+kIOHIDScrollAccelerationTypeKey, so we need the full fallback chain to support it.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::sendWheelEvent):
+Un-wrapping this optional results in losing the engaged state, and sending
+a garbage ScrollingAccelerationCurve across the wire.
+The message argument is also an optional, so just pass it along.
+
+The result of this bug was that if you had ever used a device with a curve
+for a given page, and then used a device with no curve, MomentumEventDispatcher
+would have a garbage curve (from this message trying to "unset" the optional),
+and a garbage curve results in chaotic scrolling.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-10  Tim Horton  
+
+Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher
+https://bugs.webkit.org/show_bug.cgi?id=234189
+
+
+Reviewed by Simon Fraser.
+
+* Shared/mac/ScrollingAccelerationCurveMac.mm:
+(WebKit::fromIOHIDDevice):
+Fix the FIXME here about the additional fallback values; it turns out
+Magic Mouse is one device that does not have a value for
+kIOHIDScrollAccelerationTypeKey, so we need the full fallback chain to support it.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::sendWheelEvent):
+Un-wrapping this optional results in losing the engaged state, and sending
+a garbage ScrollingAccelerationCurve across the wire.
+The message argument is also an optional, so just pass it along.
+
+The result of this bug was that if you had ever used a device with a curve
+for a given page, and then used a device with no curve, MomentumEventDispatcher
+would have a garbage curve (from this message trying to "unset" the optional),
+and a garbage curve results in chaotic scrolling.
+
 2021-12-09  Alan Coon  
 
 Cherry-pick r286805. rdar://problem/86291413


Modified: branches/safari-612-branch/Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm (286972 => 286973)

--- branches/safari-612-branch/Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm	2021-12-13 20:38:56 UTC (rev 286972)
+++ branches/safari-612-branch/Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm	2021-12-13 20:56:48 UTC (rev 286973)
@@ -116,26 +116,37 @@
 return std::nullopt;
 }
 
-// FIXME: There is some 

[webkit-changes] [286974] branches/safari-612-branch/Source

[alancoon]

Title: [286974] branches/safari-612-branch/Source








Revision 286974
Author alanc...@apple.com
Date 2021-12-13 12:56:53 -0800 (Mon, 13 Dec 2021)


Log Message
Cherry-pick r286858. rdar://problem/86423741

Use simpler idioms for std::less and std::greater possible in modern C++
https://bugs.webkit.org/show_bug.cgi?id=234117

Reviewed by Anders Carlsson.

Source/WebCore:

* testing/InternalsMapLike.cpp:
(WebCore::InternalsMapLike::inspectValues const): Remove unneeded explicit
use of std:less, because this is what std::sort by default.

Source/WebKit:

* WebProcess/WebPage/MomentumEventDispatcher.cpp:
(WebKit::MomentumEventDispatcher::equalizeTailGaps): Removed unneeded
template arguments for std::greater, and removed explicit use of std::less,
since that's what std::sort does by default.

Source/WTF:

* wtf/ListDump.h:
(WTF::sortedListDump): Removed unnecessary template arguments to std::less.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WTF/ChangeLog
branches/safari-612-branch/Source/WTF/wtf/ListDump.h
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/testing/InternalsMapLike.cpp
branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp




Diff

Modified: branches/safari-612-branch/Source/WTF/ChangeLog (286973 => 286974)

--- branches/safari-612-branch/Source/WTF/ChangeLog	2021-12-13 20:56:48 UTC (rev 286973)
+++ branches/safari-612-branch/Source/WTF/ChangeLog	2021-12-13 20:56:53 UTC (rev 286974)
@@ -1,3 +1,42 @@
+2021-12-13  Alan Coon  
+
+Cherry-pick r286858. rdar://problem/86423741
+
+Use simpler idioms for std::less and std::greater possible in modern C++
+https://bugs.webkit.org/show_bug.cgi?id=234117
+
+Reviewed by Anders Carlsson.
+
+Source/WebCore:
+
+* testing/InternalsMapLike.cpp:
+(WebCore::InternalsMapLike::inspectValues const): Remove unneeded explicit
+use of std:less, because this is what std::sort by default.
+
+Source/WebKit:
+
+* WebProcess/WebPage/MomentumEventDispatcher.cpp:
+(WebKit::MomentumEventDispatcher::equalizeTailGaps): Removed unneeded
+template arguments for std::greater, and removed explicit use of std::less,
+since that's what std::sort does by default.
+
+Source/WTF:
+
+* wtf/ListDump.h:
+(WTF::sortedListDump): Removed unnecessary template arguments to std::less.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-09  Darin Adler  
+
+Use simpler idioms for std::less and std::greater possible in modern C++
+https://bugs.webkit.org/show_bug.cgi?id=234117
+
+Reviewed by Anders Carlsson.
+
+* wtf/ListDump.h:
+(WTF::sortedListDump): Removed unnecessary template arguments to std::less.
+
 2021-12-06  Alan Coon  
 
 Cherry-pick r286537. rdar://problem/85928816


Modified: branches/safari-612-branch/Source/WTF/wtf/ListDump.h (286973 => 286974)

--- branches/safari-612-branch/Source/WTF/wtf/ListDump.h	2021-12-13 20:56:48 UTC (rev 286973)
+++ branches/safari-612-branch/Source/WTF/wtf/ListDump.h	2021-12-13 20:56:53 UTC (rev 286974)
@@ -121,7 +121,7 @@
 template
 CString sortedListDump(const T& list, const char* comma = ", ")
 {
-return sortedListDump(list, std::less(), comma);
+return sortedListDump(list, std::less<>(), comma);
 }
 
 template


Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (286973 => 286974)

--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-13 20:56:48 UTC (rev 286973)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-13 20:56:53 UTC (rev 286974)
@@ -1,3 +1,43 @@
+2021-12-13  Alan Coon  
+
+Cherry-pick r286858. rdar://problem/86423741
+
+Use simpler idioms for std::less and std::greater possible in modern C++
+https://bugs.webkit.org/show_bug.cgi?id=234117
+
+Reviewed by Anders Carlsson.
+
+Source/WebCore:
+
+* testing/InternalsMapLike.cpp:
+(WebCore::InternalsMapLike::inspectValues const): Remove unneeded explicit
+use of std:less, because this is what std::sort by default.
+
+Source/WebKit:
+
+* WebProcess/WebPage/MomentumEventDispatcher.cpp:
+(WebKit::MomentumEventDispatcher::equalizeTailGaps): Removed unneeded
+template arguments for std::greater, and removed explicit use of std::less,
+since that's what std::sort does by default.
+
+Source/WTF:
+
+* wtf/ListDump.h:
+(WTF::sortedListDump): Removed unnecessary template arguments to std::less.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-09  Darin 

[webkit-changes] [286972] trunk

[antti]

Title: [286972] trunk








Revision 286972
Author an...@apple.com
Date 2021-12-13 12:38:56 -0800 (Mon, 13 Dec 2021)


Log Message
[CSS Cascade Layers] Layers specified in import rules can not be reordered on media query evaluation
https://bugs.webkit.org/show_bug.cgi?id=234158

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-cascade/layer-media-query-expected.txt:

Source/WebCore:

* style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addChildRules):
(WebCore::Style::RuleSetBuilder::addRulesFromSheetContents):

@import rules can introduce new layers so need to alse be considered for reordering by media queries
(which requires static evaluation).

(WebCore::Style::RuleSetBuilder::disallowDynamicMediaQueryEvaluationIfNeeded):

Factor into a function.

* style/RuleSetBuilder.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-media-query-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/RuleSetBuilder.cpp
trunk/Source/WebCore/style/RuleSetBuilder.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (286971 => 286972)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-12-13 20:29:59 UTC (rev 286971)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-12-13 20:38:56 UTC (rev 286972)
@@ -1,3 +1,12 @@
+2021-12-13  Antti Koivisto  
+
+[CSS Cascade Layers] Layers specified in import rules can not be reordered on media query evaluation
+https://bugs.webkit.org/show_bug.cgi?id=234158
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/css-cascade/layer-media-query-expected.txt:
+
 2021-12-13  Sergio Villar Senin  
 
 [css-writing-modes] Use the correct margins in computeInlinePreferredLogicalWidths in orthogonal flows


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-media-query-expected.txt (286971 => 286972)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-media-query-expected.txt	2021-12-13 20:29:59 UTC (rev 286971)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-media-query-expected.txt	2021-12-13 20:38:56 UTC (rev 286972)
@@ -7,5 +7,5 @@
 PASS C1 Reordering
 PASS C2 Reordering
 PASS C3 Reordering
-FAIL C4 Reordering assert_equals: C4 Reordering expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)"
+PASS C4 Reordering
 


Modified: trunk/Source/WebCore/ChangeLog (286971 => 286972)

--- trunk/Source/WebCore/ChangeLog	2021-12-13 20:29:59 UTC (rev 286971)
+++ trunk/Source/WebCore/ChangeLog	2021-12-13 20:38:56 UTC (rev 286972)
@@ -1,3 +1,23 @@
+2021-12-13  Antti Koivisto  
+
+[CSS Cascade Layers] Layers specified in import rules can not be reordered on media query evaluation
+https://bugs.webkit.org/show_bug.cgi?id=234158
+
+Reviewed by Simon Fraser.
+
+* style/RuleSetBuilder.cpp:
+(WebCore::Style::RuleSetBuilder::addChildRules):
+(WebCore::Style::RuleSetBuilder::addRulesFromSheetContents):
+
+@import rules can introduce new layers so need to alse be considered for reordering by media queries
+(which requires static evaluation).
+
+(WebCore::Style::RuleSetBuilder::disallowDynamicMediaQueryEvaluationIfNeeded):
+
+Factor into a function.
+
+* style/RuleSetBuilder.h:
+
 2021-12-13  Chris Dumez  
 
 Regression(r283565) Unable to report private messages as Spam in Twitter app


Modified: trunk/Source/WebCore/style/RuleSetBuilder.cpp (286971 => 286972)

--- trunk/Source/WebCore/style/RuleSetBuilder.cpp	2021-12-13 20:29:59 UTC (rev 286971)
+++ trunk/Source/WebCore/style/RuleSetBuilder.cpp	2021-12-13 20:38:56 UTC (rev 286972)
@@ -110,8 +110,7 @@
 continue;
 }
 if (is(*rule)) {
-if (!m_ruleSet && !m_mediaQueryCollector.dynamicContextStack.isEmpty())
-requiresStaticMediaQueryEvaluation = true;
+disallowDynamicMediaQueryEvaluationIfNeeded();
 
 auto& layerRule = downcast(*rule);
 if (layerRule.isStatement()) {
@@ -126,8 +125,7 @@
 continue;
 }
 if (is(*rule) || is(*rule) || is(*rule)) {
-if (!m_ruleSet && !m_mediaQueryCollector.dynamicContextStack.isEmpty())
-requiresStaticMediaQueryEvaluation = true;
+disallowDynamicMediaQueryEvaluationIfNeeded();
 
 if (m_resolver)
 m_collectedResolverMutatingRules.append({ *rule, m_currentCascadeLayerIdentifier });
@@ -151,8 +149,10 @@
 
 if (m_mediaQueryCollector.pushAndEvaluate(rule->mediaQueries())) {
 auto& cascadeLayerName = rule->cascadeLayerName();
-if (cascadeLayerName)
+if (cascadeLayerName) {
+disallowDynamicMediaQueryEvaluationIfNeeded();
 pushCascadeLayer(*cascadeLayerName);
+}
 
 

[webkit-changes] [286971] trunk/Source

[cdumez]

Title: [286971] trunk/Source








Revision 286971
Author cdu...@apple.com
Date 2021-12-13 12:29:59 -0800 (Mon, 13 Dec 2021)


Log Message
Regression(r283565) Unable to report private messages as Spam in Twitter app
https://bugs.webkit.org/show_bug.cgi?id=234253


Reviewed by Alex Christensen.

Source/WebCore:

Add macro for new linkedOnOrAfter check for sending the Authorization header
on same origin redirects.

* platform/cocoa/VersionChecks.h:

Source/WebKit:

In r283565, we aligned WebKit's behavior with the Fetch specification and with
Gecko / Blink by keeping the Authorization header on same origin redirects.

However, when reporting a private message in the twitter app, it does a
same-origin redirect from `https://twitter.com/account/authenticate_web_view?...`
to `https://twitter.com/account/authenticate_web_view?...` and the HTTP server
reponds with a 401/Unauthorized when we send the Authorization on the post-redirect
request. As far as I can tell, our behavior is correct here and I suspect this is an
issue with the twitter server. As a result, I am simply gating the new behavior
behind a linked-on-or-after check to give twitter a chance to address the issue on
their end.

* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

Source/WTF:

Add some new iOS / macOS versions.

* wtf/spi/darwin/dyldSPI.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/VersionChecks.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (286970 => 286971)

--- trunk/Source/WTF/ChangeLog	2021-12-13 20:28:00 UTC (rev 286970)
+++ trunk/Source/WTF/ChangeLog	2021-12-13 20:29:59 UTC (rev 286971)
@@ -1,3 +1,15 @@
+2021-12-13  Chris Dumez  
+
+Regression(r283565) Unable to report private messages as Spam in Twitter app
+https://bugs.webkit.org/show_bug.cgi?id=234253
+
+
+Reviewed by Alex Christensen.
+
+Add some new iOS / macOS versions.
+
+* wtf/spi/darwin/dyldSPI.h:
+
 2021-12-13  Elliott Williams  
 
 Deployment target for macOS 11+ does not follow minor version bumps


Modified: trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h (286970 => 286971)

--- trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h	2021-12-13 20:28:00 UTC (rev 286970)
+++ trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h	2021-12-13 20:29:59 UTC (rev 286971)
@@ -133,6 +133,7 @@
 #define DYLD_IOS_VERSION_14_2 0x000E0200
 #define DYLD_IOS_VERSION_14_5 0x000E0500
 #define DYLD_IOS_VERSION_15_0 0x000f
+#define DYLD_IOS_VERSION_15_4 0x000f0400
 #define DYLD_IOS_VERSION_16_0 0x0010
 
 #define DYLD_MACOSX_VERSION_10_11 0x000A0B00
@@ -145,6 +146,7 @@
 #define DYLD_MACOSX_VERSION_10_16 0x000A1000
 #define DYLD_MACOSX_VERSION_11_3 0x000B0300
 #define DYLD_MACOSX_VERSION_12_00 0x000c
+#define DYLD_MACOSX_VERSION_12_3 0x000c0300
 #define DYLD_MACOSX_VERSION_13_0 0x000d
 
 #endif


Modified: trunk/Source/WebCore/ChangeLog (286970 => 286971)

--- trunk/Source/WebCore/ChangeLog	2021-12-13 20:28:00 UTC (rev 286970)
+++ trunk/Source/WebCore/ChangeLog	2021-12-13 20:29:59 UTC (rev 286971)
@@ -1,3 +1,16 @@
+2021-12-13  Chris Dumez  
+
+Regression(r283565) Unable to report private messages as Spam in Twitter app
+https://bugs.webkit.org/show_bug.cgi?id=234253
+
+
+Reviewed by Alex Christensen.
+
+Add macro for new linkedOnOrAfter check for sending the Authorization header
+on same origin redirects.
+
+* platform/cocoa/VersionChecks.h:
+
 2021-12-13  Youenn Fablet  
 
 FetchResponse::clone should use the relevant realm for the cloned response


Modified: trunk/Source/WebCore/platform/cocoa/VersionChecks.h (286970 => 286971)

--- trunk/Source/WebCore/platform/cocoa/VersionChecks.h	2021-12-13 20:28:00 UTC (rev 286970)
+++ trunk/Source/WebCore/platform/cocoa/VersionChecks.h	2021-12-13 20:29:59 UTC (rev 286971)
@@ -72,6 +72,7 @@
 FirstWithDOMWindowReuseRestriction  = DYLD_IOS_VERSION_15_0,
 FirstWithApplicationCacheDisabledByDefault = DYLD_IOS_VERSION_15_0,
 FirstWithoutExpandoIndexedPropertiesOnWindow = DYLD_IOS_VERSION_15_0,
+FirstWithAuthorizationHeaderOnSameOriginRedirects = DYLD_IOS_VERSION_15_4,
 FirstForbiddingDotPrefixedFonts = DYLD_IOS_VERSION_16_0,
 #elif PLATFORM(MAC)
 FirstThatConvertsInvalidURLsToBlank = DYLD_MACOSX_VERSION_10_12,
@@ -99,6 +100,7 @@
 FirstThatAllowsWheelEventGesturesToBecomeNonBlocking = DYLD_MACOSX_VERSION_11_3,
 FirstWithApplicationCacheDisabledByDefault = DYLD_MACOSX_VERSION_12_00,
 FirstWithoutExpandoIndexedPropertiesOnWindow = DYLD_MACOSX_VERSION_12_00,
+FirstWithAuthorizationHeaderOnSameOriginRedirects = DYLD_MACOSX_VERSION_12_3,
 FirstForbiddingDotPrefixedFonts = DYLD_MACOSX_VERSION_13_0,
 #endif
 };


Modified: trunk/Source/WebKit/ChangeLog 

[webkit-changes] [286970] trunk

[youenn]

Title: [286970] trunk








Revision 286970
Author you...@apple.com
Date 2021-12-13 12:28:00 -0800 (Mon, 13 Dec 2021)


Log Message
FetchResponse::clone should use the relevant realm for the cloned response
https://bugs.webkit.org/show_bug.cgi?id=234238

Reviewed by Alexey Shvayka.

Source/WebCore:

Reuse the relevant realm for cloning as per https://fetch.spec.whatwg.org/#dom-response-clone step 3.
If context is stopped, throw an InvalidStateError exception, like done in Chrome.

Test: http/wpt/fetch/clone-realm.html

* Modules/fetch/FetchResponse.cpp:
* Modules/fetch/FetchResponse.h:
* Modules/fetch/FetchResponse.idl:

LayoutTests:

* http/wpt/fetch/clone-realm-expected.txt: Added.
* http/wpt/fetch/clone-realm.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
trunk/Source/WebCore/Modules/fetch/FetchResponse.idl


Added Paths

trunk/LayoutTests/http/wpt/fetch/clone-realm-expected.txt
trunk/LayoutTests/http/wpt/fetch/clone-realm.html




Diff

Modified: trunk/LayoutTests/ChangeLog (286969 => 286970)

--- trunk/LayoutTests/ChangeLog	2021-12-13 20:25:56 UTC (rev 286969)
+++ trunk/LayoutTests/ChangeLog	2021-12-13 20:28:00 UTC (rev 286970)
@@ -1,3 +1,13 @@
+2021-12-13  Youenn Fablet  
+
+FetchResponse::clone should use the relevant realm for the cloned response
+https://bugs.webkit.org/show_bug.cgi?id=234238
+
+Reviewed by Alexey Shvayka.
+
+* http/wpt/fetch/clone-realm-expected.txt: Added.
+* http/wpt/fetch/clone-realm.html: Added.
+
 2021-12-13  Rob Buis  
 
 [ macOS and iOS ] editing/deleting/forward-delete-crash.html is timing out


Added: trunk/LayoutTests/http/wpt/fetch/clone-realm-expected.txt (0 => 286970)

--- trunk/LayoutTests/http/wpt/fetch/clone-realm-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/wpt/fetch/clone-realm-expected.txt	2021-12-13 20:28:00 UTC (rev 286970)
@@ -0,0 +1,3 @@
+
+PASS Cloning a response fails when its frame is detached
+


Added: trunk/LayoutTests/http/wpt/fetch/clone-realm.html (0 => 286970)

--- trunk/LayoutTests/http/wpt/fetch/clone-realm.html	(rev 0)
+++ trunk/LayoutTests/http/wpt/fetch/clone-realm.html	2021-12-13 20:28:00 UTC (rev 286970)
@@ -0,0 +1,32 @@
+
+
+
+
+
+
+