date:20211215

[webkit-changes] [287126] trunk/Source/WebCore

2021-12-15 Thread andresg_22

Title: [287126] trunk/Source/WebCore








Revision 287126
Author andresg...@apple.com
Date 2021-12-15 23:08:17 -0800 (Wed, 15 Dec 2021)


Log Message
Fix for crash in AXIsolatedObject::textMarkerRangeForNSRange.
https://bugs.webkit.org/show_bug.cgi?id=234377


Reviewed by Chris Fleizach.

Covered by accessibility/mac/textmarker-range-for-range.html.

AXIsolatedObject::textMarkerRangeForNSRange needs to autorelease the
object retrieved from the main thread. This was causing intermittent
crashes when accessing the return value off of the main thread.

* accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::textMarkerRangeForNSRange const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (287125 => 287126)

--- trunk/Source/WebCore/ChangeLog	2021-12-16 04:33:12 UTC (rev 287125)
+++ trunk/Source/WebCore/ChangeLog	2021-12-16 07:08:17 UTC (rev 287126)
@@ -1,3 +1,20 @@
+2021-12-15  Andres Gonzalez  
+
+Fix for crash in AXIsolatedObject::textMarkerRangeForNSRange.
+https://bugs.webkit.org/show_bug.cgi?id=234377
+
+
+Reviewed by Chris Fleizach.
+
+Covered by accessibility/mac/textmarker-range-for-range.html.
+
+AXIsolatedObject::textMarkerRangeForNSRange needs to autorelease the
+object retrieved from the main thread. This was causing intermittent
+crashes when accessing the return value off of the main thread.
+
+* accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
+(WebCore::AXIsolatedObject::textMarkerRangeForNSRange const):
+
 2021-12-15  Brady Eidson  
 
 Add a "NotificationData" object to encompass local Notification-related parameters, instead of passing tons of them around everywhere.


Modified: trunk/Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm (287125 => 287126)

--- trunk/Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm	2021-12-16 04:33:12 UTC (rev 287125)
+++ trunk/Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm	2021-12-16 07:08:17 UTC (rev 287126)
@@ -80,7 +80,7 @@
 
 AXTextMarkerRangeRef AXIsolatedObject::textMarkerRangeForNSRange(const NSRange& range) const
 {
-return Accessibility::retrieveValueFromMainThread([, this] () -> AXTextMarkerRangeRef {
+return Accessibility::retrieveAutoreleasedValueFromMainThread([, this] () -> RetainPtr {
 auto* axObject = associatedAXObject();
 return axObject ? axObject->textMarkerRangeForNSRange(range) : nullptr;
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287125] trunk/Source/WebKit

2021-12-15 Thread beidson

Title: [287125] trunk/Source/WebKit








Revision 287125
Author beid...@apple.com
Date 2021-12-15 20:33:12 -0800 (Wed, 15 Dec 2021)


Log Message
Some webpushtool improvements.
https://bugs.webkit.org/show_bug.cgi?id=234372

Reviewed by Alex Christensen.

- Make the list of current connections be reliably ordered
- If the invocation is solely about injecting a push message, exit afterwards
- Some other tiny niceties

* webpushd/WebPushDaemon.mm:
(WebPushD::Daemon::broadcastAllConnectionIdentities):
(WebPushD::Daemon::injectPushMessageForTesting):

* webpushd/webpushtool/WebPushToolConnection.h:
* webpushd/webpushtool/WebPushToolConnection.mm:
(WebPushTool::Connection::create):
(WebPushTool::Connection::Connection):
(WebPushTool::Connection::connectToService):
(WebPushTool::Connection::startAction):
(WebPushTool::Connection::sendPushMessage):

* webpushd/webpushtool/WebPushToolMain.mm:
(main):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/webpushd/WebPushDaemon.mm
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (287124 => 287125)

--- trunk/Source/WebKit/ChangeLog	2021-12-16 03:46:06 UTC (rev 287124)
+++ trunk/Source/WebKit/ChangeLog	2021-12-16 04:33:12 UTC (rev 287125)
@@ -1,5 +1,31 @@
 2021-12-15  Brady Eidson  
 
+Some webpushtool improvements.
+https://bugs.webkit.org/show_bug.cgi?id=234372
+
+Reviewed by Alex Christensen.
+
+- Make the list of current connections be reliably ordered
+- If the invocation is solely about injecting a push message, exit afterwards
+- Some other tiny niceties
+
+* webpushd/WebPushDaemon.mm:
+(WebPushD::Daemon::broadcastAllConnectionIdentities):
+(WebPushD::Daemon::injectPushMessageForTesting):
+
+* webpushd/webpushtool/WebPushToolConnection.h:
+* webpushd/webpushtool/WebPushToolConnection.mm:
+(WebPushTool::Connection::create):
+(WebPushTool::Connection::Connection):
+(WebPushTool::Connection::connectToService):
+(WebPushTool::Connection::startAction):
+(WebPushTool::Connection::sendPushMessage):
+
+* webpushd/webpushtool/WebPushToolMain.mm:
+(main):
+
+2021-12-15  Brady Eidson  
+
 Add a "NotificationData" object to encompass local Notification-related parameters, instead of passing tons of them around everywhere.
 https://bugs.webkit.org/show_bug.cgi?id=234370
 


Modified: trunk/Source/WebKit/webpushd/WebPushDaemon.mm (287124 => 287125)

--- trunk/Source/WebKit/webpushd/WebPushDaemon.mm	2021-12-16 03:46:06 UTC (rev 287124)
+++ trunk/Source/WebKit/webpushd/WebPushDaemon.mm	2021-12-16 04:33:12 UTC (rev 287125)
@@ -188,8 +188,14 @@
 void Daemon::broadcastAllConnectionIdentities()
 {
 broadcastDebugMessage((JSC::MessageLevel)4, "===\nCurrent connections:");
-for (auto& iterator : m_connectionMap)
-iterator.value->broadcastDebugMessage("");
+
+auto connections = copyToVector(m_connectionMap.values());
+std::sort(connections.begin(), connections.end(), [] (const Ref& a, const Ref& b) {
+return a->identifier() < b->identifier();
+});
+
+for (auto& iterator : connections)
+iterator->broadcastDebugMessage("");
 broadcastDebugMessage((JSC::MessageLevel)4, "===");
 }
 
@@ -350,7 +356,7 @@
 return;
 }
 
-connection->broadcastDebugMessage(makeString("Injected a test push messasge for ", message.targetAppCodeSigningIdentifier, " at ", message.registrationURL.string()));
+connection->broadcastDebugMessage(makeString("Injected a test push message for ", message.targetAppCodeSigningIdentifier, " at ", message.registrationURL.string()));
 connection->broadcastDebugMessage(message.message);
 
 auto addResult = m_testingPushMessages.ensure(message.targetAppCodeSigningIdentifier, [] {


Modified: trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h (287124 => 287125)

--- trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h	2021-12-16 03:46:06 UTC (rev 287124)
+++ trunk/Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h	2021-12-16 04:33:12 UTC (rev 287125)
@@ -58,8 +58,8 @@
 class Connection : public CanMakeWeakPtr {
 WTF_MAKE_FAST_ALLOCATED;
 public:
-static std::unique_ptr create(Action, PreferTestService, Reconnect);
-Connection(Action, PreferTestService, Reconnect);
+static std::unique_ptr create(std::optional, PreferTestService, Reconnect);
+Connection(std::optional, PreferTestService, Reconnect);
 
 void connectToService(WaitForServiceToExist);
 
@@ -75,7 +75,7 @@
 
 void sendAuditToken();
 
-Action m_action;
+std::optional m_action;
 bool m_reconnect { false };
 RetainPtr m_connection;
 const char* m_serviceName;


Modified:

[webkit-changes] [287124] trunk/Source

2021-12-15 Thread beidson

Title: [287124] trunk/Source








Revision 287124
Author beid...@apple.com
Date 2021-12-15 19:46:06 -0800 (Wed, 15 Dec 2021)


Log Message
Add a "NotificationData" object to encompass local Notification-related parameters, instead of passing tons of them around everywhere.
https://bugs.webkit.org/show_bug.cgi?id=234370

Reviewed by Tim Horton.

Source/WebCore:

No behavior change.

* Modules/notifications/Notification.cpp:
(WebCore::Notification::dataWithoutNotificationID const):
* Modules/notifications/Notification.h:

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

* NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::showNotification):
* NetworkProcess/Notifications/NetworkNotificationManager.h:

* Shared/Notifications/NotificationManagerMessageHandler.h:
* Shared/Notifications/NotificationManagerMessageHandler.messages.in:

* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):

* UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:
(WebKit::WebNotificationManagerMessageHandler::showNotification):
* UIProcess/Notifications/WebNotificationManagerMessageHandler.h:

* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Modules/notifications/Notification.cpp
trunk/Source/WebCore/Modules/notifications/Notification.h
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h
trunk/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h
trunk/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in
trunk/Source/WebKit/UIProcess/Notifications/WebNotification.cpp
trunk/Source/WebKit/UIProcess/Notifications/WebNotification.h
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp


Added Paths

trunk/Source/WebCore/Modules/notifications/NotificationData.cpp
trunk/Source/WebCore/Modules/notifications/NotificationData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (287123 => 287124)

--- trunk/Source/WebCore/ChangeLog	2021-12-16 03:33:41 UTC (rev 287123)
+++ trunk/Source/WebCore/ChangeLog	2021-12-16 03:46:06 UTC (rev 287124)
@@ -1,3 +1,19 @@
+2021-12-15  Brady Eidson  
+
+Add a "NotificationData" object to encompass local Notification-related parameters, instead of passing tons of them around everywhere.
+https://bugs.webkit.org/show_bug.cgi?id=234370
+
+Reviewed by Tim Horton.
+
+No behavior change.
+
+* Modules/notifications/Notification.cpp:
+(WebCore::Notification::dataWithoutNotificationID const):
+* Modules/notifications/Notification.h:
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+
 2021-12-15  Alex Christensen  
 
 Remove unreachable code in Plugin and PluginController


Modified: trunk/Source/WebCore/Headers.cmake (287123 => 287124)

--- trunk/Source/WebCore/Headers.cmake	2021-12-16 03:33:41 UTC (rev 287123)
+++ trunk/Source/WebCore/Headers.cmake	2021-12-16 03:46:06 UTC (rev 287124)
@@ -280,6 +280,7 @@
 Modules/notifications/Notification.h
 Modules/notifications/NotificationClient.h
 Modules/notifications/NotificationController.h
+Modules/notifications/NotificationData.h
 Modules/notifications/NotificationDirection.h
 Modules/notifications/NotificationPermission.h
 Modules/notifications/NotificationPermissionCallback.h


Modified: trunk/Source/WebCore/Modules/notifications/Notification.cpp (287123 => 287124)

--- trunk/Source/WebCore/Modules/notifications/Notification.cpp	2021-12-16 03:33:41 UTC (rev 287123)
+++ trunk/Source/WebCore/Modules/notifications/Notification.cpp	2021-12-16 03:46:06 UTC (rev 287124)
@@ -41,6 +41,7 @@
 #include "JSDOMPromiseDeferred.h"
 #include "NotificationClient.h"
 #include "NotificationController.h"
+#include "NotificationData.h"
 #include "NotificationPermissionCallback.h"
 #include

[webkit-changes] [287123] trunk/Tools

2021-12-15 Thread wilander

Title: [287123] trunk/Tools








Revision 287123
Author wilan...@apple.com
Date 2021-12-15 19:33:41 -0800 (Wed, 15 Dec 2021)


Log Message
TestWebKitAPI.PrivateClickMeasurement.MigrateWithDestinationToken is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=234335


Unreviewed test gardening.


* TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:
(cleanUp):
Made the function sleep-wait until the file is indeed deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm




Diff

Modified: trunk/Tools/ChangeLog (287122 => 287123)

--- trunk/Tools/ChangeLog	2021-12-16 02:15:38 UTC (rev 287122)
+++ trunk/Tools/ChangeLog	2021-12-16 03:33:41 UTC (rev 287123)
@@ -1,3 +1,15 @@
+2021-12-15  John Wilander  
+
+TestWebKitAPI.PrivateClickMeasurement.MigrateWithDestinationToken is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=234335
+
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:
+(cleanUp):
+Made the function sleep-wait until the file is indeed deleted.
+
 2021-12-15  Jonathan Bedard  
 
 [reporelaypy] Forward branches to alternate remote


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm (287122 => 287123)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm	2021-12-16 02:15:38 UTC (rev 287122)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm	2021-12-16 03:33:41 UTC (rev 287123)
@@ -316,6 +316,8 @@
 NSFileManager *defaultFileManager = NSFileManager.defaultManager;
 NSString *itpRoot = WKWebsiteDataStore.defaultDataStore._configuration._resourceLoadStatisticsDirectory.path;
 [defaultFileManager removeItemAtPath:itpRoot error:nil];
+while ([defaultFileManager fileExistsAtPath:itpRoot])
+usleep(1);
 EXPECT_FALSE([defaultFileManager fileExistsAtPath:itpRoot]);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287121] trunk

2021-12-15 Thread achristensen

Title: [287121] trunk








Revision 287121
Author achristen...@apple.com
Date 2021-12-15 17:52:47 -0800 (Wed, 15 Dec 2021)


Log Message
Remove unreachable code in Plugin and PluginController
https://bugs.webkit.org/show_bug.cgi?id=234365

Reviewed by Geoff Garen and Anders Carlsson.

Source/WebCore:

* bindings/js/ScriptController.h:
* bindings/js/ScriptControllerMac.mm:
* history/BackForwardCache.cpp:
(WebCore::canCacheFrame):
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setExperimentalPlugInSandboxProfilesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::experimentalPlugInSandboxProfilesEnabled const): Deleted.

Source/WebKit:

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetPageCacheSupportsPlugins):
(WKPreferencesGetPageCacheSupportsPlugins):
(WKPreferencesSetAsynchronousPluginInitializationEnabled):
(WKPreferencesGetAsynchronousPluginInitializationEnabled):
(WKPreferencesSetAsynchronousPluginInitializationEnabledForAllPlugins):
(WKPreferencesGetAsynchronousPluginInitializationEnabledForAllPlugins):
(WKPreferencesSetArtificialPluginInitializationDelayEnabled):
(WKPreferencesGetArtificialPluginInitializationDelayEnabled):
(WKPreferencesSetPluginSandboxProfilesEnabledForAllPlugins):
(WKPreferencesGetPluginSandboxProfilesEnabledForAllPlugins):
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setPageCacheSupportsPlugins:]):
(-[WKPreferences _pageCacheSupportsPlugins]):
(-[WKPreferences _setAsynchronousPluginInitializationEnabled:]):
(-[WKPreferences _asynchronousPluginInitializationEnabled]):
(-[WKPreferences _setArtificialPluginInitializationDelayEnabled:]):
(-[WKPreferences _artificialPluginInitializationDelayEnabled]):
(-[WKPreferences _setExperimentalPlugInSandboxProfilesEnabled:]):
(-[WKPreferences _experimentalPlugInSandboxProfilesEnabled]):
* WebProcess/Plugins/PDF/PDFPlugin.h:
(isType):
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::getSelectionForWordAtPoint const): Deleted.
* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Plugin): Deleted.
* WebProcess/Plugins/Plugin.h:
(WebKit::Plugin::type const): Deleted.
(WebKit::Plugin::isPluginProxy const): Deleted.
(WebKit::Plugin::isNetscapePlugin const): Deleted.
(WebKit::Plugin::isPDFPlugin const): Deleted.
* WebProcess/Plugins/PluginController.h:
(WebKit::PluginController::asynchronousPluginInitializationEnabled const): Deleted.
(WebKit::PluginController::asynchronousPluginInitializationEnabledForAllPlugins const): Deleted.
(WebKit::PluginController::artificialPluginInitializationDelayEnabled const): Deleted.
(WebKit::PluginController::PluginDestructionProtector::PluginDestructionProtector): Deleted.
(WebKit::PluginController::PluginDestructionProtector::~PluginDestructionProtector): Deleted.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginFocusOrWindowFocusChanged):
(WebKit::PluginView::didFailToInitializePlugin): Deleted.
(WebKit::PluginView::getSelectionForWordAtPoint const): Deleted.
(WebKit::PluginView::invalidate): Deleted.
(WebKit::PluginView::userAgent): Deleted.
(WebKit::PluginView::cancelStreamLoad): Deleted.
(WebKit::PluginView::continueStreamLoad): Deleted.
(WebKit::PluginView::cancelManualStreamLoad): Deleted.
(WebKit::PluginView::setStatusbarText): Deleted.
(WebKit::PluginView::isAcceleratedCompositingEnabled): Deleted.
(WebKit::PluginView::compositingRenderServerPort): Deleted.
(WebKit::PluginView::getAuthenticationInfo): Deleted.
(WebKit::PluginView::isPrivateBrowsingEnabled): Deleted.
(WebKit::PluginView::asynchronousPluginInitializationEnabled const): Deleted.
(WebKit::PluginView::asynchronousPluginInitializationEnabledForAllPlugins const): Deleted.
(WebKit::PluginView::artificialPluginInitializationDelayEnabled const): Deleted.
(WebKit::PluginView::protectPluginFromDestruction): Deleted.
(WebKit::PluginView::unprotectPluginFromDestruction): Deleted.
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::asynchronousPluginInitializationEnabled const): Deleted.
(WebKit::WebPage::setAsynchronousPluginInitializationEnabled): Deleted.
(WebKit::WebPage::asynchronousPluginInitializationEnabledForAllPlugins const): Deleted.
(WebKit::WebPage::setAsynchronousPluginInitializationEnabledForAllPlugins): Deleted.
(WebKit::WebPage::artificialPluginInitializationDelayEnabled const): Deleted.
(WebKit::WebPage::setArtificialPluginInitializationDelayEnabled): Deleted.

Source/WTF:

* Scripts/Preferences/WebPreferences.yaml:
* Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:

* fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html:
* media/crash-closing-page-with-media-as-plugin-fallback.html:
* plugins/crash-restoring-plugin-page-from-page-cache.html:
* plugins/frameset-with-plugin-frame.html:
* plugins/netscape-plugin-page-cache-works.html:
* plugins/netscape-plugin-page-cache-works-expected.html: Remove test for no-longer-reachable

[webkit-changes] [287120] trunk/Source

2021-12-15 Thread cdumez

Title: [287120] trunk/Source








Revision 287120
Author cdu...@apple.com
Date 2021-12-15 17:18:05 -0800 (Wed, 15 Dec 2021)


Log Message
Support passing an old-style enum to add(Hasher&, ...)
https://bugs.webkit.org/show_bug.cgi?id=234368

Reviewed by Darin Adler.

Source/WebCore:

Drop static_casts that should no longer be needed now that we can pass
an enum to add(Hasher&, ...).

* platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):

Source/WTF:

Support passing an old-style enum to add(Hasher&, ...). Previously, it would work for enum classes
but lead to ambiguity errors with some compiler when passing a plain enum.

* wtf/Hasher.h:
(WTF::Hasher::add):
(WTF::add):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Hasher.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h




Diff

Modified: trunk/Source/WTF/ChangeLog (287119 => 287120)

--- trunk/Source/WTF/ChangeLog	2021-12-16 01:08:06 UTC (rev 287119)
+++ trunk/Source/WTF/ChangeLog	2021-12-16 01:18:05 UTC (rev 287120)
@@ -1,3 +1,17 @@
+2021-12-15  Chris Dumez  
+
+Support passing an old-style enum to add(Hasher&, ...)
+https://bugs.webkit.org/show_bug.cgi?id=234368
+
+Reviewed by Darin Adler.
+
+Support passing an old-style enum to add(Hasher&, ...). Previously, it would work for enum classes
+but lead to ambiguity errors with some compiler when passing a plain enum.
+
+* wtf/Hasher.h:
+(WTF::Hasher::add):
+(WTF::add):
+
 2021-12-15  Jer Noble  
 
 [Mac] Adopt -[NSScreen safeAreaInsets]


Modified: trunk/Source/WTF/wtf/Hasher.h (287119 => 287120)

--- trunk/Source/WTF/wtf/Hasher.h	2021-12-16 01:08:06 UTC (rev 287119)
+++ trunk/Source/WTF/wtf/Hasher.h	2021-12-16 01:18:05 UTC (rev 287120)
@@ -31,7 +31,7 @@
 
 template uint32_t computeHash(const Types&...);
 template uint32_t computeHash(std::initializer_list, std::initializer_list...);
-template std::enable_if_t::value && sizeof(UnsignedInteger) <= sizeof(uint32_t), void> add(Hasher&, UnsignedInteger);
+template std::enable_if_t && sizeof(UnsignedInteger) <= sizeof(uint32_t) && !std::is_enum_v, void> add(Hasher&, UnsignedInteger);
 
 class Hasher {
 WTF_MAKE_FAST_ALLOCATED;
@@ -51,7 +51,7 @@
 return hasher.m_underlyingHasher.hash();
 }
 
-template friend std::enable_if_t::value && sizeof(UnsignedInteger) <= sizeof(uint32_t), void> add(Hasher& hasher, UnsignedInteger integer)
+template friend std::enable_if_t && sizeof(UnsignedInteger) <= sizeof(uint32_t) && !std::is_enum_v, void> add(Hasher& hasher, UnsignedInteger integer)
 {
 // We can consider adding a more efficient code path for hashing booleans or individual bytes if needed.
 // We can consider adding a more efficient code path for hashing 16-bit values if needed, perhaps using addCharacter,
@@ -123,7 +123,7 @@
 add(hasher, url.string());
 }
 
-template std::enable_if_t::value, void> add(Hasher& hasher, Enumeration value)
+template std::enable_if_t, void> add(Hasher& hasher, Enumeration value)
 {
 add(hasher, static_cast>(value));
 }


Modified: trunk/Source/WebCore/ChangeLog (287119 => 287120)

--- trunk/Source/WebCore/ChangeLog	2021-12-16 01:08:06 UTC (rev 287119)
+++ trunk/Source/WebCore/ChangeLog	2021-12-16 01:18:05 UTC (rev 287120)
@@ -1,3 +1,16 @@
+2021-12-15  Chris Dumez  
+
+Support passing an old-style enum to add(Hasher&, ...)
+https://bugs.webkit.org/show_bug.cgi?id=234368
+
+Reviewed by Darin Adler.
+
+Drop static_casts that should no longer be needed now that we can pass
+an enum to add(Hasher&, ...).
+
+* platform/network/ProtectionSpaceHash.h:
+(WebCore::ProtectionSpaceHash::hash):
+
 2021-12-15  Alexey Shvayka  
 
 [WebIDL] Remove the now-unused "ExecState" value of [CallWith] extended attribute


Modified: trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h (287119 => 287120)

--- trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h	2021-12-16 01:08:06 UTC (rev 287119)
+++ trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h	2021-12-16 01:18:05 UTC (rev 287120)
@@ -37,8 +37,8 @@
 Hasher hasher;
 add(hasher, protectionSpace.host());
 add(hasher, protectionSpace.port());
-add(hasher, static_cast(protectionSpace.serverType()));
-add(hasher, static_cast(protectionSpace.authenticationScheme()));
+add(hasher, protectionSpace.serverType());
+add(hasher, protectionSpace.authenticationScheme());
 if (!protectionSpace.isProxy())
 add(hasher, protectionSpace.realm());
 return hasher.hash();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287119] trunk/Source/WebCore

2021-12-15 Thread commit-queue

Title: [287119] trunk/Source/WebCore








Revision 287119
Author commit-qu...@webkit.org
Date 2021-12-15 17:08:06 -0800 (Wed, 15 Dec 2021)


Log Message
[WebIDL] Remove the now-unused "ExecState" value of [CallWith] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=234331

Patch by Alexey Shvayka  on 2021-12-15
Reviewed by Darin Adler.

ExecState was removed in favor of JSGlobalObject in https://webkit.org/b/202392.
This change removes leftovers from bindings generator, improving the condition for
exception check in GenerateConstructorDefinition, and even renames WebIDL test cases.

No new tests, no behavior change.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.json:
* bindings/scripts/test/JS/*: Updated.
* bindings/scripts/test/TestObj.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.json
trunk/Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (287118 => 287119)

--- trunk/Source/WebCore/ChangeLog	2021-12-16 00:55:58 UTC (rev 287118)
+++ trunk/Source/WebCore/ChangeLog	2021-12-16 01:08:06 UTC (rev 287119)
@@ -1,3 +1,23 @@
+2021-12-15  Alexey Shvayka  
+
+[WebIDL] Remove the now-unused "ExecState" value of [CallWith] extended attribute
+https://bugs.webkit.org/show_bug.cgi?id=234331
+
+Reviewed by Darin Adler.
+
+ExecState was removed in favor of JSGlobalObject in https://webkit.org/b/202392.
+This change removes leftovers from bindings generator, improving the condition for
+exception check in GenerateConstructorDefinition, and even renames WebIDL test cases.
+
+No new tests, no behavior change.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateCallWith):
+(GenerateConstructorDefinition):
+* bindings/scripts/IDLAttributes.json:
+* bindings/scripts/test/JS/*: Updated.
+* bindings/scripts/test/TestObj.idl:
+
 2021-12-15  Gabriel Nava Marino  
 
 null ptr deref in WebCore::ApplyStyleCommand::applyRelativeFontStyleChange


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (287118 => 287119)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2021-12-16 00:55:58 UTC (rev 287118)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2021-12-16 01:08:06 UTC (rev 287119)
@@ -5969,10 +5969,6 @@
 $indent ||= "";
 
 my @callWithArgs;
-if ($codeGenerator->ExtendedAttributeContains($callWith, "ExecState")) {
-push(@callWithArgs, "*${globalObject}");
-push(@callWithArgs, $callFrameReference);
-}
 # Global object of current realm (https://html.spec.whatwg.org/multipage/webappapis.html#concept-current-everything)
 if ($codeGenerator->ExtendedAttributeContains($callWith, "GlobalObject")) {
 push(@callWithArgs, "*${globalObject}");
@@ -7729,7 +7725,8 @@
 my $functionString = GenerateParametersCheck($outputArray, $operation, $interface, $functionImplementationName, "");
 
 push(@$outputArray, "auto object = ${functionString};\n");
-push(@$outputArray, "RETURN_IF_EXCEPTION(throwScope, encodedJSValue());\n") if $codeGenerator->ExtendedAttributeContains($interface->extendedAttributes->{CallWith}, "ExecState");
+push(@$outputArray, "if constexpr (IsExceptionOr)\n");
+push(@$outputArray, "RETURN_IF_EXCEPTION(throwScope, { });\n");
 
 push(@$outputArray, "static_assert(TypeOrExceptionOrUnderlyingType::isRef);\n");
 


Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.json (287118 => 287119)

--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.json	2021-12-16 00:55:58 UTC (rev 287118)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.json	2021-12-16 01:08:06 UTC (rev 287119)
@@ -51,7 +51,7 @@
 },
 "CallWith": {
 "contextsAllowed": ["attribute", "operation"],
-"values": ["Document", "RelevantDocument", "ExecState", "ScriptExecutionContext", "RelevantScriptExecutionContext", "GlobalObject", "RelevantGlobalObject",

[webkit-changes] [287118] trunk

2021-12-15 Thread commit-queue

Title: [287118] trunk








Revision 287118
Author commit-qu...@webkit.org
Date 2021-12-15 16:55:58 -0800 (Wed, 15 Dec 2021)


Log Message
null ptr deref in WebCore::ApplyStyleCommand::applyRelativeFontStyleChange
https://bugs.webkit.org/show_bug.cgi?id=234312

Patch by Gabriel Nava Marino  on 2021-12-15
Reviewed by Chris Dumez.

Source/WebCore:

In some situations calling ApplyStyleCommand::nodeFullySelected forces layout in a
way that disconnects the element. In this situation, we now break out of iteration.

We also add an isOrphan() check in ApplyStyleCommand::applyInlineStyle given
the possibility of this scenario.

Test: fast/editing/apply-relative-font-style-change-crash-004.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::applyInlineStyle):

LayoutTests:

* TestExpectations:
* fast/editing/apply-relative-font-style-change-crash-004-expected.txt: Added.
* fast/editing/apply-relative-font-style-change-crash-004.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp


Added Paths

trunk/LayoutTests/fast/editing/apply-relative-font-style-change-crash-004-expected.txt
trunk/LayoutTests/fast/editing/apply-relative-font-style-change-crash-004.html




Diff

Modified: trunk/LayoutTests/ChangeLog (287117 => 287118)

--- trunk/LayoutTests/ChangeLog	2021-12-16 00:55:07 UTC (rev 287117)
+++ trunk/LayoutTests/ChangeLog	2021-12-16 00:55:58 UTC (rev 287118)
@@ -1,3 +1,14 @@
+2021-12-15  Gabriel Nava Marino  
+
+null ptr deref in WebCore::ApplyStyleCommand::applyRelativeFontStyleChange
+https://bugs.webkit.org/show_bug.cgi?id=234312
+
+Reviewed by Chris Dumez.
+
+* TestExpectations:
+* fast/editing/apply-relative-font-style-change-crash-004-expected.txt: Added.
+* fast/editing/apply-relative-font-style-change-crash-004.html: Added.
+
 2021-12-15  J Pascoe  
 
 [WebAuthn] Allow same-site, cross-origin iframe get()


Modified: trunk/LayoutTests/TestExpectations (287117 => 287118)

--- trunk/LayoutTests/TestExpectations	2021-12-16 00:55:07 UTC (rev 287117)
+++ trunk/LayoutTests/TestExpectations	2021-12-16 00:55:58 UTC (rev 287118)
@@ -3377,6 +3377,9 @@
 fast/text/design-system-ui-15.html [ ImageOnlyFailure ]
 fast/text/design-system-ui-16.html [ ImageOnlyFailure ]
 
+# This is a crash test.
+fast/editing/apply-relative-font-style-change-crash-004.html [ Pass Failure ]
+
 # This is a crash test. The result is ignored for now.
 imported/w3c/web-platform-tests/shadow-dom/imperative-slot-assign-not-slotable-crash.html [ Pass Failure ]
 


Added: trunk/LayoutTests/fast/editing/apply-relative-font-style-change-crash-004-expected.txt (0 => 287118)

--- trunk/LayoutTests/fast/editing/apply-relative-font-style-change-crash-004-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/editing/apply-relative-font-style-change-crash-004-expected.txt	2021-12-16 00:55:58 UTC (rev 287118)
@@ -0,0 +1,41 @@
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: RangeError: Maximum

[webkit-changes] [287117] branches/safari-612-branch/Source/WebCore

2021-12-15 Thread alancoon

Title: [287117] branches/safari-612-branch/Source/WebCore








Revision 287117
Author alanc...@apple.com
Date 2021-12-15 16:55:07 -0800 (Wed, 15 Dec 2021)


Log Message
Cherry-pick r287079. rdar://problem/85892959

Twitter scroll stutter: ensure that CA backing store is always deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=234328


Reviewed by Tim Horton.

When scrolling pages like Twitter and Facebook we observed CoreAnimation commits on the
scrolling thread taking longer than they should because CABackingStore objects were being
released in those transactions.

Work around this issue by extending the lifetime of CABackingStore objects if we detect that
they might be entrained into a scrolling tree commit, by virtue of having overlapping main
thread and scrolling thread commits.

The logic is contained in PlatformCALayerContentsDelayedReleaser, which puts layer contents
into a retaining vector when they are being cleared on the layer. They are released at the
end of a main thread commit; if we detected overlapping commits, then we release on a
dispatch to extend the lifetime slightly.

The remaining changes are plumbing to get commit willBegin/didEnd messages to PlatformCALayerContentsDelayedReleaser
for main and scrolling threads.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* page/scrolling/ScrollingTree.h:
* page/scrolling/ThreadedScrollingTree.h:
* page/scrolling/mac/ScrollingCoordinatorMac.h:
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::willStartPlatformRenderingUpdate):
(WebCore::ScrollingCoordinatorMac::didCompletePlatformRenderingUpdate):
* page/scrolling/mac/ScrollingTreeMac.h:
* page/scrolling/mac/ScrollingTreeMac.mm:
(ScrollingTreeMac::applyLayerPositionsInternal):
(ScrollingTreeMac::registerForPlatformRenderingUpdateCallback):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateDrawsContent):
* platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::clearContents):
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::setBackingStoreAttached):
(WebCore::PlatformCALayerCocoa::clearContents):
* platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.h: Added.
(WebCore::PlatformCALayerContentsDelayedReleaser::WTF_GUARDED_BY_LOCK):
* platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.mm: Added.
(WebCore::PlatformCALayerContentsDelayedReleaser::singleton):
(WebCore::PlatformCALayerContentsDelayedReleaser::takeLayerContents):
(WebCore::PlatformCALayerContentsDelayedReleaser::mainThreadCommitWillStart):
(WebCore::PlatformCALayerContentsDelayedReleaser::mainThreadCommitDidEnd):
(WebCore::PlatformCALayerContentsDelayedReleaser::scrollingThreadCommitWillStart):
(WebCore::PlatformCALayerContentsDelayedReleaser::scrollingThreadCommitDidEnd):
(WebCore::PlatformCALayerContentsDelayedReleaser::updateSawOverlappingCommit):
(WebCore::PlatformCALayerContentsDelayedReleaser::clearRetainedContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/SourcesCocoa.txt
branches/safari-612-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTree.h
branches/safari-612-branch/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h
branches/safari-612-branch/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm
branches/safari-612-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.h
branches/safari-612-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm
branches/safari-612-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
branches/safari-612-branch/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp
branches/safari-612-branch/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
branches/safari-612-branch/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h
branches/safari-612-branch/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm


Added Paths

branches/safari-612-branch/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.h
branches/safari-612-branch/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.mm




Diff

Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (287116 => 287117)

--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-12-16 00:52:57 UTC (rev 287116)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog

[webkit-changes] [287116] trunk

2021-12-15 Thread j_pascoe

Title: [287116] trunk








Revision 287116
Author j_pas...@apple.com
Date 2021-12-15 16:52:57 -0800 (Wed, 15 Dec 2021)


Log Message
[WebAuthn] Allow same-site, cross-origin iframe get()
https://bugs.webkit.org/show_bug.cgi?id=234309
rdar://problem/86486313

Reviewed by Brent Fulgham.

Source/WebCore:

The Web Authentication level 2 specifies a feature policy to allow get calls in
cross-origin i-frames. This patch implements this feature policy partially. Only
same-site, cross-origin i-frames are supported instead. This is for tracking prevention
purposes. https://w3c.github.io/webauthn/#sctn-iframe-guidance

This patch also starts passing ClientDataJSON hashes to ASC to avoid the situation
where WebKit includes crossOrigin or other fields in ClientDataJSON that ASC is
unaware of when generating ClientDataJSON.

Added layout test cases for same-site, cross-origin get calls.

* Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
(WebCore::doesHaveSameSiteAsAncestors):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):
* Modules/webauthn/WebAuthenticationUtils.cpp:
(WebCore::buildClientDataJson):
* Modules/webauthn/WebAuthenticationUtils.h:
* html/FeaturePolicy.cpp:
(WebCore::policyTypeName):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):
* html/FeaturePolicy.h:

Source/WebKit:

The Web Authentication level 2 specifies a feature policy to allow get calls in
cross-origin i-frames. This patch implements this feature policy partially. Only
same-site, cross-origin i-frames are supported instead. This is for tracking prevention
purposes. https://w3c.github.io/webauthn/#sctn-iframe-guidance

This patch also starts passing ClientDataJSON hashes to ASC to avoid the situation
where WebKit includes crossOrigin or other fields in ClientDataJSON that ASC is
unaware of when generating ClientDataJSON.

Added layout test cases for same-site, cross-origin get calls.

* Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(produceClientDataJson):
* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::configureRegistrationRequestContext):
(WebKit::configurationAssertionRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::contextForRequest):

LayoutTests:

Add layout test for WebAuthn get assertions on cross-site, same-sites i-frames with
publickey-credentials-get feature policy.

* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt:
* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
* http/wpt/webauthn/resources/util.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html
trunk/LayoutTests/http/wpt/webauthn/resources/util.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp
trunk/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h
trunk/Source/WebCore/html/FeaturePolicy.cpp
trunk/Source/WebCore/html/FeaturePolicy.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm


Added Paths

trunk/LayoutTests/http/wpt/webauthn/resources/samesite-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (287115 => 287116)

--- trunk/LayoutTests/ChangeLog	2021-12-16 00:51:44 UTC (rev 287115)
+++ trunk/LayoutTests/ChangeLog	2021-12-16 00:52:57 UTC (rev 287116)
@@ -1,3 +1,18 @@
+2021-12-15  J Pascoe  
+
+[WebAuthn] Allow same-site, cross-origin iframe get()
+https://bugs.webkit.org/show_bug.cgi?id=234309
+rdar://problem/86486313
+
+Reviewed by Brent Fulgham.
+
+Add layout test for WebAuthn get assertions on cross-site, same-sites i-frames with
+publickey-credentials-get feature policy.
+
+* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt:
+* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
+* http/wpt/webauthn/resources/util.js:
+
 2021-12-15  Ryan Haddad  
 
 PCM: Remove old DB update and migration code, and add a unit test for destination token DB columns


Modified:

[webkit-changes] [287115] trunk/Tools

2021-12-15 Thread jbedard

Title: [287115] trunk/Tools








Revision 287115
Author jbed...@apple.com
Date 2021-12-15 16:51:44 -0800 (Wed, 15 Dec 2021)


Log Message
[reporelaypy] Forward branches to alternate remote
https://bugs.webkit.org/show_bug.cgi?id=234347


Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Bump version.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py:
(Checkout.Encoder.default): Add remotes.
(Checkout.clone): After cloning a repository, add required remotes.
(Checkout.add_remotes): Track remotes in repository.
(Checkout.__init__): Allow caller to specify set of remotes to be tracked.
(Checkout.push_update): Push update for specified remote.
(Checkout.update_for): Return 'True' and 'False.'
(Checkout.update_all): If a branch is being updated, we should forward that
update to any tracked remotes.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py:
(HookProcessor.process_worker_hook): After updating a branch, forward that
update to any tracked remotes.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py:
(CheckoutUnittest.test_constructor_no_sentinal): Capture debug logging.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py:
(CheckoutRouteUnittest.test_landing): Capture debug logging.
(CheckoutRouteUnittest.test_invoked_redirect): Ditto.
(CheckoutRouteUnittest.test_trac): Ditto.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/hooks_unittest.py:
(HooksUnittest.test_process): Test for any error logging.
(HooksUnittest.test_process_branch): Ditto.
* Tools/Scripts/libraries/reporelaypy/run: Allow caller to specify remote to be tracked.
* Tools/Scripts/libraries/reporelaypy/setup.py: Bump version.

Canonical link: https://commits.webkit.org/245300@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py
trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py
trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py
trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py
trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py
trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/hooks_unittest.py
trunk/Tools/Scripts/libraries/reporelaypy/run
trunk/Tools/Scripts/libraries/reporelaypy/setup.py




Diff

Modified: trunk/Tools/ChangeLog (287114 => 287115)

--- trunk/Tools/ChangeLog	2021-12-16 00:46:40 UTC (rev 287114)
+++ trunk/Tools/ChangeLog	2021-12-16 00:51:44 UTC (rev 287115)
@@ -1,3 +1,36 @@
+2021-12-15  Jonathan Bedard  
+
+[reporelaypy] Forward branches to alternate remote
+https://bugs.webkit.org/show_bug.cgi?id=234347
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Bump version.
+* Scripts/libraries/reporelaypy/reporelaypy/checkout.py:
+(Checkout.Encoder.default): Add remotes.
+(Checkout.clone): After cloning a repository, add required remotes.
+(Checkout.add_remotes): Track remotes in repository.
+(Checkout.__init__): Allow caller to specify set of remotes to be tracked.
+(Checkout.push_update): Push update for specified remote.
+(Checkout.update_for): Return 'True' and 'False.'
+(Checkout.update_all): If a branch is being updated, we should forward that
+update to any tracked remotes.
+* Scripts/libraries/reporelaypy/reporelaypy/hooks.py:
+(HookProcessor.process_worker_hook): After updating a branch, forward that
+update to any tracked remotes.
+* Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py:
+(CheckoutUnittest.test_constructor_no_sentinal): Capture debug logging.
+* Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py:
+(CheckoutRouteUnittest.test_landing): Capture debug logging.
+(CheckoutRouteUnittest.test_invoked_redirect): Ditto.
+(CheckoutRouteUnittest.test_trac): Ditto.
+* Scripts/libraries/reporelaypy/reporelaypy/tests/hooks_unittest.py:
+(HooksUnittest.test_process): Test for any error logging.
+(HooksUnittest.test_process_branch): Ditto.
+* Scripts/libraries/reporelaypy/run: Allow caller to specify remote to be tracked.
+* Scripts/libraries/reporelaypy/setup.py: Bump version.
+
 2021-12-15  Don Olmstead  
 
 Split ATK specific code in WPEViewBackends


Modified: trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py (287114 => 287115)

--- trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py	2021-12-16 00:46:40 UTC (rev 287114)
+++ trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py	2021-12-16 00:51:44 UTC (rev 287115)
@@ -44,7 +44,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(0, 3, 1)
+version = Version(0, 4, 0)
 
 import

[webkit-changes] [287114] branches/safari-612-branch/Source

2021-12-15 Thread alancoon

Title: [287114] branches/safari-612-branch/Source








Revision 287114
Author alanc...@apple.com
Date 2021-12-15 16:46:40 -0800 (Wed, 15 Dec 2021)


Log Message
Versioning.

WebKit-7612.4.5

Modified Paths

branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig (287113 => 287114)

--- branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-12-15 23:28:01 UTC (rev 287113)
+++ branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-12-16 00:46:40 UTC (rev 287114)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (287113 => 287114)

--- branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-12-15 23:28:01 UTC (rev 287113)
+++ branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-12-16 00:46:40 UTC (rev 287114)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (287113 => 287114)

--- branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-12-15 23:28:01 UTC (rev 287113)
+++ branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-12-16 00:46:40 UTC (rev 287114)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig (287113 => 287114)

--- branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig	2021-12-15 23:28:01 UTC (rev 287113)
+++ branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig	2021-12-16 00:46:40 UTC (rev 287114)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (287113 => 287114)

--- branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-12-15 23:28:01 UTC (rev 287113)
+++ branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-12-16 00:46:40 UTC (rev 287114)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (287113 => 287114)

--- branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-12-15 23:28:01 UTC (rev 287113)
+++ branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-12-16 00:46:40 UTC (rev 287114)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig (287113 => 287114)

--- branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig	2021-12-15 23:28:01 UTC (rev 287113)
+++ branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig	2021-12-16 00:46:40 UTC (rev 287114)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (287113 => 287114)

--- branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2021-12-15 23:28:01 UTC

[webkit-changes] [287113] tags/Safari-613.1.11.7/

2021-12-15 Thread repstein

Title: [287113] tags/Safari-613.1.11.7/








Revision 287113
Author repst...@apple.com
Date 2021-12-15 15:28:01 -0800 (Wed, 15 Dec 2021)


Log Message
Tag Safari-613.1.11.7.

Added Paths

tags/Safari-613.1.11.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287112] branches/safari-613.1.11-branch/Source/WebKit

2021-12-15 Thread repstein

Title: [287112] branches/safari-613.1.11-branch/Source/WebKit








Revision 287112
Author repst...@apple.com
Date 2021-12-15 15:24:54 -0800 (Wed, 15 Dec 2021)


Log Message
Cherry-pick r286781. rdar://problem/86221898

Unreviewed fix after r286778 to address WebContent crashes on launch

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.11-branch/Source/WebKit/ChangeLog
branches/safari-613.1.11-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: branches/safari-613.1.11-branch/Source/WebKit/ChangeLog (287111 => 287112)

--- branches/safari-613.1.11-branch/Source/WebKit/ChangeLog	2021-12-15 23:23:57 UTC (rev 287111)
+++ branches/safari-613.1.11-branch/Source/WebKit/ChangeLog	2021-12-15 23:24:54 UTC (rev 287112)
@@ -1,5 +1,21 @@
 2021-12-15  Alan Coon  
 
+Cherry-pick r286781. rdar://problem/86221898
+
+Unreviewed fix after r286778 to address WebContent crashes on launch
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-09  Chris Dumez  
+
+Unreviewed fix after r286778 to address WebContent crashes on launch
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
+2021-12-15  Alan Coon  
+
 Cherry-pick r286778. rdar://problem/86221898
 
 [macOS][WP] Block access to unused system calls


Modified: branches/safari-613.1.11-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (287111 => 287112)

--- branches/safari-613.1.11-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2021-12-15 23:23:57 UTC (rev 287111)
+++ branches/safari-613.1.11-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2021-12-15 23:24:54 UTC (rev 287112)
@@ -2207,6 +2207,7 @@
 (machtrap-number MSC_mach_msg2_trap)
 )
 )
+)
 #endif // HAVE(SANDBOX_MESSAGE_FILTERING)
 
 (if (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287111] branches/safari-613.1.11-branch/Source

2021-12-15 Thread repstein

Title: [287111] branches/safari-613.1.11-branch/Source








Revision 287111
Author repst...@apple.com
Date 2021-12-15 15:23:57 -0800 (Wed, 15 Dec 2021)


Log Message
Versioning.

WebKit-7613.1.11.7

Modified Paths

branches/safari-613.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (287110 => 287111)

--- branches/safari-613.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-12-15 23:19:57 UTC (rev 287110)
+++ branches/safari-613.1.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-12-15 23:23:57 UTC (rev 287111)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (287110 => 287111)

--- branches/safari-613.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-12-15 23:19:57 UTC (rev 287110)
+++ branches/safari-613.1.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-12-15 23:23:57 UTC (rev 287111)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (287110 => 287111)

--- branches/safari-613.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-12-15 23:19:57 UTC (rev 287110)
+++ branches/safari-613.1.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-12-15 23:23:57 UTC (rev 287111)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/WebCore/Configurations/Version.xcconfig (287110 => 287111)

--- branches/safari-613.1.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-12-15 23:19:57 UTC (rev 287110)
+++ branches/safari-613.1.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-12-15 23:23:57 UTC (rev 287111)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (287110 => 287111)

--- branches/safari-613.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-12-15 23:19:57 UTC (rev 287110)
+++ branches/safari-613.1.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-12-15 23:23:57 UTC (rev 287111)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig (287110 => 287111)

--- branches/safari-613.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig	2021-12-15 23:19:57 UTC (rev 287110)
+++ branches/safari-613.1.11-branch/Source/WebGPU/Configurations/Version.xcconfig	2021-12-15 23:23:57 UTC (rev 287111)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;
-MICRO_VERSION = 6;
+MICRO_VERSION = 7;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (287110 => 287111)

--- branches/safari-613.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-12-15 23:19:57 UTC (rev 287110)
+++ branches/safari-613.1.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-12-15 23:23:57 UTC (rev 287111)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 11;

[webkit-changes] [287110] trunk/Source/WebCore

2021-12-15 Thread bfulgham

Title: [287110] trunk/Source/WebCore








Revision 287110
Author bfulg...@apple.com
Date 2021-12-15 15:19:57 -0800 (Wed, 15 Dec 2021)


Log Message
Clean-up: Adopt Page::forEachDocument in some missed spots
https://bugs.webkit.org/show_bug.cgi?id=234324


Reviewed by Darin Adler.

Switch manual loops to our 'forEachDocument' style in a few places that were missed
in earlier refactoring.

No change in behavior.

* history/BackForwardCache.cpp:
(WebCore::setBackForwardCacheState)
* page/EventHandler.cpp:
(WebCore::removeDraggedContentDocumentMarkersFromAllFramesInPage):
* page/Frame.cpp:
(WebCore::Frame::orientationChanged):
* page/Page.cpp:
(WebCore::Page::~Page):
(WebCore::Page::forEachDocumentFromMainFrame): Added.
(WebCore::Page::forEachDocument): Use new method.
(WebCore::Page::forEachFrameFromMainFrame): Added.
(WebCore::Page::windowScreenDidChange):
(WebCore::Page::userAgentChanged):
* page/ios/FrameIOS.mm:
(WebCore::Frame::dispatchPageHideEventBeforePause):
(WebCore::Frame::dispatchPageShowEventBeforeResume):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/BackForwardCache.cpp
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/page/ios/FrameIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (287109 => 287110)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 22:34:30 UTC (rev 287109)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 23:19:57 UTC (rev 287110)
@@ -1,3 +1,33 @@
+2021-12-15  Brent Fulgham  
+
+Clean-up: Adopt Page::forEachDocument in some missed spots
+https://bugs.webkit.org/show_bug.cgi?id=234324
+
+
+Reviewed by Darin Adler.
+
+Switch manual loops to our 'forEachDocument' style in a few places that were missed
+in earlier refactoring.
+
+No change in behavior.
+
+* history/BackForwardCache.cpp:
+(WebCore::setBackForwardCacheState)
+* page/EventHandler.cpp:
+(WebCore::removeDraggedContentDocumentMarkersFromAllFramesInPage):
+* page/Frame.cpp:
+(WebCore::Frame::orientationChanged):
+* page/Page.cpp:
+(WebCore::Page::~Page):
+(WebCore::Page::forEachDocumentFromMainFrame): Added.
+(WebCore::Page::forEachDocument): Use new method.
+(WebCore::Page::forEachFrameFromMainFrame): Added.
+(WebCore::Page::windowScreenDidChange):
+(WebCore::Page::userAgentChanged):
+* page/ios/FrameIOS.mm:
+(WebCore::Frame::dispatchPageHideEventBeforePause):
+(WebCore::Frame::dispatchPageShowEventBeforeResume):
+
 2021-12-15  Alex Christensen  
 
 Fix Linux and windows build


Modified: trunk/Source/WebCore/history/BackForwardCache.cpp (287109 => 287110)

--- trunk/Source/WebCore/history/BackForwardCache.cpp	2021-12-15 22:34:30 UTC (rev 287109)
+++ trunk/Source/WebCore/history/BackForwardCache.cpp	2021-12-15 23:19:57 UTC (rev 287110)
@@ -388,10 +388,9 @@
 
 static void setBackForwardCacheState(Page& page, Document::BackForwardCacheState BackForwardCacheState)
 {
-for (Frame* frame = (); frame; frame = frame->tree().traverseNext()) {
-if (auto* document = frame->document())
-document->setBackForwardCacheState(BackForwardCacheState);
-}
+page.forEachDocument([&] (Document& document) {
+document.setBackForwardCacheState(BackForwardCacheState);
+});
 }
 
 // When entering back/forward cache, tear down the render tree before setting the in-cache flag.


Modified: trunk/Source/WebCore/page/EventHandler.cpp (287109 => 287110)

--- trunk/Source/WebCore/page/EventHandler.cpp	2021-12-15 22:34:30 UTC (rev 287109)
+++ trunk/Source/WebCore/page/EventHandler.cpp	2021-12-15 23:19:57 UTC (rev 287110)
@@ -3925,10 +3925,9 @@
 
 static void removeDraggedContentDocumentMarkersFromAllFramesInPage(Page& page)
 {
-for (RefPtr frame = (); frame; frame = frame->tree().traverseNext()) {
-if (RefPtr document = frame->document())
-document->markers().removeMarkers(DocumentMarker::DraggedContent);
-}
+page.forEachDocument([] (Document& document) {
+document.markers().removeMarkers(DocumentMarker::DraggedContent);
+});
 
 if (auto* mainFrameRenderer = page.mainFrame().contentRenderer())
 mainFrameRenderer->repaintRootContents();


Modified: trunk/Source/WebCore/page/Frame.cpp (287109 => 287110)

--- trunk/Source/WebCore/page/Frame.cpp	2021-12-15 22:34:30 UTC (rev 287109)
+++ trunk/Source/WebCore/page/Frame.cpp	2021-12-15 23:19:57 UTC (rev 287110)
@@ -362,15 +362,9 @@
 #if ENABLE(ORIENTATION_EVENTS)
 void Frame::orientationChanged()
 {
-Vector> frames;
-for (Frame* frame = this; frame; frame = frame->tree().traverseNext())
-frames.append(*frame);
-
-auto newOrientation = orientation();
-for (auto& frame : frames) {
-if (Document* document = frame->document())
-

[webkit-changes] [287109] trunk

2021-12-15 Thread commit-queue

Title: [287109] trunk








Revision 287109
Author commit-qu...@webkit.org
Date 2021-12-15 14:34:30 -0800 (Wed, 15 Dec 2021)


Log Message
[Shadow Realms] Wrapped functions must only throw TypeError from calling realm
https://bugs.webkit.org/show_bug.cgi?id=234357

JSTests:

Test the cases when the exception would be thrown by a function
originating from both the shadow realm and the incubating realm.

Patch by Joseph Griego  on 2021-12-15
Reviewed by Yusuke Suzuki.

* stress/shadow-realm-evaluate.js:
(shouldBe):
(let.f.realm.evaluate):
(shouldBe.f):

Source/_javascript_Core:

Patch by Joseph Griego  on 2021-12-15
Reviewed by Yusuke Suzuki.

This wrapping logic already exists for ShadowRealm.prototype.evaluate
but not for calls to wrapped functions. at present, this requires some
awkward manouvering to actually throw a typeerror from the shadow realm,
since the wrapper code always runs in the incubating realm.

Hopefully we can make this less messy soon by replacing this
implementation with one more integrated with the runtime.

This case wasn't covered by existing JSC or test262 tests; added
coverage both upstream in t262 and in this patch.

* builtins/ShadowRealmPrototype.js:
(wrapped):
(globalPrivate.wrap):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/shadow-realm-evaluate.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/ShadowRealmPrototype.js




Diff

Modified: trunk/JSTests/ChangeLog (287108 => 287109)

--- trunk/JSTests/ChangeLog	2021-12-15 21:54:53 UTC (rev 287108)
+++ trunk/JSTests/ChangeLog	2021-12-15 22:34:30 UTC (rev 287109)
@@ -1,3 +1,18 @@
+2021-12-15  Joseph Griego  
+
+[Shadow Realms] Wrapped functions must only throw TypeError from calling realm
+https://bugs.webkit.org/show_bug.cgi?id=234357
+
+Test the cases when the exception would be thrown by a function
+originating from both the shadow realm and the incubating realm.
+
+Reviewed by Yusuke Suzuki.
+
+* stress/shadow-realm-evaluate.js:
+(shouldBe):
+(let.f.realm.evaluate):
+(shouldBe.f):
+
 2021-12-13  Yusuke Suzuki  
 
 [JSC] Update Intl tests based on ICU 69~


Modified: trunk/JSTests/stress/shadow-realm-evaluate.js (287108 => 287109)

--- trunk/JSTests/stress/shadow-realm-evaluate.js	2021-12-15 21:54:53 UTC (rev 287108)
+++ trunk/JSTests/stress/shadow-realm-evaluate.js	2021-12-15 22:34:30 UTC (rev 287109)
@@ -174,3 +174,35 @@
 shouldBe(retrievedFoo, false);
 shouldBe(anotherFoo, 42);
 }
+
+// wrapped functions throw TypeError from the calling realm whenever the
+// implementing function throws:
+
+// (1) when the calling realm is the incubating realm
+{
+let realm = new ShadowRealm();
+let f = realm.evaluate("() => {throw new Error('ahh');}");
+shouldThrow(f, TypeError, (e) => {});
+}
+
+// (2) when the calling realm is the shadow realm
+{
+let realm = new ShadowRealm();
+let f = realm.evaluate(`
+  (f) => {
+try {
+  f();
+} catch(e) {
+  if (e instanceof TypeError)
+return 'ok';
+  else
+return e.toString();
+}
+return 'fail: normal exit';
+  }
+`);
+shouldBe(
+f(() => {throw new Error('ahhh');}),
+'ok'
+);
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (287108 => 287109)

--- trunk/Source/_javascript_Core/ChangeLog	2021-12-15 21:54:53 UTC (rev 287108)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-12-15 22:34:30 UTC (rev 287109)
@@ -1,3 +1,25 @@
+2021-12-15  Joseph Griego  
+
+[Shadow Realms] Wrapped functions must only throw TypeError from calling realm
+https://bugs.webkit.org/show_bug.cgi?id=234357
+
+Reviewed by Yusuke Suzuki.
+
+This wrapping logic already exists for ShadowRealm.prototype.evaluate
+but not for calls to wrapped functions. at present, this requires some
+awkward manouvering to actually throw a typeerror from the shadow realm,
+since the wrapper code always runs in the incubating realm.
+
+Hopefully we can make this less messy soon by replacing this
+implementation with one more integrated with the runtime.
+
+This case wasn't covered by existing JSC or test262 tests; added
+coverage both upstream in t262 and in this patch.
+
+* builtins/ShadowRealmPrototype.js:
+(wrapped):
+(globalPrivate.wrap):
+
 2021-12-14  Ross Kirsling  
 
 [JSC] OpInstanceofCustom should be in CommonSlowPaths


Modified: trunk/Source/_javascript_Core/builtins/ShadowRealmPrototype.js (287108 => 287109)

--- trunk/Source/_javascript_Core/builtins/ShadowRealmPrototype.js	2021-12-15 21:54:53 UTC (rev 287108)
+++ trunk/Source/_javascript_Core/builtins/ShadowRealmPrototype.js	2021-12-15 22:34:30 UTC (rev 287109)
@@ -42,7 +42,18 @@
 // calling the wrapped function
 @putByValDirect(wrappedArgs, index,

[webkit-changes] [287108] trunk/Source/WebCore

2021-12-15 Thread achristensen

Title: [287108] trunk/Source/WebCore








Revision 287108
Author achristen...@apple.com
Date 2021-12-15 13:54:53 -0800 (Wed, 15 Dec 2021)


Log Message
Fix Linux and windows build
https://bugs.webkit.org/show_bug.cgi?id=234362

* Headers.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (287107 => 287108)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 21:54:20 UTC (rev 287107)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 21:54:53 UTC (rev 287108)
@@ -1,3 +1,10 @@
+2021-12-15  Alex Christensen  
+
+Fix Linux and windows build
+https://bugs.webkit.org/show_bug.cgi?id=234362
+
+* Headers.cmake:
+
 2021-12-15  Chris Dumez  
 
 Unreviewed build fix after r287077.


Modified: trunk/Source/WebCore/Headers.cmake (287107 => 287108)

--- trunk/Source/WebCore/Headers.cmake	2021-12-15 21:54:20 UTC (rev 287107)
+++ trunk/Source/WebCore/Headers.cmake	2021-12-15 21:54:53 UTC (rev 287108)
@@ -1730,7 +1730,6 @@
 platform/network/ProtectionSpace.h
 platform/network/ProtectionSpaceBase.h
 platform/network/ProtectionSpaceHash.h
-platform/network/ProxyServer.h
 platform/network/ResourceErrorBase.h
 platform/network/ResourceHandle.h
 platform/network/ResourceHandleClient.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287107] trunk/Source/WebCore

2021-12-15 Thread cdumez

Title: [287107] trunk/Source/WebCore








Revision 287107
Author cdu...@apple.com
Date 2021-12-15 13:54:20 -0800 (Wed, 15 Dec 2021)


Log Message
Unreviewed build fix after r287077.

* platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (287106 => 287107)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 21:34:14 UTC (rev 287106)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 21:54:20 UTC (rev 287107)
@@ -1,3 +1,10 @@
+2021-12-15  Chris Dumez  
+
+Unreviewed build fix after r287077.
+
+* platform/network/ProtectionSpaceHash.h:
+(WebCore::ProtectionSpaceHash::hash):
+
 2021-12-15  Alex Christensen  
 
 Remove ProxyServer


Modified: trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h (287106 => 287107)

--- trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h	2021-12-15 21:34:14 UTC (rev 287106)
+++ trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h	2021-12-15 21:54:20 UTC (rev 287107)
@@ -37,8 +37,8 @@
 Hasher hasher;
 add(hasher, protectionSpace.host());
 add(hasher, protectionSpace.port());
-add(hasher, protectionSpace.serverType());
-add(hasher, protectionSpace.authenticationScheme());
+add(hasher, static_cast(protectionSpace.serverType()));
+add(hasher, static_cast(protectionSpace.authenticationScheme()));
 if (!protectionSpace.isProxy())
 add(hasher, protectionSpace.realm());
 return hasher.hash();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287106] trunk/Source

2021-12-15 Thread commit-queue

Title: [287106] trunk/Source








Revision 287106
Author commit-qu...@webkit.org
Date 2021-12-15 13:34:14 -0800 (Wed, 15 Dec 2021)


Log Message
Remove ProxyServer
https://bugs.webkit.org/show_bug.cgi?id=234362

Patch by Alex Christensen  on 2021-12-15
Reviewed by Geoffrey Garen.

Source/WebCore:

It was only used for NPAPI.

* PlatformAppleWin.cmake:
* PlatformMac.cmake:
* Sources.txt:
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/Curl.cmake:
* platform/SourcesSoup.txt:
* platform/network/ProxyServer.cpp: Removed.
* platform/network/ProxyServer.h: Removed.
* platform/network/cf/ProxyServerCFNet.cpp: Removed.
* platform/network/curl/ProxyServerCurl.cpp: Removed.
* platform/network/soup/ProxyServerSoup.cpp: Removed.

Source/WebKit:

* WebProcess/Plugins/PluginView.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformAppleWin.cmake
trunk/Source/WebCore/PlatformMac.cmake
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/Curl.cmake
trunk/Source/WebCore/platform/SourcesSoup.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp


Removed Paths

trunk/Source/WebCore/platform/network/ProxyServer.cpp
trunk/Source/WebCore/platform/network/ProxyServer.h
trunk/Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp
trunk/Source/WebCore/platform/network/curl/ProxyServerCurl.cpp
trunk/Source/WebCore/platform/network/soup/ProxyServerSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (287105 => 287106)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 21:32:07 UTC (rev 287105)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 21:34:14 UTC (rev 287106)
@@ -1,3 +1,25 @@
+2021-12-15  Alex Christensen  
+
+Remove ProxyServer
+https://bugs.webkit.org/show_bug.cgi?id=234362
+
+Reviewed by Geoffrey Garen.
+
+It was only used for NPAPI.
+
+* PlatformAppleWin.cmake:
+* PlatformMac.cmake:
+* Sources.txt:
+* SourcesCocoa.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/Curl.cmake:
+* platform/SourcesSoup.txt:
+* platform/network/ProxyServer.cpp: Removed.
+* platform/network/ProxyServer.h: Removed.
+* platform/network/cf/ProxyServerCFNet.cpp: Removed.
+* platform/network/curl/ProxyServerCurl.cpp: Removed.
+* platform/network/soup/ProxyServerSoup.cpp: Removed.
+
 2021-12-15  Tyler Wilcock  
 
 AX: Move comment about accessibilityShouldUseUniqueId in WebAccessibilityObjectWrapperMac.mm to the right place


Modified: trunk/Source/WebCore/PlatformAppleWin.cmake (287105 => 287106)

--- trunk/Source/WebCore/PlatformAppleWin.cmake	2021-12-15 21:32:07 UTC (rev 287105)
+++ trunk/Source/WebCore/PlatformAppleWin.cmake	2021-12-15 21:34:14 UTC (rev 287106)
@@ -43,7 +43,6 @@
 platform/network/cf/NetworkStorageSessionCFNet.cpp
 platform/network/cf/NetworkStorageSessionCFNetWin.cpp
 platform/network/cf/ProtectionSpaceCFNet.cpp
-platform/network/cf/ProxyServerCFNet.cpp
 platform/network/cf/ResourceErrorCF.cpp
 platform/network/cf/ResourceHandleCFNet.cpp
 platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp


Modified: trunk/Source/WebCore/PlatformMac.cmake (287105 => 287106)

--- trunk/Source/WebCore/PlatformMac.cmake	2021-12-15 21:32:07 UTC (rev 287105)
+++ trunk/Source/WebCore/PlatformMac.cmake	2021-12-15 21:34:14 UTC (rev 287106)
@@ -402,7 +402,6 @@
 platform/network/cf/DNSResolveQueueCFNet.cpp
 platform/network/cf/FormDataStreamCFNet.cpp
 platform/network/cf/NetworkStorageSessionCFNet.cpp
-platform/network/cf/ProxyServerCFNet.cpp
 platform/network/cf/ResourceRequestCFNet.cpp
 platform/network/cf/SocketStreamHandleImplCFNet.cpp
 


Modified: trunk/Source/WebCore/Sources.txt (287105 => 287106)

--- trunk/Source/WebCore/Sources.txt	2021-12-15 21:32:07 UTC (rev 287105)
+++ trunk/Source/WebCore/Sources.txt	2021-12-15 21:34:14 UTC (rev 287106)
@@ -2227,7 +2227,6 @@
 platform/network/ParsedContentType.cpp
 platform/network/ParsedRequestRange.cpp
 platform/network/ProtectionSpaceBase.cpp
-platform/network/ProxyServer.cpp
 platform/network/ResourceErrorBase.cpp
 platform/network/ResourceHandle.cpp
 platform/network/ResourceHandleClient.cpp


Modified: trunk/Source/WebCore/SourcesCocoa.txt (287105 => 287106)

--- trunk/Source/WebCore/SourcesCocoa.txt	2021-12-15 21:32:07 UTC (rev 287105)
+++ trunk/Source/WebCore/SourcesCocoa.txt	2021-12-15 21:34:14 UTC (rev 287106)
@@ -565,7 +565,6 @@
 platform/network/cf/DNSResolveQueueCFNet.cpp
 platform/network/cf/FormDataStreamCFNet.cpp
 platform/network/cf/NetworkStorageSessionCFNet.cpp
-platform/network/cf/ProxyServerCFNet.cpp
 platform/network/cf/ResourceRequestCFNet.cpp
 platform/network/cf/SocketStreamHandleImplCFNet.cpp
 platform/network/cocoa/CertificateInfoCocoa.mm


Modified:

[webkit-changes] [287105] trunk/Tools

2021-12-15 Thread don . olmstead

Title: [287105] trunk/Tools








Revision 287105
Author don.olmst...@sony.com
Date 2021-12-15 13:32:07 -0800 (Wed, 15 Dec 2021)


Log Message
Split ATK specific code in WPEViewBackends
https://bugs.webkit.org/show_bug.cgi?id=234310

Reviewed by Adrian Perez de Castro.

Move ATK specific code in WPEViewBackends into the atk directory. This splits
ViewBackend's implementation into two files with ATK specific code migrated to
atk/ViewBackendAtk.cpp. The code in WebKitAccessibleApplication is all ATK specific so
its completely moved into the atk directory.

* wpe/backends/CMakeLists.txt:
* wpe/backends/PlatformWPE.cmake:
* wpe/backends/ViewBackend.cpp:
(WPEToolingBackends::ViewBackend::initializeAccessibility):
(WPEToolingBackends::ViewBackend::updateAccessibilityState):
(WPEToolingBackends::addKeyEventListener): Deleted.
(WPEToolingBackends::removeKeyEventListener): Deleted.
(WPEToolingBackends::notifyAccessibilityKeyEventListeners): Deleted.
(WPEToolingBackends::ViewBackend::setAccessibleChild): Deleted.
* wpe/backends/ViewBackend.h:
* wpe/backends/atk/ViewBackendAtk.cpp: Copied from Tools/wpe/backends/ViewBackend.cpp.
(WPEToolingBackends::addKeyEventListener):
(WPEToolingBackends::removeKeyEventListener):
(WPEToolingBackends::ViewBackend::notifyAccessibilityKeyEventListeners):
(WPEToolingBackends::ViewBackend::initializeAccessibility):
(WPEToolingBackends::ViewBackend::updateAccessibilityState):
(WPEToolingBackends::ViewBackend::setAccessibleChild):
* wpe/backends/atk/WebKitAccessibleApplication.cpp: Renamed from Tools/wpe/backends/WebKitAccessibleApplication.cpp.
* wpe/backends/atk/WebKitAccessibleApplication.h: Renamed from Tools/wpe/backends/WebKitAccessibleApplication.h.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/wpe/backends/CMakeLists.txt
trunk/Tools/wpe/backends/PlatformWPE.cmake
trunk/Tools/wpe/backends/ViewBackend.cpp
trunk/Tools/wpe/backends/ViewBackend.h


Added Paths

trunk/Tools/wpe/backends/atk/
trunk/Tools/wpe/backends/atk/ViewBackendAtk.cpp
trunk/Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp
trunk/Tools/wpe/backends/atk/WebKitAccessibleApplication.h


Removed Paths

trunk/Tools/wpe/backends/WebKitAccessibleApplication.cpp
trunk/Tools/wpe/backends/WebKitAccessibleApplication.h




Diff

Modified: trunk/Tools/ChangeLog (287104 => 287105)

--- trunk/Tools/ChangeLog	2021-12-15 21:26:53 UTC (rev 287104)
+++ trunk/Tools/ChangeLog	2021-12-15 21:32:07 UTC (rev 287105)
@@ -1,3 +1,35 @@
+2021-12-15  Don Olmstead  
+
+Split ATK specific code in WPEViewBackends
+https://bugs.webkit.org/show_bug.cgi?id=234310
+
+Reviewed by Adrian Perez de Castro.
+
+Move ATK specific code in WPEViewBackends into the atk directory. This splits
+ViewBackend's implementation into two files with ATK specific code migrated to
+atk/ViewBackendAtk.cpp. The code in WebKitAccessibleApplication is all ATK specific so
+its completely moved into the atk directory.
+
+* wpe/backends/CMakeLists.txt:
+* wpe/backends/PlatformWPE.cmake:
+* wpe/backends/ViewBackend.cpp:
+(WPEToolingBackends::ViewBackend::initializeAccessibility):
+(WPEToolingBackends::ViewBackend::updateAccessibilityState):
+(WPEToolingBackends::addKeyEventListener): Deleted.
+(WPEToolingBackends::removeKeyEventListener): Deleted.
+(WPEToolingBackends::notifyAccessibilityKeyEventListeners): Deleted.
+(WPEToolingBackends::ViewBackend::setAccessibleChild): Deleted.
+* wpe/backends/ViewBackend.h:
+* wpe/backends/atk/ViewBackendAtk.cpp: Copied from Tools/wpe/backends/ViewBackend.cpp.
+(WPEToolingBackends::addKeyEventListener):
+(WPEToolingBackends::removeKeyEventListener):
+(WPEToolingBackends::ViewBackend::notifyAccessibilityKeyEventListeners):
+(WPEToolingBackends::ViewBackend::initializeAccessibility):
+(WPEToolingBackends::ViewBackend::updateAccessibilityState):
+(WPEToolingBackends::ViewBackend::setAccessibleChild):
+* wpe/backends/atk/WebKitAccessibleApplication.cpp: Renamed from Tools/wpe/backends/WebKitAccessibleApplication.cpp.
+* wpe/backends/atk/WebKitAccessibleApplication.h: Renamed from Tools/wpe/backends/WebKitAccessibleApplication.h.
+
 2021-12-15  Alex Christensen  
 
 Avoid unnecessary allocation and UTF-8 conversion when calling DFABytecodeInterpreter::interpret


Modified: trunk/Tools/wpe/backends/CMakeLists.txt (287104 => 287105)

--- trunk/Tools/wpe/backends/CMakeLists.txt	2021-12-15 21:26:53 UTC (rev 287104)
+++ trunk/Tools/wpe/backends/CMakeLists.txt	2021-12-15 21:32:07 UTC (rev 287105)
@@ -13,7 +13,6 @@
 set(WPEToolingBackends_SOURCES
 HeadlessViewBackend.cpp
 ViewBackend.cpp
-WebKitAccessibleApplication.cpp
 WindowViewBackend.cpp
 )
 


Modified: trunk/Tools/wpe/backends/PlatformWPE.cmake (287104 => 287105)

--- trunk/Tools/wpe/backends/PlatformWPE.cmake	2021-12-15 21:26:53 UTC (rev 287104)
+++

[webkit-changes] [287104] trunk/Source/WebCore

2021-12-15 Thread tyler_w

Title: [287104] trunk/Source/WebCore








Revision 287104
Author tyle...@apple.com
Date 2021-12-15 13:26:53 -0800 (Wed, 15 Dec 2021)


Log Message
AX: Move comment about accessibilityShouldUseUniqueId in WebAccessibilityObjectWrapperMac.mm to the right place
https://bugs.webkit.org/show_bug.cgi?id=234334

Reviewed by Chris Fleizach.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
Move comment about accessibilityShouldUseUniqueId next to its
defintion rather than its current location next to
accessibilityIsIgnored.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (287103 => 287104)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 21:24:41 UTC (rev 287103)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 21:26:53 UTC (rev 287104)
@@ -1,3 +1,15 @@
+2021-12-15  Tyler Wilcock  
+
+AX: Move comment about accessibilityShouldUseUniqueId in WebAccessibilityObjectWrapperMac.mm to the right place
+https://bugs.webkit.org/show_bug.cgi?id=234334
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+Move comment about accessibilityShouldUseUniqueId next to its
+defintion rather than its current location next to
+accessibilityIsIgnored.
+
 2021-12-15  Alexey Shvayka  
 
 [WebIDL] Remove the now-unused [DocumentEventHandler] extended attribute


Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (287103 => 287104)

--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2021-12-15 21:24:41 UTC (rev 287103)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2021-12-15 21:26:53 UTC (rev 287104)
@@ -3009,15 +3009,6 @@
 return NO;
 }
 
-// accessibilityShouldUseUniqueId is an AppKit method we override so that
-// objects will be given a unique ID, and therefore allow AppKit to know when they
-// become obsolete (e.g. when the user navigates to a new web page, making this one
-// unrendered but not deallocated because it is in the back/forward cache).
-// It is important to call NSAccessibilityUnregisterUniqueIdForUIElement in the
-// appropriate place (e.g. dealloc) to remove these non-retained references from
-// AppKit's id mapping tables. We do this in detach by calling unregisterUniqueIdForUIElement.
-//
-// Registering an object is also required for observing notifications. Only registered objects can be observed.
 ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
 - (BOOL)accessibilityIsIgnored
 ALLOW_DEPRECATED_IMPLEMENTATIONS_END
@@ -4331,6 +4322,15 @@
 return YES;
 }
 
+// accessibilityShouldUseUniqueId is an AppKit method we override so that
+// objects will be given a unique ID, and therefore allow AppKit to know when they
+// become obsolete (e.g. when the user navigates to a new web page, making this one
+// unrendered but not deallocated because it is in the back/forward cache).
+// It is important to call NSAccessibilityUnregisterUniqueIdForUIElement in the
+// appropriate place (e.g. dealloc) to remove these non-retained references from
+// AppKit's id mapping tables. We do this in detach by calling unregisterUniqueIdForUIElement.
+//
+// Registering an object is also required for observing notifications. Only registered objects can be observed.
 - (BOOL)accessibilityShouldUseUniqueId
 {
 // All AX object wrappers should use unique ID's because it's faster within AppKit to look them up.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287103] trunk/Source/WebKit

2021-12-15 Thread cdumez

Title: [287103] trunk/Source/WebKit








Revision 287103
Author cdu...@apple.com
Date 2021-12-15 13:24:41 -0800 (Wed, 15 Dec 2021)


Log Message
RELEASE_ASSERT in WTF::Deque::first()
https://bugs.webkit.org/show_bug.cgi?id=234301

Reviewed by Geoffrey Garen.

WebPageProxy::interpretKeyEvent() gets called as the result of IPC from the WebProcess
and assumes that WebPageProxy::m_keyEventQueue is non-empty. We have evidence based on
the Chrome crash report that this assertion doesn't always hold. Also, the WebProcess
is not a trusted process so we shouldn't be making such assumptions in the first place.

Add a check in WebPageProxy::interpretKeyEvent() to properly deal with an empty queue.

No new tests, unknown how to reproduce.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::interpretKeyEvent):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (287102 => 287103)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 21:13:03 UTC (rev 287102)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 21:24:41 UTC (rev 287103)
@@ -1,3 +1,22 @@
+2021-12-15  Chris Dumez  
+
+RELEASE_ASSERT in WTF::Deque::first()
+https://bugs.webkit.org/show_bug.cgi?id=234301
+
+Reviewed by Geoffrey Garen.
+
+WebPageProxy::interpretKeyEvent() gets called as the result of IPC from the WebProcess
+and assumes that WebPageProxy::m_keyEventQueue is non-empty. We have evidence based on
+the Chrome crash report that this assertion doesn't always hold. Also, the WebProcess
+is not a trusted process so we shouldn't be making such assumptions in the first place.
+
+Add a check in WebPageProxy::interpretKeyEvent() to properly deal with an empty queue.
+
+No new tests, unknown how to reproduce.
+
+* UIProcess/ios/WebPageProxyIOS.mm:
+(WebKit::WebPageProxy::interpretKeyEvent):
+
 2021-12-15  Alex Christensen  
 
 Actually use adattributiond.entitlements when code signing adattributiond


Modified: trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm (287102 => 287103)

--- trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm	2021-12-15 21:13:03 UTC (rev 287102)
+++ trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm	2021-12-15 21:24:41 UTC (rev 287103)
@@ -723,7 +723,10 @@
 void WebPageProxy::interpretKeyEvent(const EditorState& state, bool isCharEvent, CompletionHandler&& completionHandler)
 {
 m_editorState = state;
-completionHandler(pageClient().interpretKeyEvent(m_keyEventQueue.first(), isCharEvent));
+if (m_keyEventQueue.isEmpty())
+completionHandler(false);
+else
+completionHandler(pageClient().interpretKeyEvent(m_keyEventQueue.first(), isCharEvent));
 }
 
 // Complex text input support for plug-ins.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287102] trunk/LayoutTests

2021-12-15 Thread ryanhaddad

Title: [287102] trunk/LayoutTests








Revision 287102
Author ryanhad...@apple.com
Date 2021-12-15 13:13:03 -0800 (Wed, 15 Dec 2021)


Log Message
PCM: Remove old DB update and migration code, and add a unit test for destination token DB columns
https://bugs.webkit.org/show_bug.cgi?id=234281

Unreviewed test gardening.

Rebaseline tests for iOS.

* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt:
* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt:
* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt:
* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt:
* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt:
* platform/ios/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt:
* platform/ios/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt:
* platform/ios/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt:
* platform/ios/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt
trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (287101 => 287102)

--- trunk/LayoutTests/ChangeLog	2021-12-15 21:10:17 UTC (rev 287101)
+++ trunk/LayoutTests/ChangeLog	2021-12-15 21:13:03 UTC (rev 287102)
@@ -1,3 +1,22 @@
+2021-12-15  Ryan Haddad  
+
+PCM: Remove old DB update and migration code, and add a unit test for destination token DB columns
+https://bugs.webkit.org/show_bug.cgi?id=234281
+
+Unreviewed test gardening.
+
+Rebaseline tests for iOS.
+
+* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt:
+* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt:
+* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt:
+* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt:
+* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt:
+* platform/ios/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt:
+* platform/ios/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt:
+* platform/ios/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt:
+* platform/ios/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt:
+
 2021-12-15  Arcady Goldmints-Orlov  
 
 [GLIB] Update test expectations and baselines. Unreviewed test gardening.


Modified: trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt (287101 => 287102)

--- trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt	2021-12-15 21:10:17 UTC (rev 287101)
+++ trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt	2021-12-15 21:13:03 UTC (rev 287102)
@@ -12,4 +12,5 @@
 Attribution trigger data: 12
 Attribution priority: 0
 Attribution earliest time to send: Within 24-48 hours
+Destination token: Not set

[webkit-changes] [287101] trunk/LayoutTests

2021-12-15 Thread commit-queue

Title: [287101] trunk/LayoutTests








Revision 287101
Author commit-qu...@webkit.org
Date 2021-12-15 13:10:17 -0800 (Wed, 15 Dec 2021)


Log Message
[GLIB] Update test expectations and baselines. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=234353

Patch by Arcady Goldmints-Orlov  on 2021-12-15

* platform/glib/TestExpectations:
* platform/glib/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt: Added.
* platform/glib/http/tests/workers/service/service-worker-download-body.https-expected.txt: Added.
* platform/glib/http/tests/workers/service/service-worker-download-stream.https-expected.txt: Added.
* platform/glib/http/tests/workers/service/service-worker-download.https-expected.txt: Added.
* platform/glib/http/wpt/service-workers/fetch-service-worker-preload-download-through-direct-preload.https-expected.txt: Added.
* platform/glib/http/wpt/service-workers/fetch-service-worker-preload-download.https-expected.txt: Added.
* platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Added.
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/glib/http/tests/workers/
trunk/LayoutTests/platform/glib/http/tests/workers/service/
trunk/LayoutTests/platform/glib/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt
trunk/LayoutTests/platform/glib/http/tests/workers/service/service-worker-download-body.https-expected.txt
trunk/LayoutTests/platform/glib/http/tests/workers/service/service-worker-download-stream.https-expected.txt
trunk/LayoutTests/platform/glib/http/tests/workers/service/service-worker-download.https-expected.txt
trunk/LayoutTests/platform/glib/http/wpt/service-workers/
trunk/LayoutTests/platform/glib/http/wpt/service-workers/fetch-service-worker-preload-download-through-direct-preload.https-expected.txt
trunk/LayoutTests/platform/glib/http/wpt/service-workers/fetch-service-worker-preload-download.https-expected.txt
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (287100 => 287101)

--- trunk/LayoutTests/ChangeLog	2021-12-15 21:06:48 UTC (rev 287100)
+++ trunk/LayoutTests/ChangeLog	2021-12-15 21:10:17 UTC (rev 287101)
@@ -1,3 +1,18 @@
+2021-12-15  Arcady Goldmints-Orlov  
+
+[GLIB] Update test expectations and baselines. Unreviewed test gardening.
+https://bugs.webkit.org/show_bug.cgi?id=234353
+
+* platform/glib/TestExpectations:
+* platform/glib/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt: Added.
+* platform/glib/http/tests/workers/service/service-worker-download-body.https-expected.txt: Added.
+* platform/glib/http/tests/workers/service/service-worker-download-stream.https-expected.txt: Added.
+* platform/glib/http/tests/workers/service/service-worker-download.https-expected.txt: Added.
+* platform/glib/http/wpt/service-workers/fetch-service-worker-preload-download-through-direct-preload.https-expected.txt: Added.
+* platform/glib/http/wpt/service-workers/fetch-service-worker-preload-download.https-expected.txt: Added.
+* platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Added.
+* platform/gtk/TestExpectations:
+
 2021-12-15  Alexey Shvayka  
 
 [WebIDL] onselectionchange IDL attribute should not Document-reflect event listeners


Modified: trunk/LayoutTests/platform/glib/TestExpectations (287100 => 287101)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-12-15 21:06:48 UTC (rev 287100)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-12-15 21:10:17 UTC (rev 287101)
@@ -806,6 +806,8 @@
 webkit.org/b/234084 media/track/audio-track-configuration.html [ Failure ]
 webkit.org/b/234084 media/track/video-track-configuration.html [ Failure ]
 
+webkit.org/b/234352 imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible.html [ ImageOnlyFailure ]
+
 #
 # End of GStreamer-related bugs
 #
@@ -1897,6 +1899,9 @@
 #  is not supported by GTK/WPE
 http/tests/model/ [ Skip ]
 
+# The DocumentTimeline.maximumFrameRate property which this test is about is not available on GTK/WPE.
+webanimations/frame-rate/document-timeline-maximum-frame-rate.html [ Skip ]
+
 #
 # End of UNSUPPORTED tests.

[webkit-changes] [287100] trunk/Source/WebKit

2021-12-15 Thread commit-queue

Title: [287100] trunk/Source/WebKit








Revision 287100
Author commit-qu...@webkit.org
Date 2021-12-15 13:06:48 -0800 (Wed, 15 Dec 2021)


Log Message
Actually use adattributiond.entitlements when code signing adattributiond
https://bugs.webkit.org/show_bug.cgi?id=234329


Patch by Alex Christensen  on 2021-12-15
Reviewed by Tim Horton.

r283897 got me so close.  I generate the entitlements and the sandbox profile.  Now I need to actually sign with the entitlements.
I verified by building two roots that before this change, the codesign invocation looked like this:
/usr/bin/codesign --force --sign - --generate-entitlement-der .../Root/System/Library/Frameworks/WebKit.framework/Daemons/adattributiond
and after this change it looks like this:
/usr/bin/codesign --force --sign - --entitlements .../TempContent/Objects/WebKit.build/adattributiond.build/adattributiond.entitlements
--generate-entitlement-der .../Root/System/Library/Frameworks/WebKit.framework/Daemons/adattributiond

* Configurations/adattributiond.xcconfig:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/adattributiond.xcconfig




Diff

Modified: trunk/Source/WebKit/ChangeLog (287099 => 287100)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 20:55:50 UTC (rev 287099)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 21:06:48 UTC (rev 287100)
@@ -1,3 +1,20 @@
+2021-12-15  Alex Christensen  
+
+Actually use adattributiond.entitlements when code signing adattributiond
+https://bugs.webkit.org/show_bug.cgi?id=234329
+
+
+Reviewed by Tim Horton.
+
+r283897 got me so close.  I generate the entitlements and the sandbox profile.  Now I need to actually sign with the entitlements.
+I verified by building two roots that before this change, the codesign invocation looked like this:
+/usr/bin/codesign --force --sign - --generate-entitlement-der .../Root/System/Library/Frameworks/WebKit.framework/Daemons/adattributiond
+and after this change it looks like this:
+/usr/bin/codesign --force --sign - --entitlements .../TempContent/Objects/WebKit.build/adattributiond.build/adattributiond.entitlements
+--generate-entitlement-der .../Root/System/Library/Frameworks/WebKit.framework/Daemons/adattributiond
+
+* Configurations/adattributiond.xcconfig:
+
 2021-12-15  Per Arne Vollan  
 
 [iOS][WP] Add access to required syscall


Modified: trunk/Source/WebKit/Configurations/adattributiond.xcconfig (287099 => 287100)

--- trunk/Source/WebKit/Configurations/adattributiond.xcconfig	2021-12-15 20:55:50 UTC (rev 287099)
+++ trunk/Source/WebKit/Configurations/adattributiond.xcconfig	2021-12-15 21:06:48 UTC (rev 287100)
@@ -30,5 +30,9 @@
 
 WK_PROCESSED_XCENT_FILE=$(TEMP_FILE_DIR)/$(FULL_PRODUCT_NAME).entitlements
 
+WK_CODE_SIGN_FLAGS = $(WK_CODE_SIGN_FLAGS_$(WK_PLATFORM_NAME));
+WK_CODE_SIGN_FLAGS_iphoneos = --entitlements $(WK_PROCESSED_XCENT_FILE);
+OTHER_CODE_SIGN_FLAGS = $(WK_CODE_SIGN_FLAGS);
+
 INSTALL_PATH[sdk=iphone*] = $(WEBKIT_FRAMEWORKS_DIR)/WebKit.framework/Daemons;
 INSTALL_PATH[sdk=macosx*] = $(WEBKIT_FRAMEWORKS_DIR)/WebKit.framework/Versions/A/Daemons;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287099] branches/safari-613.1.12-branch/Source/WebKit

2021-12-15 Thread repstein

Title: [287099] branches/safari-613.1.12-branch/Source/WebKit








Revision 287099
Author repst...@apple.com
Date 2021-12-15 12:55:50 -0800 (Wed, 15 Dec 2021)


Log Message
Cherry-pick r287098. rdar://problem/86502081

[iOS][WP] Add access to required syscall
https://bugs.webkit.org/show_bug.cgi?id=234336


Reviewed by Brent Fulgham.

Add access to required system call in the WebProcess sandbox on iOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.12-branch/Source/WebKit/ChangeLog
branches/safari-613.1.12-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in




Diff

Modified: branches/safari-613.1.12-branch/Source/WebKit/ChangeLog (287098 => 287099)

--- branches/safari-613.1.12-branch/Source/WebKit/ChangeLog	2021-12-15 20:51:38 UTC (rev 287098)
+++ branches/safari-613.1.12-branch/Source/WebKit/ChangeLog	2021-12-15 20:55:50 UTC (rev 287099)
@@ -1,5 +1,34 @@
 2021-12-15  Alan Coon  
 
+Cherry-pick r287098. rdar://problem/86502081
+
+[iOS][WP] Add access to required syscall
+https://bugs.webkit.org/show_bug.cgi?id=234336
+
+
+Reviewed by Brent Fulgham.
+
+Add access to required system call in the WebProcess sandbox on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-15  Per Arne Vollan  
+
+[iOS][WP] Add access to required syscall
+https://bugs.webkit.org/show_bug.cgi?id=234336
+
+
+Reviewed by Brent Fulgham.
+
+Add access to required system call in the WebProcess sandbox on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
+2021-12-15  Alan Coon  
+
 Cherry-pick r287069. rdar://problem/86502081
 
 [iOS][WP] Add access to required syscall


Modified: branches/safari-613.1.12-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (287098 => 287099)

--- branches/safari-613.1.12-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-15 20:51:38 UTC (rev 287098)
+++ branches/safari-613.1.12-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-15 20:55:50 UTC (rev 287099)
@@ -1560,6 +1560,11 @@
 (define (kernel-mig-routine-in-use)
 (kernel-mig-routine
 (when (defined? '_mach_make_memory_entry) _mach_make_memory_entry)
+#if PLATFORM(WATCHOS)
+(when (defined? 'mach_make_memory_entry) mach_make_memory_entry)
+(when (defined? 'mach_make_memory_entry_64) mach_make_memory_entry_64)
+(when (defined? 'vm_copy) vm_copy)
+#endif
 host_get_io_master
 io_connect_async_method
 io_connect_method
@@ -1636,11 +1641,6 @@
 (when (defined? 'mach_port_is_connection_for_service)
 (allow mach-message-send (kernel-mig-routine mach_port_is_connection_for_service))
 )
-
-(if (and gizmo? (defined? 'mach_make_memory_entry))
-(allow mach-message-send (kernel-mig-routine mach_make_memory_entry)))
-(if (and gizmo? (defined? 'mach_make_memory_entry_64))
-(allow mach-message-send (kernel-mig-routine mach_make_memory_entry_64)))
 )
 )
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287098] trunk/Source/WebKit

2021-12-15 Thread pvollan

Title: [287098] trunk/Source/WebKit








Revision 287098
Author pvol...@apple.com
Date 2021-12-15 12:51:38 -0800 (Wed, 15 Dec 2021)


Log Message
[iOS][WP] Add access to required syscall
https://bugs.webkit.org/show_bug.cgi?id=234336


Reviewed by Brent Fulgham.

Add access to required system call in the WebProcess sandbox on iOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (287097 => 287098)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 20:15:38 UTC (rev 287097)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 20:51:38 UTC (rev 287098)
@@ -1,3 +1,15 @@
+2021-12-15  Per Arne Vollan  
+
+[iOS][WP] Add access to required syscall
+https://bugs.webkit.org/show_bug.cgi?id=234336
+
+
+Reviewed by Brent Fulgham.
+
+Add access to required system call in the WebProcess sandbox on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
 2021-12-15  Jer Noble  
 
 [Mac] Adopt -[NSScreen safeAreaInsets]


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (287097 => 287098)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-15 20:15:38 UTC (rev 287097)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-15 20:51:38 UTC (rev 287098)
@@ -1561,6 +1561,11 @@
 (define (kernel-mig-routine-in-use)
 (kernel-mig-routine
 (when (defined? '_mach_make_memory_entry) _mach_make_memory_entry)
+#if PLATFORM(WATCHOS)
+(when (defined? 'mach_make_memory_entry) mach_make_memory_entry)
+(when (defined? 'mach_make_memory_entry_64) mach_make_memory_entry_64)
+(when (defined? 'vm_copy) vm_copy)
+#endif
 host_get_io_master
 io_connect_async_method
 io_connect_method
@@ -1637,11 +1642,6 @@
 (when (defined? 'mach_port_is_connection_for_service)
 (allow mach-message-send (kernel-mig-routine mach_port_is_connection_for_service))
 )
-
-(if (and gizmo? (defined? 'mach_make_memory_entry))
-(allow mach-message-send (kernel-mig-routine mach_make_memory_entry)))
-(if (and gizmo? (defined? 'mach_make_memory_entry_64))
-(allow mach-message-send (kernel-mig-routine mach_make_memory_entry_64)))
 )
 )
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287097] branches/safari-613.1.12-branch/Source/WebKit

2021-12-15 Thread repstein

Title: [287097] branches/safari-613.1.12-branch/Source/WebKit








Revision 287097
Author repst...@apple.com
Date 2021-12-15 12:15:38 -0800 (Wed, 15 Dec 2021)


Log Message
Cherry-pick r287069. rdar://problem/86502081

[iOS][WP] Add access to required syscall
https://bugs.webkit.org/show_bug.cgi?id=234336


Reviewed by Tim Horton.

Add required syscall to the WebContent process' sandbox on iOS. This syscall was blocked in
https://trac.webkit.org/changeset/286673/webkit.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.12-branch/Source/WebKit/ChangeLog
branches/safari-613.1.12-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in




Diff

Modified: branches/safari-613.1.12-branch/Source/WebKit/ChangeLog (287096 => 287097)

--- branches/safari-613.1.12-branch/Source/WebKit/ChangeLog	2021-12-15 20:15:35 UTC (rev 287096)
+++ branches/safari-613.1.12-branch/Source/WebKit/ChangeLog	2021-12-15 20:15:38 UTC (rev 287097)
@@ -1,5 +1,36 @@
 2021-12-15  Alan Coon  
 
+Cherry-pick r287069. rdar://problem/86502081
+
+[iOS][WP] Add access to required syscall
+https://bugs.webkit.org/show_bug.cgi?id=234336
+
+
+Reviewed by Tim Horton.
+
+Add required syscall to the WebContent process' sandbox on iOS. This syscall was blocked in
+https://trac.webkit.org/changeset/286673/webkit.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-15  Per Arne Vollan  
+
+[iOS][WP] Add access to required syscall
+https://bugs.webkit.org/show_bug.cgi?id=234336
+
+
+Reviewed by Tim Horton.
+
+Add required syscall to the WebContent process' sandbox on iOS. This syscall was blocked in
+https://trac.webkit.org/changeset/286673/webkit.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
+2021-12-15  Alan Coon  
+
 Cherry-pick r286961. rdar://problem/86343642
 
 REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS


Modified: branches/safari-613.1.12-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (287096 => 287097)

--- branches/safari-613.1.12-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-15 20:15:35 UTC (rev 287096)
+++ branches/safari-613.1.12-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-15 20:15:38 UTC (rev 287097)
@@ -1636,6 +1636,11 @@
 (when (defined? 'mach_port_is_connection_for_service)
 (allow mach-message-send (kernel-mig-routine mach_port_is_connection_for_service))
 )
+
+(if (and gizmo? (defined? 'mach_make_memory_entry))
+(allow mach-message-send (kernel-mig-routine mach_make_memory_entry)))
+(if (and gizmo? (defined? 'mach_make_memory_entry_64))
+(allow mach-message-send (kernel-mig-routine mach_make_memory_entry_64)))
 )
 )
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287096] branches/safari-613.1.12-branch/Source/WebKit

2021-12-15 Thread repstein

Title: [287096] branches/safari-613.1.12-branch/Source/WebKit








Revision 287096
Author repst...@apple.com
Date 2021-12-15 12:15:35 -0800 (Wed, 15 Dec 2021)


Log Message
Cherry-pick r286961. rdar://problem/86343642

REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=234181


Reviewed by Eric Carlson.

Use network connection state change callback to know when connection fails or is cancelled.
Introduce ConnectionStateTracker to know when to stop reading new UDP packets.
ConnectionStateTracker will be stopped when state is changed to failed or cancelled as well as when the whole connection is closed.
Renaming m_nwConnections to m_connections as m_nwConnections name was already used.
Reduce error logging to only new error codes or when connectino enters unrecoverable failure (hence changing to failed state).

Covered by existing tests.

* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h:
* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.12-branch/Source/WebKit/ChangeLog
branches/safari-613.1.12-branch/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h
branches/safari-613.1.12-branch/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm




Diff

Modified: branches/safari-613.1.12-branch/Source/WebKit/ChangeLog (287095 => 287096)

--- branches/safari-613.1.12-branch/Source/WebKit/ChangeLog	2021-12-15 20:14:08 UTC (rev 287095)
+++ branches/safari-613.1.12-branch/Source/WebKit/ChangeLog	2021-12-15 20:15:35 UTC (rev 287096)
@@ -1,3 +1,46 @@
+2021-12-15  Alan Coon  
+
+Cherry-pick r286961. rdar://problem/86343642
+
+REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS
+https://bugs.webkit.org/show_bug.cgi?id=234181
+
+
+Reviewed by Eric Carlson.
+
+Use network connection state change callback to know when connection fails or is cancelled.
+Introduce ConnectionStateTracker to know when to stop reading new UDP packets.
+ConnectionStateTracker will be stopped when state is changed to failed or cancelled as well as when the whole connection is closed.
+Renaming m_nwConnections to m_connections as m_nwConnections name was already used.
+Reduce error logging to only new error codes or when connectino enters unrecoverable failure (hence changing to failed state).
+
+Covered by existing tests.
+
+* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h:
+* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-13  Youenn Fablet  
+
+REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS
+https://bugs.webkit.org/show_bug.cgi?id=234181
+
+
+Reviewed by Eric Carlson.
+
+Use network connection state change callback to know when connection fails or is cancelled.
+Introduce ConnectionStateTracker to know when to stop reading new UDP packets.
+ConnectionStateTracker will be stopped when state is changed to failed or cancelled as well as when the whole connection is closed.
+Renaming m_nwConnections to m_connections as m_nwConnections name was already used.
+Reduce error logging to only new error codes or when connectino enters unrecoverable failure (hence changing to failed state).
+
+Covered by existing tests.
+
+* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h:
+* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
+
 2021-12-13  Youenn Fablet  
 
 Fix ServiceWorker downloads


Modified: branches/safari-613.1.12-branch/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h (287095 => 287096)

--- branches/safari-613.1.12-branch/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h	2021-12-15 20:14:08 UTC (rev 287095)
+++ branches/safari-613.1.12-branch/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h	2021-12-15 20:15:35 UTC (rev 287096)
@@ -77,7 +77,7 @@
 
 NetworkRTCProvider& m_rtcProvider;
 WebCore::LibWebRTCSocketIdentifier m_identifier;
-Ref m_nwConnections;
+Ref m_connections;
 };
 
 } // namespace WebKit


Modified: branches/safari-613.1.12-branch/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm (287095 => 287096)

--- branches/safari-613.1.12-branch/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm	2021-12-15 20:14:08 UTC (rev 287095)
+++ branches/safari-613.1.12-branch/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm	2021-12-15 20:15:35 UTC (rev 287096)
@@ -58,11 +58,21 @@
 void sendTo(const uint8_t*, size_t, const rtc::SocketAddress&, const rtc::PacketOptions&);
 void

[webkit-changes] [287095] trunk/Source/WebCore

2021-12-15 Thread shvaikalesh

Title: [287095] trunk/Source/WebCore








Revision 287095
Author shvaikal...@gmail.com
Date 2021-12-15 12:14:08 -0800 (Wed, 15 Dec 2021)


Log Message
[WebIDL] Remove the now-unused [DocumentEventHandler] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=234047

Reviewed by Darin Adler.

[DocumentEventHandler] was originally introduced just to accommodate onselectionchange
IDL attribute, which became unnecessary as of r287089. Also, HTML spec has no concept
of reflecting event handlers to Document, only to Window [1].

[1] https://html.spec.whatwg.org/multipage/webappapis.html#window-reflecting-body-element-event-handler-set

No new tests, no behavior change.

* bindings/js/JSEventListener.cpp:
(WebCore::documentEventHandlerAttribute): Deleted.
(WebCore::setDocumentEventHandlerAttribute): Deleted.
* bindings/js/JSEventListener.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
* bindings/scripts/IDLAttributes.json:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSEventListener.cpp
trunk/Source/WebCore/bindings/js/JSEventListener.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.json




Diff

Modified: trunk/Source/WebCore/ChangeLog (287094 => 287095)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 20:09:13 UTC (rev 287094)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 20:14:08 UTC (rev 287095)
@@ -1,3 +1,27 @@
+2021-12-15  Alexey Shvayka  
+
+[WebIDL] Remove the now-unused [DocumentEventHandler] extended attribute
+https://bugs.webkit.org/show_bug.cgi?id=234047
+
+Reviewed by Darin Adler.
+
+[DocumentEventHandler] was originally introduced just to accommodate onselectionchange
+IDL attribute, which became unnecessary as of r287089. Also, HTML spec has no concept
+of reflecting event handlers to Document, only to Window [1].
+
+[1] https://html.spec.whatwg.org/multipage/webappapis.html#window-reflecting-body-element-event-handler-set
+
+No new tests, no behavior change.
+
+* bindings/js/JSEventListener.cpp:
+(WebCore::documentEventHandlerAttribute): Deleted.
+(WebCore::setDocumentEventHandlerAttribute): Deleted.
+* bindings/js/JSEventListener.h:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateAttributeGetterBodyDefinition):
+(GenerateAttributeSetterBodyDefinition):
+* bindings/scripts/IDLAttributes.json:
+
 2021-12-15  Jer Noble  
 
 [Mac] Adopt -[NSScreen safeAreaInsets]


Modified: trunk/Source/WebCore/bindings/js/JSEventListener.cpp (287094 => 287095)

--- trunk/Source/WebCore/bindings/js/JSEventListener.cpp	2021-12-15 20:09:13 UTC (rev 287094)
+++ trunk/Source/WebCore/bindings/js/JSEventListener.cpp	2021-12-15 20:14:08 UTC (rev 287095)
@@ -316,29 +316,4 @@
 setEventHandlerAttribute(lexicalGlobalObject, wrapper, window, eventType, value);
 }
 
-JSC::JSValue documentEventHandlerAttribute(HTMLElement& element, const AtomString& eventType, DOMWrapperWorld& isolatedWorld)
-{
-auto& document = element.document();
-return eventHandlerAttribute(document.attributeEventListener(eventType, isolatedWorld), document);
-}
-
-void setDocumentEventHandlerAttribute(JSC::JSGlobalObject& lexicalGlobalObject, JSC::JSObject& wrapper, HTMLElement& element, const AtomString& eventType, JSC::JSValue value)
-{
-ASSERT(wrapper.globalObject());
-auto& document = element.document();
-auto* documentWrapper = JSC::jsCast(toJS(, JSC::jsCast(wrapper.globalObject()), document));
-ASSERT(documentWrapper);
-document.setAttributeEventListener(eventType, createEventListenerForEventHandlerAttribute(lexicalGlobalObject, value, *documentWrapper), currentWorld(lexicalGlobalObject));
-}
-
-JSC::JSValue documentEventHandlerAttribute(Document& document, const AtomString& eventType, DOMWrapperWorld& isolatedWorld)
-{
-return eventHandlerAttribute(document, eventType, isolatedWorld);
-}
-
-void setDocumentEventHandlerAttribute(JSC::JSGlobalObject& lexicalGlobalObject, JSC::JSObject& wrapper, Document& document, const AtomString& eventType, JSC::JSValue value)
-{
-setEventHandlerAttribute(lexicalGlobalObject, wrapper, document, eventType, value);
-}
-
 } // namespace WebCore


Modified: trunk/Source/WebCore/bindings/js/JSEventListener.h (287094 => 287095)

--- trunk/Source/WebCore/bindings/js/JSEventListener.h	2021-12-15 20:09:13 UTC (rev 287094)
+++ trunk/Source/WebCore/bindings/js/JSEventListener.h	2021-12-15 20:14:08 UTC (rev 287095)
@@ -92,12 +92,6 @@
 JSC::JSValue windowEventHandlerAttribute(DOMWindow&, const AtomString& eventType, DOMWrapperWorld&);
 void setWindowEventHandlerAttribute(JSC::JSGlobalObject&, JSC::JSObject&, DOMWindow&, const AtomString& eventType, JSC::JSValue);
 
-// Like the functions above, but for attributes that forward event handlers to the document rather than setting

[webkit-changes] [287094] trunk/Source

2021-12-15 Thread jer . noble

Title: [287094] trunk/Source








Revision 287094
Author jer.no...@apple.com
Date 2021-12-15 12:09:13 -0800 (Wed, 15 Dec 2021)


Log Message
[Mac] Adopt -[NSScreen safeAreaInsets]
https://bugs.webkit.org/show_bug.cgi?id=234291


Reviewed by Eric Carlson.

Source/WebCore:

Adopt -safeAreaInsets and rename screenRectAvoidingMenuBar() to safeScreenFrame().

* platform/PlatformScreen.h:
* platform/mac/PlatformScreenMac.mm:
(WebCore::safeScreenFrame): Renamed from screenRectAvoidingMenuBar.

Source/WebKit:

Drive-by fix: use the safeAreaFrame() when determining where to place the exit
fullscreen placeholder image.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimationAndExitImmediately:]):

Source/WTF:

* wtf/PlatformHave.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformScreen.h
trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (287093 => 287094)

--- trunk/Source/WTF/ChangeLog	2021-12-15 19:57:41 UTC (rev 287093)
+++ trunk/Source/WTF/ChangeLog	2021-12-15 20:09:13 UTC (rev 287094)
@@ -1,3 +1,13 @@
+2021-12-15  Jer Noble  
+
+[Mac] Adopt -[NSScreen safeAreaInsets]
+https://bugs.webkit.org/show_bug.cgi?id=234291
+
+
+Reviewed by Eric Carlson.
+
+* wtf/PlatformHave.h:
+
 2021-12-15  Chris Dumez  
 
 Move SWServers from NetworkProcess to NetworkSession


Modified: trunk/Source/WTF/wtf/PlatformHave.h (287093 => 287094)

--- trunk/Source/WTF/wtf/PlatformHave.h	2021-12-15 19:57:41 UTC (rev 287093)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2021-12-15 20:09:13 UTC (rev 287094)
@@ -1120,3 +1120,7 @@
 #if ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 16)
 #define HAVE_UIFINDINTERACTION 1
 #endif
+
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 12
+#define HAVE_NSSCREEN_SAFE_AREA 1
+#endif


Modified: trunk/Source/WebCore/ChangeLog (287093 => 287094)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 19:57:41 UTC (rev 287093)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 20:09:13 UTC (rev 287094)
@@ -1,3 +1,17 @@
+2021-12-15  Jer Noble  
+
+[Mac] Adopt -[NSScreen safeAreaInsets]
+https://bugs.webkit.org/show_bug.cgi?id=234291
+
+
+Reviewed by Eric Carlson.
+
+Adopt -safeAreaInsets and rename screenRectAvoidingMenuBar() to safeScreenFrame().
+
+* platform/PlatformScreen.h:
+* platform/mac/PlatformScreenMac.mm:
+(WebCore::safeScreenFrame): Renamed from screenRectAvoidingMenuBar.
+
 2021-12-15  Alex Christensen  
 
 More cleanup after PluginProcess removal


Modified: trunk/Source/WebCore/platform/PlatformScreen.h (287093 => 287094)

--- trunk/Source/WebCore/platform/PlatformScreen.h	2021-12-15 19:57:41 UTC (rev 287093)
+++ trunk/Source/WebCore/platform/PlatformScreen.h	2021-12-15 20:09:13 UTC (rev 287094)
@@ -140,7 +140,7 @@
 IORegistryGPUID gpuIDForDisplay(PlatformDisplayID);
 IORegistryGPUID gpuIDForDisplayMask(uint32_t);
 
-WEBCORE_EXPORT FloatRect screenRectAvoidingMenuBar(NSScreen *);
+WEBCORE_EXPORT FloatRect safeScreenFrame(NSScreen *);
 
 #endif // !PLATFORM(MAC)
 


Modified: trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm (287093 => 287094)

--- trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm	2021-12-15 19:57:41 UTC (rev 287093)
+++ trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm	2021-12-15 20:09:13 UTC (rev 287094)
@@ -44,10 +44,6 @@
 #import 
 #endif
 
-#if USE(APPLE_INTERNAL_SDK) && __has_include()
-#import 
-#endif
-
 namespace WebCore {
 
 // These functions scale between screen and page coordinates because _javascript_/DOM operations
@@ -419,14 +415,16 @@
 return flippedPoint;
 }
 
-#if USE(APPLE_INTERNAL_SDK) && __has_include()
-#import 
-#else
-FloatRect screenRectAvoidingMenuBar(NSScreen* screen)
+FloatRect safeScreenFrame(NSScreen* screen)
 {
-return screen.frame;
+FloatRect frame = screen.frame;
+#if HAVE(NSSCREEN_SAFE_AREA)
+auto insets = screen.safeAreaInsets;
+frame.contract(insets.left + insets.right, insets.top + insets.bottom);
+frame.move(insets.left, insets.bottom);
+#endif
+return frame;
 }
-#endif
 
 
 } // namespace WebCore


Modified: trunk/Source/WebKit/ChangeLog (287093 => 287094)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 19:57:41 UTC (rev 287093)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 20:09:13 UTC (rev 287094)
@@ -1,3 +1,18 @@
+2021-12-15  Jer Noble  
+
+[Mac] Adopt -[NSScreen safeAreaInsets]
+https://bugs.webkit.org/show_bug.cgi?id=234291
+
+
+Reviewed by Eric Carlson.
+
+Drive-by fix: use the safeAreaFrame() when determining where to place the exit
+

[webkit-changes] [287093] trunk/Source

2021-12-15 Thread commit-queue

Title: [287093] trunk/Source








Revision 287093
Author commit-qu...@webkit.org
Date 2021-12-15 11:57:41 -0800 (Wed, 15 Dec 2021)


Log Message
More cleanup after PluginProcess removal
https://bugs.webkit.org/show_bug.cgi?id=234354

Patch by Alex Christensen  on 2021-12-15
Reviewed by Tim Horton.

Source/WebCore:

* platform/network/ProxyServer.h:

Source/WebKit:

Remove some unused code, unify some sources.

* Configurations/PluginProcessShim.xcconfig: Removed.
* Configurations/PluginService.xcconfig: Removed.
* DerivedSources.make:
* Shared/Cocoa/SharedRingBufferStorage.cpp:
(WebKit::ReadOnlySharedRingBufferStorage::allocate):
(WebKit::SharedRingBufferStorage::setStorage):
(WebKit::SharedRingBufferStorage::allocate):
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultMediaSessionCoordinatorEnabled):
* Sources.txt:
* UIProcess/WebProcessPool.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::platformLayer const):
(WebKit::PluginView::contentsScaleFactor):
(WebKit::PluginView::pluginProcessCrashed): Deleted.
(WebKit::PluginView::proxiesForURL): Deleted.
(WebKit::PluginView::cookiesForURL): Deleted.
(WebKit::PluginView::setCookiesForURL): Deleted.
* WebProcess/Plugins/PluginView.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ProxyServer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/DerivedSources.make
trunk/Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/Plugins/PluginController.h
trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit/WebProcess/Plugins/PluginView.h


Removed Paths

trunk/Source/WebKit/Configurations/PluginProcessShim.xcconfig
trunk/Source/WebKit/Configurations/PluginService.xcconfig




Diff

Modified: trunk/Source/WebCore/ChangeLog (287092 => 287093)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 19:46:23 UTC (rev 287092)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 19:57:41 UTC (rev 287093)
@@ -1,3 +1,12 @@
+2021-12-15  Alex Christensen  
+
+More cleanup after PluginProcess removal
+https://bugs.webkit.org/show_bug.cgi?id=234354
+
+Reviewed by Tim Horton.
+
+* platform/network/ProxyServer.h:
+
 2021-12-15  Antti Koivisto  
 
 [:has() pseudo-class] Use Bloom filter to quickly reject :has() selectors


Modified: trunk/Source/WebCore/platform/network/ProxyServer.h (287092 => 287093)

--- trunk/Source/WebCore/platform/network/ProxyServer.h	2021-12-15 19:46:23 UTC (rev 287092)
+++ trunk/Source/WebCore/platform/network/ProxyServer.h	2021-12-15 19:57:41 UTC (rev 287093)
@@ -66,6 +66,7 @@
 };
 
 // Return a vector of proxy servers for the given URL.
+// FIXME: This is dead code. Remove it.
 WEBCORE_EXPORT Vector proxyServersForURL(const URL&);
 
 // Converts the given vector of proxy servers to a PAC string, as described in


Modified: trunk/Source/WebKit/ChangeLog (287092 => 287093)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 19:46:23 UTC (rev 287092)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 19:57:41 UTC (rev 287093)
@@ -1,3 +1,34 @@
+2021-12-15  Alex Christensen  
+
+More cleanup after PluginProcess removal
+https://bugs.webkit.org/show_bug.cgi?id=234354
+
+Reviewed by Tim Horton.
+
+Remove some unused code, unify some sources.
+
+* Configurations/PluginProcessShim.xcconfig: Removed.
+* Configurations/PluginService.xcconfig: Removed.
+* DerivedSources.make:
+* Shared/Cocoa/SharedRingBufferStorage.cpp:
+(WebKit::ReadOnlySharedRingBufferStorage::allocate):
+(WebKit::SharedRingBufferStorage::setStorage):
+(WebKit::SharedRingBufferStorage::allocate):
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultMediaSessionCoordinatorEnabled):
+* Sources.txt:
+* UIProcess/WebProcessPool.h:
+* WebKit.xcodeproj/project.pbxproj:
+* WebProcess/Plugins/PluginController.h:
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::platformLayer const):
+(WebKit::PluginView::contentsScaleFactor):
+(WebKit::PluginView::pluginProcessCrashed): Deleted.
+(WebKit::PluginView::proxiesForURL): Deleted.
+(WebKit::PluginView::cookiesForURL): Deleted.
+(WebKit::PluginView::setCookiesForURL): Deleted.
+* WebProcess/Plugins/PluginView.h:
+
 2021-12-15  Sihui Liu  
 
 REGRESSION (r286936): Many webstorage layout tests have become flaky failures


Deleted: trunk/Source/WebKit/Configurations/PluginProcessShim.xcconfig (287092 => 287093)

--- trunk/Source/WebKit/Configurations/PluginProcessShim.xcconfig	2021-12-15 19:46:23 UTC (rev 287092)
+++

[webkit-changes] [287092] trunk/Source/bmalloc

2021-12-15 Thread ysuzuki

Title: [287092] trunk/Source/bmalloc








Revision 287092
Author ysuz...@apple.com
Date 2021-12-15 11:46:23 -0800 (Wed, 15 Dec 2021)


Log Message
[libpas] Implement atomics in inline assembly if compiler is using ARM64
https://bugs.webkit.org/show_bug.cgi?id=234333

Reviewed by Filip Pizlo.

libpas relies on how value is loaded since we are using `pas_depend`.
For example, we expect that compare_and_swap_strong returns a loaded value.
But it is not guaranteed: the compiler can return argument's old_value
if we ensure that the loaded value equals to old_value. In that case,
pas_depend's chain is broken because we start using distinct registers.
This can happen if atomics is implemented as LL/SC loop.

This patch implements atomics in inline assembly if the build is ARM64 (not ARM64E),
so that we ensure that we return loaded value's register instead of old value's one.

This significantly improved crash rate of libpas test suite on ARM64 (on ARM64E, all
tests pass already).

* libpas/src/libpas/pas_config_prefix.h:
* libpas/src/libpas/pas_lock.h:
(pas_lock_unlock):
* libpas/src/libpas/pas_lock_free_read_ptr_ptr_hashtable.h:
(pas_lock_free_read_ptr_ptr_hashtable_find):
* libpas/src/libpas/pas_utils.h:
(pas_atomic_store_uint8):
(pas_compare_and_swap_uint8_weak):
(pas_compare_and_swap_uint8_strong):
(pas_compare_and_swap_uint16_weak):
(pas_compare_and_swap_uint32_weak):
(pas_compare_and_swap_uint32_strong):
(pas_compare_and_swap_uint64_weak):
(pas_compare_and_swap_uint64_strong):
(pas_atomic_store_bool):
(pas_compare_and_swap_bool_weak):
(pas_compare_and_swap_bool_strong):
(pas_compare_and_swap_uintptr_weak):
(pas_compare_and_swap_uintptr_strong):
(pas_compare_and_swap_ptr_weak):
(pas_compare_and_swap_ptr_strong):
(pas_compare_and_swap_pair_weak):
(pas_compare_and_swap_pair_strong):
(pas_atomic_load_pair):
(pas_atomic_store_pair):
(pas_compare_ptr_opaque):

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h
trunk/Source/bmalloc/libpas/src/libpas/pas_lock.h
trunk/Source/bmalloc/libpas/src/libpas/pas_lock_free_read_ptr_ptr_hashtable.h
trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (287091 => 287092)

--- trunk/Source/bmalloc/ChangeLog	2021-12-15 19:45:12 UTC (rev 287091)
+++ trunk/Source/bmalloc/ChangeLog	2021-12-15 19:46:23 UTC (rev 287092)
@@ -1,3 +1,50 @@
+2021-12-15  Yusuke Suzuki  
+
+[libpas] Implement atomics in inline assembly if compiler is using ARM64
+https://bugs.webkit.org/show_bug.cgi?id=234333
+
+Reviewed by Filip Pizlo.
+
+libpas relies on how value is loaded since we are using `pas_depend`.
+For example, we expect that compare_and_swap_strong returns a loaded value.
+But it is not guaranteed: the compiler can return argument's old_value
+if we ensure that the loaded value equals to old_value. In that case,
+pas_depend's chain is broken because we start using distinct registers.
+This can happen if atomics is implemented as LL/SC loop.
+
+This patch implements atomics in inline assembly if the build is ARM64 (not ARM64E),
+so that we ensure that we return loaded value's register instead of old value's one.
+
+This significantly improved crash rate of libpas test suite on ARM64 (on ARM64E, all
+tests pass already).
+
+* libpas/src/libpas/pas_config_prefix.h:
+* libpas/src/libpas/pas_lock.h:
+(pas_lock_unlock):
+* libpas/src/libpas/pas_lock_free_read_ptr_ptr_hashtable.h:
+(pas_lock_free_read_ptr_ptr_hashtable_find):
+* libpas/src/libpas/pas_utils.h:
+(pas_atomic_store_uint8):
+(pas_compare_and_swap_uint8_weak):
+(pas_compare_and_swap_uint8_strong):
+(pas_compare_and_swap_uint16_weak):
+(pas_compare_and_swap_uint32_weak):
+(pas_compare_and_swap_uint32_strong):
+(pas_compare_and_swap_uint64_weak):
+(pas_compare_and_swap_uint64_strong):
+(pas_atomic_store_bool):
+(pas_compare_and_swap_bool_weak):
+(pas_compare_and_swap_bool_strong):
+(pas_compare_and_swap_uintptr_weak):
+(pas_compare_and_swap_uintptr_strong):
+(pas_compare_and_swap_ptr_weak):
+(pas_compare_and_swap_ptr_strong):
+(pas_compare_and_swap_pair_weak):
+(pas_compare_and_swap_pair_strong):
+(pas_atomic_load_pair):
+(pas_atomic_store_pair):
+(pas_compare_ptr_opaque):
+
 2021-12-14  Yusuke Suzuki  
 
 Unreviewed, fix Xcode build of libpas


Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h (287091 => 287092)

--- trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h	2021-12-15 19:45:12 UTC (rev 287091)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h	2021-12-15 19:46:23 UTC (rev 287092)
@@ -31,8 +31,14 @@
 
 #if (defined(__arm64__) && defined(__APPLE__)) || defined(__aarch64__) ||

[webkit-changes] [287091] trunk/Source/WebCore

2021-12-15 Thread antti

Title: [287091] trunk/Source/WebCore








Revision 287091
Author an...@apple.com
Date 2021-12-15 11:45:12 -0800 (Wed, 15 Dec 2021)


Log Message
[:has() pseudo-class] Use Bloom filter to quickly reject :has() selectors
https://bugs.webkit.org/show_bug.cgi?id=234341

Reviewed by Dean Jackson.

We can dramatically speed up cases where there are many :has rules, most of which don't match their argument
by building a Bloom filter describing the features of the subtree.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchHasPseudoClass const):

Build and cache HasSelectorFilter per element/filter type. It will be constructed only if multiple :has()
selectors are tested for the same element (otherwise the regular match cache is more efficient).
Use it to quickly reject selectors.
Also add a basic inital optimization to bail out if there are no child/sibling elements that could match.

* css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectElementIdentifierHashes):
(WebCore::SelectorFilter::collectSimpleSelectorHash):
(WebCore::SelectorFilter::collectSelectorHashes):
(WebCore::SelectorFilter::chooseSelectorHashesForFilter):
(WebCore::collectElementIdentifierHashes): Deleted.
(WebCore::collectSimpleSelectorHash): Deleted.
(WebCore::collectSelectorHashes): Deleted.
(WebCore::chooseSelectorHashesForFilter): Deleted.
* css/SelectorFilter.h:
* style/HasSelectorFilter.cpp: Added.
(WebCore::Style::HasSelectorFilter::HasSelectorFilter):
(WebCore::Style::HasSelectorFilter::typeForMatchElement):
(WebCore::Style::HasSelectorFilter::makeKey):

The key consists of the most specific string in the rightmost compound of the selector along with
:hover pseudo class, if any.

(WebCore::Style::HasSelectorFilter::add):

Add an Element to the filter.
The features collected are the same as for the regular selector filter, plus permutations with
:hover pseudo-class if it would match.

* style/HasSelectorFilter.h: Copied from Source/WebCore/style/SelectorMatchingState.h.
(WebCore::Style::HasSelectorFilter::type const):
(WebCore::Style::HasSelectorFilter::reject const):

Add HasSelectorFilter which uses non-counting BloomFilter internally. The size of the filter is 512 bytes.

* style/SelectorMatchingState.h:
(WebCore::Style::makeHasPseudoClassSelectorFilterKey):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorFilter.cpp
trunk/Source/WebCore/css/SelectorFilter.h
trunk/Source/WebCore/style/SelectorMatchingState.h


Added Paths

trunk/Source/WebCore/style/HasSelectorFilter.cpp
trunk/Source/WebCore/style/HasSelectorFilter.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (287090 => 287091)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 19:42:28 UTC (rev 287090)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 19:45:12 UTC (rev 287091)
@@ -1,3 +1,56 @@
+2021-12-15  Antti Koivisto  
+
+[:has() pseudo-class] Use Bloom filter to quickly reject :has() selectors
+https://bugs.webkit.org/show_bug.cgi?id=234341
+
+Reviewed by Dean Jackson.
+
+We can dramatically speed up cases where there are many :has rules, most of which don't match their argument
+by building a Bloom filter describing the features of the subtree.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::matchHasPseudoClass const):
+
+Build and cache HasSelectorFilter per element/filter type. It will be constructed only if multiple :has()
+selectors are tested for the same element (otherwise the regular match cache is more efficient).
+Use it to quickly reject selectors.
+Also add a basic inital optimization to bail out if there are no child/sibling elements that could match.
+
+* css/SelectorFilter.cpp:
+(WebCore::SelectorFilter::collectElementIdentifierHashes):
+(WebCore::SelectorFilter::collectSimpleSelectorHash):
+(WebCore::SelectorFilter::collectSelectorHashes):
+(WebCore::SelectorFilter::chooseSelectorHashesForFilter):
+(WebCore::collectElementIdentifierHashes): Deleted.
+(WebCore::collectSimpleSelectorHash): Deleted.
+(WebCore::collectSelectorHashes): Deleted.
+(WebCore::chooseSelectorHashesForFilter): Deleted.
+* css/SelectorFilter.h:
+* style/HasSelectorFilter.cpp: Added.
+(WebCore::Style::HasSelectorFilter::HasSelectorFilter):
+(WebCore::Style::HasSelectorFilter::typeForMatchElement):
+(WebCore::Style::HasSelectorFilter::makeKey):
+
+The key consists of the most specific string in the rightmost compound of the selector along with
+:hover pseudo class, if any.
+
+(WebCore::Style::HasSelectorFilter::add):
+
+Add an Element to the filter.
+

[webkit-changes] [287090] trunk/Source/WebKit

2021-12-15 Thread sihui_liu

Title: [287090] trunk/Source/WebKit








Revision 287090
Author sihui_...@apple.com
Date 2021-12-15 11:42:28 -0800 (Wed, 15 Dec 2021)


Log Message
REGRESSION (r286936): Many webstorage layout tests have become flaky failures
https://bugs.webkit.org/show_bug.cgi?id=234274


Reviewed by Chris Dumez.

Connection (listener) is not added properly to existing MemoryStorageAreas, so events are not dispatched.
Also according to the old behavior, we don't add connection (listener) to StorageArea when creating it, but when
there is a connection message.

* NetworkProcess/storage/SessionStorageManager.cpp:
(WebKit::SessionStorageManager::addStorageArea):
(WebKit::SessionStorageManager::connectToSessionStorageArea):
(WebKit::SessionStorageManager::cloneStorageArea):
* NetworkProcess/storage/SessionStorageManager.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.cpp
trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (287089 => 287090)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 19:37:58 UTC (rev 287089)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 19:42:28 UTC (rev 287090)
@@ -1,3 +1,21 @@
+2021-12-15  Sihui Liu  
+
+REGRESSION (r286936): Many webstorage layout tests have become flaky failures
+https://bugs.webkit.org/show_bug.cgi?id=234274
+
+
+Reviewed by Chris Dumez.
+
+Connection (listener) is not added properly to existing MemoryStorageAreas, so events are not dispatched.
+Also according to the old behavior, we don't add connection (listener) to StorageArea when creating it, but when
+there is a connection message.
+
+* NetworkProcess/storage/SessionStorageManager.cpp:
+(WebKit::SessionStorageManager::addStorageArea):
+(WebKit::SessionStorageManager::connectToSessionStorageArea):
+(WebKit::SessionStorageManager::cloneStorageArea):
+* NetworkProcess/storage/SessionStorageManager.h:
+
 2021-12-15  Chris Dumez  
 
 Move SWServers from NetworkProcess to NetworkSession


Modified: trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.cpp (287089 => 287090)

--- trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.cpp	2021-12-15 19:37:58 UTC (rev 287089)
+++ trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.cpp	2021-12-15 19:42:28 UTC (rev 287090)
@@ -62,11 +62,10 @@
 storageArea->removeListener(connection);
 }
 
-StorageAreaIdentifier SessionStorageManager::addStorageArea(std::unique_ptr storageArea, IPC::Connection::UniqueID connection, StorageNamespaceIdentifier namespaceIdentifier)
+StorageAreaIdentifier SessionStorageManager::addStorageArea(std::unique_ptr storageArea, StorageNamespaceIdentifier namespaceIdentifier)
 {
 auto identifier = storageArea->identifier();
 m_registry.registerStorageArea(identifier, *storageArea);
-storageArea->addListener(connection);
 m_storageAreasByNamespace.add(namespaceIdentifier, identifier);
 m_storageAreas.add(identifier, WTFMove(storageArea));
 
@@ -76,13 +75,17 @@
 StorageAreaIdentifier SessionStorageManager::connectToSessionStorageArea(IPC::Connection::UniqueID connection, const WebCore::ClientOrigin& origin, StorageNamespaceIdentifier namespaceIdentifier)
 {
 auto identifier = m_storageAreasByNamespace.get(namespaceIdentifier);
-if (identifier.isValid()) {
-ASSERT(m_storageAreas.contains(identifier));
-return identifier;
+if (!identifier.isValid()) {
+auto newStorageArea = makeUnique(origin);
+identifier = addStorageArea(WTFMove(newStorageArea), namespaceIdentifier);
 }
 
-auto newStorageArea = makeUnique(origin);
-return addStorageArea(WTFMove(newStorageArea), connection, namespaceIdentifier);
+auto storageArea = m_storageAreas.get(identifier);
+if (!storageArea)
+return StorageAreaIdentifier { };
+
+storageArea->addListener(connection);
+return identifier;
 }
 
 void SessionStorageManager::disconnectFromStorageArea(IPC::Connection::UniqueID connection, StorageAreaIdentifier identifier)
@@ -97,10 +100,8 @@
 if (!identifier.isValid())
 return;
 
-if (auto iterator = m_storageAreas.find(identifier); iterator != m_storageAreas.end()) {
-auto newStorageArea = iterator->value->clone();
-addStorageArea(WTFMove(newStorageArea), connection, targetNamespaceIdentifier);
-}
+if (auto storageArea = m_storageAreas.get(identifier))
+addStorageArea(storageArea->clone(), targetNamespaceIdentifier);
 }
 
 } // namespace WebKit


Modified: trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.h (287089 => 287090)

--- trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.h	2021-12-15 19:37:58 UTC (rev 287089)
+++ trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.h	2021-12-15 19:42:28 UTC (rev 287090)
@@ -52,7 +52,7 @@
 void

[webkit-changes] [287089] trunk

2021-12-15 Thread shvaikalesh

Title: [287089] trunk








Revision 287089
Author shvaikal...@gmail.com
Date 2021-12-15 11:37:58 -0800 (Wed, 15 Dec 2021)


Log Message
[WebIDL] onselectionchange IDL attribute should not Document-reflect event listeners
https://bugs.webkit.org/show_bug.cgi?id=234349

Reviewed by Darin Adler.

Source/WebCore:

onselectionchange IDL attribute should not forward event listeners from  to Document because:
  a) the attribute is being standardized as a global event handler [1];
  b) "selectionchange" event should be emitted on Document only for selection changes of ranges [2],
 while it should bubble to  only when selection changes occur in  /  elements;
  c) HTML spec has no concept of reflecting event handlers to Document, only to Window [3].

While this patch aligns WebKit with Blink and Gecko, event listener forwarding is preserved for
"onselectionchange" content attribute in order to ensure web-compatibility in the following case:
  * a userland  listener that relies on `document.activeElement`
to handle selection changes, including ones that occur in  /  elements.
This is caught by the fast/events/selectionchange-user-initiated.html test as well.

[1] https://w3c.github.io/selection-api/#extensions-to-globaleventhandlers-interface
[2] https://w3c.github.io/selection-api/#selectionchange-event
[3] https://html.spec.whatwg.org/multipage/webappapis.html#window-reflecting-body-element-event-handler-set

Test: fast/dom/event-handler-attributes.html

* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseAttribute):
* html/HTMLBodyElement.idl:

LayoutTests:

* fast/dom/event-handler-attributes-expected.txt:
* fast/dom/event-handler-attributes.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt
trunk/LayoutTests/fast/dom/event-handler-attributes.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLBodyElement.cpp
trunk/Source/WebCore/html/HTMLBodyElement.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (287088 => 287089)

--- trunk/LayoutTests/ChangeLog	2021-12-15 18:55:46 UTC (rev 287088)
+++ trunk/LayoutTests/ChangeLog	2021-12-15 19:37:58 UTC (rev 287089)
@@ -1,3 +1,13 @@
+2021-12-15  Alexey Shvayka  
+
+[WebIDL] onselectionchange IDL attribute should not Document-reflect event listeners
+https://bugs.webkit.org/show_bug.cgi?id=234349
+
+Reviewed by Darin Adler.
+
+* fast/dom/event-handler-attributes-expected.txt:
+* fast/dom/event-handler-attributes.html:
+
 2021-12-15  Yoshiaki Jitsukawa  
 
 JPEG XL decoder should support understand color profiles


Modified: trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt (287088 => 287089)

--- trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt	2021-12-15 18:55:46 UTC (rev 287088)
+++ trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt	2021-12-15 19:37:58 UTC (rev 287089)
@@ -581,10 +581,6 @@
 PASS testElementAttribute(bodyElement, "storage") is "window"
 PASS testElementAttribute(bodyElement, "unload") is "window"
 
-Event names we expect to be forwarded from  element to document)
-
-PASS testElementAttribute(bodyElement, "selectionchange") is "document"
-
 Non-forwarded event names on  element
 
 PASS testElementAttribute(bodyElement, "abort") is "target"
@@ -641,6 +637,7 @@
 PASS testElementAttribute(bodyElement, "seeked") is "target"
 PASS testElementAttribute(bodyElement, "seeking") is "target"
 PASS testElementAttribute(bodyElement, "select") is "target"
+FAIL testElementAttribute(bodyElement, "selectionchange") should be target. Was script: target; content: document.
 PASS testElementAttribute(bodyElement, "selectstart") is "target"
 PASS testElementAttribute(bodyElement, "stalled") is "target"
 PASS testElementAttribute(bodyElement, "submit") is "target"
@@ -680,10 +677,6 @@
 PASS testElementAttribute(framesetElement, "storage") is "window"
 PASS testElementAttribute(framesetElement, "unload") is "window"
 
-Event names we expect to be forwarded from  element to document)
-
-FAIL testElementAttribute(framesetElement, "selectionchange") should be document. Was target.
-
 Non-forwarded event names on  element
 
 PASS testElementAttribute(framesetElement, "abort") is "target"
@@ -740,6 +733,7 @@
 PASS testElementAttribute(framesetElement, "seeked") is "target"
 PASS testElementAttribute(framesetElement, "seeking") is "target"
 PASS testElementAttribute(framesetElement, "select") is "target"
+PASS testElementAttribute(framesetElement, "selectionchange") is "target"
 PASS testElementAttribute(framesetElement, "selectstart") is "target"
 PASS testElementAttribute(framesetElement, "stalled") is "target"
 PASS testElementAttribute(framesetElement, "submit") is "target"
@@ -942,6 +936,10 @@
 PASS testElementAttribute(nonHTMLElement, "webkittransitionend") is "none"
 PASS testElementAttribute(nonHTMLElement, "wheel") is "none"
 
+onselectionchange IDL attribute doesn't forward event

[webkit-changes] [287088] tags/Safari-613.1.11.6/

2021-12-15 Thread repstein

Title: [287088] tags/Safari-613.1.11.6/








Revision 287088
Author repst...@apple.com
Date 2021-12-15 10:55:46 -0800 (Wed, 15 Dec 2021)


Log Message
Tag Safari-613.1.11.6.

Added Paths

tags/Safari-613.1.11.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287087] tags/Safari-613.1.11.6/

2021-12-15 Thread repstein

Title: [287087] tags/Safari-613.1.11.6/








Revision 287087
Author repst...@apple.com
Date 2021-12-15 10:55:33 -0800 (Wed, 15 Dec 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-613.1.11.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287086] trunk

2021-12-15 Thread commit-queue

Title: [287086] trunk








Revision 287086
Author commit-qu...@webkit.org
Date 2021-12-15 10:49:18 -0800 (Wed, 15 Dec 2021)


Log Message
Avoid unnecessary allocation and UTF-8 conversion when calling DFABytecodeInterpreter::interpret
https://bugs.webkit.org/show_bug.cgi?id=234351

Patch by Alex Christensen  on 2021-12-15
Reviewed by Tim Hatcher.

Source/WebCore:

A valid URL, the only input into DFABytecodeInterpreter::interpret, contains only ASCII characters.
In the overwhelming majority of cases, we have an 8-bit string.  There is no need to allocate, copy, and convert it.
In the rare case that we somehow get a UTF-16 encoded ASCII string, just do what we did before and UTF-8 encode it.

Regular expressions allow matching the end of the string, which we currently implement by checking for the
null character, so I had to keep the parts that read the null character at the end of a string by checking
to see if we are at the end of the string when reading a character and returning the null character if we are.

Covered by many API tests.

* contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::populateTopURLActionCacheIfNeeded const):
(WebCore::ContentExtensions::ContentExtension::populateFrameURLActionCacheIfNeeded const):
* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsFromContentRuleList const):
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):
* contentextensions/ContentExtensionsBackend.h:
* contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpetJumpTable):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
* contentextensions/DFABytecodeInterpreter.h:

Tools:

* TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/ContentExtension.cpp
trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.cpp
trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.h
trunk/Source/WebCore/contentextensions/DFABytecodeInterpreter.cpp
trunk/Source/WebCore/contentextensions/DFABytecodeInterpreter.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (287085 => 287086)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 18:32:26 UTC (rev 287085)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 18:49:18 UTC (rev 287086)
@@ -1,3 +1,32 @@
+2021-12-15  Alex Christensen  
+
+Avoid unnecessary allocation and UTF-8 conversion when calling DFABytecodeInterpreter::interpret
+https://bugs.webkit.org/show_bug.cgi?id=234351
+
+Reviewed by Tim Hatcher.
+
+A valid URL, the only input into DFABytecodeInterpreter::interpret, contains only ASCII characters.
+In the overwhelming majority of cases, we have an 8-bit string.  There is no need to allocate, copy, and convert it.
+In the rare case that we somehow get a UTF-16 encoded ASCII string, just do what we did before and UTF-8 encode it.
+
+Regular expressions allow matching the end of the string, which we currently implement by checking for the
+null character, so I had to keep the parts that read the null character at the end of a string by checking
+to see if we are at the end of the string when reading a character and returning the null character if we are.
+
+Covered by many API tests.
+
+* contentextensions/ContentExtension.cpp:
+(WebCore::ContentExtensions::ContentExtension::populateTopURLActionCacheIfNeeded const):
+(WebCore::ContentExtensions::ContentExtension::populateFrameURLActionCacheIfNeeded const):
+* contentextensions/ContentExtensionsBackend.cpp:
+(WebCore::ContentExtensions::ContentExtensionsBackend::actionsFromContentRuleList const):
+(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):
+* contentextensions/ContentExtensionsBackend.h:
+* contentextensions/DFABytecodeInterpreter.cpp:
+(WebCore::ContentExtensions::DFABytecodeInterpreter::interpetJumpTable):
+(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
+* contentextensions/DFABytecodeInterpreter.h:
+
 2021-12-15  Alan Bujtas  
 
 [LFC][IFC] Use the physical margin/border/padding values for inline boxes when generating the display content


Modified: trunk/Source/WebCore/contentextensions/ContentExtension.cpp (287085 => 287086)

--- trunk/Source/WebCore/contentextensions/ContentExtension.cpp	2021-12-15 18:32:26 UTC (rev 287085)
+++ trunk/Source/WebCore/contentextensions/ContentExtension.cpp	2021-12-15 18:49:18 UTC (rev 287086)
@@ -114,7 +114,7 @@
 return;
 
 DFABytecodeInterpreter interpreter(m_compiledExtension->topURLFiltersBytecode());
-auto topURLActions =

[webkit-changes] [287085] branches/safari-613.1.11-branch/Source/WebKit

2021-12-15 Thread repstein

Title: [287085] branches/safari-613.1.11-branch/Source/WebKit








Revision 287085
Author repst...@apple.com
Date 2021-12-15 10:32:26 -0800 (Wed, 15 Dec 2021)


Log Message
Cherry-pick r286778. rdar://problem/86221898

[macOS][WP] Block access to unused system calls
https://bugs.webkit.org/show_bug.cgi?id=234003

Reviewed by Brent Fulgham.

Based on telemetry, block access to unused system calls in the WebContent process on macOS.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.11-branch/Source/WebKit/ChangeLog
branches/safari-613.1.11-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: branches/safari-613.1.11-branch/Source/WebKit/ChangeLog (287084 => 287085)

--- branches/safari-613.1.11-branch/Source/WebKit/ChangeLog	2021-12-15 18:19:32 UTC (rev 287084)
+++ branches/safari-613.1.11-branch/Source/WebKit/ChangeLog	2021-12-15 18:32:26 UTC (rev 287085)
@@ -1,3 +1,30 @@
+2021-12-15  Alan Coon  
+
+Cherry-pick r286778. rdar://problem/86221898
+
+[macOS][WP] Block access to unused system calls
+https://bugs.webkit.org/show_bug.cgi?id=234003
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, block access to unused system calls in the WebContent process on macOS.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-09  Per Arne Vollan  
+
+[macOS][WP] Block access to unused system calls
+https://bugs.webkit.org/show_bug.cgi?id=234003
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, block access to unused system calls in the WebContent process on macOS.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2021-12-10  Russell Epstein  
 
 Cherry-pick r286805. rdar://problem/86331680


Modified: branches/safari-613.1.11-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (287084 => 287085)

--- branches/safari-613.1.11-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2021-12-15 18:19:32 UTC (rev 287084)
+++ branches/safari-613.1.11-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2021-12-15 18:32:26 UTC (rev 287085)
@@ -1896,6 +1896,8 @@
 (syscall-number
 SYS___disable_threadsignal
 SYS___mac_syscall
+SYS___pthread_sigmask
+SYS___semwait_signal
 SYS_access
 SYS_bsdthread_create
 SYS_bsdthread_ctl
@@ -1906,6 +1908,7 @@
 SYS_csops_audittoken
 SYS_csrctl
 SYS_exit
+SYS_faccessat ;; 
 SYS_fcntl
 SYS_fcntl_nocancel
 SYS_fgetxattr
@@ -1938,6 +1941,8 @@
 SYS_kdebug_trace_string ;; Needed for performance sampling, see .
 SYS_kevent_id
 SYS_kevent_qos
+SYS_kqueue_workloop_ctl ;; 
+SYS_listxattr
 SYS_lseek
 SYS_lstat64
 SYS_madvise
@@ -1959,16 +1964,23 @@
 SYS_psynch_cvwait
 SYS_psynch_mutexdrop
 SYS_psynch_mutexwait
+SYS_psynch_rw_unlock
+SYS_psynch_rw_wrlock
 SYS_read
 SYS_read_nocancel
 SYS_readlink
 SYS_rename
+SYS_sendto
+SYS_sigprocmask
 SYS_stat64
 SYS_statfs64
+SYS_socket
 SYS_sysctlbyname
 SYS_thread_selfid
 SYS_ulock_wait
 SYS_ulock_wake
+SYS_umask
+SYS_work_interval_ctl
 SYS_workq_kernreturn
 SYS_write_nocancel
 SYS_writev))
@@ -1975,19 +1987,7 @@
 
 (define (syscall-unix-intel)
 (syscall-number
-SYS___pthread_sigmask
-SYS___semwait_signal
-SYS_faccessat ;; 
-SYS_kqueue_workloop_ctl ;; 
-SYS_listxattr
-SYS_psynch_rw_unlock
-SYS_psynch_rw_wrlock
-SYS_sendto
-SYS_sigaltstack
-SYS_sigprocmask
-SYS_socket
-SYS_umask
-SYS_work_interval_ctl))
+SYS_sigaltstack))
 
 (define (syscall-unix-apple-silicon)
 (syscall-number
@@ -1994,79 +1994,30 @@
 SYS_guarded_open_dprotected_np ;; 
 SYS_mremap_encrypted))
 
-(define (syscalls-possibly-unused)
+(define (syscalls-rarely-used)
 (syscall-number
 SYS___pthread_kill
-SYS___pthread_markcancel
 SYS___semwait_signal_nocancel
-SYS_abort_with_payload
 SYS_change_fdguard_np
 SYS_chmod
-SYS_chmod_extended
 SYS_connect
-SYS_connect_nocancel
-SYS_connectx
-SYS_dup
 SYS_fchmod
-SYS_fgetattrlist ;; 
-SYS_fileport_makeport
-SYS_fstat64_extended ;; 
 SYS_fsync
 SYS_getegid
-SYS_getpeername
 SYS_getpriority ;; rdar://81727094. Required for CoreAudio AudioOutputUnitStart call. Remove when GPU process is

[webkit-changes] [287084] trunk/Source

2021-12-15 Thread cdumez

Title: [287084] trunk/Source








Revision 287084
Author cdu...@apple.com
Date 2021-12-15 10:19:32 -0800 (Wed, 15 Dec 2021)


Log Message
Move SWServers from NetworkProcess to NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=234179

Reviewed by Darin Adler.

Source/WebKit:

Move SWServers from NetworkProcess to NetworkSession since they are per session.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::establishSWServerConnection):
(WebKit::NetworkConnectionToWebProcess::establishSWContextConnection):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::addWebsiteDataStore):
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):
(WebKit::NetworkProcess::processPushMessage):
(WebKit::NetworkProcess::forEachSWServer): Deleted.
(WebKit::NetworkProcess::swServerForSession): Deleted.
(WebKit::NetworkProcess::existingSWOriginStoreForSession const): Deleted.
(WebKit::NetworkProcess::registerSWServerConnection): Deleted.
(WebKit::NetworkProcess::unregisterSWServerConnection): Deleted.
(WebKit::NetworkProcess::addServiceWorkerSession): Deleted.
* NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::swServerForSessionIfExists): Deleted.
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::lowMemoryHandler):
(WebKit::NetworkSession::swOriginStore const):
(WebKit::NetworkSession::registerSWServerConnection):
(WebKit::NetworkSession::unregisterSWServerConnection):
(WebKit::NetworkSession::ensureSWServer):
(WebKit::NetworkSession::addServiceWorkerSession):
(WebKit::NetworkSession::hasServiceWorkerDatabasePath const):
* NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::swServer):
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
* WebProcess/WebPage/WebPage.h:

Source/WTF:

* wtf/MemoryPressureHandler.h:
Using a bool as underlying type for those enum classes is sufficient.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryPressureHandler.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSession.h
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h




Diff

Modified: trunk/Source/WTF/ChangeLog (287083 => 287084)

--- trunk/Source/WTF/ChangeLog	2021-12-15 18:09:48 UTC (rev 287083)
+++ trunk/Source/WTF/ChangeLog	2021-12-15 18:19:32 UTC (rev 287084)
@@ -1,3 +1,13 @@
+2021-12-15  Chris Dumez  
+
+Move SWServers from NetworkProcess to NetworkSession
+https://bugs.webkit.org/show_bug.cgi?id=234179
+
+Reviewed by Darin Adler.
+
+* wtf/MemoryPressureHandler.h:
+Using a bool as underlying type for those enum classes is sufficient.
+
 2021-12-15  Tomoki Imai  
 
 [PlayStation] Use FileSystem instead of FileSystemPlayStation except several unsupported APIs


Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.h (287083 => 287084)

--- trunk/Source/WTF/wtf/MemoryPressureHandler.h	2021-12-15 18:09:48 UTC (rev 287083)
+++ trunk/Source/WTF/wtf/MemoryPressureHandler.h	2021-12-15 18:19:32 UTC (rev 287084)
@@ -66,8 +66,8 @@
 Inactive,
 };
 
-enum class Critical : uint8_t { No, Yes };
-enum class Synchronous : uint8_t { No, Yes };
+enum class Critical : bool { No, Yes };
+enum class Synchronous : bool { No, Yes };
 
 typedef WTF::Function LowMemoryHandler;
 


Modified: trunk/Source/WebKit/ChangeLog (287083 => 287084)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 18:09:48 UTC (rev 287083)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 18:19:32 UTC (rev 287084)
@@ -1,3 +1,51 @@
+2021-12-15  Chris Dumez  
+
+Move SWServers from NetworkProcess to NetworkSession
+https://bugs.webkit.org/show_bug.cgi?id=234179
+
+Reviewed by Darin Adler.
+
+Move SWServers from NetworkProcess to NetworkSession since they are per session.
+
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
+(WebKit::NetworkConnectionToWebProcess::establishSWServerConnection):
+(WebKit::NetworkConnectionToWebProcess::establishSWContextConnection):
+* NetworkProcess/NetworkProcess.cpp:
+

[webkit-changes] [287083] trunk/Source/WebCore

2021-12-15 Thread zalan

Title: [287083] trunk/Source/WebCore








Revision 287083
Author za...@apple.com
Date 2021-12-15 10:09:48 -0800 (Wed, 15 Dec 2021)


Log Message
[LFC][IFC] Use the physical margin/border/padding values for inline boxes when generating the display content
https://bugs.webkit.org/show_bug.cgi?id=234346

Reviewed by Antti Koivisto.

Display content is always based on visual order. When we construct the display boxes
  - we visit the line runs in visual order
  - we make space for margin/border/padding by looking at the physical sides of the content
The visually first box may very well be logically the last and this first box's left side (again, visually)
may refer to the logical start/end values depending on the inline axis direction.

E.g in case of right to left inline direction, the border-inline-end value of an inline box should be use as the
"visually first" border on the left side of the inline box content.

It means that
 - physical values are used when creating the display boxes
 - and logical values are used throughout the layout
which in practice means that isLeftToRightDirection check should only happen before and after layout
(physical -> logical and logical -> physical respectively) but never during layout.

* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::marginLeft):
(WebCore::Layout::marginRight):
(WebCore::Layout::borderLeft):
(WebCore::Layout::borderRight):
(WebCore::Layout::paddingLeft):
(WebCore::Layout::paddingRight):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (287082 => 287083)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 18:08:42 UTC (rev 287082)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 18:09:48 UTC (rev 287083)
@@ -1,3 +1,34 @@
+2021-12-15  Alan Bujtas  
+
+[LFC][IFC] Use the physical margin/border/padding values for inline boxes when generating the display content
+https://bugs.webkit.org/show_bug.cgi?id=234346
+
+Reviewed by Antti Koivisto.
+
+Display content is always based on visual order. When we construct the display boxes
+  - we visit the line runs in visual order
+  - we make space for margin/border/padding by looking at the physical sides of the content 
+The visually first box may very well be logically the last and this first box's left side (again, visually)
+may refer to the logical start/end values depending on the inline axis direction. 
+
+E.g in case of right to left inline direction, the border-inline-end value of an inline box should be use as the
+"visually first" border on the left side of the inline box content.   
+
+It means that
+ - physical values are used when creating the display boxes
+ - and logical values are used throughout the layout
+which in practice means that isLeftToRightDirection check should only happen before and after layout
+(physical -> logical and logical -> physical respectively) but never during layout.
+
+* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
+(WebCore::Layout::marginLeft):
+(WebCore::Layout::marginRight):
+(WebCore::Layout::borderLeft):
+(WebCore::Layout::borderRight):
+(WebCore::Layout::paddingLeft):
+(WebCore::Layout::paddingRight):
+(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
+
 2021-12-15  Yoshiaki Jitsukawa  
 
 JPEG XL decoder should support understand color profiles


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp (287082 => 287083)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp	2021-12-15 18:08:42 UTC (rev 287082)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp	2021-12-15 18:09:48 UTC (rev 287083)
@@ -41,6 +41,36 @@
 namespace WebCore {
 namespace Layout {
 
+static inline LayoutUnit marginLeft(const Layout::BoxGeometry& boxGeometry, bool isLeftToRightDirection)
+{
+return isLeftToRightDirection ? boxGeometry.marginStart() : boxGeometry.marginEnd();
+}
+
+static inline LayoutUnit marginRight(const Layout::BoxGeometry& boxGeometry, bool isLeftToRightDirection)
+{
+return isLeftToRightDirection ? boxGeometry.marginEnd() : boxGeometry.marginStart();
+}
+
+static inline LayoutUnit borderLeft(const Layout::BoxGeometry& boxGeometry, bool isLeftToRightDirection)
+{
+return isLeftToRightDirection ? boxGeometry.borderStart() : boxGeometry.borderEnd();
+}
+
+static inline LayoutUnit borderRight(const Layout::BoxGeometry& boxGeometry, bool isLeftToRightDirection)
+{
+return isLeftToRightDirection ? boxGeometry.borderEnd() : boxGeometry.borderStart();
+}
+
+static

[webkit-changes] [287082] trunk/Source/ThirdParty/ANGLE

2021-12-15 Thread dino

Title: [287082] trunk/Source/ThirdParty/ANGLE








Revision 287082
Author d...@apple.com
Date 2021-12-15 10:08:42 -0800 (Wed, 15 Dec 2021)


Log Message
[ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables
https://bugs.webkit.org/show_bug.cgi?id=233837


Reviewed by Antoine Quint.

Turn off unknown-warning-option on Apple builds. This shouldn't need to be
upstreamed - the Xcode configurations for ANGLE are specific to WebKit.

* Configurations/Base.xcconfig:

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (287081 => 287082)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-15 18:03:57 UTC (rev 287081)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-15 18:08:42 UTC (rev 287082)
@@ -1,3 +1,16 @@
+2021-12-15  Dean Jackson  
+
+[ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables
+https://bugs.webkit.org/show_bug.cgi?id=233837
+
+
+Reviewed by Antoine Quint.
+
+Turn off unknown-warning-option on Apple builds. This shouldn't need to be
+upstreamed - the Xcode configurations for ANGLE are specific to WebKit.
+
+* Configurations/Base.xcconfig:
+
 2021-12-15  Chris Lord  
 
 [GTK] Use libgbm and the ANGLE gbm backend to fix initialisation


Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (287081 => 287082)

--- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2021-12-15 18:03:57 UTC (rev 287081)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2021-12-15 18:08:42 UTC (rev 287082)
@@ -61,7 +61,7 @@
 
 PREBINDING = NO;
 
-WARNING_CFLAGS = -Wformat=2 -Wglobal-constructors -Wno-inconsistent-missing-override;
+WARNING_CFLAGS = -Wformat=2 -Wglobal-constructors -Wno-inconsistent-missing-override -Wno-unknown-warning-option;
 
 SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
 SUPPORTS_MACCATALYST = YES;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287080] trunk/Source/WTF

2021-12-15 Thread tomoki . imai

Title: [287080] trunk/Source/WTF








Revision 287080
Author tomoki.i...@sony.com
Date 2021-12-15 09:50:28 -0800 (Wed, 15 Dec 2021)


Log Message
[PlayStation] Use FileSystem instead of FileSystemPlayStation except several unsupported APIs
https://bugs.webkit.org/show_bug.cgi?id=234337

Reviewed by Don Olmstead.

PlayStation should use FileSystem as its current SDK supports std::filesystem.
We have to maintain FileSystemPlayStation for now to supply some of FileSystem APIs
because the following functions are not supported yet.
- std::filesystem::space
- std::filesystem::rename
- std::filesystem::canonical
- std::filesystem::directory_iterator
- std::filesystem::remove_all

The plan is to remove FileSystemPlayStation entirely after the SDK supports these functions.

This patch also fixes the incompatible issue of FileSystem::listDirectory of FileSystemPlayStation.
FileSystem::listDirectory is expected to return only the names, but it actually returns full paths.

Confirmed that there is no regression in FileSystem related testcases in TestWTF.

* wtf/FileSystem.cpp: Add PLATFORM(PLAYSTATION) guards not to use unsupported std::filesystem APIs.
* wtf/playstation/FileSystemPlayStation.cpp: Remove the functions duplicated with FileSystem.
Make FileSystem::listDirectory returns only names.
Add listDirectorySub which can return a full path because deleteNonEmptyDirectory depends on it.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FileSystem.cpp
trunk/Source/WTF/wtf/playstation/FileSystemPlayStation.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (287079 => 287080)

--- trunk/Source/WTF/ChangeLog	2021-12-15 17:46:07 UTC (rev 287079)
+++ trunk/Source/WTF/ChangeLog	2021-12-15 17:50:28 UTC (rev 287080)
@@ -1,3 +1,31 @@
+2021-12-15  Tomoki Imai  
+
+[PlayStation] Use FileSystem instead of FileSystemPlayStation except several unsupported APIs
+https://bugs.webkit.org/show_bug.cgi?id=234337
+
+Reviewed by Don Olmstead.
+
+PlayStation should use FileSystem as its current SDK supports std::filesystem.
+We have to maintain FileSystemPlayStation for now to supply some of FileSystem APIs
+because the following functions are not supported yet.
+- std::filesystem::space
+- std::filesystem::rename
+- std::filesystem::canonical
+- std::filesystem::directory_iterator
+- std::filesystem::remove_all
+
+The plan is to remove FileSystemPlayStation entirely after the SDK supports these functions.
+
+This patch also fixes the incompatible issue of FileSystem::listDirectory of FileSystemPlayStation.
+FileSystem::listDirectory is expected to return only the names, but it actually returns full paths.
+
+Confirmed that there is no regression in FileSystem related testcases in TestWTF.
+
+* wtf/FileSystem.cpp: Add PLATFORM(PLAYSTATION) guards not to use unsupported std::filesystem APIs.
+* wtf/playstation/FileSystemPlayStation.cpp: Remove the functions duplicated with FileSystem.
+Make FileSystem::listDirectory returns only names.
+Add listDirectorySub which can return a full path because deleteNonEmptyDirectory depends on it.
+
 2021-12-15  Youenn Fablet  
 
 Make use of PLATFORM(COCOA) in MediaRecorder WebPreference


Modified: trunk/Source/WTF/wtf/FileSystem.cpp (287079 => 287080)

--- trunk/Source/WTF/wtf/FileSystem.cpp	2021-12-15 17:46:07 UTC (rev 287079)
+++ trunk/Source/WTF/wtf/FileSystem.cpp	2021-12-15 17:50:28 UTC (rev 287080)
@@ -612,6 +612,7 @@
 return std::filesystem::remove(fsPath, ec);
 }
 
+#if !PLATFORM(PLAYSTATION)
 bool moveFile(const String& oldPath, const String& newPath)
 {
 auto fsOldPath = toStdFileSystemPath(oldPath);
@@ -629,6 +630,7 @@
 return false;
 return std::filesystem::remove_all(fsOldPath, ec);
 }
+#endif
 
 std::optional fileSize(const String& path)
 {
@@ -639,6 +641,7 @@
 return size;
 }
 
+#if !PLATFORM(PLAYSTATION)
 std::optional volumeFreeSpace(const String& path)
 {
 std::error_code ec;
@@ -647,6 +650,7 @@
 return std::nullopt;
 return spaceInfo.available;
 }
+#endif
 
 bool createSymbolicLink(const String& targetPath, const String& symbolicLinkPath)
 {
@@ -683,6 +687,7 @@
 return ec ? std::nullopt : std::make_optional(linkCount);
 }
 
+#if !PLATFORM(PLAYSTATION)
 bool deleteNonEmptyDirectory(const String& path)
 {
 std::error_code ec;
@@ -689,6 +694,7 @@
 std::filesystem::remove_all(toStdFileSystemPath(path), ec);
 return !ec;
 }
+#endif
 
 std::optional fileModificationTime(const String& path)
 {
@@ -756,6 +762,7 @@
 return fromStdFileSystemPath(toStdFileSystemPath(path).parent_path());
 }
 
+#if !PLATFORM(PLAYSTATION)
 String realPath(const String& path)
 {
 std::error_code ec;
@@ -762,7 +769,9 @@
 auto canonicalPath = std::filesystem::canonical(toStdFileSystemPath(path), ec);
 return ec ? path : fromStdFileSystemPath(canonicalPath);
 }
+#endif

[webkit-changes] [287079] trunk/Source/WebCore

2021-12-15 Thread simon . fraser

Title: [287079] trunk/Source/WebCore








Revision 287079
Author simon.fra...@apple.com
Date 2021-12-15 09:46:07 -0800 (Wed, 15 Dec 2021)


Log Message
Twitter scroll stutter: ensure that CA backing store is always deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=234328


Reviewed by Tim Horton.

When scrolling pages like Twitter and Facebook we observed CoreAnimation commits on the
scrolling thread taking longer than they should because CABackingStore objects were being
released in those transactions.

Work around this issue by extending the lifetime of CABackingStore objects if we detect that
they might be entrained into a scrolling tree commit, by virtue of having overlapping main
thread and scrolling thread commits.

The logic is contained in PlatformCALayerContentsDelayedReleaser, which puts layer contents
into a retaining vector when they are being cleared on the layer. They are released at the
end of a main thread commit; if we detected overlapping commits, then we release on a
dispatch to extend the lifetime slightly.

The remaining changes are plumbing to get commit willBegin/didEnd messages to PlatformCALayerContentsDelayedReleaser
for main and scrolling threads.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* page/scrolling/ScrollingTree.h:
* page/scrolling/ThreadedScrollingTree.h:
* page/scrolling/mac/ScrollingCoordinatorMac.h:
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::willStartPlatformRenderingUpdate):
(WebCore::ScrollingCoordinatorMac::didCompletePlatformRenderingUpdate):
* page/scrolling/mac/ScrollingTreeMac.h:
* page/scrolling/mac/ScrollingTreeMac.mm:
(ScrollingTreeMac::applyLayerPositionsInternal):
(ScrollingTreeMac::registerForPlatformRenderingUpdateCallback):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateDrawsContent):
* platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::clearContents):
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::setBackingStoreAttached):
(WebCore::PlatformCALayerCocoa::clearContents):
* platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.h: Added.
(WebCore::PlatformCALayerContentsDelayedReleaser::WTF_GUARDED_BY_LOCK):
* platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.mm: Added.
(WebCore::PlatformCALayerContentsDelayedReleaser::singleton):
(WebCore::PlatformCALayerContentsDelayedReleaser::takeLayerContents):
(WebCore::PlatformCALayerContentsDelayedReleaser::mainThreadCommitWillStart):
(WebCore::PlatformCALayerContentsDelayedReleaser::mainThreadCommitDidEnd):
(WebCore::PlatformCALayerContentsDelayedReleaser::scrollingThreadCommitWillStart):
(WebCore::PlatformCALayerContentsDelayedReleaser::scrollingThreadCommitDidEnd):
(WebCore::PlatformCALayerContentsDelayedReleaser::updateSawOverlappingCommit):
(WebCore::PlatformCALayerContentsDelayedReleaser::clearRetainedContents):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/scrolling/ScrollingTree.h
trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm


Added Paths

trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.h
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (287078 => 287079)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 17:26:13 UTC (rev 287078)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 17:46:07 UTC (rev 287079)
@@ -1,3 +1,61 @@
+2021-12-15  Simon Fraser  
+
+Twitter scroll stutter: ensure that CA backing store is always deallocated on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=234328
+
+
+Reviewed by Tim Horton.
+
+When scrolling pages like Twitter and Facebook we observed CoreAnimation commits on the
+scrolling thread taking longer than they should because CABackingStore objects were being
+released in those transactions.
+
+Work around this issue by extending the lifetime of CABackingStore objects if we detect that
+they might be entrained into a scrolling tree

[webkit-changes] [287078] trunk/LayoutTests

2021-12-15 Thread youenn

Title: [287078] trunk/LayoutTests








Revision 287078
Author you...@apple.com
Date 2021-12-15 09:26:13 -0800 (Wed, 15 Dec 2021)


Log Message
[ Mac wk2 and iOS wk2 ] webrtc/libwebrtc/descriptionGetters.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=214084


Reviewed by Eric Carlson.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* webrtc/libwebrtc/descriptionGetters.html:
We are no longer getting the descriptions straight from the backend.
Instead, we are storing them at end of createOffer or answer/set descriptions time.
Update test accordingly.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters.html




Diff

Modified: trunk/LayoutTests/ChangeLog (287077 => 287078)

--- trunk/LayoutTests/ChangeLog	2021-12-15 17:10:36 UTC (rev 287077)
+++ trunk/LayoutTests/ChangeLog	2021-12-15 17:26:13 UTC (rev 287078)
@@ -1,3 +1,18 @@
+2021-12-15  Youenn Fablet  
+
+[ Mac wk2 and iOS wk2 ] webrtc/libwebrtc/descriptionGetters.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=214084
+
+
+Reviewed by Eric Carlson.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* webrtc/libwebrtc/descriptionGetters.html:
+We are no longer getting the descriptions straight from the backend.
+Instead, we are storing them at end of createOffer or answer/set descriptions time.
+Update test accordingly.
+
 2021-12-15  Jer Noble  
 
 [ iOS EWS ]  2X media/track (layout-tests) are a constant image failure


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (287077 => 287078)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-12-15 17:10:36 UTC (rev 287077)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-12-15 17:26:13 UTC (rev 287078)
@@ -1895,8 +1895,6 @@
 
 webkit.org/b/21365 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm [ Pass Failure ]
 
-webkit.org/b/214084 webrtc/libwebrtc/descriptionGetters.html [ Pass Failure ]
-
 webkit.org/b/214322 [ Debug ] http/tests/workers/worker-importScripts-banned-mimetype.html [ Pass Crash ]
 
 webkit.org/b/214382 [ Release ] imported/w3c/web-platform-tests/websockets/remove-own-iframe-during-onerror.window.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (287077 => 287078)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-12-15 17:10:36 UTC (rev 287077)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-12-15 17:26:13 UTC (rev 287078)
@@ -1109,8 +1109,6 @@
 
 webkit.org/b/229076 [ BigSur Debug ] webrtc/video-interruption.html [ Pass Crash ]
 
-webkit.org/b/214084 webrtc/libwebrtc/descriptionGetters.html [ Pass Failure ]
-
 webkit.org/b/213804 fast/scrolling/mac/scroll-snapping-in-progress.html [ Pass Failure ]
 
 webkit.org/b/229206 [ Debug ] http/wpt/webrtc/sframe-transform-error.html [ Pass Failure ]


Modified: trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters.html (287077 => 287078)

--- trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters.html	2021-12-15 17:10:36 UTC (rev 287077)
+++ trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters.html	2021-12-15 17:26:13 UTC (rev 287078)
@@ -28,57 +28,61 @@
 
 localConnection.addTrack(stream.getVideoTracks()[0], stream);
 return localConnection.createOffer();
-}).then((desc) => {
+}).then(async (desc) => {
 currentSDP = desc.sdp;
 
-assert_equals(localConnection.currentLocalDescription, null);
-assert_equals(localConnection.pendingLocalDescription, null);
-assert_equals(localConnection.localDescription, null);
+assert_equals(localConnection.currentLocalDescription, null, "test 1");
+assert_equals(localConnection.pendingLocalDescription, null, "test 2");
+assert_equals(localConnection.localDescription, null, "test 3");
 
-assert_equals(remoteConnection.currentRemoteDescription, null);
-assert_equals(remoteConnection.pendingRemoteDescription, null);
-assert_equals(remoteConnection.remoteDescription, null);
+assert_equals(remoteConnection.currentRemoteDescription, null, "test 4");
+assert_equals(remoteConnection.pendingRemoteDescription, null, "test 5");
+assert_equals(remoteConnection.remoteDescription, null, "test 6");
 
 localDescriptionPromise = localConnection.setLocalDescription(desc);
-remoteDescriptionPromise = remoteConnection.setRemoteDescription(desc);
+assert_equals(localConnection.currentLocalDescription, null, "test 7");
+assert_equals(localConnection.pendingLocalDescription, null, "test 8");
 
-assert_equals(localConnection.currentLocalDescription, null, "test 1");
-

[webkit-changes] [287077] trunk/Source/WebCore

2021-12-15 Thread cdumez

Title: [287077] trunk/Source/WebCore








Revision 287077
Author cdu...@apple.com
Date 2021-12-15 09:10:36 -0800 (Wed, 15 Dec 2021)


Log Message
http/tests/security/basic-auth-subresource.html and some other http auth tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=234314


Reviewed by Darin Adler.

http/tests/security/basic-auth-subresource.html and some other http auth tests are flaky.

No new tests, I will be able to unskip those layout tests in internal once this lands.

* platform/network/ProtectionSpaceBase.cpp:
(WebCore::ProtectionSpaceBase::ProtectionSpaceBase):
(WebCore::ProtectionSpaceBase::host const): Deleted.
(WebCore::ProtectionSpaceBase::port const): Deleted.
(WebCore::ProtectionSpaceBase::serverType const): Deleted.
(WebCore::ProtectionSpaceBase::realm const): Deleted.
(WebCore::ProtectionSpaceBase::authenticationScheme const): Deleted.
* platform/network/ProtectionSpaceBase.h:
(WebCore::ProtectionSpaceBase::host const):
(WebCore::ProtectionSpaceBase::port const):
(WebCore::ProtectionSpaceBase::serverType const):
(WebCore::ProtectionSpaceBase::realm const):
(WebCore::ProtectionSpaceBase::authenticationScheme const):
Clean up / modernise the ProtectionSpaceBase class.

* platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):
- Use Hasher in ProtectionSpaceHash::hash() as it is less error-prone. I believe the
  previous implementation was wrong because it was calling
  `StringHasher::hashMemory(hashCodes, codeCount)` instead of
  `StringHasher::hashMemory(hashCodes, codeCount * sizeof(unsigned))`.
  This could have resulted in inefficiencies I believe since we were not hashing the
  whole array memory.
- Fix ProtectionSpace so that emptyValueIsZero is false instead of
  true. This was a bug since the ProtectionSpaceBase constructor initializes data
  members to non-zero values.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ProtectionSpaceBase.cpp
trunk/Source/WebCore/platform/network/ProtectionSpaceBase.h
trunk/Source/WebCore/platform/network/ProtectionSpaceHash.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (287076 => 287077)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 16:59:20 UTC (rev 287076)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 17:10:36 UTC (rev 287077)
@@ -1,3 +1,42 @@
+2021-12-15  Chris Dumez  
+
+http/tests/security/basic-auth-subresource.html and some other http auth tests are flaky
+https://bugs.webkit.org/show_bug.cgi?id=234314
+
+
+Reviewed by Darin Adler.
+
+http/tests/security/basic-auth-subresource.html and some other http auth tests are flaky.
+
+No new tests, I will be able to unskip those layout tests in internal once this lands.
+
+* platform/network/ProtectionSpaceBase.cpp:
+(WebCore::ProtectionSpaceBase::ProtectionSpaceBase):
+(WebCore::ProtectionSpaceBase::host const): Deleted.
+(WebCore::ProtectionSpaceBase::port const): Deleted.
+(WebCore::ProtectionSpaceBase::serverType const): Deleted.
+(WebCore::ProtectionSpaceBase::realm const): Deleted.
+(WebCore::ProtectionSpaceBase::authenticationScheme const): Deleted.
+* platform/network/ProtectionSpaceBase.h:
+(WebCore::ProtectionSpaceBase::host const):
+(WebCore::ProtectionSpaceBase::port const):
+(WebCore::ProtectionSpaceBase::serverType const):
+(WebCore::ProtectionSpaceBase::realm const):
+(WebCore::ProtectionSpaceBase::authenticationScheme const):
+Clean up / modernise the ProtectionSpaceBase class.
+
+* platform/network/ProtectionSpaceHash.h:
+(WebCore::ProtectionSpaceHash::hash):
+- Use Hasher in ProtectionSpaceHash::hash() as it is less error-prone. I believe the
+  previous implementation was wrong because it was calling
+  `StringHasher::hashMemory(hashCodes, codeCount)` instead of
+  `StringHasher::hashMemory(hashCodes, codeCount * sizeof(unsigned))`.
+  This could have resulted in inefficiencies I believe since we were not hashing the
+  whole array memory.
+- Fix ProtectionSpace so that emptyValueIsZero is false instead of
+  true. This was a bug since the ProtectionSpaceBase constructor initializes data
+  members to non-zero values.
+
 2021-12-15  Gavin Phillips  
 
 Fix SVG resource invalidation logic causing incorrect layout state.


Modified: trunk/Source/WebCore/platform/network/ProtectionSpaceBase.cpp (287076 => 287077)

--- trunk/Source/WebCore/platform/network/ProtectionSpaceBase.cpp	2021-12-15 16:59:20 UTC (rev 287076)
+++ trunk/Source/WebCore/platform/network/ProtectionSpaceBase.cpp	2021-12-15 17:10:36 UTC (rev 287077)
@@ -33,46 +33,18 @@
 #endif
 
 namespace WebCore {
-
-// Need to enforce empty, non-null strings due to the pickiness of the String == String operator
-// combined with the semantics of the String(NSString*) constructor

[webkit-changes] [287076] trunk/Source/WebCore

2021-12-15 Thread commit-queue

Title: [287076] trunk/Source/WebCore








Revision 287076
Author commit-qu...@webkit.org
Date 2021-12-15 08:59:20 -0800 (Wed, 15 Dec 2021)


Log Message
Fix SVG resource invalidation logic causing incorrect layout state.
https://bugs.webkit.org/show_bug.cgi?id=233190


When SVG resources perform parent layout/resource invalidation, we can incorrectly
cross the SVG boundary when operating on a node which isn't an SVGRoot.
This can cause us to exit layout() with elements that still needsLayout().

Patch by Gavin Phillips  on 2021-12-15
Reviewed by Darin Adler.

* rendering/svg/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (287075 => 287076)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 16:33:45 UTC (rev 287075)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 16:59:20 UTC (rev 287076)
@@ -1,3 +1,18 @@
+2021-12-15  Gavin Phillips  
+
+Fix SVG resource invalidation logic causing incorrect layout state.
+https://bugs.webkit.org/show_bug.cgi?id=233190
+
+
+When SVG resources perform parent layout/resource invalidation, we can incorrectly
+cross the SVG boundary when operating on a node which isn't an SVGRoot.
+This can cause us to exit layout() with elements that still needsLayout().
+
+Reviewed by Darin Adler.
+
+* rendering/svg/RenderSVGResource.cpp:
+(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
+
 2021-12-15  Chris Lord  
 
 [GTK] Use libgbm and the ANGLE gbm backend to fix initialisation


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp (287075 => 287076)

--- trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp	2021-12-15 16:33:45 UTC (rev 287075)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp	2021-12-15 16:59:20 UTC (rev 287076)
@@ -207,8 +207,22 @@
 else if (is(object) && downcast(object).isInLayout())
 object.setNeedsLayout(MarkOnlyThis);
 #endif
-else
-object.setNeedsLayout(MarkContainingBlockChain);
+else {
+if (!is(object))
+object.setNeedsLayout(MarkOnlyThis);
+else {
+auto svgRoot = SVGRenderSupport::findTreeRootObject(downcast(object));
+if (!svgRoot || !svgRoot->isInLayout())
+object.setNeedsLayout(MarkContainingBlockChain);
+else {
+// We just want to re-layout the ancestors up to the RenderSVGRoot.
+object.setNeedsLayout(MarkOnlyThis);
+for (auto current = object.parent(); current != svgRoot; current = current->parent())
+current->setNeedsLayout(MarkOnlyThis);
+svgRoot->setNeedsLayout(MarkOnlyThis);
+}
+}
+}
 }
 
 if (is(object))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287075] trunk

2021-12-15 Thread clord

Title: [287075] trunk








Revision 287075
Author cl...@igalia.com
Date 2021-12-15 08:33:45 -0800 (Wed, 15 Dec 2021)


Log Message
[GTK] Use libgbm and the ANGLE gbm backend to fix initialisation
https://bugs.webkit.org/show_bug.cgi?id=234293

Reviewed by Don Olmstead.

.:

Add cmake files to find gbm and libdrm.

* Source/cmake/FindGBM.cmake: Added.
* Source/cmake/FindLibDRM.cmake: Added.

Source/ThirdParty/ANGLE:

Use GBM backend for GTK platform.

* CMakeLists.txt:
* GL.cmake:
* PlatformGTK.cmake:

Source/WebCore:

Make ANGLE context non-TEXTURE_2D drawingBufferTextureTarget Cocoa-specific.

* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::drawingBufferTextureTarget):

Modified Paths

trunk/ChangeLog
trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/GL.cmake
trunk/Source/ThirdParty/ANGLE/PlatformGTK.cmake
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp


Added Paths

trunk/Source/cmake/FindGBM.cmake
trunk/Source/cmake/FindLibDRM.cmake




Diff

Modified: trunk/ChangeLog (287074 => 287075)

--- trunk/ChangeLog	2021-12-15 16:25:24 UTC (rev 287074)
+++ trunk/ChangeLog	2021-12-15 16:33:45 UTC (rev 287075)
@@ -1,3 +1,15 @@
+2021-12-15  Chris Lord  
+
+[GTK] Use libgbm and the ANGLE gbm backend to fix initialisation
+https://bugs.webkit.org/show_bug.cgi?id=234293
+
+Reviewed by Don Olmstead.
+
+Add cmake files to find gbm and libdrm.
+
+* Source/cmake/FindGBM.cmake: Added.
+* Source/cmake/FindLibDRM.cmake: Added.
+
 2021-12-11  Aakash Jain  
 
 Update my github username.


Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (287074 => 287075)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2021-12-15 16:25:24 UTC (rev 287074)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2021-12-15 16:33:45 UTC (rev 287075)
@@ -9,9 +9,7 @@
 set(angle_is_winuwp FALSE)
 elseif (UNIX)
 set(is_linux TRUE)
-if (ENABLE_X11_TARGET)
-set(angle_use_x11 TRUE)
-endif ()
+set(ozone_platform_gbm TRUE)
 endif ()
 
 include(Compiler.cmake)


Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (287074 => 287075)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-15 16:25:24 UTC (rev 287074)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-15 16:33:45 UTC (rev 287075)
@@ -1,3 +1,16 @@
+2021-12-15  Chris Lord  
+
+[GTK] Use libgbm and the ANGLE gbm backend to fix initialisation
+https://bugs.webkit.org/show_bug.cgi?id=234293
+
+Reviewed by Don Olmstead.
+
+Use GBM backend for GTK platform.
+
+* CMakeLists.txt:
+* GL.cmake:
+* PlatformGTK.cmake:
+
 2021-12-15  Kyle Piddington  
 
 [ANGLE] Roll ANGLE to 12-14-2021 (5ee7dfbd5a3)


Modified: trunk/Source/ThirdParty/ANGLE/GL.cmake (287074 => 287075)

--- trunk/Source/ThirdParty/ANGLE/GL.cmake	2021-12-15 16:25:24 UTC (rev 287074)
+++ trunk/Source/ThirdParty/ANGLE/GL.cmake	2021-12-15 16:33:45 UTC (rev 287075)
@@ -163,9 +163,6 @@
 "src/libANGLE/renderer/gl/egl/gbm/SurfaceGbm.cpp"
 "src/libANGLE/renderer/gl/egl/gbm/SurfaceGbm.h"
 )
-
-pkg_config("src/libANGLE/renderer/gl/libdrm") 
-set(packages "src/libANGLE/renderer/gl/libdrm" )
 endif()
 
 


Modified: trunk/Source/ThirdParty/ANGLE/PlatformGTK.cmake (287074 => 287075)

--- trunk/Source/ThirdParty/ANGLE/PlatformGTK.cmake	2021-12-15 16:25:24 UTC (rev 287074)
+++ trunk/Source/ThirdParty/ANGLE/PlatformGTK.cmake	2021-12-15 16:33:45 UTC (rev 287075)
@@ -22,10 +22,22 @@
 
 list(APPEND ANGLE_DEFINITIONS
 ANGLE_ENABLE_OPENGL
+ANGLE_USE_GBM
+USE_SYSTEM_EGL
 )
 
+find_package(LibDRM REQUIRED)
+find_package(GBM REQUIRED)
+
+list(APPEND ANGLE_PRIVATE_INCLUDE_DIRECTORIES
+${LIBDRM_INCLUDE_DIR}
+{GBM_INCLUDE_DIR}
+)
+
 list(APPEND ANGLEGLESv2_LIBRARIES
 ${CMAKE_DL_LIBS}
+${LIBDRM_LIBRARIES}
+${GBM_LIBRARIES}
 Threads::Threads
 )
 
@@ -34,24 +46,4 @@
 else ()
 list(APPEND ANGLEGLESv2_LIBRARIES OpenGL::GLES)
 endif ()
-
-# NOTE: When both Wayland and X11 are enabled, ANGLE_USE_X11 will be
-# defined and the X11 type definitions will be used for code involving
-# both. That works because types for both Wayland and X11 have the same
-# sizes and the code in WebKit casts the values to the proper types as
-# needed.
-set(GTK_ANGLE_DEFINITIONS)
-
-if (ENABLE_X11_TARGET)
-list(APPEND ANGLE_SOURCES ${libangle_gl_glx_sources})
-list(APPEND ANGLEGLESv2_LIBRARIES X11)
-list(APPEND GTK_ANGLE_DEFINITIONS ANGLE_USE_X11)
-endif ()
-
-# Allow building ANGLE on platforms which may not provide X11 headers.
-if (NOT GTK_ANGLE_DEFINITIONS)
-list(APPEND GTK_ANGLE_DEFINITIONS USE_SYSTEM_EGL)
-endif ()
-
-list(APPEND ANGLE_DEFINITIONS

[webkit-changes] [287074] trunk/LayoutTests

2021-12-15 Thread jer . noble

Title: [287074] trunk/LayoutTests








Revision 287074
Author jer.no...@apple.com
Date 2021-12-15 08:25:24 -0800 (Wed, 15 Dec 2021)


Log Message
[ iOS EWS ]  2X media/track (layout-tests) are a constant image failure
https://bugs.webkit.org/show_bug.cgi?id=234090


Reviewed by Eric Carlson.

Fix the expected results.

* media/track/track-webvtt-no-snap-to-lines-overlap-expected.html:
* media/track/track-webvtt-snap-to-lines-left-right-expected.html:
* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap-expected.html
trunk/LayoutTests/media/track/track-webvtt-snap-to-lines-left-right-expected.html
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (287073 => 287074)

--- trunk/LayoutTests/ChangeLog	2021-12-15 16:23:33 UTC (rev 287073)
+++ trunk/LayoutTests/ChangeLog	2021-12-15 16:25:24 UTC (rev 287074)
@@ -1,3 +1,17 @@
+2021-12-15  Jer Noble  
+
+[ iOS EWS ]  2X media/track (layout-tests) are a constant image failure
+https://bugs.webkit.org/show_bug.cgi?id=234090
+
+
+Reviewed by Eric Carlson.
+
+Fix the expected results.
+
+* media/track/track-webvtt-no-snap-to-lines-overlap-expected.html:
+* media/track/track-webvtt-snap-to-lines-left-right-expected.html:
+* platform/ios-wk2/TestExpectations:
+
 2021-12-15  Youenn Fablet  
 
 Make sure to start a realtime outgoing source in case it is taken to another sender


Modified: trunk/LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap-expected.html (287073 => 287074)

--- trunk/LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap-expected.html	2021-12-15 16:23:33 UTC (rev 287073)
+++ trunk/LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap-expected.html	2021-12-15 16:25:24 UTC (rev 287074)
@@ -13,6 +13,7 @@
 body { margin:0 }
 .cue-box {
 position: absolute;
+font-family: sans-serif;
 font-size: 12px;
 }
 .cue {


Modified: trunk/LayoutTests/media/track/track-webvtt-snap-to-lines-left-right-expected.html (287073 => 287074)

--- trunk/LayoutTests/media/track/track-webvtt-snap-to-lines-left-right-expected.html	2021-12-15 16:23:33 UTC (rev 287073)
+++ trunk/LayoutTests/media/track/track-webvtt-snap-to-lines-left-right-expected.html	2021-12-15 16:25:24 UTC (rev 287074)
@@ -13,6 +13,7 @@
 body { margin:0 }
 .cue-box {
 position: absolute;
+font-family: sans-serif;
 font-size: 12px;
 }
 .cue {


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (287073 => 287074)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-12-15 16:23:33 UTC (rev 287073)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-12-15 16:25:24 UTC (rev 287074)
@@ -2250,10 +2250,6 @@
 
 webkit.org/b/232337 [ Release ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html [ Pass Failure  DumpJSConsoleLogInStdErr ]
 
-# webkit.org/b/234090 The two folloing tests are constant failures on iOS15 and EWS
-media/track/track-webvtt-no-snap-to-lines-overlap.html [ ImageOnlyFailure ]
-media/track/track-webvtt-snap-to-lines-left-right.html [ ImageOnlyFailure ]
-
 # webkit.org/b/234278 The following 8 tests are flakey failures on iOS 15
 imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-frame.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287073] trunk/Source/WebKit

2021-12-15 Thread youenn

Title: [287073] trunk/Source/WebKit








Revision 287073
Author you...@apple.com
Date 2021-12-15 08:23:33 -0800 (Wed, 15 Dec 2021)


Log Message
RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit should only reset once
https://bugs.webkit.org/show_bug.cgi?id=234340

Reviewed by Eric Carlson.

As seen in logs, there are cases where the unit is notified reset several times before it gets stopped and restarted.
This triggers resetting on WebProcess side several times which is unneeded.
Instead, we now only call reset once in a start/stop cycle of the audio unit.
Manually tested.

* GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::notifyReset):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::start):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (287072 => 287073)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 14:40:41 UTC (rev 287072)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 16:23:33 UTC (rev 287073)
@@ -1,3 +1,19 @@
+2021-12-15  Youenn Fablet  
+
+RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit should only reset once
+https://bugs.webkit.org/show_bug.cgi?id=234340
+
+Reviewed by Eric Carlson.
+
+As seen in logs, there are cases where the unit is notified reset several times before it gets stopped and restarted.
+This triggers resetting on WebProcess side several times which is unneeded.
+Instead, we now only call reset once in a start/stop cycle of the audio unit.
+Manually tested.
+
+* GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
+(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::notifyReset):
+(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::start):
+
 2021-12-15  Per Arne Vollan  
 
 [iOS][WP] Add access to required syscall


Modified: trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp (287072 => 287073)

--- trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp	2021-12-15 14:40:41 UTC (rev 287072)
+++ trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp	2021-12-15 16:23:33 UTC (rev 287073)
@@ -88,6 +88,7 @@
 bool m_isPlaying { false };
 WebCore::CAAudioStreamDescription m_description;
 bool m_shouldRegisterAsSpeakerSamplesProducer { false };
+bool m_canReset { true };
 };
 
 RemoteAudioMediaStreamTrackRendererInternalUnitManager::RemoteAudioMediaStreamTrackRendererInternalUnitManager(GPUConnectionToWebProcess& gpuConnectionToWebProcess)
@@ -178,6 +179,10 @@
 
 void RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::notifyReset()
 {
+if (!m_canReset)
+return;
+
+m_canReset = false;
 m_connection->send(Messages::GPUProcessConnection::ResetAudioMediaStreamTrackRendererInternalUnit { m_identifier }, 0);
 }
 
@@ -202,6 +207,7 @@
 m_readOffset = 0;
 m_generateOffset = 0;
 m_isPlaying = true;
+m_canReset = true;
 m_ringBuffer = WebCore::CARingBuffer::adoptStorage(makeUniqueRef(handle), description, numberOfFrames).moveToUniquePtr();
 m_renderSemaphore = WTFMove(semaphore);
 m_description = description;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287072] trunk/Source/WTF

2021-12-15 Thread youenn

Title: [287072] trunk/Source/WTF








Revision 287072
Author you...@apple.com
Date 2021-12-15 06:40:41 -0800 (Wed, 15 Dec 2021)


Log Message
Make use of PLATFORM(COCOA) in MediaRecorder WebPreference
https://bugs.webkit.org/show_bug.cgi?id=234339

Reviewed by Eric Carlson.

* Scripts/Preferences/WebPreferencesExperimental.yaml:
HAVE(AVASSETWRITERDELEGATE) has been removed from PlatformHave.h given it was true on all supported platforms.
But it was still used to guard MediaRecorder preference, thus MediaRecorder got disabled inadvertently.
Let's guard MediaRecorder with PLATFORM(COCOA).

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml




Diff

Modified: trunk/Source/WTF/ChangeLog (287071 => 287072)

--- trunk/Source/WTF/ChangeLog	2021-12-15 14:15:06 UTC (rev 287071)
+++ trunk/Source/WTF/ChangeLog	2021-12-15 14:40:41 UTC (rev 287072)
@@ -1,3 +1,15 @@
+2021-12-15  Youenn Fablet  
+
+Make use of PLATFORM(COCOA) in MediaRecorder WebPreference
+https://bugs.webkit.org/show_bug.cgi?id=234339
+
+Reviewed by Eric Carlson.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+HAVE(AVASSETWRITERDELEGATE) has been removed from PlatformHave.h given it was true on all supported platforms.
+But it was still used to guard MediaRecorder preference, thus MediaRecorder got disabled inadvertently.
+Let's guard MediaRecorder with PLATFORM(COCOA).
+
 2021-12-14  Alex Christensen  
 
 Remove properties set by NSURLProtocol on NSURLRequest before serializing


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (287071 => 287072)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-12-15 14:15:06 UTC (rev 287071)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-12-15 14:40:41 UTC (rev 287072)
@@ -851,7 +851,7 @@
 WebKitLegacy:
   default: false
 WebKit:
-  "HAVE(AVASSETWRITERDELEGATE)": true
+  "PLATFORM(COCOA)": true
   default: false
 WebCore:
   default: false






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287071] trunk

2021-12-15 Thread carlosgc

Title: [287071] trunk








Revision 287071
Author carlo...@webkit.org
Date 2021-12-15 06:15:06 -0800 (Wed, 15 Dec 2021)


Log Message
[GTK][a11y] Add support for loading events when building with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=234344

Reviewed by Joanmarie Diggs.

Source/WebCore:

Emit document:load-complete, document:reload, document:load-stopped and object:state-changed:busy.

* accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::loadEvent):
* accessibility/atspi/AccessibilityAtspi.h:
* accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::loadEvent):
* accessibility/atspi/AccessibilityObjectAtspi.h:

Tools:

Add a test case to check loading events.

* TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
(AccessibilityTest::shouldProcessEvent): Helper to make the filters conditions easier to read.
(AccessibilityTest::startEventMonitor): Make it possible to use the monitor without filtering events.
(testDocumentLoadEvents):
(beforeAll):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (287070 => 287071)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 13:48:20 UTC (rev 287070)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 14:15:06 UTC (rev 287071)
@@ -1,5 +1,23 @@
 2021-12-15  Carlos Garcia Campos  
 
+[GTK][a11y] Add support for loading events when building with ATSPI
+https://bugs.webkit.org/show_bug.cgi?id=234344
+
+Reviewed by Joanmarie Diggs.
+
+Emit document:load-complete, document:reload, document:load-stopped and object:state-changed:busy.
+
+* accessibility/atspi/AXObjectCacheAtspi.cpp:
+(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
+* accessibility/atspi/AccessibilityAtspi.cpp:
+(WebCore::AccessibilityAtspi::loadEvent):
+* accessibility/atspi/AccessibilityAtspi.h:
+* accessibility/atspi/AccessibilityObjectAtspi.cpp:
+(WebCore::AccessibilityObjectAtspi::loadEvent):
+* accessibility/atspi/AccessibilityObjectAtspi.h:
+
+2021-12-15  Carlos Garcia Campos  
+
 [GTK][a11y] Register the wrappers tree when there's an event listener registered
 https://bugs.webkit.org/show_bug.cgi?id=234338
 


Modified: trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp (287070 => 287071)

--- trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp	2021-12-15 13:48:20 UTC (rev 287070)
+++ trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp	2021-12-15 14:15:06 UTC (rev 287071)
@@ -305,8 +305,36 @@
 wrapper->textInserted(insertedText, position);
 }
 
-void AXObjectCache::frameLoadingEventPlatformNotification(AccessibilityObject* object, AXLoadingEvent loadingEvent)
+void AXObjectCache::frameLoadingEventPlatformNotification(AccessibilityObject* coreObject, AXLoadingEvent loadingEvent)
 {
+RELEASE_ASSERT(isMainThread());
+if (!coreObject)
+return;
+
+if (coreObject->roleValue() != AccessibilityRole::WebArea)
+return;
+
+auto* wrapper = coreObject->wrapper();
+if (!wrapper)
+return;
+
+switch (loadingEvent) {
+case AXObjectCache::AXLoadingStarted:
+wrapper->stateChanged("busy", true);
+break;
+case AXObjectCache::AXLoadingReloaded:
+wrapper->stateChanged("busy", true);
+wrapper->loadEvent("Reload");
+break;
+case AXObjectCache::AXLoadingFailed:
+wrapper->stateChanged("busy", false);
+wrapper->loadEvent("LoadStopped");
+break;
+case AXObjectCache::AXLoadingFinished:
+wrapper->stateChanged("busy", false);
+wrapper->loadEvent("LoadComplete");
+break;
+}
 }
 
 void AXObjectCache::platformHandleFocusedUIElementChanged(Node* oldFocusedNode, Node* newFocusedNode)


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp (287070 => 287071)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2021-12-15 13:48:20 UTC (rev 287070)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2021-12-15 14:15:06 UTC (rev 287071)
@@ -464,6 +464,21 @@
 });
 }
 
+void AccessibilityAtspi::loadEvent(AccessibilityObjectAtspi& atspiObject, CString&& event)
+{
+RELEASE_ASSERT(isMainThread());
+m_queue->dispatch([this, atspiObject = Ref { atspiObject }, event = WTFMove(event)] {
+if (!m_connection)
+return;
+

[webkit-changes] [287070] trunk

2021-12-15 Thread carlosgc

Title: [287070] trunk








Revision 287070
Author carlo...@webkit.org
Date 2021-12-15 05:48:20 -0800 (Wed, 15 Dec 2021)


Log Message
[GTK][a11y] Register the wrappers tree when there's an event listener registered
https://bugs.webkit.org/show_bug.cgi?id=234338

Reviewed by Joanmarie Diggs.

Source/WebCore:

Connect to the atspi registry to get the list of registered event listeners. If there's any listener, we register
the tree to ensure we can emit signals, but we only emit the signals for which there's a listener registered,
except for the ones required by the atspi cache.

* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::AccessibilityAtspi): Connect to the registry.
(WebCore::AccessibilityAtspi::~AccessibilityAtspi): Disconnect registry signals.
(WebCore::AccessibilityAtspi::registerTrees const): Register the trees of all root objects.
(WebCore::AccessibilityAtspi::initializeRegistry): Get the list of listeners registered and connect to
EventListenerRegistered signal.
(WebCore::AccessibilityAtspi::addEventListener): Add an event listener to the list converting the detail to non
camel case to be abel to compare it later on signal emission.
(WebCore::eventIsSubtype): Helper to check if event type is subtype of another.
(WebCore::AccessibilityAtspi::removeEventListener): Remove and events listener from the list.
(WebCore::AccessibilityAtspi::shouldEmitSignal): Return whether the given signal should be emitted, checking the
registered event listeners.
(WebCore::AccessibilityAtspi::parentChanged): Do not emit the signal if the object hasn't been registered yet to
avoid flooding during tree creation. We just register the object the object in that case which will update the
cache because addAccessible is always called.
(WebCore::AccessibilityAtspi::stateChanged): Return early if signal should not be emitted.
(WebCore::AccessibilityAtspi::textChanged): Ditto.
(WebCore::AccessibilityAtspi::textAttributesChanged): Ditto.
(WebCore::AccessibilityAtspi::textCaretMoved): Ditto.
(WebCore::AccessibilityAtspi::textSelectionChanged): Ditto.
(WebCore::AccessibilityAtspi::valueChanged): Ditto.
(WebCore::AccessibilityAtspi::selectionChanged): Ditto.
* accessibility/atspi/AccessibilityAtspi.h:
(WebCore::AccessibilityAtspi::hasEventListeners const):
* accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::childAdded): Return early if object is already detached or ignored.
(WebCore::AccessibilityObjectAtspi::childRemoved): Ditto.
(WebCore::AccessibilityObjectAtspi::stateChanged): Do not return early if the object is not registered because
we might end up emitting the signal.
* accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::selectionChanged): Ditto.
* accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::textInserted): Ditto.
(WebCore::AccessibilityObjectAtspi::textDeleted): Ditto.
(WebCore::AccessibilityObjectAtspi::selectionChanged): Ditto.
(WebCore::AccessibilityObjectAtspi::textAttributesChanged): Ditto.
* accessibility/atspi/AccessibilityObjectValueAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::valueChanged): Ditto.
* accessibility/atspi/AccessibilityRootAtspi.cpp:
(WebCore::AccessibilityRootAtspi::embedded): Register the tree if there are event listeners registered.

Tools:

Add unit test to check the tree is created when there's a listener connected.

* TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
(AccessibilityTest::findTestApplication): Iterate the applications list backwards since the test program is
usually the last one in the list.
(AccessibilityTest::accessibleApplicationIsTestProgram): Helper to check if a given accessible belongs to the
test program.
(AccessibilityTest::startEventMonitor): Support for listening to events associated to the test program, not to a
particular accessible.
(testAccessibleEventListener):
(beforeAll):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectValueAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (287069 => 287070)

--- trunk/Source/WebCore/ChangeLog	2021-12-15 10:16:10 UTC (rev 287069)
+++ trunk/Source/WebCore/ChangeLog	2021-12-15 13:48:20 UTC (rev 287070)
@@ -1,3 +1,55 @@
+2021-12-15  Carlos Garcia Campos  
+
+[GTK][a11y] Register the wrappers tree when there's an event listener registered
+https://bugs.webkit.org/show_bug.cgi?id=234338

[webkit-changes] [287069] trunk/Source/WebKit

2021-12-15 Thread pvollan

Title: [287069] trunk/Source/WebKit








Revision 287069
Author pvol...@apple.com
Date 2021-12-15 02:16:10 -0800 (Wed, 15 Dec 2021)


Log Message
[iOS][WP] Add access to required syscall
https://bugs.webkit.org/show_bug.cgi?id=234336


Reviewed by Tim Horton.

Add required syscall to the WebContent process' sandbox on iOS. This syscall was blocked in
https://trac.webkit.org/changeset/286673/webkit.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (287068 => 287069)

--- trunk/Source/WebKit/ChangeLog	2021-12-15 09:43:04 UTC (rev 287068)
+++ trunk/Source/WebKit/ChangeLog	2021-12-15 10:16:10 UTC (rev 287069)
@@ -1,3 +1,16 @@
+2021-12-15  Per Arne Vollan  
+
+[iOS][WP] Add access to required syscall
+https://bugs.webkit.org/show_bug.cgi?id=234336
+
+
+Reviewed by Tim Horton.
+
+Add required syscall to the WebContent process' sandbox on iOS. This syscall was blocked in
+https://trac.webkit.org/changeset/286673/webkit.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
 2021-12-14  Jean-Yves Avenard  
 
 SourceBufferParser should be using contiguous shared buffer


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (287068 => 287069)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-15 09:43:04 UTC (rev 287068)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2021-12-15 10:16:10 UTC (rev 287069)
@@ -1637,6 +1637,11 @@
 (when (defined? 'mach_port_is_connection_for_service)
 (allow mach-message-send (kernel-mig-routine mach_port_is_connection_for_service))
 )
+
+(if (and gizmo? (defined? 'mach_make_memory_entry))
+(allow mach-message-send (kernel-mig-routine mach_make_memory_entry)))
+(if (and gizmo? (defined? 'mach_make_memory_entry_64))
+(allow mach-message-send (kernel-mig-routine mach_make_memory_entry_64)))
 )
 )
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287067] trunk

2021-12-15 Thread youenn

Title: [287067] trunk








Revision 287067
Author you...@apple.com
Date 2021-12-15 01:36:17 -0800 (Wed, 15 Dec 2021)


Log Message
Make sure to start a realtime outgoing source in case it is taken to another sender
https://bugs.webkit.org/show_bug.cgi?id=234296


Reviewed by Eric Carlson.

Source/WebCore:

We are asynchronously starting libwebrtc sources.
When a sender is created first and is assigned a source later, we take the source and assign it to the sender.
In that case, the source might not be started and we will not send any data.

Test: webrtc/addTransceiver-then-addTrack.html

* Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

LayoutTests:

* webrtc/addTransceiver-then-addTrack-expected.txt: Added.
* webrtc/addTransceiver-then-addTrack.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp


Added Paths

trunk/LayoutTests/webrtc/addTransceiver-then-addTrack-expected.txt
trunk/LayoutTests/webrtc/addTransceiver-then-addTrack.html




Diff

Modified: trunk/LayoutTests/ChangeLog (287066 => 287067)

--- trunk/LayoutTests/ChangeLog	2021-12-15 09:16:02 UTC (rev 287066)
+++ trunk/LayoutTests/ChangeLog	2021-12-15 09:36:17 UTC (rev 287067)
@@ -1,3 +1,14 @@
+2021-12-15  Youenn Fablet  
+
+Make sure to start a realtime outgoing source in case it is taken to another sender
+https://bugs.webkit.org/show_bug.cgi?id=234296
+
+
+Reviewed by Eric Carlson.
+
+* webrtc/addTransceiver-then-addTrack-expected.txt: Added.
+* webrtc/addTransceiver-then-addTrack.html: Added.
+
 2021-12-14  Joonghun Park  
 
 Fix that height is calculated incorrectly when using display:table, box-sizing:border-box and padding.


Added: trunk/LayoutTests/webrtc/addTransceiver-then-addTrack-expected.txt (0 => 287067)

--- trunk/LayoutTests/webrtc/addTransceiver-then-addTrack-expected.txt	(rev 0)
+++ trunk/LayoutTests/webrtc/addTransceiver-then-addTrack-expected.txt	2021-12-15 09:36:17 UTC (rev 287067)
@@ -0,0 +1,4 @@
+
+
+PASS Ensure addTrack reuses transceiver as expected
+


Added: trunk/LayoutTests/webrtc/addTransceiver-then-addTrack.html (0 => 287067)

--- trunk/LayoutTests/webrtc/addTransceiver-then-addTrack.html	(rev 0)
+++ trunk/LayoutTests/webrtc/addTransceiver-then-addTrack.html	2021-12-15 09:36:17 UTC (rev 287067)
@@ -0,0 +1,106 @@
+
+
+
+
+
+
+
+
+