[webkit-changes] [287740] trunk/LayoutTests
Title: [287740] trunk/LayoutTests Revision 287740 Author dp...@igalia.com Date 2022-01-06 22:41:03 -0800 (Thu, 06 Jan 2022) Log Message [GLIB] Unreviewed test gardening, emit baseline for accessibility/accessibility-node-memory-management.html https://bugs.webkit.org/show_bug.cgi?id=209102 * platform/glib/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations Added Paths trunk/LayoutTests/platform/glib/accessibility/accessibility-node-memory-management-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (287739 => 287740) --- trunk/LayoutTests/ChangeLog 2022-01-07 04:56:41 UTC (rev 287739) +++ trunk/LayoutTests/ChangeLog 2022-01-07 06:41:03 UTC (rev 287740) @@ -1,3 +1,10 @@ +2022-01-06 Diego Pino Garcia + +[GLIB] Unreviewed test gardening, emit baseline for accessibility/accessibility-node-memory-management.html +https://bugs.webkit.org/show_bug.cgi?id=209102 + +* platform/glib/TestExpectations: + 2022-01-06 Myles C. Maxfield REGRESSION(r281389): Text wraps unnecessarily within intrinsically-sized elements when using certain fonts and the inner HTML of the element contains a new line that is not preceded by a space Modified: trunk/LayoutTests/platform/glib/TestExpectations (287739 => 287740) --- trunk/LayoutTests/platform/glib/TestExpectations 2022-01-07 04:56:41 UTC (rev 287739) +++ trunk/LayoutTests/platform/glib/TestExpectations 2022-01-07 06:41:03 UTC (rev 287740) @@ -334,8 +334,6 @@ webkit.org/b/98380 accessibility/th-as-title-ui.html [ Failure ] webkit.org/b/98382 accessibility/visible-elements.html [ Timeout ] -webkit.org/b/209102 accessibility/accessibility-node-memory-management.html [ Failure ] - webkit.org/b/215405 accessibility/roles-computedRoleString.html [ Failure ] webkit.org/b/215405 [ Release ] accessibility/roles-exposed.html [ Failure ] webkit.org/b/215405 [ Debug ] accessibility/canvas-accessibilitynodeobject.html [ Crash ] Added: trunk/LayoutTests/platform/glib/accessibility/accessibility-node-memory-management-expected.txt (0 => 287740) --- trunk/LayoutTests/platform/glib/accessibility/accessibility-node-memory-management-expected.txt (rev 0) +++ trunk/LayoutTests/platform/glib/accessibility/accessibility-node-memory-management-expected.txt 2022-01-07 06:41:03 UTC (rev 287740) @@ -0,0 +1,16 @@ +This test makes sure that AccessibilityNodeObjects are properly detached when the node they point to is deleted. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +Button role: AXRole: AXButton +Button role after being detached: AXRole: AXInvalid +PASS buttonRole != detachedRole is true +Canvas button role: AXRole: AXButton +PASS canvasButtonRole is buttonRole +Canvas button role after being detached: AXRole: AXInvalid +PASS detachedCanvasButtonRole is detachedRole +PASS successfullyParsed is true + +TEST COMPLETE + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287739] trunk/Source/WebCore
Title: [287739] trunk/Source/WebCore Revision 287739 Author simon.fra...@apple.com Date 2022-01-06 20:56:41 -0800 (Thu, 06 Jan 2022) Log Message Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters (v2) https://bugs.webkit.org/show_bug.cgi?id=234937 Reviewed by Tim Horton. Refine the logic added in r286932, which tries to ensure that the scrolling thread commits a layer position change in cases where the main thread is also in the middle of a commit. The condition used in r286932 forced a layer position change if the scroll position had changed from the scroll position at the last display refresh. Tracing shows that this isn't always correct, so, instead, use ThreadedScrollingTree's "desynchronized" state as the signal to force a position change. We can thus remove the code related to maintaining scrollPositionAtLastDisplayRefresh. However, towards the end of a momentum scroll, when there isn't an event on every display refresh, this caused too many forced commits. So make two changes to reduce the frequency of going into the desynchronized state here: 1. Not every display refresh triggers a rendering update. So tell ThreadedScrollingTree, via RenderingUpdateScheduler, Page and ScrollingCoordinatorMac if a rendering update was scheduled. ThreadedScrollingTree::displayDidRefreshOnScrollingThread() uses this knowledge to avoid scheduling the delayed rendering update detection timer. 2. Not every rendering update results in a CA commit, yet the code assumed this. Fix by having ScrollingTreeMac::didCompleteRenderingUpdate() check to see if a CA transaction is active. This stops waitForRenderingUpdateCompletionOrTimeout() waiting for a signal that never comes and thus timing out. * page/Page.cpp: (WebCore::Page::scheduledRenderingUpdate): * page/Page.h: * page/RenderingUpdateScheduler.cpp: (WebCore::RenderingUpdateScheduler::scheduleRenderingUpdate): * page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::scheduledRenderingUpdate): * page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::isScrollingTreeMac const): (WebCore::ScrollingTree::WTF_REQUIRES_LOCK): * page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::updateScrollPositionAtLastDisplayRefresh): Deleted. * page/scrolling/ScrollingTreeScrollingNode.h: * page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::scheduledRenderingUpdate): (WebCore::ThreadedScrollingTree::willStartRenderingUpdate): (WebCore::ThreadedScrollingTree::didCompleteRenderingUpdate): (WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread): (WebCore::ThreadedScrollingTree::isScrollingSynchronizedWithMainThread): (WebCore::ThreadedScrollingTree::didCompletePlatformRenderingUpdate): Deleted. (WebCore::ThreadedScrollingTree::storeScrollPositionsAtLastDisplayRefresh): Deleted. * page/scrolling/ThreadedScrollingTree.h: (WebCore::ThreadedScrollingTree::WTF_GUARDED_BY_LOCK): * page/scrolling/mac/ScrollingCoordinatorMac.h: * page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::scheduledRenderingUpdate): (WebCore::ScrollingCoordinatorMac::didCompletePlatformRenderingUpdate): * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm: (WebCore::ScrollingTreeFrameScrollingNodeMac::repositionScrollingLayers): * page/scrolling/mac/ScrollingTreeMac.h: * page/scrolling/mac/ScrollingTreeMac.mm: (ScrollingTreeMac::didCompleteRenderingUpdate): (ScrollingTreeMac::didCompletePlatformRenderingUpdate): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebCore/page/RenderingUpdateScheduler.cpp trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h trunk/Source/WebCore/page/scrolling/ScrollingTree.h trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.h trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.h trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (287738 => 287739) --- trunk/Source/WebCore/ChangeLog 2022-01-07 04:54:03 UTC (rev 287738) +++ trunk/Source/WebCore/ChangeLog 2022-01-07 04:56:41 UTC (rev 287739) @@ -1,3 +1,67 @@ +2022-01-06 Simon Fraser + +Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters (v2) +https://bugs.webkit.org/show_bug.cgi?id=234937 + +Reviewed by Tim Horton. + +Refine the logic added in r286932, which tries to ensure that the scrolling thread commits a +
[webkit-changes] [287738] trunk
Title: [287738] trunk
Revision 287738
Author sbar...@apple.com
Date 2022-01-06 20:54:03 -0800 (Thu, 06 Jan 2022)
Log Message
preparePatchpointForExceptions needs to handle tuples
https://bugs.webkit.org/show_bug.cgi?id=234909
Reviewed by Yusuke Suzuki.
JSTests:
Add support to the builder to have functions return tuples.
* wasm/Builder.js:
(const._normalizeFunctionSignature):
(const._maybeRegisterType):
* wasm/Builder_WebAssemblyBinary.js:
(const.emitters.Type):
* wasm/stress/exception-throw-from-function-returning-tuple.js: Added.
(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.testCatchWithExceptionThrownFromFunctionReturningTuple):
Source/_javascript_Core:
We got the offsets wrong when building a stackmap in B3IRGenerator
for exception sites. We need to index into StackmapGenerationParams
differently from indexing into the patchpoint's children. StackmapGenerationParams
reserves its first N entries for the N return values. The patchpoint's
children contains no results though, so we don't need to account for
the number of return values when indexing into the children() vector
of the PatchpointValue. To make this code simpler, we keep track of the
number of live values we need when throwing. These values are both
at the end of StackmapGenerationParams and at the end of the children()
vector. So we just look at the last "number of live values" in both
vectors to get the correct ValueRep and correct type. The code for
calls also didn't account for the fact that call arguments will be
appended after the live values we're building into a stackmap. This
patch fixes that code to always put the live values last.
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::PatchpointExceptionHandle::generate const):
(JSC::Wasm::B3IRGenerator::preparePatchpointForExceptions):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/wasm/Builder.js
trunk/JSTests/wasm/Builder_WebAssemblyBinary.js
trunk/JSTests/wasm/self-test/test_BuilderJSON.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
Added Paths
trunk/JSTests/wasm/stress/exception-throw-from-function-returning-tuple.js
Diff
Modified: trunk/JSTests/ChangeLog (287737 => 287738)
--- trunk/JSTests/ChangeLog 2022-01-07 04:28:29 UTC (rev 287737)
+++ trunk/JSTests/ChangeLog 2022-01-07 04:54:03 UTC (rev 287738)
@@ -1,3 +1,20 @@
+2022-01-06 Saam Barati
+
+preparePatchpointForExceptions needs to handle tuples
+https://bugs.webkit.org/show_bug.cgi?id=234909
+
+Reviewed by Yusuke Suzuki.
+
+Add support to the builder to have functions return tuples.
+
+* wasm/Builder.js:
+(const._normalizeFunctionSignature):
+(const._maybeRegisterType):
+* wasm/Builder_WebAssemblyBinary.js:
+(const.emitters.Type):
+* wasm/stress/exception-throw-from-function-returning-tuple.js: Added.
+(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.testCatchWithExceptionThrownFromFunctionReturningTuple):
+
2022-01-03 Yusuke Suzuki
Array.prototype.toLocaleString does not respect deletion of Object.prototype.toLocaleString
Modified: trunk/JSTests/wasm/Builder.js (287737 => 287738)
--- trunk/JSTests/wasm/Builder.js 2022-01-07 04:28:29 UTC (rev 287737)
+++ trunk/JSTests/wasm/Builder.js 2022-01-07 04:54:03 UTC (rev 287738)
@@ -46,10 +46,16 @@
assert.isArray(params);
for (const p of params)
assert.truthy(WASM.isValidValueType(p) || p === "void", `Type parameter ${p} needs a valid value type`);
-if (typeof(ret) === "undefined")
-ret = "void";
-assert.isNotArray(ret, `Multiple return values not supported by WebAssembly yet`);
-assert.truthy(WASM.isValidBlockType(ret), `Type return ${ret} must be valid block type`);
+if (typeof ret === "undefined")
+ret = [];
+else if (typeof ret === "string") {
+if (ret === "void")
+ret = [];
+else
+ret = [ret];
+}
+for (let type of ret)
+assert.truthy(WASM.isValidBlockType(type), `Type return ${type} must be valid block type`);
return [params, ret];
};
@@ -77,14 +83,19 @@
const [params, ret] = _normalizeFunctionSignature(type.params, type.ret);
assert.isNotUndef(typeSection, `Can not add type if a type section is not present`);
// Try reusing an equivalent type from the type section.
-types:
for (let i = 0; i !== typeSection.data.length; ++i) {
+let shallowEqual = (a, b) => {
+if (a.length !== b.length)
+return false;
+for (let i = 0; i < a.length; ++i) {
+if (a[i] !== b[i])
+return false;
+}
+return true;
+};
+
const t = typeSection.data[i];
-if (t.ret === ret && params.length === t.params.length) {
-for (let j = 0; j !== t.params.length; ++j) {
-
[webkit-changes] [287737] trunk/Source
Title: [287737] trunk/Source Revision 287737 Author timothy_hor...@apple.com Date 2022-01-06 20:28:29 -0800 (Thu, 06 Jan 2022) Log Message Move linkedOnOrAfter() to WTF https://bugs.webkit.org/show_bug.cgi?id=234942 Reviewed by Darin Adler. Source/WebCore: * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSDOMWindowCustom.cpp: * bindings/js/JSWindowProxy.cpp: * html/MediaElementSession.cpp: (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const): * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest): * page/Quirks.cpp: * page/SecurityOrigin.cpp: * platform/Timer.cpp: (WebCore::shouldSuppressThreadSafetyCheck): * platform/cocoa/VersionChecks.h: Removed. * platform/cocoa/VersionChecks.mm: Removed. * platform/graphics/cocoa/FontCacheCoreText.cpp: * platform/network/DataURLDecoder.cpp: * testing/js/WebCoreTestSupport.cpp: Source/WebKit: * NetworkProcess/WebStorage/ios/LocalStorageDatabaseTrackerIOS.mm: * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection): * NetworkProcess/cocoa/NetworkProcessCocoa.mm: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::configurationForSessionID): * Shared/Cocoa/AuxiliaryProcessCocoa.mm: (WebKit::AuxiliaryProcess::platformInitialize): * Shared/Cocoa/CompletionHandlerCallChecker.mm: (WebKit::shouldThrowExceptionForDuplicateCompletionHandlerCall): * Shared/Cocoa/DefaultWebBrowserChecks.mm: (WebKit::determineITPState): * Shared/Cocoa/WebKit2InitializeCocoa.mm: (WebKit::InitializeWebKit2): * Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultPassiveTouchListenersAsDefaultOnDocument): (WebKit::defaultCSSOMViewScrollingAPIEnabled): (WebKit::defaultPassiveWheelListenersAsDefaultOnDocument): (WebKit::defaultWheelEventGesturesBecomeNonBlocking): (WebKit::defaultOfflineWebApplicationCacheEnabled): * UIProcess/API/C/WKPage.cpp: (WKPageReload): * UIProcess/API/Cocoa/WKWebView.mm: (shouldAllowPictureInPictureMediaPlayback): (shouldAllowSettingAnyXHRHeaderFromFileURLs): (shouldRequireUserGestureToLoadVideo): (shouldRestrictBaseURLSchemes): (-[WKWebView _initializeWithConfiguration:]): (-[WKWebView _setupPageConfiguration:]): (-[WKWebView reload]): (-[WKWebView takeSnapshotWithConfiguration:completionHandler:]): * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (defaultShouldDecidePolicyBeforeLoadingQuickLookPreview): (-[WKWebViewConfiguration init]): * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore init]): * UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _computedObscuredInset]): * UIProcess/API/mac/WKWebViewMac.mm: (-[WKWebView _web_dragDestinationActionForDraggingInfo:]): * UIProcess/Cocoa/WebProcessPoolCocoa.mm: * UIProcess/Inspector/mac/WKInspectorViewController.mm: (-[WKInspectorViewController inspectorWKWebViewReload:]): * UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::hasScrollableOrZoomedMainFrame const): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): (WebKit::WebPageProxy::makeViewBlankIfUnpaintedSinceLastLoadCommit): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createWebPage): * UIProcess/WebProcessProxy.cpp: (WebKit::isMainThreadOrCheckDisabled): * UIProcess/ios/WKContentView.mm: (-[WKContentView _commonInitializationWithProcessPool:configuration:]): * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _shouldUseContextMenus]): (applicationIsKnownToIgnoreMouseEvents): * UIProcess/ios/WKScrollView.mm: (-[WKScrollView _systemContentInset]): * UIProcess/ios/WKStylusDeviceObserver.mm: (-[WKStylusDeviceObserver start]): (-[WKStylusDeviceObserver stop]): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::desktopClassBrowsingRecommended): * WebProcess/cocoa/WebProcessCocoa.mm: Source/WebKitLegacy/mac: * DefaultDelegates/WebDefaultUIDelegate.mm: (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]): * Misc/WebDownload.mm: (shouldCallOnNetworkThread): * Misc/WebIconDatabase.mm: (+[WebIconDatabase sharedIconDatabase]): * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultAllowsPictureInPictureMediaPlayback): (WebKit::defaultJavaScriptCanOpenWindowsAutomatically): (WebKit::defaultPassiveTouchListenersAsDefaultOnDocument): (WebKit::defaultRequiresUserGestureToLoadVideo): (WebKit::defaultWebSQLEnabled): (WebKit::defaultShouldRestrictBaseURLSchemes): (WebKit::defaultShouldConvertInvalidURLsToBlank): (WebKit::defaultPassiveWheelListenersAsDefaultOnDocument): (WebKit::defaultWheelEventGesturesBecomeNonBlocking): * WebView/WebView.mm: (needsLaBanquePostaleQuirks): Source/WTF: Move linkedOnOrAfter() and the associated SDKVersion enum to WTF from WebCore. This precedes a series of patches that will adopt it in WTF and _javascript_Core, and then replace the underlying mechanism with a slightly more flexible one. * wtf/cocoa/RuntimeApplicationChecksCocoa.cpp: (WTF::linke
[webkit-changes] [287736] branches/safari-612.4.9.0-branch/Source
Title: [287736] branches/safari-612.4.9.0-branch/Source Revision 287736 Author repst...@apple.com Date 2022-01-06 17:02:51 -0800 (Thu, 06 Jan 2022) Log Message Versioning. WebKit-7612.4.9.0.1 Modified Paths branches/safari-612.4.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.4.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.4.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.4.9.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.4.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.4.9.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.4.9.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.4.9.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.4.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (287735 => 287736) --- branches/safari-612.4.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-01-07 00:42:01 UTC (rev 287735) +++ branches/safari-612.4.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-01-07 01:02:51 UTC (rev 287736) @@ -25,8 +25,8 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (287735 => 287736) --- branches/safari-612.4.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-01-07 00:42:01 UTC (rev 287735) +++ branches/safari-612.4.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-01-07 01:02:51 UTC (rev 287736) @@ -25,8 +25,8 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (287735 => 287736) --- branches/safari-612.4.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-01-07 00:42:01 UTC (rev 287735) +++ branches/safari-612.4.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-01-07 01:02:51 UTC (rev 287736) @@ -25,8 +25,8 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.9.0-branch/Source/WebCore/Configurations/Version.xcconfig (287735 => 287736) --- branches/safari-612.4.9.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-01-07 00:42:01 UTC (rev 287735) +++ branches/safari-612.4.9.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-01-07 01:02:51 UTC (rev 287736) @@ -25,8 +25,8 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (287735 => 287736) --- branches/safari-612.4.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-01-07 00:42:01 UTC (rev 287735) +++ branches/safari-612.4.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-01-07 01:02:51 UTC (rev 287736) @@ -25,8 +25,8 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDL
[webkit-changes] [287735] tags/Safari-612.4.9.1.1/
Title: [287735] tags/Safari-612.4.9.1.1/ Revision 287735 Author repst...@apple.com Date 2022-01-06 16:42:01 -0800 (Thu, 06 Jan 2022) Log Message Tag Safari-612.4.9.1.1. Added Paths tags/Safari-612.4.9.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287734] branches/safari-612.4.9.1-branch/Source/WebKit
Title: [287734] branches/safari-612.4.9.1-branch/Source/WebKit
Revision 287734
Author repst...@apple.com
Date 2022-01-06 16:36:30 -0800 (Thu, 06 Jan 2022)
Log Message
Cherry-pick r287651. rdar://problem/86338105
Fix the build
* Shared/ios/WebIOSEventFactory.mm:
(WebIOSEventFactory::createWebWheelEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.4.9.1-branch/Source/WebKit/ChangeLog
branches/safari-612.4.9.1-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm
Diff
Modified: branches/safari-612.4.9.1-branch/Source/WebKit/ChangeLog (287733 => 287734)
--- branches/safari-612.4.9.1-branch/Source/WebKit/ChangeLog 2022-01-07 00:36:26 UTC (rev 287733)
+++ branches/safari-612.4.9.1-branch/Source/WebKit/ChangeLog 2022-01-07 00:36:30 UTC (rev 287734)
@@ -1,5 +1,24 @@
2022-01-06 Russell Epstein
+Cherry-pick r287651. rdar://problem/86338105
+
+Fix the build
+
+* Shared/ios/WebIOSEventFactory.mm:
+(WebIOSEventFactory::createWebWheelEvent):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-01-05 Tim Horton
+
+Fix the build
+
+* Shared/ios/WebIOSEventFactory.mm:
+(WebIOSEventFactory::createWebWheelEvent):
+
+2022-01-06 Russell Epstein
+
Cherry-pick r287641. rdar://problem/86338105
Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's
Modified: branches/safari-612.4.9.1-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm (287733 => 287734)
--- branches/safari-612.4.9.1-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm 2022-01-07 00:36:26 UTC (rev 287733)
+++ branches/safari-612.4.9.1-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm 2022-01-07 00:36:30 UTC (rev 287734)
@@ -178,7 +178,8 @@
{ },
timestamp,
timestamp,
-{ }
+{ },
+WebKit::WebWheelEvent::MomentumEndType::Unknown
};
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287733] branches/safari-612.4.9.1-branch/Source
Title: [287733] branches/safari-612.4.9.1-branch/Source Revision 287733 Author repst...@apple.com Date 2022-01-06 16:36:26 -0800 (Thu, 06 Jan 2022) Log Message Cherry-pick r287641. rdar://problem/86338105 Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's https://bugs.webkit.org/show_bug.cgi?id=234535 Reviewed by Simon Fraser. Source/WebKit: Currently, synthetic momentum dispatch is strictly tied to the duration of the real platform momentum phase, which has two unfortunate implications: - if our phase runs shorter than the platform phase, we'll keep dispatching zero-delta events until the platform momentum ends - more importantly, if our phase runs longer, it will be abruptly terminated when the platform momentum ends In practice, our synthetic phase is very close in duration to the system one, so the impact is minimal. But, to be safe, disentagle the two durations, using a new bit from the platform to determine if the system momentum phase was interrupted by the user (e.g. by tapping the trackpad) or naturally, and ignoring the ended event in the natural case, allowing synthetic events to continue being dispatched. * Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent): (WebKit::WebWheelEvent::encode const): (WebKit::WebWheelEvent::decode): * Shared/WebWheelEvent.h: (WebKit::WebWheelEvent::momentumEndType const): * Shared/WebWheelEventCoalescer.cpp: (WebKit::WebWheelEventCoalescer::coalesce): Plumb momentumEndType along on WebWheelEvent. Platforms that don't provide information about the interruption reason will always say Unknown. * Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent): Only bother looking up the CGEvent/IOHIDEvent once, and extract all relevant details in one go. * WebProcess/WebPage/MomentumEventDispatcher.cpp: (WebKit::MomentumEventDispatcher::handleWheelEvent): Don't interrupt the synthetic momentum phase if the momentum-ended event comes from the natural end of the deceleration instead of an interruption (or an unknown reason). Keep track of whether we're in the middle of a platform momentum phase that we chose (at momentum-begin time) to override. When deciding whether to eat an incoming event, take *both* this new bit and whether we are currently in the middle of a synthetic phase into account. It is important to continue eating incoming events in the case where the synthetic phase ended early (so `active` became false) but the platform phase continues. (WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent): (WebKit::MomentumEventDispatcher::didEndMomentumPhase): Adjust some logging wording to be more precise. (WebKit::MomentumEventDispatcher::setScrollingAccelerationCurve): Make this log public so that the curve value is visible in logs. (WebKit::MomentumEventDispatcher::consumeDeltaForCurrentTime): Make consumeDeltaForCurrentTime inform the client via an optional when we are at the end of the delta table. (WebKit::MomentumEventDispatcher::displayWasRefreshed): Stop the synthetic momentum phase as soon as we run out of deltas. (WebKit::MomentumEventDispatcher::computeNextDelta): * WebProcess/WebPage/MomentumEventDispatcher.h: Source/WTF: * wtf/PlatformHave.h: Add a HAVE for kIOHIDEventScrollMomentumInterrupted. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287641 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.4.9.1-branch/Source/WTF/ChangeLog branches/safari-612.4.9.1-branch/Source/WTF/wtf/PlatformHave.h branches/safari-612.4.9.1-branch/Source/WebCore/PAL/pal/spi/mac/IOKitSPIMac.h branches/safari-612.4.9.1-branch/Source/WebKit/ChangeLog branches/safari-612.4.9.1-branch/Source/WebKit/Shared/WebWheelEvent.cpp branches/safari-612.4.9.1-branch/Source/WebKit/Shared/WebWheelEvent.h branches/safari-612.4.9.1-branch/Source/WebKit/Shared/WebWheelEventCoalescer.cpp branches/safari-612.4.9.1-branch/Source/WebKit/Shared/mac/WebEventFactory.mm branches/safari-612.4.9.1-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp branches/safari-612.4.9.1-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h Diff Modified: branches/safari-612.4.9.1-branch/Source/WTF/ChangeLog (287732 => 287733) --- branches/safari-612.4.9.1-branch/Source/WTF/ChangeLog 2022-01-07 00:34:21 UTC (rev 287732) +++ branches/safari-612.4.9.1-branch/Source/WTF/ChangeLog 2022-01-07 00:36:26 UTC (rev 287733) @@ -1,3 +1,97 @@ +2022-01-06 Russell Epstein + +Cherry-pick r287641. rdar://problem/86338105 + +Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's +https://bugs.webkit.org/show_bug.cgi?id=234535 + + +Re
[webkit-changes] [287732] branches/safari-612.4.9.1-branch/Source
Title: [287732] branches/safari-612.4.9.1-branch/Source Revision 287732 Author repst...@apple.com Date 2022-01-06 16:34:21 -0800 (Thu, 06 Jan 2022) Log Message Versioning. WebKit-7612.4.9.1.1 Modified Paths branches/safari-612.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.4.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.4.9.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.4.9.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (287731 => 287732) --- branches/safari-612.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-01-07 00:18:59 UTC (rev 287731) +++ branches/safari-612.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-01-07 00:34:21 UTC (rev 287732) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (287731 => 287732) --- branches/safari-612.4.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-01-07 00:18:59 UTC (rev 287731) +++ branches/safari-612.4.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-01-07 00:34:21 UTC (rev 287732) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (287731 => 287732) --- branches/safari-612.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-01-07 00:18:59 UTC (rev 287731) +++ branches/safari-612.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-01-07 00:34:21 UTC (rev 287732) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig (287731 => 287732) --- branches/safari-612.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-01-07 00:18:59 UTC (rev 287731) +++ branches/safari-612.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-01-07 00:34:21 UTC (rev 287732) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (287731 => 287732) --- branches/safari-612.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-01-07 00:18:59 UTC (rev 287731) +++ branches/safari-612.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-01-07 00:34:21 UTC (rev 287732) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VE
[webkit-changes] [287731] trunk/Source
Title: [287731] trunk/Source Revision 287731 Author wenson_hs...@apple.com Date 2022-01-06 16:18:59 -0800 (Thu, 06 Jan 2022) Log Message Add a helper function that returns the value of a std::optional or constructs T if needed https://bugs.webkit.org/show_bug.cgi?id=234865 Reviewed by Darin Adler. Source/WebCore: Use `valueOrDefault` where appropriate. See WTF/ChangeLog for more details. * Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp: (WebCore::convert): (WebCore::ApplePayPaymentHandler::didAuthorizePayment): * Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::applyConstraints): * Modules/mediastream/RTCIceCandidate.cpp: (WebCore::RTCIceCandidate::create): * Modules/webdatabase/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSql): * Modules/webxr/WebXRBoundedReferenceSpace.cpp: (WebCore::WebXRBoundedReferenceSpace::updateIfNeeded): * dom/Document.cpp: * html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::setupDateTimeChooserParameters): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): * html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::isPointInPathInternal): (WebCore::CanvasRenderingContext2DBase::isPointInStrokeInternal): * layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::build): * layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp: (WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const): * layout/formattingContexts/table/TableFormattingContext.cpp: (WebCore::Layout::TableFormattingContext::setUsedGeometryForCells): * loader/DocumentLoader.cpp: * loader/FrameLoader.cpp: * loader/PolicyChecker.cpp: * loader/ResourceLoader.cpp: * loader/SubresourceLoader.cpp: * loader/cache/CachedResource.cpp: * loader/cache/CachedResourceLoader.cpp: * page/EventHandler.cpp: (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::lastKnownMousePosition const): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const): (WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): (WebCore::EventHandler::fakeMouseMoveEventTimerFired): (WebCore::EventHandler::hoverTimerFired): * page/FrameView.cpp: (WebCore::FrameView::setLayoutViewportOverrideRect): * page/Page.cpp: (WebCore::Page::sampledPageTopColor const): * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll const): * page/scrolling/ScrollingTreeLatchingController.cpp: (WebCore::ScrollingTreeLatchingController::nodeDidHandleEvent): * platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::calculateLayerBoundingRect): * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext): * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::naturalSize): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setVisibleAndCoverageRects): * platform/graphics/transforms/TransformState.cpp: (WebCore::TransformState::mappedPoint const): (WebCore::TransformState::mapQuad const): (WebCore::TransformState::flattenWithTransform): * platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::systemPreviewInfo const): * platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::filter): (WebCore::ResourceResponseBase::sanitizeHTTPHeaderFieldsAccordingToTainting): * rendering/PaintInfo.h: (WebCore::PaintInfo::applyTransform): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffset const): * rendering/RenderGrid.cpp: (WebCore::RenderGrid::computeAutoRepeatTracksCount const): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::paintLayerByApplyingTransform): * rendering/RenderView.cpp: (WebCore::RenderView::layout): * rendering/svg/LegacyRenderSVGRoot.cpp: (WebCore::LegacyRenderSVGRoot::nodeAtPoint): * rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtFloatPoint): * rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): * rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtFloatPoint): * rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::hitTestClipContent): * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::clippedOverflowRect const): (WebCore::RenderSVGRoot::absoluteRects const): (WebCore::RenderSVGRoot::absoluteQuads const): * rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::nodeAtFloatPoint): * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint): * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::clipContextToCSSClippingArea): * rendering/svg/SVGRenderingContext.cpp: (W
[webkit-changes] [287728] branches/safari-612.4.9.1-branch/
Title: [287728] branches/safari-612.4.9.1-branch/ Revision 287728 Author repst...@apple.com Date 2022-01-06 16:06:41 -0800 (Thu, 06 Jan 2022) Log Message New branch. Added Paths branches/safari-612.4.9.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287729] branches/safari-612.4.9.2-branch/
Title: [287729] branches/safari-612.4.9.2-branch/ Revision 287729 Author repst...@apple.com Date 2022-01-06 16:06:48 -0800 (Thu, 06 Jan 2022) Log Message New branch. Added Paths branches/safari-612.4.9.2-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287727] branches/safari-612.4.9.0-branch/
Title: [287727] branches/safari-612.4.9.0-branch/ Revision 287727 Author repst...@apple.com Date 2022-01-06 16:06:35 -0800 (Thu, 06 Jan 2022) Log Message New branch. Added Paths branches/safari-612.4.9.0-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287730] branches/safari-612.4.9.3-branch/
Title: [287730] branches/safari-612.4.9.3-branch/ Revision 287730 Author repst...@apple.com Date 2022-01-06 16:06:58 -0800 (Thu, 06 Jan 2022) Log Message New branch. Added Paths branches/safari-612.4.9.3-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287726] tags/Safari-612.4.9/
Title: [287726] tags/Safari-612.4.9/ Revision 287726 Author repst...@apple.com Date 2022-01-06 15:57:27 -0800 (Thu, 06 Jan 2022) Log Message Tag Safari-612.4.9. Added Paths tags/Safari-612.4.9/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287725] tags/Safari-612.4.9/
Title: [287725] tags/Safari-612.4.9/ Revision 287725 Author repst...@apple.com Date 2022-01-06 15:56:25 -0800 (Thu, 06 Jan 2022) Log Message Delete tag. Removed Paths tags/Safari-612.4.9/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287724] trunk
Title: [287724] trunk
Revision 287724
Author mmaxfi...@apple.com
Date 2022-01-06 15:50:19 -0800 (Thu, 06 Jan 2022)
Log Message
REGRESSION(r281389): Text wraps unnecessarily within intrinsically-sized elements when using certain fonts and the inner HTML of the element contains a new line that is not preceded by a space
https://bugs.webkit.org/show_bug.cgi?id=232939
Reviewed by Alan Bujtas.
Source/WebCore:
We need newline characters to have the same width as space characters for 2 reasons:
1. Our code implicitly depends on it. We have places where we measure a newline character in one place,
and then later realize that we shouldn't have included its with so we subtract out the width of
the space character. (For more information, read the comments of this bugzilla bug.) This assumes
that the width of the newline character is equal to the width of the space character.
2. We need it for correctness. Even if WebKit was entirely consistent about measuring the width of
newline characters, we don't want to have the width of an element depend on the width of the
newline character in the font. Every other browser forces newline characters to have the same
width as space characters. And, even if we weren't concerned about compatibility (we are),
we'd be producing bogus results because font designers aren't incentivized to put any meaningful
values in their fonts for the width of a newline character, since no software actually uses it.
Luckily, we already have our "charactersTreatedAsSpace" infrastructure, so we can just tweak it to have
it set characters which are treated as space, but aren't the tab character, to have the same width as
the space character.
Test: fast/text/newline-width.html
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
LayoutTests:
The div:before { position: absolute; } is necessary to trigger this bug; I assume it's necessary to
opt-out of IFC.
* fast/text/newline-width-expected.html: Added.
* fast/text/newline-width.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/WidthIterator.cpp
Added Paths
trunk/LayoutTests/fast/text/newline-width-expected.html
trunk/LayoutTests/fast/text/newline-width.html
Diff
Modified: trunk/LayoutTests/ChangeLog (287723 => 287724)
--- trunk/LayoutTests/ChangeLog 2022-01-06 23:42:36 UTC (rev 287723)
+++ trunk/LayoutTests/ChangeLog 2022-01-06 23:50:19 UTC (rev 287724)
@@ -1,3 +1,17 @@
+2022-01-06 Myles C. Maxfield
+
+REGRESSION(r281389): Text wraps unnecessarily within intrinsically-sized elements when using certain fonts and the inner HTML of the element contains a new line that is not preceded by a space
+https://bugs.webkit.org/show_bug.cgi?id=232939
+
+
+Reviewed by Alan Bujtas.
+
+The div:before { position: absolute; } is necessary to trigger this bug; I assume it's necessary to
+opt-out of IFC.
+
+* fast/text/newline-width-expected.html: Added.
+* fast/text/newline-width.html: Added.
+
2022-01-06 Tim Nguyen
Unprefix -webkit-print-color-adjust CSS property
Added: trunk/LayoutTests/fast/text/newline-width-expected.html (0 => 287724)
--- trunk/LayoutTests/fast/text/newline-width-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/newline-width-expected.html 2022-01-06 23:50:19 UTC (rev 287724)
@@ -0,0 +1,17 @@
+
+
+
+
+div {
+font: expanded 48px 'Apple Chancery';
+white-space: nowrap;
+display: inline-block;
+background: green;
+}
+
+
+
+This test makes sure that newline characters have the same widths as space characters. We're using Apple Chancery here because the font its newline character is much wider than its space character.
+ a b c d e
+
+
Added: trunk/LayoutTests/fast/text/newline-width.html (0 => 287724)
--- trunk/LayoutTests/fast/text/newline-width.html (rev 0)
+++ trunk/LayoutTests/fast/text/newline-width.html 2022-01-06 23:50:19 UTC (rev 287724)
@@ -0,0 +1,23 @@
+
+
+
+
+div {
+font: expanded 48px 'Apple Chancery';
+white-space: pre-wrap;
+white-space: nowrap;
+display: inline-block;
+background: green;
+}
+
+
+
+This test makes sure that newline characters have the same widths as space characters. We're using Apple Chancery here because the font its newline character is much wider than its space character.
+
+a
+b
+c
+d
+e
+
+
Modified: trunk/Source/WebCore/ChangeLog (287723 => 287724)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 23:42:36 UTC (rev 287723)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 23:50:19 UTC (rev 287724)
@@ -1,3 +1,32 @@
+2022-01-06 Myles C. Maxfield
+
+REGRESSION(r281389): Text wraps unnecessarily within intrinsically-sized elements when using certain fonts and the inner HTML of the element contains a new line that is not preceded by a space
+ht
[webkit-changes] [287723] trunk/Tools
Title: [287723] trunk/Tools
Revision 287723
Author lmo...@igalia.com
Date 2022-01-06 15:42:36 -0800 (Thu, 06 Jan 2022)
Log Message
[GLIB] Make API test initialize localstorage to ensure the database file is created
https://bugs.webkit.org/show_bug.cgi?id=234891
Reviewed by Michael Catanzaro.
Changes needed after 245553@main/r287418 changed the localstorage
behavior to avoid creating an empty database file when reading empty
databases.
* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp
Diff
Modified: trunk/Tools/ChangeLog (287722 => 287723)
--- trunk/Tools/ChangeLog 2022-01-06 23:42:24 UTC (rev 287722)
+++ trunk/Tools/ChangeLog 2022-01-06 23:42:36 UTC (rev 287723)
@@ -1,3 +1,17 @@
+2022-01-06 Lauro Moura
+
+[GLIB] Make API test initialize localstorage to ensure the database file is created
+https://bugs.webkit.org/show_bug.cgi?id=234891
+
+Reviewed by Michael Catanzaro.
+
+Changes needed after 245553@main/r287418 changed the localstorage
+behavior to avoid creating an empty database file when reading empty
+databases.
+
+* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
+(testWebsiteDataConfiguration):
+
2022-01-04 Jonathan Bedard
[EWS] Support pull-requests in ConfigureBuild
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp (287722 => 287723)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp 2022-01-06 23:42:24 UTC (rev 287722)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp 2022-01-06 23:42:36 UTC (rev 287723)
@@ -168,11 +168,12 @@
test->loadURI(kServer->getURIForPath("/empty").data());
test->waitUntilLoadFinished();
-test->runJavaScriptAndWaitUntilFinished("window.localStorage.clear();", nullptr);
+test->runJavaScriptAndWaitUntilFinished("window.localStorage.myproperty = 42;", nullptr);
GUniquePtr localStorageDirectory(g_build_filename(Test::dataDirectory(), "local-storage", nullptr));
g_assert_cmpstr(localStorageDirectory.get(), ==, webkit_website_data_manager_get_local_storage_directory(test->m_manager));
test->assertFileIsCreated(localStorageDirectory.get());
g_assert_true(g_file_test(localStorageDirectory.get(), G_FILE_TEST_IS_DIR));
+test->runJavaScriptAndWaitUntilFinished("window.localStorage.clear();", nullptr);
test->loadURI(kServer->getURIForPath("/empty").data());
test->waitUntilLoadFinished();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287722] tags/Safari-612.4.9/
Title: [287722] tags/Safari-612.4.9/ Revision 287722 Author repst...@apple.com Date 2022-01-06 15:42:24 -0800 (Thu, 06 Jan 2022) Log Message Tag Safari-612.4.9. Added Paths tags/Safari-612.4.9/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287721] tags/Safari-612.4.8.1.1/
Title: [287721] tags/Safari-612.4.8.1.1/ Revision 287721 Author repst...@apple.com Date 2022-01-06 15:41:27 -0800 (Thu, 06 Jan 2022) Log Message Tag Safari-612.4.8.1.1. Added Paths tags/Safari-612.4.8.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287720] trunk/Source
Title: [287720] trunk/Source
Revision 287720
Author timothy_hor...@apple.com
Date 2022-01-06 15:39:49 -0800 (Thu, 06 Jan 2022)
Log Message
Separate "linked-on-or-{before, after}-everything" override from the SDK version
https://bugs.webkit.org/show_bug.cgi?id=234930
Reviewed by Wenson Hsieh.
Source/WebCore:
* platform/cocoa/VersionChecks.mm:
(WebCore::linkedOnOrAfter):
Make use of the new bit instead of checking for Safari's bundle identifier.
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::setLinkedOnOrAfterEverythingForTesting):
Adopt the new bit.
Source/WebKit:
* Shared/AuxiliaryProcess.h:
* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::platformInitialize):
* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getLinkedOnOrAfterOverride):
Plumb the LOA override optional through process initialization (just like
we do for SDK version, because linkedOnOrAfter() is used VERY early in
_javascript_Core initialization).
* UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _setLinkedOnOrBeforeEverythingForTesting]):
(+[WKProcessPool _setLinkedOnOrAfterEverythingForTesting]):
(+[WKProcessPool _setLinkedOnOrAfterEverything]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
Expose non-testing SPI for Safari to opt in to "linked-on-or-after-everything"
so that we can (eventually) stop using a bundle identifier check.
* UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/WebProcessPool.cpp:
Initialize the LOA override using the same logic we previously used in linkedOnOrAfter().
Source/WTF:
* wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:
(WTF::linkedOnOrAfterOverrideValue):
(WTF::setLinkedOnOrAfterOverride):
(WTF::linkedOnOrAfterOverride):
* wtf/cocoa/RuntimeApplicationChecksCocoa.h:
Add an explicit optional bit for "this application should pretend to be
linked on or {after, before} everything" instead of just overriding the
SDK version. This is a prerequisite for getting rid of applicationSDKVersion(),
which will happen in a future patch.
This is in WTF because linkedOnOrAfter() is going to move here in a
future patch as well.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp
trunk/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/VersionChecks.mm
trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/AuxiliaryProcess.h
trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (287719 => 287720)
--- trunk/Source/WTF/ChangeLog 2022-01-06 23:18:46 UTC (rev 287719)
+++ trunk/Source/WTF/ChangeLog 2022-01-06 23:39:49 UTC (rev 287720)
@@ -1,3 +1,23 @@
+2022-01-06 Tim Horton
+
+Separate "linked-on-or-{before, after}-everything" override from the SDK version
+https://bugs.webkit.org/show_bug.cgi?id=234930
+
+Reviewed by Wenson Hsieh.
+
+* wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:
+(WTF::linkedOnOrAfterOverrideValue):
+(WTF::setLinkedOnOrAfterOverride):
+(WTF::linkedOnOrAfterOverride):
+* wtf/cocoa/RuntimeApplicationChecksCocoa.h:
+Add an explicit optional bit for "this application should pretend to be
+linked on or {after, before} everything" instead of just overriding the
+SDK version. This is a prerequisite for getting rid of applicationSDKVersion(),
+which will happen in a future patch.
+
+This is in WTF because linkedOnOrAfter() is going to move here in a
+future patch as well.
+
2022-01-06 Stephan Szabo
[PlayStation] Fix build break after r287698
Modified: trunk/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp (287719 => 287720)
--- trunk/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp 2022-01-06 23:18:46 UTC (rev 287719)
+++ trunk/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp 2022-01-06 23:39:49 UTC (rev 287720)
@@ -48,4 +48,20 @@
return dyld_get_program_sdk_version();
}
+static std::optional& linkedOnOrAfterOverrideValue()
+{
+static NeverDestroyed> linkedOnOrAfter;
+return linkedOnOrAfter;
}
+
+void setLinkedOnOrAfterOverride(std::optional linkedOnOrAfter)
+{
+linkedOnOrAfterOverrideValue() = linkedOnOrAfter;
+}
+
+std::optional linkedOnOrAfterOver
[webkit-changes] [287719] trunk/Tools
Title: [287719] trunk/Tools
Revision 287719
Author jbed...@apple.com
Date 2022-01-06 15:18:46 -0800 (Thu, 06 Jan 2022)
Log Message
[EWS] Support pull-requests in ConfigureBuild
https://bugs.webkit.org/show_bug.cgi?id=234848
Reviewed by Dewei Zhu.
* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.pr_url): Map pull-request number to URL.
(GitHubMixin.get_pull_request_number): Check if the event triggering
this was a pull_request, and the specified branch can be mapped to a
pull-request.
(ConfigureBuild.start): Add pull-request details.
(ConfigureBuild.add_pr_details): Ditto.
Canonical link: https://commits.webkit.org/245802@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (287718 => 287719)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-01-06 23:00:36 UTC (rev 287718)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-01-06 23:18:46 UTC (rev 287719)
@@ -54,6 +54,8 @@
RESULTS_DB_URL = 'https://results.webkit.org/'
WithProperties = properties.WithProperties
Interpolate = properties.Interpolate
+BRANCH_PR_RE = re.compile(r'^refs/pull/(?P\d+)/merge$')
+GITHUB_REPOSITORIES = ['https://github.com/WebKit/WebKit']
class BufferLogHeaderObserver(logobserver.BufferLogObserver):
@@ -69,7 +71,32 @@
return self._get(self.headers)
-class ConfigureBuild(buildstep.BuildStep):
+class GitHubMixin(object):
+def pr_url(self, pr_number=None):
+pr_number = pr_number or self.get_pull_request_number()
+if not pr_number:
+return ''
+return '{}/pull/{}'.format(self.getProperty('repository', '-'), pr_number)
+
+def get_pull_request_number(self):
+pr_number = self.getProperty('pull_request')
+if pr_number:
+return int(pr_number)
+
+if self.getProperty('event') != 'pull_request':
+return None
+if self.getProperty('repository') not in GITHUB_REPOSITORIES:
+return None
+
+match = BRANCH_PR_RE.match(self.getProperty('branch', ''))
+if not match:
+return None
+pr_number = int(match.group('id'))
+self.setProperty('pull_request', pr_number)
+return pr_number
+
+
+class ConfigureBuild(buildstep.BuildStep, GitHubMixin):
name = 'configure-build'
description = ['configuring build']
descriptionDone = ['Configured build']
@@ -109,6 +136,8 @@
self.setProperty('additionalArguments', self.additionalArguments, 'config.json')
self.add_patch_id_url()
+self.add_pr_details()
+
self.finished(SUCCESS)
return defer.succeed(None)
@@ -117,7 +146,12 @@
if patch_id:
self.addURL('Patch {}'.format(patch_id), Bugzilla.patch_url(patch_id))
+def add_pr_details(self):
+pr_number = self.get_pull_request_number()
+if pr_number:
+self.addURL('Pull request {}'.format(pr_number), self.pr_url(pr_number=pr_number))
+
class CheckOutSource(git.Git):
name = 'clean-and-update-working-directory'
CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR = (0, 2)
Modified: trunk/Tools/ChangeLog (287718 => 287719)
--- trunk/Tools/ChangeLog 2022-01-06 23:00:36 UTC (rev 287718)
+++ trunk/Tools/ChangeLog 2022-01-06 23:18:46 UTC (rev 287719)
@@ -1,3 +1,19 @@
+2022-01-04 Jonathan Bedard
+
+[EWS] Support pull-requests in ConfigureBuild
+https://bugs.webkit.org/show_bug.cgi?id=234848
+
+
+Reviewed by Dewei Zhu.
+
+* CISupport/ews-build/steps.py:
+(GitHubMixin.pr_url): Map pull-request number to URL.
+(GitHubMixin.get_pull_request_number): Check if the event triggering
+this was a pull_request, and the specified branch can be mapped to a
+pull-request.
+(ConfigureBuild.start): Add pull-request details.
+(ConfigureBuild.add_pr_details): Ditto.
+
2022-01-06 Alex Christensen
Start using C++20
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287718] trunk
Title: [287718] trunk Revision 287718 Author stephan.sz...@sony.com Date 2022-01-06 15:00:36 -0800 (Thu, 06 Jan 2022) Log Message [PlayStation] Fix build break after r287698 https://bugs.webkit.org/show_bug.cgi?id=234931 Unreviewed build fix .: * Source/cmake/OptionsPlayStation.cmake: Workaround for not having u8string for gtest. Source/WTF: * wtf/PlatformHave.h: Use MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR on PlayStation Modified Paths trunk/ChangeLog trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/cmake/OptionsPlayStation.cmake Diff Modified: trunk/ChangeLog (287717 => 287718) --- trunk/ChangeLog 2022-01-06 22:31:58 UTC (rev 287717) +++ trunk/ChangeLog 2022-01-06 23:00:36 UTC (rev 287718) @@ -1,3 +1,12 @@ +2022-01-06 Stephan Szabo + +[PlayStation] Fix build break after r287698 +https://bugs.webkit.org/show_bug.cgi?id=234931 + +Unreviewed build fix + +* Source/cmake/OptionsPlayStation.cmake: Workaround for not having u8string for gtest. + 2022-01-06 Fujii Hironori [MSVC] Suppress new warnings C5054 and C5055 introduced by /permissive- Modified: trunk/Source/WTF/ChangeLog (287717 => 287718) --- trunk/Source/WTF/ChangeLog 2022-01-06 22:31:58 UTC (rev 287717) +++ trunk/Source/WTF/ChangeLog 2022-01-06 23:00:36 UTC (rev 287718) @@ -1,3 +1,12 @@ +2022-01-06 Stephan Szabo + +[PlayStation] Fix build break after r287698 +https://bugs.webkit.org/show_bug.cgi?id=234931 + +Unreviewed build fix + +* wtf/PlatformHave.h: Use MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR on PlayStation + 2022-01-06 Alex Christensen Start using C++20 Modified: trunk/Source/WTF/wtf/PlatformHave.h (287717 => 287718) --- trunk/Source/WTF/wtf/PlatformHave.h 2022-01-06 22:31:58 UTC (rev 287717) +++ trunk/Source/WTF/wtf/PlatformHave.h 2022-01-06 23:00:36 UTC (rev 287718) @@ -115,6 +115,8 @@ #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12 #define HAVE_MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR 1 +#elif PLATFORM(PLAYSTATION) +#define HAVE_MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR 1 #elif COMPILER(GCC) #if !GCC_VERSION_AT_LEAST(9, 0, 0) #define HAVE_MISSING_STD_FILESYSTEM_PATH_CONSTRUCTOR 1 Modified: trunk/Source/cmake/OptionsPlayStation.cmake (287717 => 287718) --- trunk/Source/cmake/OptionsPlayStation.cmake 2022-01-06 22:31:58 UTC (rev 287717) +++ trunk/Source/cmake/OptionsPlayStation.cmake 2022-01-06 23:00:36 UTC (rev 287718) @@ -299,3 +299,7 @@ if (HAVE_MEMMEM) add_definitions(-DHAVE_MEMMEM=1) endif () + +# FIXME: gtest assumes that you will have u8string if __cpp_char8_t +# (feature test macro) is defined. +add_compile_options(-U__cpp_char8_t) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287717] branches/safari-612-branch
Title: [287717] branches/safari-612-branch
Revision 287717
Author repst...@apple.com
Date 2022-01-06 14:31:58 -0800 (Thu, 06 Jan 2022)
Log Message
Revert "Apply patch. rdar://problem/87124847"
This reverts commit r287709.
Modified Paths
branches/safari-612-branch/LayoutTests/ChangeLog
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/bindings/js/ReadableStream.cpp
Removed Paths
branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt
branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html
Diff
Modified: branches/safari-612-branch/LayoutTests/ChangeLog (287716 => 287717)
--- branches/safari-612-branch/LayoutTests/ChangeLog 2022-01-06 21:02:33 UTC (rev 287716)
+++ branches/safari-612-branch/LayoutTests/ChangeLog 2022-01-06 22:31:58 UTC (rev 287717)
@@ -1,19 +1,5 @@
2022-01-06 Russell Epstein
-Apply patch. rdar://problem/87124847
-
-2022-01-06 Youenn Fablet
-
-ReadableStream::lock should check whether there is an exception when getting ReadableStreamDefaultReader private constructor
-https://bugs.webkit.org/show_bug.cgi?id=234890
-
-Reviewed by Frédéric Wang.
-
-* streams/readable-stream-lock-after-worker-terminates-crash-expected.txt: Added.
-* streams/readable-stream-lock-after-worker-terminates-crash.html: Added.
-
-2022-01-06 Russell Epstein
-
Apply patch. rdar://problem/87125345
2022-01-06 Youenn Fablet
Deleted: branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt (287716 => 287717)
--- branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt 2022-01-06 21:02:33 UTC (rev 287716)
+++ branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt 2022-01-06 22:31:58 UTC (rev 287717)
@@ -1,2 +0,0 @@
-CONSOLE MESSAGE: This test PASS if it does not crash.
-
Deleted: branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html (287716 => 287717)
--- branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html 2022-01-06 21:02:33 UTC (rev 287716)
+++ branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html 2022-01-06 22:31:58 UTC (rev 287717)
@@ -1,30 +0,0 @@
-
-function createWorker() {
-function createRequest() {
-setTimeout(() => {
-const request = new Request("http://test.org", {"method": "POST", "body": "text" });
-request.text();
-request.body;
-}, 0);
-self.postMessage("");
-};
-const worker = new Worker('data:application/_javascript_;charset=utf-8,' + createRequest.toString() + ';createRequest()');
-return new Promise(resolve => {
-worker._onmessage_ = () => {
-worker.terminate();
-resolve();
-}
-});
-}
-
-_onload_ = () => {
-if (window.testRunner)
-testRunner.dumpAsText();
-console.log('This test PASS if it does not crash.')
-for (var i = 0; i < 100; ++i) {
-const script = document.createElement('script');
-script.src = ""
-document.head.appendChild(script);
-}
-};
-
Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (287716 => 287717)
--- branches/safari-612-branch/Source/WebCore/ChangeLog 2022-01-06 21:02:33 UTC (rev 287716)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2022-01-06 22:31:58 UTC (rev 287717)
@@ -1,23 +1,5 @@
2022-01-06 Russell Epstein
-Apply patch. rdar://problem/87124847
-
-2022-01-06 Youenn Fablet
-
-ReadableStream::lock should check whether there is an exception when getting ReadableStreamDefaultReader private constructor
-https://bugs.webkit.org/show_bug.cgi?id=234890
-
-Reviewed by Frédéric Wang and Mark Lam.
-
-Do in ReadableStream::lock like we are doing when getting ReadableStream private constructor in ReadableStream::create.
-For that reason, introduce a invokeConstructor utility function.
-
-Test: streams/readable-stream-lock-after-worker-terminates-crash.html
-
-* bindings/js/ReadableStream.cpp:
-
-2022-01-06 Russell Epstein
-
Apply patch. rdar://problem/87125345
2022-01-06 Youenn Fablet
Modified: branches/safari-612-branch/Source/WebCore/bindings/js/ReadableStream.cpp (287716 => 287717)
--- branches/safari-612-branch/Source/WebCore/bindings/js/ReadableStream.cpp 2022-01-06 21:02:33 UTC (rev 287716)
+++ branches/safari-612-branch/Source/WebCore/bindings/js/ReadableStream.cpp 2022-01-06 22:31:58 UTC (rev 287717)
@@ -37,47 +37,30 @@
namespace WebCore {
using namespace JSC;
-static inline ExceptionOr i
[webkit-changes] [287716] trunk
Title: [287716] trunk Revision 287716 Author hironori.fu...@sony.com Date 2022-01-06 13:02:33 -0800 (Thu, 06 Jan 2022) Log Message [MSVC] Suppress new warnings C5054 and C5055 introduced by /permissive- https://bugs.webkit.org/show_bug.cgi?id=234929 Reviewed by Ross Kirsling. After 245790@main enabled C++20 which implicitly enabled /permissive- switch, WinCairo builds emit a lot of new compilation warnings. * Source/cmake/OptionsMSVC.cmake: Suppress the warnings. Modified Paths trunk/ChangeLog trunk/Source/cmake/OptionsMSVC.cmake Diff Modified: trunk/ChangeLog (287715 => 287716) --- trunk/ChangeLog 2022-01-06 21:01:52 UTC (rev 287715) +++ trunk/ChangeLog 2022-01-06 21:02:33 UTC (rev 287716) @@ -1,3 +1,16 @@ +2022-01-06 Fujii Hironori + +[MSVC] Suppress new warnings C5054 and C5055 introduced by /permissive- +https://bugs.webkit.org/show_bug.cgi?id=234929 + +Reviewed by Ross Kirsling. + +After 245790@main enabled C++20 which implicitly enabled +/permissive- switch, WinCairo builds emit a lot of new compilation +warnings. + +* Source/cmake/OptionsMSVC.cmake: Suppress the warnings. + 2022-01-06 Alex Christensen Start using C++20 Modified: trunk/Source/cmake/OptionsMSVC.cmake (287715 => 287716) --- trunk/Source/cmake/OptionsMSVC.cmake 2022-01-06 21:01:52 UTC (rev 287715) +++ trunk/Source/cmake/OptionsMSVC.cmake 2022-01-06 21:02:33 UTC (rev 287716) @@ -103,6 +103,10 @@ /wd4996 # Your code uses a function, class member, variable, or typedef that's marked deprecated /wd5205 # delete of an abstract class 'type-name' that has a non-virtual destructor results in undefined behavior + +/wd5054 # operator 'operator-name': deprecated between enumerations of different types + +/wd5055 # operator 'operator-name': deprecated between enumerations and floating-point types ) # Create pdb files for debugging purposes, also for Release builds ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287715] trunk/Source
Title: [287715] trunk/Source
Revision 287715
Author you...@apple.com
Date 2022-01-06 13:01:52 -0800 (Thu, 06 Jan 2022)
Log Message
Microphone device filtering heuristic is too harsh
https://bugs.webkit.org/show_bug.cgi?id=234596
Reviewed by Eric Carlson.
Source/WebCore:
When audio capture happens, there are more audio devices and some audio devices get an input stream for echo cancellation.
We add an API to disable that filtering which is used when capture is not done in the process where audio enumeration is done.
A longer term solution should look at doing this filtering in all cases.
Manually tested in Safari and Minibrowser.
* WebCore.xcodeproj/project.pbxproj:
* platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
* platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:
Source/WebKit:
* UIProcess/WebPageProxy.cpp:
Disable filtering if audio capture happens in GPUProcess.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (287714 => 287715)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 20:51:35 UTC (rev 287714)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 21:01:52 UTC (rev 287715)
@@ -1,3 +1,21 @@
+2022-01-06 Youenn Fablet
+
+Microphone device filtering heuristic is too harsh
+https://bugs.webkit.org/show_bug.cgi?id=234596
+
+
+Reviewed by Eric Carlson.
+
+When audio capture happens, there are more audio devices and some audio devices get an input stream for echo cancellation.
+We add an API to disable that filtering which is used when capture is not done in the process where audio enumeration is done.
+A longer term solution should look at doing this filtering in all cases.
+
+Manually tested in Safari and Minibrowser.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
+* platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:
+
2022-01-06 Simon Fraser
A gentle momentum scroll into an edge sometimes fails to rubberband, stopping abruptly
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (287714 => 287715)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2022-01-06 20:51:35 UTC (rev 287714)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2022-01-06 21:01:52 UTC (rev 287715)
@@ -1055,7 +1055,7 @@
3F2B33EF165AF15600E3987C /* JSWebKitCSSViewportRule.h in Headers */ = {isa = PBXBuildFile; fileRef = 3F2B33EA165AF15500E3987C /* JSWebKitCSSViewportRule.h */; };
3F42B31D1881191B00278AAC /* WebVideoFullscreenControllerAVKit.h in Headers */ = {isa = PBXBuildFile; fileRef = 3F42B31B1881191B00278AAC /* WebVideoFullscreenControllerAVKit.h */; settings = {ATTRIBUTES = (Private, ); }; };
3F8020351E9E47BF00DEC61D /* CoreAudioCaptureDevice.h in Headers */ = {isa = PBXBuildFile; fileRef = 3F8020321E9E381D00DEC61D /* CoreAudioCaptureDevice.h */; };
- 3F8020371E9E47C500DEC61D /* CoreAudioCaptureDeviceManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 3F8020341E9E381D00DEC61D /* CoreAudioCaptureDeviceManager.h */; };
+ 3F8020371E9E47C500DEC61D /* CoreAudioCaptureDeviceManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 3F8020341E9E381D00DEC61D /* CoreAudioCaptureDeviceManager.h */; settings = {ATTRIBUTES = (Private, ); }; };
3FBC4AF3189881560046EE38 /* VideoFullscreenInterfaceAVKit.mm in Sources */ = {isa = PBXBuildFile; fileRef = 3FBC4AF1189881560046EE38 /* VideoFullscreenInterfaceAVKit.mm */; };
3FBC4AF4189881560046EE38 /* VideoFullscreenInterfaceAVKit.h in Headers */ = {isa = PBXBuildFile; fileRef = 3FBC4AF2189881560046EE38 /* VideoFullscreenInterfaceAVKit.h */; settings = {ATTRIBUTES = (Private, ); }; };
3FF813A71DBA8640009BF001 /* PointerLockController.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFC434F192406A900A0D3B5 /* PointerLockController.h */; settings = {ATTRIBUTES = (Private, ); }; };
Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp (287714 => 287715)
--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp 2022-01-06 20:51:35 UTC (rev 287714)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp 2022-01-06 21:01:52 UTC (rev 287715)
@@ -111,28 +111,30 @@
return deviceHasStreams(deviceID, address);
}
-static bool isValidCaptureDevice(const CoreAudioCaptureDevice& device)
+static bool isValidCaptureDevice(const CoreAudioCaptureDevice& device, bool filterTapEnabledDevices)
{
-// Ignore output devices that have input only for echo cancellation.
-AudioObjectPropertyAddress address = {
-kAudioDeviceP
[webkit-changes] [287714] trunk/Source/WebCore
Title: [287714] trunk/Source/WebCore Revision 287714 Author simon.fra...@apple.com Date 2022-01-06 12:51:35 -0800 (Thu, 06 Jan 2022) Log Message A gentle momentum scroll into an edge sometimes fails to rubberband, stopping abruptly https://bugs.webkit.org/show_bug.cgi?id=234896 Reviewed by Tim Horton. During the momentum phase of a scroll gesture we can hit the edge and try to determine that we should start a rubberband animation. If, at this time, we happen to be at the edge, then we'd fail to start the animation and the momentum would appear to stop abruptly. Two fixes were needed. First, ScrollingEffectsController::startRubberBandAnimationIfNecessary() looks at whether we're currently stretched, but we might be passing through the edge on the way into a rubberband, so also need to check for a stretch force. Second, ScrollAnimationRubberBand needs to not stop prematurely if, in its first callback, it's still at the edge even though it's animating into a rubberband. The easy fix here is to just avoid completion during the first few frames. I was unable to make a reliable layout test for this. * platform/mac/ScrollAnimationRubberBand.mm: (WebCore::ScrollAnimationRubberBand::serviceAnimation): * platform/mac/ScrollingEffectsController.mm: (WebCore::ScrollingEffectsController::startRubberBandAnimationIfNecessary): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mac/ScrollAnimationRubberBand.mm trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm Diff Modified: trunk/Source/WebCore/ChangeLog (287713 => 287714) --- trunk/Source/WebCore/ChangeLog 2022-01-06 20:32:42 UTC (rev 287713) +++ trunk/Source/WebCore/ChangeLog 2022-01-06 20:51:35 UTC (rev 287714) @@ -1,3 +1,30 @@ +2022-01-06 Simon Fraser + +A gentle momentum scroll into an edge sometimes fails to rubberband, stopping abruptly +https://bugs.webkit.org/show_bug.cgi?id=234896 + +Reviewed by Tim Horton. + +During the momentum phase of a scroll gesture we can hit the edge and try to determine that +we should start a rubberband animation. If, at this time, we happen to be at the edge, then +we'd fail to start the animation and the momentum would appear to stop abruptly. + +Two fixes were needed. First, +ScrollingEffectsController::startRubberBandAnimationIfNecessary() looks at whether we're +currently stretched, but we might be passing through the edge on the way into a rubberband, +so also need to check for a stretch force. + +Second, ScrollAnimationRubberBand needs to not stop prematurely if, in its first callback, +it's still at the edge even though it's animating into a rubberband. The easy fix here is to +just avoid completion during the first few frames. + +I was unable to make a reliable layout test for this. + +* platform/mac/ScrollAnimationRubberBand.mm: +(WebCore::ScrollAnimationRubberBand::serviceAnimation): +* platform/mac/ScrollingEffectsController.mm: +(WebCore::ScrollingEffectsController::startRubberBandAnimationIfNecessary): + 2022-01-06 Tim Nguyen Unprefix -webkit-print-color-adjust CSS property Modified: trunk/Source/WebCore/platform/mac/ScrollAnimationRubberBand.mm (287713 => 287714) --- trunk/Source/WebCore/platform/mac/ScrollAnimationRubberBand.mm 2022-01-06 20:32:42 UTC (rev 287713) +++ trunk/Source/WebCore/platform/mac/ScrollAnimationRubberBand.mm 2022-01-06 20:51:35 UTC (rev 287714) @@ -91,7 +91,8 @@ roundToDevicePixelTowardZero(elasticDeltaForTimeDelta(m_initialOverscroll.height(), -m_initialVelocity.height(), elapsedTime)) }; -bool animationComplete = rubberBandOffset.isZero(); +// We might be rubberbanding away from an edge and back, so wait a frame or two before checking for completion. +bool animationComplete = rubberBandOffset.isZero() && elapsedTime > 24_ms; m_currentOffset = m_targetOffset + rubberBandOffset; m_client.scrollAnimationDidUpdate(*this, m_currentOffset); Modified: trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm (287713 => 287714) --- trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm 2022-01-06 20:32:42 UTC (rev 287713) +++ trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm 2022-01-06 20:51:35 UTC (rev 287714) @@ -447,7 +447,7 @@ bool willOverscroll = targetOffset != contrainedOffset; auto stretchAmount = m_client.stretchAmount(); -if (stretchAmount.isZero() && !willOverscroll) +if (stretchAmount.isZero() && !willOverscroll && m_stretchScrollForce.isZero()) return; auto initialVelocity = m_momentumVelocity; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287713] tags/Safari-613.1.12.1.3/
Title: [287713] tags/Safari-613.1.12.1.3/ Revision 287713 Author repst...@apple.com Date 2022-01-06 12:32:42 -0800 (Thu, 06 Jan 2022) Log Message Tag Safari-613.1.12.1.3. Added Paths tags/Safari-613.1.12.1.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287712] trunk
Title: [287712] trunk Revision 287712 Author n...@apple.com Date 2022-01-06 12:21:02 -0800 (Thu, 06 Jan 2022) Log Message Unprefix -webkit-print-color-adjust CSS property https://bugs.webkit.org/show_bug.cgi?id=201098 Reviewed by Darin Adler. color-adjust is also a deprecated shorthand that just contains print-color-adjust. LayoutTests/imported/w3c: * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Source/WebCore: * animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSProperties.json: * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: LayoutTests: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * fast/css/getComputedStyle/resources/property-names.js: * fast/css/print-color-adjust-expected.txt: Added. * fast/css/print-color-adjust.html: Added. * fast/css/webkit-color-adjust-expected.txt: Removed. * fast/css/webkit-color-adjust.html: Removed. * platform/glib/fast/css/getComputedStyle/computed-style-expected.txt: * platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/glib/svg/css/getComputedStyle-basic-expected.txt: * platform/ios/fast/css/getComputedStyle/computed-style-expected.txt: * platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * platform/ios/svg/css/getComputedStyle-basic-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: * webgl/webgl-oom-paint-document-no-crash.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/glib/svg/css/getComputedStyle-basic-expected.txt trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/ios/svg/css/getComputedStyle-basic-expected.txt trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt trunk/LayoutTests/webgl/webgl-oom-paint-document-no-crash.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js Added Paths trunk/LayoutTests/fast/css/print-color-adjust-expected.txt trunk/LayoutTests/fast/css/print-color-adjust.html Removed Paths trunk/LayoutTests/fast/css/webkit-color-adjust-expected.txt trunk/LayoutTests/fast/css/webkit-color-adjust.html Diff Modified: trunk/LayoutTests/ChangeLog (287711 => 287712) --- trunk/LayoutTests/ChangeLog 2022-01-06 20:13:31 UTC (rev 287711) +++ trunk/LayoutTests/ChangeLog 2022-01-06 20:21:02 UTC (rev 287712) @@ -1,3 +1,29 @@ +2022-01-06 Tim Nguyen + +Unprefix -webkit-print-color-adjust CSS property +https://bugs.webkit.org/show_bug.cgi?id=201098 + +Reviewed by Darin Adler. + +color-adjust is also a deprecated shorthand that just contains print-color-adjust. + +* fast/css/getComputedStyle/computed-style-expected.txt: +* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* fast/css/getComputedStyle/resources/property-names.js: +* fast/css/print-color-adjust-expected.txt: Added. +* fast/css/print-color-adjust.html: Added. +* fast/css/webkit-color-adjust-expected.txt: Removed. +* fast/css/webkit-color-adjust.html: Removed. +* platform/glib/fast/css/getComputedStyle/computed-style-expected.txt: +* platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* platform/glib/svg/css/getComputedStyle-basic-expected.txt: +* platform/ios/fast/css/getComputedStyle/computed-style-expec
[webkit-changes] [287711] trunk
Title: [287711] trunk
Revision 287711
Author you...@apple.com
Date 2022-01-06 12:13:31 -0800 (Thu, 06 Jan 2022)
Log Message
ReadableStream::lock should check whether there is an exception when getting ReadableStreamDefaultReader private constructor
https://bugs.webkit.org/show_bug.cgi?id=234890
Source/WebCore:
Reviewed by Frédéric Wang and Mark Lam.
Do in ReadableStream::lock like we are doing when getting ReadableStream private constructor in ReadableStream::create.
For that reason, introduce a invokeConstructor utility function.
Test: streams/readable-stream-lock-after-worker-terminates-crash.html
* bindings/js/ReadableStream.cpp:
LayoutTests:
Reviewed by Frédéric Wang.
* streams/readable-stream-lock-after-worker-terminates-crash-expected.txt: Added.
* streams/readable-stream-lock-after-worker-terminates-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ReadableStream.cpp
Added Paths
trunk/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt
trunk/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (287710 => 287711)
--- trunk/LayoutTests/ChangeLog 2022-01-06 20:04:41 UTC (rev 287710)
+++ trunk/LayoutTests/ChangeLog 2022-01-06 20:13:31 UTC (rev 287711)
@@ -1,3 +1,13 @@
+2022-01-06 Youenn Fablet
+
+ReadableStream::lock should check whether there is an exception when getting ReadableStreamDefaultReader private constructor
+https://bugs.webkit.org/show_bug.cgi?id=234890
+
+Reviewed by Frédéric Wang.
+
+* streams/readable-stream-lock-after-worker-terminates-crash-expected.txt: Added.
+* streams/readable-stream-lock-after-worker-terminates-crash.html: Added.
+
2022-01-06 Said Abou-Hallawa
REGRESSION(r285618):A crash may happen when calculating the color-interpolation of a referenced SVG filter
Added: trunk/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt (0 => 287711)
--- trunk/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt 2022-01-06 20:13:31 UTC (rev 287711)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: This test PASS if it does not crash.
+
Added: trunk/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html (0 => 287711)
--- trunk/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html (rev 0)
+++ trunk/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html 2022-01-06 20:13:31 UTC (rev 287711)
@@ -0,0 +1,30 @@
+
+function createWorker() {
+function createRequest() {
+setTimeout(() => {
+const request = new Request("http://test.org", {"method": "POST", "body": "text" });
+request.text();
+request.body;
+}, 0);
+self.postMessage("");
+};
+const worker = new Worker('data:application/_javascript_;charset=utf-8,' + createRequest.toString() + ';createRequest()');
+return new Promise(resolve => {
+worker._onmessage_ = () => {
+worker.terminate();
+resolve();
+}
+});
+}
+
+_onload_ = () => {
+if (window.testRunner)
+testRunner.dumpAsText();
+console.log('This test PASS if it does not crash.')
+for (var i = 0; i < 100; ++i) {
+const script = document.createElement('script');
+script.src = ""
+document.head.appendChild(script);
+}
+};
+
Modified: trunk/Source/WebCore/ChangeLog (287710 => 287711)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 20:04:41 UTC (rev 287710)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 20:13:31 UTC (rev 287711)
@@ -1,3 +1,17 @@
+2022-01-06 Youenn Fablet
+
+ReadableStream::lock should check whether there is an exception when getting ReadableStreamDefaultReader private constructor
+https://bugs.webkit.org/show_bug.cgi?id=234890
+
+Reviewed by Frédéric Wang and Mark Lam.
+
+Do in ReadableStream::lock like we are doing when getting ReadableStream private constructor in ReadableStream::create.
+For that reason, introduce a invokeConstructor utility function.
+
+Test: streams/readable-stream-lock-after-worker-terminates-crash.html
+
+* bindings/js/ReadableStream.cpp:
+
2022-01-06 Said Abou-Hallawa
REGRESSION(r285618):A crash may happen when calculating the color-interpolation of a referenced SVG filter
Modified: trunk/Source/WebCore/bindings/js/ReadableStream.cpp (287710 => 287711)
--- trunk/Source/WebCore/bindings/js/ReadableStream.cpp 2022-01-06 20:04:41 UTC (rev 287710)
+++ trunk/Source/WebCore/bindings/js/ReadableStream.cpp 2022-01-06 20:13:31 UTC (rev 287711)
@@ -37,15 +37,15 @@
namespace WebCore {
using namespace JSC
[webkit-changes] [287710] trunk
Title: [287710] trunk Revision 287710 Author s...@apple.com Date 2022-01-06 12:04:41 -0800 (Thu, 06 Jan 2022) Log Message REGRESSION(r285618):A crash may happen when calculating the color-interpolation of a referenced SVG filter https://bugs.webkit.org/show_bug.cgi?id=234918 rdar://86928631 Reviewed by Simon Fraser. Source/WebCore: When building a referenced SVGFilter, the color-interpolation property of the effect element is needed. If the effect element does not have a renderer, we fallback to the computed style property value. And if the SVG filter is inside an which has media queries, a Document:: updateLayout() will be forced. Building the SVGFilter should not invoke an updateLayout() since this may not be safe and out of order. Test: css3/filters/reference-filter-color-interpolation-update-layout.html * svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::colorInterpolationForElement): LayoutTests: * css3/filters/reference-filter-color-interpolation-update-layout-expected.txt: Added. * css3/filters/reference-filter-color-interpolation-update-layout.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp Added Paths trunk/LayoutTests/css3/filters/reference-filter-color-interpolation-update-layout-expected.txt trunk/LayoutTests/css3/filters/reference-filter-color-interpolation-update-layout.html Diff Modified: trunk/LayoutTests/ChangeLog (287709 => 287710) --- trunk/LayoutTests/ChangeLog 2022-01-06 20:01:46 UTC (rev 287709) +++ trunk/LayoutTests/ChangeLog 2022-01-06 20:04:41 UTC (rev 287710) @@ -1,3 +1,14 @@ +2022-01-06 Said Abou-Hallawa + +REGRESSION(r285618):A crash may happen when calculating the color-interpolation of a referenced SVG filter +https://bugs.webkit.org/show_bug.cgi?id=234918 +rdar://86928631 + +Reviewed by Simon Fraser. + +* css3/filters/reference-filter-color-interpolation-update-layout-expected.txt: Added. +* css3/filters/reference-filter-color-interpolation-update-layout.html: Added. + 2022-01-06 Alan Bujtas Tighten test expectation for imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform.html Added: trunk/LayoutTests/css3/filters/reference-filter-color-interpolation-update-layout-expected.txt (0 => 287710) --- trunk/LayoutTests/css3/filters/reference-filter-color-interpolation-update-layout-expected.txt (rev 0) +++ trunk/LayoutTests/css3/filters/reference-filter-color-interpolation-update-layout-expected.txt 2022-01-06 20:04:41 UTC (rev 287710) @@ -0,0 +1,3 @@ +This test passes if it does not crash. + + Added: trunk/LayoutTests/css3/filters/reference-filter-color-interpolation-update-layout.html (0 => 287710) --- trunk/LayoutTests/css3/filters/reference-filter-color-interpolation-update-layout.html (rev 0) +++ trunk/LayoutTests/css3/filters/reference-filter-color-interpolation-update-layout.html 2022-01-06 20:04:41 UTC (rev 287710) @@ -0,0 +1,33 @@ + +This test passes if it does not crash. + + + +if (window.testRunner) +window.testRunner.dumpAsText(true); + + Modified: trunk/Source/WebCore/ChangeLog (287709 => 287710) --- trunk/Source/WebCore/ChangeLog 2022-01-06 20:01:46 UTC (rev 287709) +++ trunk/Source/WebCore/ChangeLog 2022-01-06 20:04:41 UTC (rev 287710) @@ -1,3 +1,23 @@ +2022-01-06 Said Abou-Hallawa + +REGRESSION(r285618):A crash may happen when calculating the color-interpolation of a referenced SVG filter +https://bugs.webkit.org/show_bug.cgi?id=234918 +rdar://86928631 + +Reviewed by Simon Fraser. + +When building a referenced SVGFilter, the color-interpolation property +of the effect element is needed. If the effect element does not have a +renderer, we fallback to the computed style property value. And if the +SVG filter is inside an which has media queries, a Document:: +updateLayout() will be forced. Building the SVGFilter should not invoke +an updateLayout() since this may not be safe and out of order. + +Test: css3/filters/reference-filter-color-interpolation-update-layout.html + +* svg/graphics/filters/SVGFilterBuilder.cpp: +(WebCore::colorInterpolationForElement): + 2022-01-06 Antoine Quint Remove Animation::operator= Modified: trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp (287709 => 287710) --- trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp 2022-01-06 20:01:46 UTC (rev 287709) +++ trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp 2022-01-06 20:04:41 UTC (rev 287710) @@ -70,7 +70,7 @@ return renderer->style().svgStyle().colorInterpolationFilters(); // Try to determine the property value from the computed style. -if (auto value = Compute
[webkit-changes] [287709] branches/safari-612-branch
Title: [287709] branches/safari-612-branch
Revision 287709
Author repst...@apple.com
Date 2022-01-06 12:01:46 -0800 (Thu, 06 Jan 2022)
Log Message
Apply patch. rdar://problem/87124847
Modified Paths
branches/safari-612-branch/LayoutTests/ChangeLog
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/bindings/js/ReadableStream.cpp
Added Paths
branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt
branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html
Diff
Modified: branches/safari-612-branch/LayoutTests/ChangeLog (287708 => 287709)
--- branches/safari-612-branch/LayoutTests/ChangeLog 2022-01-06 19:59:35 UTC (rev 287708)
+++ branches/safari-612-branch/LayoutTests/ChangeLog 2022-01-06 20:01:46 UTC (rev 287709)
@@ -1,5 +1,19 @@
2022-01-06 Russell Epstein
+Apply patch. rdar://problem/87124847
+
+2022-01-06 Youenn Fablet
+
+ReadableStream::lock should check whether there is an exception when getting ReadableStreamDefaultReader private constructor
+https://bugs.webkit.org/show_bug.cgi?id=234890
+
+Reviewed by Frédéric Wang.
+
+* streams/readable-stream-lock-after-worker-terminates-crash-expected.txt: Added.
+* streams/readable-stream-lock-after-worker-terminates-crash.html: Added.
+
+2022-01-06 Russell Epstein
+
Apply patch. rdar://problem/87125345
2022-01-06 Youenn Fablet
Added: branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt (0 => 287709)
--- branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt (rev 0)
+++ branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash-expected.txt 2022-01-06 20:01:46 UTC (rev 287709)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: This test PASS if it does not crash.
+
Added: branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html (0 => 287709)
--- branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html (rev 0)
+++ branches/safari-612-branch/LayoutTests/streams/readable-stream-lock-after-worker-terminates-crash.html 2022-01-06 20:01:46 UTC (rev 287709)
@@ -0,0 +1,30 @@
+
+function createWorker() {
+function createRequest() {
+setTimeout(() => {
+const request = new Request("http://test.org", {"method": "POST", "body": "text" });
+request.text();
+request.body;
+}, 0);
+self.postMessage("");
+};
+const worker = new Worker('data:application/_javascript_;charset=utf-8,' + createRequest.toString() + ';createRequest()');
+return new Promise(resolve => {
+worker._onmessage_ = () => {
+worker.terminate();
+resolve();
+}
+});
+}
+
+_onload_ = () => {
+if (window.testRunner)
+testRunner.dumpAsText();
+console.log('This test PASS if it does not crash.')
+for (var i = 0; i < 100; ++i) {
+const script = document.createElement('script');
+script.src = ""
+document.head.appendChild(script);
+}
+};
+
Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (287708 => 287709)
--- branches/safari-612-branch/Source/WebCore/ChangeLog 2022-01-06 19:59:35 UTC (rev 287708)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2022-01-06 20:01:46 UTC (rev 287709)
@@ -1,5 +1,23 @@
2022-01-06 Russell Epstein
+Apply patch. rdar://problem/87124847
+
+2022-01-06 Youenn Fablet
+
+ReadableStream::lock should check whether there is an exception when getting ReadableStreamDefaultReader private constructor
+https://bugs.webkit.org/show_bug.cgi?id=234890
+
+Reviewed by Frédéric Wang and Mark Lam.
+
+Do in ReadableStream::lock like we are doing when getting ReadableStream private constructor in ReadableStream::create.
+For that reason, introduce a invokeConstructor utility function.
+
+Test: streams/readable-stream-lock-after-worker-terminates-crash.html
+
+* bindings/js/ReadableStream.cpp:
+
+2022-01-06 Russell Epstein
+
Apply patch. rdar://problem/87125345
2022-01-06 Youenn Fablet
Modified: branches/safari-612-branch/Source/WebCore/bindings/js/ReadableStream.cpp (287708 => 287709)
--- branches/safari-612-branch/Source/WebCore/bindings/js/ReadableStream.cpp 2022-01-06 19:59:35 UTC (rev 287708)
+++ branches/safari-612-branch/Source/WebCore/bindings/js/ReadableStream.cpp 2022-01-06 20:01:46 UTC (rev 287709)
@@ -37,30 +37,47 @@
namespace WebCore {
using namespace JSC;
-ExceptionOr> ReadableStream::create(JSC::JSGlobalObject& lexicalGlobalObject, RefPtr&& sourc
[webkit-changes] [287708] trunk/Source/WebCore
Title: [287708] trunk/Source/WebCore
Revision 287708
Author grao...@webkit.org
Date 2022-01-06 11:59:35 -0800 (Thu, 06 Jan 2022)
Log Message
Remove Animation::operator=
https://bugs.webkit.org/show_bug.cgi?id=234915
Reviewed by Yusuke Suzuki.
This doesn't seem to be required, so let's remove it.
* platform/animation/Animation.cpp:
(WebCore::Animation::operator=): Deleted.
* platform/animation/Animation.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/animation/Animation.cpp
trunk/Source/WebCore/platform/animation/Animation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (287707 => 287708)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 19:57:38 UTC (rev 287707)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 19:59:35 UTC (rev 287708)
@@ -1,5 +1,18 @@
2022-01-06 Antoine Quint
+Remove Animation::operator=
+https://bugs.webkit.org/show_bug.cgi?id=234915
+
+Reviewed by Yusuke Suzuki.
+
+This doesn't seem to be required, so let's remove it.
+
+* platform/animation/Animation.cpp:
+(WebCore::Animation::operator=): Deleted.
+* platform/animation/Animation.h:
+
+2022-01-06 Antoine Quint
+
[Web Animations] inserting a rule within a @keyframes rule should update animations
https://bugs.webkit.org/show_bug.cgi?id=234895
Modified: trunk/Source/WebCore/platform/animation/Animation.cpp (287707 => 287708)
--- trunk/Source/WebCore/platform/animation/Animation.cpp 2022-01-06 19:57:38 UTC (rev 287707)
+++ trunk/Source/WebCore/platform/animation/Animation.cpp 2022-01-06 19:59:35 UTC (rev 287708)
@@ -94,35 +94,6 @@
{
}
-Animation& Animation::operator=(const Animation& o)
-{
-m_name = o.m_name;
-m_iterationCount = o.m_iterationCount;
-m_delay = o.m_delay;
-m_duration = o.m_duration;
-m_timingFunction = o.m_timingFunction;
-m_nameStyleScopeOrdinal = o.m_nameStyleScopeOrdinal;
-m_property = o.m_property;
-m_direction = o.m_direction;
-m_fillMode = o.m_fillMode;
-m_playState = o.m_playState;
-m_compositeOperation = o.m_compositeOperation;
-
-m_delaySet = o.m_delaySet;
-m_directionSet = o.m_directionSet;
-m_durationSet = o.m_durationSet;
-m_fillModeSet = o.m_fillModeSet;
-m_iterationCountSet = o.m_iterationCountSet;
-m_nameSet = o.m_nameSet;
-m_playStateSet = o.m_playStateSet;
-m_propertySet = o.m_propertySet;
-m_timingFunctionSet = o.m_timingFunctionSet;
-m_compositeOperationSet = o.m_compositeOperationSet;
-m_isNone = o.m_isNone;
-
-return *this;
-}
-
Animation::~Animation() = default;
bool Animation::animationsMatch(const Animation& other, bool matchProperties) const
Modified: trunk/Source/WebCore/platform/animation/Animation.h (287707 => 287708)
--- trunk/Source/WebCore/platform/animation/Animation.h 2022-01-06 19:57:38 UTC (rev 287707)
+++ trunk/Source/WebCore/platform/animation/Animation.h 2022-01-06 19:59:35 UTC (rev 287708)
@@ -177,8 +177,6 @@
bool isPropertyFilled() const { return m_propertyFilled; }
bool isTimingFunctionFilled() const { return m_timingFunctionFilled; }
-Animation& operator=(const Animation&);
-
// return true if all members of this class match (excluding m_next)
bool animationsMatch(const Animation&, bool matchProperties = true) const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287707] trunk
Title: [287707] trunk Revision 287707 Author grao...@webkit.org Date 2022-01-06 11:57:38 -0800 (Thu, 06 Jan 2022) Log Message [Web Animations] inserting a rule within a @keyframes rule should update animations https://bugs.webkit.org/show_bug.cgi?id=234895 Reviewed by Darin Adler. LayoutTests/imported/w3c: Mark WPT progressions. * web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt: * web-platform-tests/css/css-animations/KeyframeEffect-setKeyframes.tentative-expected.txt: Source/WebCore: Using the CSSOM, it is possible to insert or delete rules within an @keyframes rule. In fact, there are two WPT that check this behavior with the getKeyframes() and setKeyframes() methods. This would not have any effect until now because when we consider whether to invalidate animations in Styleable::updateCSSAnimations(), we look at the previous and current AnimationList and don't see any difference because we look, as far as keyframes are concerned, at the @keyframes name but not at the keyframes content. Now, when a rule is added or deleted from an @keyframes rule using the CSSOM, we notify the Document using the new keyframesRuleDidChange() method, which in turn checks all CSSAnimation objects applied to elements in that document using that @keyframes rule and notifies them of the change by calling keyframesRuleDidChange(). This clears the keyframes on the associated KeyframeEffect, invalidates the target and sets a flag on the ElementAnimationRareData that this element is pending update to its CSS Animations' keyframe such that during the next call Styleable::updateCSSAnimations() we force the update even if the previous and current AnimationList look identical. During that next call to Styleable::updateCSSAnimations(), we will call into the new CSSAnimation::updateKeyframesIfNeeded() which will re-compute the keyframes based on the current set of rules within the @keyframes rule. The final piece of work required is to track when setKeyframes() is called on the effect that updates to the @keyframes rule should no longer apply since they keyframes were overriden by the Web Animations API. This is done by setting an additional flag in CSSAnimation::effectKeyframesWereSetUsingBindings(). * animation/CSSAnimation.cpp: (WebCore::CSSAnimation::effectKeyframesWereSetUsingBindings): (WebCore::CSSAnimation::keyframesRuleDidChange): (WebCore::CSSAnimation::updateKeyframesIfNeeded): * animation/CSSAnimation.h: * animation/ElementAnimationRareData.h: (WebCore::ElementAnimationRareData::cssAnimationsDidUpdate): (WebCore::ElementAnimationRareData::keyframesRuleDidChange): (WebCore::ElementAnimationRareData::hasPendingKeyframesUpdate const): * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::keyframesRuleDidChange): * animation/KeyframeEffect.h: * css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::didMutateRules): (WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope): (WebCore::CSSStyleSheet::RuleMutationScope::~RuleMutationScope): * css/CSSStyleSheet.h: * dom/Document.cpp: (WebCore::Document::keyframesRuleDidChange): * dom/Document.h: * dom/Element.cpp: (WebCore::Element::cssAnimationsDidUpdate): (WebCore::Element::keyframesRuleDidChange): (WebCore::Element::hasPendingKeyframesUpdate const): * dom/Element.h: * style/Styleable.cpp: (WebCore::Styleable::updateCSSAnimations const): * style/Styleable.h: (WebCore::Styleable::keyframesRuleDidChange const): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-setKeyframes.tentative-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/CSSAnimation.cpp trunk/Source/WebCore/animation/CSSAnimation.h trunk/Source/WebCore/animation/ElementAnimationRareData.h trunk/Source/WebCore/animation/KeyframeEffect.cpp trunk/Source/WebCore/animation/KeyframeEffect.h trunk/Source/WebCore/css/CSSStyleSheet.cpp trunk/Source/WebCore/css/CSSStyleSheet.h trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/style/Styleable.cpp trunk/Source/WebCore/style/Styleable.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287706 => 287707) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-06 19:47:35 UTC (rev 287706) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-06 19:57:38 UTC (rev 287707) @@ -1,3 +1,15 @@ +2022-01-06 Antoine Quint + +[Web Animations] inserting a rule within a @keyframes rule should update animations +https://bugs.webkit.org/show_bug.cgi?id=234895 + +Reviewed by Darin Adler. + +Mark WPT progressions. + +* web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt: +* web-platform-tests/css/c
[webkit-changes] [287706] branches/safari-612-branch/Source/WebKit
Title: [287706] branches/safari-612-branch/Source/WebKit
Revision 287706
Author repst...@apple.com
Date 2022-01-06 11:47:35 -0800 (Thu, 06 Jan 2022)
Log Message
Cherry-pick r287651. rdar://problem/86338105
Fix the build
* Shared/ios/WebIOSEventFactory.mm:
(WebIOSEventFactory::createWebWheelEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm
Diff
Modified: branches/safari-612-branch/Source/WebKit/ChangeLog (287705 => 287706)
--- branches/safari-612-branch/Source/WebKit/ChangeLog 2022-01-06 19:47:31 UTC (rev 287705)
+++ branches/safari-612-branch/Source/WebKit/ChangeLog 2022-01-06 19:47:35 UTC (rev 287706)
@@ -1,5 +1,24 @@
2022-01-06 Russell Epstein
+Cherry-pick r287651. rdar://problem/86338105
+
+Fix the build
+
+* Shared/ios/WebIOSEventFactory.mm:
+(WebIOSEventFactory::createWebWheelEvent):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-01-05 Tim Horton
+
+Fix the build
+
+* Shared/ios/WebIOSEventFactory.mm:
+(WebIOSEventFactory::createWebWheelEvent):
+
+2022-01-06 Russell Epstein
+
Cherry-pick r287641. rdar://problem/86338105
Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's
Modified: branches/safari-612-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm (287705 => 287706)
--- branches/safari-612-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm 2022-01-06 19:47:31 UTC (rev 287705)
+++ branches/safari-612-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm 2022-01-06 19:47:35 UTC (rev 287706)
@@ -178,7 +178,8 @@
{ },
timestamp,
timestamp,
-{ }
+{ },
+WebKit::WebWheelEvent::MomentumEndType::Unknown
};
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287705] branches/safari-612-branch/Source
Title: [287705] branches/safari-612-branch/Source Revision 287705 Author repst...@apple.com Date 2022-01-06 11:47:31 -0800 (Thu, 06 Jan 2022) Log Message Cherry-pick r287641. rdar://problem/86338105 Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's https://bugs.webkit.org/show_bug.cgi?id=234535 Reviewed by Simon Fraser. Source/WebKit: Currently, synthetic momentum dispatch is strictly tied to the duration of the real platform momentum phase, which has two unfortunate implications: - if our phase runs shorter than the platform phase, we'll keep dispatching zero-delta events until the platform momentum ends - more importantly, if our phase runs longer, it will be abruptly terminated when the platform momentum ends In practice, our synthetic phase is very close in duration to the system one, so the impact is minimal. But, to be safe, disentagle the two durations, using a new bit from the platform to determine if the system momentum phase was interrupted by the user (e.g. by tapping the trackpad) or naturally, and ignoring the ended event in the natural case, allowing synthetic events to continue being dispatched. * Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent): (WebKit::WebWheelEvent::encode const): (WebKit::WebWheelEvent::decode): * Shared/WebWheelEvent.h: (WebKit::WebWheelEvent::momentumEndType const): * Shared/WebWheelEventCoalescer.cpp: (WebKit::WebWheelEventCoalescer::coalesce): Plumb momentumEndType along on WebWheelEvent. Platforms that don't provide information about the interruption reason will always say Unknown. * Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent): Only bother looking up the CGEvent/IOHIDEvent once, and extract all relevant details in one go. * WebProcess/WebPage/MomentumEventDispatcher.cpp: (WebKit::MomentumEventDispatcher::handleWheelEvent): Don't interrupt the synthetic momentum phase if the momentum-ended event comes from the natural end of the deceleration instead of an interruption (or an unknown reason). Keep track of whether we're in the middle of a platform momentum phase that we chose (at momentum-begin time) to override. When deciding whether to eat an incoming event, take *both* this new bit and whether we are currently in the middle of a synthetic phase into account. It is important to continue eating incoming events in the case where the synthetic phase ended early (so `active` became false) but the platform phase continues. (WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent): (WebKit::MomentumEventDispatcher::didEndMomentumPhase): Adjust some logging wording to be more precise. (WebKit::MomentumEventDispatcher::setScrollingAccelerationCurve): Make this log public so that the curve value is visible in logs. (WebKit::MomentumEventDispatcher::consumeDeltaForCurrentTime): Make consumeDeltaForCurrentTime inform the client via an optional when we are at the end of the delta table. (WebKit::MomentumEventDispatcher::displayWasRefreshed): Stop the synthetic momentum phase as soon as we run out of deltas. (WebKit::MomentumEventDispatcher::computeNextDelta): * WebProcess/WebPage/MomentumEventDispatcher.h: Source/WTF: * wtf/PlatformHave.h: Add a HAVE for kIOHIDEventScrollMomentumInterrupted. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287641 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612-branch/Source/WTF/ChangeLog branches/safari-612-branch/Source/WTF/wtf/PlatformHave.h branches/safari-612-branch/Source/WebCore/PAL/pal/spi/mac/IOKitSPIMac.h branches/safari-612-branch/Source/WebKit/ChangeLog branches/safari-612-branch/Source/WebKit/Shared/WebWheelEvent.cpp branches/safari-612-branch/Source/WebKit/Shared/WebWheelEvent.h branches/safari-612-branch/Source/WebKit/Shared/WebWheelEventCoalescer.cpp branches/safari-612-branch/Source/WebKit/Shared/mac/WebEventFactory.mm branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h Diff Modified: branches/safari-612-branch/Source/WTF/ChangeLog (287704 => 287705) --- branches/safari-612-branch/Source/WTF/ChangeLog 2022-01-06 19:44:38 UTC (rev 287704) +++ branches/safari-612-branch/Source/WTF/ChangeLog 2022-01-06 19:47:31 UTC (rev 287705) @@ -1,3 +1,97 @@ +2022-01-06 Russell Epstein + +Cherry-pick r287641. rdar://problem/86338105 + +Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's +https://bugs.webkit.org/show_bug.cgi?id=234535 + + +Reviewed by Simon Fraser. + +Source/WebKit: + +Currently, synthetic mo
[webkit-changes] [287704] trunk/Source/WebCore
Title: [287704] trunk/Source/WebCore
Revision 287704
Author andresg...@apple.com
Date 2022-01-06 11:44:38 -0800 (Thu, 06 Jan 2022)
Log Message
Replace WTFMove + clear with std::exchange for AXObjectCache notification queues.
https://bugs.webkit.org/show_bug.cgi?id=234919
Reviewed by Chris Fleizach.
Code clean up, per Darin Adler's comment in
https://bugs.webkit.org/show_bug.cgi?id=234355.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::passwordNotificationPostTimerFired):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (287703 => 287704)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 19:41:35 UTC (rev 287703)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 19:44:38 UTC (rev 287704)
@@ -1,3 +1,18 @@
+2022-01-06 Andres Gonzalez
+
+Replace WTFMove + clear with std::exchange for AXObjectCache notification queues.
+https://bugs.webkit.org/show_bug.cgi?id=234919
+
+
+Reviewed by Chris Fleizach.
+
+Code clean up, per Darin Adler's comment in
+https://bugs.webkit.org/show_bug.cgi?id=234355.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::notificationPostTimerFired):
+(WebCore::AXObjectCache::passwordNotificationPostTimerFired):
+
2022-01-06 Tim Horton
Always assume Safari is "linked-on-or-after" any SDK version
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (287703 => 287704)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-01-06 19:41:35 UTC (rev 287703)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-01-06 19:44:38 UTC (rev 287704)
@@ -111,6 +111,7 @@
#include "TextBoundaries.h"
#include "TextControlInnerElements.h"
#include "TextIterator.h"
+#include
#include
#include
@@ -1081,8 +1082,7 @@
// In tests, posting notifications has a tendency to immediately queue up other notifications, which can lead to unexpected behavior
// when the notification list is cleared at the end. Instead copy this list at the start.
-auto notifications = WTFMove(m_notificationsToPost);
-m_notificationsToPost.clear();
+auto notifications = std::exchange(m_notificationsToPost, { });
// Filter out the notifications that are not going to be posted to platform clients.
Vector, AXNotification>> notificationsToPost;
@@ -1133,8 +1133,7 @@
// In tests, posting notifications has a tendency to immediately queue up other notifications, which can lead to unexpected behavior
// when the notification list is cleared at the end. Instead copy this list at the start.
-auto notifications = WTFMove(m_passwordNotificationsToPost);
-m_passwordNotificationsToPost.clear();
+auto notifications = std::exchange(m_passwordNotificationsToPost, { });
for (auto& notification : notifications)
postTextStateChangePlatformNotification(notification.get(), AXTextEditTypeInsert, " ", VisiblePosition());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287703] branches/safari-612.4.8.1-branch/Source/WebKit
Title: [287703] branches/safari-612.4.8.1-branch/Source/WebKit
Revision 287703
Author repst...@apple.com
Date 2022-01-06 11:41:35 -0800 (Thu, 06 Jan 2022)
Log Message
Cherry-pick r287651. rdar://problem/86338105
Fix the build
* Shared/ios/WebIOSEventFactory.mm:
(WebIOSEventFactory::createWebWheelEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.4.8.1-branch/Source/WebKit/ChangeLog
branches/safari-612.4.8.1-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm
Diff
Modified: branches/safari-612.4.8.1-branch/Source/WebKit/ChangeLog (287702 => 287703)
--- branches/safari-612.4.8.1-branch/Source/WebKit/ChangeLog 2022-01-06 19:41:31 UTC (rev 287702)
+++ branches/safari-612.4.8.1-branch/Source/WebKit/ChangeLog 2022-01-06 19:41:35 UTC (rev 287703)
@@ -1,5 +1,24 @@
2022-01-06 Russell Epstein
+Cherry-pick r287651. rdar://problem/86338105
+
+Fix the build
+
+* Shared/ios/WebIOSEventFactory.mm:
+(WebIOSEventFactory::createWebWheelEvent):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-01-05 Tim Horton
+
+Fix the build
+
+* Shared/ios/WebIOSEventFactory.mm:
+(WebIOSEventFactory::createWebWheelEvent):
+
+2022-01-06 Russell Epstein
+
Cherry-pick r287641. rdar://problem/86338105
Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's
Modified: branches/safari-612.4.8.1-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm (287702 => 287703)
--- branches/safari-612.4.8.1-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm 2022-01-06 19:41:31 UTC (rev 287702)
+++ branches/safari-612.4.8.1-branch/Source/WebKit/Shared/ios/WebIOSEventFactory.mm 2022-01-06 19:41:35 UTC (rev 287703)
@@ -178,7 +178,8 @@
{ },
timestamp,
timestamp,
-{ }
+{ },
+WebKit::WebWheelEvent::MomentumEndType::Unknown
};
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287702] branches/safari-612.4.8.1-branch/Source
Title: [287702] branches/safari-612.4.8.1-branch/Source Revision 287702 Author repst...@apple.com Date 2022-01-06 11:41:31 -0800 (Thu, 06 Jan 2022) Log Message Cherry-pick r287641. rdar://problem/86338105 Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's https://bugs.webkit.org/show_bug.cgi?id=234535 Reviewed by Simon Fraser. Source/WebKit: Currently, synthetic momentum dispatch is strictly tied to the duration of the real platform momentum phase, which has two unfortunate implications: - if our phase runs shorter than the platform phase, we'll keep dispatching zero-delta events until the platform momentum ends - more importantly, if our phase runs longer, it will be abruptly terminated when the platform momentum ends In practice, our synthetic phase is very close in duration to the system one, so the impact is minimal. But, to be safe, disentagle the two durations, using a new bit from the platform to determine if the system momentum phase was interrupted by the user (e.g. by tapping the trackpad) or naturally, and ignoring the ended event in the natural case, allowing synthetic events to continue being dispatched. * Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent): (WebKit::WebWheelEvent::encode const): (WebKit::WebWheelEvent::decode): * Shared/WebWheelEvent.h: (WebKit::WebWheelEvent::momentumEndType const): * Shared/WebWheelEventCoalescer.cpp: (WebKit::WebWheelEventCoalescer::coalesce): Plumb momentumEndType along on WebWheelEvent. Platforms that don't provide information about the interruption reason will always say Unknown. * Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent): Only bother looking up the CGEvent/IOHIDEvent once, and extract all relevant details in one go. * WebProcess/WebPage/MomentumEventDispatcher.cpp: (WebKit::MomentumEventDispatcher::handleWheelEvent): Don't interrupt the synthetic momentum phase if the momentum-ended event comes from the natural end of the deceleration instead of an interruption (or an unknown reason). Keep track of whether we're in the middle of a platform momentum phase that we chose (at momentum-begin time) to override. When deciding whether to eat an incoming event, take *both* this new bit and whether we are currently in the middle of a synthetic phase into account. It is important to continue eating incoming events in the case where the synthetic phase ended early (so `active` became false) but the platform phase continues. (WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent): (WebKit::MomentumEventDispatcher::didEndMomentumPhase): Adjust some logging wording to be more precise. (WebKit::MomentumEventDispatcher::setScrollingAccelerationCurve): Make this log public so that the curve value is visible in logs. (WebKit::MomentumEventDispatcher::consumeDeltaForCurrentTime): Make consumeDeltaForCurrentTime inform the client via an optional when we are at the end of the delta table. (WebKit::MomentumEventDispatcher::displayWasRefreshed): Stop the synthetic momentum phase as soon as we run out of deltas. (WebKit::MomentumEventDispatcher::computeNextDelta): * WebProcess/WebPage/MomentumEventDispatcher.h: Source/WTF: * wtf/PlatformHave.h: Add a HAVE for kIOHIDEventScrollMomentumInterrupted. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287641 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.4.8.1-branch/Source/WTF/ChangeLog branches/safari-612.4.8.1-branch/Source/WTF/wtf/PlatformHave.h branches/safari-612.4.8.1-branch/Source/WebCore/PAL/pal/spi/mac/IOKitSPIMac.h branches/safari-612.4.8.1-branch/Source/WebKit/ChangeLog branches/safari-612.4.8.1-branch/Source/WebKit/Shared/WebWheelEvent.cpp branches/safari-612.4.8.1-branch/Source/WebKit/Shared/WebWheelEvent.h branches/safari-612.4.8.1-branch/Source/WebKit/Shared/WebWheelEventCoalescer.cpp branches/safari-612.4.8.1-branch/Source/WebKit/Shared/mac/WebEventFactory.mm branches/safari-612.4.8.1-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp branches/safari-612.4.8.1-branch/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h Diff Modified: branches/safari-612.4.8.1-branch/Source/WTF/ChangeLog (287701 => 287702) --- branches/safari-612.4.8.1-branch/Source/WTF/ChangeLog 2022-01-06 19:38:37 UTC (rev 287701) +++ branches/safari-612.4.8.1-branch/Source/WTF/ChangeLog 2022-01-06 19:41:31 UTC (rev 287702) @@ -1,3 +1,97 @@ +2022-01-06 Russell Epstein + +Cherry-pick r287641. rdar://problem/86338105 + +Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's +https://bugs.webkit.org/show_bug.cgi?id=234535 + + +Re
[webkit-changes] [287701] branches/safari-612.4.8.1-branch/Source
Title: [287701] branches/safari-612.4.8.1-branch/Source Revision 287701 Author repst...@apple.com Date 2022-01-06 11:38:37 -0800 (Thu, 06 Jan 2022) Log Message Versioning. WebKit-7612.4.8.1.1 Modified Paths branches/safari-612.4.8.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.4.8.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.4.8.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.4.8.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.4.8.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.4.8.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.4.8.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.4.8.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.4.8.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (287700 => 287701) --- branches/safari-612.4.8.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-01-06 19:19:53 UTC (rev 287700) +++ branches/safari-612.4.8.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-01-06 19:38:37 UTC (rev 287701) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 8; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.8.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (287700 => 287701) --- branches/safari-612.4.8.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-01-06 19:19:53 UTC (rev 287700) +++ branches/safari-612.4.8.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-01-06 19:38:37 UTC (rev 287701) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 8; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.8.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (287700 => 287701) --- branches/safari-612.4.8.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-01-06 19:19:53 UTC (rev 287700) +++ branches/safari-612.4.8.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-01-06 19:38:37 UTC (rev 287701) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 8; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.8.1-branch/Source/WebCore/Configurations/Version.xcconfig (287700 => 287701) --- branches/safari-612.4.8.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-01-06 19:19:53 UTC (rev 287700) +++ branches/safari-612.4.8.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-01-06 19:38:37 UTC (rev 287701) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 8; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.4.8.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (287700 => 287701) --- branches/safari-612.4.8.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-01-06 19:19:53 UTC (rev 287700) +++ branches/safari-612.4.8.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-01-06 19:38:37 UTC (rev 287701) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 4; TINY_VERSION = 8; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VE
[webkit-changes] [287700] branches/safari-612.4.8.1-branch/
Title: [287700] branches/safari-612.4.8.1-branch/ Revision 287700 Author repst...@apple.com Date 2022-01-06 11:19:53 -0800 (Thu, 06 Jan 2022) Log Message New branch. Added Paths branches/safari-612.4.8.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287699] trunk/Source
Title: [287699] trunk/Source
Revision 287699
Author timothy_hor...@apple.com
Date 2022-01-06 10:58:12 -0800 (Thu, 06 Jan 2022)
Log Message
Always assume Safari is "linked-on-or-after" any SDK version
https://bugs.webkit.org/show_bug.cgi?id=234914
Reviewed by Aditya Keerthi.
Source/WebCore:
* platform/cocoa/VersionChecks.h:
* platform/cocoa/VersionChecks.mm:
(WebCore::linkedOnOrAfter):
Remove the AssumeSafariIsAlwaysLinkedOnAfter::No mechanism, which no longer
has any clients.
Source/WebKit:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
Get rid of this special-case AssumeSafariIsAlwaysLinkedOnAfter::No,
from r244203, because we no longer target versions of macOS that
ship with versions of Safari that require this special case.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/VersionChecks.h
trunk/Source/WebCore/platform/cocoa/VersionChecks.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (287698 => 287699)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 18:14:28 UTC (rev 287698)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 18:58:12 UTC (rev 287699)
@@ -1,3 +1,16 @@
+2022-01-06 Tim Horton
+
+Always assume Safari is "linked-on-or-after" any SDK version
+https://bugs.webkit.org/show_bug.cgi?id=234914
+
+Reviewed by Aditya Keerthi.
+
+* platform/cocoa/VersionChecks.h:
+* platform/cocoa/VersionChecks.mm:
+(WebCore::linkedOnOrAfter):
+Remove the AssumeSafariIsAlwaysLinkedOnAfter::No mechanism, which no longer
+has any clients.
+
2022-01-06 Alex Christensen
Start using C++20
Modified: trunk/Source/WebCore/platform/cocoa/VersionChecks.h (287698 => 287699)
--- trunk/Source/WebCore/platform/cocoa/VersionChecks.h 2022-01-06 18:14:28 UTC (rev 287698)
+++ trunk/Source/WebCore/platform/cocoa/VersionChecks.h 2022-01-06 18:58:12 UTC (rev 287699)
@@ -112,7 +112,6 @@
#endif
};
-enum class AssumeSafariIsAlwaysLinkedOnAfter : bool { No, Yes };
-WEBCORE_EXPORT bool linkedOnOrAfter(SDKVersion, AssumeSafariIsAlwaysLinkedOnAfter = AssumeSafariIsAlwaysLinkedOnAfter::Yes);
+WEBCORE_EXPORT bool linkedOnOrAfter(SDKVersion);
}
Modified: trunk/Source/WebCore/platform/cocoa/VersionChecks.mm (287698 => 287699)
--- trunk/Source/WebCore/platform/cocoa/VersionChecks.mm 2022-01-06 18:14:28 UTC (rev 287698)
+++ trunk/Source/WebCore/platform/cocoa/VersionChecks.mm 2022-01-06 18:58:12 UTC (rev 287699)
@@ -33,7 +33,7 @@
namespace WebCore {
-bool linkedOnOrAfter(SDKVersion sdkVersion, AssumeSafariIsAlwaysLinkedOnAfter assumeSafariIsAlwaysLinkedOnAfter)
+bool linkedOnOrAfter(SDKVersion sdkVersion)
{
#if PLATFORM(IOS_FAMILY)
bool isSafari = WebCore::IOSApplication::isMobileSafari();
@@ -41,7 +41,7 @@
bool isSafari = WebCore::MacApplication::isSafari();
#endif
-if (isSafari && assumeSafariIsAlwaysLinkedOnAfter == AssumeSafariIsAlwaysLinkedOnAfter::Yes)
+if (isSafari)
return true;
auto sdkVersionAsInteger = static_cast(sdkVersion);
Modified: trunk/Source/WebKit/ChangeLog (287698 => 287699)
--- trunk/Source/WebKit/ChangeLog 2022-01-06 18:14:28 UTC (rev 287698)
+++ trunk/Source/WebKit/ChangeLog 2022-01-06 18:58:12 UTC (rev 287699)
@@ -1,3 +1,16 @@
+2022-01-06 Tim Horton
+
+Always assume Safari is "linked-on-or-after" any SDK version
+https://bugs.webkit.org/show_bug.cgi?id=234914
+
+Reviewed by Aditya Keerthi.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _initializeWithConfiguration:]):
+Get rid of this special-case AssumeSafariIsAlwaysLinkedOnAfter::No,
+from r244203, because we no longer target versions of macOS that
+ship with versions of Safari that require this special case.
+
2022-01-06 Alex Christensen
Start using C++20
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (287698 => 287699)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-01-06 18:14:28 UTC (rev 287698)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-01-06 18:58:12 UTC (rev 287699)
@@ -340,7 +340,7 @@
WKProcessPool *relatedWebViewProcessPool = [relatedWebView->_configuration processPool];
if (processPool && processPool != relatedWebViewProcessPool)
[NSException raise:NSInvalidArgumentException format:@"Related web view %@ has process pool %@ but configuration specifies a different process pool %@", relatedWebView, relatedWebViewProcessPool, configuration.processPool];
-if ([relatedWebView->_configuration websiteDataStore] != [_configuration websiteDataStore] && linkedOnOrAfter(WebCore::SDKVersion::FirstWithExceptionsForRelatedWebViewsUsingDifferentDataStores, WebCore::AssumeSafariIsAlwaysLinkedOnAfter::No))
+if ([relatedWebView->_configuration websiteDataStore] != [_configuration websiteDataStore
[webkit-changes] [287698] trunk
Title: [287698] trunk Revision 287698 Author achristen...@apple.com Date 2022-01-06 10:14:28 -0800 (Thu, 06 Jan 2022) Log Message Start using C++20 https://bugs.webkit.org/show_bug.cgi?id=233963 Reviewed by Yusuke Suzuki. .: * Source/cmake/OptionsCommon.cmake: * Source/cmake/WebKitCompilerFlags.cmake: Source/bmalloc: * Configurations/Base.xcconfig: Source/_javascript_Core: * Configurations/Base.xcconfig: * Configurations/_javascript_Core.xcconfig: * DerivedSources.make: * heap/Heap.cpp: (JSC::Heap::addCoreConstraints): * runtime/CachedTypes.cpp: * runtime/LiteralParser.h: * shell/PlatformPlayStation.cmake: Source/ThirdParty: * gtest/xcode/Config/General.xcconfig: Source/ThirdParty/ANGLE: * Configurations/Base.xcconfig: Source/ThirdParty/libwebrtc: * Configurations/Base.xcconfig: * Source/webrtc/rtc_base/system/no_unique_address.h: Source/WebCore: * Configurations/Base.xcconfig: * DerivedSources.make: * platform/graphics/cocoa/IOSurface.mm: (WebCore::IOSurface::ensurePlatformContext): * platform/ios/wak/WebCoreThread.mm: Source/WebCore/PAL: * Configurations/Base.xcconfig: Source/WebGPU: * Configurations/Base.xcconfig: Source/WebInspectorUI: * Configurations/Base.xcconfig: Source/WebKit: * Configurations/Base.xcconfig: * PlatformMac.cmake: * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration _setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Source/WebKitLegacy: * PlatformMac.cmake: Source/WebKitLegacy/mac: * Configurations/Base.xcconfig: * Configurations/WebKitLegacy.xcconfig: * MigrateHeaders.make: Source/WTF: * Configurations/Base.xcconfig: * wtf/DisallowCType.h: * wtf/FileSystem.cpp: (WTF::FileSystemImpl::toStdFileSystemPath): (WTF::FileSystemImpl::fromStdFileSystemPath): * wtf/PlatformHave.h: * wtf/VectorTraits.h: * wtf/text/StringOperators.h: Tools: * DumpRenderTree/DerivedSources.make: * DumpRenderTree/mac/Configurations/Base.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MobileMiniBrowser/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Tests/WTF/Expected.cpp: (TestWebKitAPI::NonCopyable::NonCopyable): * TestWebKitAPI/Tests/WTF/URLParser.cpp: (TestWebKitAPI::TEST_F): * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/DerivedSources.make: * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Modified Paths trunk/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/Base.xcconfig trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig trunk/Source/_javascript_Core/DerivedSources.make trunk/Source/_javascript_Core/heap/Heap.cpp trunk/Source/_javascript_Core/runtime/CachedTypes.cpp trunk/Source/_javascript_Core/runtime/LiteralParser.h trunk/Source/_javascript_Core/shell/PlatformPlayStation.cmake trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/system/no_unique_address.h trunk/Source/WTF/ChangeLog trunk/Source/WTF/Configurations/Base.xcconfig trunk/Source/WTF/wtf/DisallowCType.h trunk/Source/WTF/wtf/FileSystem.cpp trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WTF/wtf/VectorTraits.h trunk/Source/WTF/wtf/text/StringOperators.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/Base.xcconfig trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/Base.xcconfig trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/Configurations/Base.xcconfig trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Configurations/Base.xcconfig trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/Base.xcconfig trunk/Source/WebKit/PlatformMac.cmake trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm trunk/Source/WebKitLegacy/ChangeLog trunk/Source/WebKitLegacy/PlatformMac.cmake trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig trunk/Source/WebKitLegacy/mac/MigrateHeaders.make trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/Configurations/Base.xcconfig trunk/Source/cmake/OptionsCommon.cmake trunk/Source/cmake/WebKitCompilerFlags.cmake trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DerivedSources.make trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig trunk/Tools/MiniBrowser/Configurations/Base.xcconfig trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig trunk/Tools/TestWebKitAPI/Tests/WTF/Expected.cpp trunk/Tools/TestWebKitAPI/
[webkit-changes] [287697] trunk/Source/WebCore
Title: [287697] trunk/Source/WebCore
Revision 287697
Author akeer...@apple.com
Date 2022-01-06 10:04:00 -0800 (Thu, 06 Jan 2022)
Log Message
Prevent reentrancy in -[WebCoreThemeView window]
https://bugs.webkit.org/show_bug.cgi?id=234258
Reviewed by Wenson Hsieh.
Prevent reentrancy in `-[WebCoreThemeView window]` by eagerly
initializing the window (when `WebCoreThemeView` is created).
`WebCoreThemeView` is already only created once per process (as a
static variable in `ThemeMac::ensuredView`), so a static variable
for the window is unnecessary.
* platform/mac/ThemeMac.mm:
(-[WebCoreThemeView init]):
(-[WebCoreThemeView window]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ThemeMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (287696 => 287697)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 17:51:41 UTC (rev 287696)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 18:04:00 UTC (rev 287697)
@@ -1,3 +1,22 @@
+2022-01-06 Aditya Keerthi
+
+Prevent reentrancy in -[WebCoreThemeView window]
+https://bugs.webkit.org/show_bug.cgi?id=234258
+
+
+Reviewed by Wenson Hsieh.
+
+Prevent reentrancy in `-[WebCoreThemeView window]` by eagerly
+initializing the window (when `WebCoreThemeView` is created).
+
+`WebCoreThemeView` is already only created once per process (as a
+static variable in `ThemeMac::ensuredView`), so a static variable
+for the window is unnecessary.
+
+* platform/mac/ThemeMac.mm:
+(-[WebCoreThemeView init]):
+(-[WebCoreThemeView window]):
+
2022-01-06 Chris Dumez
Drop implementation for COOP / COEP violation reporting
Modified: trunk/Source/WebCore/platform/mac/ThemeMac.mm (287696 => 287697)
--- trunk/Source/WebCore/platform/mac/ThemeMac.mm 2022-01-06 17:51:41 UTC (rev 287696)
+++ trunk/Source/WebCore/platform/mac/ThemeMac.mm 2022-01-06 18:04:00 UTC (rev 287697)
@@ -68,17 +68,27 @@
}
@end
-@implementation WebCoreThemeView
+@implementation WebCoreThemeView {
+RetainPtr _window;
+}
-- (NSWindow *)window
+- (instancetype)init
{
+if (!(self = [super init]))
+return nil;
+
// Using defer:YES prevents us from wasting any window server resources for this window, since we're not actually
// going to draw into it. The other arguments match what you get when calling -[NSWindow init].
-static WebCoreThemeWindow *window = [[WebCoreThemeWindow alloc] initWithContentRect:NSMakeRect(100, 100, 100, 100)
-styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:YES];
-return window;
+_window = adoptNS([[WebCoreThemeWindow alloc] initWithContentRect:NSMakeRect(100, 100, 100, 100) styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:YES]);
+
+return self;
}
+- (NSWindow *)window
+{
+return _window.get();
+}
+
- (BOOL)isFlipped
{
return YES;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287696] trunk/LayoutTests
Title: [287696] trunk/LayoutTests Revision 287696 Author za...@apple.com Date 2022-01-06 09:51:41 -0800 (Thu, 06 Jan 2022) Log Message Tighten test expectation for imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform.html Unreviewed. * TestExpectations: Test passes fine in Release -this is an assertion issue in Debug. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (287695 => 287696) --- trunk/LayoutTests/ChangeLog 2022-01-06 17:25:14 UTC (rev 287695) +++ trunk/LayoutTests/ChangeLog 2022-01-06 17:51:41 UTC (rev 287696) @@ -1,3 +1,11 @@ +2022-01-06 Alan Bujtas + +Tighten test expectation for imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform.html + +Unreviewed. + +* TestExpectations: Test passes fine in Release -this is an assertion issue in Debug. + 2022-01-06 Chris Dumez Drop implementation for COOP / COEP violation reporting Modified: trunk/LayoutTests/TestExpectations (287695 => 287696) --- trunk/LayoutTests/TestExpectations 2022-01-06 17:25:14 UTC (rev 287695) +++ trunk/LayoutTests/TestExpectations 2022-01-06 17:51:41 UTC (rev 287696) @@ -2361,7 +2361,7 @@ webkit.org/b/231292 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-clip.html [ ImageOnlyFailure ] webkit.org/b/231292 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-scroll.html [ ImageOnlyFailure ] # Needs layer re-parenting -webkit.org/b/231292 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform.html [ Skip ] +webkit.org/b/231292 [ Debug ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform.html [ Skip ] # Assertion failure in MessagePort::contextDestroyed, usually attributed to later tests webkit.org/b/94458 http/tests/security/MessagePort/event-listener-context.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287695] branches/safari-613.1.12.1-branch/Source/WebKit
Title: [287695] branches/safari-613.1.12.1-branch/Source/WebKit Revision 287695 Author repst...@apple.com Date 2022-01-06 09:25:14 -0800 (Thu, 06 Jan 2022) Log Message Cherry-pick r287648. rdar://problem/86870109 [iOS][WP] Unable to consume mach extension https://bugs.webkit.org/show_bug.cgi?id=234889 Reviewed by Brent Fulgham. The WebContent process on iOS is unable to consume mach extensions to the frontboard service. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287648 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-613.1.12.1-branch/Source/WebKit/ChangeLog branches/safari-613.1.12.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Diff Modified: branches/safari-613.1.12.1-branch/Source/WebKit/ChangeLog (287694 => 287695) --- branches/safari-613.1.12.1-branch/Source/WebKit/ChangeLog 2022-01-06 17:25:10 UTC (rev 287694) +++ branches/safari-613.1.12.1-branch/Source/WebKit/ChangeLog 2022-01-06 17:25:14 UTC (rev 287695) @@ -1,5 +1,34 @@ 2022-01-06 Russell Epstein +Cherry-pick r287648. rdar://problem/86870109 + +[iOS][WP] Unable to consume mach extension +https://bugs.webkit.org/show_bug.cgi?id=234889 + + +Reviewed by Brent Fulgham. + +The WebContent process on iOS is unable to consume mach extensions to the frontboard service. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287648 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-01-05 Per Arne Vollan + +[iOS][WP] Unable to consume mach extension +https://bugs.webkit.org/show_bug.cgi?id=234889 + + +Reviewed by Brent Fulgham. + +The WebContent process on iOS is unable to consume mach extensions to the frontboard service. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + +2022-01-06 Russell Epstein + Cherry-pick r287616. rdar://problem/85990387 [macCatalyst][GPUP][NetworkProcess] Block WindowServer connections Modified: branches/safari-613.1.12.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (287694 => 287695) --- branches/safari-613.1.12.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-01-06 17:25:10 UTC (rev 287694) +++ branches/safari-613.1.12.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-01-06 17:25:14 UTC (rev 287695) @@ -1084,6 +1084,7 @@ (global-name "com.apple.cfprefsd.agent" "com.apple.cfprefsd.daemon" +"com.apple.frontboard.systemappservices" "com.apple.iphone.axserver-systemwide" "com.apple.mobileassetd.v2" "com.apple.mobilegestalt.xpc" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287694] branches/safari-613.1.12.1-branch/Source/WebKit
Title: [287694] branches/safari-613.1.12.1-branch/Source/WebKit
Revision 287694
Author repst...@apple.com
Date 2022-01-06 09:25:10 -0800 (Thu, 06 Jan 2022)
Log Message
Cherry-pick r287616. rdar://problem/85990387
[macCatalyst][GPUP][NetworkProcess] Block WindowServer connections
https://bugs.webkit.org/show_bug.cgi?id=234432
Reviewed by Brent Fulgham.
Block WindowServer connections on macCatalyst.
* GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::initializeProcess):
* NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::initializeProcess):
* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::setApplicationIsDaemon):
* WebAuthnProcess/mac/WebAuthnProcessMac.mm:
(WebKit::WebAuthnProcess::initializeProcess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.1.12.1-branch/Source/WebKit/ChangeLog
branches/safari-613.1.12.1-branch/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm
branches/safari-613.1.12.1-branch/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm
branches/safari-613.1.12.1-branch/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm
branches/safari-613.1.12.1-branch/Source/WebKit/WebAuthnProcess/mac/WebAuthnProcessMac.mm
Diff
Modified: branches/safari-613.1.12.1-branch/Source/WebKit/ChangeLog (287693 => 287694)
--- branches/safari-613.1.12.1-branch/Source/WebKit/ChangeLog 2022-01-06 17:21:06 UTC (rev 287693)
+++ branches/safari-613.1.12.1-branch/Source/WebKit/ChangeLog 2022-01-06 17:25:10 UTC (rev 287694)
@@ -1,3 +1,46 @@
+2022-01-06 Russell Epstein
+
+Cherry-pick r287616. rdar://problem/85990387
+
+[macCatalyst][GPUP][NetworkProcess] Block WindowServer connections
+https://bugs.webkit.org/show_bug.cgi?id=234432
+
+
+Reviewed by Brent Fulgham.
+
+Block WindowServer connections on macCatalyst.
+
+* GPUProcess/mac/GPUProcessMac.mm:
+(WebKit::GPUProcess::initializeProcess):
+* NetworkProcess/mac/NetworkProcessMac.mm:
+(WebKit::NetworkProcess::initializeProcess):
+* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
+(WebKit::AuxiliaryProcess::setApplicationIsDaemon):
+* WebAuthnProcess/mac/WebAuthnProcessMac.mm:
+(WebKit::WebAuthnProcess::initializeProcess):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-01-05 Per Arne Vollan
+
+[macCatalyst][GPUP][NetworkProcess] Block WindowServer connections
+https://bugs.webkit.org/show_bug.cgi?id=234432
+
+
+Reviewed by Brent Fulgham.
+
+Block WindowServer connections on macCatalyst.
+
+* GPUProcess/mac/GPUProcessMac.mm:
+(WebKit::GPUProcess::initializeProcess):
+* NetworkProcess/mac/NetworkProcessMac.mm:
+(WebKit::NetworkProcess::initializeProcess):
+* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
+(WebKit::AuxiliaryProcess::setApplicationIsDaemon):
+* WebAuthnProcess/mac/WebAuthnProcessMac.mm:
+(WebKit::WebAuthnProcess::initializeProcess):
+
2022-01-05 Alan Coon
Cherry-pick r287377. rdar://problem/86829012
Modified: branches/safari-613.1.12.1-branch/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm (287693 => 287694)
--- branches/safari-613.1.12.1-branch/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm 2022-01-06 17:21:06 UTC (rev 287693)
+++ branches/safari-613.1.12.1-branch/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm 2022-01-06 17:25:10 UTC (rev 287694)
@@ -35,7 +35,6 @@
#import
#import
#import
-#import
#import
#import
#import
@@ -46,11 +45,7 @@
void GPUProcess::initializeProcess(const AuxiliaryProcessInitializationParameters&)
{
-#if PLATFORM(MAC) && !PLATFORM(MACCATALYST)
-// Having a window server connection in this process would result in spin logs ().
-OSStatus error = SetApplicationIsDaemon(true);
-ASSERT_UNUSED(error, error == noErr);
-#endif
+setApplicationIsDaemon();
#if ENABLE(LOWER_FORMATREADERBUNDLE_CODESIGNING_REQUIREMENTS)
// For testing in engineering builds, allow CoreMedia to load the MediaFormatReader bundle no matter its code signature.
Modified: branches/safari-613.1.12.1-branch/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm (287693 => 287694)
--- branches/safari-613.1.12.1-branch/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm 2022-01-06 17:21:06 UTC (rev 287693)
+++ branches/safari-613.1.12.1-branch/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm 2022-01-06 17:25:10 UTC (rev 287694)
@@ -51,12 +51,7 @@
void NetworkProcess::initializeProcess(const AuxiliaryProcessInitializationParameters&)
{
-#if PLATFORM(MAC) && !PLATFORM(MACCATALYST)
-// Having a window server connection in this process would result in spin logs ().
-OSStatus error = SetApplicationIsDaemon(tr
[webkit-changes] [287693] trunk
Title: [287693] trunk Revision 287693 Author cdu...@apple.com Date 2022-01-06 09:21:06 -0800 (Thu, 06 Jan 2022) Log Message Drop implementation for COOP / COEP violation reporting https://bugs.webkit.org/show_bug.cgi?id=234899 Reviewed by Geoffrey Garen. Source/WebCore: Drop implementation for COOP / COEP violation reporting. The implementation was based on an outdated version of the specification and has never shipped. Many COOP/COEP reporting tests are also flaky. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * loader/CrossOriginEmbedderPolicy.cpp: (WebCore::contextURLForReport): Deleted. (WebCore::sendCOEPPolicyInheritenceViolation): Deleted. (WebCore::sendCOEPCORPViolation): Deleted. * loader/CrossOriginEmbedderPolicy.h: * loader/CrossOriginOpenerPolicy.cpp: (WebCore::enforceResponseCrossOriginOpenerPolicy): (WebCore::doCrossOriginOpenerHandlingOfResponse): (WebCore::crossOriginOpenerPolicyValueToEffectivePolicyString): Deleted. (WebCore::sendViolationReportWhenNavigatingToCOOPResponse): Deleted. (WebCore::sendViolationReportWhenNavigatingAwayFromCOOPResponse): Deleted. * loader/CrossOriginOpenerPolicy.h: * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::willSendRequest): (WebCore::DocumentLoader::doCrossOriginOpenerHandlingOfResponse): (WebCore::DocumentLoader::responseReceived): * loader/PingLoader.cpp: (WebCore::PingLoader::sendReportToEndpoint): Deleted. * loader/PingLoader.h: * loader/ReportingEndpointsCache.cpp: Removed. (WebCore::ReportingEndpointsCache::Endpoint::Endpoint): Deleted. (WebCore::ReportingEndpointsCache::Endpoint::hasExpired const): Deleted. (WebCore::ReportingEndpointsCache::create): Deleted. (WebCore::ReportingEndpointsCache::addEndpointsFromResponse): Deleted. (WebCore::ReportingEndpointsCache::addEndpointsFromReportToHeader): Deleted. (WebCore::ReportingEndpointsCache::addEndpointFromDictionary): Deleted. (WebCore::ReportingEndpointsCache::endpointURL const): Deleted. * loader/ReportingEndpointsCache.h: Removed. * page/Page.cpp: * page/Page.h: (WebCore::Page::reportingEndpointsCache): Deleted. * page/PageConfiguration.cpp: * page/PageConfiguration.h: Source/WebKit: Drop implementation for COOP / COEP violation reporting. The implementation was based on an outdated version of the specification and has never shipped. Many COOP/COEP reporting tests are also flaky. * NetworkProcess/NetworkLoadChecker.cpp: (WebKit::performCORPCheck): * NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::shouldInterruptNavigationForCrossOriginEmbedderPolicy): (WebKit::NetworkResourceLoader::shouldInterruptWorkerLoadForCrossOriginEmbedderPolicy): (WebKit::NetworkResourceLoader::doCrossOriginOpenerHandlingOfResponse): * WebProcess/WebPage/WebPage.cpp: (WebKit::m_appHighlightsVisible): (WebKit::WebPage::sendCOEPPolicyInheritenceViolation): Deleted. (WebKit::WebPage::sendCOEPCORPViolation): Deleted. (WebKit::WebPage::sendViolationReportWhenNavigatingToCOOPResponse): Deleted. (WebKit::WebPage::sendViolationReportWhenNavigatingAwayFromCOOPResponse): Deleted. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): * WebProcess/WebProcess.h: (WebKit::WebProcess::webSocketChannelManager): (WebKit::WebProcess::reportingEndpointsCache): Deleted. LayoutTests: Skip all COOP / COEP reporting tests instead of marking individual tests as flaky or failing. * TestExpectations: * platform/ios-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp trunk/Source/WebCore/loader/CrossOriginEmbedderPolicy.h trunk/Source/WebCore/loader/CrossOriginOpenerPolicy.cpp trunk/Source/WebCore/loader/CrossOriginOpenerPolicy.h trunk/Source/WebCore/loader/DocumentLoader.cpp trunk/Source/WebCore/loader/PingLoader.cpp trunk/Source/WebCore/loader/PingLoader.h trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebCore/page/PageConfiguration.cpp trunk/Source/WebCore/page/PageConfiguration.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit/WebProcess/WebProcess.cpp trunk/Source/WebKit/WebProcess/WebProcess.h Removed Paths trunk/Source/WebCore/loader/ReportingEndpointsCache.cpp trunk/Source/WebCore/loader/ReportingEndpointsCache.h Diff Modifi
[webkit-changes] [287692] trunk/Source/WebCore
Title: [287692] trunk/Source/WebCore
Revision 287692
Author cdu...@apple.com
Date 2022-01-06 09:15:43 -0800 (Thu, 06 Jan 2022)
Log Message
Drop unnecessary data member in WorkerThreadableLoader
https://bugs.webkit.org/show_bug.cgi?id=234907
Reviewed by Youenn Fablet.
Drop unnecessary data member in WorkerThreadableLoader. It is unused and holding a strong
reference to the WorkerGlobalScope for an extended period of time can lead to issues such
as Bug 230109.
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
* loader/WorkerThreadableLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp
trunk/Source/WebCore/loader/WorkerThreadableLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (287691 => 287692)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 17:15:26 UTC (rev 287691)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 17:15:43 UTC (rev 287692)
@@ -1,5 +1,20 @@
2022-01-06 Chris Dumez
+Drop unnecessary data member in WorkerThreadableLoader
+https://bugs.webkit.org/show_bug.cgi?id=234907
+
+Reviewed by Youenn Fablet.
+
+Drop unnecessary data member in WorkerThreadableLoader. It is unused and holding a strong
+reference to the WorkerGlobalScope for an extended period of time can lead to issues such
+as Bug 230109.
+
+* loader/WorkerThreadableLoader.cpp:
+(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+* loader/WorkerThreadableLoader.h:
+
+2022-01-06 Chris Dumez
+
Potential high CPU usage on macrumors.com
https://bugs.webkit.org/show_bug.cgi?id=234867
Modified: trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp (287691 => 287692)
--- trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp 2022-01-06 17:15:26 UTC (rev 287691)
+++ trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp 2022-01-06 17:15:43 UTC (rev 287692)
@@ -55,8 +55,7 @@
namespace WebCore {
WorkerThreadableLoader::WorkerThreadableLoader(WorkerOrWorkletGlobalScope& workerOrWorkletGlobalScope, ThreadableLoaderClient& client, const String& taskMode, ResourceRequest&& request, const ThreadableLoaderOptions& options, const String& referrer)
-: m_WorkerOrWorkletGlobalScope(workerOrWorkletGlobalScope)
-, m_workerClientWrapper(ThreadableLoaderClientWrapper::create(client, options.initiator))
+: m_workerClientWrapper(ThreadableLoaderClientWrapper::create(client, options.initiator))
, m_bridge(*new MainThreadBridge(m_workerClientWrapper.get(), workerOrWorkletGlobalScope.workerOrWorkletThread()->workerLoaderProxy(), taskMode, WTFMove(request), options, referrer.isEmpty() ? workerOrWorkletGlobalScope.url().strippedForUseAsReferrer() : referrer, workerOrWorkletGlobalScope))
{
}
Modified: trunk/Source/WebCore/loader/WorkerThreadableLoader.h (287691 => 287692)
--- trunk/Source/WebCore/loader/WorkerThreadableLoader.h 2022-01-06 17:15:26 UTC (rev 287691)
+++ trunk/Source/WebCore/loader/WorkerThreadableLoader.h 2022-01-06 17:15:43 UTC (rev 287692)
@@ -132,7 +132,6 @@
void computeIsDone() final;
-Ref m_WorkerOrWorkletGlobalScope;
Ref m_workerClientWrapper;
MainThreadBridge& m_bridge;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287691] branches/safari-613.1.12.1-branch
Title: [287691] branches/safari-613.1.12.1-branch
Revision 287691
Author repst...@apple.com
Date 2022-01-06 09:15:26 -0800 (Thu, 06 Jan 2022)
Log Message
Cherry-pick r287417. rdar://problem/86841302
REGRESSION(Containment) nullptr deref in RenderBox::styleDidChange
https://bugs.webkit.org/show_bug.cgi?id=234647
Reviewed by Simon Fraser.
Source/WebCore:
Do not try to propagate the writing mode to the RenderView unless we are attached to one.
Test: fast/dynamic/document-elment-renderer-null-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
* fast/dynamic/document-elment-renderer-null-crash-expected.txt: Added.
* fast/dynamic/document-elment-renderer-null-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.1.12.1-branch/LayoutTests/ChangeLog
branches/safari-613.1.12.1-branch/Source/WebCore/ChangeLog
branches/safari-613.1.12.1-branch/Source/WebCore/rendering/RenderBox.cpp
Added Paths
branches/safari-613.1.12.1-branch/LayoutTests/fast/dynamic/document-elment-renderer-null-crash-expected.txt
branches/safari-613.1.12.1-branch/LayoutTests/fast/dynamic/document-elment-renderer-null-crash.html
Diff
Modified: branches/safari-613.1.12.1-branch/LayoutTests/ChangeLog (287690 => 287691)
--- branches/safari-613.1.12.1-branch/LayoutTests/ChangeLog 2022-01-06 17:06:39 UTC (rev 287690)
+++ branches/safari-613.1.12.1-branch/LayoutTests/ChangeLog 2022-01-06 17:15:26 UTC (rev 287691)
@@ -1,3 +1,41 @@
+2022-01-06 Russell Epstein
+
+Cherry-pick r287417. rdar://problem/86841302
+
+REGRESSION(Containment) nullptr deref in RenderBox::styleDidChange
+https://bugs.webkit.org/show_bug.cgi?id=234647
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+Do not try to propagate the writing mode to the RenderView unless we are attached to one.
+
+Test: fast/dynamic/document-elment-renderer-null-crash.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::styleDidChange):
+
+LayoutTests:
+
+* fast/dynamic/document-elment-renderer-null-crash-expected.txt: Added.
+* fast/dynamic/document-elment-renderer-null-crash.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-12-23 Alan Bujtas
+
+REGRESSION(Containment) nullptr deref in RenderBox::styleDidChange
+https://bugs.webkit.org/show_bug.cgi?id=234647
+
+
+Reviewed by Simon Fraser.
+
+* fast/dynamic/document-elment-renderer-null-crash-expected.txt: Added.
+* fast/dynamic/document-elment-renderer-null-crash.html: Added.
+
2022-01-04 Alan Coon
Cherry-pick r287574. rdar://problem/86855896
Added: branches/safari-613.1.12.1-branch/LayoutTests/fast/dynamic/document-elment-renderer-null-crash-expected.txt (0 => 287691)
--- branches/safari-613.1.12.1-branch/LayoutTests/fast/dynamic/document-elment-renderer-null-crash-expected.txt (rev 0)
+++ branches/safari-613.1.12.1-branch/LayoutTests/fast/dynamic/document-elment-renderer-null-crash-expected.txt 2022-01-06 17:15:26 UTC (rev 287691)
@@ -0,0 +1 @@
+PASS if no crash
Added: branches/safari-613.1.12.1-branch/LayoutTests/fast/dynamic/document-elment-renderer-null-crash.html (0 => 287691)
--- branches/safari-613.1.12.1-branch/LayoutTests/fast/dynamic/document-elment-renderer-null-crash.html (rev 0)
+++ branches/safari-613.1.12.1-branch/LayoutTests/fast/dynamic/document-elment-renderer-null-crash.html 2022-01-06 17:15:26 UTC (rev 287691)
@@ -0,0 +1,12 @@
+PASS if no crash
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+var iframe = document.createElement("iframe");
+insertionPoint.appendChild(iframe);
+
+var iframeDocument = iframe.contentWindow.document;
+iframeDocument.open();
+iframeDocument.appendChild(document.createElement("script"));
+iframeDocument.close();
+
Modified: branches/safari-613.1.12.1-branch/Source/WebCore/ChangeLog (287690 => 287691)
--- branches/safari-613.1.12.1-branch/Source/WebCore/ChangeLog 2022-01-06 17:06:39 UTC (rev 287690)
+++ branches/safari-613.1.12.1-branch/Source/WebCore/ChangeLog 2022-01-06 17:15:26 UTC (rev 287691)
@@ -1,3 +1,45 @@
+2022-01-06 Russell Epstein
+
+Cherry-pick r287417. rdar://problem/86841302
+
+REGRESSION(Containment) nullptr deref in RenderBox::styleDidChange
+https://bugs.webkit.org/show_bug.cgi?id=234647
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+Do not try to propagate the writing mode to the RenderView unless we are attached to one.
+
+Test: fast/dynamic/document-elment-renderer-null-crash.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::styleDidChange):
+
+Layo
[webkit-changes] [287690] branches/safari-613.1.12.1-branch/Source
Title: [287690] branches/safari-613.1.12.1-branch/Source Revision 287690 Author repst...@apple.com Date 2022-01-06 09:06:39 -0800 (Thu, 06 Jan 2022) Log Message Versioning. WebKit-7613.1.12.1.3 Modified Paths branches/safari-613.1.12.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.12.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.12.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.12.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.12.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.12.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.1.12.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.12.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.12.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.12.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (287689 => 287690) --- branches/safari-613.1.12.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-01-06 17:00:10 UTC (rev 287689) +++ branches/safari-613.1.12.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-01-06 17:06:39 UTC (rev 287690) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 12; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.12.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (287689 => 287690) --- branches/safari-613.1.12.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-01-06 17:00:10 UTC (rev 287689) +++ branches/safari-613.1.12.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-01-06 17:06:39 UTC (rev 287690) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 12; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.12.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (287689 => 287690) --- branches/safari-613.1.12.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-01-06 17:00:10 UTC (rev 287689) +++ branches/safari-613.1.12.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-01-06 17:06:39 UTC (rev 287690) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 12; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.12.1-branch/Source/WebCore/Configurations/Version.xcconfig (287689 => 287690) --- branches/safari-613.1.12.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-01-06 17:00:10 UTC (rev 287689) +++ branches/safari-613.1.12.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-01-06 17:06:39 UTC (rev 287690) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 12; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.12.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (287689 => 287690) --- branches/safari-613.1.12.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-01-06 17:00:10 UTC (rev 287689) +++ branches/safari-613.1.12.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-01-06 17:06:39 UTC (rev 287690) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 12; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.12.1-branch/Source/WebGPU/Configurations/Version.xcconfig (287689 => 287690) --- branches/safari-613.1.12.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-01-06 17:00:10 UTC (rev 287689) +++ branches/safari-613.1.12.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-01-06 17:06:39 UTC (rev 287690) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 12; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION =
[webkit-changes] [287689] trunk/Source/WebCore
Title: [287689] trunk/Source/WebCore Revision 287689 Author cdu...@apple.com Date 2022-01-06 09:00:10 -0800 (Thu, 06 Jan 2022) Log Message Potential high CPU usage on macrumors.com https://bugs.webkit.org/show_bug.cgi?id=234867 Reviewed by Geoffrey Garen. The issue would occur when a suspended EventLoopTaskGroup had pending tasks and was getting marked as ready to stop. The "ready to stop" concept was introduced in r269227 so that we would only stop event loop groups for a given origin once all groups in that origin are ready to stop. This was so that promises from detached iframes could resolve when scripted from another frame. The bug here was that an EventLoopTaskGroup could move from "Suspended" state (a mode in which its tasks are not executed) and into a "ReadyToStop" state (a mode in which its tasks are executed until all groups in its origin are ready to stop). As a result, we would take a EventLoopGroup out of suspended state unintentionally. This was causing a rescheduling loop in DeferredPromise::callFunction() which would cause high CPU usage. Because activeDOMObjectsAreSuspended() returns true, callFunction() would not call the JS function and would instead schedule a task on the event loop to do so. The exception here is that the event loop group is suspended too and thus the scheduled task will not run until the ActiveDOMObjects (and the event loop group) get resumed (i.e. page is restored from the back/forward cache). However, due to the bug above, the event loop group was unexpected NOT suspended and would run the scheduled task on the next runloop iteration and callFunction() would just keep rescheduling itself in a loop. To address the issue, we now cancel all tasks in the group and stop it permanently when its state moves from "suspended" to "ready to stop". The state moves from "suspended" to "ready to stop" when a CachedPage gets destroyed. As this point, the tasks in this group will never run since we're suspended and we'll never get out of suspension (ready to stop). * bindings/js/JSDOMPromiseDeferred.cpp: (WebCore::DeferredPromise::callFunction): * dom/EventLoop.cpp: (WebCore::EventLoop::resumeGroup): (WebCore::EventLoop::run): (WebCore::EventLoop::clearAllTasks): * dom/EventLoop.h: (WebCore::EventLoopTaskGroup::markAsReadyToStop): (WebCore::EventLoopTaskGroup::isStoppedPermanently const): (WebCore::EventLoopTaskGroup::isSuspended const): (WebCore::EventLoopTaskGroup::isStoppedPermanently): Deleted. (WebCore::EventLoopTaskGroup::isSuspended): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp trunk/Source/WebCore/dom/EventLoop.cpp trunk/Source/WebCore/dom/EventLoop.h Diff Modified: trunk/Source/WebCore/ChangeLog (287688 => 287689) --- trunk/Source/WebCore/ChangeLog 2022-01-06 16:40:39 UTC (rev 287688) +++ trunk/Source/WebCore/ChangeLog 2022-01-06 17:00:10 UTC (rev 287689) @@ -1,3 +1,45 @@ +2022-01-06 Chris Dumez + +Potential high CPU usage on macrumors.com +https://bugs.webkit.org/show_bug.cgi?id=234867 + + +Reviewed by Geoffrey Garen. + +The issue would occur when a suspended EventLoopTaskGroup had pending tasks and was getting marked +as ready to stop. The "ready to stop" concept was introduced in r269227 so that we would only stop +event loop groups for a given origin once all groups in that origin are ready to stop. This was so +that promises from detached iframes could resolve when scripted from another frame. The bug here +was that an EventLoopTaskGroup could move from "Suspended" state (a mode in which its tasks are not +executed) and into a "ReadyToStop" state (a mode in which its tasks are executed until all groups +in its origin are ready to stop). As a result, we would take a EventLoopGroup out of suspended +state unintentionally. This was causing a rescheduling loop in DeferredPromise::callFunction() +which would cause high CPU usage. Because activeDOMObjectsAreSuspended() returns true, +callFunction() would not call the JS function and would instead schedule a task on the event loop +to do so. The exception here is that the event loop group is suspended too and thus the scheduled +task will not run until the ActiveDOMObjects (and the event loop group) get resumed (i.e. page is +restored from the back/forward cache). However, due to the bug above, the event loop group was +unexpected NOT suspended and would run the scheduled task on the next runloop iteration and +callFunction() would just keep rescheduling itself in a loop. + +To address the issue, we now cancel all tasks in the group and stop it permanently when its state +moves from "suspended" to "ready to stop". The state moves from "suspended" to "ready to stop" +when a CachedPage gets destroyed. As this point, the tasks in this group will never run since
[webkit-changes] [287688] trunk/LayoutTests/imported/w3c
Title: [287688] trunk/LayoutTests/imported/w3c Revision 287688 Author mrobin...@webkit.org Date 2022-01-06 08:40:39 -0800 (Thu, 06 Jan 2022) Log Message REGRESSION (r287323): [iOS] 9 imported/w3c/web-platform-tests/css/css-transforms tests consistently failing https://bugs.webkit.org/show_bug.cgi?id=234908 Reviewed by Simon Fraser. Adjust WPT trasnform reference test fuzziness for iOS. In some cases the reference matches more closely and in other cases slightly less closely. * web-platform-tests/css/css-transforms/2d-rotate-001.html: * web-platform-tests/css/css-transforms/css-skew-002.html: * web-platform-tests/css/css-transforms/rotate_45deg.html: * web-platform-tests/css/css-transforms/rotate_x_45deg.html: * web-platform-tests/css/css-transforms/rotate_y_45deg.html: * web-platform-tests/css/css-transforms/skew-test1.html: * web-platform-tests/css/css-transforms/transform-percent-008.html: * web-platform-tests/css/css-transforms/ttwf-transform-skewx-001.html: * web-platform-tests/css/css-transforms/ttwf-transform-skewy-001.html: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/2d-rotate-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-skew-002.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/rotate_45deg.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/rotate_x_45deg.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/rotate_y_45deg.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/skew-test1.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-percent-008.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/ttwf-transform-skewx-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/ttwf-transform-skewy-001.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287687 => 287688) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-06 16:35:03 UTC (rev 287687) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-06 16:40:39 UTC (rev 287688) @@ -1,3 +1,24 @@ +2022-01-06 Martin Robinson + +REGRESSION (r287323): [iOS] 9 imported/w3c/web-platform-tests/css/css-transforms tests consistently failing +https://bugs.webkit.org/show_bug.cgi?id=234908 + + +Reviewed by Simon Fraser. + +Adjust WPT trasnform reference test fuzziness for iOS. In some cases the reference +matches more closely and in other cases slightly less closely. + +* web-platform-tests/css/css-transforms/2d-rotate-001.html: +* web-platform-tests/css/css-transforms/css-skew-002.html: +* web-platform-tests/css/css-transforms/rotate_45deg.html: +* web-platform-tests/css/css-transforms/rotate_x_45deg.html: +* web-platform-tests/css/css-transforms/rotate_y_45deg.html: +* web-platform-tests/css/css-transforms/skew-test1.html: +* web-platform-tests/css/css-transforms/transform-percent-008.html: +* web-platform-tests/css/css-transforms/ttwf-transform-skewx-001.html: +* web-platform-tests/css/css-transforms/ttwf-transform-skewy-001.html: + 2022-01-05 Antoine Quint computed style for transition longhand properties is wrong Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/2d-rotate-001.html (287687 => 287688) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/2d-rotate-001.html 2022-01-06 16:35:03 UTC (rev 287687) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/2d-rotate-001.html 2022-01-06 16:40:39 UTC (rev 287688) @@ -5,7 +5,7 @@ - +
[webkit-changes] [287687] trunk/Source/WebCore
Title: [287687] trunk/Source/WebCore
Revision 287687
Author j...@apple.com
Date 2022-01-06 08:35:03 -0800 (Thu, 06 Jan 2022)
Log Message
Content Filtering should be using SharedBuffer instead of copying its data
https://bugs.webkit.org/show_bug.cgi?id=234713
rdar://problem/86947433
Reviewed by Youenn Fablet.
We can directly construct the NSData used by ParentalControlsContentFilter
and NetworkExtensionContentFilter from the SharedBuffer.
No change in observable behaviour.
* loader/ContentFilter.cpp:
(WebCore::ContentFilter::continueAfterDataReceived):
* loader/ContentFilter.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::dataReceived):
* platform/PlatformContentFilter.h:
* platform/cocoa/NetworkExtensionContentFilter.h:
* platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::addData):
* platform/cocoa/ParentalControlsContentFilter.h:
* platform/cocoa/ParentalControlsContentFilter.mm:
(WebCore::ParentalControlsContentFilter::addData):
* testing/MockContentFilter.cpp:
(WebCore::MockContentFilter::addData):
* testing/MockContentFilter.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ContentFilter.cpp
trunk/Source/WebCore/loader/ContentFilter.h
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/platform/PlatformContentFilter.h
trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.h
trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm
trunk/Source/WebCore/platform/cocoa/ParentalControlsContentFilter.h
trunk/Source/WebCore/platform/cocoa/ParentalControlsContentFilter.mm
trunk/Source/WebCore/testing/MockContentFilter.cpp
trunk/Source/WebCore/testing/MockContentFilter.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (287686 => 287687)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 16:23:45 UTC (rev 287686)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 16:35:03 UTC (rev 287687)
@@ -1,5 +1,34 @@
2022-01-06 Jean-Yves Avenard
+Content Filtering should be using SharedBuffer instead of copying its data
+https://bugs.webkit.org/show_bug.cgi?id=234713
+rdar://problem/86947433
+
+Reviewed by Youenn Fablet.
+
+We can directly construct the NSData used by ParentalControlsContentFilter
+and NetworkExtensionContentFilter from the SharedBuffer.
+
+No change in observable behaviour.
+
+* loader/ContentFilter.cpp:
+(WebCore::ContentFilter::continueAfterDataReceived):
+* loader/ContentFilter.h:
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::dataReceived):
+* platform/PlatformContentFilter.h:
+* platform/cocoa/NetworkExtensionContentFilter.h:
+* platform/cocoa/NetworkExtensionContentFilter.mm:
+(WebCore::NetworkExtensionContentFilter::addData):
+* platform/cocoa/ParentalControlsContentFilter.h:
+* platform/cocoa/ParentalControlsContentFilter.mm:
+(WebCore::ParentalControlsContentFilter::addData):
+* testing/MockContentFilter.cpp:
+(WebCore::MockContentFilter::addData):
+* testing/MockContentFilter.h:
+
+2022-01-06 Jean-Yves Avenard
+
Have CachedRawResourceClient and related networking actors use SharedBuffer.
https://bugs.webkit.org/show_bug.cgi?id=232424
rdar://84744687
Modified: trunk/Source/WebCore/loader/ContentFilter.cpp (287686 => 287687)
--- trunk/Source/WebCore/loader/ContentFilter.cpp 2022-01-06 16:23:45 UTC (rev 287686)
+++ trunk/Source/WebCore/loader/ContentFilter.cpp 2022-01-06 16:35:03 UTC (rev 287687)
@@ -145,14 +145,14 @@
return m_state != State::Blocked;
}
-bool ContentFilter::continueAfterDataReceived(const uint8_t* data, int length)
+bool ContentFilter::continueAfterDataReceived(const SharedBuffer& data)
{
Ref protectedClient { m_client };
if (m_state == State::Filtering) {
-LOG(ContentFiltering, "ContentFilter received %d bytes of data from <%s>.\n", length, m_mainResource->url().string().ascii().data());
-forEachContentFilterUntilBlocked([data, length](PlatformContentFilter& contentFilter) {
-contentFilter.addData(data, length);
+LOG(ContentFiltering, "ContentFilter received %zu bytes of data from <%s>.\n", data.size(), m_mainResource->url().string().ascii().data());
+forEachContentFilterUntilBlocked([data = "" { data }](auto& contentFilter) {
+contentFilter.addData(data);
});
if (m_state == State::Allowed)
Modified: trunk/Source/WebCore/loader/ContentFilter.h (287686 => 287687)
--- trunk/Source/WebCore/loader/ContentFilter.h 2022-01-06 16:23:45 UTC (rev 287686)
+++ trunk/Source/WebCore/loader/ContentFilter.h 2022-01-06 16:35:03 UTC (rev 287687)
@@ -60,7 +60,7 @@
bool continueAfterWillSendRequest(ResourceRequest&, const ResourceResponse&);
bool continueAfterResponseReceived(const ResourceResponse&);
-bool continueAfterDataReceived(const uint
[webkit-changes] [287686] trunk/Tools
Title: [287686] trunk/Tools Revision 287686 Author jbed...@apple.com Date 2022-01-06 08:23:45 -0800 (Thu, 06 Jan 2022) Log Message [webkitbugspy] Initial library commit https://bugs.webkit.org/show_bug.cgi?id=234400 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/webkitbugspy/MANIFEST.in: Added. * Tools/Scripts/libraries/webkitbugspy/README.md: Added. * Tools/Scripts/libraries/webkitbugspy/setup.py: Added. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Added. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py: Added. (Tracker): Bugzilla implementation of generic isssue tracker. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py: Added. (Tracker): GitHub implementation of generic isssue tracker. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py: Added. (Issue): Dynamically fetched generic Issue object referencing parent Tracker. (Issue.Comment): Issue comment including author and timestamp. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/__init__.py: Added. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/base.py: Added. (Base): Base class for mocking http based issue trackers. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py: Added. (Bugzilla): Partial mock of Bugzilla webserver. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/data.py: Added. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py: Added. (GitHub): Partial mock of GitHub webserver. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/__init__.py: Added. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py: Added. (TestBugzilla): * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py: Added. (TestGitHub): * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/user_unittest.py: Added. (TestUser): * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py: Added. (Tracker): Generic base of all issue trackers. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/user.py: Added. (User): User object tied to specific tracker. (User.Encoder): User JSON encoder. (User.Mapping): Mapping of user alias to User object. * Tools/Scripts/webkitpy/test/main.py: (main): Add webkitbugspy to subdirectories to be tested. Canonical link: https://commits.webkit.org/245782@main Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/test/main.py Added Paths trunk/Tools/Scripts/libraries/webkitbugspy/ trunk/Tools/Scripts/libraries/webkitbugspy/MANIFEST.in trunk/Tools/Scripts/libraries/webkitbugspy/README.md trunk/Tools/Scripts/libraries/webkitbugspy/setup.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/__init__.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/base.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/data.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/__init__.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/user_unittest.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/user.py Diff Modified: trunk/Tools/ChangeLog (287685 => 287686) --- trunk/Tools/ChangeLog 2022-01-06 15:57:49 UTC (rev 287685) +++ trunk/Tools/ChangeLog 2022-01-06 16:23:45 UTC (rev 287686) @@ -1,3 +1,46 @@ +2021-12-16 Jonathan Bedard + +[webkitbugspy] Initial library commit +https://bugs.webkit.org/show_bug.cgi?id=234400 + + +Reviewed by Dewei Zhu. + +* Scripts/libraries/webkitbugspy/MANIFEST.in: Added. +* Scripts/libraries/webkitbugspy/README.md: Added. +* Scripts/libraries/webkitbugspy/setup.py: Added. +* Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Added. +* Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py: Added. +(Tracker): Bugzilla implementation of generic isssue tracker. +* Scripts/libraries/webkitbugspy/webkitbugspy/github.py: Added. +(Tracker): GitHub implementation of generic isssue tracker. +* Scripts/libraries/webkitbugspy/webkitbugspy/issue.py: Added. +(Issue): Dynamically fetched generic Issue object referencing parent Tracker. +
[webkit-changes] [287685] trunk/Source/bmalloc
Title: [287685] trunk/Source/bmalloc
Revision 287685
Author stephan.sz...@sony.com
Date 2022-01-06 07:57:49 -0800 (Thu, 06 Jan 2022)
Log Message
[PlayStation] Fix non-ninja PlayStation build after r285853
https://bugs.webkit.org/show_bug.cgi?id=234922
Unreviewed build fix.
* PlatformPlayStation.cmake: Added. For MSVS playstatino builds, compile as C++ to
avoid issues with the standard set being invalid.
Modified Paths
trunk/Source/bmalloc/ChangeLog
Added Paths
trunk/Source/bmalloc/PlatformPlayStation.cmake
Diff
Modified: trunk/Source/bmalloc/ChangeLog (287684 => 287685)
--- trunk/Source/bmalloc/ChangeLog 2022-01-06 15:31:46 UTC (rev 287684)
+++ trunk/Source/bmalloc/ChangeLog 2022-01-06 15:57:49 UTC (rev 287685)
@@ -1,3 +1,13 @@
+2022-01-06 Stephan Szabo
+
+[PlayStation] Fix non-ninja PlayStation build after r285853
+https://bugs.webkit.org/show_bug.cgi?id=234922
+
+Unreviewed build fix.
+
+* PlatformPlayStation.cmake: Added. For MSVS playstatino builds, compile as C++ to
+avoid issues with the standard set being invalid.
+
2022-01-04 Philippe Normand
[PAS] constant-logical-operand clang warnings
Added: trunk/Source/bmalloc/PlatformPlayStation.cmake (0 => 287685)
--- trunk/Source/bmalloc/PlatformPlayStation.cmake (rev 0)
+++ trunk/Source/bmalloc/PlatformPlayStation.cmake 2022-01-06 15:57:49 UTC (rev 287685)
@@ -0,0 +1,8 @@
+if (${CMAKE_GENERATOR} MATCHES "Visual Studio")
+# With the VisualStudio generator, the compiler complains about -std=c++* for C sources.
+set_source_files_properties(
+${bmalloc_SOURCES}
+PROPERTIES LANGUAGE CXX
+)
+endif ()
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287683] trunk
Title: [287683] trunk
Revision 287683
Author za...@apple.com
Date 2022-01-06 06:33:25 -0800 (Thu, 06 Jan 2022)
Log Message
Ensure that the top layer is always anchored to the RenderView
https://bugs.webkit.org/show_bug.cgi?id=231292
Reviewed by Simon Fraser.
Source/WebCore:
A fixed positioned block level box is not necessarily anchored to the RenderView (see canContainFixedPositionObjects).
This patch ensures that we skip those ancestors and return the RenderView as the containing block for the top layer content.
https://fullscreen.spec.whatwg.org/#new-stacking-layer
"If the top layer position property computes to fixed, its containing block is the viewport, and the initial containing block otherwise."
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock const):
(WebCore::containerForElement):
LayoutTests:
* TestExpectations: offsetFromAncestorContainer expects no transformed renderer in-between the
dialog and the RenderView's layer. It will go away with the layer re-parenting work.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (287682 => 287683)
--- trunk/LayoutTests/ChangeLog 2022-01-06 13:41:00 UTC (rev 287682)
+++ trunk/LayoutTests/ChangeLog 2022-01-06 14:33:25 UTC (rev 287683)
@@ -1,3 +1,14 @@
+2022-01-06 Alan Bujtas
+
+Ensure that the top layer is always anchored to the RenderView
+https://bugs.webkit.org/show_bug.cgi?id=231292
+
+
+Reviewed by Simon Fraser.
+
+* TestExpectations: offsetFromAncestorContainer expects no transformed renderer in-between the
+dialog and the RenderView's layer. It will go away with the layer re-parenting work.
+
2022-01-05 Antoine Quint
computed style for transition longhand properties is wrong
Modified: trunk/LayoutTests/TestExpectations (287682 => 287683)
--- trunk/LayoutTests/TestExpectations 2022-01-06 13:41:00 UTC (rev 287682)
+++ trunk/LayoutTests/TestExpectations 2022-01-06 14:33:25 UTC (rev 287683)
@@ -2359,7 +2359,8 @@
webkit.org/b/231292 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-stacking.html [ ImageOnlyFailure ]
webkit.org/b/231292 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-clip.html [ ImageOnlyFailure ]
webkit.org/b/231292 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-scroll.html [ ImageOnlyFailure ]
-webkit.org/b/231292 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform.html [ ImageOnlyFailure ]
+# Needs layer re-parenting
+webkit.org/b/231292 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-transform.html [ Skip ]
# Assertion failure in MessagePort::contextDestroyed, usually attributed to later tests
webkit.org/b/94458 http/tests/security/MessagePort/event-listener-context.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (287682 => 287683)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 13:41:00 UTC (rev 287682)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 14:33:25 UTC (rev 287683)
@@ -1,3 +1,21 @@
+2022-01-06 Alan Bujtas
+
+Ensure that the top layer is always anchored to the RenderView
+https://bugs.webkit.org/show_bug.cgi?id=231292
+
+
+Reviewed by Simon Fraser.
+
+A fixed positioned block level box is not necessarily anchored to the RenderView (see canContainFixedPositionObjects).
+This patch ensures that we skip those ancestors and return the RenderView as the containing block for the top layer content.
+
+https://fullscreen.spec.whatwg.org/#new-stacking-layer
+"If the top layer position property computes to fixed, its containing block is the viewport, and the initial containing block otherwise."
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::containingBlock const):
+(WebCore::containerForElement):
+
2022-01-06 Jean-Yves Avenard
length argument passed to didReceiveData can never be negative.
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (287682 => 287683)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2022-01-06 13:41:00 UTC (rev 287682)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2022-01-06 14:33:25 UTC (rev 287683)
@@ -658,8 +658,9 @@
RenderBlock* RenderObject::containingBlock() const
{
-auto containingBlockForRenderer = [](const RenderElement& renderer)
-{
+auto containingBlockForRenderer = [](const auto& renderer) -> RenderBlock* {
+if (isInTopLayerOrBackdrop(renderer.style(), renderer.element()))
+return &renderer.view();
if (renderer.isAbsolutelyPositioned())
return ren
[webkit-changes] [287682] trunk/Source/WebInspectorUI
Title: [287682] trunk/Source/WebInspectorUI
Revision 287682
Author rcali...@apple.com
Date 2022-01-06 05:41:00 -0800 (Thu, 06 Jan 2022)
Log Message
Web Inspector: `shape-outside` description doesn't make sense
https://bugs.webkit.org/show_bug.cgi?id=234675
Reviewed by Devin Rousso.
Add the ability to overwrite CSS documentation obtained from the upstream data source
with information sourced from a local JSON file.
* Scripts/update-inspector-css-documentation:
* UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json: Added.
Local JSON file with fields to overwrite specific data.
* UserInterface/External/CSSDocumentation/CSSDocumentation.js:
Update description for `shape-outside` CSS property.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Scripts/update-inspector-css-documentation
trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js
Added Paths
trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (287681 => 287682)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-01-06 13:03:26 UTC (rev 287681)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-01-06 13:41:00 UTC (rev 287682)
@@ -1,3 +1,21 @@
+2022-01-06 Razvan Caliman
+
+Web Inspector: `shape-outside` description doesn't make sense
+https://bugs.webkit.org/show_bug.cgi?id=234675
+
+
+Reviewed by Devin Rousso.
+
+Add the ability to overwrite CSS documentation obtained from the upstream data source
+with information sourced from a local JSON file.
+
+* Scripts/update-inspector-css-documentation:
+* UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json: Added.
+Local JSON file with fields to overwrite specific data.
+
+* UserInterface/External/CSSDocumentation/CSSDocumentation.js:
+Update description for `shape-outside` CSS property.
+
2022-01-05 Devin Rousso
Web Inspector: Layers: add reference page button
Modified: trunk/Source/WebInspectorUI/Scripts/update-inspector-css-documentation (287681 => 287682)
--- trunk/Source/WebInspectorUI/Scripts/update-inspector-css-documentation 2022-01-06 13:03:26 UTC (rev 287681)
+++ trunk/Source/WebInspectorUI/Scripts/update-inspector-css-documentation 2022-01-06 13:41:00 UTC (rev 287682)
@@ -25,8 +25,11 @@
# This script generates the file with CSS documentation shown in Web Inspector:
# Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js
#
-# The data comes from the VSCode custom data repository:
+# The upstream data comes from the VSCode custom data repository:
# https://github.com/microsoft/vscode-custom-data/blob/main/web-data/data/browsers.css-data.json
+#
+# To overwrite descriptions and other CSS documentation fields obtained from the upstream data, update the file:
+# Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json
import json
import urllib.request
@@ -37,6 +40,7 @@
ROOT_DIR = (Path(__file__).parent / ".." / ".." / "..").resolve()
OUTPUT_DIR = "Source/WebInspectorUI/UserInterface/External/CSSDocumentation"
OUTPUT_FILENAME = "CSSDocumentation.js"
+CSS_DATA_OVERRIDES_JSON_PATH = Path(ROOT_DIR, OUTPUT_DIR, "CSSDocumentation-overrides.json").resolve()
try:
print(f"Downloading: {VSCODE_CSS_DATA_JSON_URL}")
@@ -52,14 +56,22 @@
print("Parsing failed\n{0}".format(err))
exit()
+try:
+print("Parsing local JSON with overrides")
+overrides = json.load(open(CSS_DATA_OVERRIDES_JSON_PATH, "r"))
+except json.JSONDecodeError as err:
+print("Parsing failed\n{0}".format(err))
+exit()
+
print("Extracting CSS property data")
properties = {}
for prop in data["properties"]:
name = prop.get("name")
-description = prop.get("description")
-syntax = prop.get("syntax")
-references = prop.get("references")
+prop_override = overrides.get(name, {})
+description = prop_override.get("description") or prop.get("description")
+syntax = prop_override.get("syntax") or prop.get("syntax")
+references = prop_override.get("references") or prop.get("references")
url = ""
if (references):
Added: trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json (0 => 287682)
--- trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json 2022-01-06 13:41:00 UTC (rev 287682)
@@ -0,0 +1,5 @@
+{
+"shape-outside": {
+"description": "Defines a shape around which adjacent inline content should wrap."
+}
+}
Modified: trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js (287681 => 287682)
--- trunk/Source/We
[webkit-changes] [287681] trunk/Source/WebCore
Title: [287681] trunk/Source/WebCore
Revision 287681
Author j...@apple.com
Date 2022-01-06 05:03:26 -0800 (Thu, 06 Jan 2022)
Log Message
length argument passed to didReceiveData can never be negative.
https://bugs.webkit.org/show_bug.cgi?id=234916
rdar://problem/87190340
Reviewed by Youenn Fablet.
Signed int argument will be removed in bug 232424.
No change in observable behaviour. Covered by existing tests.
* inspector/agents/InspectorNetworkAgent.cpp:
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didReceiveData):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didReceiveData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
trunk/Source/WebCore/workers/WorkerScriptLoader.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (287680 => 287681)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 11:41:53 UTC (rev 287680)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 13:03:26 UTC (rev 287681)
@@ -1,3 +1,21 @@
+2022-01-06 Jean-Yves Avenard
+
+length argument passed to didReceiveData can never be negative.
+https://bugs.webkit.org/show_bug.cgi?id=234916
+rdar://problem/87190340
+
+Reviewed by Youenn Fablet.
+
+Signed int argument will be removed in bug 232424.
+
+No change in observable behaviour. Covered by existing tests.
+
+* inspector/agents/InspectorNetworkAgent.cpp:
+* workers/WorkerScriptLoader.cpp:
+(WebCore::WorkerScriptLoader::didReceiveData):
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::didReceiveData):
+
2022-01-06 Youenn Fablet
WorkerMessagePortChannelProvider::takeAllMessagesForPort should guarantee execution of the takeMessagePort callback
Modified: trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp (287680 => 287681)
--- trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp 2022-01-06 11:41:53 UTC (rev 287680)
+++ trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp 2022-01-06 13:03:26 UTC (rev 287681)
@@ -129,9 +129,6 @@
if (!dataLength)
return;
-if (dataLength == -1)
-dataLength = strlen(reinterpret_cast(data));
-
m_responseText.append(m_decoder->decode(data, dataLength));
}
Modified: trunk/Source/WebCore/workers/WorkerScriptLoader.cpp (287680 => 287681)
--- trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2022-01-06 11:41:53 UTC (rev 287680)
+++ trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2022-01-06 13:03:26 UTC (rev 287681)
@@ -215,9 +215,6 @@
if (!len)
return;
-if (len == -1)
-len = strlen(reinterpret_cast(data));
-
m_script.append(m_decoder->decode(data, len));
}
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (287680 => 287681)
--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2022-01-06 11:41:53 UTC (rev 287680)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2022-01-06 13:03:26 UTC (rev 287681)
@@ -1055,9 +1055,6 @@
if (!len)
return;
-if (len == -1)
-len = strlen(reinterpret_cast(data));
-
if (useDecoder)
m_responseBuilder.append(m_decoder->decode(data, len));
else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287680] branches/safari-612-branch
Title: [287680] branches/safari-612-branch
Revision 287680
Author repst...@apple.com
Date 2022-01-06 03:41:53 -0800 (Thu, 06 Jan 2022)
Log Message
Apply patch. rdar://problem/87125345
Modified Paths
branches/safari-612-branch/LayoutTests/ChangeLog
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/loader/FrameLoader.cpp
branches/safari-612-branch/Source/WebCore/loader/FrameLoader.h
branches/safari-612-branch/Source/WebCore/testing/ServiceWorkerInternals.cpp
branches/safari-612-branch/Source/WebCore/testing/ServiceWorkerInternals.h
branches/safari-612-branch/Source/WebCore/testing/ServiceWorkerInternals.idl
Added Paths
branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site-worker.js
branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site.https-expected.txt
branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site.https.html
branches/safari-612-branch/LayoutTests/http/wpt/service-workers/resources/navigation-iframe-site-frame.html
Diff
Modified: branches/safari-612-branch/LayoutTests/ChangeLog (287679 => 287680)
--- branches/safari-612-branch/LayoutTests/ChangeLog 2022-01-06 10:50:00 UTC (rev 287679)
+++ branches/safari-612-branch/LayoutTests/ChangeLog 2022-01-06 11:41:53 UTC (rev 287680)
@@ -1,3 +1,18 @@
+2022-01-06 Russell Epstein
+
+Apply patch. rdar://problem/87125345
+
+2022-01-06 Youenn Fablet
+
+Use requester when calling updateRequestAndAddExtraFields
+https://bugs.webkit.org/show_bug.cgi?id=234507
+
+
+* http/wpt/service-workers/navigation-iframe-site-worker.js: Added.
+* http/wpt/service-workers/navigation-iframe-site.https-expected.txt: Added.
+* http/wpt/service-workers/navigation-iframe-site.https.html: Added.
+* http/wpt/service-workers/resources/navigation-iframe-site-frame.html: Added.
+
2022-01-05 Russell Epstein
Cherry-pick r287593. rdar://problem/86910670
Added: branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site-worker.js (0 => 287680)
--- branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site-worker.js (rev 0)
+++ branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site-worker.js 2022-01-06 11:41:53 UTC (rev 287680)
@@ -0,0 +1,11 @@
+addEventListener("message", (e) => {
+self.port = e.data.port;
+});
+
+addEventListener("fetch", (e) => {
+if (self.internals) {
+self.port.postMessage(self.internals.fetchEventIsSameSite(e) ? "FAIL" : "PASS");
+return;
+}
+self.port.postMessage("PASS");
+});
Added: branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site.https-expected.txt (0 => 287680)
--- branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site.https-expected.txt (rev 0)
+++ branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site.https-expected.txt 2022-01-06 11:41:53 UTC (rev 287680)
@@ -0,0 +1,5 @@
+
+PASS Setup worker
+PASS Validate worker gets right request after navigation
+PASS Validate worker gets right request after post navigation
+
Added: branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site.https.html (0 => 287680)
--- branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site.https.html (rev 0)
+++ branches/safari-612-branch/LayoutTests/http/wpt/service-workers/navigation-iframe-site.https.html 2022-01-06 11:41:53 UTC (rev 287680)
@@ -0,0 +1,68 @@
+
+
+Service Worker Fetch Event
+
+
+