date:20220203

[webkit-changes] [289106] trunk/Source/WebCore

2022-02-03 Thread clord

Title: [289106] trunk/Source/WebCore








Revision 289106
Author cl...@igalia.com
Date 2022-02-03 23:16:39 -0800 (Thu, 03 Feb 2022)


Log Message
[GTK][WPE] Use dmabuf when possible to transfer ANGLE rendering to the compositor
https://bugs.webkit.org/show_bug.cgi?id=235946

Reviewed by Žan Doberšek.

Use dmabuf when available to transfer ANGLE WebGL rendering contents
to the compositor.

No new tests, no change in behaviour.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* SourcesGTK.txt:
* SourcesWPE.txt:
* platform/TextureMapper.cmake:
* platform/graphics/OpenGLShims.cpp:
(WebCore::initializeOpenGLShims):
* platform/graphics/OpenGLShims.h:
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::prepareTextureImpl):
* platform/graphics/angle/GraphicsContextGLANGLE.h:
* platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::createImage const):
(WebCore::GLContextEGL::destroyImage const):
* platform/graphics/egl/GLContextEGL.h:
* platform/graphics/gbm/GBMDevice.cpp: Added.
(WebCore::threadSpecificDevice):
(WebCore::GBMDevice::get):
(WebCore::GBMDevice::GBMDevice):
(WebCore::GBMDevice::~GBMDevice):
* platform/graphics/gbm/GBMDevice.h: Added.
(WebCore::GBMDevice::device const):
* platform/graphics/nicosia/texmap/NicosiaGCGLANGLEPipe.cpp:
(Nicosia::GCGLANGLEPipeSource::swapBuffersIfNeeded):
* platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLANGLE::EGLImageBacking::EGLImageBacking):
(WebCore::GraphicsContextGLANGLE::EGLImageBacking::~EGLImageBacking):
(WebCore::GraphicsContextGLANGLE::EGLImageBacking::format const):
(WebCore::GraphicsContextGLANGLE::EGLImageBacking::stride const):
(WebCore::GraphicsContextGLANGLE::EGLImageBacking::releaseResources):
(WebCore::GraphicsContextGLANGLE::EGLImageBacking::reset):
(WebCore::GraphicsContextGLANGLE::~GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLANGLE::reshapeDisplayBufferBacking):
* platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
(WebCore::TextureMapperPlatformLayerBuffer::textureVariant const):
(WebCore::TextureMapperPlatformLayerBuffer::size const):
(WebCore::TextureMapperPlatformLayerBuffer::textureVariant): Deleted.
* platform/graphics/texmap/TextureMapperPlatformLayerDmabuf.cpp: Added.
(WebCore::createFourCC):
(WebCore::fourCCToGLFormat):
(WebCore::formatHasAlpha):
(WebCore::TextureMapperPlatformLayerDmabuf::TextureMapperPlatformLayerDmabuf):
(WebCore::m_fd):
(WebCore::TextureMapperPlatformLayerDmabuf::~TextureMapperPlatformLayerDmabuf):
(WebCore::TextureMapperPlatformLayerDmabuf::validateTexture):
(WebCore::TextureMapperPlatformLayerDmabuf::paintToTextureMapper):
(WebCore::TextureMapperPlatformLayerDmabuf::clone):
* platform/graphics/texmap/TextureMapperPlatformLayerDmabuf.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/PlatformWPE.cmake
trunk/Source/WebCore/SourcesGTK.txt
trunk/Source/WebCore/SourcesWPE.txt
trunk/Source/WebCore/platform/TextureMapper.cmake
trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp
trunk/Source/WebCore/platform/graphics/OpenGLShims.h
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h
trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp
trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.h
trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGCGLANGLEPipe.cpp
trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h


Added Paths

trunk/Source/WebCore/platform/graphics/gbm/
trunk/Source/WebCore/platform/graphics/gbm/GBMDevice.cpp
trunk/Source/WebCore/platform/graphics/gbm/GBMDevice.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerDmabuf.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerDmabuf.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289105 => 289106)

--- trunk/Source/WebCore/ChangeLog	2022-02-04 06:58:12 UTC (rev 289105)
+++ trunk/Source/WebCore/ChangeLog	2022-02-04 07:16:39 UTC (rev 289106)
@@ -1,3 +1,66 @@
+2022-02-03  Chris Lord  
+
+[GTK][WPE] Use dmabuf when possible to transfer ANGLE rendering to the compositor
+https://bugs.webkit.org/show_bug.cgi?id=235946
+
+Reviewed by Žan Doberšek.
+
+Use dmabuf when available to transfer ANGLE WebGL rendering contents
+to the compositor.
+
+No new tests, no change in behaviour.
+
+* PlatformGTK.cmake:
+* PlatformWPE.cmake:
+* SourcesGTK.txt:
+* SourcesWPE.txt:
+* platform/TextureMapper.cmake:
+* platform/graphics/OpenGLShims.cpp:
+(WebCore::initializeOpenGLShims):
+* platform/graphics/OpenGLShims.h:
+*

[webkit-changes] [289105] trunk/LayoutTests/imported/w3c

2022-02-03 Thread jonlee

Title: [289105] trunk/LayoutTests/imported/w3c








Revision 289105
Author jon...@apple.com
Date 2022-02-03 22:58:12 -0800 (Thu, 03 Feb 2022)


Log Message
Pull selective WPT tests in preparation of https://bugs.webkit.org/show_bug.cgi?id=235685

These remove the empty .
* web-platform-tests/css/css-flexbox/align-content-001.htm:
* web-platform-tests/css/css-flexbox/align-content-002.htm:
* web-platform-tests/css/css-flexbox/align-content-003.htm:
* web-platform-tests/css/css-flexbox/align-content-004.htm:
* web-platform-tests/css/css-flexbox/align-content-005.htm:
* web-platform-tests/css/css-flexbox/align-items-001.htm:
* web-platform-tests/css/css-flexbox/align-items-002.htm:
* web-platform-tests/css/css-flexbox/align-items-003.htm:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-017.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-018.html:
* web-platform-tests/css/css-values/angle-units-002.html:
* web-platform-tests/css/css-values/angle-units-003.html:
* web-platform-tests/css/css-values/angle-units-004.html:
* web-platform-tests/css/css-values/angle-units-005.html:

Convert tabs to spaces.
* web-platform-tests/css/css-variables/vars-background-shorthand-001.html:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-001.htm
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-002.htm
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-003.htm
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-004.htm
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-005.htm
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-001.htm
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-002.htm
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-003.htm
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-017.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-018.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/angle-units-002.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/angle-units-003.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/angle-units-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/angle-units-005.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-variables/vars-background-shorthand-001.html




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289104 => 289105)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-02-04 06:37:14 UTC (rev 289104)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-02-04 06:58:12 UTC (rev 289105)
@@ -1,3 +1,26 @@
+2022-02-03  Jon Lee  
+
+Pull selective WPT tests in preparation of https://bugs.webkit.org/show_bug.cgi?id=235685
+
+These remove the empty .
+* web-platform-tests/css/css-flexbox/align-content-001.htm:
+* web-platform-tests/css/css-flexbox/align-content-002.htm:
+* web-platform-tests/css/css-flexbox/align-content-003.htm:
+* web-platform-tests/css/css-flexbox/align-content-004.htm:
+* web-platform-tests/css/css-flexbox/align-content-005.htm:
+* web-platform-tests/css/css-flexbox/align-items-001.htm:
+* web-platform-tests/css/css-flexbox/align-items-002.htm:
+* web-platform-tests/css/css-flexbox/align-items-003.htm:
+* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-017.html:
+* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-018.html:
+* web-platform-tests/css/css-values/angle-units-002.html:
+* web-platform-tests/css/css-values/angle-units-003.html:
+* web-platform-tests/css/css-values/angle-units-004.html:
+* web-platform-tests/css/css-values/angle-units-005.html:
+
+Convert tabs to spaces.
+* web-platform-tests/css/css-variables/vars-background-shorthand-001.html:
+
 2022-02-03  Ziran Sun  
 
 [Forms] Value doesn't change for stepUp()/stepDown() with out of range values


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-001.htm (289104 => 289105)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-001.htm	2022-02-04 06:37:14 UTC (rev 289104)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-content-001.htm	2022-02-04 06:58:12 UTC (rev 289105)
@@ -6,7 +6,6 @@
 
 
 
-
 
 
 #flexbox

Modified:

[webkit-changes] [289104] trunk/Source

2022-02-03 Thread rniwa

Title: [289104] trunk/Source








Revision 289104
Author rn...@webkit.org
Date 2022-02-03 22:37:14 -0800 (Thu, 03 Feb 2022)


Log Message
Delete SelectionAcrossShadowBoundariesEnabled
https://bugs.webkit.org/show_bug.cgi?id=235993

Reviewed by Darin Adler.

Source/WebCore:

Delete this runtime flag which has always been enabled for a while.

* editing/Editor.cpp:
(WebCore::Editor::selectedText const):
(WebCore::Editor::selectedTextForDataTransfer const):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
* editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::selectionInHTMLFormat):
* editing/gtk/EditorGtk.cpp:
(WebCore::Editor::writeSelectionToPasteboard):
* editing/libwpe/EditorLibWPE.cpp:
(WebCore::Editor::writeSelectionToPasteboard):
* editing/mac/EditorMac.mm:
(WebCore::Editor::writeImageToPasteboard):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createFromSelection):

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences keygenElementEnabled]):
(-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
(-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
(-[WebPreferences isXSSAuditorEnabled]):
* WebView/WebPreferencesPrivate.h:

Source/WTF:

* Scripts/Preferences/WebPreferencesInternal.yaml:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/VisibleSelection.cpp
trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm
trunk/Source/WebCore/editing/gtk/EditorGtk.cpp
trunk/Source/WebCore/editing/libwpe/EditorLibWPE.cpp
trunk/Source/WebCore/editing/mac/EditorMac.mm
trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h




Diff

Modified: trunk/Source/WTF/ChangeLog (289103 => 289104)

--- trunk/Source/WTF/ChangeLog	2022-02-04 06:35:43 UTC (rev 289103)
+++ trunk/Source/WTF/ChangeLog	2022-02-04 06:37:14 UTC (rev 289104)
@@ -1,3 +1,12 @@
+2022-02-03  Ryosuke Niwa  
+
+Delete SelectionAcrossShadowBoundariesEnabled
+https://bugs.webkit.org/show_bug.cgi?id=235993
+
+Reviewed by Darin Adler.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
 2022-02-03  Robert Jenner  
 
 Unreviewed, reverting r288902.


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (289103 => 289104)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-02-04 06:35:43 UTC (rev 289103)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-02-04 06:37:14 UTC (rev 289104)
@@ -760,18 +760,6 @@
 WebKit:
   default: true
 
-SelectionAcrossShadowBoundariesEnabled:
-  type: bool
-  humanReadableName: "Selection across shadow DOM"
-  humanReadableDescription: "Allow user-initiated selection across shadow DOM boundaries"
-  defaultValue:
-WebKitLegacy:
-  default: true
-WebKit:
-  default: true
-WebCore:
-  default: true
-  
 SelectionFlippingEnabled:
   type: bool
   humanReadableName: "Selection Flipping"


Modified: trunk/Source/WebCore/ChangeLog (289103 => 289104)

--- trunk/Source/WebCore/ChangeLog	2022-02-04 06:35:43 UTC (rev 289103)
+++ trunk/Source/WebCore/ChangeLog	2022-02-04 06:37:14 UTC (rev 289104)
@@ -1,3 +1,28 @@
+2022-02-03  Ryosuke Niwa  
+
+Delete SelectionAcrossShadowBoundariesEnabled
+https://bugs.webkit.org/show_bug.cgi?id=235993
+
+Reviewed by Darin Adler.
+
+Delete this runtime flag which has always been enabled for a while.
+
+* editing/Editor.cpp:
+(WebCore::Editor::selectedText const):
+(WebCore::Editor::selectedTextForDataTransfer const):
+* editing/VisibleSelection.cpp:
+(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
+* editing/cocoa/EditorCocoa.mm:
+(WebCore::Editor::selectionInHTMLFormat):
+* editing/gtk/EditorGtk.cpp:
+(WebCore::Editor::writeSelectionToPasteboard):
+* editing/libwpe/EditorLibWPE.cpp:
+(WebCore::Editor::writeSelectionToPasteboard):
+* editing/mac/EditorMac.mm:
+(WebCore::Editor::writeImageToPasteboard):
+* loader/archive/cf/LegacyWebArchive.cpp:
+(WebCore::LegacyWebArchive::createFromSelection):
+
 2022-02-03  Megan Gardner  
 
 Add pen type for HitTestRequest.


Modified: trunk/Source/WebCore/editing/Editor.cpp (289103 => 289104)

--- trunk/Source/WebCore/editing/Editor.cpp	2022-02-04 06:35:43 UTC (rev 289103)
+++ trunk/Source/WebCore/editing/Editor.cpp	2022-02-04 06:37:14 UTC (rev 289104)
@@ -3305,18 +3305,12 @@
 
 String Editor::selectedText() const

[webkit-changes] [289103] trunk/Source/WebKit

2022-02-03 Thread megan_gardner

Title: [289103] trunk/Source/WebKit








Revision 289103
Author megan_gard...@apple.com
Date 2022-02-03 22:35:43 -0800 (Thu, 03 Feb 2022)


Log Message
Plumb pointer type though native to web events.
https://bugs.webkit.org/show_bug.cgi?id=236118

Reviewed by Tim Horton.

* Shared/NativeWebMouseEvent.h:
* Shared/ios/NativeWebMouseEventIOS.mm:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* UIProcess/ios/WKMouseGestureRecognizer.mm:
(-[WKMouseGestureRecognizer createMouseEventWithType:wasCancelled:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/NativeWebMouseEvent.h
trunk/Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm
trunk/Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (289102 => 289103)

--- trunk/Source/WebKit/ChangeLog	2022-02-04 03:13:53 UTC (rev 289102)
+++ trunk/Source/WebKit/ChangeLog	2022-02-04 06:35:43 UTC (rev 289103)
@@ -1,3 +1,16 @@
+2022-02-03  Megan Gardner  
+
+Plumb pointer type though native to web events.
+https://bugs.webkit.org/show_bug.cgi?id=236118
+
+Reviewed by Tim Horton.
+
+* Shared/NativeWebMouseEvent.h:
+* Shared/ios/NativeWebMouseEventIOS.mm:
+(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
+* UIProcess/ios/WKMouseGestureRecognizer.mm:
+(-[WKMouseGestureRecognizer createMouseEventWithType:wasCancelled:]):
+
 2022-02-03  Wenson Hsieh  
 
 Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer's MediaPlayerIdentifier


Modified: trunk/Source/WebKit/Shared/NativeWebMouseEvent.h (289102 => 289103)

--- trunk/Source/WebKit/Shared/NativeWebMouseEvent.h	2022-02-04 03:13:53 UTC (rev 289102)
+++ trunk/Source/WebKit/Shared/NativeWebMouseEvent.h	2022-02-04 06:35:43 UTC (rev 289103)
@@ -70,7 +70,7 @@
 explicit NativeWebMouseEvent(const WebCore::IntPoint&);
 #elif PLATFORM(IOS_FAMILY)
 NativeWebMouseEvent(::WebEvent *);
-NativeWebMouseEvent(Type, Button, unsigned short buttons, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, float deltaX, float deltaY, float deltaZ, int clickCount, OptionSet, WallTime timestamp, double force, GestureWasCancelled);
+NativeWebMouseEvent(Type, Button, unsigned short buttons, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, float deltaX, float deltaY, float deltaZ, int clickCount, OptionSet, WallTime timestamp, double force, GestureWasCancelled, const String& pointerType);
 #elif USE(LIBWPE)
 NativeWebMouseEvent(struct wpe_input_pointer_event*, float deviceScaleFactor);
 #elif PLATFORM(WIN)


Modified: trunk/Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm (289102 => 289103)

--- trunk/Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm	2022-02-04 03:13:53 UTC (rev 289102)
+++ trunk/Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm	2022-02-04 06:35:43 UTC (rev 289103)
@@ -38,8 +38,8 @@
 {
 }
 
-NativeWebMouseEvent::NativeWebMouseEvent(Type type, Button button, unsigned short buttons, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, float deltaX, float deltaY, float deltaZ, int clickCount, OptionSet modifiers, WallTime timestamp, double force, GestureWasCancelled gestureWasCancelled)
-: WebMouseEvent(type, button, buttons, position, globalPosition, deltaX, deltaY, deltaZ, clickCount, modifiers, timestamp, force, NoTap, WebCore::mousePointerID, WebCore::mousePointerEventType(), gestureWasCancelled)
+NativeWebMouseEvent::NativeWebMouseEvent(Type type, Button button, unsigned short buttons, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, float deltaX, float deltaY, float deltaZ, int clickCount, OptionSet modifiers, WallTime timestamp, double force, GestureWasCancelled gestureWasCancelled, const String& pointerType)
+: WebMouseEvent(type, button, buttons, position, globalPosition, deltaX, deltaY, deltaZ, clickCount, modifiers, timestamp, force, NoTap, WebCore::mousePointerID, pointerType, gestureWasCancelled)
 {
 }
 


Modified: trunk/Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm (289102 => 289103)

--- trunk/Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm	2022-02-04 03:13:53 UTC (rev 289102)
+++ trunk/Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm	2022-02-04 06:35:43 UTC (rev 289103)
@@ -130,7 +130,10 @@
 auto delta = point - WebCore::IntPoint { [_currentTouch previousLocationInView:self.view] };
 // UITouch's timestamp uses mach_absolute_time as its timebase, same as MonotonicTime.
 auto timestamp = MonotonicTime::fromRawSeconds([_currentTouch timestamp]).approximateWallTime();
-return WTF::makeUnique(type, button, buttons, point, point, delta.width(), delta.height(), 0, [_currentTouch tapCount], modifiers, timestamp, 0, cancelled ? WebKit::GestureWasCancelled::Yes : WebKit::GestureWasCancelled::No);
+
+String pointerType = WebCore::mousePointerEventType();
+
+return

[webkit-changes] [289102] trunk/Source/WebCore

2022-02-03 Thread megan_gardner

Title: [289102] trunk/Source/WebCore








Revision 289102
Author megan_gard...@apple.com
Date 2022-02-03 19:13:53 -0800 (Thu, 03 Feb 2022)


Log Message
Add pen type for HitTestRequest.
https://bugs.webkit.org/show_bug.cgi?id=236112

Reviewed by Tim Horton.

* rendering/HitTestRequest.h:
(WebCore::HitTestRequest::mouseEvent const):
(WebCore::HitTestRequest::penEvent const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/HitTestRequest.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289101 => 289102)

--- trunk/Source/WebCore/ChangeLog	2022-02-04 02:53:09 UTC (rev 289101)
+++ trunk/Source/WebCore/ChangeLog	2022-02-04 03:13:53 UTC (rev 289102)
@@ -1,3 +1,14 @@
+2022-02-03  Megan Gardner  
+
+Add pen type for HitTestRequest.
+https://bugs.webkit.org/show_bug.cgi?id=236112
+
+Reviewed by Tim Horton.
+
+* rendering/HitTestRequest.h:
+(WebCore::HitTestRequest::mouseEvent const):
+(WebCore::HitTestRequest::penEvent const):
+
 2022-02-03  Myles C. Maxfield  
 
 Two bopomofo tone marks are not moved to the correct place in vertical text with a particular bopomofo font


Modified: trunk/Source/WebCore/rendering/HitTestRequest.h (289101 => 289102)

--- trunk/Source/WebCore/rendering/HitTestRequest.h	2022-02-04 02:53:09 UTC (rev 289101)
+++ trunk/Source/WebCore/rendering/HitTestRequest.h	2022-02-04 03:13:53 UTC (rev 289102)
@@ -49,6 +49,7 @@
 CollectMultipleElements = 1 << 15,
 // When using list-based testing, continue hit testing even after a hit has been found.
 IncludeAllElementsUnderPoint = 1 << 16,
+PenEvent = 1 << 17,
 };
 
 HitTestRequest(OptionSet type = { Type::ReadOnly, Type::Active, Type::DisallowUserAgentShadowContent })
@@ -66,7 +67,8 @@
 bool ignoreClipping() const { return m_type.contains(Type::IgnoreClipping); }
 bool svgClipContent() const { return m_type.contains(Type::SVGClipContent); }
 bool touchEvent() const { return m_type.contains(Type::TouchEvent); }
-bool mouseEvent() const { return !touchEvent(); }
+bool mouseEvent() const { return !touchEvent() && !penEvent(); }
+bool penEvent() const { return m_type.contains(Type::PenEvent); }
 bool disallowsUserAgentShadowContent() const { return m_type.contains(Type::DisallowUserAgentShadowContent); }
 bool disallowsUserAgentShadowContentExceptForImageOverlays() const { return m_type.contains(Type::DisallowUserAgentShadowContentExceptForImageOverlays); }
 bool allowsFrameScrollbars() const { return m_type.contains(Type::AllowFrameScrollbars); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289101] trunk

2022-02-03 Thread mmaxfield

Title: [289101] trunk








Revision 289101
Author mmaxfi...@apple.com
Date 2022-02-03 18:53:09 -0800 (Thu, 03 Feb 2022)


Log Message
Two bopomofo tone marks are not moved to the correct place in vertical text with a particular bopomofo font
https://bugs.webkit.org/show_bug.cgi?id=235257


Reviewed by Darin Adler.

.:

Thank you so much to Bobby Tung and But Ko for reporting this bug and providing a test font for it!!!

* metadata/contributors.json:

Source/WebCore:

Turns out one of our character data tables was missing some characters.

I really dislike these kinds of fixes, because it's just perpetuating the fact that WebKit has big tables of characters
in its source code. A long-term fix would be a systemic replacement of this entire table with either Unicode property
lookup, or more ideally, removing the need for it in the first place. Unfortunately, at this point in the release cycle,
this fix probably needs to be smaller and more targetted.

Tests: fast/text/bopomofo-tone-marks-2.html
   fast/text/bopomofo-tone-marks.html

* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::isCJKIdeographOrSymbol):

LayoutTests:

This can't be a WPT test because we only have permission to add the test font to the WebKit repository.

Thank you so much to Bobby Tung and But Ko for reporting this bug and providing a test font for it!!!

* fast/text/bopomofo-tone-marks-2-expected-mismatch.html: Added.
* fast/text/bopomofo-tone-marks-2.html: Added.
* fast/text/bopomofo-tone-marks-expected-mismatch.html: Added.
* fast/text/bopomofo-tone-marks.html: Added.
* fast/text/resources/BopomofoGposSubset-Regular/BopomofoGposSubset-Regular.ttf: Added.
* fast/text/resources/BopomofoGposSubset-Regular/LICENSE: Added.

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
trunk/metadata/contributors.json


Added Paths

trunk/LayoutTests/fast/text/bopomofo-tone-marks-2-expected-mismatch.html
trunk/LayoutTests/fast/text/bopomofo-tone-marks-2.html
trunk/LayoutTests/fast/text/bopomofo-tone-marks-expected-mismatch.html
trunk/LayoutTests/fast/text/bopomofo-tone-marks.html
trunk/LayoutTests/fast/text/resources/BopomofoGposSubset-Regular/
trunk/LayoutTests/fast/text/resources/BopomofoGposSubset-Regular/BopomofoGposSubset-Regular.ttf
trunk/LayoutTests/fast/text/resources/BopomofoGposSubset-Regular/LICENSE




Diff

Modified: trunk/ChangeLog (289100 => 289101)

--- trunk/ChangeLog	2022-02-04 02:45:45 UTC (rev 289100)
+++ trunk/ChangeLog	2022-02-04 02:53:09 UTC (rev 289101)
@@ -1,3 +1,15 @@
+2022-02-03  Myles C. Maxfield  
+
+Two bopomofo tone marks are not moved to the correct place in vertical text with a particular bopomofo font
+https://bugs.webkit.org/show_bug.cgi?id=235257
+
+
+Reviewed by Darin Adler.
+
+Thank you so much to Bobby Tung and But Ko for reporting this bug and providing a test font for it!!!
+
+* metadata/contributors.json:
+
 2022-02-03  Elliott Williams  
 
 Add Elliott Williams to contributors.json


Modified: trunk/LayoutTests/ChangeLog (289100 => 289101)

--- trunk/LayoutTests/ChangeLog	2022-02-04 02:45:45 UTC (rev 289100)
+++ trunk/LayoutTests/ChangeLog	2022-02-04 02:53:09 UTC (rev 289101)
@@ -1,3 +1,22 @@
+2022-02-03  Myles C. Maxfield  
+
+Two bopomofo tone marks are not moved to the correct place in vertical text with a particular bopomofo font
+https://bugs.webkit.org/show_bug.cgi?id=235257
+
+
+Reviewed by Darin Adler.
+
+This can't be a WPT test because we only have permission to add the test font to the WebKit repository.
+
+Thank you so much to Bobby Tung and But Ko for reporting this bug and providing a test font for it!!!
+
+* fast/text/bopomofo-tone-marks-2-expected-mismatch.html: Added.
+* fast/text/bopomofo-tone-marks-2.html: Added.
+* fast/text/bopomofo-tone-marks-expected-mismatch.html: Added.
+* fast/text/bopomofo-tone-marks.html: Added.
+* fast/text/resources/BopomofoGposSubset-Regular/BopomofoGposSubset-Regular.ttf: Added.
+* fast/text/resources/BopomofoGposSubset-Regular/LICENSE: Added.
+
 2022-02-03  Alan Bujtas  
 
 [RenderTreeBuilder] Clean up column spanners when style change affects containing block


Added: trunk/LayoutTests/fast/text/bopomofo-tone-marks-2-expected-mismatch.html (0 => 289101)

--- trunk/LayoutTests/fast/text/bopomofo-tone-marks-2-expected-mismatch.html	(rev 0)
+++ trunk/LayoutTests/fast/text/bopomofo-tone-marks-2-expected-mismatch.html	2022-02-04 02:53:09 UTC (rev 289101)
@@ -0,0 +1,17 @@
+
+
+
+
+
+@font-face {
+font-family: "BopomofoGposSubset";
+src: url("resources/BopomofoGposSubset-Regular/BopomofoGposSubset-Regular.ttf") format("truetype");
+}
+
+
+
+
+ãã
+
+
+


Added: trunk/LayoutTests/fast/text/bopomofo-tone-marks-2.html (0 => 289101)

---

[webkit-changes] [289100] trunk/Source

2022-02-03 Thread wenson_hsieh

Title: [289100] trunk/Source








Revision 289100
Author wenson_hs...@apple.com
Date 2022-02-03 18:45:45 -0800 (Thu, 03 Feb 2022)


Log Message
Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer's MediaPlayerIdentifier
https://bugs.webkit.org/show_bug.cgi?id=236090

Reviewed by Eric Carlson.

Source/WebCore:

Add plumbing for an optional MediaPlayerIdentifier through the video fullscreen model. This identifier is
invalidated upon `loadstart`, and updated once we observe `loadedmetadata`, which ensures that if the media
engine (and media player) changes out from underneath the video fullscreen model, we still keep the new player
ID up to date.

See WebKit/ChangeLog for more details.

* platform/cocoa/VideoFullscreenModel.h:
(WebCore::VideoFullscreenModelClient::setPlayerIdentifier):
* platform/cocoa/VideoFullscreenModelVideoElement.h:
* platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::updateForEventName):
(WebCore::VideoFullscreenModelVideoElement::observedEventNames):

Additionally listen for `loadstartEvent` and `loadedmetadataEvent` (see above).

(WebCore::VideoFullscreenModelVideoElement::setPlayerIdentifier):
* platform/ios/VideoFullscreenInterfaceAVKit.h:
* platform/mac/VideoFullscreenInterfaceMac.h:
(WebCore::VideoFullscreenInterfaceMac::playerIdentifier const):

Source/WebKit:

Add an IPC message between VideoFullscreenManager and VideoFullscreenManagerProxy to update the media player ID
corresponding to a given PlaybackSessionContextIdentifier. This is sent if the underlying media player changes
(and subsequently fires `loadstart` and `loadedmetadata` events), and also sent upon entering fullscreen video.

In a future patch, this mechanism will be used to teach VideoFullscreenManagerProxy to grab an image bitmap from
the GPU process for a given PlaybackSessionContextIdentifier.

* UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::setPlayerIdentifier):
* WebProcess/cocoa/VideoFullscreenManager.h:
* WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenInterfaceContext::setPlayerIdentifier):
(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::setPlayerIdentifier):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h
trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h
trunk/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h
trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (289099 => 289100)

--- trunk/Source/WebCore/ChangeLog	2022-02-04 02:26:07 UTC (rev 289099)
+++ trunk/Source/WebCore/ChangeLog	2022-02-04 02:45:45 UTC (rev 289100)
@@ -1,3 +1,31 @@
+2022-02-03  Wenson Hsieh  
+
+Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer's MediaPlayerIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=236090
+
+Reviewed by Eric Carlson.
+
+Add plumbing for an optional MediaPlayerIdentifier through the video fullscreen model. This identifier is
+invalidated upon `loadstart`, and updated once we observe `loadedmetadata`, which ensures that if the media
+engine (and media player) changes out from underneath the video fullscreen model, we still keep the new player
+ID up to date.
+
+See WebKit/ChangeLog for more details.
+
+* platform/cocoa/VideoFullscreenModel.h:
+(WebCore::VideoFullscreenModelClient::setPlayerIdentifier):
+* platform/cocoa/VideoFullscreenModelVideoElement.h:
+* platform/cocoa/VideoFullscreenModelVideoElement.mm:
+(WebCore::VideoFullscreenModelVideoElement::updateForEventName):
+(WebCore::VideoFullscreenModelVideoElement::observedEventNames):
+
+Additionally listen for `loadstartEvent` and `loadedmetadataEvent` (see above).
+
+(WebCore::VideoFullscreenModelVideoElement::setPlayerIdentifier):
+* platform/ios/VideoFullscreenInterfaceAVKit.h:
+* platform/mac/VideoFullscreenInterfaceMac.h:
+(WebCore::VideoFullscreenInterfaceMac::playerIdentifier const):
+
 2022-02-03  Commit Queue  
 
 Unreviewed, reverting r289096.


Modified: trunk/Source/WebCore/platform/cocoa/VideoFullscreenModel.h (289099 => 289100)

---

[webkit-changes] [289099] trunk/Source/WebCore

2022-02-03 Thread commit-queue

Title: [289099] trunk/Source/WebCore








Revision 289099
Author commit-qu...@webkit.org
Date 2022-02-03 18:26:07 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed, reverting r289096.
https://bugs.webkit.org/show_bug.cgi?id=236114

will break build

Reverted changeset:

"[WebAuthn] Remove misspelled constant
"LocalAuthenticatiorAccessGroup""
https://bugs.webkit.org/show_bug.cgi?id=235894
https://commits.webkit.org/r289096

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289098 => 289099)

--- trunk/Source/WebCore/ChangeLog	2022-02-04 02:24:21 UTC (rev 289098)
+++ trunk/Source/WebCore/ChangeLog	2022-02-04 02:26:07 UTC (rev 289099)
@@ -1,3 +1,17 @@
+2022-02-03  Commit Queue  
+
+Unreviewed, reverting r289096.
+https://bugs.webkit.org/show_bug.cgi?id=236114
+
+will break build
+
+Reverted changeset:
+
+"[WebAuthn] Remove misspelled constant
+"LocalAuthenticatiorAccessGroup""
+https://bugs.webkit.org/show_bug.cgi?id=235894
+https://commits.webkit.org/r289096
+
 2022-02-03  Alan Bujtas  
 
 [RenderTreeBuilder] Clean up column spanners when style change affects containing block


Modified: trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h (289098 => 289099)

--- trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h	2022-02-04 02:24:21 UTC (rev 289098)
+++ trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h	2022-02-04 02:26:07 UTC (rev 289099)
@@ -77,6 +77,9 @@
 Get
 };
 
+// rdar://88104045 - Remove once staged change completed
+const char LocalAuthenticatiorAccessGroup[] = "com.apple.webkit.webauthn";
+
 constexpr const char LocalAuthenticatorAccessGroup[] = "com.apple.webkit.webauthn";
 
 // Credential serialization






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289098] trunk

2022-02-03 Thread zalan

Title: [289098] trunk








Revision 289098
Author za...@apple.com
Date 2022-02-03 18:24:21 -0800 (Thu, 03 Feb 2022)


Log Message
[RenderTreeBuilder] Clean up column spanners when style change affects containing block
https://bugs.webkit.org/show_bug.cgi?id=236042


Reviewed by Antti Koivisto.

Source/WebCore:

In addition to removing the leftover spanners after style change, this patch also expands on the type of style changes that may affect the subtree state inside a multicolumn flow.

Test: fast/multicol/leftover-spanner-on-style-change-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::setStyle):
(WebCore::RenderElement::adjustFragmentedFlowStateOnContainingBlockChangeIfNeeded):
* rendering/RenderElement.h:
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):

LayoutTests:

* fast/multicol/leftover-spanner-on-style-change-crash-expected.txt: Added.
* fast/multicol/leftover-spanner-on-style-change-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp


Added Paths

trunk/LayoutTests/fast/multicol/leftover-spanner-on-style-change-crash-expected.txt
trunk/LayoutTests/fast/multicol/leftover-spanner-on-style-change-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (289097 => 289098)

--- trunk/LayoutTests/ChangeLog	2022-02-04 02:22:29 UTC (rev 289097)
+++ trunk/LayoutTests/ChangeLog	2022-02-04 02:24:21 UTC (rev 289098)
@@ -1,3 +1,14 @@
+2022-02-03  Alan Bujtas  
+
+[RenderTreeBuilder] Clean up column spanners when style change affects containing block
+https://bugs.webkit.org/show_bug.cgi?id=236042
+
+
+Reviewed by Antti Koivisto.
+
+* fast/multicol/leftover-spanner-on-style-change-crash-expected.txt: Added.
+* fast/multicol/leftover-spanner-on-style-change-crash.html: Added.
+
 2022-02-03  Jon Lee  
 
 Unreviewed gardening.


Added: trunk/LayoutTests/fast/multicol/leftover-spanner-on-style-change-crash-expected.txt (0 => 289098)

--- trunk/LayoutTests/fast/multicol/leftover-spanner-on-style-change-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/multicol/leftover-spanner-on-style-change-crash-expected.txt	2022-02-04 02:24:21 UTC (rev 289098)
@@ -0,0 +1 @@
+


Added: trunk/LayoutTests/fast/multicol/leftover-spanner-on-style-change-crash.html (0 => 289098)

--- trunk/LayoutTests/fast/multicol/leftover-spanner-on-style-change-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/leftover-spanner-on-style-change-crash.html	2022-02-04 02:24:21 UTC (rev 289098)
@@ -0,0 +1,31 @@
+
+  html {
+columns: 1px;
+  }
+  div::before {
+content: url();
+  }
+  frame {
+column-span: all;
+  }
+  :first-child {
+position: absolute;
+rotate: 0deg;
+  }
+  :read-only {
+translate: 0;
+  }
+
+
+
+  if (window.testRunner)
+testRunner.dumpAsText();
+  internals.settings.setTextAutosizingEnabled(true);
+  _onload_ = () => {
+let div0 = document.createElement('div');
+document.body.appendChild(div0);
+div0.appendChild(document.createElement('frame'));
+document.body.offsetTop;
+document.designMode = 'on';
+  };
+


Modified: trunk/Source/WebCore/ChangeLog (289097 => 289098)

--- trunk/Source/WebCore/ChangeLog	2022-02-04 02:22:29 UTC (rev 289097)
+++ trunk/Source/WebCore/ChangeLog	2022-02-04 02:24:21 UTC (rev 289098)
@@ -1,3 +1,24 @@
+2022-02-03  Alan Bujtas  
+
+[RenderTreeBuilder] Clean up column spanners when style change affects containing block
+https://bugs.webkit.org/show_bug.cgi?id=236042
+
+
+Reviewed by Antti Koivisto.
+
+In addition to removing the leftover spanners after style change, this patch also expands on the type of style changes that may affect the subtree state inside a multicolumn flow.
+
+Test: fast/multicol/leftover-spanner-on-style-change-crash.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::styleDidChange):
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::setStyle):
+(WebCore::RenderElement::adjustFragmentedFlowStateOnContainingBlockChangeIfNeeded):
+* rendering/RenderElement.h:
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):
+
 2022-02-03  Tyler Wilcock  
 
 AXIsolatedTree::updateChildren removes subtrees that should instead be moved


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (289097 => 289098)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2022-02-04 02:22:29 UTC (rev 289097)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2022-02-04

[webkit-changes] [289097] trunk/Source/WebCore

2022-02-03 Thread tyler_w

Title: [289097] trunk/Source/WebCore








Revision 289097
Author tyle...@apple.com
Date 2022-02-03 18:22:29 -0800 (Thu, 03 Feb 2022)


Log Message
AXIsolatedTree::updateChildren removes subtrees that should instead be moved
https://bugs.webkit.org/show_bug.cgi?id=236057

Reviewed by Andres Gonzalez.

In AXIsolatedTree::updateChildren, we can sometimes remove subtrees from the nodemap that are
queued to be added somewhere else in the tree. Specifically, this can happen when:

  1. Object 123 is considered to be a new child based on the live AX tree, and we collect node changes for it.
  2. Object 123 is currently a member of a subtree of some other object in oldChildrenIDs.
  3. Because of 2, Object 123 is removed from the node map in removeSubtreeFromNodeMap
  4. We try to queue the addition of this node somewhere in tree in queueChange, but ASSERT because Object 123 is not in the nodemap anymore.

This causes us to hit ASSERT(m_nodeMap.contains(objectID) in AXIsolatedTree::queueChange(const NodeChange&).

This patch fixes this problem by keeping track of the IDs we are queuing for addition
to the tree and making sure we don't remove those IDs.

* accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::queueChange):
(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
(WebCore::AXIsolatedTree::nodeAncestryChanges):
Keep track of IDs we are queueing changes for.
(WebCore::AXIsolatedTree::updateChildren):
Keep track of IDs we are queueing changes for and don't remove them,
even if they are part of oldChildrenIDs.
(WebCore::AXIsolatedTree::removeSubtreeFromNodeMap):
* accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::removeSubtreeFromNodeMap):
Accept another paramter listing IDs to keep.
(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
Keep track of IDs we are queueing changes for.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289096 => 289097)

--- trunk/Source/WebCore/ChangeLog	2022-02-04 02:09:58 UTC (rev 289096)
+++ trunk/Source/WebCore/ChangeLog	2022-02-04 02:22:29 UTC (rev 289097)
@@ -1,3 +1,38 @@
+2022-02-03  Tyler Wilcock  
+
+AXIsolatedTree::updateChildren removes subtrees that should instead be moved
+https://bugs.webkit.org/show_bug.cgi?id=236057
+
+Reviewed by Andres Gonzalez.
+
+In AXIsolatedTree::updateChildren, we can sometimes remove subtrees from the nodemap that are
+queued to be added somewhere else in the tree. Specifically, this can happen when:
+
+  1. Object 123 is considered to be a new child based on the live AX tree, and we collect node changes for it.
+  2. Object 123 is currently a member of a subtree of some other object in oldChildrenIDs.
+  3. Because of 2, Object 123 is removed from the node map in removeSubtreeFromNodeMap
+  4. We try to queue the addition of this node somewhere in tree in queueChange, but ASSERT because Object 123 is not in the nodemap anymore.
+
+This causes us to hit ASSERT(m_nodeMap.contains(objectID) in AXIsolatedTree::queueChange(const NodeChange&).
+
+This patch fixes this problem by keeping track of the IDs we are queuing for addition
+to the tree and making sure we don't remove those IDs.
+
+* accessibility/isolatedtree/AXIsolatedTree.cpp:
+(WebCore::AXIsolatedTree::queueChange):
+(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
+(WebCore::AXIsolatedTree::nodeAncestryChanges):
+Keep track of IDs we are queueing changes for.
+(WebCore::AXIsolatedTree::updateChildren):
+Keep track of IDs we are queueing changes for and don't remove them,
+even if they are part of oldChildrenIDs.
+(WebCore::AXIsolatedTree::removeSubtreeFromNodeMap):
+* accessibility/isolatedtree/AXIsolatedTree.h:
+(WebCore::AXIsolatedTree::removeSubtreeFromNodeMap):
+Accept another paramter listing IDs to keep.
+(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
+Keep track of IDs we are queueing changes for.
+
 2022-02-03  J Pascoe  
 
 [WebAuthn] Remove misspelled constant "LocalAuthenticatiorAccessGroup" 


Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp (289096 => 289097)

--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp	2022-02-04 02:09:58 UTC (rev 289096)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp	2022-02-04 02:22:29 UTC (rev 289097)
@@ -231,14 +231,14 @@
 
 AXID parentID = nodeChange.isolatedObject->parent();
 if (parentID.isValid()) {
-ASSERT(m_nodeMap.contains(parentID));
+ASSERT_WITH_MESSAGE(m_nodeMap.contains(parentID), "node map should've contained parentID: %s", parentID.loggingString().utf8().data());

[webkit-changes] [289096] trunk/Source/WebCore

2022-02-03 Thread j_pascoe

Title: [289096] trunk/Source/WebCore








Revision 289096
Author j_pas...@apple.com
Date 2022-02-03 18:09:58 -0800 (Thu, 03 Feb 2022)


Log Message
[WebAuthn] Remove misspelled constant "LocalAuthenticatiorAccessGroup"
https://bugs.webkit.org/show_bug.cgi?id=235894
rdar://88104045

Reviewed by Darin Adler.

This change removes a constant with a misspelled variable name after all
downstream usage is removed.

* Modules/webauthn/WebAuthenticationConstants.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289095 => 289096)

--- trunk/Source/WebCore/ChangeLog	2022-02-04 01:41:57 UTC (rev 289095)
+++ trunk/Source/WebCore/ChangeLog	2022-02-04 02:09:58 UTC (rev 289096)
@@ -1,3 +1,16 @@
+2022-02-03  J Pascoe  
+
+[WebAuthn] Remove misspelled constant "LocalAuthenticatiorAccessGroup" 
+https://bugs.webkit.org/show_bug.cgi?id=235894
+rdar://88104045
+
+Reviewed by Darin Adler.
+
+This change removes a constant with a misspelled variable name after all
+downstream usage is removed.
+
+* Modules/webauthn/WebAuthenticationConstants.h:
+
 2022-02-03  Michael Saboff  
 
 WebKit projects have incorrect install name for the frameworks for Catalyst builds with the system content path


Modified: trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h (289095 => 289096)

--- trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h	2022-02-04 01:41:57 UTC (rev 289095)
+++ trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h	2022-02-04 02:09:58 UTC (rev 289096)
@@ -77,9 +77,6 @@
 Get
 };
 
-// rdar://88104045 - Remove once staged change completed
-const char LocalAuthenticatiorAccessGroup[] = "com.apple.webkit.webauthn";
-
 constexpr const char LocalAuthenticatorAccessGroup[] = "com.apple.webkit.webauthn";
 
 // Credential serialization






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289095] tags/Safari-613.1.14.5.8/

2022-02-03 Thread repstein

Title: [289095] tags/Safari-613.1.14.5.8/








Revision 289095
Author repst...@apple.com
Date 2022-02-03 17:41:57 -0800 (Thu, 03 Feb 2022)


Log Message
Tag Safari-613.1.14.5.8.

Added Paths

tags/Safari-613.1.14.5.8/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289094] branches/safari-613.1.14.5-branch/Source

2022-02-03 Thread repstein

Title: [289094] branches/safari-613.1.14.5-branch/Source








Revision 289094
Author repst...@apple.com
Date 2022-02-03 17:40:56 -0800 (Thu, 03 Feb 2022)


Log Message
Cherry-pick r289091. rdar://problem/88387438

WebKit projects have incorrect install name for the frameworks for Catalyst builds with the system content path
https://bugs.webkit.org/show_bug.cgi?id=236105

Reviewed by Saam Barati.

Source/_javascript_Core:

Updated DYLIB_INSTALL_NAME_BASE for Catalyst builds to use _javascript_CORE_FRAMEWORKS_DIR, which doesn't have the
system content path prefix.

* Configurations/_javascript_Core.xcconfig:

Source/ThirdParty/ANGLE:

Updated DYLIB_INSTALL_NAME_BASE for Catalyst builds to not use the system content path prefix.

* Configurations/ANGLE-dynamic.xcconfig:

Source/ThirdParty/libwebrtc:

Updated DYLIB_INSTALL_NAME_BASE for Catalyst builds to not use the system content path prefix.

* Configurations/libwebrtc.xcconfig:

Source/WebCore:

Added WK_USE_ALTERNATE_FRAMEWORKS_DIR based computation to the WEBCORE_FRAMEWORKS_DIR production.
This allowed the simplification of NORMAL_PRODUCTION_FRAMEWORKS_DIR.
Changed DYLIB_INSTALL_NAME_BASE_PLATFORM for Catalyst builds to use WEBCORE_FRAMEWORKS_DIR.

* Configurations/WebCore.xcconfig:

Source/WebKit:

Refactored build variable computation so that WEBKIT_FRAMEWORKS_DIR doesn't have the system content path
prepended.  This refactoring includes:
- Created INSTALL_PATH_PREFIX to have the system content path when in use.
- Changed WEBKIT_FRAMEWORKS_DIR computation to eliminate the inclusion the SYSTEM_CONTENT_PATH.
- Added INSTALL_PATH_PREFIX to the various INSTALL_PATH computations.
- Changed the various DYLIB_INSTALL_NAME_BASE computations for Catalyst builds to use WEBKIT_FRAMEWORKS_DIR.

* Configurations/Base.xcconfig:
* Configurations/BaseTarget.xcconfig:
* Configurations/BaseXPCService.xcconfig:
* Configurations/Shim.xcconfig:
* Configurations/WebKit.xcconfig:
* Configurations/WebKitSwift.xcconfig:
* Configurations/adattributiond.xcconfig:
* Configurations/webpushd.xcconfig:

Source/WebKitLegacy/mac:

Refactored build variable computation so that WEBKIT_LEGACY_FRAMEWORKS_DIR doesn't have the system content path
prepended.  This refactoring includes:
- Created INSTALL_PATH_PREFIX to have the system content path when in use.
- Changed WEBKIT_LEGACY_FRAMEWORKS_DIR computation to eliminate the inclusion the SYSTEM_CONTENT_PATH.
- Reworked INSTALL_PATH to use INSTALL_PATH_PREFIX in the main productions instead of each of variants.
- Changed DYLIB_INSTALL_NAME_BASE computation for Catalyst builds to use WEBKIT_LEGACY_FRAMEWORKS_DIR.

* Configurations/Base.xcconfig:
* Configurations/WebKitLegacy.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.14.5-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.1.14.5-branch/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
branches/safari-613.1.14.5-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-613.1.14.5-branch/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig
branches/safari-613.1.14.5-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-613.1.14.5-branch/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
branches/safari-613.1.14.5-branch/Source/WebCore/ChangeLog
branches/safari-613.1.14.5-branch/Source/WebCore/Configurations/WebCore.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/ChangeLog
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/Base.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/BaseTarget.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/BaseXPCService.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/Shim.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/WebKit.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/WebKitSwift.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/adattributiond.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/webpushd.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-613.1.14.5-branch/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig




Diff

Modified: branches/safari-613.1.14.5-branch/Source/_javascript_Core/ChangeLog (289093 => 289094)

--- branches/safari-613.1.14.5-branch/Source/_javascript_Core/ChangeLog	2022-02-04 01:32:46 UTC (rev 289093)
+++ branches/safari-613.1.14.5-branch/Source/_javascript_Core/ChangeLog	2022-02-04 01:40:56 UTC (rev 289094)
@@ -1,3 +1,83 @@
+2022-02-03  Russell Epstein  
+
+Cherry-pick

[webkit-changes] [289093] trunk/Tools

2022-02-03 Thread emw

Title: [289093] trunk/Tools








Revision 289093
Author e...@apple.com
Date 2022-02-03 17:32:46 -0800 (Thu, 03 Feb 2022)


Log Message
[XCBuild] Add headers-only dependencies to projects in Tools/
https://bugs.webkit.org/show_bug.cgi?id=235751

Reviewed by Alexey Proskuryakov.

Many projects in Tools/ depend on WebKit.framework or other products which are upstream in
the build graph. In Make-based sequential builds, WebKit and friends would always build
before Tools; in workspaces, the targets may build in any order.

Add "product dependencies" build phases to targets which do not express
their dependencies through linker options, in the same manner as
https://commits.webkit.org/246026@main.

The legacy build system doesn't understand the "Product Dependencies" phase and thinks we're
trying to copy our own build products, so add an EXCLUDED_SOURCE_FILE_NAMES setting as a
workaround.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add product dependencies.
* DumpRenderTree/mac/Configurations/Base.xcconfig: Add WK_WHICH_BUILD_SYSTEM.
* DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Legacy support.
* TestWebKitAPI/Configurations/Base.xcconfig: Legacy support.
* TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Add WK_WHICH_BUILD_SYSTEM.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add product dependencies.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig
trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig
trunk/Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj




Diff

Modified: trunk/Tools/ChangeLog (289092 => 289093)

--- trunk/Tools/ChangeLog	2022-02-04 01:27:47 UTC (rev 289092)
+++ trunk/Tools/ChangeLog	2022-02-04 01:32:46 UTC (rev 289093)
@@ -1,3 +1,29 @@
+2022-02-03  Elliott Williams  
+
+[XCBuild] Add headers-only dependencies to projects in Tools/
+https://bugs.webkit.org/show_bug.cgi?id=235751
+
+Reviewed by Alexey Proskuryakov.
+
+Many projects in Tools/ depend on WebKit.framework or other products which are upstream in
+the build graph. In Make-based sequential builds, WebKit and friends would always build
+before Tools; in workspaces, the targets may build in any order.
+
+Add "product dependencies" build phases to targets which do not express
+their dependencies through linker options, in the same manner as
+https://commits.webkit.org/246026@main.
+
+The legacy build system doesn't understand the "Product Dependencies" phase and thinks we're
+trying to copy our own build products, so add an EXCLUDED_SOURCE_FILE_NAMES setting as a
+workaround.
+
+* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add product dependencies.
+* DumpRenderTree/mac/Configurations/Base.xcconfig: Add WK_WHICH_BUILD_SYSTEM.
+* DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Legacy support.
+* TestWebKitAPI/Configurations/Base.xcconfig: Legacy support.
+* TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Add WK_WHICH_BUILD_SYSTEM.
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add product dependencies.
+
 2022-02-03  Jonathan Bedard  
 
 [EWS] Rename RunJSCTestsWithoutPatch


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (289092 => 289093)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2022-02-04 01:27:47 UTC (rev 289092)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2022-02-04 01:32:46 UTC (rev 289093)
@@ -119,6 +119,7 @@
 		BCF6C6500C98E9C000AC063E /* GCController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCF6C64F0C98E9C000AC063E /* GCController.cpp */; };
 		C23EA2081BC9F05100C980B7 /* FontWithFeatures.otf in Copy Font Files */ = {isa = PBXBuildFile; fileRef = C23EA2061BC9EABA00C980B7 /* FontWithFeatures.otf */; };
 		C23EA2091BC9F05100C980B7 /* FontWithFeatures.ttf in Copy Font Files */ = {isa = PBXBuildFile; fileRef = C23EA2071BC9EABA00C980B7 /* FontWithFeatures.ttf */; };
+		DDD2187827A21850002B7025 /* WebKit.framework in Product Dependencies */ = {isa = PBXBuildFile; fileRef = 9335435F03D75502008635CE /* WebKit.framework */; };
 		E1B7816511AF31B7007E1BC2 /* MockGeolocationProvider.mm in Sources */ = {isa = PBXBuildFile; fileRef = E1B7808711AF1669007E1BC2 /* MockGeolocationProvider.mm */; };
 		F4010B7B24DA201F00A876E2 /* PoseAsClass.mm in Sources */ = {isa = PBXBuildFile; fileRef = F4010B7924DA200E00A876E2 /* PoseAsClass.mm */; };
 		F445C68624B2789D00790440 /* UIScriptControllerShared.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F445C68524B2788F00790440 /* UIScriptControllerShared.cpp */; };
@@ -198,6 +199,17

[webkit-changes] [289092] branches/safari-613.1.14.5-branch/Source

2022-02-03 Thread repstein

Title: [289092] branches/safari-613.1.14.5-branch/Source








Revision 289092
Author repst...@apple.com
Date 2022-02-03 17:27:47 -0800 (Thu, 03 Feb 2022)


Log Message
Versioning.

WebKit-7613.1.14.5.8

Modified Paths

branches/safari-613.1.14.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.14.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.14.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.14.5-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.14.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.14.5-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-613.1.14.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.14.5-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.14.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (289091 => 289092)

--- branches/safari-613.1.14.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-04 01:16:05 UTC (rev 289091)
+++ branches/safari-613.1.14.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-04 01:27:47 UTC (rev 289092)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 5;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.14.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (289091 => 289092)

--- branches/safari-613.1.14.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-04 01:16:05 UTC (rev 289091)
+++ branches/safari-613.1.14.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-04 01:27:47 UTC (rev 289092)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 5;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.14.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (289091 => 289092)

--- branches/safari-613.1.14.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-04 01:16:05 UTC (rev 289091)
+++ branches/safari-613.1.14.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-04 01:27:47 UTC (rev 289092)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 5;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.14.5-branch/Source/WebCore/Configurations/Version.xcconfig (289091 => 289092)

--- branches/safari-613.1.14.5-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-04 01:16:05 UTC (rev 289091)
+++ branches/safari-613.1.14.5-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-04 01:27:47 UTC (rev 289092)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 5;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.14.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (289091 => 289092)

--- branches/safari-613.1.14.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-04 01:16:05 UTC (rev 289091)
+++ branches/safari-613.1.14.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-04 01:27:47 UTC (rev 289092)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 5;
-NANO_VERSION = 7;
+NANO_VERSION = 8;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.14.5-branch/Source/WebGPU/Configurations/Version.xcconfig (289091 => 289092)

--- branches/safari-613.1.14.5-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-04 01:16:05 UTC (rev 289091)
+++ branches/safari-613.1.14.5-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-04 01:27:47 UTC (rev 289092)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 5;
-NANO_VERSION = 7;
+NANO_VERSION

[webkit-changes] [289091] trunk/Source

2022-02-03 Thread msaboff

Title: [289091] trunk/Source








Revision 289091
Author msab...@apple.com
Date 2022-02-03 17:16:05 -0800 (Thu, 03 Feb 2022)


Log Message
WebKit projects have incorrect install name for the frameworks for Catalyst builds with the system content path
https://bugs.webkit.org/show_bug.cgi?id=236105

Reviewed by Saam Barati.

Source/_javascript_Core:

Updated DYLIB_INSTALL_NAME_BASE for Catalyst builds to use _javascript_CORE_FRAMEWORKS_DIR, which doesn't have the
system content path prefix.

* Configurations/_javascript_Core.xcconfig:

Source/ThirdParty/ANGLE:

Updated DYLIB_INSTALL_NAME_BASE for Catalyst builds to not use the system content path prefix.

* Configurations/ANGLE-dynamic.xcconfig:

Source/ThirdParty/libwebrtc:

Updated DYLIB_INSTALL_NAME_BASE for Catalyst builds to not use the system content path prefix.

* Configurations/libwebrtc.xcconfig:

Source/WebCore:

Added WK_USE_ALTERNATE_FRAMEWORKS_DIR based computation to the WEBCORE_FRAMEWORKS_DIR production.
This allowed the simplification of NORMAL_PRODUCTION_FRAMEWORKS_DIR.
Changed DYLIB_INSTALL_NAME_BASE_PLATFORM for Catalyst builds to use WEBCORE_FRAMEWORKS_DIR.

* Configurations/WebCore.xcconfig:

Source/WebKit:

Refactored build variable computation so that WEBKIT_FRAMEWORKS_DIR doesn't have the system content path
prepended.  This refactoring includes:
- Created INSTALL_PATH_PREFIX to have the system content path when in use.
- Changed WEBKIT_FRAMEWORKS_DIR computation to eliminate the inclusion the SYSTEM_CONTENT_PATH.
- Added INSTALL_PATH_PREFIX to the various INSTALL_PATH computations.
- Changed the various DYLIB_INSTALL_NAME_BASE computations for Catalyst builds to use WEBKIT_FRAMEWORKS_DIR.

* Configurations/Base.xcconfig:
* Configurations/BaseTarget.xcconfig:
* Configurations/BaseXPCService.xcconfig:
* Configurations/Shim.xcconfig:
* Configurations/WebKit.xcconfig:
* Configurations/WebKitSwift.xcconfig:
* Configurations/adattributiond.xcconfig:
* Configurations/webpushd.xcconfig:

Source/WebKitLegacy/mac:

Refactored build variable computation so that WEBKIT_LEGACY_FRAMEWORKS_DIR doesn't have the system content path
prepended.  This refactoring includes:
- Created INSTALL_PATH_PREFIX to have the system content path when in use.
- Changed WEBKIT_LEGACY_FRAMEWORKS_DIR computation to eliminate the inclusion the SYSTEM_CONTENT_PATH.
- Reworked INSTALL_PATH to use INSTALL_PATH_PREFIX in the main productions instead of each of variants.
- Changed DYLIB_INSTALL_NAME_BASE computation for Catalyst builds to use WEBKIT_LEGACY_FRAMEWORKS_DIR.

* Configurations/Base.xcconfig:
* Configurations/WebKitLegacy.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/Base.xcconfig
trunk/Source/WebKit/Configurations/BaseTarget.xcconfig
trunk/Source/WebKit/Configurations/BaseXPCService.xcconfig
trunk/Source/WebKit/Configurations/Shim.xcconfig
trunk/Source/WebKit/Configurations/WebKit.xcconfig
trunk/Source/WebKit/Configurations/WebKitSwift.xcconfig
trunk/Source/WebKit/Configurations/adattributiond.xcconfig
trunk/Source/WebKit/Configurations/webpushd.xcconfig
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (289090 => 289091)

--- trunk/Source/_javascript_Core/ChangeLog	2022-02-04 01:06:52 UTC (rev 289090)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-04 01:16:05 UTC (rev 289091)
@@ -1,3 +1,15 @@
+2022-02-03  Michael Saboff  
+
+WebKit projects have incorrect install name for the frameworks for Catalyst builds with the system content path
+https://bugs.webkit.org/show_bug.cgi?id=236105
+
+Reviewed by Saam Barati.
+
+Updated DYLIB_INSTALL_NAME_BASE for Catalyst builds to use _javascript_CORE_FRAMEWORKS_DIR, which doesn't have the
+system content path prefix.
+
+* Configurations/_javascript_Core.xcconfig:
+
 2022-02-03  Yusuke Suzuki  
 
 [JSC] MultiDeleteByOffset should not define value


Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (289090 => 289091)

--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig	2022-02-04 01:06:52 UTC (rev 289090)
+++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig	2022-02-04 01:16:05 UTC (rev 289091)
@@ -46,7 +46,7 @@
 INSTALL_PATH = $(INSTALL_PATH_PREFIX)$(_javascript_CORE_FRAMEWORKS_DIR);
 DYLIB_INSTALL_NAME_BASE =

[webkit-changes] [289090] trunk/Source/WebKit

2022-02-03 Thread wenson_hsieh

Title: [289090] trunk/Source/WebKit








Revision 289090
Author wenson_hs...@apple.com
Date 2022-02-03 17:06:52 -0800 (Thu, 03 Feb 2022)


Log Message
Add plumbing to inform WebPageProxy when videos play, pause, seek, and enter or exit fullscreen
https://bugs.webkit.org/show_bug.cgi?id=236083

Reviewed by Eric Carlson.

Add several methods on WebPageProxy which are called from both VideoFullscreenManagerProxy as well as
PlaybackSessionManagerProxy; in future patches, these will be used to detect when a fullscreen video has been
paused for at least 250 ms, and call out to the page client to perform "video frame extraction".

No change in behavior (yet).

* Shared/Cocoa/PlaybackSessionContextIdentifier.h: Renamed from Source/WebKit/WebProcess/cocoa/PlaybackSessionContextIdentifier.h.

Move this from Source/WebKit/WebProcess/cocoa to Shared/Cocoa. This enum type is passed around in media code in
both the UI and web processes, so it should be in the Shared folder instead of the WebProcess folder.

* UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionManagerProxy::currentTimeChanged):
(WebKit::PlaybackSessionManagerProxy::rateChanged):
(WebKit::PlaybackSessionManagerProxy::isPaused const):

Add a helper method to return whether or not the session for a given PlaybackSessionContextIdentifier is paused
(that is, neither playing nor stalled).

* UIProcess/Cocoa/VideoFullscreenManagerProxy.h:

Drive-by fix: remove an unused member variable.

* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::didExitFullscreen):
(WebKit::VideoFullscreenManagerProxy::didEnterFullscreen):

Add another version of these methods that includes the session context ID as an argument.

* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::didChangePlaybackRate):
(WebKit::WebPageProxy::didChangeCurrentTime):
(WebKit::WebPageProxy::updateFullscreenVideoExtraction):
(WebKit::WebPageProxy::fullscreenVideoExtractionTimerFired):
* UIProcess/WebPageProxy.cpp:
(WebKit::m_fullscreenVideoExtractionTimer):
(WebKit::WebPageProxy::didEnterFullscreen):
(WebKit::WebPageProxy::didExitFullscreen):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::m_notificationManagerMessageHandler): Deleted.
* UIProcess/WebPageProxy.h:
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
trunk/Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/Shared/Cocoa/PlaybackSessionContextIdentifier.h


Removed Paths

trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionContextIdentifier.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (289089 => 289090)

--- trunk/Source/WebKit/ChangeLog	2022-02-04 00:22:13 UTC (rev 289089)
+++ trunk/Source/WebKit/ChangeLog	2022-02-04 01:06:52 UTC (rev 289090)
@@ -1,3 +1,54 @@
+2022-02-03  Wenson Hsieh  
+
+Add plumbing to inform WebPageProxy when videos play, pause, seek, and enter or exit fullscreen
+https://bugs.webkit.org/show_bug.cgi?id=236083
+
+Reviewed by Eric Carlson.
+
+Add several methods on WebPageProxy which are called from both VideoFullscreenManagerProxy as well as
+PlaybackSessionManagerProxy; in future patches, these will be used to detect when a fullscreen video has been
+paused for at least 250 ms, and call out to the page client to perform "video frame extraction".
+
+No change in behavior (yet).
+
+* Shared/Cocoa/PlaybackSessionContextIdentifier.h: Renamed from Source/WebKit/WebProcess/cocoa/PlaybackSessionContextIdentifier.h.
+
+Move this from Source/WebKit/WebProcess/cocoa to Shared/Cocoa. This enum type is passed around in media code in
+both the UI and web processes, so it should be in the Shared folder instead of the WebProcess folder.
+
+* UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
+* UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
+(WebKit::PlaybackSessionManagerProxy::currentTimeChanged):
+(WebKit::PlaybackSessionManagerProxy::rateChanged):
+(WebKit::PlaybackSessionManagerProxy::isPaused const):
+
+Add a helper method to return whether or not the session for a given PlaybackSessionContextIdentifier is paused
+(that is, neither playing nor stalled).
+
+* UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
+
+Drive-by fix: remove an unused member variable.
+
+* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+

[webkit-changes] [289089] trunk/Tools

2022-02-03 Thread jbedard

Title: [289089] trunk/Tools








Revision 289089
Author jbed...@apple.com
Date 2022-02-03 16:22:13 -0800 (Thu, 03 Feb 2022)


Log Message
[EWS] Rename RunJSCTestsWithoutPatch
https://bugs.webkit.org/show_bug.cgi?id=236106


Reviewed by Alexey Proskuryakov.

* Tools/CISupport/ews-build/steps.py:
(RunJavaScriptCoreTests.evaluateCommand):
(RunJSCTestsWithoutChange): Renamed from RunJSCTestsWithoutPatch.
(RunJSCTestsWithoutPatch): Renamed to RunJSCTestsWithoutChange.
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/246789@main

Modified Paths

trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (289088 => 289089)

--- trunk/Tools/CISupport/ews-build/steps.py	2022-02-03 23:47:15 UTC (rev 289088)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-02-04 00:22:13 UTC (rev 289089)
@@ -2249,7 +2249,7 @@
 CompileJSCWithoutPatch(),
 ValidateChange(verifyBugClosed=False, addURLs=False),
 KillOldProcesses(),
-RunJSCTestsWithoutPatch(),
+RunJSCTestsWithoutChange(),
 AnalyzeJSCTestsResults()])
 return rc
 
@@ -2313,8 +2313,8 @@
 log.addStdout(message)
 
 
-class RunJSCTestsWithoutPatch(RunJavaScriptCoreTests):
-name = 'jscore-test-without-patch'
+class RunJSCTestsWithoutChange(RunJavaScriptCoreTests):
+name = 'jscore-test-without-change'
 prefix = 'jsc_clean_tree_'
 
 def evaluateCommand(self, cmd):


Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (289088 => 289089)

--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-02-03 23:47:15 UTC (rev 289088)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-02-04 00:22:13 UTC (rev 289089)
@@ -51,7 +51,7 @@
KillOldProcesses, PrintConfiguration, PushCommitToWebKitRepo, ReRunAPITests, ReRunWebKitPerlTests,
ReRunWebKitTests, RevertPullRequestChanges, RunAPITests, RunAPITestsWithoutPatch, RunBindingsTests, RunBuildWebKitOrgUnitTests,
RunBuildbotCheckConfigForBuildWebKit, RunBuildbotCheckConfigForEWS, RunEWSUnitTests, RunResultsdbpyTests,
-   RunJavaScriptCoreTests, RunJSCTestsWithoutPatch, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyPython2Tests,
+   RunJavaScriptCoreTests, RunJSCTestsWithoutChange, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyPython2Tests,
RunWebKitPyPython3Tests, RunWebKitTests, RunWebKitTestsInStressMode, RunWebKitTestsInStressGuardmallocMode,
RunWebKitTestsWithoutPatch, RunWebKitTestsRedTree, RunWebKitTestsRepeatFailuresRedTree, RunWebKitTestsRepeatFailuresWithoutPatchRedTree,
RunWebKitTestsWithoutPatchRedTree, AnalyzeLayoutTestsResultsRedTree, TestWithFailureCount, ShowIdentifier,
@@ -1526,11 +1526,11 @@
 return rc
 
 
-class TestRunJSCTestsWithoutPatch(BuildStepMixinAdditions, unittest.TestCase):
+class TestRunJSCTestsWithoutChange(BuildStepMixinAdditions, unittest.TestCase):
 def setUp(self):
 self.longMessage = True
 self.jsonFileName = 'jsc_results.json'
-self.command_extra = RunJSCTestsWithoutPatch.command_extra
+self.command_extra = RunJSCTestsWithoutChange.command_extra
 return self.setUpBuildStep()
 
 def tearDown(self):
@@ -1537,7 +1537,7 @@
 return self.tearDownBuildStep()
 
 def test_success(self):
-self.setupStep(RunJSCTestsWithoutPatch())
+self.setupStep(RunJSCTestsWithoutChange())
 self.setProperty('fullPlatform', 'jsc-only')
 self.setProperty('configuration', 'release')
 self.expectRemoteCommands(
@@ -1552,7 +1552,7 @@
 return self.runStep()
 
 def test_failure(self):
-self.setupStep(RunJSCTestsWithoutPatch())
+self.setupStep(RunJSCTestsWithoutChange())
 self.setProperty('fullPlatform', 'jsc-only')
 self.setProperty('configuration', 'debug')
 self.expectRemoteCommands(


Modified: trunk/Tools/ChangeLog (289088 => 289089)

--- trunk/Tools/ChangeLog	2022-02-03 23:47:15 UTC (rev 289088)
+++ trunk/Tools/ChangeLog	2022-02-04 00:22:13 UTC (rev 289089)
@@ -1,5 +1,19 @@
 2022-02-03  Jonathan Bedard  
 
+[EWS] Rename RunJSCTestsWithoutPatch
+https://bugs.webkit.org/show_bug.cgi?id=236106
+
+
+Reviewed by Alexey Proskuryakov.
+
+* CISupport/ews-build/steps.py:
+(RunJavaScriptCoreTests.evaluateCommand):
+(RunJSCTestsWithoutChange): Renamed from RunJSCTestsWithoutPatch.
+(RunJSCTestsWithoutPatch): Renamed to RunJSCTestsWithoutChange.
+*

[webkit-changes] [289088] releases/WebKitGTK/webkit-2.34

2022-02-03 Thread aperez

Title: [289088] releases/WebKitGTK/webkit-2.34








Revision 289088
Author ape...@igalia.com
Date 2022-02-03 15:47:15 -0800 (Thu, 03 Feb 2022)


Log Message
Merge r286094 - Report the initiating url instead of the redirected one
https://bugs.webkit.org/show_bug.cgi?id=233037

Patch by Carlos Garcia Campos  on 2021-11-20
Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

* web-platform-tests/content-security-policy/securitypolicyviolation/img-src-redirect.sub-expected.txt:

Source/WebCore:

As per the spec, blockedURI should use the requested URL of original request instead of redirected location.

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::CachedResourceLoader::canRequestAfterRedirection const):
(WebCore::CachedResourceLoader::updateRequestAfterRedirection):
* loader/cache/CachedResourceLoader.h:
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowChildContextFromSource const):
(WebCore::ContentSecurityPolicy::allowScriptFromSource const):
(WebCore::ContentSecurityPolicy::allowImageFromSource const):
(WebCore::ContentSecurityPolicy::allowStyleFromSource const):
(WebCore::ContentSecurityPolicy::allowFontFromSource const):
(WebCore::ContentSecurityPolicy::allowManifestFromSource const):
(WebCore::ContentSecurityPolicy::allowMediaFromSource const):
* page/csp/ContentSecurityPolicy.h:

Source/WebKit:

Pass pre-redirect URL to allowChildContextFromSource() and allowScriptFromSource().

* NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::isAllowedByContentSecurityPolicy):

LayoutTests:

* TestExpectations: Unskip imported/w3c/web-platform-tests/content-security-policy/securitypolicyviolation/img-src-redirect.sub.html
* http/tests/security/contentSecurityPolicy/1.1/child-src/worker-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/font-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/image-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/script-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/stylesheet-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/svg-font-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/svg-image-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/track-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-redirect-blocked-expected.txt:

Modified Paths

releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.34/LayoutTests/TestExpectations
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/worker-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/font-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/image-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/script-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/stylesheet-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/svg-font-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/svg-image-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/track-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/imported/w3c/ChangeLog

[webkit-changes] [289087] releases/WebKitGTK/webkit-2.34

2022-02-03 Thread aperez

Title: [289087] releases/WebKitGTK/webkit-2.34








Revision 289087
Author ape...@igalia.com
Date 2022-02-03 15:46:42 -0800 (Thu, 03 Feb 2022)


Log Message
Merge r285320 - Form action with a redirect should report correct blocked URI
https://bugs.webkit.org/show_bug.cgi?id=232660


Patch by Kate Cheney  on 2021-11-04
Reviewed by Brent Fulgham.

Source/WebCore:

We currently report the blocked URI as the target of a redirect, per
the spec it should actually be the initiating url.

Test: http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkIfFormActionAllowedByCSP const):
* loader/FrameLoader.h:
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowResourceFromSource const):
(WebCore::ContentSecurityPolicy::allowFormAction const):
* page/csp/ContentSecurityPolicy.h:

LayoutTests:

* http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt:
Update console logging to report the correct URL.

Modified Paths

releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt
releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/loader/DocumentLoader.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/loader/FrameLoader.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/loader/FrameLoader.h
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/csp/ContentSecurityPolicy.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/csp/ContentSecurityPolicy.h


Added Paths

releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri-expected.txt
releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri.html




Diff

Modified: releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog (289086 => 289087)

--- releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog	2022-02-03 23:45:25 UTC (rev 289086)
+++ releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog	2022-02-03 23:46:42 UTC (rev 289087)
@@ -1,3 +1,16 @@
+2021-11-04  Kate Cheney  
+
+Form action with a redirect should report correct blocked URI
+https://bugs.webkit.org/show_bug.cgi?id=232660
+
+
+Reviewed by Brent Fulgham.
+
+* http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri.html: Added.
+* http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt:
+Update console logging to report the correct URL.
+
 2022-01-19  Rob Buis  
 
 Null check m_progressTracker in clearProvisionalLoad


Modified: releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt (289086 => 289087)

--- releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt	2022-02-03 23:45:25 UTC (rev 289086)
+++ releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt	2022-02-03 23:46:42 UTC (rev 289087)
@@ -1,3 +1,3 @@
-CONSOLE MESSAGE: Refused to load http://localhost:8000/navigation/resources/form-target.pl because it does not appear in the form-action directive of the Content Security Policy.
+CONSOLE MESSAGE: Refused to load http://127.0.0.1:8000/navigation/resources/redirection-response.py?host=localhost:8000=302=form-target.pl because it does not appear in the form-action directive of the Content Security Policy.
 
 Tests that blocking form redirect works correctly. If this test passes, you will see a console error, and will not see a page indicating a form was POSTed.


Added: releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri-expected.txt (0 => 289087)

--- releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.34/LayoutTests/http/tests/security/contentSecurityPolicy/form-action-redirect-with-correct-blocked-uri-expected.txt	2022-02-03 23:46:42 UTC (rev 289087)
@@ -0,0 +1,7 @@
+CONSOLE MESSAGE: Refused to load

[webkit-changes] [289086] trunk/LayoutTests

2022-02-03 Thread jonlee

Title: [289086] trunk/LayoutTests








Revision 289086
Author jon...@apple.com
Date 2022-02-03 15:45:25 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed gardening.

* gpu-process/TestExpectations: Tests are no longer crashing.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (289085 => 289086)

--- trunk/LayoutTests/ChangeLog	2022-02-03 23:27:03 UTC (rev 289085)
+++ trunk/LayoutTests/ChangeLog	2022-02-03 23:45:25 UTC (rev 289086)
@@ -1,3 +1,9 @@
+2022-02-03  Jon Lee  
+
+Unreviewed gardening.
+
+* gpu-process/TestExpectations: Tests are no longer crashing.
+
 2022-02-03  Ziran Sun  
 
 [Forms] Value doesn't change for stepUp()/stepDown() with out of range values


Modified: trunk/LayoutTests/gpu-process/TestExpectations (289085 => 289086)

--- trunk/LayoutTests/gpu-process/TestExpectations	2022-02-03 23:27:03 UTC (rev 289085)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2022-02-03 23:45:25 UTC (rev 289086)
@@ -1,4 +1,3 @@
-accessibility/ios-simulator/aria-details.html [ Crash ]
 animations/steps-transform-rendering-updates.html
 animations/stop-animation-on-suspend.html [ Pass ]
 compositing/backgrounds/fixed-backgrounds.html
@@ -33,7 +32,6 @@
 css3/calc/border-radius.html
 css3/color-filters/color-filter-color-property-list-item.html
 css3/color-filters/color-filter-color-text-decorations.html
-css3/color-filters/svg/color-filter-inline-svg.html [ Crash ]
 css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html
 css3/filters/backdrop/dynamic-with-clip-path.html
 css3/filters/backdrop/dynamic-with-clip-path.html [ Pass ]
@@ -204,7 +202,6 @@
 http/tests/resourceLoadStatistics/operating-dates-all-website-data-removed.html
 http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html
 http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction.html
-http/tests/security/canvas-remote-read-remote-video-hls.html [ Crash ]
 http/tests/security/css-mask-image-credentials.html
 http/tests/security/css-mask-image.html
 http/tests/security/svg-image-with-cached-remote-image.html
@@ -599,77 +596,6 @@
 imported/w3c/web-platform-tests/css/css-transforms/inline-styles/svg-inline-styles-011.html
 imported/w3c/web-platform-tests/css/css-transforms/inline-styles/svg-inline-styles-012.html
 imported/w3c/web-platform-tests/css/css-transforms/inline-styles/svg-inline-styles-013.html
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-001.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-002.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-003.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-004.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-005.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-006.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-007.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-008.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-009.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-010.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-011.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-012.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-013.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-014.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-015.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-016.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-017.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-018.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-019.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-020.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-021.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-022.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-023.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-024.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-025.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-026.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-027.html [ Crash ]
-imported/w3c/web-platform-tests/css/css-transforms/matrix/svg-matrix-028.html [ Crash ]

[webkit-changes] [289085] trunk/Source/JavaScriptCore

2022-02-03 Thread ysuzuki

Title: [289085] trunk/Source/_javascript_Core








Revision 289085
Author ysuz...@apple.com
Date 2022-02-03 15:27:03 -0800 (Thu, 03 Feb 2022)


Log Message
[JSC] MultiDeleteByOffset should not define value
https://bugs.webkit.org/show_bug.cgi?id=236103

Reviewed by Saam Barati.

MultiDeleteByOffset should not define any values in clobberizing.

* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGClobberize.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (289084 => 289085)

--- trunk/Source/_javascript_Core/ChangeLog	2022-02-03 23:21:54 UTC (rev 289084)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-03 23:27:03 UTC (rev 289085)
@@ -1,5 +1,17 @@
 2022-02-03  Yusuke Suzuki  
 
+[JSC] MultiDeleteByOffset should not define value
+https://bugs.webkit.org/show_bug.cgi?id=236103
+
+Reviewed by Saam Barati.
+
+MultiDeleteByOffset should not define any values in clobberizing.
+
+* dfg/DFGClobberize.h:
+(JSC::DFG::clobberize):
+
+2022-02-03  Yusuke Suzuki  
+
 Unreviewed, remove UnlinkedMetadataTable::offsetInMetadataTable since it is no longer used
 https://bugs.webkit.org/show_bug.cgi?id=236063
 


Modified: trunk/Source/_javascript_Core/dfg/DFGClobberize.h (289084 => 289085)

--- trunk/Source/_javascript_Core/dfg/DFGClobberize.h	2022-02-03 23:21:54 UTC (rev 289084)
+++ trunk/Source/_javascript_Core/dfg/DFGClobberize.h	2022-02-03 23:27:03 UTC (rev 289085)
@@ -1414,8 +1414,6 @@
 // alias analysis.
 write(NamedProperties);
 }
-if (node->multiDeleteByOffsetData().allVariantsStoreEmpty())
-def(HeapLocation(NamedPropertyLoc, heap, node->child1()), LazyNode(graph.freezeStrong(JSValue(;
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289084] trunk

2022-02-03 Thread emw

Title: [289084] trunk








Revision 289084
Author e...@apple.com
Date 2022-02-03 15:21:54 -0800 (Thu, 03 Feb 2022)


Log Message
Add Elliott Williams to contributors.json

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (289083 => 289084)

--- trunk/ChangeLog	2022-02-03 23:14:43 UTC (rev 289083)
+++ trunk/ChangeLog	2022-02-03 23:21:54 UTC (rev 289084)
@@ -1,3 +1,11 @@
+2022-02-03  Elliott Williams  
+
+Add Elliott Williams to contributors.json
+
+Unreviewed.
+
+* metadata/contributors.json:
+
 2022-01-24  Jonathan Bedard  
 
 [git-webkit] Configure default branch management 


Modified: trunk/metadata/contributors.json (289083 => 289084)

--- trunk/metadata/contributors.json	2022-02-03 23:14:43 UTC (rev 289083)
+++ trunk/metadata/contributors.json	2022-02-03 23:21:54 UTC (rev 289084)
@@ -2234,6 +2234,18 @@
   ]
},
{
+  "emails" : [
+ "e...@apple.com"
+  ],
+  "expertise" : "Xcode build system",
+  "github" : "emw-apple",
+  "name" : "Elliott Williams",
+  "nicks" : [
+ "emw"
+  ],
+  "status" : "committer"
+   },
+   {
   "aliases" : [
  "Emil Eklund"
   ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289083] releases/WebKitGTK/webkit-2.34/Source/WebKit

2022-02-03 Thread aperez

Title: [289083] releases/WebKitGTK/webkit-2.34/Source/WebKit








Revision 289083
Author ape...@igalia.com
Date 2022-02-03 15:14:43 -0800 (Thu, 03 Feb 2022)


Log Message
Merge r288809 - REGRESSION(r288644): [GTK4] Criticals when using pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=235883

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseZoomBegin):
Only cancel the click gesture on GTK3. We don't use g_object_set_data() on GTK4.

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (289082 => 289083)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-03 23:13:21 UTC (rev 289082)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-03 23:14:43 UTC (rev 289083)
@@ -1,3 +1,14 @@
+2022-01-31  Alexander Mikhaylenko  
+
+REGRESSION(r288644): [GTK4] Criticals when using pinch zoom
+https://bugs.webkit.org/show_bug.cgi?id=235883
+
+Reviewed by Carlos Garcia Campos.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseZoomBegin):
+Only cancel the click gesture on GTK3. We don't use g_object_set_data() on GTK4.
+
 2022-01-26  Alexander Mikhaylenko  
 
 [GTK3] Pinch zooming from a link activates it


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp (289082 => 289083)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp	2022-02-03 23:13:21 UTC (rev 289082)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp	2022-02-03 23:14:43 UTC (rev 289083)
@@ -1833,8 +1833,10 @@
 
 webkitWebViewBaseSynthesizeWheelEvent(webViewBase, event, 0, 0, x, y, WheelEventPhase::Began, WheelEventPhase::NoPhase, true);
 
+#if !USE(GTK4)
 GtkGesture* click = GTK_GESTURE(g_object_get_data(G_OBJECT(webViewBase), "wk-view-multi-press-gesture"));
 gtk_gesture_set_state(click, GTK_EVENT_SEQUENCE_DENIED);
+#endif
 }
 
 static void webkitWebViewBaseZoomChanged(WebKitWebViewBase* webViewBase, gdouble scale, GtkGesture* gesture)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289082] releases/WebKitGTK/webkit-2.34/Source/WebKit

2022-02-03 Thread aperez

Title: [289082] releases/WebKitGTK/webkit-2.34/Source/WebKit








Revision 289082
Author ape...@igalia.com
Date 2022-02-03 15:13:21 -0800 (Thu, 03 Feb 2022)


Log Message
Merge r288644 - [GTK3] Pinch zooming from a link activates it
https://bugs.webkit.org/show_bug.cgi?id=235639

Reviewed by Carlos Garcia Campos.

Turns out gestures behave differently between GTK3 and 4. On GTK4 it works
fine, but on GTK3 starting a pinch zoom triggers the multipress gesture
when one finger is down, and completes it when the second finger is down.

This results in a bogus click, with no way to prevent it as it happens
before any of the zoom callbacks are called. Since we can't know if there
will be a zoom afterwards or not, we can't do anything about it.

However, what we can do is reorder these gestures. In GTK3 the order the
gestures are processed in depends on which order they were created in.

At that point, there's a problem with the fact the gestures are grouped.
Grouping means that these 2 gestures are triggered at the same time. While
somehow the press gesture is still triggered without grouping with the
original order, they become properly decoupled in reverse order and
ungrouped.

At that point, we can safely cancel the press gesture when the zoom gesture
starts, and fix the issue.

This seems to still work fine for GTK4.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseZoomBegin):
(webkitWebViewBaseConstructed):

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (289081 => 289082)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-03 23:09:21 UTC (rev 289081)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-03 23:13:21 UTC (rev 289082)
@@ -1,5 +1,38 @@
 2022-01-26  Alexander Mikhaylenko  
 
+[GTK3] Pinch zooming from a link activates it
+https://bugs.webkit.org/show_bug.cgi?id=235639
+
+Reviewed by Carlos Garcia Campos.
+
+Turns out gestures behave differently between GTK3 and 4. On GTK4 it works
+fine, but on GTK3 starting a pinch zoom triggers the multipress gesture
+when one finger is down, and completes it when the second finger is down.
+
+This results in a bogus click, with no way to prevent it as it happens
+before any of the zoom callbacks are called. Since we can't know if there
+will be a zoom afterwards or not, we can't do anything about it.
+
+However, what we can do is reorder these gestures. In GTK3 the order the
+gestures are processed in depends on which order they were created in.
+
+At that point, there's a problem with the fact the gestures are grouped.
+Grouping means that these 2 gestures are triggered at the same time. While
+somehow the press gesture is still triggered without grouping with the
+original order, they become properly decoupled in reverse order and
+ungrouped.
+
+At that point, we can safely cancel the press gesture when the zoom gesture
+starts, and fix the issue.
+
+This seems to still work fine for GTK4.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseZoomBegin):
+(webkitWebViewBaseConstructed):
+
+2022-01-26  Alexander Mikhaylenko  
+
 [GTK] REGRESSION: Touch scrolling is broken
 https://bugs.webkit.org/show_bug.cgi?id=235436
 


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp (289081 => 289082)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp	2022-02-03 23:09:21 UTC (rev 289081)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp	2022-02-03 23:13:21 UTC (rev 289082)
@@ -1832,6 +1832,9 @@
 auto* event = gtk_gesture_get_last_event(gesture, sequence);
 
 webkitWebViewBaseSynthesizeWheelEvent(webViewBase, event, 0, 0, x, y, WheelEventPhase::Began, WheelEventPhase::NoPhase, true);
+
+GtkGesture* click = GTK_GESTURE(g_object_get_data(G_OBJECT(webViewBase), "wk-view-multi-press-gesture"));
+gtk_gesture_set_state(click, GTK_EVENT_SEQUENCE_DENIED);
 }
 
 static void webkitWebViewBaseZoomChanged(WebKitWebViewBase* webViewBase, gdouble scale, GtkGesture* gesture)
@@ -2054,6 +2057,17 @@
 gtk_widget_add_controller(viewWidget, GTK_EVENT_CONTROLLER(gesture));
 #endif
 
+#if USE(GTK4)
+gesture = gtk_gesture_click_new();
+gtk_widget_add_controller(viewWidget, GTK_EVENT_CONTROLLER(gesture));
+#else
+auto* gesture = gtk_gesture_multi_press_new(viewWidget);
+g_object_set_data_full(G_OBJECT(viewWidget), "wk-view-multi-press-gesture", gesture, g_object_unref);
+#endif
+gtk_gesture_single_set_touch_only(GTK_GESTURE_SINGLE(gesture), TRUE);
+g_signal_connect_object(gesture, "pressed",

[webkit-changes] [289081] trunk/Source

2022-02-03 Thread sihui_liu

Title: [289081] trunk/Source








Revision 289081
Author sihui_...@apple.com
Date 2022-02-03 15:09:21 -0800 (Thu, 03 Feb 2022)


Log Message
Delay writing origin file in NetworkStorageManager
https://bugs.webkit.org/show_bug.cgi?id=235897
rdar://87163253

Reviewed by Geoffrey Garen.

Revert r288924 that delays writing origin file to when OriginStorageManager is destroyed, and take a different
approach that schedules a async task to write origin file. PLT results show that the new approach can also make
up for PLT regresion caused by r286936, where network process started to write origin file before replying sync
storage message from web process.

* NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::localOriginStorageManager):
* NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::OriginStorageManager):
(WebKit::OriginStorageManager::~OriginStorageManager): Deleted.
* NetworkProcess/storage/OriginStorageManager.h:

Modified Paths

trunk/Source/WebCore/Headers.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp
trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.h




Diff

Modified: trunk/Source/WebCore/Headers.cmake (289080 => 289081)

--- trunk/Source/WebCore/Headers.cmake	2022-02-03 22:27:18 UTC (rev 289080)
+++ trunk/Source/WebCore/Headers.cmake	2022-02-03 23:09:21 UTC (rev 289081)
@@ -224,6 +224,8 @@
 Modules/indexeddb/server/IDBConnectionToClient.h
 Modules/indexeddb/server/IDBConnectionToClientDelegate.h
 Modules/indexeddb/server/IDBServer.h
+Modules/indexeddb/server/MemoryIDBBackingStore.h
+Modules/indexeddb/server/SQLiteIDBBackingStore.h
 Modules/indexeddb/server/ServerOpenDBRequest.h
 Modules/indexeddb/server/UniqueIDBDatabase.h
 Modules/indexeddb/server/UniqueIDBDatabaseConnection.h


Modified: trunk/Source/WebKit/ChangeLog (289080 => 289081)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 22:27:18 UTC (rev 289080)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 23:09:21 UTC (rev 289081)
@@ -1,3 +1,23 @@
+2022-02-03  Sihui Liu  
+
+Delay writing origin file in NetworkStorageManager
+https://bugs.webkit.org/show_bug.cgi?id=235897
+rdar://87163253
+
+Reviewed by Geoffrey Garen.
+
+Revert r288924 that delays writing origin file to when OriginStorageManager is destroyed, and take a different
+approach that schedules a async task to write origin file. PLT results show that the new approach can also make 
+up for PLT regresion caused by r286936, where network process started to write origin file before replying sync 
+storage message from web process.
+
+* NetworkProcess/storage/NetworkStorageManager.cpp:
+(WebKit::NetworkStorageManager::localOriginStorageManager):
+* NetworkProcess/storage/OriginStorageManager.cpp:
+(WebKit::OriginStorageManager::OriginStorageManager):
+(WebKit::OriginStorageManager::~OriginStorageManager): Deleted.
+* NetworkProcess/storage/OriginStorageManager.h:
+
 2022-02-03  Robert Jenner  
 
 Unreviewed, reverting r288902.


Modified: trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp (289080 => 289081)

--- trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp	2022-02-03 22:27:18 UTC (rev 289080)
+++ trunk/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp	2022-02-03 23:09:21 UTC (rev 289081)
@@ -213,12 +213,16 @@
 
 return *m_localOriginStorageManagers.ensure(origin, [&] {
 auto originDirectory = originDirectoryPath(m_path, origin, m_salt);
-// We write origin file at when OriginStorageManager is destroyed to avoid delay
-// in replying sync messages for Web Storage API.
-auto writeOriginFileFunction = [originFile = originFilePath(originDirectory), origin]() {
-writeOriginToFileIfNecessary(originFile, origin);
-};
-return makeUnique(WTFMove(writeOriginFileFunction), WTFMove(originDirectory), LocalStorageManager::localStorageFilePath(m_customLocalStoragePath, origin));
+// Write origin file asynchronously to avoid delay in replying sync messages for Web Storage API.
+if (!originDirectory.isEmpty()) {
+m_queue->dispatch([this, protectedThis = Ref { *this }, origin, originDirectory]() mutable {
+if (!m_localOriginStorageManagers.contains(origin))
+return;
+
+writeOriginToFileIfNecessary(originFilePath(originDirectory), origin);
+});
+}
+return makeUnique(WTFMove(originDirectory), LocalStorageManager::localStorageFilePath(m_customLocalStoragePath, origin));
 }).iterator->value;
 }
 


Modified: trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp (289080 => 289081)

---

[webkit-changes] [289079] releases/WebKitGTK/webkit-2.34

2022-02-03 Thread aperez

Title: [289079] releases/WebKitGTK/webkit-2.34








Revision 289079
Author ape...@igalia.com
Date 2022-02-03 14:27:08 -0800 (Thu, 03 Feb 2022)


Log Message
Merge r282952 - [GTK] Allow sending precise mouse wheel events in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=230541

Reviewed by Tim Horton.

Source/WebKit:

Add code to be able to send precise synthetic mouse-wheel events in GTK.

* Shared/NativeWebWheelEvent.h:
* Shared/gtk/NativeWebWheelEventGtk.cpp:
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSynthesizeWheelEvent):
(webkitWebViewBaseSetWheelHasPreciseDeltas):
* UIProcess/API/gtk/WebKitWebViewBaseInternal.h:

Tools:

Add API to be able to send precise mouse-wheel events in EventSender.

* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::setWheelHasPreciseDeltas):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::toWebKitGLibAPI):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::setWheelHasPreciseDeltas):

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/NativeWebWheelEvent.h
releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBaseInternal.h
releases/WebKitGTK/webkit-2.34/Tools/ChangeLog
releases/WebKitGTK/webkit-2.34/Tools/WebKitTestRunner/EventSenderProxy.h
releases/WebKitGTK/webkit-2.34/Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl
releases/WebKitGTK/webkit-2.34/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp
releases/WebKitGTK/webkit-2.34/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.h
releases/WebKitGTK/webkit-2.34/Tools/WebKitTestRunner/TestController.cpp
releases/WebKitGTK/webkit-2.34/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (289078 => 289079)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-03 22:12:39 UTC (rev 289078)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-03 22:27:08 UTC (rev 289079)
@@ -1,3 +1,20 @@
+2021-09-23  Chris Lord  
+
+[GTK] Allow sending precise mouse wheel events in LayoutTests
+https://bugs.webkit.org/show_bug.cgi?id=230541
+
+Reviewed by Tim Horton.
+
+Add code to be able to send precise synthetic mouse-wheel events in GTK.
+
+* Shared/NativeWebWheelEvent.h:
+* Shared/gtk/NativeWebWheelEventGtk.cpp:
+(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseSynthesizeWheelEvent):
+(webkitWebViewBaseSetWheelHasPreciseDeltas):
+* UIProcess/API/gtk/WebKitWebViewBaseInternal.h:
+
 2022-01-20  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.4 release


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/NativeWebWheelEvent.h (289078 => 289079)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/NativeWebWheelEvent.h	2022-02-03 22:12:39 UTC (rev 289078)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/NativeWebWheelEvent.h	2022-02-03 22:27:08 UTC (rev 289079)
@@ -61,7 +61,7 @@
 NativeWebWheelEvent(GdkEvent*);
 NativeWebWheelEvent(GdkEvent*, WebWheelEvent::Phase, WebWheelEvent::Phase momentumPhase);
 NativeWebWheelEvent(GdkEvent*, const WebCore::IntPoint&, const WebCore::FloatSize& wheelTicks);
-NativeWebWheelEvent(GdkEvent*, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, const WebCore::FloatSize& delta, const WebCore::FloatSize& wheelTicks, WebWheelEvent::Phase, WebWheelEvent::Phase momentumPhase);
+NativeWebWheelEvent(GdkEvent*, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, const WebCore::FloatSize& delta, const WebCore::FloatSize& wheelTicks, WebWheelEvent::Phase, WebWheelEvent::Phase momentumPhase, bool hasPreciseDeltas = false);
 #elif USE(LIBWPE)
 NativeWebWheelEvent(struct wpe_input_axis_event*, float deviceScaleFactor, WebWheelEvent::Phase, WebWheelEvent::Phase momentumPhase);
 #elif PLATFORM(WIN)


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp (289078 => 289079)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp	2022-02-03 22:12:39 UTC (rev 289078)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp	2022-02-03

[webkit-changes] [289080] releases/WebKitGTK/webkit-2.34

2022-02-03 Thread aperez

Title: [289080] releases/WebKitGTK/webkit-2.34








Revision 289080
Author ape...@igalia.com
Date 2022-02-03 14:27:18 -0800 (Thu, 03 Feb 2022)


Log Message
Merge r288609 - [GTK] REGRESSION: Touch scrolling is broken
https://bugs.webkit.org/show_bug.cgi?id=235436

Reviewed by Chris Lord.

Source/WebKit:

Remove webkitWebViewBaseSetWheelHasPreciseDeltas(), instead add a parameter
to webkitWebViewBaseSynthesizeWheelEvent() that specifies whether the event
should have precise deltas or not.

Correct the touch swipe velocity, since it won't get multiplied by
pixelsPerLineStep().

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::navigationGestureDidBegin):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseZoomBegin):
(webkitWebViewBaseTouchDragBegin):
(webkitWebViewBaseTouchDragUpdate):
(webkitWebViewBaseTouchSwipe):
(webkitWebViewBaseSynthesizeWheelEvent):
(webkitWebViewBaseSetWheelHasPreciseDeltas): Deleted.
* UIProcess/API/gtk/WebKitWebViewBaseInternal.h:
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
(WebKit::WebAutomationSession::platformSimulateWheelInteraction):

Tools:

Stop using webkitWebViewBaseSetWheelHasPreciseDeltas(), instead pass the correct parameter into
webkitWebViewBaseSynthesizeWheelEvent().

* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSenderProxy::setWheelHasPreciseDeltas):

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBaseInternal.h
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp
releases/WebKitGTK/webkit-2.34/Tools/ChangeLog
releases/WebKitGTK/webkit-2.34/Tools/WebKitTestRunner/EventSenderProxy.h
releases/WebKitGTK/webkit-2.34/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (289079 => 289080)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-03 22:27:08 UTC (rev 289079)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-03 22:27:18 UTC (rev 289080)
@@ -1,3 +1,31 @@
+2022-01-26  Alexander Mikhaylenko  
+
+[GTK] REGRESSION: Touch scrolling is broken
+https://bugs.webkit.org/show_bug.cgi?id=235436
+
+Reviewed by Chris Lord.
+
+Remove webkitWebViewBaseSetWheelHasPreciseDeltas(), instead add a parameter
+to webkitWebViewBaseSynthesizeWheelEvent() that specifies whether the event
+should have precise deltas or not.
+
+Correct the touch swipe velocity, since it won't get multiplied by
+pixelsPerLineStep().
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::navigationGestureDidBegin):
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseZoomBegin):
+(webkitWebViewBaseTouchDragBegin):
+(webkitWebViewBaseTouchDragUpdate):
+(webkitWebViewBaseTouchSwipe):
+(webkitWebViewBaseSynthesizeWheelEvent):
+(webkitWebViewBaseSetWheelHasPreciseDeltas): Deleted.
+* UIProcess/API/gtk/WebKitWebViewBaseInternal.h:
+* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
+* UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
+(WebKit::WebAutomationSession::platformSimulateWheelInteraction):
+
 2021-09-23  Chris Lord  
 
 [GTK] Allow sending precise mouse wheel events in LayoutTests


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp (289079 => 289080)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp	2022-02-03 22:27:08 UTC (rev 289079)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp	2022-02-03 22:27:18 UTC (rev 289080)
@@ -466,7 +466,7 @@
 
 void PageClientImpl::navigationGestureDidBegin()
 {
-webkitWebViewBaseSynthesizeWheelEvent(WEBKIT_WEB_VIEW_BASE(m_viewWidget), 0, 0, 0, 0, WheelEventPhase::Began, WheelEventPhase::NoPhase);
+webkitWebViewBaseSynthesizeWheelEvent(WEBKIT_WEB_VIEW_BASE(m_viewWidget), 0, 0, 0, 0, WheelEventPhase::Began, WheelEventPhase::NoPhase, true);
 }
 
 void PageClientImpl::navigationGestureWillEnd(bool, WebBackForwardListItem&)


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp (289079 => 289080)

---

[webkit-changes] [289078] trunk/Source/WebCore

2022-02-03 Thread nham

Title: [289078] trunk/Source/WebCore








Revision 289078
Author n...@apple.com
Date 2022-02-03 14:12:39 -0800 (Thu, 03 Feb 2022)


Log Message
LocalStorage values should be 8-bit strings in memory if possible
https://bugs.webkit.org/show_bug.cgi?id=235484

Reviewed by Chris Dumez.

LocalStorage values are stored into a SQLite column as 16-bit strings and are deserialized
back into memory as 16-bit strings. To save memory, this makes it so that we deserialize the
string into an 8-bit string in memory if possible.

Estimated win of ~3MB on Membuster5.

* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::columnBlobAsString):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289077 => 289078)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 21:47:06 UTC (rev 289077)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 22:12:39 UTC (rev 289078)
@@ -1,3 +1,19 @@
+2022-02-03  Ben Nham  
+
+LocalStorage values should be 8-bit strings in memory if possible
+https://bugs.webkit.org/show_bug.cgi?id=235484
+
+Reviewed by Chris Dumez.
+
+LocalStorage values are stored into a SQLite column as 16-bit strings and are deserialized
+back into memory as 16-bit strings. To save memory, this makes it so that we deserialize the
+string into an 8-bit string in memory if possible.
+
+Estimated win of ~3MB on Membuster5.
+
+* platform/sql/SQLiteStatement.cpp:
+(WebCore::SQLiteStatement::columnBlobAsString):
+
 2022-02-03  Ziran Sun  
 
 [Forms] Value doesn't change for stepUp()/stepDown() with out of range values


Modified: trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp (289077 => 289078)

--- trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp	2022-02-03 21:47:06 UTC (rev 289077)
+++ trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp	2022-02-03 22:12:39 UTC (rev 289078)
@@ -284,7 +284,7 @@
 return String();
 
 ASSERT(!(size % sizeof(UChar)));
-return String(static_cast(blob), size / sizeof(UChar));
+return StringImpl::create8BitIfPossible(static_cast(blob), size / sizeof(UChar));
 }
 
 Vector SQLiteStatement::columnBlob(int col)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289077] trunk

2022-02-03 Thread jbedard

Title: [289077] trunk








Revision 289077
Author jbed...@apple.com
Date 2022-02-03 13:47:06 -0800 (Thu, 03 Feb 2022)


Log Message
[git-webkit] Configure default branch management
https://bugs.webkit.org/show_bug.cgi?id=235378


Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/decorators.py:
(hybridmethod.__get__): Forward certain attributes, namely those used by Memoize.
* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git):
(Git.config): Add project config to fall back on.
(Git.url): Move memoize to config.
(Git.checkout): Clear Git.config, since that owns memoization.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.parser): Add --overwrite and --append flags.
(PullRequest.create_commit): Either amend an existing commit or create a new one,
depending on the repository settings and arguments passed.
(PullRequest.main): Only keep track of branch history if the user explicitly requests
it or we're using an overwrite workflow with a user owned fork. If repository settings
indicate such branches should never be created, return an error if the user attempts to do so.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): Add project config to repository config, prompt the user about their prefered
history retention strategy if the project is using an overwrite workflow.
(Setup.parser): Use the project's default merge behavior.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:

Canonical link: https://commits.webkit.org/246783@main

Modified Paths

trunk/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/setup.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/decorators.py
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py


Added Paths

trunk/metadata/project_config




Diff

Modified: trunk/ChangeLog (289076 => 289077)

--- trunk/ChangeLog	2022-02-03 21:42:21 UTC (rev 289076)
+++ trunk/ChangeLog	2022-02-03 21:47:06 UTC (rev 289077)
@@ -1,3 +1,13 @@
+2022-01-24  Jonathan Bedard  
+
+[git-webkit] Configure default branch management 
+https://bugs.webkit.org/show_bug.cgi?id=235378
+
+
+Reviewed by Dewei Zhu.
+
+* metadata/project_config: Added.
+
 2022-02-03  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.2 release


Modified: trunk/Tools/ChangeLog (289076 => 289077)

--- trunk/Tools/ChangeLog	2022-02-03 21:42:21 UTC (rev 289076)
+++ trunk/Tools/ChangeLog	2022-02-03 21:47:06 UTC (rev 289077)
@@ -1,3 +1,38 @@
+2022-02-03  Jonathan Bedard  
+
+[git-webkit] Configure default branch management 
+https://bugs.webkit.org/show_bug.cgi?id=235378
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitcorepy/setup.py: Bump version.
+* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
+* Scripts/libraries/webkitcorepy/webkitcorepy/decorators.py:
+(hybridmethod.__get__): Forward certain attributes, namely those used by Memoize.
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
+(Git):
+(Git.config): Add project config to fall back on.
+(Git.url): Move memoize to config.
+(Git.checkout): Clear Git.config, since that owns memoization.
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
+(PullRequest.parser): Add --overwrite and --append flags.
+(PullRequest.create_commit): Either amend an existing commit or

[webkit-changes] [289076] trunk/Source/JavaScriptCore

2022-02-03 Thread ysuzuki

Title: [289076] trunk/Source/_javascript_Core








Revision 289076
Author ysuz...@apple.com
Date 2022-02-03 13:42:21 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed, remove UnlinkedMetadataTable::offsetInMetadataTable since it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=236063

Follow-up after Saam's comment.

* bytecode/UnlinkedMetadataTable.h:
(JSC::UnlinkedMetadataTable::offsetInMetadataTable): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTable.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (289075 => 289076)

--- trunk/Source/_javascript_Core/ChangeLog	2022-02-03 21:34:50 UTC (rev 289075)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-03 21:42:21 UTC (rev 289076)
@@ -1,5 +1,15 @@
 2022-02-03  Yusuke Suzuki  
 
+Unreviewed, remove UnlinkedMetadataTable::offsetInMetadataTable since it is no longer used
+https://bugs.webkit.org/show_bug.cgi?id=236063
+
+Follow-up after Saam's comment.
+
+* bytecode/UnlinkedMetadataTable.h:
+(JSC::UnlinkedMetadataTable::offsetInMetadataTable): Deleted.
+
+2022-02-03  Yusuke Suzuki  
+
 [JSC] Use MetadataTable instead of UnlinkedMetadataTable
 https://bugs.webkit.org/show_bug.cgi?id=236063
 rdar://88269480


Modified: trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTable.h (289075 => 289076)

--- trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTable.h	2022-02-03 21:34:50 UTC (rev 289075)
+++ trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTable.h	2022-02-03 21:42:21 UTC (rev 289076)
@@ -64,17 +64,6 @@
 return adoptRef(*new UnlinkedMetadataTable);
 }
 
-template 
-uintptr_t offsetInMetadataTable(const Opcode& opcode)
-{
-ASSERT(m_isFinalized);
-// UnlinkedMetadataTable can be realloc-ed from the mutator thread, thus, it is not OK to touch this table from non mutator thread if the mutator thread is running.
-ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());
-uintptr_t baseTypeOffset = m_is32Bit ? offsetTable32()[Opcode::opcodeID] : offsetTable16()[Opcode::opcodeID];
-baseTypeOffset = roundUpToMultipleOf(alignof(typename Opcode::Metadata), baseTypeOffset);
-return baseTypeOffset + sizeof(typename Opcode::Metadata) * opcode.m_metadataID;
-}
-
 template 
 unsigned numEntries();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289075] trunk

2022-02-03 Thread zsun

Title: [289075] trunk








Revision 289075
Author z...@igalia.com
Date 2022-02-03 13:34:50 -0800 (Thu, 03 Feb 2022)


Log Message
[Forms] Value doesn't change for stepUp()/stepDown() with out of range values
https://bugs.webkit.org/show_bug.cgi?id=235509

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/forms/the-input-element/input-stepdown-expected.txt:
* web-platform-tests/html/semantics/forms/the-input-element/input-stepup-expected.txt:
* web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt:

Source/WebCore:

For input type number, WebKit throws "invalid state" Error when the value is greater than
max when calling stepUp() or less than min when calling stepDown(). According to section 10
in https://html.spec.whatwg.org/multipage/input.html#dom-input-stepup,
we should do "return", which indicates that value doesn't change.

* html/InputType.cpp:
(WebCore::InputType::applyStep):

LayoutTests:

Update expectation files.

* fast/forms/date/date-stepup-stepdown-expected.txt:
* fast/forms/date/date-stepup-stepdown.html:
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt:
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html:
* fast/forms/month/month-stepup-stepdown-expected.txt:
* fast/forms/month/month-stepup-stepdown.html:
* fast/forms/number/number-stepup-stepdown-expected.txt:
* fast/forms/number/number-stepup-stepdown.html:
* fast/forms/range/range-stepup-stepdown-expected.txt:
* fast/forms/range/range-stepup-stepdown.html:
* fast/forms/time/time-stepup-stepdown-expected.txt:
* fast/forms/time/time-stepup-stepdown.html:
* fast/forms/week/week-stepup-stepdown-expected.txt:
* fast/forms/week/week-stepup-stepdown.html:
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt:
* platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-stepdown-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-stepdown-expected.txt.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-stepup-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-stepup-expected.txt.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/date/date-stepup-stepdown-expected.txt
trunk/LayoutTests/fast/forms/date/date-stepup-stepdown.html
trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt
trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html
trunk/LayoutTests/fast/forms/month/month-stepup-stepdown-expected.txt
trunk/LayoutTests/fast/forms/month/month-stepup-stepdown.html
trunk/LayoutTests/fast/forms/number/number-stepup-stepdown-expected.txt
trunk/LayoutTests/fast/forms/number/number-stepup-stepdown.html
trunk/LayoutTests/fast/forms/range/range-stepup-stepdown-expected.txt
trunk/LayoutTests/fast/forms/range/range-stepup-stepdown.html
trunk/LayoutTests/fast/forms/time/time-stepup-stepdown-expected.txt
trunk/LayoutTests/fast/forms/time/time-stepup-stepdown.html
trunk/LayoutTests/fast/forms/week/week-stepup-stepdown-expected.txt
trunk/LayoutTests/fast/forms/week/week-stepup-stepdown.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-stepdown-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-stepup-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt
trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/InputType.cpp


Added Paths

trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-stepdown-expected.txt
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-stepup-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (289074 => 289075)

--- trunk/LayoutTests/ChangeLog	2022-02-03 21:32:43 UTC (rev 289074)
+++ trunk/LayoutTests/ChangeLog	2022-02-03 21:34:50 UTC (rev 289075)
@@ -1,3 +1,32 @@
+2022-02-03  Ziran Sun  
+
+[Forms] Value doesn't change for stepUp()/stepDown() with out of range values
+

[webkit-changes] [289074] trunk

2022-02-03 Thread nmouchtaris

Title: [289074] trunk








Revision 289074
Author nmouchta...@apple.com
Date 2022-02-03 13:32:43 -0800 (Thu, 03 Feb 2022)


Log Message
Implement CSS overscroll-behavior for synchronous scroll
https://bugs.webkit.org/show_bug.cgi?id=222968

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/scrolling/sync-scroll-overscroll-behavior-element.html
   fast/scrolling/sync-scroll-overscroll-behavior-iframe.html
   fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-element.html
   fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-iframe.html

Split up patch by Cathie Chen and Frederic Wang. Add function for blocking scroll chaining
and filtering scroll delta depending on the values of overscroll behavior for a scrollable
area. This patch is for synchronous scrolling only.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEventInternal):
(WebCore::scrollViaNonPlatformEvent):
(WebCore::EventHandler::handleWheelEventInAppropriateEnclosingBox):
(WebCore::EventHandler::scrollableAreaCanHandleEvent):
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
(WebCore::findEnclosingScrollableContainer):
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::eventForPropagation const):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::deltaForPropagation const):
(WebCore::ScrollableArea::shouldBlockScrollPropagation const):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::horizontalOverscrollBehaviorPreventsPropagation const):
(WebCore::ScrollableArea::verticalOverscrollBehaviorPreventsPropagation const):
* platform/ScrollingEffectsController.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::allowsVerticalStretching const):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching const):
* platform/mac/ScrollingEffectsController.mm:
(WebCore::ScrollingEffectsController::wheelDeltaBiasingTowardsVertical):

LayoutTests:

* fast/scrolling/sync-scroll-overscroll-behavior-element-expected.txt: Added.
* fast/scrolling/sync-scroll-overscroll-behavior-element.html: Added.
* fast/scrolling/sync-scroll-overscroll-behavior-iframe-expected.txt: Added.
* fast/scrolling/sync-scroll-overscroll-behavior-iframe.html: Added.
* fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-element-expected.txt: Added.
* fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-element.html: Added.
* fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-iframe-expected.txt: Added.
* fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-iframe.html: Added.
* platform/mac-wk1/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebCore/page/mac/EventHandlerMac.mm
trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
trunk/Source/WebCore/platform/ScrollableArea.cpp
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/platform/ScrollingEffectsController.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm


Added Paths

trunk/LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-element-expected.txt
trunk/LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-element.html
trunk/LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-iframe-expected.txt
trunk/LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-iframe.html
trunk/LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-element-expected.txt
trunk/LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-element.html
trunk/LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-iframe-expected.txt
trunk/LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (289073 => 289074)

--- trunk/LayoutTests/ChangeLog	2022-02-03 21:30:22 UTC (rev 289073)
+++ trunk/LayoutTests/ChangeLog	2022-02-03 21:32:43 UTC (rev 289074)
@@ -1,3 +1,21 @@
+2022-02-03  Nikolaos Mouchtaris  
+
+Implement CSS overscroll-behavior for synchronous scroll
+https://bugs.webkit.org/show_bug.cgi?id=222968
+
+Reviewed by Simon Fraser.
+
+* fast/scrolling/sync-scroll-overscroll-behavior-element-expected.txt: Added.
+* fast/scrolling/sync-scroll-overscroll-behavior-element.html: Added.
+* fast/scrolling/sync-scroll-overscroll-behavior-iframe-expected.txt: Added.
+* fast/scrolling/sync-scroll-overscroll-behavior-iframe.html: Added.
+* fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-element-expected.txt: Added.
+*

[webkit-changes] [289073] trunk

2022-02-03 Thread jenner

Title: [289073] trunk








Revision 289073
Author jen...@apple.com
Date 2022-02-03 13:30:22 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed, reverting r288902.

Broke compile-webkit for iOS-15-Simulator

Reverted changeset:

"Import APSConnection-related SPI"
https://bugs.webkit.org/show_bug.cgi?id=235856
https://commits.webkit.org/r288902

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/WebKitLibraries/ChangeLog


Removed Paths

trunk/Source/WebKit/Platform/spi/Cocoa/ApplePushServiceSPI.h
trunk/Source/WebKit/webpushd/ApplePushServiceConnection.h
trunk/Source/WebKit/webpushd/ApplePushServiceConnection.mm
trunk/Source/WebKit/webpushd/MockPushServiceConnection.h
trunk/Source/WebKit/webpushd/MockPushServiceConnection.mm
trunk/Source/WebKit/webpushd/PushServiceConnection.h
trunk/Source/WebKit/webpushd/PushServiceConnection.mm
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/15/ApplePushService.framework/




Diff

Modified: trunk/Source/WTF/ChangeLog (289072 => 289073)

--- trunk/Source/WTF/ChangeLog	2022-02-03 21:23:17 UTC (rev 289072)
+++ trunk/Source/WTF/ChangeLog	2022-02-03 21:30:22 UTC (rev 289073)
@@ -1,3 +1,15 @@
+2022-02-03  Robert Jenner  
+
+Unreviewed, reverting r288902.
+
+Broke compile-webkit for iOS-15-Simulator
+
+Reverted changeset:
+
+"Import APSConnection-related SPI"
+https://bugs.webkit.org/show_bug.cgi?id=235856
+https://commits.webkit.org/r288902
+
 2022-02-02  Xan Lopez  
 
 [JSC] Remove compiler warning in TrailingArray.h


Modified: trunk/Source/WTF/wtf/PlatformHave.h (289072 => 289073)

--- trunk/Source/WTF/wtf/PlatformHave.h	2022-02-03 21:23:17 UTC (rev 289072)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2022-02-03 21:30:22 UTC (rev 289073)
@@ -1173,8 +1173,3 @@
 #if ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 150400)
 #define HAVE_UIACTIVITYTYPE_SHAREPLAY 1
 #endif
-
-#if ((PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 13) \
-|| (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 16))
-#define HAVE_APPLE_PUSH_SERVICE_URL_TOKEN_SUPPORT 1
-#endif


Modified: trunk/Source/WebKit/ChangeLog (289072 => 289073)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 21:23:17 UTC (rev 289072)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 21:30:22 UTC (rev 289073)
@@ -1,3 +1,15 @@
+2022-02-03  Robert Jenner  
+
+Unreviewed, reverting r288902.
+
+Broke compile-webkit for iOS-15-Simulator
+
+Reverted changeset:
+
+"Import APSConnection-related SPI"
+https://bugs.webkit.org/show_bug.cgi?id=235856
+https://commits.webkit.org/r288902
+
 2022-02-03  Per Arne Vollan  
 
 [iOS][WP] Add access to required syscalls


Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (289072 => 289073)

--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2022-02-03 21:23:17 UTC (rev 289072)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2022-02-03 21:30:22 UTC (rev 289073)
@@ -54,13 +54,6 @@
 WK_ACCESSIBILITY_LDFLAGS_COCOA_TOUCH_NO = $(WK_ACCESSIBILITY_LDFLAGS$(WK_MACOS_1014));
 WK_ACCESSIBILITY_LDFLAGS_MACOS_SINCE_1014 = -weak_library /usr/lib/libAccessibility.dylib;
 
-WK_APPLE_PUSH_SERVICE_LDFLAGS = $(WK_APPLE_PUSH_SERVICE_LDFLAGS_$(WK_PLATFORM_NAME));
-WK_APPLE_PUSH_SERVICE_LDFLAGS_iphoneos = $(WK_APPLE_PUSH_SERVICE_LDFLAGS$(WK_IOS_15));
-WK_APPLE_PUSH_SERVICE_LDFLAGS_iphonesimulator = $(WK_APPLE_PUSH_SERVICE_LDFLAGS$(WK_IOS_15));
-WK_APPLE_PUSH_SERVICE_LDFLAGS_IOS_SINCE_15 = -framework ApplePushService;
-WK_APPLE_PUSH_SERVICE_LDFLAGS_macosx = $(WK_APPLE_PUSH_SERVICE_LDFLAGS$(WK_MACOS_1200));
-WK_APPLE_PUSH_SERVICE_LDFLAGS_MACOS_SINCE_1200 = -framework ApplePushService;
-
 WK_APPKIT_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));
 WK_APPKIT_LDFLAGS_macosx = -framework AppKit;
 WK_APPKIT_LDFLAGS_maccatalyst = -framework AppKit;
@@ -162,7 +155,7 @@
 WK_LIBNETWORKEXTENSION_LDFLAGS_macosx = -weak_library /usr/lib/libnetworkextension.dylib;
 WK_LIBNETWORKEXTENSION_LDFLAGS_tvos = ;
 
-FRAMEWORK_AND_LIBRARY_LDFLAGS = -lobjc -framework CFNetwork -framework CoreAudio -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework IOKit -framework IOSurface -framework WebKitLegacy -lnetwork -framework Metal $(WK_ACCESSIBILITY_LDFLAGS) $(WK_APPKIT_LDFLAGS) $(WK_APPLE_PUSH_SERVICE_LDFLAGS) $(WK_BACKBOARD_SERVICES_LDFLAGS) $(WK_RUNNINGBOARD_SERVICES_LDFLAGS) $(WK_AUTHKIT_LDFLAGS) $(WK_CARBON_LDFLAGS) $(WK_CONTACTS_LDFLAGS) $(WK_CORE_PREDICTION_LDFLAGS) $(WK_CORE_SERVICES_LDFLAGS) $(WK_GRAPHICS_SERVICES_LDFLAGS) $(WK_LIBNETWORKEXTENSION_LDFLAGS) $(WK_LIBSANDBOX_LDFLAGS) $(WK_LIBWEBRTC_LDFLAGS) $(WK_MOBILE_CORE_SERVICES_LDFLAGS) $(WK_MOBILE_GESTALT_LDFLAGS) $(WK_PDFKIT_LDFLAGS) $(WK_PROTOTYPE_TOOLS_LDFLAGS)

[webkit-changes] [289072] trunk/Source/WebKit

2022-02-03 Thread pvollan

Title: [289072] trunk/Source/WebKit








Revision 289072
Author pvol...@apple.com
Date 2022-02-03 13:23:17 -0800 (Thu, 03 Feb 2022)


Log Message
[iOS][WP] Add access to required syscalls
https://bugs.webkit.org/show_bug.cgi?id=236087


Reviewed by Brent Fulgham.

Add access to required syscalls which are rarely used. This is based on recent telemetry.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (289071 => 289072)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 21:06:48 UTC (rev 289071)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 21:23:17 UTC (rev 289072)
@@ -1,5 +1,17 @@
 2022-02-03  Per Arne Vollan  
 
+[iOS][WP] Add access to required syscalls
+https://bugs.webkit.org/show_bug.cgi?id=236087
+
+
+Reviewed by Brent Fulgham.
+
+Add access to required syscalls which are rarely used. This is based on recent telemetry.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
+2022-02-03  Per Arne Vollan  
+
 [iOS][WP] Enable sandbox state rules for Mach messages
 https://bugs.webkit.org/show_bug.cgi?id=236027
 


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (289071 => 289072)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2022-02-03 21:06:48 UTC (rev 289071)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2022-02-03 21:23:17 UTC (rev 289072)
@@ -1321,9 +1321,11 @@
 SYS___pthread_sigmask
 SYS___semwait_signal
 SYS_getattrlistbulk ;; xpc_realpath and directory enumeration
+SYS_iopolicysys
 SYS_open_dprotected_np
 SYS_psynch_rw_wrlock
-SYS_umask))
+SYS_umask
+SYS_work_interval_ctl))
 
 (when (defined? 'syscall-unix)
 (deny syscall-unix (with telemetry) (with send-signal SIGKILL))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289071] trunk

2022-02-03 Thread commit-queue

Title: [289071] trunk








Revision 289071
Author commit-qu...@webkit.org
Date 2022-02-03 13:06:48 -0800 (Thu, 03 Feb 2022)


Log Message
ANGLE Metal and ANGLE OpenGL cannot be initialised one after the other
https://bugs.webkit.org/show_bug.cgi?id=236030

Patch by Kimmo Kinnunen  on 2022-02-03
Reviewed by Dean Jackson.

Source/WebCore:

Test: webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html

Remove the power-preference specific native displays.
Add a native display for opengl, and use the default
one for Metal.

After the recent ANGLE roll, ANGLE uses (native display, power preference)
as the key to look up EGLDisplays.

* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::releaseThreadResources):
* platform/graphics/angle/GraphicsContextGLANGLE.h:
* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::initializeEGLDisplay):

LayoutTests:

* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt: Added.
* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
* webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm


Added Paths

trunk/LayoutTests/webgl/pending/conformance2/misc/
trunk/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt
trunk/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html
trunk/LayoutTests/webgl/resources/pending_webgl_test_files/conformance2/misc/
trunk/LayoutTests/webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html




Diff

Modified: trunk/LayoutTests/ChangeLog (289070 => 289071)

--- trunk/LayoutTests/ChangeLog	2022-02-03 21:05:05 UTC (rev 289070)
+++ trunk/LayoutTests/ChangeLog	2022-02-03 21:06:48 UTC (rev 289071)
@@ -1,3 +1,14 @@
+2022-02-03  Kimmo Kinnunen  
+
+ANGLE Metal and ANGLE OpenGL cannot be initialised one after the other
+https://bugs.webkit.org/show_bug.cgi?id=236030
+
+Reviewed by Dean Jackson.
+
+* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt: Added.
+* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
+* webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
+
 2022-02-03  Patrick Griffis  
 
 [Win] Update expectations for failing CSP test


Added: trunk/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt (0 => 289071)

--- trunk/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt	(rev 0)
+++ trunk/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt	2022-02-03 21:06:48 UTC (rev 289071)
@@ -0,0 +1,4 @@
+This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
+
+Test: ../../../resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html?webglVersion=2
+[ PASS ] All tests passed


Added: trunk/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html (0 => 289071)

--- trunk/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html	(rev 0)
+++ trunk/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html	2022-02-03 21:06:48 UTC (rev 289071)
@@ -0,0 +1,17 @@
+
+
+
+
+WebGL Conformance Test Wrapper for webgl2-after-webgl1-bug.html
+
+
+This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
+Test: 
+
+

+ +

Added: trunk/LayoutTests/webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html (0 => 289071)


--- trunk/LayoutTests/webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html	(rev 0)
+++ trunk/LayoutTests/webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html	2022-02-03 21:06:48 UTC (rev 289071)
@@ -0,0 +1,67 @@
+
+
+
+
+
+
+
+WebGL conformance test for WebGL1 and WebGL2 context sequentially
+



[webkit-changes] [289070] releases/WebKitGTK/webkit-2.34/Source/JavaScriptCore


2022-02-03

Thread
aperez

Title: [289070] releases/WebKitGTK/webkit-2.34/Source/_javascript_Core








Revision 289070
Author ape...@igalia.com
Date 2022-02-03 13:05:05 -0800 (Thu, 03 Feb 2022)


Log Message
Merge r287421 - Make DeferredWorkTimer::addPendingWork() return a Ticket.
https://bugs.webkit.org/show_bug.cgi?id=234628
rdar://84260429

Reviewed by Yusuke Suzuki.

1. Make Ticket a unique token instead of the JSObject* target object.
   The Ticket is now a pointer to the TicketData in the pending work list.

2. Instead of taking a Ticket argument, DeferredWorkTimer::addPendingWork() now
   takes a JSObject* `target` argument explicitly, and returns the Ticket for the
   added TicketData instead.

   All the relevant DeferredWorkTimer APIS already take a Ticket as an argument.
   This ensures that addPendingWork() is called before we start doing work with
   these APIs (especially scheduleWorkSoon()).

3. Previously, addPendingWork() will only save one instance of TicketData for
   a given JSObject* key.  With this patch, we'll register a new TicketData
   instance for every call to addPendingWork(), and return a unique Ticket for it.

   This is needed because it may be possible for 2 different clients to call
   addPendingWork() and scheduleWorkSoon() with the same target JSObject* but with
   different sets of dependencies.

   Secondly, even is the both sets of dependencies are identical, a client may
   call addPendingWork() and scheduleWorkSoon() with the same JSObject* target
   more than once because it intended to schedule more than 1 task to run.

   Note that DeferredWorkTimer::doWork() consumes the corresponding TicketData
   (i.e. removes it from the m_pendingTickets list) for each task as it is run.
   To ensure that the dependencies for each task is protected, we'll either need
   to ref count the TicketData for the same target object (and hold off on removing
   it from the list), or we'll need to register a different TicketData instance
   for each task.  Ref counting can solve the second issue above, but does not
   solve the first.  So, this patch goes with the more generic solution to allow
   each task to have its own TicketData instance (and, its own unique Ticket).

4. Previously, if the client cancels pending work, we would remove the TicketData
   immediately from the m_pendingTickets list.  This opens up an opportunity for
   the same TicketData memory to be re-allocated by another client.  This, in turn,
   would make the Ticket token not unique and potentially allow a cancelled ticket
   to be reused before DeferredWorkTimer::doWork() is called.

   This patch changes DeferredWorkTimer::cancelPendingWork() to only clear the
   contents of the TicketData instead.  TicketData::scriptExecutionOwner being
   null is used as an indication that the ticket has been cancelled.  Since the
   TicketData itself is not "freed" yet, all TicketData will remain unique until
   DeferredWorkTimer::doWork().

   Consequently, DeferredWorkTimer::doWork() will now check for cancelled tickets
   and remove them from the m_pendingTickets list.

5. JSFinalizationRegistry was previously calling DeferredWorkTimer::hasPendingWork()
   to check if it has already scheduled a task, so as not to reschedule again until
   after the previously scheduled task has been run.  This does not play nice
   with the new Ticket API, because this hasPendingWork() check needs to be done
   before calling addPendingWork(), and hence, the Ticket is not available yet.

   Fortunately, JSFinalizationRegistry should know if it has already scheduled
   a task itself.  This patch adds a m_hasAlreadyScheduledWork flag to
   JSFinalizationRegistry that can be used for this check instead.

* jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
* runtime/DeferredWorkTimer.cpp:
(JSC::DeferredWorkTimer::TicketData::TicketData):
(JSC::DeferredWorkTimer::TicketData::vm):
(JSC::DeferredWorkTimer::TicketData::cancel):
(JSC::DeferredWorkTimer::doWork):
(JSC::DeferredWorkTimer::addPendingWork):
(JSC::DeferredWorkTimer::hasPendingWork):
(JSC::DeferredWorkTimer::hasDependancyInPendingWork):
(JSC::DeferredWorkTimer::cancelPendingWork):
* runtime/DeferredWorkTimer.h:
(JSC::DeferredWorkTimer::TicketData::target):
* runtime/JSFinalizationRegistry.cpp:
(JSC::JSFinalizationRegistry::finalizeUnconditionally):
* runtime/JSFinalizationRegistry.h:
* wasm/WasmStreamingCompiler.cpp:
(JSC::Wasm::StreamingCompiler::StreamingCompiler):
(JSC::Wasm::StreamingCompiler::~StreamingCompiler):
(JSC::Wasm::StreamingCompiler::didComplete):
(JSC::Wasm::StreamingCompiler::fail):
(JSC::Wasm::StreamingCompiler::cancel):
* wasm/WasmStreamingCompiler.h:
* wasm/js/JSWebAssembly.cpp:
(JSC::JSWebAssembly::webAssemblyModuleValidateAsync):
(JSC::instantiate):
(JSC::compileAndInstantiate):
(JSC::JSWebAssembly::webAssemblyModuleInstantinateAsync):

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/_javascript_Core/jsc.cpp




[webkit-changes] [289069] trunk/Source/WebKit


2022-02-03

Thread
pvollan

Title: [289069] trunk/Source/WebKit








Revision 289069
Author pvol...@apple.com
Date 2022-02-03 12:50:16 -0800 (Thu, 03 Feb 2022)


Log Message
[iOS][WP] Enable sandbox state rules for Mach messages
https://bugs.webkit.org/show_bug.cgi?id=236027


Reviewed by Brent Fulgham.

After  has been fixed, we can enable sandbox state rules for Mach messages.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (289068 => 289069)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 20:29:54 UTC (rev 289068)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 20:50:16 UTC (rev 289069)
@@ -1,3 +1,15 @@
+2022-02-03  Per Arne Vollan  
+
+[iOS][WP] Enable sandbox state rules for Mach messages
+https://bugs.webkit.org/show_bug.cgi?id=236027
+
+
+Reviewed by Brent Fulgham.
+
+After  has been fixed, we can enable sandbox state rules for Mach messages.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
 2022-02-03  Chris Dumez  
 
 Rename NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded()


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (289068 => 289069)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2022-02-03 20:29:54 UTC (rev 289068)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2022-02-03 20:50:16 UTC (rev 289069)
@@ -1645,16 +1645,15 @@
 #endif
 
 #if HAVE(SANDBOX_STATE_FLAGS)
-;; FIXME: enable this when rdar://85931614 is fixed
-;;(with-filter (require-not (state-flag "WebContentProcessLaunched"))
-;;(allow mach-message-send
-;;(kernel-mig-routine-only-in-use-during-launch)))
-;;(with-filter (state-flag "WebContentProcessLaunched")
-;;(allow mach-message-send
-;;(with report)
-;;(with telemetry)
-;;(with message "kernel mig routine used after launch")
-;;(kernel-mig-routine-only-in-use-during-launch)))
+(with-filter (require-not (state-flag "WebContentProcessLaunched"))
+(allow mach-message-send
+(kernel-mig-routine-only-in-use-during-launch)))
+(with-filter (state-flag "WebContentProcessLaunched")
+(allow mach-message-send
+(with report)
+(with telemetry)
+(with message "kernel mig routine used after launch")
+(kernel-mig-routine-only-in-use-during-launch)))
 #endif
 
 (when (defined? 'mach_port_is_connection_for_service)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289068] trunk/LayoutTests


2022-02-03

Thread
pgriffis

Title: [289068] trunk/LayoutTests








Revision 289068
Author pgrif...@igalia.com
Date 2022-02-03 12:29:54 -0800 (Thu, 03 Feb 2022)


Log Message
[Win] Update expectations for failing CSP test
https://bugs.webkit.org/show_bug.cgi?id=236093

Unreviewed expectations update.


* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (289067 => 289068)

--- trunk/LayoutTests/ChangeLog	2022-02-03 20:15:15 UTC (rev 289067)
+++ trunk/LayoutTests/ChangeLog	2022-02-03 20:29:54 UTC (rev 289068)
@@ -1,3 +1,12 @@
+2022-02-03  Patrick Griffis  
+
+[Win] Update expectations for failing CSP test
+https://bugs.webkit.org/show_bug.cgi?id=236093
+
+Unreviewed expectations update.
+
+* platform/win/TestExpectations:
+
 2022-02-03  Frédéric Wang  
 
 null ptr deref in RenderTreeBuilder::Block::attachIgnoringContinuation


Modified: trunk/LayoutTests/platform/win/TestExpectations (289067 => 289068)

--- trunk/LayoutTests/platform/win/TestExpectations	2022-02-03 20:15:15 UTC (rev 289067)
+++ trunk/LayoutTests/platform/win/TestExpectations	2022-02-03 20:29:54 UTC (rev 289068)
@@ -4918,3 +4918,8 @@
 # These tests require platform support.
 fast/text/locale-shaping-2.html [ ImageOnlyFailure ]
 fast/text/locale-shaping-3.html [ ImageOnlyFailure ]
+
+# webkit.org/b/236092 object images don't pass through object-src CSP checks on Windows.
+http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html [ Failure ]
+http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html [ Failure ]
+http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked3.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289067] trunk/Tools


2022-02-03

Thread
Hironori . Fujii

Title: [289067] trunk/Tools








Revision 289067
Author hironori.fu...@sony.com
Date 2022-02-03 12:15:15 -0800 (Thu, 03 Feb 2022)


Log Message
REGRESSION(r288878) webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests tests are failing with Windows Python
https://bugs.webkit.org/show_bug.cgi?id=236043

Reviewed by Jonathan Bedard.

* Scripts/webkitpy/port/base.py:
(Port.relative_test_filename): Normalize filename with
TEST_PATH_SEPARATOR before comparing with layout_tests_dir().

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/base.py




Diff

Modified: trunk/Tools/ChangeLog (289066 => 289067)

--- trunk/Tools/ChangeLog	2022-02-03 19:59:26 UTC (rev 289066)
+++ trunk/Tools/ChangeLog	2022-02-03 20:15:15 UTC (rev 289067)
@@ -1,3 +1,14 @@
+2022-02-03  Fujii Hironori  
+
+REGRESSION(r288878) webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests tests are failing with Windows Python
+https://bugs.webkit.org/show_bug.cgi?id=236043
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/webkitpy/port/base.py:
+(Port.relative_test_filename): Normalize filename with
+TEST_PATH_SEPARATOR before comparing with layout_tests_dir().
+
 2022-02-03  J Pascoe  
 
 [WebAuthn] Allow use of hardware-fixed credentials while using alternate store


Modified: trunk/Tools/Scripts/webkitpy/port/base.py (289066 => 289067)

--- trunk/Tools/Scripts/webkitpy/port/base.py	2022-02-03 19:59:26 UTC (rev 289066)
+++ trunk/Tools/Scripts/webkitpy/port/base.py	2022-02-03 20:15:15 UTC (rev 289067)
@@ -718,8 +718,7 @@
 def relative_test_filename(self, filename):
 """Returns a test_name a relative unix-style path for a filename under the LayoutTests
 directory. Ports may legitimately return abspaths here if no relpath makes sense."""
-# Ports that run on windows need to override this method to deal with
-# filenames with backslashes in them.
+filename = filename.replace(self.host.filesystem.sep, self.TEST_PATH_SEPARATOR)
 if filename.startswith(self.layout_tests_dir()):
 return self.host.filesystem.relpath(filename, self.layout_tests_dir()).replace(self.host.filesystem.sep, self.TEST_PATH_SEPARATOR)
 else:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289066] trunk/Source/bmalloc


2022-02-03

Thread
mikhail

Title: [289066] trunk/Source/bmalloc








Revision 289066
Author mikh...@igalia.com
Date 2022-02-03 11:59:26 -0800 (Thu, 03 Feb 2022)


Log Message
Fix BSD compilation after r289056
https://bugs.webkit.org/show_bug.cgi?id=236086

Unreviewed, fixes missing header in BSD systems.

The include is moved up so it is included in both UNIX and BSD systems,
as adding the include in both #if triggers a code style warning (header
included twice), even though the includes are guarded.


* bmalloc/AvailableMemory.cpp:

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (289065 => 289066)

--- trunk/Source/bmalloc/ChangeLog	2022-02-03 19:50:48 UTC (rev 289065)
+++ trunk/Source/bmalloc/ChangeLog	2022-02-03 19:59:26 UTC (rev 289066)
@@ -1,5 +1,18 @@
 2022-02-03  Mikhail R. Gadelha  
 
+Fix BSD compilation after r289056
+https://bugs.webkit.org/show_bug.cgi?id=236086
+
+Unreviewed, fixes missing header in BSD systems.
+
+The include is moved up so it is included in both UNIX and BSD systems,
+as adding the include in both #if triggers a code style warning (header
+included twice), even though the includes are guarded.
+
+* bmalloc/AvailableMemory.cpp:
+
+2022-02-03  Mikhail R. Gadelha  
+
 Fix undefined behavior when querying linux memory size
 https://bugs.webkit.org/show_bug.cgi?id=228280
 


Modified: trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp (289065 => 289066)

--- trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp	2022-02-03 19:50:48 UTC (rev 289065)
+++ trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp	2022-02-03 19:59:26 UTC (rev 289066)
@@ -44,10 +44,10 @@
 #import 
 #import 
 #elif BOS(UNIX)
+#include 
 #if BOS(LINUX)
 #include 
 #include 
-#include 
 #elif BOS(FREEBSD)
 #include "VMAllocate.h"
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289065] trunk/Source/WebKit


2022-02-03

Thread
cdumez

Title: [289065] trunk/Source/WebKit








Revision 289065
Author cdu...@apple.com
Date 2022-02-03 11:50:48 -0800 (Thu, 03 Feb 2022)


Log Message
Rename NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded()
https://bugs.webkit.org/show_bug.cgi?id=236088

Reviewed by Darin Adler.

Rename NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded() to make it clear it is for the
service worker connection, to avoid confusing with the shared workers.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::serviceWorkerServerToContextConnectionNoLongerNeeded):
(WebKit::NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded): Deleted.
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::connectionIsNoLongerNeeded):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (289064 => 289065)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 19:46:39 UTC (rev 289064)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 19:50:48 UTC (rev 289065)
@@ -1,5 +1,22 @@
 2022-02-03  Chris Dumez  
 
+Rename NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded()
+https://bugs.webkit.org/show_bug.cgi?id=236088
+
+Reviewed by Darin Adler.
+
+Rename NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded() to make it clear it is for the
+service worker connection, to avoid confusing with the shared workers.
+
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+(WebKit::NetworkConnectionToWebProcess::serviceWorkerServerToContextConnectionNoLongerNeeded):
+(WebKit::NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded): Deleted.
+* NetworkProcess/NetworkConnectionToWebProcess.h:
+* NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
+(WebKit::WebSWServerToContextConnection::connectionIsNoLongerNeeded):
+
+2022-02-03  Chris Dumez  
+
 Rename ServiceWorkerInitializationData / ServiceWorkerInformation so they can be reused by shared workers
 https://bugs.webkit.org/show_bug.cgi?id=236089
 


Modified: trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp (289064 => 289065)

--- trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp	2022-02-03 19:46:39 UTC (rev 289064)
+++ trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp	2022-02-03 19:50:48 UTC (rev 289065)
@@ -1223,9 +1223,9 @@
 m_swContextConnection = nullptr;
 }
 
-void NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded()
+void NetworkConnectionToWebProcess::serviceWorkerServerToContextConnectionNoLongerNeeded()
 {
-CONNECTION_RELEASE_LOG(ServiceWorker, "serverToContextConnectionNoLongerNeeded: WebProcess no longer useful for running service workers");
+CONNECTION_RELEASE_LOG(ServiceWorker, "serviceWorkerServerToContextConnectionNoLongerNeeded: WebProcess no longer useful for running service workers");
 m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::ServiceWorkerContextConnectionNoLongerNeeded { webProcessIdentifier() }, 0);
 
 m_swContextConnection = nullptr;


Modified: trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h (289064 => 289065)

--- trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h	2022-02-03 19:46:39 UTC (rev 289064)
+++ trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h	2022-02-03 19:50:48 UTC (rev 289065)
@@ -181,7 +181,7 @@
 void checkProcessLocalPortForActivity(const WebCore::MessagePortIdentifier&, CompletionHandler&&);
 
 #if ENABLE(SERVICE_WORKER)
-void serverToContextConnectionNoLongerNeeded();
+void serviceWorkerServerToContextConnectionNoLongerNeeded();
 WebSWServerConnection* swConnection();
 std::unique_ptr createFetchTask(NetworkResourceLoader&, const WebCore::ResourceRequest&);
 #endif


Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp (289064 => 289065)

--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp	2022-02-03 19:46:39 UTC (rev 289064)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp	2022-02-03 19:50:48 UTC (rev 289065)
@@ -162,7 +162,7 @@
 
 void WebSWServerToContextConnection::connectionIsNoLongerNeeded()
 {
-m_connection.serverToContextConnectionNoLongerNeeded();
+m_connection.serviceWorkerServerToContextConnectionNoLongerNeeded();
 }
 
 void WebSWServerToContextConnection::setThrottleState(bool isThrottleable)










[webkit-changes] [289064] trunk/Source/WebInspectorUI


2022-02-03

Thread
nvasilyev

Title: [289064] trunk/Source/WebInspectorUI








Revision 289064
Author nvasil...@apple.com
Date 2022-02-03 11:46:39 -0800 (Thu, 03 Feb 2022)


Log Message
Web Inspector: [Flexbox] Add setting to guard Flexbox Inspector feature
https://bugs.webkit.org/show_bug.cgi?id=236091


Reviewed by Patrick Angle.

* UserInterface/Base/Setting.js:
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createEngineeringSettingsView):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (289063 => 289064)

--- trunk/Source/WebInspectorUI/ChangeLog	2022-02-03 19:44:54 UTC (rev 289063)
+++ trunk/Source/WebInspectorUI/ChangeLog	2022-02-03 19:46:39 UTC (rev 289064)
@@ -1,3 +1,15 @@
+2022-02-03  Nikita Vasilyev  
+
+Web Inspector: [Flexbox] Add setting to guard Flexbox Inspector feature
+https://bugs.webkit.org/show_bug.cgi?id=236091
+
+
+Reviewed by Patrick Angle.
+
+* UserInterface/Base/Setting.js:
+* UserInterface/Views/SettingsTabContentView.js:
+(WI.SettingsTabContentView.prototype._createEngineeringSettingsView):
+
 2022-02-02  Timothy Hatcher  
 
 Web Inspector: didShowExtensionTab needs to pass the frameID of the tab


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (289063 => 289064)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2022-02-03 19:44:54 UTC (rev 289063)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2022-02-03 19:46:39 UTC (rev 289064)
@@ -239,6 +239,7 @@
 protocolFilterMultiplexingBackendMessages: new WI.Setting("protocol-filter-multiplexing-backend-messages", true),
 
 // Engineering
+engineeringEnableFlexboxInspector: new WI.EngineeringSetting("engineering-enable-flexbox-inspector", false),
 engineeringShowInternalExecutionContexts: new WI.EngineeringSetting("engineering-show-internal-execution-contexts", false),
 engineeringShowInternalScripts: new WI.EngineeringSetting("engineering-show-internal-scripts", false),
 engineeringPauseForInternalScripts: new WI.EngineeringSetting("engineering-pause-for-internal-scripts", false),


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (289063 => 289064)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js	2022-02-03 19:44:54 UTC (rev 289063)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js	2022-02-03 19:46:39 UTC (rev 289064)
@@ -443,6 +443,7 @@
 
 let elementsGroup = engineeringSettingsView.addGroup(WI.unlocalizedString("Elements:"));
 elementsGroup.addSetting(WI.settings.engineeringAllowEditingUserAgentShadowTrees, WI.unlocalizedString("Allow editing UserAgent shadow trees"));
+elementsGroup.addSetting(WI.settings.engineeringEnableFlexboxInspector, WI.unlocalizedString("Enable Flexbox Inspector"));
 
 engineeringSettingsView.addSeparator();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289063] trunk/Source/WebKit


2022-02-03

Thread
cdumez

Title: [289063] trunk/Source/WebKit








Revision 289063
Author cdu...@apple.com
Date 2022-02-03 11:44:54 -0800 (Thu, 03 Feb 2022)


Log Message
Rename ServiceWorkerInitializationData / ServiceWorkerInformation so they can be reused by shared workers
https://bugs.webkit.org/show_bug.cgi?id=236089

Reviewed by Alex Christensen.

* Shared/RemoteWorkerInitializationData.cpp: Renamed from Source/WebKit/Shared/ServiceWorkerInitializationData.cpp.
(WebKit::RemoteWorkerInitializationData::encode const):
(WebKit::RemoteWorkerInitializationData::decode):
* Shared/RemoteWorkerInitializationData.h: Renamed from Source/WebKit/Shared/ServiceWorkerInitializationData.h.
* Sources.txt:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::enableServiceWorkers):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::hasServiceWorkerPageProxy):
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):
* WebProcess/Storage/WebSWContextManagerConnection.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::establishServiceWorkerContextConnectionToNetworkProcess):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/WebProcess.messages.in


Added Paths

trunk/Source/WebKit/Shared/RemoteWorkerInitializationData.cpp
trunk/Source/WebKit/Shared/RemoteWorkerInitializationData.h


Removed Paths

trunk/Source/WebKit/Shared/ServiceWorkerInitializationData.cpp
trunk/Source/WebKit/Shared/ServiceWorkerInitializationData.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (289062 => 289063)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 19:18:09 UTC (rev 289062)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 19:44:54 UTC (rev 289063)
@@ -1,3 +1,28 @@
+2022-02-03  Chris Dumez  
+
+Rename ServiceWorkerInitializationData / ServiceWorkerInformation so they can be reused by shared workers
+https://bugs.webkit.org/show_bug.cgi?id=236089
+
+Reviewed by Alex Christensen.
+
+* Shared/RemoteWorkerInitializationData.cpp: Renamed from Source/WebKit/Shared/ServiceWorkerInitializationData.cpp.
+(WebKit::RemoteWorkerInitializationData::encode const):
+(WebKit::RemoteWorkerInitializationData::decode):
+* Shared/RemoteWorkerInitializationData.h: Renamed from Source/WebKit/Shared/ServiceWorkerInitializationData.h.
+* Sources.txt:
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::enableServiceWorkers):
+* UIProcess/WebProcessProxy.h:
+(WebKit::WebProcessProxy::hasServiceWorkerPageProxy):
+* WebKit.xcodeproj/project.pbxproj:
+* WebProcess/Storage/WebSWContextManagerConnection.cpp:
+(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):
+* WebProcess/Storage/WebSWContextManagerConnection.h:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::establishServiceWorkerContextConnectionToNetworkProcess):
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+
 2022-02-03  Kimmo Kinnunen  
 
 Crash at com.apple.WebKit: WebKit::RemoteLayerBackingStore::display


Copied: trunk/Source/WebKit/Shared/RemoteWorkerInitializationData.cpp (from rev 289062, trunk/Source/WebKit/Shared/ServiceWorkerInitializationData.cpp) (0 => 289063)

--- trunk/Source/WebKit/Shared/RemoteWorkerInitializationData.cpp	(rev 0)
+++ trunk/Source/WebKit/Shared/RemoteWorkerInitializationData.cpp	2022-02-03 19:44:54 UTC (rev 289063)
@@ -0,0 +1,67 @@
+/*
+ * Copyright (C) 2019-2022 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, 



[webkit-changes] [289062] trunk/Source


2022-02-03

Thread
commit-queue

Title: [289062] trunk/Source








Revision 289062
Author commit-qu...@webkit.org
Date 2022-02-03 11:18:09 -0800 (Thu, 03 Feb 2022)


Log Message
Crash at com.apple.WebKit: WebKit::RemoteLayerBackingStore::display
https://bugs.webkit.org/show_bug.cgi?id=236003
Source/WebCore:

Patch by Kimmo Kinnunen  on 2022-02-03
Reviewed by Simon Fraser.

* platform/graphics/GraphicsLayerContentsDisplayDelegate.h:
Add a comment not to call PlatformCALayer::setBackingStoreAttached()

* platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm:
Clear the PlatformCALayer contents in more explicit way.

Source/WebKit:



Patch by Kimmo Kinnunen  on 2022-02-03
Reviewed by Simon Fraser.

Using UI-side compositing, following chain would be the cause a crash:
PlatformCALayerRemote::recursiveBuildTransaction
RemoteLayerBackingStore::display
PlatformCALayer::platformCALayerLayerDisplay
WebProcessGraphicsContextGLCocoa.mm DisplayBufferDisplayDelegate::display
PlatformCALayer::setContents(nullptr)

The nullptr contents happens when the WebGL context does not have
display buffer yet or when the display buffer creation would fail.

Setting empty layer contents would destroy the RemoteLayerBackingStore,
even though the callstack is in process of displaying the layer to the
backing store.

When setting PlatformCALayer contents "empty", clear the backing store instead
of removing the backing store.

Tested by LayoutTests/webgl (under ASAN, ios simulator)

* Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
* WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm:
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::setContents):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayerContentsDisplayDelegate.h
trunk/Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h
trunk/Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm
trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289061 => 289062)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 19:01:24 UTC (rev 289061)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 19:18:09 UTC (rev 289062)
@@ -1,3 +1,16 @@
+2022-02-03  Kimmo Kinnunen  
+
+Crash at com.apple.WebKit: WebKit::RemoteLayerBackingStore::display
+https://bugs.webkit.org/show_bug.cgi?id=236003
+
+Reviewed by Simon Fraser.
+
+* platform/graphics/GraphicsLayerContentsDisplayDelegate.h:
+Add a comment not to call PlatformCALayer::setBackingStoreAttached()
+
+* platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm:
+Clear the PlatformCALayer contents in more explicit way.
+
 2022-02-03  Chris Dumez  
 
 Move and rename ServiceWorkerThreadProxy::setupPageForServiceWorker()


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayerContentsDisplayDelegate.h (289061 => 289062)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayerContentsDisplayDelegate.h	2022-02-03 19:01:24 UTC (rev 289061)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayerContentsDisplayDelegate.h	2022-02-03 19:18:09 UTC (rev 289062)
@@ -45,6 +45,7 @@
 
 #if USE(CA)
 virtual void prepareToDelegateDisplay(PlatformCALayer&);
+// Must not detach the platform layer backing store.
 virtual void display(PlatformCALayer&) = 0;
 virtual GraphicsLayer::CompositingCoordinatesOrientation orientation() const;
 #else


Modified: trunk/Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm (289061 => 289062)

--- trunk/Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm	2022-02-03 19:01:24 UTC (rev 289061)
+++ trunk/Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm	2022-02-03 19:18:09 UTC (rev 289062)
@@ -58,7 +58,7 @@
 if (m_displayBuffer)
 layer.setContents(*m_displayBuffer);
 else
-layer.setContents(nullptr);
+layer.clearContents();
 }
 
 GraphicsLayer::CompositingCoordinatesOrientation orientation() const final


Modified: trunk/Source/WebKit/ChangeLog (289061 => 289062)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 19:01:24 UTC (rev 289061)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 19:18:09 UTC (rev 289062)
@@ -1,3 +1,35 @@
+2022-02-03  Kimmo Kinnunen  
+
+Crash at com.apple.WebKit: WebKit::RemoteLayerBackingStore::display
+https://bugs.webkit.org/show_bug.cgi?id=236003
+
+
+Reviewed by Simon Fraser.
+
+Using UI-side compositing, following chain would be the cause a crash:
+PlatformCALayerRemote::recursiveBuildTransaction
+RemoteLayerBackingStore::display
+PlatformCALayer::platformCALayerLayerDisplay
+WebProcessGraphicsContextGLCocoa.mm 



[webkit-changes] [289061] trunk/Source


2022-02-03

Thread
cdumez

Title: [289061] trunk/Source








Revision 289061
Author cdu...@apple.com
Date 2022-02-03 11:01:24 -0800 (Thu, 03 Feb 2022)


Log Message
Move and rename ServiceWorkerThreadProxy::setupPageForServiceWorker()
https://bugs.webkit.org/show_bug.cgi?id=236085

Reviewed by Darin Adler.

Move and rename ServiceWorkerThreadProxy::setupPageForServiceWorker() so that it can be reused for shared workers.

Source/WebCore:

* page/Page.cpp:
(WebCore::Page::setupForRemoteWorker):
* page/Page.h:
* workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::setupPageForServiceWorker): Deleted.
* workers/service/context/ServiceWorkerThreadProxy.h:

Source/WebKit:

* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289060 => 289061)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 18:46:52 UTC (rev 289060)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 19:01:24 UTC (rev 289061)
@@ -1,3 +1,19 @@
+2022-02-03  Chris Dumez  
+
+Move and rename ServiceWorkerThreadProxy::setupPageForServiceWorker()
+https://bugs.webkit.org/show_bug.cgi?id=236085
+
+Reviewed by Darin Adler.
+
+Move and rename ServiceWorkerThreadProxy::setupPageForServiceWorker() so that it can be reused for shared workers.
+
+* page/Page.cpp:
+(WebCore::Page::setupForRemoteWorker):
+* page/Page.h:
+* workers/service/context/ServiceWorkerThreadProxy.cpp:
+(WebCore::ServiceWorkerThreadProxy::setupPageForServiceWorker): Deleted.
+* workers/service/context/ServiceWorkerThreadProxy.h:
+
 2022-02-03  Frédéric Wang  
 
 null ptr deref in RenderTreeBuilder::Block::attachIgnoringContinuation


Modified: trunk/Source/WebCore/page/Page.cpp (289060 => 289061)

--- trunk/Source/WebCore/page/Page.cpp	2022-02-03 18:46:52 UTC (rev 289060)
+++ trunk/Source/WebCore/page/Page.cpp	2022-02-03 19:01:24 UTC (rev 289061)
@@ -3892,4 +3892,26 @@
 return m_modelPlayerProvider.get();
 }
 
+void Page::setupForRemoteWorker(const URL& scriptURL, const SecurityOriginData& topOrigin, const String& referrerPolicy)
+{
+mainFrame().loader().initForSynthesizedDocument({ });
+auto document = Document::createNonRenderedPlaceholder(mainFrame(), scriptURL);
+document->createDOMWindow();
+
+document->storageBlockingStateDidChange();
+
+auto origin = topOrigin.securityOrigin();
+origin->setStorageBlockingPolicy(settings().storageBlockingPolicy());
+
+auto originAsURL = origin->toURL();
+document->setSiteForCookies(originAsURL);
+document->setFirstPartyForCookies(originAsURL);
+document->setDomainForCachePartition(origin->domainForCachePartition());
+
+if (auto policy = parseReferrerPolicy(referrerPolicy, ReferrerPolicySource::HTTPHeader))
+document->setReferrerPolicy(*policy);
+
+mainFrame().setDocument(WTFMove(document));
+}
+
 } // namespace WebCore


Modified: trunk/Source/WebCore/page/Page.h (289060 => 289061)

--- trunk/Source/WebCore/page/Page.h	2022-02-03 18:46:52 UTC (rev 289060)
+++ trunk/Source/WebCore/page/Page.h	2022-02-03 19:01:24 UTC (rev 289061)
@@ -256,6 +256,8 @@
 WEBCORE_EXPORT static void updateStyleForAllPagesAfterGlobalChangeInEnvironment();
 WEBCORE_EXPORT static void clearPreviousItemFromAllPages(HistoryItem*);
 
+WEBCORE_EXPORT void setupForRemoteWorker(const URL& scriptURL, const SecurityOriginData& topOrigin, const String& referrerPolicy);
+
 void updateStyleAfterChangeInEnvironment();
 
 WEBCORE_EXPORT explicit Page(PageConfiguration&&);


Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp (289060 => 289061)

--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp	2022-02-03 18:46:52 UTC (rev 289060)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp	2022-02-03 19:01:24 UTC (rev 289061)
@@ -51,29 +51,6 @@
 
 namespace WebCore {
 
-void ServiceWorkerThreadProxy::setupPageForServiceWorker(Page& page, const ServiceWorkerContextData& data)
-{
-auto& mainFrame = page.mainFrame();
-mainFrame.loader().initForSynthesizedDocument({ });
-auto document = Document::createNonRenderedPlaceholder(mainFrame, data.scriptURL);
-document->createDOMWindow();
-
-document->storageBlockingStateDidChange();
-
-auto origin = data.registration.key.topOrigin().securityOrigin();
-origin->setStorageBlockingPolicy(page.settings().storageBlockingPolicy());
-
-auto originURL = origin->toURL();
-



[webkit-changes] [289060] trunk


2022-02-03

Thread
ntim

Title: [289060] trunk








Revision 289060
Author n...@apple.com
Date 2022-02-03 10:46:52 -0800 (Thu, 03 Feb 2022)


Log Message
null ptr deref in RenderTreeBuilder::Block::attachIgnoringContinuation
https://bugs.webkit.org/show_bug.cgi?id=234170

Patch by Frédéric Wang  on 2022-02-03
Reviewed by Antti Koivisto.

Source/WebCore:

When an element with "display: contents" is put into the top layer, its computed style for
the display property becomes "block" [1]. However, RenderTreeUpdater::updateElementRenderer
does not manage well this transition. In particular, a null ptr deref happens for some
special configuration involving a . To work around that
issue, always force tearing down renderers when updating an element in the top layer.

[1] https://fullscreen.spec.whatwg.org/#new-stacking-layer

Test: fast/layers/top-layer-display-contents-crash.html

* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateElementRenderer): Always force tearing down renderers
for top layer element.

LayoutTests:

Add regression test.

* fast/css/top-layer-display-contents-crash-expected.txt: Added.
* fast/css/top-layer-display-contents-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp


Added Paths

trunk/LayoutTests/fast/css/top-layer-display-contents-crash-expected.txt
trunk/LayoutTests/fast/css/top-layer-display-contents-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (289059 => 289060)

--- trunk/LayoutTests/ChangeLog	2022-02-03 18:01:45 UTC (rev 289059)
+++ trunk/LayoutTests/ChangeLog	2022-02-03 18:46:52 UTC (rev 289060)
@@ -1,3 +1,15 @@
+2022-02-03  Frédéric Wang  
+
+null ptr deref in RenderTreeBuilder::Block::attachIgnoringContinuation
+https://bugs.webkit.org/show_bug.cgi?id=234170
+
+Reviewed by Antti Koivisto.
+
+Add regression test.
+
+* fast/css/top-layer-display-contents-crash-expected.txt: Added.
+* fast/css/top-layer-display-contents-crash.html: Added.
+
 2022-02-03  Chris Dumez  
 
 Start connecting SharedWorker to the WebKit2 layer


Added: trunk/LayoutTests/fast/css/top-layer-display-contents-crash-expected.txt (0 => 289060)

--- trunk/LayoutTests/fast/css/top-layer-display-contents-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/top-layer-display-contents-crash-expected.txt	2022-02-03 18:46:52 UTC (rev 289060)
@@ -0,0 +1,3 @@
+This test PASS if it does not CRASH.
+
+TEXT_CHILD


Added: trunk/LayoutTests/fast/css/top-layer-display-contents-crash.html (0 => 289060)

--- trunk/LayoutTests/fast/css/top-layer-display-contents-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/css/top-layer-display-contents-crash.html	2022-02-03 18:46:52 UTC (rev 289060)
@@ -0,0 +1,18 @@
+
+  if (testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+  }
+  _onload_ = () => {
+var frame = document.createElement("frame");
+document.body.appendChild(frame);
+iframe.appendChild(frame);
+requestAnimationFrame(() => {
+	dialog.showModal();
+	if (testRunner)
+  testRunner.notifyDone();
+});
+  };
+
+This test PASS if it does not CRASH.
+TEXT_CHILD


Modified: trunk/Source/WebCore/ChangeLog (289059 => 289060)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 18:01:45 UTC (rev 289059)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 18:46:52 UTC (rev 289060)
@@ -1,3 +1,24 @@
+2022-02-03  Frédéric Wang  
+
+null ptr deref in RenderTreeBuilder::Block::attachIgnoringContinuation
+https://bugs.webkit.org/show_bug.cgi?id=234170
+
+Reviewed by Antti Koivisto.
+
+When an element with "display: contents" is put into the top layer, its computed style for
+the display property becomes "block" [1]. However, RenderTreeUpdater::updateElementRenderer
+does not manage well this transition. In particular, a null ptr deref happens for some
+special configuration involving a . To work around that
+issue, always force tearing down renderers when updating an element in the top layer.
+
+[1] https://fullscreen.spec.whatwg.org/#new-stacking-layer
+
+Test: fast/layers/top-layer-display-contents-crash.html
+
+* rendering/updating/RenderTreeUpdater.cpp:
+(WebCore::RenderTreeUpdater::updateElementRenderer): Always force tearing down renderers
+for top layer element.
+
 2022-02-03  Chris Dumez  
 
 Implement AbortSignal.timeout()


Modified: trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp (289059 => 289060)

--- trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp	2022-02-03 18:01:45 UTC (rev 289059)
+++ trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp	2022-02-03 18:46:52 UTC (rev 289060)
@@ -317,7 +317,7 @@
 elementUpdateStyle->addCachedPseudoStyle(RenderStyle::clonePtr(*it.value.style));
 }
 
-bool 



[webkit-changes] [289059] trunk


2022-02-03

Thread
j_pascoe

Title: [289059] trunk








Revision 289059
Author j_pas...@apple.com
Date 2022-02-03 10:01:45 -0800 (Thu, 03 Feb 2022)


Log Message
[WebAuthn] Allow use of hardware-fixed credentials while using alternate store
https://bugs.webkit.org/show_bug.cgi?id=235923
rdar://88102108

Reviewed by Brent Fulgham.

Source/WebKit:

This patch allows use of credentials created before a user started using
the alternate credential store by searching regardless of status when
querying credentials.

Added API test + tested manually.

* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):

Tools:

Add new test for querying credentials created both before and after enabling
alternative credential store.

* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::WebCore::addKeyToKeychain):
(TestWebKitAPI::WebCore::cleanUpKeychain):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (289058 => 289059)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 17:58:13 UTC (rev 289058)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 18:01:45 UTC (rev 289059)
@@ -1,3 +1,21 @@
+2022-02-03  J Pascoe  
+
+[WebAuthn] Allow use of hardware-fixed credentials while using alternate store
+https://bugs.webkit.org/show_bug.cgi?id=235923
+rdar://88102108
+
+Reviewed by Brent Fulgham.
+
+This patch allows use of credentials created before a user started using
+the alternate credential store by searching regardless of status when
+querying credentials.
+
+Added API test + tested manually.
+
+* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
+(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
+
 2022-02-03  Per Arne Vollan  
 
 [iOS][WP] Add file-ioctl telemetry


Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (289058 => 289059)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm	2022-02-03 17:58:13 UTC (rev 289058)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm	2022-02-03 18:01:45 UTC (rev 289059)
@@ -120,19 +120,18 @@
 static std::optional>> getExistingCredentials(const String& rpId)
 {
 // Search Keychain for existing credential matched the RP ID.
-auto query = adoptNS([[NSMutableDictionary alloc] init]);
-[query setDictionary:@{
+NSDictionary *query = @{
 (id)kSecClass: (id)kSecClassKey,
 (id)kSecAttrKeyClass: (id)kSecAttrKeyClassPrivate,
+(id)kSecAttrSynchronizable: (id)kSecAttrSynchronizableAny,
 (id)kSecAttrLabel: rpId,
 (id)kSecReturnAttributes: @YES,
 (id)kSecMatchLimit: (id)kSecMatchLimitAll,
 (id)kSecUseDataProtectionKeychain: @YES
-}];
-updateQueryIfNecessary(query.get());
+};
 
 CFTypeRef attributesArrayRef = nullptr;
-OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query.get(), );
+OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query, );
 if (status && status != errSecItemNotFound)
 return std::nullopt;
 auto retainAttributesArray = adoptCF(attributesArrayRef);
@@ -599,6 +598,7 @@
 NSMutableDictionary *queryDictionary = [@{
 (id)kSecClass: (id)kSecClassKey,
 (id)kSecAttrKeyClass: (id)kSecAttrKeyClassPrivate,
+(id)kSecAttrSynchronizable: (id)kSecAttrSynchronizableAny,
 (id)kSecAttrApplicationLabel: nsCredentialId.get(),
 (id)kSecReturnRef: @YES,
 (id)kSecUseDataProtectionKeychain: @YES
@@ -608,7 +608,6 @@
 queryDictionary[(id)kSecUseAuthenticationContext] = context;
 
 auto query = adoptNS(queryDictionary);
-updateQueryIfNecessary(query.get());
 
 CFTypeRef privateKeyRef = nullptr;
 OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query.get(), );
@@ -633,19 +632,18 @@
 
 // Extra step: update the Keychain item with the same value to update its modification date such that LRU can be used
 // for selectAssertionResponse
-auto query = adoptNS([[NSMutableDictionary alloc] init]);
-[query setDictionary:@{
+NSDictionary *query = @{
 (id)kSecClass: (id)kSecClassKey,
 (id)kSecAttrKeyClass: (id)kSecAttrKeyClassPrivate,
+(id)kSecAttrSynchronizable: (id)kSecAttrSynchronizableAny,
 (id)kSecAttrApplicationLabel: nsCredentialId.get(),
 (id)kSecUseDataProtectionKeychain: @YES
-}];
-updateQueryIfNecessary(query.get());
+};
 
 



[webkit-changes] [289058] trunk


2022-02-03

Thread
cdumez

Title: [289058] trunk








Revision 289058
Author cdu...@apple.com
Date 2022-02-03 09:58:13 -0800 (Thu, 03 Feb 2022)


Log Message
Implement AbortSignal.timeout()
https://bugs.webkit.org/show_bug.cgi?id=236039

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import AbortSignal.timeout() tests from upstream WPT.

* web-platform-tests/dom/abort/AbortSignal.any-expected.txt:
* web-platform-tests/dom/abort/AbortSignal.any.js:
(async_test.t.signal.onabort.t.step_func_done):
(async_test.t.string_appeared_here.signal.onabort.t.step_func):
* web-platform-tests/dom/abort/AbortSignal.any.worker-expected.txt:
* web-platform-tests/dom/abort/abort-signal-timeout-expected.txt: Added.
* web-platform-tests/dom/abort/abort-signal-timeout.html: Added.
* web-platform-tests/dom/abort/w3c-import.log:

Source/WebCore:

Implement the new AbortSignal.timeout() as per:
- https://dom.spec.whatwg.org/#dom-abortsignal-timeout

Test: imported/w3c/web-platform-tests/dom/abort/abort-signal-timeout.html

* bindings/js/JSAbortSignalCustom.cpp:
(WebCore::JSAbortSignalOwner::isReachableFromOpaqueRoots):
* dom/AbortSignal.cpp:
(WebCore::AbortSignal::timeout):
(WebCore::AbortSignal::eventListenersDidChange):
* dom/AbortSignal.h:
* dom/AbortSignal.idl:
* page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
* page/DOMTimer.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any.js
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any.worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSAbortSignalCustom.cpp
trunk/Source/WebCore/dom/AbortSignal.cpp
trunk/Source/WebCore/dom/AbortSignal.h
trunk/Source/WebCore/dom/AbortSignal.idl
trunk/Source/WebCore/page/DOMTimer.cpp
trunk/Source/WebCore/page/DOMTimer.h


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/abort-signal-timeout-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/abort-signal-timeout.html




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289057 => 289058)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-02-03 16:38:40 UTC (rev 289057)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-02-03 17:58:13 UTC (rev 289058)
@@ -1,3 +1,21 @@
+2022-02-03  Chris Dumez  
+
+Implement AbortSignal.timeout()
+https://bugs.webkit.org/show_bug.cgi?id=236039
+
+Reviewed by Darin Adler.
+
+Import AbortSignal.timeout() tests from upstream WPT.
+
+* web-platform-tests/dom/abort/AbortSignal.any-expected.txt:
+* web-platform-tests/dom/abort/AbortSignal.any.js:
+(async_test.t.signal.onabort.t.step_func_done):
+(async_test.t.string_appeared_here.signal.onabort.t.step_func):
+* web-platform-tests/dom/abort/AbortSignal.any.worker-expected.txt:
+* web-platform-tests/dom/abort/abort-signal-timeout-expected.txt: Added.
+* web-platform-tests/dom/abort/abort-signal-timeout.html: Added.
+* web-platform-tests/dom/abort/w3c-import.log:
+
 2022-02-03  Antoine Quint  
 
 Incorrect KeyframesEffect generated for background


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any-expected.txt (289057 => 289058)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any-expected.txt	2022-02-03 16:38:40 UTC (rev 289057)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any-expected.txt	2022-02-03 17:58:13 UTC (rev 289058)
@@ -1,4 +1,7 @@
 
 PASS the AbortSignal.abort() static returns an already aborted signal
 PASS signal returned by AbortSignal.abort() should not fire abort event
+PASS AbortSignal.timeout() returns a non-aborted signal
+PASS Signal returned by AbortSignal.timeout() times out
+PASS AbortSignal timeouts fire in order
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any.js (289057 => 289058)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any.js	2022-02-03 16:38:40 UTC (rev 289057)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/abort/AbortSignal.any.js	2022-02-03 17:58:13 UTC (rev 289058)
@@ -10,3 +10,31 @@
   s._onabort_ = t.unreached_func("abort event handler called");
   t.step_timeout(() => { t.done(); }, 2000);
 }, "signal returned by AbortSignal.abort() should not fire abort event");
+
+test(t => {
+  const signal = AbortSignal.timeout(0);
+  assert_true(signal instanceof AbortSignal, "returned object is an AbortSignal");
+  assert_false(signal.aborted, "returned signal is not already aborted");
+}, "AbortSignal.timeout() returns a non-aborted signal");
+
+async_test(t => {
+  const signal = AbortSignal.timeout(5);
+  signal._onabort_ = 



[webkit-changes] [289057] trunk/Source/WebCore


2022-02-03

Thread
mark . lam

Title: [289057] trunk/Source/WebCore








Revision 289057
Author mark@apple.com
Date 2022-02-03 08:38:40 -0800 (Thu, 03 Feb 2022)


Log Message
Flaky scope.assertNoException() assertion in ~JSExecState when running workers WPT tests
https://bugs.webkit.org/show_bug.cgi?id=235978

Reviewed by Yusuke Suzuki.

Because Web workers can be terminated at any point, it is possible for JSExecState::loadModule()
to get a termination exception, which would incorrectly cause it to assert and crash in debug.
This patch updates the code so that termination exceptions are properly dealt with instead of
crashing.

No new tests, covered by imported/w3c/web-platform-tests/workers that flakily crash in
debug.

* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::reportException):
* bindings/js/JSExecState.h:
(WebCore::JSExecState::call):
(WebCore::JSExecState::evaluate):
(WebCore::JSExecState::profiledCall):
(WebCore::JSExecState::profiledEvaluate):
(WebCore::JSExecState::linkAndEvaluateModule):
(WebCore::JSExecState::~JSExecState):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* workers/WorkerOrWorkletScriptController.cpp:
(WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp
trunk/Source/WebCore/bindings/js/JSExecState.h
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/workers/WorkerOrWorkletScriptController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289056 => 289057)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 15:29:18 UTC (rev 289056)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 16:38:40 UTC (rev 289057)
@@ -1,3 +1,32 @@
+2022-02-03  Mark Lam  
+
+Flaky scope.assertNoException() assertion in ~JSExecState when running workers WPT tests
+https://bugs.webkit.org/show_bug.cgi?id=235978
+
+Reviewed by Yusuke Suzuki.
+
+Because Web workers can be terminated at any point, it is possible for JSExecState::loadModule()
+to get a termination exception, which would incorrectly cause it to assert and crash in debug.
+This patch updates the code so that termination exceptions are properly dealt with instead of
+crashing.
+
+No new tests, covered by imported/w3c/web-platform-tests/workers that flakily crash in
+debug.
+
+* bindings/js/JSDOMExceptionHandling.cpp:
+(WebCore::reportException):
+* bindings/js/JSExecState.h:
+(WebCore::JSExecState::call):
+(WebCore::JSExecState::evaluate):
+(WebCore::JSExecState::profiledCall):
+(WebCore::JSExecState::profiledEvaluate):
+(WebCore::JSExecState::linkAndEvaluateModule):
+(WebCore::JSExecState::~JSExecState):
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::evaluateInWorld):
+* workers/WorkerOrWorkletScriptController.cpp:
+(WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously):
+
 2022-02-03  Chris Dumez  
 
 Start connecting SharedWorker to the WebKit2 layer


Modified: trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp (289056 => 289057)

--- trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp	2022-02-03 15:29:18 UTC (rev 289056)
+++ trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp	2022-02-03 16:38:40 UTC (rev 289057)
@@ -91,12 +91,15 @@
 void reportException(JSGlobalObject* lexicalGlobalObject, JSC::Exception* exception, CachedScript* cachedScript, bool fromModule, ExceptionDetails* exceptionDetails)
 {
 VM& vm = lexicalGlobalObject->vm();
-auto scope = DECLARE_CATCH_SCOPE(vm);
-
 RELEASE_ASSERT(vm.currentThreadIsHoldingAPILock());
 if (vm.isTerminationException(exception))
 return;
 
+// We can declare a CatchScope here because we will clear the exception below if it's
+// not a TerminationException. If it's a TerminationException, it'll remain sticky in
+// the VM, but we have the check above to ensure that we do not re-enter this scope.
+auto scope = DECLARE_CATCH_SCOPE(vm);
+
 ErrorHandlingScope errorScope(lexicalGlobalObject->vm());
 
 auto callStack = Inspector::createScriptCallStackFromException(lexicalGlobalObject, exception);


Modified: trunk/Source/WebCore/bindings/js/JSExecState.h (289056 => 289057)

--- trunk/Source/WebCore/bindings/js/JSExecState.h	2022-02-03 15:29:18 UTC (rev 289056)
+++ trunk/Source/WebCore/bindings/js/JSExecState.h	2022-02-03 16:38:40 UTC (rev 289057)
@@ -51,14 +51,28 @@
 
 static JSC::JSValue call(JSC::JSGlobalObject* lexicalGlobalObject, JSC::JSValue functionObject, const JSC::CallData& callData, JSC::JSValue thisValue, const JSC::ArgList& args, NakedPtr& returnedException)
 {
-JSExecState currentState(lexicalGlobalObject);
-return JSC::call(lexicalGlobalObject, functionObject, callData, thisValue, args, returnedException);
+



[webkit-changes] [289056] trunk/Source/bmalloc


2022-02-03

Thread
mikhail

Title: [289056] trunk/Source/bmalloc








Revision 289056
Author mikh...@igalia.com
Date 2022-02-03 07:29:18 -0800 (Thu, 03 Feb 2022)


Log Message
Fix undefined behavior when querying linux memory size
https://bugs.webkit.org/show_bug.cgi?id=228280

Reviewed by Mark Lam.

When running JSC compiled with the undefined behavior sanitizer enabled in a 32 bits machine:

../../Source/bmalloc/bmalloc/AvailableMemory.cpp:115:60: runtime error:
signed integer overflow: 32839056 * 4096 cannot be represented in type 'long int'

This patch slighly rewrites how the available memory is calculated to
use sysinfo (like it's done for FREEBSD).

* bmalloc/AvailableMemory.cpp:
(bmalloc::LinuxMemory::singleton):
(bmalloc::computeAvailableMemory):
(bmalloc::memoryStatus):

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (289055 => 289056)

--- trunk/Source/bmalloc/ChangeLog	2022-02-03 15:23:40 UTC (rev 289055)
+++ trunk/Source/bmalloc/ChangeLog	2022-02-03 15:29:18 UTC (rev 289056)
@@ -1,3 +1,23 @@
+2022-02-03  Mikhail R. Gadelha  
+
+Fix undefined behavior when querying linux memory size
+https://bugs.webkit.org/show_bug.cgi?id=228280
+
+Reviewed by Mark Lam.
+
+When running JSC compiled with the undefined behavior sanitizer enabled in a 32 bits machine:
+
+../../Source/bmalloc/bmalloc/AvailableMemory.cpp:115:60: runtime error:
+signed integer overflow: 32839056 * 4096 cannot be represented in type 'long int'
+
+This patch slighly rewrites how the available memory is calculated to
+use sysinfo (like it's done for FREEBSD).
+
+* bmalloc/AvailableMemory.cpp:
+(bmalloc::LinuxMemory::singleton):
+(bmalloc::computeAvailableMemory):
+(bmalloc::memoryStatus):
+
 2022-01-31  David Kilzer  
 
 [libpas] get_num_free_bytes_for_each_heap_callback() is called with `arg` pointing to uninitialized stack memory


Modified: trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp (289055 => 289056)

--- trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp	2022-02-03 15:23:40 UTC (rev 289055)
+++ trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp	2022-02-03 15:29:18 UTC (rev 289056)
@@ -47,10 +47,10 @@
 #if BOS(LINUX)
 #include 
 #include 
+#include 
 #elif BOS(FREEBSD)
 #include "VMAllocate.h"
 #include 
-#include 
 #include 
 #include 
 #endif
@@ -107,13 +107,7 @@
 static std::once_flag s_onceFlag;
 std::call_once(s_onceFlag,
 [] {
-long numPages = sysconf(_SC_PHYS_PAGES);
 s_singleton.pageSize = sysconf(_SC_PAGE_SIZE);
-if (numPages == -1 || s_singleton.pageSize == -1)
-s_singleton.availableMemory = availableMemoryGuess;
-else
-s_singleton.availableMemory = numPages * s_singleton.pageSize;
-
 s_singleton.statmFd = open("/proc/self/statm", O_RDONLY | O_CLOEXEC);
 });
 return s_singleton;
@@ -149,8 +143,6 @@
 }
 
 long pageSize { 0 };
-size_t availableMemory { 0 };
-
 int statmFd { -1 };
 };
 #endif
@@ -167,9 +159,7 @@
 // Round up the memory size to a multiple of 128MB because max_mem may not be exactly 512MB
 // (for example) and we have code that depends on those boundaries.
 return ((sizeAccordingToKernel + multiple - 1) / multiple) * multiple;
-#elif BOS(LINUX)
-return LinuxMemory::singleton().availableMemory;
-#elif BOS(FREEBSD)
+#elif BOS(FREEBSD) || BOS(LINUX)
 struct sysinfo info;
 if (!sysinfo())
 return info.totalram * info.mem_unit;
@@ -205,12 +195,9 @@
 size_t memoryFootprint = 0;
 if (KERN_SUCCESS == task_info(mach_task_self(), TASK_VM_INFO, (task_info_t)(), ))
 memoryFootprint = static_cast(vmInfo.phys_footprint);
-
-double percentInUse = static_cast(memoryFootprint) / static_cast(availableMemory());
 #elif BOS(LINUX)
 auto& memory = LinuxMemory::singleton();
 size_t memoryFootprint = memory.footprint();
-double percentInUse = static_cast(memoryFootprint) / static_cast(memory.availableMemory);
 #elif BOS(FREEBSD)
 struct kinfo_proc info;
 size_t infolen = sizeof(info);
@@ -224,10 +211,9 @@
 size_t memoryFootprint = 0;
 if (!sysctl(mib, 4, , , nullptr, 0))
 memoryFootprint = static_cast(info.ki_rssize) * vmPageSize();
+#endif
 
 double percentInUse = static_cast(memoryFootprint) / static_cast(availableMemory());
-#endif
-
 double percentAvailableMemoryInUse = std::min(percentInUse, 1.0);
 return MemoryStatus(memoryFootprint, percentAvailableMemoryInUse);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289055] trunk/Source/WebKit


2022-02-03

Thread
pvollan

Title: [289055] trunk/Source/WebKit








Revision 289055
Author pvol...@apple.com
Date 2022-02-03 07:23:40 -0800 (Thu, 03 Feb 2022)


Log Message
[iOS][WP] Add file-ioctl telemetry
https://bugs.webkit.org/show_bug.cgi?id=236031


Reviewed by Darin Adler.

Add file-ioctl telemetry in the WebContent process on iOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (289054 => 289055)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 15:21:42 UTC (rev 289054)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 15:23:40 UTC (rev 289055)
@@ -1,3 +1,15 @@
+2022-02-03  Per Arne Vollan  
+
+[iOS][WP] Add file-ioctl telemetry
+https://bugs.webkit.org/show_bug.cgi?id=236031
+
+
+Reviewed by Darin Adler.
+
+Add file-ioctl telemetry in the WebContent process on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+
 2022-02-03  Chris Dumez  
 
 Start connecting SharedWorker to the WebKit2 layer


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (289054 => 289055)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2022-02-03 15:21:42 UTC (rev 289054)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in	2022-02-03 15:23:40 UTC (rev 289055)
@@ -377,7 +377,7 @@
   (literal "/dev/random")
   (literal "/dev/urandom"))
 
-(allow file-read* file-write-data file-ioctl
+(allow file-read* file-write-data
(literal "/dev/aes_0")))
 
 (define required-etc-files
@@ -1362,8 +1362,12 @@
 
 ;; restrict to the two ioctl's /dev/aes_0 needs
 (allow file-ioctl (with telemetry)
-   (ioctl-command (_IO "T" 101)) ;; IOAES_GET_INFO
-   (ioctl-command (_IO "T" 102))) ;; IOAES_ENCRYPT_DECRYPT
+(require-all
+(literal "/dev/aes_0")
+(require-any
+(ioctl-command (_IO "T" 101)) ;; IOAES_GET_INFO
+(ioctl-command (_IO "T" 102)) ;; IOAES_ENCRYPT_DECRYPT
+)))
 
 (deny socket-ioctl (with telemetry))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289054] trunk


2022-02-03

Thread
cdumez

Title: [289054] trunk








Revision 289054
Author cdu...@apple.com
Date 2022-02-03 07:21:42 -0800 (Thu, 03 Feb 2022)


Log Message
Start connecting SharedWorker to the WebKit2 layer
https://bugs.webkit.org/show_bug.cgi?id=236052

Reviewed by Darin Adler.

Source/WebCore:

Start connecting SharedWorker to the WebKit2 layer with a provider / connection, similarly to what is done
for service workers.

* Headers.cmake:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* workers/shared/SharedWorker.cpp:
(WebCore::mainThreadConnection):
(WebCore::SharedWorker::create):
* workers/shared/SharedWorkerManager.h:
* workers/shared/SharedWorkerObjectConnection.cpp: Copied from Source/WebCore/workers/shared/SharedWorkerManager.h.
* workers/shared/SharedWorkerObjectConnection.h: Copied from Source/WebCore/workers/shared/SharedWorkerManager.h.
* workers/shared/SharedWorkerProvider.cpp: Copied from Source/WebCore/workers/shared/SharedWorkerManager.h.
(WebCore::SharedWorkerProvider::singleton):
(WebCore::SharedWorkerProvider::setSharedProvider):
* workers/shared/SharedWorkerProvider.h: Copied from Source/WebCore/workers/shared/SharedWorkerManager.h.
(WebCore::SharedWorkerProvider::~SharedWorkerProvider):
* workers/shared/SharedWorkerScriptLoader.h:

Source/WebKit:

Start connecting SharedWorker to the WebKit2 layer with a provider / connection, similarly to what is done
for service workers.

* Sources.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::sharedWorkerConnection):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Storage/WebSharedWorkerObjectConnection.cpp: Copied from Source/WebCore/workers/shared/SharedWorkerManager.h.
(WebKit::WebSharedWorkerObjectConnection::messageSenderConnection const):
(WebKit::WebSharedWorkerObjectConnection::requestSharedWorker):
* WebProcess/Storage/WebSharedWorkerObjectConnection.h: Copied from Source/WebCore/workers/shared/SharedWorkerManager.h.
* WebProcess/Storage/WebSharedWorkerProvider.cpp: Copied from Source/WebCore/workers/shared/SharedWorkerManager.h.
(WebKit::WebSharedWorkerProvider::singleton):
(WebKit::WebSharedWorkerProvider::sharedWorkerConnection):
* WebProcess/Storage/WebSharedWorkerProvider.h: Copied from Source/WebCore/workers/shared/SharedWorkerManager.h.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

LayoutTests:

Skip pure SharedWorkers tests on WK1 since we will only implement this for WebKit2 in the short term.
Land WK1-specific baselines for tests that use SharedWorkers but also cover other things.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/script-src/worker-importscripts.sub-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/script-src/worker-set-timeout.sub-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/offline/appcache/workers/appcache-worker.https-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/Worker_Self_Origin-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/workers-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/workers/abrupt-completion-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/workers/semantics/multiple-workers/001-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/workers/semantics/run-a-worker/003-expected.txt: Added.
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/workers/shared/SharedWorker.cpp
trunk/Source/WebCore/workers/shared/SharedWorkerManager.h
trunk/Source/WebCore/workers/shared/SharedWorkerScriptLoader.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.h
trunk/Source/WebKit/WebProcess/WebProcess.cpp


Added Paths

trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/script-src/
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/script-src/worker-importscripts.sub-expected.txt
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/script-src/worker-set-timeout.sub-expected.txt




[webkit-changes] [289053] trunk/Source/WebKit


2022-02-03

Thread
pvollan

Title: [289053] trunk/Source/WebKit








Revision 289053
Author pvol...@apple.com
Date 2022-02-03 07:19:27 -0800 (Thu, 03 Feb 2022)


Log Message
[iOS][GPUP] Add access to sysctl property
https://bugs.webkit.org/show_bug.cgi?id=235973


Reviewed by Darin Adler.

Add access to required sysctl property "hw.ncpu" in the GPU process on iOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (289052 => 289053)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 15:14:08 UTC (rev 289052)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 15:19:27 UTC (rev 289053)
@@ -1,5 +1,17 @@
 2022-02-03  Per Arne Vollan  
 
+[iOS][GPUP] Add access to sysctl property
+https://bugs.webkit.org/show_bug.cgi?id=235973
+
+
+Reviewed by Darin Adler.
+
+Add access to required sysctl property "hw.ncpu" in the GPU process on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
+2022-02-03  Per Arne Vollan  
+
 [GPUP] Add read access to sysctl properties
 https://bugs.webkit.org/show_bug.cgi?id=236018
 


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (289052 => 289053)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2022-02-03 15:14:08 UTC (rev 289052)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2022-02-03 15:19:27 UTC (rev 289053)
@@ -529,6 +529,7 @@
 "hw.machine"
 "hw.memsize"
 "hw.model"
+"hw.ncpu"
 "hw.pagesize_compat"
 "hw.physicalcpu_max"
 "hw.product" ;; 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289052] trunk/Source/WebKit


2022-02-03

Thread
pvollan

Title: [289052] trunk/Source/WebKit








Revision 289052
Author pvol...@apple.com
Date 2022-02-03 07:14:08 -0800 (Thu, 03 Feb 2022)


Log Message
[GPUP] Add read access to sysctl properties
https://bugs.webkit.org/show_bug.cgi?id=236018


Reviewed by Darin Adler.

Add read access to sysctl properties based on telemetry.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (289051 => 289052)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 14:51:37 UTC (rev 289051)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 15:14:08 UTC (rev 289052)
@@ -1,3 +1,16 @@
+2022-02-03  Per Arne Vollan  
+
+[GPUP] Add read access to sysctl properties
+https://bugs.webkit.org/show_bug.cgi?id=236018
+
+
+Reviewed by Darin Adler.
+
+Add read access to sysctl properties based on telemetry.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
 2022-02-03  Youenn Fablet  
 
 MediaRecorderPrivate should not need to create IOSurfaces


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (289051 => 289052)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2022-02-03 14:51:37 UTC (rev 289051)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2022-02-03 15:14:08 UTC (rev 289052)
@@ -152,17 +152,24 @@
 "hw.l2cachesize"
 "hw.logicalcpu"
 "hw.logicalcpu_max"
+"hw.machine"
 "hw.memsize"
 "hw.model"
 "hw.ncpu"
 "hw.physicalcpu"
 "hw.physicalcpu_max"
+"hw.product"
+"hw.target"
 "hw.vectorunit"
 "kern.hostname"
 "kern.hv_vmm_present"
+"kern.iossupportversion"
 "kern.maxfilesperproc"
 "kern.osproductversion"
-"kern.osrelease")
+"kern.osrelease"
+"kern.ostype"
+"kern.osversion"
+"kern.version")
 (sysctl-name-prefix "hw.optional.") ;; 
 (sysctl-name-prefix "hw.perflevel") ;; 
 )


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (289051 => 289052)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2022-02-03 14:51:37 UTC (rev 289051)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2022-02-03 15:14:08 UTC (rev 289052)
@@ -532,9 +532,11 @@
 "hw.pagesize_compat"
 "hw.physicalcpu_max"
 "hw.product" ;; 
+"kern.bootargs"
 "kern.osproductversion"
 "kern.osvariant_status"
 "kern.secure_kernel"
+"kern.osversion"
 "vm.footprint_suspend"))
 
 (allow iokit-get-properties






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [289051] trunk/Source/WebCore


2022-02-03

Thread
zalan

Title: [289051] trunk/Source/WebCore








Revision 289051
Author za...@apple.com
Date 2022-02-03 06:51:37 -0800 (Thu, 03 Feb 2022)


Log Message
[LFC][IFC] imported/w3c/web-platform-tests/css/css-writing-modes/text-align-vlr* tests are failing
https://bugs.webkit.org/show_bug.cgi?id=236059

Reviewed by Antti Koivisto.

Content (alignment) offset should be flipped for vertical writing mode.

* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::flipLogicalRectToVisualForWritingMode):
(WebCore::Layout::InlineDisplayContentBuilder::movePointHorizontallyForWritingMode const):
* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289050 => 289051)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 14:31:17 UTC (rev 289050)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 14:51:37 UTC (rev 289051)
@@ -1,3 +1,18 @@
+2022-02-03  Alan Bujtas  
+
+[LFC][IFC] imported/w3c/web-platform-tests/css/css-writing-modes/text-align-vlr* tests are failing
+https://bugs.webkit.org/show_bug.cgi?id=236059
+
+Reviewed by Antti Koivisto.
+
+Content (alignment) offset should be flipped for vertical writing mode. 
+
+* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
+(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
+(WebCore::Layout::InlineDisplayContentBuilder::flipLogicalRectToVisualForWritingMode):
+(WebCore::Layout::InlineDisplayContentBuilder::movePointHorizontallyForWritingMode const):
+* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
+
 2022-02-03  Youenn Fablet  
 
 RealtimeIncomingVideoSourceCocoa should not need to create IOSurfaces


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp (289050 => 289051)

--- trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp	2022-02-03 14:31:17 UTC (rev 289050)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp	2022-02-03 14:51:37 UTC (rev 289051)
@@ -327,7 +327,7 @@
 ASSERT(lineContent.inlineBaseDirection == TextDirection::LTR || !hasContent);
 #endif
 auto writingMode = root().style().writingMode();
-auto contentStartInVisualOrder = displayLine.left() + displayLine.contentLeft();
+auto contentStartInVisualOrder = movePointHorizontallyForWritingMode(displayLine.topLeft(), displayLine.contentLeft(), writingMode);
 
 for (auto& lineRun : lineContent.runs) {
 auto& layoutBox = lineRun.layoutBox();
@@ -334,7 +334,7 @@
 
 auto visualRectRelativeToRoot = [&](auto logicalRect) {
 auto visualRect = flipLogicalRectToVisualForWritingMode(logicalRect, writingMode);
-visualRect.moveBy({ contentStartInVisualOrder, displayLine.top() });
+visualRect.moveBy(contentStartInVisualOrder);
 return visualRect;
 };
 
@@ -789,7 +789,7 @@
 case WritingMode::LeftToRight:
 case WritingMode::RightToLeft: {
 // See InlineFormattingGeometry for more info.
-return InlineRect { logicalRect.left(), logicalRect.top(), logicalRect.height(), logicalRect.width() };
+return { logicalRect.left(), logicalRect.top(), logicalRect.height(), logicalRect.width() };
 }
 default:
 ASSERT_NOT_REACHED();
@@ -798,7 +798,26 @@
 return logicalRect;
 }
 
+InlineLayoutPoint InlineDisplayContentBuilder::movePointHorizontallyForWritingMode(const InlineLayoutPoint& logicalPoint, InlineLayoutUnit horizontalOffset, WritingMode writingMode) const
+{
+auto visualPoint = logicalPoint;
+switch (writingMode) {
+case WritingMode::TopToBottom:
+visualPoint.moveBy(FloatPoint { horizontalOffset, { } });
+break;
+case WritingMode::LeftToRight:
+case WritingMode::RightToLeft: {
+visualPoint.moveBy(FloatPoint { { }, horizontalOffset });
+break;
+}
+default:
+ASSERT_NOT_REACHED();
+break;
+}
+return visualPoint;
 }
+
 }
+}
 
 #endif


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h (289050 => 289051)

--- trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h	2022-02-03 14:31:17 UTC (rev 289050)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h	2022-02-03 14:51:37 UTC (rev 289051)
@@ -67,6 +67,8 @@
 void adjustVisualGeometryForDisplayBox(size_t displayBoxNodeIndex, 



[webkit-changes] [289050] trunk/Source/WebKit


2022-02-03

Thread
youenn

Title: [289050] trunk/Source/WebKit








Revision 289050
Author you...@apple.com
Date 2022-02-03 06:31:17 -0800 (Thu, 03 Feb 2022)


Log Message
MediaRecorderPrivate should not need to create IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=235953

Reviewed by Eric Carlson.

Make use of SharedVideoFrameReader and SharedVideoFrameWriter between SampleBufferDisplayLayer and RemoteSampleBufferDisplayLayer.
Covered by existing MediaRecorder tests.

* GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::videoSampleAvailable):
(WebKit::RemoteMediaRecorder::setSharedVideoFrameSemaphore):
(WebKit::RemoteMediaRecorder::setSharedVideoFrameMemory):
* GPUProcess/webrtc/RemoteMediaRecorder.h:
* GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
* SourcesCocoa.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::videoSampleAvailable):
(WebKit::MediaRecorderPrivate::copySharedVideoFrame):
* WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
* WebProcess/GPU/webrtc/MediaRecorderPrivate.mm: Removed.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.h
trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.messages.in
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.h


Removed Paths

trunk/Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (289049 => 289050)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 14:07:43 UTC (rev 289049)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 14:31:17 UTC (rev 289050)
@@ -1,5 +1,29 @@
 2022-02-03  Youenn Fablet  
 
+MediaRecorderPrivate should not need to create IOSurfaces
+https://bugs.webkit.org/show_bug.cgi?id=235953
+
+Reviewed by Eric Carlson.
+
+Make use of SharedVideoFrameReader and SharedVideoFrameWriter between SampleBufferDisplayLayer and RemoteSampleBufferDisplayLayer.
+Covered by existing MediaRecorder tests.
+
+* GPUProcess/webrtc/RemoteMediaRecorder.cpp:
+(WebKit::RemoteMediaRecorder::videoSampleAvailable):
+(WebKit::RemoteMediaRecorder::setSharedVideoFrameSemaphore):
+(WebKit::RemoteMediaRecorder::setSharedVideoFrameMemory):
+* GPUProcess/webrtc/RemoteMediaRecorder.h:
+* GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
+* SourcesCocoa.txt:
+* WebKit.xcodeproj/project.pbxproj:
+* WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
+(WebKit::MediaRecorderPrivate::videoSampleAvailable):
+(WebKit::MediaRecorderPrivate::copySharedVideoFrame):
+* WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
+* WebProcess/GPU/webrtc/MediaRecorderPrivate.mm: Removed.
+
+2022-02-03  Youenn Fablet  
+
 SampleBufferDiplayLayer should not need to create IOSurfaces
 https://bugs.webkit.org/show_bug.cgi?id=235954
 


Modified: trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp (289049 => 289050)

--- trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp	2022-02-03 14:07:43 UTC (rev 289049)
+++ trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp	2022-02-03 14:31:17 UTC (rev 289050)
@@ -33,6 +33,7 @@
 #include "SharedRingBufferStorage.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -87,21 +88,30 @@
 
 void RemoteMediaRecorder::videoSampleAvailable(WebCore::RemoteVideoSample&& remoteSample)
 {
-if (!m_imageTransferSession || m_imageTransferSession->pixelFormat() != remoteSample.videoFormat())
-m_imageTransferSession = ImageTransferSessionVT::create(remoteSample.videoFormat());
+RefPtr sample;
+if (!remoteSample.surface()) {
+auto pixelBuffer = m_sharedVideoFrameReader.read();
+if (!pixelBuffer)
+return;
 
-if (!m_imageTransferSession) {
-ASSERT_NOT_REACHED();
-return;
-}
+sample = MediaSampleAVFObjC::createImageSample(WTFMove(pixelBuffer), remoteSample.rotation(), remoteSample.mirrored());
+sample->setTimestamps(remoteSample.time(), MediaTime { });
+} else {
+if (!m_imageTransferSession || m_imageTransferSession->pixelFormat() != remoteSample.videoFormat())
+m_imageTransferSession = ImageTransferSessionVT::create(remoteSample.videoFormat());
 
-auto sampleBuffer = m_imageTransferSession->createMediaSample(remoteSample);
-if (!sampleBuffer) {
-ASSERT_NOT_REACHED();
-return;
+if (!m_imageTransferSession) {
+ASSERT_NOT_REACHED();
+return;
+}
+
+sample = m_imageTransferSession->createMediaSample(remoteSample);
+if (!sample) {
+ASSERT_NOT_REACHED();
+return;
+}
 }
-
-



[webkit-changes] [289049] trunk


2022-02-03

Thread
youenn

Title: [289049] trunk








Revision 289049
Author you...@apple.com
Date 2022-02-03 06:07:43 -0800 (Thu, 03 Feb 2022)


Log Message
RealtimeIncomingVideoSourceCocoa should not need to create IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=235952

Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/vp8-then-h264.html

* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
Instead of using an IOSurface-based buffer pool, we use a regular memory buffer pool.
A follow-up should probably remove the need to convert YUV420 webrtc video frames to NV12 CVPixelBuffers in RealtimeIncomingVideoSourceCocoa,
so as to leave that to when copying the webrtc video frames into shared memory buffers used for IPC.

LayoutTests:

* webrtc/vp8-then-h264-expected.txt: Added.
* webrtc/vp8-then-h264.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm


Added Paths

trunk/LayoutTests/webrtc/vp8-then-h264-expected.txt
trunk/LayoutTests/webrtc/vp8-then-h264.html




Diff

Modified: trunk/LayoutTests/ChangeLog (289048 => 289049)

--- trunk/LayoutTests/ChangeLog	2022-02-03 14:02:26 UTC (rev 289048)
+++ trunk/LayoutTests/ChangeLog	2022-02-03 14:07:43 UTC (rev 289049)
@@ -1,3 +1,13 @@
+2022-02-03  Youenn Fablet  
+
+RealtimeIncomingVideoSourceCocoa should not need to create IOSurfaces
+https://bugs.webkit.org/show_bug.cgi?id=235952
+
+Reviewed by Eric Carlson.
+
+* webrtc/vp8-then-h264-expected.txt: Added.
+* webrtc/vp8-then-h264.html: Added.
+
 2022-02-03  Martin Robinson  
 
 Transform interpolation should blend between shared transform function primitives


Added: trunk/LayoutTests/webrtc/vp8-then-h264-expected.txt (0 => 289049)

--- trunk/LayoutTests/webrtc/vp8-then-h264-expected.txt	(rev 0)
+++ trunk/LayoutTests/webrtc/vp8-then-h264-expected.txt	2022-02-03 14:07:43 UTC (rev 289049)
@@ -0,0 +1,7 @@
+Video should be running, go to black and running.
+Following, should be a snapshot of the video, a black frame and a snapshot of the video.
+
+
+PASS Setting video exchange with VP8
+PASS Setting exchange with H264 using VP8 decoded stream as input
+


Added: trunk/LayoutTests/webrtc/vp8-then-h264.html (0 => 289049)

--- trunk/LayoutTests/webrtc/vp8-then-h264.html	(rev 0)
+++ trunk/LayoutTests/webrtc/vp8-then-h264.html	2022-02-03 14:07:43 UTC (rev 289049)
@@ -0,0 +1,62 @@
+
+
+
+
+Testing muting video
+
+
+Video should be running, go to black and running.
+Following, should be a snapshot of the video, a black frame and a snapshot of the video.
+
+
+
+
+
+