date:20220223

[webkit-changes] [290414] trunk

2022-02-23 Thread commit-queue

Title: [290414] trunk








Revision 290414
Author commit-qu...@webkit.org
Date 2022-02-23 23:28:49 -0800 (Wed, 23 Feb 2022)


Log Message
Unreviewed, reverting r290284.
https://bugs.webkit.org/show_bug.cgi?id=237131

It is preventing the fuzzer from finding other bugs

Reverted changeset:

"Make input element UA shadow tree creation lazy"
https://bugs.webkit.org/show_bug.cgi?id=236747
https://commits.webkit.org/r290284

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/BaseDateAndTimeInputType.cpp
trunk/Source/WebCore/html/BaseDateAndTimeInputType.h
trunk/Source/WebCore/html/ColorInputType.cpp
trunk/Source/WebCore/html/ColorInputType.h
trunk/Source/WebCore/html/FileInputType.cpp
trunk/Source/WebCore/html/FileInputType.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp
trunk/Source/WebCore/html/HTMLTextAreaElement.h
trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp
trunk/Source/WebCore/html/HTMLTextFormControlElement.h
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h
trunk/Source/WebCore/html/RangeInputType.cpp
trunk/Source/WebCore/html/RangeInputType.h
trunk/Source/WebCore/html/SearchInputType.cpp
trunk/Source/WebCore/html/SearchInputType.h
trunk/Source/WebCore/html/TextFieldInputType.cpp
trunk/Source/WebCore/html/TextFieldInputType.h


Removed Paths

trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-expected.html
trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation.html
trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation.js




Diff

Modified: trunk/LayoutTests/ChangeLog (290413 => 290414)

--- trunk/LayoutTests/ChangeLog	2022-02-24 06:35:55 UTC (rev 290413)
+++ trunk/LayoutTests/ChangeLog	2022-02-24 07:28:49 UTC (rev 290414)
@@ -1,3 +1,16 @@
+2022-02-23  Commit Queue  
+
+Unreviewed, reverting r290284.
+https://bugs.webkit.org/show_bug.cgi?id=237131
+
+It is preventing the fuzzer from finding other bugs
+
+Reverted changeset:
+
+"Make input element UA shadow tree creation lazy"
+https://bugs.webkit.org/show_bug.cgi?id=236747
+https://commits.webkit.org/r290284
+
 2022-02-23  Tim Nguyen  
 
 Use of showModalDialog should appear as a warning in WI console


Deleted: trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-expected.html (290413 => 290414)

--- trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-expected.html	2022-02-24 06:35:55 UTC (rev 290413)
+++ trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-expected.html	2022-02-24 07:28:49 UTC (rev 290414)
@@ -1,6 +0,0 @@
-
-
-
-run({ useParser: true });
-


Deleted: trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation.html (290413 => 290414)

--- trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation.html	2022-02-24 06:35:55 UTC (rev 290413)
+++ trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation.html	2022-02-24 07:28:49 UTC (rev 290414)
@@ -1,6 +0,0 @@
-
-
-
-run({ useParser: false });
-


Deleted: trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation.js (290413 => 290414)

--- trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation.js	2022-02-24 06:35:55 UTC (rev 290413)
+++ trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation.js	2022-02-24 07:28:49 UTC (rev 290414)
@@ -1,57 +0,0 @@
-const types = {
-"color": { value: "#008000" },
-"date": { value: "2022-01-01" },
-"datetime-local": { value: "2022-01-01" },
-"email": { value: "he...@example.com" },
-"file": { },
-"month": { value: "2022-01" },
-"number": { value: "123" },
-"password": { },
-"range": { value: "75" },
-"search": { value: "abc" },
-"telephone": { value: "+613" },
-"text": { value: "abc" },
-"time": { value: "10:00" },
-"url": { value: "https://example.com/" },
-"week": { value: "2022-W1" },
-};
-
-function supportsType(typeName) {
-let e = document.createElement("input");
-e.type = typeName;
-return e.type == typeName;
-}
-
-function makeAndAppendInput(options, typeName, attributes = { }) {
-let span = document.createElement("span");
-document.body.append(span);
-
-if (options.useParser) {
-let tag = `

Modified: trunk/Source/WebCore/ChangeLog (290413 => 290414)

--- trunk/Source/WebCore/ChangeLog	2022-02-24 06:35:55 UTC (rev 290413)
+++ trunk/Source/WebCore/ChangeLog	2022-02-24 07:28:49 UTC (rev 290414)
@@ -1,3 +1,16 @@
+2022-02-23  Commit Queue  
+
+Unreviewed, reverting r290284.
+https://bugs.webkit.org/show_bug.cgi?id=237131
+
+It is preventing the fuzzer from finding other bugs
+
+Reverted changeset:
+
+"Make input element UA shadow tree creation lazy"
+https://bugs.webkit.org/show_bug.cgi?id=236747
+https://commits.webkit.org/r290284
+
 2022-02-23  Tim Nguyen  
 
 Use of showModalDialog should appear as a warning in WI console


Modified: trunk/Source

[webkit-changes] [290413] trunk/Source/WebKit

2022-02-23 Thread commit-queue

Title: [290413] trunk/Source/WebKit








Revision 290413
Author commit-qu...@webkit.org
Date 2022-02-23 22:35:55 -0800 (Wed, 23 Feb 2022)


Log Message
REGRESSION(r290175): Texture upload from video and user media is slower than expected for non-GPUP WebGL
https://bugs.webkit.org/show_bug.cgi?id=237034

Patch by Kimmo Kinnunen  on 2022-02-23
Reviewed by Youenn Fablet.

Add back the code-path to obtain the IOSurface backed CVPixelBuffers directly
via IPC transfer. This is used on macOS where WebGL is in WP.

* GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
(WebKit::RemoteVideoFrameObjectHeap::pixelBuffer):
* GPUProcess/media/RemoteVideoFrameObjectHeap.h:
* GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
* WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:
(WebKit::RemoteVideoFrameProxy::pixelBuffer const):
* WebProcess/GPU/media/RemoteVideoFrameProxy.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h
trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in
trunk/Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (290412 => 290413)

--- trunk/Source/WebKit/ChangeLog	2022-02-24 06:16:30 UTC (rev 290412)
+++ trunk/Source/WebKit/ChangeLog	2022-02-24 06:35:55 UTC (rev 290413)
@@ -1,3 +1,21 @@
+2022-02-23  Kimmo Kinnunen  
+
+REGRESSION(r290175): Texture upload from video and user media is slower than expected for non-GPUP WebGL
+https://bugs.webkit.org/show_bug.cgi?id=237034
+
+Reviewed by Youenn Fablet.
+
+Add back the code-path to obtain the IOSurface backed CVPixelBuffers directly
+via IPC transfer. This is used on macOS where WebGL is in WP.
+
+* GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
+(WebKit::RemoteVideoFrameObjectHeap::pixelBuffer):
+* GPUProcess/media/RemoteVideoFrameObjectHeap.h:
+* GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
+* WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:
+(WebKit::RemoteVideoFrameProxy::pixelBuffer const):
+* WebProcess/GPU/media/RemoteVideoFrameProxy.h:
+
 2022-02-23  Don Olmstead  
 
 Fix !ENABLE(SERVICE_WORKER) build after r290387


Modified: trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp (290412 => 290413)

--- trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp	2022-02-24 06:16:30 UTC (rev 290412)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp	2022-02-24 06:35:55 UTC (rev 290413)
@@ -117,6 +117,28 @@
 }
 m_connection->send(Messages::RemoteVideoFrameObjectHeapProxyProcessor::NewVideoFrameBuffer { identifier }, 0);
 }
+
+void RemoteVideoFrameObjectHeap::pixelBuffer(RemoteVideoFrameReadReference&& read, CompletionHandler)>&& completionHandler)
+{
+auto videoFrame = retire(WTFMove(read), defaultTimeout);
+if (!videoFrame) {
+ASSERT_IS_TESTING_IPC();
+completionHandler(nullptr);
+return;
+}
+RetainPtr pixelBuffer;
+if (is(videoFrame))
+pixelBuffer = downcast(*videoFrame).pixelBuffer();
+else if (is(*videoFrame))
+pixelBuffer = downcast(*videoFrame).pixelBuffer();
+else {
+ASSERT_NOT_REACHED();
+completionHandler(nullptr);
+return;
+}
+completionHandler(pixelBuffer);
+}
+
 #endif
 
 }


Modified: trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h (290412 => 290413)

--- trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h	2022-02-24 06:16:30 UTC (rev 290412)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h	2022-02-24 06:35:55 UTC (rev 290413)
@@ -57,12 +57,15 @@
 
 // IPC::MessageReceiver overrides.
 void didReceiveMessage(IPC::Connection&, IPC::Decoder&) final;
+bool didReceiveSyncMessage(IPC::Connection&, IPC::Decoder&, UniqueRef&) final;
 
 // Messages.
 void releaseVideoFrame(RemoteVideoFrameWriteReference&&);
 #if PLATFORM(COCOA)
 void getVideoFrameBuffer(RemoteVideoFrameReadReference&&);
+void pixelBuffer(RemoteVideoFrameReadReference&&, CompletionHandler)>&&);
 #endif
+inline static Seconds defaultTimeout = 10_s;
 
 GPUConnectionToWebProcess* m_gpuConnectionToWebProcess WTF_GUARDED_BY_CAPABILITY(m_consumeThread);
 const Ref m_connection;


Modified: trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in (290412 => 290413)

--- trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in	2022-02-24 06:16:30 UTC (rev 290412)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in	2022-02-24 06:35:55 UTC (rev 290413)
@@ -24,8 +24,9 @@
 #if ENABLE(GPU_PROCESS) && ENABLE(VIDEO)
 messages -> RemoteVideoFrameObjectHeap NotRefCounted {
 #if PLATFORM(COCOA)
-Ge

[webkit-changes] [290412] trunk

2022-02-23 Thread ntim

Title: [290412] trunk








Revision 290412
Author n...@apple.com
Date 2022-02-23 22:16:30 -0800 (Wed, 23 Feb 2022)


Log Message
Use of showModalDialog should appear as a warning in WI console
https://bugs.webkit.org/show_bug.cgi?id=237046

Reviewed by Devin Rousso.

Source/WebCore:

* page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):

LayoutTests:

Test gardening to take in account new console warning.

* fast/animation/request-animation-frame-during-modal-expected.txt:
* fast/dom/Window/open-window-min-size-expected.txt:
* fast/events/show-modal-dialog-onblur-onfocus-expected.txt:
* http/tests/cookies/document-cookie-after-showModalDialog-expected.txt:
* http/tests/security/navigate-when-restoring-cached-page-expected.txt:
* http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt:
* platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
* platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
* platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
* platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
* platform/wincairo-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
* platform/wincairo-wk1/fast/events/unload-showModalDialog-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt
trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt
trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt
trunk/LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt
trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt
trunk/LayoutTests/http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.cpp


Added Paths

trunk/LayoutTests/platform/mac-wk1/fast/events/
trunk/LayoutTests/platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt
trunk/LayoutTests/platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt
trunk/LayoutTests/platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt
trunk/LayoutTests/platform/wincairo-wk1/fast/
trunk/LayoutTests/platform/wincairo-wk1/fast/events/
trunk/LayoutTests/platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expected.txt
trunk/LayoutTests/platform/wincairo-wk1/fast/events/pagehide-showModalDialog-expected.txt
trunk/LayoutTests/platform/wincairo-wk1/fast/events/unload-showModalDialog-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (290411 => 290412)

--- trunk/LayoutTests/ChangeLog	2022-02-24 03:18:27 UTC (rev 290411)
+++ trunk/LayoutTests/ChangeLog	2022-02-24 06:16:30 UTC (rev 290412)
@@ -1,3 +1,25 @@
+2022-02-23  Tim Nguyen  
+
+Use of showModalDialog should appear as a warning in WI console
+https://bugs.webkit.org/show_bug.cgi?id=237046
+
+Reviewed by Devin Rousso.
+
+Test gardening to take in account new console warning.
+
+* fast/animation/request-animation-frame-during-modal-expected.txt:
+* fast/dom/Window/open-window-min-size-expected.txt:
+* fast/events/show-modal-dialog-onblur-onfocus-expected.txt:
+* http/tests/cookies/document-cookie-after-showModalDialog-expected.txt:
+* http/tests/security/navigate-when-restoring-cached-page-expected.txt:
+* http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt:
+* platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
+* platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
+* platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
+* platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
+* platform/wincairo-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
+* platform/wincairo-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
+
 2022-02-23  Robert Jenner  
 
 [ Mac wk1 Release ] imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html is a constant text failure


Modified: trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt (290411 => 290412)

--- trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt	2022-02-24 03:18:27 UTC (rev 290411)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt	2022-02-24 06:16:30 UTC (rev 290412)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the  element instead.
 Tests that requestAnimationFrame callbacks are not invoked while modal dialogs are displayed.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


Modified: trunk/LayoutTests/fast/dom/Window/open-window-mi

[webkit-changes] [290411] trunk/Source/WebCore

2022-02-23 Thread cdumez

Title: [290411] trunk/Source/WebCore








Revision 290411
Author cdu...@apple.com
Date 2022-02-23 19:18:27 -0800 (Wed, 23 Feb 2022)


Log Message
Modernize / simplify ScrollingStateTree a bit
https://bugs.webkit.org/show_bug.cgi?id=237111

Reviewed by Simon Fraser.

Modernize / simplify ScrollingStateTree a bit.

* page/scrolling/ScrollingStateTree.cpp:
(WebCore::nodeTypeAndParentMatch):
Simplify function body to be on one line and make function static since it doesn't
need an instance.

(WebCore::nodeWasReattachedRecursive):
Make function static since it doesn't need an instance.

(WebCore::ScrollingStateTree::createUnparentedNode):
- Pass a reference instead of pointer

(WebCore::ScrollingStateTree::insertNode):
- Use template deduction for Ref<>
- Drop unnecessarily 0-check for parentID since stateNodeForID(parentID) would have
  returned null and we would have returned early a few lines above.

(WebCore::ScrollingStateTree::unparentNode):
(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):
- Use RefPtr type for protectedNode based on the variable naming. Previously, auto
  would have deduced to a raw pointer.

(WebCore::ScrollingStateTree::detachAndDestroySubtree):
(WebCore::ScrollingStateTree::clear):
Pass more references instead of pointers.

(WebCore::ScrollingStateTree::commit):
use auto and std::exchange() to make the code a bit more concise.

(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
Take a reference in parameter instead of a raw pointer since the pointer couldn't
be null.

(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
- Take a reference in parameter instead of a raw pointer since the pointer couldn't
be null.
- Rename currNode to currentNode per WebKit coding style.

(WebCore::ScrollingStateTree::willRemoveNode):
Take a reference in parameter instead of a raw pointer since the pointer couldn't
be null.

(WebCore::ScrollingStateTree::stateNodeForID const):
Rewrite function in a more concise way by calling HashMap::get() instead of HashMap::find().

(WebCore::reconcileLayerPositionsRecursive):
- Make function static since it doesn't need an instance
- Rename currNode to currentNode per WebKit coding style

(WebCore::ScrollingStateTree::reconcileViewportConstrainedLayerPositions):
Make function a bit more concise by not doing an early return.

(showScrollingStateTree):
Take in a reference instead of a raw pointer.

(WebCore::ScrollingStateTree::nodeTypeAndParentMatch const): Deleted.
(WebCore::ScrollingStateTree::nodeWasReattachedRecursive): Deleted.
(WebCore::ScrollingStateTree::reconcileLayerPositionsRecursive): Deleted.
* page/scrolling/ScrollingStateTree.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp
trunk/Source/WebCore/page/scrolling/ScrollingStateTree.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290410 => 290411)

--- trunk/Source/WebCore/ChangeLog	2022-02-24 02:25:14 UTC (rev 290410)
+++ trunk/Source/WebCore/ChangeLog	2022-02-24 03:18:27 UTC (rev 290411)
@@ -1,3 +1,71 @@
+2022-02-23  Chris Dumez  
+
+Modernize / simplify ScrollingStateTree a bit
+https://bugs.webkit.org/show_bug.cgi?id=237111
+
+Reviewed by Simon Fraser.
+
+Modernize / simplify ScrollingStateTree a bit.
+
+* page/scrolling/ScrollingStateTree.cpp:
+(WebCore::nodeTypeAndParentMatch):
+Simplify function body to be on one line and make function static since it doesn't
+need an instance.
+
+(WebCore::nodeWasReattachedRecursive):
+Make function static since it doesn't need an instance.
+
+(WebCore::ScrollingStateTree::createUnparentedNode):
+- Pass a reference instead of pointer
+
+(WebCore::ScrollingStateTree::insertNode):
+- Use template deduction for Ref<>
+- Drop unnecessarily 0-check for parentID since stateNodeForID(parentID) would have
+  returned null and we would have returned early a few lines above.
+
+(WebCore::ScrollingStateTree::unparentNode):
+(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):
+- Use RefPtr type for protectedNode based on the variable naming. Previously, auto
+  would have deduced to a raw pointer.
+
+(WebCore::ScrollingStateTree::detachAndDestroySubtree):
+(WebCore::ScrollingStateTree::clear):
+Pass more references instead of pointers.
+
+(WebCore::ScrollingStateTree::commit):
+use auto and std::exchange() to make the code a bit more concise.
+
+(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
+Take a reference in parameter instead of a raw pointer since the pointer couldn't
+be null.
+
+(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
+- Take a reference in parameter instead of a raw pointer since the pointer couldn't
+be null.
+- Rename currNode to currentNode per WebKit coding style.
+
+(

[webkit-changes] [290410] tags/Safari-614.1.5.3/

2022-02-23 Thread repstein

Title: [290410] tags/Safari-614.1.5.3/








Revision 290410
Author repst...@apple.com
Date 2022-02-23 18:25:14 -0800 (Wed, 23 Feb 2022)


Log Message
Tag Safari-614.1.5.3.

Added Paths

tags/Safari-614.1.5.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290409] trunk/LayoutTests

2022-02-23 Thread jenner

Title: [290409] trunk/LayoutTests








Revision 290409
Author jen...@apple.com
Date 2022-02-23 18:24:21 -0800 (Wed, 23 Feb 2022)


Log Message
[ Mac wk1 Release ] imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=236126

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290408 => 290409)

--- trunk/LayoutTests/ChangeLog	2022-02-24 01:51:52 UTC (rev 290408)
+++ trunk/LayoutTests/ChangeLog	2022-02-24 02:24:21 UTC (rev 290409)
@@ -1,5 +1,14 @@
 2022-02-23  Robert Jenner  
 
+[ Mac wk1 Release ] imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html is a constant text failure
+https://bugs.webkit.org/show_bug.cgi?id=236126
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
+2022-02-23  Robert Jenner  
+
 Unreviewed, reverting r290351 and r290404.
 
 Broke the build after revert of initial commit (r290348)


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (290408 => 290409)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2022-02-24 01:51:52 UTC (rev 290408)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2022-02-24 02:24:21 UTC (rev 290409)
@@ -1781,3 +1781,5 @@
 http/tests/push-api/subscribe-default-permissions.html [ Skip ]
 http/tests/push-api/subscribe-deny-permissions.html [ Skip ]
 http/tests/push-api/subscribe-grant-permissions.html [ Skip ]
+
+webkit.org/b/236126 imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290408] branches/safari-614.1.5-branch/Source

2022-02-23 Thread repstein

Title: [290408] branches/safari-614.1.5-branch/Source








Revision 290408
Author repst...@apple.com
Date 2022-02-23 17:51:52 -0800 (Wed, 23 Feb 2022)


Log Message
Versioning.

WebKit-7614.1.5.3

Modified Paths

branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (290407 => 290408)

--- branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-24 01:43:16 UTC (rev 290407)
+++ branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-24 01:51:52 UTC (rev 290408)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (290407 => 290408)

--- branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-24 01:43:16 UTC (rev 290407)
+++ branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-24 01:51:52 UTC (rev 290408)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (290407 => 290408)

--- branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-24 01:43:16 UTC (rev 290407)
+++ branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-24 01:51:52 UTC (rev 290408)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig (290407 => 290408)

--- branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-24 01:43:16 UTC (rev 290407)
+++ branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-24 01:51:52 UTC (rev 290408)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (290407 => 290408)

--- branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-24 01:43:16 UTC (rev 290407)
+++ branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-24 01:51:52 UTC (rev 290408)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig (290407 => 290408)

--- branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-24 01:43:16 UTC (rev 290407)
+++ branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-24 01:51:52 UTC (rev 290408)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (290407 => 290408)

--- branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-02-24 01:43:16 UTC (rev 290407)
+++ branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-02-24 01:51:52 UTC (rev 290408)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NAN

[webkit-changes] [290407] trunk/Source/WebKit

2022-02-23 Thread don . olmstead

Title: [290407] trunk/Source/WebKit








Revision 290407
Author don.olmst...@sony.com
Date 2022-02-23 17:43:16 -0800 (Wed, 23 Feb 2022)


Log Message
Fix !ENABLE(SERVICE_WORKER) build after r290387
https://bugs.webkit.org/show_bug.cgi?id=237119

Unreviewed build fix.


* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::establishRemoteWorkerContextConnectionToNetworkProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290406 => 290407)

--- trunk/Source/WebKit/ChangeLog	2022-02-24 01:31:29 UTC (rev 290406)
+++ trunk/Source/WebKit/ChangeLog	2022-02-24 01:43:16 UTC (rev 290407)
@@ -1,3 +1,13 @@
+2022-02-23  Don Olmstead  
+
+Fix !ENABLE(SERVICE_WORKER) build after r290387
+https://bugs.webkit.org/show_bug.cgi?id=237119
+
+Unreviewed build fix.
+
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::establishRemoteWorkerContextConnectionToNetworkProcess):
+
 2022-02-23  Maxim Cournoyer  
 
 [WPE][GTK] Paths should be canonicalized before calling bwrap


Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (290406 => 290407)

--- trunk/Source/WebKit/WebProcess/WebProcess.cpp	2022-02-24 01:31:29 UTC (rev 290406)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp	2022-02-24 01:43:16 UTC (rev 290407)
@@ -1935,8 +1935,10 @@
 auto& ipcConnection = ensureNetworkProcessConnection().connection();
 switch (workerType) {
 case RemoteWorkerType::ServiceWorker:
+#if ENABLE(SERVICE_WORKER)
 SWContextManager::singleton().setConnection(makeUnique(ipcConnection, WTFMove(registrableDomain), serviceWorkerPageIdentifier, pageGroupID, webPageProxyID, pageID, store, WTFMove(initializationData)));
 SWContextManager::singleton().connection()->establishConnection(WTFMove(completionHandler));
+#endif
 break;
 case RemoteWorkerType::SharedWorker:
 SharedWorkerContextManager::singleton().setConnection(makeUnique(ipcConnection, WTFMove(registrableDomain), pageGroupID, webPageProxyID, pageID, store, WTFMove(initializationData)));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290406] trunk

2022-02-23 Thread jenner

Title: [290406] trunk








Revision 290406
Author jen...@apple.com
Date 2022-02-23 17:31:29 -0800 (Wed, 23 Feb 2022)


Log Message
Unreviewed, reverting r290351 and r290404.

Broke the build after revert of initial commit (r290348)
Rebases no longer needed due to revert

Reverted changesets:

"Use of showModalDialog should appear as a warning in WI
console"
https://bugs.webkit.org/show_bug.cgi?id=237046
https://commits.webkit.org/r290351

"Use of showModalDialog should appear as a warning in WI
console"
https://bugs.webkit.org/show_bug.cgi?id=237046
https://commits.webkit.org/r290404

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt
trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt
trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt
trunk/LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt
trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt
trunk/LayoutTests/http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.cpp


Removed Paths

trunk/LayoutTests/platform/mac-wk1/fast/events/
trunk/LayoutTests/platform/wincairo-wk1/fast/




Diff

Modified: trunk/LayoutTests/ChangeLog (290405 => 290406)

--- trunk/LayoutTests/ChangeLog	2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/ChangeLog	2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,5 +1,24 @@
 2022-02-23  Robert Jenner  
 
+Unreviewed, reverting r290351 and r290404.
+
+Broke the build after revert of initial commit (r290348)
+Rebases no longer needed due to revert
+
+Reverted changesets:
+
+"Use of showModalDialog should appear as a warning in WI
+console"
+https://bugs.webkit.org/show_bug.cgi?id=237046
+https://commits.webkit.org/r290351
+
+"Use of showModalDialog should appear as a warning in WI
+console"
+https://bugs.webkit.org/show_bug.cgi?id=237046
+https://commits.webkit.org/r290404
+
+2022-02-23  Robert Jenner  
+
 Use of showModalDialog should appear as a warning in WI console
 https://bugs.webkit.org/show_bug.cgi?id=237046
 


Modified: trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt (290405 => 290406)

--- trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt	2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt	2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the  element instead.
 Tests that requestAnimationFrame callbacks are not invoked while modal dialogs are displayed.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


Modified: trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt (290405 => 290406)

--- trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt	2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt	2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the  element instead.
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt (290405 => 290406)

--- trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt	2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt	2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the  element instead.
 Pop up a modal dialog. Verifies that focus events are not fired while inside the message loop.
 
 


Modified: trunk/LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt (290405 => 290406)

--- trunk/LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt	2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt	2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the  element instead.
 Tests that document.cookie returns the right value after a showModalDialog() call
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


Modified: trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt (290405 => 290406)

--- trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt	2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/http/tests/security/navigate-when-restor

[webkit-changes] [290405] trunk/Source/JavaScriptCore

2022-02-23 Thread ysuzuki

Title: [290405] trunk/Source/_javascript_Core








Revision 290405
Author ysuz...@apple.com
Date 2022-02-23 17:24:20 -0800 (Wed, 23 Feb 2022)


Log Message
[JSC] Adjust thread number for GC throughput
https://bugs.webkit.org/show_bug.cgi?id=237122

Reviewed by Mark Lam.

Adjust numberOfGCMarkers from 4 to 3 to make GC and main thread througput better on M1 macOS.
3 makes sense since there is also a main thread when they are running concurrently to the
main thread.

It offers 1.2% improvement in Speedometer2 in M1Max MBP and 0.4% improvement in M1 MBP.

--
|   subtest| ms  | ms  |  b / a   | pValue (significance using False Discovery Rate) |
--
| Elm-TodoMVC  |107.445000   |102.856667   |0.957296  | 0.00 (significant)   |
| VueJS-TodoMVC|21.571667|21.805000|1.010817  | 0.403054 |
| EmberJS-TodoMVC  |113.32   |111.30   |0.982174  | 0.27 (significant)   |
| BackboneJS-TodoMVC   |39.981667|39.318333|0.983409  | 0.002346 (significant)   |
| Preact-TodoMVC   |15.516667|15.648333|1.008485  | 0.544754 |
| AngularJS-TodoMVC|117.01   |115.346667   |0.985785  | 0.000495 (significant)   |
| Vanilla-ES2015-TodoMVC   |57.79|57.176667|0.989387  | 0.000270 (significant)   |
| Inferno-TodoMVC  |55.275000|53.755000|0.972501  | 0.00 (significant)   |
| Flight-TodoMVC   |53.875000|53.941667|1.001237  | 0.739556 |
| Angular2-TypeScript-TodoMVC  |36.60|36.471667|0.996494  | 0.743761 |
| VanillaJS-TodoMVC|48.058333|47.671667|0.991954  | 0.158193 |
| jQuery-TodoMVC   |203.43   |201.878333   |0.992356  | 0.009271 (significant)   |
| EmberJS-Debug-TodoMVC|325.058333   |319.848333   |0.983972  | 0.03 (significant)   |
| React-TodoMVC|80.53|79.281667|0.984458  | 0.11 (significant)   |
| React-Redux-TodoMVC  |134.738333   |131.801667   |0.978205  | 0.00 (significant)   |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |56.78|56.168333|0.989227  | 0.000514 (significant)   |
--
a mean = 293.86568
b mean = 297.52900
pValue = 0.0266899465
(Bigger means are better.)
1.012 times better
Results ARE significant

* runtime/Options.cpp:
(JSC::overrideDefaults):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (290404 => 290405)

--- trunk/Source/_javascript_Core/ChangeLog	2022-02-24 01:12:17 UTC (rev 290404)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-24 01:24:20 UTC (rev 290405)
@@ -1,3 +1,46 @@
+2022-02-23  Yusuke Suzuki  
+
+[JSC] Adjust thread number for GC throughput
+https://bugs.webkit.org/show_bug.cgi?id=237122
+
+Reviewed by Mark Lam.
+
+Adjust numberOfGCMarkers from 4 to 3 to make GC and main thread througput better on M1 macOS.
+3 makes sense since there is also a main thread when they are running concurrently to the
+main thread.
+
+It offers 1.2% improvement in Speedometer2 in M1Max MBP and 0.4% improvement in M1 MBP.
+
+--
+|   subtest| ms  | ms  |  b / a   | pValue (significance using False Discovery Rate) |
+--
+| Elm-TodoMVC  |107.445000   |102.856667   |0.957296  | 0.00 (significant)   |
+| VueJS-TodoMVC|21.571667|21.805000|1.010817  | 0.403054 |
+| EmberJS-TodoMVC  |113.32   |111.3000

[webkit-changes] [290404] trunk/LayoutTests

2022-02-23 Thread jenner

Title: [290404] trunk/LayoutTests








Revision 290404
Author jen...@apple.com
Date 2022-02-23 17:12:17 -0800 (Wed, 23 Feb 2022)


Log Message
Use of showModalDialog should appear as a warning in WI console
https://bugs.webkit.org/show_bug.cgi?id=237046

Unreviewed test gardening. Rebase for wk1 mac and Windows tests.

* platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
* platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
* platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
* platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
* platform/wincairo-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
* platform/wincairo-wk1/fast/events/unload-showModalDialog-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac-wk1/fast/events/
trunk/LayoutTests/platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt
trunk/LayoutTests/platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt
trunk/LayoutTests/platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt
trunk/LayoutTests/platform/wincairo-wk1/fast/
trunk/LayoutTests/platform/wincairo-wk1/fast/events/
trunk/LayoutTests/platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expected.txt
trunk/LayoutTests/platform/wincairo-wk1/fast/events/pagehide-showModalDialog-expected.txt
trunk/LayoutTests/platform/wincairo-wk1/fast/events/unload-showModalDialog-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (290403 => 290404)

--- trunk/LayoutTests/ChangeLog	2022-02-24 00:52:30 UTC (rev 290403)
+++ trunk/LayoutTests/ChangeLog	2022-02-24 01:12:17 UTC (rev 290404)
@@ -1,3 +1,17 @@
+2022-02-23  Robert Jenner  
+
+Use of showModalDialog should appear as a warning in WI console
+https://bugs.webkit.org/show_bug.cgi?id=237046
+
+Unreviewed test gardening. Rebase for wk1 mac and Windows tests.
+
+* platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
+* platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
+* platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
+* platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
+* platform/wincairo-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
+* platform/wincairo-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
+
 2022-02-23  J Pascoe  
 
 [WebAuthn] Improve error message for missing pubKeyCredParams


Added: trunk/LayoutTests/platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt (0 => 290404)

--- trunk/LayoutTests/platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt	2022-02-24 01:12:17 UTC (rev 290404)
@@ -0,0 +1,7 @@
+CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the  element instead.
+CONSOLE MESSAGE: Use of window.showModalDialog is not allowed while unloading a page.
+This test verifies that prompts are forbidden when leaving a webpage.
+
+Prompts include alert, confirm, prompt, and showModalDialog.
+
+If there is no prompt, the test passed.


Added: trunk/LayoutTests/platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt (0 => 290404)

--- trunk/LayoutTests/platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt	2022-02-24 01:12:17 UTC (rev 290404)
@@ -0,0 +1,7 @@
+CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the  element instead.
+CONSOLE MESSAGE: Use of window.showModalDialog is not allowed while unloading a page.
+This test verifies that prompts are forbidden when leaving a webpage.
+
+Prompts include alert, confirm, prompt, and showModalDialog.
+
+If there is no prompt, the test passed.


Added: trunk/LayoutTests/platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt (0 => 290404)

--- trunk/LayoutTests/platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt	2022-02-24 01:12:17 UTC (rev 290404)
@@ -0,0 +1,8 @@
+main frame - has 1 onunload handler(s)
+CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the  element instead.
+CONSOLE MESSAGE: Use of window.showModalDialog is not allowed while unloading a page.
+This test verifies that prompts are forbidden when leaving a webpage.
+
+Prompts include alert, confirm, prompt, and showModalDialog.
+
+If there is no prompt, the test passed.


Added: trunk/LayoutTests/platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expe

[webkit-changes] [290403] tags/Safari-613.1.17.1.7/

2022-02-23 Thread repstein

Title: [290403] tags/Safari-613.1.17.1.7/








Revision 290403
Author repst...@apple.com
Date 2022-02-23 16:52:30 -0800 (Wed, 23 Feb 2022)


Log Message
Tag Safari-613.1.17.1.7.

Added Paths

tags/Safari-613.1.17.1.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290402] tags/Safari-614.1.3.5/

2022-02-23 Thread repstein

Title: [290402] tags/Safari-614.1.3.5/








Revision 290402
Author repst...@apple.com
Date 2022-02-23 16:51:50 -0800 (Wed, 23 Feb 2022)


Log Message
Tag Safari-614.1.3.5.

Added Paths

tags/Safari-614.1.3.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290401] trunk/Source/WebKit

2022-02-23 Thread commit-queue

Title: [290401] trunk/Source/WebKit








Revision 290401
Author commit-qu...@webkit.org
Date 2022-02-23 16:49:22 -0800 (Wed, 23 Feb 2022)


Log Message
[WPE][GTK] Paths should be canonicalized before calling bwrap
https://bugs.webkit.org/show_bug.cgi?id=211131

Patch by Maxim Cournoyer  on 2022-02-23
Reviewed by Michael Catanzaro.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindSymlinksRealPath): Relocate earlier in file,
add a 'bindOption' argument and use FileSystem::realPath instead
of realpath from the standard C library.
(WebKit::bindIfExists): Use the modified above procedure to
canonicalize the source path, and avoid adding bind mounts for
locations under /etc.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290400 => 290401)

--- trunk/Source/WebKit/ChangeLog	2022-02-24 00:47:08 UTC (rev 290400)
+++ trunk/Source/WebKit/ChangeLog	2022-02-24 00:49:22 UTC (rev 290401)
@@ -1,3 +1,18 @@
+2022-02-23  Maxim Cournoyer  
+
+[WPE][GTK] Paths should be canonicalized before calling bwrap
+https://bugs.webkit.org/show_bug.cgi?id=211131
+
+Reviewed by Michael Catanzaro.
+
+* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+(WebKit::bindSymlinksRealPath): Relocate earlier in file,
+add a 'bindOption' argument and use FileSystem::realPath instead
+of realpath from the standard C library.
+(WebKit::bindIfExists): Use the modified above procedure to
+canonicalize the source path, and avoid adding bind mounts for
+locations under /etc.
+
 2022-02-23  Liliana Marie Prikler 
 
 Bubblewrap launcher doesn't bind font locations from XDG_DATA_DIRS


Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (290400 => 290401)

--- trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2022-02-24 00:47:08 UTC (rev 290400)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2022-02-24 00:49:22 UTC (rev 290401)
@@ -27,7 +27,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -165,6 +164,15 @@
 Device,
 };
 
+static void bindSymlinksRealPath(Vector& args, const char* path, const char* bindOption = "--ro-bind")
+{
+WTF::String realPath = FileSystem::realPath(path);
+if (path != realPath) {
+CString rpath = realPath.utf8();
+args.appendVector(Vector({ bindOption, rpath.data(), rpath.data() }));
+}
+}
+
 static void bindIfExists(Vector& args, const char* path, BindFlags bindFlags = BindFlags::ReadOnly)
 {
 if (!path || path[0] == '\0')
@@ -177,7 +185,16 @@
 bindType = "--ro-bind-try";
 else
 bindType = "--bind-try";
-args.appendVector(Vector({ bindType, path, path }));
+
+// Canonicalize the source path, otherwise a symbolic link could
+// point to a location outside of the namespace.
+bindSymlinksRealPath(args, path, bindType);
+
+// As /etc is exposed wholesale, do not layer extraneous bind
+// directives on top, which could fail in the presence of symbolic
+// links.
+if (!g_str_has_prefix(path, "/etc/"))
+args.appendVector(Vector({ bindType, path, path }));
 }
 
 static void bindDBusSession(Vector& args, bool allowPortals)
@@ -415,17 +432,6 @@
 }));
 }
 
-static void bindSymlinksRealPath(Vector& args, const char* path)
-{
-char realPath[PATH_MAX];
-
-if (realpath(path, realPath) && strcmp(path, realPath)) {
-args.appendVector(Vector({
-"--ro-bind", realPath, realPath,
-}));
-}
-}
-
 // Translate a libseccomp error code into an error message. libseccomp
 // mostly returns negative errno values such as -ENOMEM, but some
 // standard errno values are used for non-standard purposes where their






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290400] trunk

2022-02-23 Thread emw

Title: [290400] trunk








Revision 290400
Author e...@apple.com
Date 2022-02-23 16:47:08 -0800 (Wed, 23 Feb 2022)


Log Message
[XCBuild] Don't automatically use the ../Internal/WebKit workspace
https://bugs.webkit.org/show_bug.cgi?id=237115

Reviewed by Alexey Proskuryakov.

When the USE_WORKSPACE=YES Make flag was added in https://commits.webkit.org/246232@main, we
configured Make to automatically use the workspace at ../Internal/WebKit/WebKit.xcworkspace,
if it was available. The idea was to make it easier for workspace builds to automatically
detect dependencies needed by folks at Apple, like WebKitAdditions.

In practice, this has made workspace builds silently rely on code from outside of the WebKit
repo, and it's unintuitive since non-workspace Make builds do not do this.

* Makefile.shared:

Modified Paths

trunk/ChangeLog
trunk/Makefile.shared




Diff

Modified: trunk/ChangeLog (290399 => 290400)

--- trunk/ChangeLog	2022-02-24 00:39:27 UTC (rev 290399)
+++ trunk/ChangeLog	2022-02-24 00:47:08 UTC (rev 290400)
@@ -1,3 +1,20 @@
+2022-02-23  Elliott Williams  
+
+[XCBuild] Don't automatically use the ../Internal/WebKit workspace
+https://bugs.webkit.org/show_bug.cgi?id=237115
+
+Reviewed by Alexey Proskuryakov.
+
+When the USE_WORKSPACE=YES Make flag was added in https://commits.webkit.org/246232@main, we
+configured Make to automatically use the workspace at ../Internal/WebKit/WebKit.xcworkspace,
+if it was available. The idea was to make it easier for workspace builds to automatically
+detect dependencies needed by folks at Apple, like WebKitAdditions.
+
+In practice, this has made workspace builds silently rely on code from outside of the WebKit
+repo, and it's unintuitive since non-workspace Make builds do not do this.
+
+* Makefile.shared:
+
 2022-02-23  W.D. Xiong  
 
 Add wdx's Github username to contributors.json


Modified: trunk/Makefile.shared (290399 => 290400)

--- trunk/Makefile.shared	2022-02-24 00:39:27 UTC (rev 290399)
+++ trunk/Makefile.shared	2022-02-24 00:47:08 UTC (rev 290400)
@@ -5,10 +5,7 @@
 ifeq ($(USE_WORKSPACE),YES)
 SCHEME ?= $(notdir $(CURDIR))
 XCODE_TARGET = -scheme "$(SCHEME)"
-WORKSPACE := $(firstword $(wildcard \
-	$(dir $(lastword $(MAKEFILE_LIST)))../Internal/WebKit/WebKit.xcworkspace \
-	$(dir $(lastword $(MAKEFILE_LIST)))WebKit.xcworkspace \
-	))
+WORKSPACE := $(dir $(lastword $(MAKEFILE_LIST)))WebKit.xcworkspace
 else
 SCHEME =
 endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290399] trunk/Source/WebCore

2022-02-23 Thread jenner

Title: [290399] trunk/Source/WebCore








Revision 290399
Author jen...@apple.com
Date 2022-02-23 16:39:27 -0800 (Wed, 23 Feb 2022)


Log Message
Unreviewed, reverting r290348.

Broke a test, slowing down EWS.

Reverted changeset:

"Create a DOMWindow::printWarningMessage method and start
using it in DOMWindow.cpp"
https://bugs.webkit.org/show_bug.cgi?id=237047
https://commits.webkit.org/r290348

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/DOMWindow.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290398 => 290399)

--- trunk/Source/WebCore/ChangeLog	2022-02-24 00:37:24 UTC (rev 290398)
+++ trunk/Source/WebCore/ChangeLog	2022-02-24 00:39:27 UTC (rev 290399)
@@ -1,3 +1,16 @@
+2022-02-23  Robert Jenner  
+
+Unreviewed, reverting r290348.
+
+Broke a test, slowing down EWS.
+
+Reverted changeset:
+
+"Create a DOMWindow::printWarningMessage method and start
+using it in DOMWindow.cpp"
+https://bugs.webkit.org/show_bug.cgi?id=237047
+https://commits.webkit.org/r290348
+
 2022-02-23  Alan Bujtas  
 
 [IFC][Integration] Flip accumulatedOffset to take writing mode into account when hittesting across formatting contexts.


Modified: trunk/Source/WebCore/page/DOMWindow.cpp (290398 => 290399)

--- trunk/Source/WebCore/page/DOMWindow.cpp	2022-02-24 00:37:24 UTC (rev 290398)
+++ trunk/Source/WebCore/page/DOMWindow.cpp	2022-02-24 00:39:27 UTC (rev 290399)
@@ -1066,7 +1066,7 @@
 return;
 
 if (!(page->openedByDOM() || page->backForward().count() <= 1)) {
-printWarningMessage("Can't close the window since it was not opened by _javascript_"_s);
+console()->addMessage(MessageSource::JS, MessageLevel::Warning, "Can't close the window since it was not opened by _javascript_"_s);
 return;
 }
 
@@ -1874,8 +1874,8 @@
 int DOMWindow::webkitRequestAnimationFrame(Ref&& callback)
 {
 static bool firstTime = true;
-if (firstTime) {
-printWarningMessage("webkitRequestAnimationFrame() is deprecated and will be removed. Please use requestAnimationFrame() instead."_s);
+if (firstTime && document()) {
+document()->addConsoleMessage(MessageSource::JS, MessageLevel::Warning, "webkitRequestAnimationFrame() is deprecated and will be removed. Please use requestAnimationFrame() instead."_s);
 firstTime = false;
 }
 return requestAnimationFrame(WTFMove(callback));
@@ -2110,7 +2110,8 @@
 
 String innerMessage;
 if (!isAllowedToUseDeviceOrientation(innerMessage) || !hasPermissionToReceiveDeviceMotionOrOrientationEvents(innerMessage)) {
-printWarningMessage(makeString("No device orientation events will be fired, reason: ", innerMessage, "."));
+if (RefPtr document = this->document())
+document->addConsoleMessage(MessageSource::JS, MessageLevel::Warning, makeString("No device orientation events will be fired, reason: ", innerMessage, "."));
 return;
 }
 
@@ -2138,7 +2139,8 @@
 String innerMessage;
 if (!isAllowedToUseDeviceMotion(innerMessage) || !hasPermissionToReceiveDeviceMotionOrOrientationEvents(innerMessage)) {
 failedToRegisterDeviceMotionEventListener();
-printWarningMessage(makeString("No device motion events will be fired, reason: ", innerMessage, "."));
+if (RefPtr document = this->document())
+document->addConsoleMessage(MessageSource::JS, MessageLevel::Warning, makeString("No device motion events will be fired, reason: ", innerMessage, "."));
 return;
 }
 
@@ -2426,25 +2428,15 @@
 lockHistory, lockBackForwardList);
 }
 
-void DOMWindow::printConsoleMessage(const String& message, MessageLevel level) const
+void DOMWindow::printErrorMessage(const String& message) const
 {
 if (message.isEmpty())
 return;
 
 if (PageConsoleClient* pageConsole = console())
-pageConsole->addMessage(MessageSource::JS, level, message);
+pageConsole->addMessage(MessageSource::JS, MessageLevel::Error, message);
 }
 
-void DOMWindow::printErrorMessage(const String& message) const
-{
-printConsoleMessage(message, MessageLevel::Error);
-}
-
-void DOMWindow::printWarningMessage(const String& message) const
-{
-printConsoleMessage(message, MessageLevel::Warning);
-}
-
 String DOMWindow::crossDomainAccessErrorMessage(const DOMWindow& activeWindow, IncludeTargetOrigin includeTargetOrigin)
 {
 const URL& activeWindowURL = activeWindow.document()->url();


Modified: trunk/Source/WebCore/page/DOMWindow.h (290398 => 290399)

--- trunk/Source/WebCore/page/DOMWindow.h	2022-02-24 00:37:24 UTC (rev 290398)
+++ trunk/Source/WebCore/page/DOMWindow.h	2022-02-24 00:39:27 UTC (rev 290399)
@@ -440,9 +440,6 @@
 void decrementGamepadEventListenerCount();
 #endif
 
-void printConsoleMessage(const String&, MessageLevel) const;
-void printWarningMessage(const String&) const;
-
 bool m_shouldPrintWhe

[webkit-changes] [290398] branches/safari-613.1.17.1-branch/Source

2022-02-23 Thread repstein

Title: [290398] branches/safari-613.1.17.1-branch/Source








Revision 290398
Author repst...@apple.com
Date 2022-02-23 16:37:24 -0800 (Wed, 23 Feb 2022)


Log Message
Versioning.

WebKit-7613.1.17.1.7

Modified Paths

branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-613.1.17.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.17.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.17.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (290397 => 290398)

--- branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
+++ branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-24 00:37:24 UTC (rev 290398)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (290397 => 290398)

--- branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
+++ branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-24 00:37:24 UTC (rev 290398)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (290397 => 290398)

--- branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
+++ branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-24 00:37:24 UTC (rev 290398)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig (290397 => 290398)

--- branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
+++ branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-24 00:37:24 UTC (rev 290398)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (290397 => 290398)

--- branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
+++ branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-24 00:37:24 UTC (rev 290398)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig (290397 => 290398)

--- branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
+++ branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-24 00:37:24 UTC (rev 290398)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION =

[webkit-changes] [290397] branches/safari-614.1.3-branch/Source

2022-02-23 Thread repstein

Title: [290397] branches/safari-614.1.3-branch/Source








Revision 290397
Author repst...@apple.com
Date 2022-02-23 16:34:42 -0800 (Wed, 23 Feb 2022)


Log Message
Versioning.

WebKit-7614.1.3.5

Modified Paths

branches/safari-614.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-614.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-614.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-614.1.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-614.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-614.1.3-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-614.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-614.1.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-614.1.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-614.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (290396 => 290397)

--- branches/safari-614.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-24 00:21:04 UTC (rev 290396)
+++ branches/safari-614.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (290396 => 290397)

--- branches/safari-614.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-24 00:21:04 UTC (rev 290396)
+++ branches/safari-614.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (290396 => 290397)

--- branches/safari-614.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-24 00:21:04 UTC (rev 290396)
+++ branches/safari-614.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.3-branch/Source/WebCore/Configurations/Version.xcconfig (290396 => 290397)

--- branches/safari-614.1.3-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-24 00:21:04 UTC (rev 290396)
+++ branches/safari-614.1.3-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (290396 => 290397)

--- branches/safari-614.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-24 00:21:04 UTC (rev 290396)
+++ branches/safari-614.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.3-branch/Source/WebGPU/Configurations/Version.xcconfig (290396 => 290397)

--- branches/safari-614.1.3-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-24 00:21:04 UTC (rev 290396)
+++ branches/safari-614.1.3-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (290396 => 290397)

--- branches/safari-614.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-02-24 00:21:04 UTC (rev 290396)
+++ branches/safari-614.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-02-24 00:34:42 UTC (rev 290397)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NAN

[webkit-changes] [290396] trunk/Source/WebCore

2022-02-23 Thread zalan

Title: [290396] trunk/Source/WebCore








Revision 290396
Author za...@apple.com
Date 2022-02-23 16:21:04 -0800 (Wed, 23 Feb 2022)


Log Message
[IFC][Integration] Flip accumulatedOffset to take writing mode into account when hittesting across formatting contexts.
https://bugs.webkit.org/show_bug.cgi?id=237094

Reviewed by Antti Koivisto.

Both paint and hittest need coord flip (vertical writing mode here) when jumping through formatting context boundaries.

* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::flippedContentOffsetIfNeeded):
(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::hitTest):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (290395 => 290396)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 23:47:27 UTC (rev 290395)
+++ trunk/Source/WebCore/ChangeLog	2022-02-24 00:21:04 UTC (rev 290396)
@@ -1,3 +1,17 @@
+2022-02-23  Alan Bujtas  
+
+[IFC][Integration] Flip accumulatedOffset to take writing mode into account when hittesting across formatting contexts.
+https://bugs.webkit.org/show_bug.cgi?id=237094
+
+Reviewed by Antti Koivisto.
+
+Both paint and hittest need coord flip (vertical writing mode here) when jumping through formatting context boundaries.
+
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::flippedContentOffsetIfNeeded):
+(WebCore::LayoutIntegration::LineLayout::paint):
+(WebCore::LayoutIntegration::LineLayout::hitTest):
+
 2022-02-23  Chris Dumez  
 
 Adopt more widely the new URL constructor that takes in a String


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (290395 => 290396)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-02-23 23:47:27 UTC (rev 290395)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-02-24 00:21:04 UTC (rev 290396)
@@ -657,6 +657,13 @@
 return m_boxTree.rootLayoutBox();
 }
 
+static LayoutPoint flippedContentOffsetIfNeeded(const RenderBlockFlow& root, const RenderBox& childRenderer, LayoutPoint contentOffset)
+{
+if (root.style().isFlippedBlocksWritingMode())
+return root.flipForWritingModeForChild(childRenderer, contentOffset);
+return contentOffset;
+}
+
 void LineLayout::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
 {
 if (!m_inlineContent)
@@ -736,12 +743,8 @@
 
 if (auto& renderer = m_boxTree.rendererForLayoutBox(box.layoutBox()); is(renderer) && renderer.isReplacedOrInlineBlock()) {
 auto& renderBox = downcast(renderer);
-if (!renderBox.hasSelfPaintingLayer() && paintInfo.shouldPaintWithinRoot(renderBox)) {
-auto visualTopLeft = paintOffset;
-if (flow().style().isFlippedBlocksWritingMode())
-visualTopLeft = flow().flipForWritingModeForChild(renderBox, paintOffset);
-renderBox.paintAsInlineBlock(paintInfo, visualTopLeft);
-}
+if (!renderBox.hasSelfPaintingLayer() && paintInfo.shouldPaintWithinRoot(renderBox))
+renderBox.paintAsInlineBlock(paintInfo, flippedContentOffsetIfNeeded(flow(), renderBox, paintOffset));
 }
 }
 
@@ -768,7 +771,7 @@
 continue;
 
 if (box.isAtomicInlineLevelBox()) {
-if (renderer.hitTest(request, result, locationInContainer, accumulatedOffset))
+if (renderer.hitTest(request, result, locationInContainer, flippedContentOffsetIfNeeded(flow(), downcast(renderer), accumulatedOffset)))
 return true;
 continue;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290395] trunk/Source/WebKit

2022-02-23 Thread commit-queue

Title: [290395] trunk/Source/WebKit








Revision 290395
Author commit-qu...@webkit.org
Date 2022-02-23 15:47:27 -0800 (Wed, 23 Feb 2022)


Log Message
Bubblewrap launcher doesn't bind font locations from XDG_DATA_DIRS
https://bugs.webkit.org/show_bug.cgi?id=237089

Patch by Liliana Marie Prikler  on 2022-02-23
Reviewed by Michael Catanzaro.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindFonts): Expose font directories present in the
XDG_DATA_DIRS environment variable.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290394 => 290395)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 23:18:34 UTC (rev 290394)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 23:47:27 UTC (rev 290395)
@@ -1,3 +1,14 @@
+2022-02-23  Liliana Marie Prikler 
+
+Bubblewrap launcher doesn't bind font locations from XDG_DATA_DIRS
+https://bugs.webkit.org/show_bug.cgi?id=237089
+
+Reviewed by Michael Catanzaro.
+
+* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+(WebKit::bindFonts): Expose font directories present in the
+XDG_DATA_DIRS environment variable.
+
 2022-02-23  Chris Dumez  
 
 Adopt more widely the new URL constructor that takes in a String


Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (290394 => 290395)

--- trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2022-02-23 23:18:34 UTC (rev 290394)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2022-02-23 23:47:27 UTC (rev 290395)
@@ -288,6 +288,7 @@
 const char* homeDir = g_get_home_dir();
 const char* dataDir = g_get_user_data_dir();
 const char* cacheDir = g_get_user_cache_dir();
+const char* const * dataDirs = g_get_system_data_dirs();
 
 // Configs can include custom dirs but then we have to parse them...
 GUniquePtr fontConfig(g_build_filename(configDir, "fontconfig", nullptr));
@@ -304,6 +305,10 @@
 bindIfExists(args, fontHomeConfigDir.get());
 bindIfExists(args, fontData.get());
 bindIfExists(args, fontHomeData.get());
+for (auto* dataDir = dataDirs; dataDir && *dataDir; dataDir++) {
+GUniquePtr fontDataDir(g_build_filename(*dataDir, "fonts", nullptr));
+bindIfExists(args, fontDataDir.get());
+}
 bindIfExists(args, "/var/cache/fontconfig"); // Used by Debian.
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290393] trunk

2022-02-23 Thread wdx

Title: [290393] trunk








Revision 290393
Author w...@apple.com
Date 2022-02-23 14:45:41 -0800 (Wed, 23 Feb 2022)


Log Message
Add wdx's Github username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237106

Unreviewed.


* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (290392 => 290393)

--- trunk/ChangeLog	2022-02-23 22:33:42 UTC (rev 290392)
+++ trunk/ChangeLog	2022-02-23 22:45:41 UTC (rev 290393)
@@ -1,3 +1,12 @@
+2022-02-23  W.D. Xiong  
+
+Add wdx's Github username to contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=237106
+
+Unreviewed.
+
+* metadata/contributors.json:
+
 2022-02-23  Zan Dobersek  
 
 [GStreamer] Add WebKitDMABufVideoSink


Modified: trunk/metadata/contributors.json (290392 => 290393)

--- trunk/metadata/contributors.json	2022-02-23 22:33:42 UTC (rev 290392)
+++ trunk/metadata/contributors.json	2022-02-23 22:45:41 UTC (rev 290393)
@@ -6717,6 +6717,7 @@
  "w...@apple.com",
  "w_xi...@apple.com"
   ],
+  "github" : "xw",
   "name" : "W.D. Xiong",
   "nicks" : [
  "wdx"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290392] trunk

2022-02-23 Thread j_pascoe

Title: [290392] trunk








Revision 290392
Author j_pas...@apple.com
Date 2022-02-23 14:33:42 -0800 (Wed, 23 Feb 2022)


Log Message
[WebAuthn] Improve error message for missing pubKeyCredParams
https://bugs.webkit.org/show_bug.cgi?id=235421
rdar://87884875

Reviewed by Brent Fulgham.

Source/WebCore:

We have seen confusion from library authors around the language
used in this error not indicating enough information about what
the problem is. This patch adds additional information, useful
to developers seeing this error.

* Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):

LayoutTests:

Update test to reflect new error message.

* http/wpt/webauthn/public-key-credential-create-failure.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure.https.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (290391 => 290392)

--- trunk/LayoutTests/ChangeLog	2022-02-23 21:40:10 UTC (rev 290391)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 22:33:42 UTC (rev 290392)
@@ -1,3 +1,15 @@
+2022-02-23  J Pascoe  
+
+[WebAuthn] Improve error message for missing pubKeyCredParams
+https://bugs.webkit.org/show_bug.cgi?id=235421
+rdar://87884875
+
+Reviewed by Brent Fulgham.
+
+Update test to reflect new error message.
+
+* http/wpt/webauthn/public-key-credential-create-failure.https.html:
+
 2022-02-23  Alan Bujtas  
 
 [Subpixel] imported/w3c/web-platform-tests/css/css-flexbox/auto-margins-001.html fails at certain font sizes


Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure.https.html (290391 => 290392)

--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure.https.html	2022-02-23 21:40:10 UTC (rev 290391)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure.https.html	2022-02-23 22:33:42 UTC (rev 290392)
@@ -68,7 +68,7 @@
 };
 
 return promiseRejects(t, "NotSupportedError",
-navigator.credentials.create(options), "No desired properties of the to be created credential are provided.");
+navigator.credentials.create(options), "Unable to create credential because options.pubKeyCredParams is empty.");
 }, "PublicKeyCredential's [[create]] with an empty pubKeyCredParams");
 
 promise_test(function(t) {


Modified: trunk/Source/WebCore/ChangeLog (290391 => 290392)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 21:40:10 UTC (rev 290391)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 22:33:42 UTC (rev 290392)
@@ -1,3 +1,19 @@
+2022-02-23  J Pascoe  
+
+[WebAuthn] Improve error message for missing pubKeyCredParams
+https://bugs.webkit.org/show_bug.cgi?id=235421
+rdar://87884875
+
+Reviewed by Brent Fulgham.
+
+We have seen confusion from library authors around the language
+used in this error not indicating enough information about what
+the problem is. This patch adds additional information, useful
+to developers seeing this error.
+
+* Modules/webauthn/AuthenticatorCoordinator.cpp:
+(WebCore::AuthenticatorCoordinator::create const):
+
 2022-02-23  Alan Bujtas  
 
 [IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr


Modified: trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp (290391 => 290392)

--- trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp	2022-02-23 21:40:10 UTC (rev 290391)
+++ trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp	2022-02-23 22:33:42 UTC (rev 290392)
@@ -141,7 +141,7 @@
 // Most of the jobs are done by bindings. However, we can't know if the JSValue of options.pubKeyCredParams
 // is empty or not. Return NotSupportedError as long as it is empty.
 if (options.pubKeyCredParams.isEmpty()) {
-promise.reject(Exception { NotSupportedError, "No desired properties of the to be created credential are provided."_s });
+promise.reject(Exception { NotSupportedError, "Unable to create credential because options.pubKeyCredParams is empty."_s });
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290391] tags/Safari-614.1.5.2/

2022-02-23 Thread repstein

Title: [290391] tags/Safari-614.1.5.2/








Revision 290391
Author repst...@apple.com
Date 2022-02-23 13:40:10 -0800 (Wed, 23 Feb 2022)


Log Message
Tag Safari-614.1.5.2.

Added Paths

tags/Safari-614.1.5.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290390] trunk/Source/bmalloc

2022-02-23 Thread basuke . suzuki

Title: [290390] trunk/Source/bmalloc








Revision 290390
Author basuke.suz...@sony.com
Date 2022-02-23 12:59:41 -0800 (Wed, 23 Feb 2022)


Log Message
[libpas] PlayStation uses 16k page size.
https://bugs.webkit.org/show_bug.cgi?id=237096

Reviewed by Yusuke Suzuki.

Match the granule default size to system page size for our platform.

* libpas/src/libpas/pas_internal_config.h:

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (290389 => 290390)

--- trunk/Source/bmalloc/ChangeLog	2022-02-23 20:57:36 UTC (rev 290389)
+++ trunk/Source/bmalloc/ChangeLog	2022-02-23 20:59:41 UTC (rev 290390)
@@ -1 +1,12 @@
+2022-02-23  Basuke Suzuki  
+
+[libpas] PlayStation uses 16k page size.
+https://bugs.webkit.org/show_bug.cgi?id=237096
+
+Reviewed by Yusuke Suzuki.
+
+Match the granule default size to system page size for our platform.
+
+* libpas/src/libpas/pas_internal_config.h:
+
 == Rolled over to ChangeLog-2022-02-22 ==


Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h (290389 => 290390)

--- trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h	2022-02-23 20:57:36 UTC (rev 290389)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h	2022-02-23 20:59:41 UTC (rev 290390)
@@ -49,7 +49,7 @@
 #define PAS_MARGE_PAGE_DEFAULT_SHIFT 22
 #define PAS_MARGE_PAGE_DEFAULT_SIZE  ((size_t)1 << PAS_MARGE_PAGE_DEFAULT_SHIFT)
 
-#if PAS_ARM64
+#if PAS_ARM64 || PAS_PLATFORM(PLAYSTATION)
 #define PAS_GRANULE_DEFAULT_SHIFT14
 #else
 #define PAS_GRANULE_DEFAULT_SHIFT12






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290389] trunk/Tools

2022-02-23 Thread wenson_hsieh

Title: [290389] trunk/Tools








Revision 290389
Author wenson_hs...@apple.com
Date 2022-02-23 12:57:36 -0800 (Wed, 23 Feb 2022)


Log Message
REGRESSION (288925?): [iOS] TestWebKitAPI.RequestTextInputContext.TextInteraction_FocusingReadOnlyElementShouldScrollToReveal is failing
https://bugs.webkit.org/show_bug.cgi?id=237069
rdar://89325305

Reviewed by Kate Cheney.

This iOS API test occasionally fails in some test runners in automation, due to `didScroll` still being false at
the end of the test. While I was unable to reproduce (both locally, and using EWS test runners), from code
inspection this test appears to be inherently flaky since the scrolling is triggered via editor state updates
propagated through remote layer tree commits; however, the test only verifies that scrolling occurs after one
IPC round-trip between the web and UI processes (due to the call to `-stringByEvaluatingJavaScript:`).

Since the regression point is suspiciously close to r288925, it's possible that the optimizations introduced in
r288925 removed an extra sync IPC round-trip to the web process and back when requesting an autocorrection
context after element focus, which would make this flakiness easier to reproduce in some configurations.

In any case, one speculative fix for this test is to simply wait for the scrolling to occur, instead of assuming
that it occurs after a single IPC round-trip.

* TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm




Diff

Modified: trunk/Tools/ChangeLog (290388 => 290389)

--- trunk/Tools/ChangeLog	2022-02-23 20:34:08 UTC (rev 290388)
+++ trunk/Tools/ChangeLog	2022-02-23 20:57:36 UTC (rev 290389)
@@ -1,3 +1,27 @@
+2022-02-23  Wenson Hsieh  
+
+REGRESSION (288925?): [iOS] TestWebKitAPI.RequestTextInputContext.TextInteraction_FocusingReadOnlyElementShouldScrollToReveal is failing
+https://bugs.webkit.org/show_bug.cgi?id=237069
+rdar://89325305
+
+Reviewed by Kate Cheney.
+
+This iOS API test occasionally fails in some test runners in automation, due to `didScroll` still being false at
+the end of the test. While I was unable to reproduce (both locally, and using EWS test runners), from code
+inspection this test appears to be inherently flaky since the scrolling is triggered via editor state updates
+propagated through remote layer tree commits; however, the test only verifies that scrolling occurs after one
+IPC round-trip between the web and UI processes (due to the call to `-stringByEvaluatingJavaScript:`).
+
+Since the regression point is suspiciously close to r288925, it's possible that the optimizations introduced in
+r288925 removed an extra sync IPC round-trip to the web process and back when requesting an autocorrection
+context after element focus, which would make this flakiness easier to reproduce in some configurations.
+
+In any case, one speculative fix for this test is to simply wait for the scrolling to occur, instead of assuming
+that it occurs after a single IPC round-trip.
+
+* TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
+(TestWebKitAPI::TEST):
+
 2022-02-23  Jonathan Bedard  
 
 [run-webkit-tests] Catch OSError when sampling


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm (290388 => 290389)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm	2022-02-23 20:34:08 UTC (rev 290388)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm	2022-02-23 20:57:36 UTC (rev 290389)
@@ -664,7 +664,7 @@
 }
 
 EXPECT_WK_STREQ("INPUT", [webView stringByEvaluatingJavaScript:@"document.activeElement.tagName"]);
-EXPECT_TRUE(didScroll);
+TestWebKitAPI::Util::run(&didScroll);
 }
 
 TEST(RequestTextInputContext, TextInteraction_FocusElementInDetachedDocument)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290388] trunk/Source/WebCore

2022-02-23 Thread zalan

Title: [290388] trunk/Source/WebCore








Revision 290388
Author za...@apple.com
Date 2022-02-23 12:34:08 -0800 (Wed, 23 Feb 2022)


Log Message
[IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr
https://bugs.webkit.org/show_bug.cgi?id=237090

Reviewed by Antti Koivisto.

* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::firstLinePhysicalBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineLogicalBaseline const):
(WebCore::LayoutIntegration::LineLayout::firstInlineBoxRect const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (290387 => 290388)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 20:12:24 UTC (rev 290387)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 20:34:08 UTC (rev 290388)
@@ -1,3 +1,15 @@
+2022-02-23  Alan Bujtas  
+
+[IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr
+https://bugs.webkit.org/show_bug.cgi?id=237090
+
+Reviewed by Antti Koivisto.
+
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::firstLinePhysicalBaseline const):
+(WebCore::LayoutIntegration::LineLayout::lastLineLogicalBaseline const):
+(WebCore::LayoutIntegration::LineLayout::firstInlineBoxRect const):
+
 2022-02-23  J Pascoe  
 
 Prevent use of PDFKit when using PDF.js


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (290387 => 290388)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-02-23 20:12:24 UTC (rev 290387)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-02-23 20:34:08 UTC (rev 290388)
@@ -441,10 +441,17 @@
 }
 
 auto& firstLine = m_inlineContent->lines.first();
-if (rootLayoutBox().style().isHorizontalWritingMode())
+switch (rootLayoutBox().style().writingMode()) {
+case WritingMode::TopToBottom:
 return LayoutUnit { firstLine.lineBoxTop() + firstLine.baseline() };
-
-return LayoutUnit { firstLine.lineBoxLeft() + (firstLine.lineBoxWidth() - firstLine.baseline()) };
+case WritingMode::LeftToRight:
+return LayoutUnit { firstLine.lineBoxLeft() + (firstLine.lineBoxWidth() - firstLine.baseline()) };
+case WritingMode::RightToLeft:
+return LayoutUnit { firstLine.lineBoxLeft() + firstLine.baseline() };
+default:
+ASSERT_NOT_REACHED();
+return { };
+}
 }
 
 LayoutUnit LineLayout::lastLineLogicalBaseline() const
@@ -455,15 +462,23 @@
 }
 
 auto& lastLine = m_inlineContent->lines.last();
-if (rootLayoutBox().style().isHorizontalWritingMode())
+switch (rootLayoutBox().style().writingMode()) {
+case WritingMode::TopToBottom:
 return LayoutUnit { lastLine.lineBoxTop() + lastLine.baseline() };
+case WritingMode::LeftToRight: {
+// FIXME: We should set the computed height on the root's box geometry (in RenderBlockFlow) so that
+// we could call m_layoutState.geometryForRootBox().borderBoxHeight() instead.
 
-// FIXME: We should set the computed height on the root's box geometry (in RenderBlockFlow) so that
-// we could call m_layoutState.geometryForRootBox().borderBoxHeight() instead.
-
-// Line is always visual coordinates while logicalHeight is not (i.e. this translate to "box visual width" - "line visual right")
-auto lineLogicalTop = flow().logicalHeight() - lastLine.lineBoxRight();
-return LayoutUnit { lineLogicalTop + lastLine.baseline() };
+// Line is always visual coordinates while logicalHeight is not (i.e. this translate to "box visual width" - "line visual right")
+auto lineLogicalTop = flow().logicalHeight() - lastLine.lineBoxRight();
+return LayoutUnit { lineLogicalTop + lastLine.baseline() };
+}
+case WritingMode::RightToLeft:
+return LayoutUnit { lastLine.lineBoxLeft() + lastLine.baseline() };
+default:
+ASSERT_NOT_REACHED();
+return { };
+}
 }
 
 void LineLayout::adjustForPagination()
@@ -572,7 +587,7 @@
 // FIXME: We should be able to flip the display boxes soon after the root block
 // is finished sizing in one go.
 auto firstBoxRect = Layout::toLayoutRect(firstBox->rect());
-switch (flow().style().writingMode()) {
+switch (rootLayoutBox().style().writingMode()) {
 case WritingMode::TopToBottom:
 case WritingMode::LeftToRight:
 return firstBoxRect;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290387] trunk/Source/WebKit

2022-02-23 Thread cdumez

Title: [290387] trunk/Source/WebKit








Revision 290387
Author cdu...@apple.com
Date 2022-02-23 12:12:24 -0800 (Wed, 23 Feb 2022)


Log Message
Share more code between service and shared workers for context connection establishment
https://bugs.webkit.org/show_bug.cgi?id=237085

Reviewed by Youenn Fablet.

Share more code between service and shared workers for context connection establishment.

* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::ensureSWServer):
* NetworkProcess/SharedWorker/WebSharedWorker.cpp:
(WebKit::WebSharedWorker::firstSharedWorkerObjectProcess const):
* NetworkProcess/SharedWorker/WebSharedWorker.h:
* NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
(WebKit::WebSharedWorkerServer::didFinishFetchingSharedWorkerScript):
(WebKit::WebSharedWorkerServer::createContextConnection):
(WebKit::WebSharedWorkerServer::removeContextConnection):
(WebKit::WebSharedWorkerServer::shutDownSharedWorker):
* NetworkProcess/SharedWorker/WebSharedWorkerServer.h:
* NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::NetworkProcessProxy::establishSharedWorkerContextConnectionToNetworkProcess): Deleted.
(WebKit::NetworkProcessProxy::establishServiceWorkerContextConnectionToNetworkProcess): Deleted.
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::establishServiceWorkerContextConnectionToNetworkProcess): Deleted.
(WebKit::WebProcessPool::establishSharedWorkerContextConnectionToNetworkProcess): Deleted.
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::establishRemoteWorkerContext):
(WebKit::WebProcessProxy::establishServiceWorkerContext): Deleted.
(WebKit::WebProcessProxy::establishSharedWorkerContext): Deleted.
* UIProcess/WebProcessProxy.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcess::establishSharedWorkerContextConnectionToNetworkProcess): Deleted.
(WebKit::WebProcess::establishServiceWorkerContextConnectionToNetworkProcess): Deleted.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorker.cpp
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorker.h
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.h
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h
trunk/Source/WebKit/Shared/RemoteWorkerType.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/WebProcess.messages.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (290386 => 290387)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 19:28:20 UTC (rev 290386)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 20:12:24 UTC (rev 290387)
@@ -1,3 +1,47 @@
+2022-02-23  Chris Dumez  
+
+Share more code between service and shared workers for context connection establishment
+https://bugs.webkit.org/show_bug.cgi?id=237085
+
+Reviewed by Youenn Fablet.
+
+Share more code between service and shared workers for context connection establishment.
+
+* NetworkProcess/NetworkSession.cpp:
+(WebKit::NetworkSession::ensureSWServer):
+* NetworkProcess/SharedWorker/WebSharedWorker.cpp:
+(WebKit::WebSharedWorker::firstSharedWorkerObjectProcess const):
+* NetworkProcess/SharedWorker/WebSharedWorker.h:
+* NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
+(WebKit::WebSharedWorkerServer::didFinishFetchingSharedWorkerScript):
+(WebKit::WebSharedWorkerServer::createContextConnection):
+(WebKit::WebSharedWorkerServer::removeContextConnection):
+(WebKit::WebSharedWorkerServer::shutDownSharedWorker):
+* NetworkProcess/SharedWorker/WebSharedWorkerServer.h:
+* NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h:
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::establishRemoteWorkerContextConnectionToNetworkProcess):
+(WebKit::NetworkProcessProxy::establishSh

[webkit-changes] [290386] trunk/LayoutTests

2022-02-23 Thread jenner

Title: [290386] trunk/LayoutTests








Revision 290386
Author jen...@apple.com
Date 2022-02-23 11:28:20 -0800 (Wed, 23 Feb 2022)


Log Message
[ Mac EWS ] imported/w3c/web-platform-tests/workers/semantics/multiple-workers/004.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=237095

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations: Setting [ Pass Failure ] expectations for flaky test failure that is slowing down EWS.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290385 => 290386)

--- trunk/LayoutTests/ChangeLog	2022-02-23 19:26:12 UTC (rev 290385)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 19:28:20 UTC (rev 290386)
@@ -8,6 +8,15 @@
 
 * platform/ios-simulator-wk2/TestExpectations: It must have progressed at some point.
 
+2022-02-23  Robert Jenner  
+
+[ Mac EWS ] imported/w3c/web-platform-tests/workers/semantics/multiple-workers/004.html is a flaky text failure
+https://bugs.webkit.org/show_bug.cgi?id=237095
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations: Setting [ Pass Failure ] expectations for flaky test failure that is slowing down EWS.
+
 2022-02-23  Jon Lee  
 
 Unreviewed gardening for GPU Process bot.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (290385 => 290386)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2022-02-23 19:26:12 UTC (rev 290385)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2022-02-23 19:28:20 UTC (rev 290386)
@@ -1689,3 +1689,5 @@
 
 # Captured WebGL to another context2d or WebGL not implemented yet.
 webkit.org/b/236496 fast/mediastream/captureStream/canvas3d.html [ Timeout ]
+
+webkit.org/b/237095 imported/w3c/web-platform-tests/workers/semantics/multiple-workers/004.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290385] trunk/LayoutTests

2022-02-23 Thread zalan

Title: [290385] trunk/LayoutTests








Revision 290385
Author za...@apple.com
Date 2022-02-23 11:26:12 -0800 (Wed, 23 Feb 2022)


Log Message
[Subpixel] imported/w3c/web-platform-tests/css/css-flexbox/auto-margins-001.html fails at certain font sizes
https://bugs.webkit.org/show_bug.cgi?id=217643


Unreviewed gardening.


* platform/ios-simulator-wk2/TestExpectations: It must have progressed at some point.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290384 => 290385)

--- trunk/LayoutTests/ChangeLog	2022-02-23 19:02:54 UTC (rev 290384)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 19:26:12 UTC (rev 290385)
@@ -1,3 +1,13 @@
+2022-02-23  Alan Bujtas  
+
+[Subpixel] imported/w3c/web-platform-tests/css/css-flexbox/auto-margins-001.html fails at certain font sizes
+https://bugs.webkit.org/show_bug.cgi?id=217643
+
+
+Unreviewed gardening.
+
+* platform/ios-simulator-wk2/TestExpectations: It must have progressed at some point.
+
 2022-02-23  Jon Lee  
 
 Unreviewed gardening for GPU Process bot.


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (290384 => 290385)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2022-02-23 19:02:54 UTC (rev 290384)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2022-02-23 19:26:12 UTC (rev 290385)
@@ -126,8 +126,6 @@
 
 webkit.org/b/217412 http/wpt/cache-storage/cache-quota.any.html [ Pass Failure ]
 
-webkit.org/b/217643 imported/w3c/web-platform-tests/css/css-flexbox/auto-margins-001.html [ Pass ImageOnlyFailure ]
-
 webkit.org/b/217669 http/wpt/service-workers/service-worker-spinning-activate.https.html [ Pass Timeout Failure ]
 webkit.org/b/217669 http/wpt/service-workers/service-worker-spinning-fetch.https.html [ Pass Timeout Failure ]
 webkit.org/b/217669 http/wpt/service-workers/service-worker-spinning-install.https.html [ Pass Timeout Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290384] trunk/Source

2022-02-23 Thread j_pascoe

Title: [290384] trunk/Source








Revision 290384
Author j_pas...@apple.com
Date 2022-02-23 11:02:54 -0800 (Wed, 23 Feb 2022)


Log Message
Prevent use of PDFKit when using PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237052
rdar://89251696

Reviewed by Tim Horton.

Source/WebCore:

Add WEBCORE_EXPORT in order to use isPDFMIMEType.

* platform/MIMETypeRegistry.h:

Source/WebKit:

PDFKit was still being used by embeds, this patch fixes that issue by treating
pdf embeds as frames if PDF.js is enabled and also prevents the loading of
the PDFKit plugin entirely by modifying shouldUsePDFPlugin.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldUsePDFPlugin const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/MIMETypeRegistry.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (290383 => 290384)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 18:36:23 UTC (rev 290383)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 19:02:54 UTC (rev 290384)
@@ -1,3 +1,15 @@
+2022-02-23  J Pascoe  
+
+Prevent use of PDFKit when using PDF.js
+https://bugs.webkit.org/show_bug.cgi?id=237052
+rdar://89251696
+
+Reviewed by Tim Horton.
+
+Add WEBCORE_EXPORT in order to use isPDFMIMEType.
+
+* platform/MIMETypeRegistry.h:
+
 2022-02-23  Alan Bujtas  
 
 [IFC][Integration] LineLayout::firstInlineBoxRect should flip the rect coordinates for vertical-rl


Modified: trunk/Source/WebCore/platform/MIMETypeRegistry.h (290383 => 290384)

--- trunk/Source/WebCore/platform/MIMETypeRegistry.h	2022-02-23 18:36:23 UTC (rev 290383)
+++ trunk/Source/WebCore/platform/MIMETypeRegistry.h	2022-02-23 19:02:54 UTC (rev 290384)
@@ -105,7 +105,7 @@
 static bool isApplicationPluginMIMEType(const String& mimeType);
 
 // Check to see if a MIME type is one of the common PDF/PS types.
-static bool isPDFMIMEType(const String& mimeType);
+WEBCORE_EXPORT static bool isPDFMIMEType(const String& mimeType);
 static bool isPostScriptMIMEType(const String& mimeType);
 WEBCORE_EXPORT static bool isPDFOrPostScriptMIMEType(const String& mimeType);
 


Modified: trunk/Source/WebKit/ChangeLog (290383 => 290384)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 18:36:23 UTC (rev 290383)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 19:02:54 UTC (rev 290384)
@@ -1,5 +1,22 @@
 2022-02-23  J Pascoe  
 
+Prevent use of PDFKit when using PDF.js
+https://bugs.webkit.org/show_bug.cgi?id=237052
+rdar://89251696
+
+Reviewed by Tim Horton.
+
+PDFKit was still being used by embeds, this patch fixes that issue by treating
+pdf embeds as frames if PDF.js is enabled and also prevents the loading of
+the PDFKit plugin entirely by modifying shouldUsePDFPlugin.
+
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::objectContentType):
+* WebProcess/WebPage/mac/WebPageMac.mm:
+(WebKit::WebPage::shouldUsePDFPlugin const):
+
+2022-02-23  J Pascoe  
+
 [WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionResponse
 https://bugs.webkit.org/show_bug.cgi?id=237043
 rdar://89317740


Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (290383 => 290384)

--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2022-02-23 18:36:23 UTC (rev 290383)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2022-02-23 19:02:54 UTC (rev 290384)
@@ -1704,6 +1704,10 @@
 return ObjectContentType::Frame;
 }
 }
+if (auto* webPage = m_frame->page()) {
+if (webPage->corePage()->settings().pdfJSViewerEnabled() && MIMETypeRegistry::isPDFMIMEType(mimeType))
+return ObjectContentType::Frame;
+}
 
 if (MIMETypeRegistry::isSupportedImageMIMEType(mimeType))
 return ObjectContentType::Image;


Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm (290383 => 290384)

--- trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm	2022-02-23 18:36:23 UTC (rev 290383)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm	2022-02-23 19:02:54 UTC (rev 290384)
@@ -206,6 +206,7 @@
 bool WebPage::shouldUsePDFPlugin(const String& contentType, StringView path) const
 {
 return pdfPluginEnabled()
+&& !corePage()->settings().pdfJSViewerEnabled()
 && getPDFLayerControllerClass()
 && (MIMETypeRegistry::isPDFOrPostScriptMIMEType(contentType)
 || (contentType.isEmpty()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mail

[webkit-changes] [290383] trunk/Tools

2022-02-23 Thread jbedard

Title: [290383] trunk/Tools








Revision 290383
Author jbed...@apple.com
Date 2022-02-23 10:36:23 -0800 (Wed, 23 Feb 2022)


Log Message
[run-webkit-tests] Catch OSError when sampling
https://bugs.webkit.org/show_bug.cgi?id=237087


Reviewed by Aakash Jain.

* Tools/Scripts/webkitpy/port/darwin.py:
(DarwinPort.sample_process): Catch OSError when either sampling a
process or running spindump. These errors indicate the error gathering process
failed, but such a failure should not be fatal to the entire test run.

Canonical link: https://commits.webkit.org/247698@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/darwin.py




Diff

Modified: trunk/Tools/ChangeLog (290382 => 290383)

--- trunk/Tools/ChangeLog	2022-02-23 18:26:38 UTC (rev 290382)
+++ trunk/Tools/ChangeLog	2022-02-23 18:36:23 UTC (rev 290383)
@@ -1,3 +1,16 @@
+2022-02-23  Jonathan Bedard  
+
+[run-webkit-tests] Catch OSError when sampling
+https://bugs.webkit.org/show_bug.cgi?id=237087
+
+
+Reviewed by Aakash Jain.
+
+* Scripts/webkitpy/port/darwin.py:
+(DarwinPort.sample_process): Catch OSError when either sampling a
+process or running spindump. These errors indicate the error gathering process
+failed, but such a failure should not be fatal to the entire test run.
+
 2022-02-23  J Pascoe  
 
 [WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionResponse


Modified: trunk/Tools/Scripts/webkitpy/port/darwin.py (290382 => 290383)

--- trunk/Tools/Scripts/webkitpy/port/darwin.py	2022-02-23 18:26:38 UTC (rev 290382)
+++ trunk/Tools/Scripts/webkitpy/port/darwin.py	2022-02-23 18:36:23 UTC (rev 290383)
@@ -188,7 +188,7 @@
 host.executive.run_command(spindump_command)
 host.filesystem.move_to_base_host(DarwinPort.tailspin_file_path(host, name, pid, str(tempdir)),
   DarwinPort.tailspin_file_path(self.host, name, pid, self.results_directory()))
-except (IOError, ScriptError) as e:
+except (IOError, ScriptError, OSError) as e:
 _log.warning('Unable to symbolicate tailspin log of process:' + str(e))
 else:  # Tailspin failed, run sample instead
 try:
@@ -202,7 +202,7 @@
 ])
 host.filesystem.move_to_base_host(DarwinPort.sample_file_path(host, name, pid, str(tempdir)),
   DarwinPort.sample_file_path(self.host, name, pid, self.results_directory()))
-except ScriptError as e:
+except (ScriptError, OSError) as e:
 _log.warning('Unable to sample process:' + str(e))
 host.filesystem.rmtree(str(tempdir))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290382] trunk/Source/WebCore

2022-02-23 Thread zalan

Title: [290382] trunk/Source/WebCore








Revision 290382
Author za...@apple.com
Date 2022-02-23 10:26:38 -0800 (Wed, 23 Feb 2022)


Log Message
[IFC][Integration] LineLayout::firstInlineBoxRect should flip the rect coordinates for vertical-rl
https://bugs.webkit.org/show_bug.cgi?id=237036

Reviewed by Antti Koivisto and Darin Adler.

This is similar to what RenderInline::firstInlineBoxTopLeft does.

* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::firstInlineBoxRect const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (290381 => 290382)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 18:19:54 UTC (rev 290381)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 18:26:38 UTC (rev 290382)
@@ -1,3 +1,15 @@
+2022-02-23  Alan Bujtas  
+
+[IFC][Integration] LineLayout::firstInlineBoxRect should flip the rect coordinates for vertical-rl
+https://bugs.webkit.org/show_bug.cgi?id=237036
+
+Reviewed by Antti Koivisto and Darin Adler.
+
+This is similar to what RenderInline::firstInlineBoxTopLeft does.
+
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::firstInlineBoxRect const):
+
 2022-02-23  J Pascoe  
 
 [WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionResponse


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (290381 => 290382)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-02-23 18:19:54 UTC (rev 290381)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-02-23 18:26:38 UTC (rev 290382)
@@ -565,11 +565,24 @@
 LayoutRect LineLayout::firstInlineBoxRect(const RenderInline& renderInline) const
 {
 auto& layoutBox = m_boxTree.layoutBoxForRenderer(renderInline);
+auto* firstBox = m_inlineContent->firstBoxForLayoutBox(layoutBox);
+if (!firstBox)
+return { };
 
-if (auto* box = m_inlineContent->firstBoxForLayoutBox(layoutBox))
-return Layout::toLayoutRect(box->rect());
-
-return { };
+// FIXME: We should be able to flip the display boxes soon after the root block
+// is finished sizing in one go.
+auto firstBoxRect = Layout::toLayoutRect(firstBox->rect());
+switch (flow().style().writingMode()) {
+case WritingMode::TopToBottom:
+case WritingMode::LeftToRight:
+return firstBoxRect;
+case WritingMode::RightToLeft:
+firstBoxRect.setX(flow().width() - firstBoxRect.maxX());
+return firstBoxRect;
+default:
+ASSERT_NOT_REACHED();
+return firstBoxRect;
+}
 }
 
 LayoutRect LineLayout::enclosingBorderBoxRectFor(const RenderInline& renderInline) const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290381] trunk

2022-02-23 Thread j_pascoe

Title: [290381] trunk








Revision 290381
Author j_pas...@apple.com
Date 2022-02-23 10:19:54 -0800 (Wed, 23 Feb 2022)


Log Message
[WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionResponse
https://bugs.webkit.org/show_bug.cgi?id=237043
rdar://89317740

Reviewed by Brent Fulgham.

Source/WebCore:

The userHandle is a nullable field on UserEntity. This patch changes
various API/SPI to allow passing null userHandle.

* Modules/webauthn/AuthenticatorAssertionResponse.cpp:
(WebCore::AuthenticatorAssertionResponse::create):
(WebCore::AuthenticatorAssertionResponse::AuthenticatorAssertionResponse):
* Modules/webauthn/AuthenticatorAssertionResponse.h:

Source/WebKit:

The userHandle is a nullable field on UserEntity. This patch changes
various API/SPI to allow passing null userHandle.

* Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
Update forward declared SPI, reflecting userHandle as nullable.
* UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponseInternal.h:
* UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.h:
Update userHandle property to null.
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(getAllLocalAuthenticatorCredentialsImpl):
* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):

Tools:

Create tests to check for null userHandle.

* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.cpp
trunk/Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponseInternal.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (290380 => 290381)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 18:14:59 UTC (rev 290380)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 18:19:54 UTC (rev 290381)
@@ -1,3 +1,19 @@
+2022-02-23  J Pascoe  
+
+[WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionResponse
+https://bugs.webkit.org/show_bug.cgi?id=237043
+rdar://89317740
+
+Reviewed by Brent Fulgham.
+
+The userHandle is a nullable field on UserEntity. This patch changes
+various API/SPI to allow passing null userHandle.
+
+* Modules/webauthn/AuthenticatorAssertionResponse.cpp:
+(WebCore::AuthenticatorAssertionResponse::create):
+(WebCore::AuthenticatorAssertionResponse::AuthenticatorAssertionResponse):
+* Modules/webauthn/AuthenticatorAssertionResponse.h:
+
 2022-02-23  Antti Koivisto  
 
 [CSS Container Queries] offsetWidth/Height and similar should update layout for container queries


Modified: trunk/Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.cpp (290380 => 290381)

--- trunk/Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.cpp	2022-02-23 18:14:59 UTC (rev 290380)
+++ trunk/Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.cpp	2022-02-23 18:19:54 UTC (rev 290381)
@@ -48,7 +48,7 @@
 return create(ArrayBuffer::create(rawId.data(), rawId.size()), ArrayBuffer::create(authenticatorData.data(), authenticatorData.size()), ArrayBuffer::create(signature.data(), signature.size()), WTFMove(userhandleBuffer), std::nullopt, attachment);
 }
 
-Ref AuthenticatorAssertionResponse::create(Ref&& rawId, Ref&& userHandle, String&& name, SecAccessControlRef accessControl, AuthenticatorAttachment attachment)
+Ref AuthenticatorAssertionResponse::create(Ref&& rawId, RefPtr&& userHandle, String&& name, SecAccessControlRef accessControl, AuthenticatorAttachment attachment)
 {
 return adoptRef(*new AuthenticatorAssertionResponse(WTFMove(rawId), WTFMove(userHandle), WTFMove(name), accessControl, attachment));
 }
@@ -66,7 +66,7 @@
 {
 }
 
-AuthenticatorAssertionResponse::AuthenticatorAssertionResponse(Ref&& rawId, Ref&& userHandle, String&& name, SecAccessControlRef accessControl, AuthenticatorAttachment attachment)
+AuthenticatorAssertionResponse::AuthenticatorAssertionResponse(Ref&& rawId, RefPtr&& userHandle, String&& name, SecAccessControlRef accessControl, AuthenticatorAttachment attachment)
 : AuthenticatorResponse(WTFMove(rawId), attachment)
 , m_userHandle(WTFMove(userHandle))
 , m_name(WTFMove(name))


Modified: trunk/Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h (290380 => 290381)

--- trunk/Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h	2022-02-23 18:14:59 UTC (rev 290380)
+++ trunk/So

[webkit-changes] [290380] trunk

2022-02-23 Thread antti

Title: [290380] trunk








Revision 290380
Author an...@apple.com
Date 2022-02-23 10:14:59 -0800 (Wed, 23 Feb 2022)


Log Message
[CSS Container Queries] offsetWidth/Height and similar should update layout for container queries
https://bugs.webkit.org/show_bug.cgi?id=237079

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-contain/container-queries/auto-scrollbars-expected.txt:
* web-platform-tests/css/css-contain/container-queries/inline-size-containment-expected.txt:
* web-platform-tests/css/css-contain/container-queries/inline-size-containment-vertical-rl-expected.txt:
* web-platform-tests/css/css-contain/container-queries/transition-scrollbars-expected.txt:

Source/WebCore:

Fix

css/css-contain/container-queries/inline-size-containment.html
css/css-contain/container-queries/inline-size-containment-vertical-rl.html

* dom/Document.cpp:
(WebCore::Document::updateLayout):

Make iterative instead of recursive.

(WebCore::Document::updateLayoutIfDimensionsOutOfDate):

Check for query containers.
Call local updateLayout instead of the FrameViewLayoutContext one.

* page/FrameView.cpp:
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
* style/StyleScope.cpp:
(WebCore::Style::Scope::updateQueryContainerState):

Add protection against infinite layout/invalidation cycle with unstable layouts.

* style/StyleScope.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/auto-scrollbars-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-containment-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-containment-vertical-rl-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/transition-scrollbars-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/style/StyleScope.cpp
trunk/Source/WebCore/style/StyleScope.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (290379 => 290380)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-02-23 18:09:17 UTC (rev 290379)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-02-23 18:14:59 UTC (rev 290380)
@@ -1,3 +1,15 @@
+2022-02-23  Antti Koivisto  
+
+[CSS Container Queries] offsetWidth/Height and similar should update layout for container queries
+https://bugs.webkit.org/show_bug.cgi?id=237079
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/css-contain/container-queries/auto-scrollbars-expected.txt:
+* web-platform-tests/css/css-contain/container-queries/inline-size-containment-expected.txt:
+* web-platform-tests/css/css-contain/container-queries/inline-size-containment-vertical-rl-expected.txt:
+* web-platform-tests/css/css-contain/container-queries/transition-scrollbars-expected.txt:
+
 2022-02-22  Antti Koivisto  
 
 [CSS container Queries] getComputedStyle should update style for invalid query containers


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/auto-scrollbars-expected.txt (290379 => 290380)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/auto-scrollbars-expected.txt	2022-02-23 18:09:17 UTC (rev 290379)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/auto-scrollbars-expected.txt	2022-02-23 18:14:59 UTC (rev 290380)
@@ -1,4 +1,4 @@
 
-FAIL Initial layout - expecting a scrollbar without overflowing content instead of overflowing content without a scrollbar assert_equals: Layout with a scrollbar means the container query applies expected "50px" but got "100px"
+FAIL Initial layout - expecting a scrollbar without overflowing content instead of overflowing content without a scrollbar assert_less_than: Expects a vertical scrollbar expected a number less than 100 but got 100
 FAIL Same result after a reflow assert_less_than: Expects a vertical scrollbar expected a number less than 100 but got 100
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-containment-expected.txt (290379 => 290380)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-containment-expected.txt	2022-02-23 18:09:17 UTC (rev 290379)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-containment-expected.txt	2022-02-23 18:14:59 UTC (rev 290380)
@@ -1,3 +1,3 @@
 
-FAIL inline-size containment only assert_equals: expected 400 but got 20
+PASS inline-size containment only
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-containment-vertical-rl-expected.txt (290379 => 290380)

--- trunk/LayoutTests/imported/w3

[webkit-changes] [290379] trunk/LayoutTests

2022-02-23 Thread jonlee

Title: [290379] trunk/LayoutTests








Revision 290379
Author jon...@apple.com
Date 2022-02-23 10:09:17 -0800 (Wed, 23 Feb 2022)


Log Message
Unreviewed gardening for GPU Process bot.

* imported/blink/svg/paintorder/paintorder.svg:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/blink/svg/paintorder/paintorder.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (290378 => 290379)

--- trunk/LayoutTests/ChangeLog	2022-02-23 18:02:56 UTC (rev 290378)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 18:09:17 UTC (rev 290379)
@@ -1,5 +1,11 @@
 2022-02-23  Jon Lee  
 
+Unreviewed gardening for GPU Process bot.
+
+* imported/blink/svg/paintorder/paintorder.svg:
+
+2022-02-23  Jon Lee  
+
 Test gardening for [CSS Blending] Non-separable blend modes don't work
 https://bugs.webkit.org/show_bug.cgi?id=131354
 


Modified: trunk/LayoutTests/imported/blink/svg/paintorder/paintorder.svg (290378 => 290379)

--- trunk/LayoutTests/imported/blink/svg/paintorder/paintorder.svg	2022-02-23 18:02:56 UTC (rev 290378)
+++ trunk/LayoutTests/imported/blink/svg/paintorder/paintorder.svg	2022-02-23 18:09:17 UTC (rev 290379)
@@ -1,5 +1,5 @@
 
-	
+	
 	
 		
 			






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290378] trunk/LayoutTests

2022-02-23 Thread jonlee

Title: [290378] trunk/LayoutTests








Revision 290378
Author jon...@apple.com
Date 2022-02-23 10:02:56 -0800 (Wed, 23 Feb 2022)


Log Message
Test gardening for [CSS Blending] Non-separable blend modes don't work
https://bugs.webkit.org/show_bug.cgi?id=131354

LayoutTests/imported/mozilla:

Unreviewed. Relanding with updated fuzzy data.
* svg/blend-color.svg:
* svg/blend-hue.svg:
* svg/blend-luminosity.svg:

LayoutTests:

Unreviewed.
* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/mozilla/ChangeLog
trunk/LayoutTests/imported/mozilla/svg/blend-color.svg
trunk/LayoutTests/imported/mozilla/svg/blend-hue.svg
trunk/LayoutTests/imported/mozilla/svg/blend-luminosity.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (290377 => 290378)

--- trunk/LayoutTests/ChangeLog	2022-02-23 17:50:53 UTC (rev 290377)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 18:02:56 UTC (rev 290378)
@@ -1,3 +1,11 @@
+2022-02-23  Jon Lee  
+
+Test gardening for [CSS Blending] Non-separable blend modes don't work
+https://bugs.webkit.org/show_bug.cgi?id=131354
+
+Unreviewed.
+* TestExpectations:
+
 2022-02-23  Andres Gonzalez  
 
 Fix for assert crash in AccessibilityRenderObject::visiblePositionForIndex.


Modified: trunk/LayoutTests/TestExpectations (290377 => 290378)

--- trunk/LayoutTests/TestExpectations	2022-02-23 17:50:53 UTC (rev 290377)
+++ trunk/LayoutTests/TestExpectations	2022-02-23 18:02:56 UTC (rev 290378)
@@ -1959,11 +1959,7 @@
 webkit.org/b/139192 imported/mozilla/svg/smil/transform/rotate-angle-4.svg [ ImageOnlyFailure ]
 webkit.org/b/139192 imported/mozilla/svg/smil/transform/rotate-angle-5.svg [ ImageOnlyFailure ]
 webkit.org/b/139199 imported/mozilla/svg/as-image/img-content-outside-viewBox-1.html [ ImageOnlyFailure ]
-webkit.org/b/131354 imported/mozilla/svg/blend-color.svg [ ImageOnlyFailure ]
 webkit.org/b/131354 imported/mozilla/svg/blend-difference-stacking.html [ ImageOnlyFailure ]
-webkit.org/b/131354 imported/mozilla/svg/blend-hard-light.svg [ ImageOnlyFailure ]
-webkit.org/b/131354 imported/mozilla/svg/blend-hue.svg [ ImageOnlyFailure ]
-webkit.org/b/131354 imported/mozilla/svg/blend-luminosity.svg [ ImageOnlyFailure ]
 webkit.org/b/139210 imported/mozilla/svg/text/textLength-5.svg [ ImageOnlyFailure ]
 webkit.org/b/139210 imported/mozilla/svg/text/textLength-6.svg [ ImageOnlyFailure ]
 webkit.org/b/139237 imported/mozilla/svg/filters/feComposite-1.svg [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/imported/mozilla/ChangeLog (290377 => 290378)

--- trunk/LayoutTests/imported/mozilla/ChangeLog	2022-02-23 17:50:53 UTC (rev 290377)
+++ trunk/LayoutTests/imported/mozilla/ChangeLog	2022-02-23 18:02:56 UTC (rev 290378)
@@ -1,3 +1,13 @@
+2022-02-19  Jon Lee  
+
+Test gardening for [CSS Blending] Non-separable blend modes don't work
+https://bugs.webkit.org/show_bug.cgi?id=131354
+
+Unreviewed. Relanding with updated fuzzy data.
+* svg/blend-color.svg:
+* svg/blend-hue.svg:
+* svg/blend-luminosity.svg:
+
 2022-02-22  Jonathan Bedard  
 
 Unreviewed, reverting r290220.


Modified: trunk/LayoutTests/imported/mozilla/svg/blend-color.svg (290377 => 290378)

--- trunk/LayoutTests/imported/mozilla/svg/blend-color.svg	2022-02-23 17:50:53 UTC (rev 290377)
+++ trunk/LayoutTests/imported/mozilla/svg/blend-color.svg	2022-02-23 18:02:56 UTC (rev 290378)
@@ -3,6 +3,7 @@
  http://creativecommons.org/publicdomain/zero/1.0/
 -->
 
+
 
   
 


Modified: trunk/LayoutTests/imported/mozilla/svg/blend-hue.svg (290377 => 290378)

--- trunk/LayoutTests/imported/mozilla/svg/blend-hue.svg	2022-02-23 17:50:53 UTC (rev 290377)
+++ trunk/LayoutTests/imported/mozilla/svg/blend-hue.svg	2022-02-23 18:02:56 UTC (rev 290378)
@@ -3,6 +3,7 @@
  http://creativecommons.org/publicdomain/zero/1.0/
 -->
 
+
 
   
 


Modified: trunk/LayoutTests/imported/mozilla/svg/blend-luminosity.svg (290377 => 290378)

--- trunk/LayoutTests/imported/mozilla/svg/blend-luminosity.svg	2022-02-23 17:50:53 UTC (rev 290377)
+++ trunk/LayoutTests/imported/mozilla/svg/blend-luminosity.svg	2022-02-23 18:02:56 UTC (rev 290378)
@@ -3,6 +3,7 @@
  http://creativecommons.org/publicdomain/zero/1.0/
 -->
 
+
 
   
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290377] trunk

2022-02-23 Thread andresg_22

Title: [290377] trunk








Revision 290377
Author andresg...@apple.com
Date 2022-02-23 09:50:53 -0800 (Wed, 23 Feb 2022)


Log Message
Fix for assert crash in AccessibilityRenderObject::visiblePositionForIndex.
https://bugs.webkit.org/show_bug.cgi?id=236795
rdar://89025180

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/native-text-control-attributed-string.html

In some cases like the one described in the bug, AccessibilityRenderObject::visiblePositionForIndex
is passed an index greater than the length of the text actually contained
in the text control. This triggers this assert that verifies that you can
round-trip from index to VisiblePosition and back to index. This patch
does a bounds check in the index and adjust if necessary.
The test exercise this method through the JS AccessibilityUIElement::attributedStringForRange
for both  of type text and password.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForIndex const):

LayoutTests:

* accessibility/native-text-control-attributed-string-expected.txt: Added.
* accessibility/native-text-control-attributed-string.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp


Added Paths

trunk/LayoutTests/accessibility/native-text-control-attributed-string-expected.txt
trunk/LayoutTests/accessibility/native-text-control-attributed-string.html




Diff

Modified: trunk/LayoutTests/ChangeLog (290376 => 290377)

--- trunk/LayoutTests/ChangeLog	2022-02-23 16:35:55 UTC (rev 290376)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 17:50:53 UTC (rev 290377)
@@ -1,3 +1,14 @@
+2022-02-23  Andres Gonzalez  
+
+Fix for assert crash in AccessibilityRenderObject::visiblePositionForIndex.
+https://bugs.webkit.org/show_bug.cgi?id=236795
+rdar://89025180
+
+Reviewed by Chris Fleizach.
+
+* accessibility/native-text-control-attributed-string-expected.txt: Added.
+* accessibility/native-text-control-attributed-string.html: Added.
+
 2022-02-23  Alejandro G. Castro  
 
 Unreviewed test gardening.


Added: trunk/LayoutTests/accessibility/native-text-control-attributed-string-expected.txt (0 => 290377)

--- trunk/LayoutTests/accessibility/native-text-control-attributed-string-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/native-text-control-attributed-string-expected.txt	2022-02-23 17:50:53 UTC (rev 290377)
@@ -0,0 +1,95 @@
+Tests that attributedStringForRange works properly for native text and password fields, including for ranges out of bound.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Attributed string for range (0, 9): some word{
+AXBackgroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 0 )";
+AXFont = {
+AXFontFamily = ".AppleSystemUIFont";
+AXFontName = ".SFNS-Regular";
+AXFontSize = 11;
+AXVisibleName = "System Font Regular";
+};
+AXForegroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 1 )";
+}
+Attributed string for range (0, 3): som{
+AXBackgroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 0 )";
+AXFont = {
+AXFontFamily = ".AppleSystemUIFont";
+AXFontName = ".SFNS-Regular";
+AXFontSize = 11;
+AXVisibleName = "System Font Regular";
+};
+AXForegroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 1 )";
+}
+Attributed string for range (5, 4): word{
+AXBackgroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 0 )";
+AXFont = {
+AXFontFamily = ".AppleSystemUIFont";
+AXFontName = ".SFNS-Regular";
+AXFontSize = 11;
+AXVisibleName = "System Font Regular";
+};
+AXForegroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 1 )";
+}
+Attributed string for range (5, 10): null
+Attributed string for range (10, 1): null
+Attributed string for range (-1, 1): s{
+AXBackgroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 0 )";
+AXFont = {
+AXFontFamily = ".AppleSystemUIFont";
+AXFontName = ".SFNS-Regular";
+AXFontSize = 11;
+AXVisibleName = "System Font Regular";
+};
+AXForegroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 1 )";
+}
+
+Attributed string for range (0, 3): •••{
+AXBackgroundColor = " [ (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0 0 0 0 )";
+AXFont = {
+AXFon

[webkit-changes] [290376] branches/safari-614.1.5-branch/Source

2022-02-23 Thread kocsen_chung

Title: [290376] branches/safari-614.1.5-branch/Source








Revision 290376
Author kocsen_ch...@apple.com
Date 2022-02-23 08:35:55 -0800 (Wed, 23 Feb 2022)


Log Message
Versioning.

WebKit-7614.1.5.2

Modified Paths

branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (290375 => 290376)

--- branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-23 16:33:40 UTC (rev 290375)
+++ branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-02-23 16:35:55 UTC (rev 290376)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (290375 => 290376)

--- branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-23 16:33:40 UTC (rev 290375)
+++ branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-02-23 16:35:55 UTC (rev 290376)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (290375 => 290376)

--- branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-23 16:33:40 UTC (rev 290375)
+++ branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-02-23 16:35:55 UTC (rev 290376)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig (290375 => 290376)

--- branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-23 16:33:40 UTC (rev 290375)
+++ branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2022-02-23 16:35:55 UTC (rev 290376)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (290375 => 290376)

--- branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-23 16:33:40 UTC (rev 290375)
+++ branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-02-23 16:35:55 UTC (rev 290376)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig (290375 => 290376)

--- branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-23 16:33:40 UTC (rev 290375)
+++ branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-02-23 16:35:55 UTC (rev 290376)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (290375 => 290376)

--- branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-02-23 16:33:40 UTC (rev 290375)
+++ branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-02-23 16:35:55 UTC (rev 290376)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;

[webkit-changes] [290375] trunk

2022-02-23 Thread commit-queue

Title: [290375] trunk








Revision 290375
Author commit-qu...@webkit.org
Date 2022-02-23 08:33:40 -0800 (Wed, 23 Feb 2022)


Log Message
[GStreamer] De-initialize GStreamer before terminating WebProcess
https://bugs.webkit.org/show_bug.cgi?id=237084

Patch by Philippe Normand  on 2022-02-23
Reviewed by Carlos Garcia Campos.

Source/WebKit:

Allowing the leak tracer to report/log leaks. There is an issue though, if the UIProcess
exits too early, the leak tracer reporting will be interrupted potentially too early. The
workaround is to have 2 tabs open in the GTK MiniBrowser, closing the one where media
handling and leak tracing was done and keeping the second tab open.

* WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):

Tools:

* flatpak/flatpakutils.py:
(WebkitFlatpak.setup_gstbuild): Do not add extra quotes to GST_TRACERS, this is not supposed
to store paths.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp
trunk/Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp
trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py




Diff

Modified: trunk/Source/WebKit/ChangeLog (290374 => 290375)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 16:09:16 UTC (rev 290374)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 16:33:40 UTC (rev 290375)
@@ -1,3 +1,18 @@
+2022-02-23  Philippe Normand  
+
+[GStreamer] De-initialize GStreamer before terminating WebProcess
+https://bugs.webkit.org/show_bug.cgi?id=237084
+
+Reviewed by Carlos Garcia Campos.
+
+Allowing the leak tracer to report/log leaks. There is an issue though, if the UIProcess
+exits too early, the leak tracer reporting will be interrupted potentially too early. The
+workaround is to have 2 tabs open in the GTK MiniBrowser, closing the one where media
+handling and leak tracing was done and keeping the second tab open.
+
+* WebProcess/glib/WebProcessGLib.cpp:
+(WebKit::WebProcess::stopRunLoop):
+
 2022-02-23  Youenn Fablet  
 
 RemoteSampleBufferDisplayLayer::enqueueSample should not change media samples owned by its object heap


Modified: trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp (290374 => 290375)

--- trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp	2022-02-23 16:09:16 UTC (rev 290374)
+++ trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp	2022-02-23 16:33:40 UTC (rev 290375)
@@ -36,6 +36,10 @@
 #include 
 #endif
 
+#if USE(GSTREAMER)
+#include 
+#endif
+
 #if USE(GCRYPT)
 #include 
 #endif
@@ -67,6 +71,13 @@
 
 return true;
 }
+
+void platformFinalize() override
+{
+#if USE(GSTREAMER)
+gst_deinit();
+#endif
+}
 };
 
 int WebProcessMain(int argc, char** argv)


Modified: trunk/Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp (290374 => 290375)

--- trunk/Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp	2022-02-23 16:09:16 UTC (rev 290374)
+++ trunk/Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp	2022-02-23 16:33:40 UTC (rev 290375)
@@ -40,6 +40,10 @@
 #include 
 #endif
 
+#if USE(GSTREAMER)
+#include 
+#endif
+
 namespace WebKit {
 using namespace WebCore;
 
@@ -99,6 +103,13 @@
 
 return true;
 }
+
+void platformFinalize() override
+{
+#if USE(GSTREAMER)
+gst_deinit();
+#endif
+}
 };
 
 int WebProcessMain(int argc, char** argv)


Modified: trunk/Tools/ChangeLog (290374 => 290375)

--- trunk/Tools/ChangeLog	2022-02-23 16:09:16 UTC (rev 290374)
+++ trunk/Tools/ChangeLog	2022-02-23 16:33:40 UTC (rev 290375)
@@ -1,3 +1,14 @@
+2022-02-23  Philippe Normand  
+
+[GStreamer] De-initialize GStreamer before terminating WebProcess
+https://bugs.webkit.org/show_bug.cgi?id=237084
+
+Reviewed by Carlos Garcia Campos.
+
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.setup_gstbuild): Do not add extra quotes to GST_TRACERS, this is not supposed
+to store paths.
+
 2022-02-23  Alex Christensen  
 
 Call WKNavigationDelegate.didFailProvisionalNavigation even after a cross-origin navigation with COOP


Modified: trunk/Tools/flatpak/flatpakutils.py (290374 => 290375)

--- trunk/Tools/flatpak/flatpakutils.py	2022-02-23 16:09:16 UTC (rev 290374)
+++ trunk/Tools/flatpak/flatpakutils.py	2022-02-23 16:33:40 UTC (rev 290375)
@@ -691,7 +691,7 @@
 command = [os.path.join(gst_dir, 'gst-env.py'), '--builddir', gst_builddir, '--srcdir', gst_dir, "--only-environment"]
 gst_env = run_sanitized(command, gather_output=True)
 allowlist = ("LD_LIBRARY_PATH", "PATH", "PKG_CONFIG_PATH")
-nopathlist = ("GST_DEBUG", "GST_VERSION", "GST_ENV")
+nopathlist = ("GST_DEBUG", "GST_VERSION", "GST_ENV", "GST_TRACERS")
 env = {}
 for line in [line for line in gst_env.splitlines() if not line.startswith("export")]:
 tokens = line.split("=")






___
webkit-changes mailing list
webkit-changes@li

[webkit-changes] [290374] trunk/Source/WebCore

2022-02-23 Thread dpino

Title: [290374] trunk/Source/WebCore








Revision 290374
Author dp...@igalia.com
Date 2022-02-23 08:09:16 -0800 (Wed, 23 Feb 2022)


Log Message
[GTK] Unreviewed, build fix for Debian Stable after r290366

* platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(webKitVideoSinkSetMediaPlayerPrivate):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (290373 => 290374)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 16:00:11 UTC (rev 290373)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 16:09:16 UTC (rev 290374)
@@ -1,3 +1,10 @@
+2022-02-23  Diego Pino Garcia  
+
+[GTK] Unreviewed, build fix for Debian Stable after r290366
+
+* platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
+(webKitVideoSinkSetMediaPlayerPrivate):
+
 2022-02-23  Jer Noble  
 
 REGRESSION (r287574): ASSERTION FAILED: !m_impl || !m_shouldEnableAssertions || m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack()


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp (290373 => 290374)

--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp	2022-02-23 16:00:11 UTC (rev 290373)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp	2022-02-23 16:09:16 UTC (rev 290374)
@@ -72,7 +72,9 @@
 GST_DEBUG("Acting upon flush-start event");
 }
 
+#if USE(GSTREAMER_GL)
 player->flushCurrentBuffer();
+#endif
 return GST_PAD_PROBE_OK;
 }, player, nullptr);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290373] trunk/Source/WebKit

2022-02-23 Thread youenn

Title: [290373] trunk/Source/WebKit








Revision 290373
Author you...@apple.com
Date 2022-02-23 08:00:11 -0800 (Wed, 23 Feb 2022)


Log Message
RemoteSampleBufferDisplayLayer::enqueueSample should not change media samples owned by its object heap
https://bugs.webkit.org/show_bug.cgi?id=237025


Reviewed by Darin Adler.

Updated https://commits.webkit.org/r290358 according comments given during review.

* Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::RemoteVideoFrameObjectHeapProxyProcessor):
* WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
(WebKit::SharedVideoFrameWriter::write):
(WebKit::SharedVideoFrameReader::SharedVideoFrameReader):
* WebProcess/GPU/webrtc/SharedVideoFrame.h:
(WebKit::SharedVideoFrame::encode const):
(WebKit::SharedVideoFrame::decode):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h
trunk/Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (290372 => 290373)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 15:54:52 UTC (rev 290372)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 16:00:11 UTC (rev 290373)
@@ -1,3 +1,25 @@
+2022-02-23  Youenn Fablet  
+
+RemoteSampleBufferDisplayLayer::enqueueSample should not change media samples owned by its object heap
+https://bugs.webkit.org/show_bug.cgi?id=237025
+
+
+Reviewed by Darin Adler.
+
+Updated https://commits.webkit.org/r290358 according comments given during review.
+
+* Platform/IPC/ArgumentCoders.h:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+* WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
+(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::RemoteVideoFrameObjectHeapProxyProcessor):
+* WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
+(WebKit::SharedVideoFrameWriter::write):
+(WebKit::SharedVideoFrameReader::SharedVideoFrameReader):
+* WebProcess/GPU/webrtc/SharedVideoFrame.h:
+(WebKit::SharedVideoFrame::encode const):
+(WebKit::SharedVideoFrame::decode):
+
 2022-02-23  Alex Christensen  
 
 Call WKNavigationDelegate.didFailProvisionalNavigation even after a cross-origin navigation with COOP


Modified: trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h (290372 => 290373)

--- trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h	2022-02-23 15:54:52 UTC (rev 290372)
+++ trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h	2022-02-23 16:00:11 UTC (rev 290373)
@@ -852,4 +852,9 @@
 }
 };
 
+template<> struct ArgumentCoder {
+static void encode(Encoder&, const std::nullptr_t&) { }
+static WARN_UNUSED_RETURN bool decode(Decoder&, std::nullptr_t&) { return true; }
+};
+
 } // namespace IPC


Modified: trunk/Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp (290372 => 290373)

--- trunk/Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp	2022-02-23 15:54:52 UTC (rev 290372)
+++ trunk/Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp	2022-02-23 16:00:11 UTC (rev 290373)
@@ -43,7 +43,6 @@
 RemoteVideoFrameObjectHeapProxyProcessor::RemoteVideoFrameObjectHeapProxyProcessor(GPUProcessConnection& connection)
 : m_connectionID(connection.connection().uniqueID())
 , m_queue(WorkQueue::create("RemoteVideoFrameObjectHeapProxy", WorkQueue::QOS::UserInteractive))
-, m_sharedVideoFrameReader(nullptr)
 {
 connection.addClient(*this);
 connection.connection().addWorkQueueMessageReceiver(Messages::RemoteVideoFrameObjectHeapProxyProcessor::messageReceiverName(), m_queue, this);


Modified: trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp (290372 => 290373)

--- trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp	2022-02-23 15:54:52 UTC (rev 290372)
+++ trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp	2022-02-23 16:00:11 UTC (rev 290373)
@@ -96,11 +96,11 @@
 return sharedVideoFrame;
 }
 if (is(frame)) {
-auto pixelBuffer = downcast(frame).pixelBuffer();
-IOSurfaceRef surface = pixelBuffer ? CVPixelBufferGetIOSurface(pixelBuffer) : nullptr;
-if (surface) {
-sharedVideoFrame.buffer = MachSendRight::adopt(IOSurfaceCreateMachPort(surface));
-return sharedVideoFrame;
+if (auto pixelBuffer = downcast(frame).pixelBuffer()) {
+if (auto surface = CVPixelBufferGetIOSurface(pixelBuffer)) {
+sharedVideoFrame.buffer = MachSendRight::adopt(IOSurfaceCreateMachPort(surface));
+return sharedVideoFrame;
+}
 }
 }

[webkit-changes] [290372] trunk/Source/WebCore

2022-02-23 Thread jer . noble

Title: [290372] trunk/Source/WebCore








Revision 290372
Author jer.no...@apple.com
Date 2022-02-23 07:54:52 -0800 (Wed, 23 Feb 2022)


Log Message
REGRESSION (r287574): ASSERTION FAILED: !m_impl || !m_shouldEnableAssertions || m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack()
https://bugs.webkit.org/show_bug.cgi?id=235168


Reviewed by Alexey Proskuryakov.

Use runOnMainThread() from within WebCore, as it will dispatch to the correct thread when
running under iOS/WebKitLegacy.

* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (290371 => 290372)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 15:20:31 UTC (rev 290371)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 15:54:52 UTC (rev 290372)
@@ -1,3 +1,17 @@
+2022-02-23  Jer Noble  
+
+REGRESSION (r287574): ASSERTION FAILED: !m_impl || !m_shouldEnableAssertions || m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack()
+https://bugs.webkit.org/show_bug.cgi?id=235168
+
+
+Reviewed by Alexey Proskuryakov.
+
+Use runOnMainThread() from within WebCore, as it will dispatch to the correct thread when
+running under iOS/WebKitLegacy.
+
+* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
+(WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack):
+
 2022-02-23  Youenn Fablet  
 
 RemoteVideoFrameObjectHeap::getVideoFrameBuffer can use base class pixelBuffer accessor


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm (290371 => 290372)

--- trunk/Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm	2022-02-23 15:20:31 UTC (rev 290371)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm	2022-02-23 15:54:52 UTC (rev 290372)
@@ -87,7 +87,7 @@
 return;
 
 [m_assetTrack loadValuesAsynchronouslyForKeys:assetTrackConfigurationKeyNames() completionHandler:[weakThis = WeakPtr(this)] () mutable {
-callOnMainRunLoop([weakThis = WTFMove(weakThis)] {
+callOnMainThread([weakThis = WTFMove(weakThis)] {
 if (weakThis && weakThis->m_audioTrackConfigurationObserver)
 (*weakThis->m_audioTrackConfigurationObserver)();
 if (weakThis && weakThis->m_videoTrackConfigurationObserver)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290371] trunk

2022-02-23 Thread commit-queue

Title: [290371] trunk








Revision 290371
Author commit-qu...@webkit.org
Date 2022-02-23 07:20:31 -0800 (Wed, 23 Feb 2022)


Log Message
Call WKNavigationDelegate.didFailProvisionalNavigation even after a cross-origin navigation with COOP
https://bugs.webkit.org/show_bug.cgi?id=237071


Patch by Alex Christensen  on 2022-02-23
Reviewed by Chris Dumez.

Source/WebKit:

There was an assumption that this callback wasn't needed in this case, but it is.
Covered by an API test that verifies the callback is received.

* UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (290370 => 290371)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 14:59:57 UTC (rev 290370)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 15:20:31 UTC (rev 290371)
@@ -1,3 +1,17 @@
+2022-02-23  Alex Christensen  
+
+Call WKNavigationDelegate.didFailProvisionalNavigation even after a cross-origin navigation with COOP
+https://bugs.webkit.org/show_bug.cgi?id=237071
+
+
+Reviewed by Chris Dumez.
+
+There was an assumption that this callback wasn't needed in this case, but it is.
+Covered by an API test that verifies the callback is received.
+
+* UIProcess/ProvisionalPageProxy.cpp:
+(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
+
 2022-02-23  Zan Dobersek  
 
 [GLib] Add missing WebPage.h inclusion in WebProcessGLib.cpp


Modified: trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp (290370 => 290371)

--- trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp	2022-02-23 14:59:57 UTC (rev 290370)
+++ trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp	2022-02-23 15:20:31 UTC (rev 290371)
@@ -297,15 +297,6 @@
 ASSERT(!m_provisionalLoadURL.isNull());
 m_provisionalLoadURL = { };
 
-if (m_isProcessSwappingOnNavigationResponse) {
-// If the provisional load fails and we were process-swapping on navigation response, then we simply destroy ourselves.
-// In this case, the provisional load is still ongoing in the committed process and the ProvisionalPageProxy destructor
-// will stop it and cause the committed process to send its own DidFailProvisionalLoadForFrame IPC.
-ASSERT(m_page.provisionalPageProxy() == this);
-m_page.destroyProvisionalPage();
-return;
-}
-
 // Make sure the Page's main frame's expectedURL gets cleared since we updated it in didStartProvisionalLoad.
 if (auto* pageMainFrame = m_page.mainFrame())
 pageMainFrame->didFailProvisionalLoad();


Modified: trunk/Tools/ChangeLog (290370 => 290371)

--- trunk/Tools/ChangeLog	2022-02-23 14:59:57 UTC (rev 290370)
+++ trunk/Tools/ChangeLog	2022-02-23 15:20:31 UTC (rev 290371)
@@ -1,3 +1,14 @@
+2022-02-23  Alex Christensen  
+
+Call WKNavigationDelegate.didFailProvisionalNavigation even after a cross-origin navigation with COOP
+https://bugs.webkit.org/show_bug.cgi?id=237071
+
+
+Reviewed by Chris Dumez.
+
+* TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
+(TEST):
+
 2022-02-23  Angelos Oikonomopoulos  
 
 [JSC] Set ssh keepalive in run-jsc-stress-tests


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm (290370 => 290371)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm	2022-02-23 14:59:57 UTC (rev 290370)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm	2022-02-23 15:20:31 UTC (rev 290371)
@@ -38,6 +38,8 @@
 #import 
 #import 
 #import 
+#import 
+#import 
 #import 
 #import 
 
@@ -1010,3 +1012,54 @@
 
 EXPECT_FALSE(didTryToLoadRadarURL);
 }
+
+TEST(WKNavigation, CrossOriginCOOPCancelResponseFailProvisionalNavigationCallback)
+{
+using namespace TestWebKitAPI;
+HTTPServer server({
+{ "/path1", { "hi" } },
+{ "/path2", { "hi" } },
+{ "/path3", { { { "Cross-Origin-Opener-Policy", "same-origin" } }, "hi" } }
+}, HTTPServer::Protocol::HttpsProxy);
+
+auto storeConfiguration = adoptNS([[_WKWebsiteDataStoreConfiguration alloc] initNonPersistentConfiguration]);
+[storeConfiguration setProxyConfiguration:@{
+(NSString *)kCFStreamPropertyHTTPSProxyHost: @"127.0.0.1",
+(NSString *)kCFStreamPropertyHTTPSProxyPort: @(server.port())
+}];
+auto dataStore = adoptNS([[WKWebsiteDataStore alloc] _initWithConfiguration:storeConfiguration.get()]);
+auto configuration = adoptNS([WKWebViewConfiguration new]);
+[configuration setWebsiteDataStore:dataStore.get()];
+auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectZero configuration:configuration.get()]);
+
+__block Vector finishedSuccessfullyCallbacks;
+

[webkit-changes] [290370] trunk/Source/WebKit

2022-02-23 Thread commit-queue

Title: [290370] trunk/Source/WebKit








Revision 290370
Author commit-qu...@webkit.org
Date 2022-02-23 06:59:57 -0800 (Wed, 23 Feb 2022)


Log Message
[GLib] Add missing WebPage.h inclusion in WebProcessGLib.cpp
https://bugs.webkit.org/show_bug.cgi?id=237081

Unreviewed, adding the WebPage.h header inclusion in WebProcessGLib.cpp
to avoid incomplete-type errors for the WebPage class under a certain
combination of unified sources.

Patch by Zan Dobersek  on 2022-02-23

* WebProcess/glib/WebProcessGLib.cpp:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290369 => 290370)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 14:01:56 UTC (rev 290369)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 14:59:57 UTC (rev 290370)
@@ -1,3 +1,14 @@
+2022-02-23  Zan Dobersek  
+
+[GLib] Add missing WebPage.h inclusion in WebProcessGLib.cpp
+https://bugs.webkit.org/show_bug.cgi?id=237081
+
+Unreviewed, adding the WebPage.h header inclusion in WebProcessGLib.cpp
+to avoid incomplete-type errors for the WebPage class under a certain
+combination of unified sources.
+
+* WebProcess/glib/WebProcessGLib.cpp:
+
 2022-02-23  Youenn Fablet  
 
 RemoteVideoFrameObjectHeap::getVideoFrameBuffer can use base class pixelBuffer accessor


Modified: trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp (290369 => 290370)

--- trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp	2022-02-23 14:01:56 UTC (rev 290369)
+++ trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp	2022-02-23 14:59:57 UTC (rev 290370)
@@ -29,6 +29,7 @@
 
 #include "WebKitExtensionManager.h"
 #include "WebKitWebExtensionPrivate.h"
+#include "WebPage.h"
 #include "WebProcessCreationParameters.h"
 
 #if USE(GSTREAMER)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290369] trunk/Tools

2022-02-23 Thread angelos

Title: [290369] trunk/Tools








Revision 290369
Author ange...@igalia.com
Date 2022-02-23 06:01:56 -0800 (Wed, 23 Feb 2022)


Log Message
[JSC] Set ssh keepalive in run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=237031

Reviewed by Adrian Perez de Castro.

If a remote goes down after an ssh connection has been established, we
need to be able to detect that. Keep the common ssh config options in
one constant and add ServerAliveInterval=30 to it.

While here, change sshRead to execute ssh directly (instead of
going through the shell). Similarly, don't open-code the read
loop, just call IO.read.

* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/Tools/ChangeLog (290368 => 290369)

--- trunk/Tools/ChangeLog	2022-02-23 13:47:10 UTC (rev 290368)
+++ trunk/Tools/ChangeLog	2022-02-23 14:01:56 UTC (rev 290369)
@@ -1,3 +1,20 @@
+2022-02-23  Angelos Oikonomopoulos  
+
+[JSC] Set ssh keepalive in run-jsc-stress-tests
+https://bugs.webkit.org/show_bug.cgi?id=237031
+
+Reviewed by Adrian Perez de Castro.
+
+If a remote goes down after an ssh connection has been established, we
+need to be able to detect that. Keep the common ssh config options in
+one constant and add ServerAliveInterval=30 to it.
+
+While here, change sshRead to execute ssh directly (instead of
+going through the shell). Similarly, don't open-code the read
+loop, just call IO.read.
+
+* Scripts/run-jsc-stress-tests:
+
 2022-02-23  Kimmo Kinnunen  
 
 Fix GPUP WebGL generator script wrt uninitialised sized span


Modified: trunk/Tools/Scripts/run-jsc-stress-tests (290368 => 290369)

--- trunk/Tools/Scripts/run-jsc-stress-tests	2022-02-23 13:47:10 UTC (rev 290368)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2022-02-23 14:01:56 UTC (rev 290369)
@@ -87,6 +87,13 @@
   :iterationsCeiling => 10)
 
 REMOTE_TIMEOUT = 120
+SSH_OPTIONS_DEFAULT = [
+"-o",
+"NoHostAuthenticationForLocalhost=yes",
+"-o",
+"ServerAliveInterval=30",
+]
+
 begin
 require 'shellwords'
 rescue Exception => e
@@ -2550,12 +2557,13 @@
 raise unless $remote
 
 result = ""
-IO.popen("ssh -o NoHostAuthenticationForLocalhost=yes -p #{remoteHost.port}" + (remoteHost.identity_file_path ? " -i #{remoteHost.identity_file_path}" : "") + " #{remoteHost.user}@#{remoteHost.host} '#{cmd}'", "r") {
-  | inp |
-  inp.each_line {
-| line |
-result += line
-  }
+ssh_cmd = ["ssh"] +
+  SSH_OPTIONS_DEFAULT +
+  ["-p", remoteHost.port.to_s] +
+  (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) +
+ ["#{remoteHost.user}@#{remoteHost.host}", cmd]
+IO.popen(ssh_cmd, "r") { |inp|
+result = inp.read
 }
 raise "#{$?}" unless $?.success? or options[:ignoreFailure]
 result
@@ -2689,8 +2697,8 @@
 end
 
 def copyBundleToRemote(remoteHost)
-mysys(["ssh", "-o", "NoHostAuthenticationForLocalhost=yes"] + (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) + ["-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", "mkdir -p #{remoteHost.remoteDirectory}"])
-mysys(["scp", "-o", "NoHostAuthenticationForLocalhost=yes"] + (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) + ["-P", remoteHost.port.to_s, ($outputDir.dirname + $tarFileName).to_s, "#{remoteHost.user}@#{remoteHost.host}:#{remoteHost.remoteDirectory}"])
+mysys(["ssh"] + SSH_OPTIONS_DEFAULT + (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) + ["-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", "mkdir -p #{remoteHost.remoteDirectory}"])
+mysys(["scp"] + SSH_OPTIONS_DEFAULT + (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) + ["-P", remoteHost.port.to_s, ($outputDir.dirname + $tarFileName).to_s, "#{remoteHost.user}@#{remoteHost.host}:#{remoteHost.remoteDirectory}"])
 end
 
 def exportBaseEnvironmentVariables(escape)
@@ -2724,7 +2732,7 @@
 remoteScript += exportBaseEnvironmentVariables(true)
 $envVars.each { |var| remoteScript += "export " << var << "\n" }
 remoteScript += "#{testRunner.command(remoteIndex)}\""
-runAndMonitorTestRunnerCommand(["ssh", "-o", "NoHostAuthenticationForLocalhost=yes"] + (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) + ["-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", remoteScript])
+runAndMonitorTestRunnerCommand(["ssh"] + SSH_OPTIONS_DEFAULT + (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) + ["-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", remoteScript])
 else
 Dir.chdir($runnerDir) {
 runAndMonitorTestRunnerCommand(Shellwords.shellsplit(testRunner

[webkit-changes] [290368] trunk/Source

2022-02-23 Thread youenn

Title: [290368] trunk/Source








Revision 290368
Author you...@apple.com
Date 2022-02-23 05:47:10 -0800 (Wed, 23 Feb 2022)


Log Message
RemoteVideoFrameObjectHeap::getVideoFrameBuffer can use base class pixelBuffer accessor
https://bugs.webkit.org/show_bug.cgi?id=237020

Reviewed by Kimmo Kinnunen.

Source/WebCore:

No change of behavior.
Covered by existing tests.

* platform/graphics/cv/VideoFrameCV.h:
(WebCore::VideoFrameC$V::pixelBuffer const: Mark it as final.

Source/WebKit:

Make use of pixelBuffer virtual method to simplify things.
Add a missing early return in case of not found pixel buffer.

* GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
(WebKit::RemoteVideoFrameObjectHeap::getVideoFrameBuffer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cv/VideoFrameCV.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (290367 => 290368)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 13:19:45 UTC (rev 290367)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 13:47:10 UTC (rev 290368)
@@ -1,3 +1,16 @@
+2022-02-23  Youenn Fablet  
+
+RemoteVideoFrameObjectHeap::getVideoFrameBuffer can use base class pixelBuffer accessor
+https://bugs.webkit.org/show_bug.cgi?id=237020
+
+Reviewed by Kimmo Kinnunen.
+
+No change of behavior.
+Covered by existing tests.
+
+* platform/graphics/cv/VideoFrameCV.h:
+(WebCore::VideoFrameC$V::pixelBuffer const: Mark it as final.
+
 2022-02-23  Zan Dobersek  
 
 [GStreamer] Add WebKitDMABufVideoSink


Modified: trunk/Source/WebCore/platform/graphics/cv/VideoFrameCV.h (290367 => 290368)

--- trunk/Source/WebCore/platform/graphics/cv/VideoFrameCV.h	2022-02-23 13:19:45 UTC (rev 290367)
+++ trunk/Source/WebCore/platform/graphics/cv/VideoFrameCV.h	2022-02-23 13:47:10 UTC (rev 290368)
@@ -40,7 +40,7 @@
 WEBCORE_EXPORT static Ref create(MediaTime presentationTime, bool isMirrored, VideoRotation, RetainPtr&&);
 WEBCORE_EXPORT ~VideoFrameCV();
 
-CVPixelBufferRef pixelBuffer() const { return m_pixelBuffer.get(); }
+CVPixelBufferRef pixelBuffer() const final { return m_pixelBuffer.get(); }
 ImageOrientation orientation() const;
 
 template void encode(Encoder&) const;


Modified: trunk/Source/WebKit/ChangeLog (290367 => 290368)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 13:19:45 UTC (rev 290367)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 13:47:10 UTC (rev 290368)
@@ -1,3 +1,16 @@
+2022-02-23  Youenn Fablet  
+
+RemoteVideoFrameObjectHeap::getVideoFrameBuffer can use base class pixelBuffer accessor
+https://bugs.webkit.org/show_bug.cgi?id=237020
+
+Reviewed by Kimmo Kinnunen.
+
+Make use of pixelBuffer virtual method to simplify things.
+Add a missing early return in case of not found pixel buffer.
+
+* GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
+(WebKit::RemoteVideoFrameObjectHeap::getVideoFrameBuffer):
+
 2022-02-23  Kimmo Kinnunen  
 
 Fix GPUP WebGL generator script wrt uninitialised sized span


Modified: trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp (290367 => 290368)

--- trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp	2022-02-23 13:19:45 UTC (rev 290367)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp	2022-02-23 13:47:10 UTC (rev 290368)
@@ -94,22 +94,27 @@
 auto identifier = read.identifier();
 auto videoFrame = retire(WTFMove(read), 0_s);
 
-if (!videoFrame)
+if (!videoFrame) {
 m_connection->send(Messages::RemoteVideoFrameObjectHeapProxyProcessor::VideoFrameBufferNotFound { identifier }, 0);
-RetainPtr pixelBuffer;
-if (is(videoFrame))
-pixelBuffer = downcast(*videoFrame).pixelBuffer();
-else if (is(*videoFrame))
-pixelBuffer = downcast(*videoFrame).pixelBuffer();
-else {
+return;
+}
+
+auto pixelBuffer = videoFrame->pixelBuffer();
+if (!pixelBuffer) {
+m_connection->send(Messages::RemoteVideoFrameObjectHeapProxyProcessor::VideoFrameBufferNotFound { identifier }, 0);
 ASSERT_NOT_REACHED();
 return;
 }
 
-m_sharedVideoFrameWriter.write(pixelBuffer.get(),
+bool result = m_sharedVideoFrameWriter.write(pixelBuffer,
 [&](auto& semaphore) { m_connection->send(Messages::RemoteVideoFrameObjectHeapProxyProcessor::SetSharedVideoFrameSemaphore { semaphore }, 0); },
 [&](auto& handle) { m_connection->send(Messages::RemoteVideoFrameObjectHeapProxyProcessor::SetSharedVideoFrameMemory { handle }, 0); }
 );
+if (!result) {
+// FIXME: We should ASSERT_NOT_REACHED once we support enough pixel buffer types.
+m_connection->send(Messages::RemoteVideoFrameObjectHeapProxyProcessor::VideoFrameBufferNotFound { identifier }, 0);
+return;
+}
 m_connection->send(Messages::RemoteVide

[webkit-changes] [290367] trunk

2022-02-23 Thread commit-queue

Title: [290367] trunk








Revision 290367
Author commit-qu...@webkit.org
Date 2022-02-23 05:19:45 -0800 (Wed, 23 Feb 2022)


Log Message
Fix GPUP WebGL generator script wrt uninitialised sized span
https://bugs.webkit.org/show_bug.cgi?id=235889

Patch by Kimmo Kinnunen  on 2022-02-23
Reviewed by Antti Koivisto.
Source/WebKit:

Regenerated.

* WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
(WebKit::RemoteGraphicsContextGLProxy::getShaderPrecisionFormat):

Tools:

Fix the generator. The r290328 only edited the generated files.
Add a other hunk missing from r290175.

* Scripts/generate-gpup-webgl:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/generate-gpup-webgl




Diff

Modified: trunk/Source/WebKit/ChangeLog (290366 => 290367)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 12:27:24 UTC (rev 290366)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 13:19:45 UTC (rev 290367)
@@ -1,5 +1,17 @@
 2022-02-23  Kimmo Kinnunen  
 
+Fix GPUP WebGL generator script wrt uninitialised sized span
+https://bugs.webkit.org/show_bug.cgi?id=235889
+
+Reviewed by Antti Koivisto.
+
+Regenerated.
+
+* WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
+(WebKit::RemoteGraphicsContextGLProxy::getShaderPrecisionFormat):
+
+2022-02-23  Kimmo Kinnunen  
+
 Thread safety analysis macros are confusing for non-Lock use-cases
 https://bugs.webkit.org/show_bug.cgi?id=237022
 


Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp (290366 => 290367)

--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp	2022-02-23 12:27:24 UTC (rev 290366)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp	2022-02-23 13:19:45 UTC (rev 290367)
@@ -686,8 +686,8 @@
 
 void RemoteGraphicsContextGLProxy::getShaderPrecisionFormat(GCGLenum shaderType, GCGLenum precisionType, GCGLSpan range, GCGLint* precision)
 {
-constexpr std::array emptyRangeReply { 0, 0 };
-IPC::ArrayReference rangeReply { emptyRangeReply };
+constexpr std::array rangeReplyEmpty { };
+IPC::ArrayReference rangeReply { rangeReplyEmpty };
 int32_t precisionReply = { };
 if (!isContextLost()) {
 auto sendResult = sendSync(Messages::RemoteGraphicsContextGL::GetShaderPrecisionFormat(shaderType, precisionType), Messages::RemoteGraphicsContextGL::GetShaderPrecisionFormat::Reply(rangeReply, precisionReply));


Modified: trunk/Tools/ChangeLog (290366 => 290367)

--- trunk/Tools/ChangeLog	2022-02-23 12:27:24 UTC (rev 290366)
+++ trunk/Tools/ChangeLog	2022-02-23 13:19:45 UTC (rev 290367)
@@ -1,3 +1,14 @@
+2022-02-23  Kimmo Kinnunen  
+
+Fix GPUP WebGL generator script wrt uninitialised sized span
+https://bugs.webkit.org/show_bug.cgi?id=235889
+
+Reviewed by Antti Koivisto.
+Fix the generator. The r290328 only edited the generated files.
+Add a other hunk missing from r290175.
+
+* Scripts/generate-gpup-webgl:
+
 2022-02-23  Zan Dobersek  
 
 [GStreamer] Add WebKitDMABufVideoSink


Modified: trunk/Tools/Scripts/generate-gpup-webgl (290366 => 290367)

--- trunk/Tools/Scripts/generate-gpup-webgl	2022-02-23 12:27:24 UTC (rev 290366)
+++ trunk/Tools/Scripts/generate-gpup-webgl	2022-02-23 13:19:45 UTC (rev 290367)
@@ -105,7 +105,9 @@
 void GetError() -> (uint32_t returnValue) Synchronous
 void PaintRenderingResultsToCanvas(WebCore::RenderingResourceIdentifier imageBuffer) -> () Synchronous
 void PaintCompositedResultsToCanvas(WebCore::RenderingResourceIdentifier imageBuffer) -> () Synchronous
-void CopyTextureFromMedia(WebCore::MediaPlayerIdentifier identifier, uint32_t texture, uint32_t target, int32_t level, uint32_t internalFormat, uint32_t format, uint32_t type, bool premultiplyAlpha, bool flipY) -> (bool success) Synchronous
+#if ENABLE(VIDEO)
+void CopyTextureFromVideoFrame(WebKit::RemoteVideoFrameReadReference videoFrame, uint32_t texture, uint32_t target, int32_t level, uint32_t internalFormat, uint32_t format, uint32_t type, bool premultiplyAlpha, bool flipY) -> (bool success) Synchronous
+#endif
 #if ENABLE(MEDIA_STREAM)
 void PaintCompositedResultsToMediaSample() -> (std::optional properties) Synchronous
 #endif
@@ -646,10 +648,10 @@
 if o.type.is_dynamic_span():
 self.pre_call_stmts += [f"{str(v.type)} {str(v.name)};"]
 else:
-# FIXME: Likely this creates a dangling reference span aReply = { { } };.
-# https://bugs.webkit.org/show_bug.cgi?id=235889
-self.pre_call_stmts += [f"{str(v.type)} {str(v.name)} {{ {{ }} }};"]
-
+self.pre_call_stmts += [
+

[webkit-changes] [290366] trunk

2022-02-23 Thread commit-queue

Title: [290366] trunk








Revision 290366
Author commit-qu...@webkit.org
Date 2022-02-23 04:27:24 -0800 (Wed, 23 Feb 2022)


Log Message
[GStreamer] Add WebKitDMABufVideoSink
https://bugs.webkit.org/show_bug.cgi?id=236883

Patch by Zan Dobersek  on 2022-02-23
Reviewed by Philippe Normand.

.:

* Source/cmake/FindGStreamer.cmake:
Also search for gstreamer-allocators-1.0, produce the relevant variables
containing include directories and cflags.

Source/WebCore:

Add custom WebKitDMABufVideoSink sink that is able to accept decoded
dmabuf or raw data in a range of RGB-like or YUV formats.

The sink is pretty straightforward, in large part mirroring the
WebKitGLVideoSink implementation. The formats that (at the moment) we
can correctly handle inside the TextureMapper-based graphics pipeline
are combined with both the dmabuf or raw memory type during the caps
construction. Like the GL counterpart, the received samples are passed
on to the associated MediaPlayerPrivateGStreamer object. The common
integration into the MediaPlayerPrivateGStreamer functionality is
encapsulated into the webKitVideoSinkSetMediaPlayerPrivate() function.

The MediaPlayerPrivateGStreamer implementation will be enhanced later to
properly handle samples conforming to either variant of these caps. But
the idea is that when using this sink, a dmabuf-containing sample will
pass the dmabuf to the graphics subsystem and a raw-data-containing
sample will copy the data into a dmabuf object (created or reused) and
then pass it on.

The WEBKIT_GST_DMABUF_SINK_FORCED_FALLBACK_CAPS_FORMAT environment
variable can be set to specify the desired exclusive format that this
sink should support. This is especially helpful to debug the correct
handling of different RGB or YUV formats inside the graphics pipeline.
When set, only raw data of the specified format is accepted, meaning the
pipeline upstream will perform any necessary conversion of the decoded
data into the desired format. Raw data is then packed into dmabufs and
sent into the pipeline for display, enabling the developer to examine
whether the given format is handled appropriately.

The sink element is registered in registerWebKitGStreamerElements().
This functionality will require The GStreamer allocators library, so the
necessary dependency glue is also provided.

* platform/GStreamer.cmake:
* platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: Added.
(forcedFallbackCapsFormat):
(webKitDMABufVideoSinkConstructed):
(webKitDMABufVideoSinkFinalize):
(webKitDMABufVideoSinkGetProperty):
(webkit_dmabuf_video_sink_class_init):
(webKitDMABufVideoSinkSetMediaPlayerPrivate):
(webKitDMABufVideoSinkProbePlatform):
* platform/graphics/gstreamer/DMABufVideoSinkGStreamer.h: Added.
* platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(webKitGLVideoSinkSetMediaPlayerPrivate):
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):
* platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp: Added.
(webKitVideoSinkSetMediaPlayerPrivate):
* platform/graphics/gstreamer/GStreamerVideoSinkCommon.h: Added.

Tools:

* Scripts/webkitpy/style/checker.py:
Add two additional files under the GObject-style exceptions.

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/GStreamer.cmake
trunk/Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
trunk/Source/cmake/FindGStreamer.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checker.py


Added Paths

trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.h




Diff

Modified: trunk/ChangeLog (290365 => 290366)

--- trunk/ChangeLog	2022-02-23 12:06:12 UTC (rev 290365)
+++ trunk/ChangeLog	2022-02-23 12:27:24 UTC (rev 290366)
@@ -1,3 +1,14 @@
+2022-02-23  Zan Dobersek  
+
+[GStreamer] Add WebKitDMABufVideoSink
+https://bugs.webkit.org/show_bug.cgi?id=236883
+
+Reviewed by Philippe Normand.
+
+* Source/cmake/FindGStreamer.cmake:
+Also search for gstreamer-allocators-1.0, produce the relevant variables
+containing include directories and cflags.
+
 2022-02-22  Philippe Normand  
 
 [GStreamer] Initial MediaRecorder implementation


Modified: trunk/Source/WebCore/ChangeLog (290365 => 290366)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 12:06:12 UTC (rev 290365)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 12:27:24 UTC (rev 290366)
@@ -1,3 +1,61 @@
+2022-02-23  Zan Dobersek  
+
+[GStreamer] Add WebKitDMABufVideoSink
+https://bugs.webkit.org/show_bug.cgi?id=236883
+
+Reviewed by Philippe Normand.
+
+Add custom WebKitDMABufVideoSink sink that is able to accept d

[webkit-changes] [290365] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-02-23 Thread carlosgc

Title: [290365] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 290365
Author carlo...@webkit.org
Date 2022-02-23 04:06:12 -0800 (Wed, 23 Feb 2022)


Log Message
Merge r290360 - [GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called
https://bugs.webkit.org/show_bug.cgi?id=217655

Stop the run loop for GTK and WPE to ensure a normal exit, since we need
atexit handlers to be called to cleanup resources like EGL displays.

Reviewed by Carlos Garcia Campos.

* Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::didClose):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
* WebProcess/WebProcess.h:
* WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.h
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-23 12:06:12 UTC (rev 290365)
@@ -1,3 +1,21 @@
+2022-02-23  Pablo Saavedra  
+
+[GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called
+https://bugs.webkit.org/show_bug.cgi?id=217655
+
+Stop the run loop for GTK and WPE to ensure a normal exit, since we need
+atexit handlers to be called to cleanup resources like EGL displays.
+
+Reviewed by Carlos Garcia Campos.
+
+* Shared/AuxiliaryProcess.cpp:
+(WebKit::AuxiliaryProcess::didClose):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeConnection):
+* WebProcess/WebProcess.h:
+* WebProcess/glib/WebProcessGLib.cpp:
+(WebKit::WebProcess::stopRunLoop):
+
 2022-02-22  Kate Cheney  
 
 NSSharingServicePicker gets deallocated when using the standard share menu item


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-02-23 12:06:12 UTC (rev 290365)
@@ -60,7 +60,13 @@
 
 void AuxiliaryProcess::didClose(IPC::Connection&)
 {
+// Stop the run loop for GTK and WPE to ensure a normal exit, since we need
+// atexit handlers to be called to cleanup resources like EGL displays.
+#if PLATFORM(GTK) || PLATFORM(WPE)
+stopRunLoop();
+#else
 _exit(EXIT_SUCCESS);
+#endif
 }
 
 void AuxiliaryProcess::initialize(const AuxiliaryProcessInitializationParameters& parameters)


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp	2022-02-23 12:06:12 UTC (rev 290365)
@@ -257,6 +257,7 @@
 using namespace JSC;
 using namespace WebCore;
 
+#if !PLATFORM(GTK) && !PLATFORM(WPE)
 NO_RETURN static void callExit(IPC::Connection*)
 {
 #if OS(WINDOWS)
@@ -266,6 +267,7 @@
 _exit(EXIT_SUCCESS);
 #endif
 }
+#endif
 
 WebProcess& WebProcess::singleton()
 {
@@ -359,9 +361,13 @@
 {
 AuxiliaryProcess::initializeConnection(connection);
 
+// Do not call exit in background queue for GTK and WPE because we need to ensure
+// atexit handlers are called in the main thread to cleanup resources like EGL displays.
+#if !PLATFORM(GTK) && !PLATFORM(WPE)
 // We call _exit() directly from the background queue in case the main thread is unresponsive
 // and AuxiliaryProcess::didClose() does not get called.
 connection->setDidCloseOnConnectionWorkQueueCallback(callExit);
+#endif
 
 #if !PLATFORM(GTK) && !PLATFORM(WPE) && !ENABLE(IPC_TESTING_API)
 connection->setShouldExitOnSyncMessageSendFailure(true);


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.h (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.h	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.h	2022-02-23 12:06:12 UTC (rev 290365)
@@ -511,7 +511,7 @@
 bool shouldTerminate() override;
 void terminate() override;
 
-#if USE(APPKIT)
+#if USE(APPKIT) || PLATFORM(GTK) || PLATFORM(WPE)
 void stopRunLoop() override;
 #endif
 


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKi

[webkit-changes] [290364] releases/WebKitGTK/webkit-2.36/Source/WebCore

2022-02-23 Thread carlosgc

Title: [290364] releases/WebKitGTK/webkit-2.36/Source/WebCore








Revision 290364
Author carlo...@webkit.org
Date 2022-02-23 04:06:05 -0800 (Wed, 23 Feb 2022)


Log Message
Merge r290299 - Properly uninitialize EGL display before termination
https://bugs.webkit.org/show_bug.cgi?id=236766

>From the docs [1], if contexts or surfaces associated with display
is current to any thread, they are not released until they
are no longer current as a result of eglMakeCurrent.

So call eglMakeCurrent() to such effect.

[1] https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglMakeCurrent.xhtml

Reviewed by Carlos Garcia Campos.

* platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::terminateEGLDisplay):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (290363 => 290364)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-02-23 11:49:04 UTC (rev 290363)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-02-23 12:06:05 UTC (rev 290364)
@@ -1,3 +1,21 @@
+2022-02-22  Pablo Saavedra  
+
+Properly uninitialize EGL display before termination
+https://bugs.webkit.org/show_bug.cgi?id=236766
+
+From the docs [1], if contexts or surfaces associated with display
+is current to any thread, they are not released until they
+are no longer current as a result of eglMakeCurrent.
+
+So call eglMakeCurrent() to such effect.
+
+[1] https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglMakeCurrent.xhtml
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/graphics/PlatformDisplay.cpp:
+(WebCore::PlatformDisplay::terminateEGLDisplay):
+
 2022-02-21  Alex Christensen  
 
 Improve const correctness for SecurityOrigin accessors


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp (290363 => 290364)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2022-02-23 11:49:04 UTC (rev 290363)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2022-02-23 12:06:05 UTC (rev 290364)
@@ -278,6 +278,7 @@
 ASSERT(m_eglDisplayInitialized);
 if (m_eglDisplay == EGL_NO_DISPLAY)
 return;
+eglMakeCurrent(m_eglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
 eglTerminate(m_eglDisplay);
 m_eglDisplay = EGL_NO_DISPLAY;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290363] trunk/Tools/CISupport/ews-build/steps_unittest.py

2022-02-23 Thread aakash_jain

Title: [290363] trunk/Tools/CISupport/ews-build/steps_unittest.py








Revision 290363
Author aakash_j...@apple.com
Date 2022-02-23 03:49:04 -0800 (Wed, 23 Feb 2022)


Log Message
Use python 3 f-strings in EWS - part 1
https://bugs.webkit.org/show_bug.cgi?id=237053

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-build/steps_unittest.py: Used f-strings for formatting.
(ExpectMasterShellCommand.__repr__):
(BuildStepMixinAdditions._checkSpawnProcess):
(BuildStepMixinAdditions._send_email):
(TestStepNameShouldBeValidIdentifier.test_step_names_are_valid):
(test_success):
(test_unexpected_failure):

Canonical link: https://commits.webkit.org/247681@main

Modified Paths

trunk/Tools/CISupport/ews-build/steps_unittest.py




Diff

Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (290362 => 290363)

--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-02-23 11:44:43 UTC (rev 290362)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-02-23 11:49:04 UTC (rev 290363)
@@ -97,7 +97,7 @@
 return self
 
 def __repr__(self):
-return 'ExpectMasterShellCommand({0})'.format(repr(self.args))
+return f'ExpectMasterShellCommand({repr(self.args)})'
 
 
 class BuildStepMixinAdditions(BuildStepMixin, TestReactorMixin):
@@ -165,7 +165,7 @@
 def _checkSpawnProcess(self, processProtocol, executable, args, env, path, usePTY, **kwargs):
 got = (executable, args, env, path, usePTY)
 if not self._expected_local_commands:
-self.fail('got local command {0} when no further commands were expected'.format(got))
+self.fail(f'got local command {got} when no further commands were expected')
 local_command = self._expected_local_commands.pop(0)
 try:
 self.assertEqual(got, (local_command.args[0], local_command.args, local_command.env, local_command.path, local_command.usePTY))
@@ -200,7 +200,7 @@
 if not subject or not text:
 self._emails_list.append('Error: skipping email since no subject or text is specified')
 return False
-self._emails_list.append('Subject: {}\nTo: {}\nReference: {}\nBody:\n\n{}'.format(subject, to_emails, reference, text))
+self._emails_list.append(f'Subject: {subject}\nTo: {to_emails}\nReference: {reference}\nBody:\n\n{text}')
 return True
 
 def runStep(self):
@@ -273,8 +273,8 @@
 for build_step in build_step_classes:
 if 'name' in vars(build_step[1]):
 name = build_step[1].name
-self.assertFalse(' ' in name, 'step name "{}" contain space.'.format(name))
-self.assertTrue(buildbot_identifiers.ident_re.match(name), 'step name "{}" is not a valid buildbot identifier.'.format(name))
+self.assertFalse(' ' in name, f'step name "{name}" contain space.')
+self.assertTrue(buildbot_identifiers.ident_re.match(name), f'step name "{name}" is not a valid buildbot identifier.')
 
 
 class TestCheckStyle(BuildStepMixinAdditions, unittest.TestCase):
@@ -464,7 +464,7 @@
 ExpectShell(workdir='wkdir',
 timeout=300,
 logEnviron=False,
-command=['python3', 'Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
+command=['python3', 'Tools/Scripts/run-bindings-tests', f'--json-output={self.jsonFileName}'],
 logfiles={'json': self.jsonFileName},
 )
 + 0,
@@ -478,7 +478,7 @@
 ExpectShell(workdir='wkdir',
 timeout=300,
 logEnviron=False,
-command=['python3', 'Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
+command=['python3', 'Tools/Scripts/run-bindings-tests', f'--json-output={self.jsonFileName}'],
 logfiles={'json': self.jsonFileName},
 )
 + ExpectShell.log('stdio', stdout='FAIL: (JS) JSTestInterface.cpp')
@@ -547,7 +547,7 @@
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
 logEnviron=False,
-command=['python', 'Tools/Scripts/test-webkitpy', '--verbose', '--json-output={0}'.format(self.jsonFileName)],
+command=['python', 'Tools/Scripts/test-webkitpy', '--verbose', f'--json-output={self.jsonFileName}'],
 logfiles={'json': self.jsonFileName},
 timeout=120,
 )
@@ -561,7 +561,7 @@
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
 logEnviron=False,
-command=['python', 'Tools/Scripts/test-webkitpy', '--verbose', '--json-output={0}'.format(self.jsonFileName)],
+command=['python', 'Tools/Scripts/test-webkitpy'

[webkit-changes] [290362] trunk/LayoutTests

2022-02-23 Thread alex

Title: [290362] trunk/LayoutTests








Revision 290362
Author a...@webkit.org
Date 2022-02-23 03:44:43 -0800 (Wed, 23 Feb 2022)


Log Message
Unreviewed test gardening.

These tests had incorrect expected results with failing tests for
glib.

* platform/glib/TestExpectations:
* platform/glib/webgl/1.0.3/conformance/context/context-lost-restored-expected.txt: Removed.
* platform/glib/webgl/1.0.3/conformance/extensions/oes-texture-half-float-expected.txt: Removed.
* platform/glib/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-s3tc-expected.txt: Removed.
* platform/glib/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt: Removed.
* platform/glib/webgl/1.0.3/conformance/misc/webgl-specific-expected.txt: Removed.
* platform/glib/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Removed.
* platform/glib/webgl/1.0.3/conformance/rendering/point-no-attributes-expected.txt: Removed.
* platform/glib/webgl/1.0.3/conformance/textures/texture-copying-feedback-loops-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations


Removed Paths

trunk/LayoutTests/platform/glib/webgl/1.0.3/conformance/context/
trunk/LayoutTests/platform/glib/webgl/1.0.3/conformance/extensions/
trunk/LayoutTests/platform/glib/webgl/1.0.3/conformance/misc/
trunk/LayoutTests/platform/glib/webgl/1.0.3/conformance/renderbuffers/
trunk/LayoutTests/platform/glib/webgl/1.0.3/conformance/rendering/
trunk/LayoutTests/platform/glib/webgl/1.0.3/conformance/textures/




Diff

Modified: trunk/LayoutTests/ChangeLog (290361 => 290362)

--- trunk/LayoutTests/ChangeLog	2022-02-23 09:59:12 UTC (rev 290361)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 11:44:43 UTC (rev 290362)
@@ -1,3 +1,20 @@
+2022-02-23  Alejandro G. Castro  
+
+Unreviewed test gardening.
+
+These tests had incorrect expected results with failing tests for
+glib.
+
+* platform/glib/TestExpectations:
+* platform/glib/webgl/1.0.3/conformance/context/context-lost-restored-expected.txt: Removed.
+* platform/glib/webgl/1.0.3/conformance/extensions/oes-texture-half-float-expected.txt: Removed.
+* platform/glib/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-s3tc-expected.txt: Removed.
+* platform/glib/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt: Removed.
+* platform/glib/webgl/1.0.3/conformance/misc/webgl-specific-expected.txt: Removed.
+* platform/glib/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Removed.
+* platform/glib/webgl/1.0.3/conformance/rendering/point-no-attributes-expected.txt: Removed.
+* platform/glib/webgl/1.0.3/conformance/textures/texture-copying-feedback-loops-expected.txt: Removed.
+
 2022-02-23  Kimmo Kinnunen  
 
 Crash when calling WEBGL_lose_context.loseContext() after the context has been lost


Modified: trunk/LayoutTests/platform/glib/TestExpectations (290361 => 290362)

--- trunk/LayoutTests/platform/glib/TestExpectations	2022-02-23 09:59:12 UTC (rev 290361)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2022-02-23 11:44:43 UTC (rev 290362)
@@ -1412,7 +1412,16 @@
 
 webkit.org/b/229052 webgl/1.0.x/conformance/textures/misc/texture-corner-case-videos.html [ Failure ]
 
+webkit.org/b/169917 webgl/1.0.3/conformance/context/context-lost-restored.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/extensions/oes-texture-half-float.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/extensions/webgl-compressed-texture-s3tc.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/misc/webgl-specific.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/rendering/point-no-attributes.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/textures/texture-copying-feedback-loops.html [ Failure ]
 
+
 #
 # End of WebGL-related bugs
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290361] trunk

2022-02-23 Thread commit-queue

Title: [290361] trunk








Revision 290361
Author commit-qu...@webkit.org
Date 2022-02-23 01:59:12 -0800 (Wed, 23 Feb 2022)


Log Message
Thread safety analysis macros are confusing for non-Lock use-cases
https://bugs.webkit.org/show_bug.cgi?id=237022

Patch by Kimmo Kinnunen  on 2022-02-23
Reviewed by Chris Dumez.

Source/WebKit:

Use WTF_GUARDED_BY_CAPABILITY instead of WTF_GUARDED_BY_LOCK
for non-lock use-cases.

* GPUProcess/graphics/RemoteGraphicsContextGL.h:
* GPUProcess/graphics/RemoteRenderingBackend.h:
* GPUProcess/graphics/WebGPU/RemoteGPU.h:
* GPUProcess/media/RemoteVideoFrameObjectHeap.h:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:

Source/WTF:

Thread safety analysis proves that a capability is acquired or not acquired.
Change the semantics of thread safety analysis application in WebKit:
  Before, we had only one capability, "lock".
  After, we have arbitrary amount of capabilities, one of which is "lock".

Add thread safety analysis macros to support non-Lock use-cases better.

Non-lock use-case:
Before:
  class WTF_CAPABILITY_LOCK ThreadAssertion { ... };
  "WTF::ThreadAssertion is obviously not a lock but we use the lock capability machinery to obtain the analysis support.
   It behaves like the lock capability and can be acquired."

After:
  class WTF_CAPABILITY("is current") ThreadAssertion { ... };
  "WTF::ThreadAssertion has a capability called 'is current' that can be acquired."

The documentation string "lock", "is current" will appear in the compile error messages to clarify the
violations.

* wtf/ThreadAssertions.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
* wtf/ThreadSafetyAnalysis.h:

Tools:

* Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
* TestWebKitAPI/Tests/WTF/ThreadAssertionsTest.cpp:
(TestWebKitAPI::WTF_REQUIRES_CAPABILITY):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ThreadAssertions.h
trunk/Source/WTF/wtf/ThreadSafetyAnalysis.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
trunk/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h
trunk/Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/TestWebKitAPI/Tests/WTF/ThreadAssertionsTest.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (290360 => 290361)

--- trunk/Source/WTF/ChangeLog	2022-02-23 09:32:13 UTC (rev 290360)
+++ trunk/Source/WTF/ChangeLog	2022-02-23 09:59:12 UTC (rev 290361)
@@ -1,3 +1,34 @@
+2022-02-23  Kimmo Kinnunen  
+
+Thread safety analysis macros are confusing for non-Lock use-cases
+https://bugs.webkit.org/show_bug.cgi?id=237022
+
+Reviewed by Chris Dumez.
+
+Thread safety analysis proves that a capability is acquired or not acquired.
+Change the semantics of thread safety analysis application in WebKit:
+  Before, we had only one capability, "lock".
+  After, we have arbitrary amount of capabilities, one of which is "lock".
+
+Add thread safety analysis macros to support non-Lock use-cases better.
+
+Non-lock use-case:
+Before:
+  class WTF_CAPABILITY_LOCK ThreadAssertion { ... };
+  "WTF::ThreadAssertion is obviously not a lock but we use the lock capability machinery to obtain the analysis support.
+   It behaves like the lock capability and can be acquired."
+
+After:
+  class WTF_CAPABILITY("is current") ThreadAssertion { ... };
+  "WTF::ThreadAssertion has a capability called 'is current' that can be acquired."
+
+The documentation string "lock", "is current" will appear in the compile error messages to clarify the
+violations.
+
+* wtf/ThreadAssertions.h:
+(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
+* wtf/ThreadSafetyAnalysis.h:
+
 2022-02-22  Chris Dumez  
 
 Add a URL constructor that takes a String


Modified: trunk/Source/WTF/wtf/ThreadAssertions.h (290360 => 290361)

--- trunk/Source/WTF/wtf/ThreadAssertions.h	2022-02-23 09:32:13 UTC (rev 290360)
+++ trunk/Source/WTF/wtf/ThreadAssertions.h	2022-02-23 09:59:12 UTC (rev 290361)
@@ -41,11 +41,11 @@
 // void doTask() { assertIsCurrent(m_ownerThread); doTaskImpl(); }
 // template void doTaskCompileFailure() { doTaskImpl(); }
 // private:
-// void doTaskImpl() WTF_REQUIRES_LOCK(m_ownerThread);
-// int m_value WTF_GUARDED_BY_LOCK(m_ownerThread) { 0 };
+// void doTaskImpl() WTF_REQUIRES_CAPABILITY(m_ownerThread);
+// int m_value WTF_GUARDED_BY_CAPABILITY(m_ownerThread) { 0 };
 // NO_UNIQUE_ADDRESS ThreadAssertion m_ownerThread;
 // };
-class WTF_CAPABILITY_LOCK ThreadAssertion {
+class WTF_CAPABILITY("is current") ThreadAssertion {
 public:
 ThreadAssertion() = default;
 enum UninitializedTag { Uninitiali

[webkit-changes] [290360] trunk/Source/WebKit

2022-02-23 Thread psaavedra

Title: [290360] trunk/Source/WebKit








Revision 290360
Author psaave...@igalia.com
Date 2022-02-23 01:32:13 -0800 (Wed, 23 Feb 2022)


Log Message
[GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called
https://bugs.webkit.org/show_bug.cgi?id=217655

Stop the run loop for GTK and WPE to ensure a normal exit, since we need
atexit handlers to be called to cleanup resources like EGL displays.

Reviewed by Carlos Garcia Campos.

* Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::didClose):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
* WebProcess/WebProcess.h:
* WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290359 => 290360)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 09:28:47 UTC (rev 290359)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 09:32:13 UTC (rev 290360)
@@ -1,3 +1,21 @@
+2022-02-23  Pablo Saavedra  
+
+[GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called
+https://bugs.webkit.org/show_bug.cgi?id=217655
+
+Stop the run loop for GTK and WPE to ensure a normal exit, since we need
+atexit handlers to be called to cleanup resources like EGL displays.
+
+Reviewed by Carlos Garcia Campos.
+
+* Shared/AuxiliaryProcess.cpp:
+(WebKit::AuxiliaryProcess::didClose):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeConnection):
+* WebProcess/WebProcess.h:
+* WebProcess/glib/WebProcessGLib.cpp:
+(WebKit::WebProcess::stopRunLoop):
+
 2022-02-23  Youenn Fablet  
 
 RemoteSampleBufferDisplayLayer::enqueueSample should not change media samples owned by its object heap


Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp (290359 => 290360)

--- trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-02-23 09:28:47 UTC (rev 290359)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-02-23 09:32:13 UTC (rev 290360)
@@ -60,7 +60,13 @@
 
 void AuxiliaryProcess::didClose(IPC::Connection&)
 {
+// Stop the run loop for GTK and WPE to ensure a normal exit, since we need
+// atexit handlers to be called to cleanup resources like EGL displays.
+#if PLATFORM(GTK) || PLATFORM(WPE)
+stopRunLoop();
+#else
 _exit(EXIT_SUCCESS);
+#endif
 }
 
 void AuxiliaryProcess::initialize(const AuxiliaryProcessInitializationParameters& parameters)


Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (290359 => 290360)

--- trunk/Source/WebKit/WebProcess/WebProcess.cpp	2022-02-23 09:28:47 UTC (rev 290359)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp	2022-02-23 09:32:13 UTC (rev 290360)
@@ -257,6 +257,7 @@
 using namespace JSC;
 using namespace WebCore;
 
+#if !PLATFORM(GTK) && !PLATFORM(WPE)
 NO_RETURN static void callExit(IPC::Connection*)
 {
 #if OS(WINDOWS)
@@ -266,6 +267,7 @@
 _exit(EXIT_SUCCESS);
 #endif
 }
+#endif
 
 WebProcess& WebProcess::singleton()
 {
@@ -359,9 +361,13 @@
 {
 AuxiliaryProcess::initializeConnection(connection);
 
+// Do not call exit in background queue for GTK and WPE because we need to ensure
+// atexit handlers are called in the main thread to cleanup resources like EGL displays.
+#if !PLATFORM(GTK) && !PLATFORM(WPE)
 // We call _exit() directly from the background queue in case the main thread is unresponsive
 // and AuxiliaryProcess::didClose() does not get called.
 connection->setDidCloseOnConnectionWorkQueueCallback(callExit);
+#endif
 
 #if !PLATFORM(GTK) && !PLATFORM(WPE) && !ENABLE(IPC_TESTING_API)
 connection->setShouldExitOnSyncMessageSendFailure(true);


Modified: trunk/Source/WebKit/WebProcess/WebProcess.h (290359 => 290360)

--- trunk/Source/WebKit/WebProcess/WebProcess.h	2022-02-23 09:28:47 UTC (rev 290359)
+++ trunk/Source/WebKit/WebProcess/WebProcess.h	2022-02-23 09:32:13 UTC (rev 290360)
@@ -511,7 +511,7 @@
 bool shouldTerminate() override;
 void terminate() override;
 
-#if USE(APPKIT)
+#if USE(APPKIT) || PLATFORM(GTK) || PLATFORM(WPE)
 void stopRunLoop() override;
 #endif
 


Modified: trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp (290359 => 290360)

--- trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp	2022-02-23 09:28:47 UTC (rev 290359)
+++ trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp	2022-02-23 09:32:13 UTC (rev 290360)
@@ -72,6 +72,20 @@
 
 using namespace WebCore;
 
+void WebProcess::stopRunLoop()
+{
+// Pages are normally closed after Close message is received from the UI
+// process, but it can happen that the connection is closed before the
+// Close message is processed because the UI process close the socket
+// right after sending the Close message. Close here any pending page to
+// ensure the th

[webkit-changes] [290359] trunk/Source/JavaScriptCore

2022-02-23 Thread aperez

Title: [290359] trunk/Source/_javascript_Core








Revision 290359
Author ape...@igalia.com
Date 2022-02-23 01:28:47 -0800 (Wed, 23 Feb 2022)


Log Message
Ensure generated inline assembler that setups segments returns to previous state
https://bugs.webkit.org/show_bug.cgi?id=236976

Reviewed by Yusuke Suzuki.

Use .previous in inline assembler in order to ensure that mixed emission of assembler
functions and other definitions correctly puts each of them in their rightful sections
in the output object code.

* assembler/MacroAssemblerARM64.cpp:
* assembler/MacroAssemblerARMv7.cpp:
* assembler/MacroAssemblerMIPS.cpp:
* assembler/MacroAssemblerX86Common.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (290358 => 290359)

--- trunk/Source/_javascript_Core/ChangeLog	2022-02-23 09:12:02 UTC (rev 290358)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-23 09:28:47 UTC (rev 290359)
@@ -1,3 +1,19 @@
+2022-02-23  Adrian Perez de Castro  
+
+Ensure generated inline assembler that setups segments returns to previous state
+https://bugs.webkit.org/show_bug.cgi?id=236976
+
+Reviewed by Yusuke Suzuki.
+
+Use .previous in inline assembler in order to ensure that mixed emission of assembler
+functions and other definitions correctly puts each of them in their rightful sections
+in the output object code.
+
+* assembler/MacroAssemblerARM64.cpp:
+* assembler/MacroAssemblerARMv7.cpp:
+* assembler/MacroAssemblerMIPS.cpp:
+* assembler/MacroAssemblerX86Common.cpp:
+
 2022-02-22  Chris Dumez  
 
 Add a URL constructor that takes a String


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp (290358 => 290359)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp	2022-02-23 09:12:02 UTC (rev 290358)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp	2022-02-23 09:28:47 UTC (rev 290359)
@@ -572,6 +572,7 @@
 #else
 "ret" "\n"
 #endif
+".previous" "\n"
 );
 #endif // COMPILER(GCC_COMPATIBLE)
 


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.cpp (290358 => 290359)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.cpp	2022-02-23 09:12:02 UTC (rev 290358)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.cpp	2022-02-23 09:28:47 UTC (rev 290359)
@@ -361,6 +361,7 @@
 // Restore the sp and pc.
 "ldr   sp, [sp, #" STRINGIZE_VALUE_OF(PROBE_CPU_SP_OFFSET) "]" "\n"
 "pop   { pc }" "\n"
+".previous" "\n"
 );
 #endif // COMPILER(GCC_COMPATIBLE)
 


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.cpp (290358 => 290359)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.cpp	2022-02-23 09:12:02 UTC (rev 290358)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.cpp	2022-02-23 09:28:47 UTC (rev 290359)
@@ -549,6 +549,7 @@
 "jr$ra" "\n"
 "nop" "\n"
 ".set pop" "\n"
+".previous" "\n"
 );
 #endif // COMPILER(GCC_COMPATIBLE)
 


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.cpp (290358 => 290359)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.cpp	2022-02-23 09:12:02 UTC (rev 290358)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.cpp	2022-02-23 09:28:47 UTC (rev 290359)
@@ -341,6 +341,7 @@
 "popl %ecx" "\n"
 "popl %ebp" "\n"
 "ret" "\n"
+".previous" "\n"
 );
 #endif
 
@@ -709,6 +710,7 @@
 "popq %rcx" "\n"
 "popq %rbp" "\n"
 "ret" "\n"
+".previous" "\n"
 );
 #endif // COMPILER(GCC_COMPATIBLE)
 #endif // CPU(X86_64)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290358] trunk/Source/WebKit

2022-02-23 Thread youenn

Title: [290358] trunk/Source/WebKit








Revision 290358
Author you...@apple.com
Date 2022-02-23 01:12:02 -0800 (Wed, 23 Feb 2022)


Log Message
RemoteSampleBufferDisplayLayer::enqueueSample should not change media samples owned by its object heap
https://bugs.webkit.org/show_bug.cgi?id=237025

Reviewed by Darin Adler.

>From past bugs, it is risky to change CMSampleBuffer dictionaries if they can be used on various threads (encoder, display layer...).
Instead, we create a new MediaSample that is wrapping the same CVPixelBufferRef, on which can safely apply setAsDisplayImmediately.

We introduce SharedVideoFrame as a replacement to RemoteVideoSample.
We beef up SharedVideoFrameWriter and SharedVideoFrameReader to handle any MediaSample,
with specific handling for remote frames, IOSurface frames or other in memory frames.
We make use of SharedVideoFrame in SampleBufferDisplayLayer, which allows to unify enqueueSample and enqueueCV in one IPC message,
which is easier to maintain.

We update call sites that create SharedVideoFrameReader to either take nullptr or a object heap reference when they will need it in the future.

Covered by existing tests.

* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
* GPUProcess/webrtc/RemoteMediaRecorder.cpp:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
* WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:
* WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
* WebProcess/GPU/webrtc/SharedVideoFrame.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in
trunk/Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h
trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (290357 => 290358)

--- trunk/Source/WebKit/ChangeLog	2022-02-23 08:50:18 UTC (rev 290357)
+++ trunk/Source/WebKit/ChangeLog	2022-02-23 09:12:02 UTC (rev 290358)
@@ -1,5 +1,36 @@
 2022-02-23  Youenn Fablet  
 
+RemoteSampleBufferDisplayLayer::enqueueSample should not change media samples owned by its object heap
+https://bugs.webkit.org/show_bug.cgi?id=237025
+
+Reviewed by Darin Adler.
+
+From past bugs, it is risky to change CMSampleBuffer dictionaries if they can be used on various threads (encoder, display layer...).
+Instead, we create a new MediaSample that is wrapping the same CVPixelBufferRef, on which can safely apply setAsDisplayImmediately.
+
+We introduce SharedVideoFrame as a replacement to RemoteVideoSample.
+We beef up SharedVideoFrameWriter and SharedVideoFrameReader to handle any MediaSample,
+with specific handling for remote frames, IOSurface frames or other in memory frames.
+We make use of SharedVideoFrame in SampleBufferDisplayLayer, which allows to unify enqueueSample and enqueueCV in one IPC message,
+which is easier to maintain.
+
+We update call sites that create SharedVideoFrameReader to either take nullptr or a object heap reference when they will need it in the future.
+
+Covered by existing tests.
+
+* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
+* GPUProcess/webrtc/RemoteMediaRecorder.cpp:
+* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
+* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
+* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
+* WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
+* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
+* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:
+* WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
+* WebProcess/GPU/webrtc/SharedVideoFrame.h:
+
+2022-02-23  Youenn Fablet  
+
 Optimize RemoteVideoFrame handling in WebProcess WebRTC pipeline
 https://bugs.webkit.org/show_bug.cgi?id=236970
 


Modified: trunk/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm (290357 => 290358)

--- trunk/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm	2022-02-23 08:50:18 UTC (rev 290357)
+++ trunk/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm	2022-02-23 09:12:02 UTC (rev 290358)
@@ -285,7 +285,7 @@
 return;
 
 if (!encoder->frameReader)
-

[webkit-changes] [290357] trunk/Source/WebCore

2022-02-23 Thread sihui_liu

Title: [290357] trunk/Source/WebCore








Revision 290357
Author sihui_...@apple.com
Date 2022-02-23 00:50:18 -0800 (Wed, 23 Feb 2022)


Log Message
REGRESSION(r289474): [iOS] ASSERTION FAILED: isMainThread() under WebCore::IDBServer::UniqueIDBDatabase::abortActiveTransactions()
https://bugs.webkit.org/show_bug.cgi?id=237066


Reviewed by Chris Dumez.

We no longer need the assertion because the function can be called on non-main thread since r289474, where we
started to abort transactions for suspension on WorkQueue. To avoid confusion, rename mainThreadAbortResult to
suspensionAbortResult.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortActiveTransactions):
* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setSuspensionAbortResult):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::suspensionAbortResult const):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setMainThreadAbortResult): Deleted.
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::mainThreadAbortResult const): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290356 => 290357)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 08:23:37 UTC (rev 290356)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 08:50:18 UTC (rev 290357)
@@ -1,3 +1,24 @@
+2022-02-23  Sihui Liu  
+
+REGRESSION(r289474): [iOS] ASSERTION FAILED: isMainThread() under WebCore::IDBServer::UniqueIDBDatabase::abortActiveTransactions()
+https://bugs.webkit.org/show_bug.cgi?id=237066
+
+
+Reviewed by Chris Dumez.
+
+We no longer need the assertion because the function can be called on non-main thread since r289474, where we 
+started to abort transactions for suspension on WorkQueue. To avoid confusion, rename mainThreadAbortResult to 
+suspensionAbortResult.
+
+* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
+(WebCore::IDBServer::UniqueIDBDatabase::abortActiveTransactions):
+* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
+(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setSuspensionAbortResult):
+(WebCore::IDBServer::UniqueIDBDatabaseTransaction::suspensionAbortResult const):
+(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setMainThreadAbortResult): Deleted.
+(WebCore::IDBServer::UniqueIDBDatabaseTransaction::mainThreadAbortResult const): Deleted.
+
 2022-02-23  Kimmo Kinnunen  
 
 Crash when calling WEBGL_lose_context.loseContext() after the context has been lost


Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (290356 => 290357)

--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2022-02-23 08:23:37 UTC (rev 290356)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2022-02-23 08:50:18 UTC (rev 290357)
@@ -1184,9 +1184,8 @@
 return;
 }
 
-// If transaction is already aborted on the main thread for suspension,
-// return the result of that abort.
-if (auto existingAbortResult = takenTransaction->mainThreadAbortResult()) {
+// If transaction is already aborted for suspension, return the result of that abort.
+if (auto existingAbortResult = takenTransaction->suspensionAbortResult()) {
 callback(*existingAbortResult);
 transactionCompleted(WTFMove(takenTransaction));
 return;
@@ -1475,11 +1474,9 @@
 
 void UniqueIDBDatabase::abortActiveTransactions()
 {
-ASSERT(isMainThread());
-
 for (auto& identifier : copyToVector(m_inProgressTransactions.keys())) {
 auto transaction = m_inProgressTransactions.get(identifier);
-transaction->setMainThreadAbortResult(m_backingStore->abortTransaction(transaction->info().identifier()));
+transaction->setSuspensionAbortResult(m_backingStore->abortTransaction(transaction->info().identifier()));
 }
 }
 


Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h (290356 => 290357)

--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h	2022-02-23 08:23:37 UTC (rev 290356)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h	2022-02-23 08:50:18 UTC (rev 290357)
@@ -87,8 +87,8 @@
 
 const Vector& objectStoreIdentifiers();
 
-void setMainThreadAbortResult(const IDBError& error) { m_mainThreadAbortResult = { error }; }
-const std::optional& mainThreadAbortResult() const { return m_mainThreadAbortResult; }
+void setSuspensionAbortResult(const IDBError& error) { m_suspensionAbortResult = { error }; }
+const std::optional& sus

[webkit-changes] [290356] trunk

2022-02-23 Thread commit-queue

Title: [290356] trunk








Revision 290356
Author commit-qu...@webkit.org
Date 2022-02-23 00:23:37 -0800 (Wed, 23 Feb 2022)


Log Message
Crash when calling WEBGL_lose_context.loseContext() after the context has been lost
https://bugs.webkit.org/show_bug.cgi?id=236966

Patch by Kimmo Kinnunen  on 2022-02-23
Reviewed by Dean Jackson.

Source/WebCore:

WebGLRenderingContextBase::forceLostContext() would
try to synthesize a GL error to the underlying
m_context. However, m_context is cleared when a real
context loss happens. This happens for example when we
simulate a GPU status failure or when we create too
many contexts. The m_context is not currently cleared
when the page simulates context lost via WEBGL_lose_contexts.loseContext().

Test: webgl/lose-context-after-context-lost.html

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::synthesizeGLError):

LayoutTests:

* webgl/lose-context-after-context-lost-expected.txt: Added.
* webgl/lose-context-after-context-lost.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp


Added Paths

trunk/LayoutTests/webgl/lose-context-after-context-lost-expected.txt
trunk/LayoutTests/webgl/lose-context-after-context-lost.html




Diff

Modified: trunk/LayoutTests/ChangeLog (290355 => 290356)

--- trunk/LayoutTests/ChangeLog	2022-02-23 08:16:29 UTC (rev 290355)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 08:23:37 UTC (rev 290356)
@@ -1,3 +1,13 @@
+2022-02-23  Kimmo Kinnunen  
+
+Crash when calling WEBGL_lose_context.loseContext() after the context has been lost
+https://bugs.webkit.org/show_bug.cgi?id=236966
+
+Reviewed by Dean Jackson.
+
+* webgl/lose-context-after-context-lost-expected.txt: Added.
+* webgl/lose-context-after-context-lost.html: Added.
+
 2022-02-23  Youenn Fablet  
 
 Enable WebRTCRemoteVideoFrameEnabled by default in WebKitTestRunner


Modified: trunk/LayoutTests/platform/glib/TestExpectations (290355 => 290356)

--- trunk/LayoutTests/platform/glib/TestExpectations	2022-02-23 08:16:29 UTC (rev 290355)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2022-02-23 08:23:37 UTC (rev 290356)
@@ -1395,6 +1395,7 @@
 webkit.org/b/219251 fast/canvas/webgl/getIndexedParameter-crash.html [ Failure ]
 
 webkit.org/b/172812 fast/canvas/webgl/lose-context-on-status-failure.html [ Skip ]
+webkit.org/b/172812 webgl/lose-context-after-context-lost.html [ Failure ]
 
 webkit.org/b/223624 webgl/conformance/extensions/khr-parallel-shader-compile.html [ Skip ]
 


Added: trunk/LayoutTests/webgl/lose-context-after-context-lost-expected.txt (0 => 290356)

--- trunk/LayoutTests/webgl/lose-context-after-context-lost-expected.txt	(rev 0)
+++ trunk/LayoutTests/webgl/lose-context-after-context-lost-expected.txt	2022-02-23 08:23:37 UTC (rev 290356)
@@ -0,0 +1,46 @@
+Test that WEBGL_lose_context functions do not crash after context has been lost.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+TEST COMPLETE: 29 PASS, 2 FAIL
+
+Running test: loseMethod: loseContext, testedMethod: loseContext
+PASS gl.isContextLost() is true
+PASS gl.getError() is gl.CONTEXT_LOST_WEBGL
+PASS gl.getError() is gl.NO_ERROR
+PASS Got webglcontextlost.
+PASS Did not crash on tested method loseContext.
+Running test: loseMethod: loseContext, testedMethod: restoreContext
+PASS gl.isContextLost() is true
+PASS gl.getError() is gl.CONTEXT_LOST_WEBGL
+PASS gl.getError() is gl.NO_ERROR
+PASS Got webglcontextlost.
+PASS Did not crash on tested method restoreContext.
+Running test: loseMethod: manyContexts, testedMethod: loseContext
+PASS gl.isContextLost() is true
+FAIL gl.getError() should be 37442. Was 0.
+PASS gl.getError() is gl.NO_ERROR
+PASS Got webglcontextlost.
+PASS Did not crash on tested method loseContext.
+Running test: loseMethod: manyContexts, testedMethod: restoreContext
+PASS gl.isContextLost() is true
+FAIL gl.getError() should be 37442. Was 0.
+PASS gl.getError() is gl.NO_ERROR
+PASS Got webglcontextlost.
+PASS Did not crash on tested method restoreContext.
+Running test: loseMethod: gpuStatusFailure, testedMethod: loseContext
+PASS gl.isContextLost() is true
+PASS gl.getError() is gl.CONTEXT_LOST_WEBGL
+PASS gl.getError() is gl.NO_ERROR
+PASS Got webglcontextlost.
+PASS Did not crash on tested method loseContext.
+Running test: loseMethod: gpuStatusFailure, testedMethod: restoreContext
+PASS gl.isContextLost() is true
+PASS gl.getError() is gl.CONTEXT_LOST_WEBGL
+PASS gl.getError() is gl.NO_ERROR
+PASS Got webglcontextlost.
+PASS Did not crash on tested method restoreContext.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/webgl/lose-context-after-context-lost.html (0 => 290356)

--- trunk/LayoutTests/webgl/lose-context-after-context-lost.html	(rev 0

[webkit-changes] [290355] trunk/Source

2022-02-23 Thread youenn

Title: [290355] trunk/Source








Revision 290355
Author you...@apple.com
Date 2022-02-23 00:16:29 -0800 (Wed, 23 Feb 2022)


Log Message
Optimize RemoteVideoFrame handling in WebProcess WebRTC pipeline
https://bugs.webkit.org/show_bug.cgi?id=236970

Reviewed by Eric Carlson.

Source/WebCore:

In case of remote video frame, directly get the remote video frame as a MediaSample in receive side.
On send side, wrap remote video frames as provider-based WebRTC video frames.
LibWebRTCCodecs will optimize the handling of remote frames for hardware encoders and no change will
happen for software encoders.
Covered by existing tests.

* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
* platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:

Source/WebKit:

Fix bug in LibWebRTCCodecsProxy that would make use of shared video frame instead of remote video frame when a shared video frame is available.
Use VideoFrame* as webrtc frame provider for encoding and decoding.

* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
* WebProcess/GPU/media/RemoteVideoFrameProxy.h:
* WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm
trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
trunk/Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.h
trunk/Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (290354 => 290355)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 08:05:44 UTC (rev 290354)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 08:16:29 UTC (rev 290355)
@@ -1,3 +1,19 @@
+2022-02-23  Youenn Fablet  
+
+Optimize RemoteVideoFrame handling in WebProcess WebRTC pipeline
+https://bugs.webkit.org/show_bug.cgi?id=236970
+
+Reviewed by Eric Carlson.
+
+In case of remote video frame, directly get the remote video frame as a MediaSample in receive side.
+On send side, wrap remote video frames as provider-based WebRTC video frames.
+LibWebRTCCodecs will optimize the handling of remote frames for hardware encoders and no change will
+happen for software encoders.
+Covered by existing tests.
+
+* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
+* platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
+
 2022-02-23  Lauro Moura  
 
 Unreviewed, non-unified build fix after 247623@main


Modified: trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm (290354 => 290355)

--- trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm	2022-02-23 08:05:44 UTC (rev 290354)
+++ trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm	2022-02-23 08:16:29 UTC (rev 290355)
@@ -33,6 +33,7 @@
 #import "CVUtilities.h"
 #import "Logging.h"
 #import "MediaSampleAVFObjC.h"
+#import "VideoFrame.h"
 #import 
 
 ALLOW_UNUSED_PARAMETERS_BEGIN
@@ -127,7 +128,11 @@
 return createMediaSampleFromCVPixelBuffer(m_blackFrame.get(), rotation, frame.timestamp_us());
 }
 
-// FIXME: Detect the case of frame having a FrameBufferProvider.
+if (auto* provider = videoFrameBufferProvider(frame)) {
+// The only supported provider is VideoFrame.
+return static_cast(provider);
+}
+
 // In case of in memory samples, we have non interleaved YUV data while CVPixelBuffers prefer interleaved YUV data.
 // Maybe we should introduce a MediaSample that would represent non interleaved YUV data as an optimization.
 auto pixelBuffer = adoptCF(webrtc::createPixelBufferFromFrame(frame, [this](size_t width, size_t height, webrtc::BufferType bufferType) -> CVPixelBufferRef {


Modified: trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp (290354 => 290355)

--- trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp	2022-02-23 08:05:44 UTC (rev 290354)
+++ trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp	2022-02-23 08:16:29 UTC (rev 290355)
@@ -33,6 +33,7 @@
 #include "Logging.h"
 #include "RealtimeIncomingVideoSourceCocoa.h"
 #include "RealtimeVideoUtilities.h"
+#include "VideoFrame.h"
 
 ALLOW_UNUSED_PARAMETERS_BEGIN
 
@@ -84,7 +85,17 @@
 break;
 }
 
-// FIXME: Optimize the case of PlatformSample::RemoteVideoFrameProxyType.
+bool shouldApplyRotation = m_shouldApplyRotation && m_currentRotation != webrtc::kVideoRotation_0;
+if (!shouldApplyRotation && is(sample) && downcast(sample).isRemoteProxy()) {
+Ref videoFrame { downcast(sample) };
+auto size = sample.presentationSize();
+sendFrame(webrtc::toWebRTCVideoFrameBuffer(&videoFrame.leakRef(),
+[](auto* pointer) { return static_cast(pointer)->pi

[webkit-changes] [290354] trunk

2022-02-23 Thread youenn

Title: [290354] trunk








Revision 290354
Author you...@apple.com
Date 2022-02-23 00:05:44 -0800 (Wed, 23 Feb 2022)


Log Message
Enable WebRTCRemoteVideoFrameEnabled by default in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=236969

Reviewed by Eric Carlson.

Tools:

* WebKitTestRunner/TestOptions.cpp:

LayoutTests:

Disable WebRTCRemoteVideoFrameEnabled for those two tests until we figure out why they fail more with this option.

* fast/mediastream/getUserMedia-to-canvas-1.html:
* fast/mediastream/getUserMedia-to-canvas-2.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-1.html
trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-2.html
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestOptions.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (290353 => 290354)

--- trunk/LayoutTests/ChangeLog	2022-02-23 08:04:17 UTC (rev 290353)
+++ trunk/LayoutTests/ChangeLog	2022-02-23 08:05:44 UTC (rev 290354)
@@ -1,3 +1,15 @@
+2022-02-23  Youenn Fablet  
+
+Enable WebRTCRemoteVideoFrameEnabled by default in WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=236969
+
+Reviewed by Eric Carlson.
+
+Disable WebRTCRemoteVideoFrameEnabled for those two tests until we figure out why they fail more with this option.
+
+* fast/mediastream/getUserMedia-to-canvas-1.html:
+* fast/mediastream/getUserMedia-to-canvas-2.html:
+
 2022-02-22  Chris Dumez  
 
 http/wpt/push-api/onpush-disabled.html fails


Modified: trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-1.html (290353 => 290354)

--- trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-1.html	2022-02-23 08:04:17 UTC (rev 290353)
+++ trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-1.html	2022-02-23 08:05:44 UTC (rev 290354)
@@ -1,4 +1,4 @@
-
+
 
 
 


Modified: trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-2.html (290353 => 290354)

--- trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-2.html	2022-02-23 08:04:17 UTC (rev 290353)
+++ trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-2.html	2022-02-23 08:05:44 UTC (rev 290354)
@@ -1,4 +1,4 @@
-
+
 
 
 


Modified: trunk/Tools/ChangeLog (290353 => 290354)

--- trunk/Tools/ChangeLog	2022-02-23 08:04:17 UTC (rev 290353)
+++ trunk/Tools/ChangeLog	2022-02-23 08:05:44 UTC (rev 290354)
@@ -1,3 +1,12 @@
+2022-02-23  Youenn Fablet  
+
+Enable WebRTCRemoteVideoFrameEnabled by default in WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=236969
+
+Reviewed by Eric Carlson.
+
+* WebKitTestRunner/TestOptions.cpp:
+
 2022-02-22  Chris Dumez  
 
 Drop StringHasher::hashMemory() and use the modern Hasher instead


Modified: trunk/Tools/WebKitTestRunner/TestOptions.cpp (290353 => 290354)

--- trunk/Tools/WebKitTestRunner/TestOptions.cpp	2022-02-23 08:04:17 UTC (rev 290353)
+++ trunk/Tools/WebKitTestRunner/TestOptions.cpp	2022-02-23 08:05:44 UTC (rev 290354)
@@ -127,7 +127,7 @@
 { "TextAutosizingUsesIdempotentMode", false },
 { "UsesBackForwardCache", false },
 { "WebAuthenticationEnabled", true },
-{ "WebRTCRemoteVideoFrameEnabled", false },
+{ "WebRTCRemoteVideoFrameEnabled", true },
 { "WebRTCMDNSICECandidatesEnabled", false },
 { "XSSAuditorEnabled", false },
 #if PLATFORM(IOS_FAMILY_SIMULATOR)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290353] trunk/Source/WebCore

2022-02-23 Thread lmoura

Title: [290353] trunk/Source/WebCore








Revision 290353
Author lmo...@igalia.com
Date 2022-02-23 00:04:17 -0800 (Wed, 23 Feb 2022)


Log Message
Unreviewed, non-unified build fix after 247623@main
https://bugs.webkit.org/show_bug.cgi?id=237074


* bindings/js/WebAssemblyCachedScriptSourceProvider.h: Namespace.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/WebAssemblyCachedScriptSourceProvider.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290352 => 290353)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 07:35:12 UTC (rev 290352)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 08:04:17 UTC (rev 290353)
@@ -1,3 +1,10 @@
+2022-02-23  Lauro Moura  
+
+Unreviewed, non-unified build fix after 247623@main
+https://bugs.webkit.org/show_bug.cgi?id=237074
+
+* bindings/js/WebAssemblyCachedScriptSourceProvider.h: Namespace.
+
 2022-02-22  Chris Dumez  
 
 http/wpt/push-api/onpush-disabled.html fails


Modified: trunk/Source/WebCore/bindings/js/WebAssemblyCachedScriptSourceProvider.h (290352 => 290353)

--- trunk/Source/WebCore/bindings/js/WebAssemblyCachedScriptSourceProvider.h	2022-02-23 07:35:12 UTC (rev 290352)
+++ trunk/Source/WebCore/bindings/js/WebAssemblyCachedScriptSourceProvider.h	2022-02-23 08:04:17 UTC (rev 290353)
@@ -78,7 +78,7 @@
 }
 
 private:
-WebAssemblyCachedScriptSourceProvider(CachedScript* cachedScript, const SourceOrigin& sourceOrigin, String sourceURL)
+WebAssemblyCachedScriptSourceProvider(CachedScript* cachedScript, const JSC::SourceOrigin& sourceOrigin, String sourceURL)
 : BaseWebAssemblySourceProvider(sourceOrigin, WTFMove(sourceURL))
 , m_cachedScript(cachedScript)
 , m_buffer(nullptr)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

61 matches

Mail list logo