[webkit-changes] [290819] trunk/LayoutTests

[youenn]

Title: [290819] trunk/LayoutTests








Revision 290819
Author you...@apple.com
Date 2022-03-03 23:55:10 -0800 (Thu, 03 Mar 2022)


Log Message
fast/mediastream/getUserMedia-to-canvas-1.html and fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote video frame flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=237042


Reviewed by Eric Carlson.

Video element videoWidth/videoHeight are updated when track settings are changed,
and not when video frames being received.

This does not guarantee that videoWidth/videoHeight (main thread) are fully in sync
with the actual video frames (background thread) when there is a change of size.

We might be able to tighten this in MediaPlayerPrivateMediaStreamAVFObjC by only resorting on video frames.
In the meantime, we update the test to use requestVideoFrameCallback which provides accurate per frame metadata.

* fast/mediastream/getUserMedia-to-canvas-1.html:
* fast/mediastream/getUserMedia-to-canvas-2.html:
* webrtc/routines.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-1.html
trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-2.html
trunk/LayoutTests/webrtc/routines.js




Diff

Modified: trunk/LayoutTests/ChangeLog (290818 => 290819)

--- trunk/LayoutTests/ChangeLog	2022-03-04 06:58:01 UTC (rev 290818)
+++ trunk/LayoutTests/ChangeLog	2022-03-04 07:55:10 UTC (rev 290819)
@@ -1,3 +1,24 @@
+2022-03-03  Youenn Fablet  
+
+fast/mediastream/getUserMedia-to-canvas-1.html and fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote video frame flag is enabled
+https://bugs.webkit.org/show_bug.cgi?id=237042
+
+
+Reviewed by Eric Carlson.
+
+Video element videoWidth/videoHeight are updated when track settings are changed,
+and not when video frames being received.
+
+This does not guarantee that videoWidth/videoHeight (main thread) are fully in sync
+with the actual video frames (background thread) when there is a change of size.
+
+We might be able to tighten this in MediaPlayerPrivateMediaStreamAVFObjC by only resorting on video frames.
+In the meantime, we update the test to use requestVideoFrameCallback which provides accurate per frame metadata.
+
+* fast/mediastream/getUserMedia-to-canvas-1.html:
+* fast/mediastream/getUserMedia-to-canvas-2.html:
+* webrtc/routines.js:
+
 2022-03-03  Kimmo Kinnunen  
 
 WebGL context count is not limited for GPU process


Modified: trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-1.html (290818 => 290819)

--- trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-1.html	2022-03-04 06:58:01 UTC (rev 290818)
+++ trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-1.html	2022-03-04 07:55:10 UTC (rev 290819)
@@ -1,4 +1,4 @@
-
+
 
 
 


Modified: trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-2.html (290818 => 290819)

--- trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-2.html	2022-03-04 06:58:01 UTC (rev 290818)
+++ trunk/LayoutTests/fast/mediastream/getUserMedia-to-canvas-2.html	2022-03-04 07:55:10 UTC (rev 290819)
@@ -1,4 +1,4 @@
-
+
 
 
 


Modified: trunk/LayoutTests/webrtc/routines.js (290818 => 290819)

--- trunk/LayoutTests/webrtc/routines.js	2022-03-04 06:58:01 UTC (rev 290818)
+++ trunk/LayoutTests/webrtc/routines.js	2022-03-04 07:55:10 UTC (rev 290819)
@@ -150,9 +150,16 @@
 return new Promise((resolve) => setTimeout(resolve, duration));
 }
 
-function waitForVideoSize(video, width, height, count)
+async function waitForVideoSize(video, width, height, count)
 {
-if (video.videoWidth === width && video.videoHeight === height)
+if (video.requestVideoFrameCallback) {
+const frameMetadata = await new Promise(resolve => video.requestVideoFrameCallback((now, metadata) => {
+resolve(metadata);
+}));
+
+if (frameMetadata.width === width && frameMetadata.height === height)
+return Promise.resolve("video has expected size");
+} else if (video.videoWidth === width && video.videoHeight === height)
 return Promise.resolve("video has expected size");
 
 if (count === undefined)
@@ -160,9 +167,8 @@
 if (++count > 20)
 return Promise.reject("waitForVideoSize timed out, expected " + width + "x"+ height + " but got " + video.videoWidth + "x" + video.videoHeight);
 
-return waitFor(100).then(() => {
-return waitForVideoSize(video, width, height, count);
-});
+await waitFor(100);
+return waitForVideoSize(video, width, height, count);
 }
 
 async function doHumAnalysis(stream, expected)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290818] trunk/Source/WebKit

[beidson]

Title: [290818] trunk/Source/WebKit








Revision 290818
Author beid...@apple.com
Date 2022-03-03 22:58:01 -0800 (Thu, 03 Mar 2022)


Log Message
Add a new "Daemon -> Client" message type to webpushd
https://bugs.webkit.org/show_bug.cgi?id=237391

Reviewed by Alex Christensen.

Future work will need more messages like this.
So let's add the mechanism in a small standalone patch that uses it for debug messages.

No behavior change for now.

* NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm:
(WebKit::WebPushD::handleWebPushDaemonMessage):
(WebKit::WebPushD::Connection::connectionReceivedEvent):
(WebKit::WebPushD::Connection::connectionReceivedEvent const): Deleted.

* NetworkProcess/Notifications/WebPushDaemonConnection.cpp:
(WebKit::WebPushD::Connection::debugMessage):
* NetworkProcess/Notifications/WebPushDaemonConnection.h:

* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:
* NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementConnectionCocoa.mm:
(WebKit::PCM::Connection::connectionReceivedEvent):
(WebKit::PCM::Connection::connectionReceivedEvent const): Deleted.

* Platform/IPC/DaemonConnection.h:

* Shared/WebPushDaemonConstants.h:
(WebKit::WebPushD::daemonMessageTypeSendsReply):

* webpushd/ICAppBundle.mm:
(WebPushD::broadcastDebugMessage):

* webpushd/PushClientConnection.h:
* webpushd/PushClientConnection.mm:
(WebPushD::ClientConnection::broadcastDebugMessage):
(WebPushD::ClientConnection::sendDebugMessage):
(WebPushD::ClientConnection::sendDaemonMessage const):

* webpushd/WebPushDaemon.h:
* webpushd/WebPushDaemon.mm:
(WebPushD::Daemon::broadcastDebugMessage):
(WebPushD::Daemon::broadcastAllConnectionIdentities):
(WebPushD::Daemon::connectionAdded):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm
trunk/Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.cpp
trunk/Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.h
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementConnectionCocoa.mm
trunk/Source/WebKit/Platform/IPC/DaemonConnection.h
trunk/Source/WebKit/Shared/WebPushDaemonConstants.h
trunk/Source/WebKit/webpushd/ICAppBundle.mm
trunk/Source/WebKit/webpushd/PushClientConnection.h
trunk/Source/WebKit/webpushd/PushClientConnection.mm
trunk/Source/WebKit/webpushd/WebPushDaemon.h
trunk/Source/WebKit/webpushd/WebPushDaemon.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (290817 => 290818)

--- trunk/Source/WebKit/ChangeLog	2022-03-04 06:38:04 UTC (rev 290817)
+++ trunk/Source/WebKit/ChangeLog	2022-03-04 06:58:01 UTC (rev 290818)
@@ -1,3 +1,49 @@
+2022-03-03  Brady Eidson  
+
+Add a new "Daemon -> Client" message type to webpushd
+https://bugs.webkit.org/show_bug.cgi?id=237391
+
+Reviewed by Alex Christensen.
+
+Future work will need more messages like this.
+So let's add the mechanism in a small standalone patch that uses it for debug messages.
+
+No behavior change for now.
+
+* NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm:
+(WebKit::WebPushD::handleWebPushDaemonMessage):
+(WebKit::WebPushD::Connection::connectionReceivedEvent):
+(WebKit::WebPushD::Connection::connectionReceivedEvent const): Deleted.
+
+* NetworkProcess/Notifications/WebPushDaemonConnection.cpp:
+(WebKit::WebPushD::Connection::debugMessage):
+* NetworkProcess/Notifications/WebPushDaemonConnection.h:
+
+* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:
+* NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementConnectionCocoa.mm:
+(WebKit::PCM::Connection::connectionReceivedEvent):
+(WebKit::PCM::Connection::connectionReceivedEvent const): Deleted.
+
+* Platform/IPC/DaemonConnection.h:
+
+* Shared/WebPushDaemonConstants.h:
+(WebKit::WebPushD::daemonMessageTypeSendsReply):
+
+* webpushd/ICAppBundle.mm:
+(WebPushD::broadcastDebugMessage):
+
+* webpushd/PushClientConnection.h:
+* webpushd/PushClientConnection.mm:
+(WebPushD::ClientConnection::broadcastDebugMessage):
+(WebPushD::ClientConnection::sendDebugMessage):
+(WebPushD::ClientConnection::sendDaemonMessage const):
+
+* webpushd/WebPushDaemon.h:
+* webpushd/WebPushDaemon.mm:
+(WebPushD::Daemon::broadcastDebugMessage):
+(WebPushD::Daemon::broadcastAllConnectionIdentities):
+(WebPushD::Daemon::connectionAdded):
+
 2022-03-03  Ross Kirsling  
 
 REGRESSION(r290815): Fix even more incorrect #if ENABLE(SERVICE_WORKER) usage in NetworkProcess


Modified: trunk/Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm (290817 => 

[webkit-changes] [290817] trunk/Source/WebKit

[ross . kirsling]

Title: [290817] trunk/Source/WebKit








Revision 290817
Author ross.kirsl...@sony.com
Date 2022-03-03 22:38:04 -0800 (Thu, 03 Mar 2022)


Log Message
REGRESSION(r290815): Fix even more incorrect #if ENABLE(SERVICE_WORKER) usage in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=237461

Unreviewed build fix.


* NetworkProcess/NetworkProcess.cpp:
The existence of NetworkProcess::{getPendingPushMessages, processPushMessages} depend on ENABLE(SERVICE_WORKER);
it is only when they exist that their implementation depends on ENABLE(BUILT_IN_NOTIFICATIONS).

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290816 => 290817)

--- trunk/Source/WebKit/ChangeLog	2022-03-04 06:02:52 UTC (rev 290816)
+++ trunk/Source/WebKit/ChangeLog	2022-03-04 06:38:04 UTC (rev 290817)
@@ -1,3 +1,14 @@
+2022-03-03  Ross Kirsling  
+
+REGRESSION(r290815): Fix even more incorrect #if ENABLE(SERVICE_WORKER) usage in NetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=237461
+
+Unreviewed build fix.
+
+* NetworkProcess/NetworkProcess.cpp:
+The existence of NetworkProcess::{getPendingPushMessages, processPushMessages} depend on ENABLE(SERVICE_WORKER);
+it is only when they exist that their implementation depends on ENABLE(BUILT_IN_NOTIFICATIONS).
+
 2022-03-03  Ben Nham  
 
 Enforce silent push quota


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (290816 => 290817)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2022-03-04 06:02:52 UTC (rev 290816)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2022-03-04 06:38:04 UTC (rev 290817)
@@ -2232,7 +2232,8 @@
 session->storageManager().moveData(dataTypes, oldOrigin, newOrigin, [aggregator] { });
 }
 
-#if ENABLE(SERVICE_WORKER) && ENABLE(BUILT_IN_NOTIFICATIONS)
+#if ENABLE(SERVICE_WORKER)
+#if ENABLE(BUILT_IN_NOTIFICATIONS)
 
 void NetworkProcess::getPendingPushMessages(PAL::SessionID sessionID, CompletionHandler&)>&& callback)
 {
@@ -2276,7 +2277,8 @@
 callback(false);
 }
 
-#endif // ENABLE(SERVICE_WORKER) && ENABLE(BUILT_IN_NOTIFICATIONS)
+#endif // ENABLE(BUILT_IN_NOTIFICATIONS)
+#endif // ENABLE(SERVICE_WORKER)
 
 void NetworkProcess::deletePushAndNotificationRegistration(PAL::SessionID sessionID, const SecurityOriginData& origin, CompletionHandler&& callback)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290816] trunk

[commit-queue]

Title: [290816] trunk








Revision 290816
Author commit-qu...@webkit.org
Date 2022-03-03 22:02:52 -0800 (Thu, 03 Mar 2022)


Log Message
WebGL context count is not limited for GPU process
https://bugs.webkit.org/show_bug.cgi?id=222411

Patch by Kimmo Kinnunen  on 2022-03-03
Reviewed by Kenneth Russell.

Source/WebCore:

Move the context limit from the GraphicsContextGL implementation
level to WebGLRenderingContext level. This way the limit
is applied to the GPUP implementation too.

Recycle the context with the earliest activity (draw, readpixels)
instead of the creation order.

Stores the WebGL contexts to per-thread set and limits the size of the set.
The set is per-thread to support WebGL contexts in DOM as well as
offscreen canvas use-cases. Offscreen canvas is not implemented for Cocoa
but other ports may enable it.

Tested by:
LayoutTests/webgl/lose-context-after-context-lost.html
LayoutTests/webgl/many-contexts-access-after-loss.html
LayoutTests/webgl/many-contexts.html
LayoutTests/webgl/max-active-contexts-console-warning.html
LayoutTests/webgl/max-active-contexts-gc.html
LayoutTests/webgl/max-active-contexts-oldest-context-lost.html
LayoutTests/webgl/max-active-contexts-webglcontextlost-prevent-default.html

* Headers.cmake:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::activeContexts):
(WebCore::addActiveContext):
(WebCore::removeActiveContext):
(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::setGraphicsContextGL):
(WebCore::WebGLRenderingContextBase::destroyGraphicsContextGL):
(WebCore::WebGLRenderingContextBase::clearIfComposited):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::WebGLRenderingContextBase::updateActiveOrdinal):
* html/canvas/WebGLRenderingContextBase.h:
(WebCore::WebGLRenderingContextBase::activeOrdinal const):
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLANGLE::~GraphicsContextGLANGLE):
* platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm:
(WebCore::createWebProcessGraphicsContextGL):
* platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
* platform/graphics/opengl/GraphicsContextGLOpenGLManager.cpp: Removed.
* platform/graphics/opengl/GraphicsContextGLOpenGLManager.h: Removed.
* platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
(WebCore::createWebProcessGraphicsContextGL):
* platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::~GraphicsContextGLANGLE):

LayoutTests:

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
trunk/Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp
trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp
trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp


Removed Paths

trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLManager.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLManager.h




Diff

Modified: trunk/LayoutTests/ChangeLog (290815 => 290816)

--- trunk/LayoutTests/ChangeLog	2022-03-04 05:28:22 UTC (rev 290815)
+++ trunk/LayoutTests/ChangeLog	2022-03-04 06:02:52 UTC (rev 290816)
@@ -1,3 +1,12 @@
+2022-03-03  Kimmo Kinnunen  
+
+WebGL context count is not limited for GPU process
+https://bugs.webkit.org/show_bug.cgi?id=222411
+
+Reviewed by Kenneth Russell.
+
+* platform/ios-wk2/TestExpectations:
+
 2022-03-03  Ben Nham  
 
 Enforce silent push quota


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (290815 => 290816)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-03-04 05:28:22 UTC (rev 290815)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-03-04 06:02:52 UTC (rev 290816)
@@ -2228,13 +2228,7 @@
 
 # Test failures from turning GPU Process on by default
 webkit.org/b/234536 webgl/2.0.0/conformance/reading/read-pixels-test.html
-webkit.org/b/234536 webgl/many-contexts-access-after-loss.html
-webkit.org/b/234536 webgl/many-contexts.html
-webkit.org/b/234536 webgl/max-active-contexts-console-warning.html
-webkit.org/b/234536 webgl/max-active-contexts-gc.html
-webkit.org/b/234536 

[webkit-changes] [290815] trunk

[nham]

Title: [290815] trunk








Revision 290815
Author n...@apple.com
Date 2022-03-03 21:28:22 -0800 (Thu, 03 Mar 2022)


Log Message
Enforce silent push quota
https://bugs.webkit.org/show_bug.cgi?id=236863

Reviewed by Brady Eidson.

Source/WebCore:

All PushSubscriptions are created with the userVisibleOnly flag set. This means that all
push events should result in a user-facing notification.

To enforce this, we use a quota system. A push subscription can process up to three silent
pushes. After three silent pushes, we remove the push subscription. To continue to receive
pushes, the user must navigate back to the website and the site must request permission to
send pushes again.

Originally we were going to use a more complicated quota system that moved subscriptions
from waking to non-waking before finally unsubscribing, but this seemed like it could lead
to subscriptions being in a partially-working state that would be hard to explain and reason
about. As a result, I've removed the wakeState column from PushDatabase and replaced it
a silentPushCount column.

To track whether or not a service worker has shown a notification while processing a push
event, we use a boolean flag on ServiceWorkerGlobalScope. This should be sufficient because
we currently only process one push event at a time.

Covered by existing and new API tests.

* Modules/push-api/PushDatabase.cpp:
(WebCore::PushRecord::isolatedCopy const):
(WebCore::PushRecord::isolatedCopy):
(WebCore::PushDatabase::insertRecord):
(WebCore::makePushRecordFromRow):
(WebCore::PushDatabase::getRecordByTopic):
(WebCore::PushDatabase::getRecordByBundleIdentifierAndScope):
(WebCore::PushDatabase::getTopics):
(WebCore::PushDatabase::incrementSilentPushCount):
(WebCore::PushDatabase::removeRecordsByBundleIdentifierAndSecurityOrigin):
* Modules/push-api/PushDatabase.h:
* workers/service/ServiceWorkerGlobalScope.h:
* workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::showNotification):
* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFirePushEvent):

Source/WebKit:

 - If a push event doesn't result in a notification or if the associated promise rejects,
   then we increment the silent push count associated with that origin.
 - PushService now removes a subscription if the origin has reached its quota of silent
   pushes.

Covered by existing and new API tests.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processPushMessage):
* NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::incrementSilentPushCount):
(WebKit::ReplyCaller::callReply):
* Shared/WebPushDaemonConstants.h:
(WebKit::WebPushD::messageTypeSendsReply):
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _notificationManagerForTesting]):
* webpushd/PushService.mm:
(WebPushD::updateTopicLists):
(WebPushD::PushService::incrementSilentPushCount):
* webpushd/WebPushDaemon.mm:
(WebPushD::MessageInfo::incrementSilentPushCount::encodeReply):
(WebPushD::Daemon::decodeAndHandleMessage):
(WebPushD::Daemon::incrementSilentPushCount):

Tools:

Modified existing push tests to show a notification. Added a new test case to make sure that
subscriptions are removed when an origin reaches its quota of silent pushes.

* TestWebKitAPI/TestNotificationProvider.cpp:
(TestWebKitAPI::notificationPermissions):
(TestWebKitAPI::TestNotificationProvider::TestNotificationProvider):
(TestWebKitAPI::TestNotificationProvider::~TestNotificationProvider):
(TestWebKitAPI::TestNotificationProvider::notificationPermissions):
(TestWebKitAPI::TestNotificationProvider::setPermission):
* TestWebKitAPI/Tests/WebCore/PushDatabase.cpp:
(TestWebKitAPI::makeTemporaryDatabasePath):
(TestWebKitAPI::getTopicsSync):
(TestWebKitAPI::PushDatabaseTest::getTopics):
(TestWebKitAPI::PushDatabaseTest::removeRecordsByBundleIdentifierAndSecurityOrigin):
(TestWebKitAPI::PushDatabaseTest::incrementSilentPushCount):
(TestWebKitAPI::operator==):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::TEST):
* TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::origin const):

LayoutTests:

Update PushEvent tests to check that notifications are displayed.

* http/wpt/push-api/pushEvent.any.js:
(promise_test.async const):
(promise_test.async if):
* http/wpt/push-api/pushEvent.any.serviceworker-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/push-api/pushEvent.any.js
trunk/LayoutTests/http/wpt/push-api/pushEvent.any.serviceworker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/push-api/PushDatabase.cpp
trunk/Source/WebCore/Modules/push-api/PushDatabase.h
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp

[webkit-changes] [290814] trunk/Source/WebKit

[nham]

Title: [290814] trunk/Source/WebKit








Revision 290814
Author n...@apple.com
Date 2022-03-03 20:40:06 -0800 (Thu, 03 Mar 2022)


Log Message
Allow webpushd to launch browser in background
https://bugs.webkit.org/show_bug.cgi?id=237114

Reviewed by Brady Eidson.

Now that webpushd is sandboxed on Mac (r289566), the LaunchServices SPI call to launch
Safari is now failing, because LaunchServices goes down a different path when there is a
sandboxed caller. In particular, it fails to launch Safari because Safari doesn't register
for the webkit-app-launch scheme. Safari also doesn't want to list this scheme in its plist.

For now, to unblock our testing, we're giving ourselves an entitlement to restore the
pre-sandboxed behavior of being able to launch Safari even though it doesn't register for
the webkit-app-launch scheme. We are still in discussions with LaunchServices and Safari
about if there is a better and more restrictive way of granting ourselves this ability.

* Scripts/process-entitlements.sh:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/process-entitlements.sh




Diff

Modified: trunk/Source/WebKit/ChangeLog (290813 => 290814)

--- trunk/Source/WebKit/ChangeLog	2022-03-04 04:08:26 UTC (rev 290813)
+++ trunk/Source/WebKit/ChangeLog	2022-03-04 04:40:06 UTC (rev 290814)
@@ -1,3 +1,22 @@
+2022-03-03  Ben Nham  
+
+Allow webpushd to launch browser in background
+https://bugs.webkit.org/show_bug.cgi?id=237114
+
+Reviewed by Brady Eidson.
+
+Now that webpushd is sandboxed on Mac (r289566), the LaunchServices SPI call to launch
+Safari is now failing, because LaunchServices goes down a different path when there is a
+sandboxed caller. In particular, it fails to launch Safari because Safari doesn't register
+for the webkit-app-launch scheme. Safari also doesn't want to list this scheme in its plist.
+
+For now, to unblock our testing, we're giving ourselves an entitlement to restore the
+pre-sandboxed behavior of being able to launch Safari even though it doesn't register for
+the webkit-app-launch scheme. We are still in discussions with LaunchServices and Safari
+about if there is a better and more restrictive way of granting ourselves this ability.
+
+* Scripts/process-entitlements.sh:
+
 2022-03-03  Devin Rousso  
 
 [GPU Process] dont load Apple Pay button/logo PDFs in the WebProcess


Modified: trunk/Source/WebKit/Scripts/process-entitlements.sh (290813 => 290814)

--- trunk/Source/WebKit/Scripts/process-entitlements.sh	2022-03-04 04:08:26 UTC (rev 290813)
+++ trunk/Source/WebKit/Scripts/process-entitlements.sh	2022-03-04 04:40:06 UTC (rev 290814)
@@ -222,9 +222,8 @@
 
 function mac_process_webpushd_entitlements()
 {
-# FIXME: Add a sandbox profile for webpushd.
-echo "webpushd sandbox has not been implemented yet"
 plistbuddy Add :com.apple.private.aps-connection-initiate bool YES
+plistbuddy Add :com.apple.private.launchservices.allowopenwithanyhandler bool YES
 }
 
 # 
@@ -513,6 +512,7 @@
 # FIXME: Add a sandbox profile for webpushd and add it to the seatbelt-profiles array.
 echo "webpushd sandbox has not been implemented yet"
 plistbuddy Add :aps-connection-initiate bool YES
+plistbuddy Add :com.apple.private.launchservices.allowopenwithanyhandler bool YES
 }
 
 function ios_family_process_network_entitlements()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290813] trunk/Source

[drousso]

Title: [290813] trunk/Source








Revision 290813
Author drou...@apple.com
Date 2022-03-03 20:08:26 -0800 (Thu, 03 Mar 2022)


Log Message
[GPU Process] dont load Apple Pay button/logo PDFs in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=237177

Reviewed by Simon Fraser.

Source/WebCore:

* platform/graphics/SystemImage.h: Added.
(WebCore::SystemImage::draw const):
(WebCore::SystemImage::SystemImage):
Introduce a new extendable class `SystemImage` that represents a collection of arguments
and methodology (that uses those arguments) to draw something from the system.
This patch introduces two concrete uses:
- `ApplePayButtonSystemImage` uses PassKit SPI to draw an Apple Pay button.
- `ApplePayLogoSystemImage` loads a PDF file of the Apple Pay logo from inside PassKit.
This architecture was chosen so that `GraphicsContext` doesn't have to know about Apple Pay
specific things, instead only dealing with a very generic interface (whos subclasses know
more specifically what to do with the data they're given).

* Modules/applepay/ApplePayButtonSystemImage.h: Added.
(WebCore::ApplePayButtonSystemImage::create):
(WebCore::ApplePayButtonSystemImage::ApplePayButtonSystemImage):
(WebCore::ApplePayButtonSystemImage::encode const):
(WebCore::ApplePayButtonSystemImage::decode):
(isType):
* Modules/applepay/ApplePayButtonSystemImage.mm: Added.
(WebCore::toPKPaymentButtonType):
(WebCore::toPKPaymentButtonStyle):
(WebCore::ApplePayButtonSystemImage::draw const):
* css/CSSPrimitiveValueMappings.h:
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.cpp:
* rendering/style/RenderStyleConstants.h:
Drive-by: Move `ApplePayButtonStyle` and `ApplePayButtonType` to `ApplePayButtonSystemImage.h`
so they can be used elsewhere (e.g. GPUProcess) without having to include everything else.

* Modules/applepay/ApplePayLogoSystemImage.h: Added.
(WebCore::ApplePayLogoSystemImage::create):
(WebCore::ApplePayLogoSystemImage::ApplePayLogoSystemImage):
(WebCore::ApplePayLogoSystemImage::encode const):
(WebCore::ApplePayLogoSystemImage::decode):
(isType):
* Modules/applepay/ApplePayLogoSystemImage.mm: Added.
(WebCore::passKitBundle):
(WebCore::loadPassKitPDFPage):
(WebCore::applePayLogoWhite):
(WebCore::applePayLogoBlack):
(WebCore::applePayLogoForStyle):
(WebCore::ApplePayLogoSystemImage::draw const):
Add a new `ApplePayLogoStyle` so that the WebProcess isn't able to provide an arbitrary PDF
to load when rendering `-webkit-named-image(apple-pay-logo-[white,black])`.

* platform/cocoa/ThemeCocoa.mm:
(WebCore::ThemeCocoa::drawNamedImage const):
(WebCore::fitContextToBox): Deleted.
(WebCore::passKitBundle): Deleted.
(WebCore::loadPassKitPDFPage): Deleted.
(WebCore::applePayButtonLogoBlack): Deleted.
(WebCore::applePayButtonLogoWhite): Deleted.
(WebCore::drawApplePayButton): Deleted.
* rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::paintApplePayButton):
(WebCore::toPKPaymentButtonStyle): Deleted.
(WebCore::toPKPaymentButtonType): Deleted.
Move the logic that draws the Apple Pay button to a method on `GraphicsContext` so that it
can hook into the various GPUProcess flags/systems.

* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawSystemImage): Added.
* platform/graphics/BifurcatedGraphicsContext.h:
* platform/graphics/BifurcatedGraphicsContext.cpp:
(WebCore::BifurcatedGraphicsContext::drawSystemImage): Added.
* platform/graphics/NullGraphicsContext.h:
(WebCore::NullGraphicsContext::drawSystemImage): Added.
* platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::append):
* platform/graphics/displaylists/DisplayListItemBuffer.cpp:
(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::safeCopy const):
* platform/graphics/displaylists/DisplayListItemType.h:
* platform/graphics/displaylists/DisplayListItemType.cpp:
(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):
* platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::DrawSystemImage::DrawSystemImage): Added.
(WebCore::DisplayList::DrawSystemImage::systemImage const): Added.
(WebCore::DisplayList::DrawSystemImage::destination const): Added.
(WebCore::DisplayList::DrawSystemImage::globalBounds const): Added.
(WebCore::DisplayList::DrawSystemImage::localBounds const): Added.
(WebCore::DisplayList::DrawSystemImage::encode const): Added.
(WebCore::DisplayList::DrawSystemImage::decode): Added.
* platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawSystemImage::apply const): Added.
(WebCore::DisplayList::operator<<):
* platform/graphics/displaylists/DisplayListRecorder.h:
* platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawSystemImage): Added.
* platform/graphics/displaylists/DisplayListRecorderImpl.h:
* 

[webkit-changes] [290812] trunk

[simon . fraser]

Title: [290812] trunk








Revision 290812
Author simon.fra...@apple.com
Date 2022-03-03 18:54:00 -0800 (Thu, 03 Mar 2022)


Log Message
Element with position: sticky after sticking, starts to move incorrectly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=231953


Reviewed by Sam Weinig.

Source/WebCore:

Sometimes we'd fail to push new StickyPositionViewportConstraints to the scrolling
tree, because operator== failed to compare m_constrainingRectAtLastLayout. This breaks
the requirement that the "last committed scroll position" for the overflow scrolling
node has to be updated in the same commit as the "constraining-rect-at-last-layout"
on the sticky node.

Test: scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints.html

* page/scrolling/ScrollingConstraints.cpp:
(WebCore::operator<<):
* page/scrolling/ScrollingConstraints.h:
(WebCore::StickyPositionViewportConstraints::operator== const):

LayoutTests:

* platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt: Added.
* scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt: Added.
* scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingConstraints.cpp
trunk/Source/WebCore/page/scrolling/ScrollingConstraints.h


Added Paths

trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints.html




Diff

Modified: trunk/LayoutTests/ChangeLog (290811 => 290812)

--- trunk/LayoutTests/ChangeLog	2022-03-04 02:40:59 UTC (rev 290811)
+++ trunk/LayoutTests/ChangeLog	2022-03-04 02:54:00 UTC (rev 290812)
@@ -1,5 +1,17 @@
 2022-03-03  Simon Fraser  
 
+Element with position: sticky after sticking, starts to move incorrectly when scrolling
+https://bugs.webkit.org/show_bug.cgi?id=231953
+
+
+Reviewed by Sam Weinig.
+
+* platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt: Added.
+* scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt: Added.
+* scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints.html: Added.
+
+2022-03-03  Simon Fraser  
+
 nasa.gov page with fixed backgrounds paints incorrectly on scroll
 https://bugs.webkit.org/show_bug.cgi?id=237405
 


Added: trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt (0 => 290812)

--- trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt	2022-03-04 02:54:00 UTC (rev 290812)
@@ -0,0 +1,46 @@
+Hello
+
+(Frame scrolling node
+  (scrollable area size 800 600)
+  (contents size 800 600)
+  (scrollable area parameters
+(horizontal scroll elasticity 1)
+(vertical scroll elasticity 1)
+(horizontal scrollbar mode 0)
+(vertical scrollbar mode 0))
+  (layout viewport at (0,0) size 800x600)
+  (min layout viewport origin (0,0))
+  (max layout viewport origin (0,0))
+  (behavior for fixed 0)
+  (children 2
+(Overflow scrolling node
+  (scroll position 0 380)
+  (scrollable area size 300 500)
+  (contents size 300 1400)
+  (requested scroll position 0 380)
+  (requested scroll position represents programmatic scroll 1)
+  (scrollable area parameters
+(horizontal scroll elasticity 1)
+(vertical scroll elasticity 1)
+(horizontal scrollbar mode 0)
+(vertical scrollbar mode 0)
+(allows vertical scrolling 1))
+)
+(Overflow scroll proxy node
+  (related overflow scrolling node scroll position (0,380))
+  (children 1
+(Sticky node
+  (anchor edges: AnchorEdgeTop )
+  (top offset 0.00)
+  (containing block rect at (0,0) size 300x1400)
+  (sticky box rect at (0,400) size 300x200)
+  (constraining rect at (0,380) size 300x500)
+  (sticky offset at last layout width=0 height=0)
+  (layer position at last layout (0,400))
+)
+  )
+)
+  )
+)
+
+


Added: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt (0 => 290812)

--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt	(rev 0)
+++ 

[webkit-changes] [290811] trunk/Tools

[dewei_zhu]

Title: [290811] trunk/Tools








Revision 290811
Author dewei_...@apple.com
Date 2022-03-03 18:40:59 -0800 (Thu, 03 Mar 2022)


Log Message
'run-benchmark' script should log http requests during benchmark run.
https://bugs.webkit.org/show_bug.cgi?id=237076


Reviewed by Jonathan Bedard.

Relanding 290583 with fix.
Add support to log http requests during benchmark run for diagnostic purpose.
AutoInstall sets 'AUTOINSTALL_CA_CERT_PATH' to environment variables when certificate is specified,
and uses 'AUTOINSTALL_CA_CERT_PATH' when it's present in environment variables. This ensures scripts invoked
from subprocess can use autoinstalled correcctly.

* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall):
(AutoInstall.set_index):
* Scripts/webkitpy/__init__.py: Update 'attr' package version to 20.3.0 so match upgraded twisted version
* Scripts/webkitpy/autoinstalled/twisted.py: Upgrade twisted version to latest python2 & python3 compatibile
version with specified implicit dependencies.
* Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Ensure benchmark diagnostic directory is created.
(BenchmarkRunner.__init__):
* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Add '--log-path'
arugment to allow specify logging output and it defaults to '/tmp/run-benchmark-http.log'
* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
(HTTPServerDriver.set_device_id):
(HTTPServerDriver):
(HTTPServerDriver.set_http_log):
* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Pass http log path to
twisted http server if specified.
(SimpleHTTPServerDriver.__init__):
(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver.set_http_log):
* Scripts/webkitpy/benchmark_runner/run_benchmark.py: Fix a tiny bug that default_diagnose_dir() is involked twice in
argument parser help message.
(config_argument_parser):
* Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Set http request log path if diagnostic directory
is specified.
(WebServerBenchmarkRunner.__init__):

Canonical link: https://commits.webkit.org/248047@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
trunk/Tools/Scripts/webkitpy/__init__.py
trunk/Tools/Scripts/webkitpy/autoinstalled/twisted.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py




Diff

Modified: trunk/Tools/ChangeLog (290810 => 290811)

--- trunk/Tools/ChangeLog	2022-03-04 02:19:22 UTC (rev 290810)
+++ trunk/Tools/ChangeLog	2022-03-04 02:40:59 UTC (rev 290811)
@@ -1,3 +1,43 @@
+2022-03-03  Dewei Zhu  
+
+'run-benchmark' script should log http requests during benchmark run.
+https://bugs.webkit.org/show_bug.cgi?id=237076
+
+
+Reviewed by Jonathan Bedard.
+
+Relanding 290583 with fix.
+Add support to log http requests during benchmark run for diagnostic purpose.
+AutoInstall sets 'AUTOINSTALL_CA_CERT_PATH' to environment variables when certificate is specified,
+and uses 'AUTOINSTALL_CA_CERT_PATH' when it's present in environment variables. This ensures scripts invoked
+from subprocess can use autoinstalled correcctly.
+
+* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
+(AutoInstall):
+(AutoInstall.set_index):
+* Scripts/webkitpy/__init__.py: Update 'attr' package version to 20.3.0 so match upgraded twisted version
+* Scripts/webkitpy/autoinstalled/twisted.py: Upgrade twisted version to latest python2 & python3 compatibile
+version with specified implicit dependencies.
+* Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Ensure benchmark diagnostic directory is created.
+(BenchmarkRunner.__init__):
+* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Add '--log-path'
+arugment to allow specify logging output and it defaults to '/tmp/run-benchmark-http.log'
+* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
+(HTTPServerDriver.set_device_id):
+(HTTPServerDriver):
+(HTTPServerDriver.set_http_log):
+* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Pass http log path to
+twisted http server if specified.
+(SimpleHTTPServerDriver.__init__):
+(SimpleHTTPServerDriver.serve):
+(SimpleHTTPServerDriver.set_http_log):
+* 

[webkit-changes] [290810] trunk/Tools

[jbedard]

Title: [290810] trunk/Tools








Revision 290810
Author jbed...@apple.com
Date 2022-03-03 18:19:22 -0800 (Thu, 03 Mar 2022)


Log Message
[git-webkit] Handle new PR with old branch name
https://bugs.webkit.org/show_bug.cgi?id=237457


Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.main):

Canonical link: https://commits.webkit.org/248046@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py




Diff

Modified: trunk/Tools/ChangeLog (290809 => 290810)

--- trunk/Tools/ChangeLog	2022-03-04 01:38:16 UTC (rev 290809)
+++ trunk/Tools/ChangeLog	2022-03-04 02:19:22 UTC (rev 290810)
@@ -1,3 +1,16 @@
+2022-03-03  Jonathan Bedard  
+
+[git-webkit] Handle new PR with old branch name
+https://bugs.webkit.org/show_bug.cgi?id=237457
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
+(PullRequest.main):
+
 2022-03-03  Sihui Liu  
 
 Text manipulation does not observe updated title element


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (290809 => 290810)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-03-04 01:38:16 UTC (rev 290809)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-03-04 02:19:22 UTC (rev 290810)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='4.3.8',
+version='4.3.9',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (290809 => 290810)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-03-04 01:38:16 UTC (rev 290809)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-03-04 02:19:22 UTC (rev 290810)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(4, 3, 8)
+version = Version(4, 3, 9)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('jinja2', Version(2, 11, 3)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py (290809 => 290810)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py	2022-03-04 01:38:16 UTC (rev 290809)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py	2022-03-04 02:19:22 UTC (rev 290810)
@@ -213,7 +213,7 @@
 for pr in rmt.pull_requests.find(opened=None, head=repository.branch):
 existing_pr = pr
 if existing_pr.opened:
-continue
+break
 if existing_pr and not existing_pr.opened and not args.defaults and (args.defaults is False or Terminal.choose(
 "'{}' is already associated with '{}', which is closed.\nWould you like to create a new pull-request?".format(
 repository.branch, existing_pr,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290809] tags/Safari-614.1.5.6/

[repstein]

Title: [290809] tags/Safari-614.1.5.6/








Revision 290809
Author repst...@apple.com
Date 2022-03-03 17:38:16 -0800 (Thu, 03 Mar 2022)


Log Message
Tag Safari-614.1.5.6.

Added Paths

tags/Safari-614.1.5.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290808] tags/Safari-614.1.5.6/

[repstein]

Title: [290808] tags/Safari-614.1.5.6/








Revision 290808
Author repst...@apple.com
Date 2022-03-03 17:38:07 -0800 (Thu, 03 Mar 2022)


Log Message
Remove tag.

Removed Paths

tags/Safari-614.1.5.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290806] trunk

[sihui_liu]

Title: [290806] trunk








Revision 290806
Author sihui_...@apple.com
Date 2022-03-03 17:32:11 -0800 (Thu, 03 Mar 2022)


Log Message
Text manipulation does not observe updated title element
https://bugs.webkit.org/show_bug.cgi?id=237435
rdar://87318842

Reviewed by Wenson Hsieh.

Source/WebCore:

TextManipulationController now monitors two types of nodes (after first-time manipulation):
(1) manipulated nodes with content update
(2) non-manipulated nodes (newly displayed or newly added)
We should make sure title element gets added to set (1) if it's newly created, and gets added to set (2) if its
text content is updated.

New test: TextManipulation.CompleteTextManipulationForTitleElement

* dom/Document.cpp:
(WebCore::Document::setTitle):
* dom/Text.cpp:
(WebCore::Text::setDataAndUpdate):
* editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::didUpdateContentForNode):
(WebCore::TextManipulationController::didAddOrCreateRendererForNode):
(WebCore::TextManipulationController::scheduleObservationUpdate):
(WebCore::TextManipulationController::replace):
(WebCore::TextManipulationController::didCreateRendererForElement): Deleted.
(WebCore::TextManipulationController::didUpdateContentForText): Deleted.
(WebCore::TextManipulationController::didCreateRendererForTextNode): Deleted.
* editing/TextManipulationController.h:
* html/HTMLTitleElement.cpp:
* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createRenderer):
(WebCore::RenderTreeUpdater::createTextRenderer):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Text.cpp
trunk/Source/WebCore/editing/TextManipulationController.cpp
trunk/Source/WebCore/editing/TextManipulationController.h
trunk/Source/WebCore/html/HTMLTitleElement.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (290805 => 290806)

--- trunk/Source/WebCore/ChangeLog	2022-03-04 01:26:55 UTC (rev 290805)
+++ trunk/Source/WebCore/ChangeLog	2022-03-04 01:32:11 UTC (rev 290806)
@@ -1,3 +1,37 @@
+2022-03-03  Sihui Liu  
+
+Text manipulation does not observe updated title element
+https://bugs.webkit.org/show_bug.cgi?id=237435
+rdar://87318842
+
+Reviewed by Wenson Hsieh.
+
+TextManipulationController now monitors two types of nodes (after first-time manipulation): 
+(1) manipulated nodes with content update 
+(2) non-manipulated nodes (newly displayed or newly added)
+We should make sure title element gets added to set (1) if it's newly created, and gets added to set (2) if its
+text content is updated.
+
+New test: TextManipulation.CompleteTextManipulationForTitleElement
+
+* dom/Document.cpp:
+(WebCore::Document::setTitle):
+* dom/Text.cpp:
+(WebCore::Text::setDataAndUpdate):
+* editing/TextManipulationController.cpp:
+(WebCore::TextManipulationController::didUpdateContentForNode):
+(WebCore::TextManipulationController::didAddOrCreateRendererForNode):
+(WebCore::TextManipulationController::scheduleObservationUpdate):
+(WebCore::TextManipulationController::replace):
+(WebCore::TextManipulationController::didCreateRendererForElement): Deleted.
+(WebCore::TextManipulationController::didUpdateContentForText): Deleted.
+(WebCore::TextManipulationController::didCreateRendererForTextNode): Deleted.
+* editing/TextManipulationController.h:
+* html/HTMLTitleElement.cpp:
+* rendering/updating/RenderTreeUpdater.cpp:
+(WebCore::RenderTreeUpdater::createRenderer):
+(WebCore::RenderTreeUpdater::createTextRenderer):
+
 2022-03-03  Michael Saboff  
 
 Copy WebKit frameworks and XPC processes to Secondary Path


Modified: trunk/Source/WebCore/dom/Document.cpp (290805 => 290806)

--- trunk/Source/WebCore/dom/Document.cpp	2022-03-04 01:26:55 UTC (rev 290805)
+++ trunk/Source/WebCore/dom/Document.cpp	2022-03-04 01:32:11 UTC (rev 290806)
@@ -1726,6 +1726,7 @@
 if (m_titleElement)
 m_titleElement->setTextContent(title);
 } else if (is(element)) {
+std::optional oldTitle;
 if (!m_titleElement) {
 RefPtr headElement = head();
 if (!headElement)
@@ -1732,10 +1733,21 @@
 return;
 m_titleElement = HTMLTitleElement::create(HTMLNames::titleTag, *this);
 headElement->appendChild(*m_titleElement);
+} else
+oldTitle = m_titleElement->textContent();
+
+// appendChild above may have run scripts which removed m_titleElement.
+if (!m_titleElement)
+return;
+
+m_titleElement->setTextContent(title);
+auto* 

[webkit-changes] [290805] trunk/Source

[msaboff]

Title: [290805] trunk/Source








Revision 290805
Author msab...@apple.com
Date 2022-03-03 17:26:55 -0800 (Thu, 03 Mar 2022)


Log Message
Copy WebKit frameworks and XPC processes to Secondary Path
https://bugs.webkit.org/show_bug.cgi?id=237394

Reviewed by Saam Barati.

Source/_javascript_Core:

Added build configuration variables and scripts to copy the built Framework to the SYSTEM_SECONDARY_CONTENT_PATH
when it is set.

* Configurations/Base.xcconfig:
* _javascript_Core.xcodeproj/project.pbxproj:
* Scripts/copy-frameworks-to-secondary-path.sh: Added.

Source/ThirdParty/ANGLE:

Added build configuration variables and scripts to copy the built Framework to the SYSTEM_SECONDARY_CONTENT_PATH
when it is set.

* ANGLE.xcodeproj/project.pbxproj:
* Configurations/ANGLE-dynamic.xcconfig:
* scripts/copy-frameworks-to-secondary-path.sh: Added.

Source/ThirdParty/libwebrtc:

Added build configuration variables and scripts to copy the built Framework to the SYSTEM_SECONDARY_CONTENT_PATH
when it is set.

* Configurations/libwebrtc.xcconfig:
* Scripts/copy-frameworks-to-secondary-path.sh: Added.
* libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:

Added build configuration variables and scripts to copy the built Framework to the SYSTEM_SECONDARY_CONTENT_PATH
when it is set.

* Configurations/WebCore.xcconfig:
* Scripts/copy-frameworks-to-secondary-path.sh: Added.
* WebCore.xcodeproj/project.pbxproj:

Source/WebGPU:

Added build configuration variables and scripts to copy the built Framework to the SYSTEM_SECONDARY_CONTENT_PATH
when it is set.

* Configurations/WebGPU.xcconfig:
* Scripts/copy-frameworks-to-secondary-path.sh: Added.
* WebGPU.xcodeproj/project.pbxproj:

Source/WebInspectorUI:

Added build configuration variables and scripts to copy the built Framework to the SYSTEM_SECONDARY_CONTENT_PATH
when it is set.

* Configurations/WebInspectorUIFramework.xcconfig:
* Scripts/copy-frameworks-to-secondary-path.sh: Added.
* WebInspectorUI.xcodeproj/project.pbxproj:

Source/WebKit:

Added build configuration variables and scripts to copy the built Framework as well as the XPC services 
to the SYSTEM_SECONDARY_CONTENT_PATH when it is set.  When copying the XPC services, we update the XPC
binaries to reference the frameworks from the SYSTEM_SECONDARY_CONTENT_PATH by updating
DYLD_VERSIONED_FRAMEWORK_PATH.

* Configurations/Base.xcconfig:
* Configurations/WebKitSwift.xcconfig:
* Scripts/copy-frameworks-to-secondary-path.sh: Added.
* Scripts/copy-xpc-services-to-secondary-path.sh: Added.
* Scripts/update-dyld-environment-load-command: Added.
* Scripts/webkitpy: Added.
* Scripts/webkitpy/mach_o.py: Added.
(_utf8_bytes_to_str):
(_mach_o_int_field):
(_mach_o_int_field._get_mach_o_int_field):
(_mach_o_int_field._set_mach_o_int_field):
(_mach_o_int_field._set_mach_o_int_field.func):
(_mach_o_chararray_field):
(_mach_o_chararray_field._get_mach_o_chararray_field):
(_mach_o_chararray_field._set_mach_o_chararray_field):
(_mach_o_chararray_field._set_mach_o_chararray_field.func):
(_mach_o_varchar_field):
(_mach_o_varchar_field._get_mach_o_varchar_field):
(_mach_o_varchar_field._set_mach_o_varchar_field):
(_mach_o_varchar_field._set_mach_o_varchar_field.func):
(MachOCommand):
(MachOCommand.__init__):
(MachOSourceVersionCommand):
(MachOSourceVersionCommand.version_str):
(MachOSection):
(MachOSection.__init__):
(MachOSegmentCommand):
(MachOSection32):
(MachOSegment32Command):
(MachOSegment32Command.__init__):
(MachOSection64):
(MachOSegment64Command):
(MachOSegment64Command.__init__):
(MachOLoadDylibCommand):
(MachOLoadDylibCommand._version_str):
(MachOLoadDylibCommand.compatibility_version_str):
(MachOLoadDylibCommand.current_version_str):
(MachODyldEnvironmentCommand):
(MachODyldEnvironmentCommand.variable):
(MachODyldEnvironmentCommand.value):
(MachODyldEnvironmentCommand.build):
(MachOIDDylibCommand):
(MachOHeader):
(MachOHeader.__init__):
(MachOHeader.used_header_size):
(MachOHeader.total_header_size):
(MachOHeader.available_header_size):
(MachOHeader.architecture_name):
(MachOHeader.id_command):
(MachOHeader.dyld_env_commands):
(MachOHeader.dyld_versioned_framework_paths):
(MachOHeader.filter_commands):
(MachOHeader.update_file):
(MachOHeader.parse_command):
(MachOHeader32LE):
(MachOHeader32LE.__init__):
(MachOHeader64LE):
(MachOHeader64LE.__init__):
(MachOFile):
(MachOFile.__init__):
(is_macho_bytes):
(is_macho_file):
(enumerate_macho_files):
* WebKit.xcodeproj/project.pbxproj:

Source/WebKitLegacy:

Added build configuration variables and scripts to copy the built Framework to the SYSTEM_SECONDARY_CONTENT_PATH
when it is set.

* WebKitLegacy.xcodeproj/project.pbxproj:
* scripts/copy-frameworks-to-secondary-path.sh: Added.

Source/WebKitLegacy/mac:

Added build configuration variables and scripts to copy the built Framework to the SYSTEM_SECONDARY_CONTENT_PATH
when it is set.

* Configurations/Base.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog

[webkit-changes] [290804] tags/Safari-614.1.5.6/

[alancoon]

Title: [290804] tags/Safari-614.1.5.6/








Revision 290804
Author alanc...@apple.com
Date 2022-03-03 17:21:23 -0800 (Thu, 03 Mar 2022)


Log Message
Tag Safari-614.1.5.6.

Added Paths

tags/Safari-614.1.5.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290803] trunk/Source/WebCore

[commit-queue]

Title: [290803] trunk/Source/WebCore








Revision 290803
Author commit-qu...@webkit.org
Date 2022-03-03 17:08:25 -0800 (Thu, 03 Mar 2022)


Log Message
Allow [SecureContext] extended attribute on namespaces.
https://bugs.webkit.org/show_bug.cgi?id=237401

Patch by Dan Glastonbury  on 2022-03-03
Reviewed by Alexey Shvayka.

* bindings/scripts/IDLAttributes.json:
Enable SecureContext as a valid extended attribute on namespace.
* bindings/scripts/test/BindingTestGlobalConstructors.idl:
* bindings/scripts/test/JS/*: Updated
* bindings/scripts/test/TestNamespaceObject.idl:
Added [SecureContext] to namespace

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/IDLAttributes.json
trunk/Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp
trunk/Source/WebCore/bindings/scripts/test/TestNamespaceObject.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (290802 => 290803)

--- trunk/Source/WebCore/ChangeLog	2022-03-04 01:06:26 UTC (rev 290802)
+++ trunk/Source/WebCore/ChangeLog	2022-03-04 01:08:25 UTC (rev 290803)
@@ -1,3 +1,17 @@
+2022-03-03  Dan Glastonbury  
+
+Allow [SecureContext] extended attribute on namespaces.
+https://bugs.webkit.org/show_bug.cgi?id=237401
+
+Reviewed by Alexey Shvayka.
+
+* bindings/scripts/IDLAttributes.json:
+Enable SecureContext as a valid extended attribute on namespace.
+* bindings/scripts/test/BindingTestGlobalConstructors.idl:
+* bindings/scripts/test/JS/*: Updated
+* bindings/scripts/test/TestNamespaceObject.idl:
+Added [SecureContext] to namespace
+
 2022-03-03  Simon Fraser  
 
 nasa.gov page with fixed backgrounds paints incorrectly on scroll


Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.json (290802 => 290803)

--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.json	2022-03-04 01:06:26 UTC (rev 290802)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.json	2022-03-04 01:08:25 UTC (rev 290803)
@@ -461,7 +461,7 @@
 "unsupported": true
 },
 "SecureContext": {
-"contextsAllowed": ["interface", "dictionary", "enum", "attribute", "operation", "constant"],
+"contextsAllowed": ["interface", "namespace", "dictionary", "enum", "attribute", "operation", "constant"],
 "standard": {
 "url": "https://webidl.spec.whatwg.org/#SecureContext"
 }


Modified: trunk/Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl (290802 => 290803)

--- trunk/Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl	2022-03-04 01:06:26 UTC (rev 290802)
+++ trunk/Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl	2022-03-04 01:08:25 UTC (rev 290803)
@@ -45,7 +45,7 @@
 attribute TestNamedSetterWithLegacyOverrideBuiltInsConstructor TestNamedSetterWithLegacyOverrideBuiltIns;
 attribute TestNamedSetterWithLegacyUnforgeablePropertiesConstructor TestNamedSetterWithLegacyUnforgeableProperties;
 attribute TestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor TestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns;
-attribute TestNamespaceObjectConstructor TestInterfaceName;
+[SecureContext] attribute TestNamespaceObjectConstructor TestInterfaceName;
 [Conditional=ConditionDerived] attribute TestOperationConditionalConstructor TestOperationConditional;
 attribute TestOverloadedConstructorsWithSequenceConstructor TestOverloadedConstructorsWithSequence;
 attribute TestPluginInterfaceConstructor TestPluginInterface;


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp (290802 => 290803)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp	2022-03-04 01:06:26 UTC (rev 290802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp	2022-03-04 01:08:25 UTC (rev 290803)
@@ -260,16 +260,15 @@
 { -1, -1 },
 { -1, -1 },
 { -1, -1 },
-{ 55, -1 },
+{ 54, -1 },
 { -1, -1 },
 { -1, -1 },
 { -1, -1 },
 { -1, -1 },
 { -1, -1 },
-{ 49, -1 },
 { -1, -1 },
-{ 64, -1 },
 { -1, -1 },
+{ 63, -1 },
 { -1, -1 },
 { -1, -1 },
 { -1, -1 },
@@ -282,6 +281,7 @@
 { -1, -1 },
 { -1, -1 },
 { -1, -1 },
+{ -1, -1 },
 { 35, -1 },
 { -1, -1 },
 { -1, -1 },
@@ -288,7 +288,7 @@
 { -1, -1 },
 { -1, -1 },
 { -1, -1 },
-{ 68, -1 },
+{ 67, -1 },
 { 13, 261 },
 { -1, -1 },
 { -1, -1 },
@@ -332,7 +332,7 @@
 { -1, -1 },
 { -1, -1 },
 { 30, -1 },
-{ 57, -1 },
+{ 56, -1 },
 { -1, -1 },
 { -1, -1 },
 { -1, -1 },
@@ -341,7 +341,7 @@
 { -1, -1 },
 { 9, 257 },
 { -1, -1 },
-{ 59, -1 },
+{ 58, -1 },
 { 19, -1 },
 { -1, -1 },
 { -1, -1 },
@@ -387,7 +387,7 @@
 

[webkit-changes] [290802] trunk

[commit-queue]

Title: [290802] trunk








Revision 290802
Author commit-qu...@webkit.org
Date 2022-03-03 17:06:26 -0800 (Thu, 03 Mar 2022)


Log Message
[JSC] Update wasm branch hinting
https://bugs.webkit.org/show_bug.cgi?id=237411

Patch by Tom Tartarin  on 2022-03-03
Reviewed by Yusuke Suzuki.

JSTests:

Simplify the module tested with the updated format.

* wasm/branch-hints/branchHintsModule.wasm:
* wasm/branch-hints/branchHintsSection.js:

Source/_javascript_Core:

Change the section's name.
Clarify semantics in the parser.

* wasm/WasmBranchHintsSectionParser.cpp:
(JSC::Wasm::BranchHintsSectionParser::parse):
* wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseCustom):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/branch-hints/branchHintsModule.wasm
trunk/JSTests/wasm/branch-hints/branchHintsSection.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmBranchHintsSectionParser.cpp
trunk/Source/_javascript_Core/wasm/WasmSectionParser.cpp




Diff

Modified: trunk/JSTests/ChangeLog (290801 => 290802)

--- trunk/JSTests/ChangeLog	2022-03-04 01:04:39 UTC (rev 290801)
+++ trunk/JSTests/ChangeLog	2022-03-04 01:06:26 UTC (rev 290802)
@@ -1,3 +1,15 @@
+2022-03-03  Tom Tartarin  
+
+[JSC] Update wasm branch hinting
+https://bugs.webkit.org/show_bug.cgi?id=237411
+
+Reviewed by Yusuke Suzuki.
+
+Simplify the module tested with the updated format.
+
+* wasm/branch-hints/branchHintsModule.wasm:
+* wasm/branch-hints/branchHintsSection.js:
+
 2022-02-25  Mark Lam  
 
 operationMaterializeObjectInOSR should DeferTerminationForAWhile instead of just DeferTermination.


Modified: trunk/JSTests/wasm/branch-hints/branchHintsModule.wasm (290801 => 290802)

--- trunk/JSTests/wasm/branch-hints/branchHintsModule.wasm	2022-03-04 01:04:39 UTC (rev 290801)
+++ trunk/JSTests/wasm/branch-hints/branchHintsModule.wasm	2022-03-04 01:06:26 UTC (rev 290802)
@@ -1,4 +1,5 @@
-asm

-``

`

p




\x80
	

A\x80\x80\xC0memory_main
	
A
%code_annotation.branch_hint


%


-1+
A"!@ AІF@A
! A
j"A\xA0\x8DG- 
\ No newline at end of file
+asm


`



_fun#metadata.code.branch_hint




+(
&

A
+"
 l"A
+J@ @ AL+  

\ No newline at end of file


Modified: trunk/JSTests/wasm/branch-hints/branchHintsSection.js (290801 => 290802)

--- trunk/JSTests/wasm/branch-hints/branchHintsSection.js	2022-03-04 01:04:39 UTC (rev 290801)
+++ trunk/JSTests/wasm/branch-hints/branchHintsSection.js	2022-03-04 01:06:26 UTC (rev 290802)
@@ -1,44 +1,36 @@
 import * as assert from '../assert.js'
 
 /*
-This test loads a WebAssembly file compiled with wat2wasm with support for code annotations.
-see: https://github.com/yuri91/wabt/tree/annotations
+This test loads a WebAssembly file compiled with wat2wasm with support for code annotations:
+wat2wasm --enable-annotations --enable-code-metadata branchHintsModule
 
 From the following .wat:
 (module
-  (type (;0;) (func))
-  (type (;1;) (func (param i32) (result i32)))
-  (type (;2;) (func (result i32)))
-  (func $__wasm_nullptr (type 0)
-unreachable)
-  (func $main (type 2) (result i32)
-(local i32 i32 i32 i32)
-i32.const 0
-local.tee 2
-local.set 3
-loop  ;; label = @1
-  local.get 2
-  i32.const 5
-  i32.eq
-  (@code_annotation.branch_hint "\00") if  ;; label = @2
-i32.const 1
-local.set 3
-  end
-  local.get 2
-  i32.const 1
-  i32.add
-  local.tee 2
-  i32.const 10
-  i32.ne
-  (@code_annotation.branch_hint "\01") br_if 0 (;@1;)
-end
-local.get 3)
-  (table (;0;) 1 1 funcref)
-  (memory (;0;) 17 128)
-  (global (;0;) (mut i32) (i32.const 1048576))
-  (export "memory" (memory 0))
-  (export "_main" (func $main))
-  (elem (;0;) (i32.const 0) func $__wasm_nullptr))
+  (func $fun (param i32) (result i32)
+(local i32)
+i32.const 10
+local.tee 1
+local.get 0
+i32.mul
+local.tee 0
+i32.const 10
+i32.gt_s
+(@metadata.code.branch_hint "\01") if
+  local.get 0
+  return
+end
+(block
+  local.get 0
+  i32.const 0
+  i32.le_s
+  (@metadata.code.branch_hint "\00") br_if 0
+  local.get 0
+  return
+)
+local.get 1
+return
+  )
+  (export "_fun" (func $fun)))
 */
 
 const verbose = false;
@@ -55,8 +47,11 @@
 };
 
 const branchHintsModule = module(wasmFile);
-const parsedBranchHintsSection = WebAssembly.Module.customSections(branchHintsModule, "code_annotation.branch_hint");
+const parsedBranchHintsSection = WebAssembly.Module.customSections(branchHintsModule, "metadata.code.branch_hint");
 assert.eq(parsedBranchHintsSection.length, 1);
 const instance = new WebAssembly.Instance(branchHintsModule);
-const result = 

[webkit-changes] [290801] trunk

[commit-queue]

Title: [290801] trunk








Revision 290801
Author commit-qu...@webkit.org
Date 2022-03-03 17:04:39 -0800 (Thu, 03 Mar 2022)


Log Message
Add Dan Glastonbury's name to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237453

Patch by Dan Glastonbury  on 2022-03-03
Reviewed by Alan Bujtas.

* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (290800 => 290801)

--- trunk/ChangeLog	2022-03-04 00:57:34 UTC (rev 290800)
+++ trunk/ChangeLog	2022-03-04 01:04:39 UTC (rev 290801)
@@ -1,3 +1,12 @@
+2022-03-03  Dan Glastonbury  
+
+Add Dan Glastonbury's name to contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=237453
+
+Reviewed by Alan Bujtas.
+
+* metadata/contributors.json:
+
 2022-03-03  Anjali Kumar  
 
 Add myself (Anjali Kumar) to contributors.json


Modified: trunk/metadata/contributors.json (290800 => 290801)

--- trunk/metadata/contributors.json	2022-03-04 00:57:34 UTC (rev 290800)
+++ trunk/metadata/contributors.json	2022-03-04 01:04:39 UTC (rev 290801)
@@ -1671,6 +1671,16 @@
},
{
   "emails" : [
+ "d...@apple.com"
+  ],
+  "github" : "djg",
+  "name" : "Dan Glastonbury",
+  "nicks" : [
+ "djg"
+  ]
+   },
+   {
+  "emails" : [
  "d...@gnome.org"
   ],
   "name" : "Dan Winship",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290800] trunk

[commit-queue]

Title: [290800] trunk








Revision 290800
Author commit-qu...@webkit.org
Date 2022-03-03 16:57:34 -0800 (Thu, 03 Mar 2022)


Log Message
Add myself (Anjali Kumar) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237449

Patch by Anjali Kumar  on 2022-03-03
Reviewed by Patrick Angle.

* metadata/contributors.json: Added myself.

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (290799 => 290800)

--- trunk/ChangeLog	2022-03-04 00:53:08 UTC (rev 290799)
+++ trunk/ChangeLog	2022-03-04 00:57:34 UTC (rev 290800)
@@ -1,3 +1,12 @@
+2022-03-03  Anjali Kumar  
+
+Add myself (Anjali Kumar) to contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=237449
+
+Reviewed by Patrick Angle.
+
+* metadata/contributors.json: Added myself.
+
 2022-03-01  Jonathan Bedard  
 
 [git-webkit] Sync personal fork by default


Modified: trunk/metadata/contributors.json (290799 => 290800)

--- trunk/metadata/contributors.json	2022-03-04 00:53:08 UTC (rev 290799)
+++ trunk/metadata/contributors.json	2022-03-04 00:57:34 UTC (rev 290800)
@@ -751,6 +751,15 @@
},
{
   "emails" : [
+ "anjalik...@apple.com"
+  ],
+  "name" : "Anjali Kumar",
+  "nicks" : [
+ "anjalik"
+  ]
+   },
+   {
+  "emails" : [
  "ann...@chromium.org"
   ],
   "name" : "Anna Cavender",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290799] trunk/Tools

[lmoura]

Title: [290799] trunk/Tools








Revision 290799
Author lmo...@igalia.com
Date 2022-03-03 16:53:08 -0800 (Thu, 03 Mar 2022)


Log Message
[Python3] Switch a few more glib scripts to Python3
https://bugs.webkit.org/show_bug.cgi?id=237442

Reviewed by Adrian Perez de Castro.

* Scripts/check-for-global-bss-symbols-in-webkitgtk-libs: Update
shebang.
(bss_symbols): Decode Popen bytes output.
* gtk/jhbuildrc: Update shebang.
* gtk/ycm_extra_conf.py: Ditto.
* jhbuild/jhbuild-wrapper: Ditto.
(jhbuild_at_expected_revision): Decode Popen bytes output.
* jhbuild/jhbuildrc_common.py: Remove uneeded shebang.
* wpe/jhbuildrc: Update shebang.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs
trunk/Tools/gtk/jhbuildrc
trunk/Tools/gtk/ycm_extra_conf.py
trunk/Tools/jhbuild/jhbuild-wrapper
trunk/Tools/jhbuild/jhbuildrc_common.py
trunk/Tools/wpe/jhbuildrc




Diff

Modified: trunk/Tools/ChangeLog (290798 => 290799)

--- trunk/Tools/ChangeLog	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/ChangeLog	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,3 +1,20 @@
+2022-03-03  Lauro Moura  
+
+[Python3] Switch a few more glib scripts to Python3
+https://bugs.webkit.org/show_bug.cgi?id=237442
+
+Reviewed by Adrian Perez de Castro.
+
+* Scripts/check-for-global-bss-symbols-in-webkitgtk-libs: Update
+shebang.
+(bss_symbols): Decode Popen bytes output.
+* gtk/jhbuildrc: Update shebang.
+* gtk/ycm_extra_conf.py: Ditto.
+* jhbuild/jhbuild-wrapper: Ditto.
+(jhbuild_at_expected_revision): Decode Popen bytes output.
+* jhbuild/jhbuildrc_common.py: Remove uneeded shebang.
+* wpe/jhbuildrc: Update shebang.
+
 2022-03-03  Jonathan Bedard  
 
 [webkitcorepy] Disable prompt when saving credentials


Modified: trunk/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs (290798 => 290799)

--- trunk/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 import re
 import subprocess
@@ -10,7 +10,7 @@
 data = ""
 pattern = re.compile('^[0-9a-f]+ ([a-zA-Z ])[a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ] \.bss\t[0-9a-f]+ +(.*)$')
 for line in data.splitlines():
-m = pattern.match(line)
+m = pattern.match(line.decode('utf-8', 'ignore'))
 if not m:
 continue
 if sfilter is None or sfilter(m.group(1)):


Modified: trunk/Tools/gtk/jhbuildrc (290798 => 290799)

--- trunk/Tools/gtk/jhbuildrc	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/gtk/jhbuildrc	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2011-2014 Igalia S.L.
 #
 # This library is free software; you can redistribute it and/or


Modified: trunk/Tools/gtk/ycm_extra_conf.py (290798 => 290799)

--- trunk/Tools/gtk/ycm_extra_conf.py	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/gtk/ycm_extra_conf.py	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2013 Danilo Cesar Lemes de Paula 
 # Copyright (C) 2014 ChangSeok Oh 
 #


Modified: trunk/Tools/jhbuild/jhbuild-wrapper (290798 => 290799)

--- trunk/Tools/jhbuild/jhbuild-wrapper	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/jhbuild/jhbuild-wrapper	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2011 Igalia S.L.
 # Copyright (C) 2012 Gustavo Noronha Silva 
 # Copyright (C) 2012 Intel Corporation
@@ -59,7 +59,7 @@
 if process.returncode != 0:
 raise Exception('failed to find jhbuild revision: %s' % err)
 
-return output.strip() == jhbuild_revision
+return output.strip().decode('utf-8', 'ignore') == jhbuild_revision
 
 
 def update_jhbuild():


Modified: trunk/Tools/jhbuild/jhbuildrc_common.py (290798 => 290799)

--- trunk/Tools/jhbuild/jhbuildrc_common.py	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/jhbuild/jhbuildrc_common.py	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 # Copyright (C) 2011 Igalia S.L.
 # Copyright (C) 2012 Intel Corporation
 #


Modified: trunk/Tools/wpe/jhbuildrc (290798 => 290799)

--- trunk/Tools/wpe/jhbuildrc	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/wpe/jhbuildrc	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2014 Igalia S.L.
 #
 # This library is free software; you can redistribute it and/or






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290798] trunk/Source/WebKit

[jenner]

Title: [290798] trunk/Source/WebKit








Revision 290798
Author jen...@apple.com
Date 2022-03-03 15:46:29 -0800 (Thu, 03 Mar 2022)


Log Message
Unreviewed, reverting r290752.

r290752 broke mutliple tests, slowing down the iOS15 EWS
queue.

Reverted changeset:

"[iOS] Hard link AVPictureInPictureController"
https://bugs.webkit.org/show_bug.cgi?id=237227
https://commits.webkit.org/r290752

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (290797 => 290798)

--- trunk/Source/WebKit/ChangeLog	2022-03-03 23:25:50 UTC (rev 290797)
+++ trunk/Source/WebKit/ChangeLog	2022-03-03 23:46:29 UTC (rev 290798)
@@ -1,3 +1,16 @@
+2022-03-03  Robert Jenner  
+
+Unreviewed, reverting r290752.
+
+r290752 broke mutliple tests, slowing down the iOS15 EWS
+queue.
+
+Reverted changeset:
+
+"[iOS] Hard link AVPictureInPictureController"
+https://bugs.webkit.org/show_bug.cgi?id=237227
+https://commits.webkit.org/r290752
+
 2022-03-03  Tim Horton  
 
 WKContentView should explicitly request the system pointer in the fallback case


Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (290797 => 290798)

--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2022-03-03 23:25:50 UTC (rev 290797)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2022-03-03 23:46:29 UTC (rev 290798)
@@ -152,17 +152,11 @@
 WK_LIBNETWORKEXTENSION_LDFLAGS_macosx = -weak_library /usr/lib/libnetworkextension.dylib;
 WK_LIBNETWORKEXTENSION_LDFLAGS_tvos = ;
 
-WK_AVKIT_LDFLAGS = $(WK_AVKIT_LDFLAGS$(WK_PLATFORM_NAME));
-WK_AVKIT_LDFLAGS_iphoneos = -framework AVKit;
-WK_AVKIT_LDFLAGS_iphonesimulator = -framework AVKit;
-WK_AVKIT_LDFLAGS_maccatalyst = -framework AVKit;
-WK_AVKIT_LDFLAGS_tvos = -framework AVKit;
-
 WK_INSTALL_COORDINATION_LDFLAGS = $(WK_INSTALL_COORDINATION_LDFLAGS_$(WK_PLATFORM_NAME));
 WK_INSTALL_COORDINATION_LDFLAGS_iphoneos = -framework InstallCoordination;
 WK_INSTALL_COORDINATION_LDFLAGS_iphonesimulator = $(WK_INSTALL_COORDINATION_LDFLAGS_iphoneos)
 
-FRAMEWORK_AND_LIBRARY_LDFLAGS = -lobjc -framework CFNetwork -framework CoreAudio -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework IOKit -framework IOSurface -framework WebKitLegacy -lnetwork -framework Metal $(WK_ACCESSIBILITY_LDFLAGS) $(WK_APPKIT_LDFLAGS) $(WK_BACKBOARD_SERVICES_LDFLAGS) $(WK_RUNNINGBOARD_SERVICES_LDFLAGS) $(WK_AUTHKIT_LDFLAGS) $(WK_CARBON_LDFLAGS) $(WK_CONTACTS_LDFLAGS) $(WK_CORE_PREDICTION_LDFLAGS) $(WK_CORE_SERVICES_LDFLAGS) $(WK_GRAPHICS_SERVICES_LDFLAGS) $(WK_LIBNETWORKEXTENSION_LDFLAGS) $(WK_LIBSANDBOX_LDFLAGS) $(WK_LIBWEBRTC_LDFLAGS) $(WK_MOBILE_CORE_SERVICES_LDFLAGS) $(WK_MOBILE_GESTALT_LDFLAGS) $(WK_PDFKIT_LDFLAGS) $(WK_PROTOTYPE_TOOLS_LDFLAGS) $(WK_SAFE_BROWSING_LDFLAGS) $(WK_SECURITY_INTERFACE_LDFLAGS) $(WK_UIKIT_LDFLAGS) $(WK_UNIFORM_TYPE_IDENTIFIERS_LDFLAGS) $(WK_URL_FORMATTING_LDFLAGS) $(WK_WEBINSPECTORUI_LDFLAGS) $(WK_COORDINATOR_LDFLAGS) $(WK_INSTALL_COORDINATION_LD
 FLAGS) $(WK_AVKIT_LDFLAGS);
+FRAMEWORK_AND_LIBRARY_LDFLAGS = -lobjc -framework CFNetwork -framework CoreAudio -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework IOKit -framework IOSurface -framework WebKitLegacy -lnetwork -framework Metal $(WK_ACCESSIBILITY_LDFLAGS) $(WK_APPKIT_LDFLAGS) $(WK_BACKBOARD_SERVICES_LDFLAGS) $(WK_RUNNINGBOARD_SERVICES_LDFLAGS) $(WK_AUTHKIT_LDFLAGS) $(WK_CARBON_LDFLAGS) $(WK_CONTACTS_LDFLAGS) $(WK_CORE_PREDICTION_LDFLAGS) $(WK_CORE_SERVICES_LDFLAGS) $(WK_GRAPHICS_SERVICES_LDFLAGS) $(WK_LIBNETWORKEXTENSION_LDFLAGS) $(WK_LIBSANDBOX_LDFLAGS) $(WK_LIBWEBRTC_LDFLAGS) $(WK_MOBILE_CORE_SERVICES_LDFLAGS) $(WK_MOBILE_GESTALT_LDFLAGS) $(WK_PDFKIT_LDFLAGS) $(WK_PROTOTYPE_TOOLS_LDFLAGS) $(WK_SAFE_BROWSING_LDFLAGS) $(WK_SECURITY_INTERFACE_LDFLAGS) $(WK_UIKIT_LDFLAGS) $(WK_UNIFORM_TYPE_IDENTIFIERS_LDFLAGS) $(WK_URL_FORMATTING_LDFLAGS) $(WK_WEBINSPECTORUI_LDFLAGS) $(WK_COORDINATOR_LDFLAGS) $(WK_INSTALL_COORDINATION_LDF
 LAGS);
 
 // Prevent C++ standard library basic_stringstream, operator new, delete and their related exception types from being exported as weak symbols.
 UNEXPORTED_SYMBOL_LDFLAGS = -Wl,-unexported_symbol -Wl,__ZTISt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTISt9exception -Wl,-unexported_symbol -Wl,__ZTSSt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTSSt9exception -Wl,-unexported_symbol -Wl,__ZdlPvS_ -Wl,-unexported_symbol -Wl,__ZnwmPv -Wl,-unexported_symbol -Wl,__Znwm -Wl,-unexported_symbol -Wl,__ZTVNSt3__117bad_function_callE -Wl,-unexported_symbol -Wl,__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIc0_NS_13basic_istreamIcS2_EE -Wl,-unexported_symbol -Wl,__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIc0_NS_14basic_iostreamIcS2_EE 

[webkit-changes] [290797] trunk/Source/WebKit

[timothy_horton]

Title: [290797] trunk/Source/WebKit








Revision 290797
Author timothy_hor...@apple.com
Date 2022-03-03 15:25:50 -0800 (Thu, 03 Mar 2022)


Log Message
WKContentView should explicitly request the system pointer in the fallback case
https://bugs.webkit.org/show_bug.cgi?id=237410


Reviewed by Anders Carlsson.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView pointerRegionForPositionInformation:point:]):
(-[WKContentView pointerInteraction:styleForRegion:]):
Instead of assuming a nil region and nil style will provide the system
pointer, provide a region the size of the WKContentView and explicitly
request the system pointer shape.

Also, drive-by adopt the API `systemPointerStyle` instead of the
deprecated SPI version.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (290796 => 290797)

--- trunk/Source/WebKit/ChangeLog	2022-03-03 22:51:22 UTC (rev 290796)
+++ trunk/Source/WebKit/ChangeLog	2022-03-03 23:25:50 UTC (rev 290797)
@@ -1,3 +1,21 @@
+2022-03-03  Tim Horton  
+
+WKContentView should explicitly request the system pointer in the fallback case
+https://bugs.webkit.org/show_bug.cgi?id=237410
+
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView pointerRegionForPositionInformation:point:]):
+(-[WKContentView pointerInteraction:styleForRegion:]):
+Instead of assuming a nil region and nil style will provide the system
+pointer, provide a region the size of the WKContentView and explicitly
+request the system pointer shape.
+
+Also, drive-by adopt the API `systemPointerStyle` instead of the
+deprecated SPI version.
+
 2022-03-03  Chris Dumez  
 
 [macOS] WebContent processes crash with XPC_EXIT_REASON_SIGTERM_TIMEOUT when logging out


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (290796 => 290797)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2022-03-03 22:51:22 UTC (rev 290796)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2022-03-03 23:25:50 UTC (rev 290797)
@@ -10014,7 +10014,7 @@
 return [UIPointerRegion regionWithRect:self.bounds identifier:editablePointerRegionIdentifier];
 }
 
-return nil;
+return [UIPointerRegion regionWithRect:self.bounds identifier:pointerRegionIdentifier];
 }
 
 - (UIPointerStyle *)pointerInteraction:(UIPointerInteraction *)interaction styleForRegion:(UIPointerRegion *)region
@@ -10039,7 +10039,7 @@
 
 if (self.webView._editable) {
 if (_positionInformation.shouldNotUseIBeamInEditableContent)
-return nil;
+return [UIPointerStyle systemPointerStyle];
 return iBeamCursor();
 }
 
@@ -10046,17 +10046,14 @@
 if (_positionInformation.cursor && [region.identifier isEqual:pointerRegionIdentifier]) {
 WebCore::Cursor::Type cursorType = _positionInformation.cursor->type();
 
-ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 if (cursorType == WebCore::Cursor::Hand)
-return [UIPointerStyle _systemPointerStyle];
-ALLOW_DEPRECATED_DECLARATIONS_END
+return [UIPointerStyle systemPointerStyle];
 
 if (cursorType == WebCore::Cursor::IBeam && _positionInformation.lineCaretExtent.contains(_positionInformation.request.point))
 return iBeamCursor();
 }
 
-ASSERT_NOT_REACHED();
-return nil;
+return [UIPointerStyle systemPointerStyle];
 }
 
 #endif // HAVE(UI_POINTER_INTERACTION)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290796] trunk/Tools

[jbedard]

Title: [290796] trunk/Tools








Revision 290796
Author jbed...@apple.com
Date 2022-03-03 14:51:22 -0800 (Thu, 03 Mar 2022)


Log Message
[webkitcorepy] Disable prompt when saving credentials
https://bugs.webkit.org/show_bug.cgi?id=237438


Reviewed by Aakash Jain.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker.credentials): Pass 'save' to webkitcorepy.credentials.
* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:
(credentials): Unless caller explicitly disables saving, assume that all credentials
should be saved to a system's keyring.
* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.github): Automatically save any prompted credentials.
(Setup.git): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.credentials): Pass 'save' to github.Tracker.credentials.

Canonical link: https://commits.webkit.org/248036@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py




Diff

Modified: trunk/Tools/ChangeLog (290795 => 290796)

--- trunk/Tools/ChangeLog	2022-03-03 22:38:50 UTC (rev 290795)
+++ trunk/Tools/ChangeLog	2022-03-03 22:51:22 UTC (rev 290796)
@@ -1,5 +1,30 @@
 2022-03-03  Jonathan Bedard  
 
+[webkitcorepy] Disable prompt when saving credentials
+https://bugs.webkit.org/show_bug.cgi?id=237438
+
+
+Reviewed by Aakash Jain.
+
+* Scripts/libraries/webkitbugspy/setup.py: Bump version.
+* Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
+* Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
+(Tracker.credentials): Pass 'save' to webkitcorepy.credentials.
+* Scripts/libraries/webkitcorepy/setup.py: Bump version.
+* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
+* Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:
+(credentials): Unless caller explicitly disables saving, assume that all credentials
+should be saved to a system's keyring.
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
+(Setup.github): Automatically save any prompted credentials.
+(Setup.git): Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
+(GitHub.credentials): Pass 'save' to github.Tracker.credentials.
+
+2022-03-03  Jonathan Bedard  
+
 [git-webkit] Open pre-populated GitHub page for new tokens
 https://bugs.webkit.org/show_bug.cgi?id=237436
 


Modified: trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py (290795 => 290796)

--- trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py	2022-03-03 22:38:50 UTC (rev 290795)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py	2022-03-03 22:51:22 UTC (rev 290796)
@@ -86,7 +86,7 @@
 return self.issue(int(match.group('id')))
 return None
 
-def credentials(self, required=True, validate=False):
+def credentials(self, required=True, validate=False, save_in_keyring=None):
 def validater(username, access_token):
 if '@' in username:
 sys.stderr.write("Provided username contains an '@' symbol. Please make sure to enter your GitHub username, not an email associated with the account\n")
@@ -119,6 +119,7 @@
 prompt=prompt,
 key_name='token',
 validater=validater if validate else None,
+save_in_keyring=save_in_keyring,
 )
 
 def request(self, path=None, params=None, headers=None, authenticated=None, paginate=True):


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py (290795 => 290796)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py	2022-03-03 22:38:50 UTC (rev 290795)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py	2022-03-03 22:51:22 UTC (rev 290796)
@@ -29,7 +29,7 @@
 _cache = dict()
 
 
-def credentials(url, required=True, name=None, prompt=None, key_name='password', validater=None, retry=3):

[webkit-changes] [290795] trunk/Source/WebKit

[cdumez]

Title: [290795] trunk/Source/WebKit








Revision 290795
Author cdu...@apple.com
Date 2022-03-03 14:38:50 -0800 (Thu, 03 Mar 2022)


Log Message
[macOS] WebContent processes crash with XPC_EXIT_REASON_SIGTERM_TIMEOUT when logging out
https://bugs.webkit.org/show_bug.cgi?id=237398


Reviewed by Darin Adler.

Because we don't use RunningBoard on macOS, we leak an OS transaction to control the lifetime of our XPC
services ourselves. However, one of the side effects of leaking this transaction is that the default SIGTERM
handler doesn't cleanly exit our XPC services when logging out or rebooting. This led to crashes with
XPC_EXIT_REASON_SIGTERM_TIMEOUT as termination reason (rdar://88940229).

To address the issue, we now set our own SIGTERM handler that releases the OS transaction and calls the
default SIGTERM handler to exit cleanly. In the future, we should likely adopt RunningBoard on macOS and
control our lifetime via process assertions instead of leaking this OS transaction.

* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::setOSTransaction):
(WebKit::XPCServiceExit):
(WebKit::osTransaction): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (290794 => 290795)

--- trunk/Source/WebKit/ChangeLog	2022-03-03 22:07:56 UTC (rev 290794)
+++ trunk/Source/WebKit/ChangeLog	2022-03-03 22:38:50 UTC (rev 290795)
@@ -1,3 +1,27 @@
+2022-03-03  Chris Dumez  
+
+[macOS] WebContent processes crash with XPC_EXIT_REASON_SIGTERM_TIMEOUT when logging out
+https://bugs.webkit.org/show_bug.cgi?id=237398
+
+
+Reviewed by Darin Adler.
+
+Because we don't use RunningBoard on macOS, we leak an OS transaction to control the lifetime of our XPC
+services ourselves. However, one of the side effects of leaking this transaction is that the default SIGTERM
+handler doesn't cleanly exit our XPC services when logging out or rebooting. This led to crashes with
+XPC_EXIT_REASON_SIGTERM_TIMEOUT as termination reason (rdar://88940229).
+
+To address the issue, we now set our own SIGTERM handler that releases the OS transaction and calls the
+default SIGTERM handler to exit cleanly. In the future, we should likely adopt RunningBoard on macOS and
+control our lifetime via process assertions instead of leaking this OS transaction.
+
+* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
+(WebKit::XPCServiceInitializer):
+* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
+(WebKit::setOSTransaction):
+(WebKit::XPCServiceExit):
+(WebKit::osTransaction): Deleted.
+
 2022-03-03  Wenson Hsieh  
 
 [iOS] Further reduce hangs underneath -[WKContentView requestAutocorrectionContextWithCompletionHandler:]


Modified: trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h (290794 => 290795)

--- trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h	2022-03-03 22:07:56 UTC (rev 290794)
+++ trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h	2022-03-03 22:38:50 UTC (rev 290795)
@@ -82,7 +82,7 @@
 }
 
 #if PLATFORM(MAC)
-OSObjectPtr& osTransaction();
+void setOSTransaction(OSObjectPtr&&);
 #endif
 
 template
@@ -113,7 +113,7 @@
 // so ensure that we have an outstanding transaction here. This is not needed on iOS because
 // the UIProcess takes process assertions on behalf of its child processes.
 #if PLATFORM(MAC)
-osTransaction() = adoptOSObject(os_transaction_create("WebKit XPC Service"));
+setOSTransaction(adoptOSObject(os_transaction_create("WebKit XPC Service")));
 #endif
 
 InitializeWebKit2();


Modified: trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm (290794 => 290795)

--- trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm	2022-03-03 22:07:56 UTC (rev 290794)
+++ trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm	2022-03-03 22:38:50 UTC (rev 290795)
@@ -29,6 +29,7 @@
 #import "SandboxUtilities.h"
 #import "XPCServiceEntryPoint.h"
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -159,10 +160,27 @@
 }
 
 #if PLATFORM(MAC)
-OSObjectPtr& osTransaction()
+void setOSTransaction(OSObjectPtr&& transaction)
 {
-static NeverDestroyed> transaction;
-return transaction.get();
+static NeverDestroyed> globalTransaction;
+
+// Because we don't use RunningBoard on macOS, we leak an OS transaction to control the lifetime of our XPC
+// services ourselves. However, one of 

[webkit-changes] [290794] trunk/Source/WebKit

[wenson_hsieh]

Title: [290794] trunk/Source/WebKit








Revision 290794
Author wenson_hs...@apple.com
Date 2022-03-03 14:07:56 -0800 (Thu, 03 Mar 2022)


Log Message
[iOS] Further reduce hangs underneath -[WKContentView requestAutocorrectionContextWithCompletionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=237387
rdar://89654600

Reviewed by Tim Horton.

Tweak the mitigations landed in r288925 to be even more aggressive. Currently, we preemptively send an
autocorrection context from the web process to the UI process after receiving an IPC message from the UI process
indicating that an input view has been shown. However, this message might arrive too late in cases where the web
process hangs immediately after we're done setting element focus, within the very same runloop; in such a
scenario, we'll still end up hanging underneath the sync autocorrection request underneath `-_elementDidFocus:`
in the UI process.

We can instead make this mitigation even more aggressive, by setting a flag on WebPage when we're about to
propagate an `ElementDidFocus` message to the UI process that (in lieu of the WebKit client) would normally
cause the keyboard to appear. During the next DOM selection change, we then consult this flag and preemptively
send an autocorrection context to the UI process.

Additionally, remove another safeguard in the original change in r288925 which effectively invalidated the
cached autocorrection context after the end of the runloop by setting `_autocorrectionContextNeedsUpdate`. This
was only done to narrow the scope of the fix to just the scenario where UIKit requests autocorrection contexts
multiple times in the same runloop iteration. However, this appears to be insufficient to tackle more scenarios
where UIKit frequently requests autocorrection contexts even though the selection has not changed; hopefully, by
leaving `_autocorrectionContextNeedsUpdate := NO`, we can mitigate some of these other cases.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::notifySelectionChanged):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
* WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::notifyRevealedSelectionByScrollingFrame):
(WebKit::WebChromeClient::didLayout):
* WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::overflowScrollPositionChanged):
(WebKit::WebEditorClient::subFrameScrollPositionChanged):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didScrollSelection):
(WebKit::WebPage::didChangeSelection):

Split `didChangeSelection` into two methods: `didScrollSelection`, which is invoked from codepaths where we're
scheduling an editor state after overflow or mainframe scrolling, and `didChangeSelection`, which now takes a
`Frame` indicating the frame that contains the changed selection. On iOS, we handle this by both scheduling an
editor state update, but also preemptively sending the autocorrection context to the UI process if we've just
focused an element that will probably cause the keyboard to appear (unless the client explicitly prevents it).

Note that we must check the `frame` containing the changed selection and bail if the render tree is in the
middle of being destroyed, so that we don't end up triggering layout (and release asserting) in the case where
we're clearing the selection during document teardown.

(WebKit::WebPage::resetFocusedElementForFrame):
(WebKit::WebPage::elementDidFocus):
(WebKit::WebPage::elementDidBlur):
(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::didChangeOverflowScrollPosition): Deleted.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::setIsShowingInputViewForFocusedElement):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateSelectionAppearance):

Pass in `frame` to `didChangeSelection`.

(WebKit::WebPage::setIsShowingInputViewForFocusedElement): Deleted.

Move this back into the header, now that it's a straightforward setter again.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm
trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (290793 => 290794)

--- trunk/Source/WebKit/ChangeLog	2022-03-03 21:51:04 UTC (rev 290793)
+++ trunk/Source/WebKit/ChangeLog	2022-03-03 22:07:56 UTC (rev 290794)
@@ -1,3 +1,72 @@
+2022-03-03  Wenson Hsieh  
+
+[iOS] Further reduce hangs underneath -[WKContentView 

[webkit-changes] [290793] trunk/Tools

[jbedard]

Title: [290793] trunk/Tools








Revision 290793
Author jbed...@apple.com
Date 2022-03-03 13:51:04 -0800 (Thu, 03 Mar 2022)


Log Message
[git-webkit] Open pre-populated GitHub page for new tokens
https://bugs.webkit.org/show_bug.cgi?id=237436


Reviewed by Ryan Haddad.

GitHub gives us a way to pre-populate its token generation web page. We should
open this page with appropriate arguments during setup.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker.credentials): Make 'prompt' into a function, allowing us to open a url
and change the prompt based on the success of opening the url.
* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:
(credentials): Allow 'prompt' to be callable.

Canonical link: https://commits.webkit.org/248033@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitbugspy/setup.py
trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py
trunk/Tools/Scripts/libraries/webkitcorepy/setup.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py




Diff

Modified: trunk/Tools/ChangeLog (290792 => 290793)

--- trunk/Tools/ChangeLog	2022-03-03 21:19:46 UTC (rev 290792)
+++ trunk/Tools/ChangeLog	2022-03-03 21:51:04 UTC (rev 290793)
@@ -1,3 +1,24 @@
+2022-03-03  Jonathan Bedard  
+
+[git-webkit] Open pre-populated GitHub page for new tokens
+https://bugs.webkit.org/show_bug.cgi?id=237436
+
+
+Reviewed by Ryan Haddad.
+
+GitHub gives us a way to pre-populate its token generation web page. We should
+open this page with appropriate arguments during setup.
+
+* Scripts/libraries/webkitbugspy/setup.py: Bump version.
+* Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
+* Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
+(Tracker.credentials): Make 'prompt' into a function, allowing us to open a url
+and change the prompt based on the success of opening the url.
+* Scripts/libraries/webkitcorepy/setup.py: Bump version.
+* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
+* Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:
+(credentials): Allow 'prompt' to be callable.
+
 2022-03-03  Lauro Moura  
 
 [build.webkit.org] Add GTK queue using clang


Modified: trunk/Tools/Scripts/libraries/webkitbugspy/setup.py (290792 => 290793)

--- trunk/Tools/Scripts/libraries/webkitbugspy/setup.py	2022-03-03 21:19:46 UTC (rev 290792)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/setup.py	2022-03-03 21:51:04 UTC (rev 290793)
@@ -30,7 +30,7 @@
 
 setup(
 name='webkitbugspy',
-version='0.3.3',
+version='0.3.4',
 description='Library containing a shared API for various bug trackers.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py (290792 => 290793)

--- trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py	2022-03-03 21:19:46 UTC (rev 290792)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py	2022-03-03 21:51:04 UTC (rev 290793)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(0, 3, 3)
+version = Version(0, 3, 4)
 
 from .user import User
 from .issue import Issue


Modified: trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py (290792 => 290793)

--- trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py	2022-03-03 21:19:46 UTC (rev 290792)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py	2022-03-03 21:51:04 UTC (rev 290793)
@@ -102,13 +102,21 @@
 return False
 
 hostname = self.url.split('/')[2]
+token_url = 'https://{}/settings/tokens/new'.format(hostname)
+
+def prompt():
+result = "GitHub's API\nProvide {} username and access token to create and update pull requests".format(hostname)
+if webkitcorepy.Terminal.open_url('{}?scopes=repo,workflow={}%20Local%20Automation'.format(token_url, self.name)):
+return result
+return '''{}
+Please go to {token_url} and generate a new 'Personal access token' via 'Developer settings'
+with 'repo' and 'workflow' access and appropriate 'Expiration' for your {host} user'''.format(result, token_url=token_url, host=hostname)
+
 return webkitcorepy.credentials(
 url=""
 required=required,
 name=self.url.split('/')[2].replace('.', 

[webkit-changes] [290792] trunk/Tools

[lmoura]

Title: [290792] trunk/Tools








Revision 290792
Author lmo...@igalia.com
Date 2022-03-03 13:19:46 -0800 (Thu, 03 Mar 2022)


Log Message
[build.webkit.org] Add GTK queue using clang
https://bugs.webkit.org/show_bug.cgi?id=229637

Reviewed by Michael Catanzaro.

This commit adds a specific queue to build with clang in place of GCC.
It will help cover both toolchains and catch bugs and warnings
that happen to be raised by/to affect only clang.

Initially, it'll be a build-only queue, moving to a complete build and
tester in the future. It'll use clang-12, the version available in the
current SDK used by GTK and WPE.

* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):

Modified Paths

trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/build-webkit-org/config.json (290791 => 290792)

--- trunk/Tools/CISupport/build-webkit-org/config.json	2022-03-03 21:02:09 UTC (rev 290791)
+++ trunk/Tools/CISupport/build-webkit-org/config.json	2022-03-03 21:19:46 UTC (rev 290792)
@@ -113,6 +113,7 @@
 { "name": "gtk-linux-bot-17", "platform": "gtk" },
 { "name": "gtk-linux-bot-18", "platform": "gtk" },
 { "name": "gtk-linux-bot-19", "platform": "gtk" },
+{ "name": "gtk-linux-bot-20", "platform": "gtk" },
 
 { "name": "jsconly-linux-igalia-bot-1", "platform": "jsc-only" },
 { "name": "jsconly-linux-igalia-bot-2", "platform": "jsc-only" },
@@ -484,6 +485,11 @@
   "workernames": ["gtk-linux-bot-19"]
 },
 {
+  "name": "GTK-Linux-64-bit-Release-Clang", "factory": "BuildFactory", "builddir": "gtk-linux-64-release-clang",
+  "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+  "workernames": ["gtk-linux-bot-20"]
+},
+{
   "name": "WinCairo-64-bit-WKL-Release-Build", "factory": "BuildFactory", "builddir": "wincairo-wkl-release",
   "platform": "wincairo", "configuration": "release", "architectures": ["x86_64"],
   "triggers": ["wincairo-wkl-release-tests", "wincairo-jsc-release-tests"],
@@ -605,6 +611,7 @@
 
 "schedulers": [ { "type": "AnyBranchScheduler", "name": "trunk", "change_filter": "trunk_filter", "treeStableTimer": 45.0,
   "builderNames": ["GTK-Linux-64-bit-Release-Build", "GTK-Linux-64-bit-Debug-Build",
+   "GTK-Linux-64-bit-Release-Clang",
"GTK-Linux-64-bit-Release-Debian-Stable-Build",
"GTK-Linux-64-bit-Release-Ubuntu-LTS-Build",
"WPE-Linux-64-bit-Release-Ubuntu-LTS-Build",


Modified: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (290791 => 290792)

--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py	2022-03-03 21:02:09 UTC (rev 290791)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py	2022-03-03 21:19:46 UTC (rev 290792)
@@ -978,6 +978,17 @@
 'transfer-to-s3',
 'trigger'
 ],
+'GTK-Linux-64-bit-Release-Clang': [
+'configure-build',
+'configuration',
+'clean-and-update-working-directory',
+'show-identifier',
+'kill-old-processes',
+'delete-WebKitBuild-directory',
+'delete-stale-build-files',
+'jhbuild',
+'compile-webkit'
+],
 'GTK-Linux-64-bit-Release-Tests': [
 'configure-build',
 'configuration',


Modified: trunk/Tools/ChangeLog (290791 => 290792)

--- trunk/Tools/ChangeLog	2022-03-03 21:02:09 UTC (rev 290791)
+++ trunk/Tools/ChangeLog	2022-03-03 21:19:46 UTC (rev 290792)
@@ -1,3 +1,22 @@
+2022-03-03  Lauro Moura  
+
+[build.webkit.org] Add GTK queue using clang
+https://bugs.webkit.org/show_bug.cgi?id=229637
+
+Reviewed by Michael Catanzaro.
+
+This commit adds a specific queue to build with clang in place of GCC.
+It will help cover both toolchains and catch bugs and warnings
+that happen to be raised by/to affect only clang.
+
+Initially, it'll be a build-only queue, moving to a complete build and
+tester in the future. It'll use clang-12, the version available in the
+current SDK used by GTK and WPE.
+
+* CISupport/build-webkit-org/config.json:
+* CISupport/build-webkit-org/factories_unittest.py:
+(TestExpectedBuildSteps):
+
 2022-03-03  Myles C. Maxfield  
 
 [Style] Forbid spaces between type names and protocol names in Objective-C

[webkit-changes] [290791] trunk/Source/WebGPU

[mmaxfield]

Title: [290791] trunk/Source/WebGPU








Revision 290791
Author mmaxfi...@apple.com
Date 2022-03-03 13:02:09 -0800 (Thu, 03 Mar 2022)


Log Message
[WebGPU] Abide by the WebKit Style Guide
https://bugs.webkit.org/show_bug.cgi?id=237437

Reviewed by Darin Adler.

The style guide says "Do not place a space between the type name and the protocol name."

* WebGPU/Adapter.h:
(WebGPU::Adapter::create):
* WebGPU/Adapter.mm:
(WebGPU::Adapter::Adapter):
(WebGPU::deviceMeetsRequiredLimits):
* WebGPU/BindGroup.h:
(WebGPU::BindGroup::create):
(WebGPU::BindGroup::vertexArgumentBuffer const):
(WebGPU::BindGroup::fragmentArgumentBuffer const):
(WebGPU::BindGroup::computeArgumentBuffer const):
* WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
(WebGPU::BindGroup::BindGroup):
* WebGPU/BindGroupLayout.h:
(WebGPU::BindGroupLayout::create):
(WebGPU::BindGroupLayout::vertexArgumentEncoder const):
(WebGPU::BindGroupLayout::fragmentArgumentEncoder const):
(WebGPU::BindGroupLayout::computeArgumentEncoder const):
* WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::BindGroupLayout):
* WebGPU/Buffer.h:
(WebGPU::Buffer::create):
(WebGPU::Buffer::buffer const):
* WebGPU/Buffer.mm:
(WebGPU::Buffer::Buffer):
* WebGPU/CommandBuffer.h:
(WebGPU::CommandBuffer::create):
(WebGPU::CommandBuffer::commandBuffer const):
* WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::CommandBuffer):
* WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::create):
* WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::CommandEncoder):
* WebGPU/ComputePassEncoder.h:
(WebGPU::ComputePassEncoder::create):
* WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::ComputePassEncoder):
* WebGPU/ComputePipeline.h:
(WebGPU::ComputePipeline::create):
(WebGPU::ComputePipeline::computePipelineState const):
* WebGPU/ComputePipeline.mm:
(WebGPU::createLibrary):
(WebGPU::createFunction):
(WebGPU::createComputePipelineState):
(WebGPU::ComputePipeline::ComputePipeline):
* WebGPU/Device.h:
* WebGPU/Device.mm:
(WebGPU::Device::create):
(WebGPU::Device::Device):
* WebGPU/Instance.mm:
(WebGPU::sortedDevices):
(WebGPU::Instance::requestAdapter):
* WebGPU/QuerySet.h:
(WebGPU::QuerySet::create):
(WebGPU::QuerySet::counterSampleBuffer const):
* WebGPU/QuerySet.mm:
(WebGPU::QuerySet::QuerySet):
* WebGPU/Queue.h:
(WebGPU::Queue::create):
* WebGPU/Queue.mm:
(WebGPU::Queue::Queue):
* WebGPU/RenderBundle.h:
(WebGPU::RenderBundle::create):
(WebGPU::RenderBundle::indirectCommandBuffer const):
* WebGPU/RenderBundle.mm:
(WebGPU::RenderBundle::RenderBundle):
* WebGPU/RenderBundleEncoder.h:
(WebGPU::RenderBundleEncoder::create):
* WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::RenderBundleEncoder):
* WebGPU/RenderPassEncoder.h:
(WebGPU::RenderPassEncoder::create):
* WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
* WebGPU/RenderPipeline.h:
(WebGPU::RenderPipeline::create):
(WebGPU::RenderPipeline::renderPipelineState const):
* WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::RenderPipeline):
* WebGPU/Sampler.h:
(WebGPU::Sampler::create):
(WebGPU::Sampler::samplerState const):
* WebGPU/Sampler.mm:
(WebGPU::Sampler::Sampler):
* WebGPU/ShaderModule.h:
(WebGPU::ShaderModule::create):
(WebGPU::ShaderModule::library const):
* WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::createLibrary):
(WebGPU::earlyCompileShaderModule):
(WebGPU::ShaderModule::ShaderModule):
* WebGPU/Texture.h:
(WebGPU::Texture::create):
(WebGPU::Texture::texture const):
* WebGPU/Texture.mm:
(WebGPU::Texture::Texture):
* WebGPU/TextureView.h:
(WebGPU::TextureView::create):
(WebGPU::TextureView::texture const):
* WebGPU/TextureView.mm:
(WebGPU::TextureView::TextureView):

Modified Paths

trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/Adapter.h
trunk/Source/WebGPU/WebGPU/Adapter.mm
trunk/Source/WebGPU/WebGPU/BindGroup.h
trunk/Source/WebGPU/WebGPU/BindGroup.mm
trunk/Source/WebGPU/WebGPU/BindGroupLayout.h
trunk/Source/WebGPU/WebGPU/BindGroupLayout.mm
trunk/Source/WebGPU/WebGPU/Buffer.h
trunk/Source/WebGPU/WebGPU/Buffer.mm
trunk/Source/WebGPU/WebGPU/CommandBuffer.h
trunk/Source/WebGPU/WebGPU/CommandBuffer.mm
trunk/Source/WebGPU/WebGPU/CommandEncoder.h
trunk/Source/WebGPU/WebGPU/CommandEncoder.mm
trunk/Source/WebGPU/WebGPU/ComputePassEncoder.h
trunk/Source/WebGPU/WebGPU/ComputePassEncoder.mm
trunk/Source/WebGPU/WebGPU/ComputePipeline.h
trunk/Source/WebGPU/WebGPU/ComputePipeline.mm
trunk/Source/WebGPU/WebGPU/Device.h
trunk/Source/WebGPU/WebGPU/Device.mm
trunk/Source/WebGPU/WebGPU/Instance.mm
trunk/Source/WebGPU/WebGPU/QuerySet.h
trunk/Source/WebGPU/WebGPU/QuerySet.mm
trunk/Source/WebGPU/WebGPU/Queue.h
trunk/Source/WebGPU/WebGPU/Queue.mm
trunk/Source/WebGPU/WebGPU/RenderBundle.h
trunk/Source/WebGPU/WebGPU/RenderBundle.mm
trunk/Source/WebGPU/WebGPU/RenderBundleEncoder.h
trunk/Source/WebGPU/WebGPU/RenderBundleEncoder.mm
trunk/Source/WebGPU/WebGPU/RenderPassEncoder.h
trunk/Source/WebGPU/WebGPU/RenderPassEncoder.mm

[webkit-changes] [290790] branches/safari-613-branch/Source

[repstein]

Title: [290790] branches/safari-613-branch/Source








Revision 290790
Author repst...@apple.com
Date 2022-03-03 12:22:24 -0800 (Thu, 03 Mar 2022)


Log Message
Versioning.

WebKit-7613.2.1

Modified Paths

branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig (290789 => 290790)

--- branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-03-03 20:21:03 UTC (rev 290789)
+++ branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-03-03 20:22:24 UTC (rev 290790)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 1;
-TINY_VERSION = 17;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (290789 => 290790)

--- branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-03-03 20:21:03 UTC (rev 290789)
+++ branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-03-03 20:22:24 UTC (rev 290790)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 1;
-TINY_VERSION = 17;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (290789 => 290790)

--- branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-03-03 20:21:03 UTC (rev 290789)
+++ branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-03-03 20:22:24 UTC (rev 290790)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 1;
-TINY_VERSION = 17;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig (290789 => 290790)

--- branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig	2022-03-03 20:21:03 UTC (rev 290789)
+++ branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig	2022-03-03 20:22:24 UTC (rev 290790)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 1;
-TINY_VERSION = 17;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (290789 => 290790)

--- branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-03-03 20:21:03 UTC (rev 290789)
+++ branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-03-03 20:22:24 UTC (rev 290790)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 1;
-TINY_VERSION = 17;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig (290789 => 290790)

--- branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-03-03 20:21:03 UTC (rev 290789)
+++ branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-03-03 20:22:24 UTC (rev 290790)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 MAJOR_VERSION = 613;
-MINOR_VERSION = 1;
-TINY_VERSION = 17;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (290789 => 290790)

--- 

[webkit-changes] [290789] branches/safari-613-branch/Source/JavaScriptCore

[repstein]

Title: [290789] branches/safari-613-branch/Source/_javascript_Core








Revision 290789
Author repst...@apple.com
Date 2022-03-03 12:21:03 -0800 (Thu, 03 Mar 2022)


Log Message
Cherry-pick r288363. rdar://problem/88995092

Fix build when using Visual Studio 2022
https://bugs.webkit.org/show_bug.cgi?id=235440

Reviewed by Antti Koivisto.

It doesn't like having a switch with a default but no cases.
This is cleaner with if statements anyways.
Also make members const because I can.

* jit/JITCode.cpp:
(JSC::JITCode::calleeSaveRegisters const):
* jit/JITCode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/Source/_javascript_Core/ChangeLog
branches/safari-613-branch/Source/_javascript_Core/jit/JITCode.cpp
branches/safari-613-branch/Source/_javascript_Core/jit/JITCode.h




Diff

Modified: branches/safari-613-branch/Source/_javascript_Core/ChangeLog (290788 => 290789)

--- branches/safari-613-branch/Source/_javascript_Core/ChangeLog	2022-03-03 19:51:30 UTC (rev 290788)
+++ branches/safari-613-branch/Source/_javascript_Core/ChangeLog	2022-03-03 20:21:03 UTC (rev 290789)
@@ -1,3 +1,39 @@
+2022-03-03  Russell Epstein  
+
+Cherry-pick r288363. rdar://problem/88995092
+
+Fix build when using Visual Studio 2022
+https://bugs.webkit.org/show_bug.cgi?id=235440
+
+Reviewed by Antti Koivisto.
+
+It doesn't like having a switch with a default but no cases.
+This is cleaner with if statements anyways.
+Also make members const because I can.
+
+* jit/JITCode.cpp:
+(JSC::JITCode::calleeSaveRegisters const):
+* jit/JITCode.h:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-01-21  Alex Christensen  
+
+Fix build when using Visual Studio 2022
+https://bugs.webkit.org/show_bug.cgi?id=235440
+
+Reviewed by Antti Koivisto.
+
+It doesn't like having a switch with a default but no cases.
+This is cleaner with if statements anyways.
+Also make members const because I can.
+
+* jit/JITCode.cpp:
+(JSC::JITCode::calleeSaveRegisters const):
+* jit/JITCode.h:
+
 2022-02-09  Alan Coon  
 
 Cherry-pick r289450. rdar://problem/88483574


Modified: branches/safari-613-branch/Source/_javascript_Core/jit/JITCode.cpp (290788 => 290789)

--- branches/safari-613-branch/Source/_javascript_Core/jit/JITCode.cpp	2022-03-03 19:51:30 UTC (rev 290788)
+++ branches/safari-613-branch/Source/_javascript_Core/jit/JITCode.cpp	2022-03-03 20:21:03 UTC (rev 290789)
@@ -99,22 +99,19 @@
 
 const RegisterAtOffsetList* JITCode::calleeSaveRegisters() const
 {
-switch (jitType()) {
 #if ENABLE(FTL_JIT)
-case JITType::FTLJIT:
+if (m_jitType == JITType::FTLJIT)
 return static_cast(this)->calleeSaveRegisters();
 #endif
 #if ENABLE(DFG_JIT)
-case JITType::DFGJIT:
+if (m_jitType == JITType::DFGJIT)
 return ::dfgCalleeSaveRegisters();
 #endif
-default:
 #if !ENABLE(C_LOOP)
-return ::llintBaselineCalleeSaveRegisters();
+return ::llintBaselineCalleeSaveRegisters();
 #else
-return nullptr;
+return nullptr;
 #endif
-}
 }
 
 JITCodeWithCodeRef::JITCodeWithCodeRef(JITType jitType)


Modified: branches/safari-613-branch/Source/_javascript_Core/jit/JITCode.h (290788 => 290789)

--- branches/safari-613-branch/Source/_javascript_Core/jit/JITCode.h	2022-03-03 19:51:30 UTC (rev 290788)
+++ branches/safari-613-branch/Source/_javascript_Core/jit/JITCode.h	2022-03-03 20:21:03 UTC (rev 290789)
@@ -232,8 +232,8 @@
 const RegisterAtOffsetList* calleeSaveRegisters() const;
 
 private:
-JITType m_jitType;
-ShareAttribute m_shareAttribute;
+const JITType m_jitType;
+const ShareAttribute m_shareAttribute;
 protected:
 Intrinsic m_intrinsic { NoIntrinsic }; // Effective only in NativeExecutable.
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290788] trunk/Source/JavaScriptCore

[sbarati]

Title: [290788] trunk/Source/_javascript_Core








Revision 290788
Author sbar...@apple.com
Date 2022-03-03 11:51:30 -0800 (Thu, 03 Mar 2022)


Log Message
Add a DeferTraps scope
https://bugs.webkit.org/show_bug.cgi?id=237306


Reviewed by Mark Lam.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::noticeIncomingCall):
* bytecode/CodeBlock.h:
* bytecode/RepatchInlines.h:
(JSC::linkFor):
(JSC::virtualForWithFunction):
* dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):
* interpreter/InterpreterInlines.h:
(JSC::Interpreter::execute):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
* runtime/ExceptionScope.h:
* runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::installCode):
* runtime/VMTraps.cpp:
(JSC::VMTraps::handleTraps):
(JSC::VMTraps::takeTopPriorityTrap):
* runtime/VMTraps.h:
(JSC::VMTraps::needHandling const):
(JSC::VMTraps::maybeNeedHandling const):
(JSC::VMTraps::hasTrapBit):
(JSC::VMTraps::setTrapBit):
* runtime/VMTrapsInlines.h:
(JSC::DeferTraps::DeferTraps):
(JSC::DeferTraps::~DeferTraps):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecode/RepatchInlines.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/interpreter/InterpreterInlines.h
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/ExceptionScope.h
trunk/Source/_javascript_Core/runtime/ScriptExecutable.cpp
trunk/Source/_javascript_Core/runtime/VMTraps.cpp
trunk/Source/_javascript_Core/runtime/VMTraps.h
trunk/Source/_javascript_Core/runtime/VMTrapsInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (290787 => 290788)

--- trunk/Source/_javascript_Core/ChangeLog	2022-03-03 19:04:10 UTC (rev 290787)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-03-03 19:51:30 UTC (rev 290788)
@@ -1,3 +1,46 @@
+2022-03-03  Saam Barati  
+
+Add a DeferTraps scope
+https://bugs.webkit.org/show_bug.cgi?id=237306
+
+
+Reviewed by Mark Lam.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock):
+(JSC::CodeBlock::jettison):
+(JSC::CodeBlock::noticeIncomingCall):
+* bytecode/CodeBlock.h:
+* bytecode/RepatchInlines.h:
+(JSC::linkFor):
+(JSC::virtualForWithFunction):
+* dfg/DFGOperations.cpp:
+(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::executeProgram):
+(JSC::Interpreter::executeCall):
+(JSC::Interpreter::executeConstruct):
+(JSC::Interpreter::execute):
+(JSC::Interpreter::executeModuleProgram):
+* interpreter/InterpreterInlines.h:
+(JSC::Interpreter::execute):
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::setUpCall):
+* runtime/ExceptionScope.h:
+* runtime/ScriptExecutable.cpp:
+(JSC::ScriptExecutable::installCode):
+* runtime/VMTraps.cpp:
+(JSC::VMTraps::handleTraps):
+(JSC::VMTraps::takeTopPriorityTrap):
+* runtime/VMTraps.h:
+(JSC::VMTraps::needHandling const):
+(JSC::VMTraps::maybeNeedHandling const):
+(JSC::VMTraps::hasTrapBit):
+(JSC::VMTraps::setTrapBit):
+* runtime/VMTrapsInlines.h:
+(JSC::DeferTraps::DeferTraps):
+(JSC::DeferTraps::~DeferTraps):
+
 2022-03-03  Adrian Perez de Castro  
 
 Non-unified build fixes, early March 2022 edition


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (290787 => 290788)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2022-03-03 19:04:10 UTC (rev 290787)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2022-03-03 19:51:30 UTC (rev 290788)
@@ -279,6 +279,7 @@
 , m_didFailJITCompilation(false)
 , m_didFailFTLCompilation(false)
 , m_hasBeenCompiledWithFTL(false)
+, m_isJettisoned(false)
 , m_numCalleeLocals(other.m_numCalleeLocals)
 , m_numVars(other.m_numVars)
 , m_numberOfArgumentsToSkip(other.m_numberOfArgumentsToSkip)
@@ -330,6 +331,7 @@
 , m_didFailJITCompilation(false)
 , m_didFailFTLCompilation(false)
 , m_hasBeenCompiledWithFTL(false)
+, m_isJettisoned(false)
 , m_numCalleeLocals(unlinkedCodeBlock->numCalleeLocals())
 , m_numVars(unlinkedCodeBlock->numVars())
 , m_hasDebuggerStatement(false)
@@ -2191,6 +2193,8 @@
 
 VM& vm = *m_vm;
 
+m_isJettisoned = true;
+
 CodeBlock* codeBlock = this; // Placate GCC for use in CODEBLOCK_LOG_EVENT  (does not like this).
 CODEBLOCK_LOG_EVENT(codeBlock, 

[webkit-changes] [290787] branches/safari-614.1.5-branch

[repstein]

Title: [290787] branches/safari-614.1.5-branch








Revision 290787
Author repst...@apple.com
Date 2022-03-03 11:04:10 -0800 (Thu, 03 Mar 2022)


Log Message
Cherry-pick r290512. rdar://problem/89765722

[Tables] Incorrect table sizing when colgroup comes after tbody
https://bugs.webkit.org/show_bug.cgi?id=237205


Reviewed by Antti Koivisto.

Source/WebCore:

Let's use the colgroup for table sizing even when it comes after any thead, tbody, tfoot, and tr elements.
This makes WebKit match other rendering engines (see https://src.chromium.org/viewvc/blink?revision=159442=revision)

Test: fast/table/table-sizing-fails-when-colgroup-comes-after-content.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::firstColumn const):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::nextColumn const):

LayoutTests:

* fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html: Added.
* fast/table/table-sizing-fails-when-colgroup-comes-after-content.html: Added.
* platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt: Progression.
* platform/mac/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt: Progression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-614.1.5-branch/LayoutTests/ChangeLog
branches/safari-614.1.5-branch/LayoutTests/platform/ios/tables/mozilla_expected_failures/dom/appendCol1-expected.txt
branches/safari-614.1.5-branch/LayoutTests/platform/ios/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt
branches/safari-614.1.5-branch/LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt
branches/safari-614.1.5-branch/LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt
branches/safari-614.1.5-branch/Source/WebCore/ChangeLog
branches/safari-614.1.5-branch/Source/WebCore/rendering/RenderTable.cpp
branches/safari-614.1.5-branch/Source/WebCore/rendering/RenderTableCol.cpp


Added Paths

branches/safari-614.1.5-branch/LayoutTests/fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html
branches/safari-614.1.5-branch/LayoutTests/fast/table/table-sizing-fails-when-colgroup-comes-after-content.html




Diff

Modified: branches/safari-614.1.5-branch/LayoutTests/ChangeLog (290786 => 290787)

--- branches/safari-614.1.5-branch/LayoutTests/ChangeLog	2022-03-03 19:00:32 UTC (rev 290786)
+++ branches/safari-614.1.5-branch/LayoutTests/ChangeLog	2022-03-03 19:04:10 UTC (rev 290787)
@@ -1,3 +1,48 @@
+2022-03-03  Russell Epstein  
+
+Cherry-pick r290512. rdar://problem/89765722
+
+[Tables] Incorrect table sizing when colgroup comes after tbody
+https://bugs.webkit.org/show_bug.cgi?id=237205
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+Let's use the colgroup for table sizing even when it comes after any thead, tbody, tfoot, and tr elements.
+This makes WebKit match other rendering engines (see https://src.chromium.org/viewvc/blink?revision=159442=revision)
+
+Test: fast/table/table-sizing-fails-when-colgroup-comes-after-content.html
+
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::firstColumn const):
+* rendering/RenderTableCol.cpp:
+(WebCore::RenderTableCol::nextColumn const):
+
+LayoutTests:
+
+* fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html: Added.
+* fast/table/table-sizing-fails-when-colgroup-comes-after-content.html: Added.
+* platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt: Progression.
+* platform/mac/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt: Progression.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-25  Alan Bujtas  
+
+[Tables] Incorrect table sizing when colgroup comes after tbody
+https://bugs.webkit.org/show_bug.cgi?id=237205
+
+
+Reviewed by Antti Koivisto.
+
+* fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html: Added.
+* fast/table/table-sizing-fails-when-colgroup-comes-after-content.html: Added.
+* platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt: Progression.
+* platform/mac/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt: Progression.
+
 2022-02-19  Jon Lee  
 
 Unreviewed gardening for GPU Process bots.


Added: branches/safari-614.1.5-branch/LayoutTests/fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html (0 => 290787)

--- branches/safari-614.1.5-branch/LayoutTests/fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html	(rev 0)
+++ 

[webkit-changes] [290786] branches/safari-614.1.5-branch/Source

[repstein]

Title: [290786] branches/safari-614.1.5-branch/Source








Revision 290786
Author repst...@apple.com
Date 2022-03-03 11:00:32 -0800 (Thu, 03 Mar 2022)


Log Message
Versioning.

WebKit-7614.1.5.6

Modified Paths

branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-614.1.5-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (290785 => 290786)

--- branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-03-03 18:25:57 UTC (rev 290785)
+++ branches/safari-614.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-03-03 19:00:32 UTC (rev 290786)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (290785 => 290786)

--- branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-03-03 18:25:57 UTC (rev 290785)
+++ branches/safari-614.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-03-03 19:00:32 UTC (rev 290786)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (290785 => 290786)

--- branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-03-03 18:25:57 UTC (rev 290785)
+++ branches/safari-614.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-03-03 19:00:32 UTC (rev 290786)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig (290785 => 290786)

--- branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2022-03-03 18:25:57 UTC (rev 290785)
+++ branches/safari-614.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2022-03-03 19:00:32 UTC (rev 290786)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (290785 => 290786)

--- branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-03-03 18:25:57 UTC (rev 290785)
+++ branches/safari-614.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-03-03 19:00:32 UTC (rev 290786)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig (290785 => 290786)

--- branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-03-03 18:25:57 UTC (rev 290785)
+++ branches/safari-614.1.5-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-03-03 19:00:32 UTC (rev 290786)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (290785 => 290786)

--- branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-03-03 18:25:57 UTC (rev 290785)
+++ branches/safari-614.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-03-03 19:00:32 UTC (rev 290786)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 614;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 

[webkit-changes] [290785] trunk

[simon . fraser]

Title: [290785] trunk








Revision 290785
Author simon.fra...@apple.com
Date 2022-03-03 10:25:57 -0800 (Thu, 03 Mar 2022)


Log Message
nasa.gov page with fixed backgrounds paints incorrectly on scroll
https://bugs.webkit.org/show_bug.cgi?id=237405


Reviewed by Antti Koivisto.
Source/WebCore:

https://www.nasa.gov/specials/artemis/ shows an issue where elements with background-attachment:fixed
don't repaint on scroll. This page has scrollable  and , and the elements with fixed
backgrounds are composited, so this reveals that we fail to repaint composited children
of an overflow scroll in this case.

Fix by having RenderLayerScrollableArea::scrollTo() do repaints on slow repaint objects
which are scrolled by the current scroller.

Do some unrelated cleanup in code that I was going to use in this patch but turned out
not to need: rename hasFixedBackgroundImage() to hasAnyFixedBackground() for clarity,
and share the implementation with hasAnyLocalBackground().

Test: fast/repaint/background-attachment-fixed-in-composited-scroll.html

* rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::willBeDestroyed):
* rendering/RenderLayer.cpp:
* rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::scrollTo):
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasImageWithAttachment const):
(WebCore::FillLayer::hasFixedImage const): Deleted.
* rendering/style/FillLayer.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::hasAnyLocalBackground const): Deleted.
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::hasBackgroundImage const):
(WebCore::RenderStyle::hasAnyFixedBackground const):
(WebCore::RenderStyle::hasAnyLocalBackground const):
(WebCore::RenderStyle::hasFixedBackgroundImage const): Deleted.

LayoutTests:

Repaint test which is only valid for mac-wk2 (iOS does not support background-attachment:fixed).

* TestExpectations:
* fast/repaint/background-attachment-fixed-in-composited-scroll-expected.txt: Added.
* fast/repaint/background-attachment-fixed-in-composited-scroll.html: Added.
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp
trunk/Source/WebCore/rendering/style/FillLayer.cpp
trunk/Source/WebCore/rendering/style/FillLayer.h
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h


Added Paths

trunk/LayoutTests/fast/repaint/background-attachment-fixed-in-composited-scroll-expected.txt
trunk/LayoutTests/fast/repaint/background-attachment-fixed-in-composited-scroll.html




Diff

Modified: trunk/LayoutTests/ChangeLog (290784 => 290785)

--- trunk/LayoutTests/ChangeLog	2022-03-03 18:20:43 UTC (rev 290784)
+++ trunk/LayoutTests/ChangeLog	2022-03-03 18:25:57 UTC (rev 290785)
@@ -1,3 +1,18 @@
+2022-03-03  Simon Fraser  
+
+nasa.gov page with fixed backgrounds paints incorrectly on scroll
+https://bugs.webkit.org/show_bug.cgi?id=237405
+
+
+Reviewed by Antti Koivisto.
+
+Repaint test which is only valid for mac-wk2 (iOS does not support background-attachment:fixed).
+
+* TestExpectations:
+* fast/repaint/background-attachment-fixed-in-composited-scroll-expected.txt: Added.
+* fast/repaint/background-attachment-fixed-in-composited-scroll.html: Added.
+* platform/mac-wk2/TestExpectations:
+
 2022-03-03  Jon Lee  
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/TestExpectations (290784 => 290785)

--- trunk/LayoutTests/TestExpectations	2022-03-03 18:20:43 UTC (rev 290784)
+++ trunk/LayoutTests/TestExpectations	2022-03-03 18:25:57 UTC (rev 290785)
@@ -92,6 +92,7 @@
 compositing/scrolling/async-overflow-scrolling [ Skip ]
 compositing/layer-creation/clipping-scope [ Skip ]
 fast/repaint/background-attachment-local-scroll.html [ Skip ]
+fast/repaint/background-attachment-fixed-in-composited-scroll.html [ Skip ]
 
 # WebKit2 only.
 printing/printing-events.html [ Skip ]


Added: trunk/LayoutTests/fast/repaint/background-attachment-fixed-in-composited-scroll-expected.txt (0 => 290785)

--- trunk/LayoutTests/fast/repaint/background-attachment-fixed-in-composited-scroll-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/repaint/background-attachment-fixed-in-composited-scroll-expected.txt	2022-03-03 18:25:57 UTC (rev 290785)
@@ -0,0 +1,11 @@
+Test that a scroll of an overflow scrolling element, with a composoited `background-attachment:fixed` child, repaints
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS layerTreeAsText.indexOf('(rect 0.00 0.00 280.00 200.00)') > -1 is true
+PASS layerTreeAsText.indexOf('(rect 11.00 11.00 

[webkit-changes] [290784] trunk

[mmaxfield]

Title: [290784] trunk








Revision 290784
Author mmaxfi...@apple.com
Date 2022-03-03 10:20:43 -0800 (Thu, 03 Mar 2022)


Log Message
[Style] Forbid spaces between type names and protocol names in Objective-C
https://bugs.webkit.org/show_bug.cgi?id=237406

Reviewed by Darin Adler.

According to https://lists.webkit.org/pipermail/webkit-dev/2022-February/032130.html.

Tools:

Because the style checker uses regexes, we don't know what's a type name and what's
a protocol name, so the checker simplifies the problem and just checks for "id <".

* Scripts/webkitpy/style/checkers/cpp.py:
(check_objc_protocol):
(check_style):

Websites/webkit.org:

* code-style.md:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/code-style.md




Diff

Modified: trunk/Tools/ChangeLog (290783 => 290784)

--- trunk/Tools/ChangeLog	2022-03-03 18:01:07 UTC (rev 290783)
+++ trunk/Tools/ChangeLog	2022-03-03 18:20:43 UTC (rev 290784)
@@ -1,3 +1,19 @@
+2022-03-03  Myles C. Maxfield  
+
+[Style] Forbid spaces between type names and protocol names in Objective-C
+https://bugs.webkit.org/show_bug.cgi?id=237406
+
+Reviewed by Darin Adler.
+
+According to https://lists.webkit.org/pipermail/webkit-dev/2022-February/032130.html.
+
+Because the style checker uses regexes, we don't know what's a type name and what's
+a protocol name, so the checker simplifies the problem and just checks for "id <".
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_objc_protocol):
+(check_style):
+
 2022-03-03  Jonathan Bedard  
 
 [Python-3] Invoke webkit-patch with Python 3 by default (Follow-up fix)


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (290783 => 290784)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2022-03-03 18:01:07 UTC (rev 290783)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2022-03-03 18:20:43 UTC (rev 290784)
@@ -2,7 +2,7 @@
 #
 # Copyright (C) 2009, 2010, 2012 Google Inc. All rights reserved.
 # Copyright (C) 2009 Torch Mobile Inc.
-# Copyright (C) 2009-2021 Apple Inc. All rights reserved.
+# Copyright (C) 2009-2022 Apple Inc. All rights reserved.
 # Copyright (C) 2010 Chris Jerdonek (cjerdo...@webkit.org)
 #
 # Redistribution and use in source and binary forms, with or without
@@ -3399,6 +3399,31 @@
 check_version_string(wk_api_available.group(1), "ios")
 
 
+def check_objc_protocol(clean_lines, line_number, file_extension, error):
+"""Looks for spaces between type names and protocol names.
+
+Because the style checker uses regexes, we don't know what's a type and what's a protocol.
+So, this check is a simplification and just checks for "id <"
+
+Args:
+  clean_lines: A CleansedLines instance containing the file.
+  line_number: The number of the line to check.
+  file_extension: The extension (without the dot) of the filename.
+  error: The function to call with any errors found.
+"""
+
+if file_extension != "m" and file_extension != "mm":
+return
+
+line = clean_lines.elided[line_number]  # Get rid of comments and strings.
+
+using_space_with_protocol = search(r'\bid <', line)
+if not using_space_with_protocol:
+return
+
+error(line_number, 'spacing/objc-protocol', 2, "Protocol names shouldn't have a space before them.")
+
+
 def check_style(clean_lines, line_number, file_extension, class_state, file_state, enum_state, error):
 """Checks rules from the 'C++ style rules' section of cppguide.html.
 
@@ -3480,6 +3505,7 @@
 check_enum_casing(clean_lines, line_number, enum_state, error)
 check_once_flag(clean_lines, line_number, file_state, error)
 check_arguments_for_wk_api_available(clean_lines, line_number, error)
+check_objc_protocol(clean_lines, line_number, file_extension, error)
 
 
 _RE_PATTERN_INCLUDE_NEW_STYLE = re.compile(r'#(?:include|import) +"[^/]+\.h"')


Modified: trunk/Websites/webkit.org/ChangeLog (290783 => 290784)

--- trunk/Websites/webkit.org/ChangeLog	2022-03-03 18:01:07 UTC (rev 290783)
+++ trunk/Websites/webkit.org/ChangeLog	2022-03-03 18:20:43 UTC (rev 290784)
@@ -1,3 +1,14 @@
+2022-03-03  Myles C. Maxfield  
+
+[Style] Forbid spaces between type names and protocol names in Objective-C
+https://bugs.webkit.org/show_bug.cgi?id=237406
+
+Reviewed by Darin Adler.
+
+According to https://lists.webkit.org/pipermail/webkit-dev/2022-February/032130.html.
+
+* code-style.md:
+
 2022-02-15  Jon Davis  
 
 Fix WordPress wpautop to account for the Dialog element.


Modified: trunk/Websites/webkit.org/code-style.md (290783 => 290784)

--- trunk/Websites/webkit.org/code-style.md	2022-03-03 18:01:07 UTC (rev 290783)
+++ trunk/Websites/webkit.org/code-style.md	2022-03-03 18:20:43 UTC (rev 290784)
@@ -320,6 +320,20 @@
 
 ```
 
+[](#spacing-objc-protocol) In 

[webkit-changes] [290783] trunk/LayoutTests

[jonlee]

Title: [290783] trunk/LayoutTests








Revision 290783
Author jon...@apple.com
Date 2022-03-03 10:01:07 -0800 (Thu, 03 Mar 2022)


Log Message
Unreviewed test gardening.

* gpu-process/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290782 => 290783)

--- trunk/LayoutTests/ChangeLog	2022-03-03 17:56:37 UTC (rev 290782)
+++ trunk/LayoutTests/ChangeLog	2022-03-03 18:01:07 UTC (rev 290783)
@@ -1,3 +1,10 @@
+2022-03-03  Jon Lee  
+
+Unreviewed test gardening.
+
+* gpu-process/TestExpectations:
+* platform/ios/TestExpectations:
+
 2022-03-03  Alan Bujtas  
 
 A text node longer than 65,535 characters following another text node is invisible in a scrolling context


Modified: trunk/LayoutTests/gpu-process/TestExpectations (290782 => 290783)

--- trunk/LayoutTests/gpu-process/TestExpectations	2022-03-03 17:56:37 UTC (rev 290782)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2022-03-03 18:01:07 UTC (rev 290783)
@@ -2,6 +2,9 @@
 
 # Incorrect size
 webkit.org/b/236906 imported/w3c/web-platform-tests/css/css-contain/contain-size-breaks-001.html [ ImageOnlyFailure ]
+webkit.org/b/236906 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-and-white-space-003.html [ ImageOnlyFailure Pass ]
+webkit.org/b/236906 imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-006.html [ ImageOnlyFailure Pass ]
+webkit.org/b/236906 imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-with-overflow-wrap-004.html [ ImageOnlyFailure Pass ]
 
 # There is text in/near the box
 webkit.org/b/236907 fast/shadow-dom/nth-node-on-shadow-child-invalidation.html [ ImageOnlyFailure ]
@@ -208,7 +211,7 @@
 webkit.org/b/236919 imported/w3c/web-platform-tests/css/css-multicol/multicol-count-non-integer-001.xht [ ImageOnlyFailure ]
 webkit.org/b/236919 imported/w3c/web-platform-tests/css/css-multicol/multicol-count-non-integer-002.xht [ ImageOnlyFailure ]
 webkit.org/b/236919 imported/w3c/web-platform-tests/css/css-multicol/multicol-count-non-integer-003.xht [ ImageOnlyFailure ]
-webkit.org/b/236919 imported/w3c/web-platform-tests/css/css-multicol/multicol-fill-auto-002.xht [ ImageOnlyFailure ]
+webkit.org/b/236919 imported/w3c/web-platform-tests/css/css-multicol/multicol-fill-auto-002.xht [ ImageOnlyFailure Pass ]
 webkit.org/b/236919 imported/w3c/web-platform-tests/css/css-multicol/multicol-fill-auto-003.xht [ ImageOnlyFailure ]
 webkit.org/b/236919 imported/w3c/web-platform-tests/css/css-multicol/multicol-fill-auto-block-children-001.xht [ ImageOnlyFailure ]
 webkit.org/b/236919 imported/w3c/web-platform-tests/css/css-multicol/multicol-fill-balance-001.xht [ ImageOnlyFailure ]
@@ -253,11 +256,20 @@
 webkit.org/b/236920 imported/w3c/web-platform-tests/css/css-shapes/shape-outside/shape-image/shape-image-017.html
 
 # Writing mode failures
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/block-flow-direction-vlr-007.xht [ ImageOnlyFailure Pass ]
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/block-flow-direction-vlr-015.xht [ ImageOnlyFailure Pass ]
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/block-flow-direction-vrl-005.xht [ ImageOnlyFailure Pass ]
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/block-flow-direction-vrl-006.xht [ ImageOnlyFailure Pass ]
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/block-flow-direction-vrl-011.xht [ ImageOnlyFailure Pass ]
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/block-flow-direction-vrl-024.xht [ ImageOnlyFailure Pass ]
 webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/central-baseline-alignment-002.xht [ ImageOnlyFailure ]
 webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/inline-block-alignment-004.xht [ ImageOnlyFailure ]
 webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/inline-block-alignment-orthogonal-vlr-005.xht [ ImageOnlyFailure ]
 webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/inline-block-alignment-orthogonal-vrl-004.xht [ ImageOnlyFailure ]
 webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/inline-table-alignment-004.xht [ ImageOnlyFailure ]
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/row-progression-vrl-004.xht [ ImageOnlyFailure Pass ]
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/row-progression-vrl-006.xht [ ImageOnlyFailure Pass ]
+webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/table-column-order-005.xht [ ImageOnlyFailure Pass ]
 webkit.org/b/236921 imported/w3c/web-platform-tests/css/css-writing-modes/text-baseline-vlr-005.xht [ 

[webkit-changes] [290782] trunk

[zalan]

Title: [290782] trunk








Revision 290782
Author za...@apple.com
Date 2022-03-03 09:56:37 -0800 (Thu, 03 Mar 2022)


Log Message
A text node longer than 65,535 characters following another text node is invisible in a scrolling context
https://bugs.webkit.org/show_bug.cgi?id=237330


Reviewed by Antti Koivisto.

Source/WebCore:

1. We split text content at 65536 characters (see Text::createWithLengthLimit)
2. InlineTextBox can only hold up to 65534 (max short unsigned) characters (unsigned short m_len { 0 };)

Arithmetic overflow produces 0 length inline text boxes and they get removed at
LegacyLineLayout::computeBlockDirectionPositionsForLine as redundant boxes.

Test: fast/text/text-overflow-over-64k.html

* rendering/LegacyInlineTextBox.h: Let's just use unsigned. At this point we don't have that many
legacy inline text boxes anyway.

LayoutTests:

* fast/text/text-overflow-over-64k-expected.html: Added.
* fast/text/text-overflow-over-64k.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/LegacyInlineTextBox.h


Added Paths

trunk/LayoutTests/fast/text/text-overflow-over-64k-expected.html
trunk/LayoutTests/fast/text/text-overflow-over-64k.html




Diff

Modified: trunk/LayoutTests/ChangeLog (290781 => 290782)

--- trunk/LayoutTests/ChangeLog	2022-03-03 17:30:09 UTC (rev 290781)
+++ trunk/LayoutTests/ChangeLog	2022-03-03 17:56:37 UTC (rev 290782)
@@ -1,3 +1,14 @@
+2022-03-03  Alan Bujtas  
+
+A text node longer than 65,535 characters following another text node is invisible in a scrolling context
+https://bugs.webkit.org/show_bug.cgi?id=237330
+
+
+Reviewed by Antti Koivisto.
+
+* fast/text/text-overflow-over-64k-expected.html: Added.
+* fast/text/text-overflow-over-64k.html: Added.
+
 2022-03-03  Youenn Fablet  
 
 macOS Safari 15.2 Audio Echo Issue after camera pause/unpause


Added: trunk/LayoutTests/fast/text/text-overflow-over-64k-expected.html (0 => 290782)

--- trunk/LayoutTests/fast/text/text-overflow-over-64k-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/text-overflow-over-64k-expected.html	2022-03-03 17:56:37 UTC (rev 290782)
@@ -0,0 +1,10 @@
+
+div {
+  overflow: scroll;
+  width: 500px;
+  height: 500px;
+  border: solid;
+}
+
+0
 0
 

[webkit-changes] [290781] trunk/Source/WebKit

[ross . kirsling]

Title: [290781] trunk/Source/WebKit








Revision 290781
Author ross.kirsl...@sony.com
Date 2022-03-03 09:30:09 -0800 (Thu, 03 Mar 2022)


Log Message
REGRESSION(r290776): NetworkSession::swServer depends on ENABLE(SERVICE_WORKER)
https://bugs.webkit.org/show_bug.cgi?id=237432

Unreviewed build fix.


* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::terminateRemoteWorkerContextConnectionWhenPossible):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290780 => 290781)

--- trunk/Source/WebKit/ChangeLog	2022-03-03 17:25:38 UTC (rev 290780)
+++ trunk/Source/WebKit/ChangeLog	2022-03-03 17:30:09 UTC (rev 290781)
@@ -1,3 +1,13 @@
+2022-03-03  Ross Kirsling  
+
+REGRESSION(r290776): NetworkSession::swServer depends on ENABLE(SERVICE_WORKER)
+https://bugs.webkit.org/show_bug.cgi?id=237432
+
+Unreviewed build fix.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::terminateRemoteWorkerContextConnectionWhenPossible):
+
 2022-03-03  Chris Dumez  
 
 REGRESSION(r290356-r290351?): [ iOS EWS ] 3 imported/w3c/web-platform-tests/service-workers/service-worker/* tests are constant text failures.


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (290780 => 290781)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2022-03-03 17:25:38 UTC (rev 290780)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2022-03-03 17:30:09 UTC (rev 290781)
@@ -2087,8 +2087,10 @@
 
 switch (workerType) {
 case RemoteWorkerType::ServiceWorker:
+#if ENABLE(SERVICE_WORKER)
 if (auto* swServer = session->swServer())
 swServer->terminateContextConnectionWhenPossible(registrableDomain, processIdentifier);
+#endif
 break;
 case RemoteWorkerType::SharedWorker:
 if (auto* sharedWorkerServer = session->sharedWorkerServer())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290780] trunk/Source/WebCore

[commit-queue]

Title: [290780] trunk/Source/WebCore








Revision 290780
Author commit-qu...@webkit.org
Date 2022-03-03 09:25:38 -0800 (Thu, 03 Mar 2022)


Log Message
Update IDLParser to support trailing commas in enums.
https://bugs.webkit.org/show_bug.cgi?id=232607


Patch by Dan Glastonbury  on 2022-03-03
Reviewed by Sam Weinig.

Now compatible with the grammar specified by [1].

[1] https://webidl.spec.whatwg.org/#prod-EnumValueListComma

* bindings/scripts/IDLParser.pm:
(parseEnumValues):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convertEnumerationToString):
(WebCore::convertEnumerationToJS):
(WebCore::parseEnumeration):
(WebCore::expectedEnumerationValues):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (290779 => 290780)

--- trunk/Source/WebCore/ChangeLog	2022-03-03 17:24:15 UTC (rev 290779)
+++ trunk/Source/WebCore/ChangeLog	2022-03-03 17:25:38 UTC (rev 290780)
@@ -1,3 +1,25 @@
+2022-03-03  Dan Glastonbury  
+
+Update IDLParser to support trailing commas in enums.
+https://bugs.webkit.org/show_bug.cgi?id=232607
+
+
+Reviewed by Sam Weinig.
+
+Now compatible with the grammar specified by [1].
+
+[1] https://webidl.spec.whatwg.org/#prod-EnumValueListComma
+
+* bindings/scripts/IDLParser.pm:
+(parseEnumValues):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::convertEnumerationToString):
+(WebCore::convertEnumerationToJS):
+(WebCore::parseEnumeration):
+(WebCore::expectedEnumerationValues):
+* bindings/scripts/test/JS/JSTestObj.h:
+* bindings/scripts/test/TestObj.idl:
+
 2022-03-03  Antti Koivisto  
 
 Simplify pseudo element resolution


Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (290779 => 290780)

--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm	2022-03-03 17:24:15 UTC (rev 290779)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm	2022-03-03 17:25:38 UTC (rev 290780)
@@ -1507,6 +1507,9 @@
 my $next = $self->nextToken();
 if ($next->value() eq ",") {
 $self->assertTokenValue($self->getToken(), ",", __LINE__);
+}
+$next = $self->nextToken();
+if ($next->type() == StringToken) {
 my $enumValueToken = $self->getToken();
 $self->assertTokenType($enumValueToken, StringToken);
 my $enumValue = $self->unquoteString($enumValueToken->value());


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (290779 => 290780)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2022-03-03 17:24:15 UTC (rev 290779)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2022-03-03 17:25:38 UTC (rev 290780)
@@ -165,6 +165,38 @@
 return "\"\", \"enumValue1\", \"EnumValue2\", \"EnumValue3\"";
 }
 
+String convertEnumerationToString(TestObj::EnumTrailingComma enumerationValue)
+{
+static const NeverDestroyed values[] = {
+MAKE_STATIC_STRING_IMPL("enumValue1"),
+MAKE_STATIC_STRING_IMPL("enumValue2"),
+};
+static_assert(static_cast(TestObj::EnumTrailingComma::EnumValue1) == 0, "TestObj::EnumTrailingComma::EnumValue1 is not 0 as expected");
+static_assert(static_cast(TestObj::EnumTrailingComma::EnumValue2) == 1, "TestObj::EnumTrailingComma::EnumValue2 is not 1 as expected");
+ASSERT(static_cast(enumerationValue) < WTF_ARRAY_LENGTH(values));
+return values[static_cast(enumerationValue)];
+}
+
+template<> JSString* convertEnumerationToJS(JSGlobalObject& lexicalGlobalObject, TestObj::EnumTrailingComma enumerationValue)
+{
+return jsStringWithCache(lexicalGlobalObject.vm(), convertEnumerationToString(enumerationValue));
+}
+
+template<> std::optional parseEnumeration(JSGlobalObject& lexicalGlobalObject, JSValue value)
+{
+auto stringValue = value.toWTFString();
+if (stringValue == "enumValue1")
+return TestObj::EnumTrailingComma::EnumValue1;
+if (stringValue == "enumValue2")
+return TestObj::EnumTrailingComma::EnumValue2;
+return std::nullopt;
+}
+
+template<> const char* expectedEnumerationValues()
+{
+return "\"enumValue1\", \"enumValue2\"";
+}
+
 String convertEnumerationToString(TestObj::Optional enumerationValue)
 {
 static const NeverDestroyed values[] = {


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h (290779 => 290780)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2022-03-03 17:24:15 UTC (rev 290779)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2022-03-03 17:25:38 UTC (rev 290780)
@@ -121,6 +121,12 @@
 template<> std::optional parseEnumeration(JSC::JSGlobalObject&, JSC::JSValue);
 

[webkit-changes] [290779] trunk/Source/WebCore

[antti]

Title: [290779] trunk/Source/WebCore








Revision 290779
Author an...@apple.com
Date 2022-03-03 09:24:15 -0800 (Thu, 03 Mar 2022)


Log Message
Simplify pseudo element resolution
https://bugs.webkit.org/show_bug.cgi?id=237413

Reviewed by Antoine Quint.

Remove ElementUpdates struct with a map that contains pseudo element updates.
Instead use a single ElementUpdate struct and pass the pseudo element styles
as cached pseudo styles of the element RenderStyle. Previously RenderTreeUpdater
would move them there.

* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::Parent::Parent):
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::pushParent):
(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::RenderTreeUpdater::updateElementRenderer):
* rendering/updating/RenderTreeUpdater.h:
* rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::needsPseudoElement):
* rendering/updating/RenderTreeUpdaterGeneratedContent.h:
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::computeDescendantsToResolve):
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::shouldResolveElement):
(WebCore::Style::TreeResolver::resetDescendantStyleRelations):
(WebCore::Style::TreeResolver::resolveComposedTree):
(WebCore::Style::computeDescendantsToResolve): Deleted.
(WebCore::Style::shouldResolveElement): Deleted.
(WebCore::Style::resetDescendantStyleRelations): Deleted.
* style/StyleTreeResolver.h:
* style/StyleUpdate.cpp:
(WebCore::Style::Update::elementUpdate const):
(WebCore::Style::Update::elementUpdate):
(WebCore::Style::Update::elementStyle const):
(WebCore::Style::Update::elementStyle):
(WebCore::Style::Update::addElement):
(WebCore::Style::Update::elementUpdates const): Deleted.
(WebCore::Style::Update::elementUpdates): Deleted.
* style/StyleUpdate.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.h
trunk/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.h
trunk/Source/WebCore/style/StyleTreeResolver.cpp
trunk/Source/WebCore/style/StyleTreeResolver.h
trunk/Source/WebCore/style/StyleUpdate.cpp
trunk/Source/WebCore/style/StyleUpdate.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290778 => 290779)

--- trunk/Source/WebCore/ChangeLog	2022-03-03 16:57:49 UTC (rev 290778)
+++ trunk/Source/WebCore/ChangeLog	2022-03-03 17:24:15 UTC (rev 290779)
@@ -1,3 +1,48 @@
+2022-03-03  Antti Koivisto  
+
+Simplify pseudo element resolution
+https://bugs.webkit.org/show_bug.cgi?id=237413
+
+Reviewed by Antoine Quint.
+
+Remove ElementUpdates struct with a map that contains pseudo element updates.
+Instead use a single ElementUpdate struct and pass the pseudo element styles
+as cached pseudo styles of the element RenderStyle. Previously RenderTreeUpdater
+would move them there.
+
+* rendering/updating/RenderTreeUpdater.cpp:
+(WebCore::RenderTreeUpdater::Parent::Parent):
+(WebCore::RenderTreeUpdater::updateRenderTree):
+(WebCore::RenderTreeUpdater::pushParent):
+(WebCore::RenderTreeUpdater::popParent):
+(WebCore::RenderTreeUpdater::updateBeforeDescendants):
+(WebCore::RenderTreeUpdater::updateAfterDescendants):
+(WebCore::RenderTreeUpdater::updateElementRenderer):
+* rendering/updating/RenderTreeUpdater.h:
+* rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
+(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
+(WebCore::RenderTreeUpdater::GeneratedContent::needsPseudoElement):
+* rendering/updating/RenderTreeUpdaterGeneratedContent.h:
+* style/StyleTreeResolver.cpp:
+(WebCore::Style::TreeResolver::computeDescendantsToResolve):
+(WebCore::Style::TreeResolver::resolveElement):
+(WebCore::Style::TreeResolver::shouldResolveElement):
+(WebCore::Style::TreeResolver::resetDescendantStyleRelations):
+(WebCore::Style::TreeResolver::resolveComposedTree):
+(WebCore::Style::computeDescendantsToResolve): Deleted.
+(WebCore::Style::shouldResolveElement): Deleted.
+(WebCore::Style::resetDescendantStyleRelations): Deleted.
+* style/StyleTreeResolver.h:
+* style/StyleUpdate.cpp:
+(WebCore::Style::Update::elementUpdate const):
+(WebCore::Style::Update::elementUpdate):
+(WebCore::Style::Update::elementStyle const):
+

[webkit-changes] [290778] trunk

[youenn]

Title: [290778] trunk








Revision 290778
Author you...@apple.com
Date 2022-03-03 08:57:49 -0800 (Thu, 03 Mar 2022)


Log Message
macOS Safari 15.2 Audio Echo Issue after camera pause/unpause
https://bugs.webkit.org/show_bug.cgi?id=235544


Reviewed by Eric Carlson.

Source/WebCore:

After https://commits.webkit.org/r275600, the muted state of MediaPlayer would be set to the page muted state
without taking into consideration HTMLMediaElement.muted.
Update the call site to use effectiveMuted instead.
Add internals API to write a corresponding layout test.

Test: fast/mediastream/mediastreamtrack-audiovideo-mutepage.html

* html/HTMLMediaElement.cpp:
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* fast/mediastream/mediastreamtrack-audiovideo-mutepage-expected.txt: Added.
* fast/mediastream/mediastreamtrack-audiovideo-mutepage.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Added Paths

trunk/LayoutTests/fast/mediastream/mediastreamtrack-audiovideo-mutepage-expected.txt
trunk/LayoutTests/fast/mediastream/mediastreamtrack-audiovideo-mutepage.html




Diff

Modified: trunk/LayoutTests/ChangeLog (290777 => 290778)

--- trunk/LayoutTests/ChangeLog	2022-03-03 16:53:59 UTC (rev 290777)
+++ trunk/LayoutTests/ChangeLog	2022-03-03 16:57:49 UTC (rev 290778)
@@ -1,3 +1,14 @@
+2022-03-03  Youenn Fablet  
+
+macOS Safari 15.2 Audio Echo Issue after camera pause/unpause
+https://bugs.webkit.org/show_bug.cgi?id=235544
+
+
+Reviewed by Eric Carlson.
+
+* fast/mediastream/mediastreamtrack-audiovideo-mutepage-expected.txt: Added.
+* fast/mediastream/mediastreamtrack-audiovideo-mutepage.html: Added.
+
 2022-03-03  Chris Dumez  
 
 REGRESSION(r290356-r290351?): [ iOS EWS ] 3 imported/w3c/web-platform-tests/service-workers/service-worker/* tests are constant text failures.


Added: trunk/LayoutTests/fast/mediastream/mediastreamtrack-audiovideo-mutepage-expected.txt (0 => 290778)

--- trunk/LayoutTests/fast/mediastream/mediastreamtrack-audiovideo-mutepage-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mediastream/mediastreamtrack-audiovideo-mutepage-expected.txt	2022-03-03 16:57:49 UTC (rev 290778)
@@ -0,0 +1,4 @@
+
+
+PASS Muting then unmuting a page should not change media element muted state if HTMLMediaElement.muted is true
+


Added: trunk/LayoutTests/fast/mediastream/mediastreamtrack-audiovideo-mutepage.html (0 => 290778)

--- trunk/LayoutTests/fast/mediastream/mediastreamtrack-audiovideo-mutepage.html	(rev 0)
+++ trunk/LayoutTests/fast/mediastream/mediastreamtrack-audiovideo-mutepage.html	2022-03-03 16:57:49 UTC (rev 290778)
@@ -0,0 +1,32 @@
+
+
+
+
+
+
+
+