date:20220423

[webkit-changes] [293302] trunk/Source/WebCore

2022-04-23 Thread cdumez

Title: [293302] trunk/Source/WebCore








Revision 293302
Author cdu...@apple.com
Date 2022-04-23 22:49:49 -0700 (Sat, 23 Apr 2022)


Log Message
Unreviewed build fix after r293301.

* bindings/js/JSDOMConvertStrings.h:
(WebCore::Converter>::convert):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMConvertStrings.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (293301 => 293302)

--- trunk/Source/WebCore/ChangeLog	2022-04-24 04:48:31 UTC (rev 293301)
+++ trunk/Source/WebCore/ChangeLog	2022-04-24 05:49:49 UTC (rev 293302)
@@ -1,3 +1,10 @@
+2022-04-23  Chris Dumez  
+
+Unreviewed build fix after r293301.
+
+* bindings/js/JSDOMConvertStrings.h:
+(WebCore::Converter>::convert):
+
 2022-04-23  Alan Bujtas  
 
 [Win] Unreviewed build fix.


Modified: trunk/Source/WebCore/bindings/js/JSDOMConvertStrings.h (293301 => 293302)

--- trunk/Source/WebCore/bindings/js/JSDOMConvertStrings.h	2022-04-24 04:48:31 UTC (rev 293301)
+++ trunk/Source/WebCore/bindings/js/JSDOMConvertStrings.h	2022-04-24 05:49:49 UTC (rev 293302)
@@ -187,7 +187,7 @@
 };
 
 template<> struct Converter> : DefaultConverter> {
-static String convert(JSC::JSGlobalObject& lexicalGlobalObject, JSC::JSValue value)
+static AtomString convert(JSC::JSGlobalObject& lexicalGlobalObject, JSC::JSValue value)
 {
 return valueToByteAtomString(lexicalGlobalObject, value);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293301] trunk/Source

2022-04-23 Thread cdumez

Title: [293301] trunk/Source








Revision 293301
Author cdu...@apple.com
Date 2022-04-23 21:48:31 -0700 (Sat, 23 Apr 2022)


Log Message
[IDL] Add support for [AtomString] with USVString & ByteString types
https://bugs.webkit.org/show_bug.cgi?id=239695

Reviewed by Cameron McCormack.

Add support for [AtomString] with USVString and ByteString types in our WebIDL
bindings. This is needed to mark the AtomString(const String&) constructor
explicit.

* Source/WTF/wtf/text/AtomString.cpp:
(WTF::replaceUnpairedSurrogatesWithReplacementCharacterInternal):
(WTF::replaceUnpairedSurrogatesWithReplacementCharacter):
* Source/WTF/wtf/text/AtomString.h:
* Source/WTF/wtf/text/WTFString.cpp:
(WTF::replaceUnpairedSurrogatesWithReplacementCharacter): Deleted.
* Source/WTF/wtf/text/WTFString.h:
* Source/WebCore/Modules/fetch/FetchResponse.h:
* Source/WebCore/Modules/fetch/FetchResponse.idl:
* Source/WebCore/bindings/js/JSDOMConvertStrings.cpp:
(WebCore::throwIfInvalidByteString):
(WebCore::identifierToByteString):
(WebCore::valueToByteString):
(WebCore::valueToByteAtomString):
(WebCore::valueToUSVAtomString):
(WebCore::stringToByteString): Deleted.
* Source/WebCore/bindings/js/JSDOMConvertStrings.h:
(WebCore::Converter>::convert):
(WebCore::Converter>::convert):
(WebCore::Converter>::convert):
(WebCore::JSConverter>::convert):
(WebCore::JSConverter>::convert):
(WebCore::JSConverter>::convert):
* Source/WebCore/html/HTMLAnchorElement.idl:
* Source/WebCore/html/HTMLAreaElement.idl:
* Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::httpStatusText const):
(WebCore::ResourceResponseBase::setHTTPStatusText):
* Source/WebCore/platform/network/ResourceResponseBase.h:

Canonical link: https://commits.webkit.org/249926@main

Modified Paths

trunk/Source/WTF/wtf/text/AtomString.cpp
trunk/Source/WTF/wtf/text/AtomString.h
trunk/Source/WTF/wtf/text/WTFString.cpp
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
trunk/Source/WebCore/Modules/fetch/FetchResponse.idl
trunk/Source/WebCore/bindings/js/JSDOMConvertStrings.cpp
trunk/Source/WebCore/bindings/js/JSDOMConvertStrings.h
trunk/Source/WebCore/html/HTMLAnchorElement.idl
trunk/Source/WebCore/html/HTMLAreaElement.idl
trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp
trunk/Source/WebCore/platform/network/ResourceResponseBase.h




Diff

Modified: trunk/Source/WTF/wtf/text/AtomString.cpp (293300 => 293301)

--- trunk/Source/WTF/wtf/text/AtomString.cpp	2022-04-24 03:54:39 UTC (rev 293300)
+++ trunk/Source/WTF/wtf/text/AtomString.cpp	2022-04-24 04:48:31 UTC (rev 293301)
@@ -27,6 +27,8 @@
 #include 
 
 #include 
+#include 
+#include 
 
 namespace WTF {
 
@@ -160,4 +162,35 @@
 });
 }
 
+static inline StringBuilder replaceUnpairedSurrogatesWithReplacementCharacterInternal(StringView view)
+{
+// Slow path: https://infra.spec.whatwg.org/#_javascript_-string-convert
+// Replaces unpaired surrogates with the replacement character.
+StringBuilder result;
+result.reserveCapacity(view.length());
+for (auto codePoint : view.codePoints()) {
+if (U_IS_SURROGATE(codePoint))
+result.append(replacementCharacter);
+else
+result.appendCharacter(codePoint);
+}
+return result;
+}
+
+AtomString replaceUnpairedSurrogatesWithReplacementCharacter(AtomString&& string)
+{
+// Fast path for the case where there are no unpaired surrogates.
+if (LIKELY(!hasUnpairedSurrogate(string)))
+return WTFMove(string);
+return replaceUnpairedSurrogatesWithReplacementCharacterInternal(string).toAtomString();
+}
+
+String replaceUnpairedSurrogatesWithReplacementCharacter(String&& string)
+{
+// Fast path for the case where there are no unpaired surrogates.
+if (LIKELY(!hasUnpairedSurrogate(string)))
+return WTFMove(string);
+return replaceUnpairedSurrogatesWithReplacementCharacterInternal(string).toString();
+}
+
 } // namespace WTF


Modified: trunk/Source/WTF/wtf/text/AtomString.h (293300 => 293301)

--- trunk/Source/WTF/wtf/text/AtomString.h	2022-04-24 03:54:39 UTC (rev 293300)
+++ trunk/Source/WTF/wtf/text/AtomString.h	2022-04-24 04:48:31 UTC (rev 293301)
@@ -208,6 +208,9 @@
 
 template bool equalLettersIgnoringASCIICase(const AtomString&, const char ()[length]);
 
+WTF_EXPORT_PRIVATE AtomString replaceUnpairedSurrogatesWithReplacementCharacter(AtomString&&);
+WTF_EXPORT_PRIVATE String replaceUnpairedSurrogatesWithReplacementCharacter(String&&);
+
 inline AtomString::AtomString()
 {
 }


Modified: trunk/Source/WTF/wtf/text/WTFString.cpp (293300 => 293301)

--- trunk/Source/WTF/wtf/text/WTFString.cpp	2022-04-24 03:54:39 UTC (rev 293300)
+++ trunk/Source/WTF/wtf/text/WTFString.cpp	2022-04-24 04:48:31 UTC (rev 293301)
@@ -665,26 +665,6 @@
 return nullString;
 }
 
-String

[webkit-changes] [293300] trunk/Source/WebCore

2022-04-23 Thread zalan

Title: [293300] trunk/Source/WebCore








Revision 293300
Author za...@apple.com
Date 2022-04-23 20:54:39 -0700 (Sat, 23 Apr 2022)


Log Message
[Win] Unreviewed build fix.

* Headers.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (293299 => 293300)

--- trunk/Source/WebCore/ChangeLog	2022-04-24 03:45:52 UTC (rev 293299)
+++ trunk/Source/WebCore/ChangeLog	2022-04-24 03:54:39 UTC (rev 293300)
@@ -1,3 +1,9 @@
+2022-04-23  Alan Bujtas  
+
+[Win] Unreviewed build fix.
+
+* Headers.cmake:
+
 2022-04-23  Wenson Hsieh  
 
 Remove the `PreferInlineTextSelectionInImages` internal feature flag


Modified: trunk/Source/WebCore/Headers.cmake (293299 => 293300)

--- trunk/Source/WebCore/Headers.cmake	2022-04-24 03:45:52 UTC (rev 293299)
+++ trunk/Source/WebCore/Headers.cmake	2022-04-24 03:54:39 UTC (rev 293300)
@@ -974,6 +974,8 @@
 layout/LayoutUnits.h
 layout/MarginTypes.h
 
+layout/formattingContexts/flex/FlexFormattingState.h
+
 layout/formattingContexts/inline/display/InlineDisplayBox.h
 layout/formattingContexts/inline/InlineRect.h
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293299] trunk/Source

2022-04-23 Thread wenson_hsieh

Title: [293299] trunk/Source








Revision 293299
Author wenson_hs...@apple.com
Date 2022-04-23 20:45:52 -0700 (Sat, 23 Apr 2022)


Log Message
Remove the `PreferInlineTextSelectionInImages` internal feature flag
https://bugs.webkit.org/show_bug.cgi?id=234849

Reviewed by Sam Weinig.

Source/WebCore:

See WebKit/ChangeLog for more details.

* en.lproj/Localizable.strings:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
* page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
* platform/ContextMenuItem.cpp:
(WebCore::isValidContextMenuAction):
* platform/ContextMenuItem.h:
* platform/LocalizedStrings.h:
* platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::contextMenuItemTagQuickLookImage): Deleted.
(WebCore::contextMenuItemTagQuickLookImageForTextSelection): Deleted.
(WebCore::contextMenuItemTagQuickLookImageForVisualSearch): Deleted.

Source/WebKit:

This patch reverts r279164, which introduced an internal feature to avoid Live Text analysis when hovering over
images, and instead added a new context menu item to reveal selectable text in the image by launching the
QuickLook panel in Live Text mode.

This alternate Live Text experience was originally devised as a way to mitigate the power and performance impact
of passively triggering Live Text analysis when hovering over images on pre-M1 devices, but this mitigation was
ultimately deemed unnecessary in macOS 12.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
* UIProcess/Cocoa/QuickLookPreviewActivity.h: Removed.
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::computeHasVisualSearchResults):
(WebKit::WebViewImpl::computeHasImageAnalysisResults): Deleted.
* UIProcess/PageClient.h:
(WebKit::PageClient::computeHasVisualSearchResults):
(WebKit::PageClient::computeHasImageAnalysisResults): Deleted.
* UIProcess/WebContextMenuProxy.h:
(WebKit::WebContextMenuProxy::quickLookPreviewActivity const): Deleted.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::computeHasVisualSearchResults):
(WebKit::WebPageProxy::computeHasImageAnalysisResults): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/PageClientImplMac.h:
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::computeHasVisualSearchResults):
(WebKit::PageClientImpl::computeHasImageAnalysisResults): Deleted.
* UIProcess/mac/WKQuickLookPreviewController.h:
* UIProcess/mac/WKQuickLookPreviewController.mm:
* UIProcess/mac/WebContextMenuProxyMac.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
(WebKit::WebContextMenuProxyMac::insertOrUpdateQuickLookImageItem): Deleted.
(WebKit::WebContextMenuProxyMac::updateQuickLookContextMenuItemTitle): Deleted.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::handleContextMenuLookUpImage):
(WebKit::WebPageProxy::handleContextMenuQuickLookImage): Deleted.
* WebKit.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

See WebKit/ChangeLog for more details.

* WebView/WebHTMLView.mm:
(toTag):

Source/WTF:

See WebKit/ChangeLog for more details.

* Scripts/Preferences/WebPreferencesInternal.yaml:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/en.lproj/Localizable.strings
trunk/Source/WebCore/page/ContextMenuController.cpp
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/platform/ContextMenuItem.cpp
trunk/Source/WebCore/platform/ContextMenuItem.h
trunk/Source/WebCore/platform/LocalizedStrings.h
trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/c/WKSharedAPICast.h
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKit/UIProcess/PageClient.h
trunk/Source/WebKit/UIProcess/WebContextMenuProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.h
trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm
trunk/Source/WebKit/UIProcess/mac/WKQuickLookPreviewController.h
trunk/Source/WebKit/UIProcess/mac/WKQuickLookPreviewController.mm
trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h
trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm


Removed Paths

trunk/Source/WebKit/UIProcess/Cocoa/QuickLookPreviewActivity.h




Diff

Modified: trunk/Source/WTF/ChangeLog (293298 => 293299)

--- trunk/Source/WTF/ChangeLog	2022-04-24 02:27:34 UTC

[webkit-changes] [293298] trunk/Source/WebCore

2022-04-23 Thread andresg_22

Title: [293298] trunk/Source/WebCore








Revision 293298
Author andresg...@apple.com
Date 2022-04-23 19:27:34 -0700 (Sat, 23 Apr 2022)


Log Message
Code cleanup in preparation for optimizing use of AccessibilityObject::elementsFromAttribute.
https://bugs.webkit.org/show_bug.cgi?id=239664


Reviewed by Chris Fleizach.

No new functionality.

AccessibilityObject::elementsFromAttribute now returns a vector as
opposed to taking an out parameter. This makes the code more concise
and possibly more efficient.
Removed this method from the AXCoreObject interface, since this method
should not be exposed to an AT client. The Inspector is an exception
that accesses AccessibilityObjects directly and not through the
AXCoreObject interface.
All these changes are entirely code cleanup and modernization, no change
in functionality.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
(WebCore::AccessibilityNodeObject::textUnderElement const):
(WebCore::AccessibilityNodeObject::descriptionForElements const):
(WebCore::AccessibilityNodeObject::ariaDescribedByAttribute const):
(WebCore::AccessibilityNodeObject::ariaLabeledByAttribute const):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements const): Renamed.
(WebCore::AccessibilityNodeObject::ariaLabeledByElements const): Deleted.
* accessibility/AccessibilityNodeObject.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaElementsFromAttribute const):
(WebCore::AccessibilityObject::elementsFromAttribute const):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityObjectInterface.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isTabItemSelected const):
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::elementsFromAttribute const): Deleted.
* accessibility/isolatedtree/AXIsolatedObject.h:
* inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::accessiblityObjectForNode):
(WebCore::InspectorAuditAccessibilityObject::getControlledNodes):
(WebCore::InspectorAuditAccessibilityObject::getFlowedNodes):
(WebCore::InspectorAuditAccessibilityObject::getMouseEventNode):
(WebCore::InspectorAuditAccessibilityObject::getOwnedNodes):
* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293297 => 293298)

--- trunk/Source/WebCore/ChangeLog	2022-04-23 23:03:32 UTC (rev 293297)
+++ trunk/Source/WebCore/ChangeLog	2022-04-24 02:27:34 UTC (rev 293298)
@@ -1,3 +1,51 @@
+2022-04-23  Andres Gonzalez  
+
+Code cleanup in preparation for optimizing use of AccessibilityObject::elementsFromAttribute.
+https://bugs.webkit.org/show_bug.cgi?id=239664
+
+
+Reviewed by Chris Fleizach.
+
+No new functionality.
+
+AccessibilityObject::elementsFromAttribute now returns a vector as
+opposed to taking an out parameter. This makes the code more concise
+and possibly more efficient.
+Removed this method from the AXCoreObject interface, since this method
+should not be exposed to an AT client. The Inspector is an exception
+that accesses AccessibilityObjects directly and not through the
+AXCoreObject interface.
+All these changes are entirely code cleanup and modernization, no change
+in functionality.
+
+* accessibility/AccessibilityNodeObject.cpp:
+(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
+(WebCore::AccessibilityNodeObject::textUnderElement const):
+(WebCore::AccessibilityNodeObject::descriptionForElements const):
+(WebCore::AccessibilityNodeObject::ariaDescribedByAttribute const):
+(WebCore::AccessibilityNodeObject::ariaLabeledByAttribute const):
+(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements const): Renamed.
+(WebCore::AccessibilityNodeObject::ariaLabeledByElements const): Deleted.
+* accessibility/AccessibilityNodeObject.h:
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::ariaElementsFromAttribute const):
+(WebCore::AccessibilityObject::elementsFromAttribute const):
+

[webkit-changes] [293297] trunk/Source/WebCore

2022-04-23 Thread zalan

Title: [293297] trunk/Source/WebCore








Revision 293297
Author za...@apple.com
Date 2022-04-23 16:03:32 -0700 (Sat, 23 Apr 2022)


Log Message
[FFC][Integration] Add integration API to FlexFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=239692

Reviewed by Antti Koivisto.

The integration codepath needs dedicated (and temporary)APIs on the formatting contexts.
(This is exactly how inline layout has been integrated.)

* layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntergration):
(WebCore::Layout::FlexFormattingContext::computedIntrinsicWidthConstraintsForIntegration):
* layout/formattingContexts/flex/FlexFormattingContext.h:
* layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntergration):
(WebCore::Layout::InlineFormattingContext::lineLayoutForIntergration): Deleted.
* layout/formattingContexts/inline/InlineFormattingContext.h:
* layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
(WebCore::LayoutIntegration::FlexLayout::computeIntrinsicWidthConstraints):
(WebCore::LayoutIntegration::FlexLayout::layout):
* layout/integration/flex/LayoutIntegrationFlexLayout.h:
(WebCore::LayoutIntegration::FlexLayout::rootLayoutBox const):
(WebCore::LayoutIntegration::FlexLayout::rootLayoutBox):
* layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
trunk/Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
trunk/Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h
trunk/Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293296 => 293297)

--- trunk/Source/WebCore/ChangeLog	2022-04-23 22:26:57 UTC (rev 293296)
+++ trunk/Source/WebCore/ChangeLog	2022-04-23 23:03:32 UTC (rev 293297)
@@ -1,3 +1,31 @@
+2022-04-23  Alan Bujtas  
+
+[FFC][Integration] Add integration API to FlexFormattingContext
+https://bugs.webkit.org/show_bug.cgi?id=239692
+
+Reviewed by Antti Koivisto.
+
+The integration codepath needs dedicated (and temporary)APIs on the formatting contexts.
+(This is exactly how inline layout has been integrated.)
+
+* layout/formattingContexts/flex/FlexFormattingContext.cpp:
+(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntergration):
+(WebCore::Layout::FlexFormattingContext::computedIntrinsicWidthConstraintsForIntegration):
+* layout/formattingContexts/flex/FlexFormattingContext.h:
+* layout/formattingContexts/inline/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntergration):
+(WebCore::Layout::InlineFormattingContext::lineLayoutForIntergration): Deleted.
+* layout/formattingContexts/inline/InlineFormattingContext.h:
+* layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
+(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
+(WebCore::LayoutIntegration::FlexLayout::computeIntrinsicWidthConstraints):
+(WebCore::LayoutIntegration::FlexLayout::layout):
+* layout/integration/flex/LayoutIntegrationFlexLayout.h:
+(WebCore::LayoutIntegration::FlexLayout::rootLayoutBox const):
+(WebCore::LayoutIntegration::FlexLayout::rootLayoutBox):
+* layout/integration/inline/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::layout):
+
 2022-04-23  Brady Eidson  
 
 Add WKNotification and WKWebsiteDataStore SPI for handling click/close of persistent notifications


Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp (293296 => 293297)

--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp	2022-04-23 22:26:57 UTC (rev 293296)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp	2022-04-23 23:03:32 UTC (rev 293297)
@@ -118,7 +118,16 @@
 }
 }
 
+void FlexFormattingContext::layoutInFlowContentForIntergration(const ConstraintsForInFlowContent&)
+{
 }
+
+IntrinsicWidthConstraints FlexFormattingContext::computedIntrinsicWidthConstraintsForIntegration()
+{
+return { };
 }
 
+}
+}
+
 #endif


Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h (293296 => 293297)

--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h	2022-04-23 22:26:57 UTC (rev 293296)
+++

[webkit-changes] [293296] trunk

2022-04-23 Thread beidson

Title: [293296] trunk








Revision 293296
Author beid...@apple.com
Date 2022-04-23 15:26:57 -0700 (Sat, 23 Apr 2022)


Log Message
Add WKNotification and WKWebsiteDataStore SPI for handling click/close of persistent notifications
https://bugs.webkit.org/show_bug.cgi

Reviewed by Chris Dumez.

Source/WebCore:

Covered by existing tests with WKTR changes.

In Cocoa, expose the dictionary representation of a notification as an NSDictionary,
as it is meant to be used as an NSUserNotification userInfo value.

* Modules/notifications/NotificationData.h:
* Modules/notifications/NotificationDataCocoa.mm: Added.
(WebCore::NotificationData::fromDictionary):
(WebCore::NotificationData::dictionaryRepresentation const):

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:

* workers/service/server/SWServer.cpp:
(WebCore::SWServer::processNotificationEvent):
* workers/service/server/SWServer.h:

Source/WebKit:

For notifications that are persistent, add WKWebsiteDataStore SPI to handle click/close operations,
as the WKNotificationManager's runtime record of such notifications might be gone.

WebKitTestRunner exercises this new SPI in existing tests.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processNotificationEvent):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:

* SourcesCocoa.txt:

* UIProcess/API/C/WKNotification.cpp:
(WKNotificationGetIsPersistent):
* UIProcess/API/C/WKNotification.h:

* UIProcess/API/C/mac/WKNotificationPrivateMac.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h.
* UIProcess/API/C/mac/WKNotificationPrivateMac.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h.
(WKNotificationCopyDictionaryRepresentation):

* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _processPersistentNotificationClick:completionHandler:]):
(-[WKWebsiteDataStore _processPersistentNotificationClose:completionHandler:]):
* UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

* UIProcess/API/Cocoa/_WKDownload.mm:
* UIProcess/API/Cocoa/_WKDownloadInternal.h:

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::processNotificationEvent):
* UIProcess/Network/NetworkProcessProxy.h:

* UIProcess/Notifications/WebNotification.cpp:
* UIProcess/Notifications/WebNotification.h:
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::dispatchDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):

* WebKit.xcodeproj/project.pbxproj:

Tools:

Teach WKTR to use the new SPI by keeping a set of notifications that are persistent.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

* WebKitTestRunner/WebNotificationProvider.cpp:
(WTR::WebNotificationProvider::showWebNotification):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::reset):
* WebKitTestRunner/WebNotificationProvider.h:

* WebKitTestRunner/cocoa/WebNotificationProviderCocoa.mm:
(WTR::WebNotificationProvider::simulateWebNotificationClickForServiceWorkerNotifications):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/notifications/NotificationData.h
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
trunk/Source/WebKit/Shared/ModelIdentifier.h
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/API/C/WKNotification.cpp
trunk/Source/WebKit/UIProcess/API/C/WKNotification.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h
trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm
trunk/Source/WebKit/UIProcess/ModelElementController.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/Notifications/WebNotification.cpp
trunk/Source/WebKit/UIProcess/Notifications/WebNotification.h
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
trunk/Tools/WebKitTestRunner/WebNotificationProvider.cpp
trunk/Tools/WebKitTestRunner/WebNotificationProvider.h


Added Paths

trunk/Source/WebCore/Modules/notifications/NotificationDataCocoa.mm
trunk/Source/WebKit/UIProcess/API/C/mac/WKNotificationPrivateMac.h
trunk/Source/WebKit/UIProcess/API/C/mac/WKNotificationPrivateMac.mm

[webkit-changes] [293295] trunk/Source/WebCore

2022-04-23 Thread justin_michaud

Title: [293295] trunk/Source/WebCore








Revision 293295
Author justin_mich...@apple.com
Date 2022-04-23 14:47:00 -0700 (Sat, 23 Apr 2022)


Log Message
Fix build error caused by LTO + Unified Sources
https://bugs.webkit.org/show_bug.cgi?id=239679

Reviewed by Alex Christensen.

This hopefully fixes the following build error:
Undefined symbols for architecture x86_64:
  "JSC::GenericTypedArrayView::tryCreateUninitialized(unsigned long)", referenced from:
  WebCore::FEGaussianBlurSoftwareApplier::apply(WebCore::Filter const&, WTF::Vector >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FilterImage&) const in lto.o
ld: symbol(s) not found for architecture x86_64

* platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293294 => 293295)

--- trunk/Source/WebCore/ChangeLog	2022-04-23 21:13:57 UTC (rev 293294)
+++ trunk/Source/WebCore/ChangeLog	2022-04-23 21:47:00 UTC (rev 293295)
@@ -1,3 +1,18 @@
+2022-04-23  Justin Michaud  
+
+Fix build error caused by LTO + Unified Sources
+https://bugs.webkit.org/show_bug.cgi?id=239679
+
+Reviewed by Alex Christensen.
+
+This hopefully fixes the following build error:
+Undefined symbols for architecture x86_64:
+  "JSC::GenericTypedArrayView::tryCreateUninitialized(unsigned long)", referenced from:
+  WebCore::FEGaussianBlurSoftwareApplier::apply(WebCore::Filter const&, WTF::Vector >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FilterImage&) const in lto.o
+ld: symbol(s) not found for architecture x86_64
+
+* platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:
+
 2022-04-23  Alan Bujtas  
 
 [FFC][Integration] Construct and update the layout tree for the flex items


Modified: trunk/Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp (293294 => 293295)

--- trunk/Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp	2022-04-23 21:13:57 UTC (rev 293294)
+++ trunk/Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp	2022-04-23 21:47:00 UTC (rev 293295)
@@ -33,12 +33,12 @@
 #include "GraphicsContext.h"
 #include "ImageBuffer.h"
 #include "PixelBuffer.h"
+#include <_javascript_Core/TypedArrayInlines.h>
 #include 
 
 #if USE(ACCELERATE)
 #include 
 #else
-#include <_javascript_Core/TypedArrayInlines.h>
 #include 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293294] trunk/Tools

2022-04-23 Thread emw

Title: [293294] trunk/Tools








Revision 293294
Author e...@apple.com
Date 2022-04-23 14:13:57 -0700 (Sat, 23 Apr 2022)


Log Message
[buildbot] Increase the EWS compile timeout to account for delayed output from clang/XCBuild
https://bugs.webkit.org/show_bug.cgi?id=239455

Reviewed by Ryan Haddad.

Same as https://commits.webkit.org/249737@main, needed to work around
delayed output bugs in Xcode/XCBuild.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.__init__):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/249919@main

Modified Paths

trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (293293 => 293294)

--- trunk/Tools/CISupport/ews-build/steps.py	2022-04-23 20:25:12 UTC (rev 293293)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-04-23 21:13:57 UTC (rev 293294)
@@ -2295,6 +2295,9 @@
 
 def __init__(self, skipUpload=False, **kwargs):
 self.skipUpload = skipUpload
+# https://bugs.webkit.org/show_bug.cgi?id=239455: The timeout needs to be >20 min to work
+# around log output delays on slower machines.
+kwargs.setdefault('timeout', 60 * 30)
 super(CompileWebKit, self).__init__(logEnviron=False, **kwargs)
 
 def doStepIf(self, step):


Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (293293 => 293294)

--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-04-23 20:25:12 UTC (rev 293293)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-04-23 21:13:57 UTC (rev 293294)
@@ -1166,6 +1166,7 @@
 self.setProperty('configuration', 'release')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-webkit', '--release'],
 )
@@ -1181,6 +1182,7 @@
 self.setProperty('configuration', 'release')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-webkit', '--release', '--prefix=/app/webkit/WebKitBuild/release/install', '--gtk'],
 )
@@ -1196,6 +1198,7 @@
 self.setProperty('configuration', 'release')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-webkit', '--release', '--wpe'],
 )
@@ -1210,6 +1213,7 @@
 self.setProperty('configuration', 'debug')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
 )
@@ -1242,6 +1246,7 @@
 self.setProperty('configuration', 'release')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-webkit', '--release'],
 )
@@ -1256,6 +1261,7 @@
 self.setProperty('configuration', 'debug')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
 )
@@ -1366,6 +1372,7 @@
 self.setProperty('configuration', 'release')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-jsc', '--release'],
 )
@@ -1380,6 +1387,7 @@
 self.setProperty('configuration', 'debug')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-jsc', '--debug'],
 )
@@ -1404,6 +1412,7 @@
 self.setProperty('configuration', 'release')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+timeout=1800,
 logEnviron=False,
 command=['perl', 'Tools/Scripts/build-jsc', '--release'],
 )
@@ -1418,6 +1427,7 @@
 self.setProperty('configuration', 'debug')
 self.expectRemoteCommands(
 ExpectShell(workdir='wkdir',
+

[webkit-changes] [293293] trunk/Source/WebCore

2022-04-23 Thread zalan

Title: [293293] trunk/Source/WebCore








Revision 293293
Author za...@apple.com
Date 2022-04-23 13:25:12 -0700 (Sat, 23 Apr 2022)


Log Message
[FFC][Integration] Construct and update the layout tree for the flex items
https://bugs.webkit.org/show_bug.cgi?id=239684

Reviewed by Antti Koivisto.

This patch implements the usual flow of preparing a subtree for integration layout.

1. Take the direct children of a RenderFlexibleBox (flex items) and construct Layout::ContainerBox objects.
2. Run layout on the direct children (RenderBlocks) first and update the associated Layout::ContainerBoxes' geometries.
3. Call LayoutIntegration::FlexLayout::layout (not yet implemented) to run flex layout on the flex items.

* layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTreeForFlexContent):
* layout/integration/LayoutIntegrationBoxTree.h:
* layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
(WebCore::LayoutIntegration::FlexLayout::updateFlexItemDimensions):
* layout/integration/flex/LayoutIntegrationFlexLayout.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):
* rendering/RenderFlexibleBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h
trunk/Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
trunk/Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (293292 => 293293)

--- trunk/Source/WebCore/ChangeLog	2022-04-23 17:36:17 UTC (rev 293292)
+++ trunk/Source/WebCore/ChangeLog	2022-04-23 20:25:12 UTC (rev 293293)
@@ -1,3 +1,27 @@
+2022-04-23  Alan Bujtas  
+
+[FFC][Integration] Construct and update the layout tree for the flex items
+https://bugs.webkit.org/show_bug.cgi?id=239684
+
+Reviewed by Antti Koivisto.
+
+This patch implements the usual flow of preparing a subtree for integration layout.
+
+1. Take the direct children of a RenderFlexibleBox (flex items) and construct Layout::ContainerBox objects.
+2. Run layout on the direct children (RenderBlocks) first and update the associated Layout::ContainerBoxes' geometries.
+3. Call LayoutIntegration::FlexLayout::layout (not yet implemented) to run flex layout on the flex items.
+
+* layout/integration/LayoutIntegrationBoxTree.cpp:
+(WebCore::LayoutIntegration::BoxTree::buildTreeForFlexContent):
+* layout/integration/LayoutIntegrationBoxTree.h:
+* layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
+(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
+(WebCore::LayoutIntegration::FlexLayout::updateFlexItemDimensions):
+* layout/integration/flex/LayoutIntegrationFlexLayout.h:
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):
+* rendering/RenderFlexibleBox.h:
+
 2022-04-23  Andres Gonzalez  
 
 AX ITM: Table row objects should return a non-null unignored parent even when a table object is not found in its ancestry.


Modified: trunk/Source/WebCore/Headers.cmake (293292 => 293293)

--- trunk/Source/WebCore/Headers.cmake	2022-04-23 17:36:17 UTC (rev 293292)
+++ trunk/Source/WebCore/Headers.cmake	2022-04-23 20:25:12 UTC (rev 293293)
@@ -970,6 +970,7 @@
 
 inspector/agents/InspectorPageAgent.h
 
+layout/LayoutState.h
 layout/LayoutUnits.h
 layout/MarginTypes.h
 
@@ -976,6 +977,8 @@
 layout/formattingContexts/inline/display/InlineDisplayBox.h
 layout/formattingContexts/inline/InlineRect.h
 
+layout/integration/LayoutIntegrationBoxTree.h
+
 layout/integration/flex/LayoutIntegrationFlexLayout.h
 
 layout/integration/inline/InlineIteratorBox.h
@@ -991,6 +994,7 @@
 
 layout/layouttree/LayoutContainerBox.h
 layout/layouttree/LayoutBox.h
+layout/layouttree/LayoutInitialContainingBlock.h
 
 loader/CanvasActivityRecord.h
 loader/ContentFilterClient.h


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp (293292 => 293293)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp	2022-04-23 17:36:17 UTC (rev 293292)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp	2022-04-23 20:25:12 UTC (rev 293293)
@@ -37,6 +37,7 @@
 #include "RenderBlockFlow.h"
 #include "RenderChildIterator.h"
 #include "RenderDetailsMarker.h"
+#include "RenderFlexibleBox.h"
 #include "RenderImage.h"
 #include "RenderLineBreak.h"
 #include "RenderListItem.h"
@@ -87,6 +88,8 @@
 
 if (is(rootRenderer))
 buildTreeForInlineContent();
+else if (is(rootRenderer))
+

[webkit-changes] [293291] trunk

2022-04-23 Thread andresg_22

Title: [293291] trunk








Revision 293291
Author andresg...@apple.com
Date 2022-04-23 09:30:25 -0700 (Sat, 23 Apr 2022)


Log Message
AX ITM: Table row objects should return a non-null unignored parent even when a table object is not found in its ancestry.
https://bugs.webkit.org/show_bug.cgi?id=239606


Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/aria-expanded-supported-roles.html.
In addition, fixed test accessibility/mac/heading-clickpoint.html.

AccessibilityARIAGridRow::parentObjectUnignored was returning nullptr
if there was no table ancestor. This caused problems in isolated tree
mode where only the root object should have a null parent. With this
patch this method will return the table ancestor if one exists, its
parent in the AX tree otherwise.
Changed all classes in the AXObject hierarchy to return an AXObject for
the parentObjectUnignored method instead of an AXCoreObject.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedObjectForPage):
Removed unnecessary downcast.
* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::parentObjectUnignored const):
(WebCore::AccessibilityARIAGridRow::parentTable const):
Rewrote this method using Accessibility::findAncestor.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::parentObjectUnignored const):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectUnignored const):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentObjectUnignored const):
* accessibility/AccessibilityTableCell.h:

LayoutTests:

* accessibility/aria-expanded-supported-roles.html:
* accessibility/mac/heading-clickpoint-expected.txt:
* accessibility/mac/heading-clickpoint.html:
* platform/mac/accessibility/aria-expanded-supported-roles-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/aria-expanded-supported-roles.html
trunk/LayoutTests/accessibility/mac/heading-clickpoint-expected.txt
trunk/LayoutTests/accessibility/mac/heading-clickpoint.html
trunk/LayoutTests/platform/glib/accessibility/aria-expanded-supported-roles-expected.txt
trunk/LayoutTests/platform/mac/accessibility/aria-expanded-supported-roles-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h
trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp
trunk/Source/WebCore/accessibility/AccessibilityTableCell.h




Diff

Modified: trunk/LayoutTests/ChangeLog (293290 => 293291)

--- trunk/LayoutTests/ChangeLog	2022-04-23 15:09:11 UTC (rev 293290)
+++ trunk/LayoutTests/ChangeLog	2022-04-23 16:30:25 UTC (rev 293291)
@@ -1,3 +1,16 @@
+2022-04-23  Andres Gonzalez  
+
+AX ITM: Table row objects should return a non-null unignored parent even when a table object is not found in its ancestry.
+https://bugs.webkit.org/show_bug.cgi?id=239606
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/aria-expanded-supported-roles.html:
+* accessibility/mac/heading-clickpoint-expected.txt:
+* accessibility/mac/heading-clickpoint.html:
+* platform/mac/accessibility/aria-expanded-supported-roles-expected.txt:
+
 2022-04-23  Carlos Garcia Campos  
 
 [ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier


Modified: trunk/LayoutTests/accessibility/aria-expanded-supported-roles.html (293290 => 293291)

--- trunk/LayoutTests/accessibility/aria-expanded-supported-roles.html	2022-04-23 15:09:11 UTC (rev 293290)
+++ trunk/LayoutTests/accessibility/aria-expanded-supported-roles.html	2022-04-23 16:30:25 UTC (rev 293291)
@@ -1,7 +1,10 @@
 
 
+
+
 
-