[webkit-changes] [294096] trunk/LayoutTests
Title: [294096] trunk/LayoutTests Revision 294096 Author commit-qu...@webkit.org Date 2022-05-11 23:39:58 -0700 (Wed, 11 May 2022) Log Message [GPU Process] webrtc/vp8-then-h264-gpu-process-crash.html flaky fails after turning DOM in GPUP on by default https://bugs.webkit.org/show_bug.cgi?id=236926 Patch by John Cunningham on 2022-05-11 Reviewed by Youenn Fablet. * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wpe/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (294095 => 294096) --- trunk/LayoutTests/ChangeLog 2022-05-12 05:41:29 UTC (rev 294095) +++ trunk/LayoutTests/ChangeLog 2022-05-12 06:39:58 UTC (rev 294096) @@ -1,3 +1,12 @@ +2022-05-11 John Cunningham + +[GPU Process] webrtc/vp8-then-h264-gpu-process-crash.html flaky fails after turning DOM in GPUP on by default +https://bugs.webkit.org/show_bug.cgi?id=236926 + +Reviewed by Youenn Fablet. + +* platform/wpe/TestExpectations: + 2022-05-11 Patrick Angle Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overriden JSC built-ins Modified: trunk/LayoutTests/platform/wpe/TestExpectations (294095 => 294096) --- trunk/LayoutTests/platform/wpe/TestExpectations 2022-05-12 05:41:29 UTC (rev 294095) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2022-05-12 06:39:58 UTC (rev 294096) @@ -1350,6 +1350,14 @@ webkit.org/b/230277 imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-006.html [ ImageOnlyFailure ] webkit.org/b/230277 imported/w3c/web-platform-tests/css/css-transforms/scrollable-scroll-3d-transform-z.html [ ImageOnlyFailure ] +## +# Test failures from turning GPU Process on by default + +# Media failures +webkit.org/b/236926 webrtc/vp8-then-h264-gpu-process-crash.html [ Timeout Pass ] + + end of test failures related to GPU Process on by default + # # UNSORTED Expectations. When in doubt, put it here. # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294095] trunk/Source/WebCore
Title: [294095] trunk/Source/WebCore Revision 294095 Author dp...@igalia.com Date 2022-05-11 22:41:29 -0700 (Wed, 11 May 2022) Log Message [WPE] Unreviewed, build fix after r293816 https://bugs.webkit.org/show_bug.cgi?id=240330 Build was broken when ENABLE_ORIENTATION_EVENTS=ON * dom/DeviceOrientationEvent.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/DeviceOrientationEvent.idl Diff Modified: trunk/Source/WebCore/ChangeLog (294094 => 294095) --- trunk/Source/WebCore/ChangeLog 2022-05-12 05:14:05 UTC (rev 294094) +++ trunk/Source/WebCore/ChangeLog 2022-05-12 05:41:29 UTC (rev 294095) @@ -1,3 +1,12 @@ +2022-05-11 Diego Pino Garcia + +[WPE] Unreviewed, build fix after r293816 +https://bugs.webkit.org/show_bug.cgi?id=240330 + +Build was broken when ENABLE_ORIENTATION_EVENTS=ON + +* dom/DeviceOrientationEvent.idl: + 2022-05-11 Simon Fraser Some RenderStyle::diff() optimizations Modified: trunk/Source/WebCore/dom/DeviceOrientationEvent.idl (294094 => 294095) --- trunk/Source/WebCore/dom/DeviceOrientationEvent.idl 2022-05-12 05:14:05 UTC (rev 294094) +++ trunk/Source/WebCore/dom/DeviceOrientationEvent.idl 2022-05-12 05:41:29 UTC (rev 294095) @@ -48,7 +48,7 @@ optional unrestricted double? compassAccuracy = null); #else readonly attribute boolean? absolute; -undefined initDeviceOrientationEvent(optional DOMString type = "", +undefined initDeviceOrientationEvent(optional [AtomString] DOMString type = "", optional boolean bubbles = false, optional boolean cancelable = false, optional unrestricted double? alpha = null, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294094] trunk/Source/WebCore
Title: [294094] trunk/Source/WebCore
Revision 294094
Author simon.fra...@apple.com
Date 2022-05-11 22:14:05 -0700 (Wed, 11 May 2022)
Log Message
Some RenderStyle::diff() optimizations
https://bugs.webkit.org/show_bug.cgi?id=240323
Reviewed by Alan Bujtas.
Some LengthBox operator== stuff was showing up on profiles, which we can avoid by
first testing m_surroundData pointer equality.
scrollPadding and scrollSnapType live in rareNonInheritedData, so we can move their
comparisons into rareNonInheritedDataChangeRequiresLayout().
changeRequiresRepaint() can check for m_backgroundData and m_surroundData pointer
equality before doing more expensive tests.
These changes reduce the time in RenderStyle::diff() in the MotionMark Design
subtest by ~40%.
* rendering/style/RenderStyle.cpp:
(WebCore::rareNonInheritedDataChangeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::changeRequiresLayerRepaint const):
(WebCore::RenderStyle::changeRequiresRepaint const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294093 => 294094)
--- trunk/Source/WebCore/ChangeLog 2022-05-12 04:49:28 UTC (rev 294093)
+++ trunk/Source/WebCore/ChangeLog 2022-05-12 05:14:05 UTC (rev 294094)
@@ -1,3 +1,28 @@
+2022-05-11 Simon Fraser
+
+Some RenderStyle::diff() optimizations
+https://bugs.webkit.org/show_bug.cgi?id=240323
+
+Reviewed by Alan Bujtas.
+
+Some LengthBox operator== stuff was showing up on profiles, which we can avoid by
+first testing m_surroundData pointer equality.
+
+scrollPadding and scrollSnapType live in rareNonInheritedData, so we can move their
+comparisons into rareNonInheritedDataChangeRequiresLayout().
+
+changeRequiresRepaint() can check for m_backgroundData and m_surroundData pointer
+equality before doing more expensive tests.
+
+These changes reduce the time in RenderStyle::diff() in the MotionMark Design
+subtest by ~40%.
+
+* rendering/style/RenderStyle.cpp:
+(WebCore::rareNonInheritedDataChangeRequiresLayout):
+(WebCore::RenderStyle::changeRequiresLayout const):
+(WebCore::RenderStyle::changeRequiresLayerRepaint const):
+(WebCore::RenderStyle::changeRequiresRepaint const):
+
2022-05-11 Wenson Hsieh
ImageAnalysisQueue should extract and analyze images inside of subframes
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (294093 => 294094)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2022-05-12 04:49:28 UTC (rev 294093)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2022-05-12 05:14:05 UTC (rev 294094)
@@ -741,6 +741,10 @@
if (!arePointingToEqualData(first.boxReflect, second.boxReflect))
return true;
+// If the counter directives change, trigger a relayout to re-calculate counter values and rebuild the counter node tree.
+if (!arePointingToEqualData(first.counterDirectives, second.counterDirectives))
+return true;
+
if (first.multiCol != second.multiCol)
return true;
@@ -816,6 +820,12 @@
|| first.effectiveContainment().contains(Containment::InlineSize) != second.effectiveContainment().contains(Containment::InlineSize))
return true;
+if (first.scrollPadding != second.scrollPadding)
+return true;
+
+if (first.scrollSnapType != second.scrollSnapType)
+return true;
+
return false;
}
@@ -904,12 +914,35 @@
return true;
}
-if (m_surroundData->margin != other.m_surroundData->margin)
-return true;
+if (m_surroundData.ptr() != other.m_surroundData.ptr()) {
+if (m_surroundData->margin != other.m_surroundData->margin)
+return true;
-if (m_surroundData->padding != other.m_surroundData->padding)
-return true;
+if (m_surroundData->padding != other.m_surroundData->padding)
+return true;
+// If our border widths change, then we need to layout. Other changes to borders only necessitate a repaint.
+if (borderLeftWidth() != other.borderLeftWidth()
+|| borderTopWidth() != other.borderTopWidth()
+|| borderBottomWidth() != other.borderBottomWidth()
+|| borderRightWidth() != other.borderRightWidth())
+return true;
+
+if (position() != PositionType::Static) {
+if (m_surroundData->offset != other.m_surroundData->offset) {
+// FIXME: We would like to use SimplifiedLayout for relative positioning, but we can't quite do that yet.
+// We need to make sure SimplifiedLayout can operate correctly on RenderInlines (we will need
+// to add a selfNeedsSimplifiedLayout bit in order to not get confused and taint every line).
+if (position() != PositionType::
[webkit-changes] [294093] tags/WebKit-7614.1.13.3/
Title: [294093] tags/WebKit-7614.1.13.3/ Revision 294093 Author repst...@apple.com Date 2022-05-11 21:49:28 -0700 (Wed, 11 May 2022) Log Message Tag WebKit-7614.1.13.3. Added Paths tags/WebKit-7614.1.13.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294091] branches/safari-7614.1.13-branch/Source/WebKit
Title: [294091] branches/safari-7614.1.13-branch/Source/WebKit Revision 294091 Author repst...@apple.com Date 2022-05-11 21:46:10 -0700 (Wed, 11 May 2022) Log Message Cherry-pick r293936. rdar://problem/92859012 Fix adattributiond build in internal build on older macOS https://bugs.webkit.org/show_bug.cgi?id=240184 Patch by Alex Christensen on 2022-05-06 Reviewed by Alexey Proskuryakov. We need to search for WK_OVERRIDE_FRAMEWORKS_DIR to find the right frameworks * Configurations/adattributiond.xcconfig: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293936 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.13-branch/Source/WebKit/ChangeLog branches/safari-7614.1.13-branch/Source/WebKit/Configurations/adattributiond.xcconfig Diff Modified: branches/safari-7614.1.13-branch/Source/WebKit/ChangeLog (294090 => 294091) --- branches/safari-7614.1.13-branch/Source/WebKit/ChangeLog 2022-05-12 04:33:35 UTC (rev 294090) +++ branches/safari-7614.1.13-branch/Source/WebKit/ChangeLog 2022-05-12 04:46:10 UTC (rev 294091) @@ -1,3 +1,32 @@ +2022-05-11 Russell Epstein + +Cherry-pick r293936. rdar://problem/92859012 + +Fix adattributiond build in internal build on older macOS +https://bugs.webkit.org/show_bug.cgi?id=240184 + + +Patch by Alex Christensen on 2022-05-06 +Reviewed by Alexey Proskuryakov. + +We need to search for WK_OVERRIDE_FRAMEWORKS_DIR to find the right frameworks + +* Configurations/adattributiond.xcconfig: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293936 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-05-06 Alex Christensen + +Fix adattributiond build in internal build on older macOS +https://bugs.webkit.org/show_bug.cgi?id=240184 + + +Reviewed by Alexey Proskuryakov. + +We need to search for WK_OVERRIDE_FRAMEWORKS_DIR to find the right frameworks + +* Configurations/adattributiond.xcconfig: + 2022-05-06 Brent Fulgham Remove unused ApplePayRemoteUIEnabled preference Modified: branches/safari-7614.1.13-branch/Source/WebKit/Configurations/adattributiond.xcconfig (294090 => 294091) --- branches/safari-7614.1.13-branch/Source/WebKit/Configurations/adattributiond.xcconfig 2022-05-12 04:33:35 UTC (rev 294090) +++ branches/safari-7614.1.13-branch/Source/WebKit/Configurations/adattributiond.xcconfig 2022-05-12 04:46:10 UTC (rev 294091) @@ -35,4 +35,9 @@ WK_CODE_SIGN_FLAGS_iphoneos = --entitlements $(WK_PROCESSED_XCENT_FILE); OTHER_CODE_SIGN_FLAGS = $(WK_CODE_SIGN_FLAGS); +WK_OVERRIDE_FRAMEWORKS_DIR = $(WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_$(USE_STAGING_INSTALL_PATH)); +WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_YES = $(WK_INSTALL_PATH_PREFIX)$(SYSTEM_LIBRARY_DIR)/StagedFrameworks/Safari; + +FRAMEWORK_SEARCH_PATHS = $(inherited) $(WK_OVERRIDE_FRAMEWORKS_DIR) + INSTALL_PATH = $(INSTALL_PATH_PREFIX)$(WEBKIT_FRAMEWORKS_DIR)/WebKit.framework/$(WK_FRAMEWORK_VERSION_PREFIX)Daemons; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294092] branches/safari-7614.1.13-branch/Source/WebKit
Title: [294092] branches/safari-7614.1.13-branch/Source/WebKit Revision 294092 Author repst...@apple.com Date 2022-05-11 21:46:13 -0700 (Wed, 11 May 2022) Log Message Cherry-pick r293945. rdar://problem/92859012 Fix another internal build https://bugs.webkit.org/show_bug.cgi?id=240201 Patch by Alex Christensen on 2022-05-06 Reviewed by Alexey Proskuryakov. Bug 240184 introduced a classic "but I have spaces in my path" bug. * Configurations/adattributiond.xcconfig: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293945 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.13-branch/Source/WebKit/ChangeLog branches/safari-7614.1.13-branch/Source/WebKit/Configurations/adattributiond.xcconfig Diff Modified: branches/safari-7614.1.13-branch/Source/WebKit/ChangeLog (294091 => 294092) --- branches/safari-7614.1.13-branch/Source/WebKit/ChangeLog 2022-05-12 04:46:10 UTC (rev 294091) +++ branches/safari-7614.1.13-branch/Source/WebKit/ChangeLog 2022-05-12 04:46:13 UTC (rev 294092) @@ -1,5 +1,34 @@ 2022-05-11 Russell Epstein +Cherry-pick r293945. rdar://problem/92859012 + +Fix another internal build +https://bugs.webkit.org/show_bug.cgi?id=240201 + + +Patch by Alex Christensen on 2022-05-06 +Reviewed by Alexey Proskuryakov. + +Bug 240184 introduced a classic "but I have spaces in my path" bug. + +* Configurations/adattributiond.xcconfig: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293945 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-05-06 Alex Christensen + +Fix another internal build +https://bugs.webkit.org/show_bug.cgi?id=240201 + + +Reviewed by Alexey Proskuryakov. + +Bug 240184 introduced a classic "but I have spaces in my path" bug. + +* Configurations/adattributiond.xcconfig: + +2022-05-11 Russell Epstein + Cherry-pick r293936. rdar://problem/92859012 Fix adattributiond build in internal build on older macOS Modified: branches/safari-7614.1.13-branch/Source/WebKit/Configurations/adattributiond.xcconfig (294091 => 294092) --- branches/safari-7614.1.13-branch/Source/WebKit/Configurations/adattributiond.xcconfig 2022-05-12 04:46:10 UTC (rev 294091) +++ branches/safari-7614.1.13-branch/Source/WebKit/Configurations/adattributiond.xcconfig 2022-05-12 04:46:13 UTC (rev 294092) @@ -38,6 +38,9 @@ WK_OVERRIDE_FRAMEWORKS_DIR = $(WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_$(USE_STAGING_INSTALL_PATH)); WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_YES = $(WK_INSTALL_PATH_PREFIX)$(SYSTEM_LIBRARY_DIR)/StagedFrameworks/Safari; -FRAMEWORK_SEARCH_PATHS = $(inherited) $(WK_OVERRIDE_FRAMEWORKS_DIR) +WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR)); +WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES = "$(WK_OVERRIDE_FRAMEWORKS_DIR)"; +FRAMEWORK_SEARCH_PATHS = $(inherited) $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) + INSTALL_PATH = $(INSTALL_PATH_PREFIX)$(WEBKIT_FRAMEWORKS_DIR)/WebKit.framework/$(WK_FRAMEWORK_VERSION_PREFIX)Daemons; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294090] branches/safari-7614.1.13-branch/Source/WebGPU
Title: [294090] branches/safari-7614.1.13-branch/Source/WebGPU Revision 294090 Author repst...@apple.com Date 2022-05-11 21:33:35 -0700 (Wed, 11 May 2022) Log Message Cherry-pick r293937. rdar://problem/92524485 [WebGPU] Fix build on downlevel OSes in Apple's build system https://bugs.webkit.org/show_bug.cgi?id=240159 Reviewed by Alexey Proskuryakov. Some variables from WebKitTargetConditionals.xcconfig and PlatformSupport.xcconfig are used, so we have to make sure we include them. Also refactor the INSTALL_PATH variable a bit. * Configurations/Base.xcconfig: * Configurations/WebGPU.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Added. * WebGPU.xcodeproj/project.pbxproj: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293937 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.13-branch/Source/WebGPU/ChangeLog branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Base.xcconfig branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/WebGPU.xcconfig branches/safari-7614.1.13-branch/Source/WebGPU/WebGPU.xcodeproj/project.pbxproj Added Paths branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/WebKitTargetConditionals.xcconfig Diff Modified: branches/safari-7614.1.13-branch/Source/WebGPU/ChangeLog (294089 => 294090) --- branches/safari-7614.1.13-branch/Source/WebGPU/ChangeLog 2022-05-12 04:27:57 UTC (rev 294089) +++ branches/safari-7614.1.13-branch/Source/WebGPU/ChangeLog 2022-05-12 04:33:35 UTC (rev 294090) @@ -1,3 +1,44 @@ +2022-05-11 Russell Epstein + +Cherry-pick r293937. rdar://problem/92524485 + +[WebGPU] Fix build on downlevel OSes in Apple's build system +https://bugs.webkit.org/show_bug.cgi?id=240159 + + +Reviewed by Alexey Proskuryakov. + +Some variables from WebKitTargetConditionals.xcconfig and +PlatformSupport.xcconfig are used, so we have to make sure +we include them. Also refactor the INSTALL_PATH variable a +bit. + +* Configurations/Base.xcconfig: +* Configurations/WebGPU.xcconfig: +* Configurations/WebKitTargetConditionals.xcconfig: Added. +* WebGPU.xcodeproj/project.pbxproj: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293937 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-05-06 Myles C. Maxfield + +[WebGPU] Fix build on downlevel OSes in Apple's build system +https://bugs.webkit.org/show_bug.cgi?id=240159 + + +Reviewed by Alexey Proskuryakov. + +Some variables from WebKitTargetConditionals.xcconfig and +PlatformSupport.xcconfig are used, so we have to make sure +we include them. Also refactor the INSTALL_PATH variable a +bit. + +* Configurations/Base.xcconfig: +* Configurations/WebGPU.xcconfig: +* Configurations/WebKitTargetConditionals.xcconfig: Added. +* WebGPU.xcodeproj/project.pbxproj: + 2022-05-03 Myles C. Maxfield [WebGPU] Device creation should not always fail if supported features are requested Modified: branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Base.xcconfig (294089 => 294090) --- branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Base.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) +++ branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Base.xcconfig 2022-05-12 04:33:35 UTC (rev 294090) @@ -22,7 +22,9 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include? "../../../../Internal/Configurations/HaveInternalSDK.xcconfig" +#include? "/AppleInternal/XcodeConfig/PlatformSupport.xcconfig" #include "SDKVariant.xcconfig" +#include "WebKitTargetConditionals.xcconfig" CODE_SIGN_IDENTITY = -; AD_HOC_CODE_SIGNING_ALLOWED = YES; Modified: branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/WebGPU.xcconfig (294089 => 294090) --- branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/WebGPU.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) +++ branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/WebGPU.xcconfig 2022-05-12 04:33:35 UTC (rev 294090) @@ -38,10 +38,9 @@ INFOPLIST_FILE = Info.plist; -INSTALL_PATH = $(INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_$(USE_SYSTEM_CONTENT_PATH)); -INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH)$(WEBGPU_FRAMEWORKS_DIR); -INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_ = $(INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO); -INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO = $(WEBGPU_FRAMEWORKS_DIR); +INSTALL_PATH_PREFIX = $(INSTALL_PATH_PREFIX_$(USE_SYSTEM_CONTENT_PATH)); +INSTALL_PATH_PREFIX_YES = $(SYSTEM_CONTENT_PATH); +INSTALL_PATH = $(INSTALL_PATH_PREFIX)$(WEBGPU_FRAMEWORKS_DIR); SECONDARY_STAGED_FRAMEWORK_DIRECTORY = $(SYSTEM_SECONDARY_CONTENT_PATH)$(SYSTEM_LIBRARY_DIR)/StagedFrameworks/Safari COPY_STAGED_FRAMEWORKS_TO_SECONDARY_PATH = $(COPY_STAGED_FRAME
[webkit-changes] [294089] branches/safari-7614.1.13-branch/Source
Title: [294089] branches/safari-7614.1.13-branch/Source Revision 294089 Author repst...@apple.com Date 2022-05-11 21:27:57 -0700 (Wed, 11 May 2022) Log Message Versioning. WebKit-7614.1.13.3 Modified Paths branches/safari-7614.1.13-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.13-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.13-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.13-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.13-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.13-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.13-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.13-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.13-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294088 => 294089) --- branches/safari-7614.1.13-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-12 04:05:58 UTC (rev 294088) +++ branches/safari-7614.1.13-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 13; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.13-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294088 => 294089) --- branches/safari-7614.1.13-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-12 04:05:58 UTC (rev 294088) +++ branches/safari-7614.1.13-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 13; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.13-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294088 => 294089) --- branches/safari-7614.1.13-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-12 04:05:58 UTC (rev 294088) +++ branches/safari-7614.1.13-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 13; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.13-branch/Source/WebCore/Configurations/Version.xcconfig (294088 => 294089) --- branches/safari-7614.1.13-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-12 04:05:58 UTC (rev 294088) +++ branches/safari-7614.1.13-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 13; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.13-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294088 => 294089) --- branches/safari-7614.1.13-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-12 04:05:58 UTC (rev 294088) +++ branches/safari-7614.1.13-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 13; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Version.xcconfig (294088 => 294089) --- branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-12 04:05:58 UTC (rev 294088) +++ branches/safari-7614.1.13-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 13; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.13-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (294088 => 294089) --- branches/safari-7614.1.13-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-05-12 04:05:58 UTC (rev 294088) +++ branches/safari-7614.1.13-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-05-12 04:27:57 UTC (rev 294089) @@ -1,7 +1,7 @@ MAJOR_VERSION = 614; MINOR_VERSION
[webkit-changes] [294088] trunk
Title: [294088] trunk
Revision 294088
Author wenson_hs...@apple.com
Date 2022-05-11 21:05:58 -0700 (Wed, 11 May 2022)
Log Message
ImageAnalysisQueue should extract and analyze images inside of subframes
https://bugs.webkit.org/show_bug.cgi?id=240328
rdar://93134975
Reviewed by Tim Horton.
Teach `ImageAnalysisQueue` to recursively find all images on the page (including images in of subframe content)
and queue them for analysis. To do this, we refactor `enqueueAllImages` to call into a new recursive helper
method, `enqueueAllImagesRecursive`, to look for more candidate image elements that exist inside frame owner
elements (e.g. `iframe`).
Test: ImageAnalysisTests.AnalyzeImagesInSubframes
* page/ImageAnalysisQueue.cpp:
(WebCore::ImageAnalysisQueue::enqueueAllImages):
(WebCore::ImageAnalysisQueue::enqueueAllImagesRecursive):
* page/ImageAnalysisQueue.h:
ImageAnalysisQueue should extract and analyze images inside of subframes
https://bugs.webkit.org/show_bug.cgi?id=240328
rdar://93134975
Reviewed by Tim Horton.
Add an API test to verify that we extract and analyze images inside of subframes, in addition to images in the
main frame.
* TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/multiple-images.html:
Canonical link: https://commits.webkit.org/250478@main
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ImageAnalysisQueue.cpp
trunk/Source/WebCore/page/ImageAnalysisQueue.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/multiple-images.html
Diff
Modified: trunk/Source/WebCore/ChangeLog (294087 => 294088)
--- trunk/Source/WebCore/ChangeLog 2022-05-12 02:06:37 UTC (rev 294087)
+++ trunk/Source/WebCore/ChangeLog 2022-05-12 04:05:58 UTC (rev 294088)
@@ -1,3 +1,23 @@
+2022-05-11 Wenson Hsieh
+
+ImageAnalysisQueue should extract and analyze images inside of subframes
+https://bugs.webkit.org/show_bug.cgi?id=240328
+rdar://93134975
+
+Reviewed by Tim Horton.
+
+Teach `ImageAnalysisQueue` to recursively find all images on the page (including images in of subframe content)
+and queue them for analysis. To do this, we refactor `enqueueAllImages` to call into a new recursive helper
+method, `enqueueAllImagesRecursive`, to look for more candidate image elements that exist inside frame owner
+elements (e.g. `iframe`).
+
+Test: ImageAnalysisTests.AnalyzeImagesInSubframes
+
+* page/ImageAnalysisQueue.cpp:
+(WebCore::ImageAnalysisQueue::enqueueAllImages):
+(WebCore::ImageAnalysisQueue::enqueueAllImagesRecursive):
+* page/ImageAnalysisQueue.h:
+
2022-05-11 Patrick Angle
Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overriden JSC built-ins
Modified: trunk/Source/WebCore/page/ImageAnalysisQueue.cpp (294087 => 294088)
--- trunk/Source/WebCore/page/ImageAnalysisQueue.cpp 2022-05-12 02:06:37 UTC (rev 294087)
+++ trunk/Source/WebCore/page/ImageAnalysisQueue.cpp 2022-05-12 04:05:58 UTC (rev 294088)
@@ -97,8 +97,18 @@
m_identifier = identifier;
}
+enqueueAllImagesRecursive(document);
+}
+
+void ImageAnalysisQueue::enqueueAllImagesRecursive(Document& document)
+{
for (auto& image : descendantsOfType(document))
enqueueIfNeeded(image);
+
+for (auto& frameOwner : descendantsOfType(document)) {
+if (RefPtr contentDocument = frameOwner.contentDocument())
+enqueueAllImagesRecursive(*contentDocument);
+}
}
void ImageAnalysisQueue::resumeProcessing()
Modified: trunk/Source/WebCore/page/ImageAnalysisQueue.h (294087 => 294088)
--- trunk/Source/WebCore/page/ImageAnalysisQueue.h 2022-05-12 02:06:37 UTC (rev 294087)
+++ trunk/Source/WebCore/page/ImageAnalysisQueue.h 2022-05-12 04:05:58 UTC (rev 294088)
@@ -54,6 +54,8 @@
void resumeProcessingSoon();
void resumeProcessing();
+void enqueueAllImagesRecursive(Document&);
+
enum class Priority : bool { Low, High };
struct Task {
WeakPtr element;
Modified: trunk/Tools/ChangeLog (294087 => 294088)
--- trunk/Tools/ChangeLog 2022-05-12 02:06:37 UTC (rev 294087)
+++ trunk/Tools/ChangeLog 2022-05-12 04:05:58 UTC (rev 294088)
@@ -1,3 +1,18 @@
+2022-05-11 Wenson Hsieh
+
+ImageAnalysisQueue should extract and analyze images inside of subframes
+https://bugs.webkit.org/show_bug.cgi?id=240328
+rdar://93134975
+
+Reviewed by Tim Horton.
+
+Add an API test to verify that we extract and analyze images inside of subframes, in addition to images in the
+main frame.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebKitCocoa/multiple-images.html:
+
2022-05-10 Ben Nham
Re-send connection configuration if webpushd dies
[webkit-changes] [294087] trunk/Source/JavaScriptCore
Title: [294087] trunk/Source/_javascript_Core
Revision 294087
Author sbar...@apple.com
Date 2022-05-11 19:06:37 -0700 (Wed, 11 May 2022)
Log Message
Better handle clobbered registers in O0 register allocation
https://bugs.webkit.org/show_bug.cgi?id=240205
Reviewed by Yusuke Suzuki.
This patch makes Air's O0 register allocator better handle clobbered
registers. We now model both early and late clobber directly, and use
this to perform a basic interference analysis when allocating a register
to a Tmp. An early clobber interferes with any Use in an instruction, and
any early Defs. A late clobber interferes with any Defs in an instruction,
and any late Uses. What this enables is an early Use can be allocated
to a register that is only late clobbered. And a result can be allocated
to a register that is only early clobbered.
Prior to this, the algorithm had a bug where a Use may be allocated to
a register that is early clobbered.
* b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
(JSC::B3::Air::GenerateAndAllocateRegisters::buildLiveRanges):
(JSC::B3::Air::GenerateAndAllocateRegisters::alloc):
(JSC::B3::Air::GenerateAndAllocateRegisters::freeDeadTmpsIfNeeded):
(JSC::B3::Air::GenerateAndAllocateRegisters::assignTmp):
(JSC::B3::Air::GenerateAndAllocateRegisters::prepareForGeneration):
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):
* b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
* b3/air/testair.cpp:
* jit/RegisterSet.h:
Canonical link: https://commits.webkit.org/250477@main
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp
trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.h
trunk/Source/_javascript_Core/b3/air/testair.cpp
trunk/Source/_javascript_Core/jit/RegisterSet.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (294086 => 294087)
--- trunk/Source/_javascript_Core/ChangeLog 2022-05-12 01:44:45 UTC (rev 294086)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-05-12 02:06:37 UTC (rev 294087)
@@ -1,3 +1,34 @@
+2022-05-08 Saam Barati
+
+Better handle clobbered registers in O0 register allocation
+https://bugs.webkit.org/show_bug.cgi?id=240205
+
+
+Reviewed by Yusuke Suzuki.
+
+This patch makes Air's O0 register allocator better handle clobbered
+registers. We now model both early and late clobber directly, and use
+this to perform a basic interference analysis when allocating a register
+to a Tmp. An early clobber interferes with any Use in an instruction, and
+any early Defs. A late clobber interferes with any Defs in an instruction,
+and any late Uses. What this enables is an early Use can be allocated
+to a register that is only late clobbered. And a result can be allocated
+to a register that is only early clobbered.
+
+Prior to this, the algorithm had a bug where a Use may be allocated to
+a register that is early clobbered.
+
+* b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
+(JSC::B3::Air::GenerateAndAllocateRegisters::buildLiveRanges):
+(JSC::B3::Air::GenerateAndAllocateRegisters::alloc):
+(JSC::B3::Air::GenerateAndAllocateRegisters::freeDeadTmpsIfNeeded):
+(JSC::B3::Air::GenerateAndAllocateRegisters::assignTmp):
+(JSC::B3::Air::GenerateAndAllocateRegisters::prepareForGeneration):
+(JSC::B3::Air::GenerateAndAllocateRegisters::generate):
+* b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
+* b3/air/testair.cpp:
+* jit/RegisterSet.h:
+
2022-05-11 Patrick Angle
Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overriden JSC built-ins
Modified: trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp (294086 => 294087)
--- trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp 2022-05-12 01:44:45 UTC (rev 294086)
+++ trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp 2022-05-12 02:06:37 UTC (rev 294087)
@@ -78,7 +78,7 @@
{
m_liveRangeEnd = TmpMap(m_code, 0);
-m_globalInstIndex = 0;
+m_globalInstIndex = 1;
for (BasicBlock* block : m_code) {
for (Tmp tmp : liveness.liveAtHead(block)) {
if (!tmp.isReg())
@@ -180,11 +180,12 @@
{
ASSERT(reg);
ASSERT(m_map[tmp].reg == reg);
+ASSERT(tmp.isReg() || m_liveRangeEnd[tmp] >= m_globalInstIndex);
flush(tmp, reg);
release(tmp, reg);
}
-ALWAYS_INLINE void GenerateAndAllocateRegisters::alloc(Tmp tmp, Reg reg, bool isDef)
+ALWAYS_INLINE void GenerateAndAllocateRegisters::alloc(Tmp tmp, Reg reg, Arg::Role role)
{
if (Tmp occupyingTmp = m_currentAllocation->at(reg))
spill(occupyingTmp, reg);
@@ -197,7 +198,7 @@
m_availableRegs[tmp.bank()].clear(reg);
m_curren
[webkit-changes] [294086] trunk/Source/WebKit
Title: [294086] trunk/Source/WebKit Revision 294086 Author yousuke.kim...@sony.com Date 2022-05-11 18:44:45 -0700 (Wed, 11 May 2022) Log Message [WinCairo] Fix a compile error due to InspectorResourceURLSchemeHandler https://bugs.webkit.org/show_bug.cgi?id=239490 Reviewed by Yusuke Suzuki. * UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp: Canonical link: https://commits.webkit.org/250476@main Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (294085 => 294086) --- trunk/Source/WebKit/ChangeLog 2022-05-12 01:36:11 UTC (rev 294085) +++ trunk/Source/WebKit/ChangeLog 2022-05-12 01:44:45 UTC (rev 294086) @@ -1,3 +1,12 @@ +2022-05-12 Yousuke Kimoto + +[WinCairo] Fix a compile error due to InspectorResourceURLSchemeHandler +https://bugs.webkit.org/show_bug.cgi?id=239490 + +Reviewed by Yusuke Suzuki. + +* UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp: + 2022-05-10 Ben Nham Re-send connection configuration if webpushd dies Modified: trunk/Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp (294085 => 294086) --- trunk/Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp 2022-05-12 01:36:11 UTC (rev 294085) +++ trunk/Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp 2022-05-12 01:44:45 UTC (rev 294086) @@ -29,6 +29,7 @@ #if ENABLE(REMOTE_INSPECTOR) #include "APIPageConfiguration.h" +#include "InspectorResourceURLSchemeHandler.h" #include "WebInspectorUIProxy.h" #include "WebPageGroup.h" #include "WebPageProxy.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294085] branches/safari-7614.1.12-branch/Source
Title: [294085] branches/safari-7614.1.12-branch/Source Revision 294085 Author alanc...@apple.com Date 2022-05-11 18:36:11 -0700 (Wed, 11 May 2022) Log Message Versioning. WebKit-7614.1.12.3 Modified Paths branches/safari-7614.1.12-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.12-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.12-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.12-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.12-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.12-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.12-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.12-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.12-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.12-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294084 => 294085) --- branches/safari-7614.1.12-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-12 00:56:46 UTC (rev 294084) +++ branches/safari-7614.1.12-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-12 01:36:11 UTC (rev 294085) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.12-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294084 => 294085) --- branches/safari-7614.1.12-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-12 00:56:46 UTC (rev 294084) +++ branches/safari-7614.1.12-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-12 01:36:11 UTC (rev 294085) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.12-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294084 => 294085) --- branches/safari-7614.1.12-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-12 00:56:46 UTC (rev 294084) +++ branches/safari-7614.1.12-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-12 01:36:11 UTC (rev 294085) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.12-branch/Source/WebCore/Configurations/Version.xcconfig (294084 => 294085) --- branches/safari-7614.1.12-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-12 00:56:46 UTC (rev 294084) +++ branches/safari-7614.1.12-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-12 01:36:11 UTC (rev 294085) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.12-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294084 => 294085) --- branches/safari-7614.1.12-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-12 00:56:46 UTC (rev 294084) +++ branches/safari-7614.1.12-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-12 01:36:11 UTC (rev 294085) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.12-branch/Source/WebGPU/Configurations/Version.xcconfig (294084 => 294085) --- branches/safari-7614.1.12-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-12 00:56:46 UTC (rev 294084) +++ branches/safari-7614.1.12-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-12 01:36:11 UTC (rev 294085) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-7614.1.12-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (294084 => 294085) --- branches/safari-7614.1.12-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-05-12 00:56:46 UTC (rev 294084) +++ branches/safari-7614.1.12-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-05-12 01:36:11 UTC (rev 294085) @@ -1,7 +1,7 @@ MAJOR_VERSION = 614; MINOR_VERSION
[webkit-changes] [294084] trunk
Title: [294084] trunk Revision 294084 Author n...@apple.com Date 2022-05-11 17:56:46 -0700 (Wed, 11 May 2022) Log Message Re-send connection configuration if webpushd dies https://bugs.webkit.org/show_bug.cgi?id=240286 Reviewed by Geoffrey Garen. If webpushd dies, all future communication with it from NetworkProcess fails because we don't re-send the connection configuration to the daemon after the connection is interrupted. This manifests itself as an "invalid sender" AbortError from various PushManager methods because webpushd doesn't know the bundle identifier of the UIProcess it is working on behalf of. To fix this, I moved the responsibility for sending the configuration from NetworkNotificationManager to WebPushD::Connection, and WebPushD::Connection re-sends the configuration every time a new XPC connection is created. Covered by a new API test. Source/WebKit: * NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::NetworkSession): * NetworkProcess/NetworkSession.h: (WebKit::NetworkSession::webPushDaemonUsesMockBundlesForTesting const): Deleted. * NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm: (WebKit::WebPushD::Connection::newConnectionWasInitialized const): * NetworkProcess/Notifications/NetworkNotificationManager.cpp: (WebKit::NetworkNotificationManager::NetworkNotificationManager): (WebKit::NetworkNotificationManager::sendMessage const): (WebKit::NetworkNotificationManager::sendMessageWithReply const): (WebKit::NetworkNotificationManager::maybeSendConnectionConfiguration const): Deleted. * NetworkProcess/Notifications/NetworkNotificationManager.h: * NetworkProcess/Notifications/WebPushDaemonConnection.cpp: (WebKit::WebPushD::Connection::Connection): * NetworkProcess/Notifications/WebPushDaemonConnection.h: * NetworkProcess/cocoa/NetworkSessionCocoa.h: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): Tools: * TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: (TestWebKitAPI::testWebPushDaemonPList): (TestWebKitAPI::setUpTestWebPushD): (TestWebKitAPI::restartTestWebPushD): (TestWebKitAPI::WebPushDTest::WebPushDTest): * TestWebKitAPI/cocoa/DaemonTestUtilities.h: * TestWebKitAPI/cocoa/DaemonTestUtilities.mm: (TestWebKitAPI::restartService): Canonical link: https://commits.webkit.org/250475@main Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp trunk/Source/WebKit/NetworkProcess/NetworkSession.h trunk/Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h trunk/Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.cpp trunk/Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm trunk/Tools/TestWebKitAPI/cocoa/DaemonTestUtilities.h trunk/Tools/TestWebKitAPI/cocoa/DaemonTestUtilities.mm Diff Modified: trunk/Source/WebKit/ChangeLog (294083 => 294084) --- trunk/Source/WebKit/ChangeLog 2022-05-12 00:54:25 UTC (rev 294083) +++ trunk/Source/WebKit/ChangeLog 2022-05-12 00:56:46 UTC (rev 294084) @@ -1,3 +1,41 @@ +2022-05-10 Ben Nham + +Re-send connection configuration if webpushd dies +https://bugs.webkit.org/show_bug.cgi?id=240286 + +Reviewed by Geoffrey Garen. + +If webpushd dies, all future communication with it from NetworkProcess fails because we +don't re-send the connection configuration to the daemon after the connection is +interrupted. This manifests itself as an "invalid sender" AbortError from various +PushManager methods because webpushd doesn't know the bundle identifier of the UIProcess it +is working on behalf of. + +To fix this, I moved the responsibility for sending the configuration from +NetworkNotificationManager to WebPushD::Connection, and WebPushD::Connection re-sends the +configuration every time a new XPC connection is created. + +Covered by a new API test. + +* NetworkProcess/NetworkSession.cpp: +(WebKit::NetworkSession::NetworkSession): +* NetworkProcess/NetworkSession.h: +(WebKit::NetworkSession::webPushDaemonUsesMockBundlesForTesting const): Deleted. +* NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm: +(WebKit::WebPushD::Connection::newConnectionWasInitialized const): +* NetworkProcess/Notifications/NetworkNotificationManager.cpp: +(WebKit::NetworkNotificationManager::NetworkNotificationManager): +(WebKit::NetworkNotificationManager::sendMessage const): +(WebKit::NetworkNotificationManager::sendMessageWithReply const): +
[webkit-changes] [294083] tags/WebKit-7613.3.1.1.2/
Title: [294083] tags/WebKit-7613.3.1.1.2/ Revision 294083 Author alanc...@apple.com Date 2022-05-11 17:54:25 -0700 (Wed, 11 May 2022) Log Message Tag WebKit-7613.3.1.1.2. Added Paths tags/WebKit-7613.3.1.1.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294081] tags/WebKit-7613.3.1.0.2/
Title: [294081] tags/WebKit-7613.3.1.0.2/ Revision 294081 Author alanc...@apple.com Date 2022-05-11 17:02:12 -0700 (Wed, 11 May 2022) Log Message Tag WebKit-7613.3.1.0.2. Added Paths tags/WebKit-7613.3.1.0.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294080] tags/WebKit-7614.1.13.2/
Title: [294080] tags/WebKit-7614.1.13.2/ Revision 294080 Author repst...@apple.com Date 2022-05-11 16:58:20 -0700 (Wed, 11 May 2022) Log Message Tag WebKit-7614.1.13.2. Added Paths tags/WebKit-7614.1.13.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294079] trunk
Title: [294079] trunk Revision 294079 Author cdu...@apple.com Date 2022-05-11 16:52:02 -0700 (Wed, 11 May 2022) Log Message fast/text/international/system-language/navigator-language/navigator-language-fr.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=240104 Reviewed by Per Arne Vollan and Myles Maxfield. The test was flaky and navigator.language would sometimes return "fr" and sometimes "fr-FR". The reason for this is that Cocoa ports used 2 separate mechanisms to override the system language: 1. The override languages were used to set the AppleLanguages NSUserDefaults, causing APIs such as CFLocaleCopyPreferredLanguages() to return the overriden languages. 2. During process initialization we would also call WTF::overrideUserPreferredLanguages() which would add the override languages to an override Vector in WTF. The test was setting the override language to "fr". When method 2 would succeed, navigator.language would return "fr", from preferredLanguagesOverride(). However, Internals::resetToConsistentState() would reset WTF::preferredLanguagesOverride() shortly after the test starts running. As a result, the override Vector in WTF would often end up being empty and we would end up calling CFLocaleCopyPreferredLanguages(). However, CFLocaleCopyPreferredLanguages() return "fr-FR", which is equivalent but not exactly the same. To address the issue, I made the following changes: a. Use a single method for overriding languages for Cocoa ports. We are now using the AppleLanguages user default exclusively and not the WTF::preferredLanguagesOverride() Vector. b. We now call Internals::resetToConsistentState() only after running the test in WebKitTestRunner, not at the beginning of the test. This is consistent to what we were already doing in DumpRenderTree. Because Internals::resetToConsistentState() resets the languages, we don't want it to run at the beginning of the test. This is because some tests specify their languages in their header and WKTR ends up setting those languages via TestOptions, before actually running the test. We don't want those to get cleared. * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Only ask the injected bundle to reset after running the test and not before. This is consistent with what DumpRenderTree was already doing. The injected bundle would call Internals::resetToConsistentState() when receiving this reset message. * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::setAppleLanguagesPreference): Move the logic to set the AppleLanguages user default from the WebKit2 layer to WTF, inside LanguageCocoa.mm and use it inside WTF::overrideUserPreferredLanguages(). * Source/WTF/wtf/Language.cpp: (WTF::overrideUserPreferredLanguages): * Source/WTF/wtf/cocoa/LanguageCocoa.mm: (WTF::overrideUserPreferredLanguages): Stop using the WTF::preferredLanguagesOverride() Vector on Cocoa and set the AppleLanguages user default instead. WebKit2 was using both AppleLanguages and this Vector, which would give inconsistent results, especially when resetting the Vector but not the user default. Using the user default is also more realistic then the fake override Vector as we end up calling into the usual CF APIs to retrieve the languages. * Source/WebCore/platform/graphics/FontDescription.cpp: (WebCore::computeSpecializedChineseLocale): * Source/WebCore/platform/graphics/FontGenericFamilies.cpp: (WebCore::computeUserPrefersSimplified): Add some FIXME comments. These functions do locale matching but use minimized locales which may cause the matching to fail. This is causing fast/text/international/generic-font-family-language-traditional.html to fail. We didn't notice before because our test infrastructure storing language overrides in a vector in WTF, which doesn't get minimized, unlike locales we get from the system. * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::userPreferredLanguages const): Stop minimizing the locales returned by internals.userPreferredLanguages(). It used to not matter because locales set by the test would be set in the WTF::overrideUserPreferredLanguages() Vector and locales from that vector would get returned un-minimized, even when requesting minimized locales. However, now that we are no longer using this vector and using the regular code path instead, locales would get minimized and this would cause a test to fail. The test was checking that the values returned by internals.userPreferredLanguages() are exactly the same as the ones set via internals.setUserPreferredLanguages(). * LayoutTests/fast/harness/user-preferred-language.html: Tweak test to use call internals.setUserPreferredLanguages() with proper locales instead of using non-locales. This used to not matter because we were storing them in the WTF::overrideUserPreferredLanguages() Vector and internals.userPreferredLanguages() would return then as-is from
[webkit-changes] [294078] releases/Apple/Safari Technology Preview/ Safari Technology Preview 145/
Title: [294078] releases/Apple/Safari Technology Preview/Safari Technology Preview 145/ Revision 294078 Author alanc...@apple.com Date 2022-05-11 15:32:01 -0700 (Wed, 11 May 2022) Log Message Added a tag for Safari Technology Preview release 145. Added Paths releases/Apple/Safari Technology Preview/Safari Technology Preview 145/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294077] trunk
Title: [294077] trunk Revision 294077 Author yu...@chromium.org Date 2022-05-11 14:57:56 -0700 (Wed, 11 May 2022) Log Message [WinCairo] Support file downloads https://bugs.webkit.org/show_bug.cgi?id=240293 Reviewed by Fujii Hironori. .: * Source/cmake/OptionsWin.cmake: enable DOWNLOAD_ATTRIBUTE by default in WinCairo. Source/WebCore: Properly convert suggested file name to utf8. Coverred by LayoutTests/http/tests/download/literal-utf-8.html. * platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::platformSuggestedFilename const): Source/WebKit: Hooked up Curl calls to Download callbacks. Added basic support for file downloads in Curl. * NetworkProcess/curl/NetworkDataTaskCurl.cpp: (WebKit::NetworkDataTaskCurl::cancel): (WebKit::NetworkDataTaskCurl::curlDidReceiveData): (WebKit::NetworkDataTaskCurl::curlDidComplete): (WebKit::NetworkDataTaskCurl::deleteDownloadFile): (WebKit::NetworkDataTaskCurl::curlDidFailWithError): (WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse): * NetworkProcess/curl/NetworkDataTaskCurl.h: LayoutTests: * platform/wincairo/TestExpectations: enable downloads tests. Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wincairo/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h trunk/Source/cmake/OptionsWin.cmake Diff Modified: trunk/ChangeLog (294076 => 294077) --- trunk/ChangeLog 2022-05-11 21:57:24 UTC (rev 294076) +++ trunk/ChangeLog 2022-05-11 21:57:56 UTC (rev 294077) @@ -1,3 +1,12 @@ +2022-05-11 Yury Semikhatsky + +[WinCairo] Support file downloads +https://bugs.webkit.org/show_bug.cgi?id=240293 + +Reviewed by Fujii Hironori. + +* Source/cmake/OptionsWin.cmake: enable DOWNLOAD_ATTRIBUTE by default in WinCairo. + 2022-05-11 Jonathan Bedard Remove Subversion references from ReadMe Modified: trunk/LayoutTests/ChangeLog (294076 => 294077) --- trunk/LayoutTests/ChangeLog 2022-05-11 21:57:24 UTC (rev 294076) +++ trunk/LayoutTests/ChangeLog 2022-05-11 21:57:56 UTC (rev 294077) @@ -1,3 +1,12 @@ +2022-05-11 Yury Semikhatsky + +[WinCairo] Support file downloads +https://bugs.webkit.org/show_bug.cgi?id=240293 + +Reviewed by Fujii Hironori. + +* platform/wincairo/TestExpectations: enable downloads tests. + 2022-05-11 Antti Koivisto REGRESSION (r291788): MotionMark Suits subtest is 9% regressed Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (294076 => 294077) --- trunk/LayoutTests/platform/wincairo/TestExpectations 2022-05-11 21:57:24 UTC (rev 294076) +++ trunk/LayoutTests/platform/wincairo/TestExpectations 2022-05-11 21:57:56 UTC (rev 294077) @@ -54,23 +54,15 @@ fast/dom/DeviceMotion [ Skip ] fast/dom/Window/window-properties-device-orientation.html [ Skip ] -# DOWNLOAD_ATTRIBUTE is disabled -fast/dom/HTMLAnchorElement/anchor-download.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-file-blob-download-then-revoke.html [ Skip ] -fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Skip ] +# Unexpected suggested file name. +fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html [ Failure ] +fast/dom/HTMLAnchorElement/anchor-download.html [ Failure ] +fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html [ Failure ] +fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html [ Failure ] +fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html [ Failure ] +fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html [ Failure ] +fast/dom/HTMLAnchorElement/anchor-file-b
[webkit-changes] [294076] branches/safari-7613.3.1.1-branch/Source
Title: [294076] branches/safari-7613.3.1.1-branch/Source Revision 294076 Author alanc...@apple.com Date 2022-05-11 14:57:24 -0700 (Wed, 11 May 2022) Log Message Versioning. WebKit-7613.3.1.1.2 Modified Paths branches/safari-7613.3.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7613.3.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7613.3.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7613.3.1.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7613.3.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7613.3.1.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7613.3.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7613.3.1.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7613.3.1.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7613.3.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294075 => 294076) --- branches/safari-7613.3.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) +++ branches/safari-7613.3.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-11 21:57:24 UTC (rev 294076) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294075 => 294076) --- branches/safari-7613.3.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) +++ branches/safari-7613.3.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-11 21:57:24 UTC (rev 294076) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294075 => 294076) --- branches/safari-7613.3.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) +++ branches/safari-7613.3.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-11 21:57:24 UTC (rev 294076) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.1-branch/Source/WebCore/Configurations/Version.xcconfig (294075 => 294076) --- branches/safari-7613.3.1.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) +++ branches/safari-7613.3.1.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-11 21:57:24 UTC (rev 294076) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294075 => 294076) --- branches/safari-7613.3.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) +++ branches/safari-7613.3.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-11 21:57:24 UTC (rev 294076) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.1-branch/Source/WebGPU/Configurations/Version.xcconfig (294075 => 294076) --- branches/safari-7613.3.1.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) +++ branches/safari-7613.3.1.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-11 21:57:24 UTC (rev 294076) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FU
[webkit-changes] [294075] branches/safari-7613.3.1.0-branch/Source
Title: [294075] branches/safari-7613.3.1.0-branch/Source Revision 294075 Author alanc...@apple.com Date 2022-05-11 14:56:05 -0700 (Wed, 11 May 2022) Log Message Versioning. WebKit-7613.3.1.0.2 Modified Paths branches/safari-7613.3.1.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7613.3.1.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7613.3.1.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7613.3.1.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7613.3.1.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7613.3.1.0-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7613.3.1.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7613.3.1.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7613.3.1.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7613.3.1.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294074 => 294075) --- branches/safari-7613.3.1.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-11 21:47:25 UTC (rev 294074) +++ branches/safari-7613.3.1.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294074 => 294075) --- branches/safari-7613.3.1.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-11 21:47:25 UTC (rev 294074) +++ branches/safari-7613.3.1.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294074 => 294075) --- branches/safari-7613.3.1.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-11 21:47:25 UTC (rev 294074) +++ branches/safari-7613.3.1.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.0-branch/Source/WebCore/Configurations/Version.xcconfig (294074 => 294075) --- branches/safari-7613.3.1.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-11 21:47:25 UTC (rev 294074) +++ branches/safari-7613.3.1.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294074 => 294075) --- branches/safari-7613.3.1.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-11 21:47:25 UTC (rev 294074) +++ branches/safari-7613.3.1.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7613.3.1.0-branch/Source/WebGPU/Configurations/Version.xcconfig (294074 => 294075) --- branches/safari-7613.3.1.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-11 21:47:25 UTC (rev 294074) +++ branches/safari-7613.3.1.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-11 21:56:05 UTC (rev 294075) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FU
[webkit-changes] [294074] trunk
Title: [294074] trunk Revision 294074 Author jbed...@apple.com Date 2022-05-11 14:47:25 -0700 (Wed, 11 May 2022) Log Message Remove Subversion references from ReadMe https://bugs.webkit.org/show_bug.cgi?id=240316 Reviewed by Geoffrey Garen. * ReadMe.md: Canonical link: https://commits.webkit.org/250471@main Modified Paths trunk/ChangeLog trunk/ReadMe.md Diff Modified: trunk/ChangeLog (294073 => 294074) --- trunk/ChangeLog 2022-05-11 21:43:36 UTC (rev 294073) +++ trunk/ChangeLog 2022-05-11 21:47:25 UTC (rev 294074) @@ -1,3 +1,13 @@ +2022-05-11 Jonathan Bedard + +Remove Subversion references from ReadMe +https://bugs.webkit.org/show_bug.cgi?id=240316 + + +Reviewed by Geoffrey Garen. + +* ReadMe.md: + 2022-05-06 Sihui Liu Unreviewed, add github info to contributors.json. Modified: trunk/ReadMe.md (294073 => 294074) --- trunk/ReadMe.md 2022-05-11 21:43:36 UTC (rev 294073) +++ trunk/ReadMe.md 2022-05-11 21:47:25 UTC (rev 294074) @@ -44,14 +44,6 @@ For information about this, and other aspects of using Git with WebKit, read [the wiki page](https://trac.webkit.org/wiki/UsingGitWithWebKit). -### Checking out the Subversion Repository - -If you don't want to use Git, run the following command to check out WebKit's Subversion repository: - -``` -svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit -``` - ## Building WebKit ### Building macOS Port ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294073] tags/WebKit-7613.3.1.1.1/
Title: [294073] tags/WebKit-7613.3.1.1.1/ Revision 294073 Author alanc...@apple.com Date 2022-05-11 14:43:36 -0700 (Wed, 11 May 2022) Log Message Tag WebKit-7613.3.1.1.1. Added Paths tags/WebKit-7613.3.1.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294072] trunk/Source/WebKit
Title: [294072] trunk/Source/WebKit
Revision 294072
Author msab...@apple.com
Date 2022-05-11 14:41:42 -0700 (Wed, 11 May 2022)
Log Message
Need to add DYLD_LIBRARY_PATH for XPC services
https://bugs.webkit.org/show_bug.cgi?id=240289
Reviewed by Alexey Proskuryakov.
Set DYLD_LIBRARY_PATH / DYLD_VERSIONED_LIBRARY_PATH for XPC services depending on the value of USE_STAGING_INSTALL_PATH.
Also added DYLD_LIBRARY_PATH to the XPC environment for webpushd.
* Configurations/BaseTarget.xcconfig:
* webpushd/webpushtool/WebPushToolMain.mm:
(registerDaemonWithLaunchD):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/BaseTarget.xcconfig
trunk/Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (294071 => 294072)
--- trunk/Source/WebKit/ChangeLog 2022-05-11 21:37:13 UTC (rev 294071)
+++ trunk/Source/WebKit/ChangeLog 2022-05-11 21:41:42 UTC (rev 294072)
@@ -1,3 +1,17 @@
+2022-05-11 Michael Saboff
+
+Need to add DYLD_LIBRARY_PATH for XPC services
+https://bugs.webkit.org/show_bug.cgi?id=240289
+
+Reviewed by Alexey Proskuryakov.
+
+Set DYLD_LIBRARY_PATH / DYLD_VERSIONED_LIBRARY_PATH for XPC services depending on the value of USE_STAGING_INSTALL_PATH.
+Also added DYLD_LIBRARY_PATH to the XPC environment for webpushd.
+
+* Configurations/BaseTarget.xcconfig:
+* webpushd/webpushtool/WebPushToolMain.mm:
+(registerDaemonWithLaunchD):
+
2022-05-11 Per Arne Vollan
[WP] Remove obsolete message filters
Modified: trunk/Source/WebKit/Configurations/BaseTarget.xcconfig (294071 => 294072)
--- trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2022-05-11 21:37:13 UTC (rev 294071)
+++ trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2022-05-11 21:41:42 UTC (rev 294072)
@@ -125,8 +125,8 @@
WEBKIT_LEGACY_PRIVATE_HEADERS_DIR = $(UMBRELLA_FRAMEWORKS_DIR)/WebKitLegacy.framework/$(WK_FRAMEWORK_VERSION_PREFIX)PrivateHeaders;
OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH = $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_$(USE_STAGING_INSTALL_PATH));
-OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES = -Wl,-dyld_env,DYLD_VERSIONED_FRAMEWORK_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari;
-OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES[arch=arm64*][sdk=macosx11*] = -Wl,-dyld_env,DYLD_FRAMEWORK_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari;
+OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES = -Wl,-dyld_env,DYLD_VERSIONED_FRAMEWORK_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari,-dyld_env,DYLD_VERSIONED_LIBRARY_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari;
+OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES[arch=arm64*][sdk=macosx11*] = -Wl,-dyld_env,DYLD_FRAMEWORK_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari,-dyld_env,DYLD_LIBRARY_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari;
WK_USE_OVERRIDE_FRAMEWORKS_DIR = $(WK_NOT_$(WK_EMPTY_$(WK_OVERRIDE_FRAMEWORKS_DIR)));
Modified: trunk/Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm (294071 => 294072)
--- trunk/Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm 2022-05-11 21:37:13 UTC (rev 294071)
+++ trunk/Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm 2022-05-11 21:41:42 UTC (rev 294072)
@@ -106,6 +106,7 @@
{
auto environmentVariables = adoptNS(xpc_dictionary_create(nullptr, nullptr, 0));
xpc_dictionary_set_string(environmentVariables.get(), "DYLD_FRAMEWORK_PATH", currentExecutableDirectoryURL.fileSystemRepresentation);
+xpc_dictionary_set_string(environmentVariables.get(), "DYLD_LIBRARY_PATH", currentExecutableDirectoryURL.fileSystemRepresentation);
xpc_dictionary_set_value(plist.get(), "EnvironmentVariables", environmentVariables.get());
}
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294071] tags/WebKit-7613.3.1.0.1/
Title: [294071] tags/WebKit-7613.3.1.0.1/ Revision 294071 Author alanc...@apple.com Date 2022-05-11 14:37:13 -0700 (Wed, 11 May 2022) Log Message Tag WebKit-7613.3.1.0.1. Added Paths tags/WebKit-7613.3.1.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294070] branches/safari-613-branch/Source
Title: [294070] branches/safari-613-branch/Source
Revision 294070
Author alanc...@apple.com
Date 2022-05-11 13:40:13 -0700 (Wed, 11 May 2022)
Log Message
Cherry-pick r293804. rdar://92717726
Crash under WebCore: WebCore::CachedResourceClientWalker::next()
https://bugs.webkit.org/show_bug.cgi?id=240072
Reviewed by Geoff Garen.
Have CachedResource and CachedResourceClientWalker hold the clients via WeakPtrs instead of
raw pointers and null check them before usage. This is a lot safer.
* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/WeakHashCountedSet.h: Added.
(WTF::WeakHashCountedSet::begin):
(WTF::WeakHashCountedSet::end):
(WTF::WeakHashCountedSet::begin const):
(WTF::WeakHashCountedSet::end const):
(WTF::WeakHashCountedSet::find):
(WTF::WeakHashCountedSet::find const):
(WTF::WeakHashCountedSet::contains const):
(WTF::WeakHashCountedSet::computeSize const):
(WTF::WeakHashCountedSet::clear):
(WTF::Counter>::add):
(WTF::Counter>::remove):
* Source/WebCore/html/HTMLLinkElement.h:
* Source/WebCore/loader/DocumentThreadableLoader.h:
* Source/WebCore/loader/ImageLoader.h:
* Source/WebCore/loader/LinkLoader.h:
* Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
* Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::switchClientsToRevalidatedResource):
* Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::hasClients const):
(WebCore::CachedResource::hasClient):
(WebCore::CachedResource::numberOfClients const):
* Source/WebCore/loader/cache/CachedResourceClient.h:
* Source/WebCore/loader/cache/CachedResourceClientWalker.h:
(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
(WebCore::CachedResourceClientWalker::next):
* Source/WebCore/rendering/RenderObject.h:
Canonical link: https://commits.webkit.org/245886.562@safari-7613.3.1.0-branch
Modified Paths
branches/safari-613-branch/Source/WTF/WTF.xcodeproj/project.pbxproj
branches/safari-613-branch/Source/WTF/wtf/CMakeLists.txt
branches/safari-613-branch/Source/WebCore/html/HTMLLinkElement.h
branches/safari-613-branch/Source/WebCore/loader/DocumentThreadableLoader.h
branches/safari-613-branch/Source/WebCore/loader/ImageLoader.h
branches/safari-613-branch/Source/WebCore/loader/LinkLoader.h
branches/safari-613-branch/Source/WebCore/loader/cache/CachedImage.cpp
branches/safari-613-branch/Source/WebCore/loader/cache/CachedResource.cpp
branches/safari-613-branch/Source/WebCore/loader/cache/CachedResource.h
branches/safari-613-branch/Source/WebCore/loader/cache/CachedResourceClient.h
branches/safari-613-branch/Source/WebCore/loader/cache/CachedResourceClientWalker.h
branches/safari-613-branch/Source/WebCore/rendering/RenderObject.h
Added Paths
branches/safari-613-branch/Source/WTF/wtf/WeakHashCountedSet.h
Diff
Modified: branches/safari-613-branch/Source/WTF/WTF.xcodeproj/project.pbxproj (294069 => 294070)
--- branches/safari-613-branch/Source/WTF/WTF.xcodeproj/project.pbxproj 2022-05-11 20:40:08 UTC (rev 294069)
+++ branches/safari-613-branch/Source/WTF/WTF.xcodeproj/project.pbxproj 2022-05-11 20:40:13 UTC (rev 294070)
@@ -72,6 +72,7 @@
3337DB9CE743410FAF076E17 /* StackTrace.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 313EDEC9778E49C9BEA91CFC /* StackTrace.cpp */; };
337B2D6A26546EB300DDFD3D /* LikelyDenseUnsignedIntegerSet.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 337B2D6826546EAA00DDFD3D /* LikelyDenseUnsignedIntegerSet.cpp */; };
4427C5AA21F6D6C300A612A4 /* ASCIICType.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4427C5A921F6D6C300A612A4 /* ASCIICType.cpp */; };
+ 46449E8B2822E5680005A8BC /* WeakHashCountedSet.h in Headers */ = {isa = PBXBuildFile; fileRef = 46449E8A2822E5670005A8BC /* WeakHashCountedSet.h */; settings = {ATTRIBUTES = (Private, ); }; };
46BEB6EB22FFE24900269867 /* RefCounted.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 46BEB6E922FFDDD500269867 /* RefCounted.cpp */; };
46E93049271F1205005BA6E5 /* SafeStrerror.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 46E43647271F10AA00C88C90 /* SafeStrerror.cpp */; };
50DE35F5215BB01500B979C7 /* ExternalStringImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 50DE35F3215BB01500B979C7 /* ExternalStringImpl.cpp */; };
@@ -394,6 +395,7 @@
4468567225094FE8008CCA05 /* ThreadSanitizerSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ThreadSanitizerSupport.h; sourceTree = ""; };
44CDE4D226EE6CDA009F6ACB /* TypeCastsCocoa.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TypeCastsCocoa.h; sourceTree = ""; };
46209A27266D543A007F8F4A /* CancellableTask.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CancellableTask.h; sourceTree = ""; };
+ 46449E8A2822E5670005A8BC /* WeakHas
[webkit-changes] [294069] branches/safari-613-branch
Title: [294069] branches/safari-613-branch
Revision 294069
Author alanc...@apple.com
Date 2022-05-11 13:40:08 -0700 (Wed, 11 May 2022)
Log Message
Cherry-pick r293736. rdar://80891555
StorageMap::removeItem may fail to remove item from map
https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555
Reviewed by Chris Dumez.
Source/WebCore:
We may have updated m_impl, but we don't update iterator for removal. In this case, item is not removed from
map, but currentSize is updated. The mismatch between currentSize and actual size of the map may lead to
underflow and overflow in currentSize when item is added or removed later.
Test: storage/domstorage/sessionstorage/window-open-remove-item.html
* storage/StorageMap.cpp:
(WebCore::StorageMap::removeItem):
LayoutTests:
* storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
* storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
* storage/domstorage/sessionstorage/window-open-remove-item.html: Added.
Canonical link: https://commits.webkit.org/245886.561@safari-7613.3.1.0-branch
Modified Paths
branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/storage/StorageMap.cpp
Added Paths
branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/resources/window-open-remove-item.html
branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/window-open-remove-item-expected.txt
branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/window-open-remove-item.html
Diff
Modified: branches/safari-613-branch/LayoutTests/ChangeLog (294068 => 294069)
--- branches/safari-613-branch/LayoutTests/ChangeLog 2022-05-11 20:40:03 UTC (rev 294068)
+++ branches/safari-613-branch/LayoutTests/ChangeLog 2022-05-11 20:40:08 UTC (rev 294069)
@@ -1,3 +1,15 @@
+2022-05-03 Sihui Liu
+
+StorageMap::removeItem may fail to remove item from map
+https://bugs.webkit.org/show_bug.cgi?id=239982
+rdar://80891555
+
+Reviewed by Chris Dumez.
+
+* storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
+* storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
+* storage/domstorage/sessionstorage/window-open-remove-item.html: Added.
+
2022-04-26 Russell Epstein
Cherry-pick r290630. rdar://problem/89442583
Added: branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/resources/window-open-remove-item.html (0 => 294069)
--- branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/resources/window-open-remove-item.html (rev 0)
+++ branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/resources/window-open-remove-item.html 2022-05-11 20:40:08 UTC (rev 294069)
@@ -0,0 +1,15 @@
+
+
+
+
+if (sessionStorage.getItem("key") != "value")
+localStorage.setItem("result", "fail");
+else {
+sessionStorage.removeItem("key");
+sessionStorage.setItem("key", "newValue");
+localStorage.setItem("result", "pass");
+}
+
+
+
+
\ No newline at end of file
Added: branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/window-open-remove-item-expected.txt (0 => 294069)
--- branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/window-open-remove-item-expected.txt (rev 0)
+++ branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/window-open-remove-item-expected.txt 2022-05-11 20:40:08 UTC (rev 294069)
@@ -0,0 +1,11 @@
+Test verifies that process does not crash when item is updated in another window
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS localStorage.getItem('result') is "pass"
+PASS sessionStorage.getItem('key') is "value"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/window-open-remove-item.html (0 => 294069)
--- branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/window-open-remove-item.html (rev 0)
+++ branches/safari-613-branch/LayoutTests/storage/domstorage/sessionstorage/window-open-remove-item.html 2022-05-11 20:40:08 UTC (rev 294069)
@@ -0,0 +1,24 @@
+
+
+
+
+