[webkit-changes] [WebKit/WebKit] 3d0a14: [LFC][Cleanup] Remove Layout::Box::formattingConte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d0a14637f43e289c60e35954aacd2bf963ea535 https://github.com/WebKit/WebKit/commit/3d0a14637f43e289c60e35954aacd2bf963ea535 Author: Alan Bujtas Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebCore/layout/FormattingState.cpp M Source/WebCore/layout/FormattingState.h M Source/WebCore/layout/LayoutState.cpp M Source/WebCore/layout/Verification.cpp M Source/WebCore/layout/formattingContexts/FormattingContext.cpp M Source/WebCore/layout/formattingContexts/FormattingContext.h M Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp M Source/WebCore/layout/formattingContexts/table/TableFormattingQuirks.cpp M Source/WebCore/layout/layouttree/LayoutBox.cpp M Source/WebCore/layout/layouttree/LayoutBox.h M Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h Log Message: --- [LFC][Cleanup] Remove Layout::Box::formattingContextRoot https://bugs.webkit.org/show_bug.cgi?id=245351 Reviewed by Antti Koivisto. 1. While laying out a formatting context, we precisely know what the root of the formatting context is. 2. Finding the formatting context root of a "random" layout box should only be a valid operation when ASSERTing against some state (with the exception of finding the parent floating state when initializing an IFC, -we could certainly eliminate it with having a formatting context tree). Move formattingContextRoot impl under FormattingContext (NDEBUG only). * Source/WebCore/layout/FormattingState.cpp: (WebCore::Layout::FormattingState::boxGeometry): * Source/WebCore/layout/FormattingState.h: (WebCore::Layout::FormattingState::setIntrinsicWidthConstraintsForBox): (WebCore::Layout::FormattingState::intrinsicWidthConstraintsForBox const): * Source/WebCore/layout/LayoutState.cpp: (WebCore::Layout::LayoutState::ensureInlineFormattingState): * Source/WebCore/layout/Verification.cpp: (WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded): * Source/WebCore/layout/formattingContexts/FormattingContext.cpp: (WebCore::Layout::FormattingContext::geometryForBox const): (WebCore::Layout::FormattingContext::collectOutOfFlowDescendantsIfNeeded): (WebCore::Layout::FormattingContext::formattingContextRoot): (WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const): * Source/WebCore/layout/formattingContexts/FormattingContext.h: * Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp: (WebCore::Layout::FormattingGeometry::complicatedCases const): * Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp: (WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider): * Source/WebCore/layout/formattingContexts/table/TableFormattingQuirks.cpp: (WebCore::Layout::TableFormattingQuirks::heightValueOfNearestContainingBlockWithFixedHeight const): * Source/WebCore/layout/layouttree/LayoutBox.cpp: (WebCore::Layout::Box::formattingContextRoot const): Deleted. * Source/WebCore/layout/layouttree/LayoutBox.h: * Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h: (WebCore::Layout::containingBlockChainWithinFormattingContext): Canonical link: https://commits.webkit.org/254662@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5cc2ef: Make MessagePort's close() set [[Detached]]
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5cc2efcf871d0bb2bfe202005f295f3537617e69 https://github.com/WebKit/WebKit/commit/5cc2efcf871d0bb2bfe202005f295f3537617e69 Author: Chris Dumez Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/fast/events/message-port-clone-expected.txt M LayoutTests/fast/events/message-port-clone.html M LayoutTests/imported/w3c/web-platform-tests/webmessaging/message-channels/close.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webmessaging/message-channels/close.any.worker-expected.txt M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/dom/MessageChannel.cpp M Source/WebCore/dom/MessagePort.cpp M Source/WebCore/dom/MessagePort.h Log Message: --- Make MessagePort's close() set [[Detached]] https://bugs.webkit.org/show_bug.cgi?id=185078 Reviewed by Brent Fulgham. Throw a DataCloneError when trying to serialize a MessagePort that has been detached / closed: - https://github.com/whatwg/html/pull/3584 This aligns our behavior with Gecko and the HTML specification. * LayoutTests/imported/w3c/web-platform-tests/webmessaging/message-channels/close.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webmessaging/message-channels/close.any.worker-expected.txt: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::create): * Source/WebCore/dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel): * Source/WebCore/dom/MessagePort.cpp: (WebCore::MessagePort::close): (WebCore::MessagePort::dispatchEvent): (WebCore::MessagePort::virtualHasPendingActivity const): * Source/WebCore/dom/MessagePort.h: Canonical link: https://commits.webkit.org/254661@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8cdd7d: Do not launch network process for sending WebCache...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cdd7d631bd4af28ac1135be960b5554f45419f2 https://github.com/WebKit/WebKit/commit/8cdd7d631bd4af28ac1135be960b5554f45419f2 Author: Sihui Liu Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h M Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.cpp M Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.h M Source/WebKit/WebProcess/WebProcess.cpp Log Message: --- Do not launch network process for sending WebCacheStorageConnection::reference and WebCacheStorageConnection::dereference https://bugs.webkit.org/show_bug.cgi?id=245370 Reviewed by Youenn Fablet. The newly launched network process will have no information about cache identifiers used in previous network process, so there is no point sending these messages. * Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp: (WebKit::WebCacheStorageConnection::open): (WebKit::WebCacheStorageConnection::reference): (WebKit::WebCacheStorageConnection::dereference): (WebKit::WebCacheStorageConnection::networkProcessConnectionClosed): * Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h: * Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.cpp: (WebKit::WebCacheStorageProvider::networkProcessConnectionClosed): * Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.h: * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::networkProcessConnectionClosed): Canonical link: https://commits.webkit.org/254660@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 195c7f: [JSC] Accelerate baseline String#replace performance
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 195c7f139a84e0af36a5aaea6b61d7470b95a3b5 https://github.com/WebKit/WebKit/commit/195c7f139a84e0af36a5aaea6b61d7470b95a3b5 Author: Yusuke Suzuki Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGDoesGC.cpp M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/dfg/DFGNode.h M Source/JavaScriptCore/dfg/DFGNodeType.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp M Source/JavaScriptCore/dfg/DFGSafeToExecute.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp M Source/JavaScriptCore/ftl/FTLCapabilities.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/interpreter/CachedCall.h M Source/JavaScriptCore/interpreter/CallFrameClosure.h M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/interpreter/Interpreter.h M Source/JavaScriptCore/interpreter/InterpreterInlines.h M Source/JavaScriptCore/runtime/Intrinsic.cpp M Source/JavaScriptCore/runtime/Intrinsic.h M Source/JavaScriptCore/runtime/StringPrototype.cpp M Source/JavaScriptCore/runtime/StringPrototypeInlines.h Log Message: --- [JSC] Accelerate baseline String#replace performance https://bugs.webkit.org/show_bug.cgi?id=245349 Reviewed by Ross Kirsling. We found that C++ runtime String#replace implementation is too generic and doing various inefficient things. This patch unifies the implementation with DFG operations for the fast path so that we do very simple and fast operations for String#replace(String, String) case even in non DFG. It shows consistent improvement in VanillaXXX in Speedometer2.1 on Intel machines. With --useDFGJIT=0, we see 35% improvement. string-replace-benchmark 219.2726+-0.5822 ^ 162.1922+-0.5799^ definitely 1.3519x faster * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleIntrinsicCall): * Source/JavaScriptCore/dfg/DFGClobberize.h: (JSC::DFG::clobberize): * Source/JavaScriptCore/dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): * Source/JavaScriptCore/dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * Source/JavaScriptCore/dfg/DFGNode.h: (JSC::DFG::Node::hasHeapPrediction): * Source/JavaScriptCore/dfg/DFGNodeType.h: * Source/JavaScriptCore/dfg/DFGOperations.cpp: (JSC::DFG::JSC_DEFINE_JIT_OPERATION): (JSC::DFG::stringReplaceStringString): Deleted. * Source/JavaScriptCore/dfg/DFGOperations.h: * Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp: * Source/JavaScriptCore/dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp: (JSC::DFG::StrengthReductionPhase::handleNode): * Source/JavaScriptCore/ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileNode): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): * Source/JavaScriptCore/interpreter/CachedCall.h: (JSC::CachedCall::CachedCall): (JSC::CachedCall::call): * Source/JavaScriptCore/interpreter/CallFrameClosure.h: * Source/JavaScriptCore/interpreter/Interpreter.cpp: (JSC::Interpreter::prepareForRepeatCall): * Source/JavaScriptCore/interpreter/Interpreter.h: * Source/JavaScriptCore/interpreter/InterpreterInlines.h: (JSC::Interpreter::execute): * Source/JavaScriptCore/runtime/Intrinsic.cpp: (JSC::intrinsicName): * Source/JavaScriptCore/runtime/Intrinsic.h: * Source/JavaScriptCore/runtime/StringPrototype.cpp: (JSC::StringPrototype::finishCreation): (JSC::jsSpliceSubstrings): (JSC::removeUsingRegExpSearch): (JSC::replaceUsingRegExpSearch): (JSC::JSC_DEFINE_JIT_OPERATION): (JSC::replace): (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::StringRange::StringRange): Deleted. (JSC::jsSpliceSubstringsWithSeparators): Deleted. (JSC::replaceUsingStringSearch): Deleted. * Source/JavaScriptCore/runtime/StringPrototypeInlines.h: (JSC::jsSpliceSubstringsWithSeparators): (JSC::stringReplaceStringString): (JSC::replaceUsingStringSearch):
[webkit-changes] [WebKit/WebKit] b2518c: Error: redefinition of 'gigacageEnabledForProcess'...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2518c25355d2196ed1335a289ec76258f3796cf https://github.com/WebKit/WebKit/commit/b2518c25355d2196ed1335a289ec76258f3796cf Author: Ben Nham Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/bmalloc/bmalloc/ProcessCheck.mm Log Message: --- Error: redefinition of 'gigacageEnabledForProcess' in JSCOnly MacOS Ports https://bugs.webkit.org/show_bug.cgi?id=245295 rdar://problem/100133724 Reviewed by Mark Lam. The BPLATFORM guard around `gigacageEnabledForProcess()` in ProcessCheck.h does not match the guard in ProcessCheck.mm. This breaks the JSCOnly variant of the bmalloc build on Darwin since the JSCOnly variant doesn't define a BPLATFORM macro. Fix this by making the guards match. * Source/bmalloc/bmalloc/ProcessCheck.mm: Canonical link: https://commits.webkit.org/254658@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f58ef3: Clicking links doesn't work when using mouse on iPad
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f58ef38d48f42f5d7723691cb090823908ff5f9f https://github.com/WebKit/WebKit/commit/f58ef38d48f42f5d7723691cb090823908ff5f9f Author: Richard Robinson Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- Clicking links doesn't work when using mouse on iPad https://bugs.webkit.org/show_bug.cgi?id=245376 rdar://100039854 Reviewed by Tim Horton. Our implementation of `gestureRecognizer:shouldReceiveTouch:` was preventing the touches from making it to the synthetic tap gesture, so this PR fixes it. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView gestureRecognizer:shouldReceiveTouch:]): Canonical link: https://commits.webkit.org/254657@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b87209: Percentage-based translations don't work with SVG ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b87209ee89e8e4595ec4f5409906b368310321cd https://github.com/WebKit/WebKit/commit/b87209ee89e8e4595ec4f5409906b368310321cd Author: Tim Nguyen Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/gtk/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt M LayoutTests/platform/gtk/svg/batik/text/smallFonts-expected.txt M LayoutTests/platform/gtk/svg/batik/text/textFeatures-expected.txt M LayoutTests/platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt M LayoutTests/platform/ios/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt M LayoutTests/platform/ios/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt M LayoutTests/platform/ios/svg/batik/text/textFeatures-expected.txt M LayoutTests/platform/ios/svg/text/append-text-node-to-tspan-expected.txt M LayoutTests/platform/ios/svg/text/modify-text-node-in-tspan-expected.txt M LayoutTests/platform/ios/svg/text/remove-text-node-from-tspan-expected.txt M LayoutTests/platform/ios/svg/text/scaled-font-expected.txt M LayoutTests/platform/ios/svg/text/scaling-font-with-geometric-precision-expected.txt M LayoutTests/platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt M LayoutTests/platform/mac/svg/batik/text/smallFonts-expected.txt M LayoutTests/platform/mac/svg/batik/text/textFeatures-expected.txt M LayoutTests/platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt M Source/WebCore/rendering/svg/RenderSVGText.cpp M Source/WebCore/svg/SVGTextElement.cpp M Source/WebCore/svg/SVGTextElement.h Log Message: --- Percentage-based translations don't work with SVG https://bugs.webkit.org/show_bug.cgi?id=245122 Reviewed by Myles C. Maxfield. The two main issues are: - Stale SVGTextElement::animatedLocalTransform() function: Historically, all SVG elements have had the same animatedLocalTransform function, see: https://github.com/WebKit/WebKit/commit/f8cc29f9d2d96f5761a8aab9f6bd31afb0edf0a8 This looks like an artifact of when SVGTextElement did not inherit from the common SVGGraphicsElement class, where we had to add the same function twice. Removing this code puts it in-line with SVGGraphicsElement::animatedLocalTransform() which does take in account the reference box rect (for percentage based transforms) and transform-origin. - We also need to compute transform at the end of RenderSVGText::layout, to avoid computing with the wrong bounds (which may happen if the font hasn't loaded yet). Rebaseline tests resulting from these changes (mainly minor differences in dimensions that match other browsers). Test: imported/w3c/web-platform-tests/css/css-transforms/transform-box/view-box-mutation-002.html * LayoutTests/TestExpectations: * LayoutTests/platform/gtk/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: * LayoutTests/platform/gtk/svg/batik/text/smallFonts-expected.txt: * LayoutTests/platform/gtk/svg/batik/text/textFeatures-expected.txt: * LayoutTests/platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: * LayoutTests/platform/ios/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: * LayoutTests/platform/ios/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: * LayoutTests/platform/ios/svg/batik/text/textFeatures-expected.txt: * LayoutTests/platform/ios/svg/text/append-text-node-to-tspan-expected.txt: * LayoutTests/platform/ios/svg/text/modify-text-node-in-tspan-expected.txt: * LayoutTests/platform/ios/svg/text/remove-text-node-from-tspan-expected.txt: * LayoutTests/platform/ios/svg/text/scaled-font-expected.txt: * LayoutTests/platform/ios/svg/text/scaling-font-with-geometric-precision-expected.txt: * LayoutTests/platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: * LayoutTests/platform/mac/svg/batik/text/smallFonts-expected.txt: * LayoutTests/platform/mac/svg/batik/text/textFeatures-expected.txt: * LayoutTests/platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: * Source/WebCore/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::animatedLocalTransform const): Deleted. * Source/WebCore/svg/SVGTextElement.h: * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Canonical link: https://commits.webkit.org/254656@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 662e9f: [JSC] HeapBigInt CompareStrictEq should call use a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 662e9f67690eac1d94556207cea3186159996337 https://github.com/WebKit/WebKit/commit/662e9f67690eac1d94556207cea3186159996337 Author: Yusuke Suzuki Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: A JSTests/stress/osr-exit-check-node-liveness-heap-bigint-strict-eq.js M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp Log Message: --- [JSC] HeapBigInt CompareStrictEq should call use after speculation checks https://bugs.webkit.org/show_bug.cgi?id=233682 rdar://86192953 Reviewed by Saam Barati. Because we call use() before speculation check, in OSR exit, these nodes may be counted as dead, which can make OSR exit recovering for these node's loc to undefined. We should call `use()` after possible OSR exit (in this case, speculation). * JSTests/stress/osr-exit-check-node-liveness-heap-bigint-strict-eq.js: Added. (shouldBe): (main.v29): (main): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: Canonical link: https://commits.webkit.org/254655@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5bda1c: [WGSL] Port WGSLUnitTests to TestWebKitAPI
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5bda1cab2367440c3b9bb734234b75d876d3e6c1 https://github.com/WebKit/WebKit/commit/5bda1cab2367440c3b9bb734234b75d876d3e6c1 Author: Dan Glastonbury Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Tools/Scripts/run-api-tests M Tools/Scripts/webkitpy/port/darwin.py A Tools/TestWebKitAPI/Configurations/TestWGSL.xcconfig M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWGSL.xcscheme A Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp A Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp M Tools/TestWebKitAPI/ios/mainIOS.mm M Tools/TestWebKitAPI/mac/mainMac.mm Log Message: --- [WGSL] Port WGSLUnitTests to TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=245061 rdar://problem/99808942 Reviewed by Elliott Williams. So we can run the tests on EWS, port the XCTest-based WGSLUnitTests to gtest-based standalone executable TestWGSL. This was a straight-forward change of ObjC interfaces to C++ classes and renaming of testing macros. * Tools/Scripts/run-api-tests: * Tools/Scripts/webkitpy/port/darwin.py: (DarwinPort): * Tools/TestWebKitAPI/Configurations/TestWGSL.xcconfig: Added. * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWGSL.xcscheme: Added. * Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp: Added. (TestWebKitAPI::checkSingleToken): (TestWebKitAPI::checkSingleLiteral): (TestWebKitAPI::checkNextTokenIs): (TestWebKitAPI::checkNextTokenIsIdentifier): (TestWebKitAPI::checkNextTokenIsLiteral): (TestWebKitAPI::checkNextTokensAreBuiltinAttr): (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp: Added. (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/mac/mainMac.mm: (main): Canonical link: https://commits.webkit.org/254654@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2a641: [WPE][GTK] Introduce WPE 2.0 API version, and ENAB...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2a6414f90b356961962b1e57ad3a83405d2a4a2 https://github.com/WebKit/WebKit/commit/b2a6414f90b356961962b1e57ad3a83405d2a4a2 Author: Michael Catanzaro Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [WPE][GTK] Introduce WPE 2.0 API version, and ENABLE_2022_GLIB_API flag to indicate either GTK 4 or WPE 2.0 https://bugs.webkit.org/show_bug.cgi?id=244641 Reviewed by Adrian Perez de Castro. Since there are few users of the WPE 1.1 API, and we don't need to keep it around, WPE 2.0 will simply replace WPE 1.1. In contrast, the WPE 1.0 API is still required until Igalia is ready to phase out libsoup 2. With a new API version, I will be able to start breaking things in subsequent commits. I've also fixed some misleading code in OptionsWPE.cmake where option dependencies were located under an unrelated comment, intermixed with option definitions. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/254653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 93784d: Misc compiler warnings, mid September 2022 edition
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93784da988d5ca78d1a9f0fa853ca20c07fa9a5b https://github.com/WebKit/WebKit/commit/93784da988d5ca78d1a9f0fa853ca20c07fa9a5b Author: Michael Catanzaro Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/ThirdParty/ANGLE/CMakeLists.txt M Source/WebCore/css/CSSComputedStyleDeclaration.cpp Log Message: --- Misc compiler warnings, mid September 2022 edition https://bugs.webkit.org/show_bug.cgi?id=245371 Reviewed by Don Olmstead. * Source/ThirdParty/ANGLE/CMakeLists.txt: Upstream isn't using this warning, so suppress it. This particular case is harmless anyway. * Source/WebCore/css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForAnimationTimingFunction): Canonical link: https://commits.webkit.org/254652@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e9d74: Crash under WebNotificationManager::didUpdateNotif...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e9d745e00cd70f473e441c947cf06cd3ca0f572 https://github.com/WebKit/WebKit/commit/2e9d745e00cd70f473e441c947cf06cd3ca0f572 Author: Chris Dumez Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp Log Message: --- Crash under WebNotificationManager::didUpdateNotificationDecision() on the bots https://bugs.webkit.org/show_bug.cgi?id=245380 Reviewed by Ben Nham. We recently started calling `testRunner.grantNotificationPermission(self.origin)` in testharnessreport.js in 254620@main. This means that in some cases, we might now call this function with a null/opaque origin. This would cause crashes in WebNotificationManager::didUpdateNotificationDecision() when trying to add the null origin to the HashMap. To address the crashes, we now ignore null origins in WebNotificationManagerProxy::providerDidUpdateNotificationPolicy(). * Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp: (WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy): Canonical link: https://commits.webkit.org/254651@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d22295: [WGSL] Implement parsing for array types and calla...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d22295da2d69385297114b3985dbc255bdacadab
https://github.com/WebKit/WebKit/commit/d22295da2d69385297114b3985dbc255bdacadab
Author: Dan Glastonbury
Date: 2022-09-19 (Mon, 19 Sep 2022)
Changed paths:
M Source/WebGPU/WGSL/AST/TypeDecl.h
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
M Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm
Log Message:
---
[WGSL] Implement parsing for array types and callable array constructors.
https://bugs.webkit.org/show_bug.cgi?id=244792
rdar://99557526
Reviewed by Myles Maxfield.
* Source/WebGPU/WGSL/AST/TypeDecl.h:
(WGSL::AST::TypeDecl::isArray const):
Add kind and predicate for array types.
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::parseTypeDecl):
Begin parsing of an array type declaration. Defers to parseArrayType to do
actual parsing.
(WGSL::Parser::parseArrayType):
Parse an array type consisting of 'array' ('<' TypeDecl (','
AdditionExpression)? '>')?
This is different to the WGSL spec as this recursive descent parser can't handle
the grammar factored as AdditiveExpression | BitwiseExpression. Making the
element TypeDecl optional allows the code to parse array in
CallableExpression. Validity of array TypeDecls that require element TypeDecl
will be handled when type-checking the AST.
(WGSL::Parser::parsePrimaryExpression):
Accept array type as a CallableExpression.
* Source/WebGPU/WGSL/ParserPrivate.h:
Add prototype for parsing array type
* Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm:
- Test the parsing of a WebGPU example triangle vertex & fragment shader that
contains ArrayType, ArrayAccess and CallableExpression of array.
- Add some macros to help alleviate the repeative AST matching patterns.
Canonical link: https://commits.webkit.org/254650@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 54fc90: Skip invalid SVG+currentcolor tests.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 54fc90ab2a7b66e145c80154b15aec03a0c25761 https://github.com/WebKit/WebKit/commit/54fc90ab2a7b66e145c80154b15aec03a0c25761 Author: Matthieu Dubet Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/TestExpectations Log Message: --- Skip invalid SVG+currentcolor tests. https://bugs.webkit.org/show_bug.cgi?id=245400 Reviewed by Tim Nguyen. With SVG 2 and Color level 5, it should define a rectangle fill in red (not lime). This is the behaviour of both Gecko and Blink. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/254649@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4ee19f: [WebAuthn] Turn off optimization for some other fi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ee19f3de0a78dc74ccb4e781b315fd7e61b8498 https://github.com/WebKit/WebKit/commit/4ee19f3de0a78dc74ccb4e781b315fd7e61b8498 Author: J Pascoe Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebKit/Sources.txt M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- [WebAuthn] Turn off optimization for some other files to workaround LTO bug https://bugs.webkit.org/show_bug.cgi?id=245365 rdar://99653067 Reviewed by Elliott Williams. LTO optimization on these files ends up causing issues in some configurations, so this patch disables optimization on those files until that is resolved. None of them are hot paths. * Source/WebKit/Sources.txt: * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/254648@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4bc684: Factorize border RenderTreeAsText code.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4bc684c9be498e94df5f14b8876b8e0b3403aafe https://github.com/WebKit/WebKit/commit/4bc684c9be498e94df5f14b8876b8e0b3403aafe Author: Matthieu Dubet Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebCore/rendering/RenderTreeAsText.cpp Log Message: --- Factorize border RenderTreeAsText code. https://bugs.webkit.org/show_bug.cgi?id=245372 Reviewed by Tim Nguyen. * Source/WebCore/rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): Canonical link: https://commits.webkit.org/254647@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0bfbd6: Web Inspector: followup fixes after 254636@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0bfbd6dc157bcb2aeb618c2f39762cb93549ac0e https://github.com/WebKit/WebKit/commit/0bfbd6dc157bcb2aeb618c2f39762cb93549ac0e Author: Devin Rousso Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Base/Utilities.js M Source/WebInspectorUI/UserInterface/Models/ConsoleSnippet.js M Source/WebInspectorUI/UserInterface/Views/ConsoleSnippetTreeElement.js M Source/WebInspectorUI/UserInterface/Views/LogContentView.js M Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js Log Message: --- Web Inspector: followup fixes after 254636@main https://bugs.webkit.org/show_bug.cgi?id=245385 Reviewed by Patrick Angle. * Source/WebInspectorUI/UserInterface/Base/Utilities.js: (Set.prototype.some): Fixed indentation. * Source/WebInspectorUI/UserInterface/Models/ConsoleSnippet.js: (WI.ConsoleSnippet.prototype.run): Removed extra newline. * Source/WebInspectorUI/UserInterface/Views/ConsoleSnippetTreeElement.js: (WI.ConsoleSnippetTreeElement.prototype.onenter): Added. (WI.ConsoleSnippetTreeElement.prototype.populateContextMenu): Added. Support "Enter" to run and add a contextmenu item. * Source/WebInspectorUI/UserInterface/Views/LogContentView.js: (WI.LogContentView): (WI.LogContentView.prototype._handleSnippetsNavigationItemContextMenu): * Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js: (WI.SourcesNavigationSidebarPanel.prototype._populateCreateResourceContextMenu): * Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js: Fixed `"..."` in UI strings to be `"\u2026"`. Canonical link: https://commits.webkit.org/254646@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cfb088: Use dynamicDowncast() in RenderBox::offsetFromCont...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cfb088fd56631a371a89d06697cfba363583d33d https://github.com/WebKit/WebKit/commit/cfb088fd56631a371a89d06697cfba363583d33d Author: Nikolas Zimmermann Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebCore/rendering/RenderBox.cpp Log Message: --- Use dynamicDowncast() in RenderBox::offsetFromContainer() https://bugs.webkit.org/show_bug.cgi?id=245362 Reviewed by Tim Nguyen. * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer const): Canonical link: https://commits.webkit.org/254644@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c004a: Remove quirk: Floating list-items are display:block
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c004a6b5b1ab0e2b920b1b0df0702f73fd76dc7 https://github.com/WebKit/WebKit/commit/9c004a6b5b1ab0e2b920b1b0df0702f73fd76dc7 Author: Ahmad Saleem Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: A LayoutTests/fast/css/quirks-mode-ignore-list-item-expected.txt A LayoutTests/fast/css/quirks-mode-ignore-list-item.html M LayoutTests/platform/glib/fast/lists/001-expected.txt M LayoutTests/platform/gtk/fast/lists/001-expected.png M LayoutTests/platform/gtk/fast/lists/001-vertical-expected.png M LayoutTests/platform/ios/fast/lists/001-expected.txt M LayoutTests/platform/ios/fast/lists/001-vertical-expected.txt M LayoutTests/platform/mac/fast/lists/001-expected.png M LayoutTests/platform/mac/fast/lists/001-expected.txt M LayoutTests/platform/mac/fast/lists/001-vertical-expected.png M LayoutTests/platform/mac/fast/lists/001-vertical-expected.txt M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- Remove quirk: Floating list-items are display:block Remove quirk: Floating list-items are display:block https://bugs.webkit.org/show_bug.cgi?id=245336 Reviewed by Alan Bujtas. This patch remove quirk mode which was added to be compatible with Internet Explorer while it was not available in EdgeHTML and was never added by Firefox / Gecko. This was also later dropped by Chrome / Blink. Partial Merge - https://chromium.googlesource.com/chromium/src.git/+/06ae6f0489cf8efa87e7190ab90940b62a998c8b Currently in quirks mode, and element with float set and display set to list-item is forced to be display:block. This current action is not supported in quirks spec and is inconsistent with FF/Edge. This patch fixes that behavior and allows these elements to retain their display value even in quirks mode. * Source/WebCore/style/StyleAdjuster.cpp: (equivalentBlockDisplay): Removed "document" (DisplayType equivalentBlockDisplay): Remove WinIE quirks for DisplayType::ListItem (Adjuster:adjust): Removed "m_document" * LayoutTests/fast/css/quirks-mode-ignore-list-item.html: Added Test Case * LayoutTests/fast/css/quirks-mode-ignore-list-item-expected.txt: Add Test Case Expectations * LayoutTests/platform/glib/fast/lists/001-expected.txt: Updated Test Expectations * LayoutTests/platform/ios/fast/lists/001-expected.txt: Updated Test Expectations * LayoutTests/platform/ios/fast/lists/001-vertical-expected.txt: Updated Test Expectations * LayoutTests/platform/gtk/fast/lists/001-expected.png: Updated Test Expectations * LayoutTests/platform/gtk/fast/lists/001-vertical-expected.png: Updated Test Expectations * LayoutTests/platform/mac/fast/lists/001-expected.png: Updated Test Expectations * LayoutTests/platform/mac/fast/lists/001-expected.txt: Updated Test Expectations * LayoutTests/platform/mac/fast/lists/001-vertical-expected.png: Updated Test Expectations * LayoutTests/platform/mac/fast/lists/001-vertical-expected.txt: Updated Test Expectations Canonical link: https://commits.webkit.org/254643@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45eea0: [WebIDL] Greatly simplify reporting an OOM error i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45eea066f649f61bcf1e380097b34986dbdda9a2 https://github.com/WebKit/WebKit/commit/45eea066f649f61bcf1e380097b34986dbdda9a2 Author: Alexey Shvayka Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebCore/bindings/js/ScheduledAction.cpp Log Message: --- [WebIDL] Greatly simplify reporting an OOM error in ScheduledAction::executeFunctionInContext() https://bugs.webkit.org/show_bug.cgi?id=245367 Reviewed by Mark Lam. This change leverages JSC::Exception::create() to avoid throwing and then catching an OOM error just to wrap it into a JSC::Exception. * Source/WebCore/bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): Canonical link: https://commits.webkit.org/254642@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e08b53: Re-import css/css-color WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e08b533e57f343be032c13ff26217db4f0cf7520 https://github.com/WebKit/WebKit/commit/e08b533e57f343be032c13ff26217db4f0cf7520 Author: Sam Weinig Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-color/009900-image-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/009900-tagged-image-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/a98rgb-003-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/a98rgb-004-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/color-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/color-interpolation.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/opacity-animation-ending-correctly-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/opacity-animation-ending-correctly-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/opacity-animation-ending-correctly-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/opacity-animation-ending-correctly-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/opacity-animation-ending-correctly-002.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/css-color/at-color-profile-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/at-color-profile-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-hsl-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-hsl-002-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-hsl-003-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-hsl-004-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-rgb-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-rgb-002-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-rgb-003-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/blacksquare-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/blacktext-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/border-color-ref.xht A LayoutTests/imported/w3c/web-platform-tests/css/css-color/canvas-change-opacity-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/canvas-change-opacity.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-function-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-function-parsing.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-basic-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-002-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-non-srgb-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-percents-01-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-resolving-hwb-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-resolving-hwb.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/composited-filters-under-opacity-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-003-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-003-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-003.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-003-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-003.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-004-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-0
[webkit-changes] [WebKit/WebKit] c5a722: Entering a To: address moves the viewpoint to the ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5a7221120cea780897f84fff076b7d98b818b5a https://github.com/WebKit/WebKit/commit/c5a7221120cea780897f84fff076b7d98b818b5a Author: Richard Robinson Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreScrollPosition.mm Log Message: --- Entering a To: address moves the viewpoint to the bottom right corner of the email https://bugs.webkit.org/show_bug.cgi?id=245297 rdar://96703879 Reviewed by Tim Horton. On iPad in the Mail app, when composing a message whose contents are taller than the viewport size, and when the compose window is narrow enough such that the contact picker appears as a modal when entering a contact in the `To:` field, dismissing the contact picker causes the message to erroneously scroll to the bottom right of the message. This is because in this case, there is a large top inset on the web view's scroll view. This causes the UIProcess to erroneously create a `CGRectNull` and sends it to the web process in a visible content rect update. Because a `CGRectNull` has an origin of `(INT_MAX, INT_MAX)`, the web view attempts to scroll to that position. This PR fixes this by using `FloatRect`s intersection behavior instead of using `CGRectIntersection`, so that the resulting rect's origin stays the same instead of becoming `CGRectNull` in the case the two rects don't intersect. A change also had to be made to `-[WKWebView _scrollToContentScrollPosition:scrollOrigin:animated:]` so that the view scrolls to its original position with the inset, instead of `0`. * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _scrollToContentScrollPosition:scrollOrigin:animated:]): (-[WKWebView _updateVisibleContentRects]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreScrollPosition.mm: (-[RestoreScrollPositionWithLargeContentInsetWebView safeAreaInsets]): (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/254640@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc8155: [WebIDL] Default toJSON() method should create res...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc81559d3d3269a2f28477738c3ec1c13dd5e8e8 https://github.com/WebKit/WebKit/commit/cc81559d3d3269a2f28477738c3ec1c13dd5e8e8 Author: Alexey Shvayka Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/default-toJSON-cross-realm-expected.txt A LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/default-toJSON-cross-realm.html M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp Log Message: --- [WebIDL] Default toJSON() method should create result object in its realm https://bugs.webkit.org/show_bug.cgi?id=244939 Reviewed by Sam Weinig, Yusuke Suzuki, and Darin Adler. Per ECMA-262 [1], %Object.prototype% notation points to current realm, which is the realm of toJSON() function [2], and not the relevant one. Aligns WebKit with Blink and Gecko. [1] https://tc39.es/ecma262/#sec-well-known-intrinsic-objects (paragraph 2) [2] https://webidl.spec.whatwg.org/#default-tojson-steps (step 4) * LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/default-toJSON-cross-realm-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/default-toJSON-cross-realm.html: Added. * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GenerateDefaultToJSONOperationDefinition): * Source/WebCore/bindings/scripts/test/JS/*: Updated. Canonical link: https://commits.webkit.org/254639@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be5955: Move BorderValue implementation to .cpp file.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be59551cc253a411e3bf490b91a2041cba0a4ecf https://github.com/WebKit/WebKit/commit/be59551cc253a411e3bf490b91a2041cba0a4ecf Author: Matthieu Dubet Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebCore/Sources.txt A Source/WebCore/rendering/style/BorderValue.cpp M Source/WebCore/rendering/style/BorderValue.h Log Message: --- Move BorderValue implementation to .cpp file. https://bugs.webkit.org/show_bug.cgi?id=245366 rdar://problem/100129199 Reviewed by Tim Nguyen. * Source/WebCore/Sources.txt: * Source/WebCore/rendering/style/BorderValue.cpp: Added. (WebCore::BorderValue::BorderValue): (WebCore::BorderValue::isTransparent const): (WebCore::isVisible const): * Source/WebCore/rendering/style/BorderValue.h: (WebCore::BorderValue::BorderValue): Deleted. (WebCore::BorderValue::isTransparent const): Deleted. (WebCore::BorderValue::isVisible const): Deleted. Canonical link: https://commits.webkit.org/254638@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 999620: Versioning.
Branch: refs/heads/safari-7615.1.7-branch Home: https://github.com/WebKit/WebKit Commit: 9996206a541ca6546035a4d3e1e65a2c63d44ae1 https://github.com/WebKit/WebKit/commit/9996206a541ca6546035a4d3e1e65a2c63d44ae1 Author: Alan Coon Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.7 Canonical link: https://commits.webkit.org/254623.1@safari-7615.1.7-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc5033: Web Inspector: Layout sidebar in Elements tab lack...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc5033fed4cfe5d60ce3a3bc0a9d48edb68d574a https://github.com/WebKit/WebKit/commit/bc5033fed4cfe5d60ce3a3bc0a9d48edb68d574a Author: Devin Rousso Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Main.html M Source/WebInspectorUI/UserInterface/Views/BlackboxSettingsView.css R Source/WebInspectorUI/UserInterface/Views/CSSFlexNodeOverlayListSection.js R Source/WebInspectorUI/UserInterface/Views/CSSGridNodeOverlayListSection.js M Source/WebInspectorUI/UserInterface/Views/DetailsSection.css M Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.css M Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js M Source/WebInspectorUI/UserInterface/Views/NodeOverlayListSection.css M Source/WebInspectorUI/UserInterface/Views/NodeOverlayListSection.js M Source/WebInspectorUI/UserInterface/Views/SettingsGroup.js M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css M Source/WebInspectorUI/UserInterface/Views/SettingsView.js Log Message: --- Web Inspector: Layout sidebar in Elements tab lacks an discernable visual hierarchy https://bugs.webkit.org/show_bug.cgi?id=239525 Reviewed by Patrick Angle. * UserInterface/Views/LayoutDetailsSidebarPanel.js: (WI.LayoutDetailsSidebarPanel.prototype.initialLayout): (WI.LayoutDetailsSidebarPanel.prototype.layout): * UserInterface/Views/LayoutDetailsSidebarPanel.css: (.details-section:is(.layout-css-flexbox, .layout-css-grid) > .content > .group > .row): Added. (.details-section:is(.layout-css-flexbox, .layout-css-grid) > .content > .group > .row.empty): Added. (.details-section:is(.layout-css-flexbox, .layout-css-grid) > .content .settings-group > .title): Added. (.details-section:is(.layout-css-flexbox, .layout-css-grid) > .content .setting-editor input[type="checkbox"]): Added. (.node-overlay-list-section > h2 > .options): Added. (.node-overlay-list-section:not(:hover) > h2 > .options): Added. Move the UI for each overlay's settings to be in the panel, not in the `WI.NodeOverlayListSection`. * UserInterface/Views/NodeOverlayListSection.js: (WI.NodeOverlayListSection): (WI.NodeOverlayListSection.prototype.initialLayout): (WI.NodeOverlayListSection.prototype.layout): (WI.NodeOverlayListSection.prototype._handleOverlayStateChanged): (WI.NodeOverlayListSection.prototype.get sectionLabel): Deleted. (WI.NodeOverlayListSection.prototype._handleToggleAllCheckboxChanged): Deleted. (WI.NodeOverlayListSection.prototype._updateToggleAllCheckbox): Deleted. * UserInterface/Views/NodeOverlayListSection.css: (.node-overlay-list-section > h2): Added. (.node-overlay-list-section .node-overlay-list-item-container input[type="checkbox"]): Added. (.node-overlay-list-section): Deleted. (.node-overlay-list-section > .heading,): Deleted. (.node-overlay-list-section > .heading > label > .toggle-all): Deleted. (.node-overlay-list-section :is(.setting-editor, .node-overlay-list-item-container, .heading) input[type="checkbox"]): Deleted. * UserInterface/Views/CSSFlexNodeOverlayListSection.js: Removed. * UserInterface/Views/CSSGridNodeOverlayListSection.js: Removed. Remove the subclasses now that the only differentiating factor between them is the label. Also remove the checkbox in the heading that enables/disables all overlays because it's visually odd (i.e. the header now lines up with it's content, instead of being less indented) and because there's likely little use case in enabling *all* overlays at once. * UserInterface/Views/SettingsGroup.js: (WI.SettingsGroup): * UserInterface/Views/SettingsView.js: (WI.SettingsView): (WI.SettingsView.prototype.addCenteredContainer): * UserInterface/Views/SettingsTabContentView.css: (.content-view.tab.settings > .settings-view > :is(.settings-group, .container)): Renamed from `.content-view.tab.settings > .settings-view > .container`. (.content-view.tab.settings > .settings-view > .container.centered): Renamed from `.content-view.tab.settings > .settings-view > .container-centered`. (.content-view.tab.settings > .settings-view > .settings-group > .title): Renamed from `.content-view.tab.settings > .settings-view > .container > .title`. (.content-view.tab.settings > .settings-view > .settings-group > .editor-group): Renamed from `.content-view.tab.settings > .settings-view > .container > .editor-group`. (.content-view.tab.settings > .settings-view > .settings-group > .editor-group > .setting-editor): Renamed from `.content-view.tab.settings > .settings-view > .container > .editor-group > .setting-editor`. (.content-view.tab.settings > .settings-view > .settings-group > .editor-group > .setting-editor:first-child > *): Renamed from `.content-view.tab.settings > .settings-view > .container > .editor-group > .setting-editor:first-child > *
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7615.1.7-branch Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23c03d: Web Inspector: add support for console snippets
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23c03d7c6c3a03eca6396e8b563ec86f880a0dff https://github.com/WebKit/WebKit/commit/23c03d7c6c3a03eca6396e8b563ec86f880a0dff Author: Devin Rousso Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/inspector/unit-tests/set-utilities-expected.txt M LayoutTests/inspector/unit-tests/set-utilities.html M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Base/ObjectStore.js M Source/WebInspectorUI/UserInterface/Base/Utilities.js M Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js M Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js M Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js A Source/WebInspectorUI/UserInterface/Images/Start.svg M Source/WebInspectorUI/UserInterface/Main.html A Source/WebInspectorUI/UserInterface/Models/ConsoleSnippet.js M Source/WebInspectorUI/UserInterface/Test.html M Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js M Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.js M Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js M Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js M Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js M Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.css A Source/WebInspectorUI/UserInterface/Views/ConsoleSnippetTreeElement.css A Source/WebInspectorUI/UserInterface/Views/ConsoleSnippetTreeElement.js M Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js M Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js M Source/WebInspectorUI/UserInterface/Views/InputPopover.js M Source/WebInspectorUI/UserInterface/Views/LogContentView.css M Source/WebInspectorUI/UserInterface/Views/LogContentView.js M Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js M Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js M Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js M Source/WebInspectorUI/UserInterface/Views/QuickConsole.js M Source/WebInspectorUI/UserInterface/Views/ResourceIcons.css M Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js M Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js M Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css M Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js M Source/WebInspectorUI/UserInterface/Views/WebSocketDataGridNode.js M Source/WebInspectorUI/UserInterface/Views/WebSocketResourceTreeElement.js Log Message: --- Web Inspector: add support for console snippets https://bugs.webkit.org/show_bug.cgi?id=245161 Reviewed by Patrick Angle. Console Snippets can be very useful for developers that frequently run the same JS over and over. Previously, the developer would have to either repeatedly type the same thing, use the up arrow to find the JS in the Console history, or even use the pasteboard (likely from another app/file). With Console Snippets, the developer can rely on Web Inspector to organize and maintain the "library" of JS that the developer might want to invoke, as well as having quick ways to actually do so. * Source/WebInspectorUI/UserInterface/Models/ConsoleSnippet.js: Added. (WI.ConsoleSnippet): (WI.ConsoleSnippet.createDefaultWithTitle): (WI.ConsoleSnippet.prototype.get title): (WI.ConsoleSnippet.prototype.run): (WI.ConsoleSnippet.fromJSON): (WI.ConsoleSnippet.prototype.toJSON): * Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js: (WI.ConsoleManager): (WI.ConsoleManager.prototype.get snippets): Added. (WI.ConsoleManager.prototype.addSnippet): Added. (WI.ConsoleManager.prototype.removeSnippet): Added. (WI.ConsoleManager.prototype._handleSnippetContentChanged): Added. * Source/WebInspectorUI/UserInterface/Views/ResourceIcons.css: (:is(.anonymous-script-icon, .resource-icon.resource-type-script.console-snippet) .icon): Renamed from `.anonymous-script-icon .icon`. (@media (prefers-color-scheme: dark) :is(.anonymous-script-icon, .resource-icon.resource-type-script.console-snippet) .icon): Renamed from `@media (prefers-color-scheme: dark) .anonymous-script-icon .icon`. Force Console Snippets to use the JS clipping icon. * Source/WebInspectorUI/UserInterface/Views/ConsoleSnippetTreeElement.js: Added. (WI.ConsoleSnippetTreeElement): (WI.ConsoleSnippetTreeElement.prototype.onattach): (WI.ConsoleSnippetTreeElement.prototype.ondelete): (WI.ConsoleSnippetTreeElement.prototype.onspace): (WI.ConsoleSnippetTreeElement.prototype.canSelectOnMouseDown): (WI.ConsoleSnippetTreeElement.prototype.updateStatus): * Source/WebInspectorUI/UserInterface/Views/ConsoleSnippetTreeElement.css: Added. (.tree-outline .item.console-snippet
[webkit-changes] [WebKit/WebKit] 58854f: [ews-build.webkit.org] Use variable instead of 'or...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58854f9828c478ec3e8e55016349cd639ea77039 https://github.com/WebKit/WebKit/commit/58854f9828c478ec3e8e55016349cd639ea77039 Author: Jonathan Bedard Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews-build.webkit.org] Use variable instead of 'origin' in steps https://bugs.webkit.org/show_bug.cgi?id=242898 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (ConfigureBuild.add_pr_details): (FetchBranches.run): (UpdateWorkingDirectory.run): (CheckOutPullRequest.run): (CleanGitRepo.__init__): (ValidateRemote.start): (ValidateRemote.evaluateCommand): (ValidateRemote.doStepIf): (ValidateSquashed.start): (AddReviewerToCommitMessage.start): (ValidateCommitMessage.run): (Canonicalize.run): Canonical link: https://commits.webkit.org/254635@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a01206: [Deprecation Reporting] Stub implementation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a01206bce956b19baa818f03a3f316dcdcba881a https://github.com/WebKit/WebKit/commit/a01206bce956b19baa818f03a3f316dcdcba881a Author: Brent Fulgham Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/imported/w3c/resources/import-expectations.json A LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/META.yml A LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.html A LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.js A LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/w3c-import.log M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Headers.cmake A Source/WebCore/Modules/reporting/DeprecationReportBody.cpp A Source/WebCore/Modules/reporting/DeprecationReportBody.h A Source/WebCore/Modules/reporting/DeprecationReportBody.idl M Source/WebCore/Modules/reporting/ReportingObserver.cpp M Source/WebCore/Modules/reporting/TestReportBody.h M Source/WebCore/Modules/reporting/ViolationReportType.h M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/JSReportBodyCustom.cpp M Source/WebCore/bindings/js/WebCoreBuiltinNames.h M Source/WebCore/loader/PingLoader.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.cpp Log Message: --- [Deprecation Reporting] Stub implementation https://bugs.webkit.org/show_bug.cgi?id=245245 Reviewed by Chris Dumez. Import the Web Platform Tests for Deprecation Reporting, create a new Experimental Feature to represent the work, and provide a stub implementation of the report * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/META.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.html: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.js: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.worker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/w3c-import.log: Added. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/reporting/DeprecationReportBody.cpp: Added. (WebCore::DeprecationReportBody::deprecationReportType): (WebCore::DeprecationReportBody::DeprecationReportBody): (WebCore::DeprecationReportBody::create): (WebCore::DeprecationReportBody::type const): (WebCore::DeprecationReportBody::id const): (WebCore::DeprecationReportBody::anticipatedRemoval const): (WebCore::DeprecationReportBody::message const): (WebCore::DeprecationReportBody::sourceFile const): (WebCore::DeprecationReportBody::lineNumber const): (WebCore::DeprecationReportBody::columnNumber const): (WebCore::DeprecationReportBody::createReportFormDataForViolation const): * Source/WebCore/Modules/reporting/DeprecationReportBody.h: Copied from Source/WebCore/Modules/reporting/TestReportBody.h. (WebCore::DeprecationReportBody::encode const): (WebCore::DeprecationReportBody::decode): (isType): * Source/WebCore/Modules/reporting/DeprecationReportBody.idl: Copied from Source/WebCore/Modules/reporting/ViolationReportType.h. * Source/WebCore/Modules/reporting/ReportingObserver.cpp: (WebCore::isVisibleToReportingObservers): * Source/WebCore/Modules/reporting/TestReportBody.h: * Source/WebCore/Modules/reporting/ViolationReportType.h: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/JSReportBodyCustom.cpp: (WebCore::toJSNewlyCreated): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/loader/PingLoader.cpp: (WebCore::PingLoader::sendViolationReport): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): Canonical link: https://commits.webkit.org/254
[webkit-changes] [WebKit/WebKit] b9ccc0: [Gardening]: REBASELINE: [ iOS ] imported/w3c/web-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9ccc0e903929f7a6cb8f24dd32f7df58cc74f35 https://github.com/WebKit/WebKit/commit/b9ccc0e903929f7a6cb8f24dd32f7df58cc74f35 Author: Hercules Hjalmarsson Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [Gardening]: REBASELINE: [ iOS ] imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional.html is constantly failing https://bugs.webkit.org/show_bug.cgi?id=243946 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/254633@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b8b03: [Gardening]: REGRESSION(251564@main-251572@main?):...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b8b03c3754c1e23e7ac6f751e83e378cbcfd9bc https://github.com/WebKit/WebKit/commit/9b8b03c3754c1e23e7ac6f751e83e378cbcfd9bc Author: Hercules Hjalmarsson Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION(251564@main-251572@main?): [ Mac wk2 ] media/media-source/media-webm-vorbis-partial.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=242212 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/254632@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7096da: Revert (249987@main, 250226@main and 250267@main):...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7096da92daae613e114f3787f3c3281a5c717f14 https://github.com/WebKit/WebKit/commit/7096da92daae613e114f3787f3c3281a5c717f14 Author: Matthew Finkel Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferences.yaml M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/DocumentLoader.h M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h M Tools/TestWebKitAPI/Tests/mac/LoadWebArchive.mm Log Message: --- Revert (249987@main, 250226@main and 250267@main): Remove WebArchiveDebugMode https://bugs.webkit.org/show_bug.cgi?id=245228 Reviewed by Said Abou-Hallawa. Changes resulted in too much breakage. Reverting 249987@main, 250226@main and 250267@main. * Source/WTF/Scripts/Preferences/WebPreferences.yaml: * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::scheduleArchiveLoad): (WebCore::DocumentLoader::isLoadingRemoteArchive const): Deleted. * Source/WebCore/loader/DocumentLoader.h: * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebArchiveDebugModeEnabled): (WKPreferencesGetWebArchiveDebugModeEnabled): (WKPreferencesSetWebArchiveTestingModeEnabled): Deleted. (WKPreferencesGetWebArchiveTestingModeEnabled): Deleted. * Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _setWebArchiveDebugModeEnabled:]): (-[WKPreferences _webArchiveDebugModeEnabled]): (-[WKPreferences _setWebArchiveTestingModeEnabled:]): Deleted. (-[WKPreferences _webArchiveTestingModeEnabled]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h: * Tools/TestWebKitAPI/Tests/mac/LoadWebArchive.mm: (TestWebKitAPI::constructArchive): (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/254631@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86dc02: [Gardening]: REGRESSION(253277@main): [ iOS ] fast...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86dc0288c9225592ac910490c964892d25cc6911 https://github.com/WebKit/WebKit/commit/86dc0288c9225592ac910490c964892d25cc6911 Author: Hercules Hjalmarsson Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [Gardening]: REGRESSION(253277@main): [ iOS ] fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-after-changing-initial-scale.html is constantly failing https://bugs.webkit.org/show_bug.cgi?id=243828 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/254630@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f5b26f: Rebaseline / unskip some tests now that we support...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f5b26fd2d6829003be638f031ae9df4fee77e979 https://github.com/WebKit/WebKit/commit/f5b26fd2d6829003be638f031ae9df4fee77e979 Author: Chris Dumez Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/reporting-to-worker-owner.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/nested-worker-success.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/utf-8-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/windows-1251-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/windows-1252-expected.txt M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_nested_dedicated_worker.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/semantics/multiple-workers/003-expected.txt Log Message: --- Rebaseline / unskip some tests now that we supported nested dedicated workers https://bugs.webkit.org/show_bug.cgi?id=245327 Unreviewed, rebaseline / unskip some tests now that we supported nested dedicated workers. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/reporting-to-worker-owner.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/nested-worker-success.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/utf-8-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/windows-1251-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/windows-1252-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_nested_dedicated_worker.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/semantics/multiple-workers/003-expected.txt: Canonical link: https://commits.webkit.org/254629@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 94217a: Unreviewed, suppress exception check warning
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 94217a6eb57626c46d67099b4a9ccd8f2c83eee0 https://github.com/WebKit/WebKit/commit/94217a6eb57626c46d67099b4a9ccd8f2c83eee0 Author: Yusuke Suzuki Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/JavaScriptCore/runtime/CatchScope.h Log Message: --- Unreviewed, suppress exception check warning https://bugs.webkit.org/show_bug.cgi?id=245354 When clearExceptionExceptTermination is called, we should treat it as "exception is checked". * Source/JavaScriptCore/runtime/CatchScope.h: (JSC::CatchScope::clearExceptionExceptTermination): Canonical link: https://commits.webkit.org/254628@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c00fe9: Explicitly initialize color properties.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c00fe941b56e6b371bfc1e98d175059f269635f4 https://github.com/WebKit/WebKit/commit/c00fe941b56e6b371bfc1e98d175059f269635f4 Author: Matthieu Dubet Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp M Source/WebCore/rendering/style/StyleRareInheritedData.cpp Log Message: --- Explicitly initialize color properties. https://bugs.webkit.org/show_bug.cgi?id=245359 Reviewed by Antti Koivisto. Before this change, those properties were implicitely default-initialized to empty color, which is interpreted as current color. This change makes the current color initialization explicit. * Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleFillData::StyleFillData): * Source/WebCore/rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): Canonical link: https://commits.webkit.org/254627@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45ff77: Fix missing inconsistent override warnings in WC
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45ff77cbffa907ac3b531f837dcdf1f2b12ac1fa https://github.com/WebKit/WebKit/commit/45ff77cbffa907ac3b531f837dcdf1f2b12ac1fa Author: Don Olmstead Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.h M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.h Log Message: --- Fix missing inconsistent override warnings in WC https://bugs.webkit.org/show_bug.cgi?id=245340 Reviewed by Fujii Hironori. * Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.h: * Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.h: Canonical link: https://commits.webkit.org/254626@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca0f07: [LFC][Cleanup] Remove LayoutState::formattingState...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca0f0776f820a5cf1c1ad1e2a6cbca461c818f03 https://github.com/WebKit/WebKit/commit/ca0f0776f820a5cf1c1ad1e2a6cbca461c818f03 Author: Alan Bujtas Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/WebCore/layout/FormattingState.h M Source/WebCore/layout/LayoutState.cpp M Source/WebCore/layout/LayoutState.h M Source/WebCore/layout/Verification.cpp M Source/WebCore/layout/floats/FloatingContext.cpp M Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp M Source/WebCore/layout/formattingContexts/block/BlockFormattingGeometry.cpp M Source/WebCore/layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp Log Message: --- [LFC][Cleanup] Remove LayoutState::formattingStateForBox https://bugs.webkit.org/show_bug.cgi?id=245345 Reviewed by Antti Koivisto. In most cases the formatting state we are looking for is the current formatting context's state (e.g. intrinsic width computation). There are only a few exceptions (e.g. geometry verification) where we don't have enough context to get the correct state. This is also in preparation for removing Layout::Box::formattingContextRoot(). * Source/WebCore/layout/FormattingState.h: (WebCore::Layout::FormattingState::setIntrinsicWidthConstraintsForBox): (WebCore::Layout::FormattingState::intrinsicWidthConstraintsForBox const): * Source/WebCore/layout/LayoutState.cpp: (WebCore::Layout::LayoutState::formattingStateForBox const): Deleted. * Source/WebCore/layout/LayoutState.h: * Source/WebCore/layout/Verification.cpp: (WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded): * Source/WebCore/layout/floats/FloatingContext.cpp: (WebCore::Layout::FloatingContext::verticalPositionWithClearance const): * Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp: (WebCore::Layout::FormattingGeometry::staticVerticalPositionForOutOfFlowPositioned const): * Source/WebCore/layout/formattingContexts/block/BlockFormattingGeometry.cpp: (WebCore::Layout::BlockFormattingGeometry::intrinsicWidthConstraints const): * Source/WebCore/layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp: (WebCore::Layout::BlockMarginCollapse::precomputedPositiveNegativeValues const): (WebCore::Layout::BlockMarginCollapse::precomputedPositiveNegativeMarginBefore const): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints): Canonical link: https://commits.webkit.org/254625@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6605a9: Non-unified build fixes, September 18th edition
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6605a931f44b00ba57de58188755ee38d2ca2f83 https://github.com/WebKit/WebKit/commit/6605a931f44b00ba57de58188755ee38d2ca2f83 Author: Lauro Moura Date: 2022-09-19 (Mon, 19 Sep 2022) Changed paths: M Source/JavaScriptCore/runtime/JSMicrotask.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp M Source/WebCore/bindings/js/JSDOMMicrotask.cpp Log Message: --- Non-unified build fixes, September 18th edition Unreviewed non-unified build fixes. * Source/JavaScriptCore/runtime/JSMicrotask.cpp: Add missing VMTrapsInlines * Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp: Add missing WasmTag * Source/WebCore/bindings/js/JSDOMMicrotask.cpp: Add missing VMTrapsInlines Canonical link: https://commits.webkit.org/254624@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
