[webkit-changes] [WebKit/WebKit] 523acc: AX: AXIsolatedTree::updateChildren doesn't propaga...

2022-09-26 Thread Tyler Wilcock
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 523acc306f2bb48caf9cf15371329caae1d36346
  
https://github.com/WebKit/WebKit/commit/523acc306f2bb48caf9cf15371329caae1d36346
  Author: Tyler Wilcock 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  ---
  AX: AXIsolatedTree::updateChildren doesn't propagate updates downwards when 
AccessibilityObject::m_subtreeDirty is true
https://bugs.webkit.org/show_bug.cgi?id=245694
rdar://100245048

Reviewed by Chris Fleizach.

When AXIsolatedTree::updateChildren updates the children of the nearest 
in-isolated-tree
ancestor to the parameter object, it compares the new children of that object 
to the "old"
ones, i.e. the children for that object in the nodemap. If we found that the 
object's new children
included an object that already existed in the old nodemap children, we do 
nothing (besides
deliberately not queuing it for deletion).

Based on the update pattern of some sites, doing nothing in this scenario is 
not right, since this
existing object could have m_subtreeDirty set, meaning we need to propagate 
descendant updates downwards.
This is exactly what the live tree does in AccessibilityObject::insertChild.

With this patch, we detect m_subtreeDirty in this scenario and propagate that 
update downwards with
AXIsolatedTree::collectNodeChangesForSubtree.

Fixes accessibility/text-alternative-calculation-from-listbox.html which is 
dependent on m_subtreeDirty
updates being handled properly.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::hasDirtySubtree const): Added.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildren):

Canonical link: https://commits.webkit.org/254899@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 097a53: [WK2] Remove uses of SendSyncLegacyResult-based Me...

2022-09-26 Thread Žan Doberšek
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 097a53775b155c4ff45d51d931ea1652a654c827
  
https://github.com/WebKit/WebKit/commit/097a53775b155c4ff45d51d931ea1652a654c827
  Author: Žan Doberšek 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebKit/Platform/IPC/MessageSender.h
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.cpp
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.cpp
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  ---
  [WK2] Remove uses of SendSyncLegacyResult-based MessageSender::sendSync() 
overload
https://bugs.webkit.org/show_bug.cgi?id=245596

Reviewed by Kimmo Kinnunen.

Replace uses of the MessageSender::sendSync() method overload returning
SendSyncLegacyResult objects with the newer variant. The legacy methods
and type alias can then be removed.

* Source/WebKit/Platform/IPC/MessageSender.h:
(IPC::MessageSender::sendSync):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::computePagesForPrintingiOS):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::stringSelectionForPasteboard):
(WebKit::WebPageProxy::dataSelectionForPasteboard):
(WebKit::WebPageProxy::readSelectionFromPasteboard):
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
* Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::canMakePayments):
(WebKit::WebPaymentCoordinator::showPaymentUI):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
* Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:
(WebKit::WebSpeechSynthesisClient::voiceList):
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:
(WebKit::WebAlternativeTextClient::dismissAlternativeSoon):
(WebKit::WebAlternativeTextClient::dictationAlternatives):
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::substitutionsPanelIsShowing):
* Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::containsItem const):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

Canonical link: https://commits.webkit.org/254898@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 922f8f: TextureMapper: Calculate zFar and zNear for the pr...

2022-09-26 Thread Fujii Hironori
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 922f8f09f0ca28f6ace19c16c2b7a9a7989d5d2f
  
https://github.com/WebKit/WebKit/commit/922f8f09f0ca28f6ace19c16c2b7a9a7989d5d2f
  Author: Fujii Hironori 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/platform/graphics/texmap/TextureMapper.h
M Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
M Source/WebCore/platform/graphics/texmap/TextureMapperGL.h
M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h

  Log Message:
  ---
  TextureMapper: Calculate zFar and zNear for the projection matrix
https://bugs.webkit.org/show_bug.cgi?id=244564

Reviewed by Darin Adler.

TextureMapper was using fixed zFar and zNear values, (-9,
999). These were too big for 16 bits depth buffer on Linux.


Changed TextureMapperLayer::computeTransformsRecursive to calculate
zFar and zNear.

* LayoutTests/platform/glib/TestExpectations:
Unmarked 
imported/w3c/web-platform-tests/css/css-transforms/perspective-split-by-zero-w.html
* Source/WebCore/platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::setDepthRange):
* Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::createProjectionMatrix):
(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::setDepthRange):
* Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperComputeTransformData::updateDepthRange):
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paint):
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:

Canonical link: https://commits.webkit.org/254897@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 7605a5: Add Marcos Caceres to contributors.json

2022-09-26 Thread Marcos Cáceres
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7605a5528cba2261313bbb39849e831b63f28e9f
  
https://github.com/WebKit/WebKit/commit/7605a5528cba2261313bbb39849e831b63f28e9f
  Author: Marcos Caceres 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add Marcos Caceres to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=245715

Reviewed by Chris Dumez.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/254896@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 37175e: Unreviewed mark css3/scroll-snap/scroll-snap-drag-...

2022-09-26 Thread Nikos Mouchtaris
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37175e4a2c73e100cf94d1f9345048d5c50261f2
  
https://github.com/WebKit/WebKit/commit/37175e4a2c73e100cf94d1f9345048d5c50261f2
  Author: Nikolaos Mouchtaris 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  Unreviewed mark 
css3/scroll-snap/scroll-snap-drag-scrollbar-thumb-with-relayouts.html flaky
https://bugs.webkit.org/show_bug.cgi?id=245717


Unreviewed test gardening.

* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/254895@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 6f86bd: Add initial support for CSSStyleSheet constructor ...

2022-09-26 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f86bd6200eb4f6528757f1744f49fa653442882
  
https://github.com/WebKit/WebKit/commit/6f86bd6200eb4f6528757f1744f49fa653442882
  Author: Chris Dumez 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/dom/dom-constructors-expected.txt
M LayoutTests/fast/dom/dom-constructors.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-statement-before-import-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-baseURL.tentative-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-concat-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-concat-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-concat-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-cssRules-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-disabled-regular-sheet-insertion-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-duplicate-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-replace-on-regular-sheet-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-modify-after-removal-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-template-adoption-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/adoptedstylesheets-observablearray-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/idlharness-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/insertRule-across-context-expected.txt
A LayoutTests/platform/win/fast/dom/dom-constructors-expected.txt
M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/css/CSSStyleSheet.cpp
M Source/WebCore/css/CSSStyleSheet.h
M Source/WebCore/css/CSSStyleSheet.idl
M Source/WebCore/css/DocumentOrShadowRoot+CSSOM.idl
M Source/WebCore/css/MediaList.h
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/css/parser/CSSParserImpl.cpp
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/ShadowRoot.cpp
M Source/WebCore/dom/ShadowRoot.h
M Source/WebCore/dom/TreeScope.cpp
M Source/WebCore/dom/TreeScope.h
M Source/WebCore/style/StyleScope.cpp
M Source/WebCore/style/StyleScope.h

  Log Message:
  ---
  Add initial support for CSSStyleSheet constructor and 
TreeScope.adoptedStyleSheets attribute
https://bugs.webkit.org/show_bug.cgi?id=245648

Reviewed by Antti Koivisto and Brent Fulgham.

Add initial support for CSSStyleSheet constructor and 
TreeScope.adoptedStyleSheets attribute:
- https://w3c.github.io/csswg-drafts/cssom-1/#dom-cssstylesheet-cssstylesheet
- 
https://w3c.github.io/csswg-drafts/cssom-1/#extensions-to-the-document-or-shadow-root-interface

The implementation should be complete and is passing most tests. One issue that 
remains is that
DocumentOrShadowRoot.adoptedStyleSheets should be an ObservableArray instead of 
a FrozenArray.
We don't support for ObservableArray yet so this will need a follow-up patch.

The new support is behind an experimental feature flag, currently off by 
default.

* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-baseURL.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-cssRules-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-disabled-regular-sheet-insertion-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-duplicate-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-replace-on-regular-sheet-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-modify-after-removal-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-template-adoption-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/cssom/adoptedstylesheets-observablearray-expected.txt:
* LayoutTests/imported/w3

[webkit-changes] [WebKit/WebKit] a83424: Give myself (rr-codes) committer status.

2022-09-26 Thread Richard Robinson
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a83424cc34c2089a1ecbcf21b59c7a09a32488a6
  
https://github.com/WebKit/WebKit/commit/a83424cc34c2089a1ecbcf21b59c7a09a32488a6
  Author: Richard Robinson 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Give myself (rr-codes) committer status.

Reviewed by Tim Horton.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/254893@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3ac77f: Add a setting for visibility-change-interrupts-vid...

2022-09-26 Thread Tim Horton
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ac77f372b75ce51c3618966bb21621c35653952
  
https://github.com/WebKit/WebKit/commit/3ac77f372b75ce51c3618966bb21621c35653952
  Author: Tim Horton 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WTF/Scripts/Preferences/WebPreferences.yaml
M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp

  Log Message:
  ---
  Add a setting for visibility-change-interrupts-video instead of a 
compile-time platform check
https://bugs.webkit.org/show_bug.cgi?id=245687


Reviewed by Sam Weinig.

* Source/WTF/Scripts/Preferences/WebPreferences.yaml:
* Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::updateToPageMutedState):

Canonical link: https://commits.webkit.org/254892@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 4f3aa5: [JSC] Use destroying delete for ArrayBufferView

2022-09-26 Thread Yusuke Suzuki
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f3aa596bc546e675bd4cc421b1e125051ec7352
  
https://github.com/WebKit/WebKit/commit/4f3aa596bc546e675bd4cc421b1e125051ec7352
  Author: Yusuke Suzuki 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/JavaScriptCore/bytecode/AccessCase.cpp
M Source/JavaScriptCore/bytecode/Watchpoint.cpp
M Source/JavaScriptCore/jit/JITStubRoutine.cpp
M Source/JavaScriptCore/runtime/ArrayBufferView.cpp
M Source/JavaScriptCore/runtime/ArrayBufferView.h
M Source/JavaScriptCore/runtime/DataView.cpp
M Source/JavaScriptCore/runtime/DataView.h
M Source/JavaScriptCore/runtime/GenericTypedArrayView.h
M Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h
M Source/JavaScriptCore/runtime/TypedArrayType.h
M Source/JavaScriptCore/wasm/WasmCallee.cpp
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/DeprecatedCSSOMValue.cpp
M Source/WebCore/dom/Node.cpp

  Log Message:
  ---
  [JSC] Use destroying delete for ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=245653

Reviewed by Darin Adler.

Set TypedArrayType in ArrayBufferView field and use destroying delete for 
destruction and the other tiny functions.
So, we remove vtable pointer for that class.

* Source/JavaScriptCore/runtime/ArrayBufferView.cpp:
(JSC::ArrayBufferView::ArrayBufferView):
(JSC::ArrayBufferView::visitDerived):
(JSC::ArrayBufferView::visitDerived const):
(JSC::ArrayBufferView::wrap):
(JSC::ArrayBufferView::operator delete):
* Source/JavaScriptCore/runtime/ArrayBufferView.h:
(JSC::ArrayBufferView::getType const):
* Source/JavaScriptCore/runtime/DataView.cpp:
(JSC::DataView::DataView):
(JSC::DataView::wrapImpl):
(JSC::DataView::wrap): Deleted.
* Source/JavaScriptCore/runtime/DataView.h:
* Source/JavaScriptCore/runtime/GenericTypedArrayView.h:
* Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:
(JSC::GenericTypedArrayView::GenericTypedArrayView):
(JSC::GenericTypedArrayView::wrapImpl):
(JSC::GenericTypedArrayView::wrap): Deleted.
* Source/JavaScriptCore/runtime/TypedArrayType.h:

Canonical link: https://commits.webkit.org/254891@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 62267f: Use libwpe process management API

2022-09-26 Thread Don Olmstead
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62267f96ba7e53d7e24bd14cd7a56cf54fcd8b1c
  
https://github.com/WebKit/WebKit/commit/62267f96ba7e53d7e24bd14cd7a56cf54fcd8b1c
  Author: Don Olmstead 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/PlatformWPE.cmake
M Source/WebKit/SourcesWPE.txt
M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp
A Source/WebKit/UIProcess/Launcher/glib/ProcessProviderGLib.cpp
A Source/WebKit/UIProcess/Launcher/libwpe/ProcessProviderLibWPE.cpp
A Source/WebKit/UIProcess/Launcher/libwpe/ProcessProviderLibWPE.h
M 
Source/WebKit/UIProcess/Launcher/playstation/ProcessLauncherPlayStation.cpp
A 
Source/WebKit/UIProcess/Launcher/playstation/ProcessProviderPlayStation.cpp
M Source/cmake/OptionsPlayStation.cmake
M Tools/MiniBrowser/playstation/main.cpp
M Tools/TestWebKitAPI/PlatformPlayStation.cmake
M Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp

  Log Message:
  ---
  Use libwpe process management API
https://bugs.webkit.org/show_bug.cgi?id=241862

Reviewed by Adrian Perez de Castro and Michael Catanzaro.

The 1.14 release of libWPE added in a process management API. Add
support in WebKit to manage processes through it. On the PlayStation
side it is enabled if the WPE backend is present. For WPE it is enabled
if libWPE supports the API and the bubblewrap sandbox is not used.

The original patch came from Igalia implementing the process API in its
WPE Android port. From there it was modified to be a general libWPE
port implementation and to support a PlayStation path.

* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
* Source/WebKit/UIProcess/Launcher/glib/ProcessProviderGLib.cpp: Added.
* Source/WebKit/UIProcess/Launcher/libwpe/ProcessProviderLibWPE.cpp: Added.
* Source/WebKit/UIProcess/Launcher/libwpe/ProcessProviderLibWPE.h: Added.
* Source/WebKit/UIProcess/Launcher/playstation/ProcessLauncherPlayStation.cpp:
* Source/WebKit/UIProcess/Launcher/playstation/ProcessProviderPlayStation.cpp: 
Added.
* Source/cmake/OptionsPlayStation.cmake:
* Tools/MiniBrowser/playstation/main.cpp:
* Tools/TestWebKitAPI/PlatformPlayStation.cmake:
* Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:

Canonical link: https://commits.webkit.org/254890@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] aabdfc: Fix strokeStyle changes not being applied for succ...

2022-09-26 Thread mattwoodrow
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aabdfc49a52bb7286b4325975ccfaabdcf74d907
  
https://github.com/WebKit/WebKit/commit/aabdfc49a52bb7286b4325975ccfaabdcf74d907
  Author: Matt Woodrow 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
A LayoutTests/fast/canvas/canvas-strokePath-strokeStyle-expected.html
A LayoutTests/fast/canvas/canvas-strokePath-strokeStyle.html
M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp

  Log Message:
  ---
  Fix strokeStyle changes not being applied for successive stroke line 
operations.
https://bugs.webkit.org/show_bug.cgi?id=245465

Reviewed by Darin Adler.

The recordStrokeLineWithColorAndThickness optimised path skips serialising the 
state object, but fails to mark that we've applied the necessary changes.

This means that you can then change state back to it's original value, and we 
won't detect that it changed.

* LayoutTests/fast/canvas/canvas-strokePath-strokeStyle-expected.html: Added.
* LayoutTests/fast/canvas/canvas-strokePath-strokeStyle.html: Added.
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::strokePath):

Canonical link: https://commits.webkit.org/254889@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] dc5502: Enable libc++ assertions

2022-09-26 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc5502f840efcedfc7ab4ac73da15cf801d6d148
  
https://github.com/WebKit/WebKit/commit/dc5502f840efcedfc7ab4ac73da15cf801d6d148
  Author: Chris Dumez 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
M Source/WebCore/Configurations/WebCore.xcconfig
M Source/WebCore/PAL/Configurations/PAL.xcconfig
M Source/WebKit/Configurations/BaseTarget.xcconfig
M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig

  Log Message:
  ---
  Enable libc++ assertions
https://bugs.webkit.org/show_bug.cgi?id=245692


Reviewed by Geoffrey Garen.

Enable libc++ assertions when building WebKit. This adds extra safety and 
appears
to be perf-neutral on our benchmarks.

* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebCore/PAL/Configurations/PAL.xcconfig:
* Source/WebKit/Configurations/BaseTarget.xcconfig:
* Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:

Canonical link: https://commits.webkit.org/254888@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] f40757: [iOS] Remote playback of autoplaying & muted video...

2022-09-26 Thread Jer Noble
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f407579f73e56aa92f28abd35fc292933eb0ed27
  
https://github.com/WebKit/WebKit/commit/f407579f73e56aa92f28abd35fc292933eb0ed27
  Author: Jer Noble 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  ---
  [iOS] Remote playback of autoplaying & muted videos stops when device is 
locked
https://bugs.webkit.org/show_bug.cgi?id=245238


Reviewed by Eric Carlson.

Modify `canProduceAudio()` to take volume state into account, and only take 
mute state into
account for non-GStreamer ports.

Then, use `canProduceAudio()` to calculate the IsPlayingAudio state to report 
upward to the
Document's mediaState.

This results in the Document (and UIProcess) reporting that the page is 
performing audible
playback, and keeps the WebContent/GPU processes from suspending when in app 
background state.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaType const):
(WebCore::HTMLMediaElement::canProduceAudio const):
(WebCore::HTMLMediaElement::mediaState const):

Canonical link: https://commits.webkit.org/254887@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3d45a4: [Gardening]: [ iOS ] fast/canvas/webgl/gl-teximage...

2022-09-26 Thread Karl Rackler
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d45a4f19a752db304561f29970ac9dd44e0e9cb
  
https://github.com/WebKit/WebKit/commit/3d45a4f19a752db304561f29970ac9dd44e0e9cb
  Author: Karl Rackler 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS ] fast/canvas/webgl/gl-teximage-imagebitmap-memory.html is 
a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=237547


Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/254886@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 9fd8cc: TextureMapperGL: edge distance anti-aliasing shoul...

2022-09-26 Thread Fujii Hironori
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9fd8ccc1aa9a931022ec6a5a28297733473b6e7a
  
https://github.com/WebKit/WebKit/commit/9fd8ccc1aa9a931022ec6a5a28297733473b6e7a
  Author: Fujii Hironori 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp

  Log Message:
  ---
  TextureMapperGL: edge distance anti-aliasing should be calculated in 
homogeneous coordinates
https://bugs.webkit.org/show_bug.cgi?id=245265

Reviewed by Don Olmstead.

The edge distance anti-aliasing inflates rect edges by 1px in the
viewport coordinates and calculates an alpha value (v_antialias) for
each vertex to blur the edges. However, the viewport coordinates are
homogeneous coordinates. The projected vertex can be at infinity.
v_antialias also should be calculated in the homogeneous coordinates.

The denominator of v_antialias is same with one of the projected
vertex.

On the other hand, v_texCoord varying variable should be calculated
based on the 3D space distance.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:

Canonical link: https://commits.webkit.org/254885@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 291fad: [Gardening]: REGRESSION (247947@main?): [ iOS ] me...

2022-09-26 Thread Karl Rackler
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 291fada448af788073f75ca16b4f6589f1273e6e
  
https://github.com/WebKit/WebKit/commit/291fada448af788073f75ca16b4f6589f1273e6e
  Author: Karl Rackler 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (247947@main?): [ iOS ] media/video-played-reset.html 
is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=245710


Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/254884@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] e2b6e1: [Gardening]: [ iOS16 ] fast/text/capitalize-bounda...

2022-09-26 Thread Hercules Hjalmarsson
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2b6e15121a45278abf1cf29858b9c14ca5e86de
  
https://github.com/WebKit/WebKit/commit/e2b6e15121a45278abf1cf29858b9c14ca5e86de
  Author: Hercules Hjalmarsson 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS16 ] fast/text/capitalize-boundaries.html is a constant 
failure
https://bugs.webkit.org/show_bug.cgi?id=245708

Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/254883@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] ffae4f: Versioning.

2022-09-26 Thread Alan Coon
  Branch: refs/heads/safari-7615.1.7-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: ffae4f3b7c2ea54ae875f795760ea2cf37b421e1
  
https://github.com/WebKit/WebKit/commit/ffae4f3b7c2ea54ae875f795760ea2cf37b421e1
  Author: Alan Coon 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7615.1.7.1

Canonical link: https://commits.webkit.org/254623.2@safari-7615.1.7-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 937050: Update ANGLE to 2022-09-25 (2aa52da7e4c32ed6be32d2...

2022-09-26 Thread Dan Glastonbury
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 937050ddab337596ecffcd80eddd6b16e7455d9d
  
https://github.com/WebKit/WebKit/commit/937050ddab337596ecffcd80eddd6b16e7455d9d
  Author: Dan Glastonbury 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
M Source/ThirdParty/ANGLE/CONTRIBUTORS
M Source/ThirdParty/ANGLE/DEPS
M Source/ThirdParty/ANGLE/GLESv2.cmake
M Source/ThirdParty/ANGLE/build_overrides/vulkan_validation_layers.gni
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/doc/DebuggingTips.md
M Source/ThirdParty/ANGLE/doc/ExtensionSupport.md
A Source/ThirdParty/ANGLE/extensions/ANGLE_logic_op.txt
M Source/ThirdParty/ANGLE/extensions/ANGLE_shader_pixel_local_storage.txt
A Source/ThirdParty/ANGLE/extensions/EGL_ANGLE_sync_mtl_shared_event.txt
M Source/ThirdParty/ANGLE/include/EGL/eglext_angle.h
M Source/ThirdParty/ANGLE/include/GLES2/gl2ext_angle.h
M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h
M Source/ThirdParty/ANGLE/include/platform/FeaturesMtl_autogen.h
M Source/ThirdParty/ANGLE/include/platform/FeaturesVk_autogen.h
M Source/ThirdParty/ANGLE/include/platform/mtl_features.json
M Source/ThirdParty/ANGLE/include/platform/vk_features.json
M Source/ThirdParty/ANGLE/infra/config/generated/cr-buildbucket.cfg
M Source/ThirdParty/ANGLE/infra/config/generated/luci-milo.cfg
M Source/ThirdParty/ANGLE/infra/config/generated/luci-scheduler.cfg
M Source/ThirdParty/ANGLE/infra/config/generated/project.cfg
M Source/ThirdParty/ANGLE/infra/config/main.star
M Source/ThirdParty/ANGLE/infra/specs/angle.json
M Source/ThirdParty/ANGLE/infra/specs/angle_mb_config.pyl
M Source/ThirdParty/ANGLE/infra/specs/mixins.pyl
M Source/ThirdParty/ANGLE/infra/specs/test_suites.pyl
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_features.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_format.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_load_functions_table.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_shader_preprocessor.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_shader_translator.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/DXGI_format.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Extension_files.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_WGL_loader.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GLenum_value_to_string_map.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Metal_default_shaders.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Metal_format_table.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Test_spec_JSON.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_format.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/proc_table.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/restricted_traces.json
M Source/ThirdParty/ANGLE/scripts/egl_angle_ext.xml
M Source/ThirdParty/ANGLE/scripts/entry_point_packed_gl_enums.json
M Source/ThirdParty/ANGLE/scripts/gen_gl_enum_utils.py
M Source/ThirdParty/ANGLE/scripts/generate_android_bp.py
M Source/ThirdParty/ANGLE/scripts/generate_entry_points.py
M Source/ThirdParty/ANGLE/scripts/gl_angle_ext.xml
M Source/ThirdParty/ANGLE/scripts/registry_xml.py
M Source/ThirdParty/ANGLE/scripts/roll_aosp.sh
M Source/ThirdParty/ANGLE/src/angle_commit.h
M Source/ThirdParty/ANGLE/src/common/angle_version.h
M Source/ThirdParty/ANGLE/src/common/entry_points_enum_autogen.cpp
M Source/ThirdParty/ANGLE/src/common/entry_points_enum_autogen.h
M Source/ThirdParty/ANGLE/src/common/linux/dma_buf_utils.cpp
M Source/ThirdParty/ANGLE/src/common/linux/dma_buf_utils.h
M Source/ThirdParty/ANGLE/src/common/platform.h
M Source/ThirdParty/ANGLE/src/common/utilities.cpp
M Source/ThirdParty/ANGLE/src/common/utilities.h
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/preprocessor.y
M 
Source/ThirdParty/ANGLE/src/compiler/preprocessor/preprocessor_lex_autogen.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/preprocessor/preprocessor_tab_autogen.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/OutputHLSL.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/glslang_tab_autogen.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/glslang_tab_autogen.h
M 
Source/Th

[webkit-changes] [WebKit/WebKit] c2a254: [WGSL] SourceSpan operator== signature is incorrect

2022-09-26 Thread Dan Glastonbury
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2a2543ba247f84808fc2848867051a4cc710c88
  
https://github.com/WebKit/WebKit/commit/c2a2543ba247f84808fc2848867051a4cc710c88
  Author: Dan Glastonbury 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebGPU/WGSL/SourceSpan.h

  Log Message:
  ---
  [WGSL] SourceSpan operator== signature is incorrect
https://bugs.webkit.org/show_bug.cgi?id=245659
rdar://problem/100401133

Reviewed by Yusuke Suzuki.

The signature of SourceSpan::operator== is missing a const specifier.  Took the
opportunity to refactor SourceSpan constructors to reduce repetition.

* Source/WebGPU/WGSL/SourceSpan.h:

Canonical link: https://commits.webkit.org/254881@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] da2a97: Disable minimode scavenger in GPUProcess

2022-09-26 Thread bnham
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da2a972847cb30048e247f636e872fb41d191177
  
https://github.com/WebKit/WebKit/commit/da2a972847cb30048e247f636e872fb41d191177
  Author: Ben Nham 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/bmalloc/bmalloc/ProcessCheck.mm

  Log Message:
  ---
  Disable minimode scavenger in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=245681
rdar://100286875

Reviewed by Geoffrey Garen.

GPUProcess CPU usage during YouTube playback regressed by ~10% in the last 
major release. About 30%
of that is coming from extra activity in the scavenger thread due to increased 
scavenger frequency
(242195) and work (235347).

To work around this, disable the mini mode scavenger entirely in GPUProcess. 
This is neutral for
both Membuster and RAMification.

* Source/bmalloc/bmalloc/ProcessCheck.mm:
(bmalloc::shouldAllowMiniMode):

Canonical link: https://commits.webkit.org/254880@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 633346: [macOS] Adopt RunningBoard process assertions

2022-09-26 Thread Miguel Salinas
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6333464afab0d8b4e7bd9ea5bac1132a3bacd1ca
  
https://github.com/WebKit/WebKit/commit/6333464afab0d8b4e7bd9ea5bac1132a3bacd1ca
  Author: Miguel Salinas 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WTF/wtf/PlatformUse.h
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/Scripts/process-entitlements.sh
A Source/WebKit/Scripts/update-info-plist-for-runningboard.sh
M 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h
M 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
A Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
M Source/WebKit/UIProcess/ProcessAssertion.cpp
M Source/WebKit/UIProcess/ProcessAssertion.h
R Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  [macOS] Adopt RunningBoard process assertions
https://bugs.webkit.org/show_bug.cgi?id=244998
rdar://99753987

Reviewed by Chris Dumez.

Adopt RunningBoard process assertions on macOS and stop leaking an
os_transaction in order to keep our XPC services alive.
This paves the way for suspendable processes on macOS since we now
receive SIGKILL on application exit instead of SIGTERM. This previously
caused a page load time regression due to removing the leaked boost on
the network and GPU processes.

* Source/WTF/wtf/PlatformUse.h:
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/Scripts/update-info-plist-for-runningboard.sh: Added.
* 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
* 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceExit):
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:
* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm: Renamed from 
Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm.
(assertionsWorkQueue):
(processHasActiveRunTimeLimitation):
(+[WKProcessAssertionBackgroundTaskManager shared]):
(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager dealloc]):
(-[WKProcessAssertionBackgroundTaskManager addAssertionNeedingBackgroundTask:]):
(-[WKProcessAssertionBackgroundTaskManager 
removeAssertionNeedingBackgroundTask:]):
(-[WKProcessAssertionBackgroundTaskManager 
_notifyAssertionsOfImminentSuspension]):
(-[WKProcessAssertionBackgroundTaskManager _scheduleReleaseTask]):
(-[WKProcessAssertionBackgroundTaskManager _cancelPendingReleaseTask]):
(-[WKProcessAssertionBackgroundTaskManager _hasBackgroundTask]):
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
(-[WKProcessAssertionBackgroundTaskManager assertionWillInvalidate:]):
(-[WKProcessAssertionBackgroundTaskManager assertion:didInvalidateWithError:]):
(-[WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpiration]):
(-[WKProcessAssertionBackgroundTaskManager 
_handleBackgroundTaskExpirationOnMainThread]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):
(-[WKProcessAssertionBackgroundTaskManager setProcessStateMonitorEnabled:]):
(-[WKRBSAssertionDelegate dealloc]):
(-[WKRBSAssertionDelegate assertionWillInvalidate:]):
(-[WKRBSAssertionDelegate assertion:didInvalidateWithError:]):
(WebKit::runningBoardNameForAssertionType):
(WebKit::runningBoardDomainForAssertionType):
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::remainingRunTimeInSeconds):
(WebKit::ProcessAssertion::acquireAsync):
(WebKit::ProcessAssertion::acquireSync):
(WebKit::ProcessAssertion::~ProcessAssertion):
(WebKit::ProcessAssertion::processAssertionWillBeInvalidated):
(WebKit::ProcessAssertion::processAssertionWasInvalidated):
(WebKit::ProcessAssertion::isValid const):
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::~ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::updateRunInBackgroundCount):
(WebKit::ProcessAndUIAssertion::setProcessStateMonitorEnabled):
(WebKit::ProcessAndUIAssertion::uiAssertionWillExpireImminently):
(WebKit::ProcessAndUIAssertion::processAssertionWasInvalidated):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::shouldLeakBoost):
* Source/WebKit/UIProcess/ProcessAssertion.cpp:
* Source/WebKit/UIProcess/ProcessAssertion.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/254879@main


___
we

[webkit-changes] [WebKit/WebKit] 8e2637: Add SPI to get the SecTrustRef of a WKFrameRef

2022-09-26 Thread EWS
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e2637727a9658ca2d1ee21a3f797dca32a9a9a3
  
https://github.com/WebKit/WebKit/commit/8e2637727a9658ca2d1ee21a3f797dca32a9a9a3
  Author: Alex Christensen 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/API/C/WKCredential.cpp
M Source/WebKit/UIProcess/API/C/WKCredential.h
M Source/WebKit/UIProcess/API/C/WKFrame.cpp
M Source/WebKit/UIProcess/API/C/WKFrame.h
A Source/WebKit/UIProcess/API/C/mac/WKFrameMac.cpp
A Source/WebKit/UIProcess/API/C/mac/WKFrameMac.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Add SPI to get the SecTrustRef of a WKFrameRef
https://bugs.webkit.org/show_bug.cgi?id=245693


Reviewed by Tim Horton.

When I started to remove WKCertificateInfoRef, I regressed one legitimate use 
of getting the certificate chain from a Frame.
To fix that bug, continue to remove the unneeded WKCertificateInfoRef 
abstraction and expose WKFrameRef's SecTrustRef.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreateWithCertificateInfo):
* Source/WebKit/UIProcess/API/C/WKCredential.h:
* Source/WebKit/UIProcess/API/C/WKFrame.cpp:
(WKFrameGetCertificateInfo):
* Source/WebKit/UIProcess/API/C/WKFrame.h:
* Source/WebKit/UIProcess/API/C/mac/WKFrameMac.cpp: Copied from 
Source/WebKit/UIProcess/API/C/WKCredential.h.
(WKFrameGetServerTrust):
* Source/WebKit/UIProcess/API/C/mac/WKFrameMac.h: Copied from 
Source/WebKit/UIProcess/API/C/WKCredential.h.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/254878@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 485052: Add some Cocoa helper templates for getting object...

2022-09-26 Thread Timothy Hatcher
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 485052b30901b36de44f76c560e60674c1518c76
  
https://github.com/WebKit/WebKit/commit/485052b30901b36de44f76c560e60674c1518c76
  Author: Timothy Hatcher 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
A Source/WebKit/Platform/cocoa/CocoaHelpers.h
A Source/WebKit/Platform/cocoa/CocoaHelpers.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Add some Cocoa helper templates for getting objects of types and filtering 
containers.
https://bugs.webkit.org/show_bug.cgi?id=245646

Reviewed by Tim Horton.

These will be used in some forthcoming feature work. Instead of adding them as 
category methods in WebKit,
I made them template functions to avoid cluttering up Foundation classes with 
WebKit category methods.

* Source/WebKit/Platform/cocoa/CocoaHelpers.h: Added.
(WebKit::filterObjects):
(WebKit::mapObjects):
(WebKit::objectForKey):
* Source/WebKit/Platform/cocoa/CocoaHelpers.mm: Added.
(WebKit::filterObjects):
(WebKit::filterObjects):
(WebKit::filterObjects):
(WebKit::mapObjects):
(WebKit::mapObjects):
(WebKit::mapObjects):
(WebKit::objectForKey):
(WebKit::objectForKey):
(WebKit::objectForKey):
(WebKit::objectForKey):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/254877@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 6009cd: TextureMapperGL: REGRESSION(215058@main): edge dis...

2022-09-26 Thread Fujii Hironori
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6009cd99a53dd0843138de2206586f23621e5045
  
https://github.com/WebKit/WebKit/commit/6009cd99a53dd0843138de2206586f23621e5045
  Author: Fujii Hironori 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp

  Log Message:
  ---
  TextureMapperGL: REGRESSION(215058@main): edge distance anti-aliasing renders 
thinner edges than expected
https://bugs.webkit.org/show_bug.cgi?id=245514

Reviewed by Don Olmstead.

bug#124653 added fragmentTransformTexCoord to extend edges of a
texture to the inflation area. However, it hadn't worked after
bug#132869 renamed ENABLE_Texture macro to ENABLE_TextureRGB becuase
the transformTexCoord definition still used the old macro.

* Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:
Removed the condition with old ENABLE_Texture macro for transformTexCoord.

Canonical link: https://commits.webkit.org/254876@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] b07e2d: [JSC] Clean up wasm AirIRGenerator FP truncation

2022-09-26 Thread jjgriego
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b07e2d5c790373fbf908cecdf9aa47517c40de93
  
https://github.com/WebKit/WebKit/commit/b07e2d5c790373fbf908cecdf9aa47517c40de93
  Author: Joseph Griego 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp

  Log Message:
  ---
  [JSC] Clean up wasm AirIRGenerator FP truncation
https://bugs.webkit.org/show_bug.cgi?id=245436

Reviewed by Justin Michaud.

The implementation for all of the (checked and saturated) floating point to
integer truncations ends up being really duplicative--we have code for the
patchpoints to generate the appropriate instructions twice for each flavor of
this operation and code for the bounds checking needed is duplicated many times.

This patch adds a new method for generating only the code for an unchecked
truncation; a table of the output ranges for each flavor, and uses both to have
a single implementation for both the checked and saturating versions of each
truncation instruction.

Also avoids clobbering the macro scratch registers on ARM64 for some variants of
the truncation (the ones resulting in U64s) since the macro assembler doesn't
seem to actually need them on that architecture.

Relying on the existing test suite; this shouldn't really change the generated
code, except for the change to the macro scratch register clobbers on ARM64.

* Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::lookupTruncationRange):
(JSC::Wasm::AirIRGenerator::addUncheckedFloatingPointTruncation):
(JSC::Wasm::AirIRGenerator::truncSaturated):
(JSC::Wasm::AirIRGenerator::addCheckedFloatingPointTruncation):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):

Canonical link: https://commits.webkit.org/254875@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] afcb2f: [Gardening]: [ iOS16 ] fast/events/ios/rotation/or...

2022-09-26 Thread Hercules Hjalmarsson
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: afcb2f077fa7df1a19ebff2a1e69082d71a95455
  
https://github.com/WebKit/WebKit/commit/afcb2f077fa7df1a19ebff2a1e69082d71a95455
  Author: Hercules Hjalmarsson 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS16 ] 
fast/events/ios/rotation/orientationchange-event-listener-on.body.html is a 
almost constant failure
https://bugs.webkit.org/show_bug.cgi?id=245691

Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/254874@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] dd45d7: [Gardening]: [ iOS16 ] fast/css/ios/system-color-f...

2022-09-26 Thread Hercules Hjalmarsson
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd45d77361a61c78fafc6f6c473f17dc43b1514a
  
https://github.com/WebKit/WebKit/commit/dd45d77361a61c78fafc6f6c473f17dc43b1514a
  Author: Hercules Hjalmarsson 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS16 ] fast/css/ios/system-color-for-css-value.html is a 
constant failure
https://bugs.webkit.org/show_bug.cgi?id=245688

Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/254873@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] b41bf8: [Gardening]: [ iOS16 ] fast/text/system-font-fallb...

2022-09-26 Thread Hercules Hjalmarsson
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b41bf881ac4ccb5fb415aec39e55414a2f8b495b
  
https://github.com/WebKit/WebKit/commit/b41bf881ac4ccb5fb415aec39e55414a2f8b495b
  Author: Hercules Hjalmarsson 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS16 ] fast/text/system-font-fallback.html is a constant 
failure
https://bugs.webkit.org/show_bug.cgi?id=245686

Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/254872@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] c9095f: Add a GitHub username for bweinst...@apple.com.

2022-09-26 Thread b-weinstein
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9095f9fd57d6f9ef542cb09dd64ab3d8a1fba47
  
https://github.com/WebKit/WebKit/commit/c9095f9fd57d6f9ef542cb09dd64ab3d8a1fba47
  Author: Brian Weinstein 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add a GitHub username for bweinst...@apple.com.
https://bugs.webkit.org/show_bug.cgi?id=245684

Reviewed by Timothy Hatcher.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/254871@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] ede5c5: Unreviewed, reverting r253111@main.

2022-09-26 Thread Commit Queue
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ede5c50d642c70ed8c7b1648b8de479c4a89366c
  
https://github.com/WebKit/WebKit/commit/ede5c50d642c70ed8c7b1648b8de479c4a89366c
  Author: Commit Queue 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

  Log Message:
  ---
  Unreviewed, reverting r253111@main.
https://bugs.webkit.org/show_bug.cgi?id=245683

Introduced crash

Reverted changeset:

"[iOS][WP] Update sandbox message filter"
https://bugs.webkit.org/show_bug.cgi?id=243533
https://commits.webkit.org/253111@main

Canonical link: https://commits.webkit.org/254870@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] a7f739: [Gardening]: REGRESSION?(254483@main): [ iOS16 mac...

2022-09-26 Thread Hercules Hjalmarsson
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a7f739402edfdf2aab55f2707b68cff123ef9473
  
https://github.com/WebKit/WebKit/commit/a7f739402edfdf2aab55f2707b68cff123ef9473
  Author: Hercules Hjalmarsson 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION?(254483@main): [ iOS16 macOS wk2 ] 
http/tests/misc/iframe-shadow-realm.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=245680

Unreviewed test gardening.

* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/254869@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] d2adde: [Gardening]: [ iOS16 ] imported/w3c/web-platform-t...

2022-09-26 Thread Karl Rackler
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2adde67066c335f2ca2ba390ba897f497445163
  
https://github.com/WebKit/WebKit/commit/d2adde67066c335f2ca2ba390ba897f497445163
  Author: Karl Rackler 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/ios-simulator/TestExpectations
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS16 ] 
imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-greek.html
 is constantly failing
https://bugs.webkit.org/show_bug.cgi?id=245593


Unreviewed test gardening.

* LayoutTests/platform/ios-simulator/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/254868@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3680af: [LFC] Remove Layout::ListMarkerBox

2022-09-26 Thread Antti Koivisto
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3680af69a668ee7b3f3168d8834101adcd0710c7
  
https://github.com/WebKit/WebKit/commit/3680af69a668ee7b3f3168d8834101adcd0710c7
  Author: Antti Koivisto 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/layouttree/LayoutBox.h
R Source/WebCore/layout/layouttree/LayoutListMarkerBox.cpp
R Source/WebCore/layout/layouttree/LayoutListMarkerBox.h
M Source/WebCore/layout/layouttree/LayoutReplacedBox.cpp
M Source/WebCore/layout/layouttree/LayoutReplacedBox.h

  Log Message:
  ---
  [LFC] Remove Layout::ListMarkerBox
https://bugs.webkit.org/show_bug.cgi?id=245670


Reviewed by Alan Bujtas.

Flatten it to ReplacedBox.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::adjustIdeographicBaselineIfApplicable):
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::outsideListMarkerVisualPosition 
const):
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTreeForInlineContent):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateListMarkerDimensions):
* Source/WebCore/layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isListMarkerBox const):
(WebCore::Layout::Box::isReplacedBox const):
* Source/WebCore/layout/layouttree/LayoutListMarkerBox.cpp: Removed.
* Source/WebCore/layout/layouttree/LayoutListMarkerBox.h: Removed.
* Source/WebCore/layout/layouttree/LayoutReplacedBox.cpp:
(WebCore::Layout::ReplacedBox::ReplacedBox):
(WebCore::Layout::m_isListMarkerOutside):
* Source/WebCore/layout/layouttree/LayoutReplacedBox.h:
(WebCore::Layout::ReplacedBox::isListMarkerImage const):
(WebCore::Layout::ReplacedBox::isListMarkerOutside const):
(WebCore::Layout::ReplacedBox::ReplacedBox): Deleted.

Canonical link: https://commits.webkit.org/254867@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 84b5bc: [LFC] Clarify layout box ownership

2022-09-26 Thread Antti Koivisto
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84b5bcb034c36715857f40fa9a0aae0a01450b07
  
https://github.com/WebKit/WebKit/commit/84b5bcb034c36715857f40fa9a0aae0a01450b07
  Author: Antti Koivisto 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/layout/layouttree/LayoutBox.cpp
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/layout/layouttree/LayoutContainerBox.cpp
M Source/WebCore/layout/layouttree/LayoutContainerBox.h

  Log Message:
  ---
  [LFC] Clarify layout box ownership
https://bugs.webkit.org/show_bug.cgi?id=245672


Reviewed by Alan Bujtas.

Use std::unique_ptr for firstChild/nextSibling pointers. This does not really 
change
the actual ownership but makes it more obvious in the code that this is an 
owning tree.

* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::removeFromParent):
(WebCore::Layout::Box::setParent): Deleted.
(WebCore::Layout::Box::setNextSibling): Deleted.
(WebCore::Layout::Box::setPreviousSibling): Deleted.
* Source/WebCore/layout/layouttree/LayoutBox.h:
* Source/WebCore/layout/layouttree/LayoutContainerBox.cpp:
(WebCore::Layout::ContainerBox::appendChild):
(WebCore::Layout::ContainerBox::destroyChildren):
* Source/WebCore/layout/layouttree/LayoutContainerBox.h:

Canonical link: https://commits.webkit.org/254866@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] f370a5: [ews] commit link is incorrect for status-bubbles ...

2022-09-26 Thread Aakash J
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f370a51ace3ef8befe2932ed7fd4e91829a85cb9
  
https://github.com/WebKit/WebKit/commit/f370a51ace3ef8befe2932ed7fd4e91829a85cb9
  Author: Aakash Jain 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/github.py

  Log Message:
  ---
  [ews] commit link is incorrect for status-bubbles in alternative remotes
https://bugs.webkit.org/show_bug.cgi?id=245679

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHub.update_or_leave_comment_on_pr):
(GitHubEWS.generate_comment_text_for_change):

Canonical link: https://commits.webkit.org/254865@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 6f702c: [Gardening]: REGRESSION (253865@main): [ iOS ] scr...

2022-09-26 Thread Karl Rackler
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f702caba723d2228f8fb2b07d311887003c0425
  
https://github.com/WebKit/WebKit/commit/6f702caba723d2228f8fb2b07d311887003c0425
  Author: Karl Rackler 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (253865@main): [ iOS ] 
scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position.html is 
a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=245613


Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/254864@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] d2c029: [LBSE] Pixel snapping logic is incorrect for SVG, ...

2022-09-26 Thread Nikolas Zimmermann
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2c0299eb83a36da49226c4c3696e8ae7382c39b
  
https://github.com/WebKit/WebKit/commit/d2c0299eb83a36da49226c4c3696e8ae7382c39b
  Author: Nikolas Zimmermann 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
A 
LayoutTests/svg/compositing/inline-svg-non-integer-position-display-block-composited-expected.html
A 
LayoutTests/svg/compositing/inline-svg-non-integer-position-display-block-composited.html
A 
LayoutTests/svg/compositing/inline-svg-non-integer-position-display-inline-composited-expected.html
A 
LayoutTests/svg/compositing/inline-svg-non-integer-position-display-inline-composited.html
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp

  Log Message:
  ---
  [LBSE] Pixel snapping logic is incorrect for SVG, when elements are composited
https://bugs.webkit.org/show_bug.cgi?id=245416

Reviewed by Rob Buis.

In bug webkit.org/b/244966 ("[LBSE] Outermost  elements are not 
device-pixel aligned")
the rendering was adapted in such a way that the outermost  element is the 
only element
in the SVG subtree that is pixel snapped, delivering consistent results between 
e.g. HTML
 elements and SVG  elements, embedded in a CSS formatting context. 
The  will
get pixel snapped upon painting -- the same was enforced for the outermost 
, however
without propagating/accumulating sub-pixel errors for the descendant layers, 
since no pixel
snapping is applied within the SVG subtree.

When elements are composited another logic is used (RenderLayerBacking), and 
the device-pixel
alignment is applied for all SVG layers -- effectively breaking content. By 
fixing that, the
pixel snapping logic is consistent for all painting modes we have, no matter if 
the outer
 is composited, or any of its descendants.

Added two new reftests covering LBSE + compositing + sub-pixel locations in 
different display modes.
Doesn't affect any other existing tests.

* 
LayoutTests/svg/compositing/inline-svg-non-integer-position-display-block-composited-expected.html:
 Added.
* 
LayoutTests/svg/compositing/inline-svg-non-integer-position-display-block-composited.html:
 Added.
* 
LayoutTests/svg/compositing/inline-svg-non-integer-position-display-inline-composited-expected.html:
 Added.
* 
LayoutTests/svg/compositing/inline-svg-non-integer-position-display-inline-composited.html:
 Added.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToLayerCoords const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::snappedGraphicsLayer):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect const):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::adjustOverflowControlsPositionRelativeToAncestor):
(WebCore::RenderLayerBacking::updateMaskingLayerGeometry):
(WebCore::RenderLayerBacking::updateContentsRects):
(WebCore::RenderLayerBacking::updateClippingStackLayerGeometry):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

Canonical link: https://commits.webkit.org/254863@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] e28b8c: [LFC][IFC] Let's use "trimming" instead of "collap...

2022-09-26 Thread alan
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e28b8cba3c53baa5d693202ff02fc29906801f39
  
https://github.com/WebKit/WebKit/commit/e28b8cba3c53baa5d693202ff02fc29906801f39
  Author: Alan Bujtas 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  ---
  [LFC][IFC] Let's use "trimming" instead of "collapsing" in 
InlineContentBreaker
https://bugs.webkit.org/show_bug.cgi?id=245655

Reviewed by Antti Koivisto.

At line breaking time trimming is the correct term to use.

* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::resetTrailingWhitespace):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::append):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::reset):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:
(WebCore::Layout::InlineContentBreaker::ContinuousContent::leadingTrimmableWidth
 const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::trailingTrimmableWidth
 const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::hasTrimmableContent 
const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::isFullyTrimmable 
const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::leadingCollapsibleWidth
 const): Deleted.
(WebCore::Layout::InlineContentBreaker::ContinuousContent::trailingCollapsibleWidth
 const): Deleted.
(WebCore::Layout::InlineContentBreaker::ContinuousContent::hasCollapsibleContent
 const): Deleted.
(WebCore::Layout::InlineContentBreaker::ContinuousContent::isFullyCollapsible 
const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::TrimmableTrailingContent::remove):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):

Canonical link: https://commits.webkit.org/254862@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 6016db: Merge 254855@main - [GStreamer][MSE] Build warning...

2022-09-26 Thread Philippe Normand
  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 6016db27f0c76f0fec5156cb0b4e5211a120aa0d
  
https://github.com/WebKit/WebKit/commit/6016db27f0c76f0fec5156cb0b4e5211a120aa0d
  Author: Philippe Normand 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h

  Log Message:
  ---
  Merge 254855@main - [GStreamer][MSE] Build warning in AppendPipeline
https://bugs.webkit.org/show_bug.cgi?id=245637

Reviewed by Xabier Rodriguez-Calvar.

Follow-up after 254788@main fixing build warnings.

* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::recycleTrackForPad):
(WebCore::AppendPipeline::Track::emplaceOptionalParserForFormat):
(WebCore::AppendPipeline::Track::initializeElements):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:

Canonical link: https://commits.webkit.org/254855@main

(cherry picked from commit d628ab1f73d4115209cf29cf0f41b524e31b01ba)


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 09f7f3: Move PrivateClickMeasurement nested classes to sep...

2022-09-26 Thread EWS
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09f7f382f655d2459e9595663d914a05626e8f7a
  
https://github.com/WebKit/WebKit/commit/09f7f382f655d2459e9595663d914a05626e8f7a
  Author: Alex Christensen 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/html/HTMLAnchorElement.cpp
M Source/WebCore/html/HTMLAnchorElement.h
A Source/WebCore/loader/AttributionSecondsUntilSendData.h
A Source/WebCore/loader/AttributionTimeToSendData.h
A Source/WebCore/loader/AttributionTriggerData.cpp
A Source/WebCore/loader/AttributionTriggerData.h
A Source/WebCore/loader/EphemeralNonce.h
A Source/WebCore/loader/PCMSites.h
A Source/WebCore/loader/PCMTokens.h
M Source/WebCore/loader/PrivateClickMeasurement.cpp
M Source/WebCore/loader/PrivateClickMeasurement.h
M Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm
M Source/WebKit/NetworkProcess/DatabaseUtilities.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.h
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/NetworkSession.h
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.h
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerInterface.h
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.h
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.cpp
M 
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.h
M Source/WebKit/Platform/IPC/DaemonCoders.cpp
M Source/WebKit/Platform/IPC/DaemonCoders.h
M Source/WebKit/Scripts/generate-serializers.py
M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h
M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp
M Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm

  Log Message:
  ---
  Move PrivateClickMeasurement nested classes to separate headers and generate 
serializers
https://bugs.webkit.org/show_bug.cgi?id=245515


Reviewed by Chris Dumez.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::attributionSourceNonceForPCM const):
(WebCore::HTMLAnchorElement::parsePrivateClickMeasurementForSKAdNetwork const):
(WebCore::HTMLAnchorElement::parsePrivateClickMeasurement const):
* Source/WebCore/html/HTMLAnchorElement.h:
* Source/WebCore/loader/AttributionSecondsUntilSendData.h: Added.
(WebCore::PCM::AttributionSecondsUntilSendData::hasValidSecondsUntilSendValues):
(WebCore::PCM::AttributionSecondsUntilSendData::minSecondsUntilSend):
(WebCore::PCM::AttributionSecondsUntilSendData::encode const):
(WebCore::PCM::AttributionSecondsUntilSendData::decode):
* Source/WebCore/loader/AttributionTimeToSendData.h: Added.
(WebCore::PCM::AttributionTimeToSendData::earliestTimeToSend):
(WebCore::PCM::AttributionTimeToSendData::latestTimeToSend):
(WebCore::PCM::AttributionTimeToSendData::attributionReportEndpoint):
* Source/WebCore/loader/AttributionTriggerData.cpp: Added.
(WebCore::PCM::AttributionTriggerData::tokenPublicKeyURL const):
(WebCore::PCM::AttributionTriggerData::tokenSignatureURL const):
* Source/WebCore/loader/AttributionTriggerData.h: Added.
(WebCore::PCM::AttributionTriggerData::Priority::Priority):
(WebCore::PCM::AttributionTriggerData::isValid const):
(WebCore::PCM::AttributionTriggerData::setDestinationUnlinkableTokenValue):
(WebCore::PCM::AttributionTriggerData::setDestinationSecretToken):
* Source/WebCore/loader/EphemeralNonce.h: Added.
(WebCore::PCM::EphemeralNonce::isolatedCopy const):
(WebCore::PCM::EphemeralNonce::isolatedCopy):
* Source/WebCore/loader/PCMSites.h: Added.
(WebCore::PCM::SourceSite::SourceSite):
(WebCore::PCM::SourceSite::isolatedCopy const):
(WebCore::PCM::SourceSite::isolatedCopy):
(WebCore::PCM::SourceSite::operator== const):
(WebCore::PCM::SourceSite::operator!= const):
(WebCore::PCM::Sou

[webkit-changes] [WebKit/WebKit] 76836c: [LFC] Remove LineBreakBox layout box type

2022-09-26 Thread Antti Koivisto
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76836cf59fae568337623bc4fce07221efae5abc
  
https://github.com/WebKit/WebKit/commit/76836cf59fae568337623bc4fce07221efae5abc
  Author: Antti Koivisto 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
M Source/WebCore/layout/layouttree/LayoutBox.h
R Source/WebCore/layout/layouttree/LayoutLineBreakBox.cpp
R Source/WebCore/layout/layouttree/LayoutLineBreakBox.h
M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
M Source/WebCore/layout/layouttree/LayoutTreeBuilder.h

  Log Message:
  ---
  [LFC] Remove LineBreakBox layout box type
https://bugs.webkit.org/show_bug.cgi?id=245662


Reviewed by Alan Bujtas.

It can be represented by an element type and doesn't need a separate class.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::handleInlineLevelBox):
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTreeForInlineContent):
* Source/WebCore/layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isLineBreakBox const):
(WebCore::Layout::Box::isWordBreakOpportunity const):
(WebCore::Layout::Box::isInlineTextBox const):
* Source/WebCore/layout/layouttree/LayoutLineBreakBox.cpp: Removed.
* Source/WebCore/layout/layouttree/LayoutLineBreakBox.h: Removed.
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::TreeBuilder::createLineBreakBox): Deleted.
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.h:

Canonical link: https://commits.webkit.org/254860@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 00f23a: [LFC][IFC] Introduce InlineTextItem::isFullyTrimmable

2022-09-26 Thread alan
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00f23a6aaf0bd00e63a042396e69aeb69bf48137
  
https://github.com/WebKit/WebKit/commit/00f23a6aaf0bd00e63a042396e69aeb69bf48137
  Author: Alan Bujtas 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineTextItem.h

  Log Message:
  ---
  [LFC][IFC] Introduce InlineTextItem::isFullyTrimmable
https://bugs.webkit.org/show_bug.cgi?id=245651

Reviewed by Antti Koivisto.

This is in preparation for marking non-breaking-space characters trimmable when 
"-webkit-nbsp-mode: space" is present.

* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::appendTextContent): Call isFullyTrimmable() to check if 
the trailing content could be trimmed.
* Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp:
(WebCore::Layout::InlineTextItem::isFullyTrimmable const):
* Source/WebCore/layout/formattingContexts/inline/InlineTextItem.h:

Canonical link: https://commits.webkit.org/254859@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 60afff: [ews] Add GitHub status-bubble support for PR agai...

2022-09-26 Thread Aakash J
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60afff0cd0b6967758be7361233b1eedc49dc2ba
  
https://github.com/WebKit/WebKit/commit/60afff0cd0b6967758be7361233b1eedc49dc2ba
  Author: Aakash Jain 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/github.py

  Log Message:
  ---
  [ews] Add GitHub status-bubble support for PR against alternate remotes
https://bugs.webkit.org/show_bug.cgi?id=243987


Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHub.update_or_leave_comment_on_pr):
(GitHubEWS.add_or_update_comment_for_change_id):

Canonical link: https://commits.webkit.org/254858@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 5d6977: DOMCache should use ObjectIdentifier

2022-09-26 Thread youennf
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d697791f2e1fb3991e441fbd79f412fcff93c75
  
https://github.com/WebKit/WebKit/commit/5d697791f2e1fb3991e441fbd79f412fcff93c75
  Author: Youenn Fablet 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/Modules/cache/CacheStorageConnection.cpp
M Source/WebCore/Modules/cache/CacheStorageConnection.h
M Source/WebCore/Modules/cache/DOMCache.cpp
M Source/WebCore/Modules/cache/DOMCache.h
M Source/WebCore/Modules/cache/DOMCacheEngine.h
A Source/WebCore/Modules/cache/DOMCacheIdentifier.h
M Source/WebCore/Modules/cache/DOMCacheStorage.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/page/CacheStorageProvider.h
M Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
M Source/WebKit/NetworkProcess/cache/CacheStorageEngine.h
M Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp
M Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h
M Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp
M Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h
M Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp
M Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.h
M 
Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.messages.in
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h

  Log Message:
  ---
  DOMCache should use ObjectIdentifier
https://bugs.webkit.org/show_bug.cgi?id=245378
rdar://problem/100146730

Reviewed by Chris Dumez.

Move from uint64_t to DOMCacheIdentifier to identify DOMCache.
Update WebCore and WebKit structures, as well as the IPC needed bits.

* Source/WebCore/Modules/cache/CacheStorageConnection.cpp:
* Source/WebCore/Modules/cache/CacheStorageConnection.h:
* Source/WebCore/Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::create):
(WebCore::DOMCache::DOMCache):
* Source/WebCore/Modules/cache/DOMCache.h:
* Source/WebCore/Modules/cache/DOMCacheEngine.h:
(WebCore::DOMCacheEngine::CacheIdentifierOperationResult::decode):
* Source/WebCore/Modules/cache/DOMCacheIdentifier.h: Added.
* Source/WebCore/Modules/cache/DOMCacheStorage.cpp:
(WebCore::DOMCacheStorage::doRemove):
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::open):
(WebCore::WorkerCacheStorageConnection::openCompleted):
(WebCore::WorkerCacheStorageConnection::remove):
(WebCore::WorkerCacheStorageConnection::removeCompleted):
(WebCore::WorkerCacheStorageConnection::retrieveRecords):
(WebCore::WorkerCacheStorageConnection::batchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::batchPutOperation):
(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):
(WebCore::WorkerCacheStorageConnection::clearPendingRequests):
(WebCore::WorkerCacheStorageConnection::openOrRemoveCompleted): Deleted.
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/CacheStorageProvider.h:
* Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::remove):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::lock):
(WebKit::CacheStorage::Engine::unlock):
(WebKit::CacheStorage::Engine::readCache):
(WebKit::CacheStorage::Engine::cache):
* Source/WebKit/NetworkProcess/cache/CacheStorageEngine.h:
(WebKit::CacheStorage::Engine::salt const):
(WebKit::CacheStorage::Engine::nextCacheIdentifier): Deleted.
* Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp:
(WebKit::CacheStorage::Cache::Cache):
* Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:
(WebKit::CacheStorage::Cache::identifier const):
* Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
* Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h:
* Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::retrieveRecords):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::put

[webkit-changes] [WebKit/WebKit] 156274: Merge 254848@main - Hulu.com content is stretched ...

2022-09-26 Thread Philippe Normand
  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 15627421d9c2dbde893679099050316fa4603796
  
https://github.com/WebKit/WebKit/commit/15627421d9c2dbde893679099050316fa4603796
  Author: Jer Noble 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h

  Log Message:
  ---
  Merge 254848@main - Hulu.com content is stretched when moving to next episode
https://bugs.webkit.org/show_bug.cgi?id=245641


Reviewed by Eric Carlson.

As a prelude: at some point, WebKit fixed a bug where the `object-fit` CSS 
property was not honored
if set before media began loading in a HTMLVideoElement. Hulu.com sets it's 
video element's
`object-fit:` style to `fill`. When Hulu.com navigates to the next episode in a 
playlist, it resets
the 's `width:` and `height:` style to 100%, causing the video to 
stretch visibly. Previous
to the mentioned fix, this bug would "hide" this behavior, by causing the 
renderer to ignore `fill`
and default to `contain`.

Add a quirk for Hulu.com that reverts to the previous (broken) behavior.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateMediaPlayer):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsVideoShouldMaintainAspectRatioQuirk const):
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/254848@main

(cherry picked from commit 249fdd9c0f8bf064190f69a2791917b762922bee)


  Commit: e362e6b6f47fb0f8682e81bf696c11c6a04406bf
  
https://github.com/WebKit/WebKit/commit/e362e6b6f47fb0f8682e81bf696c11c6a04406bf
  Author: Philippe Normand 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Tools/glib/apply-build-revision-to-files.py

  Log Message:
  ---
  Merge 254851@main - [GLib] Modernize 
Tools/glib/apply-build-revision-to-files.py
https://bugs.webkit.org/show_bug.cgi?id=242191


Reviewed by Michael Catanzaro.

Switch back to git log parsing, as before 252012@main. Using webkitpy was not a 
great idea for two
reasons:

- autoinstall kicking off during offline builds and failing
- SSL issues in buildroot setups.

* Tools/glib/apply-build-revision-to-files.py:
(get_revision_from_most_recent_git_commit):
(get_build_revision):
(main):

Canonical link: https://commits.webkit.org/254851@main

(cherry picked from commit 792d6325aedb3d164f2f4a2d139523b0f7ffab02)


Compare: https://github.com/WebKit/WebKit/compare/9980be90d8de...e362e6b6f47f
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 7ff01e: Thread safety analysis can not use assertion that ...

2022-09-26 Thread Kimmo Kinnunen
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ff01e452a8ce4b9e086eeb48a3d8843b0ebb3a1
  
https://github.com/WebKit/WebKit/commit/7ff01e452a8ce4b9e086eeb48a3d8843b0ebb3a1
  Author: Kimmo Kinnunen 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WTF/wtf/RunLoop.h
M Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp

  Log Message:
  ---
  Thread safety analysis can not use assertion that a RunLoop is current
https://bugs.webkit.org/show_bug.cgi?id=245565
rdar://problem/100313515

Reviewed by Antti Koivisto.

Make it possible to assert that a run loop is current by using
assertIsCurrent(m_runLoop);

This enables thread safety analysis to enforce that a particular access is 
allowed
only on a particular run loop.

* Source/WTF/wtf/RunLoop.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
* Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/254856@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] d628ab: [GStreamer][MSE] Build warning in AppendPipeline

2022-09-26 Thread Philippe Normand
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d628ab1f73d4115209cf29cf0f41b524e31b01ba
  
https://github.com/WebKit/WebKit/commit/d628ab1f73d4115209cf29cf0f41b524e31b01ba
  Author: Philippe Normand 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h

  Log Message:
  ---
  [GStreamer][MSE] Build warning in AppendPipeline
https://bugs.webkit.org/show_bug.cgi?id=245637

Reviewed by Xabier Rodriguez-Calvar.

Follow-up after 254788@main fixing build warnings.

* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::recycleTrackForPad):
(WebCore::AppendPipeline::Track::emplaceOptionalParserForFormat):
(WebCore::AppendPipeline::Track::initializeElements):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:

Canonical link: https://commits.webkit.org/254855@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 90420b: [WK2] Remove uses of SendSyncLegacyResult-based Au...

2022-09-26 Thread Žan Doberšek
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90420b3f4aff59afd876a796b877343ac2e13f12
  
https://github.com/WebKit/WebKit/commit/90420b3f4aff59afd876a796b877343ac2e13f12
  Author: Žan Doberšek 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

  Log Message:
  ---
  [WK2] Remove uses of SendSyncLegacyResult-based 
AuxiliaryProcessProxy::sendSync() overload
https://bugs.webkit.org/show_bug.cgi?id=245591

Reviewed by Kimmo Kinnunen.

Remove one remaining use of AuxiliaryProcessProxy::sendSync() method overload 
that returns
a SendSyncLegacyResult object, enabling complete removal of that method and the 
type alias.

* Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:
(WebKit::AuxiliaryProcessProxy::send):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applyAutocorrection):

Canonical link: https://commits.webkit.org/254854@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 99c973: [WK2] Remove uses of SendSyncLegacyResult-based Co...

2022-09-26 Thread Žan Doberšek
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99c97361f04cd5a5681e6ecb61518b5ecfa03d16
  
https://github.com/WebKit/WebKit/commit/99c97361f04cd5a5681e6ecb61518b5ecfa03d16
  Author: Žan Doberšek 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm

  Log Message:
  ---
  [WK2] Remove uses of SendSyncLegacyResult-based Connection::sendSync() under 
WebProcess/WebCoreSupport/
https://bugs.webkit.org/show_bug.cgi?id=245635

Reviewed by Kimmo Kinnunen.

Replace uses of SendSyncLegacyResult-returning Connection::sendSync() method 
with the
non-legacy variant, adjusting retrieval of reply values in each case. This 
patch does
so for uses under the WebProcess/WebCoreSupport/ directory.

* Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::allStringsForType):
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::color):
(WebKit::WebPlatformStrategies::url):
(WebKit::WebPlatformStrategies::addTypes):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setURL):
(WebKit::WebPlatformStrategies::setColor):
(WebKit::WebPlatformStrategies::setStringForType):
(WebKit::WebPlatformStrategies::getNumberOfFiles):
(WebKit::WebPlatformStrategies::containsURLStringSuitableForLoading):
(WebKit::WebPlatformStrategies::urlStringSuitableForLoading):
(WebKit::WebPlatformStrategies::types):
(WebKit::WebPlatformStrategies::readTextFromClipboard):
(WebKit::WebPlatformStrategies::readFilePathsFromClipboard):
(WebKit::WebPlatformStrategies::readBufferFromClipboard):
(WebKit::WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
(WebKit::WebPlatformStrategies::writeCustomData):
(WebKit::WebPlatformStrategies::containsStringSafeForDOMToReadForType):
(WebKit::WebPlatformStrategies::getPasteboardItemsCount):
(WebKit::WebPlatformStrategies::allPasteboardItemInfo):
(WebKit::WebPlatformStrategies::informationForItemAtIndex):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
(WebKit::WebPlatformStrategies::readURLFromPasteboard):
(WebKit::WebPlatformStrategies::readStringFromPasteboard):
* Source/WebKit/WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::loadRecentSearches):
* Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:
(WebKit::WebSpeechSynthesisClient::voiceList):
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:
(WebKit::WebAlternativeTextClient::dismissAlternativeSoon):
(WebKit::WebAlternativeTextClient::dictationAlternatives):
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::substitutionsPanelIsShowing):

Canonical link: https://commits.webkit.org/254853@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] cf0cfb: Remove SVGZoomEvent

2022-09-26 Thread Rob Buis
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf0cfbaf1ad7728a145c06e3539170870bbb913f
  
https://github.com/WebKit/WebKit/commit/cf0cfbaf1ad7728a145c06e3539170870bbb913f
  Author: Rob Buis 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M LayoutTests/fast/dom/wrapper-classes.html
M LayoutTests/fast/events/event-creation-expected.txt
M LayoutTests/fast/events/event-creation.html
M 
LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/svg/historical-expected.txt
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt
M 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt
M LayoutTests/svg/custom/global-constructors-expected.txt
M LayoutTests/svg/custom/global-constructors.html
R LayoutTests/svg/custom/immutable-properties-expected.txt
R LayoutTests/svg/custom/immutable-properties.html
M LayoutTests/svg/dom/svg2-inheritance-expected.txt
M LayoutTests/svg/dom/svg2-inheritance.html
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/EventNames.in
R Source/WebCore/svg/SVGZoomEvent.cpp
R Source/WebCore/svg/SVGZoomEvent.h
R Source/WebCore/svg/SVGZoomEvent.idl

  Log Message:
  ---
  Remove SVGZoomEvent
https://bugs.webkit.org/show_bug.cgi?id=216206

Reviewed by Cameron McCormack.

Remove SVGZoomEvent support since it is removed from
the specification and from Chrome and Firefox.

* LayoutTests/fast/dom/wrapper-classes.html:
* LayoutTests/fast/events/event-creation-expected.txt:
* LayoutTests/fast/events/event-creation.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/historical-expected.txt:
* LayoutTests/svg/custom/global-constructors-expected.txt:
* LayoutTests/svg/custom/global-constructors.html:
* LayoutTests/svg/dom/svg2-inheritance-expected.txt:
* LayoutTests/svg/dom/svg2-inheritance.html:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::createEvent):
* Source/WebCore/dom/EventNames.in:
* Source/WebCore/svg/SVGZoomEvent.cpp: Removed.
* Source/WebCore/svg/SVGZoomEvent.h: Removed.
* Source/WebCore/svg/SVGZoomEvent.idl: Removed.

Canonical link: https://commits.webkit.org/254852@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 792d63: [GLib] Modernize Tools/glib/apply-build-revision-t...

2022-09-26 Thread Philippe Normand
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 792d6325aedb3d164f2f4a2d139523b0f7ffab02
  
https://github.com/WebKit/WebKit/commit/792d6325aedb3d164f2f4a2d139523b0f7ffab02
  Author: Philippe Normand 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M Tools/glib/apply-build-revision-to-files.py

  Log Message:
  ---
  [GLib] Modernize Tools/glib/apply-build-revision-to-files.py
https://bugs.webkit.org/show_bug.cgi?id=242191


Reviewed by Michael Catanzaro.

Switch back to git log parsing, as before 252012@main. Using webkitpy was not a 
great idea for two
reasons:

- autoinstall kicking off during offline builds and failing
- SSL issues in buildroot setups.

* Tools/glib/apply-build-revision-to-files.py:
(get_revision_from_most_recent_git_commit):
(get_build_revision):
(main):

Canonical link: https://commits.webkit.org/254851@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 35a0ba: [web-animations] additive/accumulative color blend...

2022-09-26 Thread Sam Weinig
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35a0ba08385cfdc1e374a1622a229ccbe618f0ed
  
https://github.com/WebKit/WebKit/commit/35a0ba08385cfdc1e374a1622a229ccbe618f0ed
  Author: Sam Weinig 
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt
M Source/WebCore/platform/graphics/ColorBlending.cpp
M Source/WebCore/platform/graphics/ColorInterpolation.h

  Log Message:
  ---
  [web-animations] additive/accumulative color blending fails to yield 
intermediary out-of-bounds values
https://bugs.webkit.org/show_bug.cgi?id=242185


Reviewed by Antoine Quint.

Additive (and Accumulative, which is identical for colors) blending in web 
animations is
implemented by calling the blend function two extra times:

1. First to add the 'base' color to the 'from' color, giving us 'additive-from'.
e.g. blend(base, from, add-operation)
2. Second to add the 'base' color to the 'to' color, giving us the 
'additive-to'.
e.g. blend(base, to, add-operation)

It then interpolates 'additive-from' to 'additive-to', using the normal, 
'replace', blend
path. Further, it expects 'additive-from' and 'additive-to' to be unclamped 
color values.

To support this scheme, the blend function for Color was updated to implement 
support for
the add operation, using a new addColorComponents helper (which is just a 
wrapper around
interpolatColorComponents that specifies 100% of each color) which uses 
ExtendedSRGBA to
avoid clamping. The normal, replace, blend path was changed to use the now 
standard color
interpolation function, interpolateColorComponents, which supports all 
interpolation methods
not just SRGB, to make it match convention. To maintain compatability with 
existing animmation
interpolation, the result of the replace blend is clipped to the sRGB gamut. 
This clipping
is suspect, but the tests currently require this. Additional discussion with 
the WG is
needed to deterimine the best path forward.

* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* Source/WebCore/platform/graphics/ColorBlending.cpp:
(WebCore::blend):
* Source/WebCore/platform/graphics/ColorInterpolation.h:
(WebCore::interpolateAlphaPremulitplied): Add a clamp, needed for the additive 
blend, as alpha > 1 doesn't really make sense.
(WebCore::addColorComponents):

Canonical link: https://commits.webkit.org/254850@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes