[webkit-changes] [WebKit/WebKit] 01ef15: Refactor some networkConnectionIntegrity codepaths...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01ef15458eb22521f5b457c37a407abe6fa90311 https://github.com/WebKit/WebKit/commit/01ef15458eb22521f5b457c37a407abe6fa90311 Author: Wenson Hsieh Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/inspector/agents/WebConsoleAgent.cpp M Source/WebCore/platform/network/cf/ResourceError.h M Source/WebCore/platform/network/mac/ResourceErrorMac.mm Log Message: --- Refactor some networkConnectionIntegrity codepaths for handling resource errors https://bugs.webkit.org/show_bug.cgi?id=246530 rdar://100523322 Reviewed by Devin Rousso. Add a flag on `ResourceError` to indicate that the resource error occurred, due to having undesired effects on network connection integrity. We consult this bit in `WebConsoleAgent` when logging a console message corresponding to this loading error, in order to provide an alternate message for the developer. * Source/WebCore/inspector/agents/WebConsoleAgent.cpp: (WebCore::networkConnectionIntegrityErrorMessage): (WebCore::WebConsoleAgent::didFailLoading): * Source/WebCore/platform/network/cf/ResourceError.h: (WebCore::ResourceError::compromisedNetworkConnectionIntegrity const): * Source/WebCore/platform/network/mac/ResourceErrorMac.mm: (dueToCompromisingNetworkConnectionIntegrity): (WebCore::ResourceError::platformLazyInit): Canonical link: https://commits.webkit.org/255572@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c269b6: [WGSL] Add a helper to aid working with vectors of...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c269b69a8c430e567650d4aae01bf65cbd3129de https://github.com/WebKit/WebKit/commit/c269b69a8c430e567650d4aae01bf65cbd3129de Author: Dan Glastonbury Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt A Source/WTF/wtf/UniqueRefVector.h M Tools/TestWebKitAPI/CMakeLists.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WTF/UniqueRefVector.cpp Log Message: --- [WGSL] Add a helper to aid working with vectors of AST nodes https://bugs.webkit.org/show_bug.cgi?id=246500 rdar://problem/101156657 Reviewed by Myles C. Maxfield. Introduce UniqueRefs; an adapter over Vector> to make working with collections of AST nodes more natural. Tested by TestWebKitAPI/Tests/WTF/UniqueRefVector.cpp * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/CMakeLists.txt: * Source/WTF/wtf/UniqueRefVector.h: Added. * Tools/TestWebKitAPI/CMakeLists.txt: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WTF/UniqueRefVector.cpp: Added. Canonical link: https://commits.webkit.org/255571@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4761d: [Gardening] Unmark some WPT as failing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4761d301f11235ed20f6aa45810a593553f545d https://github.com/WebKit/WebKit/commit/a4761d301f11235ed20f6aa45810a593553f545d Author: Tim Nguyen Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/gtk/TestExpectations Log Message: --- [Gardening] Unmark some WPT as failing https://bugs.webkit.org/show_bug.cgi?id=246557 rdar://101198083 Unreviewed test gardening. - css/css-fonts/font-variant-02.html: Fixed by recent Interop 2022 font-variant work + small-caps changes - css/css-ui/outline-005.html: Fixed by https://commits.webkit.org/255300@main - css/css-ui/outline-007.html: ? - css/css-ui/outline-021.html: Was first imported when we didn't support WPT mismatch tests - css/css-ui/outline-offset-table-001.html: Was first imported when we didn't support WPT mismatch tests * LayoutTests/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/255570@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 326e3e: Move :nth-child(X of Y) and :nth-last-child(X of Y...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 326e3efa211fe275c6bcdaed58121f8ab4045f3b https://github.com/WebKit/WebKit/commit/326e3efa211fe275c6bcdaed58121f8ab4045f3b Author: Tim Nguyen Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: R LayoutTests/fast/css/nth-child-and-nth-last-child-expected.html R LayoutTests/fast/css/nth-child-and-nth-last-child.html R LayoutTests/fast/css/nth-child-of-classname-expected.html R LayoutTests/fast/css/nth-child-of-classname.html R LayoutTests/fast/css/nth-child-of-complex-selector-expected.html R LayoutTests/fast/css/nth-child-of-complex-selector.html R LayoutTests/fast/css/nth-child-of-compound-selector-expected.html R LayoutTests/fast/css/nth-child-of-compound-selector.html R LayoutTests/fast/css/nth-child-of-tagname-expected.html R LayoutTests/fast/css/nth-child-of-tagname.html R LayoutTests/fast/css/nth-child-specificity-1-expected.html R LayoutTests/fast/css/nth-child-specificity-1.html R LayoutTests/fast/css/nth-child-specificity-2-expected.html R LayoutTests/fast/css/nth-child-specificity-2.html R LayoutTests/fast/css/nth-child-specificity-3-expected.html R LayoutTests/fast/css/nth-child-specificity-3.html R LayoutTests/fast/css/nth-child-specificity-4-expected.html R LayoutTests/fast/css/nth-child-specificity-4.html R LayoutTests/fast/css/nth-last-child-of-classname-expected.html R LayoutTests/fast/css/nth-last-child-of-classname.html R LayoutTests/fast/css/nth-last-child-of-complex-selector-expected.html R LayoutTests/fast/css/nth-last-child-of-complex-selector.html R LayoutTests/fast/css/nth-last-child-of-compound-selector-expected.html R LayoutTests/fast/css/nth-last-child-of-compound-selector.html R LayoutTests/fast/css/nth-last-child-of-style-sharing-1-expected.html R LayoutTests/fast/css/nth-last-child-of-style-sharing-1.html R LayoutTests/fast/css/nth-last-child-of-style-sharing-2-expected.html R LayoutTests/fast/css/nth-last-child-of-style-sharing-2.html R LayoutTests/fast/css/nth-last-child-of-tagname-expected.html R LayoutTests/fast/css/nth-last-child-of-tagname.html R LayoutTests/fast/css/nth-last-child-specificity-1-expected.html R LayoutTests/fast/css/nth-last-child-specificity-1.html R LayoutTests/fast/css/nth-last-child-specificity-2-expected.html R LayoutTests/fast/css/nth-last-child-specificity-2.html R LayoutTests/fast/css/nth-last-child-specificity-3-expected.html R LayoutTests/fast/css/nth-last-child-specificity-3.html R LayoutTests/fast/css/nth-last-child-specificity-4-expected.html R LayoutTests/fast/css/nth-last-child-specificity-4.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-and-nth-last-child-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-and-nth-last-child-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-and-nth-last-child.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-classname-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-classname-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-classname.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-complex-selector-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-complex-selector-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-complex-selector.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-compound-selector-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-compound-selector-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-compound-selector.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-tagname-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-tagname-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-tagname.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-specificity-1-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-specificity-1-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-specificity-1.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-specificity-2-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-specificity-2-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-specificity-2.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-specificity-3-expected.html A LayoutTests/imported/w3c/web-
[webkit-changes] [WebKit/WebKit] 62160d: Support loading Web Extension URLs and load the ba...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 62160da965fce1b9c4054c0f212660ccfb05726e https://github.com/WebKit/WebKit/commit/62160da965fce1b9c4054c0f212660ccfb05726e Author: Timothy Hatcher Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/en.lproj/Localizable.strings M Source/WebKit/Shared/WebPageCreationParameters.cpp M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm M Source/WebKit/UIProcess/Cocoa/WebURLSchemeHandlerCocoa.h M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm A Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionURLSchemeHandlerCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtension.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionController.h A Source/WebKit/UIProcess/Extensions/WebExtensionURLSchemeHandler.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebURLSchemeHandler.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionController.mm Log Message: --- Support loading Web Extension URLs and load the background page or service worker. https://bugs.webkit.org/show_bug.cgi?id=246409 Reviewed by Brian Weinstein. This also adds _WKWebExtensionController to WKWebViewConfiguration and propagate through to WebPage. * Source/WebCore/en.lproj/Localizable.strings: Updated with update-webkit-localizable-strings. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView urlSchemeHandlerForURLScheme:]): Deleted. Dead code, not used or exposed in any header. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration urlSchemeHandlerForURLScheme:]): Only return API handlers. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext setBaseURL:]): Added more assertions. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm: (-[_WKWebExtensionController extensionContextForExtension:]): Added baseURL version. * Source/WebKit/UIProcess/Cocoa/WebURLSchemeHandlerCocoa.h: * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::isAccessibleResourcePath): Added with FIXME. (WebKit::WebExtension::resourceDataForPath): Remove "/" prefix. (WebKit::toAPI): Added. (WebKit::WebExtension::createError): Use toAPI. (WebKit::WebExtension::removeError): Added. (WebKit::WebExtension::recordError): Dispatch notifications async to avoid reentrancy. (WebKit::WebExtension::backgroundContentPath): Added. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (-[_WKWebExtensionContextDelegate initWithWebExtensionContext:]): Added. (-[_WKWebExtensionContextDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Added. (-[_WKWebExtensionContextDelegate webView:didFinishNavigation:]): Added. (-[_WKWebExtensionContextDelegate webView:didFailNavigation:withError:]): Added. (-[_WKWebExtensionContextDelegate webViewWebContentProcessDidTerminate:]): Added. (WebKit::WebExtensionContext::WebExtensionContext): Create m_delegate. (WebKit::toAPI): Added. (WebKit::WebExtensionContext::createError): Use toAPI and added BaseURLTaken case. (WebKit::WebExtensionContext::load): Call loadBackgroundWebViewDuringLoad. (WebKit::WebExtensionContext::unload): Call unloadBackgroundWebView. (WebKit::WebExtensionContext::setBaseURL): Canonicalize URL scheme. (WebKit::WebExtensionContext::postAsyncNotification): Use makeBlockPtr to be safe in C++. (WebKit::WebExtensionContext::webViewConfiguration): Added. (WebKit::WebExtensionContext::backgroundContentURL): Added. (WebKit::WebExtensionContext::loadBackgroundWebViewDuringLoad): Added. (WebKit::WebExtensionContext::loadBackgroundWebView): Added. (WebKit::WebExtensionContext::unloadBackgroundWebView): Added. (WebKit::WebExtensionContext::performTasksAfterBackgroundContentLoads): Added. (WebKit::WebExtensionContext::decidePolicyForNavigationAction): Added. (WebKit::WebExtensionContext::didFinishNavigation): Added. (W
[webkit-changes] [WebKit/WebKit] 384c2c: Fix unused-but-set-variable warning in WebGL code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 384c2cdb8b944c4e991083d0be937928654a191f https://github.com/WebKit/WebKit/commit/384c2cdb8b944c4e991083d0be937928654a191f Author: Don Olmstead Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp Log Message: --- Fix unused-but-set-variable warning in WebGL code https://bugs.webkit.org/show_bug.cgi?id=246538 Reviewed by Tim Nguyen. * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: Canonical link: https://commits.webkit.org/255567@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f023f: [LFC][IFC] Fix fast/block/float/floats-offset-imag...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f023fa75e143cdc2eaff4c4f54c2cf04cb4066b https://github.com/WebKit/WebKit/commit/1f023fa75e143cdc2eaff4c4f54c2cf04cb4066b Author: Alan Bujtas Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: A LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode-expected.html A LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode.html M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h Log Message: --- [LFC][IFC] Fix fast/block/float/floats-offset-image-quirk-lineheight.html https://bugs.webkit.org/show_bug.cgi?id=246424 Reviewed by Antti Koivisto. The initial line height in quirks mode (where there's no imaginary strut on the line) is 0. It fixes inline content positioning when intrusive floats are present, where the inline content (e.g. ) is not as tall as the computed line height. |||| - || vs.|| | img | -- -- | img | - | | - | | --- ^^ tall line prevents us from placing the next to the upper float box. * LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode-expected.html: Added. * LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp: (WebCore::Layout::InlineFormattingGeometry::initialLineHeight const): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp: (WebCore::Layout::InlineFormattingQuirks::initialLineHeight const): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h: Canonical link: https://commits.webkit.org/255566@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8574b9: [WebInspector] Display OpenGL object ids in canvas...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8574b90773edf4ffb2bd7f9c5fd1b361cef52360 https://github.com/WebKit/WebKit/commit/8574b90773edf4ffb2bd7f9c5fd1b361cef52360 Author: Dan Glastonbury Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/inspector/canvas/recording-webgl-full-expected.txt M LayoutTests/inspector/canvas/recording-webgl-snapshots-expected.txt M LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-full-expected.txt M LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-snapshots-expected.txt M LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-full-expected.txt M LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-snapshots-expected.txt M Source/WebCore/inspector/InspectorCanvas.cpp M Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.css M Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js Log Message: --- [WebInspector] Display OpenGL object ids in canvas inspector https://bugs.webkit.org/show_bug.cgi?id=246186 rdar://problem/100875691 Reviewed by Devin Rousso and Dean Jackson. Record the underlying OpenGL object id associated with each WebGL object and display these ids along with the WebGL object type in WebInspector canvas inspector mode to aid determining which objects are being referred to in the call trace. * LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-full-expected.txt: * LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-snapshots-expected.txt: * LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-full-expected.txt: * LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-snapshots-expected.txt: * Source/WebCore/inspector/InspectorCanvas.cpp: (WebCore::InspectorCanvas::processArgument): * Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js: (WI.RecordingActionTreeElement._generateDOM.createParameterElement): (WI.RecordingActionTreeElement._generateDOM): Canonical link: https://commits.webkit.org/255565@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f59283: Modified regex to ignore commit id when it is part...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f59283656141034416306865126f382c4cbcf8b5 https://github.com/WebKit/WebKit/commit/f59283656141034416306865126f382c4cbcf8b5 Author: Ling Ho Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Websites/bugs.webkit.org/extensions/Commits/Extension.pm Log Message: --- Modified regex to ignore commit id when it is part of a range URL (starts with https://). https://bugs.webkit.org/show_bug.cgi?id=246478 rdar://98541419 Reviewed by Ryan Haddad. * Websites/bugs.webkit.org/extensions/Commits/Extension.pm: (bug_format_comment): Canonical link: https://commits.webkit.org/255564@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 691e28: [Gardening]: [ iOS ] animations/steps-transform-re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 691e28228b26842a39f1ba2958b5e57bb9577121 https://github.com/WebKit/WebKit/commit/691e28228b26842a39f1ba2958b5e57bb9577121 Author: Hercules Hjalmarsson Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [Gardening]: [ iOS ] animations/steps-transform-rendering-updates.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=246547 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/255563@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac05c3: [Win] fast/events/mouse-cursor-multiframecur.html ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac05c3c8005398a261ddeb9705a7611af2cb952a https://github.com/WebKit/WebKit/commit/ac05c3c8005398a261ddeb9705a7611af2cb952a Author: Ryan Haddad Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/platform/win/TestExpectations Log Message: --- [Win] fast/events/mouse-cursor-multiframecur.html is consistently failing https://bugs.webkit.org/show_bug.cgi?id=246544 rdar://101188656 Unreviewed test gardening. * LayoutTests/platform/win/TestExpectations: Canonical link: https://commits.webkit.org/255562@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 611f65: Show file names next to file inputs on iOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 611f6582b24af3e95e5bfadb7de0d568084a1ffa https://github.com/WebKit/WebKit/commit/611f6582b24af3e95e5bfadb7de0d568084a1ffa Author: Richard Robinson Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm Log Message: --- Show file names next to file inputs on iOS https://bugs.webkit.org/show_bug.cgi?id=245996 rdar://100741418 Reviewed by Aditya Keerthi. On iOS, when uploading a single image or video, the current behavior is to use "1 image" or "1 video" as its display name. This PR changes this behavior to match macOS, which is to display the file's name. * Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel _chooseMediaItems:]): Canonical link: https://commits.webkit.org/255561@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2ca681: Add setting to disable the fullscreen requirement ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2ca6817c090a1012544584e4e0f0b54782533e6a https://github.com/WebKit/WebKit/commit/2ca6817c090a1012544584e4e0f0b54782533e6a Author: Chris Dumez Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml M Source/WebCore/page/ScreenOrientation.cpp M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h Log Message: --- Add setting to disable the fullscreen requirement to lock screen orientation https://bugs.webkit.org/show_bug.cgi?id=246528 Reviewed by Wenson Hsieh. Add setting to disable the fullscreen requirement to lock screen orientation. This will be useful for Home Screen Web Apps, which are technically fullscreen but don't rely on the fullscreen API. * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: * Source/WebCore/page/ScreenOrientation.cpp: (WebCore::ScreenOrientation::lock): * Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _setRequiresFullscreenToLockScreenOrientation:]): (-[WKPreferences _requiresFullscreenToLockScreenOrientation]): * Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h: Canonical link: https://commits.webkit.org/255560@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a8abec: [JSC] Add uDFG validation phase
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8abeceb624b2e05bf50884a32835c856e1f4a2d https://github.com/WebKit/WebKit/commit/a8abeceb624b2e05bf50884a32835c856e1f4a2d Author: Yusuke Suzuki Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/Sources.txt M Source/JavaScriptCore/dfg/DFGPlan.cpp A Source/JavaScriptCore/dfg/DFGValidateUnlinked.cpp A Source/JavaScriptCore/dfg/DFGValidateUnlinked.h M Source/JavaScriptCore/runtime/OptionsList.h Log Message: --- [JSC] Add uDFG validation phase https://bugs.webkit.org/show_bug.cgi?id=246499 rdar://101154136 Reviewed by Mark Lam. This patch adds uDFG validation phase. This allows graceful failure of the compilation if we accidentally include some linked data in DFG pipeline by enhancing this phase. And at the same time, we can detect what is wrong in the given program and improve our uDFG quality incrementally. Currently, we add a first restriction: all DFG node should have the same origin to the top level CodeBlock to make the code easy. This paves the way to the initial version of LinkerIR::GlobalObject. We can enhance it, but it is postponed since it is not so frequent that we have multiple JSGlobalObject in one DFG function. * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/Sources.txt: * Source/JavaScriptCore/dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl): * Source/JavaScriptCore/dfg/DFGValidateUnlinked.cpp: Added. (JSC::DFG::ValidateUnlinked::run): (JSC::DFG::ValidateUnlinked::validateNode): (JSC::DFG::performValidateUnlinked): * Source/JavaScriptCore/dfg/DFGValidateUnlinked.h: Added. * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/29@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.8.2.1 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86beca: Versioning.
Branch: refs/heads/safari-7615.1.8.2-branch Home: https://github.com/WebKit/WebKit Commit: 86becadcf2f0609817de893276da9b6b18d54f7c https://github.com/WebKit/WebKit/commit/86becadcf2f0609817de893276da9b6b18d54f7c Author: Alan Coon Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.8.2.1 Canonical link: https://commits.webkit.org/255076.11@safari-7615.1.8.2-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 643255: Test gardening for Windows
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 643255b7f7147485ad2564df03fcdcd341c9f236 https://github.com/WebKit/WebKit/commit/643255b7f7147485ad2564df03fcdcd341c9f236 Author: Ryan Haddad Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/platform/win/TestExpectations A LayoutTests/platform/win/accessibility/loading-iframe-updates-axtree-expected.txt A LayoutTests/platform/win/editing/execCommand/insert-list-nested-with-orphaned-live-range-expected.txt A LayoutTests/platform/win/fast/dom/Window/window-appendages-cleared-expected.txt M LayoutTests/platform/win/fast/dom/dom-constructors-expected.txt A LayoutTests/platform/win/fast/dom/null-page-show-modal-dialog-crash-expected.txt A LayoutTests/platform/win/fast/dom/wrapper-identity-expected.txt M LayoutTests/platform/win/performance-api/resource-timing-apis-expected.txt A LayoutTests/platform/win/svg/custom/use-invalid-pattern-expected.txt A LayoutTests/platform/win/svg/custom/use-invalid-style-expected.txt Log Message: --- Test gardening for Windows https://bugs.webkit.org/show_bug.cgi?id=246540 rdar://101187885 Unreviewed test gardening. * LayoutTests/platform/win/TestExpectations: * LayoutTests/platform/win/accessibility/loading-iframe-updates-axtree-expected.txt: Added. * LayoutTests/platform/win/editing/execCommand/insert-list-nested-with-orphaned-live-range-expected.txt: Added. * LayoutTests/platform/win/fast/dom/Window/window-appendages-cleared-expected.txt: Added. * LayoutTests/platform/win/fast/dom/dom-constructors-expected.txt: * LayoutTests/platform/win/fast/dom/null-page-show-modal-dialog-crash-expected.txt: Added. * LayoutTests/platform/win/fast/dom/wrapper-identity-expected.txt: Added. * LayoutTests/platform/win/performance-api/resource-timing-apis-expected.txt: * LayoutTests/platform/win/svg/custom/use-invalid-pattern-expected.txt: Added. * LayoutTests/platform/win/svg/custom/use-invalid-style-expected.txt: Added. Canonical link: https://commits.webkit.org/28@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c39db6: Revert "Update ANGLE to 2022-09-25 (2aa52da7e4c32e...
Branch: refs/heads/safari-7615.1.8.2-branch Home: https://github.com/WebKit/WebKit Commit: c39db662e4e2d4d9668fa3755bcb92f29b5938e0 https://github.com/WebKit/WebKit/commit/c39db662e4e2d4d9668fa3755bcb92f29b5938e0 Author: Alan Coon Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/ThirdParty/ANGLE/ANGLE.plist M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj M Source/ThirdParty/ANGLE/CONTRIBUTORS M Source/ThirdParty/ANGLE/DEPS M Source/ThirdParty/ANGLE/GLESv2.cmake M Source/ThirdParty/ANGLE/build_overrides/vulkan_validation_layers.gni M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/doc/DebuggingTips.md M Source/ThirdParty/ANGLE/doc/ExtensionSupport.md R Source/ThirdParty/ANGLE/extensions/ANGLE_logic_op.txt M Source/ThirdParty/ANGLE/extensions/ANGLE_shader_pixel_local_storage.txt R Source/ThirdParty/ANGLE/extensions/EGL_ANGLE_sync_mtl_shared_event.txt M Source/ThirdParty/ANGLE/include/EGL/eglext_angle.h M Source/ThirdParty/ANGLE/include/GLES2/gl2ext_angle.h M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h M Source/ThirdParty/ANGLE/include/platform/FeaturesMtl_autogen.h M Source/ThirdParty/ANGLE/include/platform/FeaturesVk_autogen.h M Source/ThirdParty/ANGLE/include/platform/mtl_features.json M Source/ThirdParty/ANGLE/include/platform/vk_features.json M Source/ThirdParty/ANGLE/infra/config/generated/cr-buildbucket.cfg M Source/ThirdParty/ANGLE/infra/config/generated/luci-milo.cfg M Source/ThirdParty/ANGLE/infra/config/generated/luci-scheduler.cfg M Source/ThirdParty/ANGLE/infra/config/generated/project.cfg M Source/ThirdParty/ANGLE/infra/config/main.star M Source/ThirdParty/ANGLE/infra/specs/angle.json M Source/ThirdParty/ANGLE/infra/specs/angle_mb_config.pyl M Source/ThirdParty/ANGLE/infra/specs/mixins.pyl M Source/ThirdParty/ANGLE/infra/specs/test_suites.pyl M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_features.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_format.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_load_functions_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_shader_preprocessor.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_shader_translator.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/DXGI_format.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Extension_files.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_WGL_loader.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GLenum_value_to_string_map.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Metal_default_shaders.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Metal_format_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Test_spec_JSON.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_format.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/proc_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/restricted_traces.json M Source/ThirdParty/ANGLE/scripts/egl_angle_ext.xml M Source/ThirdParty/ANGLE/scripts/entry_point_packed_gl_enums.json M Source/ThirdParty/ANGLE/scripts/gen_gl_enum_utils.py M Source/ThirdParty/ANGLE/scripts/generate_android_bp.py M Source/ThirdParty/ANGLE/scripts/generate_entry_points.py M Source/ThirdParty/ANGLE/scripts/gl_angle_ext.xml M Source/ThirdParty/ANGLE/scripts/registry_xml.py M Source/ThirdParty/ANGLE/scripts/roll_aosp.sh M Source/ThirdParty/ANGLE/src/angle_commit.h M Source/ThirdParty/ANGLE/src/common/angle_version.h M Source/ThirdParty/ANGLE/src/common/entry_points_enum_autogen.cpp M Source/ThirdParty/ANGLE/src/common/entry_points_enum_autogen.h M Source/ThirdParty/ANGLE/src/common/linux/dma_buf_utils.cpp M Source/ThirdParty/ANGLE/src/common/linux/dma_buf_utils.h M Source/ThirdParty/ANGLE/src/common/platform.h M Source/ThirdParty/ANGLE/src/common/utilities.cpp M Source/ThirdParty/ANGLE/src/common/utilities.h M Source/ThirdParty/ANGLE/src/compiler/preprocessor/preprocessor.y M Source/ThirdParty/ANGLE/src/compiler/preprocessor/preprocessor_lex_autogen.cpp M Source/ThirdParty/ANGLE/src/compiler/preprocessor/preprocessor_tab_autogen.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/OutputHLSL.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/glslang_tab_autogen.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/glslang_tab_autogen.h
[webkit-changes] [WebKit/WebKit] 3d99c5: Remote Web Inspector: [Cocoa] `inspectable` API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d99c5a137548afb19025ccd16979e9357a8cde7 https://github.com/WebKit/WebKit/commit/3d99c5a137548afb19025ccd16979e9357a8cde7 Author: Patrick Angle Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/JavaScriptCore/API/JSContext.h M Source/JavaScriptCore/API/JSContext.mm M Source/JavaScriptCore/API/JSContextPrivate.h M Source/JavaScriptCore/API/JSContextRef.cpp M Source/JavaScriptCore/API/JSContextRef.h M Source/JavaScriptCore/API/JSContextRefPrivate.h M Source/JavaScriptCore/API/JSRemoteInspector.cpp M Source/JavaScriptCore/API/JSRemoteInspector.h M Source/JavaScriptCore/API/WebKitAvailability.h M Source/JavaScriptCore/API/tests/testIncludes.m M Source/JavaScriptCore/config.h M Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.cpp M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h M Source/JavaScriptCore/inspector/remote/RemoteInspector.h M Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h M Source/WebCore/config.h M Source/WebCore/inspector/InspectorController.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h M Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebKit2Prefix.h M Source/WebKitLegacy/mac/WebView/WebView.mm M Tools/MiniBrowser/mac/WK2BrowserWindowController.m M Tools/MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m M Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm Log Message: --- Remote Web Inspector: [Cocoa] `inspectable` API https://bugs.webkit.org/show_bug.cgi?id=245986 rdar://100736163 Reviewed by Devin Rousso. Add API to allow applications to explicitly mark a WKWebView or JSContext as inspectable. This flips assumptions about inspectability of content. Previously the default state for inspectability was `true`, with a platform-specific deamon making decisions about which applications would actually be inspectable on a system. This patch moves that decision into WebKit/WebCore/JavaScriptCore instead, and flips the default for inspectability to be `false` unless an application would have previously been always-inspectable. Those cases include: - Applications with the `get-task-allow`/`com.apple.security.get-task-allow` development entitlements when linked against an SDK without the API. - Applications with the `com.apple.webinspector.allow`/`com.apple.private.webinspector.allow-remote-inspection` entitlements. These entitlements will no longer be necessary to enable inspection, and instead the new `inspectable` API should be used. * Source/JavaScriptCore/API/JSContext.h: * Source/JavaScriptCore/API/JSContext.mm: (-[JSContext inspectable]): (-[JSContext setInspectable:]): (-[JSContext _remoteInspectionEnabled]): (-[JSContext _setRemoteInspectionEnabled:]): * Source/JavaScriptCore/API/JSContextPrivate.h: * Source/JavaScriptCore/API/JSContextRef.cpp: (JSGlobalContextCreateInGroup): (JSGlobalContextIsInspectable): (JSGlobalContextSetInspectable): (JSGlobalContextGetRemoteInspectionEnabled): (JSGlobalContextSetRemoteInspectionEnabled): * Source/JavaScriptCore/API/JSContextRef.h: * Source/JavaScriptCore/API/JSContextRefPrivate.h: * Source/JavaScriptCore/API/JSRemoteInspector.cpp: (mainProcessHasEntitlement): (defaultStateForRemoteInspectionEnabledByDefault): (JSRemoteInspectorGetInspectionEnabledByDefault): * Source/JavaScriptCore/API/JSRemoteInspector.h: * Source/JavaScriptCore/API/WebKitAvailability.h: * Source/JavaScriptCore/API/tests/testIncludes.m: * Source/JavaScriptCore/config.h: * Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp: (Inspector::JSGlobalObjectInspectorController::developerExtrasEnabled const): * Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.cpp: (Inspector::RemoteInspectionTarget::remoteControlAllowed const): (Inspector::RemoteInspectionTarget::inspectable const): (Ins
[webkit-changes] [WebKit/WebKit] 2a3796: [LFC][IFC] Use the line's margin box rect when pro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a37961edb868f532fe70f3f78ce28485fd32a80 https://github.com/WebKit/WebKit/commit/2a37961edb868f532fe70f3f78ce28485fd32a80 Author: Alan Bujtas Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: A LayoutTests/fast/inline/negative-text-indext-with-float-expected.html A LayoutTests/fast/inline/negative-text-indext-with-float.html M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp Log Message: --- [LFC][IFC] Use the line's margin box rect when probing for intrusive floats https://bugs.webkit.org/show_bug.cgi?id=246527 Reviewed by Antti Koivisto. text-indent acts as (start)margin on the line (per spec). When checking if there's any intrusive float on the current line, we should check against the line's _margin_ box (may sound a bit odd as we don't really have a corresponding _border_ box on the line). This patch converts the line rect to margin rect before calling floatConstraints() and covert the result back to (non-margin)line rect. This is mostly relevant with negative tex-indent values where the inline content may visually overlap the float box (where the margin box is not). * LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode-expected.html: Added. * LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode.html: Added. * LayoutTests/fast/block/out-of-flow-becomes-float-crash-expected.txt: Added. * LayoutTests/fast/block/out-of-flow-becomes-float-crash.html: Added. * LayoutTests/fast/inline/negative-text-indext-with-float-expected.html: Added. * LayoutTests/fast/inline/negative-text-indext-with-float.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::floatConstraints const): (WebCore::Layout::LineBuilder::lineRectForCandidateInlineContent const): Canonical link: https://commits.webkit.org/26@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d6f850: [iOS] Add screen orientation locking / unlocking s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d6f850a7728e6788cfd4947b40ca5ec45976bc7a https://github.com/WebKit/WebKit/commit/d6f850a7728e6788cfd4947b40ca5ec45976bc7a Author: Chris Dumez Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp M Source/WebKit/UIProcess/ios/PageClientImplIOS.h M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- [iOS] Add screen orientation locking / unlocking support outside layout tests https://bugs.webkit.org/show_bug.cgi?id=246435 Reviewed by Wenson Hsieh. Add screen orientation locking / unlocking support outside layout tests, on iOS devices. Outside tests, the fullscreen API uses the WKFullScreenWindowController to display a new fullscreen view on top of the current one. This new view has its own UIViewController that WebKit controls. As a result, when locking the screen orientation (which is gated on being in fullscreen), we need to do so via the WKFullScreenWindowController, instead of relying on the client application. * Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::lockFullscreenOrientation): (WebKit::WebFullScreenManagerProxy::unlockFullscreenOrientation): * Source/WebKit/UIProcess/WebFullScreenManagerProxy.h: (WebKit::WebFullScreenManagerProxyClient::lockFullscreenOrientation): (WebKit::WebFullScreenManagerProxyClient::unlockFullscreenOrientation): * Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp: (WebKit::WebScreenOrientationManagerProxy::lock): (WebKit::WebScreenOrientationManagerProxy::unlock): * Source/WebKit/UIProcess/ios/PageClientImplIOS.h: * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: (WebKit::toUIInterfaceOrientationMask): (WebKit::PageClientImpl::lockFullscreenOrientation): (WebKit::PageClientImpl::unlockFullscreenOrientation): * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController initWithWebView:]): (-[WKFullScreenViewController setSupportedOrientation:]): (-[WKFullScreenViewController supportedInterfaceOrientations]): * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController setSupportedOrientations:]): Canonical link: https://commits.webkit.org/25@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 734d5d: ScrollingThread::dispatchFunctionsFromScrollingThr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 734d5db698bf276f68b0a08d4ac4c7e221f035b4 https://github.com/WebKit/WebKit/commit/734d5db698bf276f68b0a08d4ac4c7e221f035b4 Author: Antoine Quint Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/page/scrolling/ScrollingThread.h Log Message: --- ScrollingThread::dispatchFunctionsFromScrollingThread() is unused and should be removed https://bugs.webkit.org/show_bug.cgi?id=246513 Reviewed by Simon Fraser. * Source/WebCore/page/scrolling/ScrollingThread.h: Canonical link: https://commits.webkit.org/24@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 96ac9c: [JSC] Return JSProxy from createGlobalObject in JS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96ac9c31b19e5671f8c189e49c82e82806bc7f6a https://github.com/WebKit/WebKit/commit/96ac9c31b19e5671f8c189e49c82e82806bc7f6a Author: Yusuke Suzuki Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: A JSTests/stress/do-not-use-global-object-from-create-global-object.js M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/tools/JSDollarVM.cpp Log Message: --- [JSC] Return JSProxy from createGlobalObject in JSC shell https://bugs.webkit.org/show_bug.cgi?id=244546 rdar://99338799 Reviewed by Alexey Shvayka. We should not expose raw JSGlobalObject directly in JSC shell utility. This patch fixes it. * JSTests/stress/do-not-use-global-object-from-create-global-object.js: Added. (__c_0): (__c_1): * Source/JavaScriptCore/jsc.cpp: (JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/23@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 92626c: [JSC] Integrate constant folding for StringSlice
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92626c6d115a104a3ad50e0eb1d9f2278a638fa2 https://github.com/WebKit/WebKit/commit/92626c6d115a104a3ad50e0eb1d9f2278a638fa2 Author: Yusuke Suzuki Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: A JSTests/microbenchmarks/string-slice-constants-binary.js A JSTests/microbenchmarks/string-slice-constants-identity.js A JSTests/microbenchmarks/string-slice-constants.js A JSTests/microbenchmarks/string-slice-empty-constant-folding.js A JSTests/microbenchmarks/string-slice-length-constant.js A JSTests/microbenchmarks/string-slice2.js A JSTests/microbenchmarks/string-starts-with-mod-prototype-slice.js M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/runtime/StringPrototype.cpp M Source/JavaScriptCore/runtime/StringPrototypeInlines.h Log Message: --- [JSC] Integrate constant folding for StringSlice https://bugs.webkit.org/show_bug.cgi?id=246433 rdar://problem/101107093 Reviewed by Alexey Shvayka. This patch applies StringSubstring optimization to StringSlice. We add strength reduction for StringSlice so that we can compute constant strings. We also enhance existing optimization to capture more cases: generating empty string if from and to are the same. ToT Patched string-slice-constants-binary 16.9754+-0.2657 ^ 10.8552+-0.2213^ definitely 1.5638x faster string-slice-empty 4.3653+-0.1431 4.2705+-0.0257 might be 1.0222x faster string-slice-constants17.1748+-0.2821 ^ 6.8719+-0.0946^ definitely 2.4993x faster string-slice-one-char 4.7544+-0.0539 4.7483+-0.0480 string-slice2 18.0453+-0.0894 17.9867+-0.0282 string-slice-constants-identity6.4399+-0.0305 ^ 2.9076+-0.0162^ definitely 2.2149x faster string-slice-empty-constant-folding3.7372+-0.0237 ^ 3.6572+-0.0245^ definitely 1.0219x faster string-slice-length-constant 17.0568+-0.0695 ^ 6.8520+-0.0438^ definitely 2.4893x faster string-slice 13.6193+-0.0590 ? 13.6565+-0.1618? * JSTests/microbenchmarks/string-slice-constants-binary.js: Added. (shouldBe): (test1): * JSTests/microbenchmarks/string-slice-constants-identity.js: Added. (shouldBe): (test1): * JSTests/microbenchmarks/string-slice-constants.js: Added. (shouldBe): (test1): * JSTests/microbenchmarks/string-slice-length-constant.js: Added. (shouldBe): (test1): * JSTests/microbenchmarks/string-slice2.js: Added. (shouldBe): (test1): * JSTests/microbenchmarks/string-starts-with-mod-prototype-slice.js: Added. (shouldBe): (String.prototype._startsWith): (test1): (test2): * Source/JavaScriptCore/dfg/DFGOperations.cpp: (JSC::DFG::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/dfg/DFGOperations.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileStringSlice): * Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp: (JSC::DFG::StrengthReductionPhase::handleNode): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): * Source/JavaScriptCore/runtime/StringPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/StringPrototypeInlines.h: (JSC::extractSliceOffsets): (JSC::stringSlice): (JSC::stringSubstring): Canonical link: https://commits.webkit.org/22@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 970290: Update some Element::requestFullscreen() preflight...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 970290aca193e94b34c64d5c490e66e01422833a https://github.com/WebKit/WebKit/commit/970290aca193e94b34c64d5c490e66e01422833a Author: Tim Nguyen Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-dialog-expected.txt M Source/WebCore/dom/FullscreenManager.cpp Log Message: --- Update some Element::requestFullscreen() preflight checks https://bugs.webkit.org/show_bug.cgi?id=246293 Reviewed by Jer Noble. - Align old & new fullscreen API codepaths - Add element check per-spec https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen * LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-dialog-expected.txt: * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::requestFullscreenForElement): Canonical link: https://commits.webkit.org/21@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8fc307: Link GitHub accounts on /team/
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8fc30703af6e1ee075e268db8148bc611749e7aa https://github.com/WebKit/WebKit/commit/8fc30703af6e1ee075e268db8148bc611749e7aa Author: Anne van Kesteren Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Websites/webkit.org/wp-content/themes/webkit/team.php Log Message: --- Link GitHub accounts on /team/ https://bugs.webkit.org/show_bug.cgi?id=246455 Reviewed by Jonathan Bedard. * Websites/webkit.org/wp-content/themes/webkit/team.php: Canonical link: https://commits.webkit.org/20@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9dd26e: [webkitscmpy] Handle unexpected PR data
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9dd26e36dd842c119c4332ce930d6efec6450122 https://github.com/WebKit/WebKit/commit/9dd26e36dd842c119c4332ce930d6efec6450122 Author: Jonathan Bedard Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py Log Message: --- [webkitscmpy] Handle unexpected PR data https://bugs.webkit.org/show_bug.cgi?id=246035 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub.PRGenerator.PullRequest): Canonical link: https://commits.webkit.org/255549@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d78e3: [libpas] libpas is unconditionally built with -Werror
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d78e3342b26fbe519d44a1d97763ad5b06305a4 https://github.com/WebKit/WebKit/commit/0d78e3342b26fbe519d44a1d97763ad5b06305a4 Author: Michael Catanzaro Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/bmalloc/libpas/CMakeLists.txt Log Message: --- [libpas] libpas is unconditionally built with -Werror https://bugs.webkit.org/show_bug.cgi?id=246520 Reviewed by Yusuke Suzuki. We cannot use -Werror unconditionally because it will cause builds to fail spuriously for end users. Get rid of it. * Source/bmalloc/libpas/CMakeLists.txt: Canonical link: https://commits.webkit.org/255548@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 78ad3a: Hook up temporary timer-based displayDidRefresh in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 78ad3a86bab5f481ce06414ade4e68b97e8eb9c2 https://github.com/WebKit/WebKit/commit/78ad3a86bab5f481ce06414ade4e68b97e8eb9c2 Author: Simon Fraser Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm Log Message: --- Hook up temporary timer-based displayDidRefresh in RemoteLayerTreeDrawingAreaProxyMac https://bugs.webkit.org/show_bug.cgi?id=246531 Reviewed by Tim Horton. Hook up a timer in RemoteLayerTreeDrawingAreaProxyMac to drive display refresh as an interim solution until DisplayLink is hooked up. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm: (WebKit::RemoteLayerTreeDrawingAreaProxyMac::RemoteLayerTreeDrawingAreaProxyMac): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::scheduleDisplayLink): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::pauseDisplayLink): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::displayLinkTimerFired): Canonical link: https://commits.webkit.org/255547@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf3359: Implement lastLineBaseline for tables.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bf33593289e7c50abaf636fdca635f3bac442eb4 https://github.com/WebKit/WebKit/commit/bf33593289e7c50abaf636fdca635f3bac442eb4 Author: Sammy Gill Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-003-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-table-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-table-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-table-003-expected.txt M Source/WebCore/rendering/RenderTable.cpp M Source/WebCore/rendering/RenderTable.h M Source/WebCore/rendering/RenderTableSection.cpp M Source/WebCore/rendering/RenderTableSection.h Log Message: --- Implement lastLineBaseline for tables. https://bugs.webkit.org/show_bug.cgi?id=244858 rdar://99621230 Reviewed by Alan Bujtas. CSS Box Alignment Module Level 3 provides a definition of the last baseline for tables and table rows. We currently keep track of the baselines for each row if there are cells within that are baseline aligned, so we just need to add the logic for finding the last baseline if there are no cells being baseline aligned. This is the same logic that was already in firstLineBaseline, but instead we are looking at only the last row. This logic has been refactored out into baselineFromCellContentEdges and now takes into consideration which type of baseline alignment we are doing. Spec reference: https://www.w3.org/TR/css-align-3/#baseline-export * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-003-expected.txt: * Source/WebCore/rendering/RenderTable.cpp: (WebCore::RenderTable::bottomNonEmptySection const): (WebCore::RenderTable::lastLineBaseline const): * Source/WebCore/rendering/RenderTable.h: * Source/WebCore/rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::firstLineBaseline const): (WebCore::RenderTableSection::lastLineBaseline const): (WebCore::RenderTableSection::baselineFromCellContentEdges const): * Source/WebCore/rendering/RenderTableSection.h: Canonical link: https://commits.webkit.org/255546@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6b5d0: Add name to contributors
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6b5d0356727b913f934a7f8dcfef6167e7cbde8 https://github.com/WebKit/WebKit/commit/f6b5d0356727b913f934a7f8dcfef6167e7cbde8 Author: Chirag M Shah Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M metadata/contributors.json Log Message: --- Add name to contributors Reviewed by Alex Christensen. * metadata/contributors.json: Canonical link: https://commits.webkit.org/255545@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e543a3: [ macOS Debug EWS ] compositing/backing/backing-st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e543a3ea8f44f5525ce7ee383f7fee227c66e4c5 https://github.com/WebKit/WebKit/commit/e543a3ea8f44f5525ce7ee383f7fee227c66e4c5 Author: Robert Jenner Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [ macOS Debug EWS ] compositing/backing/backing-store-attachment-animating-outside-viewport.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=246467 Unreviewed test gardening. Applying expectation to more than just Debug queues to stop it from negativly impacting merge-queue. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/255544@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2da880: WebXR should respond to changes in frame size
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2da8807b15a6fe8b49b1b83484daa350c532001e https://github.com/WebKit/WebKit/commit/2da8807b15a6fe8b49b1b83484daa350c532001e Author: Dean Jackson Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp Log Message: --- WebXR should respond to changes in frame size https://bugs.webkit.org/show_bug.cgi?id=246496 Reviewed by Antoine Quint. The size of the framebuffer provided by the compositor may change during the life of a session. Detect this and respond to it. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::startFrame): Look at the size of the incoming frame. If it has changed, re-run the setupFramebuffer logic. (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): Make sure we delete existing WebGL objects if we create new ones. Canonical link: https://commits.webkit.org/255543@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 408afb: [Gardening]: RE-REBASELINE(255471@main): [ iOS ] f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 408afbd4b71fb2b0675c5f2c92da48b84a796edd https://github.com/WebKit/WebKit/commit/408afbd4b71fb2b0675c5f2c92da48b84a796edd Author: Hercules Hjalmarsson Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/platform/ios/fast/lists/inlineBoxWrapperNullCheck-expected.txt Log Message: --- [Gardening]: RE-REBASELINE(255471@main): [ iOS ] fast/lists/inlineBoxWrapperNullCheck.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=246469 Unreviewed test gardening. * LayoutTests/platform/ios/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Canonical link: https://commits.webkit.org/255542@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d28dc: [ iOS16 ] fast/canvas/canvas-large-dimensions-draw...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4d28dc17be952277de6ce87c51a847ef1dd44b6e
https://github.com/WebKit/WebKit/commit/4d28dc17be952277de6ce87c51a847ef1dd44b6e
Author: Said Abou-Hallawa
Date: 2022-10-14 (Fri, 14 Oct 2022)
Changed paths:
M LayoutTests/fast/canvas/canvas-large-dimensions-drawing-expected.html
M LayoutTests/fast/canvas/canvas-large-dimensions-drawing.html
M LayoutTests/platform/ios-wk2/TestExpectations
Log Message:
---
[ iOS16 ] fast/canvas/canvas-large-dimensions-drawing.html is a constant
failure
https://bugs.webkit.org/show_bug.cgi?id=245597
rdar://100335937
Reviewed by Simon Fraser.
It looks like CoreAnimation on iOS16 simulator has made anti-aliasing around the
border of the rectangle a little bit wider. The failure of test shows adding the
tag can make
the test pass.
A more appropriate fix is to fit the canvas in the expected page to { 100 x 100
}
pixels. This way the extra anti-aliasing will be truncated.
* LayoutTests/fast/canvas/canvas-large-dimensions-drawing-expected.html:
* LayoutTests/fast/canvas/canvas-large-dimensions-drawing.html:
* LayoutTests/platform/ios-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/255541@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 44ccd6: Enable lh/rlh unit support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44ccd6d3b52120b11443344cc0ce02142f1cbba4 https://github.com/WebKit/WebKit/commit/44ccd6d3b52120b11443344cc0ce02142f1cbba4 Author: Tim Nguyen Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml Log Message: --- Enable lh/rlh unit support https://bugs.webkit.org/show_bug.cgi?id=246522 rdar://101172926 Reviewed by Darin Adler. Bug 211356 disabled it because of bug 211351, but the linked CSSWG issue says WebKit behavior is correct (Rune & Emilio both confirmed): > RESOLVED: browser "fixups" of line height on form controls do *not* affect > lh/rlh on the element itself. Effect of fixups on lh/rlh of descendants is > explicitly undefined. * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: Canonical link: https://commits.webkit.org/255540@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d19732: [Gardening]: [ BigSur+ iOS16 ] Two IndexedDB wpt t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1973275b1da020bf25d464a668c490a1f6ea7f3 https://github.com/WebKit/WebKit/commit/d1973275b1da020bf25d464a668c490a1f6ea7f3 Author: Hercules Hjalmarsson Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ BigSur+ iOS16 ] Two IndexedDB wpt tests are failing since import https://bugs.webkit.org/show_bug.cgi?id=243681 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/255539@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0fb07c: Adjust the corner radius of fullscreen windows
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0fb07cea5c4207c47bef5e6459bbacaf393e9ffe https://github.com/WebKit/WebKit/commit/0fb07cea5c4207c47bef5e6459bbacaf393e9ffe Author: Aditya Keerthi Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- Adjust the corner radius of fullscreen windows https://bugs.webkit.org/show_bug.cgi?id=246482 rdar://97042030 Reviewed by Devin Rousso. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController viewIsAppearing:]): Use `viewIsAppearing` to ensure that the view controller's view has been added to a window. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen:]): Canonical link: https://commits.webkit.org/255538@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a917e0: Add a mechanism to remember the last IP address of...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a917e03c36b8b0f2f016449b9b9e0318fbb3eb38 https://github.com/WebKit/WebKit/commit/a917e03c36b8b0f2f016449b9b9e0318fbb3eb38 Author: Wenson Hsieh Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebCore/platform/network/DNS.cpp M Source/WebCore/platform/network/DNS.h M Source/WebKit/NetworkProcess/NetworkDataTask.cpp M Source/WebKit/NetworkProcess/NetworkDataTask.h M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm Log Message: --- Add a mechanism to remember the last IP address of the response for the main resource request https://bugs.webkit.org/show_bug.cgi?id=246128 rdar://100831206 Reviewed by John Wilander. Add a mechanism to keep track of the last IP address, corresponding to the main resource request's response; this information is stashed in a side table on the network session, alongside the existing map of first party host to CNAME. * Source/WTF/wtf/PlatformHave.h: Remove this feature flag, since the oldest macOS version we currently support (Big Sur) contains this SPI. * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebCore/platform/network/DNS.cpp: (WebCore::IPAddress::fromString): Add a helper method to create an `IPAddress` from an IP address string (IPv4 or IPv6). * Source/WebCore/platform/network/DNS.h: (WebCore::IPAddress::IPAddress): Add another explicit constructor that takes `WTF::HashTableEmptyValueType`, so that we can store `IPAddress` as a value in a `HashMap`; see below. (WTF::HashTraits::emptyValue): Additionally add a `HashTraits` template class for `IPAddress`, which allows us to store `WebCore::IPAddress` as a hash table value by implementing `emptyValue()`. * Source/WebKit/NetworkProcess/NetworkDataTask.cpp: (WebKit::NetworkDataTask::networkSession const): * Source/WebKit/NetworkProcess/NetworkDataTask.h: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::resetParametersToDefaultValues): * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::setFirstPartyHostCNAMEDomain): (WebKit::NetworkSession::firstPartyHostCNAMEDomain): (WebKit::NetworkSession::resetFirstPartyDNSData): (WebKit::NetworkSession::setFirstPartyHostIPAddress): (WebKit::NetworkSession::firstPartyHostIPAddress): (WebKit::NetworkSession::resetCNAMEDomainData): Deleted. Rename `resetCNAMEDomainData` to `resetFirstPartyDNSData`, since we now use it to clear both first party CNAME information as well as first party IP address information. * Source/WebKit/NetworkProcess/NetworkSession.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::lastRemoteIPAddress): Add a helper function to grab the last resolved IP address of the network data task; this is intended to be used after we get a response. (WebKit::NetworkDataTaskCocoa::shouldApplyCookiePolicyForThirdPartyCNAMECloaking const): (WebKit::NetworkDataTaskCocoa::updateFirstPartyInfoForSession): Update the first party IP address, alongside the first party CNAME for the main resource. (WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking): (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): (WebKit::NetworkDataTaskCocoa::didReceiveResponse): (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection): (WebKit::hasCNAMEAndCookieTransformSPI): Deleted. Remove this helper function, since we no longer need `-respondsToSelector` checks for `_resolvedCNAMEChain` and `_cookieTransformCallback`. Canonical link: https://commits.webkit.org/255537@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f76663: Non-unified build with LLD fails due to undefined ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f76663a6c9ce233b198ac9a8dd204820d7a53b5d https://github.com/WebKit/WebKit/commit/f76663a6c9ce233b198ac9a8dd204820d7a53b5d Author: Adrian Perez de Castro Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/JavaScriptCore/wasm/js/WebAssemblyArrayPrototype.cpp Log Message: --- Non-unified build with LLD fails due to undefined AuxiliaryBarrier constructor https://bugs.webkit.org/show_bug.cgi?id=246515 Unreviewed build fix. * Source/JavaScriptCore/wasm/js/WebAssemblyArrayPrototype.cpp: Add missing AuxiliaryBarrierInlines.h header inclusion. Canonical link: https://commits.webkit.org/255536@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8cc217: Revert [255512@main] Support loading Web Extension...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cc2178d3db4c8a773af9cd1e0df0d7f9b84eda0 https://github.com/WebKit/WebKit/commit/8cc2178d3db4c8a773af9cd1e0df0d7f9b84eda0 Author: Hercules Hjalmarsson Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/en.lproj/Localizable.strings M Source/WebKit/Shared/WebPageCreationParameters.cpp M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm M Source/WebKit/UIProcess/Cocoa/WebURLSchemeHandlerCocoa.h M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm R Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionURLSchemeHandlerCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtension.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionController.h R Source/WebKit/UIProcess/Extensions/WebExtensionURLSchemeHandler.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebURLSchemeHandler.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionController.mm Log Message: --- Revert [255512@main] Support loading Web Extension URLs and load the background page or service worker. https://bugs.webkit.org/show_bug.cgi?id=246409 rdar://101174536 Reverting commit due to causing bot opensource API test to crash on macOS and iOS queues. Unreviewed revert. * Source/WebCore/en.lproj/Localizable.strings: * Source/WebKit/Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode): * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::copy const): (API::PageConfiguration::webExtensionController): Deleted. (API::PageConfiguration::setWebExtensionController): Deleted. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setupPageConfiguration:]): (-[WKWebView urlSchemeHandlerForURLScheme:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration encodeWithCoder:]): (-[WKWebViewConfiguration initWithCoder:]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration urlSchemeHandlerForURLScheme:]): (-[WKWebViewConfiguration _webExtensionController]): Deleted. (-[WKWebViewConfiguration _setWebExtensionController:]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: (NS_ERROR_ENUM): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext setBaseURL:]): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm: (-[_WKWebExtensionController extensionContextForExtension:]): * Source/WebKit/UIProcess/Cocoa/WebURLSchemeHandlerCocoa.h: (): Deleted. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::manifest): (WebKit::WebExtension::resourceDataForPath): (WebKit::WebExtension::createError): (WebKit::WebExtension::recordError): (WebKit::WebExtension::errors): (WebKit::WebExtension::hasInjectedContentForURL): (WebKit::WebExtension::allRequestedMatchPatterns): (WebKit::WebExtension::isAccessibleResourcePath): Deleted. (WebKit::WebExtension::removeError): Deleted. (WebKit::WebExtension::backgroundContentPath): Deleted. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::WebExtensionContext): (WebKit::WebExtensionContext::createError): (WebKit::WebExtensionContext::load): (WebKit::WebExtensionContext::unload): (WebKit::WebExtensionContext::setBaseURL): (WebKit::WebExtensionContext::postAsyncNotification): (-[_WKWebExtensionContextDelegate initWithWebExtensionContext:]): Deleted. (-[_WKWebExtensionContextDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted. (-[_WKWebExtensionContextDelegate webView:didFinishNavigation:]): Deleted. (-[_WKWebExtensionContextDelegate webView:didFailNavigation:withError:]): Deleted. (-[_WKWebExtensionContextDelegate webView
[webkit-changes] [WebKit/WebKit] db462f: Resync WPT tests for contain-intrinsic-size
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db462f1dc2bed318a2948ae3cc59594c63d9b926 https://github.com/WebKit/WebKit/commit/db462f1dc2bed318a2948ae3cc59594c63d9b926 Author: Cathie Chen Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-009-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-009.html A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-010-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-010.html R LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009.html M LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/w3c-import.log Log Message: --- Resync WPT tests for contain-intrinsic-size https://bugs.webkit.org/show_bug.cgi?id=246462 Reviewed by Rob Buis. Update the contain-intrinsic-size tests to WPT commit 56d81ee2e9676f7271b907fcc6fbb2b904cd6529 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-009-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-009.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-010-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-010.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009-expected.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-009.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/w3c-import.log: Canonical link: https://commits.webkit.org/255534@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5bdde0: EWS builds on tester queues do not display Identif...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5bdde03b5c55aac21967addc8000bb11aeeb319a https://github.com/WebKit/WebKit/commit/5bdde03b5c55aac21967addc8000bb11aeeb319a Author: Aakash Jain Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- EWS builds on tester queues do not display Identifier in buildbot build https://bugs.webkit.org/show_bug.cgi?id=246514 Reviewed by Jonathan Bedard. * Tools/CISupport/ews-build/steps.py: (ShowIdentifier.evaluateCommand): Canonical link: https://commits.webkit.org/255533@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6a656: Unreviewed, reverting r255507@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6a65632c6979a124dd124a4e41a69cbf7266727 https://github.com/WebKit/WebKit/commit/a6a65632c6979a124dd124a4e41a69cbf7266727 Author: Commit Queue Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebCore/platform/network/DNS.cpp M Source/WebCore/platform/network/DNS.h M Source/WebKit/NetworkProcess/NetworkDataTask.cpp M Source/WebKit/NetworkProcess/NetworkDataTask.h M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm Log Message: --- Unreviewed, reverting r255507@main. https://bugs.webkit.org/show_bug.cgi?id=246516 Broke windows build Reverted changeset: "Add a mechanism to remember the last IP address of the response for the main resource request" https://bugs.webkit.org/show_bug.cgi?id=246128 https://commits.webkit.org/255507@main Canonical link: https://commits.webkit.org/255532@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f9f41e: Safari crashes on knowyourmeme.com/memes/oh-the-hu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f9f41e5b4d58c395055ee560636fd9dfd801d50b https://github.com/WebKit/WebKit/commit/f9f41e5b4d58c395055ee560636fd9dfd801d50b Author: Alan Bujtas Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: A LayoutTests/fast/block/out-of-flow-becomes-float-crash-expected.txt A LayoutTests/fast/block/out-of-flow-becomes-float-crash.html M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp Log Message: --- Safari crashes on knowyourmeme.com/memes/oh-the-huge-manatee https://bugs.webkit.org/show_bug.cgi?id=246481 Reviewed by Antti Koivisto. This patch enables style update on the layout boxes when the renderer is floating/out-of-flow. It ensures that the layout box and the associated render stay in sync. (out of sync style could lead to an unexpected state where IFC integration layer (incorrectly) assumes that the renderer tree has certain properties (e.g. layer)). * LayoutTests/fast/block/out-of-flow-becomes-float-crash-expected.txt: Added. * LayoutTests/fast/block/out-of-flow-becomes-float-crash.html: Added. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::containing): Canonical link: https://commits.webkit.org/255531@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 67cda4: [GTK] D-Bus proxy quietly fails if host bus addres...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 67cda4acff9b343c48a2b24c326a2be08642ccee https://github.com/WebKit/WebKit/commit/67cda4acff9b343c48a2b24c326a2be08642ccee Author: Michael Catanzaro Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WTF/wtf/glib/Sandbox.cpp M Source/WTF/wtf/glib/Sandbox.h M Source/WebCore/platform/graphics/PlatformDisplay.h M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp M Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp M Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp Log Message: --- [GTK] D-Bus proxy quietly fails if host bus address is not mounted in xdg-dbus-proxy's sandbox https://bugs.webkit.org/show_bug.cgi?id=246159 Reviewed by Carlos Garcia Campos. D-Bus 1.15.2 has changed the default session bus address to a filesystem socket that lives under /tmp. However, our xdg-dbus-proxy cannot access this location because we assume the session bus socket will always be mounted under /run, since that's where all major distros put it. It's OK to be flexible and mount absolutely any directory, whatever it may be, since we're not actually trying to create a sandbox that the xdg-dbus-proxy cannot break out of. It's a trusted process, and the sandbox exists solely so that portals can verify the app ID of the process that is using the proxy, which is done by inspecting /.flatpak-info in its mount namespace's filesystem root. So let's mount whatever directory is in use and move on. Credit to oreo639 for investigating the problem and proposing a fix in WebKit#5011. The a11y bus has the same theoretical problem, although it's not an issue today because currently it will always be under /run in practice. Still, we should fix it. There is one complication: PlatformDisplay currently uses just one variable for both the host a11y bus address and the proxy bus address, relying on XDGDBusProxy to change it from the host address to the proxy address. This is fragile and it's easier to fix it than to work around it by caching the value before it changes, so at Carlos's suggestion, I have removed the ability to overwrite the value in PlatformDisplay, and added a separate variable to track the proxy address in WTF's Sandbox helpers. I have snuck in a drive-by cleanup to avoid duplicating BASE_DIRECTORY between two files, a problem that I introduced in 255218@main. Additionally, I remove a stale declaration for XDGDBusProxy::makePath, which I forgot to delete after removing the function in the same commit. Finally, always add the extra sandbox paths to the sandbox. These were originally extra paths for the web process only, but changed to be extra paths for both web process and D-Bus proxy. It's no longer needed except for the web process, but there's no particular reason to limit it either. I'm changing this here only because it's right next to the code I'm editing anyway, and it's odd to be adding extra sandbox paths specifically for the D-Bus proxy process. Canonical link: https://commits.webkit.org/255530@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] babc4f: Merge 255496@main - [WK2] constexpr-ify IPC encodi...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: babc4fead524d13368f614946044508534bd5103 https://github.com/WebKit/WebKit/commit/babc4fead524d13368f614946044508534bd5103 Author: Žan Doberšek Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebKit/Platform/IPC/ArgumentCoders.h Log Message: --- Merge 255496@main - [WK2] constexpr-ify IPC encoding, decoding of std::tuple<> objects https://bugs.webkit.org/show_bug.cgi?id=246149 Reviewed by Kimmo Kinnunen. Simplify the ArgumentCoder> specialization, removing helper structs and leaning into constexpr for a finer implementation. The encoding remains the same, just the helper struct's methods inlined into the ArgumentCoder specialization. The decoding methods are reworked to use constexpr to make compile-time codepaths. For each desired element, decoding is done into std::optional<> values that are then passed through tuples of rvalue references into recursive calls, with the index sequence adjusted each time to address the next element. Once all elements are successfully decoded, the final tuple is constructed, with the decoded objects all moved into that tuple. If decoding was unsuccessful at any point, a nullopt value is returned immediately, as before. This avoids concatenating tuples that was occurring for each decoded element, and was ending up moving each contained element into the concatenation result for each such concatenation. * Source/WebKit/Platform/IPC/ArgumentCoders.h: (IPC::TupleEncoder::encode): Deleted. (IPC::TupleDecoder<>::decode): Deleted. Canonical link: https://commits.webkit.org/255496@main (cherry picked from commit b807bfd9ce0a83f31884a9b093d37a127cca7d5a) Commit: f4a67f5bbaca01e1ab78ef09348aae1f6df51302 https://github.com/WebKit/WebKit/commit/f4a67f5bbaca01e1ab78ef09348aae1f6df51302 Author: Chris Dumez Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M LayoutTests/editing/execCommand/show-modal-dialog-during-execCommand-expected.txt M LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt M LayoutTests/fast/dom/Window/delete-operations-expected.txt M LayoutTests/fast/dom/Window/forbid-showModalDialog-expected.txt M LayoutTests/fast/dom/Window/open-window-min-size-expected.txt M LayoutTests/fast/dom/Window/showModalDialog-mandatory-parameter-expected.txt M LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt M LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt M LayoutTests/fast/dom/null-page-show-modal-dialog-crash-expected.txt M LayoutTests/fast/dom/wrapper-identity-expected.txt M LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt M LayoutTests/http/tests/security/cross-frame-access-call-expected.txt M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt M LayoutTests/http/tests/security/cross-origin-modal-dialog-base-expected.txt M LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt M LayoutTests/http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt M LayoutTests/js/dom/function-length-expected.txt M LayoutTests/js/dom/global-function-resolve-expected.txt M LayoutTests/platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt M LayoutTests/platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt M LayoutTests/platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt M LayoutTests/platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt M LayoutTests/platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt M Source/WebCore/bindings/js/JSDOMWindowBase.cpp M Source/WebCore/bindings/js/JSDOMWindowCustom.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Merge 255521@main - Regression(252759@main) Unable to log into pandora.com https://bugs.webkit.org/show_bug.cgi?id=246430 rdar://100243111 Reviewed by Geoffrey Garen and Ryosuke Niwa. We're unable to log into pandora.com since un-exposing window.showModalDialog() in 252759@main. Pandora does not actually seem to call showModalDialog() but they are calling its getter on the Window object. It is unclear why this is causing log in to fail since there is no JS error (and other browsers don't expose showModalDialog either). To resolve the issue for now, I am adding a quirk to re-expose showModalDialog on pandora.com. However, since they're not calling it, I am merely using `undefined` as value for the property. * Source/WebCore/bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::finishCreation): * Source/WebCore/bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSC_DEFINE_CUSTOM_GETTER): * Source/Web
[webkit-changes] [WebKit/WebKit] 06f615: More non-unified build fixes after 255488@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 06f6153af413dc3f5c83111adffdf40b91ed5e5c https://github.com/WebKit/WebKit/commit/06f6153af413dc3f5c83111adffdf40b91ed5e5c Author: Adrian Perez de Castro Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/css/query/MediaQueryParser.cpp Log Message: --- More non-unified build fixes after 255488@main Unreviewed non-unified build fixes. * Source/WebCore/css/query/MediaQueryParser.cpp: Add missing headers. Canonical link: https://commits.webkit.org/255529@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 13c796: "display" property value of computed style for aud...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 13c796fb7f1d6bc0cb660bedae2f9f6e8e510675 https://github.com/WebKit/WebKit/commit/13c796fb7f1d6bc0cb660bedae2f9f6e8e510675 Author: Ahmad Saleem Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: A LayoutTests/media/audio-controls-hidden-display-none-expected.txt A LayoutTests/media/audio-controls-hidden-display-none.html M Source/WebCore/css/html.css Log Message: --- "display" property value of computed style for audio element without controls is "inline" (not "none") "display" property value of computed style for audio element without controls is "inline" (not "none") https://bugs.webkit.org/show_bug.cgi?id=88105 Reviewed by Devin Rousso. This is to align Webkit behavior with Blink / Chrome and Gecko / Firefox and Web-Specifications: https://html.spec.whatwg.org/#embedded-content-rendering-rules "When an audio element is not exposing a user interface, the user agent is expected to force its 'display' property to compute to 'none', irrespective of CSS rules." When an audio element has no controls attribute, it should not be visible on the page. Before this patch, when we removed the "controls" attribute, an empty div of the size of the controls remained. Tests from Patch Authored by Silvia Pfeiffer. * Source/WebCore/css/html.css: Update UA stylesheet where the audio controls are not visible * LayoutTests/media/audio-controls-hidden-display-none.html: Added Test Cases * LayoutTests/media/audio-controls-hidden-display-none-expected.txt: Added Test Case Expectations Canonical link: https://commits.webkit.org/255528@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6f2c9: Tear down child renderers when removing display: c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6f2c95eb900fce4967fbfb6586416363eb4fe7e https://github.com/WebKit/WebKit/commit/f6f2c95eb900fce4967fbfb6586416363eb4fe7e Author: Rob Buis Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp Log Message: --- Tear down child renderers when removing display: contents https://bugs.webkit.org/show_bug.cgi?id=246450 rdar://95570441 Reviewed by Antti Koivisto. Detect when we transition away from display: contents when resolving computed styles and tear down child renderers in that case. To keep track of when to do this add a flag to Element. * Source/WebCore/dom/Element.cpp: (WebCore::Element::resolveComputedStyle): * Source/WebCore/dom/Element.h: (WebCore::Element::displayContentsChanged const): (WebCore::Element::setDisplayContentsChanged): * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::updateElementRenderer): Canonical link: https://commits.webkit.org/255527@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ee166d: Serialize template content correctly
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee166d5f222f70c4ee4caaa99c910a0aeb639c34 https://github.com/WebKit/WebKit/commit/ee166d5f222f70c4ee4caaa99c910a0aeb639c34 Author: Rob Buis Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/editing/MarkupAccumulator.cpp Log Message: --- Serialize template content correctly https://bugs.webkit.org/show_bug.cgi?id=246507 rdar://99568381 Reviewed by Ryosuke Niwa. Serialize template content correctly by not traversing the template in case we are serializing the template content document fragment. * Source/WebCore/editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Canonical link: https://commits.webkit.org/255526@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f034b: [Gardening] REGRESSION(255324@main): WebProcess cr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f034bf97e2b0c1d5eb06d70ccbbdbb701b2bb1e https://github.com/WebKit/WebKit/commit/6f034bf97e2b0c1d5eb06d70ccbbdbb701b2bb1e Author: Adrian Perez de Castro Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WTF/wtf/FileSystem.h M Source/WTF/wtf/glib/FileSystemGlib.cpp Log Message: --- [Gardening] REGRESSION(255324@main): WebProcess crash while running TestUIClient https://bugs.webkit.org/show_bug.cgi?id=246480 Reviewed by Žan Doberšek. * Source/WTF/wtf/FileSystem.h: Use nullptr to modernize invalid handle value. * Source/WTF/wtf/glib/FileSystemGlib.cpp: (WTF::FileSystemImpl::fileID): Check whether the file handle is valid before attempting to use it. Canonical link: https://commits.webkit.org/255525@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
