[webkit-changes] [WebKit/WebKit] 2a4dc7: [WebXR] Use ANGLE extension to signal compositor c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a4dc7e13fde3c6dd2995ea7702cf47ea28269de https://github.com/WebKit/WebKit/commit/2a4dc7e13fde3c6dd2995ea7702cf47ea28269de Author: Dan Glastonbury Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h M Source/WebCore/PAL/pal/spi/cocoa/MetalSPI.h M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.cpp M Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.h A Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.mm M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm M Source/WebCore/platform/xr/PlatformXR.h Log Message: --- [WebXR] Use ANGLE extension to signal compositor completion event https://bugs.webkit.org/show_bug.cgi?id=246589 rdar://problem/101212895 Reviewed by Dean Jackson. Use MTLSharedEvent, provided by WebXR system compositor, that signals when scene rendering is completed using the EGL_ANGLE_metal_shared_event_sync extension. To enable, set USE_MTLSHAREDEVENT_FOR_XR_FRAME_COMPLETION to 1 * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::startFrame): (WebCore::WebXROpaqueFramebuffer::endFrame): * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h: * Source/WebCore/PAL/pal/spi/cocoa/MetalSPI.h: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.h: * Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.mm: Renamed from Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.cpp. (WebCore::newSharedEventWithMachPort): * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::platformSupportsMetal): (WebCore::initializeEGLDisplay): (WebCore::GraphicsContextGLCocoa::newSharedEventWithMachPort): (WebCore::GraphicsContextGLCocoa::createSyncWithSharedEvent): (WebCore::GraphicsContextGLCocoa::destroySync): (WebCore::GraphicsContextGLCocoa::clientWaitSyncWithFlush): * Source/WebCore/platform/xr/PlatformXR.h: (PlatformXR::Device::FrameData::LayerData::encode const): (PlatformXR::Device::FrameData::LayerData::decode): Canonical link: https://commits.webkit.org/255613@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5011c6: [GTK] Gardening WTF_WordLock.ManyContendedLongSect...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5011c6c5ca24ac3557469ac9954068c3a4ce8008 https://github.com/WebKit/WebKit/commit/5011c6c5ca24ac3557469ac9954068c3a4ce8008 Author: Lauro Moura Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Gardening WTF_WordLock.ManyContendedLongSections timeouts Unreviewed test gardening. Was making the EWS too slow. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/255612@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2142cd: CSP: Test allowed hash of empty content block.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2142cd8c9e15eb1cbe29b260fdb6dc7180b16880 https://github.com/WebKit/WebKit/commit/2142cd8c9e15eb1cbe29b260fdb6dc7180b16880 Author: Matthew Finkel Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/content-security-policy/style-src/style-src-injected-inline-style-allowed-with-content-hash-expected.txt A LayoutTests/imported/w3c/web-platform-tests/content-security-policy/style-src/style-src-injected-inline-style-allowed-with-content-hash.html Log Message: --- CSP: Test allowed hash of empty content block. https://bugs.webkit.org/show_bug.cgi?id=233071 Reviewed by Tim Nguyen. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/style-src/style-src-injected-inline-style-allowed-with-content-hash-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/style-src/style-src-injected-inline-style-allowed-with-content-hash.html: Added. Canonical link: https://commits.webkit.org/255611@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2d8149: AX: Remove 32 ASSERT_NOT_REACHED AXIsolatedObject ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2d8149bbed87335fb0470e35007923445053c4de https://github.com/WebKit/WebKit/commit/2d8149bbed87335fb0470e35007923445053c4de Author: Tyler Wilcock Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Source/WebCore/accessibility/AccessibilityLabel.h M Source/WebCore/accessibility/AccessibilityMediaObject.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/AccessibilityObjectInterface.h M Source/WebCore/accessibility/AccessibilityProgressIndicator.h M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilityRenderObject.h M Source/WebCore/accessibility/AccessibilityScrollView.h M Source/WebCore/accessibility/AccessibilityScrollbar.h M Source/WebCore/accessibility/AccessibilitySlider.h M Source/WebCore/accessibility/AccessibilitySpinButton.h M Source/WebCore/accessibility/AccessibilityTableColumn.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h Log Message: --- AX: Remove 32 ASSERT_NOT_REACHED AXIsolatedObject functions from the AXCoreObject interface https://bugs.webkit.org/show_bug.cgi?id=246593 rdar://problem/101223521 Reviewed by Chris Fleizach. This patch: - Removes a couple completely unused functions. - Moves many functions out of the AXCoreObject interface, instead making them virtual at the AccessibilityObject level. - Makes some functions completely non-virtual (since they were only virtual because of their AXIsolatedObject implementation). This should help performance. - Moves the caching of AXPropertyName::IsSelectedOptionActive to an `#if PLATFORM(ATSPI)` block since that platform is the the only one that uses this property. * Source/WebCore/accessibility/AccessibilityLabel.h: (isType): * Source/WebCore/accessibility/AccessibilityMediaObject.h: (isType): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::scrollViewAncestor const): Deleted. (WebCore::AccessibilityObject::firstAnonymousBlockChild const): Deleted. * Source/WebCore/accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::init): (WebCore::AccessibilityObject::isAccessibilityScrollbar const): (WebCore::AccessibilityObject::isAccessibilityScrollViewInstance const): (WebCore::AccessibilityObject::isAccessibilityTableColumnInstance const): (WebCore::AccessibilityObject::isSliderThumb const): (WebCore::AccessibilityObject::isLabel const): (WebCore::AccessibilityObject::isNativeSpinButton const): (WebCore::AccessibilityObject::isSpinButtonPart const): (WebCore::AccessibilityObject::isMediaObject const): (WebCore::AccessibilityObject::stepValueForRange const): (WebCore::AccessibilityObject::parentObjectIfExists const): (WebCore::AccessibilityObject::observableObject const): (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole const): (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren const): (WebCore::AccessibilityObject::helpText const): (WebCore::AccessibilityObject::isARIAStaticText const): (WebCore::AccessibilityObject::ariaLabeledByAttribute const): (WebCore::AccessibilityObject::ariaDescribedByAttribute const): (WebCore::AccessibilityObject::anchorElement const): (WebCore::AccessibilityObject::shouldFocusActiveDescendant const): (WebCore::AccessibilityObject::index const): * Source/WebCore/accessibility/AccessibilityObjectInterface.h: (WebCore::AXCoreObject::objectID const): (WebCore::AXCoreObject::isSpinButton const): * Source/WebCore/accessibility/AccessibilityProgressIndicator.h: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: * Source/WebCore/accessibility/AccessibilityRenderObject.h: * Source/WebCore/accessibility/AccessibilityScrollView.h: (isType): * Source/WebCore/accessibility/AccessibilityScrollbar.h: (isType): * Source/WebCore/accessibility/AccessibilitySlider.h: (isType): * Source/WebCore/accessibility/AccessibilitySpinButton.h: (isType): * Source/WebCore/accessibility/AccessibilityTableColumn.h: (isType): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeProperties): (WebCore::AXIsolatedObject::init): Deleted. (WebCore::AXIsolatedObject::plainTextRangeForVisiblePositionRange const): Deleted. (WebCore::AXIsolatedObject::index const): Deleted. (WebCore::AXIsolatedObject::isAccessibilityScrollbar const): Deleted. (WebCore::AXIsolatedObject::isAccessibilityScrollViewInstance const): Deleted. (WebCore::AXIsolatedObject::isAccessibilityTableColumnInstance const): Deleted. (WebCore::AXIsolatedObject::isAccessibilityProgressIndicatorInstance const): Deleted. (WebCore::AXIsolatedObject::isSliderThumb const): Deleted. (WebCore::AXIsolatedObject::isInputSlider const): Deleted. (WebC
[webkit-changes] [WebKit/WebKit] bb8c8f: Support installsrc for tools
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb8c8f04c51d5c56917625ed16ba2542f301db75 https://github.com/WebKit/WebKit/commit/bb8c8f04c51d5c56917625ed16ba2542f301db75 Author: Alexey Proskuryakov Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Tools/Makefile M Tools/WebKitTestRunner/Configurations/Base.xcconfig Log Message: --- Support installsrc for tools https://bugs.webkit.org/show_bug.cgi?id=246532 Reviewed by Elliott Williams. * Tools/Makefile: Recurse into modules when FORCE_TOOL_INSTALL opt-in is set. Also, copy TestRunnerShared content, which is not a module. It's not ideal to use ditto, as it doesn't skip invisible files like .DS_Store, but we do the same elsewhere, and I'm not sure if there is an easy enough way to match what xcodebuild installsrc does. * Tools/WebKitTestRunner/Configurations/Base.xcconfig: Skip gtk files, because there are some unrecognized binaries there (fonts). Canonical link: https://commits.webkit.org/255609@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 80e312: [JSC] Deploy more loadPair / storePair in DFG
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80e312320f130b264ed3f4694620fd63083f8f38 https://github.com/WebKit/WebKit/commit/80e312320f130b264ed3f4694620fd63083f8f38 Author: Yusuke Suzuki Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Source/JavaScriptCore/assembler/MacroAssembler.h M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/jit/AssemblyHelpers.cpp M Source/JavaScriptCore/jit/AssemblyHelpers.h Log Message: --- [JSC] Deploy more loadPair / storePair in DFG https://bugs.webkit.org/show_bug.cgi?id=246502 rdar://101156906 Reviewed by Mark Lam. This patch deploys more and more loadPair/storePair in DFG. We also add loadPairPtr and storePairPtr so that we can use them in pointer storing places too. * Source/JavaScriptCore/assembler/MacroAssembler.h: (JSC::MacroAssembler::loadPairPtr): (JSC::MacroAssembler::storePairPtr): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::emitAllocateRawObject): * Source/JavaScriptCore/jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo): (JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator): * Source/JavaScriptCore/jit/AssemblyHelpers.h: (JSC::AssemblyHelpers::emitInitializeInlineStorage): (JSC::AssemblyHelpers::emitInitializeOutOfLineStorage): (JSC::AssemblyHelpers::emitFillStorageWithJSEmpty): (JSC::AssemblyHelpers::emitFillStorageWithDoubleEmpty): Canonical link: https://commits.webkit.org/255608@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c746f3: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c746f37b4f60239496fd58d651428f78f6cf9c2c https://github.com/WebKit/WebKit/commit/c746f37b4f60239496fd58d651428f78f6cf9c2c Author: Fujii Hironori Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M LayoutTests/platform/wincairo/editing/caret/insert-paragraph-does-not-paint-stale-carets-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-3608445-fix-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-3608462-fix-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-012-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-017-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-018-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-021-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-022-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-contiguous-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-003-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-line-end-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-line-end-ws-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-selection-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-to-select-table-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-trailing-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-trailing-ws-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-004-expected.txt M LayoutTests/platform/wincairo/editing/deleting/forward-delete-expected.txt M LayoutTests/platform/wincairo/editing/deleting/non-smart-delete-expected.txt M LayoutTests/platform/wincairo/editing/deleting/table-cells-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/5482023-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/find-after-replace-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/paste-1-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/print-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/selectAll-expected.txt M LayoutTests/platform/wincairo/editing/inserting/12882-expected.txt M LayoutTests/platform/wincairo/editing/inserting/editable-html-element-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-br-007-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-br-008-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-007-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-019-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-020-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-022-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-023-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-024-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-027-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-space-in-empty-doc-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-text-with-newlines-expected.txt M LayoutTests/platform/wincairo/editing/inserting/paragraph-separator-in-table-2-expected.txt M LayoutTests/platform/wincairo/editing/inserting/typing-003-expected.txt M LayoutTests/platform/wincairo/editing/inserting/typing-around-image-001-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-2-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-3-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4944770-2-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5028447-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5134759-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5387578-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5478250-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/cut-text-001-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/merge-end-borders-expected.txt
[webkit-changes] [WebKit/WebKit] c42fc3: [ New Test ] (254473@main): [ macOS Debug ] TestI...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c42fc3b27592d4628b5075368b4a088619d9f804 https://github.com/WebKit/WebKit/commit/c42fc3b27592d4628b5075368b4a088619d9f804 Author: Kimmo Kinnunen Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Source/WebKit/Platform/IPC/Connection.cpp M Source/WebKit/Platform/IPC/Connection.h M Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp Log Message: --- [ New Test ] (254473@main): [ macOS Debug ] TestIPC.ConnectionTest/OpenedConnectionTest.AInvalidateDeliversBDidClose/ClientIsA is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=245787 rdar://problem/100511956 Reviewed by Chris Dumez. On Cocoa: Before, IPC::Connection would detect the other side disconnecting like so: - Before the other side opens the connection, observe NO_SENDERS message through the listening port. - After the other side opens the connection, stop observing NO_SENDERS and start observing SEND_DEAD of the send port. This would fail in corner cases like the test in the subject, where the client would close the connection during initialization phase. The server Connection would receive InitializeConnection message, containing the send port. The server would stop observing NO_SENDERS, but would not verify whether the send port was already a DEAD_NAME port. Simplify by just observing the NO_SENDERS in both cases: before and after connection open. If the send port is already DEAD_NAME when server receives it, process the messages and then process the NO_SENDERS. This has the added benefit that NO_SENDERS is dispatched after dispatching all the messages. This is useful in scenarios where the sender sends messages and then immediately closes -- the messages should be still delivered as usual. This consistency behavior is not yet implemented due to the dispatching logic of the Connection. * Source/WebKit/Platform/IPC/Connection.cpp: (IPC::Connection::dispatchOnReceiveQueueForTesting): * Source/WebKit/Platform/IPC/Connection.h: * Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm: (IPC::requestNoSenderNotifications): (IPC::clearNoSenderNotifications): (IPC::Connection::platformInvalidate): (IPC::Connection::cancelSendSource): (IPC::Connection::platformOpen): (IPC::Connection::sendMessage): (IPC::Connection::platformCanSendOutgoingMessages const): (IPC::Connection::sendOutgoingMessage): (IPC::Connection::initializeSendSource): (IPC::Connection::resumeSendSource): (IPC::readFromMachPort): (IPC::Connection::receiveSourceEventHandler): (IPC::Connection::getAuditToken): * Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::ensureConnectionWorkQueueEmpty): (TestWebKitAPI::ConnectionTestBase::setupBase): (TestWebKitAPI::ConnectionTestBase::teardownBase): (TestWebKitAPI::ConnectionTest::openServer): (TestWebKitAPI::ConnectionTest::openClient): (TestWebKitAPI::ConnectionTest::server): (TestWebKitAPI::ConnectionTest::client): (TestWebKitAPI::ConnectionTest::serverClient): (TestWebKitAPI::ConnectionTest::clientClient): (TestWebKitAPI::ConnectionTest::deleteServer): (TestWebKitAPI::ConnectionTest::deleteClient): (TestWebKitAPI::PrintTo): (TestWebKitAPI::ConnectionTestABBA::serverIsA const): (TestWebKitAPI::TEST_P): (TestWebKitAPI::OpenedConnectionTest::serverIsA const): Deleted. (TestWebKitAPI::OpenedConnectionTest::SetUp): Deleted. (TestWebKitAPI::OpenedConnectionTest::TearDown): Deleted. (TestWebKitAPI::OpenedConnectionTest::openA): Deleted. (TestWebKitAPI::OpenedConnectionTest::openB): Deleted. (TestWebKitAPI::OpenedConnectionTest::openBoth): Deleted. (TestWebKitAPI::OpenedConnectionTest::a): Deleted. (TestWebKitAPI::OpenedConnectionTest::aClient): Deleted. (TestWebKitAPI::OpenedConnectionTest::b): Deleted. (TestWebKitAPI::OpenedConnectionTest::bClient): Deleted. (TestWebKitAPI::OpenedConnectionTest::deleteA): Deleted. (TestWebKitAPI::OpenedConnectionTest::deleteB): Deleted. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: Canonical link: https://commits.webkit.org/255606@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c72159: [Debug] Build failure in ThreadAssertions.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c721595118ecab15f2c8127a98a11f16e6c41675 https://github.com/WebKit/WebKit/commit/c721595118ecab15f2c8127a98a11f16e6c41675 Author: Xabier Rodriguez-Calvar Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Source/WTF/wtf/ThreadAssertions.h Log Message: --- [Debug] Build failure in ThreadAssertions.h https://bugs.webkit.org/show_bug.cgi?id=246592 Unreviewed. * Source/WTF/wtf/ThreadAssertions.h: Added include Canonical link: https://commits.webkit.org/255605@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 322ba5: Update @font-palette-values override-colors order
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 322ba50011a5c8ed120e80de0037c95076590111 https://github.com/WebKit/WebKit/commit/322ba50011a5c8ed120e80de0037c95076590111 Author: Darin Adler Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp Log Message: --- Update @font-palette-values override-colors order https://bugs.webkit.org/show_bug.cgi?id=246565 rdar://problem/101216288 Reviewed by Tim Nguyen. * LayoutTests/TestExpectations: Removed failure expectation. * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::addAttributesForCustomFontPalettes): Use CFDictionarySetValue, which overwrites existing values, resulting in "last one wins". Canonical link: https://commits.webkit.org/255604@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 52874c: [IFC][Integration] Enable '-webkit-line-break: aft...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 52874c216072d14f869e3df8de38fe84f9de3524 https://github.com/WebKit/WebKit/commit/52874c216072d14f869e3df8de38fe84f9de3524 Author: Alan Bujtas Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/editing/caret/insert-paragraph-does-not-paint-stale-carets-expected.txt M LayoutTests/editing/deleting/delete-3800834-fix-expected.txt M LayoutTests/editing/execCommand/selectAll-expected.txt M LayoutTests/editing/inserting/insert-br-008-expected.txt M LayoutTests/editing/inserting/insert-div-007-expected.txt M LayoutTests/editing/inserting/insert-space-in-empty-doc-expected.txt M LayoutTests/editing/inserting/typing-003-expected.txt M LayoutTests/editing/inserting/typing-around-image-001-expected.txt M LayoutTests/editing/mac/selection/25228-expected.txt M LayoutTests/editing/mac/spelling/autocorrection-delete-expected.txt M LayoutTests/editing/mac/spelling/autocorrection-removing-underline-expected.txt M LayoutTests/editing/mac/spelling/autocorrection-simple-expected.txt M LayoutTests/editing/mac/spelling/delete-autocorrected-word-1-expected.txt M LayoutTests/editing/mac/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt M LayoutTests/editing/pasteboard/paste-into-anchor-text-expected.txt M LayoutTests/editing/selection/51344.html M LayoutTests/editing/selection/extend-by-sentence-001-expected.txt M LayoutTests/editing/spelling/centering-misspelling-dots-expected.txt M LayoutTests/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.txt M LayoutTests/editing/style/typing-style-001-expected.txt M LayoutTests/editing/style/typing-style-002-expected.txt M LayoutTests/fast/block/height-percentage-descendants-with-absolute-pos-containingblock-expected.txt M LayoutTests/fast/forms/linebox-overflow-in-textarea-padding-simple-lines.html M LayoutTests/fast/repaint/4776765-expected.txt M LayoutTests/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt M LayoutTests/fast/text/whitespace/nowrap-line-break-after-white-space.html M LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html M LayoutTests/platform/ios-wk2/editing/execCommand/selectAll-expected.txt M LayoutTests/platform/ios-wk2/editing/inserting/12882-expected.txt M LayoutTests/platform/ios-wk2/editing/inserting/editable-html-element-expected.txt M LayoutTests/platform/ios-wk2/editing/inserting/insert-div-019-expected.txt M LayoutTests/platform/ios-wk2/editing/inserting/insert-div-023-expected.txt M LayoutTests/platform/ios-wk2/editing/inserting/insert-div-024-expected.txt M LayoutTests/platform/ios-wk2/editing/inserting/insert-div-027-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/4076267-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/5028447-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/5387578-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/5478250-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/paste-text-013-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/paste-text-014-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/pasting-object-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/unrendered-br-expected.txt M LayoutTests/platform/ios-wk2/editing/selection/6476-expected.txt M LayoutTests/platform/ios-wk2/editing/selection/click-start-of-line-expected.txt M LayoutTests/platform/ios-wk2/editing/selection/editable-non-editable-crash-expected.txt M LayoutTests/platform/ios-wk2/editing/selection/mixed-editability-1-expected.txt M LayoutTests/platform/ios-wk2/editing/style/apple-style-editable-mix-expected.txt M LayoutTests/platform/ios-wk2/editing/style/create-block-for-style-005-expected.txt M LayoutTests/platform/ios-wk2/editing/style/create-block-for-style-006-expected.txt M LayoutTests/platform/ios-wk2/editing/style/create-block-for-style-007-expected.txt M LayoutTests/platform/ios-wk2/editing/style/create-block-for-style-008-expected.txt M LayoutTests/platform/ios-wk2/editing/style/create-block-for-style-009-expected.txt M LayoutTests/platform/ios-wk2/editing/style/create-block-for-style-010-expected.txt M LayoutTests/platform/ios-wk2/editing/style/create-block-for-style-011-expected.txt M LayoutTests/platform/ios-wk2/editing/style/create-block-for-style-012-expected.txt M LayoutTests/platform/ios-wk2/editing/style/relative-font-size-change-001-expected.txt M LayoutTests/platform/ios-wk2/editing/style/relative-font-size-change-002-expected.txt M LayoutTests/platform/ios-wk2/editing/style/relative-font-size-change-003-expected.txt M LayoutTests/platform/
[webkit-changes] [WebKit/WebKit] 07860f: Unprefix font-size: -webkit-xxx-large
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07860fac0bbf23c58f3e2519f46cc8de480452c8 https://github.com/WebKit/WebKit/commit/07860fac0bbf23c58f3e2519f46cc8de480452c8 Author: Tim Nguyen Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M LayoutTests/editing/style/push-down-font-styles-mac-expected.txt M LayoutTests/editing/style/push-down-font-styles-mac.html M LayoutTests/editing/style/push-down-font-styles-win-expected.txt M LayoutTests/editing/style/push-down-font-styles-win.html A LayoutTests/fast/css/font-size-webkit-xxx-large-expected.html A LayoutTests/fast/css/font-size-webkit-xxx-large.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-xxx-large.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-valid-expected.txt M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/editing/EditingStyle.cpp M Source/WebCore/html/HTMLFontElement.cpp M Source/WebCore/platform/graphics/FontCascadeDescription.h M Source/WebCore/style/StyleBuilderCustom.h M Source/WebCore/style/StyleFontSizeFunctions.h M Source/WebCore/style/StyleResolveForFontRaw.cpp M Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js Log Message: --- Unprefix font-size: -webkit-xxx-large https://bugs.webkit.org/show_bug.cgi?id=246574 rdar://101207950 Reviewed by Myles C. Maxfield. xxx-large is now part of the spec and matches what we've implemented: https://drafts.csswg.org/css-fonts-4/#valdef-font-size-absolute-size Make -webkit-xxx-large an alias of xxx-large at parse-time, so it's easy to remove later on. * LayoutTests/editing/style/push-down-font-styles-mac-expected.txt: * LayoutTests/editing/style/push-down-font-styles-mac.html: * LayoutTests/editing/style/push-down-font-styles-win-expected.txt: * LayoutTests/editing/style/push-down-font-styles-win.html: * LayoutTests/fast/css/font-size-webkit-xxx-large-expected.html: Added. * LayoutTests/fast/css/font-size-webkit-xxx-large.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-xxx-large.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-valid-expected.txt: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontSize): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeFontSizeRaw): * Source/WebCore/editing/EditingStyle.cpp: (WebCore::legacyFontSizeFromCSSValue): * Source/WebCore/html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::cssValueFromFontSizeNumber): * Source/WebCore/platform/graphics/FontCascadeDescription.h: (WebCore::FontCascadeDescription::keywordSizeAsIdentifier const): (WebCore::FontCascadeDescription::setKeywordSizeFromIdentifier): * Source/WebCore/style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyValueFontSize): * Source/WebCore/style/StyleFontSizeFunctions.h: * Source/WebCore/style/StyleResolveForFontRaw.cpp: (WebCore::Style::resolveForFontRaw): * Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js: Canonical link: https://commits.webkit.org/255602@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d192f: [libpas] Support MallocStackLogging
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d192fe3d632fdaec9371af3f54db375cd9afe95 https://github.com/WebKit/WebKit/commit/5d192fe3d632fdaec9371af3f54db375cd9afe95 Author: Yusuke Suzuki Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Source/bmalloc/CMakeLists.txt M Source/bmalloc/bmalloc.xcodeproj/project.pbxproj M Source/bmalloc/bmalloc/Environment.cpp M Source/bmalloc/libpas/src/libpas/pas_darwin_spi.h M Source/bmalloc/libpas/src/libpas/pas_deallocate.c M Source/bmalloc/libpas/src/libpas/pas_deallocate.h M Source/bmalloc/libpas/src/libpas/pas_local_allocator_inlines.h A Source/bmalloc/libpas/src/libpas/pas_malloc_stack_logging.c A Source/bmalloc/libpas/src/libpas/pas_malloc_stack_logging.h M Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.h M Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h M Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h Log Message: --- [libpas] Support MallocStackLogging https://bugs.webkit.org/show_bug.cgi?id=246581 rdar://101210195 Reviewed by Darin Adler. This patch adds MallocStackLogging (MSL) support to libpas. After this change, bmalloc will not fallback to system malloc with MallocStackLogging environment variable (Malloc environment variable etc. fallbacks), and enable libpas MSL. The limitation is that libpas is not supporting on-demand enablement of MSL. If we would like to collect data, MallocStackLogging environment variable needs to be set (or use system malloc as before, right now). libmalloc is invoking malloc_logger hook function on allocations and deallocations. The other framework implements MSL's actual stacktrace capturing and it configures malloc_logger hook function, and this is how MSL is implemented in libmalloc. We do the same thing in libpas: calling malloc_logger hook function on allocations and deallocations. The challenge is that how to avoid adding these code into the hottest fast path in libpas: libpas allocation path is super tightly optimized and any additional load etc. regress performance severely. We took similar approach to our system malloc enablement in libpas: when libpas found MallocStackLogging, it disables thread-local-cache completely. This enforces all allocations and deallocations go to the slow path. Then, we inserted this hook in the slow path so that we insert this logging without performance penalty when MSL is not enabled. We ensured that MSL works and no performance penalty is observed from A/B tests. * Source/bmalloc/CMakeLists.txt: * Source/bmalloc/bmalloc.xcodeproj/project.pbxproj: * Source/bmalloc/bmalloc/Environment.cpp: (bmalloc::isMallocEnvironmentVariableImplyingSystemMallocSet): * Source/bmalloc/libpas/src/libpas/pas_darwin_spi.h: * Source/bmalloc/libpas/src/libpas/pas_deallocate.c: (pas_try_deallocate_slow_no_cache): * Source/bmalloc/libpas/src/libpas/pas_deallocate.h: (pas_try_deallocate_not_small_exclusive_segregated): * Source/bmalloc/libpas/src/libpas/pas_local_allocator_inlines.h: * Source/bmalloc/libpas/src/libpas/pas_malloc_stack_logging.c: Copied from Source/bmalloc/libpas/src/libpas/pas_darwin_spi.h. (compute_msl_status): (pas_compute_msl_is_enabled): (pas_msl_malloc_logging_slow): (pas_msl_free_logging_slow): * Source/bmalloc/libpas/src/libpas/pas_malloc_stack_logging.h: Added. (pas_msl_is_enabled): (pas_msl_malloc_logging): (pas_msl_free_logging): * Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.h: (pas_thread_local_cache_can_set): * Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h: (pas_try_allocate_common_impl_slow): * Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h: (pas_try_reallocate_table_bitfit_case): (pas_try_reallocate): Canonical link: https://commits.webkit.org/255601@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 712657: StringImpl::copyCharacters incorrectly uses memcpy...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71265755b78a83c1cc5614e3fede36899e4e3a05 https://github.com/WebKit/WebKit/commit/71265755b78a83c1cc5614e3fede36899e4e3a05 Author: Darin Adler Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M Source/JavaScriptCore/API/OpaqueJSString.cpp M Source/JavaScriptCore/jit/ExecutableAllocationFuzz.cpp M Source/JavaScriptCore/parser/Lexer.cpp M Source/JavaScriptCore/runtime/IntlLocale.cpp M Source/JavaScriptCore/runtime/IntlObjectInlines.h M Source/JavaScriptCore/runtime/JSString.cpp M Source/JavaScriptCore/runtime/JSStringJoiner.cpp M Source/JavaScriptCore/runtime/StringPrototype.cpp M Source/JavaScriptCore/runtime/StringPrototypeInlines.h M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/WTF/wtf/DateMath.cpp M Source/WTF/wtf/LogInitialization.cpp M Source/WTF/wtf/Logger.cpp M Source/WTF/wtf/SortedArrayMap.h M Source/WTF/wtf/Threading.cpp M Source/WTF/wtf/generic/RunLoopGeneric.cpp M Source/WTF/wtf/linux/RealTimeThreads.cpp M Source/WTF/wtf/text/ASCIIFastPath.h M Source/WTF/wtf/text/AtomString.h M Source/WTF/wtf/text/Base64.h M Source/WTF/wtf/text/IntegerToStringConversion.h M Source/WTF/wtf/text/StringConcatenate.h M Source/WTF/wtf/text/StringImpl.h M Source/WTF/wtf/text/StringView.h M Source/WTF/wtf/text/WTFString.cpp M Source/WTF/wtf/text/WTFString.h M Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp M Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp M Source/WebCore/html/HTMLImageElement.cpp M Source/WebCore/html/HTMLImageElement.h M Source/WebCore/html/LinkRelAttribute.cpp M Source/WebCore/html/LinkRelAttribute.h M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/html/parser/AtomHTMLToken.h M Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp M Source/WebCore/html/parser/HTMLMetaCharsetParser.h M Source/WebCore/html/parser/HTMLPreloadScanner.cpp M Source/WebCore/html/parser/HTMLSrcsetParser.cpp M Source/WebCore/html/parser/HTMLSrcsetParser.h M Source/WebCore/html/parser/HTMLTreeBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/page/PageSerializer.cpp M Source/WebCore/platform/glib/ApplicationGLib.cpp M Source/WebCore/platform/graphics/ComplexTextController.cpp M Source/WebCore/platform/graphics/StringTruncator.cpp M Source/WebCore/platform/graphics/TextRun.h M Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h M Source/WebCore/platform/graphics/win/FontCacheWin.cpp M Source/WebCore/platform/mediastream/CaptureDevice.h M Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp M Source/WebCore/platform/win/PasteboardWin.cpp M Source/WebCore/platform/xr/openxr/OpenXRInstance.cpp M Source/WebKit/Platform/LogInitialization.cpp M Source/WebKit/Shared/API/c/WKString.cpp M Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm M Source/WebKit/webpushd/PushService.mm M Source/WebKitLegacy/win/DOMCoreClasses.cpp M Source/WebKitLegacy/win/WebKitGraphics.cpp M Source/WebKitLegacy/win/WebView.cpp M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp Log Message: --- StringImpl::copyCharacters incorrectly uses memcpy on destination pointers that may be null https://bugs.webkit.org/show_bug.cgi?id=246260 We should assert StringImpl::copyCharacters does not discard information https://bugs.webkit.org/show_bug.cgi?id=205355 rdar://problem/100962334 Reviewed by Yusuke Suzuki. After studying the call sites of StringImpl::copyCharacters and its implementation, it is clear that many callers can pass nullptr for either the source or destination when the length passed in is 0. Since std::memcpy behavior is undefined in such cases, need to change the implementation of StringImpl::copyCharacters to not use it in those cases. In the end, decided to check for zero length even though I advised against that previously. Visiting all the call sites of StringImpl::copyCharacters led to discovering some other anomalies that are fixed with improved coding idioms, no major changes. * Source/JavaScriptCore/API/OpaqueJSString.cpp: (OpaqueJSString::characters): Updated for name change of StringView::getCharacters. * Source/JavaScriptCore/jit/ExecutableAllocationFuzz.cpp: Added include of NeverDestroyed.h. * Source/JavaScriptCore/parser/Lexer.cpp: (JSC::Lexer::parseCommentDirectiveValue): Use String::make8Bit instead of StringImpl::createUninitialized, for code that is more straightforward. Also wondering why we don't need this optimization in more places. * Source/JavaScriptCore/runtime/IntlLocale.cpp: (JSC::LocaleIDBuilder::setKeywordValue): Use StringView::getCharacters. * Source/JavaScriptCore/runtime/IntlObjectInlines.h: (JSC::ListFormatIn
