[webkit-changes] [WebKit/WebKit] 38ce5b: XMLSerializer.serializeToString() should support A...

2022-10-28 Thread Ahmad Saleem
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38ce5b803b349852d5800b8027e123ca8248e30f
  
https://github.com/WebKit/WebKit/commit/38ce5b803b349852d5800b8027e123ca8248e30f
  Author: Ahmad Saleem 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M LayoutTests/fast/dom/XMLSerializer-expected.txt
M LayoutTests/fast/dom/XMLSerializer.html
M Source/WebCore/editing/MarkupAccumulator.cpp

  Log Message:
  ---
  XMLSerializer.serializeToString() should support Attr node as parameter

XMLSerializer.serializeToString() should support Attr node as parameter
https://bugs.webkit.org/show_bug.cgi?id=247096

Reviewed by Ryosuke Niwa.

This is to align Webkit with Blink / Chrome.

Inspired from - 
https://chromium.googlesource.com/chromium/src.git/+/271184ec08ca181a7d93eed532f3ce9efb9c0bcc

The specification [1] doesn't define the behavior for Attr because the
specification assumes Attr is not a Node. However, passing an Attr is possible
now and we should not have an assertion failure.

This patch is aimed to serializeToString() matching to Web Specification.
It means serializing the attribute value.

[1] https://w3c.github.io/DOM-Parsing/#dfn-concept-serialize-xml

* Source/WebCore/editing/MarkupAccumulator.cpp: Added "Attr.h" header
(MarkAccumulator::appendNonElementNode): Add result value for "Attribute Node"
* LayoutTests/fast/dom/XMLSerializer.html: Updated to use "testharness" and 
Attr test as well
* LayoutTests/fast/dom/XMLSerializer-expected.txt: Added Test Case Expectations

Canonical link: https://commits.webkit.org/256126@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] cf7b17: Fix hasRareData() check in Element

2022-10-28 Thread Chirag Shah
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf7b17d7b271c61e6175cf6f6b5d5ae049b1a815
  
https://github.com/WebKit/WebKit/commit/cf7b17d7b271c61e6175cf6f6b5d5ae049b1a815
  Author: Chirag M Shah 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/dom/Element.cpp

  Log Message:
  ---
  Fix hasRareData() check in Element

https://bugs.webkit.org/show_bug.cgi?id=247215

We should be calling hasRareData() on the element parameter instead of
this, so that we don't trip over the security assertion.

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attributeChanged):

Canonical link: https://commits.webkit.org/256125@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 7a1bb8: Fix error in entitlement array

2022-10-28 Thread Per Arne Vollan
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a1bb8a93b3a9af95e79e33f83d1ada0b59c8c50
  
https://github.com/WebKit/WebKit/commit/7a1bb8a93b3a9af95e79e33f83d1ada0b59c8c50
  Author: Per Arne Vollan 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebKit/Scripts/process-entitlements.sh

  Log Message:
  ---
  Fix error in entitlement array
https://bugs.webkit.org/show_bug.cgi?id=247219
rdar://101697089

Unreviewed, fix error in entitlement array after 256019@main.

* Source/WebKit/Scripts/process-entitlements.sh:

Canonical link: https://commits.webkit.org/256124@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3070b3: Add PropertyWrapperFontWeight to bound the values ...

2022-10-28 Thread Chirag Shah
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3070b3d704a3a9364da1442c873419a7b6757343
  
https://github.com/WebKit/WebKit/commit/3070b3d704a3a9364da1442c873419a7b6757343
  Author: Chirag M Shah 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
A LayoutTests/fonts/font-weight-invalid-crash-expected.txt
A LayoutTests/fonts/font-weight-invalid-crash.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M Source/WebCore/animation/CSSPropertyAnimation.cpp

  Log Message:
  ---
  Add PropertyWrapperFontWeight to bound the values for weight
https://bugs.webkit.org/show_bug.cgi?id=247140
rdar://problem/100986499

Reviewed by Myles C. Maxfield.

Currently, fontWeight wasn't bounded based on the CSS specs, which led
to scenarios where FontSelectionRequest had a 0 fontWeight, and which
resulted in an empty FontSelectionRequest, which is an invalid key
based for the HashMap segmentedFontFaceCache. This resulted in map
corruption, which led to a crash. The change fixes the issue by
correctly defining PropertyWrapperFontWeight, which doesn't allow the
blend() to set invalid weight values.

Test: fonts/font-weight-invalid-crash.html

* LayoutTests/fonts/font-weight-invalid-crash-expected.txt: Added.
* LayoutTests/fonts/font-weight-invalid-crash.html: Added.
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
* 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:

Canonical link: https://commits.webkit.org/256123@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] a2cbeb: SVG animations should respect Page::imageAnimation...

2022-10-28 Thread Tyler Wilcock
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2cbeb35dc5185e2c7f501cc19db8deea5e7de8f
  
https://github.com/WebKit/WebKit/commit/a2cbeb35dc5185e2c7f501cc19db8deea5e7de8f
  Author: Tyler Wilcock 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
A 
LayoutTests/fast/images/pagewide-play-pause-animateTransform-svg-animation-expected.txt
A 
LayoutTests/fast/images/pagewide-play-pause-animateTransform-svg-animation.html
A 
LayoutTests/fast/images/pagewide-play-pause-offscreen-animations-expected.txt
A LayoutTests/fast/images/pagewide-play-pause-offscreen-animations.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/page/FrameView.cpp
M Source/WebCore/page/FrameView.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/rendering/RenderView.h
M Source/WebCore/svg/SVGDocumentExtensions.cpp
M Source/WebCore/svg/SVGDocumentExtensions.h
M Source/WebCore/svg/SVGSVGElement.cpp
M Source/WebCore/svg/SVGSVGElement.h
M Source/WebCore/svg/graphics/SVGImage.cpp
M Source/WebCore/svg/graphics/SVGImage.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl

  Log Message:
  ---
  SVG animations should respect Page::imageAnimationEnabled
https://bugs.webkit.org/show_bug.cgi?id=245399
rdar://100143723

Reviewed by Chris Fleizach.

In https://bugs.webkit.org/show_bug.cgi?id=244128 (Add experimental
feature to control image animation play/pause state), we added a
page-wide setting to control animation play/pause state. SVG
animations should respect this setting too.

This patch also fixes a bug where re-enabling page-wide animation did
not cause animations offscreen during the setting change to be
resumed when they later became visible in the viewport (instead, they
remained permanently paused).

* 
LayoutTests/fast/images/pagewide-play-pause-animateTransform-svg-animation-expected.txt:
 Added.
* 
LayoutTests/fast/images/pagewide-play-pause-animateTransform-svg-animation.html:
 Added.
* 
LayoutTests/fast/images/pagewide-play-pause-offscreen-animations-expected.txt: 
Added.
* LayoutTests/fast/images/pagewide-play-pause-offscreen-animations.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
Skip new pagewide-play-pause-offscreen-animations.html test due to differences 
in animation and
viewport behavior in WK1 / DumpRenderTree.

* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::updatePlayStateForAllAnimations):
(WebCore::FrameView::updatePlayStateForAllAnimationsIncludingSubframes):
(WebCore::FrameView::repaintVisibleImageAnimations): Deleted.
(WebCore::FrameView::repaintVisibleImageAnimationsIncludingSubframes): Deleted.
* Source/WebCore/page/FrameView.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setImageAnimationEnabled):
(WebCore::Page::updatePlayStateForAllAnimations):
(WebCore::Page::repaintAnimatedImages): Deleted.
* Source/WebCore/page/Page.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintForPausedImageAnimationsIfNeeded):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::resumePausedImageAnimationsIfNeeded):
Check new m_SVGSVGElementsWithPausedImageAnimation member for paused SVG
animations and resume them if needed.
(WebCore::svgSvgElementFrom): Added.
(WebCore::RenderView::updatePlayStateForAllAnimations):
(WebCore::RenderView::repaintImageAnimationsIfNeeded): Deleted.
All methods added in https://bugs.webkit.org/show_bug.cgi?id=244128 and
named like "repaintImageAnimationsIfNeeded" are renamed to 
updatePlayStateForAllAnimations,
since these methods now do more than repaints (because SVG animations have 
explicit resume / pause methods).

* Source/WebCore/rendering/RenderView.h:
Add new m_SVGSVGElementsWithPausedImageAnimation member. This allows us
to keep track of the paused SVG animations so that we can resume them as
they become visible in the viewport, similar to 
m_renderersWithPausedImageAnimation.

* Source/WebCore/svg/SVGDocumentExtensions.cpp:
(WebCore::animationsPausedForDocument): Added.
(WebCore::SVGDocumentExtensions::SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::allSVGSVGElements const): Added.
* Source/WebCore/svg/SVGDocumentExtensions.h:
* Source/WebCore/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::resumePausedAnimationsIfNeeded): Added.
* Source/WebCore/svg/SVGSVGElement.h:
* Source/WebCore/svg/graphics/SVGImage.cpp:
* Source/WebCore/svg/graphics/SVGImage.h:
(WebCore::SVGImage::resumeAnimation):
Added. Different from SVGImage::startAnimation in that it starts the
animation from where it last left off rather than from the beginning.

* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::allSVGSVGElements const): Added.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals

[webkit-changes] [WebKit/WebKit] cc8993: [Cocoa] Follow-up localized string addition for fu...

2022-10-28 Thread Jer Noble
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc8993e5d72616414c122fce426de067a0069dea
  
https://github.com/WebKit/WebKit/commit/cc8993e5d72616414c122fce426de067a0069dea
  Author: Jer Noble 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/en.lproj/Localizable.strings

  Log Message:
  ---
  [Cocoa] Follow-up localized string addition for fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=247217
rdar://101695343

Reviewed by Tim Horton.

* Source/WebCore/en.lproj/Localizable.strings:

Canonical link: https://commits.webkit.org/256121@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit]

2022-10-28 Thread Alan Coon
  Branch: refs/tags/WebKit-7615.1.11.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 0d5545: Add Web Extension code generator scripts, bindings...

2022-10-28 Thread Timothy Hatcher
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d554516d6f8d662d907d5200b95b9c321e29d62
  
https://github.com/WebKit/WebKit/commit/0d554516d6f8d662d907d5200b95b9c321e29d62
  Author: Timothy Hatcher 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Scripts/generate-derived-sources.sh
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
A 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIExtensionCocoa.mm
A 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm
A 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm
A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIExtension.h
A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h
A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIObject.h
A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIRuntime.h
A 
Source/WebKit/WebProcess/Extensions/Bindings/Cocoa/JSWebExtensionWrapperCocoa.mm
A Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrappable.h
A Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.cpp
A Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.h
A 
Source/WebKit/WebProcess/Extensions/Bindings/Scripts/CodeGeneratorExtensions.pm
A Source/WebKit/WebProcess/Extensions/Bindings/Scripts/IDLAttributes.json
A 
Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIExtension.idl
A 
Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl
A Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIRuntime.idl
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h
M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp

  Log Message:
  ---
  Add Web Extension code generator scripts, bindings glue, and some IDL files.
https://bugs.webkit.org/show_bug.cgi?id=246410

Reviewed by Brian Weinstein.

This stands up the code generator for the JavaScript bindings for Web 
Extensions.
This has been tested with all the IDL files, but I'm only adding a couple 
partial
interfaces with stub implementations to keep this change small. The rest of the
interfaces files will be added as the API areas are added.

For each IDL file in WebProcess/Extensions/Interfaces, a corresponding header 
and
implementation is expected in WebProcess/Extensions/API.

The bulk of the binding helpers are defined in JSWebExtensionWrapper.h, with 
converter
functions and the JSWebExtensionWrapper and WebExtensionCallbackHandler classes.

The WebExtensionCallbackHandler class handles the two ways Web Extensions can
process async results — the Manifest v2 callback function way, or the Manifest 
v3
Promise result method. This lets the API layer be agnostic about which one the
JavaScript is using and report results or errors consistently.

This is untested (besides successfully building) until API injection can be 
done.
Most of this was copied from Safari's existing implementation and changed for
WebKit to use more C++, and use WebCore's bindings scripts.

* Source/WebKit/DerivedSources-input.xcfilelist: Auto generated.
* Source/WebKit/DerivedSources-output.xcfilelist: Ditto.
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Scripts/generate-derived-sources.sh: Added WebCoreScripts var.
* Source/WebKit/SourcesCocoa.txt: Added new file.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj: Added new files.
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIExtensionCocoa.mm: 
Added.
(WebKit::WebExtensionAPIExtension::isPropertyAllowed):
(WebKit::WebExtensionAPIExtension::getURL):
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm: 
Added.
(WebKit::WebExtensionAPINamespace::extension):
(WebKit::WebExtensionAPINamespace::runtime):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm: 
Added.
(WebKit::WebExtensionAPIRuntimeBase::reportErrorForCallbackHandler):
(WebKit::WebExtensionAPIRuntime::getURL):
(WebKit::WebExtensionAPIRuntime::getManifest):
(WebKit::WebExtensionAPIRuntime::runtimeIdentifier):
(WebKit::WebExtensionAPIRuntime::getPlatformInfo):
(WebKit::WebExtensionAPIRuntime::lastError):
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIExtension.h: Added.
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h: Added.
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIObject.h: Added.
(WebKit::WebExtensionAPIObject::WebExtensionAPIObject):
(WebKit::WebExtensionAPIObject::forMainWorld const):
(WebKit::WebExtensionAPIObject::isForMainWorld const):
(WebKit::W

[webkit-changes] [WebKit/WebKit] 05f6c1: Cherry-pick f7b1858ae823. rdar://problem/101694967

2022-10-28 Thread Alan Coon
  Branch: refs/heads/safari-7615.1.11-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 05f6c13ad0185775a0970eee2888d9a089c8561b
  
https://github.com/WebKit/WebKit/commit/05f6c13ad0185775a0970eee2888d9a089c8561b
  Author: Alan Coon 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
R Source/WebCore/PAL/libavif/android_jni/gradle/wrapper/gradle-wrapper.jar

  Log Message:
  ---
  Cherry-pick f7b1858ae823. rdar://problem/101694967

Remove 
./Source/WebCore/PAL/libavif/android_jni/gradle/wrapper/gradle-wrapper.jar
https://bugs.webkit.org/show_bug.cgi?id=247216
rdar://101694967

Unreviewed.

* Source/WebCore/PAL/libavif/android_jni/gradle/wrapper/gradle-wrapper.jar: 
Removed.

Canonical link: https://commits.webkit.org/256116@main

Canonical link: https://commits.webkit.org/255891.6@safari-7615.1.11-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3a69dc: Ingest managed domains for ResourceLoadStatistics ...

2022-10-28 Thread J Pascoe
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a69dcff7becc04c05bd108b7cdd53f69426d056
  
https://github.com/WebKit/WebKit/commit/3a69dcff7becc04c05bd108b7cdd53f69426d056
  Author: J Pascoe 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
A 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-website-data-deletion-database-expected.txt
A 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-website-data-deletion-database.html
A 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-website-data-deletion-expected.txt
A 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-website-data-deletion.html
A 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-granted-storage-access-api-expected.txt
A 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-granted-storage-access-api.html
A 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-third-party-resources-exempt-from-cookie-blocking-expected.txt
A 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-third-party-resources-exempt-from-cookie-blocking.html
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h
M Source/WebCore/platform/network/NetworkStorageSession.cpp
M Source/WebCore/platform/network/NetworkStorageSession.h
M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h
M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp
M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/Shared/ResourceLoadStatisticsParameters.h
M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
M Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h
M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/TestInvocation.cpp
M Tools/WebKitTestRunner/TestInvocation.h

  Log Message:
  ---
  Ingest managed domains for ResourceLoadStatistics and loosen restrictions for 
them.
https://bugs.webkit.org/show_bug.cgi?id=246290
rdar://97344886

Reviewed by John Wilander.

This patch starts to ingest a small set of managed domains that are specically 
allowed
to use certain features normally disabled by resource load statistics. This 
patch ingests
the set on macOS and other Apple platforms.

The behavior change with regards to ResourceLoadStatistics is similar to what we
do for app-bound domains, but not exactly. These domains are exempted from 
certain deletion and
blocking policies.

* 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-cookie-blocking-between-each-other-expected.txt:
 Added.
* 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-cookie-blocking-between-each-other.html:
 Added.
* 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-website-data-deletion-database-expected.txt:
 Added.
* 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-website-data-deletion-database.html:
 Added.
* 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-website-data-deletion-expected.txt:
 Added.
* 
LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/managed-domains-exempt-from-website-data-deletion.html:
 Added.
* Source/WebCore/platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::shouldBlockCookies const):
(WebCore::NetworkStorageSession::setManagedDomains):
(WebCore::NetworkStorageSession::resetManagedDomains):
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::setManagedDomains):
(WebKit::Re

[webkit-changes] [WebKit/WebKit] f29814: CG display lists should be replayed with asynchron...

2022-10-28 Thread Tim Horton
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f29814a52babaac4eb2bc1786881762a842c5f74
  
https://github.com/WebKit/WebKit/commit/f29814a52babaac4eb2bc1786881762a842c5f74
  Author: Tim Horton 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm

  Log Message:
  ---
  CG display lists should be replayed with asynchronous rendering if appropriate
https://bugs.webkit.org/show_bug.cgi?id=247214
rdar://99473475

Reviewed by Dean Jackson.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
Enable asynchronous rendering if the original content was rendered using it.

Canonical link: https://commits.webkit.org/256118@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] e9c09a: Versioning.

2022-10-28 Thread Alan Coon
  Branch: refs/heads/safari-7615.1.11-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: e9c09a71d8e2718f9d86f85c073ae92e5afa6ddf
  
https://github.com/WebKit/WebKit/commit/e9c09a71d8e2718f9d86f85c073ae92e5afa6ddf
  Author: Alan Coon 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7615.1.11.1

Canonical link: https://commits.webkit.org/255891.5@safari-7615.1.11-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 7bb832: [Cocoa] Enhance per-navigation "network connection...

2022-10-28 Thread Matthew Finkel
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7bb832b8998d11bcb705f81e354d9cb5ecd1cd5a
  
https://github.com/WebKit/WebKit/commit/7bb832b8998d11bcb705f81e354d9cb5ecd1cd5a
  Author: Matthew Finkel 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/loader/DocumentLoader.h
A Source/WebCore/platform/network/NetworkConnectionIntegrity.h
M Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
M Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
M Source/WebKit/NetworkProcess/NetworkLoadChecker.h
M Source/WebKit/NetworkProcess/NetworkLoadParameters.h
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp
M Source/WebKit/NetworkProcess/NetworkSocketChannel.h
M Source/WebKit/NetworkProcess/PingLoad.cpp
M 
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp
M 
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp
M Source/WebKit/NetworkProcess/cache/AsyncRevalidation.cpp
M Source/WebKit/NetworkProcess/cache/AsyncRevalidation.h
M Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCache.h
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h
M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp
M Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.h
M Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp
M Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.h
M Source/WebKit/Shared/WebsitePoliciesData.cpp
M Source/WebKit/Shared/WebsitePoliciesData.h
M Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp
M Source/WebKit/UIProcess/API/APIWebsitePolicies.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
M Source/WebKit/WebProcess/Network/WebSocketChannel.cpp

  Log Message:
  ---
  [Cocoa] Enhance per-navigation "network connection integrity" setting
https://bugs.webkit.org/show_bug.cgi?id=247191
rdar://problem/101676643

Reviewed by Wenson Hsieh.

Introduce NetworkConnectionIntegrity OptionSet for defining a policy that is
applied to a webpage's resource requests. This is an enhancement of an earlier
boolean option that controlled this behavior.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/loader/DocumentLoader.h:
(WebCore::DocumentLoader::setNetworkConnectionIntegrityPolicy):
(WebCore::DocumentLoader::networkConnectionIntegrityPolicy const):
(WebCore::DocumentLoader::setNetworkConnectionIntegrityEnabled): Deleted.
(WebCore::DocumentLoader::networkConnectionIntegrityEnabled const): Deleted.
* Source/WebCore/platform/network/NetworkConnectionIntegrity.h: Copied from 
Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.h.
* Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
* Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::createSocketChannel):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):
* Source/WebKit/NetworkProcess/NetworkLoadChecker.h:
* Source/WebKit/NetworkProcess/NetworkLoadParameters.h:
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
* Source/WebKit/Ne

[webkit-changes] [WebKit/WebKit] f7b185: Remove ./Source/WebCore/PAL/libavif/android_jni/gr...

2022-10-28 Thread Alan Coon
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7b1858ae8235d40aedbee9aa0f35c9598d69002
  
https://github.com/WebKit/WebKit/commit/f7b1858ae8235d40aedbee9aa0f35c9598d69002
  Author: Alan Coon 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
R Source/WebCore/PAL/libavif/android_jni/gradle/wrapper/gradle-wrapper.jar

  Log Message:
  ---
  Remove 
./Source/WebCore/PAL/libavif/android_jni/gradle/wrapper/gradle-wrapper.jar
https://bugs.webkit.org/show_bug.cgi?id=247216
rdar://101694967

Unreviewed.

* Source/WebCore/PAL/libavif/android_jni/gradle/wrapper/gradle-wrapper.jar: 
Removed.

Canonical link: https://commits.webkit.org/256116@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 31aebd: [JSC] Simplify toThis operation

2022-10-28 Thread Yusuke Suzuki
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31aebd3fc407818a8f06a584c1b44c867ece902a
  
https://github.com/WebKit/WebKit/commit/31aebd3fc407818a8f06a584c1b44c867ece902a
  Author: Yusuke Suzuki 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/JavaScriptCore/API/JSContextRef.cpp
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
M Source/JavaScriptCore/dfg/DFGGraph.h
M Source/JavaScriptCore/runtime/ClassInfo.h
M Source/JavaScriptCore/runtime/JSCJSValue.cpp
M Source/JavaScriptCore/runtime/JSCJSValue.h
M Source/JavaScriptCore/runtime/JSCJSValueInlines.h
M Source/JavaScriptCore/runtime/JSCell.cpp
M Source/JavaScriptCore/runtime/JSCell.h
M Source/JavaScriptCore/runtime/JSObject.cpp
M Source/JavaScriptCore/runtime/JSObject.h
M Source/JavaScriptCore/runtime/JSScope.cpp
M Source/JavaScriptCore/runtime/JSScope.h
M Source/JavaScriptCore/runtime/JSString.cpp
M Source/JavaScriptCore/runtime/JSString.h

  Log Message:
  ---
  [JSC] Simplify toThis operation
https://bugs.webkit.org/show_bug.cgi?id=247162
rdar://101662631

Reviewed by Mark Lam.

This patch removes toThis hook in ClassInfo, and simplfy JSValue::toThis.
It is called relatively frequently in runtime functions. We should avoid 
dispatching
dynamic virtual function for most of the cases.

* Source/JavaScriptCore/API/JSContextRef.cpp:
(JSContextGetGlobalObject):
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::isToThisAnIdentity):
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* Source/JavaScriptCore/dfg/DFGGraph.h:
* Source/JavaScriptCore/runtime/ClassInfo.h:
* Source/JavaScriptCore/runtime/JSCJSValue.cpp:
(JSC::JSValue::toThisSloppySlowCase const):
(JSC::JSValue::toThisSlowCase const): Deleted.
* Source/JavaScriptCore/runtime/JSCJSValue.h:
* Source/JavaScriptCore/runtime/JSCJSValueInlines.h:
(JSC::JSValue::toThis const):
* Source/JavaScriptCore/runtime/JSCell.cpp:
(JSC::JSCell::toThis): Deleted.
* Source/JavaScriptCore/runtime/JSCell.h:
* Source/JavaScriptCore/runtime/JSObject.cpp:
(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::JSObject::toThis): Deleted.
* Source/JavaScriptCore/runtime/JSObject.h:
* Source/JavaScriptCore/runtime/JSScope.cpp:
(JSC::JSScope::toThis): Deleted.
* Source/JavaScriptCore/runtime/JSScope.h:
* Source/JavaScriptCore/runtime/JSString.cpp:
(JSC::JSString::toThis): Deleted.
* Source/JavaScriptCore/runtime/JSString.h:

Canonical link: https://commits.webkit.org/256115@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 82d2d6: Remove WebGLLoadPolicy code

2022-10-28 Thread Dean Jackson
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82d2d64c2ad7dcc2163f7ca040b73f587bd1b833
  
https://github.com/WebKit/WebKit/commit/82d2d64c2ad7dcc2163f7ca040b73f587bd1b833
  Author: Dean Jackson 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
R LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt
R LayoutTests/fast/canvas/webgl/useWhilePending.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
M Source/WebCore/loader/FrameLoaderClient.h
M Source/WebCore/loader/FrameLoaderTypes.h
M Source/WebCore/page/Settings.yaml
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/UIProcess/API/APINavigationClient.h
M Source/WebKit/UIProcess/API/C/WKAPICast.h
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/C/WKPageLoaderClient.h
M Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h
M Source/WebKit/UIProcess/Cocoa/NavigationState.h
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
M Tools/TestWebKitAPI/SourcesCocoa.txt
R Tools/TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm

  Log Message:
  ---
  Remove WebGLLoadPolicy code
https://bugs.webkit.org/show_bug.cgi?id=247039
rdar://101569935

Reviewed by Kimmo Kinnunen.

We don't use the WebGLLoadPolicy mechanism any more. Remove all the code.

* LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt: Removed.
* LayoutTests/fast/canvas/webgl/useWhilePending.html: Removed.
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
Lots of removal for isContextLostOrPending().
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::isContextLostOrPending): Deleted.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
* Source/WebCore/loader/FrameLoaderClient.h:
* Source/WebCore/loader/FrameLoaderTypes.h:
* Source/WebCore/page/Settings.yaml:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/UIProcess/API/APINavigationClient.h:
(API::NavigationClient::webGLLoadPolicy const): Deleted.
(API::NavigationClient::resolveWebGLLoadPolicy const): Deleted.
* Source/WebKit/UIProcess/API/C/WKAPICast.h:
(WebKit::toWebGLLoadPolicy): Deleted.
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
* Source/WebKit/UIProcess/API/C/WKPageLoaderClient.h:
* Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
* Source/WebKit/UIProcess/Cocoa/NavigationState.h:
* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::toWebCoreWebGLLoadPolicy): Deleted.
(WebKit::NavigationState::NavigationClient::webGLLoadPolicy const): Deleted.
(WebKit::NavigationState::NavigationClient::resolveWebGLLoadPolicy const): 
Deleted.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::webGLPolicyForURL): Deleted.
(WebKit::WebPageProxy::resolveWebGLPolicyForURL): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::webGLPolicyForURL const): Deleted.
(WebKit::WebFrameLoaderClient::resolveWebGLPolicyForURL const): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::webGLPolicyForURL): Deleted.
(WebKit::WebPage::resolveWebGLPolicyForURL): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::webGLPolicyForURL): Deleted.
(WebKit::WebPage::resolveWebGLPolicyForURL): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(shouldBlockWebGL): Deleted.
(WebFrameLoaderClient::webGLPolicyForURL const): Deleted.
(WebFrameLoaderClient::resolveWebGLPolicyForURL const): Deleted.
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm: Removed.

Canonical link: https://commits.webkit.org/256114@main


__

[webkit-changes] [WebKit/WebKit]

2022-10-28 Thread Alan Coon
  Branch: refs/tags/WebKit-7615.1.11
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 51613a: [JSC][armv7] Use register numbers, not names, in d...

2022-10-28 Thread jjgriego
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 51613ad86d5893667dd02bcdc0430f542f766fb9
  
https://github.com/WebKit/WebKit/commit/51613ad86d5893667dd02bcdc0430f542f766fb9
  Author: Joseph Griego 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/JavaScriptCore/disassembler/CapstoneDisassembler.cpp

  Log Message:
  ---
  [JSC][armv7] Use register numbers, not names, in disassembly
https://bugs.webkit.org/show_bug.cgi?id=246708

Reviewed by Yusuke Suzuki.

As title. Capstone by default will use the conventional names for some registers
under the usual ARM abi: e.g. r12 is the "InterProcedural link" register, `ip`,
and r11 is `fp` for ARM code...

Neither of these makes any sense inside of the JIT, which uses r12 as a GPR and
r7 as the frame pointer (like other thumb code does.) To alleviate confusion, I
suggest we ask capstone to just use register numbers for these. Note that `pc`
and `sp` are always named in the ISA, they don't have numbers at all, so they'll
still disassemble as `pc` and `sp`.

* Source/JavaScriptCore/disassembler/CapstoneDisassembler.cpp:
(JSC::tryToDisassemble):

Canonical link: https://commits.webkit.org/256113@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 4a1a50: nullptr crash in WebCore::IDBTransaction::dispatch...

2022-10-28 Thread Miguel Salinas
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a1a50028375e15290414aa3f750adf95e9fe6ee
  
https://github.com/WebKit/WebKit/commit/4a1a50028375e15290414aa3f750adf95e9fe6ee
  Author: Miguel Salinas 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
A LayoutTests/storage/indexeddb/crash-on-getdatabases-expected.txt
A LayoutTests/storage/indexeddb/crash-on-getdatabases.html
A LayoutTests/storage/indexeddb/resources/crash-on-getdatabases.js
M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

  Log Message:
  ---
  nullptr crash in WebCore::IDBTransaction::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=246706
rdar://94637046

Reviewed by Sihui Liu.

We should check if m_openDBRequest is null in
IDBTransaction::dispatchEvent. The repro is flaky but does reproduce for
me ~1/3 of the time. I tried to reduce the test case but it either
stopped reproducing or reproduced significantly less frequently.

* LayoutTests/storage/indexeddb/crash-on-getdatabases-expected.txt: Added.
* LayoutTests/storage/indexeddb/crash-on-getdatabases.html: Added.
* LayoutTests/storage/indexeddb/resources/crash-on-getdatabases.js: Added.
(async testDoesNotCrash):
* Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::dispatchEvent):

Canonical link: https://commits.webkit.org/256112@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 085b98: [JSC] uDFG should be able to watch JSGlobalObject ...

2022-10-28 Thread Yusuke Suzuki
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 085b9807d093d97e6d2df08c98904a85e09465a6
  
https://github.com/WebKit/WebKit/commit/085b9807d093d97e6d2df08c98904a85e09465a6
  Author: Yusuke Suzuki 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp
M Source/JavaScriptCore/dfg/DFGArrayMode.cpp
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/dfg/DFGGraph.h
M Source/JavaScriptCore/dfg/DFGJITCode.cpp
M Source/JavaScriptCore/dfg/DFGJITCode.h
M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp
M Source/JavaScriptCore/dfg/DFGJITCompiler.h
M Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp
M Source/JavaScriptCore/dfg/DFGPlan.cpp
M Source/JavaScriptCore/dfg/DFGPlan.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  ---
  [JSC] uDFG should be able to watch JSGlobalObject WatchpointSets
https://bugs.webkit.org/show_bug.cgi?id=247154
rdar://101657085

Reviewed by Mark Lam.

This patch allows uDFG to watch JSGlobalObject WatchpointSets.
We extract this watchpoint insertion as a LinkerIR. And we run this when 
materializing DFG::JITData,
which should eventually become uDFG's linking phase. We also fixed a bug where 
we missed visiting
uDFG CallLinkInfo in CodeBlock.

* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeJITInlineCaches):
(JSC::CodeBlock::getICStatusMap):
(JSC::CodeBlock::getCallLinkInfoForBytecodeIndex):
* Source/JavaScriptCore/dfg/DFGGraph.h:
* Source/JavaScriptCore/dfg/DFGJITCode.cpp:
(JSC::DFG::JITData::JITData):
(JSC::DFG::attemptToWatch):
(JSC::DFG::JITData::tryInitialize):
* Source/JavaScriptCore/dfg/DFGJITCode.h:
(JSC::DFG::JITData::tryCreate):
(JSC::DFG::JITData::create): Deleted.
* Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::addToConstantPool):
* Source/JavaScriptCore/dfg/DFGJITCompiler.h:
* Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
* Source/JavaScriptCore/dfg/DFGPlan.cpp:
(JSC::DFG::Plan::tryFinalizeJITData):
(JSC::DFG::Plan::finalizeJITData): Deleted.
* Source/JavaScriptCore/dfg/DFGPlan.h:

Canonical link: https://commits.webkit.org/256111@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 30e20b: [ITP Cleanup] Rename some resource load statistics...

2022-10-28 Thread Wenson Hsieh
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30e20b03def3058764d0b1ee5431fbe1231ed2b7
  
https://github.com/WebKit/WebKit/commit/30e20b03def3058764d0b1ee5431fbe1231ed2b7
  Author: Wenson Hsieh 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id.html
M LayoutTests/http/tests/navigation/statistics.html
M 
LayoutTests/http/tests/referrer-policy-anchor/origin-when-cross-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/no-referrer-when-downgrade/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/no-referrer-when-downgrade/cross-origin-http.https.html
M 
LayoutTests/http/tests/referrer-policy-iframe/no-referrer-when-downgrade/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-iframe/no-referrer/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/no-referrer/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-iframe/no-referrer/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-iframe/origin-when-cross-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/origin-when-cross-origin/cross-origin-http.https.html
M 
LayoutTests/http/tests/referrer-policy-iframe/origin-when-cross-origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-iframe/origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/origin/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-iframe/origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-iframe/same-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/same-origin/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-iframe/same-origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-iframe/strict-origin-when-cross-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/strict-origin-when-cross-origin/cross-origin-http.https.html
M 
LayoutTests/http/tests/referrer-policy-iframe/strict-origin-when-cross-origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-iframe/strict-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/strict-origin/cross-origin-http.https.html
M 
LayoutTests/http/tests/referrer-policy-iframe/strict-origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-iframe/unsafe-url/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-iframe/unsafe-url/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-iframe/unsafe-url/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-img/no-referrer-when-downgrade/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-img/no-referrer-when-downgrade/cross-origin-http.https.html
M 
LayoutTests/http/tests/referrer-policy-img/no-referrer-when-downgrade/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-img/no-referrer/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-img/no-referrer/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-img/no-referrer/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-img/origin-when-cross-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-img/origin-when-cross-origin/cross-origin-http.https.html
M 
LayoutTests/http/tests/referrer-policy-img/origin-when-cross-origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-img/origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-img/origin/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-img/origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-img/same-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-img/same-origin/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-img/same-origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-img/strict-origin-when-cross-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-img/strict-origin-when-cross-origin/cross-origin-http.https.html
M 
LayoutTests/http/tests/referrer-policy-img/strict-origin-when-cross-origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-img/strict-origin/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-img/strict-origin/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-img/strict-origin/same-origin.html
M 
LayoutTests/http/tests/referrer-policy-img/unsafe-url/cross-origin-http-http.html
M 
LayoutTests/http/tests/referrer-policy-img/unsafe-url/cross-origin-http.https.html
M LayoutTests/http/tests/referrer-policy-img/unsafe-

[webkit-changes] [WebKit/WebKit] becd84: More SortedArrayMap clients can use the Packed typ...

2022-10-28 Thread Darin Adler
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: becd8424226a4a29c34b9d66d37d9538f304086b
  
https://github.com/WebKit/WebKit/commit/becd8424226a4a29c34b9d66d37d9538f304086b
  Author: Darin Adler 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WTF/wtf/FileSystem.h
M Source/WTF/wtf/text/ASCIILiteral.h
M Source/WTF/wtf/text/Base64.h
M Source/WTF/wtf/text/StringImpl.h
M Source/WTF/wtf/text/StringSearch.h
M Source/WebCore/html/EnterKeyHint.cpp
M Source/WebCore/html/parser/HTMLTokenizer.h
M Source/WebCore/html/track/WebVTTParser.cpp
M Source/WebCore/platform/KeyboardScrollingAnimator.cpp
M Source/WebCore/platform/graphics/HEVCUtilities.cpp
M Source/WebCore/platform/text/LocaleToScriptMapping.cpp
M Source/WebCore/svg/SVGComponentTransferFunctionElement.h
M Source/WebCore/xml/XPathFunctions.cpp

  Log Message:
  ---
  More SortedArrayMap clients can use the Packed types from that header for 
efficiency
https://bugs.webkit.org/show_bug.cgi?id=246924
rdar://problem/101478661

Reviewed by Yusuke Suzuki.

* Source/WTF/wtf/FileSystem.h: Removed include of Span.h; ASCIILiteral.h pulls 
it in.

* Source/WTF/wtf/text/ASCIILiteral.h: Added ASCIILiteral::span8.

* Source/WTF/wtf/text/Base64.h: Removed include of Span.h.
* Source/WTF/wtf/text/StringImpl.h: Ditto.
* Source/WTF/wtf/text/StringSearch.h: Ditto.

* Source/WebCore/html/EnterKeyHint.cpp:
(WebCore::enterKeyHintForAttributeValue): Use PackedLettersLiteral
instead of ComparableLettersLiteral because the literals all have length <= 8.

* Source/WebCore/html/parser/HTMLTokenizer.h:
(WebCore::HTMLTokenizer::bufferCharacters): Use ASCIILiteral::span8.

* Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::checkAndCreateRegion): Fixed "charecters" typo.
(WebCore::WebVTTParser::checkStyleSheet): Ditto.

* Source/WebCore/platform/KeyboardScrollingAnimator.cpp:
(WebCore::keyboardScrollingKeyForKeyboardEvent): Use 
PackedASCIILiteral
instead of ComparableASCIILiteral because the literals all have length <= 8.

* Source/WebCore/platform/graphics/HEVCUtilities.cpp:
(WebCore::parseDoViCodecType): Use PackedLettersLiteral instead of
PackedASCIILowerCodes because all the characters are compatible with
the faster code path.
(WebCore::profileIDForAlphabeticDoViProfile): Ditto.
* Source/WebCore/platform/text/LocaleToScriptMapping.cpp:
(WebCore::scriptNameToCode): Ditto.

* Source/WebCore/svg/SVGComponentTransferFunctionElement.h:
(WebCore::SVGPropertyTraits::fromString): Use
PackedASCIILiteral instead of ComparableASCIILiteral because the
literals all have length <= 8.

* Source/WebCore/xml/XPathFunctions.cpp:
(WebCore::XPath::toStringView): Deleted.
(WebCore::XPath::FunId::evaluate const): Use the conversion built into 
StringView
instead of the toStringView function.

Canonical link: https://commits.webkit.org/256109@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 280e3b: [SIMD] Add SIMD opcodes and spec tests

2022-10-28 Thread Justin Michaud
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 280e3b5f0857cb4a332ad1103b3390b5fbe4a349
  
https://github.com/WebKit/WebKit/commit/280e3b5f0857cb4a332ad1103b3390b5fbe4a349
  Author: Justin Michaud 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M JSTests/wasm.yaml
A JSTests/wasm/simd-spec-harness.js
A JSTests/wasm/simd-spec-harness/sync_index.js
M JSTests/wasm/spec-tests/harness/async_index.js
M JSTests/wasm/spec-tests/harness/sync_index.js
A JSTests/wasm/spec-tests/simd_address.wast.js
A JSTests/wasm/spec-tests/simd_align.wast.js
A JSTests/wasm/spec-tests/simd_bit_shift.wast.js
A JSTests/wasm/spec-tests/simd_bitwise.wast.js
A JSTests/wasm/spec-tests/simd_boolean.wast.js
A JSTests/wasm/spec-tests/simd_const.wast.js
A JSTests/wasm/spec-tests/simd_conversions.wast.js
A JSTests/wasm/spec-tests/simd_f32x4.wast.js
A JSTests/wasm/spec-tests/simd_f32x4_arith.wast.js
A JSTests/wasm/spec-tests/simd_f32x4_cmp.wast.js
A JSTests/wasm/spec-tests/simd_f32x4_pmin_pmax.wast.js
A JSTests/wasm/spec-tests/simd_f32x4_rounding.wast.js
A JSTests/wasm/spec-tests/simd_f64x2.wast.js
A JSTests/wasm/spec-tests/simd_f64x2_arith.wast.js
A JSTests/wasm/spec-tests/simd_f64x2_cmp.wast.js
A JSTests/wasm/spec-tests/simd_f64x2_pmin_pmax.wast.js
A JSTests/wasm/spec-tests/simd_f64x2_rounding.wast.js
A JSTests/wasm/spec-tests/simd_i16x8_arith.wast.js
A JSTests/wasm/spec-tests/simd_i16x8_arith2.wast.js
A JSTests/wasm/spec-tests/simd_i16x8_cmp.wast.js
A JSTests/wasm/spec-tests/simd_i16x8_extadd_pairwise_i8x16.wast.js
A JSTests/wasm/spec-tests/simd_i16x8_extmul_i8x16.wast.js
A JSTests/wasm/spec-tests/simd_i16x8_q15mulr_sat_s.wast.js
A JSTests/wasm/spec-tests/simd_i16x8_sat_arith.wast.js
A JSTests/wasm/spec-tests/simd_i32x4_arith.wast.js
A JSTests/wasm/spec-tests/simd_i32x4_arith2.wast.js
A JSTests/wasm/spec-tests/simd_i32x4_cmp.wast.js
A JSTests/wasm/spec-tests/simd_i32x4_dot_i16x8.wast.js
A JSTests/wasm/spec-tests/simd_i32x4_extadd_pairwise_i16x8.wast.js
A JSTests/wasm/spec-tests/simd_i32x4_extmul_i16x8.wast.js
A JSTests/wasm/spec-tests/simd_i32x4_trunc_sat_f32x4.wast.js
A JSTests/wasm/spec-tests/simd_i32x4_trunc_sat_f64x2.wast.js
A JSTests/wasm/spec-tests/simd_i64x2_arith.wast.js
A JSTests/wasm/spec-tests/simd_i64x2_arith2.wast.js
A JSTests/wasm/spec-tests/simd_i64x2_cmp.wast.js
A JSTests/wasm/spec-tests/simd_i64x2_extmul_i32x4.wast.js
A JSTests/wasm/spec-tests/simd_i8x16_arith.wast.js
A JSTests/wasm/spec-tests/simd_i8x16_arith2.wast.js
A JSTests/wasm/spec-tests/simd_i8x16_cmp.wast.js
A JSTests/wasm/spec-tests/simd_i8x16_sat_arith.wast.js
A JSTests/wasm/spec-tests/simd_int_to_int_extend.wast.js
A JSTests/wasm/spec-tests/simd_lane.wast.js
A JSTests/wasm/spec-tests/simd_load.wast.js
A JSTests/wasm/spec-tests/simd_load16_lane.wast.js
A JSTests/wasm/spec-tests/simd_load32_lane.wast.js
A JSTests/wasm/spec-tests/simd_load64_lane.wast.js
A JSTests/wasm/spec-tests/simd_load8_lane.wast.js
A JSTests/wasm/spec-tests/simd_load_extend.wast.js
A JSTests/wasm/spec-tests/simd_load_splat.wast.js
A JSTests/wasm/spec-tests/simd_load_zero.wast.js
A JSTests/wasm/spec-tests/simd_splat.wast.js
A JSTests/wasm/spec-tests/simd_store.wast.js
A JSTests/wasm/spec-tests/simd_store16_lane.wast.js
A JSTests/wasm/spec-tests/simd_store32_lane.wast.js
A JSTests/wasm/spec-tests/simd_store64_lane.wast.js
A JSTests/wasm/spec-tests/simd_store8_lane.wast.js
A JSTests/wasm/stress/simd-kitchen-sink.js
A JSTests/wasm/v8/exceptions-simd.js
M JSTests/wasm/v8/exceptions-utils.js
A JSTests/wasm/v8/liftoff-simd-params.js
A JSTests/wasm/v8/multi-value-simd.js
A JSTests/wasm/v8/simd-call.js
A JSTests/wasm/v8/simd-errors.js
A JSTests/wasm/v8/simd-globals.js
A JSTests/wasm/v8/simd-i64x2-mul.js
M JSTests/wasm/v8/wasm-module-builder.js
M Source/JavaScriptCore/assembler/ARM64Assembler.h
M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h
M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h
M Source/JavaScriptCore/b3/air/AirInstInlines.h
M Source/JavaScriptCore/b3/air/AirLowerMacros.cpp
M Source/JavaScriptCore/b3/air/AirOpcode.opcodes
M Source/JavaScriptCore/b3/air/AirValidate.cpp
M Source/JavaScriptCore/jit/RegisterAtOffsetList.cpp
M Source/JavaScriptCore/jit/RegisterAtOffsetList.h
M Source/JavaScriptCore/jit/SIMDInfo.h
M Source/JavaScriptCore/llint/WebAssembly32_64.asm
M Source/JavaScriptCore/llint/WebAssembly64.asm
M Source/JavaScriptCore/runtime/OptionsList.h
M Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmCallingConvention.h
M Source/JavaScriptCore/wasm/WasmExceptionType.h
M Source/JavaScriptCore/wasm/Was

[webkit-changes] [WebKit/WebKit] a31fca: Add sandbox telemetry for version 2

2022-10-28 Thread Per Arne Vollan
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a31fca13ab11fdc8dbd646bf068cab390e939eb0
  
https://github.com/WebKit/WebKit/commit/a31fca13ab11fdc8dbd646bf068cab390e939eb0
  Author: Per Arne Vollan 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
M Source/WebKit/Shared/Sandbox/macOS/common.sb

  Log Message:
  ---
  Add sandbox telemetry for version 2
https://bugs.webkit.org/show_bug.cgi?id=247195
rdar://101678178

Reviewed by Chris Dumez.

Add sandbox telemetry for version 2 for access that was implicitly allowed in 
version 1. These telemetry rules
will be removed once we have gathered this information.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Source/WebKit/Shared/Sandbox/macOS/common.sb:

Canonical link: https://commits.webkit.org/256107@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] beb28b: Cherry-pick c5651d8d797d. rdar://problem/101661127

2022-10-28 Thread Per Arne Vollan
  Branch: refs/heads/safari-7615.1.11-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: beb28bd35105d50ce3110b68197247e4473fd6b3
  
https://github.com/WebKit/WebKit/commit/beb28bd35105d50ce3110b68197247e4473fd6b3
  Author: Per Arne Vollan 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Cherry-pick c5651d8d797d. rdar://problem/101661127

[macOS] Unable to load image decoder plugin
https://bugs.webkit.org/show_bug.cgi?id=247163
rdar://101661127

Reviewed by Simon Fraser.

The WebContent process's sandbox is blocking load of image decoder plugins.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/256088@main

Canonical link: https://commits.webkit.org/255891.4@safari-7615.1.11-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 951f22: [LFC][IFC] Bail out of simplified vertical alignme...

2022-10-28 Thread Alan Baradlay
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 951f228780efe33dabf6bff121c48a85cf6ff206
  
https://github.com/WebKit/WebKit/commit/951f228780efe33dabf6bff121c48a85cf6ff206
  Author: Alan Baradlay 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
M 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp

  Log Message:
  ---
  [LFC][IFC] Bail out of simplified vertical alignment when line-box-contain is 
present
https://bugs.webkit.org/show_bug.cgi?id=247194

Reviewed by Antti Koivisto.

line-box-contain may exclude certain types of inline level boxes from 
alignment. Simplified codepath does not deal with this kind of complexity.

* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::hasLineBoxContain const):
* 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::computeLogicalHeightAndAlign const):

Canonical link: https://commits.webkit.org/256106@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3fca3f: [webkitbugspy] Support radar users with no username

2022-10-28 Thread Jonathan Bedard
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fca3f4cf3f6abe28945ee3634a4ba8e61e491d9
  
https://github.com/WebKit/WebKit/commit/3fca3f4cf3f6abe28945ee3634a4ba8e61e491d9
  Author: Jonathan Bedard 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Tools/Scripts/libraries/webkitbugspy/setup.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py

  Log Message:
  ---
  [webkitbugspy] Support radar users with no username
https://bugs.webkit.org/show_bug.cgi?id=247145
rdar://101645349

Reviewed by Aakash Jain.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump verison.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py:
(Tracker.user):
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py:
(TestRadar.test_users):

Canonical link: https://commits.webkit.org/256105@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 0abef5: Expose KVO SPI WKWebView._wasPrivateRelayed

2022-10-28 Thread Matthew Finkel
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0abef5e06954ee7415379e8a49086516fd2b27c6
  
https://github.com/WebKit/WebKit/commit/0abef5e06954ee7415379e8a49086516fd2b27c6
  Author: Matthew Finkel 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/dom/SecurityContext.h
M Source/WebCore/history/CachedFrame.cpp
M Source/WebCore/history/CachedFrame.h
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/EmptyFrameLoaderClient.h
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/loader/FrameLoaderClient.h
M Source/WebCore/loader/ResourceLoader.cpp
M Source/WebCore/platform/network/ResourceResponseBase.cpp
M Source/WebCore/platform/network/ResourceResponseBase.h
M Source/WebKit/NetworkProcess/NetworkDataTask.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/Cocoa/NavigationState.h
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Source/WebKit/UIProcess/PageLoadState.cpp
M Source/WebKit/UIProcess/PageLoadState.h
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
M Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h

  Log Message:
  ---
  Expose KVO SPI WKWebView._wasPrivateRelayed
https://bugs.webkit.org/show_bug.cgi?id=247109
rdar://101605181

Reviewed by Alex Christensen.

* Source/WebCore/dom/SecurityContext.h:
(WebCore::SecurityContext::wasPrivateRelayed const):
(WebCore::SecurityContext::setWasPrivateRelayed):
* Source/WebCore/history/CachedFrame.cpp:
(WebCore::CachedFrame::hasInsecureContent const):
(WebCore::CachedFrame::wasPrivateRelayed const):
* Source/WebCore/history/CachedFrame.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::dispatchDidCommitLoad):
* Source/WebCore/loader/EmptyFrameLoaderClient.h:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::dispatchDidCommitLoad):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/FrameLoaderClient.h:
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse):
* Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::ResourceResponseBase):
* Source/WebCore/platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::wasPrivateRelayed const):
(WebCore::ResourceResponseBase::setWasPrivateRelayed):
(WebCore::ResourceResponseBase::encode const):
(WebCore::ResourceResponseBase::decode):
* Source/WebKit/NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::didReceiveResponse):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _wasPrivateRelayed]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::wasPrivateRelayed const):
(WebKit::PageLoadState::didCommitLoad):
* Source/WebKit/UIProcess/PageLoadState.h:
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didCommitLoadForFrame):
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::WebPageProxy::didCommitLoadForFrame):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidCommitLoad):
* Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidCommitLoad):
* Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h:

Canonical link: https://commits.webkit.org/256104@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] c370b6: Add myself (Vitaly Dyachkov) to contributors

2022-10-28 Thread Vitaly Dyachkov
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c370b6853d8f3735d232f6cdfc75047795046d37
  
https://github.com/WebKit/WebKit/commit/c370b6853d8f3735d232f6cdfc75047795046d37
  Author: Vitaly Dyachkov 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add myself (Vitaly Dyachkov) to contributors
https://bugs.webkit.org/show_bug.cgi?id=247200

Reviewed by Jonathan Bedard.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/256103@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 01148b: [WPE] Gardening fast/filter-image/filter-image-svg...

2022-10-28 Thread Vitaly Dyachkov
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 01148bc0a083b9784b16b4a65ee036fa0c3751d5
  
https://github.com/WebKit/WebKit/commit/01148bc0a083b9784b16b4a65ee036fa0c3751d5
  Author: Vitaly Dyachkov 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  ---
  [WPE] Gardening fast/filter-image/filter-image-svg.html

Unreviewed test gardening.

The test has been passing for a long time:
https://results.webkit.org/?suite=layout-tests&test=fast%2Ffilter-image%2Ffilter-image-svg.html&platform=WPE

* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/256102@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] d41a38: Move decidePolicyForNavigationAction to WebFrameProxy

2022-10-28 Thread EWS
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d41a381189a78568c6f085aec05ff443fdc93f4b
  
https://github.com/WebKit/WebKit/commit/d41a381189a78568c6f085aec05ff443fdc93f4b
  Author: Alex Christensen 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.h
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebFrameProxy.messages.in
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

  Log Message:
  ---
  Move decidePolicyForNavigationAction to WebFrameProxy
https://bugs.webkit.org/show_bug.cgi?id=247157
rdar://101658524

Reviewed by Chris Dumez.

* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didReceiveMessage):
(WebKit::ProvisionalPageProxy::didReceiveSyncMessage):
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync): Deleted.
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionSync): Deleted.
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebFrameProxy::decidePolicyForNavigationActionSync):
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebFrameProxy.messages.in:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync): Deleted.
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/256101@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 99f404: [GTK] Add GTK 4 migration guide

2022-10-28 Thread Michael Catanzaro
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99f4041e6cb2250026638cf31e650e1170af71b4
  
https://github.com/WebKit/WebKit/commit/99f4041e6cb2250026638cf31e650e1170af71b4
  Author: Michael Catanzaro 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
A Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md
M Source/WebKit/gtk/webkitgtk.toml.in

  Log Message:
  ---
  [GTK] Add GTK 4 migration guide
https://bugs.webkit.org/show_bug.cgi?id=247133

Reviewed by Carlos Garcia Campos.

* Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md: Added.
* Source/WebKit/gtk/webkitgtk.toml.in:

Canonical link: https://commits.webkit.org/256100@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] a665aa: Regression(iOS 16.1) Use of Shared Workers cause W...

2022-10-28 Thread Chris Dumez
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a665aab7969fcec713fd40d8f97368e86f6b37b2
  
https://github.com/WebKit/WebKit/commit/a665aab7969fcec713fd40d8f97368e86f6b37b2
  Author: Chris Dumez 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M LayoutTests/http/tests/navigation/resources/shared-worker-script.js
A 
LayoutTests/http/tests/workers/shared/shared-worker-with-service-workers-disabled-expected.txt
A 
LayoutTests/http/tests/workers/shared/shared-worker-with-service-workers-disabled.html
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Source/WebCore/workers/WorkerScriptLoader.cpp

  Log Message:
  ---
  Regression(iOS 16.1) Use of Shared Workers cause Web Content process crash in 
non-default-browser WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=247147
rdar://101562445

Reviewed by Geoffrey Garen.

253592@main made the initialization of WorkerScriptLoader::m_clientIdentifier
conditional on service workers being enabled. However, this wasn't correct
since shared workers rely on this data member too.

This clientIdentifier gets sent over IPC at some point and fails decoding
when not initialized, leading to the WebProcess getting killed.

* LayoutTests/http/tests/navigation/resources/shared-worker-script.js:
(self.onconnect):
* 
LayoutTests/http/tests/navigation/shared-worker-with-service-workers-disabled-expected.txt:
 Added.
* 
LayoutTests/http/tests/navigation/shared-worker-with-service-workers-disabled.html:
 Added.
* Source/WebCore/workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadAsynchronously):

Canonical link: https://commits.webkit.org/256099@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 3e8ac0: Fix default angle cases from at-font-face-descript...

2022-10-28 Thread Tim Nguyen
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e8ac0a21f3047ebd9add1db025f4c13d287df53
  
https://github.com/WebKit/WebKit/commit/3e8ac0a21f3047ebd9add1db025f4c13d287df53
  Author: Tim Nguyen 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors.html

  Log Message:
  ---
  Fix default angle cases from at-font-face-descriptors.html
https://bugs.webkit.org/show_bug.cgi?id=247172
rdar://101666575

Reviewed by Darin Adler.

The default angle is now 14deg, not 20deg, but even then, I do not think we 
should treat the default angle specially in this case, given that it changed. 
We lose information by serializing to the shorter form (did the author intend 
to mean 20deg or the current default angle?). For clarity, always putting the 
angle is better.

See: https://github.com/w3c/csswg-drafts/issues/2295

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors.html:

Canonical link: https://commits.webkit.org/256098@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] dad936: [WPE] Gardening touch events

2022-10-28 Thread Vitaly Dyachkov
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dad93653ebbaad0b8f957411c58646ad6e154913
  
https://github.com/WebKit/WebKit/commit/dad93653ebbaad0b8f957411c58646ad6e154913
  Author: Vitaly Dyachkov 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  ---
  [WPE] Gardening touch events

Unreviewed test gardening.

Touch events are not supported by either GTK or WPE.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/256097@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 7328bf: Unreviewed. [CMake] Fix the build after 256093@main

2022-10-28 Thread Carlos Garcia Campos
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7328bf5df5ae9a4e585123d4c5d67b168c3f167e
  
https://github.com/WebKit/WebKit/commit/7328bf5df5ae9a4e585123d4c5d67b168c3f167e
  Author: Carlos Garcia Campos 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/Headers.cmake

  Log Message:
  ---
  Unreviewed. [CMake] Fix the build after 256093@main

* Source/WebCore/Headers.cmake: Add MediaQuery.h.

Canonical link: https://commits.webkit.org/256096@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 2946bb: Allow calc() with combined percentages and lengths...

2022-10-28 Thread Darin Adler
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2946bb7fba02b40105f29744a1600ec192b59a78
  
https://github.com/WebKit/WebKit/commit/2946bb7fba02b40105f29744a1600ec192b59a78
  Author: Darin Adler 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M LayoutTests/css3/calc/line-height-expected.txt
A 
LayoutTests/fast/css/calc-with-percent-and-number-in-line-height-crash-expected.txt
A 
LayoutTests/fast/css/calc-with-percent-and-number-in-line-height-crash.html
A LayoutTests/fast/css/line-height-1-expected.html
A LayoutTests/fast/css/line-height-1.html
A LayoutTests/fast/css/line-height-2-expected.html
A LayoutTests/fast/css/line-height-2.html
A LayoutTests/fast/css/line-height-basics-expected.txt
A LayoutTests/fast/css/line-height-basics.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-computed-expected.txt
M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  ---
  Allow calc() with combined percentages and lengths for line-height
https://bugs.webkit.org/show_bug.cgi?id=247007
rdar://problem/101546260

Reviewed by Tim Nguyen and Sam Weinig.

* LayoutTests/css3/calc/line-height-expected.txt: Expect PASS.

* 
LayoutTests/fast/css/calc-with-percent-and-number-in-line-height-crash-expected.txt:
 Added.
* LayoutTests/fast/css/calc-with-percent-and-number-in-line-height-crash.html: 
Added.
Adopted this test from Chromium.

* LayoutTests/fast/css/line-height-1-expected.html: Added.
* LayoutTests/fast/css/line-height-1.html: Added.
* LayoutTests/fast/css/line-height-2-expected.html: Added.
* LayoutTests/fast/css/line-height-2.html: Added.
Adopted these tests from Mozilla.

* LayoutTests/fast/css/line-height-basics-expected.txt: Added.
* LayoutTests/fast/css/line-height-basics.html: Added.
Adopted this test from Chromium.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-computed-expected.txt:
Expected many more PASS.

* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertLineHeight): Allow percentage 
combined with length.

Canonical link: https://commits.webkit.org/256095@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] b724d3: Always use percentages for computed values of font...

2022-10-28 Thread Darin Adler
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b724d37d49cae06de4633efc4b468500f40f0ce3
  
https://github.com/WebKit/WebKit/commit/b724d37d49cae06de4633efc4b468500f40f0ce3
  Author: Darin Adler 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M 
LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
M LayoutTests/fast/text/font-stretch-parse-expected.txt
M LayoutTests/fast/text/font-stretch-parse.html
M 
LayoutTests/fast/text/variations/out-of-bounds-selection-properties-expected.txt
M LayoutTests/fast/text/variations/out-of-bounds-selection-properties.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-stretch-interpolation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-stretch-interpolation.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/inheritance-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-stretch-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute.html
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt
M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  ---
  Always use percentages for computed values of font-stretch, never keywords
https://bugs.webkit.org/show_bug.cgi?id=247008
rdar://problem/101546363

Reviewed by Tim Nguyen.

https://drafts.csswg.org/css-fonts/#propdef-font-stretch

Current CSS Fonts Module Level 4 says computed values are always serialized as 
a percentage.
This is a change since CSS Fonts Module Level 3 which said they should be 
computed "as specified".
Web Platform Tests currently has a mix; this updates tests to consistently 
expect the new form.

* LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
Updated to expect "100%" instead of "normal".

* LayoutTests/fast/text/font-stretch-parse-expected.txt: Updated.
* LayoutTests/fast/text/font-stretch-parse.html: Updated to expect percentages.

* 
LayoutTests/fast/text/variations/out-of-bounds-selection-properties-expected.txt:
* LayoutTests/fast/text/variations/out-of-bounds-selection-properties.html:
Updated to expect "100%" instead of "normal".

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-stretch-interpolation-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-stretch-interpolation.html:
Updated to expect percentages instead of keywords.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/inheritance-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-stretch-expected.txt:
Updated for more PASS.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute.html:
Updated to expect percentages instead of keywords.

* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
* 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
Updated for more PASS.

* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontStretch): Removed code path that checks for and uses keywords.

Canonical link: https://commits.webkit.org/256094@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 7bceda: [MQ4] Use the new parser and evaluator in mediaAtt...

2022-10-28 Thread Antti Koivisto
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7bceda6606988a87c3a0cd1e637d80c06cd56a49
  
https://github.com/WebKit/WebKit/commit/7bceda6606988a87c3a0cd1e637d80c06cd56a49
  Author: Antti Koivisto 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/ContainerQueryParser.cpp
M Source/WebCore/css/ContainerQueryParser.h
M Source/WebCore/css/query/GenericMediaQueryParser.cpp
M Source/WebCore/css/query/GenericMediaQueryParser.h
M Source/WebCore/css/query/MediaQueryEvaluator.cpp
M Source/WebCore/css/query/MediaQueryParser.cpp
M Source/WebCore/css/query/MediaQueryParser.h
M Source/WebCore/html/HTMLLinkElement.cpp
M Source/WebCore/html/HTMLMetaElement.cpp
M Source/WebCore/html/HTMLMetaElement.h

  Log Message:
  ---
  [MQ4] Use the new parser and evaluator in mediaAttributeMatches() functions
https://bugs.webkit.org/show_bug.cgi?id=247124
rdar://101631539

Reviewed by Darin Adler.

Start using the new code in some cases.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/ContainerQueryParser.cpp:
(WebCore::ContainerQueryParser::consumeContainerQuery):
* Source/WebCore/css/ContainerQueryParser.h:
(WebCore::ContainerQueryParser::ContainerQueryParser):
* Source/WebCore/css/query/GenericMediaQueryParser.h:
(WebCore::MQ::GenericMediaQueryParserBase::GenericMediaQueryParserBase):
(WebCore::MQ::GenericMediaQueryParser::GenericMediaQueryParser):
* Source/WebCore/css/query/MediaQueryEvaluator.cpp:
(WebCore::MQ::MediaQueryEvaluator::evaluate const):
* Source/WebCore/css/query/MediaQueryParser.cpp:
(WebCore::MQ::MediaQueryParser::MediaQueryParser):
(WebCore::MQ::MediaQueryParser::parse):
* Source/WebCore/css/query/MediaQueryParser.h:
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::mediaAttributeMatches const):
* Source/WebCore/html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::mediaAttributeMatches):
(WebCore::HTMLMetaElement::parseAttribute):
* Source/WebCore/html/HTMLMetaElement.h:

Canonical link: https://commits.webkit.org/256093@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 2dc61a: [WPE] Support the stable xdg_shell protocol in Win...

2022-10-28 Thread Žan Doberšek
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2dc61a55832a0a6e75c963cd3805ab645c5dad7c
  
https://github.com/WebKit/WebKit/commit/2dc61a55832a0a6e75c963cd3805ab645c5dad7c
  Author: Žan Doberšek 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Tools/wpe/backends/PlatformWPE.cmake
M Tools/wpe/backends/fdo/WindowViewBackend.cpp
M Tools/wpe/backends/fdo/WindowViewBackend.h

  Log Message:
  ---
  [WPE] Support the stable xdg_shell protocol in WindowViewBackend
https://bugs.webkit.org/show_bug.cgi?id=247176

Reviewed by Carlos Garcia Campos.

Have WPE's WindowViewBackend support the stable xdg_shell protocol, implementing
it alongside the support for the unstable variant of that protocol. The stable
variant is preferred, if available.

The relevant protocol files are generated and included in the build. The shell
objects and listeners are reorganized into two separate structs. The differences
between the two variants are not big, main problem is just the different set
of types and functions being used.

* Tools/wpe/backends/PlatformWPE.cmake:
* Tools/wpe/backends/fdo/WindowViewBackend.cpp:
(WPEToolingBackends::WindowViewBackend::onDOMFullscreenRequest):
(WPEToolingBackends::WindowViewBackend::WindowViewBackend):
(WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
* Tools/wpe/backends/fdo/WindowViewBackend.h:

Canonical link: https://commits.webkit.org/256092@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] b818b2: "A MediaStreamTrack ended due to a capture failure...

2022-10-28 Thread youennf
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b818b253da1d92e9e5f802dea4a735b8adeb1994
  
https://github.com/WebKit/WebKit/commit/b818b253da1d92e9e5f802dea4a735b8adeb1994
  Author: Youenn Fablet 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M LayoutTests/fast/mediastream/mediastreamtrack-configurationchange.html
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h
M Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h
M Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
M Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp

  Log Message:
  ---
  "A MediaStreamTrack ended due to a capture failure" when selecting bluetooth 
headphones as audio input device
https://bugs.webkit.org/show_bug.cgi?id=247119
rdar://problem/101628857

Reviewed by Eric Carlson.

Replace the boolean to update the sample buffer by a minimum buffer sample 
frames, which is set when render fails.
This minimum buffer sample frames is used to compute a minimum buffer size when 
setting up the audio unit.

Update Mock implementation to cover that case.
We do this by triggering this code path when 
triggerMockMicrophoneConfigurationChange is called.
We also update the capture verification timer so that timer for mock unit is 
reduced to 1 second.

Update LayoutTests/fast/mediastream/mediastreamtrack-configurationchange.html 
to cover that case.

* LayoutTests/fast/mediastream/mediastreamtrack-configurationchange.html:
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):
(WebCore::CoreAudioSharedUnit::processMicrophoneSamples):
(WebCore::CoreAudioSharedUnit::startInternal):
(WebCore::CoreAudioSharedUnit::isProducingMicrophoneSamplesChanged):
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h:
* Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h:
* Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedUnit::singleton):
(WebCore::MockAudioSharedUnit::increaseBufferSize):
(WebCore::MockAudioSharedInternalUnit::emitSampleBuffers):
(WebCore::MockAudioSharedInternalUnit::render):
* Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::triggerMockMicrophoneConfigurationChange):

Canonical link: https://commits.webkit.org/256091@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] 555067: Simplify code in CSSPropertyAnimation.cpp

2022-10-28 Thread Antoine Quint
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 555067570d22e34d232f6d9967deb54a13c4d8b5
  
https://github.com/WebKit/WebKit/commit/555067570d22e34d232f6d9967deb54a13c4d8b5
  Author: Antoine Quint 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/animation/CSSPropertyAnimation.cpp

  Log Message:
  ---
  Simplify code in CSSPropertyAnimation.cpp
https://bugs.webkit.org/show_bug.cgi?id=247117

Reviewed by Dean Jackson.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::LengthPointPropertyWrapper::LengthPointPropertyWrapper):
(WebCore::FloatPropertyWrapper::FloatPropertyWrapper):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Canonical link: https://commits.webkit.org/256090@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [WebKit/WebKit] c19a62: Fix use-after-free memory error

2022-10-28 Thread Matthieu Dubet
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c19a6292aab1bafc47e52b1bfb4341a06472ef75
  
https://github.com/WebKit/WebKit/commit/c19a6292aab1bafc47e52b1bfb4341a06472ef75
  Author: Matthieu Dubet 
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
M Source/WebCore/platform/text/TextFlags.cpp

  Log Message:
  ---
  Fix use-after-free memory error
rdar://101637166

Reviewed by Brent Fulgham.

The previous code was creating a temporary vector
which was passed to Span. Because Span doesn't own
memory, the vector was (potentially) released at
the end of the lambda function.

With this patch, a reference to the vector stored in
the HashMap is given to Span<> (we don't use a temporary anymore),
which is live for at least the whole duration of the
computeFontFeatureSettingsFromVariants function.

* Source/WebCore/platform/text/TextFlags.cpp:
(WebCore::computeFeatureSettingsFromVariants):

Canonical link: https://commits.webkit.org/256089@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes