[webkit-changes] [WebKit/WebKit] 9d09db: [LFC][IFC] Add support for "line-box-contain: inli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d09db431467a12f691533fd8b8f965d36414d46 https://github.com/WebKit/WebKit/commit/9d09db431467a12f691533fd8b8f965d36414d46 Author: Alan Baradlay Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M LayoutTests/fast/block/lineboxcontain/inline-box.html M LayoutTests/platform/ios/fast/block/lineboxcontain/inline-box-expected.txt M LayoutTests/platform/ios/fast/block/lineboxcontain/inline-box-replaced-expected.txt M LayoutTests/platform/ios/fast/block/lineboxcontain/inline-box-vertical-expected.txt M LayoutTests/platform/mac/fast/block/lineboxcontain/inline-box-expected.txt M LayoutTests/platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.txt M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h Log Message: --- [LFC][IFC] Add support for "line-box-contain: inline-box" https://bugs.webkit.org/show_bug.cgi?id=247108 Reviewed by Antti Koivisto. "line-box-contain: inline-box" makes the inline boxes contribute their vertical margin/border/padding to the line box height (normally they produce vertical overflow -except vertical margin which is completely ignored). * Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h: (WebCore::Layout::InlineLevelBox::lineBoxContain const): * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::adjustInlineBoxHeightsForLineBoxContainIfApplicable): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::printReason): (WebCore::LayoutIntegration::canUseForStyle): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.h: * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::updateInlineBoxDimensions): * Source/WebCore/layout/layouttree/LayoutBoxGeometry.h: (WebCore::Layout::BoxGeometry::marginBorderAndPaddingBefore const): (WebCore::Layout::BoxGeometry::marginBorderAndPaddingAfter const): LayoutTests/fast/block/lineboxcontain/inline-box.html: the inline-block box is incorrectly treated as replaced. Canonical link: https://commits.webkit.org/256147@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 65f0b1: [WebDriver] Support "Get Computed Label" command
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 65f0b17d5ddf4be81078c810fd814b50a65d7f31 https://github.com/WebKit/WebKit/commit/65f0b17d5ddf4be81078c810fd814b50a65d7f31 Author: Lauro Moura Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M Source/WebDriver/Session.cpp M Source/WebDriver/Session.h M Source/WebDriver/WebDriverService.cpp M Source/WebDriver/WebDriverService.h M WebDriverTests/TestExpectations.json Log Message: --- [WebDriver] Support "Get Computed Label" command https://bugs.webkit.org/show_bug.cgi?id=246814 Reviewed by Carlos Garcia Campos. Tests still marked as xfailure as they need a fix yet to be imported into local copy. Manually applying the fix shows that they should be passing, though. * Source/WebDriver/Session.cpp: (WebDriver::Session::getComputedRole): Refactor to use getComputedRole command. (WebDriver::Session::getComputedLabel): Added * Source/WebDriver/Session.h: * Source/WebDriver/WebDriverService.cpp: (WebDriver::WebDriverService::getComputedLabel): Added * Source/WebDriver/WebDriverService.h: * WebDriverTests/TestExpectations.json: Update referenced bug Canonical link: https://commits.webkit.org/256146@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 04aa3a: Resync web-platform-tests/screen-orientation from ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 04aa3aef7ee6095372062da56f660e966f1bf465 https://github.com/WebKit/WebKit/commit/04aa3aef7ee6095372062da56f660e966f1bf465 Author: Marcos Caceres Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise-expected.txt M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise.html A LayoutTests/imported/w3c/web-platform-tests/screen-orientation/fullscreen-interactions-expected.txt A LayoutTests/imported/w3c/web-platform-tests/screen-orientation/fullscreen-interactions.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-sandboxed-iframe-expected.txt M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-sandboxed-iframe.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-check-expected.txt M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-check.html A LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents-expected.txt A LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/non-fully-active.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-expected.txt M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading.html M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/resources/orientation-utils.js M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/resources/sandboxed-iframe-locking.html A LayoutTests/imported/w3c/web-platform-tests/screen-orientation/unlock-expected.txt A LayoutTests/imported/w3c/web-platform-tests/screen-orientation/unlock.html M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/fullscreen-interactions-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/lock-sandboxed-iframe-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-check-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/nested-documents-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/unlock-expected.txt Log Message: --- Resync web-platform-tests/screen-orientation from upstream https://bugs.webkit.org/show_bug.cgi?id=247111 rdar://101619487 Reviewed by Youenn Fablet. * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock.html: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise.html: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/fullscreen-interactions-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/fullscreen-interactions.html: Added. * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic.html: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-sandboxed-iframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-sandboxed-iframe.html: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-
[webkit-changes] [WebKit/WebKit] 81ba41: [IFC][Integration] Disable IFC for RenderVTTCue
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81ba4136c6199f300eb290a41b918c3127787f9c https://github.com/WebKit/WebKit/commit/81ba4136c6199f300eb290a41b918c3127787f9c Author: Alan Baradlay Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp Log Message: --- [IFC][Integration] Disable IFC for RenderVTTCue https://bugs.webkit.org/show_bug.cgi?id=247238 Reviewed by Antti Koivisto. (missing from 256139@main) * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForLineLayoutWithReason): Canonical link: https://commits.webkit.org/256144@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4041ec: [GTK][WPE] Use a single global JavaScript context ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4041ec7696c53b8f7e64d3046d4f7ae3d180cf35 https://github.com/WebKit/WebKit/commit/4041ec7696c53b8f7e64d3046d4f7ae3d180cf35 Author: Carlos Garcia Campos Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M Source/WebKit/Shared/API/APISerializedScriptValue.h M Source/WebKit/UIProcess/API/glib/APISerializedScriptValueGLib.cpp M Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp M Source/WebKit/UIProcess/API/glib/WebKitJavascriptResultPrivate.h M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp Log Message: --- [GTK][WPE] Use a single global JavaScript context to serialize/deserialize script values https://bugs.webkit.org/show_bug.cgi?id=247180 Reviewed by Michael Catanzaro. Remove the global context used by WebKitJavascriptResult and use API::SerializedScriptValue instead. * Source/WebKit/Shared/API/APISerializedScriptValue.h: * Source/WebKit/UIProcess/API/glib/APISerializedScriptValueGLib.cpp: (API::SharedJSContext::SharedJSContext): (API::SerializedScriptValue::sharedJSCContext): (API::SerializedScriptValue::deserialize): (API::coreValueFromGVariant): * Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp: (_WebKitJavascriptResult::_WebKitJavascriptResult): * Source/WebKit/UIProcess/API/glib/WebKitJavascriptResultPrivate.h: (SharedJavascriptContext::singleton): Deleted. (SharedJavascriptContext::SharedJavascriptContext): Deleted. (SharedJavascriptContext::getOrCreateContext): Deleted. (SharedJavascriptContext::releaseContext): Deleted. * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkit_web_view_get_javascript_global_context): Canonical link: https://commits.webkit.org/256143@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3c163: [GTK][WPE] Improve detection of the web view main ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3c1630617d29865df618e6fc017d958c1477b1d https://github.com/WebKit/WebKit/commit/a3c1630617d29865df618e6fc017d958c1477b1d Author: Carlos Garcia Campos Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M Source/WebCore/loader/DocumentLoader.cpp M Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebResourcePrivate.h M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h Log Message: --- [GTK][WPE] Improve detection of the web view main resource https://bugs.webkit.org/show_bug.cgi?id=247177 Reviewed by Michael Catanzaro. We currently assume that the first resource loaded for a web view in the main frame is the main resource, but we can check the request requester instead. * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::startLoadingMainResource): Set the requester before copying the request. * Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp: (webkitWebResourceCreate): (webkitWebResourceIsMainResource): * Source/WebKit/UIProcess/API/glib/WebKitWebResourcePrivate.h: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewResourceLoadStarted): * Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h: Canonical link: https://commits.webkit.org/256142@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 693343: [Nicosia] Remove Nicosia::CompositionLayer::update...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 693343741daad856141b277fac82603600e66c40 https://github.com/WebKit/WebKit/commit/693343741daad856141b277fac82603600e66c40 Author: Carlos Garcia Campos Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNodeNicosia.cpp M Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp M Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNodeNicosia.cpp M Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp M Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.cpp M Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNodeNicosia.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.h M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp Log Message: --- [Nicosia] Remove Nicosia::CompositionLayer::updateState https://bugs.webkit.org/show_bug.cgi?id=247186 Reviewed by Miguel Gomez. It's exactly the same as Nicosia::CompositionLayer::accessPending() which is more explicit and less confusing. * Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNodeNicosia.cpp: (WebCore::ScrollingTreeFixedNodeNicosia::applyLayerPositions): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp: (WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionScrollingLayers): (WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionRelatedLayers): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNodeNicosia.cpp: (WebCore::ScrollingTreeOverflowScrollProxyNodeNicosia::applyLayerPositions): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp: (WebCore::ScrollingTreeOverflowScrollingNodeNicosia::repositionScrollingLayers): * Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.cpp: (WebCore::ScrollingTreePositionedNodeNicosia::applyLayerPositions): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNodeNicosia.cpp: (WebCore::ScrollingTreeStickyNodeNicosia::applyLayerPositions): * Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.h: (Nicosia::CompositionLayer::updateState): Deleted. * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly): Canonical link: https://commits.webkit.org/256141@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 618d20: [IFC][Integration] Disable IFC for nested deprecat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 618d203596c03dcba4d8e7860064052d88334ea3 https://github.com/WebKit/WebKit/commit/618d203596c03dcba4d8e7860064052d88334ea3 Author: Alan Baradlay Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: A LayoutTests/fast/block/line-clamp-collapse-nested-blocks-expected.html A LayoutTests/fast/block/line-clamp-collapse-nested-blocks.html M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderElement.h Log Message: --- [IFC][Integration] Disable IFC for nested deprecated flex content with line-clamp https://bugs.webkit.org/show_bug.cgi?id=247234 Reviewed by Antti Koivisto. line-clamp works nested block containers. It's not sufficient to check the parent's parent only. * LayoutTests/fast/block/line-clamp-collapse-nested-blocks-expected.html: Added. * LayoutTests/fast/block/line-clamp-collapse-nested-blocks.html: Added. * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForStyle): * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderElement.h: Canonical link: https://commits.webkit.org/256140@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec9adc: [IFC][Integration] Disable IFC for RenderVTTCue
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec9adcfcd3db270348a5b7a95cdf500bdccbf088 https://github.com/WebKit/WebKit/commit/ec9adcfcd3db270348a5b7a95cdf500bdccbf088 Author: Alan Baradlay Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h Log Message: --- [IFC][Integration] Disable IFC for RenderVTTCue https://bugs.webkit.org/show_bug.cgi?id=247238 Reviewed by Antti Koivisto. RenderVTTCue consults with legacy line layout structures directly (it's been disabled through line-box-contain. see mediaControls.css) * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::printReason): (WebCore::LayoutIntegration::canUseForLineLayoutWithReason): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.h: Canonical link: https://commits.webkit.org/256139@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/wpewebkit-2.38.1 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d1c8f9: Unreviewed. Update OptionsWPE.cmake and NEWS for t...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: d1c8f94cb02b91a4cb0945b3e310349cc8cc609b https://github.com/WebKit/WebKit/commit/d1c8f94cb02b91a4cb0945b3e310349cc8cc609b Author: Carlos Garcia Campos Date: 2022-10-30 (Sun, 30 Oct 2022) Changed paths: M Source/WebKit/wpe/NEWS M Source/cmake/OptionsWPE.cmake Log Message: --- Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.38.1 release * Source/WebKit/wpe/NEWS: Add release notes for 2.38.1. * Source/cmake/OptionsWPE.cmake: Bump version numbers. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
