[webkit-changes] [WebKit/WebKit] e2ea39: Unreviewed, reverting r256262@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2ea39e15c6e754c443f4937083837583a122c3f https://github.com/WebKit/WebKit/commit/e2ea39e15c6e754c443f4937083837583a122c3f Author: Commit Queue Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Tools/Scripts/libraries/webkitcorepy/setup.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py R Tools/Scripts/libraries/webkitcorepy/webkitcorepy/multiprocessing_utils.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py R Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/multiprocessing_utils_unittest.py Log Message: --- Unreviewed, reverting r256262@main. https://bugs.webkit.org/show_bug.cgi?id=247409 Broke layout-tests for GTK/WPE Reverted changeset: "[run-webkit-tests] Extra thread spawned for each worker" https://bugs.webkit.org/show_bug.cgi?id=247324 https://commits.webkit.org/256262@main Canonical link: https://commits.webkit.org/256269@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d2fef: Fix internal build after rdar://100429656
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d2fef3d21c8962f026ab38f32522324f99954db https://github.com/WebKit/WebKit/commit/7d2fef3d21c8962f026ab38f32522324f99954db Author: Alex Christensen Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h Log Message: --- Fix internal build after rdar://100429656 https://bugs.webkit.org/show_bug.cgi?id=247408 rdar://101896139 Unreviewed. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _loadServiceWorker:completionHandler:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h: Canonical link: https://commits.webkit.org/256268@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 16904a: Punycode all IPA extensions code points in URLs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 16904a9a85c8bec95b033c9db81eb06888d8c97c https://github.com/WebKit/WebKit/commit/16904a9a85c8bec95b033c9db81eb06888d8c97c Author: Alex Christensen Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WTF/wtf/URLHelpers.cpp M Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm Log Message: --- Punycode all IPA extensions code points in URLs https://bugs.webkit.org/show_bug.cgi?id=247289 rdar://101429376 Reviewed by Tim Horton. * Source/WTF/wtf/URLHelpers.cpp: (WTF::URLHelpers::isLookalikeCharacter): * Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/256267@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cb5925: Scrolling by pressing space bar has regressed in t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cb5925ef6a3e94f82e753b50298c2a25f7160da0 https://github.com/WebKit/WebKit/commit/cb5925ef6a3e94f82e753b50298c2a25f7160da0 Author: Richard Robinson Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html M LayoutTests/fast/repaint/fixed-move-after-keyboard-scroll.html M LayoutTests/fast/scrolling/keyboard-scrolling-distance-downArrow.html M LayoutTests/fast/scrolling/mac/keyboard-scrolling-overflow-scroll.html M LayoutTests/fast/scrolling/mac/smooth-scroll-recursive-frame-to-overflow.html M LayoutTests/fast/scrolling/mac/smooth-scroll-recursive-overflow-to-overflow.html M LayoutTests/fast/scrolling/unfocusing-page-while-keyboard-scrolling.html M LayoutTests/platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/page/FrameView.cpp M Source/WebCore/page/FrameView.h M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h M Source/WebCore/page/scrolling/ScrollingStateNode.h M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h M Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm M Source/WebCore/platform/KeyboardScrollingAnimator.cpp M Source/WebCore/platform/KeyboardScrollingAnimator.h M Source/WebCore/platform/ScrollAnimation.cpp M Source/WebCore/platform/ScrollAnimation.h A Source/WebCore/platform/ScrollAnimationKeyboard.cpp A Source/WebCore/platform/ScrollAnimationKeyboard.h M Source/WebCore/platform/ScrollAnimator.cpp M Source/WebCore/platform/ScrollableArea.cpp M Source/WebCore/platform/ScrollableArea.h M Source/WebCore/platform/ScrollingEffectsController.cpp M Source/WebCore/platform/ScrollingEffectsController.h M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.h M Tools/TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp Log Message: --- Scrolling by pressing space bar has regressed in trunk, is choppy (not 120Hz) https://bugs.webkit.org/show_bug.cgi?id=246878 rdar://101052130 Reviewed by Simon Fraser. Moves keyboard smooth scrolling onto the scrolling thread instead of the main thread. A new `ScrollAnimation` is created to facilitate this, `ScrollAnimationKeyboard`. Most of the changes are to allow the state to propogate through the various classes and the scrolling tree. Since keyboard scrolling is now on a different thread, some tests had to be modified to enable the `AsyncOverflowScrollingEnabled` and `AsyncFrameScrollingEnabled` settings. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/page/FrameView.cpp: (WebCore::FrameView::requestStartKeyboardAnimation): (WebCore::FrameView::requestFinishKeyboardAnimation): * Source/WebCore/page/FrameView.h: * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::requestStartKeyboardAnimation): (WebCore::AsyncScrollingCoordinator::requestFinishKeyboardAnimation): * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h: * Source/WebCore/page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::requestStartKeyboardAnimation): (WebCore::ScrollingCoordinator::requestFinishKeyboardAnimation): * Source/WebCore/page/scrolling/ScrollingStateNode.h: * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::setKeyboardScrollData): (WebCore::ScrollingStateScrollingNode::setKeyboardScrollEndData): * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h: (WebCore::ScrollingStateScrollingNode::keyboardScrollData const): (WebCore::ScrollingStateScrollingNode::keyboardScrollEndData const): * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren): (WebCore::ScrollingTreeScrollingNode::handleKeyboardScrollRequest): (WebCore::ScrollingTreeScrollingNode::handleKeyboardScrollEndRequest): * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h:
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.12.1 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 255818: Cherry-pick 81941f622bb4. rdar://problem/101888960
Branch: refs/heads/safari-7615.1.12-branch Home: https://github.com/WebKit/WebKit Commit: 255818f1c63be5edfb8b4e4a22f1f2c35d7ceb05 https://github.com/WebKit/WebKit/commit/255818f1c63be5edfb8b4e4a22f1f2c35d7ceb05 Author: Per Arne Vollan Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/Shared/Sandbox/macOS/common.sb Log Message: --- Cherry-pick 81941f622bb4. rdar://problem/101888960 Initially allow syscall mach in sandbox v2 https://bugs.webkit.org/show_bug.cgi?id=247402 rdar://101888960 Reviewed by Tim Nguyen. Initially allow syscall mach in sandbox v2, since it was allowed in v1. Individual sandboxes will deny mach syscalls. * Source/WebKit/Shared/Sandbox/macOS/common.sb: Canonical link: https://commits.webkit.org/256265@main Canonical link: https://commits.webkit.org/256138.13@safari-7615.1.12-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf37b7: Versioning.
Branch: refs/heads/safari-7615.1.12-branch Home: https://github.com/WebKit/WebKit Commit: bf37b793b7ff11fe519c1b68901020b5b406 https://github.com/WebKit/WebKit/commit/bf37b793b7ff11fe519c1b68901020b5b406 Author: Russell Epstein Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.12.1 Canonical link: https://commits.webkit.org/256138.12@safari-7615.1.12-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 81941f: Initially allow syscall mach in sandbox v2
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81941f622bb46b75abd225732b996470d334f7c4 https://github.com/WebKit/WebKit/commit/81941f622bb46b75abd225732b996470d334f7c4 Author: Per Arne Vollan Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/Shared/Sandbox/macOS/common.sb Log Message: --- Initially allow syscall mach in sandbox v2 https://bugs.webkit.org/show_bug.cgi?id=247402 rdar://101888960 Reviewed by Tim Nguyen. Initially allow syscall mach in sandbox v2, since it was allowed in v1. Individual sandboxes will deny mach syscalls. * Source/WebKit/Shared/Sandbox/macOS/common.sb: Canonical link: https://commits.webkit.org/256265@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.11.6 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d2a30: Versioning.
Branch: refs/heads/safari-7615.1.11-branch Home: https://github.com/WebKit/WebKit Commit: 1d2a30867b264f695afc39f857f6a05647b1cdaa https://github.com/WebKit/WebKit/commit/1d2a30867b264f695afc39f857f6a05647b1cdaa Author: Harrison Weinerman Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.11.6 Canonical link: https://commits.webkit.org/255891.11@safari-7615.1.11-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c770d8: JetStream2 driver should be able to specify indivi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c770d8fffc0827be18ed9a216fec2ba1de920aa0 https://github.com/WebKit/WebKit/commit/c770d8fffc0827be18ed9a216fec2ba1de920aa0 Author: Hysu Xiong Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M PerformanceTests/JetStream2/JetStreamDriver.js M PerformanceTests/JetStream3/JetStreamDriver.js Log Message: --- JetStream2 driver should be able to specify individual subtests/test groups to run https://bugs.webkit.org/show_bug.cgi?id=247301 rdar://101783726 Reviewed by Alexey Shvayka. - Refactor existing `report` argument parsing to use URLSearchParams - Add a new URL parameter, `test`, that runs a given list of tests and/or test groups. Eventually, we'd like to be able to add profiling/ARTrace support to JetStream2, and being able to measure individual subtests would be useful as measuring the whole test may be too long and costly. * PerformanceTests/JetStream2/JetStreamDriver.js: (Driver.prototype.async initialize): (Driver.prototype.async reportScoreToRunBenchmarkRunner): (prototype.else): * PerformanceTests/JetStream3/JetStreamDriver.js: (Driver.prototype.async initialize): (Driver.prototype.async reportScoreToRunBenchmarkRunner): (prototype.else): Canonical link: https://commits.webkit.org/256264@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e5ee29: Cherry pick ebefbab, rdar://101872145
Branch: refs/heads/safari-7615.1.11-branch Home: https://github.com/WebKit/WebKit Commit: e5ee29f54fedbefad76b7ff5bf4555389829c694 https://github.com/WebKit/WebKit/commit/e5ee29f54fedbefad76b7ff5bf4555389829c694 Author: Patrick Angle Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- Cherry pick ebefbab, rdar://101872145 WebDriver: [Cocoa] Regression(255359@main) Exception when deleting remote automation session https://bugs.webkit.org/show_bug.cgi?id=247384 rdar://101872145 When running a WebDriver session on macOS Monterey, we are failing to stop observing listeners on the window, resulting in an exception. This occurs because we no longer strongly hold a reference to the window anywhere when moving from `-[WKWindowVisibilityObserver stopObserving:]` to `-[WKWindowVisibilityObserver _observeWindow:]`, which instead only uses the weak reference to the window for removing the observers. Instead, we should keep the removing of the observers in the scope where we know we still have a window. This is observable on macOS Monterey when attempting to close a remote automation session (WebDriver). * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (-[WKWindowVisibilityObserver startObserving:]): (-[WKWindowVisibilityObserver stopObserving:]): (-[WKWindowVisibilityObserver _observeWindow:]): Deleted. Canonical link: https://commits.webkit.org/255891.10@safari-7615.1.11-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1247f9: Turn ENABLE_LAYER_BASED_SVG_ENGINE ON for PlayStation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1247f947057fe27f3bbf3b9ca5dbe3a1b2f68f94 https://github.com/WebKit/WebKit/commit/1247f947057fe27f3bbf3b9ca5dbe3a1b2f68f94 Author: Don Olmstead Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- Turn ENABLE_LAYER_BASED_SVG_ENGINE ON for PlayStation https://bugs.webkit.org/show_bug.cgi?id=247386 Reviewed by Fujii Hironori. Set `ENABLE_LAYER_BASED_SVG_ENGINE` to `ENABLE_EXPERIMENTAL_FEATURES`. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/256263@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db09bf: [run-webkit-tests] Extra thread spawned for each w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db09bfbcf7d0202ce90ff92340f51f4309501770 https://github.com/WebKit/WebKit/commit/db09bfbcf7d0202ce90ff92340f51f4309501770 Author: Jonathan Bedard Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Tools/Scripts/libraries/webkitcorepy/setup.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py A Tools/Scripts/libraries/webkitcorepy/webkitcorepy/multiprocessing_utils.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py A Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/multiprocessing_utils_unittest.py Log Message: --- [run-webkit-tests] Extra thread spawned for each worker https://bugs.webkit.org/show_bug.cgi?id=247324 rdar://101813483 Reviewed by Elliott Williams. * Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version, import NullContext before TaskPool. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/multiprocessing_utils.py: Added. (Queue.__init__): (Queue.close): (Queue.__getstate__): (Queue.__setstate__): (Queue.get): * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py: (_BiDirectionalQueue.__init__): Use multiprocessing_utils.Queue for Python 3, multiprocessing.Queue for Python 2. (_BiDirectionalQueue.receive): Use Python 2/3 compatible Empty exception. (_BiDirectionalQueue.close): Only invoke thread join if the Queue has the function. (TaskPool.do): Use Python 2/3 compatible Empty exception. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/multiprocessing_utils_unittest.py: Added. (QueueUnittest.test_basic): (QueueUnittest.test_no_block): (QueueUnittest.test_timeout): Canonical link: https://commits.webkit.org/256262@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c98a2d: AX ITM: Fix for LayoutTests/accessibility/svg-remo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c98a2ded1d0097353fd604d07bf242a1e1d087e2 https://github.com/WebKit/WebKit/commit/c98a2ded1d0097353fd604d07bf242a1e1d087e2 Author: Andres Gonzalez Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/accessibility-isolated-tree/TestExpectations M LayoutTests/accessibility/svg-remote-element.html M LayoutTests/platform/glib/accessibility/svg-remote-element-expected.txt M LayoutTests/platform/mac/accessibility/svg-remote-element-expected.txt M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilitySVGElement.cpp M Source/WebCore/accessibility/AccessibilitySVGElement.h M Source/WebCore/accessibility/AccessibilitySVGRoot.cpp M Source/WebCore/accessibility/AccessibilitySVGRoot.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp Log Message: --- AX ITM: Fix for LayoutTests/accessibility/svg-remote-element.html in isolated tree mode. https://bugs.webkit.org/show_bug.cgi?id=247316 Reviewed by Chris Fleizach. Embedded SVG documents are not connected to the container's top document. Therefore, all AX SVG objects are created and cached by a separate instance of AXObjectCache different from the container's AXObjectCache. This causes that the AX SVG objects do not appear in the isolated tree built for the top document. This patch fixes this problem by passing the appropriate AXObjectCache instance to the constructor of AXSVGRoot and AXSVGElement, and overriding the axObjectCahce() method in these subclasses. Some minor code cleanup and debug logging. * LayoutTests/accessibility-isolated-tree/TestExpectations: * LayoutTests/accessibility/svg-remote-element.html: * LayoutTests/platform/glib/accessibility/svg-remote-element-expected.txt: * LayoutTests/platform/mac/accessibility/svg-remote-element-expected.txt: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::createObjectFromRenderer): (WebCore::AXObjectCache::getOrCreate): (WebCore::createFromRenderer): Renamed createObjectFromRenderer. (WebCore::AXObjectCache::getOrCreateIsolatedTree const): (WebCore::AXObjectCache::handleAttributeChange): (WebCore::AXObjectCache::updateRelationsIfNeeded): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::remoteSVGRootElement const): (WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation): * Source/WebCore/accessibility/AccessibilitySVGElement.cpp: (WebCore::AccessibilitySVGElement::AccessibilitySVGElement): (WebCore::AccessibilitySVGElement::create): * Source/WebCore/accessibility/AccessibilitySVGElement.h: * Source/WebCore/accessibility/AccessibilitySVGRoot.cpp: (WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot): (WebCore::AccessibilitySVGRoot::create): * Source/WebCore/accessibility/AccessibilitySVGRoot.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::children): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::collectNodeChangesForSubtree): Canonical link: https://commits.webkit.org/256261@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b60c1a: [Content Extensions] QueryTransforms should not un...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b60c1a321a03a8912f9b8511018525271477aefc https://github.com/WebKit/WebKit/commit/b60c1a321a03a8912f9b8511018525271477aefc Author: Wenson Hsieh Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/contentextensions/ContentExtensionActions.cpp M Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp Log Message: --- [Content Extensions] QueryTransforms should not unconditionally redirect to form-encoded URLs https://bugs.webkit.org/show_bug.cgi?id=247365 Reviewed by Tim Horton and Timothy Hatcher. Refactor `QueryTransform::applyToURL`, so that it doesn't unconditionally call into `parseURLEncodedForm()`, and set the query to this URL-encoded form. Currently, this causes query parameters and values in the input URL to become percent-encoded, regardless of whether or not any of the query transformation rules matched. Instead, we change this behavior to leave query parameters intact, in the case where they don't match any of the query transformation rules. This means that if a URL query contains `"x+y=z"` and it doesn't match any transformation rules, the final result will remain as-is, rather than `"x%20y=z"`. Test: ContentExtensionTest.QueryTransformActions * Source/WebCore/contentextensions/ContentExtensionActions.cpp: Also, add an early return in the case where the URL has no query parameters at all, so that we can avoid spending any time checking against rules. We also avoid calling `setQuery` at all in the case where no actions were applied, so that we don't need to unnecessarily re-parse the URL if nothing changed. (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::applyToURL const): * Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Add an API test to exercise the bug. Canonical link: https://commits.webkit.org/256260@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 615b2c: Hide more standard library exports
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 615b2c8069cdda2b86c6c82e6433a8138a53f218 https://github.com/WebKit/WebKit/commit/615b2c8069cdda2b86c6c82e6433a8138a53f218 Author: Dean Jackson Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig Log Message: --- Hide more standard library exports https://bugs.webkit.org/show_bug.cgi?id=247388 rdar://101884652 Reviewed by Sihui Liu. New toolchains have new C++ standard library symbols that need to be hidden. * Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig: Add more symbols to OTHER_LDFLAGS_HIDE_SYMBOLS. Canonical link: https://commits.webkit.org/256259@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9d69bb: Implement StylePropertyMap::set()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d69bb363e5ef9f79361d9e411815894b946e18b https://github.com/WebKit/WebKit/commit/9d69bb363e5ef9f79361d9e411815894b946e18b Author: Chris Dumez Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/declared-styleMap-accepts-inherit-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/set-var-reference-thcrash-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/declared.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set-shorthand-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set-shorthand-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set.tentative-expected.txt M Source/WebCore/css/CSSProperty.cpp M Source/WebCore/css/CSSProperty.h M Source/WebCore/css/StyleProperties.cpp M Source/WebCore/css/StyleProperties.h M Source/WebCore/css/calc/CSSCalcValue.cpp M Source/WebCore/css/calc/CSSCalcValue.h M Source/WebCore/css/typedom/CSSKeywordValue.cpp M Source/WebCore/css/typedom/CSSKeywordValue.h M Source/WebCore/css/typedom/CSSNumericValue.h M Source/WebCore/css/typedom/CSSStyleImageValue.cpp M Source/WebCore/css/typedom/CSSStyleImageValue.h M Source/WebCore/css/typedom/CSSStyleValue.h M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp M Source/WebCore/css/typedom/CSSStyleValueFactory.h M Source/WebCore/css/typedom/CSSUnitValue.cpp M Source/WebCore/css/typedom/CSSUnitValue.h M Source/WebCore/css/typedom/CSSUnparsedValue.cpp M Source/WebCore/css/typedom/CSSUnparsedValue.h M Source/WebCore/css/typedom/DeclaredStylePropertyMap.cpp M Source/WebCore/css/typedom/DeclaredStylePropertyMap.h M Source/WebCore/css/typedom/StylePropertyMap.cpp M Source/WebCore/css/typedom/StylePropertyMap.h M Source/WebCore/css/typedom/color/CSSColorValue.cpp M Source/WebCore/css/typedom/color/CSSColorValue.h M Source/WebCore/css/typedom/numeric/CSSMathClamp.cpp M Source/WebCore/css/typedom/numeric/CSSMathClamp.h M Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp M Source/WebCore/css/typedom/numeric/CSSMathInvert.h M Source/WebCore/css/typedom/numeric/CSSMathMax.cpp M Source/WebCore/css/typedom/numeric/CSSMathMax.h M Source/WebCore/css/typedom/numeric/CSSMathMin.cpp M Source/WebCore/css/typedom/numeric/CSSMathMin.h M Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp M Source/WebCore/css/typedom/numeric/CSSMathNegate.h M Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp M Source/WebCore/css/typedom/numeric/CSSMathProduct.h M Source/WebCore/css/typedom/numeric/CSSMathSum.cpp M Source/WebCore/css/typedom/numeric/CSSMathSum.h M Source/WebCore/css/typedom/numeric/CSSMathValue.h M Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp M Source/WebCore/css/typedom/transform/CSSMatrixComponent.h M Source/WebCore/css/typedom/transform/CSSPerspective.cpp M Source/WebCore/css/typedom/transform/CSSPerspective.h M Source/WebCore/css/typedom/transform/CSSRotate.cpp M Source/WebCore/css/typedom/transform/CSSRotate.h M Source/WebCore/css/typedom/transform/CSSScale.cpp M Source/WebCore/css/typedom/transform/CSSScale.h M Source/WebCore/css/typedom/transform/CSSSkew.cpp M Source/WebCore/css/typedom/transform/CSSSkew.h M Source/WebCore/css/typedom/transform/CSSSkewX.cpp M Source/WebCore/css/typedom/transform/CSSSkewX.h M Source/WebCore/css/typedom/transform/CSSSkewY.cpp M Source/WebCore/css/typedom/transform/CSSSkewY.h M Source/WebCore/css/typedom/transform/CSSTransformComponent.h M Source/WebCore/css/typedom/transform/CSSTransformValue.cpp M Source/WebCore/css/typedom/transform/CSSTransformValue.h M Source/WebCore/css/typedom/transform/CSSTranslate.cpp M Source/WebCore/css/typedom/transform/CSSTranslate.h M Source/WebCore/dom/StyledElement.cpp M Source/WebCore/dom/StyledElement.h Log Message: --- Implement StylePropertyMap::set() https://bugs.webkit.org/show_bug.cgi?id=247199 Reviewed by Antti Koivisto. Implement StylePropertyMap::set(): -
[webkit-changes] [WebKit/WebKit] ba3a20: Support modules for web extension service workers.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba3a201f4e4aff8cfa206c624bd696473ace6cf2 https://github.com/WebKit/WebKit/commit/ba3a201f4e4aff8cfa206c624bd696473ace6cf2 Author: Ellie Epskamp-Hunt Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionPrivate.h M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtension.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionController.mm Log Message: --- Support modules for web extension service workers. https://bugs.webkit.org/show_bug.cgi?id=247325 rdar://100429656 Reviewed by Timothy Hatcher. Revise SPI to load a service worker to include a parameter that indicates if the service worker uses modules or not. Parse the "module" type from the extension's manifest and use that to load the service worker correctly, or to create the generated background HTML file with the correct
[webkit-changes] [WebKit/WebKit] 759576: Don't apply aspect ratio scaling to gradient backg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 759576401a3d3175f5f17ea8756f36423b147a51 https://github.com/WebKit/WebKit/commit/759576401a3d3175f5f17ea8756f36423b147a51 Author: Matt Woodrow Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/css3/masking/mask-luminance-gradient-expected.html M LayoutTests/css3/masking/mask-luminance-gradient.html M Source/WebCore/display/css/DisplayFillLayerImageGeometry.cpp M Source/WebCore/rendering/BackgroundPainter.cpp M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/style/StyleGeneratedImage.h M Source/WebCore/rendering/style/StyleImage.h Log Message: --- Don't apply aspect ratio scaling to gradient background images that don't have a natural aspect ratio https://bugs.webkit.org/show_bug.cgi?id=247298 Reviewed by Simon Fraser. If we use a gradient as a background image, and set one of the background size dimension to auto, we currently scale that dimension by the same amount as the other axis to preserve the aspect ratio. Gradients have no natural dimensions (and thus no natural aspect ratio) - https://w3c.github.io/csswg-drafts/css-images/#gradients. Background sizing should fall back to using 100% (for the case where we have one size, and auto), if there's no natural aspect ratio or dimensions - https://w3c.github.io/csswg-drafts/css-backgrounds/#background-size * LayoutTests/TestExpectations: * Source/WebCore/display/css/DisplayFillLayerImageGeometry.cpp: (WebCore::Display::calculateImageIntrinsicDimensions): (WebCore::Display::calculateFillTileSize): * Source/WebCore/rendering/BackgroundPainter.cpp: (WebCore::BackgroundPainter::calculateFillTileSize): * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions const): * Source/WebCore/rendering/style/StyleGeneratedImage.h: * Source/WebCore/rendering/style/StyleImage.h: (WebCore::StyleImage::imageHasNaturalDimensions const): Canonical link: https://commits.webkit.org/256256@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 809586: Crash in gamepads in WKWebView apps that also list...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 809586a6b81ed6b9f46cda1c990392e90182266a https://github.com/WebKit/WebKit/commit/809586a6b81ed6b9f46cda1c990392e90182266a Author: Brady Eidson Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp Log Message: --- Crash in gamepads in WKWebView apps that also listen to the GameController framework themselves https://bugs.webkit.org/show_bug.cgi?id=247368 and rdar://100036005 Reviewed by Geoff Garen. No test possible for now. * Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp: (WebKit::UIGamepadProvider::platformGamepadInputActivity): Handle a mismatch between platform gamepads and established gamepads. This can happen when there's "invisible" gamepads still, and the current input event will not reveal them to WebContent. And it's fine: Things get resolved when an input even *does* reveal the gamepads to the web page. Canonical link: https://commits.webkit.org/256255@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.12 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d175f0: Cherry-pick f1b974f02e12. rdar://problem/101874781
Branch: refs/heads/safari-7615.1.12-branch Home: https://github.com/WebKit/WebKit Commit: d175f0f291a169c00ae7f8ccc798ac2998cbdffe https://github.com/WebKit/WebKit/commit/d175f0f291a169c00ae7f8ccc798ac2998cbdffe Author: Per Arne Vollan Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Cherry-pick f1b974f02e12. rdar://problem/101874781 Add missing Mac platform check in sandbox https://bugs.webkit.org/show_bug.cgi?id=247385 rdar://101874781 Reviewed by Geoffrey Garen. Add missing Mac platform check in the WebContent sandbox. * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/256254@main Canonical link: https://commits.webkit.org/256138.11@safari-7615.1.12-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f1b974: Add missing Mac platform check in sandbox
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f1b974f02e121913a8c9fdc13f4ae1b1a1cc417d https://github.com/WebKit/WebKit/commit/f1b974f02e121913a8c9fdc13f4ae1b1a1cc417d Author: Per Arne Vollan Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Add missing Mac platform check in sandbox https://bugs.webkit.org/show_bug.cgi?id=247385 rdar://101874781 Reviewed by Geoffrey Garen. Add missing Mac platform check in the WebContent sandbox. * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/256254@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58eb1c: ASSERT(!m_beginTime) in SMILTimeContainer::begin f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58eb1cbd097a97a8d804e9346f3b15993af7447d https://github.com/WebKit/WebKit/commit/58eb1cbd097a97a8d804e9346f3b15993af7447d Author: Fujii Hironori Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: A LayoutTests/svg/animations/start-animation-twice-crash-expected.txt A LayoutTests/svg/animations/start-animation-twice-crash.html M Source/WebCore/svg/SVGSVGElement.cpp M Source/WebCore/svg/animation/SMILTimeContainer.cpp M Source/WebCore/svg/animation/SMILTimeContainer.h Log Message: --- ASSERT(!m_beginTime) in SMILTimeContainer::begin fires on many sites https://bugs.webkit.org/show_bug.cgi?id=172490 Reviewed by Simon Fraser. The assertion was ensuring the begin() wasn't called before, but it was a wrong assertion. If a svg element is moved to a newly opened document, begin() can be called multiple times. Removed the assertion, and just return the function if the animation is already started. * LayoutTests/svg/animations/start-animation-twice-crash-expected.txt: Added. * LayoutTests/svg/animations/start-animation-twice-crash.html: Added. * Source/WebCore/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::insertedIntoAncestor): * Source/WebCore/svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::begin): * Source/WebCore/svg/animation/SMILTimeContainer.h: Canonical link: https://commits.webkit.org/256253@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 31de97: MobileMiniBrowser should accept the '--url' comman...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 31de97a9dff67e49e76d50adaafc58dd663f6ddf https://github.com/WebKit/WebKit/commit/31de97a9dff67e49e76d50adaafc58dd663f6ddf Author: Ryan Reno Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Tools/MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m Log Message: --- MobileMiniBrowser should accept the '--url' command line argument https://bugs.webkit.org/show_bug.cgi?id=247378 rdar://101878523 Reviewed by Simon Fraser. This adds support for parsing and acting upon a --url command line arg. With this patch you would need to edit the scheme in Xcode and pass something like: --url https://www.apple.com to get MobileMiniBrowser to navigate to a specific URL on launch. This is a first step toward adding support to run-minibrowser so you could launch (Mobile)MiniBrowser like: run-minibrowser --iphone-simulator --url https://www.apple.com * Tools/MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: (-[WebViewController viewDidLoad]): (-[WebViewController addProtocolIfNecessary:]): (-[WebViewController targetURLorDefaultURL]): Canonical link: https://commits.webkit.org/256252@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7df587: Rendering artifacts when presenting fullscreen video
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7df587ca6a527c0e64cadc9d421de5298f65ea1c https://github.com/WebKit/WebKit/commit/7df587ca6a527c0e64cadc9d421de5298f65ea1c Author: Aditya Keerthi Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- Rendering artifacts when presenting fullscreen video https://bugs.webkit.org/show_bug.cgi?id=247155 rdar://101352957 Reviewed by Tim Horton. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen:]): Floor the values in the target size, as the window dimensions need to be integral values. (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]): Canonical link: https://commits.webkit.org/256251@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd4a1c: [Gardening]: New Tests(255047@main): [ iOS macOS ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd4a1c53cdbbca0cd116fdae27492dbabc9194f4 https://github.com/WebKit/WebKit/commit/cd4a1c53cdbbca0cd116fdae27492dbabc9194f4 Author: Hercules Hjalmarsson Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations A LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/feature-policy/reporting/picture-in-picture-reporting-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/feature-policy/experimental-features/vertical-scroll-scrollintoview.tentative-expected.txt Log Message: --- [Gardening]: New Tests(255047@main): [ iOS macOS ] 3X imported/w3c/web-platform-tests/feature-policy/(Layout tests) are constantly failing https://bugs.webkit.org/show_bug.cgi?id=245967 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/feature-policy/reporting/picture-in-picture-reporting-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/feature-policy/experimental-features/vertical-scroll-scrollintoview.tentative-expected.txt: Added. Canonical link: https://commits.webkit.org/256250@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 978e82: [Build Fix] Replace Deprecated macros with direct ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 978e825ba5e56165476b0c9c27238823d8883d68 https://github.com/WebKit/WebKit/commit/978e825ba5e56165476b0c9c27238823d8883d68 Author: Ryan Reno Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Tools/MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m Log Message: --- [Build Fix] Replace Deprecated macros with direct calls. Unreviewed build fix. Replaced deprecated macros with direct calls to UIDevice messages. * Tools/MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: (-[MobileMiniBrowserUITests testBasicVideoPlayback]): (-[MobileMiniBrowserUITests testBasicVideoFullscreen]): (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]): (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]): Canonical link: https://commits.webkit.org/256249@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08fc03: Use OptionSet for WebCore::PaintPhase in layer bas...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08fc037dd96fc7b02b618bddab43c4bd927ba5aa https://github.com/WebKit/WebKit/commit/08fc037dd96fc7b02b618bddab43c4bd927ba5aa Author: Don Olmstead Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/rendering/PaintPhase.h M Source/WebCore/rendering/RenderLayerModelObject.cpp M Source/WebCore/rendering/RenderLayerModelObject.h M Source/WebCore/rendering/svg/RenderSVGContainer.cpp M Source/WebCore/rendering/svg/RenderSVGImage.cpp M Source/WebCore/rendering/svg/RenderSVGShape.cpp M Source/WebCore/rendering/svg/RenderSVGText.cpp Log Message: --- Use OptionSet for WebCore::PaintPhase in layer based SVG engine https://bugs.webkit.org/show_bug.cgi?id=247346 Reviewed by Simon Fraser. A `PaintPhase` is an `enum class` so it makes sense to use `OptionSet` instead of the `StdOrderedSet`. * Source/WebCore/rendering/PaintPhase.h: * Source/WebCore/rendering/RenderLayerModelObject.cpp: * Source/WebCore/rendering/RenderLayerModelObject.h: * Source/WebCore/rendering/svg/RenderSVGContainer.cpp: * Source/WebCore/rendering/svg/RenderSVGImage.cpp: * Source/WebCore/rendering/svg/RenderSVGShape.cpp: * Source/WebCore/rendering/svg/RenderSVGText.cpp: Canonical link: https://commits.webkit.org/256248@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1ad126: Typo error in RenderLayerCompositor::destroyRootLa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ad126f47e2a05241ed77ff1f51068aae60535de https://github.com/WebKit/WebKit/commit/1ad126f47e2a05241ed77ff1f51068aae60535de Author: Ahmad Saleem Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/rendering/RenderLayerCompositor.cpp Log Message: --- Typo error in RenderLayerCompositor::destroyRootLayer() for Horizontal Scrollbar Typo error in RenderLayerCompositor::destroyRootLayer() for Horizontal Scrollbar https://bugs.webkit.org/show_bug.cgi?id=247369 Reviewed by Alan Baradlay. Merge - https://src.chromium.org/viewvc/blink?view=revision=194036 This is to fix a copy paste error in "m_layerForHorizontalScrollbar", where the "verticalScrollbar" was mentioned instead of "horizontalScrollbar". * Source/WebCore/rendering/RenderLayerCompositor.cpp: (RenderLayerCompositor::destroyRootLayer): Fix reference to horizontalScrollbar" Canonical link: https://commits.webkit.org/256247@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd8d40: Remove flaky painting api test.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd8d401e98ed8f3a7b110a9ee3d62a7b89baf6ea https://github.com/WebKit/WebKit/commit/dd8d401e98ed8f3a7b110a9ee3d62a7b89baf6ea Author: Justin Michaud Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: R LayoutTests/fast/css-custom-paint/animate-repaint-expected.txt R LayoutTests/fast/css-custom-paint/animate-repaint.html M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Remove flaky painting api test. https://bugs.webkit.org/show_bug.cgi?id=240167 rdar://92859076 Unreviewed test gardening. * LayoutTests/fast/css-custom-paint/animate-repaint.html: Removed. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/256246@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01ba18: REGRESSION: 4 PiP API tests consistently failing o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01ba18b12b6eb4b5823551356ce62c874cb69455 https://github.com/WebKit/WebKit/commit/01ba18b12b6eb4b5823551356ce62c874cb69455 Author: Ryan Haddad Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm Log Message: --- REGRESSION: 4 PiP API tests consistently failing on Big Sur EWS https://bugs.webkit.org/show_bug.cgi?id=247373 rdar://101873453 Unreviewed test gardening. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: (TestWebKitAPI::TEST): Disable test on Big Sur to speed up EWS. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: (TEST): Ditto. Canonical link: https://commits.webkit.org/256245@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d013e: [JSC] Fix Clang build fails with -Wcast-align in Z...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d013e8f190bdd84466a7004f94411b798a5d4c0 https://github.com/WebKit/WebKit/commit/8d013e8f190bdd84466a7004f94411b798a5d4c0 Author: Yijia Huang Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreList.c Log Message: --- [JSC] Fix Clang build fails with -Wcast-align in ZycoreList.c https://bugs.webkit.org/show_bug.cgi?id=247064 rdar://101862332 Reviewed by Yusuke Suzuki. The `cast-align` warning is thrown when cast from a type with smaller alignment to a type with larger alignment. We should suppress this warning. * Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreList.c: (ZyanListAllocateNode): Canonical link: https://commits.webkit.org/256244@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 431164: [Wasm-GC] Add support for subtyping declarations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 431164ca6a4b101688188966ce5384a7f8c68681 https://github.com/WebKit/WebKit/commit/431164ca6a4b101688188966ce5384a7f8c68681 Author: Asumu Takikawa Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: A JSTests/wasm/gc/sub.js M JSTests/wasm/wasm.json M Source/JavaScriptCore/wasm/WasmFormat.h M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp M Source/JavaScriptCore/wasm/WasmLimits.h M Source/JavaScriptCore/wasm/WasmSectionParser.cpp M Source/JavaScriptCore/wasm/WasmSectionParser.h M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp M Source/JavaScriptCore/wasm/WasmTypeDefinition.h M Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp M Source/JavaScriptCore/wasm/js/WasmToJS.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp M Source/JavaScriptCore/wasm/wasm.json Log Message: --- [Wasm-GC] Add support for subtyping declarations https://bugs.webkit.org/show_bug.cgi?id=239668 Reviewed by Justin Michaud. Adds support for `sub` type section forms. These introduce subtyping declarations that can specify parent types for a `func`, `struct`, etc. type (the MVP GC proposal only allows a single parent type). Adding `sub` forms changes type expansion slightly, and requires that checking `isSubtype` look at the type hierarchy if the LHS type is a `sub` type. This patch also memoizes type expansion to avoid repeated unrolling of recursive types. With the addition of `sub`, a bare `func`, `struct`, etc declaration is treated as implicitly having a `sub` with zero/empty supertypes. To avoid `(sub () (func))` and `(func)` being represented differently, we normalize empty-supertype `sub` to be represented as just the underlying type. Subtype checking for indexed reference types is done using a display data structure. Each `sub` declaration has an associated display that records an array of supertype indices. This allows subtype checking in constant-time by checking if the supertype index is present in the subtype at the correct display offset, rather than with a linear traversal of the hierarchy. If multiple parent types are allowed in the future, this algorithm will need to change. * JSTests/wasm/gc/sub.js: Added. (module): (testSubDeclaration): * JSTests/wasm/wasm.json: * Source/JavaScriptCore/wasm/WasmFormat.h: (JSC::Wasm::isSubtypeIndex): (JSC::Wasm::isSubtype): * Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp: (JSC::Wasm::LLIntGenerator::callInformationForCaller): (JSC::Wasm::LLIntGenerator::callInformationForCallee): (JSC::Wasm::LLIntGenerator::addArguments): * Source/JavaScriptCore/wasm/WasmLimits.h: * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseType): (JSC::Wasm::SectionParser::parseRecursionGroup): (JSC::Wasm::SectionParser::checkStructuralSubtype): (JSC::Wasm::SectionParser::checkSubtypeValidity): (JSC::Wasm::SectionParser::parseSubtype): * Source/JavaScriptCore/wasm/WasmSectionParser.h: * Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp: (JSC::Wasm::TypeDefinition::dump const): (JSC::Wasm::Subtype::toString const): (JSC::Wasm::Subtype::dump const): (JSC::Wasm::computeSubtypeHash): (JSC::Wasm::TypeDefinition::hash const): (JSC::Wasm::TypeDefinition::tryCreateSubtype): (JSC::Wasm::TypeDefinition::replacePlaceholders const): (JSC::Wasm::TypeDefinition::unroll const): (JSC::Wasm::TypeDefinition::expand const): (JSC::Wasm::TypeDefinition::hasRecursiveReference const): (JSC::Wasm::SubtypeParameterTypes::hash): (JSC::Wasm::SubtypeParameterTypes::equal): (JSC::Wasm::SubtypeParameterTypes::translate): (JSC::Wasm::TypeInformation::typeDefinitionForSubtype): (JSC::Wasm::TypeInformation::addCachedUnrolling): (JSC::Wasm::TypeInformation::tryGetCachedUnrolling): (JSC::Wasm::TypeInformation::tryCleanup): * Source/JavaScriptCore/wasm/WasmTypeDefinition.h: (JSC::Wasm::typeKindSizeInBytes): (JSC::Wasm::Subtype::Subtype): (JSC::Wasm::Subtype::superType const): (JSC::Wasm::Subtype::underlyingType const): (JSC::Wasm::Subtype::displayType const): (JSC::Wasm::Subtype::displaySize const): (JSC::Wasm::Subtype::getSuperType): (JSC::Wasm::Subtype::getUnderlyingType): (JSC::Wasm::Subtype::getDisplayType): (JSC::Wasm::Subtype::storage): (JSC::Wasm::Subtype::storage const): (JSC::Wasm::TypeDefinition::allocatedSubtypeSize): * Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp: (JSC::JSWebAssemblyStruct::set): * Source/JavaScriptCore/wasm/js/WasmToJS.cpp: (JSC::Wasm::wasmToJS): * Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::initializeImports): * Source/JavaScriptCore/wasm/wasm.json: Canonical link: https://commits.webkit.org/256243@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ae5d5: ThemeAdwaita: checkbox and radio buttons are invis...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ae5d5e42fa20474d513eab00cb8f1914d861c39 https://github.com/WebKit/WebKit/commit/5ae5d5e42fa20474d513eab00cb8f1914d861c39 Author: Fujii Hironori Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/platform/adwaita/ThemeAdwaita.cpp Log Message: --- ThemeAdwaita: checkbox and radio buttons are invisible in black backgrounds https://bugs.webkit.org/show_bug.cgi?id=246785 Reviewed by Don Olmstead. * Source/WebCore/platform/adwaita/ThemeAdwaita.cpp: (WebCore::ThemeAdwaita::paintCheckbox): (WebCore::ThemeAdwaita::paintRadio): Paint the inside of a checkbox and a radio button with foregroundColor like other browsers. Canonical link: https://commits.webkit.org/256242@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b0b694: Strength reduction analyzes RegEx.exec incorrectly...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b0b694fd099f5692c3d73f7d66abaca58c4f9b4e https://github.com/WebKit/WebKit/commit/b0b694fd099f5692c3d73f7d66abaca58c4f9b4e Author: Michael Saboff Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: A JSTests/stress/regexp-strengthreduce-results-noholes.js M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp Log Message: --- Strength reduction analyzes RegEx.exec incorrectly and generate a hole for the result array https://bugs.webkit.org/show_bug.cgi?id=245464 rdar://100494428 Reviewed by Mark Lam. When employing RegExp.exec strength reductions, we need to create "undefined" entries in the result array instead of null entries per the EcmaScript spec for RegExp.match. * JSTests/stress/regexp-strengthreduce-results-noholes.js: Added. (runRegExp): (assertSameAsFirstResult): * Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp: (JSC::DFG::StrengthReductionPhase::handleNode): Canonical link: https://commits.webkit.org/256241@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ae3ec2: Add Web Extension code generator scripts, bindings...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae3ec29cd1eb5894276afcfa17a200ed87b477de https://github.com/WebKit/WebKit/commit/ae3ec29cd1eb5894276afcfa17a200ed87b477de Author: Timothy Hatcher Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources-output.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Scripts/generate-derived-sources.sh M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj A Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIExtensionCocoa.mm A Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm A Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIExtension.h A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIObject.h A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIRuntime.h A Source/WebKit/WebProcess/Extensions/Bindings/Cocoa/JSWebExtensionWrapperCocoa.mm A Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrappable.h A Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.cpp A Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.h A Source/WebKit/WebProcess/Extensions/Bindings/Scripts/CodeGeneratorExtensions.pm A Source/WebKit/WebProcess/Extensions/Bindings/Scripts/IDLAttributes.json A Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIExtension.idl A Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl A Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIRuntime.idl M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp Log Message: --- Add Web Extension code generator scripts, bindings glue, and some IDL files. https://bugs.webkit.org/show_bug.cgi?id=246410 Reviewed by Brian Weinstein. This stands up the code generator for the JavaScript bindings for Web Extensions. This has been tested with all the IDL files, but I'm only adding a couple partial interfaces with stub implementations to keep this change small. The rest of the interfaces files will be added as the API areas are added. For each IDL file in WebProcess/Extensions/Interfaces, a corresponding header and implementation is expected in WebProcess/Extensions/API. The bulk of the binding helpers are defined in JSWebExtensionWrapper.h, with converter functions and the JSWebExtensionWrapper and WebExtensionCallbackHandler classes. The WebExtensionCallbackHandler class handles the two ways Web Extensions can process async results — the Manifest v2 callback function way, or the Manifest v3 Promise result method. This lets the API layer be agnostic about which one the JavaScript is using and report results or errors consistently. This is untested (besides successfully building) until API injection can be done. Most of this was copied from Safari's existing implementation and changed for WebKit to use more C++, and use WebCore's bindings scripts. * Source/WebKit/DerivedSources-input.xcfilelist: Auto generated. * Source/WebKit/DerivedSources-output.xcfilelist: Ditto. * Source/WebKit/DerivedSources.make: * Source/WebKit/Scripts/generate-derived-sources.sh: Added WebCoreScripts var. * Source/WebKit/SourcesCocoa.txt: Added new file. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Added new files. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIExtensionCocoa.mm: Added. (WebKit::WebExtensionAPIExtension::isPropertyAllowed): (WebKit::WebExtensionAPIExtension::getURL): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm: Added. (WebKit::WebExtensionAPINamespace::extension): (WebKit::WebExtensionAPINamespace::runtime): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm: Added. (WebKit::WebExtensionAPIRuntimeBase::reportErrorForCallbackHandler): (WebKit::WebExtensionAPIRuntime::getURL): (WebKit::WebExtensionAPIRuntime::getManifest): (WebKit::WebExtensionAPIRuntime::runtimeIdentifier): (WebKit::WebExtensionAPIRuntime::getPlatformInfo): (WebKit::WebExtensionAPIRuntime::lastError): * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIExtension.h: Added. * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h: Added. * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIObject.h: Added. (WebKit::WebExtensionAPIObject::WebExtensionAPIObject): (WebKit::WebExtensionAPIObject::forMainWorld const): (WebKit::WebExtensionAPIObject::isForMainWorld const): (WebKit::WebExtensionAPIObject::runtime): *
[webkit-changes] [WebKit/WebKit] f668ca: Cherry-pick db1bc3388c3f. rdar://problem/101820591
Branch: refs/heads/safari-7615.1.12-branch Home: https://github.com/WebKit/WebKit Commit: f668ca35a6634a997a1481036567e7b2f4bd428b https://github.com/WebKit/WebKit/commit/f668ca35a6634a997a1481036567e7b2f4bd428b Author: Charlie Wolfe Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/contentextensions/ContentExtensionActions.cpp M Source/WebCore/platform/Logging.h Log Message: --- Cherry-pick db1bc3388c3f. rdar://problem/101820591 Add a logging channel for debugging content extensions https://bugs.webkit.org/show_bug.cgi?id=247348 rdar://101820591 Reviewed by Wenson Hsieh. This adds logging for content extensions that apply the URL query transformation. * Source/WebCore/contentextensions/ContentExtensionActions.cpp: (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::applyToURL const): * Source/WebCore/platform/Logging.h: Canonical link: https://commits.webkit.org/256239@main Canonical link: https://commits.webkit.org/256138.10@safari-7615.1.12-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db1bc3: Add a logging channel for debugging content extens...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db1bc3388c3f792aa58e86bfba48fb934bf58407 https://github.com/WebKit/WebKit/commit/db1bc3388c3f792aa58e86bfba48fb934bf58407 Author: Charlie Wolfe Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/contentextensions/ContentExtensionActions.cpp M Source/WebCore/platform/Logging.h Log Message: --- Add a logging channel for debugging content extensions https://bugs.webkit.org/show_bug.cgi?id=247348 rdar://101820591 Reviewed by Wenson Hsieh. This adds logging for content extensions that apply the URL query transformation. * Source/WebCore/contentextensions/ContentExtensionActions.cpp: (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::applyToURL const): * Source/WebCore/platform/Logging.h: Canonical link: https://commits.webkit.org/256239@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1b510e: Cherry-pick 5fd2411bada8. rdar://problem/101806362
Branch: refs/heads/safari-7615.1.12-branch Home: https://github.com/WebKit/WebKit Commit: 1b510e316287e115d67ae486555a3d15323daf16 https://github.com/WebKit/WebKit/commit/1b510e316287e115d67ae486555a3d15323daf16 Author: Per Arne Vollan Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/Shared/Sandbox/macOS/common.sb M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Cherry-pick 5fd2411bada8. rdar://problem/101806362 Remove sandbox v2 telemetry for known entries https://bugs.webkit.org/show_bug.cgi?id=247318 rdar://101806362 Reviewed by Brent Fulgham. Remove sandbox v2 telemetry for entries that are known to be in use on macOS. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/Shared/Sandbox/macOS/common.sb: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/256188@main Canonical link: https://commits.webkit.org/256138.4@safari-7615.1.12-branch Commit: 1e144ce5317926899b9dd78e8d97fd71d8287bed https://github.com/WebKit/WebKit/commit/1e144ce5317926899b9dd78e8d97fd71d8287bed Author: Wenson Hsieh Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm Log Message: --- Cherry-pick 193d0064ca5b. rdar://problem/101784403 REGRESSION (256119@main, 256136@main): The News app crashes on launch https://bugs.webkit.org/show_bug.cgi?id=247321 rdar://101784403 Reviewed by J Pascoe and Tim Horton. In Catalyst, the value of `crossSiteTrackingPreventionDisabledDomains` ends up being uninitialized when we try to retain it. Fix this by initializing it to `nil`. * Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::initializeManagedDomains): Canonical link: https://commits.webkit.org/256190@main Canonical link: https://commits.webkit.org/256138.5@safari-7615.1.12-branch Commit: 05793c9a2feec35e47e1a4dd44b3fe3a0bc7a138 https://github.com/WebKit/WebKit/commit/05793c9a2feec35e47e1a4dd44b3fe3a0bc7a138 Author: Wenson Hsieh Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Cherry-pick 495019c115fe. rdar://problem/101818726 REGRESSION (255929@main): Some Facebook links cannot be opened in Safari https://bugs.webkit.org/show_bug.cgi?id=247351 rdar://101818726 Reviewed by Tim Horton and John Wilander. Guard the new call to `WebFrameProxy::swapToProcess()` (which is currently a no-op) behind the experimental `SiteIsolationEnabled` feature flag. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::continueNavigationInNewProcess): Canonical link: https://commits.webkit.org/256213@main Canonical link: https://commits.webkit.org/256138.6@safari-7615.1.12-branch Commit: b465d87c98f5931e5237e5061da2edb9ad087ef7 https://github.com/WebKit/WebKit/commit/b465d87c98f5931e5237e5061da2edb9ad087ef7 Author: Tim Nguyen Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/css/CSSSelector.cpp M Source/WebCore/css/CSSSelector.h M Source/WebCore/css/SelectorChecker.cpp M Source/WebCore/css/SelectorCheckerTestFunctions.h M Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in M Source/WebCore/css/fullscreen.css M Source/WebCore/cssjit/SelectorCompiler.cpp M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp Log Message: --- Cherry-pick d7bab9d6f7c4. rdar://problem/101600873 Add temporary backdrop workaround for fullscreen elements https://bugs.webkit.org/show_bug.cgi?id=247349 rdar://101600873 Reviewed by Tim Horton. Removing RenderFullScreen introduced a regression, where content appears behind the fullscreen element. RenderFullScreen used to solve that by wrapping the fullscreen element renderer with a renderer that has a black background. The standard way of solving this issue is to add a ::backdrop that has such a background. This will be done once fullscreen switches to use the top layer. For now, add a pseudo-class that targets the parent of the fullscreen element, and use ::before to emulate the ::backdrop. We specifically pick the parent, because it is guaranteed to be able to contain children (and ::before), and to avoid conflict with any potential ::before on the fullscreen element itself. * Source/WebCore/css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText const): * Source/WebCore/css/CSSSelector.h: * Source/WebCore/css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): * Source/WebCore/css/SelectorCheckerTestFunctions.h:
[webkit-changes] [WebKit/WebKit] 6c2570: Clear floats added dynamically to previous siblings
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c2570b4a4d2472445444323e37741fc45e90904 https://github.com/WebKit/WebKit/commit/6c2570b4a4d2472445444323e37741fc45e90904 Author: Ahmad Saleem Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: A LayoutTests/fast/block/margin-collapse/clear-dynamically-added-float-expected.txt A LayoutTests/fast/block/margin-collapse/clear-dynamically-added-float.html M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- Clear floats added dynamically to previous siblings Clear floats added dynamically to previous siblings https://bugs.webkit.org/show_bug.cgi?id=247237 Reviewed by Alan Baradlay. This patch is to align Webkit behavior with Blink / Chrome and Gecko / Firefox. Merge - https://chromium.googlesource.com/chromium/src.git/+/c75a8e71e60527400e95d0834f4a07a018087130 If margin collapsing moves a child up into a previous sibling, we shouldn't add any floats that it may have cleared and prompt another layout so that the child can also clear them if necessary. Confining the need for a layout to cases where the self-collapsing block has margin excludes the more obvious case where a sibling has a lot of negative margin and moves up into a sibling with nested floats inside. * Source/WebCore/rendering/RenderBlockFlow: (RenderBlockFlow::collapseMarginsWithChildInfo): Remove "clearanceForSelfCollapsingBlock" and conditions and update comment as needed * LayoutTests/fast/block/margin-collapse/clear-dynamically-added-float.html: Added Test Case * LayoutTests/fast/block/margin-collapse/clear-dynamically-added-float-expected.txt: Added Test Case Expectations Canonical link: https://commits.webkit.org/256238@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f821c: Add Harrison Weinerman to contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f821cc18076020b4173a57a839881d2253b931e https://github.com/WebKit/WebKit/commit/6f821cc18076020b4173a57a839881d2253b931e Author: Harrison Weinerman Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M metadata/contributors.json Log Message: --- Add Harrison Weinerman to contributors.json https://bugs.webkit.org/show_bug.cgi?id=247353 Reviewed by Jonathan Bedard. Add myself to contributors.json for STP integration. * metadata/contributors.json: Canonical link: https://commits.webkit.org/256237@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 33e4db: Use sandbox API to set sandbox state variable
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33e4db9b9000eca11e9f6e6d8eecaadd39068065 https://github.com/WebKit/WebKit/commit/33e4db9b9000eca11e9f6e6d8eecaadd39068065 Author: Per Arne Vollan Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/Scripts/process-entitlements.sh M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Use sandbox API to set sandbox state variable https://bugs.webkit.org/show_bug.cgi?id=247281 rdar://101772011 Reviewed by Sihui Liu. Use sandbox API to set sandbox state variable instead of relying on reading a preference value. * Source/WebKit/Scripts/process-entitlements.sh: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/256236@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6d8e30: Remove _WKWebsiteDataStore.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6d8e30b8cba306f569fb1b127e1a2e2415fcf9cc https://github.com/WebKit/WebKit/commit/6d8e30b8cba306f569fb1b127e1a2e2415fcf9cc Author: Sihui Liu Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: R Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Remove _WKWebsiteDataStore.h https://bugs.webkit.org/show_bug.cgi?id=247282 rdar://101772089 Remove the header now as rdar://100200032 is resolved. Reviewed by Per Arne Vollan. * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.h: Removed. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/256235@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 56c573: module loader fetch should queue macro-task
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 56c57359f47b7e84c11150fcb8e5d4ac1be0b175 https://github.com/WebKit/WebKit/commit/56c57359f47b7e84c11150fcb8e5d4ac1be0b175 Author: Yusuke Suzuki Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/delay-load-event-expected.txt M LayoutTests/platform/mac/TestExpectations M Source/WebCore/bindings/js/ScriptModuleLoader.cpp Log Message: --- module loader fetch should queue macro-task https://bugs.webkit.org/show_bug.cgi?id=246355 rdar://101044632 Reviewed by Mark Lam and Alexey Shvayka. Since module loader is using `fetch` internally in the spec, every fetch should be resolved via macro-task. This patch does it via context.eventLoop().queueTask to fix flaky import-maps tests. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/delay-load-event-expected.txt: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/bindings/js/ScriptModuleLoader.cpp: (WebCore::rejectToPropagateNetworkError): (WebCore::rejectWithFetchError): (WebCore::ScriptModuleLoader::fetch): (WebCore::rejectPromise): (WebCore::ScriptModuleLoader::importModule): (WebCore::ScriptModuleLoader::notifyFinished): Canonical link: https://commits.webkit.org/256234@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 628f0b: Missing undef MESSAGE_CHECK in WebFrameProxy.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 628f0ba433d8d0d7c9eaffca7649267fe030dd86 https://github.com/WebKit/WebKit/commit/628f0ba433d8d0d7c9eaffca7649267fe030dd86 Author: Przemyslaw Gorszkowski Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/UIProcess/WebFrameProxy.cpp Log Message: --- Missing undef MESSAGE_CHECK in WebFrameProxy.cpp https://bugs.webkit.org/show_bug.cgi?id=247362 Reviewed by Carlos Garcia Campos. Add missing #undef MESSAGE_CHECK at the end of the cpp file solves the problem with errors in unified builds. * Source/WebKit/UIProcess/WebFrameProxy.cpp: Canonical link: https://commits.webkit.org/256233@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.11.5 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f78f05: Versioning.
Branch: refs/heads/safari-7615.1.11-branch Home: https://github.com/WebKit/WebKit Commit: f78f055014aef87558de81c463a953a956423923 https://github.com/WebKit/WebKit/commit/f78f055014aef87558de81c463a953a956423923 Author: Kocsen Chung Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.11.5 Canonical link: https://commits.webkit.org/255891.10@safari-7615.1.11-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d05ba: [GTK] Handle files being disallowed in DragDataGtk...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d05bac8d326001e57a518b42ae7ad3eafb2c186 https://github.com/WebKit/WebKit/commit/0d05bac8d326001e57a518b42ae7ad3eafb2c186 Author: Carlos Garcia Campos Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/platform/gtk/DragDataGtk.cpp Log Message: --- [GTK] Handle files being disallowed in DragDataGtk after 254380@main https://bugs.webkit.org/show_bug.cgi?id=247359 Reviewed by Michael Catanzaro. We need to do the same changes done in 254380@main for DragDataGtk. * Source/WebCore/platform/gtk/DragDataGtk.cpp: (WebCore::DragData::containsFiles const): (WebCore::DragData::numberOfFiles const): (WebCore::DragData::asFilenames const): Canonical link: https://commits.webkit.org/256232@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22987c: [WK2] Further simplify ArgumentCoder decoding for ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22987c3dcd7be882ad32ee1a0920e35137a6eadc https://github.com/WebKit/WebKit/commit/22987c3dcd7be882ad32ee1a0920e35137a6eadc Author: Žan Doberšek Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebKit/Platform/IPC/ArgumentCoders.h Log Message: --- [WK2] Further simplify ArgumentCoder decoding for std::tuple<>, std::array<> https://bugs.webkit.org/show_bug.cgi?id=247227 Reviewed by Kimmo Kinnunen. Have the std::tuple<> decoding in ArgumentCoders.h avoid constructing tuples of forwarding references by instead passing the rvalue references to the decoded elements through a parameter pack. Recursion is still used, and the rvalue references are passed on until the size of the parameter pack matches the size of the tuple, at which point said tuple is constructed and returned as the result of the decoding. Identical approach is adopted for the std::array<> decoder. The change incorporates a MSCV++ workaround for a compiler bug which breaks builds due to the constexpr if-statement checking the current index against the number of the already-decoded elements. Workaround moves the result of this check into a separate constexpr boolean. Tracking is set up in bug #247226. * Source/WebKit/Platform/IPC/ArgumentCoders.h: Canonical link: https://commits.webkit.org/256231@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 91bc63: Align CSSOMVariableReferenceValue serialization wi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91bc6304bed238314f758e732e8f45e4c63c1eec https://github.com/WebKit/WebKit/commit/91bc6304bed238314f758e732e8f45e4c63c1eec Author: Chris Dumez Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssUnparsedValue-expected.txt M Source/WebCore/css/typedom/CSSOMVariableReferenceValue.cpp Log Message: --- Align CSSOMVariableReferenceValue serialization with Blink https://bugs.webkit.org/show_bug.cgi?id=247202 Reviewed by Antti Koivisto. Align CSSOMVariableReferenceValue serialization with Blink and to match what WPT tests expect. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssUnparsedValue-expected.txt: * Source/WebCore/css/typedom/CSSOMVariableReferenceValue.cpp: (WebCore::CSSOMVariableReferenceValue::serialize const): Canonical link: https://commits.webkit.org/256230@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e3531: Implement input validation for CSSColorValues
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e3531dd8b179697e87ed54b0a601b4f4118629b https://github.com/WebKit/WebKit/commit/4e3531dd8b179697e87ed54b0a601b4f4118629b Author: Chris Dumez Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/resources/testhelper.js M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHWB-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHWB.html A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLCH-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLCH.html A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLab-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLab.html A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLCH-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLCH.html A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLab-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLab.html M Source/WebCore/css/typedom/color/CSSColorValue.cpp M Source/WebCore/css/typedom/color/CSSColorValue.h M Source/WebCore/css/typedom/color/CSSHSL.cpp M Source/WebCore/css/typedom/color/CSSHSL.h M Source/WebCore/css/typedom/color/CSSHWB.cpp M Source/WebCore/css/typedom/color/CSSHWB.h M Source/WebCore/css/typedom/color/CSSLCH.cpp M Source/WebCore/css/typedom/color/CSSLCH.h M Source/WebCore/css/typedom/color/CSSLab.cpp M Source/WebCore/css/typedom/color/CSSLab.h M Source/WebCore/css/typedom/color/CSSOKLCH.cpp M Source/WebCore/css/typedom/color/CSSOKLCH.h M Source/WebCore/css/typedom/color/CSSOKLab.cpp M Source/WebCore/css/typedom/color/CSSOKLab.h M Source/WebCore/css/typedom/color/CSSRGB.h Log Message: --- Implement input validation for CSSColorValues https://bugs.webkit.org/show_bug.cgi?id=247167 Reviewed by Antti Koivisto. Implement input validation for CSSColorValues: - https://drafts.css-houdini.org/css-typed-om/#csshsl - https://drafts.css-houdini.org/css-typed-om/#csshwb - https://drafts.css-houdini.org/css-typed-om/#csslab - https://drafts.css-houdini.org/css-typed-om/#csslch - https://drafts.css-houdini.org/css-typed-om/#cssoklab - https://drafts.css-houdini.org/css-typed-om/#cssoklch * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/resources/testhelper.js: (assert_color_channel_approx_equals): * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHWB-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHWB.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLCH-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLCH.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLab-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLab.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLCH-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLCH.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLab-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLab.html: Added. * Source/WebCore/css/typedom/color/CSSColorValue.cpp: (WebCore::CSSColorValue::rectifyCSSColorAngle): (WebCore::CSSColorValue::rectifyCSSColorNumber): (WebCore::CSSColorValue::toCSSColorPercent): (WebCore::CSSColorValue::toCSSColorAngle): (WebCore::CSSColorValue::toCSSColorNumber): * Source/WebCore/css/typedom/color/CSSColorValue.h: * Source/WebCore/css/typedom/color/CSSHSL.cpp: (WebCore::CSSHSL::create): (WebCore::CSSHSL::CSSHSL): (WebCore::CSSHSL::h const): (WebCore::CSSHSL::setH): (WebCore::CSSHSL::s const): (WebCore::CSSHSL::setS): (WebCore::CSSHSL::l const): (WebCore::CSSHSL::setL):
[webkit-changes] [WebKit/WebKit] fd2b5b: Fix CSSStyleValue.parse() / parseAll() for shortha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd2b5bf98a6eef3c49c4d4cc9647eba431812b00 https://github.com/WebKit/WebKit/commit/fd2b5bf98a6eef3c49c4d4cc9647eba431812b00 Author: Chris Dumez Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parse.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-string-expected.txt M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp M Source/WebCore/css/typedom/CSSStyleValueFactory.h M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp Log Message: --- Fix CSSStyleValue.parse() / parseAll() for shorthand CSS properties https://bugs.webkit.org/show_bug.cgi?id=247205 Reviewed by Antti Koivisto. Fix CSSStyleValue.parse() / parseAll() for shorthand CSS properties: - https://drafts.css-houdini.org/css-typed-om/#dom-cssstylevalue-parse - https://drafts.css-houdini.org/css-typed-om/#dom-cssstylevalue-parseall * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parse.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-string-expected.txt: * Source/WebCore/css/typedom/CSSStyleValueFactory.cpp: (WebCore::CSSStyleValueFactory::extractShorthandCSSValues): (WebCore::CSSStyleValueFactory::parseStyleValue): * Source/WebCore/css/typedom/CSSStyleValueFactory.h: * Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp: (WebCore::MainThreadStylePropertyMapReadOnly::shorthandPropertyValue const): Canonical link: https://commits.webkit.org/256228@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4153d: Undo unrelated change that added an unneeded include
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4153dffcbf5c1c1b7f1031d7aa4099c76597e90 https://github.com/WebKit/WebKit/commit/b4153dffcbf5c1c1b7f1031d7aa4099c76597e90 Author: Tim Nguyen Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp Log Message: --- Undo unrelated change that added an unneeded include https://bugs.webkit.org/show_bug.cgi?id=247349 rdar://101600873 Unreviewed follow up. * Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp: Canonical link: https://commits.webkit.org/256227@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7bab9: Add temporary backdrop workaround for fullscreen e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7bab9d6f7c45b99da17d78a464eac1fedff0ead https://github.com/WebKit/WebKit/commit/d7bab9d6f7c45b99da17d78a464eac1fedff0ead Author: Tim Nguyen Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/css/CSSSelector.cpp M Source/WebCore/css/CSSSelector.h M Source/WebCore/css/SelectorChecker.cpp M Source/WebCore/css/SelectorCheckerTestFunctions.h M Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in M Source/WebCore/css/fullscreen.css M Source/WebCore/cssjit/SelectorCompiler.cpp M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp Log Message: --- Add temporary backdrop workaround for fullscreen elements https://bugs.webkit.org/show_bug.cgi?id=247349 rdar://101600873 Reviewed by Tim Horton. Removing RenderFullScreen introduced a regression, where content appears behind the fullscreen element. RenderFullScreen used to solve that by wrapping the fullscreen element renderer with a renderer that has a black background. The standard way of solving this issue is to add a ::backdrop that has such a background. This will be done once fullscreen switches to use the top layer. For now, add a pseudo-class that targets the parent of the fullscreen element, and use ::before to emulate the ::backdrop. We specifically pick the parent, because it is guaranteed to be able to contain children (and ::before), and to avoid conflict with any potential ::before on the fullscreen element itself. * Source/WebCore/css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText const): * Source/WebCore/css/CSSSelector.h: * Source/WebCore/css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): * Source/WebCore/css/SelectorCheckerTestFunctions.h: (WebCore::matchesFullScreenParentPseudoClass): * Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in: * Source/WebCore/css/fullscreen.css: (:-webkit-full-screen-parent::before): * Source/WebCore/cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION): (WebCore::SelectorCompiler::addPseudoClassType): * Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp: Canonical link: https://commits.webkit.org/256226@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5adbc7: [GStreamer][WebRTC] Media rendering improvements
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5adbc713768c2e828b5995ef72fef9d21b10f6fb https://github.com/WebKit/WebKit/commit/5adbc713768c2e828b5995ef72fef9d21b10f6fb Author: Philippe Normand Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][WebRTC] Media rendering improvements https://bugs.webkit.org/show_bug.cgi?id=247319 Reviewed by Xabier Rodriguez-Calvar. The main one is that clock synchronization no longer happens on incoming sources, this is not needed because the renderer pipeline is separate and they can't synchronize on the system clock either. So before this patch the clock sync on the first pipeline was artificially limiting the playback on the renderer pipeline. Additionally the player no longer configures the pipeline for buffering or doing useless duration queries when playing mediastreams. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::seek): (WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate): (WebCore::MediaPlayerPrivateGStreamer::setPreload): (WebCore::MediaPlayerPrivateGStreamer::maxMediaTimeSeekable const): (WebCore::MediaPlayerPrivateGStreamer::totalBytes const): (WebCore::MediaPlayerPrivateGStreamer::platformDuration const): (WebCore::MediaPlayerPrivateGStreamer::isMediaStreamPlayer const): (WebCore::MediaPlayerPrivateGStreamer::configureElement): (WebCore::setPlaybackFlags): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): (WebCore::MediaPlayerPrivateGStreamer::configureDepayloader): (WebCore::MediaPlayerPrivateGStreamer::configureVideoDecoder): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp: (WebCore::RealtimeIncomingAudioSourceGStreamer::dispatchSample): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp: (WebCore::RealtimeIncomingSourceGStreamer::registerClient): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp: (WebCore::RealtimeIncomingVideoSourceGStreamer::dispatchSample): Canonical link: https://commits.webkit.org/256225@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e5e73c: [MSE] Bring back some useful SourceBuffer logs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e5e73c6cc13de7853fde82bf4db544153af1eb7f https://github.com/WebKit/WebKit/commit/e5e73c6cc13de7853fde82bf4db544153af1eb7f Author: Enrique Ocaña González Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/Modules/mediasource/SourceBuffer.cpp Log Message: --- [MSE] Bring back some useful SourceBuffer logs https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line https://github.com/WebKit/WebKit/commit/cd4e7ebee1a6aaa956534cb8709d95ec2c75b85a#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a10c81: Style and performance tweaks to CSS property name ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a10c81dcc8fb22521e0999dc7e119a94c92c7520 https://github.com/WebKit/WebKit/commit/a10c81dcc8fb22521e0999dc7e119a94c92c7520 Author: Darin Adler Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/animation/CSSTransition.cpp M Source/WebCore/animation/CSSTransition.h M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/css/CSSBackgroundRepeatValue.cpp M Source/WebCore/css/CSSComputedStyleDeclaration.cpp M Source/WebCore/css/CSSCustomPropertyValue.cpp M Source/WebCore/css/CSSFunctionValue.cpp M Source/WebCore/css/CSSGridAutoRepeatValue.cpp M Source/WebCore/css/CSSPrimitiveValue.cpp M Source/WebCore/css/CSSStyleDeclaration.cpp M Source/WebCore/css/CSSValuePool.cpp M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/DOMCSSNamespace.cpp M Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp M Source/WebCore/css/PropertySetCSSStyleDeclaration.h M Source/WebCore/css/StyleColor.cpp M Source/WebCore/css/StyleProperties.cpp M Source/WebCore/css/makeprop.pl M Source/WebCore/css/makevalues.pl M Source/WebCore/css/parser/CSSParserFastPaths.cpp M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp M Source/WebCore/css/typedom/StylePropertyMap.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/html/CustomPaintImage.cpp M Source/WebCore/inspector/InspectorStyleSheet.cpp M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp M Source/WebCore/inspector/agents/InspectorCSSAgent.cpp M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp M Source/WebCore/platform/HashTools.h M Source/WebCore/platform/animation/Animation.cpp M Source/WebCore/rendering/style/RenderStyleConstants.cpp M Source/WebCore/style/PropertyCascade.cpp M Source/WebCore/style/StyleBuilderCustom.h Log Message: --- Style and performance tweaks to CSS property name and keyword value tables https://bugs.webkit.org/show_bug.cgi?id=247244 rdar://101730654 Reviewed by Sam Weinig. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Use nameLiteral, numCSSPRoperties instead of lastCSSProperty, and allCSSProperties. * Source/WebCore/animation/CSSTransition.cpp: (WebCore::CSSTransition::createEvent): Use nameString. * Source/WebCore/animation/CSSTransition.h: Use const AtomString& for the return value of transitionProperty to cut down on reference count churn. Use nameString, moved isCSSTransition to private. * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::CSSPropertyIDToIDLAttributeName): Use nameForIDL. (WebCore::processKeyframeLikeObject): Use isExposed. * Source/WebCore/css/CSSBackgroundRepeatValue.cpp: (WebCore::CSSBackgroundRepeatValue::customCSSText const): Use nameString. * Source/WebCore/css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::item const): Ditto. * Source/WebCore/css/CSSCustomPropertyValue.cpp: (WebCore::CSSCustomPropertyValue::customCSSText const): Ditto. * Source/WebCore/css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::customCSSText const): Use nameLiteral. * Source/WebCore/css/CSSGridAutoRepeatValue.cpp: (WebCore::CSSGridAutoRepeatValue::customCSSText const): Ditto. * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::propertyName): Deleted. (WebCore::valueName): Deleted. (WebCore::CSSPrimitiveValue::stringValue const): Use nameString. (WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const): Ditto. (WebCore::CSSPrimitiveValue::equals const): Compare property and value IDs rather than converting to strings and comparing the strings. * Source/WebCore/css/CSSStyleDeclaration.cpp: (WebCore::parseJavaScriptCSSPropertyName): Use AtomString for the map keys for better performance. Don't add a trailing NUL character, since it's not required any more. Use findCSSProperty. (WebCore::lookupCSSPropertyFromIDLAttribute): Don't add a trailing NUL character since it's not required any more. Use findCSSProperty. (WebCore::CSSStyleDeclaration::getCSSPropertyIDFromJavaScriptPropertyName): Merged propertyIDFromJavaScriptCSSPropertyName in here, we don't need two separate functions. Use isExposed. * Source/WebCore/css/CSSValuePool.cpp: (WebCore::StaticCSSValuePool::StaticCSSValuePool): Use allCSSValueKeywords. (WebCore::CSSValuePool::createIdentifierValue): Do the assertion without using firstCSSValueKeyword and lastCSSValueKeyword. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::createTransitionPropertyValue): Use nameString.
[webkit-changes] [WebKit/WebKit] b84521: [MSE][GStreamer] Relax h264/h265 codec check for MSE
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b84521e66dedfbd7f984017dee3f5a7a8191b165 https://github.com/WebKit/WebKit/commit/b84521e66dedfbd7f984017dee3f5a7a8191b165 Author: Enrique Ocaña González Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp Log Message: --- [MSE][GStreamer] Relax h264/h265 codec check for MSE https://bugs.webkit.org/show_bug.cgi?id=247129 Reviewed by Alicia Boya Garcia. Some platforms disable/remove software parsers because of the way encrypted playback is implemented, but we still want working MSE playback there. Although software parsers are strongly recommended for MSE playback (eg: to complete info from buffers coming from some js transmuxers), they aren't strictly needed (at your own risk!). However, some video decoders (eg: the OMX h264 decoder) can only accept some of the available formats (only stream-format=byte-stream in the case of OMX). In that case, a parser is still needed in order to convert between formats before supplying buffers to the decoder. This patch checks that the most efficient decoder (hardware if available, software if not) supports both formats. If the most efficient decoder doesn't support all the formats, a parser is demanded to be available. If it's not available, the affected codec (h264, h265) is declared as not supported. Inspired by work by Eugene Mutavchi See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/948 * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::initializeDecoders): Ask for the corresponding parser if any of the h264 or h265 decoders support don't support any of the possible stream-format variants. If the parser isn't present, declare the corresponding codec as unsupported. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h: (WebCore::GStreamerRegistryScanner::RegistryLookupResult::merge): Added method to merge two results, supported when both are supported, and using hardware when both are using hardware. (WebCore::GStreamerRegistryScanner::RegistryLookupResult::operator==): Added equality operator. (WebCore::GStreamerRegistryScanner::RegistryLookupResult::operator!=): Added inequality operator. * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::createOptionalParserForFormat): Warn when a parser can't be created. Canonical link: https://commits.webkit.org/256222@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0b0af: Merge 253241@main - Punycode a few more Canadian A...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: f0b0aff41c738bb6dc7c72a07f8674d1d8d29941 https://github.com/WebKit/WebKit/commit/f0b0aff41c738bb6dc7c72a07f8674d1d8d29941 Author: Alex Christensen Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WTF/wtf/URLHelpers.cpp M Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm Log Message: --- Merge 253241@main - Punycode a few more Canadian Aboriginal syllabics characters when mixed with Latin characters https://bugs.webkit.org/show_bug.cgi?id=243693 rdar://98135919 Reviewed by Tim Horton. * Source/WTF/wtf/URLHelpers.cpp: (WTF::URLHelpers::isLookalikeCharacterOfScriptType): * Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/253241@main (cherry picked from commit b64fbc1b4bf78392372c53d1fda02f21af13b8f5) Commit: f26e2fc505b3f1695d9e7f94aeb0cb4a78a112cf https://github.com/WebKit/WebKit/commit/f26e2fc505b3f1695d9e7f94aeb0cb4a78a112cf Author: Patrick Angle Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/JavaScriptCore/inspector/InjectedScriptSource.js Log Message: --- Merge 254055@main - Web Inspector: Use more guaranteed built-ins in Inspector Injected Script https://bugs.webkit.org/show_bug.cgi?id=244622 rdar://98270447 Reviewed by Devin Rousso. Followup work done in 250474@main by using a prototypeless base for `RemoteObject`, `InjectedScript`, and `CallFrameProxy`. * Source/JavaScriptCore/inspector/InjectedScriptSource.js: (PrototypelessObjectBase): (let.InjectedScript): (let.RemoteObject): (InjectedScript.CallFrameProxy): Canonical link: https://commits.webkit.org/254055@main (cherry picked from commit ac0d3d8d8e0f5829e8384dc705f680cfe09f7e71) Commit: 661e97999a4be0fba63b33c332598915c92a5adb https://github.com/WebKit/WebKit/commit/661e97999a4be0fba63b33c332598915c92a5adb Author: Wenson Hsieh Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/dom/DataTransfer.cpp M Source/WebCore/dom/DataTransfer.h M Source/WebCore/page/DragController.cpp M Source/WebCore/page/DragController.h M Source/WebCore/page/DragState.h M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/EventHandler.h M Source/WebCore/page/SecurityOrigin.cpp M Source/WebCore/platform/DragData.cpp M Source/WebCore/platform/DragData.h M Source/WebCore/platform/cocoa/DragDataCocoa.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKitLegacy/mac/WebView/WebView.mm M Source/WebKitLegacy/win/WebView.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm Log Message: --- Merge 254380@main - Refactor some image drag and drop codepaths https://bugs.webkit.org/show_bug.cgi?id=245058 rdar://98992054 Reviewed by Ryosuke Niwa. Refactor some codepaths related to dragging and dropping images. * Source/WebCore/dom/DataTransfer.cpp: (WebCore::DataTransfer::types const): (WebCore::DataTransfer::filesFromPasteboardAndItemList const): * Source/WebCore/dom/DataTransfer.h: (WebCore::DataTransfer::allowsFileAccess const): * Source/WebCore/page/DragController.cpp: (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDragOperation): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::disallowFileAccessIfNeeded): * Source/WebCore/page/DragController.h: * Source/WebCore/page/DragState.h: * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::canDropCurrentlyDraggedImageAsFile const): (WebCore::EventHandler::handleDrag): * Source/WebCore/page/EventHandler.h: * Source/WebCore/page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canReceiveDragData const): * Source/WebCore/platform/DragData.cpp: (WebCore::DragData::disallowFileAccess): * Source/WebCore/platform/DragData.h: * Source/WebCore/platform/cocoa/DragDataCocoa.mm: (WebCore::DragData::containsFiles const): (WebCore::DragData::numberOfFiles const): (WebCore::DragData::asFilenames const): (WebCore::DragData::containsCompatibleContent const): (WebCore::DragData::containsPromise const): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView _enteredDataInteraction:client:global:operation:]): (-[WebView _updatedDataInteraction:client:global:operation:]): (-[WebView _exitedDataInteraction:client:global:operation:]): (-[WebView _tryToPerformDataInteraction:client:global:operation:]): (-[WebView draggingEntered:]): (-[WebView draggingUpdated:]): (-[WebView draggingExited:]): (-[WebView performDragOperation:]): * Source/WebKitLegacy/win/WebView.cpp: (WebView::DragEnter): (WebView::DragOver):
[webkit-changes] [WebKit/WebKit] 094201: Code style does not allow currently used member fu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09420100638c9d074649a4daf209af15b5731eae https://github.com/WebKit/WebKit/commit/09420100638c9d074649a4daf209af15b5731eae Author: Kimmo Kinnunen Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Websites/webkit.org/code-style.md Log Message: --- Code style does not allow currently used member function explanation comments for vfuncs, ipc messages https://bugs.webkit.org/show_bug.cgi?id=247313 rdar://problem/101801434 Reviewed by Ryosuke Niwa and Darin Adler. Allow the non-english sentence comments that do not end in a dot: // SomeBaseClassName and // Messages * Websites/webkit.org/code-style.md: Canonical link: https://commits.webkit.org/256221@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 64b55a: [Nicosia] AsyncScrolling: use accessCommitted inst...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 64b55a4086d73ac3d3b606699e3c851cfa70fd44 https://github.com/WebKit/WebKit/commit/64b55a4086d73ac3d3b606699e3c851cfa70fd44 Author: Carlos Garcia Campos Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp Log Message: --- [Nicosia] AsyncScrolling: use accessCommitted instead of accessPending when collecting layers for hit testing https://bugs.webkit.org/show_bug.cgi?id=247182 Reviewed by Žan Doberšek. We are currently using accessPending when collecting layers and accessCommitted when iterating the collected layers. * Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp: (WebCore::collectDescendantLayersAtPoint): Canonical link: https://commits.webkit.org/256220@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c1497: [Nicosia] Remove CoordinatedGraphicsState
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c14974c54ee05182a690f3c2d44c4b936b84ec4 https://github.com/WebKit/WebKit/commit/1c14974c54ee05182a690f3c2d44c4b936b84ec4 Author: Carlos Garcia Campos Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/platform/TextureMapper.cmake M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h R Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h M Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp M Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h Log Message: --- [Nicosia] Remove CoordinatedGraphicsState https://bugs.webkit.org/show_bug.cgi?id=247189 Reviewed by Žan Doberšek. It's just wrapping a RefPtr>, so we can use the scene directly everywhere instead. * Source/WebCore/platform/TextureMapper.cmake: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h: Removed. * Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: (WebKit::CoordinatedGraphicsScene::applyStateChanges): (WebKit::CoordinatedGraphicsScene::commitSceneState): * Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h: * Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp: (WebKit::ThreadedCompositor::renderLayerTree): (WebKit::ThreadedCompositor::updateSceneState): (WebKit::ThreadedCompositor::updateSceneWithoutRendering): * Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: (WebKit::CompositingCoordinator::CompositingCoordinator): (WebKit::CompositingCoordinator::flushPendingLayerChanges): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp: (WebKit::LayerTreeHost::commitSceneState): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: Canonical link: https://commits.webkit.org/256219@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26fabf: [GLIB] Gardening, update baselines
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26fabf17e39cf177e5ddf7cf36c9d4cbc1ee713b https://github.com/WebKit/WebKit/commit/26fabf17e39cf177e5ddf7cf36c9d4cbc1ee713b Author: Diego Pino Garcia Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M LayoutTests/platform/glib/fast/clip/outline-overflowClip-expected.txt M LayoutTests/platform/glib/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt M LayoutTests/platform/glib/fast/text/international/hindi-spacing-expected.txt M LayoutTests/platform/glib/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png M LayoutTests/platform/glib/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt M LayoutTests/platform/glib/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt M LayoutTests/platform/glib/mathml/opentype/opentype-stretchy-expected.txt M LayoutTests/platform/gtk/fast/block/float/editable-text-overlapping-float-expected.txt M LayoutTests/platform/gtk/fast/block/lineboxcontain/font-replaced-expected.png M LayoutTests/platform/gtk/fast/block/lineboxcontain/font-replaced-expected.txt M LayoutTests/platform/gtk/fast/block/lineboxcontain/glyphs-expected.png M LayoutTests/platform/gtk/fast/block/lineboxcontain/glyphs-expected.txt M LayoutTests/platform/gtk/fast/block/lineboxcontain/inline-box-expected.png M LayoutTests/platform/gtk/fast/block/lineboxcontain/inline-box-expected.txt M LayoutTests/platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.png M LayoutTests/platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.txt M LayoutTests/platform/gtk/fast/clip/outline-overflowClip-expected.png M LayoutTests/platform/gtk/fast/css/focus-ring-multiline-writingmode-vertical-expected.png M LayoutTests/platform/gtk/fast/css/text-overflow-input-expected.png M LayoutTests/platform/gtk/fast/css/text-overflow-input-expected.txt M LayoutTests/platform/gtk/fast/dom/34176-expected.png M LayoutTests/platform/gtk/fast/dom/34176-expected.txt M LayoutTests/platform/gtk/fast/forms/basic-buttons-expected.png M LayoutTests/platform/gtk/fast/forms/basic-buttons-expected.txt M LayoutTests/platform/gtk/fast/forms/button-sizes-expected.png M LayoutTests/platform/gtk/fast/forms/button-sizes-expected.txt M LayoutTests/platform/gtk/fast/forms/button-style-color-expected.png M LayoutTests/platform/gtk/fast/forms/button-style-color-expected.txt M LayoutTests/platform/gtk/fast/forms/input-button-sizes-expected.png M LayoutTests/platform/gtk/fast/forms/input-button-sizes-expected.txt M LayoutTests/platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png M LayoutTests/platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt M LayoutTests/platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png M LayoutTests/platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt M LayoutTests/platform/gtk/fast/forms/placeholder-position-expected.png M LayoutTests/platform/gtk/fast/forms/placeholder-position-expected.txt M LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.png M LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt M LayoutTests/platform/gtk/fast/inline/long-wrapped-line-expected.txt M LayoutTests/platform/gtk/fast/overflow/overflow-rtl-vertical-expected.png M LayoutTests/platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt M LayoutTests/platform/gtk/fast/repaint/4776765-expected.txt M LayoutTests/platform/gtk/fast/repaint/selection-after-delete-expected.png M LayoutTests/platform/gtk/fast/repaint/selection-after-delete-expected.txt M LayoutTests/platform/gtk/fast/repaint/selection-after-remove-expected.png M LayoutTests/platform/gtk/fast/repaint/selection-after-remove-expected.txt M LayoutTests/platform/gtk/fast/text/international/bidi-AN-after-empty-run-expected.png M LayoutTests/platform/gtk/fast/text/international/bidi-AN-after-empty-run-expected.txt M LayoutTests/platform/gtk/fast/text/international/hindi-spacing-expected.png M LayoutTests/platform/gtk/fast/text/international/rtl-caret-expected.png M LayoutTests/platform/gtk/fast/text/international/rtl-caret-expected.txt M LayoutTests/platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.png M LayoutTests/platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt M LayoutTests/platform/gtk/fast/text/trailing-white-space-2-expected.png M LayoutTests/platform/gtk/fast/text/trailing-white-space-2-expected.txt M LayoutTests/platform/gtk/fast/text/trailing-white-space-expected.png M LayoutTests/platform/gtk/fast/text/trailing-white-space-expected.txt M LayoutTests/platform/gtk/mathml/opentype/horizontal-expected.png M
[webkit-changes] [WebKit/WebKit] 63f0fd: [GLIB][GTK] Gardening, remove redundant baselines
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63f0fd5dff4ed725b57f007032f4cea93ca9597b https://github.com/WebKit/WebKit/commit/63f0fd5dff4ed725b57f007032f4cea93ca9597b Author: Diego Pino Garcia Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: R LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/stale-css-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/stale-script-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/samesite-cookies.https-expected.txt R LayoutTests/platform/gtk/fast/repaint/focus-ring-repaint-expected.txt Log Message: --- [GLIB][GTK] Gardening, remove redundant baselines Unreviewed test gardening. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/stale-css-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/stale-script-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/samesite-cookies.https-expected.txt: Removed. * LayoutTests/platform/gtk/fast/repaint/focus-ring-repaint-expected.txt: Removed. Canonical link: https://commits.webkit.org/256217@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0aed33: Experimental features menu is missing checkmarks i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0aed33be4d5e56d2cc994248f6d8c6efa5b95312 https://github.com/WebKit/WebKit/commit/0aed33be4d5e56d2cc994248f6d8c6efa5b95312 Author: Tim Horton Date: 2022-11-01 (Tue, 01 Nov 2022) Changed paths: M Tools/MiniBrowser/mac/SettingsController.m Log Message: --- Experimental features menu is missing checkmarks in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=247356 Unreviewed follow-up fix. * Tools/MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu:]): Canonical link: https://commits.webkit.org/256216@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 091a04: RenderElement::updateFillImages should take pointe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 091a04e55c801ac6ba13f4b328fbee2eece853fc https://github.com/WebKit/WebKit/commit/091a04e55c801ac6ba13f4b328fbee2eece853fc Author: Antti Koivisto Date: 2022-11-01 (Tue, 01 Nov 2022) Changed paths: M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h Log Message: --- RenderElement::updateFillImages should take pointer arguments like other similar functions https://bugs.webkit.org/show_bug.cgi?id=247317 rdar://100273147 Reviewed by Alan Baradlay. * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::updateFillImages): (WebCore::RenderElement::styleDidChange): * Source/WebCore/rendering/RenderElement.h: Canonical link: https://commits.webkit.org/256215@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 70690d: [GLIB] Gardening, update baselines after 256073@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 70690d5f132ea7c2f1ccfcefe0ae5bb1b8285d46 https://github.com/WebKit/WebKit/commit/70690d5f132ea7c2f1ccfcefe0ae5bb1b8285d46 Author: Diego Pino Garcia Date: 2022-11-01 (Tue, 01 Nov 2022) Changed paths: M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-image-interpolation-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-source-interpolation-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-image-source-computed.sub-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-lists/animations/list-style-image-interpolation-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-image-computed.sub-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-image-interpolation-expected.txt Log Message: --- [GLIB] Gardening, update baselines after 256073@main Unreviewed test gardening. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-image-interpolation-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-source-interpolation-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-image-source-computed.sub-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-lists/animations/list-style-image-interpolation-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-image-computed.sub-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-image-interpolation-expected.txt: Canonical link: https://commits.webkit.org/256214@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
