[webkit-changes] [WebKit/WebKit] 443de8: @font-face src must serialize specified URLs, not ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 443de8e8e9716b164f0a25da35e9235efd72d4dd https://github.com/WebKit/WebKit/commit/443de8e8e9716b164f0a25da35e9235efd72d4dd Author: Darin Adler Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M LayoutTests/fast/css/font-face-src-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-family-src-quoted-expected.txt M Source/WebCore/css/CSSFontFace.cpp M Source/WebCore/css/CSSFontFaceSet.cpp M Source/WebCore/css/CSSFontFaceSet.h M Source/WebCore/css/CSSFontFaceSource.cpp M Source/WebCore/css/CSSFontFaceSource.h M Source/WebCore/css/CSSFontFaceSrcValue.cpp M Source/WebCore/css/CSSFontFaceSrcValue.h M Source/WebCore/css/CSSMarkup.cpp M Source/WebCore/css/CSSValue.cpp M Source/WebCore/css/CSSValue.h M Source/WebCore/css/FontFace.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp M Source/WebCore/css/parser/CSSTokenizer.cpp M Source/WebCore/css/parser/CSSTokenizer.h M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/ScriptExecutionContext.cpp M Source/WebCore/dom/ScriptExecutionContext.h M Source/WebCore/loader/FontLoadRequest.h M Source/WebCore/loader/cache/CachedFont.cpp M Source/WebCore/loader/cache/CachedFont.h M Source/WebCore/loader/cache/CachedFontLoadRequest.h M Source/WebCore/loader/cache/CachedSVGFont.cpp M Source/WebCore/loader/cache/CachedSVGFont.h M Source/WebCore/svg/SVGFontFaceElement.cpp M Source/WebCore/svg/SVGFontFaceNameElement.cpp M Source/WebCore/svg/SVGFontFaceNameElement.h M Source/WebCore/svg/SVGFontFaceSrcElement.cpp M Source/WebCore/svg/SVGFontFaceSrcElement.h M Source/WebCore/svg/SVGFontFaceUriElement.cpp M Source/WebCore/svg/SVGFontFaceUriElement.h M Source/WebCore/workers/WorkerFontLoadRequest.cpp M Source/WebCore/workers/WorkerFontLoadRequest.h M Source/WebCore/workers/WorkerGlobalScope.cpp M Source/WebCore/workers/WorkerGlobalScope.h Log Message: --- @font-face src must serialize specified URLs, not URLs resolved against the base https://bugs.webkit.org/show_bug.cgi?id=247547 rdar://problem/102012585 Reviewed by Sam Weinig. * LayoutTests/fast/css/font-face-src-parsing-expected.txt: Updated to expect successful parsing of all the values for src. The old code expected some to be skipped, and they are not skipped any more. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-family-src-quoted-expected.txt: Expect PASS. * Source/WebCore/css/CSSFontFace.cpp: (WebCore::CSSFontFace::appendSources): Updated since CSSFontFaceSrcLocalValue and CSSFontFaceSrcResourceValue are now two separate classes and CSSFontFaceSource gets the URL from the FontLoadRequest rather than taking a separate URL argument. * Source/WebCore/css/CSSFontFaceSet.cpp: (WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered): Take AtomString. (WebCore::CSSFontFaceSet::addToFacesLookupTable): Use AtomString. * Source/WebCore/css/CSSFontFaceSet.h: Updated for above. * Source/WebCore/css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::CSSFontFaceSource): Updated the argument name since this now takes only a font face name, not a URL. Also, a font face name is *not* the same thing as a family name, so don't call it a family name. Change argument types for things we take ownership of to the appropriate owning type: AtomString and UniqueRef. (WebCore::CSSFontFaceSource::opportunisticallyStartFontDataURLLoading): Check the length of URL from the font request itself to decide if it's short enough, rather than using m_familyNameOrURI. (WebCore::CSSFontFaceSource::fontLoaded): Removed the argument from ensureCustomFontData. We don't need to pass the URL back to the object which supplied the URL in the first place. (WebCore::CSSFontFaceSource::load): Updated for the name change of m_fontFaceName. (WebCore::CSSFontFaceSource::font): Ditto. Also removed the argument from ensureCustomFontData and createFont. * Source/WebCore/css/CSSFontFaceSource.h: Changed the constructors: We don’t need to pass in a URL along with a FontLoadRequest, which contains the URL. The font face name is not the same thing as a family name, so let's not call it that. Change argument types for things we take ownership of to the appropriate owning type: AtomString and UniqueRef. There is not font face name or URL when creating from an ArrayBufferView, so don't require the caller to pass a null one in. Removed the familyNameOrURI function, which was unneeded. Replaced m_familyNameOrURI with m_fontFaceName. Made m_fontRequest const to emphasize it's never changed after construction. *
[webkit-changes] [WebKit/WebKit] db8f8f: [WinCairo][MiniBrowser] Add menu items to clear Co...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db8f8f7b140e16f97ff0fd0e38caeab7b695415a https://github.com/WebKit/WebKit/commit/db8f8f7b140e16f97ff0fd0e38caeab7b695415a Author: Kenji Shukuwa Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M Tools/MiniBrowser/win/BrowserWindow.h M Tools/MiniBrowser/win/MainWindow.cpp M Tools/MiniBrowser/win/MiniBrowserLib.rc M Tools/MiniBrowser/win/MiniBrowserLibResource.h M Tools/MiniBrowser/win/WebKitBrowserWindow.cpp M Tools/MiniBrowser/win/WebKitBrowserWindow.h M Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp M Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.h Log Message: --- [WinCairo][MiniBrowser] Add menu items to clear Cookies and Website data https://bugs.webkit.org/show_bug.cgi?id=247556 Reviewed by Fujii Hironori. Add menu items to clear Cookies and WebSite Data. * Tools/MiniBrowser/win/BrowserWindow.h: * Tools/MiniBrowser/win/MainWindow.cpp: (MainWindow::WndProc): * Tools/MiniBrowser/win/MiniBrowserLib.rc: * Tools/MiniBrowser/win/MiniBrowserLibResource.h: * Tools/MiniBrowser/win/WebKitBrowserWindow.cpp: (WebKitBrowserWindow::create): (WebKitBrowserWindow::WebKitBrowserWindow): (WebKitBrowserWindow::updateProxySettings): (deleteAllCookiesCallback): (WebKitBrowserWindow::clearCookies): (removeAllFetchCaches): (removeMemoryCaches): (removeAllServiceWorkerRegistrations): (removeAllIndexedDatabasesCallback): (removeLocalStorageCallback): (WebKitBrowserWindow::clearWebsiteData): (WebKitBrowserWindow::createNewPage): * Tools/MiniBrowser/win/WebKitBrowserWindow.h: * Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp: (WebKitLegacyBrowserWindow::clearCookies): (WebKitLegacyBrowserWindow::clearWebsiteData): * Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.h: Canonical link: https://commits.webkit.org/256386@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 64476c: Add fuzz to preserve3d-and-flattening-z-order-008.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 64476ce36f6f51c4c80c9b01a1985e78c2648b3d https://github.com/WebKit/WebKit/commit/64476ce36f6f51c4c80c9b01a1985e78c2648b3d Author: Matt Woodrow Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-and-flattening-z-order-008.html M LayoutTests/platform/ios/TestExpectations Log Message: --- Add fuzz to preserve3d-and-flattening-z-order-008. https://bugs.webkit.org/show_bug.cgi?id=243961 Reviewed by Tim Nguyen. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-and-flattening-z-order-008.html: * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/256385@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f9fd2: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f9fd27d1c8f9722eb264754ee9cc20c9e535ab8 https://github.com/WebKit/WebKit/commit/3f9fd27d1c8f9722eb264754ee9cc20c9e535ab8 Author: Fujii Hironori Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M LayoutTests/platform/wincairo-wk1/TestExpectations M LayoutTests/platform/wincairo/TestExpectations A LayoutTests/platform/wincairo/compositing/animation/state-at-end-event-transform-layer-expected.txt A LayoutTests/platform/wincairo/compositing/color-matching/image-color-matching-expected.txt A LayoutTests/platform/wincairo/compositing/color-matching/pdf-image-match-expected.txt A LayoutTests/platform/wincairo/compositing/compositing-visible-descendant-expected.txt A LayoutTests/platform/wincairo/compositing/direct-image-compositing-expected.txt A LayoutTests/platform/wincairo/compositing/generated-content-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/abs-position-inside-opacity-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/clipping-foreground-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/composited-html-size-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/fixed-in-composited-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/fixed-position-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/horizontal-scroll-composited-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/layer-due-to-layer-children-deep-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/layer-due-to-layer-children-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/outline-change-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/partial-layout-update-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/root-layer-update-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/vertical-scroll-composited-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/video-fixed-scrolling-expected.txt A LayoutTests/platform/wincairo/compositing/geometry/video-opacity-overlay-expected.txt A LayoutTests/platform/wincairo/compositing/iframes/composited-iframe-alignment-expected.txt A LayoutTests/platform/wincairo/compositing/iframes/compositing-for-scrollable-iframe-expected.txt A LayoutTests/platform/wincairo/compositing/iframes/iframe-copy-on-scroll-expected.txt A LayoutTests/platform/wincairo/compositing/iframes/iframe-in-composited-layer-expected.txt A LayoutTests/platform/wincairo/compositing/images/direct-image-background-color-expected.txt A LayoutTests/platform/wincairo/compositing/layer-creation/fixed-position-scroll-expected.txt A LayoutTests/platform/wincairo/compositing/layers-inside-overflow-scroll-expected.txt A LayoutTests/platform/wincairo/compositing/masks/direct-image-mask-expected.txt A LayoutTests/platform/wincairo/compositing/masks/masked-ancestor-expected.txt A LayoutTests/platform/wincairo/compositing/masks/multiple-masks-expected.txt A LayoutTests/platform/wincairo/compositing/masks/simple-composited-mask-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/ancestor-overflow-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/fixed-position-ancestor-clip-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/nested-scrolling-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/overflow-compositing-descendant-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/overflow-positioning-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/overflow-scroll-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/parent-overflow-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/remove-overflow-crash2-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/scroll-ancestor-update-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/scrollbar-painting-expected.txt A LayoutTests/platform/wincairo/compositing/overflow/theme-affects-visual-overflow-expected.txt A LayoutTests/platform/wincairo/compositing/reflections/animation-inside-reflection-expected.txt A LayoutTests/platform/wincairo/compositing/reflections/compositing-change-inside-reflection-expected.txt A LayoutTests/platform/wincairo/compositing/reflections/deeply-nested-reflections-expected.txt A LayoutTests/platform/wincairo/compositing/reflections/load-video-in-reflection-expected.txt A LayoutTests/platform/wincairo/compositing/reflections/masked-reflection-on-composited-expected.txt A
[webkit-changes] [WebKit/WebKit] 0d75a8: computed style for font-variation-settings should ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d75a86aa9945e0c4af7c2466fa5cf4d24013999 https://github.com/WebKit/WebKit/commit/0d75a86aa9945e0c4af7c2466fa5cf4d24013999 Author: Darin Adler Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variation-settings-computed-expected.txt M Source/WebCore/css/ComputedStyleExtractor.cpp Log Message: --- computed style for font-variation-settings should only serialize the last setting for duplicate tags https://bugs.webkit.org/show_bug.cgi?id=247553 rdar://102018065 Reviewed by Sam Weinig. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variation-settings-computed-expected.txt: Expect more PASS. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): Used a HashCountedSet to serialize only the last setting for each tag. Canonical link: https://commits.webkit.org/256383@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b942d: @font-face src descriptor format allows only ident...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b942dffc4a2e4391e95ecc49fe00c24d5a5dd06 https://github.com/WebKit/WebKit/commit/9b942dffc4a2e4391e95ecc49fe00c24d5a5dd06 Author: Darin Adler Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-format-expected.txt M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp Log Message: --- @font-face src descriptor format allows only identifiers for specified formats, others are a parse error https://bugs.webkit.org/show_bug.cgi?id=247552 rdar://problem/102018015 Reviewed by Sam Weinig. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-format-expected.txt: Expect more PASS. * Source/WebCore/css/CSSValueKeywords.in: Added the keywords for all the formats in the specification. * Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcURI): Allow only keywords for known formats. Canonical link: https://commits.webkit.org/256382@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 480554: [WGSL] Unify AST node type traits
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 480554208313ebcb878ee7ef315bc94d9b628e0b https://github.com/WebKit/WebKit/commit/480554208313ebcb878ee7ef315bc94d9b628e0b Author: Dan Glastonbury Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M Source/WebGPU/WGSL/AST/AST.h M Source/WebGPU/WGSL/AST/ASTArrayAccess.h M Source/WebGPU/WGSL/AST/ASTAssignmentStatement.h M Source/WebGPU/WGSL/AST/ASTAttribute.h A Source/WebGPU/WGSL/AST/ASTBindingAttribute.h A Source/WebGPU/WGSL/AST/ASTBuiltinAttribute.h M Source/WebGPU/WGSL/AST/ASTCallableExpression.h M Source/WebGPU/WGSL/AST/ASTCompoundStatement.h M Source/WebGPU/WGSL/AST/ASTDecl.h M Source/WebGPU/WGSL/AST/ASTExpression.h M Source/WebGPU/WGSL/AST/ASTFunctionDecl.h M Source/WebGPU/WGSL/AST/ASTGlobalDirective.h A Source/WebGPU/WGSL/AST/ASTGroupAttribute.h M Source/WebGPU/WGSL/AST/ASTIdentifierExpression.h M Source/WebGPU/WGSL/AST/ASTLiteralExpressions.h A Source/WebGPU/WGSL/AST/ASTLocationAttribute.h M Source/WebGPU/WGSL/AST/ASTNode.h M Source/WebGPU/WGSL/AST/ASTReturnStatement.h M Source/WebGPU/WGSL/AST/ASTShaderModule.h A Source/WebGPU/WGSL/AST/ASTStageAttribute.h M Source/WebGPU/WGSL/AST/ASTStatement.h M Source/WebGPU/WGSL/AST/ASTStructureAccess.h M Source/WebGPU/WGSL/AST/ASTStructureDecl.h M Source/WebGPU/WGSL/AST/ASTTypeDecl.h M Source/WebGPU/WGSL/AST/ASTUnaryExpression.h M Source/WebGPU/WGSL/AST/ASTVariableDecl.h M Source/WebGPU/WGSL/AST/ASTVariableQualifier.h M Source/WebGPU/WGSL/AST/ASTVariableStatement.h M Source/WebGPU/WGSL/AST/ASTVisitor.cpp M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WGSL/ConstLiteralTests.cpp M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp Log Message: --- [WGSL] Unify AST node type traits https://bugs.webkit.org/show_bug.cgi?id=247475 rdar://101943721 Reviewed by Myles C. Maxfield. Unify WGSL AST node type introspection to use TypeCastTraits, replacing the ".isNodeKind()" call pattern with "is(...)" to complement "downcast(...)". * Source/WebGPU/WGSL/AST/AST.h: * Source/WebGPU/WGSL/AST/ASTArrayAccess.h: * Source/WebGPU/WGSL/AST/ASTAssignmentStatement.h: * Source/WebGPU/WGSL/AST/ASTAttribute.h: (WGSL::AST::Attribute::Attribute): (isType): (WGSL::AST::Attribute::~Attribute): Deleted. (WGSL::AST::Attribute::isGroup const): Deleted. (WGSL::AST::Attribute::isBinding const): Deleted. (WGSL::AST::Attribute::isStage const): Deleted. (WGSL::AST::Attribute::isLocation const): Deleted. (WGSL::AST::Attribute::isBuiltin const): Deleted. (): Deleted. * Source/WebGPU/WGSL/AST/ASTBindingAttribute.h: Copied from Source/WebGPU/WGSL/AST/ASTGlobalDirective.h. * Source/WebGPU/WGSL/AST/ASTBuiltinAttribute.h: Copied from Source/WebGPU/WGSL/AST/ASTGlobalDirective.h. * Source/WebGPU/WGSL/AST/ASTCallableExpression.h: * Source/WebGPU/WGSL/AST/ASTCompoundStatement.h: * Source/WebGPU/WGSL/AST/ASTDecl.h: (WGSL::AST::Decl::Decl): (isType): (WGSL::AST::Decl::~Decl): Deleted. (WGSL::AST::Decl::isVariable const): Deleted. (WGSL::AST::Decl::isStruct const): Deleted. (WGSL::AST::Decl::isFunction const): Deleted. * Source/WebGPU/WGSL/AST/ASTExpression.h: (WGSL::AST::Expression::Expression): (isTypeOf): (WGSL::AST::Expression::~Expression): Deleted. (WGSL::AST::Expression::isBoolLiteral const): Deleted. (WGSL::AST::Expression::isInt32Literal const): Deleted. (WGSL::AST::Expression::isUInt32Literal const): Deleted. (WGSL::AST::Expression::isFloat32Literal const): Deleted. (WGSL::AST::Expression::isAbstractIntLiteral const): Deleted. (WGSL::AST::Expression::isAbstractFloatLiteral const): Deleted. (WGSL::AST::Expression::isIdentifier const): Deleted. (WGSL::AST::Expression::isArrayAccess const): Deleted. (WGSL::AST::Expression::isStructureAccess const): Deleted. (WGSL::AST::Expression::isCallableExpression const): Deleted. (WGSL::AST::Expression::isUnaryExpression const): Deleted. * Source/WebGPU/WGSL/AST/ASTFunctionDecl.h: * Source/WebGPU/WGSL/AST/ASTGlobalDirective.h: (WGSL::AST::GlobalDirective::GlobalDirective): * Source/WebGPU/WGSL/AST/ASTGroupAttribute.h: Copied from Source/WebGPU/WGSL/AST/ASTGlobalDirective.h. * Source/WebGPU/WGSL/AST/ASTIdentifierExpression.h: * Source/WebGPU/WGSL/AST/ASTLiteralExpressions.h: * Source/WebGPU/WGSL/AST/ASTLocationAttribute.h: Copied from Source/WebGPU/WGSL/AST/ASTGlobalDirective.h. * Source/WebGPU/WGSL/AST/ASTNode.h: (WGSL::AST::Node::Node): (WGSL::AST::ASTNode::ASTNode): Deleted. (WGSL::AST::ASTNode::span const): Deleted. * Source/WebGPU/WGSL/AST/ASTReturnStatement.h: * Source/WebGPU/WGSL/AST/ASTShaderModule.h: * Source/WebGPU/WGSL/AST/ASTStageAttribute.h: Copied from Source/WebGPU/WGSL/AST/ASTGlobalDirective.h. * Source/WebGPU/WGSL/AST/ASTStatement.h: (WGSL::AST::Statement::Statement): (isType): (WGSL::AST::Statement::~Statement): Deleted.
[webkit-changes] [WebKit/WebKit] 713b0b: Expose the FONT_FEATURE_VALUES_RULE constant
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 713b0baf74e830dd90477f29a852ca4a48093c9d https://github.com/WebKit/WebKit/commit/713b0baf74e830dd90477f29a852ca4a48093c9d Author: Darin Adler Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/CSSFontFeatureValuesRule.idl M Source/WebCore/css/CSSRule.idl Log Message: --- Expose the FONT_FEATURE_VALUES_RULE constant https://bugs.webkit.org/show_bug.cgi?id=247551 rdar://problem/102017360 Reviewed by Sam Weinig. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt: Expect more PASS. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Added CSSFontFeatureValuesRule.idl, which was missing. Not needed for the build, but better for editing and searching. * Source/WebCore/css/CSSFontFeatureValuesRule.idl: Deleted a trailing blank line. * Source/WebCore/css/CSSRule.idl: Added FONT_FEATURE_VALUES_RULE. Canonical link: https://commits.webkit.org/256380@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4718fa: Normalize style in makeprop.pl's output to aid rep...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4718faa509f327097a30847ee21ede844aff6670 https://github.com/WebKit/WebKit/commit/4718faa509f327097a30847ee21ede844aff6670 Author: Sam Weinig Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M Source/WebCore/css/makeprop.pl Log Message: --- Normalize style in makeprop.pl's output to aid replacing it https://bugs.webkit.org/show_bug.cgi?id=247550 rdar://102015817 Reviewed by Darin Adler. To make replacing makeprop.pl easier in https://bugs.webkit.org/show_bug.cgi?id=247470 this updates the generated output to consistently use the following stylist choices: - Always use fully scoped name for CSSPropertyIDs (this will also make it a bit easier to move to a scoped enum at some point). - Use the parameter name "id" for CSSPropertyID parameters in generated functions. - Move all the fullly static function bodies generated for CSSPropertyNames.gperf to be consecutive. - Add a missing space in the static part of isInheritedPropertyTable so that all the true's look the same. * Source/WebCore/css/makeprop.pl: (generateFillLayerPropertyValueSetter): (generateValueSetter): Canonical link: https://commits.webkit.org/256379@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd41ef: Include the anchor z-position in the PlatformCALay...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd41ef8a9c116a68b994797254d08b2824bc2072 https://github.com/WebKit/WebKit/commit/cd41ef8a9c116a68b994797254d08b2824bc2072 Author: Matt Woodrow Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp Log Message: --- Include the anchor z-position in the PlatformCALayer's position. https://bugs.webkit.org/show_bug.cgi?id=245353 Reviewed by Simon Fraser. We need to include the z coordinate in the position, otherwise transform-origins with a z-component are applied incorrectly. * LayoutTests/TestExpectations: * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateGeometry): Canonical link: https://commits.webkit.org/256378@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d51d63: Use std::remove_cvref where possible
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d51d63b0938d48756a22d42c0b80f7d0c0ad12b6 https://github.com/WebKit/WebKit/commit/d51d63b0938d48756a22d42c0b80f7d0c0ad12b6 Author: Žan Doberšek Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M Source/WTF/wtf/CrossThreadCopier.h M Source/WTF/wtf/StdLibExtras.h M Source/WTF/wtf/Vector.h M Source/WebCore/bindings/js/JSDOMConvertUnion.h M Source/WebCore/platform/SharedBuffer.h M Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp M Source/WebKit/Platform/IPC/DaemonDecoder.h M Source/WebKit/Platform/IPC/DaemonEncoder.h M Source/WebKit/Platform/IPC/Decoder.h M Source/WebKit/Platform/IPC/Encoder.h M Source/WebKit/Platform/IPC/HandleMessage.h M Source/WebKit/Platform/IPC/StreamConnectionEncoder.h M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp Log Message: --- Use std::remove_cvref where possible https://bugs.webkit.org/show_bug.cgi?id=247542 Reviewed by Fujii Hironori. C++20 introduces the std::remove_cvref type alias which can be used in place of combinations of std::remove_reference and std::remove_const or std::remove_cv. Older versions of GCC's standard library are covered by an already-existing fallback. WTF::RemoveCVAndReference is basically the same thing and can be replaced completely. * Source/WTF/wtf/CrossThreadCopier.h: (WTF::crossThreadCopy): * Source/WTF/wtf/StdLibExtras.h: * Source/WTF/wtf/Vector.h: (WTF::Malloc>::appendSlowCase): (WTF::Malloc>::insert): * Source/WebCore/bindings/js/JSDOMConvertUnion.h: * Source/WebCore/platform/SharedBuffer.h: (WebCore::SharedBuffer::create): * Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp: (WebCore::DisplayList::safeCopy): * Source/WebKit/Platform/IPC/DaemonDecoder.h: (WebKit::Daemon::Decoder::decode): * Source/WebKit/Platform/IPC/DaemonEncoder.h: (WebKit::Daemon::Encoder::operator<<): * Source/WebKit/Platform/IPC/Decoder.h: (IPC::Decoder::decode): * Source/WebKit/Platform/IPC/Encoder.h: * Source/WebKit/Platform/IPC/HandleMessage.h: * Source/WebKit/Platform/IPC/StreamConnectionEncoder.h: * Source/WebKit/Scripts/generate-serializers.py: (check_type_members): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): Canonical link: https://commits.webkit.org/256377@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 518d8d: [LFC][IFC] Introduce ConstraintsForInlineContent
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 518d8d287c12dbe6fdf6f5cfd9ec910598cac922 https://github.com/WebKit/WebKit/commit/518d8d287c12dbe6fdf6f5cfd9ec910598cac922 Author: Alan Baradlay Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/layout/formattingContexts/FormattingConstraints.h M Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h A Source/WebCore/layout/formattingContexts/inline/InlineFormattingConstraints.h M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h M Source/WebCore/layout/formattingContexts/table/TableFormattingConstraints.h M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h Log Message: --- [LFC][IFC] Introduce ConstraintsForInlineContent https://bugs.webkit.org/show_bug.cgi?id=247535 Reviewed by Antti Koivisto. This is similar to what we already do for flex/table content where base constraints are not sufficient. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/layout/formattingContexts/FormattingConstraints.h: Move visualLeft from base class to ConstraintsForInlineContent. (WebCore::Layout::ConstraintsForInFlowContent::logicalTop const): (WebCore::Layout::ConstraintsForInFlowContent::isConstraintsForInlineContent const): (WebCore::Layout::ConstraintsForInFlowContent::ConstraintsForInFlowContent): (WebCore::Layout::ConstraintsForInFlowContent::visualLeft const): Deleted. * Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h: (WebCore::Layout::ConstraintsForFlexContent::ConstraintsForFlexContent): (WebCore::Layout::m_minimumVerticalSpace): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingConstraints.h: Copied from Source/WebCore/layout/formattingContexts/table/TableFormattingConstraints.h. (WebCore::Layout::ConstraintsForInlineContent::visualLeft const): (WebCore::Layout::ConstraintsForInlineContent::ConstraintsForInlineContent): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::layoutInFlowContent): (WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntegration): (WebCore::Layout::InlineFormattingContext::lineLayout): (WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h: * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp: (WebCore::Layout::InlineDisplayLineBuilder::build const): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h: * Source/WebCore/layout/formattingContexts/table/TableFormattingConstraints.h: (WebCore::Layout::ConstraintsForTableContent::ConstraintsForTableContent): (WebCore::Layout::m_availableVerticalSpaceForContent): Deleted. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::updateInlineContentConstraints): * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h: Canonical link: https://commits.webkit.org/256376@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 128b2c: [IFC][Integration] Do not mutate root box's geomet...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 128b2cb838691029a10355e0f99f7884eb55a617 https://github.com/WebKit/WebKit/commit/128b2cb838691029a10355e0f99f7884eb55a617 Author: Alan Baradlay Date: 2022-11-06 (Sun, 06 Nov 2022) Changed paths: M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- [IFC][Integration] Do not mutate root box's geometry with logical values https://bugs.webkit.org/show_bug.cgi?id=247249 Reviewed by Antti Koivisto. BoxGeometry should contain values based off of the coordinate space the box itself is in (and not the coordinate space it creates for its descendant). In case of a formatting context root box (e.g. IFC root), the box's geometry may be different from what it establishes for the formatting context. e.g. "writing-mode: vertical-lr" on box flips the width/height (top/left) values for the participating descendant boxes. This flipped geometry should not be cached on the BoxGeometry instead we introduce m_inlineContentConstraints. This ensures that when a box both participates in a formatting context and establishes a new formatting context for its descendants, we don't mutate the original geometry. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::updateListMarkerDimensions): (WebCore::LayoutIntegration::LineLayout::layout): (WebCore::LayoutIntegration::LineLayout::constructContent): (WebCore::LayoutIntegration::LineLayout::updateInlineContentConstraints): (WebCore::LayoutIntegration::LineLayout::prepareFloatingState): (WebCore::LayoutIntegration::LineLayout::updateFormattingRootGeometryAndInvalidate): Deleted. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h: * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::layoutModernLines): Canonical link: https://commits.webkit.org/256375@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 96ebc7: [WK2][GLib] Add ArgumentCoder...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96ebc7619894c35e64d5155eaf81d2963d4bd4a8 https://github.com/WebKit/WebKit/commit/96ebc7619894c35e64d5155eaf81d2963d4bd4a8 Author: Žan Doberšek Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp M Source/WebKit/Shared/glib/ArgumentCodersGLib.h M Source/WebKit/Shared/glib/UserMessage.cpp Log Message: --- [WK2][GLib] Add ArgumentCoder> specialization https://bugs.webkit.org/show_bug.cgi?id=247522 Reviewed by Michael Catanzaro. Move encoding and decoding logic for GUnixFDList objects into a separate ArgumentCoder specialization, removing the logic from the UserMessage class's encoding and decoding methods. Nullness of a GRefPtr is preserved, and a file descriptor leak during decoding is fixed. When encoding, the gathered UnixFileDescriptor objects should be moved through the encoder to avoid further duplication, but this will only work later once other specific ArgumentCoder specializations properly handle rvalues. * Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp: (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): * Source/WebKit/Shared/glib/ArgumentCodersGLib.h: * Source/WebKit/Shared/glib/UserMessage.cpp: (WebKit::UserMessage::encode const): (WebKit::UserMessage::decode): Canonical link: https://commits.webkit.org/256374@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
