[webkit-changes] [WebKit/WebKit] cc446a: Allow SafariForWebKitDevelopment to load pages again
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc446ab5303d8f063c90ae113683f55b7f6883a8 https://github.com/WebKit/WebKit/commit/cc446ab5303d8f063c90ae113683f55b7f6883a8 Author: Alex Christensen Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/UIProcess/Cocoa/NavigationState.mm Log Message: --- Allow SafariForWebKitDevelopment to load pages again https://bugs.webkit.org/show_bug.cgi?id=247995 rdar://102339404 Reviewed by Chris Dumez. * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): Canonical link: https://commits.webkit.org/256773@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b55a0f: [build.webkit.org] Remove WebKitGTK and WPE packag...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b55a0fa5e42e6d810a6795f38e4a26fdfccce380 https://github.com/WebKit/WebKit/commit/b55a0fa5e42e6d810a6795f38e4a26fdfccce380 Author: Diego Pino Garcia Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/CISupport/build-webkit-org/config.json M Tools/CISupport/build-webkit-org/factories_unittest.py Log Message: --- [build.webkit.org] Remove WebKitGTK and WPE packaging bots for Ubuntu 18.04 from CI https://bugs.webkit.org/show_bug.cgi?id=247974 Reviewed by Jonathan Bedard. * Tools/CISupport/build-webkit-org/config.json: * Tools/CISupport/build-webkit-org/factories_unittest.py: Canonical link: https://commits.webkit.org/256772@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4623d9: [web-animations] web-animations/timing-model/timel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4623d94c854c0884e3d10484b0bcf580e6d07096 https://github.com/WebKit/WebKit/commit/4623d94c854c0884e3d10484b0bcf580e6d07096 Author: Antoine Quint Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-expected.txt M Source/WebCore/animation/AnimationEventBase.cpp M Source/WebCore/animation/AnimationEventBase.h M Source/WebCore/animation/AnimationPlaybackEvent.cpp M Source/WebCore/animation/AnimationPlaybackEvent.h M Source/WebCore/animation/CSSAnimation.cpp M Source/WebCore/animation/CSSAnimation.h M Source/WebCore/animation/CSSTransition.cpp M Source/WebCore/animation/CSSTransition.h M Source/WebCore/animation/DeclarativeAnimation.cpp M Source/WebCore/animation/DeclarativeAnimation.h M Source/WebCore/animation/DocumentTimeline.cpp M Source/WebCore/animation/DocumentTimeline.h M Source/WebCore/animation/DocumentTimelinesController.cpp M Source/WebCore/animation/WebAnimation.cpp M Source/WebCore/animation/WebAnimation.h M Source/WebCore/animation/WebAnimationUtilities.cpp M Source/WebCore/animation/WebAnimationUtilities.h M Source/WebCore/dom/AnimationEvent.cpp M Source/WebCore/dom/AnimationEvent.h M Source/WebCore/dom/TransitionEvent.cpp M Source/WebCore/dom/TransitionEvent.h Log Message: --- [web-animations] web-animations/timing-model/timelines/update-and-send-events.html is a unique failure https://bugs.webkit.org/show_bug.cgi?id=191187 Reviewed by Dean Jackson. We implement the animation sorting behavior specified by the Web Animations spec as part of the "update animations and send events" procedure. We used to sort events by the timeline time at the point when they were created, but the spec says to sort them by their scheduled event time which is specific to each time of Web Animations event (AnimationPlaybackEvent): "finish", "cancel" and "remove". Since the "timeline time" is only relevant to AnimationPlaybackEvent, we move it from AnimationEventBase to that interface, and add a new scheduledTime property as well. Then, in updateAnimationsAndSendEvents(), we now use the compareAnimationEventsByCompositeOrder() function to sort the events. First, we sort AnimationPlaybackEvent events among themselves by their relative "scheduled event time" when they don't match, and when they do by the type of animation related to the event (CSS Transitions, then CSS Animations and finally script-originated animations). Second, we sort TransitionEvent events and third (and last), AnimationEvent events. Those events are always sorted to retain the order in which they were enqueued. Finally, we refactored TransitionEvent and AnimationEvent to no longer expect a timeline time and to set the related WebAnimation object first to match the argument order of AnimationEventBase. * LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-expected.txt: * Source/WebCore/animation/AnimationEventBase.cpp: (WebCore::AnimationEventBase::AnimationEventBase): * Source/WebCore/animation/AnimationEventBase.h: (WebCore::AnimationEventBase::create): (WebCore::AnimationEventBase::timelineTime const): Deleted. * Source/WebCore/animation/AnimationPlaybackEvent.cpp: (WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent): (WebCore::AnimationPlaybackEvent::bindingsTimelineTime const): * Source/WebCore/animation/AnimationPlaybackEvent.h: * Source/WebCore/animation/CSSAnimation.cpp: (WebCore::CSSAnimation::createEvent): * Source/WebCore/animation/CSSAnimation.h: * Source/WebCore/animation/CSSTransition.cpp: (WebCore::CSSTransition::createEvent): * Source/WebCore/animation/CSSTransition.h: * Source/WebCore/animation/DeclarativeAnimation.cpp: (WebCore::DeclarativeAnimation::enqueueDOMEvent): * Source/WebCore/animation/DeclarativeAnimation.h: * Source/WebCore/animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::removeReplacedAnimations): (WebCore::DocumentTimeline::convertTimelineTimeToOriginRelativeTime const): * Source/WebCore/animation/DocumentTimeline.h: * Source/WebCore/animation/DocumentTimelinesController.cpp: (WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents): * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::cancel): (WebCore::WebAnimation::enqueueAnimationPlaybackEvent): (WebCore::WebAnimation::finishNotificationSteps): (WebCore::WebAnimation::convertAnimationTimeToTimelineTime const): * Source/WebCore/animation/WebAnimation.h: * Source/WebCore/animation/WebAnimationUtilities.cpp: (WebCore::compareAnimationEventsByCompositeOrder): * Source/WebCore/animation/WebAnimationUtilities.h: * Source/WebCore/dom/AnimationEvent.cpp: (WebCore::AnimationEvent::AnimationEvent): * Source/WebCore/dom/AnimationEvent.h: * Source/WebCore/dom/Tr
[webkit-changes] [WebKit/WebKit] f2f6b5: Update test262
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2f6b5d76ff5107378c7fd186bf35ba981c4136b https://github.com/WebKit/WebKit/commit/f2f6b5d76ff5107378c7fd186bf35ba981c4136b Author: Yusuke Suzuki Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M JSTests/test262/config.yaml M JSTests/test262/expectations.yaml M JSTests/test262/harness/async-gc.js M JSTests/test262/harness/compareIterator.js M JSTests/test262/harness/doneprintHandle.js M JSTests/test262/harness/temporalHelpers.js M JSTests/test262/harness/testIntl.js M JSTests/test262/latest-changes-summary.txt A JSTests/test262/test/annexB/built-ins/RegExp/prototype/compile/duplicate-named-capturing-groups-syntax.js A JSTests/test262/test/built-ins/Array/prototype/Symbol.unscopables/change-array-by-copy.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/frozen-this-value.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/get-descending-order.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/holes-not-preserved.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/ignores-species.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/immutable.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/length-casted-to-zero.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/length-decreased-while-iterating.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/length-exceeding-array-length-limit.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/length-increased-while-iterating.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/length-tolength.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/metadata/length.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/metadata/name.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/metadata/property-descriptor.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/not-a-constructor.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/this-value-boolean.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/this-value-nullish.js A JSTests/test262/test/built-ins/Array/prototype/toReversed/zero-or-one-element.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/comparefn-called-after-get-elements.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/comparefn-not-a-function.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/comparefn-stop-after-error.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/frozen-this-value.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/holes-not-preserved.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/ignores-species.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/immutable.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/length-casted-to-zero.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/length-decreased-while-iterating.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/length-exceeding-array-length-limit.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/length-increased-while-iterating.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/length-tolength.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/metadata/length.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/metadata/name.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/metadata/property-descriptor.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/not-a-constructor.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/this-value-boolean.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/this-value-nullish.js A JSTests/test262/test/built-ins/Array/prototype/toSorted/zero-or-one-element.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/deleteCount-clamped-between-zero-and-remaining-count.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/deleteCount-missing.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/deleteCount-undefined.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/discarded-element-not-read.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/elements-read-in-order.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/frozen-this-value.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/holes-not-preserved.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/ignores-species.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/immutable.js A JSTests/test262/test/built-ins/Array/prototype/toSpliced/length-casted-to-zero.js A JSTests/test262/test/built-ins/Array/prototype/
[webkit-changes] [WebKit/WebKit] 9adcbe: Refactor the code that handles selector specificit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9adcbe8f12b9c117447569ca9d6e1cc28d934ae8 https://github.com/WebKit/WebKit/commit/9adcbe8f12b9c117447569ca9d6e1cc28d934ae8 Author: Darin Adler Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/css/CSSSelector.cpp M Source/WebCore/css/CSSSelector.h M Source/WebCore/inspector/InspectorStyleSheet.cpp Log Message: --- Refactor the code that handles selector specificity for simplicity and remove unused functions https://bugs.webkit.org/show_bug.cgi?id=247851 rdar://problem/102281644 Reviewed by Sam Weinig. * Source/WebCore/css/CSSSelector.cpp: (WebCore::CSSSelector::CSSSelector): Removed the m_ prefixes from struct members. (WebCore::CSSSelector::createRareData): Get rid of the local AtomString here. Clearer without. (WebCore::SelectorSpecificity): Added a struct to wrap a selector specificity value, so we can convert from the enum without a static_cast and use the + and += operators for saturating addition of each channel in parallel. (WebCore::SelectorSpecificity::operator+=): Implemented. Replaces addSpecificities. (WebCore::operator+): Implemented by calling +=. (WebCore::selectorSpecificity): Use SelectorSpecificity. (WebCore::maxSpecificity): Ditto. Also changed to take a pointer and check for null since that simplifies the code below. (WebCore::simpleSelectorSpecificity): Renamed from simpleSelectorSpecificityInternal and changed the return value to SelectorSpecificity. Removed now-unneeded static_cast and use + instead of CSSSelector::addSpecificities. (WebCore::CSSSelector::simpleSelectorSpecificity const): Deleted. (WebCore::CSSSelector::computeSpecificity const): Updated for SelectorSpecificity. (WebCore::CSSSelector::computeSpecificityTuple const): Added. This is for the inspector code that wants the three different components of specifity as separate integers. (WebCore::CSSSelector::addSpecificities): Deleted. (WebCore::appendPseudoClassFunctionTail): Removed the m_ prefixes from struct members. (WebCore::CSSSelector::setAttribute): Ditto. (WebCore::CSSSelector::setArgument): Ditto. (WebCore::CSSSelector::setArgumentList): Ditto. (WebCore::CSSSelector::setSelectorList): Ditto. (WebCore::CSSSelector::setNth): Ditto. (WebCore::CSSSelector::matchNth const): Ditto. (WebCore::CSSSelector::nthA const): Ditto. (WebCore::CSSSelector::nthB const): Ditto. (WebCore::CSSSelector::RareData::RareData): Use WTFMove to eliminate a bit of reference count churn. Moved more initialization to the class definition. (WebCore::CSSSelector::RareData::create): Moved here from the header, since this is only called from inside this file. Changed argument type to just AtomString, which is still compatible with moving new values in and more straightforward. (WebCore::CSSSelector::RareData::matchNth): Removed the m_ prefixes from struct members. * Source/WebCore/css/CSSSelector.h: Removed idMask, classMask, simpleSelectorSpecificity, and addSpecificities, none of which are needed outside the class. Added computeSpecificityTuple for use by the inspector. Changed struct members to not use the m_ syntax; we do that for private class members, not struct members. Updated the RareData::create function and initialized a, and b in RareData. * Source/WebCore/inspector/InspectorStyleSheet.cpp: (WebCore::buildObjectForSelectorHelper): Use computeSpecificityTuple. Canonical link: https://commits.webkit.org/256769@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c223bd: [Debug][Test gardening] fast/layoutformattingconte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c223bda7a1dea0c2045b024fa34be270c004 https://github.com/WebKit/WebKit/commit/c223bda7a1dea0c2045b024fa34be270c004 Author: Alan Baradlay Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Debug][Test gardening] fast/layoutformattingcontext/intrusive-floats-takes-entire-horizontal-space.html ASSERTs https://bugs.webkit.org/show_bug.cgi?id=248019 Unreviewed. This test is skipped in LayoutTests/TestExpectations. * LayoutTests/platform/mac-wk2/TestExpectations: let top level TestExpectations handle it. Canonical link: https://commits.webkit.org/256768@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10ff50: Fix WebKitTestRunner's jscOption configuration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10ff500020954b792f3f2f25ef2ae0dd2fdde847 https://github.com/WebKit/WebKit/commit/10ff500020954b792f3f2f25ef2ae0dd2fdde847 Author: Yusuke Suzuki Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp M Tools/WebKitTestRunner/TestController.cpp Log Message: --- Fix WebKitTestRunner's jscOption configuration https://bugs.webkit.org/show_bug.cgi?id=248006 rdar://102445778 Reviewed by Chris Dumez. 250473@main removed Reset message to InjectedBundle before starting a test to fix flaky language setting issue. However, this broke jscOption since the code was expecting that Reset message is sent before running test, and we were setting jscOption at that timing. This patch recovers Reset message and instead, we add ResetStage field to the message so that InjectedBundle can avoid running language setting etc. for ResetStage::BeforeTest case while it sets jscOption for the test. * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Canonical link: https://commits.webkit.org/256767@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe4f0a: [JSC] Implement growable SharedArrayBuffer part 2
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe4f0a4cc309e65e5bb51a15359235a52a7c8f6c https://github.com/WebKit/WebKit/commit/fe4f0a4cc309e65e5bb51a15359235a52a7c8f6c Author: Yusuke Suzuki Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M JSTests/stress/detached-typed-array-iteration.js A JSTests/stress/growable-typed-array.js M JSTests/stress/typed-array-from.js M JSTests/stress/typedarray-defineOwnProperty-error.js M JSTests/stress/typedarray-functions-with-neutered.js M JSTests/wasm/js-api/neutered-inputs.js M LayoutTests/fast/canvas/webgl/arraybuffer-transfer-of-control.html M Source/JavaScriptCore/API/JSTypedArray.cpp M Source/JavaScriptCore/builtins/ArrayIteratorPrototype.js M Source/JavaScriptCore/bytecode/AccessCase.cpp M Source/JavaScriptCore/bytecode/ArrayProfile.cpp M Source/JavaScriptCore/bytecode/ArrayProfile.h M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/bytecode/SpeculatedType.cpp M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGArrayMode.cpp M Source/JavaScriptCore/dfg/DFGArrayMode.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/dfg/DFGNode.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/IntrinsicEmitter.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter.asm M Source/JavaScriptCore/runtime/ArrayBuffer.h M Source/JavaScriptCore/runtime/ArrayBufferView.cpp M Source/JavaScriptCore/runtime/ArrayBufferView.h M Source/JavaScriptCore/runtime/AtomicsObject.cpp M Source/JavaScriptCore/runtime/ClassInfo.h M Source/JavaScriptCore/runtime/DataView.cpp M Source/JavaScriptCore/runtime/DataView.h M Source/JavaScriptCore/runtime/GenericTypedArrayView.h M Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h M Source/JavaScriptCore/runtime/JSArrayBuffer.h M Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp M Source/JavaScriptCore/runtime/JSArrayBufferView.cpp M Source/JavaScriptCore/runtime/JSArrayBufferView.h M Source/JavaScriptCore/runtime/JSArrayBufferViewInlines.h M Source/JavaScriptCore/runtime/JSCast.h M Source/JavaScriptCore/runtime/JSCell.h M Source/JavaScriptCore/runtime/JSDataView.cpp M Source/JavaScriptCore/runtime/JSDataView.h M Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp M Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/JavaScriptCore/runtime/JSType.h M Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp M Source/JavaScriptCore/runtime/JSTypedArrays.cpp M Source/JavaScriptCore/runtime/JSTypedArrays.h M Source/JavaScriptCore/runtime/StructureInlines.h M Source/JavaScriptCore/runtime/TypedArrayAdaptors.h M Source/JavaScriptCore/runtime/TypedArrayType.h M Source/JavaScriptCore/testRegExp.cpp M Source/JavaScriptCore/wasm/WasmOperations.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h M Source/WTF/wtf/StdLibExtras.h M Source/WebCore/Modules/webaudio/AudioBuffer.cpp M Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp Log Message: --- [JSC] Implement growable SharedArrayBuffer part 2 https://bugs.webkit.org/show_bug.cgi?id=247921 rdar://102339939 Reviewed by Mark Lam. This patch adds runtime support for growable SharedArrayBuffer, TypedArray, and DataView. We are not supporting JIT optimization yet, but still this patch implements the basic mechanism to support it in a subsequent patch. 1. TypedArray / DataView has a mode flag which says ResizableNonShared / GrowableShared / AutoLength etc. And we use this flag to dispatch the implementation. For non resizable one, we use super simple implementation as before. 2. This patch implements "auto" length, which automatically changes length / byteLength of TypedArray based on backing storage's SharedArrayBuffer etc. 3. This patch does not implement JIT optimizations. They will be done in a subsequent patch. * JSTests/stress/detached-typed-array-iteration.js: (shouldThrow): * JSTests/stress/typed-array-from.js: (shouldBeArray): * JSTests/stress/typ
[webkit-changes] [WebKit/WebKit] 7d62c5: REGRESSION: 4 PiP API tests consistently timing ou...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d62c54471272c48c228c7e7e593072e3dbc5c49 https://github.com/WebKit/WebKit/commit/7d62c54471272c48c228c7e7e593072e3dbc5c49 Author: Robert Jenner Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm Log Message: --- REGRESSION: 4 PiP API tests consistently timing out on Big Sur EWS and Ventura https://bugs.webkit.org/show_bug.cgi?id=247373 rdar://problem/101873453 Unreviewed test gardening. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Canonical link: https://commits.webkit.org/256765@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18f611: [Layout perf test] Add fixed pitch content with ar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18f611386af9baf4c39516cf663a74357909b929 https://github.com/WebKit/WebKit/commit/18f611386af9baf4c39516cf663a74357909b929 Author: Alan Baradlay Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A PerformanceTests/Layout/fixed-pitch-arbitrary-break-long-text.html Log Message: --- [Layout perf test] Add fixed pitch content with arbitrary soft wrap opportunities https://bugs.webkit.org/show_bug.cgi?id=248011 Unreviewed. This test case helps to catch monospace type of text heavy content (e.g. build output) layout performance regressions (see webkit.org/b/247782). * PerformanceTests/Layout/fixed-pitch-arbitrary-break-long-text.html: Added. Canonical link: https://commits.webkit.org/256764@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b45acc: Address FIXMEs in process-css-properties.py
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b45acc1caf6b1fdfd094f77e80a54833c61cf726 https://github.com/WebKit/WebKit/commit/b45acc1caf6b1fdfd094f77e80a54833c61cf726 Author: Sam Weinig Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/css/process-css-properties.py Log Message: --- Address FIXMEs in process-css-properties.py https://bugs.webkit.org/show_bug.cgi?id=247861 rdar://102292266 Reviewed by Darin Adler. Address the FIXMEs I left in process-css-properties.py to make the transition from the old script easier. This mostly was removal of unnecessary extra sorting that was done to maintain character for character parity with the old script. Additionally, this removes a bunch of unnecessary list allocations by converting list-comprehension expressions (i.e. [x for x in foo]) into generator-comprehension expressions (i.e. (x for x in foo)) where materializing the list early was not necessary or useful. This allows getting rid of a bunch of caching as well, which is nice. * Source/WebCore/css/process-css-properties.py: Canonical link: https://commits.webkit.org/256763@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9f1365: [Curl] Combine multiple Timing-Allow-Origin header...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9f13658a312b4460d6e923db647752035a327054 https://github.com/WebKit/WebKit/commit/9f13658a312b4460d6e923db647752035a327054 Author: Kenji Shukuwa Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp Log Message: --- [Curl] Combine multiple Timing-Allow-Origin header fields https://bugs.webkit.org/show_bug.cgi?id=248001 Reviewed by Fujii Hironori. Combine multiple Timing-Allow-Origin header fields into one. * LayoutTests/platform/wincairo/TestExpectations: * Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::isAppendableHeader): Canonical link: https://commits.webkit.org/256762@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ceaed6: REGRESSION (255063@main): [ Ventura ] fast/forms/b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ceaed66305de1bfc29a8a4c606d1d4b25a032615 https://github.com/WebKit/WebKit/commit/ceaed66305de1bfc29a8a4c606d1d4b25a032615 Author: Karl Rackler Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A LayoutTests/platform/mac-ventura-wk1/TestExpectations A LayoutTests/platform/mac-ventura-wk2/TestExpectations A LayoutTests/platform/mac-ventura-wk2/fast/forms/button-sizes-expected.txt Log Message: --- REGRESSION (255063@main): [ Ventura ] fast/forms/button-sizes.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=248002 Unreviewed test gardening. * LayoutTests/platform/mac-ventura-wk1/TestExpectations: Added. * LayoutTests/platform/mac-ventura-wk2/TestExpectations: Added. * LayoutTests/platform/mac-ventura-wk2/fast/forms/button-sizes-expected.txt: Added. Canonical link: https://commits.webkit.org/256761@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57ba79: Add support for Skip-EWS GitHub label
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 57ba798e7aa4dfde86461fa927fae24d40486fe3 https://github.com/WebKit/WebKit/commit/57ba798e7aa4dfde86461fa927fae24d40486fe3 Author: Aakash Jain Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/CISupport/ews-build/steps.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py Log Message: --- Add support for Skip-EWS GitHub label https://bugs.webkit.org/show_bug.cgi?id=247900 Reviewed by Jonathan Bedard. * Tools/CISupport/ews-build/steps.py: (GitHubMixin): (GitHubMixin._does_pr_has_skip_label): Method to check if pr has skip-ews label. (ValidateChange.__init__): (ValidateChange): (ValidateChange.start): (ValidateChange.validate_github): Canonical link: https://commits.webkit.org/256760@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab5398: [MSE] Should not seek with no seekable range
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab539817a72136ed0d4a41d1489404ee9a0259dc https://github.com/WebKit/WebKit/commit/ab539817a72136ed0d4a41d1489404ee9a0259dc Author: Yousuke Kimoto Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A LayoutTests/media/media-source/media-source-no-seek-with-infinite-duration-expected.txt A LayoutTests/media/media-source/media-source-no-seek-with-infinite-duration.html M Source/WebCore/html/HTMLMediaElement.cpp Log Message: --- [MSE] Should not seek with no seekable range https://bugs.webkit.org/show_bug.cgi?id=247602 Reviewed by Jer Noble. According https://html.spec.whatwg.org/multipage/media.html#seeking, "If there are no ranges given in the seekable attribute then set the seeking IDL attribute to false and return." For live streaming videos, their duration is infinity, then there is no seekable range. So 'seek' should be aborted in this case. * LayoutTests/media/media-source/media-source-no-seek-with-infinite-duration-expected.txt: Added. * LayoutTests/media/media-source/media-source-no-seek-with-infinite-duration.html: Test seeking status and currentTime with an infinite duration. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seekTask): Added a condtion to check if there is no seekable range for for notifying the mdedia engine of a seek. Canonical link: https://commits.webkit.org/256759@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd4f45: [JSC] WeakMap / WeakSet constructor should accept ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd4f45d5e334782e7e809d3a28be5d1f04bd2f5a https://github.com/WebKit/WebKit/commit/dd4f45d5e334782e7e809d3a28be5d1f04bd2f5a Author: Yusuke Suzuki Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A JSTests/stress/weak-map-constructor-symbol.js A JSTests/stress/weak-set-constructor-symbol.js M Source/JavaScriptCore/runtime/WeakMapConstructor.cpp M Source/JavaScriptCore/runtime/WeakMapPrototype.cpp M Source/JavaScriptCore/runtime/WeakSetConstructor.cpp M Source/JavaScriptCore/runtime/WeakSetPrototype.cpp Log Message: --- [JSC] WeakMap / WeakSet constructor should accept symbols https://bugs.webkit.org/show_bug.cgi?id=247997 rdar://102440538 Reviewed by Alexey Shvayka. This patch fixes missing handling of symbols in WeakMap / WeakSet constructors. * JSTests/stress/weak-map-constructor-symbol.js: Added. (shouldBe): (shouldThrow): * JSTests/stress/weak-set-constructor-symbol.js: Added. (shouldBe): (shouldThrow): (test.set shouldThrow): * Source/JavaScriptCore/runtime/WeakMapConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/WeakMapPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/WeakSetConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/WeakSetPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/256758@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e015c5: [git-webkit] Improve logging when redacting PRs du...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e015c5839aca50f38f58fa3b6e145ced276c3e57 https://github.com/WebKit/WebKit/commit/e015c5839aca50f38f58fa3b6e145ced276c3e57 Author: Jonathan Bedard Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/Scripts/libraries/webkitbugspy/setup.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py Log Message: --- [git-webkit] Improve logging when redacting PRs due to the associated issue https://bugs.webkit.org/show_bug.cgi?id=247391 rdar://101886383 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py: (Tracker): Add NAME. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py: (Tracker): Add NAME. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py: (Issue.redacted): Return a Redaction object. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py: (Tracker): Add NAME. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py: (Tracker.Redaction): Instead of just returning 'True' or 'False', include a reason so that callers can better explain any behavior derived from redactions. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest.create_pull_request): Tell the user which issue reference we're considering the primary one and explain the reason that issue is redacted. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: Canonical link: https://commits.webkit.org/256757@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.12.11 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8afe4: [ews-build.webkit.org] Land from branch aliases
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8afe4b6ecf05585639c5758ac08641c520c3cb1 https://github.com/WebKit/WebKit/commit/c8afe4b6ecf05585639c5758ac08641c520c3cb1 Author: Jonathan Bedard Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/CISupport/ews-build/factories.py M Tools/CISupport/ews-build/factories_unittest.py M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- [ews-build.webkit.org] Land from branch aliases https://bugs.webkit.org/show_bug.cgi?id=247979 rdar://102419945 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/factories.py: (MergeQueueFactoryBase.__init__): Add MapBranchAlias step. * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps): Add 'map-branch-alias'. * Tools/CISupport/ews-build/steps.py: (MapBranchAlias): (MapBranchAlias.__init__): (MapBranchAlias.start): List all branches which contain the specified branch name. (MapBranchAlias.getResultSummary): (MapBranchAlias.evaluateCommand): If the specified branch is a production branch, use it. Otherwise, prefer a production branch with contains the specified branch. (MapBranchAlias.doStepIf): Map branch alias if the specified branch is 'main'. (MapBranchAlias.hideStepIf): Hide step if we aren't doing it. * Tools/CISupport/ews-build/steps_unittest.py: (TestMapBranchAlias): Canonical link: https://commits.webkit.org/256756@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec8ff5: Content downloaded with fetch() API when Content-E...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec8ff55e6568cd38eb629339e589d5d97c077d95 https://github.com/WebKit/WebKit/commit/ec8ff55e6568cd38eb629339e589d5d97c077d95 Author: Ryan Reno Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.html A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.js A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.sharedworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/resources/foo.octetstream.gz A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/resources/foo.octetstream.gz.headers A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/resources/foo.text.gz A LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/resources/foo.text.gz.headers M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/Modules/fetch/FetchLoader.cpp M Source/WebCore/loader/ResourceLoader.cpp M Source/WebCore/loader/ResourceLoader.h M Source/WebCore/loader/ResourceLoaderOptions.h M Source/WebCore/loader/ThreadableLoader.cpp M Source/WebCore/platform/network/BlobResourceHandle.cpp M Source/WebCore/platform/network/ResourceHandle.cpp M Source/WebCore/platform/network/ResourceHandle.h M Source/WebCore/platform/network/ResourceHandleInternal.h M Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp M Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp M Source/WebCore/platform/network/mac/ResourceHandleMac.mm M Source/WebCore/xml/XMLHttpRequest.cpp M Source/WebKit/NetworkProcess/NetworkLoadParameters.h M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Source/WebKitLegacy/WebCoreSupport/PingHandle.h Log Message: --- Content downloaded with fetch() API when Content-Encoding: gzip is set is not decompressed https://bugs.webkit.org/show_bug.cgi?id=247421 rdar://101935292 Reviewed by Brent Fulgham. In 195247@main we adopted CFNetwork SPI to opt-out of content encoding sniffing for XMLHttpRequest. Content encoding sniffing would cause responses with `Content-Encoding: gzip` and `Content-Type: application/octet-stream` to be treated as `Content-Type: application/gzip` and `Content-Encoding: identity` on macOS. The user and developer visible behavior is that the gzipped data is not decompressed. This brings that change forward to Fetch requests by setting the ContentEncodingSniffingPolicy flag in the FetchLoader. As an additional step this also renames the ContentEncodingSniffingPolicy flags to Default and Disable and replaces raw bools representing those flags with the enum itself. On iOS the flag has no effect since the default behavior is to opt-out of sniffing. * LayoutTests/platform/mac-wk1/TestExpectations: Skip new worker tests since workers are unsupported in WK1. * LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.html: Added. * LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.js: Added. (string_appeared_here.forEach.contentType.promise_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.serviceworker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.serviceworker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.sharedworker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.sharedworker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/fetch/content-encoding/gzip-body.any.worker-expected.txt:
[webkit-changes] [WebKit/WebKit] a8f967: [JSC] Date parse should accept narrow-no-break-space
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8f967cd42c5add143939660b7cd928375182377 https://github.com/WebKit/WebKit/commit/a8f967cd42c5add143939660b7cd928375182377 Author: Yusuke Suzuki Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M JSTests/complex.yaml A JSTests/complex/date-parse-with-narrow-no-break-space.js M Source/JavaScriptCore/runtime/JSDateMath.cpp M Source/WTF/wtf/unicode/CharacterNames.h Log Message: --- [JSC] Date parse should accept narrow-no-break-space https://bugs.webkit.org/show_bug.cgi?id=247986 rdar://102427399 Reviewed by Alexey Shvayka. After ICU 72, CLDR generates narrow-no-break-space for date time output. So, `new Date().toLocaleString('en-US')` starts generating a string including narrow-no-break-space instead of simple spaces. However since code in the wild assumes `new Date(new Date().toLocaleString('en-US'))` works, we need to maintain the ability to parse string including narrowNoBreakSpaces. Rough consensus among implementaters (V8, SpiderMonkey, and us) is replacing narrowNoBreakSpaces with simple spaces before parsing. * JSTests/complex.yaml: * JSTests/complex/date-parse-with-narrow-no-break-space.js: Added. (shouldBe): * Source/JavaScriptCore/runtime/JSDateMath.cpp: (JSC::DateCache::parseDate): * Source/WTF/wtf/unicode/CharacterNames.h: Canonical link: https://commits.webkit.org/256754@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c38857: Fix race in SuspendServiceWorkerProcessBasedOnClie...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c38857287101c28627eedc50ec964f3582448b80 https://github.com/WebKit/WebKit/commit/c38857287101c28627eedc50ec964f3582448b80 Author: Miguel Salinas Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/UIProcess/ProcessThrottler.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm Log Message: --- Fix race in SuspendServiceWorkerProcessBasedOnClientProcessesWithoutSeparateServiceWorkerProcess https://bugs.webkit.org/show_bug.cgi?id=247894 rdar://102320977 Reviewed by Chris Dumez. There is a race condition in SuspendServiceWorkerProcessBasedOnClientProcessesWithoutSeparateServiceWorkerProcess where the process may overwrite its throttle state after launching. * Source/WebKit/UIProcess/ProcessThrottler.cpp: (WebKit::ProcessThrottler::setThrottleState): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Canonical link: https://commits.webkit.org/256753@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42fd02: [ews] merge-queue fails to find reviewer on GitHub...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42fd020fc0c32ab8ef648cacc49fcbe3d2fd1a81 https://github.com/WebKit/WebKit/commit/42fd020fc0c32ab8ef648cacc49fcbe3d2fd1a81 Author: Jonathan Bedard Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- [ews] merge-queue fails to find reviewer on GitHub PRs with lots of review activity https://bugs.webkit.org/show_bug.cgi?id=243548 rdar://98129710 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (GitHubMixin): (GitHubMixin.get_reviewers): Handle pagination when retrieving reviews. Approval and rejection should override older approval or rejection. * Tools/CISupport/ews-build/steps_unittest.py: (TestGitHubMixin): (TestGitHubMixin.Response): Mock of request's response class. (TestGitHubMixin.test_no_reviewers): (TestGitHubMixin.test_single_review): (TestGitHubMixin.test_multipe_reviews): (TestGitHubMixin.test_retracted_review): (TestGitHubMixin.test_pagination): (TestGitHubMixin.test_reviewers_invalid_response): (TestGitHubMixin.test_reviewers_error): Canonical link: https://commits.webkit.org/256752@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 730967: Include WebFrame.h to fix the build.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 730967c22231603b7acd6abeb215e77a91e1cdf4 https://github.com/WebKit/WebKit/commit/730967c22231603b7acd6abeb215e77a91e1cdf4 Author: Timothy Hatcher Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.cpp Log Message: --- Include WebFrame.h to fix the build. Unreviewed build fix. * Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.cpp: Canonical link: https://commits.webkit.org/256751@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 608f6e: Open headers with the UTF-8 encoding when checking...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 608f6e06c4428612455d30db1e190097e6b74091 https://github.com/WebKit/WebKit/commit/608f6e06c4428612455d30db1e190097e6b74091 Author: Timothy Hatcher Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/Scripts/check-for-inappropriate-macros-in-external-headers M Tools/Scripts/check-for-webkit-framework-include-consistency Log Message: --- Open headers with the UTF-8 encoding when checking them. Unreviewed build fix. Some header now has UTF-8 in it, and that was causing these scripts to fail. The encoding isn't relevant to the scripts, so using UTF-8 is fine. * Tools/Scripts/check-for-inappropriate-macros-in-external-headers: * Tools/Scripts/check-for-webkit-framework-include-consistency: Canonical link: https://commits.webkit.org/256750@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a344c: Fix debug assertion failure in IndentOutdentComman...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a344c3387b2bfe58dc8c8a94b1683187effef2e https://github.com/WebKit/WebKit/commit/8a344c3387b2bfe58dc8c8a94b1683187effef2e Author: Miguel Salinas Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A LayoutTests/editing/execCommand/indent-user-select-all-blockquotes-expected.txt A LayoutTests/editing/execCommand/indent-user-select-all-blockquotes.html M Source/WebCore/editing/IndentOutdentCommand.cpp Log Message: --- Fix debug assertion failure in IndentOutdentCommand::indentIntoBlockquote https://bugs.webkit.org/show_bug.cgi?id=240377 rdar://93236442 Reviewed by Ryosuke Niwa. When indenting an element into a new uneditable blockquote we end up replacing the element with an empty blockquote instead of indenting. This also fails an assert in debug builds. We should just bail out instead of trying to indent if the blockquote is not editable. * LayoutTests/editing/execCommand/indent-user-select-all-blockquotes-expected.txt: Added. * LayoutTests/editing/execCommand/indent-user-select-all-blockquotes.html: Added. * Source/WebCore/editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentIntoBlockquote): Canonical link: https://commits.webkit.org/256749@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89a1de: REGRESSION (251289@main): [ Ventura ] fast/images/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89a1de42b3478a76bbd6308541bb51e4bb6a2b9a https://github.com/WebKit/WebKit/commit/89a1de42b3478a76bbd6308541bb51e4bb6a2b9a Author: Karl Rackler Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- REGRESSION (251289@main): [ Ventura ] fast/images/animated-heics-draw.html is a consistent timeout https://bugs.webkit.org/show_bug.cgi?id=247982 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: This commit include: REGRESSION (251289@main): [ Ventura+ ] fast/images/animated-heics-draw.html is a consistent timeout https://bugs.webkit.org/show_bug.cgi?id=247982 Unreviewed test gardening. add plus * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/256748@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0080cc: Hook up the WebProcess objects for Web Extensions ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0080cc8363bfda7701fe208f44a51c01385d4f44 https://github.com/WebKit/WebKit/commit/0080cc8363bfda7701fe208f44a51c01385d4f44 Author: Timothy Hatcher Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Shared/WebExtensionContextParameters.h M Source/WebKit/Shared/WebExtensionContextParameters.serialization.in M Source/WebKit/Shared/WebExtensionControllerParameters.h M Source/WebKit/Shared/WebExtensionControllerParameters.serialization.in M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtension.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp M Source/WebKit/UIProcess/Extensions/WebExtensionController.h M Source/WebKit/UIProcess/Extensions/WebExtensionMatchPattern.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIExtensionCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIObject.h M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIRuntime.h M Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.h M Source/WebKit/WebProcess/Extensions/Bindings/Scripts/CodeGeneratorExtensions.pm A Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.cpp M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.cpp M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h Log Message: --- Hook up the WebProcess objects for Web Extensions and propogate some info over. Inject the browser and chrome namespace objects into Web Extension JS contexts. Implement the simple methods on browser.runtime and browser.extension that had FIXMEs. https://bugs.webkit.org/show_bug.cgi?id=247964 Reviewed by Brian Weinstein. * Source/WebKit/Scripts/webkit/messages.py: (serialized_identifiers): * Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp: (IPC::serializedIdentifiers): * Source/WebKit/Shared/WebExtensionContextParameters.h: * Source/WebKit/Shared/WebExtensionContextParameters.serialization.in: * Source/WebKit/Shared/WebExtensionControllerParameters.h: * Source/WebKit/Shared/WebExtensionControllerParameters.serialization.in: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::operator== const): Added for easy equality checks. (WebKit::AuxiliaryProcessProxy::operator!= const): Ditto. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm: (WebKit::WebExtensionController::load): (WebKit::WebExtensionController::unload): (WebKit::WebExtensionController::addPage): (WebKit::WebExtensionController::removePage): * Source/WebKit/UIProcess/Extensions/WebExtension.h: (WebKit::WebExtension::operator!= const): Changed style to match others. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp: (WebKit::WebExtensionContext::parameters const): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: (WebKit::WebExtensionContext::operator== const): Added for easy equality checks. (WebKit::WebExtensionContext::operator!= const): Ditto. (WebKit::WebExtensionContext::baseURL const): * Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp: (WebKit::WebExtensionController::parameters const): * Source/WebKit/UIProcess/Extensions/WebExtensionController.h: (WebKit::WebExtensionController::operator== const): Added for easy equality checks. (WebKit::WebExtensionController::operator!= const): Ditto. * Source/WebKit/UIProcess/Extensions/WebExtensionMatchPattern.h: (WebKit::WebExtensionMatchPattern::operator!= const): * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.cpp: (WebKit::WebExtensionContextProxy::get): (WebKit::WebExtensionContextProxy::getOrCreate): (WebKit::WebExtensionContextProxy::WebExtensionContextProxy): * Source/We
[webkit-changes] [WebKit/WebKit] 1e49c3: Add HeaderDoc comments to the Web Extension headers.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e49c3463baf4ccdb7f56120c1af54d4564918df https://github.com/WebKit/WebKit/commit/1e49c3463baf4ccdb7f56120c1af54d4564918df Author: Timothy Hatcher Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionPermission.h Log Message: --- Add HeaderDoc comments to the Web Extension headers. https://bugs.webkit.org/show_bug.cgi?id=247844 Reviewed by Brian Weinstein. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext setPermissionState:forURL:]): Drive-by. Add missing assert. (-[_WKWebExtensionContext setPermissionState:forURL:expirationDate:]): Ditto. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionPermission.h: Canonical link: https://commits.webkit.org/256746@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34128a: Report WebCodecsVideoFrame memoryCost
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34128a822f3670002871d33dbfa4a01d1c6b95a3 https://github.com/WebKit/WebKit/commit/34128a822f3670002871d33dbfa4a01d1c6b95a3 Author: Youenn Fablet Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.h M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.idl M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrameData.h M Source/WebCore/bindings/js/SerializedScriptValue.cpp Log Message: --- Report WebCodecsVideoFrame memoryCost https://bugs.webkit.org/show_bug.cgi?id=247720 rdar://problem/102182069 Reviewed by Eric Carlson. Report a rough estimate of WebCodecs Video Frame size. We compute the size as if it is RGBA as a good enough estimate, though NV12 would be smaller for instance. * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.h: (WebCore::WebCodecsVideoFrame::memoryCost const): * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.idl: * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrameData.h: (WebCore::WebCodecsVideoFrameData::memoryCost const): * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::computeMemoryCost const): Canonical link: https://commits.webkit.org/256745@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1999d4: WKDownloadProgress should write its progress as an...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1999d432f1a35cb558900f79f21fb8cbd38aaacc https://github.com/WebKit/WebKit/commit/1999d432f1a35cb558900f79f21fb8cbd38aaacc Author: David Quesada Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm Log Message: --- WKDownloadProgress should write its progress as an xattr when unpublishing https://bugs.webkit.org/show_bug.cgi?id=247904 rdar://102250986 Reviewed by Alexey Proskuryakov. When unpublishing the NSProgress associated with a download, write an xattr on the progress file that reflects the fraction of progress made on the download. (or -1 if a download of indeterminate length) This leaves a record of the progress for outside observers to reflect if they encounter a file that represents a partially completed download that happens to be paused, and therefore doesn't have a live NSProgress. * Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm: (-[WKDownloadProgress unpublish]): (-[WKDownloadProgress _updateProgressExtendedAttributeOnProgressFile]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: (-[DownloadProgressTestRunner init]): (-[DownloadProgressTestRunner dealloc]): On creation/deallocation of the test runner, create and delete the file being used to publish progress. This file needs to actually exist for the purposes of the new test. (-[DownloadProgressTestRunner progressURL]): (TEST): DownloadProgress.ProgressExtendedAttributeSetAfterPartialDownloadStops: Start a download and pause it, partway through, then assert that the progress file has an extended attribute set that reflects the fraction of the progress made through the download. Canonical link: https://commits.webkit.org/256744@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.12.110.2 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85600f: Versioning.
Branch: refs/heads/safari-7615.1.12.110-branch Home: https://github.com/WebKit/WebKit Commit: 85600f534213ddef6fca8c8e1dd3e752ea310921 https://github.com/WebKit/WebKit/commit/85600f534213ddef6fca8c8e1dd3e752ea310921 Author: Alan Coon Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.12.110.2 Canonical link: https://commits.webkit.org/256138.30@safari-7615.1.12.110-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 876acc: Evaluate right-hand-side of assignment before TDZ ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 876accfa73f6d4613d489f23a88b20e827cfbc73 https://github.com/WebKit/WebKit/commit/876accfa73f6d4613d489f23a88b20e827cfbc73 Author: David Degazio Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A JSTests/stress/assignment-side-effects-before-tdz-check.js M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- Evaluate right-hand-side of assignment before TDZ check https://bugs.webkit.org/show_bug.cgi?id=247787 rdar://102324888 Reviewed by Yusuke Suzuki. When we assign to a variable in its TDZ, we currently always do a TDZ check before evaluating anything else. However, per the spec, we should actually be evaluating the right-hand-side value before putting it into the destination - potentially resulting in observable side-effects like throwing an exception. This patch makes it so we add a TDZ check only after evaluating the right-hand-side expression in assignment expressions. We shouldn't need this for any read-modify-assignment expressions (i.e. +=, &&=) since those are supposed to read the TDZ-checked value before evaluating the right. * JSTests/stress/assignment-side-effects-before-tdz-check.js: Added. (catch): (try.x): * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::AssignResolveNode::emitBytecode): Canonical link: https://commits.webkit.org/256743@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 267e69: [GTK] Crash on authentication dialog with GTK 4
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 267e69155f831540e8db927613f7b86de673d88f https://github.com/WebKit/WebKit/commit/267e69155f831540e8db927613f7b86de673d88f Author: Madhu Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp Log Message: --- [GTK] Crash on authentication dialog with GTK 4 https://bugs.webkit.org/show_bug.cgi?id=246852 Reviewed by Michael Catanzaro fix gtk4 auth dialog crashes. take three * Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: (okButtonClicked): `rememberPassword' is a GtkCheckButton in gtk4, doesn't inherit Button or ToggleButton. fix cast. (webkitAuthenticationDialogInitialize): `rememberCheckButton' is a GtkCheckButton which in Gtk4 apparently gets created with a label property and no explicit label child. Do not set the the line wrap property on a non-existent label. (webkitAuthenticationDialogInitialize): `rememberCheckButton', adjust for CheckButton changes in gtk4. (webkitAuthenticationDialogUnmap): new. Implementation unsets the default window widget which is set in webkitAuthenticationDialogMap. Avoids the gtk4 crash reported in bug. (webkit_authentication_dialog_class_init): hook in the above. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: "focus" is not a valid signal for gtk4's widgets such as the WebKitAutheticationDialog. implement "move-focus" instead, to handle the situation when a dialog is active and weforward focus events to it, and we can tab between elements in the box. Presently there is a problem: if you tab past the last element in the dialog box you cannot get back in. (webkitWebViewBaseMoveFocus): new. implementation which will be called when someone emits a move-focus signal on us. Canonical link: https://commits.webkit.org/256742@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a2054f: REGRESSION (Ventura): [ Ventura+ ] TestWebKitAPI.S...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a2054f59c10a9e641d7b8d49bbc4a6841cbcbe35 https://github.com/WebKit/WebKit/commit/a2054f59c10a9e641d7b8d49bbc4a6841cbcbe35 Author: Youenn Fablet Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm Log Message: --- REGRESSION (Ventura): [ Ventura+ ] TestWebKitAPI.ServiceWorker.ServiceWorkerWindowClientFocus is a constant failure https://bugs.webkit.org/show_bug.cgi?id=247928 rdar://problem/102346207 Reviewed by Eric Carlson. Make sure to set label in DisplayCaptureSourceCocoa sources. Update GetDisplayMediaWindowAndScreen.mm test so that sleep disabler happens when capture happens and does not happen when capture does not happen. * Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp: (WebCore::DisplayCaptureSourceCocoa::settings): * Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/256741@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9d3776: REGRESSION (251289@main): [ Ventura ] fast/images/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d37767bbcc9ebd5c008060ea21ef07cec2edafe https://github.com/WebKit/WebKit/commit/9d37767bbcc9ebd5c008060ea21ef07cec2edafe Author: Karl Rackler Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- REGRESSION (251289@main): [ Ventura ] fast/images/animated-heics-draw.html is a consistent timeout https://bugs.webkit.org/show_bug.cgi?id=247982 rdar://102421055 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/256735@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad1302: Add numeric identifier to generated getter name
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad1302fe8297f628d73984d072f423c1f629fbfa https://github.com/WebKit/WebKit/commit/ad1302fe8297f628d73984d072f423c1f629fbfa Author: David Degazio Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A JSTests/stress/numeric-getter-has-correct-name.js M LayoutTests/js/script-tests/function-toString-vs-name.js M Source/JavaScriptCore/parser/ASTBuilder.h Log Message: --- Add numeric identifier to generated getter name https://bugs.webkit.org/show_bug.cgi?id=247424 rdar://101940115 Reviewed by Justin Michaud. Adds a call to set the ECMA property name for a generated getter/setter when the property name is a numeric identifier. With this change, we include the property name in the name of the new getter/setter, i.e. 'get 0' instead of 'get '. * JSTests/stress/numeric-getter-has-correct-name.js: Added. (x.prototype.get 0): (x): * LayoutTests/js/script-tests/function-toString-vs-name.js: * Source/JavaScriptCore/parser/ASTBuilder.h: (JSC::ASTBuilder::createGetterOrSetterProperty): Canonical link: https://commits.webkit.org/256740@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 688c51: Prevent WebCodecs encoder and decoder from being G...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 688c513969e45393eab4da4d912b2e9eda4fdd94 https://github.com/WebKit/WebKit/commit/688c513969e45393eab4da4d912b2e9eda4fdd94 Author: Youenn Fablet Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A LayoutTests/http/wpt/webcodecs/webcodecs-gc-expected.txt A LayoutTests/http/wpt/webcodecs/webcodecs-gc.html M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h Log Message: --- Prevent WebCodecs encoder and decoder from being GCed in case they are flushing https://bugs.webkit.org/show_bug.cgi?id=247941 rdar://problem/102360806 Reviewed by Eric Carlson. Add a m_isFlushing boolean to encoder and decoder. Forbidd GC when m_isFlushing is true. Set m_isFlushing to true when flush is called and corresponding promise is not resolved. * LayoutTests/http/wpt/webcodecs/webcodecs-gc-expected.txt: Added. * LayoutTests/http/wpt/webcodecs/webcodecs-gc.html: Added. * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp: (WebCore::WebCodecsVideoDecoder::~WebCodecsVideoDecoder): (WebCore::WebCodecsVideoDecoder::configure): (WebCore::WebCodecsVideoDecoder::decode): (WebCore::WebCodecsVideoDecoder::flush): (WebCore::WebCodecsVideoDecoder::virtualHasPendingActivity const): * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h: * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp: (WebCore::WebCodecsVideoEncoder::flush): (WebCore::WebCodecsVideoEncoder::virtualHasPendingActivity const): * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h: Canonical link: https://commits.webkit.org/256739@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e9041b: Resync fetch WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e9041b9ec42e1b7336f93101d7ab4df67fbea996 https://github.com/WebKit/WebKit/commit/e9041b9ec42e1b7336f93101d7ab4df67fbea996 Author: Ryan Reno Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/fetch/META.yml A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/cache.https.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/cache.https.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/cache.https.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/cache.https.any.sharedworker.html M LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any.js A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any.sharedworker.html M LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any.js A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any.sharedworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/request.any.worker.html M LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html M LayoutTests/imported/w3c/web-platform-tests/fetch/api/abort/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.any.sharedworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.any.sharedworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/error-after-response.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/error-after-response.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/error-after-response.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/error-after-response.any.sharedworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.sharedworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/header-value-null-byte.any.serviceworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/header-value-null-byte.any.serviceworker.html A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/header-value-null-byte.any.sharedworker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/header-value-null-byte.any.sharedworker.html A LayoutTests/imported/w3c/web-platfor
[webkit-changes] [WebKit/WebKit] c985ac: [WPE][GTK] web process leak if webkit_download_set...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c985acc37157f1ac8e7601e494ebd71bd76e6509 https://github.com/WebKit/WebKit/commit/c985acc37157f1ac8e7601e494ebd71bd76e6509 Author: Yury Semikhatsky Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp Log Message: --- [WPE][GTK] web process leak if webkit_download_set_destination is called with empty destination https://bugs.webkit.org/show_bug.cgi?id=242217 Reviewed by Michael Catanzaro. Fail if download destination is set to "". * Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp: (webkit_download_set_destination): Canonical link: https://commits.webkit.org/256737@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85605e: REGRESSION (256576@main): P3 WebGL canvases get fl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85605e6892da22a97fcb626e9cd11ab336f8f9bd https://github.com/WebKit/WebKit/commit/85605e6892da22a97fcb626e9cd11ab336f8f9bd Author: Simon Fraser Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm Log Message: --- REGRESSION (256576@main): P3 WebGL canvases get flattened to sRGB https://bugs.webkit.org/show_bug.cgi?id=247965 rdar://102395564 Reviewed by Kimmo Kinnunen. `setDisplayBuffer` was explicitly asking for an sRGB colorspace, which was now respected after 256576@main. Pass std::nullopt to use the colorspace of the source IOSurface. There are no tests for this. * Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm: Canonical link: https://commits.webkit.org/256736@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 94d6cf: [GTK] Documentation of WebKitSettings:hardware-acc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 94d6cf2aa8cd2d2d1fb1f07acab0172e338d3c23 https://github.com/WebKit/WebKit/commit/94d6cf2aa8cd2d2d1fb1f07acab0172e338d3c23 Author: Michael Catanzaro Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp Log Message: --- [GTK] Documentation of WebKitSettings:hardware-acceleration-policy mentions old default value https://bugs.webkit.org/show_bug.cgi?id=247957 Reviewed by Carlos Garcia Campos. This fixes the documentation to not refer to any particular default value. I considered referencing that the default value changed in 2.36.4, but this is difficult to do without referencing WEBKIT_HARDWARE_ACCELERATION_POLICY_ON_DEMAND, which is about to disappear in the new API version, so it seemed less awkward to just omit it. It's expected that settings will change default values over time, after all. I've also made a few drive-by tweaks. * Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: (webkit_settings_class_init): Canonical link: https://commits.webkit.org/256734@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 31d68e: Further adoption of the new CoreIPC serialization ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 31d68e08a6df7f911ec6647984d5a264a291 https://github.com/WebKit/WebKit/commit/31d68e08a6df7f911ec6647984d5a264a291 Author: Simon Lewis Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/platform/graphics/PlatformTimeRanges.cpp M Source/WebCore/platform/graphics/PlatformTimeRanges.h M Source/WebCore/platform/graphics/VideoPlaybackQualityMetrics.h M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h A Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.serialization.in Log Message: --- Further adoption of the new CoreIPC serialization mechanism for RemoteMediaPlayerState. https://bugs.webkit.org/show_bug.cgi?id=247825. rdar://102255168. Reviewed by Alex Christensen. * Source/WebCore/platform/graphics/PlatformTimeRanges.cpp: (WebCore::PlatformTimeRanges::invert): (WebCore::PlatformTimeRanges::unionWith): (WebCore::PlatformTimeRanges::start const): (WebCore::PlatformTimeRanges::end const): (WebCore::PlatformTimeRanges::duration const): (WebCore::PlatformTimeRanges::maximumBufferedTime const): (WebCore::PlatformTimeRanges::add): (WebCore::PlatformTimeRanges::copyWithEpsilon const): * Source/WebCore/platform/graphics/PlatformTimeRanges.h: (WebCore::PlatformTimeRanges::encode const): Deleted. (WebCore::PlatformTimeRanges::decode): Deleted. * Source/WebCore/platform/graphics/VideoPlaybackQualityMetrics.h: (WebCore::VideoPlaybackQualityMetrics::encode const): Deleted. (WebCore::VideoPlaybackQualityMetrics::decode): Deleted. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h: (WebKit::RemoteMediaPlayerState::encode const): Deleted. (WebKit::RemoteMediaPlayerState::decode): Deleted. * Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.serialization.in: Added. Canonical link: https://commits.webkit.org/256733@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e16ea: Fix checking for XKB support in libwpe 1.12.x
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e16ea8ff277a877d5f889389eb83e0fd176d728 https://github.com/WebKit/WebKit/commit/4e16ea8ff277a877d5f889389eb83e0fd176d728 Author: Olivier Blin Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/cmake/FindWPE.cmake Log Message: --- Fix checking for XKB support in libwpe 1.12.x https://bugs.webkit.org/show_bug.cgi?id=247973 Reviewed by Adrian Perez de Castro and Michael Catanzaro. * Source/cmake/FindWPE.cmake: FindWPE enabled XKB support for all versions less than or equal to 1.12.0 (see r292064), but this should also be enabled for all 1.12.x point releases. Canonical link: https://commits.webkit.org/256732@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] daf8b0: [Safari 16 regression] service worker download doe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: daf8b0ba46a83dd93ba488b73557960e01e02c7a https://github.com/WebKit/WebKit/commit/daf8b0ba46a83dd93ba488b73557960e01e02c7a Author: Youenn Fablet Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-use-download-and-clone.https-expected.txt A LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-use-download-and-clone.https.html A LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-use-download.https-expected.txt A LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-use-download.https.html M LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-worker.js M LayoutTests/platform/glib/TestExpectations A LayoutTests/platform/ios-wk2/http/wpt/service-workers/fetch-service-worker-preload-use-download-and-clone.https-expected.txt A LayoutTests/platform/ios-wk2/http/wpt/service-workers/fetch-service-worker-preload-use-download.https-expected.txt M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp Log Message: --- [Safari 16 regression] service worker download does not work in case of preloads https://bugs.webkit.org/show_bug.cgi?id=247885 rdar://problem/102312723 Reviewed by Alex Christensen and Geoffrey Garen. When a fetch is converted to download and is served from a service worker that uses a preload, we should use that preload. * LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-use-download.https-expected.txt: Added. * LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-use-download.https.html: Added. * LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-use-download-and-clone.https-expected.txt: Added. * LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-use-download-and-clone.https.html: Added. * LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-worker.js: (event.event.request.url.includes): Deleted. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/ios-wk2/http/wpt/service-workers/fetch-service-worker-preload-use-download-and-clone.https-expected.txt: Added. * LayoutTests/platform/ios-wk2/http/wpt/service-workers/fetch-service-worker-preload-use-download.https-expected.txt: Added. * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp: (WebKit::ServiceWorkerFetchTask::convertToDownload): Canonical link: https://commits.webkit.org/256731@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8f48b8: AX: Optimize shouldIgnoreGroup to avoid calling Ac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f48b85eab582b7016e0e116f20a6ca3c56dcdb0 https://github.com/WebKit/WebKit/commit/8f48b85eab582b7016e0e116f20a6ca3c56dcdb0 Author: Andres Gonzalez Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm Log Message: --- AX: Optimize shouldIgnoreGroup to avoid calling AccessibilityObject::textUnderElement unnecessarily. https://bugs.webkit.org/show_bug.cgi?id=247948 Reviewed by Chris Fleizach. Perform the least costly checks first. AccessibilityObject::textUnderElement can be problematic and costly, so avoid calling it in all possible cases. * Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm: (WebCore::shouldIgnoreGroup): Canonical link: https://commits.webkit.org/256730@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fac3f: RemoteAudioDestinationProxy base class is platform...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fac3faf1d5b167d9fbbd9bf4555c133718f5044 https://github.com/WebKit/WebKit/commit/3fac3faf1d5b167d9fbbd9bf4555c133718f5044 Author: Kimmo Kinnunen Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/audio/AudioDestination.h A Source/WebCore/platform/audio/AudioDestinationResampler.cpp A Source/WebCore/platform/audio/AudioDestinationResampler.h M Source/WebCore/platform/audio/PushPullFIFO.h M Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp M Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.h A Source/WebCore/platform/audio/cocoa/AudioUtilitiesCocoa.cpp A Source/WebCore/platform/audio/cocoa/AudioUtilitiesCocoa.h M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h M Source/WebCore/platform/mock/MockAudioDestinationCocoa.cpp M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.h Log Message: --- RemoteAudioDestinationProxy base class is platform specific https://bugs.webkit.org/show_bug.cgi?id=247802 rdar://problem/102238646 Reviewed by Eric Carlson. The ifdefing causes problems when passing the needed information to RemoteAudioDestinationManager::CreateAudioDestination. Due to this, the GPUP side instance is created with CreateAudioDestination+AudioSamplesStorageChanged message, which causes other problems. Instead, extract the needed platform-agnostic logic from AudioDestinationCocoa to AudioDestinationResampler. Use AudioDestinationResampler as the base-class of RemoteAudioDestinationProxy, as that is the way the data is transferred currently. This is preliminary work to be able to make CARingBuffer as a platform-agnostic AudioRingBuffer, in order to pass the ring buffer during the remote audio destination creation. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/audio/AudioDestination.h: (WebCore::AudioDestination::sampleRate const): (WebCore::AudioDestination::AudioDestination): * Source/WebCore/platform/audio/PushPullFIFO.h: * Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp: (WebCore::AudioDestinationCocoa::AudioDestinationCocoa): (WebCore::AudioDestinationCocoa::render): (WebCore::AudioDestinationCocoa::numberOfOutputChannels const): Deleted. (WebCore::AudioDestinationCocoa::framesPerBuffer const): Deleted. (WebCore::AudioDestinationCocoa::start): Deleted. (WebCore::AudioDestinationCocoa::stop): Deleted. (WebCore::AudioDestinationCocoa::setIsPlaying): Deleted. (WebCore::AudioDestinationCocoa::getAudioStreamBasicDescription): Deleted. (WebCore::assignAudioBuffersToBus): Deleted. (WebCore::AudioDestinationCocoa::hasEnoughFrames const): Deleted. (WebCore::AudioDestinationCocoa::renderOnRenderingTheadIfPlaying): Deleted. (WebCore::AudioDestinationCocoa::renderOnRenderingThead): Deleted. * Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.h: (): Deleted. * Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h: * Source/WebCore/platform/mock/MockAudioDestinationCocoa.cpp: (WebCore::MockAudioDestinationCocoa::tick): * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateScrollingNodeForViewportConstrainedRole): * Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp: (WebKit::RemoteAudioDestinationProxy::create): (WebKit::RemoteAudioDestinationProxy::RemoteAudioDestinationProxy): (WebKit::RemoteAudioDestinationProxy::connection): (WebKit::RemoteAudioDestinationProxy::startRendering): (WebKit::RemoteAudioDestinationProxy::stopRendering): (WebKit::RemoteAudioDestinationProxy::renderQuantum): * Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.h: Canonical link: https://commits.webkit.org/256729@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c148a2: Animation.commitStyles() doesn't change "style" at...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c148a252e8ff4bb32d7537cb35638741cf6fe9d5 https://github.com/WebKit/WebKit/commit/c148a252e8ff4bb32d7537cb35638741cf6fe9d5 Author: Antoine Quint Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html M Source/WebCore/animation/WebAnimation.cpp M Source/WebCore/css/ComputedStyleExtractor.cpp Log Message: --- Animation.commitStyles() doesn't change "style" attribute for individual CSS transform properties https://bugs.webkit.org/show_bug.cgi?id=247245 rdar://102014524 Reviewed by Antti Koivisto. When commitStyles() is called a null renderer is passed down to ComputedStyleExtractor::valueForPropertyInStyle(). This would make the various functions computing values for individual transform properties return "none" since those would check for a non-null, non-inline renderer. We change those checks to only check for an inline renderer to return "none". We also had to make a change to how we call MutableStyleProperties::setProperty() in commitStyles() to provide an explicit CSSParserContext created for the styled element's document such that we have valid settings. Otherwise, properties governed by a runtime flag, such as the individual transform properties, would show as disabled and we would hit an ASSERT_NOT_REACHED under MutableStyleProperties::setProperty(). Finally, we add a new WPT test to check that commitStyles() correctly commits individual transform properties to the inline style. * LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html: * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::commitStyles): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::computedTranslate): (WebCore::computedScale): (WebCore::computedRotate): (WebCore::rendererCanBeTransformed): Deleted. Canonical link: https://commits.webkit.org/256728@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da44a7: REGRESSION (Ventura): [ macOS ] 2X TestWebKitAPI.S...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da44a798c8a12288aacb2163909b6e3e859a4401 https://github.com/WebKit/WebKit/commit/da44a798c8a12288aacb2163909b6e3e859a4401 Author: Kimmo Kinnunen Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm Log Message: --- REGRESSION (Ventura): [ macOS ] 2X TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringMiniaturization (API-Tests) are constant failures https://bugs.webkit.org/show_bug.cgi?id=247924 rdar://problem/102343029 Reviewed by Darin Adler. The test assumed that actions to NSWindows or NSApp reflect synchronously back to the notifications. This is not the case. Ensure that the test expects asynchronous operation. Fix incorrect adoptNS() for notification center observers. The add function is not a NS creation function, and as such it doesn't return an adoptable ref. * Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/256727@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 63145f: Safari reuses Authorization header on second call ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63145fa91bb8fb40c7103b9971d7292b6a3e0517 https://github.com/WebKit/WebKit/commit/63145fa91bb8fb40c7103b9971d7292b6a3e0517 Author: Youenn Fablet Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A LayoutTests/http/wpt/fetch/fetch-permanent-redirect-same-origin-authorization-expected.txt A LayoutTests/http/wpt/fetch/fetch-permanent-redirect-same-origin-authorization.html A LayoutTests/http/wpt/fetch/resources/dump-authorization-header.py A LayoutTests/http/wpt/fetch/resources/redirect301.py M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/NetworkProcess/cache/NetworkCache.cpp M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm Log Message: --- Safari reuses Authorization header on second call to 301 redirects even if the header value changed when replaying the request https://bugs.webkit.org/show_bug.cgi?id=247418 rdar://problem/101935060 Reviewed by Chris Dumez. In case of serving a redirection from HTTP cache, we cannot reuse the Authorization header of the past redirect request. Instead, we should reuse the latest request Authorization header. To do this, we remove Authorization header from stored redirected requests in network cache. This handles the case of a cached redirection stored with authorization and reused without authorization. We also move the NetworkDataTaskCocoa code used to reuse the original request Authorization header to NetworkResourceLoader, so that it handles both the cache code path as well as the regular network code path. * LayoutTests/http/wpt/fetch/fetch-permanent-redirect-same-origin-authorization-expected.txt: Added. * LayoutTests/http/wpt/fetch/fetch-permanent-redirect-same-origin-authorization.html: Added. * LayoutTests/http/wpt/fetch/resources/dump-authorization-header.py: Added. (main): * LayoutTests/http/wpt/fetch/resources/redirect301.py: Added. (main): * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::willSendRedirectedRequestInternal): * Source/WebKit/NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::Cache::makeRedirectEntry): * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection): Canonical link: https://commits.webkit.org/256726@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 30bd76: Clicking a link to a download file served by a ser...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30bd7667b181ed333be95ebfc8a24617c7ebaab6 https://github.com/WebKit/WebKit/commit/30bd7667b181ed333be95ebfc8a24617c7ebaab6 Author: Youenn Fablet Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/loader/DocumentLoader.cpp Log Message: --- Clicking a link to a download file served by a service-worker with a fetch event handler yields "Frame load interrupted" error https://bugs.webkit.org/show_bug.cgi?id=247793 rdar://problem/102296700 Web Inspector shows the "Frame load interrupted" error based on the sub resource load failing error. Mark the error type as Cancellation so that Web Inspector does not show this message. Reviewed by Alex Christensen. * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::interruptedForPolicyChangeError const): (WebCore::DocumentLoader::stopLoadingForPolicyChange): Canonical link: https://commits.webkit.org/256725@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c13598: Make containing block of position:fixed dialog chi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c13598861f4027d8876901ae7e4c2ecb8661f6d8 https://github.com/WebKit/WebKit/commit/c13598861f4027d8876901ae7e4c2ecb8661f6d8 Author: Rob Buis Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-contain-ancestor-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-contain-ancestor.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-fixed-position-cb-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-fo-ancestor-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-fo-ancestor.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-transformed-ancestor-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-transformed-ancestor.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-will-change-ancestor-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-will-change-ancestor.html M Source/WebCore/rendering/RenderObject.cpp Log Message: --- Make containing block of position:fixed dialog children the viewport https://bugs.webkit.org/show_bug.cgi?id=247951 rdar://99242889 Reviewed by Alan Baradlay. Make containing block of position:fixed dialog children the viewport, since basically the dialog is reparented to the root [1] and following the rules for determining the fixed positioned element [2] the viewport will be the nearest ancestor box that establishes a fixed positioning containing block. Add WPT tests involving alll possible dialog ancestors that can stablish a fixed positioning containing block. [1] https://fullscreen.spec.whatwg.org/#new-stacking-layer [2] https://drafts.csswg.org/css-position/#fixed-cb * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-contain-ancestor-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-contain-ancestor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-fixed-position-cb-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-fo-ancestor-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-fo-ancestor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-transformed-ancestor-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-transformed-ancestor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-will-change-ancestor-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-will-change-ancestor.html: Added. * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlockForPositionType): (WebCore::containerForElement): Canonical link: https://commits.webkit.org/256724@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ef6010: HTMLImageElement and FormAssociatedElement should ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ef6010c748c31c90591255ac6fd6a33bc25e0429 https://github.com/WebKit/WebKit/commit/ef6010c748c31c90591255ac6fd6a33bc25e0429 Author: Ryosuke Niwa Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebCore/html/FormAssociatedElement.h Log Message: --- HTMLImageElement and FormAssociatedElement should share more code https://bugs.webkit.org/show_bug.cgi?id=247936 Unreviewed. Addressing Chris' review comments. * Source/WebCore/html/FormAssociatedElement.h: Canonical link: https://commits.webkit.org/256723@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes