[webkit-changes] [WebKit/WebKit] ce361a: Add deprecation guards for various AVFoundation calls
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce361abc6ad80a0353e8af5115af58af333c1dd4 https://github.com/WebKit/WebKit/commit/ce361abc6ad80a0353e8af5115af58af333c1dd4 Author: Dean Jackson Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm Log Message: --- Add deprecation guards for various AVFoundation calls https://bugs.webkit.org/show_bug.cgi?id=248794 Reviewed by Antoine Quint. * Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm: (PAL::OutputDevice::name const): * Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm: (WebCore::CDMSessionAVFoundationObjC::generateKeyRequest): * Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm: (WebCore::ImageDecoderAVFObjC::firstEnabledTrack): Canonical link: https://commits.webkit.org/257395@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 850ed7: Skip test waitasync-waiter-list-order.js
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 850ed7230d759df7ae421bf97a598eb14f3dd5fc https://github.com/WebKit/WebKit/commit/850ed7230d759df7ae421bf97a598eb14f3dd5fc Author: Yijia Huang Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M JSTests/stress/waitasync-waiter-list-order.js Log Message: --- Skip test waitasync-waiter-list-order.js https://bugs.webkit.org/show_bug.cgi?id=248807 rdar://103013518 Reviewed by Yusuke Suzuki. Temporarily skip the test until https://github.com/WebKit/WebKit/pull/7048 fixes the race condition issue for waitAsync. * JSTests/stress/waitasync-waiter-list-order.js: Canonical link: https://commits.webkit.org/257394@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5f769b: [Live Range Selection] editing/spelling/spelling-l...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5f769b008b9e59bc86d0bf1b3670a72a68a06a52 https://github.com/WebKit/WebKit/commit/5f769b008b9e59bc86d0bf1b3670a72a68a06a52 Author: Ryosuke Niwa Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M LayoutTests/editing/spelling/spelling-linebreak.html Log Message: --- [Live Range Selection] editing/spelling/spelling-linebreak.html fails https://bugs.webkit.org/show_bug.cgi?id=248791 Reviewed by Wenson Hsieh. Use a valid offset to set the selection at the end of the target element. * LayoutTests/editing/spelling/spelling-linebreak.html: Canonical link: https://commits.webkit.org/257393@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da2296: [JSC] Use getIfPropertyExists instead of hasProper...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da22966f8e5eb32c035454a25df1fd6f8b52c122 https://github.com/WebKit/WebKit/commit/da22966f8e5eb32c035454a25df1fd6f8b52c122 Author: Yusuke Suzuki Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/JavaScriptCore/runtime/ObjectConstructor.cpp Log Message: --- [JSC] Use getIfPropertyExists instead of hasProperty+get https://bugs.webkit.org/show_bug.cgi?id=248756 rdar://102973977 Reviewed by Ross Kirsling and Justin Michaud. hasProperty+get should be done separately since this two operations are observable (e.g. Proxy will see them differently). But for most of objects, they can be done by one getPropertySlot. JSObject::getIfPropertyExists can handle this case and automatically does efficient hasProperty+get combination. We should use it for toPropertyDescriptor. ToT Patched redefine-property-accessor-dictionary6.6732+-0.0235 ^ 6.1863+-0.0115^ definitely 1.0787x faster redefine-property-previous-attributes 64.1454+-0.0491 ^ 52.8705+-0.4305^ definitely 1.2133x faster redefine-property-data-dictionary5.4420+-0.0105 ^ 5.2991+-0.0157^ definitely 1.0270x faster redefine-property-data 4.5836+-0.0124 ^ 4.4179+-0.0101^ definitely 1.0375x faster redefine-property-accessor 5.8084+-0.0248 ^ 5.2639+-0.0125^ definitely 1.1034x faster * Source/JavaScriptCore/runtime/ObjectConstructor.cpp: (JSC::toPropertyDescriptor): Canonical link: https://commits.webkit.org/257392@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4ee2b8: [Live Range Selection] editing/spelling/spelling-a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ee2b8c5f8a526e95cae00b8074b578b098aef0e https://github.com/WebKit/WebKit/commit/4ee2b8c5f8a526e95cae00b8074b578b098aef0e Author: Ryosuke Niwa Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M LayoutTests/editing/spelling/spelling-attribute-change.html Log Message: --- [Live Range Selection] editing/spelling/spelling-attribute-change.html fails https://bugs.webkit.org/show_bug.cgi?id=248789 Reviewed by Wenson Hsieh. Use a valid offset to set the selection at the end of the target element. * LayoutTests/editing/spelling/spelling-attribute-change.html: Canonical link: https://commits.webkit.org/257391@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cb7097: [Live Range Selection] editing/selection/doublecli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cb70973c26fd7f76b003507e19391055385d6b41 https://github.com/WebKit/WebKit/commit/cb70973c26fd7f76b003507e19391055385d6b41 Author: Ryosuke Niwa Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: A LayoutTests/editing/selection/doubleclick-whitespace-live-range-expected.txt A LayoutTests/editing/selection/doubleclick-whitespace-live-range.html M Source/WebCore/editing/VisibleSelection.cpp Log Message: --- [Live Range Selection] editing/selection/doubleclick-whitespace-live-range.html fails https://bugs.webkit.org/show_bug.cgi?id=248778 Reviewed by Darin Adler. Update m_focus/m_anchor when expanding selection to include trailing whitespace. * LayoutTests/editing/selection/doubleclick-whitespace-live-range-expected.txt: Added. * LayoutTests/editing/selection/doubleclick-whitespace-live-range.html: Added. * Source/WebCore/editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace): Canonical link: https://commits.webkit.org/257390@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c4fa5d: [JSC] Fix x86_64 specific JS tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4fa5d14299e4ddb29c7e5902c1af243de84a8bf https://github.com/WebKit/WebKit/commit/c4fa5d14299e4ddb29c7e5902c1af243de84a8bf Author: Yusuke Suzuki Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M JSTests/stress/big-wasm-memory-grow-no-max.js M JSTests/stress/big-wasm-memory-grow.js M JSTests/stress/big-wasm-memory.js M JSTests/stress/call-apply-exponential-bytecode-size.js M JSTests/stress/dont-link-virtual-calls-on-compiler-thread.js M JSTests/stress/elidable-new-object-roflcopter-then-exit.js M JSTests/stress/materialize-regexp-cyclic-regexp.js M JSTests/stress/materialized-regexp-has-correct-last-index-set-by-match.js M JSTests/stress/regress-173035.js M JSTests/stress/stack-overflow-in-yarr-byteCompile.js M JSTests/stress/typed-array-always-large.js M JSTests/stress/typed-array-eventually-large.js M JSTests/stress/typed-array-large-eventually-oob.js M JSTests/stress/typed-array-large-slice.js M JSTests/wasm/function-tests/trap-load-shared.js M JSTests/wasm/function-tests/trap-store-shared.js M JSTests/wasm/js-api/test_memory.js M JSTests/wasm/modules/wasm-imports-js-exports.js M JSTests/wasm/stress/atomic-decrement.js M JSTests/wasm/stress/atomic-increment.js M JSTests/wasm/stress/invalid-atomic-alignment.js M JSTests/wasm/stress/simd-const-spill.js M JSTests/wasm/stress/simd-const.js M JSTests/wasm/stress/simd-load.js M JSTests/wasm/stress/simd-register-allocation.js M JSTests/wasm/stress/simd-return-value-alignment.js M Tools/Scripts/run-jsc-stress-tests Log Message: --- [JSC] Fix x86_64 specific JS tests https://bugs.webkit.org/show_bug.cgi?id=248779 rdar://problem/102996954> Reviewed by Justin Michaud. Let's use x86_64 in JS tests instead of x86-64 since x86-64 name cannot be accepted by `/usr/bin/arch` command. [1]: https://trac.webkit.org/changeset/263569/webkit * JSTests/stress/big-wasm-memory-grow-no-max.js: * JSTests/stress/big-wasm-memory-grow.js: * JSTests/stress/big-wasm-memory.js: * JSTests/stress/call-apply-exponential-bytecode-size.js: * JSTests/stress/dont-link-virtual-calls-on-compiler-thread.js: * JSTests/stress/elidable-new-object-roflcopter-then-exit.js: * JSTests/stress/materialize-regexp-cyclic-regexp.js: * JSTests/stress/materialized-regexp-has-correct-last-index-set-by-match.js: * JSTests/stress/regress-173035.js: * JSTests/stress/stack-overflow-in-yarr-byteCompile.js: * JSTests/stress/typed-array-always-large.js: * JSTests/stress/typed-array-eventually-large.js: * JSTests/stress/typed-array-large-eventually-oob.js: * JSTests/stress/typed-array-large-slice.js: * JSTests/wasm/function-tests/trap-load-shared.js: * JSTests/wasm/function-tests/trap-store-shared.js: * JSTests/wasm/js-api/test_memory.js: * JSTests/wasm/modules/wasm-imports-js-exports.js: * JSTests/wasm/stress/atomic-decrement.js: * JSTests/wasm/stress/atomic-increment.js: * JSTests/wasm/stress/invalid-atomic-alignment.js: * JSTests/wasm/stress/simd-const-spill.js: * JSTests/wasm/stress/simd-const.js: * JSTests/wasm/stress/simd-load.js: * JSTests/wasm/stress/simd-register-allocation.js: * JSTests/wasm/stress/simd-return-value-alignment.js: * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/257389@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b7bf1e: Plumb synchronous scrolling reason changed through...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7bf1e1b226b6f22c842bb8483043038270260e7 https://github.com/WebKit/WebKit/commit/b7bf1e1b226b6f22c842bb8483043038270260e7 Author: Nikolaos Mouchtaris Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h Log Message: --- Plumb synchronous scrolling reason changed through RemoteScrollingTree for ScrollPerf https://bugs.webkit.org/show_bug.cgi?id=248550 rdar://102828256 Reviewed by Simon Fraser. Implement reportSynchronousScrollingReasonsChanged for RemoteScrollingTree. Since we are already in the UIProcess we can call the logging function in WebPageProxy directly. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::reportSynchronousScrollingReasonsChanged): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp: (WebKit::RemoteScrollingTree::reportSynchronousScrollingReasonsChanged): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h: Canonical link: https://commits.webkit.org/257388@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 636481: Remove unused InProcessCookieCacheEnabled feature ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 636481109f854272182a1540eee1a46ec9801505 https://github.com/WebKit/WebKit/commit/636481109f854272182a1540eee1a46ec9801505 Author: Brent Fulgham Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp Log Message: --- Remove unused InProcessCookieCacheEnabled feature flag https://bugs.webkit.org/show_bug.cgi?id=248680 Reviewed by Chris Dumez. The InProcessCookieCacheEnabled flag was briefly needed while working on some multi-process architecture changes, but has long since lost any utility. We should remove it from the experimental feature flag set to reduce complexity. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp: (WebKit::WebCookieJar::isEligibleForCache const): Canonical link: https://commits.webkit.org/257387@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 73cd74: Disable sorting of CALayers that aren't CATransfor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 73cd744e169091de20b1ca62d31cdb37b37bad6f https://github.com/WebKit/WebKit/commit/73cd744e169091de20b1ca62d31cdb37b37bad6f Author: Matt Woodrow Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h M Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm Log Message: --- Disable sorting of CALayers that aren't CATransformLayers. https://bugs.webkit.org/show_bug.cgi?id=248292 rdar://problem/102634551> Reviewed by Simon Fraser. CoreAnimation currently sorts all layers by depth, and disabling sorting for a layer also disables sorting for any transform-layer children. If supported, this disables sorting for all normal layers and re-enables it for transform-layers, so that only preserve-3d content is sorted (as specified by css-transforms-2). This brings the CA rendering in line with other rendering backends, as well as hit-testing/point-mapping. This doesn't make any change if we can't enable sorting just for transform-layers, but this isn't a regression, as we already have a mismatch between rendering and hit-testing for that case. One thing we could do in the future is disable sorting for layers that don't have any transform-layer children, and fix a subset of the bugs fixed by the full change here. Keeping track of the child list adds complexity though, and this is a long-standing bug, so that change isn't made here. * Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h: * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::platformCALayerUseCSS3DTransformInteroperability const): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h: (WebCore::PlatformCALayerClient::platformCALayerUseCSS3DTransformInteroperability const): * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayerCocoa::commonInit): Canonical link: https://commits.webkit.org/257386@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 051231: Versioning.
Branch: refs/heads/safari-7615.1.14-branch Home: https://github.com/WebKit/WebKit Commit: 05123140bb8e448e03d404e31bfa7ebc056996f5 https://github.com/WebKit/WebKit/commit/05123140bb8e448e03d404e31bfa7ebc056996f5 Author: Alan Coon Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. Canonical link: https://commits.webkit.org/257350.1@safari-7615.1.14-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c64c3: [WPE] Gardening fast/inline/padding-ellipsis-right...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c64c35aacaaf23d571c4c05983caa8d26f4b93e https://github.com/WebKit/WebKit/commit/3c64c35aacaaf23d571c4c05983caa8d26f4b93e Author: Vitaly Dyachkov Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE] Gardening fast/inline/padding-ellipsis-right.html Unreviewed test gardening. Fixed by https://commits.webkit.org/253945@main * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/257385@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dcbdfc: Remove an ASSERT from WebFullScreenManager::willEx...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dcbdfca03eb01d96bc0e7746a8c580c988a53564 https://github.com/WebKit/WebKit/commit/dcbdfca03eb01d96bc0e7746a8c580c988a53564 Author: Geoffrey Garen Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp Log Message: --- Remove an ASSERT from WebFullScreenManager::willExitFullScreen() https://bugs.webkit.org/show_bug.cgi?id=248782 rdar://102997345 Reviewed by Aditya Keerthi. This ASSERT fires when running media/video-fullscreen-reload-crash.html. * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::willExitFullScreen): Canonical link: https://commits.webkit.org/257384@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 808a9c: Web Inspector: Add emulation toggles for prefers-r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 808a9c220b48e53a2a49a93b2560d33eb481d1bc https://github.com/WebKit/WebKit/commit/808a9c220b48e53a2a49a93b2560d33eb481d1bc Author: Razvan Caliman Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: A LayoutTests/inspector/page/overrideUserPreference-expected.txt A LayoutTests/inspector/page/overrideUserPreference.html M Source/JavaScriptCore/inspector/protocol/Page.json M Source/WebCore/inspector/InspectorInstrumentation.cpp M Source/WebCore/inspector/InspectorInstrumentation.h M Source/WebCore/inspector/agents/InspectorPageAgent.cpp M Source/WebCore/inspector/agents/InspectorPageAgent.h M Source/WebCore/page/Page.cpp M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js A Source/WebInspectorUI/UserInterface/Images/AppearanceOverride.svg M Source/WebInspectorUI/UserInterface/Main.html M Source/WebInspectorUI/UserInterface/Protocol/PageObserver.js M Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js A Source/WebInspectorUI/UserInterface/Views/OverrideUserPreferencesPopover.css A Source/WebInspectorUI/UserInterface/Views/OverrideUserPreferencesPopover.js Log Message: --- Web Inspector: Add emulation toggles for prefers-reduced-motion and prefers-contrast https://bugs.webkit.org/show_bug.cgi?id=246882 Reviewed by Patrick Angle. This was previously reviewed in https://github.com/WebKit/WebKit/pull/5650 then reverted by https://github.com/WebKit/WebKit/commit/f306cbbce4236cc5d9b40dd6d5816dacbc9ddf44 Adds controls in Web Inspector to override preferences for reduced motion and increased contrast for the inspected page. These correspond to CSS media features `prefers-reduced-motion: reduce | no-preference` and `prefers-contrast: more | no-preference`. The UI in Web Inspector starts off with preference values set to `System` meaning there is no override applied. A user can pick `On` or `Off` to force a value for the preference on the inspected page for the duration of the Web Inspector session. When a preference is overriden in Web Inspector, changes after the fact to corresponding settings in System Settings > Accessibility > Display have no effect on the inspected page until Web Inspector is closed or the preference values are returned to `System`. * LayoutTests/inspector/page/overrideUserPreference-expected.txt: Added. * LayoutTests/inspector/page/overrideUserPreference.html: Added. * Source/JavaScriptCore/inspector/protocol/Page.json: * Source/WebCore/inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::accessibilitySettingsDidChangeImpl): * Source/WebCore/inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::accessibilitySettingsDidChange): * Source/WebCore/inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): (WebCore::InspectorPageAgent::disable): (WebCore::InspectorPageAgent::overrideUserPreference): (WebCore::InspectorPageAgent::overridePrefersReducedMotion): (WebCore::InspectorPageAgent::overridePrefersContrast): (WebCore::InspectorPageAgent::accessibilitySettingsDidChange): (WebCore::InspectorPageAgent::defaultUserPreferencesDidChange): * Source/WebCore/inspector/agents/InspectorPageAgent.h: * Source/WebCore/page/Page.cpp: (WebCore::Page::accessibilitySettingsDidChange): * Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js: * Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js: (WI.CSSManager): (WI.CSSManager.prototype.get overridenUserPreferences): (WI.CSSManager.prototype.get defaultUserPreferences): (WI.CSSManager.prototype.overrideUserPreference): (WI.CSSManager.prototype.defaultUserPreferencesDidChange): * Source/WebInspectorUI/UserInterface/Images/AppearanceOverride.svg: Added. * Source/WebInspectorUI/UserInterface/Main.html: * Source/WebInspectorUI/UserInterface/Protocol/PageObserver.js: (WI.PageObserver.prototype.defaultUserPreferencesDidChange): * Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js: (WI.DOMTreeContentView): (WI.DOMTreeContentView.prototype.get navigationItems): (WI.DOMTreeContentView.prototype._handleOverrideUserPreferencesButtonClicked): (WI.DOMTreeContentView.prototype._overridenUserPreferencesDidChange): (WI.DOMTreeContentView.prototype.didDismissPopover): * Source/WebInspectorUI/UserInterface/Views/OverrideUserPreferencesPopover.css: Added. (.popover .user-preferences-content): (.popover .user-preferences-content > h1): (.popover .user-preferences-content > label): (.popover .user-preferences-content > select): * Source/WebInspectorUI/UserInterface/Views/OverrideUserPreferencesPopover.js: Added. (WI.OverrideUserPreferencesPopover): (WI.OverrideUserPreferencesPopover.prototype.show): (WI.OverrideUserPreferencesPopover.prototype.dismiss): (WI.OverrideUserPreferencesPopover.prototype._presentOverTarge
[webkit-changes] [WebKit/WebKit] 0fdf99: [JSC] Make Object.values faster
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0fdf9960015a8210d00f65256142db6bd125adf1 https://github.com/WebKit/WebKit/commit/0fdf9960015a8210d00f65256142db6bd125adf1 Author: Yusuke Suzuki Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/runtime/JSONObject.cpp M Source/JavaScriptCore/runtime/JSObject.h M Source/JavaScriptCore/runtime/JSObjectInlines.h M Source/JavaScriptCore/runtime/ObjectConstructor.cpp M Source/JavaScriptCore/runtime/ObjectConstructorInlines.h M Source/JavaScriptCore/runtime/Structure.h M Source/JavaScriptCore/runtime/StructureInlines.h Log Message: --- [JSC] Make Object.values faster https://bugs.webkit.org/show_bug.cgi?id=248749 rdar://102966742 Reviewed by Justin Michaud. This patch adds JSObject::fastForEachPropertyWithSideEffectFreeFunctor, and apply this to Object.values to accelerate performance. It makes Object.values 3x faster. ToT Patched object-values17.2415+-0.0379 ^ 5.6210+-0.0133^ definitely 3.0673x faster * Source/JavaScriptCore/dfg/DFGOperations.cpp: (JSC::DFG::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/runtime/JSONObject.cpp: (JSC::Stringifier::Holder::appendNextProperty): (JSC::FastStringifier::append): * Source/JavaScriptCore/runtime/JSObject.h: * Source/JavaScriptCore/runtime/JSObjectInlines.h: (JSC::JSObject::fastForEachPropertyWithSideEffectFreeFunctor): * Source/JavaScriptCore/runtime/ObjectConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/ObjectConstructorInlines.h: (JSC::objectAssignFast): (JSC::canPerformFastPropertyEnumerationForObjectAssign): Deleted. (JSC::canPerformFastPropertyEnumerationForJSONStringify): Deleted. (JSC::canPerformFastPropertyEnumerationForObjectEntries): Deleted. * Source/JavaScriptCore/runtime/Structure.h: * Source/JavaScriptCore/runtime/StructureInlines.h: (JSC::Structure::canPerformFastPropertyEnumeration const): Canonical link: https://commits.webkit.org/257382@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 788a24: [JSC] Clean up and enhance X86 vector instructions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 788a24f32f108ced27e623bb590d2f1ddb4eac3a https://github.com/WebKit/WebKit/commit/788a24f32f108ced27e623bb590d2f1ddb4eac3a Author: Yusuke Suzuki Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/assembler/X86Assembler.h Log Message: --- [JSC] Clean up and enhance X86 vector instructions https://bugs.webkit.org/show_bug.cgi?id=248729 rdar://102942709 Reviewed by Justin Michaud. This patch fixes X86Assembler's naming convention. Plus, this patch enhances splat / extract implementation to use more efficient instructions. Also we check SSE3 status since some of used instructions are only available in SSE3, which is not mandatory in x64. * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp: (JSC::MacroAssemblerX86Common::collectCPUFeatures): * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::supportsSSE3): (JSC::MacroAssemblerX86Common::supportsSupplementalSSE3): * Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::vectorExtractLane): (JSC::MacroAssemblerX86_64::vectorSplat): * Source/JavaScriptCore/assembler/X86Assembler.h: (JSC::X86Assembler::vextractps): (JSC::X86Assembler::pshufd_rr): (JSC::X86Assembler::pshufb_rr): (JSC::X86Assembler::pshuflw_rr): (JSC::X86Assembler::pshufhw_rr): (JSC::X86Assembler::punpcklqdq_rr): (JSC::X86Assembler::shufps_rr): (JSC::X86Assembler::shufpd_rr): (JSC::X86Assembler::movddup_rr): (JSC::X86Assembler::movhlps_rr): (JSC::X86Assembler::movshdup_rr): (JSC::X86Assembler::movsldup_rr): (JSC::X86Assembler::pshufd): Deleted. (JSC::X86Assembler::pshufb): Deleted. (JSC::X86Assembler::pshuflw): Deleted. (JSC::X86Assembler::pshufhw): Deleted. (JSC::X86Assembler::punpcklqdq): Deleted. (JSC::X86Assembler::shufps): Deleted. (JSC::X86Assembler::shufpd): Deleted. (JSC::X86Assembler::movddup): Deleted. Canonical link: https://commits.webkit.org/257381@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca028c: TransformOperation::OperationType enum should be a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca028cc950803580b8107440b6ed4b490dccb013 https://github.com/WebKit/WebKit/commit/ca028cc950803580b8107440b6ed4b490dccb013 Author: Antoine Quint Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/TransformFunctions.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h M Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h M Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.h M Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.h M Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h M Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp M Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h M Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h M Source/WebCore/platform/graphics/transforms/SkewTransformOperation.h M Source/WebCore/platform/graphics/transforms/TransformOperation.cpp M Source/WebCore/platform/graphics/transforms/TransformOperation.h M Source/WebCore/platform/graphics/transforms/TransformOperations.h M Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/style/RenderStyle.cpp Log Message: --- TransformOperation::OperationType enum should be an `enum class` https://bugs.webkit.org/show_bug.cgi?id=248762 Reviewed by Simon Fraser. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::blendFunc): * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::containsRotation): (WebCore::KeyframeEffect::computeTransformedExtentViaTransformList const): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::computedTransform): * Source/WebCore/css/TransformFunctions.cpp: (WebCore::transformOperationType): (WebCore::translateForValue): (WebCore::scaleForValue): (WebCore::rotateForValue): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::isTransformTypeTransformationMatrix): (WebCore::isTransformTypeFloatPoint3D): (WebCore::isTransformTypeNumber): (WebCore::getTransformFunctionValue): (WebCore::getValueFunctionNameForTransformOperation): (WebCore::GraphicsLayerCA::appendToUncommittedAnimations): (WebCore::hasBig3DRotation): (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints): (WebCore::GraphicsLayerCA::setTransformAnimationKeyframes): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h: * Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.h: * Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.h: * Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h: * Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp: (WebCore::RotateTransformOperation::blend): * Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h: * Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h: * Source/WebCore/platform/graphics/transforms/SkewTransformOperation.h: * Source/WebCore/platform/graphics/transforms/TransformOperation.cpp: (WebCore::operator<<): (WebCore::TransformOperation::sharedPrimitiveType const): * Source/WebCore/platform/graphics/transforms/TransformOperation.h: (WebCore::TransformOperation::TransformOperation): (WebCore::TransformOperation::type const): (WebCore::TransformOperation::primitiveType const): (WebCore::TransformOperation::is3DOperation const): (WebCore::TransformOperation::isRotateTransformOperationType const): (WebCore::TransformOperation::isScaleTransformOperationType const): (WebCore::TransformOperation::isSkewTransformOperationType const): (WebCore::TransformOperation::isTranslateTransformOperationType const): (): Deleted. * Source/WebCore/platform/graphics/transforms/TransformOperations.h: (WebCore::TransformOperations::hasMatrixOperation const): (WebCore::SharedPrimitivesPrefix::primitives const): * Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setPageScaleTransform): Canonical link: https://commits.webkit.org/257380@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3912f3: Have PlatformCALayerRemoteCustom plumb preservesFl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3912f312cb1e86980a0630241041c5ddc80c189f https://github.com/WebKit/WebKit/commit/3912f312cb1e86980a0630241041c5ddc80c189f Author: Nikolaos Mouchtaris Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h M Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.h M Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm M Source/WebKit/Platform/cocoa/LayerHostingContext.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm M Source/WebKit/UIProcess/mac/PageClientImplMac.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PluginView.cpp M Source/WebKit/WebProcess/Plugins/PluginView.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h Log Message: --- Have PlatformCALayerRemoteCustom plumb preservesFlip to UIProcess https://bugs.webkit.org/show_bug.cgi?id=247341 rdar://101786702 Reviewed by Tim Horton and Simon Fraser. Since the effects of setGeometryFlipped don't cross a hosting boundary, it is not propogated to the PDFKit layers being hosted in the WebProcess when UI-side compositing is on. This causes rendering to look wrong and scrolling in the wrong direction. To solve this issue, we plumb a bit through to the UIProcess to set preservesFlip, which allows the value of geometryFlipped to propogate through layer hosting. We also add a check for ui-side compositing when creating PDF scrollbars due to a bug where the scrollbars didn't reflect the geometryFlipped value of its ancestor. * Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.h: * Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm: (+[CALayer _web_renderLayerWithContextID:shouldPreserveFlip:]): (+[CALayer _web_renderLayerWithContextID:]): Deleted. * Source/WebKit/Platform/cocoa/LayerHostingContext.mm: (WebKit::LayerHostingContext::createPlatformLayerForHostingContext): * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties): (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const): (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::makeNode): * Source/WebKit/UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::didFirstLayerFlush): (WebKit::PageClientImpl::updateAcceleratedCompositingMode): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm: (WebKit::PlatformCALayerRemoteCustom::populateCreationProperties): Canonical link: https://commits.webkit.org/257379@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7615.1.14-branch Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d71b7: Use dump-as-markup.js in editing/pasteboard/smart-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d71b7e95dde87a7036f96953a13c2d00362b1c8 https://github.com/WebKit/WebKit/commit/3d71b7e95dde87a7036f96953a13c2d00362b1c8 Author: Ryosuke Niwa Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: A LayoutTests/editing/pasteboard/smart-drag-drop-expected.txt M LayoutTests/editing/pasteboard/smart-drag-drop.html M LayoutTests/platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt M LayoutTests/platform/ios-wk2/editing/pasteboard/smart-drag-drop-expected.txt R LayoutTests/platform/mac/editing/pasteboard/smart-drag-drop-expected.txt R LayoutTests/platform/win/editing/pasteboard/smart-drag-drop-expected.txt Log Message: --- Use dump-as-markup.js in editing/pasteboard/smart-drag-drop.html https://bugs.webkit.org/show_bug.cgi?id=248681 Reviewed by Darin Adler. Modernized the test. * LayoutTests/editing/pasteboard/smart-drag-drop-expected.txt: * LayoutTests/editing/pasteboard/smart-drag-drop.html: * LayoutTests/platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt: * LayoutTests/platform/ios-wk2/editing/pasteboard/smart-drag-drop-expected.txt: * LayoutTests/platform/mac/editing/pasteboard/smart-drag-drop-expected.txt: Removed. * LayoutTests/platform/win/editing/pasteboard/smart-drag-drop-expected.txt: Removed. Canonical link: https://commits.webkit.org/257378@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 99c2dd: Make WebGL use GPU process by default on Cocoa
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99c2dd7bfa7e76c5fee4c8e458e6c0f4f3fceb47 https://github.com/WebKit/WebKit/commit/99c2dd7bfa7e76c5fee4c8e458e6c0f4f3fceb47 Author: Kimmo Kinnunen Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml M Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml Log Message: --- Make WebGL use GPU process by default on Cocoa https://bugs.webkit.org/show_bug.cgi?id=246445 rdar://problem/101113326 Reviewed by Simon Fraser. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: Canonical link: https://commits.webkit.org/257377@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08d448: Add checks to allowsFirstPartyForCookies before ad...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08d448e0d6740cf5a2e6356c433d8ac9c23d61fe https://github.com/WebKit/WebKit/commit/08d448e0d6740cf5a2e6356c433d8ac9c23d61fe Author: Chirag M Shah Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebCore/workers/service/server/SWServer.cpp M Source/WebCore/workers/service/server/SWServer.h M Source/WebCore/workers/service/server/SWServerJobQueue.cpp M Source/WebCore/workers/service/server/SWServerJobQueue.h M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkSession.cpp Log Message: --- Add checks to allowsFirstPartyForCookies before adding a new ID<->origin mapping https://bugs.webkit.org/show_bug.cgi?id=248541 Reviewed by Alex Christensen. * Source/WebCore/workers/service/server/SWServer.cpp: (WebCore::SWServer::Connection::finishFetchingScriptInServer): (WebCore::SWServer::startScriptFetch): (WebCore::SWServer::scriptFetchFinished): (WebCore::SWServer::refreshImportedScripts): (WebCore::SWServer::refreshImportedScriptsFinished): (WebCore::SWServer::updateWorker): (WebCore::SWServer::tryInstallContextData): (WebCore::SWServer::contextConnectionCreated): * Source/WebCore/workers/service/server/SWServer.h: * Source/WebCore/workers/service/server/SWServerJobQueue.cpp: (WebCore::SWServerJobQueue::scriptFetchFinished): (WebCore::SWServerJobQueue::importedScriptsFetchFinished): * Source/WebCore/workers/service/server/SWServerJobQueue.h: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::allowsFirstPartyForCookies): * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::ensureSWServer): Canonical link: https://commits.webkit.org/257376@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f14203: Add support for the Web Extensions Event API in th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f14203440c9ccb1f09af72288eec9fb1b75f235d https://github.com/WebKit/WebKit/commit/f14203440c9ccb1f09af72288eec9fb1b75f235d Author: Kiara Rose Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources-output.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Scripts/webkit/messages.py A Source/WebKit/Shared/Extensions/WebExtensionEventListenerType.h A Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIEventCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj A Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIEventCocoa.mm A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIEvent.h M Source/WebKit/WebProcess/Extensions/Bindings/Scripts/CodeGeneratorExtensions.pm M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIEvent.idl Log Message: --- Add support for the Web Extensions Event API in the WebProcess. https://bugs.webkit.org/show_bug.cgi?id=248684 Reviewed by Timothy Hatcher. This patch adds support for the Web Extensions Event API in the WebProcess. This includes support for adding, removing, and invoking event listeners. Testing: Using a test extension, I added a 'testEvent' property to the WebExtensionTest API, and I called "browser.test.testEvent.addListener()" in the background page of the extension. Using the debugger, I confirmed that the code path for adding the listener hits and a call to Messages::WebExtensionContext::AddListener is made. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources-output.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): Add WebKit::WebExtensionEventListenerType to types that cannot be forward declared so that the correct type will be used in WebExtensionMessageReceiver. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIEventCocoa.mm: Copied from Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in. (WebKit::WebExtensionContext::addListener): (WebKit::WebExtensionContext::removeListener): Methods for adding and removing event listeners for extensions in the UIProcess. Implementation being tracked in https://bugs.webkit.org/show_bug.cgi?id=248684. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIEventCocoa.mm: Added. (WebKit::WebExtensionAPIEvent::invokeListeners): (WebKit::WebExtensionAPIEvent::invokeListenersWithArgument): (WebKit::WebExtensionAPIEvent::addListener): (WebKit::WebExtensionAPIEvent::removeListener): (WebKit::WebExtensionAPIEvent::hasListener): * Source/WebKit/WebProcess/Extensions/Bindings/Scripts/CodeGeneratorExtensions.pm: (_platformTypeVariableDeclaration): Remove this line of code so that the generated code in JSWebExtensionAPIEvent::addListener can successfully set the listener. With this line, RefPtr listener never gets set. * Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIEvent.idl: Use [NeedsPage] instead of NeedsPageWithCallbackHandler since hasListeners doesn't need the WebPage. Canonical link: https://commits.webkit.org/257375@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d03a4: Rename request initiator and initiatorName to init...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d03a4356c054b53d53b2572a3ba57ea1a8df076 https://github.com/WebKit/WebKit/commit/7d03a4356c054b53d53b2572a3ba57ea1a8df076 Author: Matthew Finkel Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebCore/Modules/cache/DOMCache.cpp M Source/WebCore/Modules/fetch/FetchLoader.cpp M Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp M Source/WebCore/Modules/mediasession/MediaMetadata.cpp M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/CachedScriptFetcher.cpp M Source/WebCore/bindings/js/CachedScriptFetcher.h M Source/WebCore/css/CSSFontFaceSrcValue.cpp M Source/WebCore/css/CSSImageValue.cpp M Source/WebCore/css/CSSImageValue.h M Source/WebCore/css/StyleRuleImport.cpp M Source/WebCore/dom/DocumentFontLoader.cpp M Source/WebCore/dom/InlineClassicScript.cpp M Source/WebCore/dom/InlineClassicScript.h M Source/WebCore/dom/LoadableClassicScript.cpp M Source/WebCore/dom/LoadableClassicScript.h M Source/WebCore/dom/LoadableImportMap.cpp M Source/WebCore/dom/LoadableImportMap.h M Source/WebCore/dom/LoadableModuleScript.cpp M Source/WebCore/dom/LoadableModuleScript.h M Source/WebCore/dom/LoadableScript.h M Source/WebCore/dom/ScriptElementCachedScriptFetcher.h M Source/WebCore/html/parser/HTMLResourcePreloader.cpp M Source/WebCore/html/parser/HTMLResourcePreloader.h M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp M Source/WebCore/loader/ApplicationManifestLoader.cpp M Source/WebCore/loader/CrossOriginPreflightChecker.cpp M Source/WebCore/loader/DocumentThreadableLoader.cpp M Source/WebCore/loader/LinkLoader.cpp M Source/WebCore/loader/ResourceTiming.cpp M Source/WebCore/loader/ResourceTiming.h M Source/WebCore/loader/ResourceTimingInformation.cpp M Source/WebCore/loader/ResourceTimingInformation.h M Source/WebCore/loader/SubresourceLoader.cpp M Source/WebCore/loader/ThreadableLoader.cpp M Source/WebCore/loader/ThreadableLoader.h M Source/WebCore/loader/WorkerThreadableLoader.cpp M Source/WebCore/loader/cache/CachedResource.cpp M Source/WebCore/loader/cache/CachedResource.h M Source/WebCore/loader/cache/CachedResourceLoader.cpp M Source/WebCore/loader/cache/CachedResourceRequest.cpp M Source/WebCore/loader/cache/CachedResourceRequest.h A Source/WebCore/loader/cache/CachedResourceRequestInitiatorTypes.cpp A Source/WebCore/loader/cache/CachedResourceRequestInitiatorTypes.h R Source/WebCore/loader/cache/CachedResourceRequestInitiators.cpp R Source/WebCore/loader/cache/CachedResourceRequestInitiators.h M Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp M Source/WebCore/loader/icon/IconLoader.cpp M Source/WebCore/page/EventSource.cpp M Source/WebCore/page/PerformanceResourceTiming.h M Source/WebCore/platform/ThreadGlobalData.cpp M Source/WebCore/platform/ThreadGlobalData.h M Source/WebCore/workers/service/FetchEvent.cpp M Source/WebCore/xml/XMLHttpRequest.cpp Log Message: --- Rename request initiator and initiatorName to initiatorType https://bugs.webkit.org/show_bug.cgi?id=248566 rdar://problem/102832673 Reviewed by Darin Adler. Resource requests have an "initiator" which is a string that represents "what triggered this request". That string may be an element type or a script method (e.g., "fetch"). Internally, "initiator" and "initiatorName" were used interchangably, and the ResourceTiming API exposes this information as "initiatorType". This change aligns the internal naming with the spec and renames uses of "initiator" and "initiatorName" to "initiatorType". * Source/WebCore/Modules/cache/DOMCache.cpp: (WebCore::DOMCache::addAll): * Source/WebCore/Modules/fetch/FetchLoader.cpp: * Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp: (WebCore::doFetch): * Source/WebCore/Modules/mediasession/MediaMetadata.cpp: (WebCore::ArtworkImageLoader::requestImageResource): * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/CachedScriptFetcher.cpp: (WebCore::CachedScriptFetcher::requestScriptWithCache const): * Source/WebCore/bindings/js/CachedScriptFetcher.h: (WebCore::CachedScriptFetcher::CachedScriptFetcher): * Source/WebCore/css/CSSFontFaceSrcValue.cpp: * Source/WebCore/css/CSSImageValue.cpp: (WebCore::CSSImageValue::CSSImageValue): (WebCore::CSSImageValue::create): (WebCore::CSSImageValue::createStyleImage const): (WebCore::CSSImageValue::loadImage): * Source/WebCore/css/CSSImageValue.h: * Source/WebCore/css/StyleRuleImport.cpp: (WebCore::StyleRuleImport::requestStyleSheet): * Source/WebCore/dom/DocumentFontLoader.cpp: (WebCore::DocumentFontLoader::cachedFont): * Source/WebCore/dom/InlineClassicScript.cpp: (WebCore::InlineClassicSc
[webkit-changes] [WebKit/WebKit] 171728: EWS pulls the wrong revision when checking out the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 171728f99da730aa5134f37439b5de387ec8dd19 https://github.com/WebKit/WebKit/commit/171728f99da730aa5134f37439b5de387ec8dd19 Author: Jonathan Bedard Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- EWS pulls the wrong revision when checking out the tree for testing for PRs https://bugs.webkit.org/show_bug.cgi?id=248725 rdar://102964437 Reviewed by Alexey Proskuryakov and Aakash Jain. After https://commits.webkit.org/257193@main, PRs are no longer testing against the ews revision and are instead testing against tip-of-tree, which is incorrect. * Tools/CISupport/ews-build/steps.py: (CheckOutSpecificRevision.doStepIf): Do step for PRs as well as patches. * Tools/CISupport/ews-build/steps_unittest.py: (TestCheckOutSpecificRevision.test_skip_pr): Deleted. Canonical link: https://commits.webkit.org/257373@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab1162: Remove "pagination line grid" SPI
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab116278c13504605c78ac58f342de7899691a19 https://github.com/WebKit/WebKit/commit/ab116278c13504605c78ac58f342de7899691a19 Author: Antti Koivisto Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/style/StyleResolveForDocument.cpp M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl M Source/WebKit/Shared/WebPageCreationParameters.cpp M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Remove "pagination line grid" SPI https://bugs.webkit.org/show_bug.cgi?id=248759 rdar://102975657 Reviewed by Alan Baradlay. This SPI was implemented for Books (rdar://23041598) but never adopted (rdar://25075170). * Source/WebCore/page/Page.cpp: (WebCore::Page::setPaginationLineGridEnabled): Deleted. * Source/WebCore/page/Page.h: (WebCore::Page::paginationLineGridEnabled const): Deleted. * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): * Source/WebCore/style/StyleResolveForDocument.cpp: (WebCore::Style::resolveForDocument): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::resetToConsistentState): (WebCore::Internals::setPaginationLineGridEnabled): Deleted. * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: * Source/WebKit/Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode): * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageSetPaginationLineGridEnabled): (WKPageGetPaginationLineGridEnabled): * Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm: (-[WKBrowsingContextController setPaginationLineGridEnabled:]): (-[WKBrowsingContextController paginationLineGridEnabled]): * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _paginationLineGridEnabled]): (-[WKWebView _setPaginationLineGridEnabled:]): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): (WebKit::WebPageProxy::setPaginationLineGridEnabled): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::m_appHighlightsVisible): (WebKit::WebPage::setPaginationLineGridEnabled): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView _setPaginationLineGridEnabled:]): (-[WebView _paginationLineGridEnabled]): Leave stubs in place as clients may still be calling these with NO value. Canonical link: https://commits.webkit.org/257372@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4690d8: iOS Mail app issues with copying attachments from ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4690d8d04a27a89412a880798fb2ac374a0770a3 https://github.com/WebKit/WebKit/commit/4690d8d04a27a89412a880798fb2ac374a0770a3 Author: Richard Robinson Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm Log Message: --- iOS Mail app issues with copying attachments from an email and pasting into new email or note or Files https://bugs.webkit.org/show_bug.cgi?id=248746 rdar://70201914 Reviewed by Wenson Hsieh. When copying an attachment in Mail, and pasting it in Mail or another app, the file becomes corrupted. This is because when copying the file to the clipboard, we use `-[NSFileWrapper serializedRepresentation]` to serialize the file and then send that data. However, when pasting the file, clients such as Mail do not expect the data to be serialized, and so they use `-[NSFileWrapper initRegularFileWithContents:]` to try to read it, which causes the file to be corrupted. There are two solutions to this: 1. Get all clients to use the correct initializer, `-[NSFileWrapper initWithSerializedRepresentation:]` 2. Do not serialize the data when copying it to the clipboard This PR does the latter, as it is the safer option. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (createItemProvider): Canonical link: https://commits.webkit.org/257371@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6112c5: Remove a float from an element's list even if its ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6112c5929ca9012278c62ee3b2a0d82d424aad99 https://github.com/WebKit/WebKit/commit/6112c5929ca9012278c62ee3b2a0d82d424aad99 Author: Ahmad Saleem Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: A LayoutTests/fast/block/overhanging-float-crashes-when-sibling-becomes-formatting-context-expected.txt A LayoutTests/fast/block/overhanging-float-crashes-when-sibling-becomes-formatting-context.html M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- Remove a float from an element's list even if its style suggests it can't contain floats Remove a float from an element's list even if its style suggests it can't contain floats https://bugs.webkit.org/show_bug.cgi?id=248487 Reviewed by Alan Baradlay. Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=190902 The reason we are failing to remove floats here is because we put an element in a second element's float lists, then put a style on that second element that prevents it from overlapping with floats in future, and then we assume that because it has that style it can't contain the float we're destroying in its float lists. * Source/WebCore/rendering/RenderBlockFlow.cpp: (RenderBlockFlow::markSiblingsWithFloatsForLayout): Add logic to remove float from an element's list * LayoutTests/fast/block/overhanging-float-crashes-when-sibling-becomes-formatting-context.html: Add Test Case * LayoutTests/fast/block/overhanging-float-crashes-when-sibling-becomes-formatting-context-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/257370@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a147a6: [Gardening]: REGRESSION (251289@main): [ Ventura ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a147a604e46d783e82b255d4f124adbd90c59f61 https://github.com/WebKit/WebKit/commit/a147a604e46d783e82b255d4f124adbd90c59f61 Author: Karl Rackler Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (251289@main): [ Ventura ] fast/images/animated-heics-draw.html is a consistent timeout https://bugs.webkit.org/show_bug.cgi?id=247982 rdar://102421055 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: This commit include: [Gardening]: REGRESSION (251289@main): [ Ventura ] fast/images/animated-heics-draw.html is a consistent timeout https://bugs.webkit.org/show_bug.cgi?id=247982 rdar://102421055 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/257369@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf51ac: Revert REGRESSION (251289@main): [ Ventura ] fast/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bf51ac10e9b18cbbad0c999e27f2c66511f51925 https://github.com/WebKit/WebKit/commit/bf51ac10e9b18cbbad0c999e27f2c66511f51925 Author: Karl Rackler Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm Log Message: --- Revert REGRESSION (251289@main): [ Ventura ] fast/images/animated-heics-draw.html is a consistent timeout because it caused the test to flaky crash webkit.org/b/247982 Unreviewed revert. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): This commit include: Revert REGRESSION (251289@main): [ Ventura ] fast/images/animated-heics-draw.html is a consistent timeout because it caused test to flaky crash webkit.org/b/247982 Unreviewed revert. * LayoutTests/platform/mac-wk2/TestExpectations: Revert REGRESSION (251289@main): [ Ventura ] fast/images/animated-heics-draw.html is a consistent timeout becaue it caused te test to flaky crash webkit.org/b/247982 Unreviewed revert * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): Canonical link: https://commits.webkit.org/257368@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ecaf59: Import WPT css/css-nesting
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ecaf5946d7a021d6e1d8bda4bb6e2c990a73d26a https://github.com/WebKit/WebKit/commit/ecaf5946d7a021d6e1d8bda4bb6e2c990a73d26a Author: Matthieu Dubet Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-properties-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-properties-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-properties.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-parent-insertion-crash.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalid-inner-rules-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalid-inner-rules.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalidation-001-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalidation-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalidation-002-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalidation-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalidation-003-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalidation-003.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalidation-004-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalidation-004.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/nesting-basic-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/nesting-basic-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/nesting-basic.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/pseudo-part-crash.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/serialize-group-rules-with-decls.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/serialize-group-rules-with-decls.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/w3c-import.log Log Message: --- Import WPT css/css-nesting https://bugs.webkit.org/show_bug.cgi?id=248608 Reviewed by Antti Koivisto and Tim Nguyen. WPT 67ccf32 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-properties-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-properties-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-properties.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-nesting.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/implicit-parent-insertion-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/invalid-inner-rules-expected.txt: Added. * LayoutTests/imported/w
[webkit-changes] [WebKit/WebKit] 81f661: [GTK][WPE] Add WebKitWebFormManager and deprecate ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81f661ea4d757aa254c322965cba2c1e7881491f https://github.com/WebKit/WebKit/commit/81f661ea4d757aa254c322965cba2c1e7881491f Author: Carlos Garcia Campos Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesWPE.txt M Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMElement.cpp M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFramePrivate.h A Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.cpp A Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.h.in A Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManagerPrivate.h M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.h.in M Source/WebKit/WebProcess/InjectedBundle/API/glib/webkit-web-extension.h.in M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h M Source/WebKit/WebProcess/InjectedBundle/API/wpe/DOM/WebKitDOMElement.h M Tools/TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp M Tools/TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp M Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK][WPE] Add WebKitWebFormManager and deprecate WebKitWebPage form related signals and WebKitDOMElement https://bugs.webkit.org/show_bug.cgi?id=248657 Reviewed by Michael Catanzaro. Move the form signals from WebKitWebPage to WebKitWebFormManager that no longer uses WebKitDOMElement, but JSCValue. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: * Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMElement.cpp: * Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp: (webkitFrameGetJSCValueForElementInWorld): (webkitFrameGetJSCValuesForElementsInWorld): * Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFramePrivate.h: * Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.cpp: Added. (webkit_web_form_manager_class_init): (webkitWebFormManagerCreate): (webkitWebFormManagerDidAssociateFormControls): (webkitWebFormManagerWillSendSubmitEvent): (webkitWebFormManagerWillSubmitForm): (nodeForJSCValue): (webkit_web_form_manager_input_element_is_user_edited): (webkit_web_form_manager_input_element_auto_fill): (webkit_web_form_manager_input_element_is_auto_filled): * Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.h.in: Added. * Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManagerPrivate.h: Added. * Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp: (worldDestroyed): (webkitWebPageDispose): (webkit_web_page_class_init): (webkit_web_page_get_form_manager): * Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.h.in: * Source/WebKit/WebProcess/InjectedBundle/API/glib/webkit-web-extension.h.in: * Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h: * Tools/TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp: (DOMElementTest::testAutoFill): * Tools/TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: (WebKitFrameTest::testJavaScriptValues): (WebKitFrameTest::willSubmitFormCallback): (WebKitFrameTest::testSubframe): * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: (didAssociateFormControlsCallback): (testWebExtensionFormControlsAssociated): * Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: (formControlsAssociatedForFrameCallback): (formControlsAssociatedCallback): (willSubmitFormDeprecatedCallback): (handleFormSubmissionCallback): (willSendSubmitEventCallback): (willSubmitFormCallback): (pageCreatedCallback): (windowObjectCleared): (methodCallCallback): (webkit_web_extension_initialize_with_user_data): * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/257366@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
