[webkit-changes] [WebKit/WebKit] bcd8cc: [web-animations] add basic interpolation support f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcd8cc0c0c83b0f2ddb78977a843650168bb138f https://github.com/WebKit/WebKit/commit/bcd8cc0c0c83b0f2ddb78977a843650168bb138f Author: Antoine Quint Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-important-001-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-length-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-length.html M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/font-size-animation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-revert-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/resources/utils.js M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/animation/CSSPropertyAnimation.h M Source/WebCore/animation/KeyframeEffect.cpp Log Message: --- [web-animations] add basic interpolation support for custom properties https://bugs.webkit.org/show_bug.cgi?id=249312 Reviewed by Antti Koivisto. Add very basic interpolation support for custom properties starting with only with the type and only dealing with non-additive and non-accumulative animations with explicit keyframe values. We add a new WPT test for that draws the blueprint for the remaining work. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-important-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-length-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-length.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/font-size-animation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-revert-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/resources/utils.js: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::blendSyntaxValues): (WebCore::blendedCSSCustomPropertyValue): (WebCore::CSSPropertyAnimation::blendCustomProperty): * Source/WebCore/animation/CSSPropertyAnimation.h: * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::setAnimatedPropertiesInStyle): Canonical link: https://commits.webkit.org/257906@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2639c5: Add Masonry support in autoPlacementAxisDirection
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2639c5de1b98ca9266210ddedb49c22b566e9934 https://github.com/WebKit/WebKit/commit/2639c5de1b98ca9266210ddedb49c22b566e9934 Author: Brandon Stewart Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/rendering/RenderGrid.cpp Log Message: --- Add Masonry support in autoPlacementAxisDirection https://bugs.webkit.org/show_bug.cgi?id=249326 Reviewed by Matt Woodrow. While working on track-sizing I noticed that align-content/masonry-align-content-003.html was only being rendered on a single column instead of being spread across multiple columns. This patch adds a check in autoPlacementMajor/MinorAxisDirection for Masonry. No new test in this patch. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::autoPlacementMajorAxisDirection const): (WebCore::RenderGrid::autoPlacementMinorAxisDirection const): Canonical link: https://commits.webkit.org/257905@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e2cc1: [CMake] Make a WebKit::TestRunnerShared target
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e2cc15056faa01dc296246a61fcf475174c50a6 https://github.com/WebKit/WebKit/commit/4e2cc15056faa01dc296246a61fcf475174c50a6 Author: Don Olmstead Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/cmake/WebKitMacros.cmake M Tools/DumpRenderTree/CMakeLists.txt M Tools/TestRunnerShared/CMakeLists.txt M Tools/TestRunnerShared/PlatformMac.cmake M Tools/WebKitTestRunner/CMakeLists.txt M Tools/WebKitTestRunner/PlatformGTK.cmake Log Message: --- [CMake] Make a WebKit::TestRunnerShared target https://bugs.webkit.org/show_bug.cgi?id=238631 Reviewed by Michael Catanzaro. * Source/cmake/WebKitMacros.cmake: * Tools/DumpRenderTree/CMakeLists.txt: * Tools/TestRunnerShared/CMakeLists.txt: * Tools/TestRunnerShared/PlatformMac.cmake: * Tools/WebKitTestRunner/CMakeLists.txt: * Tools/WebKitTestRunner/PlatformGTK.cmake: Canonical link: https://commits.webkit.org/257904@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b205f: Integrate PGM for large heap allocations
Branch: refs/heads/eng/libpas_enable_pgm Home: https://github.com/WebKit/WebKit Commit: 0b205f87676eb0cc47a9e711afa80572bd061849 https://github.com/WebKit/WebKit/commit/0b205f87676eb0cc47a9e711afa80572bd061849 Author: Brandon Stewart Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/bmalloc/bmalloc.xcodeproj/project.pbxproj M Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h Log Message: --- Integrate PGM for large heap allocations https://bugs.webkit.org/show_bug.cgi?id=249371 Reviewed by NOBODY (OOPS!). Enable PGM for large heap allocations. * Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h: (pas_try_allocate_common_impl_slow): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 07575d: Fix imported/w3c/web-platform-tests/css/css-box/in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07575d8d452fec3df400dbfc6a258155ff690dae https://github.com/WebKit/WebKit/commit/07575d8d452fec3df400dbfc6a258155ff690dae Author: Sammy Gill Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-box/inheritance.html Log Message: --- Fix imported/w3c/web-platform-tests/css/css-box/inheritance.html for margin-trim. https://bugs.webkit.org/show_bug.cgi?id=249366 rdar://103383727 Reviewed by Tim Nguyen. The test was using a value for the margin-trim property that is not valid. The value that it was using, "all," was in an old version of the spec but is not valid anymore. This would cause the test to fail in any scenarios since the parser would not recognize it as a value for the property. Replacing it with "block," should help resolve this issue. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/inheritance.html: Canonical link: https://commits.webkit.org/257903@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0e9914: Compile-time enable Notifications for additional p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e9914e91f10c1d21552e0249a0837eda3420f6b https://github.com/WebKit/WebKit/commit/0e9914e91f10c1d21552e0249a0837eda3420f6b Author: Brady Eidson Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferences.yaml M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebKit/Scripts/process-entitlements.sh M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm Log Message: --- Compile-time enable Notifications for additional platform (runtime off by default) https://bugs.webkit.org/show_bug.cgi?id=249289 rdar://103337417 Reviewed by Tim Horton. * Source/WTF/Scripts/Preferences/WebPreferences.yaml: * Source/WTF/wtf/PlatformEnable.h: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebKit/Scripts/process-entitlements.sh: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: Canonical link: https://commits.webkit.org/257902@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 643ffd: [JSC] Fix VectorAbs for I64x2
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 643ffd610e8b20bb11e7cca20b56462c4283fd7b https://github.com/WebKit/WebKit/commit/643ffd610e8b20bb11e7cca20b56462c4283fd7b Author: Yusuke Suzuki Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/b3/air/AirOpcode.opcodes M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp Log Message: --- [JSC] Fix VectorAbs for I64x2 https://bugs.webkit.org/show_bug.cgi?id=249358 rdar://103380107 Reviewed by Justin Michaud. VectorAbs for I64x2 in x64 requires a scratch register, since input and dest can be the same. This patch fixes it. Also we clean up the adhoc lowering part in Wasm::AirIRGenerator64. * Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::vectorAbsInt64): (JSC::MacroAssemblerX86_64::vectorAbs): * Source/JavaScriptCore/b3/air/AirOpcode.opcodes: * Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp: (JSC::Wasm::AirIRGenerator64::addSIMDV_V): Canonical link: https://commits.webkit.org/257901@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6828a6: Unreviewed, remove WasmAirIRGenerator.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6828a6361866ca3222cda08f856ddc10c34cb2e9 https://github.com/WebKit/WebKit/commit/6828a6361866ca3222cda08f856ddc10c34cb2e9 Author: Yusuke Suzuki Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: R Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp Log Message: --- Unreviewed, remove WasmAirIRGenerator.cpp https://bugs.webkit.org/show_bug.cgi?id=249362 rdar://103381575 This is no longer built. It is splitted into WasmAirIRGeneratorBase.h, WasmAirIRGenerator64.cpp, and WasmAirIRGenerator32_64.cpp. * Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp: Removed. Canonical link: https://commits.webkit.org/257900@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a57c8: [Gardening]: [ New Test ] (257673@main): [ iOS ] i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a57c841dc06203aa8c3b945a44af523bc90383a https://github.com/WebKit/WebKit/commit/9a57c841dc06203aa8c3b945a44af523bc90383a Author: Karl Rackler Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [Gardening]: [ New Test ] (257673@main): [ iOS ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable.w.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=249367 rdar://103383814 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/257899@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d2e0b4: Unreviewed, fix AVX function name
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d2e0b466727e6bf5d4e76f15741c0164dca587a7 https://github.com/WebKit/WebKit/commit/d2e0b466727e6bf5d4e76f15741c0164dca587a7 Author: Yusuke Suzuki Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/assembler/X86Assembler.h Log Message: --- Unreviewed, fix AVX function name https://bugs.webkit.org/show_bug.cgi?id=249361 rdar://103381465 * Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::vectorExtendHigh): * Source/JavaScriptCore/assembler/X86Assembler.h: (JSC::X86Assembler::vunpckhpd_rrr): (JSC::X86Assembler::vupckhpd_rrr): Deleted. Canonical link: https://commits.webkit.org/257898@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b13894: Cherry-pick 0f43b50f3717. rdar://problem/103383066
Branch: refs/tags/WebKit-7615.1.14.7 Home: https://github.com/WebKit/WebKit Commit: b13894ef830c742172f0a090541f373bbc0ca489 https://github.com/WebKit/WebKit/commit/b13894ef830c742172f0a090541f373bbc0ca489 Author: Elliott Williams Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/JavaScriptCore/DerivedSources.make M Source/WebCore/DerivedSources.make M Source/WebKit/DerivedSources.make M Tools/DumpRenderTree/DerivedSources.make M Tools/WebKitTestRunner/DerivedSources.make Log Message: --- Cherry-pick 0f43b50f3717. rdar://problem/103383066 [Xcode] Stop checking USE_LLVM_TARGET_TRIPLES_FOR_CLANG https://bugs.webkit.org/show_bug.cgi?id=249348 Reviewed by Tim Horton. Remove checks in DerivedSources Makefiles and make all target triple logic unconditional. Xcode has built with target triples for years, since at least Xcode 11. Triples are also mandatory for building platforms like Mac Catalyst. * Source/JavaScriptCore/DerivedSources.make: * Source/WebCore/DerivedSources.make: * Source/WebKit/DerivedSources.make: * Tools/DumpRenderTree/DerivedSources.make: * Tools/WebKitTestRunner/DerivedSources.make: Canonical link: https://commits.webkit.org/257896@main Canonical link: https://commits.webkit.org/257350.19@safari-7615.1.14-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a67ddf: Cherry-pick 0f43b50f3717. rdar://problem/103383066
Branch: refs/heads/safari-7615.1.15-branch Home: https://github.com/WebKit/WebKit Commit: a67ddf8ecc58a0786fb1c87ba4f46ae5afa11369 https://github.com/WebKit/WebKit/commit/a67ddf8ecc58a0786fb1c87ba4f46ae5afa11369 Author: Elliott Williams Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/JavaScriptCore/DerivedSources.make M Source/WebCore/DerivedSources.make M Source/WebKit/DerivedSources.make M Tools/DumpRenderTree/DerivedSources.make M Tools/WebKitTestRunner/DerivedSources.make Log Message: --- Cherry-pick 0f43b50f3717. rdar://problem/103383066 [Xcode] Stop checking USE_LLVM_TARGET_TRIPLES_FOR_CLANG https://bugs.webkit.org/show_bug.cgi?id=249348 Reviewed by Tim Horton. Remove checks in DerivedSources Makefiles and make all target triple logic unconditional. Xcode has built with target triples for years, since at least Xcode 11. Triples are also mandatory for building platforms like Mac Catalyst. * Source/JavaScriptCore/DerivedSources.make: * Source/WebCore/DerivedSources.make: * Source/WebKit/DerivedSources.make: * Tools/DumpRenderTree/DerivedSources.make: * Tools/WebKitTestRunner/DerivedSources.make: Canonical link: https://commits.webkit.org/257896@main Canonical link: https://commits.webkit.org/257698.8@safari-7615.1.15-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c65b2: Versioning.
Branch: refs/heads/safari-7615.1.14-branch Home: https://github.com/WebKit/WebKit Commit: 3c65b2685ae9e5e5062bcc55238fcbf74b0b8401 https://github.com/WebKit/WebKit/commit/3c65b2685ae9e5e5062bcc55238fcbf74b0b8401 Author: Alan Coon Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.14.6 Canonical link: https://commits.webkit.org/257350.18@safari-7615.1.14-branch Commit: e5c099915c922b6dd06c34eefae5738bcc0a40af https://github.com/WebKit/WebKit/commit/e5c099915c922b6dd06c34eefae5738bcc0a40af Author: Russell Epstein Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.14.7 Canonical link: https://commits.webkit.org/257350.18@safari-7615.1.14-branch Compare: https://github.com/WebKit/WebKit/compare/fad51bbdbed0...e5c099915c92 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9b23f: [CMake] Remove WEBKIT_CREATE_FORWARDING_HEADER macro
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9b23fd18699936c541c05a51c582a32822537ec https://github.com/WebKit/WebKit/commit/a9b23fd18699936c541c05a51c582a32822537ec Author: Don Olmstead Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/cmake/WebKitMacros.cmake Log Message: --- [CMake] Remove WEBKIT_CREATE_FORWARDING_HEADER macro https://bugs.webkit.org/show_bug.cgi?id=249343 Reviewed by Michael Catanzaro. The macro is no longer used so delete it. * Source/cmake/WebKitMacros.cmake: Canonical link: https://commits.webkit.org/257897@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f43b5: [Xcode] Stop checking USE_LLVM_TARGET_TRIPLES_FOR_...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f43b50f37176e2fa33ee3207ed7e1e13522b954 https://github.com/WebKit/WebKit/commit/0f43b50f37176e2fa33ee3207ed7e1e13522b954 Author: Elliott Williams Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/JavaScriptCore/DerivedSources.make M Source/WebCore/DerivedSources.make M Source/WebKit/DerivedSources.make M Tools/DumpRenderTree/DerivedSources.make M Tools/WebKitTestRunner/DerivedSources.make Log Message: --- [Xcode] Stop checking USE_LLVM_TARGET_TRIPLES_FOR_CLANG https://bugs.webkit.org/show_bug.cgi?id=249348 Reviewed by Tim Horton. Remove checks in DerivedSources Makefiles and make all target triple logic unconditional. Xcode has built with target triples for years, since at least Xcode 11. Triples are also mandatory for building platforms like Mac Catalyst. * Source/JavaScriptCore/DerivedSources.make: * Source/WebCore/DerivedSources.make: * Source/WebKit/DerivedSources.make: * Tools/DumpRenderTree/DerivedSources.make: * Tools/WebKitTestRunner/DerivedSources.make: Canonical link: https://commits.webkit.org/257896@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8164c6: Revert a1197f89b028. rdar://103331141
Branch: refs/heads/safari-7615.1.15-branch Home: https://github.com/WebKit/WebKit Commit: 8164c632b0cd3938d0e5b62134858b303ca2a5d2 https://github.com/WebKit/WebKit/commit/8164c632b0cd3938d0e5b62134858b303ca2a5d2 Author: Alan Coon Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/media/media-usage-state-expected.txt M LayoutTests/media/media-usage-state.html M Source/WebCore/PAL/pal/cocoa/UsageTrackingSoftLink.h M Source/WebCore/PAL/pal/cocoa/UsageTrackingSoftLink.mm M Source/WebCore/html/MediaElementSession.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h M Source/WebCore/platform/graphics/MediaUsageInfo.h M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl M Source/WebKit/UIProcess/Media/cocoa/MediaUsageManagerCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm Log Message: --- Revert a1197f89b028. rdar://103331141 Revert "Remove Quirk for shouldAutoplayForArbitraryUserGesture" This reverts commit a1197f89b028684053b8ef59c3e88babed27493a. Canonical link: https://commits.webkit.org/257698.7@safari-7615.1.15-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d9e131: Add a way to register custom URL schemes with _WKW...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9e131c11be037bf572da8e2c71c42245ac99351 https://github.com/WebKit/WebKit/commit/d9e131c11be037bf572da8e2c71c42245ac99351 Author: Timothy Hatcher Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMatchPatternCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionMatchPattern.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionMatchPattern.mm Log Message: --- Add a way to register custom URL schemes with _WKWebExtensionMatchPattern. https://bugs.webkit.org/show_bug.cgi?id=249336 Reviewed by Brian Weinstein. This method is needed to register any custom URL schemes used by the app for the extension base URLs, other than `webkit-extension`, or if extensions should have access to other supported URL schemes when using ``. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm: (+[_WKWebExtensionMatchPattern registerCustomURLScheme:]): Added. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMatchPatternCocoa.mm: (WebKit::WebExtensionMatchPattern::validSchemes): (WebKit::WebExtensionMatchPattern::supportedSchemes): (WebKit::WebExtensionMatchPattern::registerCustomURLScheme): * Source/WebKit/UIProcess/Extensions/WebExtensionMatchPattern.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionMatchPattern.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/257895@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd6656: Address more Web Extensions API review feedback.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd6656ee5c14cd925632f5072b4d1a47693caa41 https://github.com/WebKit/WebKit/commit/fd6656ee5c14cd925632f5072b4d1a47693caa41 Author: Timothy Hatcher Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h Log Message: --- Address more Web Extensions API review feedback. https://bugs.webkit.org/show_bug.cgi?id=249349 Reviewed by Brian Weinstein. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h: Canonical link: https://commits.webkit.org/257894@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f19d0: REGRESSION(257861@main?): 8X Scrolling API-Tests a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f19d05a7336ccd24aa222e8a132cd3fc2a119dd https://github.com/WebKit/WebKit/commit/3f19d05a7336ccd24aa222e8a132cd3fc2a119dd Author: Wenson Hsieh Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/Platform/spi/ios/UIKitSPI.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- REGRESSION(257861@main?): 8X Scrolling API-Tests are constantly failing or timing out https://bugs.webkit.org/show_bug.cgi?id=249339 rdar://103373219 Reviewed by Aditya Keerthi. Some of these API tests began failing because we're attempting to wait for `KeyboardWillShow` notifications in the case where the keyboard never actually shows up (due to the fact that API tests run in a non-UI-app context). Mitigate this by checking for the existence of an `UIKeyboard` right after showing the keyboard, after focusing an editable element. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _didFinishTextInteractionInTextInputContext:]): Additionally, some of the `RequestTextInputContext` API tests are legitimately failing due to the fact that they expect us to zoom to reveal the focused element after finishing interaction in a `_WKTextInputContext`; the way this worked before is that we set the `m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement` flag, which would cause us to then call into `-_zoomToRevealFocusedElement` after the next editor state update. To fix this, we create a new `_revealFocusedElementDeferrer` in `-_didFinishTextInteractionInTextInputContext:`, allowing us to reveal the focused element after the next editor state arrives. (-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]): Canonical link: https://commits.webkit.org/257893@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 43999b: [Gardening]: [ New Test ] (257671@main): [ iOS ] i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43999bd2820e229c53a96b3af8930b1aa7fadcaf https://github.com/WebKit/WebKit/commit/43999bd2820e229c53a96b3af8930b1aa7fadcaf Author: Karl Rackler Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [Gardening]: [ New Test ] (257671@main): [ iOS ] imported/w3c/web-platform-tests/fullscreen/api/element-ready-check-allowed-cross-origin.sub.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=249360 rdar://103381183 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/257892@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c65b2: Versioning.
Branch: refs/tags/WebKit-7615.1.14.6 Home: https://github.com/WebKit/WebKit Commit: 3c65b2685ae9e5e5062bcc55238fcbf74b0b8401 https://github.com/WebKit/WebKit/commit/3c65b2685ae9e5e5062bcc55238fcbf74b0b8401 Author: Alan Coon Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.14.6 Canonical link: https://commits.webkit.org/257350.18@safari-7615.1.14-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88df8b: Versioning.
Branch: refs/heads/safari-7615.1.14.4-branch Home: https://github.com/WebKit/WebKit Commit: 88df8bd89363678347460ddbcc8c8c3cec1d https://github.com/WebKit/WebKit/commit/88df8bd89363678347460ddbcc8c8c3cec1d Author: Alan Coon Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.14.4.1 Canonical link: https://commits.webkit.org/257350.14@safari-7615.1.14.4-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ee248: Add support for embedded surveys in post or page c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ee248acc11659aa7ba747c89638068a5e5116b9 https://github.com/WebKit/WebKit/commit/0ee248acc11659aa7ba747c89638068a5e5116b9 Author: Jonathan Davis Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: A Websites/webkit.org/wp-content/plugins/webkit-survey/plugin.php A Websites/webkit.org/wp-content/plugins/webkit-survey/results.php A Websites/webkit.org/wp-content/plugins/webkit-survey/survey.php Log Message: --- Add support for embedded surveys in post or page content on webkit.org https://bugs.webkit.org/show_bug.cgi?id=249342 Reviewed by Timothy Hatcher. * Websites/webkit.org/wp-content/plugins/webkit-survey/plugin.php: Added. * Websites/webkit.org/wp-content/plugins/webkit-survey/results.php: Added. * Websites/webkit.org/wp-content/plugins/webkit-survey/survey.php: Added. Canonical link: https://commits.webkit.org/257891@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7615.1.14.4-branch Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e2640: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e2640c9c0504572a729732b6938ef0dee00572d https://github.com/WebKit/WebKit/commit/3e2640c9c0504572a729732b6938ef0dee00572d Author: Fujii Hironori Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/platform/wincairo-wk1/TestExpectations M LayoutTests/platform/wincairo/TestExpectations A LayoutTests/platform/wincairo/transforms/3d/point-mapping/3d-point-mapping-4-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening https://bugs.webkit.org/show_bug.cgi?id=240439 * LayoutTests/platform/wincairo-wk1/TestExpectations: * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/transforms/3d/point-mapping/3d-point-mapping-4-expected.txt: Added. Canonical link: https://commits.webkit.org/257890@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86b8b3: REGRESSION (257768@main): [ iOS ] fast/attachment/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86b8b3a51a7114ac6f6bf03410b1c2cef67b9bdf https://github.com/WebKit/WebKit/commit/86b8b3a51a7114ac6f6bf03410b1c2cef67b9bdf Author: Ryosuke Niwa Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: A LayoutTests/platform/ios/fast/attachment/attachment-select-on-click-expected.txt Log Message: --- REGRESSION (257768@main): [ iOS ] fast/attachment/attachment-select-on-click.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=249353 Unreviewed. Add iOS specific result after 257768@main as this test had always failed on iOS. * LayoutTests/platform/ios/fast/attachment/attachment-select-on-click-expected.txt: Added. Canonical link: https://commits.webkit.org/257889@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b9b7b8: Update isMasonryRows/Columns to areMasonryRows/Col...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9b7b85430bcf1fa938d28113a67d179da852fad https://github.com/WebKit/WebKit/commit/b9b7b85430bcf1fa938d28113a67d179da852fad Author: Brandon Stewart Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/rendering/RenderGrid.cpp M Source/WebCore/rendering/RenderGrid.h Log Message: --- Update isMasonryRows/Columns to areMasonryRows/Columns https://bugs.webkit.org/show_bug.cgi?id=249325 Reviewed by Brent Fulgham. Update the function names isMasonryRows/Columns. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::areMasonryRows const): (WebCore::RenderGrid::areMasonryColumns const): (WebCore::RenderGrid::autoRepeatColumnsType const): (WebCore::RenderGrid::autoRepeatRowsType const): (WebCore::RenderGrid::placeItemsOnGrid): (WebCore::RenderGrid::gridAreaBreadthForChildIncludingAlignmentOffsets const): (WebCore::RenderGrid::columnAxisOffsetForChild const): (WebCore::RenderGrid::rowAxisOffsetForChild const): (WebCore::RenderGrid::isMasonryRows const): Deleted. (WebCore::RenderGrid::isMasonryColumns const): Deleted. * Source/WebCore/rendering/RenderGrid.h: Canonical link: https://commits.webkit.org/257888@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 350f4f: HTMLTemplateElement should have shadowRootMode att...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 350f4f7ded4367ff4ca04675f4c9fb198e972f67 https://github.com/WebKit/WebKit/commit/350f4f7ded4367ff4ca04675f4c9fb198e972f67 Author: Ryosuke Niwa Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-basic.tentative-expected.txt M Source/WebCore/html/HTMLTemplateElement.cpp M Source/WebCore/html/HTMLTemplateElement.h M Source/WebCore/html/HTMLTemplateElement.idl M Source/WebCore/html/parser/HTMLConstructionSite.cpp Log Message: --- HTMLTemplateElement should have shadowRootMode attribute https://bugs.webkit.org/show_bug.cgi?id=249287 Reviewed by Chris Dumez. Add shadowRootMode IDL attribute to HTMLTemplateElement. * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-basic.tentative-expected.txt: * Source/WebCore/html/HTMLTemplateElement.cpp: (WebCore::HTMLTemplateElement::shadowRootMode const): Added. (WebCore::HTMLTemplateElement::setShadowRootMode): Added. * Source/WebCore/html/HTMLTemplateElement.h: * Source/WebCore/html/HTMLTemplateElement.idl: * Source/WebCore/html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLTemplateElement): Fixed a bug that this wasn't checking whether declarative shadow DOM is enabled or not. This is necessary now since the streaming is always enabled as of 257820@main. Canonical link: https://commits.webkit.org/257887@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da81ee: [Lockdown Mode] Disable the WebLocks API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da81ee12ac03c37ab39ccab197d2e3df544a2b14 https://github.com/WebKit/WebKit/commit/da81ee12ac03c37ab39ccab197d2e3df544a2b14 Author: Brent Fulgham Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [Lockdown Mode] Disable the WebLocks API https://bugs.webkit.org/show_bug.cgi?id=249264 Reviewed by Chris Dumez. Disable WebLocks in Lockdown Mode. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/257886@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 555ba9: [Lockdown Mode] Disable Service Workers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 555ba9efdb304346134612cfc29c1339b7d539ef https://github.com/WebKit/WebKit/commit/555ba9efdb304346134612cfc29c1339b7d539ef Author: Brent Fulgham Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [Lockdown Mode] Disable Service Workers https://bugs.webkit.org/show_bug.cgi?id=249262 Reviewed by Chris Dumez. Disable Service Workers when in Lockdown Mode. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/257885@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 67f766: [JSC] Enable AVX JIT code generation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 67f7666861e7cb1e47c9074c7e4f1154679c7d2b https://github.com/WebKit/WebKit/commit/67f7666861e7cb1e47c9074c7e4f1154679c7d2b Author: Yusuke Suzuki Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/assembler/X86Assembler.h Log Message: --- [JSC] Enable AVX JIT code generation https://bugs.webkit.org/show_bug.cgi?id=249322 rdar://problem/103361339 Reviewed by Justin Michaud. This patch flips a flag so that x86_64 JIT will use AVX if AVX is supported. This is a part of bringup work of Wasm SIMD on x86_64 where we support SIMD operation with AVX. A/B test says neutral on iMac20,1 and MacBookAir8,2 for JetStream2 and Speedometer2. * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::supportsAVX): Canonical link: https://commits.webkit.org/257884@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 952779: Add more subtests to css/css-typed-om/the-stylepro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 952779e0423ea988d0793094865a63ea4bb1a667 https://github.com/WebKit/WebKit/commit/952779e0423ea988d0793094865a63ea4bb1a667 Author: Chris Dumez Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/accent-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/all-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-delay-end.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-delay-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-delay-start.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-direction-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-fill-mode-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-play-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-timing-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/backdrop-filter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/backface-visibility-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-attachment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-blend-mode-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-clip-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-image-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-repeat-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-size-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/baseline-shift-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/block-size-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-collapse-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-outset-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-repeat-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-slice-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-source-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-width-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-radius-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-style-expected.tx
[webkit-changes] [WebKit/WebKit] 7c4ff0: [CMake] Make WebKitLegacy a framework
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c4ff08c02d30dc38f4b05a58d187b2476cb0eb7 https://github.com/WebKit/WebKit/commit/7c4ff08c02d30dc38f4b05a58d187b2476cb0eb7 Author: Don Olmstead Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKitLegacy/CMakeLists.txt M Source/WebKitLegacy/PlatformMac.cmake M Source/WebKitLegacy/PlatformWin.cmake M Source/cmake/WebKitMacros.cmake M Tools/DumpRenderTree/CMakeLists.txt M Tools/DumpRenderTree/PlatformWin.cmake M Tools/MiniBrowser/win/CMakeLists.txt M Tools/TestRunnerShared/CMakeLists.txt M Tools/TestWebKitAPI/CMakeLists.txt Log Message: --- [CMake] Make WebKitLegacy a framework https://bugs.webkit.org/show_bug.cgi?id=249273 Reviewed by Michael Catanzaro. Create a framework target for WebKitLegacy. Copy the headers using `WEBKIT_COPY_FILES`. Use the new `WebKit::WebKitLegacy` target throughout the build by using it in `_FRAMEWORKS`. Remove `WEBKIT_MAKE_FORWARDING_HEADERS` as it is no longer used. * Source/WebKitLegacy/CMakeLists.txt: * Source/WebKitLegacy/PlatformMac.cmake: * Source/WebKitLegacy/PlatformWin.cmake: * Source/cmake/WebKitMacros.cmake: * Tools/DumpRenderTree/CMakeLists.txt: * Tools/DumpRenderTree/PlatformWin.cmake: * Tools/MiniBrowser/win/CMakeLists.txt: * Tools/TestRunnerShared/CMakeLists.txt: * Tools/TestWebKitAPI/CMakeLists.txt: Canonical link: https://commits.webkit.org/257882@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d57630: [ews] Optimization to reduce number of results dat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d57630c96a632b9f8ed4796d910cb3391d0c8c72 https://github.com/WebKit/WebKit/commit/d57630c96a632b9f8ed4796d910cb3391d0c8c72 Author: Aakash Jain Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews] Optimization to reduce number of results database lookups https://bugs.webkit.org/show_bug.cgi?id=249340 rdar://103373814 Reviewed by Ryan Haddad. When there are lot of test failures, we consult results db for every failure. However, we can bypass the retry logic only if ALL the test failures are pre-existing. If even one failure is not pre-existing, we can't benefit from results database lookups. So, we can optimize the number of results database calls, by skipping consulting results-db for further tests the moment we know that one of the test failure is not pre-existing. * Tools/CISupport/ews-build/steps.py: (RunWebKitTests.filter_failures_using_results_db): Canonical link: https://commits.webkit.org/257881@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a6ea5: [WebAssembly SIMD] Support floating-point absolute...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a6ea5eb8b9b6395b6ee4fe11afb07861cea519c https://github.com/WebKit/WebKit/commit/3a6ea5eb8b9b6395b6ee4fe11afb07861cea519c Author: David Degazio Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/assembler/X86Assembler.h M Source/JavaScriptCore/b3/air/AirLowerMacros.cpp M Source/JavaScriptCore/b3/air/AirOpcode.opcodes M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp Log Message: --- [WebAssembly SIMD] Support floating-point absolute value, negate, min, max, and square-root on Intel https://bugs.webkit.org/show_bug.cgi?id=249275 rdar://103326365 Reviewed by Yusuke Suzuki. Adds support for missing floating-point opcodes to our WebAssembly SIMD support on Intel, with some fixes to bugs that came up running the spec tests. * Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::compareFloatingPointVectorUnordered): (JSC::MacroAssemblerX86_64::vectorMax): (JSC::MacroAssemblerX86_64::vectorMin): (JSC::MacroAssemblerX86_64::vectorPmin): (JSC::MacroAssemblerX86_64::vectorPmax): (JSC::MacroAssemblerX86_64::vectorTruncSatSignedFloat64): (JSC::MacroAssemblerX86_64::vectorSqrt): (JSC::MacroAssemblerX86_64::vectorSshr8): (JSC::MacroAssemblerX86_64::vectorUshr8): (JSC::MacroAssemblerX86_64::vectorSshr): * Source/JavaScriptCore/assembler/X86Assembler.h: (JSC::X86Assembler::vmaxps_rrr): (JSC::X86Assembler::vmaxpd_rrr): (JSC::X86Assembler::vminps_rrr): (JSC::X86Assembler::vminpd_rrr): (JSC::X86Assembler::vsqrtps_rr): (JSC::X86Assembler::vsqrtpd_rr): (JSC::X86Assembler::vminpd_mrr): (JSC::X86Assembler::vpsrlw_i8rr): (JSC::X86Assembler::vpsrld_i8rr): (JSC::X86Assembler::vpsrlq_i8rr): (JSC::X86Assembler::vpsraw_i8rr): (JSC::X86Assembler::vpsrad_i8rr): (JSC::X86Assembler::vcmpeqpd_rrr): Deleted. (JSC::X86Assembler::vpsraq_rrr): Deleted. * Source/JavaScriptCore/b3/air/AirLowerMacros.cpp: (JSC::B3::Air::lowerMacros): * Source/JavaScriptCore/b3/air/AirOpcode.opcodes: * Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp: (JSC::Wasm::AirIRGenerator64::addSIMDV_V): (JSC::Wasm::AirIRGenerator64::addSIMDShift): Canonical link: https://commits.webkit.org/257880@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0227f: [Cocoa] Refactor logic for lookalike character san...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0227fc7d5f7ad63bff6514bf21f77134eddeb64 https://github.com/WebKit/WebKit/commit/e0227fc7d5f7ad63bff6514bf21f77134eddeb64 Author: Wenson Hsieh Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj M Source/WebCore/PAL/pal/PlatformMac.cmake A Source/WebCore/PAL/pal/cocoa/NetworkConnectionIntegritySoftLink.h A Source/WebCore/PAL/pal/cocoa/NetworkConnectionIntegritySoftLink.mm A Source/WebCore/PAL/pal/spi/cocoa/NetworkConnectionIntegritySPI.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in A Source/WebKit/NetworkProcess/cocoa/NetworkConnectionIntegrityHelpers.h A Source/WebKit/NetworkProcess/cocoa/NetworkConnectionIntegrityHelpers.mm M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h Log Message: --- [Cocoa] Refactor logic for lookalike character sanitization when copying or sharing links https://bugs.webkit.org/show_bug.cgi?id=249244 rdar://103314642 Reviewed by Aditya Keerthi. * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/PlatformMac.cmake: * Source/WebCore/PAL/pal/cocoa/NetworkConnectionIntegritySoftLink.h: Added. * Source/WebCore/PAL/pal/cocoa/NetworkConnectionIntegritySoftLink.mm: Added. * Source/WebCore/PAL/pal/spi/cocoa/NetworkConnectionIntegritySPI.h: Added. Add PAL softlinking and SPI headers for frameworks that are required for the "network connection integrity" feature. * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::requestLookalikeCharacterStrings): Add an IPC method to asynchronously fetch a set of lookalike character strings. * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h: * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in: * Source/WebKit/NetworkProcess/cocoa/NetworkConnectionIntegrityHelpers.h: Added. * Source/WebKit/NetworkProcess/cocoa/NetworkConnectionIntegrityHelpers.mm: Added. Add a helper file that contains the definition of `requestLookalikeCharacterStrings` (and any other related helpers that are related to network connection integrity, which we'll require in subsequent patches). * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad): `updateLookalikeCharacterStringsIfNeeded()` after committing the mainframe load. (WebKit::WebPage::updateLookalikeCharacterStringsIfNeeded): Refactor this code such that we request and cache lookalike string data in the networking process, and then propagate these strings down into the web process. * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/257879@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc1997: [Cocoa] Use a link check for background web conten...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc19977ced76d65c66f5903b23d85e391500e454 https://github.com/WebKit/WebKit/commit/dc19977ced76d65c66f5903b23d85e391500e454 Author: Miguel Salinas Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h M Source/WebKit/UIProcess/ProcessThrottler.cpp Log Message: --- [Cocoa] Use a link check for background web content suspension https://bugs.webkit.org/show_bug.cgi?id=249157 rdar://problem/103258911 Reviewed by Chris Dumez. Add a link check for fully suspending background web content processes. * Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h: * Source/WebKit/UIProcess/ProcessThrottler.cpp: (WebKit::ProcessThrottler::setShouldTakeSuspendedAssertion): Canonical link: https://commits.webkit.org/257878@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2c89b: buildbot configuration step shows "OS: Unkown" for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2c89b7778a10aecb852b7b7e1b73cacd8d2840b https://github.com/WebKit/WebKit/commit/f2c89b7778a10aecb852b7b7e1b73cacd8d2840b Author: Ryan Haddad Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- buildbot configuration step shows "OS: Unkown" for Ventura bots https://bugs.webkit.org/show_bug.cgi?id=249332 rdar://103371533 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (PrintConfiguration.convert_build_to_os_name): Add Ventura to our version / name map. Canonical link: https://commits.webkit.org/257877@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45eab1: Don't allow text selection to start on a HTMLMedia...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45eab14f59252dde66d9a3bf9bffedada1ecfd34 https://github.com/WebKit/WebKit/commit/45eab14f59252dde66d9a3bf9bffedada1ecfd34 Author: Ahmad Saleem Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: A LayoutTests/media/video-controls-start-selection-expected.txt A LayoutTests/media/video-controls-start-selection.html M Source/WebCore/html/HTMLMediaElement.h Log Message: --- Don't allow text selection to start on a HTMLMediaElement Don't allow text selection to start on a HTMLMediaElement https://bugs.webkit.org/show_bug.cgi?id=249249 Reviewed by Ryosuke Niwa. This patch is to align Webkit with Blink / Chromium and Gecko / Firefox. Merge - https://src.chromium.org/viewvc/blink?revision=196741&view=revision This patch introduces a bool function with the return value of 'false' to disable text selection on media element controls. * Source/WebCore/html/HTMLMediaElement.h: Add 'bool' with return value of 'false' * LayoutTests/media/video-controls-start-selection.html: Add Test Case * LayoutTests/media/video-controls-start-selection-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/257876@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.14.4 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b8cd1: Add filtering for WebNavigation events.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b8cd1e53947aed4b0679d330162f563f190b828 https://github.com/WebKit/WebKit/commit/0b8cd1e53947aed4b0679d330162f563f190b828 Author: Brian Weinstein Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: A Source/WebKit/Shared/Extensions/_WKWebExtensionUtilities.h A Source/WebKit/Shared/Extensions/_WKWebExtensionUtilities.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebNavigationEventCocoa.mm M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWebNavigationEvent.h A Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.h A Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm Log Message: --- Add filtering for WebNavigation events. https://bugs.webkit.org/show_bug.cgi?id=249258 rdar://102820594 Reviewed by Timothy Hatcher. When a webNavigation event listener is added, parse and save the filter that was included with the listener. When attempting to fire a webNavigation event, check the given URL and see if it passes the included filter. The filter parsing + managing code is written in Objective-C, and more tests are coming in upcoming patches. * Source/WebKit/Shared/Extensions/_WKWebExtensionUtilities.h: Added. * Source/WebKit/Shared/Extensions/_WKWebExtensionUtilities.mm: Added. (classToClassString): (+[_WKWebExtensionUtilities validateContentsOfDictionary:requiredKeys:optionalKeys:keyToExpectedValueType:outExceptionString:]): Validates the contents of the given dictionary, checking for the presence of required keys, possible optional keys, and type checking. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Add new files. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebNavigationEventCocoa.mm: (WebKit::WebExtensionAPIWebNavigationEvent::invokeListenersWithArgument): If the listener has a filter, only invoke the listener if the filter matches the target URL. (WebKit::WebExtensionAPIWebNavigationEvent::addListener): Handle the filter. (WebKit::WebExtensionAPIWebNavigationEvent::removeListener): Ditto. (WebKit::WebExtensionAPIWebNavigationEvent::hasListener): Ditto. * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWebNavigationEvent.h: Change the listener vector to a vector of pairs. * Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.h: Copied from Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWebNavigationEvent.h. * Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm: Added. (-[_WKWebExtensionWebNavigationURLPredicate initWithTypeString:value:outErrorMessage:]): (-[_WKWebExtensionWebNavigationURLPredicate matchesURL:]): (-[_WKWebExtensionWebNavigationURLFilter initWithDictionary:outErrorMessage:]): (-[_WKWebExtensionWebNavigationURLFilter matchesURL:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm: (TestWebKitAPI::TEST): Add some basic tests around filtering. Canonical link: https://commits.webkit.org/257875@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b7167: REGRESSION(257823@main): 5X lookbehind.js Test262-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b71676e914805bc2791211047d1f0ac256b45fa https://github.com/WebKit/WebKit/commit/2b71676e914805bc2791211047d1f0ac256b45fa Author: Robert Jenner Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M JSTests/test262/config.yaml Log Message: --- REGRESSION(257823@main): 5X lookbehind.js Test262-tests are constant failures https://bugs.webkit.org/show_bug.cgi?id=249330 Unreviewed test gardening. * JSTests/test262/config.yaml: Canonical link: https://commits.webkit.org/257874@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b957d5: [@property] Allow CSS-wide keywords in registered ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b957d5f5e295f6a8c8557b75c73ac2ab424f6b6d https://github.com/WebKit/WebKit/commit/b957d5f5e295f6a8c8557b75c73ac2ab424f6b6d Author: Antti Koivisto Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/css-custom-properties-api/inline-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt M Source/WebCore/css/CSSCustomPropertyValue.cpp M Source/WebCore/css/CSSCustomPropertyValue.h M Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp M Source/WebCore/css/parser/CSSParserTokenRange.h M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp Log Message: --- [@property] Allow CSS-wide keywords in registered custom properties https://bugs.webkit.org/show_bug.cgi?id=249305 Reviewed by Alan Baradlay. CSS-wide keywords (initial, inherit, unset, revert, revert-layer) should be allowed whatever the syntax is. * LayoutTests/css-custom-properties-api/inline-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt: * Source/WebCore/css/CSSCustomPropertyValue.cpp: (WebCore::CSSCustomPropertyValue::containsCSSWideKeyword const): Find if this value contains a CSS-wide keyword, including the "*" case where we just have tokens. * Source/WebCore/css/CSSCustomPropertyValue.h: * Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp: (WebCore::DOMCSSRegisterCustomProperty::registerProperty): CSS-wide keywords are not allowed as the initial value though. * Source/WebCore/css/parser/CSSParserTokenRange.h: (WebCore::CSSParserTokenRange::consumeAll): Add a helper to avoid silly consume loops. * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeCustomPropertyValueWithSyntax): (WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies): (WebCore::CSSPropertyParser::parseTypedCustomPropertyValue): Canonical link: https://commits.webkit.org/257873@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0ad49: Use dump-as-markup.js in fast/dom/delete-contents....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0ad494f99b6d91fb6f69c0a47fb78e9012b202f https://github.com/WebKit/WebKit/commit/f0ad494f99b6d91fb6f69c0a47fb78e9012b202f Author: Ryosuke Niwa Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/fast/dom/delete-contents.html Log Message: --- Use dump-as-markup.js in fast/dom/delete-contents.html https://bugs.webkit.org/show_bug.cgi?id=249124 Unreviewed test fix. Revert 257780@main. * LayoutTests/fast/dom/delete-contents.html: Canonical link: https://commits.webkit.org/257872@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e0148: Continue refactoring caret animation and painting ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e01488099a49125a027cf0e2103ba7c869e2269 https://github.com/WebKit/WebKit/commit/2e01488099a49125a027cf0e2103ba7c869e2269 Author: Richard Robinson Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/editing/FrameSelection.h M Source/WebCore/platform/CaretAnimator.h M Source/WebCore/platform/SimpleCaretAnimator.cpp M Source/WebCore/platform/SimpleCaretAnimator.h Log Message: --- Continue refactoring caret animation and painting logic https://bugs.webkit.org/show_bug.cgi?id=248978 rdar://102450089 Reviewed by Simon Fraser. * Source/WebCore/editing/FrameSelection.cpp: (WebCore::FrameSelection::paintCaret): (WebCore::CaretBase::paintCaret const): (WebCore::DragCaretController::paintDragCaret const): * Source/WebCore/editing/FrameSelection.h: * Source/WebCore/platform/CaretAnimator.h: (WebCore::CaretAnimator::presentationProperties const): (WebCore::CaretAnimator::timeSinceStart const): Deleted. * Source/WebCore/platform/SimpleCaretAnimator.cpp: (WebCore::SimpleCaretAnimator::updateAnimationProperties): (WebCore::SimpleCaretAnimator::debugDescription const): * Source/WebCore/platform/SimpleCaretAnimator.h: Canonical link: https://commits.webkit.org/257871@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 007cd2: macOS-AppleSilicon-Ventura-Debug-Build-EWS Queue B...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 007cd2b0ec85337c14af2648ff5a5b10f14521ca https://github.com/WebKit/WebKit/commit/007cd2b0ec85337c14af2648ff5a5b10f14521ca Author: Chris Gibb Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Tools/CISupport/ews-build/config.json M Tools/CISupport/ews-build/factories_unittest.py Log Message: --- macOS-AppleSilicon-Ventura-Debug-Build-EWS Queue Bringup https://bugs.webkit.org/show_bug.cgi?id=249315 rdar://101406047 Reviewed by Ryan Haddad. macOS-AppleSilicon-Ventura-Debug-Build-EWS Queue Bringup * Tools/CISupport/ews-build/config.json: * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps): Canonical link: https://commits.webkit.org/257870@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e38ea9: macOS-AppleSilicon-Ventura-Debug-WK2-Tests-EWS Que...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e38ea9cb6f0e7453d21355414bef952c6d5bacc0 https://github.com/WebKit/WebKit/commit/e38ea9cb6f0e7453d21355414bef952c6d5bacc0 Author: Chris Gibb Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Tools/CISupport/ews-build/config.json M Tools/CISupport/ews-build/factories_unittest.py Log Message: --- macOS-AppleSilicon-Ventura-Debug-WK2-Tests-EWS Queue Bringup https://bugs.webkit.org/show_bug.cgi?id=249316 rdar://101406098 Reviewed by Ryan Haddad. macOS-AppleSilicon-Ventura-Debug-WK2-Tests-EWS Queue Bringup * Tools/CISupport/ews-build/config.json: * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps): Canonical link: https://commits.webkit.org/257869@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ddf9ee: Add Masonry support in autoPlacementAxisDirection
Branch: refs/heads/eng/masonry_auto_placement_direction Home: https://github.com/WebKit/WebKit Commit: ddf9eeea33c5d0bd7d167b2eb93fa76eb00d0305 https://github.com/WebKit/WebKit/commit/ddf9eeea33c5d0bd7d167b2eb93fa76eb00d0305 Author: Brandon Stewart Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/rendering/RenderGrid.cpp Log Message: --- Add Masonry support in autoPlacementAxisDirection https://bugs.webkit.org/show_bug.cgi?id=249326 Reviewed by NOBODY (OOPS!). While working on track-sizing I noticed that align-content/masonry-align-content-003.html was only being rendered on a single column instead of being spread across multiple columns. This patch adds a check in autoPlacementMajor/MinorAxisDirection for Masonry. No new test in this patch. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::autoPlacementMajorAxisDirection const): (WebCore::RenderGrid::autoPlacementMinorAxisDirection const): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1697c3: Re-revert ThreadSafeWeakHashSet
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1697c3c9439bd31839ec3d909df5a401215637f2 https://github.com/WebKit/WebKit/commit/1697c3c9439bd31839ec3d909df5a401215637f2 Author: Alex Christensen Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt R Source/WTF/wtf/ThreadSafeWeakHashSet.h M Source/WTF/wtf/ThreadSafeWeakPtr.h M Source/WTF/wtf/WeakHashSet.h M Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h M Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp M Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.h M Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h M Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h M Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm M Source/WebKit/NetworkProcess/NetworkDataTask.cpp M Source/WebKit/NetworkProcess/NetworkDataTask.h M Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h M Source/WebKit/Platform/IPC/Connection.h M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm M Source/WebKit/UIProcess/Notifications/WebNotification.h M Source/WebKit/UIProcess/ProcessAssertion.h M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp Log Message: --- Re-revert ThreadSafeWeakHashSet https://bugs.webkit.org/show_bug.cgi?id=249328 Unreviewed. * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/CMakeLists.txt: * Source/WTF/wtf/ThreadSafeWeakHashSet.h: Removed. * Source/WTF/wtf/ThreadSafeWeakPtr.h: * Source/WTF/wtf/WeakHashSet.h: * Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp: (WebCore::FileSystemDirectoryHandle::getFileHandle): (WebCore::FileSystemDirectoryHandle::getDirectoryHandle): (WebCore::FileSystemDirectoryHandle::getHandle): * Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h: * Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp: (WebCore::AudioWorkletGlobalScope::createProcessor): (WebCore::AudioWorkletGlobalScope::processorIsNoLongerNeeded): (WebCore::AudioWorkletGlobalScope::visitProcessors): * Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.h: * Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: * Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h: * Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm: (WebCore::MediaRecorderPrivateWriter::compressedVideoOutputBufferCallback): (WebCore::MediaRecorderPrivateWriter::compressedAudioOutputBufferCallback): (WebCore::MediaRecorderPrivateWriter::flushCompressedSampleBuffers): (WebCore::MediaRecorderPrivateWriter::stopRecording): (WebCore::MediaRecorderPrivateWriter::fetchData): * Source/WebKit/NetworkProcess/NetworkDataTask.cpp: (WebKit::NetworkDataTask::scheduleFailure): * Source/WebKit/NetworkProcess/NetworkDataTask.h: * Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::~NetworkDataTaskBlob): * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::invalidateAndCancel): (WebKit::NetworkSession::registerNetworkDataTask): (WebKit::NetworkSession::unregisterNetworkDataTask): (WebKit::NetworkSession::setEmulatedConditions): * Source/WebKit/NetworkProcess/NetworkSession.h: * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h: * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::~WebSWServerToContextConnection): * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa): (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection): * Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp: (WebKit::NetworkDataTaskCurl::~NetworkDataTaskCurl): * Source/Web
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.14.5 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fad51b: Versioning.
Branch: refs/heads/safari-7615.1.14-branch Home: https://github.com/WebKit/WebKit Commit: fad51bbdbed0f2f266dcd7c58db56cdf925a45e1 https://github.com/WebKit/WebKit/commit/fad51bbdbed0f2f266dcd7c58db56cdf925a45e1 Author: Alan Coon Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.14.5 Canonical link: https://commits.webkit.org/257350.17@safari-7615.1.14-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6de097: Cherry-pick 6f3c84c00ec6. rdar://problem/103301850
Branch: refs/heads/safari-7615.1.15-branch Home: https://github.com/WebKit/WebKit Commit: 6de097d497ecb647a93d76629f7d67f84af227f8 https://github.com/WebKit/WebKit/commit/6de097d497ecb647a93d76629f7d67f84af227f8 Author: Per Arne Vollan Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Log Message: --- Cherry-pick 6f3c84c00ec6. rdar://problem/103301850 [Lockdown mode][iOS] Add telemetry for syscall mach and kernel MIG https://bugs.webkit.org/show_bug.cgi?id=249224 rdar://103301850 Reviewed by Brent Fulgham. Add telemetry for syscall mach and kernel MIG in Lockdown mode on iOS. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Canonical link: https://commits.webkit.org/257846@main Canonical link: https://commits.webkit.org/257698.6@safari-7615.1.15-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 66dbfe: Revert 257830@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 66dbfecd8efd52339e1dc9354b0ccb9f8d7aa466 https://github.com/WebKit/WebKit/commit/66dbfecd8efd52339e1dc9354b0ccb9f8d7aa466 Author: Alex Christensen Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt A Source/WTF/wtf/ThreadSafeWeakHashSet.h M Source/WTF/wtf/ThreadSafeWeakPtr.h M Source/WTF/wtf/WeakHashSet.h M Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h M Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp M Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.h M Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h M Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h M Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm M Source/WebKit/NetworkProcess/NetworkDataTask.cpp M Source/WebKit/NetworkProcess/NetworkDataTask.h M Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h M Source/WebKit/Platform/IPC/Connection.h M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm M Source/WebKit/UIProcess/Notifications/WebNotification.h M Source/WebKit/UIProcess/ProcessAssertion.h M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp Log Message: --- Revert 257830@main https://bugs.webkit.org/show_bug.cgi?id=249313 Unreviewed, originally reviewed by Chris Dumez. In, out, in! It was speculatively reverted last night, but it wasn't the cause of the problem. * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/CMakeLists.txt: * Source/WTF/wtf/ThreadSafeWeakHashSet.h: Added. * Source/WTF/wtf/ThreadSafeWeakPtr.h: * Source/WTF/wtf/WeakHashSet.h: * Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp: (WebCore::FileSystemDirectoryHandle::getFileHandle): (WebCore::FileSystemDirectoryHandle::getDirectoryHandle): (WebCore::FileSystemDirectoryHandle::getHandle): * Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h: * Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp: (WebCore::AudioWorkletGlobalScope::createProcessor): (WebCore::AudioWorkletGlobalScope::processorIsNoLongerNeeded): (WebCore::AudioWorkletGlobalScope::visitProcessors): * Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.h: * Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: * Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h: * Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm: (WebCore::MediaRecorderPrivateWriter::compressedVideoOutputBufferCallback): (WebCore::MediaRecorderPrivateWriter::compressedAudioOutputBufferCallback): (WebCore::MediaRecorderPrivateWriter::flushCompressedSampleBuffers): (WebCore::MediaRecorderPrivateWriter::stopRecording): (WebCore::MediaRecorderPrivateWriter::fetchData): * Source/WebKit/NetworkProcess/NetworkDataTask.cpp: (WebKit::NetworkDataTask::scheduleFailure): * Source/WebKit/NetworkProcess/NetworkDataTask.h: * Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::~NetworkDataTaskBlob): * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::invalidateAndCancel): (WebKit::NetworkSession::registerNetworkDataTask): (WebKit::NetworkSession::setEmulatedConditions): (WebKit::NetworkSession::unregisterNetworkDataTask): Deleted. * Source/WebKit/NetworkProcess/NetworkSession.h: * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h: * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::~WebSWServerToContextConnection): * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa): (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection)
[webkit-changes] [WebKit/WebKit] ede746: Cherry-pick a8076cd43460. rdar://problem/103277903
Branch: refs/heads/safari-7615.1.15-branch Home: https://github.com/WebKit/WebKit Commit: ede746697144a8262812484a30012a4d9cd344a5 https://github.com/WebKit/WebKit/commit/ede746697144a8262812484a30012a4d9cd344a5 Author: Kimmo Kinnunen Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/TestExpectations A LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash-expected.txt A LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash.html M Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml M Source/WebCore/html/canvas/WebGLContextAttributes.idl M Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Tools/WebKitTestRunner/TestOptions.cpp Log Message: --- Cherry-pick a8076cd43460. rdar://problem/103277903 RemoteGraphicsContextGL crashes if platform graphics context creation fails https://bugs.webkit.org/show_bug.cgi?id=249214 rdar://103277903 Reviewed by Matt Woodrow. Creating GraphicsContextGL would fail if ANGLE shared library is not present. This is as intended, on macOS this happens in recovery OS. GPUP RemoteGraphicsContextGL would access nullptr when the unusable context would be destroyed. Guard for the nullptr context. Move the IPC stream connection opening in the functions that execute on stream work queue and start receiving messages from the stream only when the context creation succeeds. This way the payload functions do not need the nullptr guard, which they do not have. * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: * Source/WebCore/html/canvas/WebGLContextAttributes.idl: * Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h: * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::initialize): * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp: (WebKit::RemoteGraphicsContextGL::initialize): (WebKit::RemoteGraphicsContextGL::stopListeningForIPC): (WebKit::RemoteGraphicsContextGL::workQueueInitialize): (WebKit::RemoteGraphicsContextGL::workQueueUninitialize): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): Canonical link: https://commits.webkit.org/257843@main Canonical link: https://commits.webkit.org/257698.4@safari-7615.1.15-branch Commit: 0300a46661c56c6087eff3660a27a98b00a5b085 https://github.com/WebKit/WebKit/commit/0300a46661c56c6087eff3660a27a98b00a5b085 Author: Miguel Salinas Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/UIProcess/ProcessThrottler.cpp Log Message: --- Cherry-pick 9bdfab144ce0. rdar://problem/103276264 [iOS] Fix crash in ProcessThrottler::sendPrepareToSuspendIPC https://bugs.webkit.org/show_bug.cgi?id=249220 rdar://103276264 Reviewed by Chris Dumez. After 257628@main we call `ProcessThrottler::updateThrottleStateIfNeeded` every time we call `ProcessThrottler::setShouldTakeSuspendedAssertion`. Instead, we should only take or drop the Suspended assertion when actually needed in `ProcessThrottler::setShouldTakeSuspendedAssertion`. * Source/WebKit/UIProcess/ProcessThrottler.cpp: (WebKit::ProcessThrottler::setShouldTakeSuspendedAssertion): Canonical link: https://commits.webkit.org/257850@main Canonical link: https://commits.webkit.org/257698.5@safari-7615.1.15-branch Compare: https://github.com/WebKit/WebKit/compare/7dd03fcb7285...0300a46661c5 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d62c57: REGRESSION (256459@main): data-type="number" is br...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d62c575193bd1c1239b45a34bea8ceb408391237 https://github.com/WebKit/WebKit/commit/d62c575193bd1c1239b45a34bea8ceb408391237 Author: David Kilzer Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/xml/XSLTUnicodeSort.cpp Log Message: --- REGRESSION (256459@main): data-type="number" is broken in libxslt https://bugs.webkit.org/show_bug.cgi?id=249321 Unreviewed revert of 256459@main. * Source/WebCore/xml/XSLTUnicodeSort.cpp: (WebCore::xsltUnicodeSortFunction): Canonical link: https://commits.webkit.org/257866@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a0182: [SIMD] B3/OMG Support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a018265fb90726b8b3e8e0fb88ec9238ee0255c https://github.com/WebKit/WebKit/commit/8a018265fb90726b8b3e8e0fb88ec9238ee0255c Author: Justin Michaud Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M JSTests/wasm/stress/simd-const-spill.js M JSTests/wasm/stress/simd-const.js M JSTests/wasm/stress/simd-kitchen-sink.js M JSTests/wasm/stress/simd-load.js M JSTests/wasm/stress/simd-register-allocation.js M JSTests/wasm/stress/simd-return-value-alignment.js M JSTests/wasm/v8/exceptions-simd.js M JSTests/wasm/v8/liftoff-simd-params.js M JSTests/wasm/v8/multi-value-simd.js M JSTests/wasm/v8/regress/regress-10309.js M JSTests/wasm/v8/regress/regress-1054466.js M JSTests/wasm/v8/regress/regress-1065599.js M JSTests/wasm/v8/regress/regress-1070078.js M JSTests/wasm/v8/regress/regress-1081030.js M JSTests/wasm/v8/regress/regress-10831.js M JSTests/wasm/v8/regress/regress-522.js M JSTests/wasm/v8/regress/regress-1112124.js M JSTests/wasm/v8/regress/regress-1116019.js M JSTests/wasm/v8/regress/regress-1124885.js M JSTests/wasm/v8/regress/regress-1132461.js M JSTests/wasm/v8/regress/regress-1161555.js M JSTests/wasm/v8/regress/regress-1161654.js M JSTests/wasm/v8/regress/regress-1161954.js M JSTests/wasm/v8/regress/regress-1165966.js M JSTests/wasm/v8/regress/regress-1179182.js M JSTests/wasm/v8/regress/regress-1187831.js M JSTests/wasm/v8/regress/regress-1188975.js M JSTests/wasm/v8/regress/regress-1199662.js M JSTests/wasm/v8/regress/regress-1231950.js M JSTests/wasm/v8/regress/regress-1242300.js M JSTests/wasm/v8/regress/regress-1242689.js M JSTests/wasm/v8/regress/regress-1264462.js M JSTests/wasm/v8/regress/regress-1271244.js M JSTests/wasm/v8/regress/regress-1271456.js M JSTests/wasm/v8/regress/regress-1271538.js M JSTests/wasm/v8/regress/regress-1282224.js M JSTests/wasm/v8/regress/regress-1283042.js M JSTests/wasm/v8/regress/regress-1283395.js M JSTests/wasm/v8/regress/regress-1284980.js M JSTests/wasm/v8/regress/regress-1286253.js M JSTests/wasm/v8/regress/regress-1289678.js M JSTests/wasm/v8/regress/regress-1290079.js M JSTests/wasm/v8/regress/regress-9447.js M JSTests/wasm/v8/regress/regress-crbug-1338980.js M JSTests/wasm/v8/regress/regress-crbug-1355070.js M JSTests/wasm/v8/regress/regress-crbug-1356718.js M JSTests/wasm/v8/simd-call.js M JSTests/wasm/v8/simd-errors.js M JSTests/wasm/v8/simd-globals.js M JSTests/wasm/v8/simd-i64x2-mul.js M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/Sources.txt M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/b3/B3ArgumentRegValue.h A Source/JavaScriptCore/b3/B3Const128Value.cpp A Source/JavaScriptCore/b3/B3Const128Value.h M Source/JavaScriptCore/b3/B3LowerToAir.cpp M Source/JavaScriptCore/b3/B3Opcode.cpp M Source/JavaScriptCore/b3/B3Opcode.h M Source/JavaScriptCore/b3/B3Procedure.cpp M Source/JavaScriptCore/b3/B3Procedure.h A Source/JavaScriptCore/b3/B3SIMDValue.cpp A Source/JavaScriptCore/b3/B3SIMDValue.h M Source/JavaScriptCore/b3/B3Validate.cpp M Source/JavaScriptCore/b3/B3Value.cpp M Source/JavaScriptCore/b3/B3Value.h M Source/JavaScriptCore/b3/B3ValueInlines.h M Source/JavaScriptCore/b3/air/AirArg.cpp M Source/JavaScriptCore/b3/air/AirCode.cpp M Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp M Source/JavaScriptCore/b3/air/AirOpcode.opcodes M Source/JavaScriptCore/ftl/FTLState.cpp M Source/JavaScriptCore/runtime/Options.cpp A Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmFunctionParser.h M Source/JavaScriptCore/wasm/WasmSIMDOpcodes.h M Tools/Scripts/run-jsc-stress-tests Log Message: --- [SIMD] B3/OMG Support https://bugs.webkit.org/show_bug.cgi?id=246347 Reviewed by Mark Lam. Support B3/ the OMG tier for SIMD functions. We add SimdValue and Const128Value as two new B3 value types, plus opcodes for every wasm simd op. We also add extra testing modes to simd spec tests to ensure that the OMG tier is being fully exercised. This should be a temporary measure until SIMD no longer requires tiering up from LLInt to BBQ. Finally, we work around a bug in register allocation for SIMD functions by disabling the use of ARM64 fp callee-saves. * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::notifyFunctionUsesSIMD): (JSC::Wasm::B3IRG
[webkit-changes] [WebKit/WebKit] e48228: [Lockdown Mode] Disable CacheStorage API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e48228395c2e9e0b09f86503efa1231cec055d09 https://github.com/WebKit/WebKit/commit/e48228395c2e9e0b09f86503efa1231cec055d09 Author: Brent Fulgham Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [Lockdown Mode] Disable CacheStorage API https://bugs.webkit.org/show_bug.cgi?id=249268 Reviewed by Chris Dumez. Disable the CacheStorage API in Lockdown Mode. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/257864@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d13b6: [JSC] Fix AVX functions more
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d13b6a54e05bcac8de9fade78527d04035ef802 https://github.com/WebKit/WebKit/commit/1d13b6a54e05bcac8de9fade78527d04035ef802 Author: Yusuke Suzuki Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h M Source/JavaScriptCore/assembler/X86Assembler.h M Source/JavaScriptCore/b3/air/AirOpcode.opcodes M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp Log Message: --- [JSC] Fix AVX functions more https://bugs.webkit.org/show_bug.cgi?id=249291 rdar://103340763 Reviewed by Michael Saboff. This patch fixes more AVX functions (vdivsd_mrr etc.) so that we can now pass all JSC tests with AVX enabled. We also fixes AirOpcode.opcodes's DivDouble definition, but since we do not lower from MoveDouble to MoveFloat, this fix does not affect on the result, but anyway, this is a bug fix. * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::divDouble): (JSC::MacroAssemblerX86Common::subDouble): * Source/JavaScriptCore/assembler/X86Assembler.h: (JSC::X86Assembler::vpinsrb_i8mrr): (JSC::X86Assembler::vpinsrb_i8rrr): (JSC::X86Assembler::vpinsrw_i8mrr): (JSC::X86Assembler::vpinsrd_i8mrr): (JSC::X86Assembler::vpinsrq_i8mrr): (JSC::X86Assembler::vdivsd_rrr): (JSC::X86Assembler::vdivsd_mrr): (JSC::X86Assembler::vdivss_mrr): * Source/JavaScriptCore/b3/air/AirOpcode.opcodes: * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): Canonical link: https://commits.webkit.org/257863@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e18e9c: [IFC] Enable vertical out-of-flow content for IFC
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e18e9c5be750f8a12fe049206870d4427984eeba https://github.com/WebKit/WebKit/commit/e18e9c5be750f8a12fe049206870d4427984eeba Author: Alan Baradlay Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/platform/ios/fast/block/positioning/auto/vertical-lr/005-expected.txt M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp Log Message: --- [IFC] Enable vertical out-of-flow content for IFC https://bugs.webkit.org/show_bug.cgi?id=249285 Reviewed by Antti Koivisto. Convert visual top/left to logical top/left for BoxGeometry (and for the associated renderer). * Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp: (WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowInlineLevelBox const): (WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowBlockLevelBox const): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForChild): Canonical link: https://commits.webkit.org/257862@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e5d99: [iOS] Scrolling after element focus does not avoid...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e5d99c2c3f855a3715de3ee90344b4b73337952 https://github.com/WebKit/WebKit/commit/3e5d99c2c3f855a3715de3ee90344b4b73337952 Author: Wenson Hsieh Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: A LayoutTests/fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard-expected.txt A LayoutTests/fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard.html M Source/WebKit/SourcesCocoa.txt A Source/WebKit/UIProcess/ios/RevealFocusedElementDeferrer.h A Source/WebKit/UIProcess/ios/RevealFocusedElementDeferrer.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- [iOS] Scrolling after element focus does not avoid input views when OOP keyboard is enabled https://bugs.webkit.org/show_bug.cgi?id=249159 rdar://88057475 Reviewed by Aditya Keerthi. Scrolling to reveal the focused element is currently broken when OOP keyboard is enabled. This is because OOP keyboard causes `UIKeyboardWillShowNotification` to be delivered to the app asynchronously (after communicating with the input UI process), rather than dispatched immediately under the call to `-reloadInputViews`. WebKit currently depends on the latter, since we expect the keyboard's final geometry (after animation) to be set by the time the post-layout editor state arrives in the UI process and we reveal the focused element using `-_zoomToRevealFocusedElement`. However, since this geometry is sent through the "KeyboardWillShow" notification which (normally) arrives after the editor state, we end up proceeding with `-_zoomToRevealFocusedElement` without knowing the final keyboard geometry, so we end up only scrolling to keep the field centered within the web view (ignoring the obscuring bounds of the software keyboard). In some cases (e.g. when focusing an input field in some system views), this can cause focused input fields to be completely obscured by the keyboard. This is somewhat tricky to fix, since it's not guaranteed that the "KeyboardWillShow" notification will always arrive after the editor state or vice versa. To complicate things further, in the Mail compose case (i.e. when the web view's scroller has `-firstResponderKeyboardAvoidanceEnabled` set to `NO`), we'll actually zoom to reveal the focused element only after `UIKeyboardDidShowNotification` instead, since the keyboard geometry isn't available before the animation has finished (see https://commits.webkit.org/246159@main for more context). And of course, this fix also needs to continue working with OOP keyboard disabled, where the "KeyboardWillShow" notification is dispatched before we've even begun waiting for the next editor state. To handle all of the above scenarios, we add a helper class that encapsulates logic for deferring calls to `-_zoomToRevealFocusedElement` after an element is focused. This helper class, `WebKit::RevealFocusedElementDeferrer`, maintains a set of flags that enumerate the three distinct reasons why we could be deferring this call: "waiting for an editor state", "waiting for a `KeyboardWillShow` notification", and "waiting for a `KeyboardDidShow` notification". As `WKContentView` receives keyboard notification from UIKit or receives an editor state update from the web process, it removes the appropriate deferral reasons from this helper object. Finally, when there are no longer any deferral reasons, we call into `-_zoomToRevealFocusedElement` and clear out the helper. Test: fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard.html * LayoutTests/fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard-expected.txt: Added. * LayoutTests/fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard.html: Added. Add a new layout test to exercise this scenario. All existing layout tests are actually insufficient to cover the changes in this fix, since a test needs to: - Show the software keyboard (by default, layout tests run with the hardware keyboard connected). - Check that we scrolled the focused input into (roughly) the center of the visible viewport, not just onto the screen. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/ios/RevealFocusedElementDeferrer.h: Added. * Source/WebKit/UIProcess/ios/RevealFocusedElementDeferrer.mm: Added. (WebKit::RevealFocusedElementDeferrer::RevealFocusedElementDeferrer): (WebKit::RevealFocusedElementDeferrer::create): (WebKit::RevealFocusedElementDeferrer::fulfill): Add the new helper class. We protect the deferrer here since it expects its client (`WKContentView`) to clear any references to itself when `-_zoomToRevealFocusedElement` is invoked. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction
[webkit-changes] [WebKit/WebKit] 492490: Mitigate crashes when removing KVO from NSWindow i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 492490a51a6c23ab76a9556c49c56ea445903b43 https://github.com/WebKit/WebKit/commit/492490a51a6c23ab76a9556c49c56ea445903b43 Author: Wenson Hsieh Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm Log Message: --- Mitigate crashes when removing KVO from NSWindow in -[WKWindowVisibilityObserver stopObserving:] https://bugs.webkit.org/show_bug.cgi?id=249103 rdar://102360839 Reviewed by Patrick Angle. After the fix in 256334@main, Music sometimes crashes when destroying `NSWindow`, when `WKWindowVisibilityObserver` attempts to remove key-value observers for "contentLayoutRect" and "titlebarAppearsTransparent" from the window that were not added in the first place. While I haven't been able to reproduce the crash locally or come up with a test case that (exactly) replicates the crashing stack during `NSWindow` destruction, it should be possible to avoid it altogether by guarding KVO registration and unregistration by using an associated object on the `NSWindow` to indicate when `WKWindowVisibilityObserver` has key-value observers to the window. If this flag is not set, then we avoid attempting to unregister KVO; similarly, if this flag is set, then we avoid attempting to re-register KVO. Test: WKWebView.PrepareForMoveToWindowShouldNotCrashWhenRemovingWindowObservers * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (-[WKWindowVisibilityObserver startObserving:]): (-[WKWindowVisibilityObserver stopObserving:]): Use the `_impl` pointer as the context key. (WebKit::WebViewImpl::viewWillMoveToWindowImpl): (WebKit::WebViewImpl::viewWillMoveToWindow): Move a debug assertion from `viewWillMoveToWindowImpl` into the call site in `viewWillMoveToWindow`, such that the assertion doesn't fire due to the SPI being misused by a client (which the new test case exercises). * Tools/TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm: Add a (somewhat contrived) API test that exercises the mitigation. Canonical link: https://commits.webkit.org/257860@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 66c0e8: Allow setting custom identifiers via the CSS Typed...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 66c0e84643e55fdac3b63d8bac7b958abe0d7120 https://github.com/WebKit/WebKit/commit/66c0e84643e55fdac3b63d8bac7b958abe0d7120 Author: Chris Dumez Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/container-name-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/page-expected.txt M Source/WebCore/css/typedom/CSSKeywordValue.cpp Log Message: --- Allow setting custom identifiers via the CSS Typed OM API https://bugs.webkit.org/show_bug.cgi?id=249270 Reviewed by Simon Fraser. Allow setting custom identifiers via the CSS Typed OM API: - https://drafts.css-houdini.org/css-typed-om/#reify-ident - https://w3c.github.io/csswg-drafts/css-values-4/#identifier-value Previously, we would fail to convert the CSSKeywordValue into a CSSValue if the identifier is a pre-defined keyword. We now construct a CSSPrimitiveValue in this case. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/container-name-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/page-expected.txt: * Source/WebCore/css/typedom/CSSKeywordValue.cpp: (WebCore::CSSKeywordValue::toCSSValue const): Canonical link: https://commits.webkit.org/257859@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd88fc: MediaStreamTrack audio rendering is broken in WKWe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd88fcd94620b0b23afe327455ce32401972257d https://github.com/WebKit/WebKit/commit/fd88fcd94620b0b23afe327455ce32401972257d Author: Youenn Fablet Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp Log Message: --- MediaStreamTrack audio rendering is broken in WKWebView https://bugs.webkit.org/show_bug.cgi?id=249306 rdar://102469310 Reviewed by Eric Carlson. WebProcess is no longer getting access to audio rendering services. We have the code to do audio rendering in GPUProcess for MediaStreamTrack but it was enabled only for capture happening in GPUProcess. Enable this code path also when capture is done in UIProcess. * Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp: (WebKit::UserMediaCaptureManager::setupCaptureProcesses): Canonical link: https://commits.webkit.org/257858@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f9b6e: Adjust indexing of synthesized small caps buffer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f9b6e69837377c259ee5fa16749d576efbb9cec https://github.com/WebKit/WebKit/commit/2f9b6e69837377c259ee5fa16749d576efbb9cec Author: Rob Buis Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/ComplexTextController.cpp Log Message: --- Adjust indexing of synthesized small caps buffer https://bugs.webkit.org/show_bug.cgi?id=249308 rdar://98714021 Reviewed by Myles C. Maxfield. Adjust indexing of synthesized small caps buffer by depending on currentIndex which is updated after the advanceByCombiningCharacterSequence call. * Source/WebCore/platform/graphics/ComplexTextController.cpp: (WebCore::ComplexTextController::collectComplexTextRuns): Canonical link: https://commits.webkit.org/257857@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 932595: Minor simplification in previousNodeConsideringAto...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 932595ba40313d978f16b69cfb4c8ff7409d8559 https://github.com/WebKit/WebKit/commit/932595ba40313d978f16b69cfb4c8ff7409d8559 Author: Ahmad Saleem Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/editing/Editing.cpp Log Message: --- Minor simplification in previousNodeConsideringAtomicNodes Minor simplification in previousNodeConsideringAtomicNodes https://bugs.webkit.org/show_bug.cgi?id=249247 Reviewed by Ryosuke Niwa. Merge - https://chromium.googlesource.com/chromium/blink/+/4284fb4b31e2ddbf7b4a2294e4bbda898f1780b5 This patch is to simplify the return value of function to return 'node->parentNode()'. * Source/WebCore/editing/Editing.cpp: (previousNodeConsideringAtomicNodes): Simplify return Canonical link: https://commits.webkit.org/257856@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 19aa97: REGRESSION: 4 PiP API tests consistently failing o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 19aa9768e3c6ffa0d06fc405d15ecf537f9a3444 https://github.com/WebKit/WebKit/commit/19aa9768e3c6ffa0d06fc405d15ecf537f9a3444 Author: Karl Rackler Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm Log Message: --- REGRESSION: 4 PiP API tests consistently failing on Big Sur EWS https://bugs.webkit.org/show_bug.cgi?id=247373 rdar://101873453 Unreviewed test gardening. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Canonical link: https://commits.webkit.org/257855@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 61e24c: An AudioSession should not get uninterrupted right...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 61e24c7fa0d02edd5b167ef096def9cdbfadd77a https://github.com/WebKit/WebKit/commit/61e24c7fa0d02edd5b167ef096def9cdbfadd77a Author: Youenn Fablet Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/TestExpectations A LayoutTests/media/audioSession/ios/audioSessionState-getUserMedia-expected.txt A LayoutTests/media/audioSession/ios/audioSessionState-getUserMedia.html M LayoutTests/platform/ios/TestExpectations M Source/WebCore/platform/audio/AudioSession.cpp M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp M Source/WebCore/platform/audio/PlatformMediaSessionManager.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm Log Message: --- An AudioSession should not get uninterrupted right away after being interrupted https://bugs.webkit.org/show_bug.cgi?id=249138 rdar://problem/103253664 Reviewed by Eric Carlson. Fix computation of whether active changed by calling isActive() so that it wokrs with RemoteAudioSession. Compute the new session state in case of change asynchronously so that, we do not reactivate the AudioSession due to one media element being interrupted and another not yet interrupted. Updated GPUProcess memory pressure exit test case to delay a bit the memory pressure signal after the document gets navigated. This is due to the AudioSession setup that might be done asynchronously. Covered by newly added test. * LayoutTests/TestExpectations: * LayoutTests/media/audioSession/ios/audioSessionState-getUserMedia-expected.txt: Added. * LayoutTests/media/audioSession/ios/audioSessionState-getUserMedia.html: Added. * LayoutTests/platform/ios/TestExpectations: * Source/WebCore/platform/audio/AudioSession.cpp: (WebCore::AudioSession::tryToSetActive): * Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp: * Source/WebCore/platform/audio/PlatformMediaSessionManager.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm: Canonical link: https://commits.webkit.org/257854@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9edeea: libpas build fix
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9edeea7f6e68a167132183276c7aba8f795173d7 https://github.com/WebKit/WebKit/commit/9edeea7f6e68a167132183276c7aba8f795173d7 Author: Brandon Stewart Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj M Source/bmalloc/libpas/src/chaos/Chaos.cpp M Source/bmalloc/libpas/src/test/ThingyAndUtilityHeapAllocationTests.cpp Log Message: --- libpas build fix https://bugs.webkit.org/show_bug.cgi?id=249290 Reviewed by Yusuke Suzuki. Add malloc stack logging files to Xcode project. Modify test cases include std:: when using move function. * Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj: * Source/bmalloc/libpas/src/chaos/Chaos.cpp: (std::threadMain): * Source/bmalloc/libpas/src/test/ThingyAndUtilityHeapAllocationTests.cpp: (std::testFreeListRefillSpans): Canonical link: https://commits.webkit.org/257853@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 30fcb6: [@property] Rename CSSPropertySyntax to CSSCustomP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30fcb6f7b33f0db82e5a2999fa33cab17bd7ce0b https://github.com/WebKit/WebKit/commit/30fcb6f7b33f0db82e5a2999fa33cab17bd7ce0b Author: Antti Koivisto Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/CSSRegisteredCustomProperty.cpp M Source/WebCore/css/CSSRegisteredCustomProperty.h M Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp M Source/WebCore/css/StyleProperties.cpp A Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp A Source/WebCore/css/parser/CSSCustomPropertySyntax.h M Source/WebCore/css/parser/CSSParser.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParser.h R Source/WebCore/css/parser/CSSPropertySyntax.cpp R Source/WebCore/css/parser/CSSPropertySyntax.h Log Message: --- [@property] Rename CSSPropertySyntax to CSSCustomPropertySyntax https://bugs.webkit.org/show_bug.cgi?id=249302 rdar://103351996 Reviewed by Antoine Quint. ...so it doesn't collide with the upcoming CSSPropertySyntax enum value in the CSSPropertyID enum (which should be an enum class). * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSRegisteredCustomProperty.cpp: (WebCore::CSSRegisteredCustomProperty::CSSRegisteredCustomProperty): * Source/WebCore/css/CSSRegisteredCustomProperty.h: * Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp: (WebCore::DOMCSSRegisterCustomProperty::registerProperty): * Source/WebCore/css/StyleProperties.cpp: (WebCore::MutableStyleProperties::setCustomProperty): * Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp: Renamed from Source/WebCore/css/parser/CSSPropertySyntax.cpp. (WebCore::CSSCustomPropertySyntax::parseComponent): (WebCore::CSSCustomPropertySyntax::parse): (WebCore::CSSCustomPropertySyntax::typeForTypeName): * Source/WebCore/css/parser/CSSCustomPropertySyntax.h: Renamed from Source/WebCore/css/parser/CSSPropertySyntax.h. (WebCore::CSSCustomPropertySyntax::isUniversal const): (WebCore::CSSCustomPropertySyntax::universal): * Source/WebCore/css/parser/CSSParser.cpp: (WebCore::CSSParser::parseValueWithVariableReferences): * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::canParseTypedCustomPropertyValue): (WebCore::CSSPropertyParser::parseTypedCustomPropertyValue): (WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies): (WebCore::CSSPropertyParser::consumeCustomPropertyValueWithSyntax): * Source/WebCore/css/parser/CSSPropertyParser.h: Canonical link: https://commits.webkit.org/257852@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4afe7: [IFC][Line clamp] Enable percent value line-clamp ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4afe709b9e3f8946c28fac2872532c0e98cf701 https://github.com/WebKit/WebKit/commit/e4afe709b9e3f8946c28fac2872532c0e98cf701 Author: Alan Baradlay Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/platform/ios/fast/overflow/line-clamp-expected.txt M LayoutTests/platform/mac/fast/overflow/line-clamp-expected.txt M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp Log Message: --- [IFC][Line clamp] Enable percent value line-clamp for IFC https://bugs.webkit.org/show_bug.cgi?id=249241 Reviewed by Antti Koivisto. In order to resolve the (non-standard) percent value for line-clamp, we need to layout the subtree first to be able to collect the number of lines. * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForStyle): * Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::RenderDeprecatedFlexibleBox::applyModernLineClamp): Canonical link: https://commits.webkit.org/257851@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9bdfab: [iOS] Fix crash in ProcessThrottler::sendPrepareTo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bdfab144ce088159138cc60fe84bd20f293576a https://github.com/WebKit/WebKit/commit/9bdfab144ce088159138cc60fe84bd20f293576a Author: Miguel Salinas Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/UIProcess/ProcessThrottler.cpp Log Message: --- [iOS] Fix crash in ProcessThrottler::sendPrepareToSuspendIPC https://bugs.webkit.org/show_bug.cgi?id=249220 rdar://103276264 Reviewed by Chris Dumez. After 257628@main we call `ProcessThrottler::updateThrottleStateIfNeeded` every time we call `ProcessThrottler::setShouldTakeSuspendedAssertion`. Instead, we should only take or drop the Suspended assertion when actually needed in `ProcessThrottler::setShouldTakeSuspendedAssertion`. * Source/WebKit/UIProcess/ProcessThrottler.cpp: (WebKit::ProcessThrottler::setShouldTakeSuspendedAssertion): Canonical link: https://commits.webkit.org/257850@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 303f8f: [web-animations] update import of web-animations/r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 303f8fa601702347326506bc42ff9e3514410e6d https://github.com/WebKit/WebKit/commit/303f8fa601702347326506bc42ff9e3514410e6d Author: Antoine Quint Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/columnGap-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/columnGap.html M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/lineHeight-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/lineHeight.html M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/minHeight-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/minHeight.html M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/perspective-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/perspective.html M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/rowGap-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/rowGap.html Log Message: --- [web-animations] update import of web-animations/responsive WPT tests https://bugs.webkit.org/show_bug.cgi?id=249292 Reviewed by Dean Jackson. Import changes made in https://github.com/web-platform-tests/wpt/pull/37457 which yield new PASS results in WebKit. * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/columnGap-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/columnGap.html: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/lineHeight-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/lineHeight.html: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/minHeight-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/minHeight.html: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/perspective-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/perspective.html: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/rowGap-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/rowGap.html: Canonical link: https://commits.webkit.org/257849@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 703c07: Revert [257736@main] Mitigate crashes when removin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 703c07cd1fa99a9ef42e4210e544183696ce69d3 https://github.com/WebKit/WebKit/commit/703c07cd1fa99a9ef42e4210e544183696ce69d3 Author: Karl Rackler Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm Log Message: --- Revert [257736@main] Mitigate crashes when removing KVO from NSWindow in -[WKWindowVisibilityObserver stopObserving:] https://bugs.webkit.org/show_bug.cgi?id=249103 rdar://102360839 Unreviewed revert This reverts because the new test addition landed as a consistent crash. * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (-[WKWindowVisibilityObserver startObserving:]): (-[WKWindowVisibilityObserver stopObserving:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm: Canonical link: https://commits.webkit.org/257848@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 83f96f: Further porting of high frequency IPC types to the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 83f96fe0a90a9d84cf00e00e38bc6b713666dbd6 https://github.com/WebKit/WebKit/commit/83f96fe0a90a9d84cf00e00e38bc6b713666dbd6 Author: Gavin Phillips Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/Modules/applepay/ApplePayErrorCode.h M Source/WebCore/Modules/applepay/ApplePayErrorContactField.h M Source/WebCore/Modules/webauthn/UserVerificationRequirement.h M Source/WebCore/platform/encryptedmedia/CDMKeySystemConfiguration.h M Source/WebCore/platform/graphics/FloatQuad.h M Source/WebCore/platform/mediacapabilities/MediaConfiguration.h M Source/WebCore/platform/mediacapabilities/MediaDecodingConfiguration.h M Source/WebCore/platform/mediacapabilities/MediaEncodingConfiguration.h M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateOptions.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h Log Message: --- Further porting of high frequency IPC types to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=249147 rdar://103253106 Reviewed by Alex Christensen. This change ports more types to the new serialization format. It includes: - MediaRecorderPrivateOptions - FloatQuad - ApplePayErrorContactField - ApplePayErrorCode - SelectionRenderingBehavior - UserVerificationRequirement - CDMKeySystemConfiguration - MediaConfiguration - MediaEncodingConfiguration - MediaDecodingConfiguration * Source/WebCore/Modules/applepay/ApplePayErrorCode.h: * Source/WebCore/Modules/applepay/ApplePayErrorContactField.h: * Source/WebCore/Modules/webauthn/UserVerificationRequirement.h: * Source/WebCore/platform/encryptedmedia/CDMKeySystemConfiguration.h: (WebCore::CDMKeySystemConfiguration::encode const): Deleted. (WebCore::CDMKeySystemConfiguration::decode): Deleted. * Source/WebCore/platform/graphics/FloatQuad.h: (WebCore::FloatQuad::encode const): Deleted. (WebCore::FloatQuad::decode): Deleted. * Source/WebCore/platform/mediacapabilities/MediaConfiguration.h: (WebCore::MediaConfiguration::encode const): Deleted. (WebCore::MediaConfiguration::decode): Deleted. * Source/WebCore/platform/mediacapabilities/MediaDecodingConfiguration.h: (WebCore::MediaDecodingConfiguration::encode const): Deleted. (WebCore::MediaDecodingConfiguration::decode): Deleted. * Source/WebCore/platform/mediacapabilities/MediaEncodingConfiguration.h: (WebCore::MediaEncodingConfiguration::encode const): Deleted. (WebCore::MediaEncodingConfiguration::decode): Deleted. * Source/WebCore/platform/mediarecorder/MediaRecorderPrivateOptions.h: (WebCore::MediaRecorderPrivateOptions::encode const): Deleted. (WebCore::MediaRecorderPrivateOptions::decode): Deleted. * Source/WebKit/Scripts/webkit/messages.py: (serialized_identifiers): * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h: Canonical link: https://commits.webkit.org/257847@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f3c84: [Lockdown mode][iOS] Add telemetry for syscall mac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f3c84c00ec6e7e03645b5c46091b76f112bc7a6 https://github.com/WebKit/WebKit/commit/6f3c84c00ec6e7e03645b5c46091b76f112bc7a6 Author: Per Arne Vollan Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Log Message: --- [Lockdown mode][iOS] Add telemetry for syscall mach and kernel MIG https://bugs.webkit.org/show_bug.cgi?id=249224 rdar://103301850 Reviewed by Brent Fulgham. Add telemetry for syscall mach and kernel MIG in Lockdown mode on iOS. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Canonical link: https://commits.webkit.org/257846@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a303d9: AX: Undo unnecessary TextMarker workaround for emp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a303d99146d4b00d5bcba419a65cbfd742516d0e https://github.com/WebKit/WebKit/commit/a303d99146d4b00d5bcba419a65cbfd742516d0e Author: Andres Gonzalez Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: A LayoutTests/accessibility/mac/text-marker-range-for-empty-contenteditable-expected.txt A LayoutTests/accessibility/mac/text-marker-range-for-empty-contenteditable.html R LayoutTests/accessibility/mac/text-marker-range-for-node-without-children-expected.txt R LayoutTests/accessibility/mac/text-marker-range-for-node-without-children.html M Source/WebCore/accessibility/AXObjectCache.cpp Log Message: --- AX: Undo unnecessary TextMarker workaround for empty text fields. https://bugs.webkit.org/show_bug.cgi?id=249162 Reviewed by Chris Fleizach. The workaround was introduced for https://bugs.webkit.org/show_bug.cgi?id=155613, but it is no longer necessary for VoiceOver and creates problems for the refactoring of AXTextMarker and AXTextMarkerRange. The range for an empty text field should be a valid, 0-length range, which is what we return now with this change. Renamed the test to reflect what the test is actually doing. * LayoutTests/accessibility/mac/text-marker-range-for-empty-contenteditable-expected.txt: Renamed from LayoutTests/accessibility/mac/text-marker-range-for-node-without-children-expected.txt. * LayoutTests/accessibility/mac/text-marker-range-for-empty-contenteditable.html: Renamed from LayoutTests/accessibility/mac/text-marker-range-for-node-without-children.html. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::boundaryPoint): (WebCore::setRangeStartOrEndWithCharacterOffset): (WebCore::AXObjectCache::rangeForUnorderedCharacterOffsets): Canonical link: https://commits.webkit.org/257845@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f26628: [@property] Support list values
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f266283a31249f27645c470313b8ee346c4f0daa https://github.com/WebKit/WebKit/commit/f266283a31249f27645c470313b8ee346c4f0daa Author: Antti Koivisto Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-computation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-initial-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt M Source/WebCore/css/CSSCustomPropertyValue.cpp M Source/WebCore/css/CSSCustomPropertyValue.h M Source/WebCore/css/CSSValue.cpp M Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParser.h Log Message: --- [@property] Support list values https://bugs.webkit.org/show_bug.cgi?id=249216 Reviewed by Chris Dumez. Consume values with + and # syntax definitions. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-computation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-initial-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt: * Source/WebCore/css/CSSCustomPropertyValue.cpp: (WebCore::CSSCustomPropertyValue::equals const): (WebCore::CSSCustomPropertyValue::customCSSText const): * Source/WebCore/css/CSSCustomPropertyValue.h: Add list value support. Handle ident values with SyntaxValue too. Use URL type for URLs. * Source/WebCore/css/CSSValue.cpp: (WebCore::CSSValue::collectDirectComputationalDependencies const): (WebCore::CSSValue::collectDirectRootComputationalDependencies const): Collect from lists too. * Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp: (WebCore::DOMCSSRegisterCustomProperty::registerProperty): Test for null initial value string instead of empty (empty string needs to be considered as an initial value). Remove unnecessary collectDirect*ComputationalDependencies calls. * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeCustomPropertyValueWithSyntax): Consume lists. (WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies): (WebCore::CSSPropertyParser::parseTypedCustomPropertyValue): Resolve syntax values in lists. Canonical link: https://commits.webkit.org/257844@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a8076c: RemoteGraphicsContextGL crashes if platform graphi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8076cd4346043611ad3d4a09d264f5a6af9f0e5 https://github.com/WebKit/WebKit/commit/a8076cd4346043611ad3d4a09d264f5a6af9f0e5 Author: Kimmo Kinnunen Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/TestExpectations A LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash-expected.txt A LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash.html M Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml M Source/WebCore/html/canvas/WebGLContextAttributes.idl M Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Tools/WebKitTestRunner/TestOptions.cpp Log Message: --- RemoteGraphicsContextGL crashes if platform graphics context creation fails https://bugs.webkit.org/show_bug.cgi?id=249214 rdar://103277903 Reviewed by Matt Woodrow. Creating GraphicsContextGL would fail if ANGLE shared library is not present. This is as intended, on macOS this happens in recovery OS. GPUP RemoteGraphicsContextGL would access nullptr when the unusable context would be destroyed. Guard for the nullptr context. Move the IPC stream connection opening in the functions that execute on stream work queue and start receiving messages from the stream only when the context creation succeeds. This way the payload functions do not need the nullptr guard, which they do not have. * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: * Source/WebCore/html/canvas/WebGLContextAttributes.idl: * Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h: * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::initialize): * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp: (WebKit::RemoteGraphicsContextGL::initialize): (WebKit::RemoteGraphicsContextGL::stopListeningForIPC): (WebKit::RemoteGraphicsContextGL::workQueueInitialize): (WebKit::RemoteGraphicsContextGL::workQueueUninitialize): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): Canonical link: https://commits.webkit.org/257843@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8f7373: WebGL tests are slow in debug due to sync IPC repl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f7373eda214f9130d7c1144266ec95d35658851 https://github.com/WebKit/WebKit/commit/8f7373eda214f9130d7c1144266ec95d35658851 Author: Kimmo Kinnunen Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/Platform/IPC/HandleMessage.h Log Message: --- WebGL tests are slow in debug due to sync IPC reply logging even when disabled https://bugs.webkit.org/show_bug.cgi?id=249219 rdar://problem/103298421 Reviewed by Cameron McCormack. When replying to a IPC sync message, do not construct log TextStream if the logging channel is disabled. Speeds up Debug build webgl/2.0.y/conformance2/state/gl-object-get-calls.html with WebGL GPUP. This test does a lot of sync messages. * Source/WebKit/Platform/IPC/HandleMessage.h: (IPC::logReply): Canonical link: https://commits.webkit.org/257842@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/webkitgtk-2.39.3 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 544e41: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 544e416affdfe60caf986985eee1481a0880d0a3 https://github.com/WebKit/WebKit/commit/544e416affdfe60caf986985eee1481a0880d0a3 Author: Carlos Garcia Campos Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/gtk/NEWS M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. Update OptionsGTK.cmake and NEWS for 2.39.3 release * Source/WebKit/gtk/NEWS: Add release notes for 2.39.3. * Source/cmake/OptionsGTK.cmake: Bump version numbers. Canonical link: https://commits.webkit.org/257841@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7dd61a: NavigationActionData.canHandleRequest should be pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7dd61a61123d34df92aeb7f2cdd273c968318394 https://github.com/WebKit/WebKit/commit/7dd61a61123d34df92aeb7f2cdd273c968318394 Author: Youenn Fablet Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- NavigationActionData.canHandleRequest should be preserved over process swap https://bugs.webkit.org/show_bug.cgi?id=249212 rdar://103073405 Reviewed by Alex Christensen. Make sure to keep the new canHandleRequest since it is tied to the new URL. We should probably compute this value in UIProcess in the future. Covered by API test. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/257840@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 11f8b4: Fix css/css-typed-om/stylevalue-serialization/cssT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 11f8b47f5d1c3327970107382c903b0a8658793d https://github.com/WebKit/WebKit/commit/11f8b47f5d1c3327970107382c903b0a8658793d Author: Chris Dumez Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html Log Message: --- Fix css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html WPT test https://bugs.webkit.org/show_bug.cgi?id=249246 Reviewed by Antoine Quint. Fix css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html WPT test. In particular, the test tries to serialize: `new CSSMathProduct(CSS.deg(1), new CSSMathInvert(new CSSUnitValue(0, 'number')))` And expects the string: `calc(1deg * (1 / 0))` However, per the specification [1], it should be: `calc(1deg / 0)` [1] https://drafts.css-houdini.org/css-typed-om-1/#serialize-a-cssmathvalue (step 5) The previously expected result in the test seemed to come from step 6 in the test but it doesn't apply here since we're serializing a CSSMathInvert as a child of a CSSMathProduct. Step 5 is for the serialization of a CSSMathProduct and has special handling when a child is a CSSMathInvert. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html: Canonical link: https://commits.webkit.org/257839@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc208a: [GStreamer][MSE] Fix a caps leak in AppendPipeline
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc208a0a320c2cd21eb180ad0df9aa6d290269ce https://github.com/WebKit/WebKit/commit/dc208a0a320c2cd21eb180ad0df9aa6d290269ce Author: Philippe Normand Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp Log Message: --- [GStreamer][MSE] Fix a caps leak in AppendPipeline https://bugs.webkit.org/show_bug.cgi?id=249155 Reviewed by Alicia Boya Garcia. The return value of `gst_pad_get_current_caps()` is `transfer full` so we need to adopt it. * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::AppendPipeline::AppendPipeline): Canonical link: https://commits.webkit.org/257838@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ddd09b: Revert 257785@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ddd09b6729405b56db4718f98f3fb36e940195a8 https://github.com/WebKit/WebKit/commit/ddd09b6729405b56db4718f98f3fb36e940195a8 Author: Alex Christensen Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: R LayoutTests/fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard-expected.txt R LayoutTests/fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard.html M Source/WebKit/SourcesCocoa.txt R Source/WebKit/UIProcess/ios/RevealFocusedElementDeferrer.h R Source/WebKit/UIProcess/ios/RevealFocusedElementDeferrer.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Revert 257785@main https://bugs.webkit.org/show_bug.cgi?id=249294 Unreviewed. It caused assertions in all iOS debug tests. * LayoutTests/fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard-expected.txt: Removed. * LayoutTests/fast/forms/ios/scroll-after-tapping-on-input-with-software-keyboard.html: Removed. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/ios/RevealFocusedElementDeferrer.h: Removed. * Source/WebKit/UIProcess/ios/RevealFocusedElementDeferrer.mm: Removed. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView cleanUpInteraction]): (-[WKContentView _keyboardWillShow]): (-[WKContentView _keyboardDidShow]): (-[WKContentView _zoomToFocusRectAfterShowingKeyboardIfNeeded]): (-[WKContentView _zoomToRevealFocusedElement]): (-[WKContentView resetShouldZoomToFocusRectAfterShowingKeyboard]): (-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]): (-[WKContentView _elementDidBlur]): (-[WKContentView _didUpdateEditorState]): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/257837@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
