[webkit-changes] [WebKit/WebKit] 9ced63: [WebGPU] Implement GPUQuerySet
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ced63bbda6ac9231451b1ca549a16f397e28c78 https://github.com/WebKit/WebKit/commit/9ced63bbda6ac9231451b1ca549a16f397e28c78 Author: Mike Wyrzykowski Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/Modules/WebGPU/GPUBuffer.h M Source/WebGPU/WebGPU/Buffer.mm M Source/WebGPU/WebGPU/CommandEncoder.h M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/QuerySet.h M Source/WebGPU/WebGPU/QuerySet.mm M Source/WebGPU/WebGPU/RenderPassEncoder.h M Source/WebGPU/WebGPU/RenderPassEncoder.mm M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.messages.in M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp A Websites/webkit.org/demos/webgpu/query-sets.html A Websites/webkit.org/demos/webgpu/scripts/query-sets.js Log Message: --- [WebGPU] Implement GPUQuerySet https://bugs.webkit.org/show_bug.cgi?id=249356 Reviewed by Dean Jackson. Implement visibility and timestamp queries. * Source/WebCore/Modules/WebGPU/GPUBuffer.h: (WebCore::GPUBuffer::~GPUBuffer): Call the backing's destroy function so buffer instances don't accumulate. * Source/WebGPU/WebGPU/Buffer.mm: (WebGPU::Buffer::unmap): Reset the mapped state on unmap. * Source/WebGPU/WebGPU/CommandEncoder.h: * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::validateRenderPassDescriptor const): (WebGPU::CommandEncoder::beginRenderPass): (WebGPU::CommandEncoder::resolveQuerySet): Resolve visibility and occlusion queries as needed. (WebGPU::CommandEncoder::writeTimestamp): writeTimestamp is not practical to implement on TBDR, the best we can get is granularity of the render pass. * Source/WebGPU/WebGPU/QuerySet.h: (WebGPU::QuerySet::create): (WebGPU::QuerySet::isValid const): (WebGPU::QuerySet::queryCount const): (WebGPU::QuerySet::visibilityBuffer const): (WebGPU::QuerySet::counterSampleBuffer const): * Source/WebGPU/WebGPU/QuerySet.mm: (WebGPU::getCounterSet): (WebGPU::Device::createQuerySet): (WebGPU::QuerySet::QuerySet): (WebGPU::QuerySet::destroy): (WebGPU::QuerySet::setLabel): (WebGPU::QuerySet::resolveTimestamps const): Implement timestamp and visibility queries. * Source/WebGPU/WebGPU/RenderPassEncoder.h: (WebGPU::RenderPassEncoder::create): Use timestamps queries if they are present in the descriptor. * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::RenderPassEncoder): (WebGPU::RenderPassEncoder::beginOcclusionQuery): (WebGPU::RenderPassEncoder::endOcclusionQuery): Metal calls for visibility queries. * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.messages.in: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp: (WebKit::RemoteCommandEncoder::copyBufferToBuffer): Fix typo where source was being used as the source and destination. * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.messages.in: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp: (WebKit::WebGPU::RemoteBufferProxy::getMappedRange): Return early if the buffer was already mapped by mapAsync. * Websites/webkit.org/demos/webgpu/query-sets.html: Added. * Websites/webkit.org/demos/webgpu/scripts/query-sets.js: Added. (async helloTriangle.async frameUpdate): (async helloTriangle): Add a demo test for this work. Canonical link: https://commits.webkit.org/258236@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 03403b: Manage CacheStorage by origin
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 03403b4f8c4e7aa6e10be71dca42f10c0f28bbdd https://github.com/WebKit/WebKit/commit/03403b4f8c4e7aa6e10be71dca42f10c0f28bbdd Author: Sihui Liu Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/http/tests/cache-storage/cache-clearing-origin.https.html M LayoutTests/http/tests/cache-storage/cache-origins.https.html M LayoutTests/http/tests/cache-storage/cache-representation.https.html M Source/WTF/wtf/FileSystem.cpp M Source/WTF/wtf/FileSystem.h M Source/WebCore/platform/network/ResourceResponseBase.cpp M Source/WebCore/platform/network/ResourceResponseBase.h M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h A Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp A Source/WebKit/NetworkProcess/storage/CacheStorageCache.h A Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp A Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.h A Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp A Source/WebKit/NetworkProcess/storage/CacheStorageManager.h A Source/WebKit/NetworkProcess/storage/CacheStorageMemoryStore.cpp A Source/WebKit/NetworkProcess/storage/CacheStorageMemoryStore.h A Source/WebKit/NetworkProcess/storage/CacheStorageRecord.h A Source/WebKit/NetworkProcess/storage/CacheStorageRegistry.cpp A Source/WebKit/NetworkProcess/storage/CacheStorageRegistry.h A Source/WebKit/NetworkProcess/storage/CacheStorageStore.h M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in M Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp M Source/WebKit/NetworkProcess/storage/OriginStorageManager.h A Source/WebKit/NetworkProcess/storage/StorageUtilities.h M Source/WebKit/Sources.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp Log Message: --- Manage CacheStorage by origin https://bugs.webkit.org/show_bug.cgi?id=247207 rdar://problem/101968609 Reviewed by Youenn Fablet. The OriginStorageManager class is designed to manage storage of a paritioned origin, and have exclusive access to origin storage directory. This patch refactors DOMCache backend to use OriginStorageManager for CacheStorage management. The old structure is: NetworkSession - CacheStorage::Engine - CacheStorage::Caches - CacheStorage::Cache The new structure is: NetworkSession - NetworkStorageManager - OriginStorageManager - CacheStorageManager - CacheStorageCache Here are the new classes: CacheStorageManager: it manages cache storage of a partitioned origin and store caches. CacheStorageCache: it represents a cache and keeps track of records (by record information) in memory. CacheStorageStore: it represents backing store of cache; it is implemented by CacheStorageMemoryStore and CacheStorageDiskStore. CacheStorageRegistry: it keeps track of all CacheStorageCaches in a session, so NetworkStorageManager can find the target of a CacheStorage IPC message quickly. Here are some other changes made to complete the transition: 1. CacheStorage messages are sent to NetworkStorageManager instead of CacheStorage::Engine. 2. NetworkStorageManager handles CachesStorage messages and performs corresponding operations on its own WorkQueue. Since WorkQueue is not tied to one thread, this patch use ResourceResponse::CrossThreadData instead of ResourceResponse in CacheStorageRecord. 3. CacheStoragePersistentStore provides a simple file system backend for CacheStorage, instead of using NetworkCache::Storage. 4. Representation string of CacheStorage will report origins that have CacheStorage data. It used to report origins of existing CacheStorage::Caches (which manages cache storage of partitioned origin like CacheStorageManager), but having CacheStorage::Caches does not mean the origin has CacheStorage data or the origin is actively performing CacheStorage operations, and the state is subjective to change based on implementation (e.g. we might add/delete CacheStorage::Caches proactively based on its activity). Therefore, let's use CacheStorage data as the truth, and update test expectations. 5. CacheStorage backend used to have multiple WorkQueues per partition origin, now it has one WorkQueue for all origins (shared with other types) for message handling, and at most one queue per cache for I/O operation on cache records. * LayoutTests/http/tests/cache-storage/cache-clearing-origin.https.html: * LayoutTests/http/tests/cache-storage/cache-origins.https.html: * LayoutTests/http/tests/cache-storage/cache-representation.https.html: * Source/WTF/wtf/FileSystem.cpp: (WTF::FileSystemImpl::overwriteEntireFile): * Source/WTF/wtf/F
[webkit-changes] [WebKit/WebKit] 33055b: [WebGPU] Support vertex shader input buffers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33055b844de35a1cefaa284d17333063b237290d https://github.com/WebKit/WebKit/commit/33055b844de35a1cefaa284d17333063b237290d Author: Mike Wyrzykowski Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebGPU/WebGPU/RenderPassEncoder.h M Source/WebGPU/WebGPU/RenderPassEncoder.mm M Source/WebGPU/WebGPU/RenderPipeline.h M Source/WebGPU/WebGPU/RenderPipeline.mm A Websites/webkit.org/demos/webgpu/scripts/textured-cube-vs-input-buffers.js A Websites/webkit.org/demos/webgpu/textured-cube-vs-input-buffers.html Log Message: --- [WebGPU] Support vertex shader input buffers https://bugs.webkit.org/show_bug.cgi?id=249636 Reviewed by Dean Jackson. Configure the pipeline state to support vertex input buffers. This was tested against external WebGPU samples but I will add a local test case while the review is on-going. * Source/WebGPU/WebGPU/RenderPassEncoder.h: * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::setBindGroup): Offset the bind group vertex buffer by the number of vertex shader input buffers. (WebGPU::RenderPassEncoder::setPipeline): Cache the number of vertex shader input buffers. * Source/WebGPU/WebGPU/RenderPipeline.h: (WebGPU::RenderPipeline::create): (WebGPU::RenderPipeline::vertexShaderInputBufferCount const): Return the number of vertex shader input buffers. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::validateRenderPipeline): (WebGPU::vertexFormat): (WebGPU::stepFunction): (WebGPU::createVertexDescriptor): (WebGPU::Device::createRenderPipeline): (WebGPU::RenderPipeline::RenderPipeline): Configure the vertex shader input buffer state. * Websites/webkit.org/demos/webgpu/scripts/textured-cube-vs-input-buffers.js: Added. (async helloCube.frameUpdate): (async helloCube): * Websites/webkit.org/demos/webgpu/textured-cube-vs-input-buffers.html: Added. Add sample test show use of vertex shader input buffers. Canonical link: https://commits.webkit.org/258234@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5f73a3: [JSC] Stop nulling out the CodeBlock spot inside t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5f73a3c6800beb956b3c47a699f0f509f7f0 https://github.com/WebKit/WebKit/commit/5f73a3c6800beb956b3c47a699f0f509f7f0 Author: Yusuke Suzuki Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/bytecode/Repatch.h M Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp M Source/JavaScriptCore/dfg/DFGDoesGCCheck.cpp M Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp M Source/JavaScriptCore/interpreter/CallFrame.cpp M Source/JavaScriptCore/interpreter/CallFrame.h M Source/JavaScriptCore/interpreter/CallFrameInlines.h M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/interpreter/ShadowChicken.cpp M Source/JavaScriptCore/interpreter/StackVisitor.cpp M Source/JavaScriptCore/jit/JITExceptions.cpp M Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp M Source/JavaScriptCore/runtime/VM.cpp M Source/JavaScriptCore/runtime/VMTraps.cpp M Source/JavaScriptCore/tools/VMInspector.cpp M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/js/JSToWasm.cpp Log Message: --- [JSC] Stop nulling out the CodeBlock spot inside the call frame inside WebAssembly https://bugs.webkit.org/show_bug.cgi?id=165321 rdar://103618930 Reviewed by Mark Lam. We are putting nullptr unnecessarily to CodeBlock slot while Callee information is enough to say this CallFrame is wasm frame or not. This patch removes it, and fixing places getting CodeBlock from CallFrame with the assumption that it can be nullptr when it is wasm frame. This allows to drop unnecessary zero fill for *all* wasm functions, which is bad. * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::noticeIncomingCall): * Source/JavaScriptCore/bytecode/Repatch.cpp: (JSC::linkMonomorphicCall): (JSC::linkDirectCall): (JSC::linkVirtualFor): (JSC::linkPolymorphicCall): * Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::scope): (JSC::DebuggerCallFrame::thisValue const): (JSC::DebuggerCallFrame::evaluateWithScopeExtension): (JSC::DebuggerCallFrame::sourceIDForCallFrame): * Source/JavaScriptCore/dfg/DFGDoesGCCheck.cpp: (JSC::DFG::DoesGCCheck::verifyCanGC): * Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp: (Inspector::functionName): * Source/JavaScriptCore/interpreter/CallFrameInlines.h: (JSC::CallFrame::codeBlock const): * Source/JavaScriptCore/interpreter/Interpreter.cpp: (JSC::Interpreter::unwind): * Source/JavaScriptCore/interpreter/ShadowChicken.cpp: (JSC::ShadowChicken::update): * Source/JavaScriptCore/interpreter/StackVisitor.cpp: (JSC::StackVisitor::readNonInlinedFrame): * Source/JavaScriptCore/jit/JITExceptions.cpp: (JSC::genericUnwind): * Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp: (JSC::PolymorphicCallStubRoutine::PolymorphicCallStubRoutine): * Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: (JSC::getCallerCodeBlock): * Source/JavaScriptCore/runtime/VM.cpp: (JSC::VM::throwException): * Source/JavaScriptCore/runtime/VMTraps.cpp: (JSC::VMTraps::invalidateCodeBlocksOnStack): * Source/JavaScriptCore/tools/VMInspector.cpp: (JSC::VMInspector::dumpRegisters): * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::AirIRGeneratorBase): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::B3IRGenerator): * Source/JavaScriptCore/wasm/js/JSToWasm.cpp: (JSC::Wasm::createJSToWasmWrapper): * Source/JavaScriptCore/wasm/js/WasmToJS.cpp: (JSC::Wasm::wasmToJS): Canonical link: https://commits.webkit.org/258233@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b0ed3: Notify networking stack that download is media rel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b0ed39e4c4b90ad8d625560562dec5709c72cbd https://github.com/WebKit/WebKit/commit/3b0ed39e4c4b90ad8d625560562dec5709c72cbd Author: Jean-Yves Avenard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/Modules/mediasource/MediaSource.cpp M Source/WebCore/Modules/mediasource/MediaSource.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/page/MediaProducer.h M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKit/file-with-mse.html A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm Log Message: --- Notify networking stack that download is media related https://bugs.webkit.org/show_bug.cgi?id=249569 rdar://103046339 Reviewed by Youenn Fablet. Send a system notification when a networking operation is likely going to be related to media playback. For now the heuristic is rather primitive: if we have an active source buffer linked to a media element we assume that all further networking operation in the page is media related. The notification is produced by the UI process whenever a content process has an active source buffers, and when all have been deleted. * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::removeSourceBuffer): (WebCore::MediaSource::regenerateActiveSourceBuffers): (WebCore::MediaSource::notifyElementUpdateMediaState const): * Source/WebCore/Modules/mediasource/MediaSource.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateMediaState): (WebCore::HTMLMediaElement::mediaState const): * Source/WebCore/html/HTMLMediaElement.h: * Source/WebCore/page/MediaProducer.h: * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::notifyMediaNetworkingActivity): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updatePlayingMediaDidChange): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::m_webProcessWithMediaNetworkingCounter): (WebKit::WebProcessPool::webProcessWithMediaNetworkingToken const): (WebKit::WebProcessPool::updateMediaNetworkingActivity): * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::shutDown): (WebKit::WebProcessProxy::removeWebPage): (WebKit::WebProcessProxy::updateMediaNetworkingActivity): * Source/WebKit/UIProcess/WebProcessProxy.h: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaNetworkingActivity.mm: Added. (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKit/file-with-mse.html: Canonical link: https://commits.webkit.org/258232@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/eng/bug-197963 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d26eba: Element::attachDeclarativeShadow should set IsAvai...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d26eba5eb7ab2fc3f968705e31b7d965d25bafd8 https://github.com/WebKit/WebKit/commit/d26eba5eb7ab2fc3f968705e31b7d965d25bafd8 Author: Ryosuke Niwa Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/fast/shadow-dom/element-internals-exposes-declarative-shadow-root-expected.txt M LayoutTests/fast/shadow-dom/element-internals-exposes-declarative-shadow-root.html M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/ElementInternals.cpp M Source/WebCore/dom/ShadowRoot.h Log Message: --- Element::attachDeclarativeShadow should set IsAvailableToElementInternals https://bugs.webkit.org/show_bug.cgi?id=249668 Reviewed by Chris Dumez. Make Element::attachDeclarativeShadow set ShadowRoot::m_isAttachDeclarativeShadow flag instead of checking isDeclarativeShadowRoot in ElementInternals::shadowRoot. Also update the assertions in the test to match the latest spec PR. * LayoutTests/fast/shadow-dom/element-internals-exposes-declarative-shadow-root-expected.txt: * LayoutTests/fast/shadow-dom/element-internals-exposes-declarative-shadow-root.html: * Source/WebCore/dom/Element.cpp: (WebCore::Element::attachDeclarativeShadow) * Source/WebCore/dom/ElementInternals.cpp: (WebCore::ElementInternals::shadowRoot const): * Source/WebCore/dom/ShadowRoot.h: Canonical link: https://commits.webkit.org/258231@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3edf24: Give up on stretching columns if they have already...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3edf242b588be169967f082cdef66d7e21878448 https://github.com/WebKit/WebKit/commit/3edf242b588be169967f082cdef66d7e21878448 Author: Ahmad Saleem Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: A LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash-expected.txt A LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash.html M Source/WebCore/rendering/RenderMultiColumnSet.cpp Log Message: --- Give up on stretching columns if they have already reached max height Give up on stretching columns if they have already reached max height https://bugs.webkit.org/show_bug.cgi?id=249705 Reviewed by Alan Baradlay. Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=192636 This doesn't change any behavior (column heights were already clamped against max height), but it avoids an assertion failure that would occur if no space shortage is recorded during a render pass. Unbreakable content (lines) that's taller than the column (max) height don't record space shortage, as columns cannot be stretched beyond the (max) height anyway. * Source/WebCore/rendering/RenderMultiColumnSet.cpp: (RenderMultiColumnSet::calculateBalancedHeight): Add if condition to restrict column height * LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash.html: Add Test Case * LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/258230@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d41b2a: Update 'assert-selection.js' from Chromium to late...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d41b2a8b640c7af24bcb7fe0be005a19264479d1 https://github.com/WebKit/WebKit/commit/d41b2a8b640c7af24bcb7fe0be005a19264479d1 Author: Ahmad Saleem Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/editing/inserting/insert-space-expected.txt M LayoutTests/resources/assert-selection.js Log Message: --- Update 'assert-selection.js' from Chromium to latest version since now RegExp lookbehind assertions is supported Update 'assert-selection.js' from Chromium to latest version since now RegExp lookbehind assertions is supported https://bugs.webkit.org/show_bug.cgi?id=249309 Reviewed by Ryosuke Niwa. This patch is to update testing script used for HTML editing test cases, which are merged from Blink / Chromium. Previously, Webkit was using old version, which didn't had requirement of "RegEx Lookbehind" but now since it is supported, we can updated to latest and also update any test expectations as well. * LayoutTests/resources/assert-selection.js: Update * LayoutTests/editing/inserting/insert-space-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/258229@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a8188f: Consider focusability even when tabs-to-links is e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8188f2bba91c479e8fadfdc9bbdbeb3d1a0e3e1 https://github.com/WebKit/WebKit/commit/a8188f2bba91c479e8fadfdc9bbdbeb3d1a0e3e1 Author: Ahmad Saleem Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/platform/ios/TestExpectations A LayoutTests/svg/custom/display-none-a-does-not-stop-focus-navigation-expected.txt A LayoutTests/svg/custom/display-none-a-does-not-stop-focus-navigation.html M Source/WebCore/svg/SVGAElement.cpp Log Message: --- Consider focusability even when tabs-to-links is enabled for Consider focusability even when tabs-to-links is enabled for https://bugs.webkit.org/show_bug.cgi?id=249546 Reviewed by Aditya Keerthi. Merge - https://chromium.googlesource.com/chromium/src.git/+/ad66827206bf24e41a4afa7dd7c3083157506c6c SVGAElement::isKeyboardFocusable could end up returning 'true' even when the element wasn't focusable (because it had "display: none" and hence no renderer) because the value of the 'tabsToLinks' setting would be returned without further checks. Because it wasn't focusable setFocusedElement would not do anything, and focus would remain where it was previously. Make sure the focusable check is considered in this case. This makes the SVGAElement version of this code look the same as the HTMLAnchorElement version. * Source/WebCore/svg/SVGAElement.cpp: (SVGAElement::isKeyboardEvent): Update logic to ensure focus check is done and return accordingly * LayoutTests/svg/custom/display-none-a-does-not-stop-focus-navigation.html: Add Test Case * LayoutTests/svg/custom/display-none-a-does-not-stop-focus-navigation-expected.txt: Add Test Case Expectation * LayoutTests/platform/ios/TestExpectations: Added test to skip on iOS since it does not support 'keyDown' Canonical link: https://commits.webkit.org/258228@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0a821c: Make sure rows are updated during simplified layout
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0a821c7d68ea240665ed1a0aaceefe1bddbebb5f https://github.com/WebKit/WebKit/commit/0a821c7d68ea240665ed1a0aaceefe1bddbebb5f Author: Ahmad Saleem Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: A LayoutTests/fast/table/table-overflow-crash-expected.txt A LayoutTests/fast/table/table-overflow-crash.html M Source/WebCore/rendering/RenderTable.cpp Log Message: --- Make sure rows are updated during simplified layout Make sure rows are updated during simplified layout https://bugs.webkit.org/show_bug.cgi?id=249707 Reviewed by Alan Baradlay. Merge - https://src.chromium.org/viewvc/blink?revision=191146&view=revision When we are calling RenderTable::simplifiedNormalFlowLayout(), we have to make sure that we call section->layoutRows() before we do the section->computeOverflowFromCells(). The call to layoutRows is needed because it will reset and update the m_forceSlowPaintPathWithOverflowingCell flag which causes to fail the ASSERT. * Source/WebCore/rendering/RenderTable.cpp: (RenderTable::simplifiedNormalFlowLayout): Add "layoutRows" before "computeOverflowFromCells" * LayoutTests/fast/table/table-overflow-crash.html: Add Test Case * LayoutTests/fast/table/table-overflow-crash-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/258227@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 202249: [WebGPU] Implement RenderBundleEncoder which appea...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2022497de7f199c23db76c643ad1935e183d28cc https://github.com/WebKit/WebKit/commit/2022497de7f199c23db76c643ad1935e183d28cc Author: Mike Wyrzykowski Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj M Source/WebGPU/WebGPU/BindGroup.h M Source/WebGPU/WebGPU/BindGroup.mm A Source/WebGPU/WebGPU/BindableResource.h M Source/WebGPU/WebGPU/ComputePipeline.mm M Source/WebGPU/WebGPU/RenderBundle.h M Source/WebGPU/WebGPU/RenderBundle.mm M Source/WebGPU/WebGPU/RenderBundleEncoder.h M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.mm M Source/WebGPU/WebGPU/RenderPipeline.mm A Websites/webkit.org/demos/webgpu/indirect-command-buffer-textured-cube.html M Websites/webkit.org/demos/webgpu/scripts/hello-triangle-msaa.js A Websites/webkit.org/demos/webgpu/scripts/indirect-command-buffer-textured-cube.js M Websites/webkit.org/demos/webgpu/scripts/instanced-textured-cube.js Log Message: --- [WebGPU] Implement RenderBundleEncoder which appears to be MTLIndirectCommandBuffer https://bugs.webkit.org/show_bug.cgi?id=249257 Reviewed by Dean Jackson. Creation of the MTLIndirectCommandBuffer is deferred as we need to tell Metal the maximum number of vertex and fragment buffers prior to creating the ICB, along with the number of draw commands. * Source/WebGPU/WebGPU.xcodeproj/project.pbxproj: * Source/WebGPU/WebGPU/BindGroup.h: (WebGPU::BindGroup::create): (WebGPU::BindGroup::resources const): * Source/WebGPU/WebGPU/BindGroup.mm: (WebGPU::Device::createBindGroup): (WebGPU::BindGroup::BindGroup): Renamed struct moved to its own header. * Source/WebGPU/WebGPU/BindableResource.h: Copied from Source/WebGPU/WebGPU/RenderBundle.mm. Moved from BindGroup.h * Source/WebGPU/WebGPU/RenderBundle.h: (WebGPU::RenderBundle::create): (WebGPU::RenderBundle::resources const): * Source/WebGPU/WebGPU/RenderBundle.mm: (WebGPU::RenderBundle::RenderBundle): Cache the ICB and required resources. * Source/WebGPU/WebGPU/RenderBundleEncoder.h: (WebGPU::RenderBundleEncoder::create): * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::Device::createRenderBundleEncoder): (WebGPU::RenderBundleEncoder::RenderBundleEncoder): (WebGPU::RenderBundleEncoder::currentRenderCommand): (WebGPU::RenderBundleEncoder::draw): (WebGPU::RenderBundleEncoder::drawIndexed): (WebGPU::RenderBundleEncoder::drawIndexedIndirect): (WebGPU::RenderBundleEncoder::drawIndirect): (WebGPU::RenderBundleEncoder::finish): (WebGPU::RenderBundleEncoder::setBindGroup): (WebGPU::RenderBundleEncoder::setIndexBuffer): (WebGPU::RenderBundleEncoder::setPipeline): (WebGPU::RenderBundleEncoder::setVertexBuffer): Implement pipeline functions. * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::executeBundles): * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipeline): * Websites/webkit.org/demos/webgpu/indirect-command-buffer-textured-cube.html: Added. * Websites/webkit.org/demos/webgpu/scripts/indirect-command-buffer-textured-cube.js: Added. (async helloCube.frameUpdate): (async helloCube): Add ICB demo test. * Websites/webkit.org/demos/webgpu/scripts/hello-triangle-msaa.js: (async helloTriangle): * Websites/webkit.org/demos/webgpu/scripts/instanced-textured-cube.js: Miscellaneous test fixes observed running under the debug metal device. Canonical link: https://commits.webkit.org/258226@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bfbe6b: Improve WASM OMG logging
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bfbe6b3ede3cb6ba92287e5d45660aad57388343 https://github.com/WebKit/WebKit/commit/bfbe6b3ede3cb6ba92287e5d45660aad57388343 Author: Justin Michaud Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/Sources.txt M Source/JavaScriptCore/b3/B3Procedure.h M Source/JavaScriptCore/b3/B3Value.cpp A Source/JavaScriptCore/jit/SIMDInfo.cpp M Source/JavaScriptCore/jit/SIMDInfo.h M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp M Source/JavaScriptCore/wasm/WasmModuleInformation.h M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp M Source/JavaScriptCore/wasm/WasmOMGPlan.h M Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp M Source/JavaScriptCore/wasm/WasmOSREntryPlan.h M Source/JavaScriptCore/wasm/WasmOperations.cpp Log Message: --- Improve WASM OMG logging https://bugs.webkit.org/show_bug.cgi?id=249738 rdar://103609640 Reviewed by Yusuke Suzuki. Improve WASM debug logging and disassembly output for the WASM OMG tier. * Source/JavaScriptCore/b3/B3Procedure.h: (JSC::B3::Procedure::usesSIMD const): * Source/JavaScriptCore/b3/B3Value.cpp: (JSC::B3::Value::generateCompilerConstructionSite): * Source/JavaScriptCore/jit/SIMDInfo.h: (WTF::printInternal): * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::notifyOptionsChanged): * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::emitLoopTierUpCheck): * Source/JavaScriptCore/wasm/WasmBBQPlan.cpp: (JSC::Wasm::BBQPlan::dumpDisassembly): (JSC::Wasm::BBQPlan::work): * Source/JavaScriptCore/wasm/WasmModuleInformation.h: (JSC::Wasm::ModuleInformation::isSIMDFunction const): * Source/JavaScriptCore/wasm/WasmOMGPlan.cpp: (JSC::Wasm::OMGPlan::dumpDisassembly): (JSC::Wasm::OMGPlan::work): * Source/JavaScriptCore/wasm/WasmOMGPlan.h: * Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp: (JSC::Wasm::OSREntryPlan::dumpDisassembly): (JSC::Wasm::OSREntryPlan::work): * Source/JavaScriptCore/wasm/WasmOSREntryPlan.h: * Source/JavaScriptCore/wasm/WasmOperations.cpp: Canonical link: https://commits.webkit.org/258225@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ae2789: Explicitly take a ProcessAssertion while handling ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae2789ffe3875ca00d70b0c58037f9347924 https://github.com/WebKit/WebKit/commit/ae2789ffe3875ca00d70b0c58037f9347924 Author: Brady Eidson Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp Log Message: --- Explicitly take a ProcessAssertion while handling push/notification events https://bugs.webkit.org/show_bug.cgi?id=249747 rdar://103613494 Reviewed by Chris Dumez. We need to guarantee the UIProcess remains unsuspended long enough to handle these events. * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::processPushMessage): (WebKit::NetworkProcessProxy::processNotificationEvent): Canonical link: https://commits.webkit.org/258224@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c560f: Fixed unused warning added in 257456@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c560f2f0a48c96b3c68110cc2e4a8a44a1aa9ae https://github.com/WebKit/WebKit/commit/1c560f2f0a48c96b3c68110cc2e4a8a44a1aa9ae Author: Don Olmstead Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/dom/FullscreenManager.cpp Log Message: --- Fixed unused warning added in 257456@main https://bugs.webkit.org/show_bug.cgi?id=249742 Reviewed by Tim Nguyen. * Source/WebCore/dom/FullscreenManager.cpp: Canonical link: https://commits.webkit.org/258223@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 301e96: WebGL fails to initialize within an OffscreenCanva...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 301e966c8ef8d1b14afe220ba29d771588b61b8b https://github.com/WebKit/WebKit/commit/301e966c8ef8d1b14afe220ba29d771588b61b8b Author: Matt Woodrow Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas-expected.txt M LayoutTests/http/wpt/offscreen-canvas/getContext-webgl-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt R LayoutTests/platform/mac-wk1/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas-expected.txt R LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp Log Message: --- WebGL fails to initialize within an OffscreenCanvas on the main thread. https://bugs.webkit.org/show_bug.cgi?id=249679 Reviewed by Dean Jackson. Lookup GraphicsClient using the ScriptExecutionContext instead of via HTMLCanvasElement. This handles the case where the CanvasBase is an OffscreenCanvas, but we're on the main thread (and not a worker). * LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas-expected.txt: * LayoutTests/http/wpt/offscreen-canvas/getContext-webgl-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap-expected.txt. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable-expected.txt. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt: Renamed from LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt. * LayoutTests/platform/mac-wk1/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas-expected.txt: Removed. * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::getGraphicsClient): Canonical link: https://commits.webkit.org/258222@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3404d0: [git-webkit] Handle invalid commit reference (Foll...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3404d08aca9739404d1f4ca1f590b8349548 https://github.com/WebKit/WebKit/commit/3404d08aca9739404d1f4ca1f590b8349548 Author: Jonathan Bedard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/trace.py Log Message: --- [git-webkit] Handle invalid commit reference (Follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=246549 rdar://101191143 Unreviewed follow-up fix. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/trace.py: (Trace.relationships): Catch invalid identifiers as well. Canonical link: https://commits.webkit.org/258221@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e2c96: WebKit crash-looping under WebCore::interactionReg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e2c969c2b7366c45ae5c2f2c1768944c498204b https://github.com/WebKit/WebKit/commit/2e2c969c2b7366c45ae5c2f2c1768944c498204b Author: Tim Horton Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/page/InteractionRegion.cpp Log Message: --- WebKit crash-looping under WebCore::interactionRegionForRenderedRegion after 256432@main https://bugs.webkit.org/show_bug.cgi?id=249744 rdar://103465057 Reviewed by Wenson Hsieh. * Source/WebCore/page/InteractionRegion.cpp: (WebCore::interactionRegionForRenderedRegion): Avoid dereferencing `element` if it is null. Both of these assignments change `element` but only if they find nonnull parents to ascend to, so we don't need to duplicate the check, we can just move it upwards. Canonical link: https://commits.webkit.org/258220@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c24a49: [JSC] Fix Air Wasm call clobbering after tail-call...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c24a49a2c1bb91639400b3fd1b8c054461f79c87 https://github.com/WebKit/WebKit/commit/c24a49a2c1bb91639400b3fd1b8c054461f79c87 Author: Yusuke Suzuki Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp Log Message: --- [JSC] Fix Air Wasm call clobbering after tail-call patch https://bugs.webkit.org/show_bug.cgi?id=249749 rdar://103573703 Reviewed by Mark Lam. tail-call change (258062@main) accidentally dropped normal wasm call's clobbering information in Air, causing crash in Amazon web page. This patch recovers it. * Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp: (JSC::Wasm::AirIRGenerator64::emitCallPatchpoint): * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::addCall): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::createCallPatchpoint): Canonical link: https://commits.webkit.org/258219@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58acbb: [CSS-Typed-OM] Make sure `column-count` value gets...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58acbb968b7336a4f32ce0c3a9026b915b6914b7 https://github.com/WebKit/WebKit/commit/58acbb968b7336a4f32ce0c3a9026b915b6914b7 Author: Chris Dumez Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-count-expected.txt M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- [CSS-Typed-OM] Make sure `column-count` value gets clamped to [1, inf] https://bugs.webkit.org/show_bug.cgi?id=249722 Reviewed by Alan Baradlay. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-count-expected.txt: * Source/WebCore/rendering/style/RenderStyle.h: (WebCore::RenderStyle::setColumnCount): Canonical link: https://commits.webkit.org/258218@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6568bf: [Live Range Selection] TestWebKitAPI.EditorStateTe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6568bf909a769e0b5f2f7d70379a6882ab6afc2f https://github.com/WebKit/WebKit/commit/6568bf909a769e0b5f2f7d70379a6882ab6afc2f Author: Ryosuke Niwa Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm Log Message: --- [Live Range Selection] TestWebKitAPI.EditorStateTests.TypingAttributesTextAlignmentAbsoluteAlignmentOptions fails https://bugs.webkit.org/show_bug.cgi?id=249677 Reviewed by Wenson Hsieh. This test fails because it was using an invalid offset. Use an equivalent valid offset. * Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/258217@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23d5b9: [IFC] Hanging trailing content should not be treat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23d5b940828fd5931a64c0bdbb471f499f13cb82 https://github.com/WebKit/WebKit/commit/23d5b940828fd5931a64c0bdbb471f499f13cb82 Author: Alan Baradlay Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineLine.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp Log Message: --- [IFC] Hanging trailing content should not be treated trimmable https://bugs.webkit.org/show_bug.cgi?id=249711 Reviewed by Antti Koivisto. If the trailing content on the line is hanging whitespace (pre-wrap), it should be treated as preserved (again, pre-wrap) and not trimmable (this likely has no visual impact though). * Source/WebCore/layout/formattingContexts/inline/InlineLine.h: (WebCore::Layout::Line::hangingTrailingWhitespaceWidth const): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::tryPlacingFloatBox): (WebCore::Layout::LineBuilder::handleInlineContent): (WebCore::Layout::trimmableTrailingContentWidth): Deleted. Canonical link: https://commits.webkit.org/258216@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 11eb34: [@property] used in initial-va...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 11eb340cd2d87f5b32d8b746e829eda7ab2f2d18 https://github.com/WebKit/WebKit/commit/11eb340cd2d87f5b32d8b746e829eda7ab2f2d18 Author: Antti Koivisto Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom-expected.txt M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/CSSProperty.h M Source/WebCore/css/CSSPropertyRule.cpp M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h M Source/WebCore/css/process-css-properties.py Log Message: --- [@property] used in initial-value descriptor should preserve whitespace https://bugs.webkit.org/show_bug.cgi?id=249731 rdar://103607902 Reviewed by Sam Weinig. The 'initial-value' descriptor has syntax and it should preserve whitespace. https://drafts.csswg.org/css-syntax-3/#typedef-declaration-value * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom-expected.txt: * Source/WebCore/css/CSSProperties.json: Use parser-grammar: "" * Source/WebCore/css/CSSProperty.h: * Source/WebCore/css/CSSPropertyRule.cpp: (WebCore::CSSPropertyRule::cssText const): Don't add extra space when serializing. * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeDeclaration): Trim whitespace conditionally. * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseValue): Trim whitespace conditionally. * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeDeclarationValue): (WebCore::CSSPropertyParserHelpers::consumePropertyInitialValue): Deleted. * Source/WebCore/css/parser/CSSPropertyParserHelpers.h: * Source/WebCore/css/process-css-properties.py: (PropertiesAndDescriptors): (PropertiesAndDescriptors.all_preserving_whitespace): (ReferenceTerm): Add a build-in type for . (Grammar): (Grammar.preserve_whitespace): Those have a special property that they preserve whitespace. (GenerateCSSPropertyNames): Generate Property::shouldPreserveWhitespace(). Canonical link: https://commits.webkit.org/258215@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7750f7: [WinCairo] Assertion fails while ~RemoteImageBuffe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7750f7a4299a3cb0955f4beadcecf47e15241673 https://github.com/WebKit/WebKit/commit/7750f7a4299a3cb0955f4beadcecf47e15241673 Author: Fujii Hironori Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp Log Message: --- [WinCairo] Assertion fails while ~RemoteImageBufferProxy in DrawingAreaWC CommitQueue https://bugs.webkit.org/show_bug.cgi?id=249694 Reviewed by Kimmo Kinnunen. An assertion failed because RemoteImageBufferProxy was destroyed in the non-main thread. * Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp: (WebKit::DrawingAreaWC::sendUpdateNonAC): Don't leave the lifetime of RefPtr in the lambda functions. Canonical link: https://commits.webkit.org/258214@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7bca60: JetStream3 harness: reset seed of Math.random() on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7bca60ef1a1704e00bd8ca90c006793f0556cb0d https://github.com/WebKit/WebKit/commit/7bca60ef1a1704e00bd8ca90c006793f0556cb0d Author: Alexey Shvayka Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M PerformanceTests/JetStream3/JetStreamDriver.js M PerformanceTests/JetStream3/simple/file-system.js Log Message: --- JetStream3 harness: reset seed of Math.random() on every benchmark iteration https://bugs.webkit.org/show_bug.cgi?id=249592 Reviewed by Yusuke Suzuki. This change extracts Math.random() implementation, which resets its seed on every iteration, from simple/file-system.js to be used for all other tests, including newly-added BigInt crypto tests that heavily rely on Math.random(). * PerformanceTests/JetStream3/JetStreamDriver.js: (prototype.get runnerCode): (prototype.get preiterationCode): (prototype.async run): (AsyncBenchmark.get runnerCode.return.async doRun): (AsyncBenchmark.prototype.get runnerCode): (AsyncBenchmark): * PerformanceTests/JetStream3/simple/file-system.js: (Benchmark.prototype.async runIteration): (Benchmark): (resetSeed): Deleted. (Math.random): Deleted. Canonical link: https://commits.webkit.org/258213@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a1184: AX: Expose bold and italic font styling as text at...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a11844523ca34c274cd4b361f9805010fc759ae https://github.com/WebKit/WebKit/commit/9a11844523ca34c274cd4b361f9805010fc759ae Author: Tommy McHugh Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: A LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling-expected.txt A LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling.html M LayoutTests/platform/mac/accessibility/content-editable-as-textarea-expected.txt M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm Log Message: --- AX: Expose bold and italic font styling as text attributes for macOS https://bugs.webkit.org/show_bug.cgi?id=249688 rdar://problem/103577386 Reviewed by Chris Fleizach. Currently WebKit only exposes bold and italic properties of font styling for iOS. This patch adds bold and italic font styling information to accessibility for macOS by checking the bold and italic symbolic font traits in AXAttributedStringSetFont and adding their result as AXFontBold and AXFontItalic font attributes. * LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling-expected.txt: Added. * LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling.html: Added. * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (AXAttributedStringSetFont): Canonical link: https://commits.webkit.org/258212@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf10c6: [run-webkit-tests] Strip stderr and stdout pattern...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bf10c63587cfba9eea146812bb92d5e5f2d7c62b https://github.com/WebKit/WebKit/commit/bf10c63587cfba9eea146812bb92d5e5f2d7c62b Author: Jonathan Bedard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py Log Message: --- [run-webkit-tests] Strip stderr and stdout patterns from ref tests https://bugs.webkit.org/show_bug.cgi?id=249724 rdar://103602017 Reviewed by Ryan Haddad. * Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._run_reftest): Strip stdout and stderr patterns, as we do for other test types. Canonical link: https://commits.webkit.org/258211@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 28c5d0: Ensure transferred max size is floored by transfer...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 28c5d0e82b0f2b000aa18734a3f2345ed9cfd86e https://github.com/WebKit/WebKit/commit/28c5d0e82b0f2b000aa18734a3f2345ed9cfd86e Author: Sammy Gill Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-041-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-041.html M Source/WebCore/rendering/RenderBox.cpp Log Message: --- Ensure transferred max size is floored by transferred min size in RenderReplaced::computeIntrinsicSizesConstrainedByTransferredMinMaxSizes. https://bugs.webkit.org/show_bug.cgi?id=249617 rdar://103537352 Reviewed by Alan Baradlay. Addresses a regression introduced by a change inside of computeIntrinsicSizesConstrainedByTransferredMinMaxSizes. This method is supposed to compute the intrinsic size and ratio of a replaced element and also restrict that size if there are any transferred min/max constraints that are violated. This code was not checking if the transferred max size became smaller than the transferred min size. The max size is supposed to be floored by the min size in order to avoid this scenario. One situation in which this can happen is when we are computing the min/max logical height, the containing block has an available width of 0px, and the max-width specified is percentage based. When the call to computeLogicalWidthInFragmentUsing returns, it will return a value of 0px when it resolves the percentage based max-width. Then, any specified value of min-width greater than 0px will cause this issue. The new code added addresses this issue by setting the max size to max(min size, max size). Ideally, we would be able to use RenderBox::constrainLogicalMinMaxSizesByAspectRatio, which has this logic for us, but my attempt to do this was causing issues when replaced elements were inside a flexbox. Spec reference: https://www.w3.org/TR/css-sizing-4/#aspect-ratio-size-transfers * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-041-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-041.html: Added. * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::computeMinMaxLogicalWidthFromAspectRatio const): (WebCore::RenderBox::computeMinMaxLogicalHeightFromAspectRatio const): Canonical link: https://commits.webkit.org/258210@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b38cc: FrameView::frame should return an AbstractFrame
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b38cc78aea225f0b479c89d29fe027e958635d0 https://github.com/WebKit/WebKit/commit/6b38cc78aea225f0b479c89d29fe027e958635d0 Author: Alex Christensen Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilityScrollView.cpp M Source/WebCore/display/DisplayView.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/history/CachedFrame.cpp M Source/WebCore/history/CachedPage.cpp M Source/WebCore/inspector/InspectorInstrumentation.cpp M Source/WebCore/inspector/InspectorInstrumentation.h M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp M Source/WebCore/inspector/agents/InspectorPageAgent.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/Frame.cpp M Source/WebCore/page/FrameView.cpp M Source/WebCore/page/FrameView.h M Source/WebCore/page/FrameViewLayoutContext.cpp M Source/WebCore/page/ModalContainerObserver.cpp M Source/WebCore/page/PageColorSampler.cpp M Source/WebCore/page/mac/EventHandlerMac.mm M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderIFrame.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderTreeAsText.cpp M Source/WebCore/rendering/RenderView.cpp M Source/WebCore/rendering/RenderWidget.cpp M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm M Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.cpp M Source/WebKitLegacy/win/WebView.cpp Log Message: --- FrameView::frame should return an AbstractFrame https://bugs.webkit.org/show_bug.cgi?id=249662 rdar://103564957 Reviewed by Chris Dumez. This is in preparation for a RemoteFrame to have a view object that is different from FrameView but inherits from a shared parent class, like Frame/RemoteFrame/AbstractFrame do now. * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::appendAccessibilityObject): (WebCore::AccessibilityObject::document const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForPoint const): (WebCore::AccessibilityRenderObject::remoteSVGRootElement const): * Source/WebCore/accessibility/AccessibilityScrollView.cpp: (WebCore::AccessibilityScrollView::document const): * Source/WebCore/display/DisplayView.cpp: (WebCore::Display::View::frame const): * Source/WebCore/dom/Document.cpp: (WebCore::Document::resolveStyle): (WebCore::Document::attachToCachedFrame): (WebCore::computeIntersectionState): * Source/WebCore/editing/FrameSelection.cpp: (WebCore::CaretBase::shouldRepaintCaret const): * Source/WebCore/history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::open): (WebCore::CachedFrame::destroy): * Source/WebCore/history/CachedPage.cpp: (WebCore::CachedPage::restore): * Source/WebCore/inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didAddOrRemoveScrollbarsImpl): * Source/WebCore/inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didAddOrRemoveScrollbars): * Source/WebCore/inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode): * Source/WebCore/inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::didPaint): * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::subframeForTargetNode): * Source/WebCore/page/Frame.cpp: (WebCore::Frame::frameForWidget): (WebCore::Frame::clearTimers): * Source/WebCore/page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::removeFromAXObjectCache): (WebCore::FrameView::init): (WebCore::FrameView::recalculateScrollbarOverlayStyle): (WebCore::FrameView::invalidateRect): (WebCore::FrameView::setFrameRect): (WebCore::FrameView::rootElementForCustomScrollbarPartStyle const): (WebCore::FrameView::createScrollbar): (WebCore::FrameView::setContentsSize): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::applyPaginationToViewport): (WebCore::FrameView::calculateScrollbarModesForLayout): (WebCore::FrameView::updateSnapOffsets): (WebCor
[webkit-changes] [WebKit/WebKit] 177a4a: [git-webkit] Add the original of a commit to the c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 177a4ad3101befc85ab639ad9d99f1284d74a1a0 https://github.com/WebKit/WebKit/commit/177a4ad3101befc85ab639ad9d99f1284d74a1a0 Author: Jonathan Bedard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pickable.py Log Message: --- [git-webkit] Add the original of a commit to the commit story https://bugs.webkit.org/show_bug.cgi?id=249655 rdar://103558956 Reviewed by Elliott Williams. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pickable.py: (Pickable.pickable): (Pickable.main): Canonical link: https://commits.webkit.org/258208@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2d8ab: Add Mark Gee to contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2d8ab5aaa1a8235e185c7e733c864ffa216e5bd https://github.com/WebKit/WebKit/commit/e2d8ab5aaa1a8235e185c7e733c864ffa216e5bd Author: Jonathan Bedard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M metadata/contributors.json Log Message: --- Add Mark Gee to contributors.json Unreviewed. * metadata/contributors.json: Canonical link: https://commits.webkit.org/258207@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0a133: Revert 258117@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0a1331fd781c2f2a45d95731f957e012a67602a https://github.com/WebKit/WebKit/commit/e0a1331fd781c2f2a45d95731f957e012a67602a Author: Matthew Finkel Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/loader/FrameLoader.cpp Log Message: --- Revert 258117@main https://bugs.webkit.org/show_bug.cgi?id=249667 rdar://problem/103565867 Reviewed by Ryan Haddad. This fix was previously reverted as part of a larger bugfix revert, but it was cherry-picked as a result of using that single revert commit earlier. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadArchive): Canonical link: https://commits.webkit.org/258206@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.14.11 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2dd6a0: Versioning.
Branch: refs/heads/safari-7615.1.14-branch Home: https://github.com/WebKit/WebKit Commit: 2dd6a0631408ce3f18c5bb312afc51905619b128 https://github.com/WebKit/WebKit/commit/2dd6a0631408ce3f18c5bb312afc51905619b128 Author: Alan Coon Date: 2022-12-16 (Fri, 16 Dec 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.14.10 Canonical link: https://commits.webkit.org/257350.22@safari-7615.1.14-branch Commit: e7da0001cadcfd8ce9cdc6916605675a460232a9 https://github.com/WebKit/WebKit/commit/e7da0001cadcfd8ce9cdc6916605675a460232a9 Author: Alan Coon Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.14.11 Canonical link: https://commits.webkit.org/257350.23@safari-7615.1.14-branch Compare: https://github.com/WebKit/WebKit/compare/ceccdde47654...e7da0001cadc ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1915b8: [PlayStation] Fix build after 258179@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1915b83c90364f6e38111612fab81931a3557771 https://github.com/WebKit/WebKit/commit/1915b83c90364f6e38111612fab81931a3557771 Author: Don Olmstead Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] Fix build after 258179@main https://bugs.webkit.org/show_bug.cgi?id=249733 Unreviewed build fix. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/258205@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aca859: [@property] Validate universal syntax initial valu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aca85912a52befcceed52e1055a2de75b303765e https://github.com/WebKit/WebKit/commit/aca85912a52befcceed52e1055a2de75b303765e Author: Antti Koivisto Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt M Source/WebCore/css/CSSCustomPropertyValue.cpp M Source/WebCore/css/CSSCustomPropertyValue.h M Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp M Source/WebCore/css/StyleRule.h M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParser.h M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h M Source/WebCore/css/parser/CSSVariableParser.cpp M Source/WebCore/css/parser/CSSVariableParser.h M Source/WebCore/style/CustomPropertyRegistry.cpp Log Message: --- [@property] Validate universal syntax initial value as https://bugs.webkit.org/show_bug.cgi?id=249708 rdar://103595129 Reviewed by Dean Jackson. Initial value for "*" syntax can't be quite any token sequence. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt: * Source/WebCore/css/CSSCustomPropertyValue.h: * Source/WebCore/css/CSSCustomPropertyValue.cpp: (WebCore::CSSCustomPropertyValue::containsCSSWideKeyword const): Simplify. Only the simple case is needed. (WebCore::CSSCustomPropertyValue::asVariableData const): Add a helper. * Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp: (WebCore::DOMCSSRegisterCustomProperty::registerProperty): * Source/WebCore/css/StyleRule.h: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumePropertyRule): * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseTypedCustomPropertyInitialValue): Add a separate function for initial value parsing. * Source/WebCore/css/parser/CSSPropertyParser.h: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumePropertyInitialValue): Consume property as . * Source/WebCore/css/parser/CSSPropertyParserHelpers.h: * Source/WebCore/css/parser/CSSVariableParser.cpp: (WebCore::CSSVariableParser::parseInitialValueForUniversalSyntax): Add a helper that also verifies no var() is being used. * Source/WebCore/css/parser/CSSVariableParser.h: * Source/WebCore/style/CustomPropertyRegistry.cpp: (WebCore::Style::CustomPropertyRegistry::registerFromStylesheet): Also return an explicit "guaranteed-invalid" value instead of a null. This doesn't change behavior. Canonical link: https://commits.webkit.org/258204@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c874d: [IFC][hanging punctuation] Line::appendTextContent...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c874dbf01e2e44eb7a989f83fe6e8b1bff4afaf https://github.com/WebKit/WebKit/commit/1c874dbf01e2e44eb7a989f83fe6e8b1bff4afaf Author: Alan Baradlay Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h Log Message: --- [IFC][hanging punctuation] Line::appendTextContent should call setTrailingStopOrComma when it sees one https://bugs.webkit.org/show_bug.cgi?id=249696 Reviewed by Antti Koivisto. This is in preparation for supporting "hanging-punctuation: allow-end". * Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp: (WebCore::Layout::Line::appendTextContent): * Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp: (WebCore::Layout::TextUtil::hasHangableStopOrCommaEnd): (WebCore::Layout::TextUtil::hangableStopOrCommaEndWidth): * Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h: Canonical link: https://commits.webkit.org/258203@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4569ef: [ews-build.webkit.org] Support multiple suites in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4569ef02ba265030d8da4900841beb0913b10451 https://github.com/WebKit/WebKit/commit/4569ef02ba265030d8da4900841beb0913b10451 Author: Jonathan Bedard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Tools/CISupport/ews-build/results_db.py Log Message: --- [ews-build.webkit.org] Support multiple suites in ResultsDatabase https://bugs.webkit.org/show_bug.cgi?id=249721 rdar://103601598 Reviewed by Ryan Haddad. Add a 'suite' argument so ResultsDatabase supports multiple suites. * Tools/CISupport/ews-build/results_db.py: (ResultsDatabase): (ResultsDatabase.get_results_summary): Add 'suite' argument. (ResultsDatabase.is_test_pre_existing_failure): Ditto. (ResultsDatabase.is_test_expected_to): Ditto. (ResultsDatabase.main): Ditto. Canonical link: https://commits.webkit.org/258202@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f7697e: Refactor caret animation handling logic when scrol...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f7697e1e0fab24855f25a56a0512c7bbdffdc108 https://github.com/WebKit/WebKit/commit/f7697e1e0fab24855f25a56a0512c7bbdffdc108 Author: Richard Robinson Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/page/EditorClient.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h M Source/WebCore/page/scrolling/ScrollingTree.h M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h M Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp M Source/WebCore/page/scrolling/ThreadedScrollingTree.h M Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp M Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.h M Source/WebCore/platform/ScrollingEffectsController.cpp M Source/WebCore/platform/ScrollingEffectsController.h M Source/WebCore/platform/mac/ScrollingEffectsController.mm M Source/WebKit/UIProcess/PageClient.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/mac/PageClientImplMac.h M Source/WebKit/UIProcess/mac/PageClientImplMac.mm M Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h M Source/WebKit/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h Log Message: --- Refactor caret animation handling logic when scrolling/zooming https://bugs.webkit.org/show_bug.cgi?id=249511 rdar://102938633 Reviewed by Simon Fraser. * Source/WebCore/loader/EmptyClients.cpp: * Source/WebCore/page/EditorClient.h: * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator): (WebCore::AsyncScrollingCoordinator::hysterisisTimerFired): (WebCore::AsyncScrollingCoordinator::applyScrollPositionUpdate): (WebCore::AsyncScrollingCoordinator::animatedScrollWillStartForNode): (WebCore::AsyncScrollingCoordinator::animatedScrollDidEndForNode): (WebCore::AsyncScrollingCoordinator::wheelEventScrollWillStartForNode): (WebCore::AsyncScrollingCoordinator::wheelEventScrollDidEndForNode): * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h: * Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h: * Source/WebCore/page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::scrollingTreeNodeWillStartAnimatedScroll): (WebCore::ScrollingTree::scrollingTreeNodeWillStartWheelEventScroll): (WebCore::ScrollingTree::scrollingTreeNodeDidStopWheelEventScroll): * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::willStartAnimatedScroll): (WebCore::ScrollingTreeScrollingNode::willStartWheelEventScroll): (WebCore::ScrollingTreeScrollingNode::didStopWheelEventScroll): * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h: * Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::scrollingTreeNodeScrollUpdated): (WebCore::ThreadedScrollingTree::scrollingTreeNodeWillStartAnimatedScroll): (WebCore::ThreadedScrollingTree::scrollingTreeNodeDidStopAnimatedScroll): (WebCore::ThreadedScrollingTree::scrollingTreeNodeWillStartWheelEventScroll): (WebCore::ThreadedScrollingTree::scrollingTreeNodeDidStopWheelEventScroll): * Source/WebCore/page/scrolling/ThreadedScrollingTree.h: * Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp: (WebCore::ThreadedScrollingTreeScrollingNodeDelegate::willStartAnimatedScroll): (WebCore::ThreadedScrollingTreeScrollingNodeDelegate::willStartWheelEventScroll): (WebCore::ThreadedScrollingTreeScrollingNodeDelegate::didStopWheelEventScroll): * Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.h: * Source/WebCore/platform/ScrollingEffectsController.cpp: (WebCore::ScrollingEffectsController::scrollAnimationWillStart): * Source/WebCore/platform/ScrollingEffectsController.h: (WebCore::ScrollingEffectsControllerClient::willStartWheelEventScroll): (WebCore::ScrollingEffectsControllerClient::didStopWheelEventScroll): * Source/WebCore/platform/mac/ScrollingEffectsController.mm: (WebCore::ScrollingEffectsController::handleWheelEvent): * Source/WebKit/UIProcess/PageClient.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setCaretDecorationVisibility): * Source/WebKit/UIPro
[webkit-changes] [WebKit/WebKit] 94b13d: Unreviewed, reverting r258185@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 94b13dafa321719af4869b4fd66c302b6999a53f https://github.com/WebKit/WebKit/commit/94b13dafa321719af4869b4fd66c302b6999a53f Author: Commit Queue Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/Modules/mediasource/MediaSource.cpp M Source/WebCore/Modules/mediasource/MediaSource.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/page/MediaProducer.h M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKit/file-with-mse.html R Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm Log Message: --- Unreviewed, reverting r258185@main. https://bugs.webkit.org/show_bug.cgi?id=249728 New API test for this change is consistently failing Reverted changeset: "Notify networking stack that download is media related" https://bugs.webkit.org/show_bug.cgi?id=249569 https://commits.webkit.org/258185@main Canonical link: https://commits.webkit.org/258200@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40db70: Fix property name in css/css-typed-om/the-stylepro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40db70745726fdd0b199b5556167b1ac47a64c12 https://github.com/WebKit/WebKit/commit/40db70745726fdd0b199b5556167b1ac47a64c12 Author: Chris Dumez Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-repeat-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-repeat.html Log Message: --- Fix property name in css/css-typed-om/the-stylepropertymap/properties/background-repeat.html WPT test https://bugs.webkit.org/show_bug.cgi?id=249717 Reviewed by Tim Nguyen. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-repeat-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-repeat.html: Canonical link: https://commits.webkit.org/258199@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68fb45: [WK2] ArgumentCoder> should use ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68fb45e34eda2fd008bee2558273e6b61f21a99f https://github.com/WebKit/WebKit/commit/68fb45e34eda2fd008bee2558273e6b61f21a99f Author: Žan Doberšek Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebKit/Platform/IPC/ArgumentCoders.h Log Message: --- [WK2] ArgumentCoder> should use increasing index sequences https://bugs.webkit.org/show_bug.cgi?id=249525 Reviewed by Kimmo Kinnunen. More intuitive increasing index sequences are adopted in the encoding and decoding implementations of ArgumentCoder>, with no real change in behavior. * Source/WebKit/Platform/IPC/ArgumentCoders.h: Canonical link: https://commits.webkit.org/258198@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08b712: [run-webkit-tests] Strip allows*HTTPS* logging mes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08b7126fcf9f0bba94141fc1afd4b87a628329c5 https://github.com/WebKit/WebKit/commit/08b7126fcf9f0bba94141fc1afd4b87a628329c5 Author: Jonathan Bedard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Tools/Scripts/webkitpy/port/darwin.py M Tools/Scripts/webkitpy/port/darwin_testcase.py M Tools/Scripts/webkitpy/port/ios_simulator.py M Tools/Scripts/webkitpy/port/mac.py M Tools/Scripts/webkitpy/port/watch_simulator.py Log Message: --- [run-webkit-tests] Strip allows*HTTPS* logging messages https://bugs.webkit.org/show_bug.cgi?id=249658 rdar://56920527 Reviewed by Alexey Proskuryakov. * Tools/Scripts/webkitpy/port/darwin.py: (DarwinPort.stderr_patterns_to_strip): Strip allows*HTTPS* logging messages. * Tools/Scripts/webkitpy/port/darwin_testcase.py: * Tools/Scripts/webkitpy/port/ios_simulator.py: (IOSSimulatorPort.logging_patterns_to_strip): Deleted. (IOSSimulatorPort.stderr_patterns_to_strip): Deleted. * Tools/Scripts/webkitpy/port/mac.py: (MacPort.stderr_patterns_to_strip): Invoke base class's stderr_patterns_to_strip. * Tools/Scripts/webkitpy/port/watch_simulator.py: (WatchSimulatorPort.logging_patterns_to_strip): Deleted. (WatchSimulatorPort.stderr_patterns_to_strip): Deleted. Canonical link: https://commits.webkit.org/258197@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 626bbc: Import dom/xslt/sort.html WPT test
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 626bbc4f3b03af0abc2a6fded3c8b72654da8442 https://github.com/WebKit/WebKit/commit/626bbc4f3b03af0abc2a6fded3c8b72654da8442 Author: David Kilzer Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/dom/xslt/sort-expected.html A LayoutTests/imported/w3c/web-platform-tests/dom/xslt/sort-ref.html A LayoutTests/imported/w3c/web-platform-tests/dom/xslt/sort.html M LayoutTests/imported/w3c/web-platform-tests/dom/xslt/w3c-import.log Log Message: --- Import dom/xslt/sort.html WPT test https://bugs.webkit.org/show_bug.cgi?id=249691 Reviewed by Tim Nguyen. Import WPT test that was added to identify an upstream libxslt regression. Upstream commit: https://github.com/web-platform-tests/wpt/commit/44dd0f4cb0faa3154c5da2aff4c9e1405447e532 * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/dom/xslt/sort-expected.html: Add. * LayoutTests/imported/w3c/web-platform-tests/dom/xslt/sort-ref.html: Add. * LayoutTests/imported/w3c/web-platform-tests/dom/xslt/sort.html: Add. * LayoutTests/imported/w3c/web-platform-tests/dom/xslt/w3c-import.log: Canonical link: https://commits.webkit.org/258196@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6204c4: REGRESSION(257823@main): named-groups/lookbehind.j...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6204c47b8556717fab441b61e56c668e6a2655dc https://github.com/WebKit/WebKit/commit/6204c47b8556717fab441b61e56c668e6a2655dc Author: Michael Saboff Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: A JSTests/stress/regexp-lookaround-captures.js M Source/JavaScriptCore/yarr/YarrInterpreter.cpp M Source/JavaScriptCore/yarr/YarrInterpreter.h M Source/JavaScriptCore/yarr/YarrJIT.cpp M Source/JavaScriptCore/yarr/YarrParser.h M Source/JavaScriptCore/yarr/YarrPattern.cpp M Source/JavaScriptCore/yarr/YarrPattern.h M Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp M Source/WebCore/contentextensions/URLFilterParser.cpp Log Message: --- REGRESSION(257823@main): named-groups/lookbehind.js Test262-test is failing https://bugs.webkit.org/show_bug.cgi?id=249330 rdar://103367993 Reviewed by Yusuke Suzuki. Fixed the case where a nested capturing group within a lookahead / lookbehind doesn't get its capture cleared if the lookaround fails. This has been a long standing issue for lookaheads. The fix is slightly different in the Yarr interpreter than in the Yarr JIT. For the interpreter, the Parenthetical Assertion processing will clear the nested captures within the assertion for the case where an inverted assertion succeeds or a normal assertion fails. For the JIT, the clearing is done at the end of a failed top level alternative for all the contained captures for that alternative. * JSTests/stress/regexp-lookaround-captures.js: Added. (arrayToString): (dumpValue): (compareArray): (testRegExp): (testRegExp.c): * Source/JavaScriptCore/yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::matchBackReference): (JSC::Yarr::Interpreter::backtrackBackReference): (JSC::Yarr::Interpreter::recordParenthesesMatch): (JSC::Yarr::Interpreter::resetMatches): (JSC::Yarr::Interpreter::matchParenthesesOnceBegin): (JSC::Yarr::Interpreter::matchParenthesesOnceEnd): (JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin): (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd): (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd): (JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd): (JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd): (JSC::Yarr::ByteCompiler::emitDisjunction): (JSC::Yarr::ByteTermDumper::dumpTerm): * Source/JavaScriptCore/yarr/YarrInterpreter.h: (JSC::Yarr::ByteTerm::ByteTerm): (JSC::Yarr::ByteTerm::containsAnyCaptures): (JSC::Yarr::ByteTerm::subpatternId): (JSC::Yarr::ByteTerm::lastSubpatternId): * Source/JavaScriptCore/yarr/YarrJIT.cpp: * Source/JavaScriptCore/yarr/YarrParser.h: (JSC::Yarr::Parser::parseTokens): * Source/JavaScriptCore/yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin): (JSC::Yarr::YarrPatternConstructor::atomParentheticalAssertionBegin): (JSC::Yarr::YarrPatternConstructor::copyDisjunction): (JSC::Yarr::YarrPatternConstructor::disjunction): * Source/JavaScriptCore/yarr/YarrPattern.h: (JSC::Yarr::PatternTerm::containsAnyCaptures): (JSC::Yarr::PatternAlternative::PatternAlternative): (JSC::Yarr::PatternAlternative::cleanupCaptures const): (JSC::Yarr::PatternDisjunction::addNewAlternative): * Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp: (JSC::Yarr::SyntaxChecker::disjunction): * Source/WebCore/contentextensions/URLFilterParser.cpp: (WebCore::ContentExtensions::PatternParser::disjunction): Canonical link: https://commits.webkit.org/258195@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fec9de: Unreviewed, reverting r257699@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fec9dea9fae22cdfee598fb3f956c4848b70c180 https://github.com/WebKit/WebKit/commit/fec9dea9fae22cdfee598fb3f956c4848b70c180 Author: Commit Queue Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/WidthIterator.cpp Log Message: --- Unreviewed, reverting r257699@main. https://bugs.webkit.org/show_bug.cgi?id=249716 PLT5 regression Reverted changeset: "[IFC] Do not block simplified text measure on HiraganaLetterSmallA or larger" https://bugs.webkit.org/show_bug.cgi?id=249066 https://commits.webkit.org/257699@main Canonical link: https://commits.webkit.org/258194@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fc5283: [WK2] Daemon::Decoder::decodeFixedLengthReference(...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fc52838b1ca2a502b206c398f5f08df1d6803e9e https://github.com/WebKit/WebKit/commit/fc52838b1ca2a502b206c398f5f08df1d6803e9e Author: Žan Doberšek Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebKit/Platform/IPC/DaemonCoders.cpp M Source/WebKit/Platform/IPC/DaemonDecoder.cpp M Source/WebKit/Platform/IPC/DaemonDecoder.h Log Message: --- [WK2] Daemon::Decoder::decodeFixedLengthReference() should return a Span https://bugs.webkit.org/show_bug.cgi?id=249704 Reviewed by Kimmo Kinnunen. Instead of a raw pointer, Daemon::Decoder::decodeFixedLengthReference() should return a Span object describing the memory area retrieved from the decoder. The sole use in CertificateInfo decoding is adjusted. To test the Span's validity, the Span's size is compared to the requested size, which will be the same when retrieval from the decoder succeeds. * Source/WebKit/Platform/IPC/DaemonCoders.cpp: (WebKit::Daemon::Coder::decode): * Source/WebKit/Platform/IPC/DaemonDecoder.cpp: (WebKit::Daemon::Decoder::decodeFixedLengthReference): * Source/WebKit/Platform/IPC/DaemonDecoder.h: Canonical link: https://commits.webkit.org/258193@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 453e83: Add some network connection integrity testing support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 453e83b1e53fb91bb95f5ca7f20855b68c2f1be1 https://github.com/WebKit/WebKit/commit/453e83b1e53fb91bb95f5ca7f20855b68c2f1be1 Author: Wenson Hsieh Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm M Source/WebKit/UIProcess/WebPageProxy.h M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebKit/NetworkConnectionIntegrityTests.mm Log Message: --- Add some network connection integrity testing support https://bugs.webkit.org/show_bug.cgi?id=249651 Reviewed by Aditya Keerthi. Add support for API tests for lookalike character sanitization. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: Leave a FIXME here, explaining that this testing hook can be removed once the API calls into the associated system framework can happen directly in the UI process, without having to go through the network process. (+[WKWebView _setLookalikeCharacterStringsForTesting:]): * Source/WebKit/UIProcess/WebPageProxy.h: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKit/NetworkConnectionIntegrityTests.mm: Added. Add a WebKitAdditions extension point, which will contain the new API tests. Canonical link: https://commits.webkit.org/258192@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35db0b: [ews-build.webkit.org] Add concept of validators (...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35db0b62befe4e0457c8adb56d156ed47c712621 https://github.com/WebKit/WebKit/commit/35db0b62befe4e0457c8adb56d156ed47c712621 Author: Jonathan Bedard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- [ews-build.webkit.org] Add concept of validators (Follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=247708 rdar://102168279 Unreviewed validator addition. @alancoon should be a validator. * Tools/CISupport/ews-build/steps.py: (ValidateCommitterAndReviewer): * Tools/CISupport/ews-build/steps_unittest.py: Canonical link: https://commits.webkit.org/258191@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 409456: BitStack::top() should calculate an index instead ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 409456bc5cee21871671023b1e50b426604e0ce7 https://github.com/WebKit/WebKit/commit/409456bc5cee21871671023b1e50b426604e0ce7 Author: Ahmad Saleem Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/editing/TextIterator.cpp Log Message: --- BitStack::top() should calculate an index instead of always using m_words.last() BitStack::top() should calculate an index instead of always using m_words.last() https://bugs.webkit.org/show_bug.cgi?id=142224 Reviewed by Antti Koivisto. Merge - https://chromium.googlesource.com/chromium/blink/+/6513eab4e0dae0ff8556dd6ddbbb9c475bec2d32 This patch is to fix a logical error, where if the stack gets deeper than sizeof(unsigned), the result reported by top() can be incorrect if anything has been popped. * Source/WebCore/editing/TextIterator.cpp: (BitStack::top): Add unsigned variable "index" and use it as an array for return value Canonical link: https://commits.webkit.org/258190@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01e7ec: Add Ian Anderson to contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01e7ec39597e7f44cd21021276f530c0085b1bf7 https://github.com/WebKit/WebKit/commit/01e7ec39597e7f44cd21021276f530c0085b1bf7 Author: Ian Anderson Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M metadata/contributors.json Log Message: --- Add Ian Anderson to contributors.json https://bugs.webkit.org/show_bug.cgi?id=249680 Reviewed by Jonathan Bedard. Add myself to contributors.json. * metadata/contributors.json: Canonical link: https://commits.webkit.org/258189@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8be5cf: [IFC][hanging punctuation] Line::HangingContent sh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8be5cfd53e57e5c2cc6ec1e9629b62b1069aefeb https://github.com/WebKit/WebKit/commit/8be5cfd53e57e5c2cc6ec1e9629b62b1069aefeb Author: Alan Baradlay Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLine.h Log Message: --- [IFC][hanging punctuation] Line::HangingContent should take "StopOrComma" trailing type https://bugs.webkit.org/show_bug.cgi?id=249695 Reviewed by Antti Koivisto. This is in preparation for supporting "hanging-punctuation: allow-end", where "A stop or comma at the end of a line conditionally hangs". (This patch also refactors Line::handleTrailingHangingContent to make it read closer to the spec language.) * Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp: (WebCore::Layout::Line::handleTrailingHangingContent): * Source/WebCore/layout/formattingContexts/inline/InlineLine.h: (WebCore::Layout::Line::HangingContent::isTrailingContentWhitespace const): (WebCore::Layout::Line::HangingContent::isTrailingContentStopOrComa const): (WebCore::Layout::Line::HangingContent::setTrailingStopOrComa): (WebCore::Layout::Line::HangingContent::resetTrailingPunctuation): Canonical link: https://commits.webkit.org/258188@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 63fdf6: [content-visibility] Make innerText take content-v...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63fdf6b4ce816181765f348ccc47e1eed8762c92 https://github.com/WebKit/WebKit/commit/63fdf6b4ce816181765f348ccc47e1eed8762c92 Author: Rob Buis Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-029-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-047-expected.txt M Source/WebCore/dom/Element.cpp M Source/WebCore/editing/TextIterator.cpp Log Message: --- [content-visibility] Make innerText take content-visibility: hidden into account https://bugs.webkit.org/show_bug.cgi?id=247196 Reviewed by Ryosuke Niwa. Make innerText take css content-visibility: hidden into account as specified here: https://w3c.github.io/csswg-drafts/css-contain/#cv-notes (Item 8). * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-047-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-080-expected.txt: * Source/WebCore/dom/Element.cpp: (WebCore::Element::innerText): * Source/WebCore/editing/TextIterator.cpp: (WebCore::TextIterator::advance): Canonical link: https://commits.webkit.org/258187@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59d042: Enable first party for cookies check on Linux
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59d042a7a674b1c547d2fc84be9d7a7a9aaca280 https://github.com/WebKit/WebKit/commit/59d042a7a674b1c547d2fc84be9d7a7a9aaca280 Author: Alex Christensen Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp Log Message: --- Enable first party for cookies check on Linux https://bugs.webkit.org/show_bug.cgi?id=247693 rdar://102154645 Reviewed by Carlos Garcia Campos. I think 256488@main resolved the problem and now the check can be done on all platforms. * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad): Canonical link: https://commits.webkit.org/258186@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb01ed: Notify networking stack that download is media rel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb01ed69cdd9a962fdd59d89bf81cc61a99416b9 https://github.com/WebKit/WebKit/commit/bb01ed69cdd9a962fdd59d89bf81cc61a99416b9 Author: Jean-Yves Avenard Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/Modules/mediasource/MediaSource.cpp M Source/WebCore/Modules/mediasource/MediaSource.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/page/MediaProducer.h M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKit/file-with-mse.html A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm Log Message: --- Notify networking stack that download is media related https://bugs.webkit.org/show_bug.cgi?id=249569 rdar://103046339 Reviewed by Youenn Fablet. Send a system notification when a networking operation is likely going to be related to media playback. For now the heuristic is rather primitive: if we have an active source buffer linked to a media element we assume that all further networking operation in the page is media related. The notification is produced by the UI process whenever a content process has an active source buffers, and when all have been deleted. * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::removeSourceBuffer): (WebCore::MediaSource::regenerateActiveSourceBuffers): (WebCore::MediaSource::notifyElementUpdateMediaState const): * Source/WebCore/Modules/mediasource/MediaSource.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateMediaState): (WebCore::HTMLMediaElement::mediaState const): * Source/WebCore/html/HTMLMediaElement.h: * Source/WebCore/page/MediaProducer.h: * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::notifyMediaNetworkingActivity): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updatePlayingMediaDidChange): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::m_webProcessWithMediaNetworkingCounter): (WebKit::WebProcessPool::webProcessWithMediaNetworkingToken const): (WebKit::WebProcessPool::updateMediaNetworkingActivity): * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::shutDown): (WebKit::WebProcessProxy::removeWebPage): (WebKit::WebProcessProxy::updateMediaNetworkingActivity): * Source/WebKit/UIProcess/WebProcessProxy.h: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaNetworkingActivity.mm: Added. (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKit/file-with-mse.html: Canonical link: https://commits.webkit.org/258185@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a03540: GPUQueue.onSubmittedWorkDone does not work in GPUP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a035407c8f5e9bbc89dc39c9f964170c0b140ea8 https://github.com/WebKit/WebKit/commit/a035407c8f5e9bbc89dc39c9f964170c0b140ea8 Author: Mike Wyrzykowski Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.messages.in Log Message: --- GPUQueue.onSubmittedWorkDone does not work in GPUProcess https://bugs.webkit.org/show_bug.cgi?id=249483 Reviewed by Kimmo Kinnunen. onSubmittedWorkDone stores the callback in a completion handler. This is not supported by stream IPC. Avoid this by making onSubmittedWorkDone non stream encodable. * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.messages.in: Canonical link: https://commits.webkit.org/258184@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ef637: [css-contain-intrinsic-size] Introduce last rememb...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ef6378c4923a62d3ea1cf172308b9a8ffd2431e https://github.com/WebKit/WebKit/commit/0ef6378c4923a62d3ea1cf172308b9a8ffd2431e Author: Cathie Chen Date: 2022-12-21 (Wed, 21 Dec 2022) Changed paths: M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/ElementRareData.cpp M Source/WebCore/dom/ElementRareData.h M Source/WebCore/rendering/RenderBox.cpp Log Message: --- [css-contain-intrinsic-size] Introduce last remembered size to Element https://bugs.webkit.org/show_bug.cgi?id=248998 Reviewed by Cameron McCormack. Per[1], when contain-intrinsic-size is with the auto-length value, the last remembered size could be its explicit intrinsic inner size. This patch introduce last remembered size to Element, and the work related to ResizeObserver will be done in the follow-up patches. [1] https://w3c.github.io/csswg-drafts/css-sizing-4/#valdef-contain-intrinsic-width-auto-length * Source/WebCore/dom/Element.cpp: (WebCore::Element::lastRememberedSize const): (WebCore::Element::setLastRememberedSize): (WebCore::Element::clearLastRememberedSize): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/ElementRareData.cpp: * Source/WebCore/dom/ElementRareData.h: (WebCore::ElementRareData::lastRememberedSize const): The lastRememberedSize is a RefPtr of ResizeObserverSize, and is stored it in ElementRareData. (WebCore::ElementRareData::setLastRememberedSize): (WebCore::ElementRareData::clearLastRememberedSize): (WebCore::ElementRareData::useTypes const): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::explicitIntrinsicInnerWidth const): Handle AutoAndLength and use lastRememberedSize if exist. (WebCore::RenderBox::explicitIntrinsicInnerHeight const): Canonical link: https://commits.webkit.org/258183@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
