[webkit-changes] [WebKit/WebKit] c7e23e: [GTK] Map munder/mover/munderover elements to Atsp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7e23e3505d35939170723b10eb4f9c1255d49eb https://github.com/WebKit/WebKit/commit/c7e23e3505d35939170723b10eb4f9c1255d49eb Author: Frédéric Wang Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: A LayoutTests/accessibility/gtk/mathml-underover-scripts-expected.txt A LayoutTests/accessibility/gtk/mathml-underover-scripts.html M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp Log Message: --- [GTK] Map munder/mover/munderover elements to Atspi::Role::Section https://bugs.webkit.org/show_bug.cgi?id=250126 Reviewed by Michael Catanzaro. Map munder/mover/munderover elements to Atspi::Role::Section as specified in the MathML AAM spec [1]. Currently, these elements are not handled by AccessibilityObjectAtspi::effectiveRole(), leading to a RELEASE_ASSERT_NOT_REACHED failure in AccessibilityObjectAtspi::role() and a release crash. Ideally, this and other MathML AAM tests should be written as cross-platform and cross-browser automated WPT tests but the infrastructure is not ready yet. So for now, just add minimal test to exercise the code fixed by this patch. * LayoutTests/accessibility/gtk/mathml-underover-scripts-expected.txt: Added. * LayoutTests/accessibility/gtk/mathml-underover-scripts.html: Added. * Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp: (WebCore::AccessibilityObjectAtspi::effectiveRole const): Map to role section. [1] https://w3c.github.io/mathml-aam Canonical link: https://commits.webkit.org/258971@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f99a53: Add support for using 'currentcolor' with color-mix()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f99a53e73e5181fada3cf04e56adfa01a2e05563 https://github.com/WebKit/WebKit/commit/f99a53e73e5181fada3cf04e56adfa01a2e05563 Author: Sam Weinig Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function.html M Source/WebCore/CMakeLists.txt M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/CSSPrimitiveValue.cpp M Source/WebCore/css/CSSPrimitiveValue.h M Source/WebCore/css/CSSUnits.cpp M Source/WebCore/css/CSSUnits.h M Source/WebCore/css/StyleColor.cpp M Source/WebCore/css/StyleColor.h M Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp A Source/WebCore/css/color/CSSResolvedColorMix.cpp A Source/WebCore/css/color/CSSResolvedColorMix.h A Source/WebCore/css/color/CSSUnresolvedColor.cpp A Source/WebCore/css/color/CSSUnresolvedColor.h A Source/WebCore/css/color/CSSUnresolvedColorMix.cpp A Source/WebCore/css/color/CSSUnresolvedColorMix.h M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/platform/graphics/ColorInterpolationMethod.cpp M Source/WebCore/platform/graphics/ColorInterpolationMethod.h M Source/WebCore/style/ColorFromPrimitiveValue.cpp Log Message: --- Add support for using 'currentcolor' with color-mix() https://bugs.webkit.org/show_bug.cgi?id=250459 Reviewed by Darin Adler. To support 'currentcolor' as the origin color in a color-mix() value, this change adds a new CSSPrimitiveValue type called CSSUnresolvedColor as a peer to the existing color value, that represents, as the name suggests, unresolved color values. In this change, CSSUnresolvedColor is only used for color-mix(), but it is implemented in a way so that we can add support for other unresolved colors like relative colors. In addition to CSSUnresolvedColor, to fully support 'currentcolor' StyleColor was updated to add a third kind in addition to Color and CurrentColor, for color-mix(). This allows for us to do late evaluation of the color-mix() in the case of a 'currentcolor' (or even in more interesting cases like an origin which is another color-mix that itself has 'currentcolor' as the origin). CSSUnresolvedColor also fixes an issue where we were not preserving calc() values for the percentages in color-mix() in the specified value serialization. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Add new files. * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::isValidCSSUnitTypeForDoubleConversion): (WebCore::isStringType): (WebCore::CSSPrimitiveValue::init): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::unitTypeString): (WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const): (WebCore::CSSPrimitiveValue::equals const): * Source/WebCore/css/CSSPrimitiveValue.h: (WebCore::isValueID): * Source/WebCore/css/CSSUnits.cpp: (WebCore::unitCategory): (WebCore::operator<<): * Source/WebCore/css/CSSUnits.h: * Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp: (WebCore::hasDoubleValue): Add new CSS_UNRESOLVED_COLOR kind. * Source/WebCore/css/StyleColor.cpp: (WebCore::StyleColor::copy): (WebCore::StyleColor::resolveColor const): (WebCore::StyleColor::isCurrentColor const): (WebCore::StyleColor::isColorMix const): (WebCore::StyleColor::resolveAbsoluteComponents): (WebCore::resolveAbsoluteComponents): (WebCore::resolveColor): (WebCore::serializationForCSS): (WebCore::operator<<): * Source/WebCore/css/StyleColor.h: (WebCore::StyleColor::StyleColor): (WebCore::StyleColor::operator=): (WebCore::StyleColor::currentColor): (WebCore::operator==): (WebCore::operator!=): (WebCore::StyleColor::operator== const): (WebCore::StyleColor::operator!= const): (WebCore::CurrentColor::operator== const): Deleted. (WebCore::CurrentColor::operator!= const): Deleted. Support a new StyleColorMix kind. Rename CurrentColor to StyleCurrentColor for consistency. * Source/WebCore/css/color/CSSResolvedColorMix.cpp: Added. (WebCore::normalizedMixPercentages): (WebCore::mixColorComponentsUsingColorInterpolationMethod): (WebCore::mix): * Source/WebCore/css/color/CSSResolvedColorMix.h: Added. CSSResolvedColorMix serves as the implementation of the final resolved color-mix(), and is used for eager mixing (in the case of the Raw variant currently used on workers) and in StyleColor when doing the final resolution. * Source/WebCore/css/color/CSSUnresolvedColor.cpp: Added. (WebCore::CSSUnresolvedColor::cssText const): (WebCore::CSSUnresolvedColor::equals const): (WebCore::CSSUnresolvedColor::createStyleColor const): * Source/WebCore/css/color/CSSUnresolvedColor.h: Added. CSSUnresolvedColor serves
[webkit-changes] [WebKit/WebKit] 5cfdac: Rename Image::hasSingleSecurityOrigin to Image::re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5cfdacb9f77cffe585529fa7a25afc82234403c9 https://github.com/WebKit/WebKit/commit/5cfdacb9f77cffe585529fa7a25afc82234403c9 Author: Matt Woodrow Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebCore/html/ImageBitmap.cpp M Source/WebCore/html/canvas/CanvasRenderingContext.cpp M Source/WebCore/html/canvas/CanvasRenderingContext.h M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/platform/graphics/BitmapImage.h M Source/WebCore/platform/graphics/GeneratedImage.h M Source/WebCore/platform/graphics/Image.h M Source/WebCore/platform/graphics/cg/PDFDocumentImage.h M Source/WebCore/svg/SVGFEImageElement.cpp M Source/WebCore/svg/SVGFEImageElement.h M Source/WebCore/svg/SVGImageElement.cpp M Source/WebCore/svg/SVGImageElement.h M Source/WebCore/svg/graphics/SVGImage.cpp M Source/WebCore/svg/graphics/SVGImage.h Log Message: --- Rename Image::hasSingleSecurityOrigin to Image::renderingTaintsOrigin. https://bugs.webkit.org/show_bug.cgi?id=250540 Reviewed by Darin Adler. There's only two entry points to this function, and one of them (CanvasRenderingContext) only calls it when the image is a SVGImage. The only interesting implementation of this (SVGImage) is not related to multiple origins (or CORS at all), but instead to SVG foreign object possibly tainting the in a different way (by drawing visited colours, spellcheck etc). This renames the function to renderingTaintsOrigin, since that more accurately reflects the behaviour. It also swaps the meaning in the process, and removes lots of overloads which aren't needed. The only (potential) behaviour change is that the ImageBitmap callsite (which didn't have an isSVGImage check) will now definitely only affect SVGImages instead of other types (which implicitly returned false for hasSingleSecurity origin by not overloading the function). I believe that was the intent of the change which added the check to the other callsite (and that returning false for !SVG was a missing impl bug), and this was just missed. * Source/WebCore/html/ImageBitmap.cpp: (WebCore::taintsOrigin): * Source/WebCore/html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::taintsOrigin): (WebCore::CanvasRenderingContext::checkOrigin): (WebCore::CanvasRenderingContext::wouldTaintOrigin): Deleted. * Source/WebCore/html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::checkOrigin): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::validateHTMLImageElement): (WebCore::WebGLRenderingContextBase::validateHTMLCanvasElement): (WebCore::WebGLRenderingContextBase::validateHTMLVideoElement): * Source/WebCore/platform/graphics/BitmapImage.h: * Source/WebCore/platform/graphics/GeneratedImage.h: * Source/WebCore/platform/graphics/Image.h: (WebCore::Image::renderingTaintsOrigin const): (WebCore::Image::hasSingleSecurityOrigin const): Deleted. * Source/WebCore/platform/graphics/cg/PDFDocumentImage.h: * Source/WebCore/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::renderingTaintsOrigin const): (WebCore::SVGFEImageElement::hasSingleSecurityOrigin const): Deleted. * Source/WebCore/svg/SVGFEImageElement.h: * Source/WebCore/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::renderingTaintsOrigin const): (WebCore::SVGImageElement::hasSingleSecurityOrigin const): Deleted. * Source/WebCore/svg/SVGImageElement.h: * Source/WebCore/svg/graphics/SVGImage.cpp: (WebCore::SVGImage::renderingTaintsOrigin const): (WebCore::SVGImage::hasSingleSecurityOrigin const): Deleted. * Source/WebCore/svg/graphics/SVGImage.h: Canonical link: https://commits.webkit.org/258969@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d318bb: WebKitGTK 2.39.4 does not build due to missing #in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d318bb461f040b90453bc4e100dcf967243ecd98 https://github.com/WebKit/WebKit/commit/d318bb461f040b90453bc4e100dcf967243ecd98 Author: Michael Catanzaro Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderVars.h Log Message: --- WebKitGTK 2.39.4 does not build due to missing #include in ANGLE https://bugs.webkit.org/show_bug.cgi?id=250689 Unreviewed build fix. * Source/ThirdParty/ANGLE/include/GLSLANG/ShaderVars.h: Canonical link: https://commits.webkit.org/258968@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] afec07: Unreviewed, reverting r258926@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: afec07b712eb45d54335f31c3066279fbfa673ea https://github.com/WebKit/WebKit/commit/afec07b712eb45d54335f31c3066279fbfa673ea Author: Commit Queue Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Unreviewed, reverting r258926@main. https://bugs.webkit.org/show_bug.cgi?id=250692 1% regression on Speedometer is probably caused by some other change Reverted changeset: "Revert 258568@main since form-associated custom element has been disabled" https://bugs.webkit.org/show_bug.cgi?id=250635 https://commits.webkit.org/258926@main Canonical link: https://commits.webkit.org/258967@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c6ef97: Unreviewed, reverting r258925@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c6ef97df4bdb6ebaa12b84c87e2502da77f4a6b5 https://github.com/WebKit/WebKit/commit/c6ef97df4bdb6ebaa12b84c87e2502da77f4a6b5 Author: Commit Queue Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: R LayoutTests/platform/win/fast/forms/state-restore-form-associated-custom-elements-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Unreviewed, reverting r258925@main. https://bugs.webkit.org/show_bug.cgi?id=250693 1% regression on Speedometer is probably caused by some other change Reverted changeset: "Unreviewed, reverting r258574@main." https://bugs.webkit.org/show_bug.cgi?id=250634 https://commits.webkit.org/258925@main Canonical link: https://commits.webkit.org/258966@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9b040: Unreviewed, reverting r258897@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9b0405cd3390ba2ebba210547c3ab2c203876e2 https://github.com/WebKit/WebKit/commit/a9b0405cd3390ba2ebba210547c3ab2c203876e2 Author: Commit Queue Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebCore/dom/CustomElementReactionQueue.cpp M Source/WebCore/dom/CustomElementReactionQueue.h Log Message: --- Unreviewed, reverting r258897@main. https://bugs.webkit.org/show_bug.cgi?id=250691 1% regression on Speedometer is probably caused by some other change Reverted changeset: "Unreviewed, reverting r258696@main." https://bugs.webkit.org/show_bug.cgi?id=250599 https://commits.webkit.org/258897@main Canonical link: https://commits.webkit.org/258965@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 300420: Unreviewed, reverting r258898@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 300420a41d05a2aca4fe3603cb4436cf6adc4879 https://github.com/WebKit/WebKit/commit/300420a41d05a2aca4fe3603cb4436cf6adc4879 Author: Commit Queue Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebCore/html/FormAssociatedCustomElement.cpp M Source/WebCore/html/ValidatedFormListedElement.cpp M Source/WebCore/html/ValidatedFormListedElement.h Log Message: --- Unreviewed, reverting r258898@main. https://bugs.webkit.org/show_bug.cgi?id=250690 1% regression on Speedometer is probably caused by some other change Reverted changeset: "Unreviewed, reverting r258621@main." https://bugs.webkit.org/show_bug.cgi?id=250600 https://commits.webkit.org/258898@main Canonical link: https://commits.webkit.org/258964@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac9669: Unreviewed, reverting r258899@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac9669ac5ad9805272db0eb6db7653c5f019d62e https://github.com/WebKit/WebKit/commit/ac9669ac5ad9805272db0eb6db7653c5f019d62e Author: Commit Queue Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: A LayoutTests/fast/forms/state-restore-form-associated-custom-elements-expected.txt A LayoutTests/fast/forms/state-restore-form-associated-custom-elements.html M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-NotSupportedError-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-form-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-labels-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-labels.html M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-setFormValue-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-validation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-validation.html M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/fieldset-elements-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/form-associated-callback-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/form-disabled-callback-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/form-elements-namedItem-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/form-reset-callback-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/label-delegatesFocus-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/attr-constructor-disabled.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/attr-constructor-disabled.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/attr-constructor-readonly.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/attr-constructor-readonly.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/attr-parser-disabled.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/attr-parser-disabled.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/attr-parser-readonly.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/attr-parser-readonly.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-form-fieldset-elements.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-form-fieldset-elements.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-form.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-form.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-move-inside-form.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-move-inside-form.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-set-form-attr.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-set-form-attr.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-setValidity.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/constructor-setValidity.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/inside-datalist.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/inside-datalist.tentative.html A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/inside-disabled-fieldset.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/upgrading/inside-disabled-fieldset.tenta
[webkit-changes] [WebKit/WebKit] 0e24ad: [WPE] Gardening `accessibility/custom-elements/tex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e24ad0de2a66991fc5e8be3703d277073b2f8e1 https://github.com/WebKit/WebKit/commit/0e24ad0de2a66991fc5e8be3703d277073b2f8e1 Author: Vitaly Dyachkov Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: A LayoutTests/platform/glib/accessibility/custom-elements/textbox-expected.txt R LayoutTests/platform/gtk/accessibility/custom-elements/textbox-expected.txt Log Message: --- [WPE] Gardening `accessibility/custom-elements/textbox.html` Unreviewed test gardening. * LayoutTests/platform/glib/accessibility/custom-elements/textbox-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/custom-elements/textbox-expected.txt. Canonical link: https://commits.webkit.org/258962@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00e89b: year 2038 problem in WebKit/Source/WTF/wtf/DateMat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00e89b0e200a9056a237a74d7315062043ebd26d https://github.com/WebKit/WebKit/commit/00e89b0e200a9056a237a74d7315062043ebd26d Author: Fujii Hironori Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WTF/wtf/DateMath.cpp Log Message: --- year 2038 problem in WebKit/Source/WTF/wtf/DateMath.cpp https://bugs.webkit.org/show_bug.cgi?id=250553 Reviewed by Darin Adler. Int32x32To64 silently truncated a 64bit time_t into a 32bit integer. * Source/WTF/wtf/DateMath.cpp: (WTF::UnixTimeToFileTime): Upated the implementation by copying the revised example. Canonical link: https://commits.webkit.org/258961@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f28556: Change notification permissions delegate method to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2855604234b9941bcc4f2132dbe96c25b2b7c24 https://github.com/WebKit/WebKit/commit/f2855604234b9941bcc4f2132dbe96c25b2b7c24 Author: Brady Eidson Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm Log Message: --- Change notification permissions delegate method to expect NSURLs instead of NSStrings https://bugs.webkit.org/show_bug.cgi?id=250432 rdar://103918987 Reviewed by Tim Horton. Makes it a bit harder for clients to do the wrong thing. * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm: (-[FirePushEventDataStoreDelegate notificationPermissionsForWebsiteDataStore:]): Canonical link: https://commits.webkit.org/258960@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e72e2b: [GStreamer] Rename video encoder
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e72e2bc70adbe5fb00f38987f82f9e1144695e7a https://github.com/WebKit/WebKit/commit/e72e2bc70adbe5fb00f38987f82f9e1144695e7a Author: Philippe Normand Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp M Source/WebCore/platform/GStreamer.cmake M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp A Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp A Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.h M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp R Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp R Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp M Tools/Scripts/webkitpy/style/checker.py Log Message: --- [GStreamer] Rename video encoder https://bugs.webkit.org/show_bug.cgi?id=250577 Reviewed by Xabier Rodriguez-Calvar. The internal GStreamer wrapper for video encoders is no longer used only for WebRTC, but also for MediaRecorder and WebCodecs. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp: * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::registerInternalVideoEncoder): * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::fillVideoRtpCapabilities): * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp: Renamed from Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp. (videoEncoderBitrateModeGetType): (videoEncoderLatencyModeGetType): (Encoders::singleton): (Encoders::registerEncoder): (Encoders::definition): (videoEncoderGetProperty): (videoEncoderSetBitrate): (videoEncoderSetEncoder): (videoEncoderFindForFormat): (videoEncoderSupportsFormat): (videoEncoderSetFormat): (videoEncoderSetProperty): (setBitrateKbitPerSec): (setBitrateBitPerSec): (createSrcPadTemplateCaps): (videoEncoderConstructed): (webkit_video_encoder_class_init): * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.h: Added. * Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp: (WebCore::MediaRecorderPrivateGStreamer::preparePipeline): * Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.h: Removed. * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: (WebCore::RealtimeOutgoingVideoSourceGStreamer::RealtimeOutgoingVideoSourceGStreamer): (WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType): * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp: (WebCore::GStreamerVideoEncoder::createEncoder): Canonical link: https://commits.webkit.org/258959@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d087dc: Revert [258946@main] Improve StringTypeAdapter tem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d087dce13acac618807110847add6fa1ffb6de2a https://github.com/WebKit/WebKit/commit/d087dce13acac618807110847add6fa1ffb6de2a Author: Žan Doberšek Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/JavaScriptCore/inspector/InjectedScriptBase.cpp M Source/WTF/wtf/text/StringConcatenate.h M Source/WTF/wtf/text/StringOperators.h M Source/WTF/wtf/text/StringView.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h Log Message: --- Revert [258946@main] Improve StringTypeAdapter templates and handling https://bugs.webkit.org/show_bug.cgi?id=250017 Unreviewed. String literals are great, in theory, with the size of the string specified right there in the type. But that size isn't a given, i.e. the literal can have an escaped null character positioned inside the string, not necessarily at the end. One way this is exhibited is by fixed-length arrays that serve as buffers for character data, which is what's causing misconstruction of the user agent string on Unix, in UserAgentGLib.cpp. This could be somewhat softly validated in the relevant StringView constructor, asserting that the result of strlen() (or an equivalent) equals the size value integrated in the type. The patch that's being reverted here will be updated to have these fixed-data arrays treated as pointers of character type, effectively returning back to enforcing strlen()-like computation of the string length. * Source/JavaScriptCore/inspector/InjectedScriptBase.cpp: (Inspector::InjectedScriptBase::makeCall): (Inspector::InjectedScriptBase::makeAsyncCall): * Source/WTF/wtf/text/StringConcatenate.h: (WTF::are8Bit): (WTF::stringTypeAdapterAccumulator): (WTF::tryMakeStringImplFromAdaptersInternal): (WTF::handleWithAdapters): (WTF::tryMakeStringFromAdapters): (WTF::tryMakeString): (WTF::makeString): (WTF::tryMakeAtomStringFromAdapters): (WTF::tryMakeAtomString): (WTF::makeAtomString): * Source/WTF/wtf/text/StringOperators.h: (WTF::StringAppend::is8Bit): (WTF::StringAppend::writeTo): (WTF::StringAppend::length): (WTF::StringAppend::is8Bit const): Deleted. (WTF::StringAppend::writeTo const): Deleted. (WTF::StringAppend::length const): Deleted. * Source/WTF/wtf/text/StringView.h: (WTF::StringView::StringView): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateNodeProperties): * Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h: Canonical link: https://commits.webkit.org/258958@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6cb040: [MQ4] "layer" is invalid as media type name
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6cb0400c49f76bb3bc77b6eb8ca36f4045d45d5e https://github.com/WebKit/WebKit/commit/6cb0400c49f76bb3bc77b6eb8ca36f4045d45d5e Author: Antti Koivisto Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-invalid-media-type-layer-002-expected.txt M Source/WebCore/css/query/MediaQueryParser.cpp Log Message: --- [MQ4] "layer" is invalid as media type name https://bugs.webkit.org/show_bug.cgi?id=250677 rdar://104297917 Reviewed by Sam Weinig. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-invalid-media-type-layer-002-expected.txt: * Source/WebCore/css/query/MediaQueryParser.cpp: (WebCore::MQ::MediaQueryParser::consumeMediaQuery): Canonical link: https://commits.webkit.org/258957@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d9cd0e: [WebRTC] Fix -Wunused-but-set-variable warnings in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9cd0e72ca7c30784f069afbc0c5617c5ff8b91d https://github.com/WebKit/WebKit/commit/d9cd0e72ca7c30784f069afbc0c5617c5ff8b91d Author: David Kilzer Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig M Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_pps_parser.cc M Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.cc A Source/ThirdParty/libwebrtc/WebKit/libwebrtc-fix-Wunused-but-set-variable.diff Log Message: --- [WebRTC] Fix -Wunused-but-set-variable warnings in the libwebrtc project https://bugs.webkit.org/show_bug.cgi?id=250622 Reviewed by Youenn Fablet. * Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig: (WK_FIXME_WARNING_CFLAGS): - Remove -Wno-unused-but-set-variable. * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_pps_parser.cc: - Add empty statements for bits_tmp and golomb_ignored variables. * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.cc: - Add empty statement for golomb_ignored variable. * Source/ThirdParty/libwebrtc/WebKit/libwebrtc-fix-Wunused-but-set-variable.diff: Add. Canonical link: https://commits.webkit.org/258956@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8fd77: Remove unused RenderListBox::valueChanged
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8fd7771b683835ba4469a6dec8d0b271f14270b https://github.com/WebKit/WebKit/commit/c8fd7771b683835ba4469a6dec8d0b271f14270b Author: Ahmad Saleem Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebCore/rendering/RenderListBox.cpp M Source/WebCore/rendering/RenderListBox.h Log Message: --- Remove unused RenderListBox::valueChanged Remove unused RenderListBox::valueChanged https://bugs.webkit.org/show_bug.cgi?id=250638 Reviewed by Alan Baradlay. This patch is to remove unused "valueChanged" function and related in header. Merge - https://src.chromium.org/viewvc/blink?view=rev&revision=169543 * Source/WebCore/rendering/RenderListBox.cpp: (RenderListBox::valueChanged): Removed * Source/WebCore/rendering/RenderListBox.h: Remove "valueChanged" Canonical link: https://commits.webkit.org/258955@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e188ce: [IFC] LineBox::inlineLevelBoxFor may return null_ptr
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e188ce4e6d0fb7a15d2c43f5081c11105b8da7b9 https://github.com/WebKit/WebKit/commit/e188ce4e6d0fb7a15d2c43f5081c11105b8da7b9 Author: Alan Baradlay Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp Log Message: --- [IFC] LineBox::inlineLevelBoxFor may return null_ptr https://bugs.webkit.org/show_bug.cgi?id=250663 Reviewed by Antti Koivisto. LineBox::inlineLevelBoxForLayoutBox() assumes it gets always called with a layoutBox present on the current line. webkit.org/b/249942 showed that it's rather easy to call this function with incorrect layoutBox (not on the current line). This patch addresses this issue by changing the return type of LineBox::inlineLevelBoxForLayoutBox from InlineLevelBox& to InlineLevelBox* and return null_ptr if the layout box cannot be found on the current line box. However this patch also extends LineBox interface with additional helper functions where the argument type makes such calls less error prone. -> parentInlineBox(const InlineLevelBox&) parentInlineBox(const Line::Run&); inlineLevelBoxFor(const Line::Run&); as many of the inlineLevelBoxForLayoutBox() call sites are actually interested in 1. the parent inline box (which we always have). 2. inline boxes based on actual runs on the line. * Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp: (WebCore::Layout::LineBox::logicalRectForTextRun const): (WebCore::Layout::LineBox::inlineLevelBoxAbsoluteTop const): (WebCore::Layout::LineBox::logicalRectForInlineLevelBox const): * Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h: (WebCore::Layout::LineBox::inlineLevelBoxFor const): (WebCore::Layout::LineBox::inlineBoxFor const): (WebCore::Layout::LineBox::parentInlineBox const): (WebCore::Layout::LineBox::inlineLevelBoxFor): (WebCore::Layout::LineBox::parentInlineBox): (WebCore::Layout::LineBox::inlineBoxFor): (WebCore::Layout::LineBox::inlineLevelBoxForLayoutBox const): Deleted. (WebCore::Layout::LineBox::inlineLevelBoxForLayoutBox): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const): (WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes): (WebCore::Layout::LineBoxBuilder::adjustInlineBoxHeightsForLineBoxContainIfApplicable): (WebCore::Layout::LineBoxBuilder::adjustOutsideListMarkersPosition): * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h: * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp: (WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const): (WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition const): (WebCore::Layout::LineBoxVerticalAligner::alignInlineLevelBoxes const): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): Canonical link: https://commits.webkit.org/258954@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f9165: [webkitcorepy] Bump certifi version
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f9165f829811152995170c3dcd70548cb0b332e https://github.com/WebKit/WebKit/commit/2f9165f829811152995170c3dcd70548cb0b332e Author: Jonathan Bedard Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/setup.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- [webkitcorepy] Bump certifi version https://bugs.webkit.org/show_bug.cgi?id=250606 rdar://104246435 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitcorepy/setup.py: Bump library version. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump library and certifi versions. Canonical link: https://commits.webkit.org/258953@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d09ec: [MQ4] Fix css/mediaqueries/negation-001.html and a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d09ec91ef71a968c3f8a23682d56dac25d60e24 https://github.com/WebKit/WebKit/commit/4d09ec91ef71a968c3f8a23682d56dac25d60e24 Author: Antti Koivisto Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/negation-001.html M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html Log Message: --- [MQ4] Fix css/mediaqueries/negation-001.html and add more 3-valued logic tests https://bugs.webkit.org/show_bug.cgi?id=250674 rdar://104296041 Reviewed by Kimmo Kinnunen. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/negation-001.html: Fix the test. The query not ((unknown) or (monochrome)) evaluates using 3-valued Kleene logic to -> not (unknown or false) -> not unknown -> unknown which in media query context doesn't match. Firefox agrees. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html: Add more tests for 3-valued logic. Firefox passes all these too. Also add a parsing test for an unknown function with extra whitespace. Canonical link: https://commits.webkit.org/258952@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 83cf78: Make it posible to start downloads without a proce...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 83cf78beac00317adb439dbe51b86f69ead8d8d9 https://github.com/WebKit/WebKit/commit/83cf78beac00317adb439dbe51b86f69ead8d8d9 Author: Carlos Garcia Campos Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h Log Message: --- Make it posible to start downloads without a process pool https://bugs.webkit.org/show_bug.cgi?id=250649 Reviewed by Youenn Fablet. In the new GLib API we plan to move the networking related APIs from WebKitWebContext (a process pool) to a new WebKitNetworkSession class. Currently downloads are actually handled by the WebsiteDataStore, the process pool is only used to use the legacy downloads client for compatibility, so we can just move the implementation to WebsiteDataStore and make WebProcessPool use it. * Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp: * Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp: (WebKit::DownloadProxyMap::createDownloadProxy): * Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::createDownloadProxy): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::download): (WebKit::WebProcessPool::resumeDownload): (WebKit::WebProcessPool::createDownloadProxy): * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::createDownloadProxy): (WebKit::WebsiteDataStore::download): (WebKit::WebsiteDataStore::resumeDownload): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: Canonical link: https://commits.webkit.org/258951@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d1eb8: Stream IPC message send tests do not test with sma...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d1eb8359a73e05a30dff4783ed765418e51e938 https://github.com/WebKit/WebKit/commit/5d1eb8359a73e05a30dff4783ed765418e51e938 Author: Kimmo Kinnunen Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebKit/Platform/IPC/StreamServerConnection.cpp M Source/WebKit/Platform/IPC/StreamServerConnection.h M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp Log Message: --- Stream IPC message send tests do not test with small connection buffer sizes https://bugs.webkit.org/show_bug.cgi?id=250669 rdar://104294217 Reviewed by Antti Koivisto. Separate the message send tests to a new test fixture and parametrize that with connection buffer size. Instantiate with 128, 256, 512, 16k sizes. With the smallest buffers, the buffer will wrap around so the tests exercise that part of the implementation. Fix a bug that affected the tests only, where unopened StreamServerConnection would assert on invalidate(). Add a test for the case. * Source/WebKit/Platform/IPC/StreamServerConnection.cpp: (IPC::StreamServerConnection::open): (IPC::StreamServerConnection::invalidate): * Source/WebKit/Platform/IPC/StreamServerConnection.h: * Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp: (TestWebKitAPI::StreamConnectionTestBase::setupBase): (TestWebKitAPI::StreamConnectionTestBase::teardownBase): (TestWebKitAPI::StreamConnectionTestBase::localReferenceBarrier): (TestWebKitAPI::TEST_F): (TestWebKitAPI::StreamMessageTest::bufferSizeLog2 const): (TestWebKitAPI::StreamMessageTest::defaultDestinationID): (TestWebKitAPI::TEST_P): (TestWebKitAPI::StreamConnectionTest::localReferenceBarrier): Deleted. (TestWebKitAPI::StreamConnectionTest::serverQueue): Deleted. Canonical link: https://commits.webkit.org/258950@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c6f463: [GStreamer][WebCodecs] Video encoding and decoding...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c6f463099606c3baba97dbc40b336aecaf495fd3 https://github.com/WebKit/WebKit/commit/c6f463099606c3baba97dbc40b336aecaf495fd3 Author: Philippe Normand Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_h264-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp8-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp9-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-createImageBitmap.any-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-drawImage.any-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp M Source/WebCore/platform/GStreamer.cmake M Source/WebCore/platform/VideoDecoder.cpp M Source/WebCore/platform/VideoEncoder.cpp M Source/WebCore/platform/VideoFrame.cpp A Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp A Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h A Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp A Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h A Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp A Source/WebCore/platform/gstreamer/GStreamerElementHarness.h M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Tools/TestWebKitAPI/PlatformGTK.cmake M Tools/TestWebKitAPI/PlatformWPE.cmake A Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp Log Message: --- [GStreamer][WebCodecs] Video encoding and decoding support https://bugs.webkit.org/show_bug.cgi?id=249972 Reviewed by Xabier Rodriguez-Calvar. The video encoder makes use of the WebRTC encoder. The video decoder relies on the platform decoder previously probed through the registry scanner. In order to have integrate the encoding and decoding at the lowest level possible we make use of a new component called GstElementHarness, so we have full control on the input and output workflow of the encoder and decoder. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_h264-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp8-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp9-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-createImageBitmap.any-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-drawImage.any-expected.txt: Added. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp: (WebCore::WebCodecsVideoFrame::create): * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/VideoDecoder.cpp: (WebCore::VideoDecoder::createLocalDecoder): * Source/WebCore/platform/VideoEncoder.cpp: (WebCore::VideoEncoder::createLocalEncoder): * Source/WebCore/platform/VideoFrame.cpp: (WebCore::VideoFrame::paintInContext): * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: Added. (WebCore::gstWorkQueue): (WebCore::GStreamerInternalVideoDecoder::create): (WebCore::GStreamerInternalVideoDecoder::postTask): (WebCore::GStreamerInternalVideoDecoder::close): (WebCore::GStreamerVideoDecoder::create): (WebCore::GStreamerVideoDecoder::GStreamerVideoDecoder): (WebCore::GStreamerVideoDecoder::~GStreamerVideoDecoder): (WebCore::GStreamerVideoDecoder::decode): (WebCore::GStreamerVideoDecoder::flush): (WebCore::GStreamerVideoDecoder::reset): (WebCore::GStreamerVideoDecoder::close): (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): (WebCore::GStreamerInternalVideoDecoder::decode): (WebCore::GStreamerInternalVideoDecoder::flush): * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h: Added. * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: Added. (WebCore::gstWorkQueue): (WebCore::GStreamerInternalVideoEncoder::create): (WebCore::GStreamerInternalVideoEncoder::postTask): (WebCore::GStreamerInternalVideoEncoder::close): (WebCore::GStreamerInternalVideoEncoder::harness const): (WebCore::GStreamerInternalVideoEncoder::isClosed const):
[webkit-changes] [WebKit/WebKit] c3fc85: [MQ4] Fix css/mediaqueries/negation-002.html WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3fc8547aea223ef2b5e780ad39cfac7a7dbe5c0 https://github.com/WebKit/WebKit/commit/c3fc8547aea223ef2b5e780ad39cfac7a7dbe5c0 Author: Antti Koivisto Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/css/query/GenericMediaQueryParser.h Log Message: --- [MQ4] Fix css/mediaqueries/negation-002.html WPT https://bugs.webkit.org/show_bug.cgi?id=250666 rdar://104291989 Reviewed by Kimmo Kinnunen. * LayoutTests/TestExpectations: * Source/WebCore/css/query/GenericMediaQueryParser.h: (WebCore::MQ::GenericMediaQueryParser::consumeCondition): '(not (foo) anything)' is invalid. (WebCore::MQ::GenericMediaQueryParser::consumeQueryInParens): Remember to consume whitespace at the end of function style unknown . Canonical link: https://commits.webkit.org/258948@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/webkitgtk-2.39.4 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a00529: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a005292b6c61d1a1877e16d6c9449cd91408283d https://github.com/WebKit/WebKit/commit/a005292b6c61d1a1877e16d6c9449cd91408283d Author: Carlos Garcia Campos Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebKit/gtk/NEWS M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. Update OptionsGTK.cmake and NEWS for 2.39.4 release * Source/WebKit/gtk/NEWS: Add release notes for 2.39.4. * Source/cmake/OptionsGTK.cmake: Bump version numbers. Canonical link: https://commits.webkit.org/258947@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 46f1a9: Improve StringTypeAdapter templates and handling
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46f1a9702080e017f95d935a7ce12a5a2a17fd34 https://github.com/WebKit/WebKit/commit/46f1a9702080e017f95d935a7ce12a5a2a17fd34 Author: Žan Doberšek Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/JavaScriptCore/inspector/InjectedScriptBase.cpp M Source/WTF/wtf/text/StringConcatenate.h M Source/WTF/wtf/text/StringOperators.h M Source/WTF/wtf/text/StringView.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h Log Message: --- Improve StringTypeAdapter templates and handling https://bugs.webkit.org/show_bug.cgi?id=250017 Reviewed by Fujii Hironori. StringConcatenate's makeString() and makeAtomString() are adjusted to accept arguments as const lvalue references, propagating them down to each StringTypeAdapter object without unnecessary copies. Similarly, the adapter objects too are handled through const lvalue references once constructed and passed on. Newly-imposed constness requires additional const qualifiers on common methods across different StringTypeAdapter specializations. The are8Bit() and stringTypeAdapterAccumulator() helper functions are simplified through using parameter packs and fold expressions to perform the necessary operations across a range of adapter objects. StringTypeAdapter specialization for StringView is moved from the StringView header into the StringConcatenate header. A new partial specialization for the StringTypeAdapter template is added, conditionally enabled if a const reference of the specified type can be used to construct a StringView object. This specialization inherits from the StringView specialization, hence a StringView is constructed for such objects. This enables removing a bunch of other StringTypeAdapter specializations. Different WTF string and impl types can be used to construct the StringView, as well as ASCIILiteral. For Vectors of character values, a corresponding Span can be implicitly constructed and is then used for StringView construction. In StringView, constructors taking in ASCIILiteral or Span are adjusted to handle const lvalue references of those objects. A new templated StringView constructor is added to handle C arrays of character data, delegating to the corresponding character-and-length StringView constructors. The const char* constructor is removed to avoid ambiguity with the constructor handling C arrays of char values, with its now functionality inlined into the fromLatin1() helper. Different static integer values can now end up generating undesired symbols when handled through references in calls to makeString() and makeAtomString(). This can be avoided by explicitly copying the passed-in value. * Source/JavaScriptCore/inspector/InjectedScriptBase.cpp: (Inspector::InjectedScriptBase::makeCall): (Inspector::InjectedScriptBase::makeAsyncCall): * Source/WTF/wtf/text/StringConcatenate.h: (WTF::are8Bit): (WTF::stringTypeAdapterAccumulator): (WTF::tryMakeStringImplFromAdaptersInternal): (WTF::handleWithAdapters): (WTF::tryMakeStringFromAdapters): (WTF::tryMakeString): (WTF::makeString): (WTF::tryMakeAtomStringFromAdapters): (WTF::tryMakeAtomString): (WTF::makeAtomString): * Source/WTF/wtf/text/StringOperators.h: (WTF::StringAppend::is8Bit const): (WTF::StringAppend::writeTo const): (WTF::StringAppend::length const): (WTF::StringAppend::is8Bit): Deleted. (WTF::StringAppend::writeTo): Deleted. (WTF::StringAppend::length): Deleted. * Source/WTF/wtf/text/StringView.h: (WTF::StringView::StringView): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateNodeProperties): * Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp: (WebKit::NetworkCache::makeVersionedDirectoryPath): Canonical link: https://commits.webkit.org/258946@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 189024: element shouldn't override FormListedElem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 189024a1815a58b3ee79bb3fe3d27dc4c6ccf82b https://github.com/WebKit/WebKit/commit/189024a1815a58b3ee79bb3fe3d27dc4c6ccf82b Author: Alexey Shvayka Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M LayoutTests/fast/forms/setCustomValidity-null-parameter.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/object-setcustomvalidity-expected.txt M Source/WebCore/html/HTMLObjectElement.h Log Message: --- element shouldn't override FormListedElement::setCustomValidity() https://bugs.webkit.org/show_bug.cgi?id=250627 Reviewed by Darin Adler. Per spec [1], element's constraint validation methods are the same as for other objects. This change removes setCustomValidity() override, allowing element's customError() to be triggered, which aligns with all the other elements: their validity states are independent of willValidate(). Removal of validationMessage() override is non-observable: the message can't be retrieved for an element that is not a candidate for constraint validation [2]. Aligns WebKit with the spec and Gecko. [1] https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-object-element:the-constraint-validation-api [2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-cva-validationmessage * LayoutTests/fast/forms/setCustomValidity-null-parameter.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/object-setcustomvalidity-expected.txt: * Source/WebCore/html/HTMLObjectElement.h: Canonical link: https://commits.webkit.org/258945@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2cae29: [Flatpak SDK] Add Flite
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2cae2987404bc4943273aa9e8aee304017d6f0c5 https://github.com/WebKit/WebKit/commit/2cae2987404bc4943273aa9e8aee304017d6f0c5 Author: ChangSeok Oh Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Tools/buildstream/elements/sdk-platform.bst A Tools/buildstream/elements/sdk/flite.bst Log Message: --- [Flatpak SDK] Add Flite https://bugs.webkit.org/show_bug.cgi?id=250668 Reviewed by Philippe Normand. This change adds Flite, a speech synthesis engine, to Flatpak SDK. * Tools/buildstream/elements/sdk-platform.bst: * Tools/buildstream/elements/sdk/flite.bst: Added. Canonical link: https://commits.webkit.org/258944@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 596466: Unreviewed. Fix GLib debug build after 258927@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5964661836644230af0c5fe3ff10d7586c0ad6d1 https://github.com/WebKit/WebKit/commit/5964661836644230af0c5fe3ff10d7586c0ad6d1 Author: Carlos Garcia Campos Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp Log Message: --- Unreviewed. Fix GLib debug build after 258927@main * Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp: (webkitDownloadCreate): Remove invalid assert now that it receives a reference. Canonical link: https://commits.webkit.org/258943@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a107c4: A no-store request should have its cache policy se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a107c4cce18136b2e307b91d2bdb9b20f651f0b5 https://github.com/WebKit/WebKit/commit/a107c4cce18136b2e307b91d2bdb9b20f651f0b5 Author: Youenn Fablet Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: A LayoutTests/fast/constructors/event-source-caching-expected.txt A LayoutTests/fast/constructors/event-source-caching.html M Source/WebCore/loader/cache/CachedResourceLoader.cpp M Source/WebCore/loader/cache/CachedResourceRequest.cpp M Source/WebCore/loader/cache/CachedResourceRequest.h Log Message: --- A no-store request should have its cache policy set to disallow even if its URL is not HTTP https://bugs.webkit.org/show_bug.cgi?id=250451 rdar://102888724 Reviewed by Chris Dumez. There is a debug assert checking fetch options cache mode when checking whether to reuse a MemoryCache cache entry. EventSource should never reuse the memory cache and set fetch options cache mode to no-store. Previously, we were only setting the cache option to disallow for HTTP URLs. We are now doing it for all URLs. * LayoutTests/fast/constructors/event-source-caching-expected.txt: Added. * LayoutTests/fast/constructors/event-source-caching.html: Added. * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource): Canonical link: https://commits.webkit.org/258942@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
