date:20230120

[webkit-changes] [WebKit/WebKit] b1c7a7: Make PlatformLayerID ProcessQualified

2023-01-20 Thread Alex Christensen

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1c7a7d92f10f5566061620b342376fdd5a48753
  
https://github.com/WebKit/WebKit/commit/b1c7a7d92f10f5566061620b342376fdd5a48753
  Author: Alex Christensen 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebCore/platform/graphics/GraphicsLayer.h
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
M 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm

  Log Message:
  ---
  Make PlatformLayerID ProcessQualified
https://bugs.webkit.org/show_bug.cgi?id=250923
rdar://104498619

Reviewed by Simon Fraser.

With site isolation we will need multiple processes compositing layers with
the same RemoteLayerTreeHost, so to prevent identifier collisions I make the
layer identifiers process qualified.  Though we technically don't need 128 bit
identifiers in a web process because a web process shouldn't need to directly
interact with layers from another process, I believe it is premature 
optimization
to add complexity to the decoding of these identifiers in order to keep the 
layer
identifiers 64 bits in the web process.

* Source/WebCore/platform/graphics/GraphicsLayer.h:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::debugName const):
(WebCore::GraphicsLayerCA::setContentsToSolidColor):
(WebCore::GraphicsLayerCA::setContentsToModel):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRects):
* 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::primaryLayerID const):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::layerIDForElement):
* Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm:
(-[WKWebView _propertiesOfLayerWithID:]):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:
(WebKit::RemoteLayerTreeNode::appendLayerDescription):

Canonical link: https://commits.webkit.org/259165@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2f177b: Fix use-after-move on navigationActionData

2023-01-20 Thread Charlie Wolfe

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f177bcd375ab4b17f8ea888a7319d1ca7bf9464
  
https://github.com/WebKit/WebKit/commit/2f177bcd375ab4b17f8ea888a7319d1ca7bf9464
  Author: Charlie Wolfe 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  Fix use-after-move on navigationActionData
https://bugs.webkit.org/show_bug.cgi?id=250826
rdar://104420066

Reviewed by Youenn Fablet and David Kilzer.

This patch fixes a use-after-move on `navigationActionData`. This is
benign, but we should still change this to fix the clang-tidy warning.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/259164@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 27ac54: Use consistent settings between WebKit/WebKitLegac...

2023-01-20 Thread Brent Fulgham

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 27ac548bef6ea93a00857b33ca9bbefa811391ef
  
https://github.com/WebKit/WebKit/commit/27ac548bef6ea93a00857b33ca9bbefa811391ef
  Author: Brent Fulgham 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html
M LayoutTests/media/ios/autoplay-only-in-main-document.html
M 
LayoutTests/media/loadedmetadata-fires-without-user-gesture-when-setRequiresUserGestureToLoadVideo-false.html
M LayoutTests/media/no-autoplay-with-user-gesture-requirement.html
M LayoutTests/media/playlist-inherits-user-gesture-expected.txt
M LayoutTests/media/playlist-inherits-user-gesture.html
M LayoutTests/media/video-add-autoplay-user-gesture-expected.txt
M LayoutTests/media/video-add-autoplay-user-gesture.html
M LayoutTests/media/video-create-with-user-gesture-expected.txt
M LayoutTests/media/video-create-with-user-gesture.html
M LayoutTests/media/video-load-require-user-gesture.html
M LayoutTests/media/video-source-before-src-expected.txt
M LayoutTests/media/video-source-before-src.html
M LayoutTests/media/video-user-gesture-tracking-expected.txt
M LayoutTests/media/video-user-gesture-tracking.html
M LayoutTests/platform/ios/media/video-source-before-src-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Modules/speech/SpeechSynthesis.cpp
M Source/WebCore/Modules/webaudio/AudioContext.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/page/Settings.yaml
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKitLegacy/mac/WebView/WebView.mm
M Source/WebKitLegacy/win/WebView.cpp

  Log Message:
  ---
  Use consistent settings between WebKit/WebKitLegacy/WebCore for audio and 
video gesture requirements
https://bugs.webkit.org/show_bug.cgi?id=250858


Reviewed by Jer Noble.

We currently have different names used for WebCore-related media gesture 
requirements, and the
preferences in WebKitLegacy and WebKit with custom code to toggle the WebCore 
bits in response
to the WebKit/WebKitLegacy settings.

Instead, we should let the generator code create the WebCore settings code, 
which will
automatically sync it when WebKit/WebKitLegacy preferences are adjusted.

Since the internal keys used to control the settings are unchanged, this should 
not
modify behavior.

* LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html: Update 
generated 'internals'
method call to match Settings.
* LayoutTests/media/ios/autoplay-only-in-main-document.html: Ditto.
* 
LayoutTests/media/loadedmetadata-fires-without-user-gesture-when-setRequiresUserGestureToLoadVideo-false.html:
 Ditto.
* LayoutTests/media/no-autoplay-with-user-gesture-requirement.html: Ditto.
* LayoutTests/media/playlist-inherits-user-gesture-expected.txt: Ditto.
* LayoutTests/media/playlist-inherits-user-gesture.html: Ditto.
* LayoutTests/media/video-add-autoplay-user-gesture-expected.txt: Ditto.
* LayoutTests/media/video-add-autoplay-user-gesture.html: Ditto.
* LayoutTests/media/video-create-with-user-gesture-expected.txt: Ditto.
* LayoutTests/media/video-create-with-user-gesture.html: Ditto.
* LayoutTests/media/video-load-require-user-gesture.html: Ditto.
* LayoutTests/media/video-source-before-src-expected.txt: Ditto.
* LayoutTests/media/video-source-before-src.html: Ditto.
* LayoutTests/media/video-user-gesture-tracking-expected.txt: Ditto.
* LayoutTests/media/video-user-gesture-tracking.html: Ditto.
* LayoutTests/platform/ios/media/video-source-before-src-expected.txt: Ditto.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
* Source/WebCore/Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::requiresUserGestureForAudioPlayback const):
(WebCore::Document::requiresUserGestureForVideoPlayback const):
(WebCore::Document::audioPlaybackRequiresUserGesture const): Deleted.
(WebCore::Document::videoPlaybackRequiresUserGesture const): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::initializeMediaSession):
(WebCore::HTMLMediaElement::updateRateChangeRestrictions):
* Source/WebCore/page/Settings.yaml:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Update for generated Settings labels.
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Ditto.
* Source/WebKitLegacy/win/WebView.cpp:
(WebView::notifyPreferencesChanged): Ditto.

Canonical link: https://commits.webkit.org/259163@main


___
webkit-change

[webkit-changes] [WebKit/WebKit] 0bba95: [Gardening]: [ macOS ] fast/canvas/canvas-scale-st...

2023-01-20 Thread Karl Rackler

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bba959287c86f1fa51ef823cc47c6a168cf4ebe
  
https://github.com/WebKit/WebKit/commit/0bba959287c86f1fa51ef823cc47c6a168cf4ebe
  Author: Karl Rackler 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M 
LayoutTests/platform/mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt

  Log Message:
  ---
  [Gardening]: [ macOS ] fast/canvas/canvas-scale-strokePath-shadow.html is a 
consistent failure
https://bugs.webkit.org/show_bug.cgi?id=250928
rdar://104502985

Unreviewed test gardening.

Re-baseline.

* 
LayoutTests/platform/mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt:

Canonical link: https://commits.webkit.org/259162@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4dae65: [JSC] Remove Wasm::PinnedRegisterInfo

2023-01-20 Thread Yusuke Suzuki

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dae653b23bef55b7cb3cd3b4f74cbd9e53208af
  
https://github.com/WebKit/WebKit/commit/4dae653b23bef55b7cb3cd3b4f74cbd9e53208af
  Author: Yusuke Suzuki 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
M Source/JavaScriptCore/jit/GPRInfo.h
M Source/JavaScriptCore/jit/RegisterSet.cpp
M Source/JavaScriptCore/jit/RegisterSet.h
M Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp
M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp
M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h
M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmBinding.cpp
M Source/JavaScriptCore/wasm/WasmMemoryInformation.cpp
M Source/JavaScriptCore/wasm/WasmMemoryInformation.h
M Source/JavaScriptCore/wasm/WasmOperations.cpp
M Source/JavaScriptCore/wasm/js/JSToWasm.cpp
M Source/JavaScriptCore/wasm/js/WasmToJS.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp

  Log Message:
  ---
  [JSC] Remove Wasm::PinnedRegisterInfo
https://bugs.webkit.org/show_bug.cgi?id=250920
rdar://104496000

Reviewed by Mark Lam.

This patch removes Wasm::PinnedRegisterInfo since we no longer have TLS version.
So, these register information can be defined at compile time. We should just 
define them in GPRInfo,
easy to read what is specified in each architecture.

* Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::loadWasmContextInstance):
(JSC::AssemblyHelpers::storeWasmContextInstance):
* Source/JavaScriptCore/jit/GPRInfo.h:
* Source/JavaScriptCore/jit/RegisterSet.cpp:
(JSC::RegisterSetBuilder::wasmPinnedRegisters):
* Source/JavaScriptCore/jit/RegisterSet.h:
* Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h:
(JSC::Wasm::ExpressionType>::AirIRGeneratorBase):
(JSC::Wasm::ExpressionType>::restoreWebAssemblyGlobalState):
(JSC::Wasm::ExpressionType>::addCall):
(JSC::Wasm::ExpressionType>::emitIndirectCall):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::emitIndirectCall):
(JSC::Wasm::B3IRGenerator::addCall):
* Source/JavaScriptCore/wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):
* Source/JavaScriptCore/wasm/WasmMemoryInformation.cpp:
(JSC::Wasm::PinnedRegisterInfo::get): Deleted.
(JSC::Wasm::PinnedRegisterInfo::PinnedRegisterInfo): Deleted.
* Source/JavaScriptCore/wasm/WasmMemoryInformation.h:
(JSC::Wasm::PinnedRegisterInfo::toSave const): Deleted.
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/wasm/js/JSToWasm.cpp:
(JSC::Wasm::marshallJSResult):
(JSC::Wasm::createJSToWasmWrapper):
* Source/JavaScriptCore/wasm/js/WasmToJS.cpp:
(JSC::Wasm::materializeImportJSCell):
(JSC::Wasm::wasmToJS):
* Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::calleeSaves const):
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

Canonical link: https://commits.webkit.org/259161@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dee20c: [Gardening]: [ New Test ] (245422@main): [ iOS ] i...

2023-01-20 Thread Karl Rackler

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dee20c9aeaf32374c041a6cc469d44a5916bd9bc
  
https://github.com/WebKit/WebKit/commit/dee20c9aeaf32374c041a6cc469d44a5916bd9bc
  Author: Karl Rackler 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-selection-expected.txt

  Log Message:
  ---
  [Gardening]: [ New Test ] (245422@main): [ iOS ] 
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-ancestor-is-inert.html
 is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=250925
rdar://104500475

Unreviewed test gardening.

Re-baseline test.

* 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-selection-expected.txt:

Canonical link: https://commits.webkit.org/259160@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] baa539: imported/w3c/web-platform-tests/mimesniff/mime-typ...

2023-01-20 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: baa5398261183ae8dc22b4629002a14fbb5f312e
  
https://github.com/WebKit/WebKit/commit/baa5398261183ae8dc22b4629002a14fbb5f312e
  Author: Chris Dumez 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/mimesniff/mime-types/resources/mime-charset.py
M LayoutTests/platform/ios-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  
imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html
  is flaky
https://bugs.webkit.org/show_bug.cgi?id=250917
rdar://99409762

Reviewed by Tim Nguyen.

imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html
is flaky on Cocoa ports due to loads intermittently failing with a
cfurlErrorNetworkConnectionLost error.

I shown the logs to the CFNetwork team and the error occurs when trying to reuse
connections. It seems the server doesn't support reusing connection and we reach
a retry limit in CFNetwork (rdar://100873042).

I believe the reason we're unable to reuse the connection is because the python
script uses `response.close_connection = True`. The recommendation from the
CFNetwork team is for the python script to also send the `Connection: close`
header so that CFNetwork doesn't attempt to reuse it.

I tried the suggested change and it seems to address the flakiness locally.

* 
LayoutTests/imported/w3c/web-platform-tests/mimesniff/mime-types/resources/mime-charset.py:
(main):

Canonical link: https://commits.webkit.org/259159@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b348ce: [LBSE] Do not relayout on dynamic transform change...

2023-01-20 Thread Nikolas Zimmermann

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b348ce7635b6efa824493df9ac2b67716a4c95c6
  
https://github.com/WebKit/WebKit/commit/b348ce7635b6efa824493df9ac2b67716a4c95c6
  Author: Nikolas Zimmermann 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M LayoutTests/platform/mac-ventura-wk2-lbse-text/TestExpectations
M Source/WebCore/rendering/RenderLayerModelObject.cpp
M Source/WebCore/rendering/RenderLayerModelObject.h
M Source/WebCore/svg/SVGGraphicsElement.cpp

  Log Message:
  ---
  [LBSE] Do not relayout on dynamic transform changes, if necessary.
https://bugs.webkit.org/show_bug.cgi?id=249141

Reviewed by Rob Buis.

The legacy SVG engine always had to perform relayouts when the transform
of an element changed (up to the containing block, stopping at RenderSVGRoot
boundary in case of mixed SVG/HTML documents). Container position and sizes
were affected by the transformations of the descendants. That's no longer the
case in LBSE, which follows CSS/HTML style of making transformations a paint
effect, not inducing costly relayouts.

However this only works if SVG  elements are not involved: SVG text
always needs a relayout, as the "screen font size scaling factor" depends on
the CTM of the transformed element (all transformations from target element
up to RenderSVGRoot enter the calculation).

Therefore add the necessary code to figure out if a relayout is unavoidable
('xScale()' / 'yScale()' of involved matrices changed --> relayout text).
For translations, etc. a relayout is unncessary, as the scaling factor cannot
change. That's the only optimization we can apply for text at present.

For all other shapes, images, etc. this is an important optimization.

Covered by existing tests, introduces one regression, marked in 
TestExpectations.
Currently this change Breaks svg/animations/list-wrapper-assertion.svg in LBSE,
webkit.org/b/249140 will fix it in a follow-up patch.

* LayoutTests/platform/mac-ventura-wk2-lbse-text/TestExpectations:
 Mark svg/animations/list-wrapper-assertion.svg as failing for the moment.
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::repaintOrRelayoutAfterSVGTransformChange):
Introduce helper function for SVG either update transform and repaint or 
relayout
* Source/WebCore/rendering/RenderLayerModelObject.h:
* Source/WebCore/svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::svgAttributeChanged):
Use new repaintOrRelayoutAfterSVGTransformChange() method, when LBSE is 
activated.

Canonical link: https://commits.webkit.org/259158@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d04e38: [Gardening]: REGRESSION (256863@main): [ iOS ] imp...

2023-01-20 Thread Karl Rackler

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d04e38cdcd325ee963f7ab8add7c8c9cf8951a09
  
https://github.com/WebKit/WebKit/commit/d04e38cdcd325ee963f7ab8add7c8c9cf8951a09
  Author: Karl Rackler 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (256863@main): [ iOS ] 
imported/w3c/web-platform-tests/webstorage/storage_local_window_open.window.html
 is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=250922
rdar://104498135

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/259157@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3a9519: Updating expectations for fast/text/khmer-lao-font...

2023-01-20 Thread EWS

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a95196448a44d0b61cdd5e4825c22328cf90b26
  
https://github.com/WebKit/WebKit/commit/3a95196448a44d0b61cdd5e4825c22328cf90b26
  Author: Dawn Flores 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  Updating expectations for fast/text/khmer-lao-font.html
https://bugs.webkit.org/show_bug.cgi?id=250921
rdar://104497095

Unreviewed test gardening..

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/259156@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f39ac: [macOS] Adjust IOKit message filter in the WebCont...

2023-01-20 Thread Per Arne Vollan

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f39acd5d511b9b48d7681413534d6d14f8117e5
  
https://github.com/WebKit/WebKit/commit/5f39acd5d511b9b48d7681413534d6d14f8117e5
  Author: Per Arne Vollan 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  [macOS] Adjust IOKit message filter in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=250526
rdar://96179312

Reviewed by Geoffrey Garen.

Adjust IOAccelerator message filter in the WebContent filter on macOS. This 
adjustment will not weaken the sandbox,
since this filtering is now enabled elsewhere with the restricted GPU 
entitlement.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/259155@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9770e5: [GARDENING] [ iOS Release arm64 ] css3/filters/eff...

2023-01-20 Thread btashawn

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9770e5c864b49b94e09603958ae09a12a93dce19
  
https://github.com/WebKit/WebKit/commit/9770e5c864b49b94e09603958ae09a12a93dce19
  Author: Bri Harris 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [GARDENING] [ iOS Release arm64 ] css3/filters/effect-contrast-hw.html is a 
constant image failure (250885)
https://bugs.webkit.org/show_bug.cgi?id=250885
rdar://problem/104456051

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/259154@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c959e: Revert 9c2ad9a13f93. rdar://problem/103003585

2023-01-20 Thread Alex Christensen

  Branch: refs/heads/safari-7615.1.18-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c959ec15e5044422bec220467606222cbcb962d
  
https://github.com/WebKit/WebKit/commit/8c959ec15e5044422bec220467606222cbcb962d
  Author: Alan Coon 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp
R Source/WebKit/Shared/LoadedWebArchive.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm

  Log Message:
  ---
  Revert 9c2ad9a13f93. rdar://problem/103003585

This reverts commit 8907b7a225ed08e647c76120b08a6ac66e64c6ac.

Canonical link: https://commits.webkit.org/258608.25@safari-7615.1.18-branch


  Commit: 897199a224682896f2a7b641ddbf6887856356e4
  
https://github.com/WebKit/WebKit/commit/897199a224682896f2a7b641ddbf6887856356e4
  Author: Chris Dumez 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  Cherry-pick 696c77d0b3f0. rdar://problem/103382619

Potential crash under WebPageProxy::continueNavigationInNewProcess()
https://bugs.webkit.org/show_bug.cgi?id=250404
rdar://103382619

Reviewed by Alex Christensen.

Make sure the navigation and m_mainframe are still valid after receiving
the async response to the NetworkProcess::AddAllowedFirstPartyForCookies
IPC. We would previously crash on a null dereference of m_mainFrame in
some cases.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):

Canonical link: https://commits.webkit.org/258750@main

Canonical link: https://commits.webkit.org/258608.26@safari-7615.1.18-branch


  Commit: 07563f7fb7a1a15023a32638bdbf4b3ed3bc2160
  
https://github.com/WebKit/WebKit/commit/07563f7fb7a1a15023a32638bdbf4b3ed3bc2160
  Author: Alex Christensen 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp
A Source/WebKit/Shared/LoadedWebArchive.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm

  Log Message:
  ---
  Cherry-pick 9c2ad9a13f93. rdar://problem/103003585

WebArchive content should not terminate web process when accessing cookies
https://bugs.webkit.org/show_bug.cgi?id=250537
rdar://103003585

Reviewed by Chris Dumez.

There are 3 different ways I'm aware of to load WebArchives.  All of them 
needed fixing.
When we load a web archive, it is only parsed in the web process, which is 
the only place
we can find out what domain it was originally fetched from, which is 
contained inside the
web archive data, which only has a way to parse it in its entirety.  Rather 
than parse
the whole thing in the UI process or buffer it in the network process 
memory then parse it,
I just disable cookie domain checks when a web archive has been loaded, 
which is rare.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::maybeCreateArchive):
* Source/WebCore/loader/FrameLoaderClient.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::allowCookieAccessForWebArchive):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::addAllowedFirstPartyForCookies):
(WebKit::NetworkProcess::webProcessWillLoadWebArchive):
(WebKit::NetworkProcess::webProcessDidLoadWebArchive):
(WebKit::NetworkProcess::allowsFirstPartyForCookies):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveMainResourceResponse):
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::ensureSWServer):

[webkit-changes] [WebKit/WebKit]

2023-01-20 Thread Alan Coon

  Branch: refs/tags/WebKit-7615.1.16.1.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e5827: Clean up NavigationActionData initialization in We...

2023-01-20 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e5827804d07269183b5f88e856672ae04dc810b
  
https://github.com/WebKit/WebKit/commit/3e5827804d07269183b5f88e856672ae04dc810b
  Author: Chris Dumez 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

  Log Message:
  ---
  Clean up NavigationActionData initialization in 
WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction()
https://bugs.webkit.org/show_bug.cgi?id=250846

Reviewed by Alex Christensen.

* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/259153@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 83a1bc: [JSC][armv7] Use the correct calling convention fo...

2023-01-20 Thread jjgriego

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83a1bc69e51b312580fb05cb9fb683cc801ae47e
  
https://github.com/WebKit/WebKit/commit/83a1bc69e51b312580fb05cb9fb683cc801ae47e
  Author: Joseph Griego 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp

  Log Message:
  ---
  [JSC][armv7] Use the correct calling convention for `operationWasmRethrow`
https://bugs.webkit.org/show_bug.cgi?id=250588

Reviewed by Mark Lam.

https://github.com/WebKit/WebKit/pull/8523 changed the signature of some runtime
wasm operations, but incorrectly translated these changes for the arm32 calling
convention, breaking some tests.

Changes to other wasm operations were covered by the platform-specific
`emitCCall`, but calls to `operationWasmRethrow` are not emitted this way.

(The arm32 calling convention requires that 64-bit arguments get passed starting
in an even-numbered registers, potentially causing an odd-numbered register to
be unused in the call, in this case, `r1/argumentGPR1`)

* Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp:
(JSC::Wasm::AirIRGenerator32::addRethrow):

Canonical link: https://commits.webkit.org/259152@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8eeac5: [macOS] media/audio-session-category.html is a fla...

2023-01-20 Thread youennf

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8eeac5b475965a5a9751af411712676794998c60
  
https://github.com/WebKit/WebKit/commit/8eeac5b475965a5a9751af411712676794998c60
  Author: Youenn Fablet 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M LayoutTests/media/audio-session-category-expected.txt
M LayoutTests/media/audio-session-category.html
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [macOS] media/audio-session-category.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=250784
rdar://problem/104392470

Reviewed by Eric Carlson.

The test is failing on release bots, instead of checking synchronously an audio 
session category,
we now wait for MediaPlayback category.

* LayoutTests/media/audio-session-category-expected.txt:
* LayoutTests/media/audio-session-category.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/259151@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 24cb5e: A MediaStreamTrack ended due to a capture failure ...

2023-01-20 Thread youennf

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24cb5e2314983e6fc5b4abdd24ff769bb181f617
  
https://github.com/WebKit/WebKit/commit/24cb5e2314983e6fc5b4abdd24ff769bb181f617
  Author: Youenn Fablet 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h

  Log Message:
  ---
  A MediaStreamTrack ended due to a capture failure - When using Airpods
https://bugs.webkit.org/show_bug.cgi?id=232835
rdar://problem/85424679

Reviewed by Eric Carlson.

Doing some manual testing, we are reconfiguring when a BT headset gets enabled 
and it is being used as the default outpt.
In that case, it sometimes takes 5 seconds on some devices to do the 
reconfiguration.
This might be due to the BT headset just starting.
Increasing from 10 seconds to 20 seconds the capture verification timer to 
ensure we are not failing capture in that case.

* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h:

Canonical link: https://commits.webkit.org/259150@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 021a45: [WGSL] Add pass to rewrite entry points to be comp...

2023-01-20 Thread Tadeu Zagallo

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 021a45c18eba49cfc45b5cad694f05095c138414
  
https://github.com/WebKit/WebKit/commit/021a45c18eba49cfc45b5cad694f05095c138414
  Author: Tadeu Zagallo 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebGPU/WGSL/AST/ASTAttribute.h
M Source/WebGPU/WGSL/AST/ASTBuiltinAttribute.h
M Source/WebGPU/WGSL/AST/ASTCallableExpression.h
M Source/WebGPU/WGSL/AST/ASTForward.h
M Source/WebGPU/WGSL/AST/ASTFunctionDecl.h
M Source/WebGPU/WGSL/AST/ASTNode.h
M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp
M Source/WebGPU/WGSL/AST/ASTStringDumper.h
M Source/WebGPU/WGSL/AST/ASTStructureDecl.h
M Source/WebGPU/WGSL/AST/ASTTypeDecl.h
M Source/WebGPU/WGSL/AST/ASTVariableDecl.h
M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
M Source/WebGPU/WGSL/AST/ASTVisitor.h
A Source/WebGPU/WGSL/EntryPointRewriter.cpp
A Source/WebGPU/WGSL/EntryPointRewriter.h
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
A Source/WebGPU/WGSL/PhaseTimer.h
A Source/WebGPU/WGSL/ResolveTypeReferences.cpp
A Source/WebGPU/WGSL/ResolveTypeReferences.h
M Source/WebGPU/WGSL/WGSL.cpp
M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp
M Websites/webkit.org/demos/webgpu/scripts/hello-triangle.js

  Log Message:
  ---
  [WGSL] Add pass to rewrite entry points to be compatible with Metal
https://bugs.webkit.org/show_bug.cgi?id=250832


Reviewed by Myles C. Maxfield.

For entry point function, builtin inputs contained in structs must be hoisted
into function parameters, and any non-builtin parameters must be moved into a
`stage_in` struct.

The implementation can't quite handle absolutely every use case yet, but the
patch was getting pretty large so I thought I pause here and commit something
that works.

A couple other things had to happen to get this initial implementation working:
- I needed some basic type information, so I added a very rudimentary pass to
  resolve type names and a new struct type.
- I also had to modify the AST to use `Ref`/`RefPtr` instead of 
`UniqueRef`/`unique_ptr`
  for types, since we need to be able to copy nodes when moving parameters 
around.
- Fixed a couple small serialization bugs with missing semicolons in 
MetalFunctionWriter
  and added serialization for matrix types.

* Source/WebGPU/WGSL/AST/ASTAttribute.h:
* Source/WebGPU/WGSL/AST/ASTBuiltinAttribute.h:
* Source/WebGPU/WGSL/AST/ASTCallableExpression.h:
* Source/WebGPU/WGSL/AST/ASTForward.h:
* Source/WebGPU/WGSL/AST/ASTFunctionDecl.h:
* Source/WebGPU/WGSL/AST/ASTNode.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
(WGSL::AST::StringDumper::visit):
* Source/WebGPU/WGSL/AST/ASTStringDumper.h:
* Source/WebGPU/WGSL/AST/ASTStructureDecl.h:
* Source/WebGPU/WGSL/AST/ASTTypeDecl.h:
(WGSL::AST::ParameterizedType::ParameterizedType):
(isType):
* Source/WebGPU/WGSL/AST/ASTVariableDecl.h:
* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::Visitor::visit):
* Source/WebGPU/WGSL/AST/ASTVisitor.h:
* Source/WebGPU/WGSL/EntryPointRewriter.cpp: Added.
(WGSL::EntryPointRewriter::EntryPointRewriter):
(WGSL::EntryPointRewriter::getResolvedType):
(WGSL::EntryPointRewriter::rewrite):
(WGSL::EntryPointRewriter::collectParameters):
(WGSL::EntryPointRewriter::constructInputStruct):
(WGSL::EntryPointRewriter::materialize):
(WGSL::EntryPointRewriter::visit):
(WGSL::EntryPointRewriter::appendBuiltins):
(WGSL::RewriteEntryPoints::RewriteEntryPoints):
(WGSL::RewriteEntryPoints::visit):
(WGSL::rewriteEntryPoints):
* Source/WebGPU/WGSL/EntryPointRewriter.h: Added.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::parseAttribute):
(WGSL::Parser::parseTypeDecl):
(WGSL::Parser::parseTypeDeclAfterIdentifier):
(WGSL::Parser::parseArrayType):
(WGSL::Parser::parseVariableDeclWithAttributes):
(WGSL::Parser::parseFunctionDecl):
(WGSL::Parser::parseStatement):
(WGSL::Parser::parseUnaryExpression):
(WGSL::Parser::parsePrimaryExpression):
(WGSL::Parser::parseCoreLHSExpression):
* Source/WebGPU/WGSL/ParserPrivate.h:
* Source/WebGPU/WGSL/PhaseTimer.h: Added.
(WGSL::dumpASTIfNeeded):
(WGSL::dumpASTAfterParsingIfNeeded):
(WGSL::dumpASTBetweenEachPassIfNeeded):
(WGSL::dumpASTAtEndIfNeeded):
(WGSL::logPhaseTimes):
(WGSL::PhaseTimer::PhaseTimer):
(WGSL::PhaseTimer::~PhaseTimer):
* Source/WebGPU/WGSL/ResolveTypeReferences.cpp: Added.
(WGSL::ResolveTypeReferences::ResolveTypeReferences):
(WGSL::ResolveTypeReferences::visit):
(WGSL::resolveTypeReferences):
* Source/WebGPU/WGSL/ResolveTypeReferences.h: Added.
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::prepare):
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp:
(TestWGSLAPI::TEST):
* Websites/webkit.org/demos/webgpu/scripts/hello-triangle.

[webkit-changes] [WebKit/WebKit] e6ff9f: Updating allowed fonts in lockdown mode

2023-01-20 Thread Vitor Roriz

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6ff9ff596a32c757bffe00b5f161d89f97a2b1c
  
https://github.com/WebKit/WebKit/commit/e6ff9ff596a32c757bffe00b5f161d89f97a2b1c
  Author: Vitor Roriz 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebCore/loader/cache/AllowedFonts.cpp

  Log Message:
  ---
  Updating allowed fonts in lockdown mode
https://bugs.webkit.org/show_bug.cgi?id=250770
rdar://102435997

Reviewed by Brent Fulgham.

Adding new target binaries to allowed fonts in lockdown mode.
Targeting fonts:

- AppleIcon fonts hosted by Apple's internal build website.
- font-awesome 4.7.0, 3.2.1, 2.0.0 and 1.0.0 from https://fontawesome.com

* Source/WebCore/loader/cache/AllowedFonts.cpp:
(WebCore::allowedFontHashesInLockdownMode):

Canonical link: https://commits.webkit.org/259148@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 059da5: AX: VoiceOver hangs in Safari when selecting "Sign...

2023-01-20 Thread Tyler Wilcock

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 059da518e6c00d18d6305e7864251f16eeefac87
  
https://github.com/WebKit/WebKit/commit/059da518e6c00d18d6305e7864251f16eeefac87
  Author: Tyler Wilcock 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp

  Log Message:
  ---
  AX: VoiceOver hangs in Safari when selecting "Sign in with Apple" on 
kickstarter.com and elsewhere
https://bugs.webkit.org/show_bug.cgi?id=250867
rdar://problem/104449619

Reviewed by Chris Fleizach.

"Sign in with Apple" on kickstarter.com triggers sync IPC through
WebChromeClient::createWindow. Depending on how the client handles this
request, this IPC may not return for an arbitrary amount of time. In
this case, Safari opens a native dialog, and the sync IPC does not
return until the dialog is closed.

This causes web content to become unresponsive to VoiceOver because the
main-thread is hung. This patch fixes this by using 
IPC::SendSyncOption::InformPlatformProcessWillSuspend
to tell VoiceOver we will become unresponsive until the IPC completes.

I couldn't find a good way to test this in an automated fashion.

* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):

Canonical link: https://commits.webkit.org/259147@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f6c162: Versioning.

2023-01-20 Thread MyahCobbs

  Branch: refs/heads/safari-7615.1.18-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: f6c1625e89549870a7c0073ed4e1fefdde4d185c
  
https://github.com/WebKit/WebKit/commit/f6c1625e89549870a7c0073ed4e1fefdde4d185c
  Author: Myah Cobbs 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7615.1.18.7

Canonical link: https://commits.webkit.org/258608.24@safari-7615.1.18-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8984da: Page scrolls more than one screenful when pressing...

2023-01-20 Thread Richard Robinson

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8984da7400104156ff59e1b95adee4349f22a451
  
https://github.com/WebKit/WebKit/commit/8984da7400104156ff59e1b95adee4349f22a451
  Author: Richard Robinson 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebCore/editing/EditorCommand.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/EventHandler.h
M Source/WebCore/platform/KeyboardScrollingAnimator.cpp
M Source/WebCore/platform/KeyboardScrollingAnimator.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  ---
  Page scrolls more than one screenful when pressing Space or Fn+Down
https://bugs.webkit.org/show_bug.cgi?id=250598
rdar://104152802

Reviewed by Simon Fraser.

Before event handler driven smooth keyboard scrolling, pressing and holding the
spacebar or page up/down keys would do the following sequence of actions:

1. Scroll down the page by a "screenful".
2. On Cocoa platforms, the scrolling mechanism would wait until the 
`keyRepeatInterval`
has passed.
3. After the interval has passed, it would continue consistently page scrolling 
until
the key is released.

With the introduction of event handler driven smooth keyboard scrolling, step 
two
was omitted. However, because smooth scrolling was slower than previously, the 
behavior
was effectively unchanged, as the slowness of the scrolling compensated for 
what would
have been the key repeat interval.

After https://github.com/WebKit/WebKit/pull/8318, smooth scrolling was adjusted 
which
caused its velocity to increase. As a result, the lack of a delay was now 
noticable,
and page scrolling would scroll more than a "screenful" unless preisely one key 
event was sent.

This PR adjusts smooth scrolling such that the smooth keyboard scroll animation 
only
starts after the `keyRepeatInterval`, with the first part of the entire scroll 
behaving the
same as it did prior to smooth keyboard scrolling.

Note that this will apply to only spacebar and page up / down scrolling, and 
not arrow key
scrolling.

* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::executeScrollPageBackward):
(WebCore::executeScrollPageForward):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::defaultKeyboardScrollEventHandler):
(WebCore::EventHandler::defaultPageUpDownEventHandler):
(WebCore::EventHandler::defaultSpaceEventHandler):
(WebCore::EventHandler::beginKeyboardScrollGesture):
(WebCore::EventHandler::startKeyboardScrollAnimationOnDocument):
(WebCore::EventHandler::startKeyboardScrollAnimationOnRenderBoxLayer):
(WebCore::EventHandler::startKeyboardScrollAnimationOnRenderBoxAndItsAncestors):
(WebCore::EventHandler::startKeyboardScrollAnimationOnEnclosingScrollableContainer):
(WebCore::EventHandler::keyboardScrollRecursively):
(WebCore::EventHandler::keyboardScroll):
* Source/WebCore/page/EventHandler.h:
* Source/WebCore/platform/KeyboardScrollingAnimator.cpp:
(WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):
* Source/WebCore/platform/KeyboardScrollingAnimator.h:

Canonical link: https://commits.webkit.org/259146@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8907b7: Cherry-pick 9c2ad9a13f93. rdar://problem/103003585

2023-01-20 Thread Alex Christensen

  Branch: refs/heads/safari-7615.1.18-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 8907b7a225ed08e647c76120b08a6ac66e64c6ac
  
https://github.com/WebKit/WebKit/commit/8907b7a225ed08e647c76120b08a6ac66e64c6ac
  Author: Alex Christensen 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp
A Source/WebKit/Shared/LoadedWebArchive.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm

  Log Message:
  ---
  Cherry-pick 9c2ad9a13f93. rdar://problem/103003585

WebArchive content should not terminate web process when accessing cookies
https://bugs.webkit.org/show_bug.cgi?id=250537
rdar://103003585

Reviewed by Chris Dumez.

There are 3 different ways I'm aware of to load WebArchives.  All of them 
needed fixing.
When we load a web archive, it is only parsed in the web process, which is 
the only place
we can find out what domain it was originally fetched from, which is 
contained inside the
web archive data, which only has a way to parse it in its entirety.  Rather 
than parse
the whole thing in the UI process or buffer it in the network process 
memory then parse it,
I just disable cookie domain checks when a web archive has been loaded, 
which is rare.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::maybeCreateArchive):
* Source/WebCore/loader/FrameLoaderClient.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::allowCookieAccessForWebArchive):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::addAllowedFirstPartyForCookies):
(WebKit::NetworkProcess::webProcessWillLoadWebArchive):
(WebKit::NetworkProcess::webProcessDidLoadWebArchive):
(WebKit::NetworkProcess::allowsFirstPartyForCookies):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveMainResourceResponse):
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::ensureSWServer):
* Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
(WebKit::WebSharedWorkerServer::createContextConnection):
* Source/WebKit/Shared/LoadedWebArchive.h: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::allowCookieAccessForWebArchive):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:

Canonical link: https://commits.webkit.org/258901@main

Canonical link: https://commits.webkit.org/258608.23@safari-7615.1.18-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 88a073: Add support for using 'currentcolor' with color-mix()

2023-01-20 Thread Sam Weinig

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88a0736c2c2d79064ae781e6ef99e4e5abbf692f
  
https://github.com/WebKit/WebKit/commit/88a0736c2c2d79064ae781e6ef99e4e5abbf692f
  Author: Sam Weinig 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function.html
M Source/WebCore/CMakeLists.txt
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/css/CSSPrimitiveValue.h
M Source/WebCore/css/CSSUnits.cpp
M Source/WebCore/css/CSSUnits.h
M Source/WebCore/css/StyleColor.cpp
M Source/WebCore/css/StyleColor.h
M Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp
A Source/WebCore/css/color/CSSResolvedColorMix.cpp
A Source/WebCore/css/color/CSSResolvedColorMix.h
A Source/WebCore/css/color/CSSUnresolvedColor.cpp
A Source/WebCore/css/color/CSSUnresolvedColor.h
A Source/WebCore/css/color/CSSUnresolvedColorMix.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/platform/graphics/ColorInterpolationMethod.cpp
M Source/WebCore/platform/graphics/ColorInterpolationMethod.h
M Source/WebCore/style/ColorFromPrimitiveValue.cpp

  Log Message:
  ---
  Add support for using 'currentcolor' with color-mix()
https://bugs.webkit.org/show_bug.cgi?id=250459

Reviewed by Darin Adler.

To support 'currentcolor' as the origin color in a color-mix()
value, this change adds a new CSSPrimitiveValue type called
CSSUnresolvedColor as a peer to the existing color value, that
represents, as the name suggests, unresolved color values.

In this change, CSSUnresolvedColor is only used for color-mix(),
but it is implemented in a way so that we can add support for
other unresolved colors like relative colors.

In addition to CSSUnresolvedColor, to fully support 'currentcolor'
StyleColor was updated to add a third kind in addition to Color
and CurrentColor, for color-mix(). This allows for us to do late
evaluation of the color-mix() in the case of a 'currentcolor'
(or even in more interesting cases like an origin which is another
color-mix that itself has 'currentcolor' as the origin).

CSSUnresolvedColor also fixes an issue where we were not preserving
calc() values for the percentages in color-mix() in the specified
value serialization.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Add new files.

* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::isStringType):
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::unitTypeString):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):
(WebCore::CSSPrimitiveValue::equals const):
* Source/WebCore/css/CSSPrimitiveValue.h:
(WebCore::isValueID):
* Source/WebCore/css/CSSUnits.cpp:
(WebCore::unitCategory):
(WebCore::operator<<):
* Source/WebCore/css/CSSUnits.h:
* Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp:
(WebCore::hasDoubleValue):
Add new CSS_UNRESOLVED_COLOR kind.

* Source/WebCore/css/StyleColor.cpp:
(WebCore::StyleColor::copy):
(WebCore::StyleColor::resolveColor const):
(WebCore::StyleColor::isCurrentColor const):
(WebCore::StyleColor::isColorMix const):
(WebCore::StyleColor::resolveAbsoluteComponents):
(WebCore::resolveAbsoluteComponents):
(WebCore::resolveColor):
(WebCore::serializationForCSS):
(WebCore::operator<<):
* Source/WebCore/css/StyleColor.h:
(WebCore::StyleColor::StyleColor):
(WebCore::StyleColor::operator=):
(WebCore::StyleColor::currentColor):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::StyleColor::operator== const):
(WebCore::StyleColor::operator!= const):
(WebCore::CurrentColor::operator== const): Deleted.
(WebCore::CurrentColor::operator!= const): Deleted.
Support a new StyleColorMix kind. Rename CurrentColor to StyleCurrentColor
for consistency.

* Source/WebCore/css/color/CSSResolvedColorMix.cpp: Added.
(WebCore::normalizedMixPercentages):
(WebCore::mixColorComponentsUsingColorInterpolationMethod):
(WebCore::mix):
* Source/WebCore/css/color/CSSResolvedColorMix.h: Added.
CSSResolvedColorMix serves as the implementation of the final
resolved color-mix(), and is used for eager mixing (in the case
of the Raw variant currently used on workers) and in StyleColor
when doing the final resolution.

* Source/WebCore/css/color/CSSUnresolvedColor.cpp: Added.
(WebCore::CSSUnresolvedColor::cssText const):
(WebCore::CSSUnresolvedColor::equals const):
(WebCore::CSSUnresolvedColor::createStyleColor const):
* Source/WebCore/css/color/CSSUnresolvedColor.h: Added.
CSSUnresolvedColor serves a container for unresolved colors
in CSSPrimitiveValue. For now it only supports color-mix(),
but is setup

[webkit-changes] [WebKit/WebKit] 8cee0c: Selector filter fails to collect hash for the firs...

2023-01-20 Thread Antti Koivisto

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8cee0c833695781b97e2aaee74936aaba2e203cb
  
https://github.com/WebKit/WebKit/commit/8cee0c833695781b97e2aaee74936aaba2e203cb
  Author: Antti Koivisto 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
A LayoutTests/fast/selectors/selector-filter-hashes-expected.txt
A LayoutTests/fast/selectors/selector-filter-hashes.html
M Source/WebCore/css/CSSSelector.h
M Source/WebCore/css/SelectorFilter.cpp
M Source/WebCore/css/SelectorFilter.h
M Source/WebCore/css/parser/CSSParser.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl

  Log Message:
  ---
  Selector filter fails to collect hash for the first simple selector in :is()
https://bugs.webkit.org/show_bug.cgi?id=250889


Reviewed by Alan Baradlay.

Logic bug in https://commits.webkit.org/259089@main

Add testing support for selector filter hash collection and a basic unit test.

* LayoutTests/fast/selectors/selector-filter-hashes-expected.txt: Added.
* LayoutTests/fast/selectors/selector-filter-hashes.html: Added.
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectSelectorHashes):

Collect from the first simple selector too when IncludeRightmost::Yes is set.

(WebCore::SelectorFilter::collectHashesForTesting):
* Source/WebCore/css/SelectorFilter.h:
* Source/WebCore/css/parser/CSSParser.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::selectorFilterHashCounts):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/259144@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

2023-01-20 Thread Alan Coon

  Branch: refs/tags/WebKit-7615.1.16.1.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

2023-01-20 Thread Alan Coon

  Branch: refs/tags/WebKit-7615.1.16.1.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4a4574: Resync web-platform-tests/resources from upstream

2023-01-20 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a4574451a99cffd3197fec02b0df9437594bfd2
  
https://github.com/WebKit/WebKit/commit/4a4574451a99cffd3197fec02b0df9437594bfd2
  Author: Chris Dumez 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/structured-cloning-error-stack-optional.sub.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-same-and-cross-origin.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-enter.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-escape.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-mouse-left.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-mouse-right.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-same-and-cross-origin.sub-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-same-and-cross-origin.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/resources/consumption-crossorigin-child.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/resources/consumption-sameorigin-child.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/resources/propagation-crossorigin-child.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/resources/utils.js
M 
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/w3c-import.log
M LayoutTests/imported/w3c/web-platform-tests/resources/channel.sub.js
M LayoutTests/imported/w3c/web-platform-tests/resources/check-layout-th.js
M 
LayoutTests/imported/w3c/web-platform-tests/resources/declarative-shadow-dom-polyfill.js
M 
LayoutTests/imported/w3c/web-platform-tests/resources/idlharness-shadowrealm.js
M LayoutTests/imported/w3c/web-platform-tests/resources/idlharness.js
M LayoutTests/imported/w3c/web-platform-tests/resources/test/README.md
M LayoutTests/imported/w3c/web-platform-tests/resources/test/conftest.py
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_async.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_async_bad_return.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_async_rejection.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_async_rejection_after_load.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_async_timeout.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_bad_return.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_count.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_err.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_err_multi.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/add_cleanup_sync_queue.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/api-tests-1.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/api-tests-2.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/api-tests-3.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/assert-array-equals.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/force_timeout.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/generate-callback.html
A 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/idlharness/IdlInterface/test_exposed_wildcard.html
M 
LayoutTests/imported/w3c/web-platform-tests/resources/test/tests/functional/idlharness/IdlInterface/test

[webkit-changes] [WebKit/WebKit] 05eb6c: Versioning.

2023-01-20 Thread Alan Coon

  Branch: refs/heads/safari-7615.1.16.1-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 05eb6ca39cb69f67f83d62288f818cbccc30f21b
  
https://github.com/WebKit/WebKit/commit/05eb6ca39cb69f67f83d62288f818cbccc30f21b
  Author: Alan Coon 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7615.1.16.1.5

Canonical link: https://commits.webkit.org/257979.23@safari-7615.1.16.1-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] db8f4c: Port NetworkResourceLoadParameters to the new IPC ...

2023-01-20 Thread Gavin

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db8f4c828416ab5cbe20155367ce24b8d2f987cf
  
https://github.com/WebKit/WebKit/commit/db8f4c828416ab5cbe20155367ce24b8d2f987cf
  Author: Gavin Phillips 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebCore/Modules/fetch/FetchBody.cpp
M Source/WebCore/Modules/fetch/FetchBody.h
M Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp
M Source/WebCore/loader/CrossOriginEmbedderPolicy.h
M Source/WebCore/loader/NavigationRequester.h
M Source/WebCore/loader/cache/KeepaliveRequestTracker.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/SecurityOrigin.cpp
M Source/WebCore/page/SecurityOrigin.h
M Source/WebCore/platform/network/CookieRequestHeaderFieldProxy.h
M Source/WebCore/platform/network/FormData.cpp
M Source/WebCore/platform/network/FormData.h
M Source/WebCore/platform/network/ResourceRequestBase.cpp
M Source/WebCore/platform/network/ResourceRequestBase.h
M Source/WebCore/platform/network/SameSiteInfo.h
M Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp
M Source/WebCore/platform/network/cf/FormDataStreamCFNet.h
M 
Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp
M Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp
M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm
M Source/WebCore/platform/network/curl/CurlFormDataStream.cpp
M Source/WebCore/platform/network/curl/CurlFormDataStream.h
M Source/WebCore/platform/network/mac/FormDataStreamMac.h
M Source/WebCore/platform/network/mac/FormDataStreamMac.mm
M Source/WebCore/platform/network/mac/ResourceHandleMac.mm
M Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp
M Source/WebCore/testing/ServiceWorkerInternals.cpp
M Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkLoadParameters.h
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
A 
Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/Platform/IPC/FormDataReference.h
M Source/WebKit/Shared/URLSchemeTaskParameters.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Port NetworkResourceLoadParameters to the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=250201
rdar://103951633

Reviewed by Alex Christensen.

Port NetworkResourceLoadParameters and other related types over to the
new IPC serialization format. This includes:
* NetworkResourceLoadParameters
* PreconnectOnly
* SameSiteInfo
* SecurityOrigin
* ContentSniffingPolicy
* ContentEncodingSniffingPolicy
* ClientCredentialPolicy
* ShouldRelaxThirdPartyCookieBlocking
* PreflightPolicy
* CrossOriginEmbedderPolicy
* CrossOriginEmbedderPolicyValue
* IncludeSecureCookies
* CookieRequestHeaderFieldProxy

* Source/WebCore/Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::fromFormData):
* Source/WebCore/Modules/fetch/FetchBody.h:
* Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp:
(WebCore::CrossOriginEmbedderPolicy::encode const):
(WebCore::CrossOriginEmbedderPolicy::decode):
* Source/WebCore/loader/CrossOriginEmbedderPolicy.h:
(WebCore::CrossOriginEmbedderPolicy::encode const): Deleted.
(WebCore::CrossOriginEmbedderPolicy::decode): Deleted.
* Source/WebCore/loader/NavigationRequester.h:
(WebCore::NavigationRequester::decode):
* Source/WebCore/loader/cache/KeepaliveRequestTracker.cpp:
(WebCore::KeepaliveRequestTracker::tryRegisterRequest):
(WebCore::KeepaliveRequestTracker::registerRequest):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::logMediaDiagnosticMessage const):
* Source/WebCore/page/Page.h:
* Source/WebCore/page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::create):
* Source/WebCore/page/SecurityOrigin.h:
(WebCore::SecurityOrigin::encode const): Deleted.
(WebCore::SecurityOrigin::decode): Deleted.
* Source/WebCore/platform/network/CookieRequestHeaderFieldProxy.h:
(WebCore::CookieRequestHeaderFieldProxy::encode const): Deleted.
(WebCore::CookieRequestHeaderFieldProxy::decode): Deleted.
* Source/WebCore/platform/network/FormData.cpp:
(WebCore::FormData::create):
* Source/WebCore/platform/network/Form

[webkit-changes] [WebKit/WebKit] f650a4: Incorrect repaint when inline content shrinks vert...

2023-01-20 Thread Alan Baradlay

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f650a441093e94116e8b60e89d2b499dbefed017
  
https://github.com/WebKit/WebKit/commit/f650a441093e94116e8b60e89d2b499dbefed017
  Author: Alan Baradlay 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
A LayoutTests/fast/repaint/leftover-after-shrinking-content-expected.txt
A LayoutTests/fast/repaint/leftover-after-shrinking-content.html
A 
LayoutTests/platform/mac-wk1/fast/repaint/leftover-after-shrinking-content-expected.txt
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h

  Log Message:
  ---
  Incorrect repaint when inline content shrinks vertically
https://bugs.webkit.org/show_bug.cgi?id=250864


Reviewed by Antti Koivisto.

After-layout-repaint-rects take both before and after layout dimensions.
This patch ensures that we have access to the "before geometry" even when we 
nuke the inline content
as part of "line layout path" invalidation before running inline layout (this 
is going to change soon when we introduce partial invalidation).

* LayoutTests/fast/repaint/leftover-after-shrinking-content-expected.txt: Added.
* LayoutTests/fast/repaint/leftover-after-shrinking-content.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::lastLineIndexForContentHeight const):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::invalidateLineLayoutPath):
(WebCore::RenderBlockFlow::layoutModernLines):
* Source/WebCore/rendering/RenderBlockFlow.h:

Canonical link: https://commits.webkit.org/259141@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d6ca4d: [webkitbugspy] Access issue milestone (Follow-up fix)

2023-01-20 Thread Jonathan Bedard

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6ca4dc5452a21b5e901ade4b5c477dc51320806
  
https://github.com/WebKit/WebKit/commit/d6ca4dc5452a21b5e901ade4b5c477dc51320806
  Author: Jonathan Bedard 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitbugspy/setup.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py

  Log Message:
  ---
  [webkitbugspy] Access issue milestone (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=250493
rdar://104147220

Unreviewed follow-up fix.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py:
(Tracker.populate): Radars may not have a milestone.

Canonical link: https://commits.webkit.org/259140@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c9c2f3: [JSC] Store Wasm::Instance* in |codeBlock| slot

2023-01-20 Thread Yusuke Suzuki

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9c2f3401b35fdb0f2ab6d548fbc77bc69c8e590
  
https://github.com/WebKit/WebKit/commit/c9c2f3401b35fdb0f2ab6d548fbc77bc69c8e590
  Author: Yusuke Suzuki 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/interpreter/CallFrame.cpp
M Source/JavaScriptCore/interpreter/CallFrame.h
M Source/JavaScriptCore/interpreter/CallFrameInlines.h
M Source/JavaScriptCore/interpreter/Interpreter.cpp
M Source/JavaScriptCore/interpreter/ProtoCallFrame.h
M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
M Source/JavaScriptCore/jit/GPRInfo.h
M Source/JavaScriptCore/llint/LLIntExceptions.cpp
M Source/JavaScriptCore/llint/LLIntThunks.cpp
M Source/JavaScriptCore/llint/WebAssembly.asm
M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h
M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmCallee.cpp
M Source/JavaScriptCore/wasm/WasmCallee.h
M Source/JavaScriptCore/wasm/WasmCallingConvention.h
M Source/JavaScriptCore/wasm/WasmContext.h
R Source/JavaScriptCore/wasm/WasmContextInlines.h
M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp
M Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h
M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp
M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp
M Source/JavaScriptCore/wasm/WasmMemoryInformation.cpp
M Source/JavaScriptCore/wasm/WasmOperations.cpp
M Source/JavaScriptCore/wasm/js/JSToWasm.cpp
M Source/JavaScriptCore/wasm/js/WasmToJS.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp

  Log Message:
  ---
  [JSC] Store Wasm::Instance* in |codeBlock| slot
https://bugs.webkit.org/show_bug.cgi?id=250822
rdar://104410328

Reviewed by Mark Lam.

This patch fixes wasm calling convention problems. The new one becomes much 
simpler and robust (and fixing existing bugs).

1. We remove vm.wasmContext.instance field. Previously, it was randomly 
configured and a lot code is missing the update of this thing (for example, 
wasm context switching
   inside wasm -> wasm call missed the update). We should not have this kind of 
"global" variable and instead we should query to CallFrame about 
Wasm::Instance* of the current CallFrame*.
2. Each wasm function stores Wasm::Instance* to the CallFrame. We use 
|codeBlock| slot for that purpose. Since it is next to |callee| slot, we can 
use storePairPtr in ARM64, no code size increase.
   Plus, because we are already writing |callee| slot, it does not add new 
performance problem. This change makes 
CallFrame::lexicalGlobalObjectFromWasmCallee super simple since we can just get
   this slot from CallFrame instead of getting it from vm.wasmContext.instance. 
And it also makes Interpreter::unwind much simpler since we no longer need to 
book-keep this variable in unwinding case.
   And this also contributes to code size reduction in Wasm IC since we no 
longer need to have store and load code for vm.wasmContext.instance.
3. We use |codeBlock| slot for Wasm::Instance*. However, Wasm LLInt already 
used it for Wasm::Callee* (wasm's codeblock). This patch allocates 2 internal 
slots for Wasm::LLInt code and use
   this slot for Wasm::Callee* instead. This slot is "WasmCodeBlock".
4. We revise the use of |this| slot for wasm functions. Previously, it was 
randomly used. But we use this slot to anchor JSWebAssemblyInstance from 
conservative GC root.
   While we are keeping Wasm::Instance* in the stack, it is not GC-managed 
cell. To keep Wasm functions alive while running, we need to anchor 
JSWebAssemblyInstance* from conservative GC root.
   We use this slot in three cases. (1) Calling wasm function from JS world / 
C++ world so that we need to keep wasm function alive. (2) We wasm-tail-call to 
a new function. Since tail-call can wipe the previous
   frame, if it is the entrance frame created by (1), we miss the anchor. 
Conservatively, we always store this cell in tail-call case. (3) And we do this 
when calling wasm function indirectly.
   This could switch to a new wasm instance, so we should keep a new instance 
anchored from the stack.

This change wipes a lot of weird things in wasm and makes calling convention 
much simpler.

* Source/JavaScriptCore/interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::operator() const):
* Source/JavaScriptCore/interpreter/ProtoCallFrame.h:
* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h:
(JSC::Wasm::ExpressionType>::AirIRGeneratorBase):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::insertConstants):
* Source/JavaScriptCore/wasm/WasmCallingConvention.h:
* Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h:
(JSC::Wasm::emitCatchPrologueShared):
* Source/JavaScriptCore/wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmWrapp

[webkit-changes] [WebKit/WebKit] cf1e88: Resync web-platform-tests/tools from upstream

2023-01-20 Thread Chris Dumez

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf1e882c30508fb0c717364f2a98101d90127b5f
  
https://github.com/WebKit/WebKit/commit/cf1e882c30508fb0c717364f2a98101d90127b5f
  Author: Chris Dumez 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/tools/META.yml
M LayoutTests/imported/w3c/web-platform-tests/tools/certs/README.md
M LayoutTests/imported/w3c/web-platform-tests/tools/certs/cacert.key
M LayoutTests/imported/w3c/web-platform-tests/tools/certs/cacert.pem
M 
LayoutTests/imported/w3c/web-platform-tests/tools/certs/web-platform.test.key
M 
LayoutTests/imported/w3c/web-platform-tests/tools/certs/web-platform.test.pem
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/affected_tests.yml
R 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/cleanup_win10.yml
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/fyi_hook.yml
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/install_certs.yml
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/install_chrome.yml
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/install_firefox.yml
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/install_fonts.yml
R 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/install_python.yml
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/install_safari.yml
R 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/safari-technology-preview.rb
A LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/sysdiagnose.yml
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/tox_pytest.yml
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/update_hosts.yml
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/azure/w3c-import.log
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/ci_built_diff.sh
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/commands.json
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/jobs.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/make_hosts_file.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/manifest_build.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/regen_certs.py
A 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/requirements_build.txt
A LayoutTests/imported/w3c/web-platform-tests/tools/ci/requirements_tc.txt
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/run_tc.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/taskcluster-run.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/decision.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/download.py
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/github_checks_output.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/sink_task.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/taskgraph.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/tasks/test.yml
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/tests/test_decision.py
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/tests/test_taskgraph.py
M 
LayoutTests/imported/w3c/web-platform-tests/tools/ci/tc/tests/test_valid.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/tests/test_jobs.py
A LayoutTests/imported/w3c/web-platform-tests/tools/ci/update_built.py
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/w3c-import.log
M LayoutTests/imported/w3c/web-platform-tests/tools/ci/website_build.sh
M LayoutTests/imported/w3c/web-platform-tests/tools/docker/Dockerfile
M LayoutTests/imported/w3c/web-platform-tests/tools/docker/commands.json
M LayoutTests/imported/w3c/web-platform-tests/tools/docker/frontend.py
A LayoutTests/imported/w3c/web-platform-tests/tools/docker/requirements.txt
M LayoutTests/imported/w3c/web-platform-tests/tools/docker/w3c-import.log
M LayoutTests/imported/w3c/web-platform-tests/tools/flake8.ini
M LayoutTests/imported/w3c/web-platform-tests/tools/gitignore/gitignore.py
M 
LayoutTests/imported/w3c/web-platform-tests/tools/gitignore/tests/test_gitignore.py
M LayoutTests/imported/w3c/web-platform-tests/tools/lint/lint.py
M LayoutTests/imported/w3c/web-platform-tests/tools/lint/rules.py
M LayoutTests/imported/w3c/web-platform-tests/tools/lint/tests/base.py
R 
LayoutTests/imported/w3c/web-platform-tests/tools/lint/tests/dummy/css/css-unique/a-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/tools/lint/tests/dummy/css/css-unique/a-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/tools/lint/tests/dummy/css/css-unique/match/a-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/tools/lint/tests/dummy/css/css-unique/match/a-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests

[webkit-changes] [WebKit/WebKit] 2663e6: [iOS] Fix release assertion in WebKit::ProcessThro...

2023-01-20 Thread Miguel Salinas

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2663e6d98e20416821cc0c1bac5df85235e42342
  
https://github.com/WebKit/WebKit/commit/2663e6d98e20416821cc0c1bac5df85235e42342
  Author: Miguel Salinas 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/UIProcess/ProcessThrottler.cpp

  Log Message:
  ---
  [iOS] Fix release assertion in WebKit::ProcessThrottler::didConnectToProcess
https://bugs.webkit.org/show_bug.cgi?id=250789

Reviewed by Chris Dumez.

This assertion needs to be updated after adding the option to drop the
'Suspended' assertion.

* Source/WebKit/UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::didConnectToProcess):

Canonical link: https://commits.webkit.org/259137@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 687773: RemoteAudioDestinationManager DeleteAudioDestinati...

2023-01-20 Thread Kimmo Kinnunen

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 687773c153f10724f3c8036b67dc8eb075245b7a
  
https://github.com/WebKit/WebKit/commit/687773c153f10724f3c8036b67dc8eb075245b7a
  Author: Kimmo Kinnunen 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h
M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in
M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp

  Log Message:
  ---
  RemoteAudioDestinationManager DeleteAudioDestination has redundant async reply
https://bugs.webkit.org/show_bug.cgi?id=250893
rdar://104471888

Reviewed by Youenn Fablet.

The asynchronous reply was not used for anything. Remove it.

* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:
(WebKit::RemoteAudioDestinationManager::deleteAudioDestination):
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h:
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::~RemoteAudioDestinationProxy):

Canonical link: https://commits.webkit.org/259136@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bccfa0: [git-webkit] Make the default for automatically re...

2023-01-20 Thread Antoine Quint

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bccfa03529c2333ade99a1d1a82d2398db776a93
  
https://github.com/WebKit/WebKit/commit/bccfa03529c2333ade99a1d1a82d2398db776a93
  Author: Antoine Quint 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py

  Log Message:
  ---
  [git-webkit] Make the default for automatically rebasing pull requests be 
"No" during `git webkit setup`
https://bugs.webkit.org/show_bug.cgi?id=250888

Reviewed by Jonathan Bedard.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:

Canonical link: https://commits.webkit.org/259135@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3c729e: AudioContext::suspend creates a remote audio desti...

2023-01-20 Thread Kimmo Kinnunen

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c729e10ad7a04cb531fbce23850242271c48222
  
https://github.com/WebKit/WebKit/commit/3c729e10ad7a04cb531fbce23850242271c48222
  Author: Kimmo Kinnunen 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp

  Log Message:
  ---
  AudioContext::suspend creates a remote audio destination
https://bugs.webkit.org/show_bug.cgi?id=250890
rdar://problem/104470320

Reviewed by Youenn Fablet.

Stopping RemoteAudioDestinationProxy that was not started would
establish a connection to GPUP RemoteAudioDestination. This is a slow
operation.

This would happen sometimes during load, where load commit would suspend
the AudioContext that the page created but did not start. AudioContext
starts in Suspended state, but suspending it would cause stop call
to the underlying destination.

To minimize the change at this time, fix the problem at
RemoteAudioDestinationProxy level. Later on, AudioContext can be
improved further.

* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::startRendering):
(WebKit::RemoteAudioDestinationProxy::stopRendering):

Canonical link: https://commits.webkit.org/259134@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 243c46: [WGSL] Add support for binary add

2023-01-20 Thread Tadeu Zagallo

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 243c46b4a2b383e9224f4794a489bde1cd185a9a
  
https://github.com/WebKit/WebKit/commit/243c46b4a2b383e9224f4794a489bde1cd185a9a
  Author: Tadeu Zagallo 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebGPU/WGSL/AST/AST.h
A Source/WebGPU/WGSL/AST/ASTBinaryExpression.h
M Source/WebGPU/WGSL/AST/ASTForward.h
M Source/WebGPU/WGSL/AST/ASTNode.h
M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp
M Source/WebGPU/WGSL/AST/ASTStringDumper.h
M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
M Source/WebGPU/WGSL/AST/ASTVisitor.h
M Source/WebGPU/WGSL/Lexer.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
M Source/WebGPU/WGSL/Token.cpp
M Source/WebGPU/WGSL/Token.h
M Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp
M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp

  Log Message:
  ---
  [WGSL] Add support for binary add
https://bugs.webkit.org/show_bug.cgi?id=250849


Reviewed by Myles C. Maxfield.

Add lexing for `+` and `++`, add a new BinaryExpression AST node,
implement parsing and codegen for add.

* Source/WebGPU/WGSL/AST/AST.h:
* Source/WebGPU/WGSL/AST/ASTBinaryExpression.h: Copied from 
Source/WebGPU/WGSL/AST/AST.h.
* Source/WebGPU/WGSL/AST/ASTForward.h:
* Source/WebGPU/WGSL/AST/ASTNode.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
(WGSL::AST::StringDumper::visit):
* Source/WebGPU/WGSL/AST/ASTStringDumper.h:
* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::Visitor::visit):
* Source/WebGPU/WGSL/AST/ASTVisitor.h:
* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::Lexer::lex):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::parseArrayType):
(WGSL::Parser::parseReturnStatement):
(WGSL::Parser::parseRelationalExpression):
(WGSL::Parser::parseShiftExpression):
(WGSL::Parser::parseAdditiveExpression):
(WGSL::Parser::parseMultiplicativeExpression):
(WGSL::Parser::parseExpression):
(WGSL::Parser::parseShortCircuitOrExpression): Deleted.
* Source/WebGPU/WGSL/ParserPrivate.h:
* Source/WebGPU/WGSL/Token.cpp:
(WGSL::toString):
* Source/WebGPU/WGSL/Token.h:
* Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:
(TestWGSLAPI::TEST):
* Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp:
(TestWGSLAPI::TEST):

Canonical link: https://commits.webkit.org/259133@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf1324: [GTK][WPE] Use base data and cache directories for...

2023-01-20 Thread Carlos Garcia Campos

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf13243c111ffef61183fe7e10b6f0c23657a800
  
https://github.com/WebKit/WebKit/commit/cf13243c111ffef61183fe7e10b6f0c23657a800
  Author: Carlos Garcia Campos 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp
M Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h

  Log Message:
  ---
  [GTK][WPE] Use base data and cache directories for tests website data 
configuration
https://bugs.webkit.org/show_bug.cgi?id=250830

Reviewed by Michael Catanzaro.

Instead of using deprecated api to set individual directories.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration):
(prepopulateHstsData):
* Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::Test):

Canonical link: https://commits.webkit.org/259132@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8efbac: [WK2] Use Spans in remaining cases of moving memor...

2023-01-20 Thread Žan Doberšek

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8efbac52b8cdb3d666f71d2f602d350a08c8c0f4
  
https://github.com/WebKit/WebKit/commit/8efbac52b8cdb3d666f71d2f602d350a08c8c0f4
  Author: Žan Doberšek 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WebCore/Modules/highlight/AppHighlight.h
M Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h
M Source/WebCore/bindings/js/BufferSource.h
M Source/WebCore/bindings/js/SerializedScriptValue.h
M Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp
M Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h
M Source/WebCore/platform/graphics/Model.h
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp

  Log Message:
  ---
  [WK2] Use Spans in remaining cases of moving memory spans through IPC
https://bugs.webkit.org/show_bug.cgi?id=250761

Reviewed by Kimmo Kinnunen.

Adopt Spans or encodeSpan()-and-decodeSpan() pairings on the remaining uses
of copying memory spans across IPC channels. Spans are mostly adopted to replace
the combination of the length value and the fixed-length data. encodeSpan() and
decodeSpan() are used where only fixed-length data is operated-with.

Especially in decoding this helps reduce the necessary logic, since all the
overflow and buffer size validation is packed inside Decoder::decodeSpan().

An exception to this is ByteArrayPixelBuffer, which now encodes a complete Span
object. Upon decoding, the Span size is validated to match the buffer size
that's computed from the buffer's format and width-and-height size.

Additionally, in AppHighlight and Model classes, direct encoding and decoding
of memory spans is replaced by simply encoding and decoding the SharedBuffer and
FragmentedSharedBuffer objects.

Finally, FragmentedSharedBuffer encoding and decoding now passes the buffer size
as a size_t value, avoiding widening and narrowing the value through uint64_t.

* Source/WebCore/Modules/highlight/AppHighlight.h:
(WebCore::AppHighlight::encode const):
(WebCore::AppHighlight::decode):
* Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h:
(WebCore::encodeArrayBuffer):
(WebCore::decodeArrayBuffer):
* Source/WebCore/bindings/js/BufferSource.h:
(WebCore::BufferSource::encode const):
(WebCore::BufferSource::decode):
* Source/WebCore/bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValue::encode const):
(WebCore::SerializedScriptValue::decode):
* Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp:
* Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h:
(WebCore::ByteArrayPixelBuffer::encode const):
(WebCore::ByteArrayPixelBuffer::decode):
* Source/WebCore/platform/graphics/Model.h:
(WebCore::Model::encode const):
(WebCore::Model::decode):
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):

Canonical link: https://commits.webkit.org/259131@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b3bce: Add logging to WTF::SuspendableWorkQueue

2023-01-20 Thread Sihui

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b3bce8b1e4f520b429c5ad943f3c62be3536e66
  
https://github.com/WebKit/WebKit/commit/4b3bce8b1e4f520b429c5ad943f3c62be3536e66
  Author: Sihui Liu 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
M Source/WTF/wtf/Logging.cpp
M Source/WTF/wtf/Logging.h
M Source/WTF/wtf/SuspendableWorkQueue.cpp
M Source/WTF/wtf/SuspendableWorkQueue.h
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp

  Log Message:
  ---
  Add logging to WTF::SuspendableWorkQueue
https://bugs.webkit.org/show_bug.cgi?id=250809
rdar://problem/104403363

Reviewed by Chris Dumez.

To help debug storage queue suspension issues like rdar://103873458.

* Source/WTF/wtf/Logging.cpp:
* Source/WTF/wtf/Logging.h:
* Source/WTF/wtf/SuspendableWorkQueue.cpp:
(WTF::SuspendableWorkQueue::create):
(WTF::SuspendableWorkQueue::SuspendableWorkQueue):
(WTF::SuspendableWorkQueue::stateString):
(WTF::SuspendableWorkQueue::suspend):
(WTF::SuspendableWorkQueue::resume):
(WTF::SuspendableWorkQueue::suspendIfNeeded):
* Source/WTF/wtf/SuspendableWorkQueue.h:
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::NetworkStorageManager):
(WebKit::NetworkStorageManager::suspend):
(WebKit::NetworkStorageManager::resume):

Canonical link: https://commits.webkit.org/259130@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 43a3e4: Followup (258794@main): Add a mismatch test to ens...

2023-01-20 Thread Said Abou-Hallawa

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43a3e4fee80f5636e453e632a72ea572ce86043f
  
https://github.com/WebKit/WebKit/commit/43a3e4fee80f5636e453e632a72ea572ce86043f
  Author: Said Abou-Hallawa 
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
A LayoutTests/fast/forms/input-text-focus-ring-expected-mismatch.html
A LayoutTests/fast/forms/input-text-focus-ring.html

  Log Message:
  ---
  Followup (258794@main): Add a mismatch test to ensure that the form control 
focus ring is drawn
https://bugs.webkit.org/show_bug.cgi?id=250850
rdar://104432889

Reviewed by Aditya Keerthi.

This verifies the test and the expected mismatch result wil differ as intended.

* LayoutTests/fast/forms/input-text-focus-ring-expected-mismatch.html: Added.
* LayoutTests/fast/forms/input-text-focus-ring.html: Added.

Canonical link: https://commits.webkit.org/259129@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

44 matches

Mail list logo