[webkit-changes] [WebKit/WebKit] 1c8b29: [GTK][Debug] Unreviewed, fix build after 259231@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c8b29ff201022e3a20578244e85d25d1b7706c4 https://github.com/WebKit/WebKit/commit/1c8b29ff201022e3a20578244e85d25d1b7706c4 Author: Diego Pino Garcia Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp Log Message: --- [GTK][Debug] Unreviewed, fix build after 259231@main * Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Canonical link: https://commits.webkit.org/259343@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d9da70: HLS videos sometimes fail to reach "ended" state &...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9da700801d7af287ce3ad9500da44f4a7feec96 https://github.com/WebKit/WebKit/commit/d9da700801d7af287ce3ad9500da44f4a7feec96 Author: Jer Noble Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/http/tests/media/hls/hls-ended-expected.txt A LayoutTests/http/tests/media/hls/hls-ended.html M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Log Message: --- HLS videos sometimes fail to reach "ended" state & cannot be restarted https://bugs.webkit.org/show_bug.cgi?id=251119 rdar://102114139 Reviewed by Eric Carlson. When WebKit receives the AVPlayerItemDidPlayToEndTimeNotification notification, it still attempts to estimate the current time because it believes it is still playing, as it hasn't yet received the -timeControlStatus KVO. Reset the values for currentTime estimation when receiving this notification so that the values returned are consistent. * LayoutTests/http/tests/media/hls/hls-ended-expected.txt: Added. * LayoutTests/http/tests/media/hls/hls-ended.html: Added. * Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::didEnd): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::didEnd): Canonical link: https://commits.webkit.org/259342@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58e8ab: Amortized behaviors of iterators and hasNullRefere...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58e8ab36fc7d9b1cb93e6d8b49668546679f5e6a https://github.com/WebKit/WebKit/commit/58e8ab36fc7d9b1cb93e6d8b49668546679f5e6a Author: Ryosuke Niwa Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/wtf/WeakHashMap.h M Source/WTF/wtf/WeakHashSet.h M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp Log Message: --- Amortized behaviors of iterators and hasNullReferences should be consistent between WeakHashSet and WeakHashMap https://bugs.webkit.org/show_bug.cgi?id=251116 Reviewed by Chris Dumez. Made const_iterator and hasNullReferences of WeakHashSet trigger amortized cleanup as in WeakHashMap for consistency. * Source/WTF/wtf/WeakHashMap.h: (WeakHashMap::hasNullReferences): Just increment the operation count and don't do amortized cleanup here. * Source/WTF/wtf/WeakHashSet.h: (WeakHashSet::WeakHashSetConstIterator::WeakHashSetConstIterator): (WeakHashSet::WeakHashSetConstIterator::operator++): Increment the operation count. (WeakHashSet::begin): (WeakHashSet::end): (WeakHashSet::hasNullReferences): Increase the operation count. (WeakHashSet::forEach): Don't increment the operation count here given the iterator does it now. (WeakHashSet::increaseOperationCountSinceLastCleanup): Now takes the increment as an argument. * Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (WTF_WeakPtr.WeakHashSetAmortizedCleanup): Added. (WTF_WeakPtr.WeakHashMapAmortizedCleanup): Canonical link: https://commits.webkit.org/259341@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 800a9b: DFG should not speculate Int32 for NaN constants
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 800a9bf27aa78b710149be8309103d96fb172051 https://github.com/WebKit/WebKit/commit/800a9bf27aa78b710149be8309103d96fb172051 Author: David Degazio Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A JSTests/stress/bitwise-and-with-NaN-constant.js M Source/JavaScriptCore/dfg/DFGGraph.h Log Message: --- DFG should not speculate Int32 for NaN constants https://bugs.webkit.org/show_bug.cgi?id=251117 rdar://104608391 Reviewed by Mark Lam. Adds a check for NaN immediates to DFG::Graph::addImmediateShouldSpeculateInt32. This prevents NaNs from being speculated as Int32s and truncated during the DFG fixup phase despite being non-finite values. * JSTests/stress/bitwise-AND-with-NaN-constant.js: Added. (foo): * Source/JavaScriptCore/dfg/DFGGraph.h: Canonical link: https://commits.webkit.org/259340@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eeb553: Rename WeakHashSet::computesEmpty to WeakHashSet::...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eeb55349e8337dfaff7af0c091e1a246b4ac556f https://github.com/WebKit/WebKit/commit/eeb55349e8337dfaff7af0c091e1a246b4ac556f Author: Ryosuke Niwa Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/wtf/ThreadSafeWeakHashSet.h M Source/WTF/wtf/WeakHashSet.h M Source/WTF/wtf/glib/RunLoopGLib.cpp M Source/WebCore/Modules/gamepad/GamepadManager.cpp M Source/WebCore/animation/DocumentTimelinesController.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/MutationObserver.cpp M Source/WebCore/dom/RadioButtonGroups.cpp M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/html/CanvasBase.h M Source/WebCore/html/HTMLFieldSetElement.cpp M Source/WebCore/html/HTMLFormElement.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/FrameView.cpp M Source/WebCore/page/FrameView.h M Source/WebCore/page/UserContentProvider.cpp M Source/WebCore/page/VisitedLinkStore.cpp M Source/WebCore/page/ios/ContentChangeObserver.cpp M Source/WebCore/page/ios/ContentChangeObserver.h M Source/WebCore/platform/ScreenOrientationProvider.cpp M Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.mm M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp M Source/WebCore/platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm M Source/WebCore/plugins/PluginInfoProvider.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.cpp M Source/WebCore/style/StyleScope.cpp M Source/WebCore/svg/SVGDocumentExtensions.cpp M Source/WebCore/svg/SVGElement.cpp M Source/WebCore/svg/SVGElement.h M Source/WebCore/svg/properties/SVGAnimatedProperty.h M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp M Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/VisitedLinkStore.cpp M Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp M Source/WebKit/UIProcess/WebPreferences.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebScreenOrientationManager.cpp M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp Log Message: --- Rename WeakHashSet::computesEmpty to WeakHashSet::isEmptyIgnoringNullReferences https://bugs.webkit.org/show_bug.cgi?id=251108 Reviewed by Chris Dumez. Renamed WeakHashSet's computesEmpty to isEmptyIgnoringNullReferences to match WeakHashMap. * Source/WTF/wtf/ThreadSafeWeakHashSet.h: * Source/WTF/wtf/WeakHashSet.h: * Source/WTF/wtf/glib/RunLoopGLib.cpp: (WTF::RunLoop::notify): * Source/WebCore/Modules/gamepad/GamepadManager.cpp: (WebCore::GamepadManager::platformGamepadInputActivity): (WebCore::GamepadManager::makeGamepadVisible): (WebCore::GamepadManager::maybeStartMonitoringGamepads): (WebCore::GamepadManager::maybeStopMonitoringGamepads): * Source/WebCore/animation/DocumentTimelinesController.cpp: (WebCore::DocumentTimelinesController::detachFromDocument): * Source/WebCore/dom/Document.cpp: (WebCore::Document::takeAnyMediaCanStartListener): * Source/WebCore/dom/MutationObserver.cpp: (WebCore::MutationObserver::~MutationObserver): * Source/WebCore/dom/RadioButtonGroups.cpp: (WebCore::RadioButtonGroup::isEmpty const): (WebCore::RadioButtonGroup::remove): * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::~CanvasBase): * Source/WebCore/html/CanvasBase.h: (WebCore::CanvasBase::hasDisplayBufferObservers const): * Source/WebCore/html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::matchesValidPseudoClass const): (WebCore::HTMLFieldSetElement::matchesInvalidPseudoClass const): (WebCore::HTMLFieldSetElement::addInvalidDescendant): * Source/WebCore/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::addInvalidFormControl): (WebCore::HTMLFormElement::matchesValidPseudoClass const): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::hasOpenedFrames const): * Source/WebCore/page/FrameView.cpp: (WebCore::FrameView::didDestroyRenderTree): (WebCore::FrameView::removeSlowRepaintObject): (WebCore::FrameView::scrollContentsFastPath): * Source/WebCore/page/FrameView.h: * Source/WebCore/page/UserContentProvider.cpp: (WebCore::UserContentProvider::~UserContentProvider): * Source/WebCore/page/VisitedLinkStore.cpp: (WebCore::VisitedLinkStore::~VisitedLinkStore): * Source/WebCore/page/ios/ContentChangeObserver.cpp: (WebCore::ContentChangeObserver::hasObservedDOMTimer const): (WebCore::ContentChangeObserver::elementDidBecomeHidden): * Source/WebCore/page/ios/ContentChangeObserver.h: (WebCore::ContentChangeObserver::hasObservedTransition const): *
[webkit-changes] [WebKit/WebKit] 1fa5ad: Cherry-pick 252432.896@safari-7614-branch (91df735...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fa5adc1417a27e7b4a71b2a5da1c0781f43c434 https://github.com/WebKit/WebKit/commit/1fa5adc1417a27e7b4a71b2a5da1c0781f43c434 Author: Dan Glastonbury Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp Log Message: --- Cherry-pick 252432.896@safari-7614-branch (91df735c5c49). rdar://104611996 [WebGL] Harden texImageImpl byte length calculation rdar://98583503 Reviewed by Kimmo Kinnunen and Ryan Haddad. The calculation of the image size has been validated earlier but out of an abundance of caution, use checked arithmetic on size_t to perform calculation, returning a GL error on overflow. * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::texImageImpl): Calculate imagePixelsByteLength with checked arithmetic to catch integer overflow. Canonical link: https://commits.webkit.org/252432.896@safari-7614-branch Canonical link: https://commits.webkit.org/259338@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 739994: Remove non-decomposable-matrix.html.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7399948b5193853dd173062ec25c9a73345fff66 https://github.com/WebKit/WebKit/commit/7399948b5193853dd173062ec25c9a73345fff66 Author: Matt Woodrow Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: R LayoutTests/compositing/contents-scale/non-decomposable-matrix-expected.html R LayoutTests/compositing/contents-scale/non-decomposable-matrix.html M LayoutTests/platform/gtk/TestExpectations Log Message: --- Remove non-decomposable-matrix.html. https://bugs.webkit.org/show_bug.cgi?id=250991 Reviewed by Tim Nguyen. This test is checking that we compute the correct contents scale for a layer that has a singular matrix, but still renders. This was previously the case for scaleZ(0), but we no longer render those (to match other browsers), so this case isn't possible. * LayoutTests/compositing/contents-scale/non-decomposable-matrix-expected.html: Removed. * LayoutTests/compositing/contents-scale/non-decomposable-matrix.html: Removed. * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/259337@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8aa4e: AX: Make scroll-to-visible-action.html and content...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8aa4e87aecf6f2c3bc352c16a0a8b46af72031f https://github.com/WebKit/WebKit/commit/c8aa4e87aecf6f2c3bc352c16a0a8b46af72031f Author: Tyler Wilcock Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/accessibility/mac/scroll-to-visible-action-expected.txt M LayoutTests/accessibility/mac/scroll-to-visible-action.html M LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt M LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame.html Log Message: --- AX: Make scroll-to-visible-action.html and content-inset-scrollview-frame.html async https://bugs.webkit.org/show_bug.cgi?id=251049 rdar://problem/104578997 Reviewed by Chris Fleizach. Making these tests async-friendly (by awaiting dynamic page changes) is required for a future patch in which we serve node frames off the main-thread. * LayoutTests/accessibility/mac/scroll-to-visible-action-expected.txt: * LayoutTests/accessibility/mac/scroll-to-visible-action.html: * LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt: * LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame.html: Canonical link: https://commits.webkit.org/259336@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b1a0c: Cherry-pick 252432.845@safari-7614-branch (2fc9fcf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b1a0c93dadf031285667d2d3fc09ecbca5001d1 https://github.com/WebKit/WebKit/commit/4b1a0c93dadf031285667d2d3fc09ecbca5001d1 Author: Matt Woodrow Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp Log Message: --- Cherry-pick 252432.845@safari-7614-branch (2fc9fcfb0857). rdar://104611648 Use-after-free in RemoteImageDecoderAVFProxy::createDecoder. https://bugs.webkit.org/show_bug.cgi?id=248317 Reviewed by Jonathan Bedard and David Kilzer. Passes a WeakPtr into the lambda instead, so that we can check if it's still alive before accessing it. * Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp: (WebKit::RemoteImageDecoderAVFProxy::createDecoder): Canonical link: https://commits.webkit.org/252432.845@safari-7614-branch Canonical link: https://commits.webkit.org/259335@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7b129: AX: Use stronger typing of AccessibilityObject in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7b129acb04cbcb1d943ed6cc46379062ab819a2 https://github.com/WebKit/WebKit/commit/d7b129acb04cbcb1d943ed6cc46379062ab819a2 Author: Tyler Wilcock Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h Log Message: --- AX: Use stronger typing of AccessibilityObject in AXObjectCache, AXIsolatedObject, and AXIsolatedTree https://bugs.webkit.org/show_bug.cgi?id=251057 rdar://problem/104582945 Reviewed by Chris Fleizach. There are a bunch of places where we pass an AXCoreObject and immediately ASSERT(is(object)). We should just use stronger types, which avoids asserts and casting, and possibly helps the compiler perform de-virtualization optimizations. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::updateIsolatedTree): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::AXIsolatedObject): (WebCore::AXIsolatedObject::create): (WebCore::AXIsolatedObject::initializeProperties): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::generateSubtree): (WebCore::AXIsolatedTree::nodeChangeForObject): (WebCore::AXIsolatedTree::updateNode): (WebCore::AXIsolatedTree::updatePropertiesForSelfAndDescendants): (WebCore::AXIsolatedTree::updateNodeAndDependentProperties): (WebCore::AXIsolatedTree::removeNode): (WebCore::AXIsolatedTree::removeSubtreeFromNodeMap): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: Canonical link: https://commits.webkit.org/259334@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7fe5c: [Test] fast/events/touch/ios/long-press-then-drag-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7fe5cfa99b2c7751e0b655ec624d867df35ac3d https://github.com/WebKit/WebKit/commit/a7fe5cfa99b2c7751e0b655ec624d867df35ac3d Author: Alan Baradlay Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html Log Message: --- [Test] fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html is a consistent failure after 258329@main https://bugs.webkit.org/show_bug.cgi?id=251112 Reviewed by Tim Horton. is used as an "beginning of line" type of anchor in this test. However since 258329@main, this inline box is (correctly) placed at the end of the previous line (matching FF and Chrome). Let'e make sure that the inline box is always at the beginning of the line. * LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html: Canonical link: https://commits.webkit.org/259333@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 574c38: Cherry-pick 252432.841@safari-7614-branch (a47510d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 574c3859cc0c99c8947c785c44f8b76a45c1fd17 https://github.com/WebKit/WebKit/commit/574c3859cc0c99c8947c785c44f8b76a45c1fd17 Author: Chris Dumez Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/fast/dom/lazy-loading-iframe-destruction-crash-expected.txt A LayoutTests/fast/dom/lazy-loading-iframe-destruction-crash.html M Source/WebCore/dom/Document.cpp Log Message: --- Cherry-pick 252432.841@safari-7614-branch (a47510d4bcf4). rdar://104609847 Fix potential crash under IntersectionObserver::disconnect() https://bugs.webkit.org/show_bug.cgi?id=248111 rdar://100355921 Reviewed by Jonathan Bedard and Ryosuke Niwa. Make sure we protect the intersection observers and resize observers before calling disconnect() on them in Document::commonTeardown(). This is a speculative fix to address the crash in the radar, which I was unable to reproduce. * LayoutTests/fast/dom/lazy-loading-iframe-destruction-crash-expected.txt: Added. * LayoutTests/fast/dom/lazy-loading-iframe-destruction-crash.html: Added. Include test from the radar, even though it didn't reproduce the issue for me. * Source/WebCore/dom/Document.cpp: (WebCore::Document::commonTeardown): Canonical link: https://commits.webkit.org/252432.841@safari-7614-branch Canonical link: https://commits.webkit.org/259332@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb16e1: Autogenerated settings turn off too many things in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb16e152e4f6b4e8d4d20035e34034431d046e57 https://github.com/WebKit/WebKit/commit/fb16e152e4f6b4e8d4d20035e34034431d046e57 Author: Brent Fulgham Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Autogenerated settings turn off too many things in Lockdown Mode https://bugs.webkit.org/show_bug.cgi?id=251103 Reviewed by Elliott Williams. We decided that 'developer' state should refer to features that are typically off, but might be enabled by developers debugging a problem. A number of features that are expected to be enabled at all times were improperly labeled with this state, causing our Lockdown Mode logic to turn them off. Instead, we should use 'stable' for features that developers may wish to turn off for A/B testing reasons, but are not intended to be off for most use cases. This patch corrects these problems, and exposes two WebRTC flags as developer options that can be enabled for experimentation, but should not be used by default. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/259331@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c0aa1: [build] Add IsoMallocInlines.h to WebCore precompi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c0aa1d5a0692f44d8dc1e105d7a1d77c311c15f https://github.com/WebKit/WebKit/commit/1c0aa1d5a0692f44d8dc1e105d7a1d77c311c15f Author: Dan Glastonbury Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/WebCorePrefix.h Log Message: --- [build] Add IsoMallocInlines.h to WebCore precompiled header https://bugs.webkit.org/show_bug.cgi?id=250878 rdar://problem/104453981 Reviewed by Alexey Proskuryakov. ClangBuildAnalyzer reports that IsoMallocInlines.h is an expensive header to parse. Consider this header as stable and add it to WebCore's precompiled header so it's parsed once. * Source/WebCore/WebCorePrefix.h: Canonical link: https://commits.webkit.org/259330@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb9624: [JSC] Simplify wasm to import function call
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb96241cb10a9cff4dccb36c3c7f8a7a2299dc23 https://github.com/WebKit/WebKit/commit/bb96241cb10a9cff4dccb36c3c7f8a7a2299dc23 Author: Yusuke Suzuki Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmInstance.h M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h M Source/JavaScriptCore/wasm/js/WebAssemblyWrapperFunction.cpp Log Message: --- [JSC] Simplify wasm to import function call https://bugs.webkit.org/show_bug.cgi?id=251068 rdar://104588822 Reviewed by Justin Michaud. We are unnecessarily complicating code generation for wasm to import function calls: we are having two cases, one for Wasm->JS and one for Wasm->Wasm. We can just make Wasm->Wasm trampoline the same signature to Wasm->JS so that we can just call a thunk in one callsite, and which can handle both Wasm->JS and Wasm->Wasm. This patch removes Wasm->Wasm special handling. We rename WasmToEmbedderStub to ImportFunctionStub and we set either Wasm->JS or Wasm->Wasm trampoline to this slot. * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::addCall): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addCall): * Source/JavaScriptCore/wasm/WasmInstance.h: (JSC::Wasm::Instance::offsetOfImportFunctionStub): (JSC::Wasm::Instance::offsetOfWasmToEmbedderStub): Deleted. * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::doWasmCall): * Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp: (JSC::JSWebAssemblyInstance::finalizeCreation): * Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h: * Source/JavaScriptCore/wasm/js/WebAssemblyWrapperFunction.cpp: (JSC::WebAssemblyWrapperFunction::create): Canonical link: https://commits.webkit.org/259329@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c089e: Cherry-pick 252432.840@safari-7614-branch (56f36c0...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c089e68eb066333c057a99dd3a511fd3495e5bf https://github.com/WebKit/WebKit/commit/3c089e68eb066333c057a99dd3a511fd3495e5bf Author: Aditya Keerthi Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm Log Message: --- Cherry-pick 252432.840@safari-7614-branch (56f36c096a15). rdar://104609397 Share Sheet may parse complex image formats https://bugs.webkit.org/show_bug.cgi?id=248097 rdar://99294213 Reviewed by Jonathan Bedard and Tim Horton. When a URL is given to the Share Sheet, the Share Sheet displays a thumbnail defined by the URL, in the UIProcess. The Web Share API allows the URL to be handed to the UIProcess from the WebProcess, via IPC. Consequently, there exists a way to trigger image decoding in the UIProcess from a compromised WebProcess, or one-click from a user. To fix, display a placeholder icon rather than showing a thumbnail defined by the URL in the Share Sheet. This behavior is achieved by specifying partial `LPLinkMetadata`. * Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm: (-[WKShareSheetURLItemProvider initWithURL:]): Mark the metadata as incomplete so that it may be refetched when the URL is actually shared. (-[WKShareSheetURLItemProvider item]): (-[WKShareSheetURLItemProvider activityViewControllerLinkMetadata:]): (-[WKShareSheet presentWithParameters:inRect:completionHandler:]): Only apply this mitigation when the Share Sheet is invoked using the Web Share API. Other contexts require more significant user interaction and are not done through IPC from the WebProcess. Canonical link: https://commits.webkit.org/252432.840@safari-7614-branch Canonical link: https://commits.webkit.org/259328@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 50d7b3: [JSC] Fix misc wasm bugs to expand V8 test coverage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 50d7b35052eb1791708bb5bab76fdcd2558cf12c https://github.com/WebKit/WebKit/commit/50d7b35052eb1791708bb5bab76fdcd2558cf12c Author: Yusuke Suzuki Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M JSTests/wasm/function-references/ref_types.js M JSTests/wasm/gc/arrays.js M JSTests/wasm/gc/i31.js M JSTests/wasm/gc/structs.js M JSTests/wasm/references/func_ref.js M JSTests/wasm/references/globals.js M JSTests/wasm/stress/global-wrong-type.js M JSTests/wasm/stress/mutable-globals.js M JSTests/wasm/v8/atomics.js M JSTests/wasm/v8/bit-shift-right.js M JSTests/wasm/v8/divrem-trap.js M JSTests/wasm/v8/export-global.js M JSTests/wasm/v8/export-table.js M JSTests/wasm/v8/externref-table.js M JSTests/wasm/v8/externref.js M JSTests/wasm/v8/ffi-error.js M JSTests/wasm/v8/indirect-call-non-zero-table.js M JSTests/wasm/v8/indirect-calls.js M JSTests/wasm/v8/indirect-tables.js M JSTests/wasm/v8/js-api.js M JSTests/wasm/v8/reference-tables.js M JSTests/wasm/v8/resources/wasm-module-builder.js M JSTests/wasm/v8/start-function.js M JSTests/wasm/v8/table-access.js M JSTests/wasm/v8/table-copy-externref.js M JSTests/wasm/v8/table-fill.js M JSTests/wasm/v8/table-grow-from-wasm.js M JSTests/wasm/v8/table-grow.js M JSTests/wasm/v8/table.js M JSTests/wasm/v8/unicode.js M Source/JavaScriptCore/wasm/WasmExceptionType.h M Source/JavaScriptCore/wasm/WasmGlobal.cpp M Source/JavaScriptCore/wasm/WasmInstance.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h M Source/JavaScriptCore/wasm/js/WebAssemblyGlobalConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyModuleConstructor.cpp Log Message: --- [JSC] Fix misc wasm bugs to expand V8 test coverage https://bugs.webkit.org/show_bug.cgi?id=251122 rdar://104623519 Reviewed by Mark Lam and Justin Michaud. This patch fixes misc wasm issues to unlock some of V8 wasm tests. This expands V8 wasm test coverage and defends against the future bug introduction. * JSTests/wasm/function-references/ref_types.js: (async testRefTypeParamCheck): (async testRefGlobalCheck): (async testExternFuncrefNonNullCheck): (async testWasmJSGlobals): * JSTests/wasm/gc/arrays.js: * JSTests/wasm/gc/i31.js: * JSTests/wasm/gc/structs.js: * JSTests/wasm/references/func_ref.js: (assert.throws): (GetLocal.0.I32Const.0.TableSet.0.End.End.WebAssembly.assert.throws): (GetLocal.0.I32Const.0.TableSet.0.End.End.WebAssembly): (makeFuncrefIdent): * JSTests/wasm/references/globals.js: (async testGlobalConstructorForFuncref): * JSTests/wasm/stress/global-wrong-type.js: (assert.throws): * JSTests/wasm/stress/mutable-globals.js: * JSTests/wasm/v8/atomics.js: (TestIllegalAtomicOp): * JSTests/wasm/v8/bit-shift-right.js: * JSTests/wasm/v8/divrem-trap.js: * JSTests/wasm/v8/export-global.js: (duplicateGlobalExportName): * JSTests/wasm/v8/export-table.js: (testExportNameClash): * JSTests/wasm/v8/externref-table.js: * JSTests/wasm/v8/externref.js: (testGCInStackCheck): * JSTests/wasm/v8/ffi-error.js: (checkFailingInstantiation): (testInvalidFFIs): * JSTests/wasm/v8/indirect-call-non-zero-table.js: * JSTests/wasm/v8/indirect-calls.js: * JSTests/wasm/v8/indirect-tables.js: (InitImportedTableSignatureMismatch): (TestNonImportedGlobalInElementSegment): * JSTests/wasm/v8/js-api.js: (get assertThrows): (set assertThrows): (set let): * JSTests/wasm/v8/reference-tables.js: * JSTests/wasm/v8/resources/wasm-module-builder.js: (assertTrapsOneOf): * JSTests/wasm/v8/start-function.js: (testInvalidIndex): (testRun2): Deleted. (testStartFFI.ffi.gak.foo): Deleted. (testStartFFI): Deleted. (testStartFunctionThrowsExplicitly.ffi.foo.throw_fn): Deleted. (testStartFunctionThrowsExplicitly): Deleted. * JSTests/wasm/v8/table-access.js: * JSTests/wasm/v8/table-copy-externref.js: * JSTests/wasm/v8/table-fill.js: * JSTests/wasm/v8/table-grow-from-wasm.js: * JSTests/wasm/v8/table-grow.js: * JSTests/wasm/v8/table.js: (TestConstructor): (TestMaximumIsReadOnce.): Deleted. (TestMaximumDoesHasProperty.): Deleted. (TestMaximumDoesHasProperty): Deleted. (TestLength): Deleted. (TestGrow.init): Deleted. (TestGrow.check): Deleted. (TestGrow): Deleted. (TestGrowWithInit.getDummy): Deleted. (TestGrowWithInit): Deleted. * JSTests/wasm/v8/unicode.js: (errorMessageUnicodeInFuncName): * Source/JavaScriptCore/wasm/WasmExceptionType.h: (JSC::Wasm::isTypeErrorExceptionType): * Source/JavaScriptCore/wasm/WasmGlobal.cpp: (JSC::Wasm::Global::set): * Source/JavaScriptCore/wasm/WasmInstance.cpp: (JSC::Wasm::Instance::initElementSegment): * Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h: (JSC::fromJSValue): * Source/JavaScriptCore/wasm/js/WebAssemblyGlobalConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/wasm/js/WebAssemblyModuleConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link:
[webkit-changes] [WebKit/WebKit] 212955: Web Inspector: Screenshots timeline is unsupported...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2129556ec693c9909c60b6576f8a1c08c9f03a4d https://github.com/WebKit/WebKit/commit/2129556ec693c9909c60b6576f8a1c08c9f03a4d Author: Patrick Angle Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebInspectorUI/UserInterface/Models/ScreenshotsInstrument.js Log Message: --- Web Inspector: Screenshots timeline is unsupported in WebKitLegacy, we should disable it when inspect such targets https://bugs.webkit.org/show_bug.cgi?id=244301 rdar://problem/99094864 Reviewed by Devin Rousso and BJ Burg. Screenshots are taken when a composite occurs to populate the screenshots timeline. Composites do not occurs for the same types of updates in WebKitLegacy as they do in WebKit2. Due to this, the timeline currently appears broken on WebKitLegacy targets. Until we can do the work in webkit.org/b/251113 to support WebKitLegacy, we instead will disable the Screenshots timeline when inspecting WebKitLegacy targets (the "Page" debuggable type, as opposed to the WK2 "Web Page" debuggable type). * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebInspectorUI/UserInterface/Models/ScreenshotsInstrument.js: (WI.ScreenshotsInstrument.supported): Canonical link: https://commits.webkit.org/259326@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6af44: REGRESSION(258644@main): The control look...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6af447cab8cbceedc894aaf219b4ce25d6724b8 https://github.com/WebKit/WebKit/commit/b6af447cab8cbceedc894aaf219b4ce25d6724b8 Author: Said Abou-Hallawa Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/platform/graphics/GraphicsContext.cpp M Source/WebCore/platform/graphics/GraphicsContext.h M Source/WebCore/platform/graphics/controls/ControlPart.cpp M Source/WebCore/platform/graphics/controls/ControlPart.h M Source/WebCore/platform/graphics/controls/PlatformControl.h M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h M Source/WebCore/platform/graphics/mac/controls/ButtonMac.h M Source/WebCore/platform/graphics/mac/controls/ButtonMac.mm M Source/WebCore/platform/graphics/mac/controls/ColorWellMac.h M Source/WebCore/platform/graphics/mac/controls/ColorWellMac.mm M Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.h M Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm M Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h M Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.mm M Source/WebCore/platform/graphics/mac/controls/MenuListButtonMac.h M Source/WebCore/platform/graphics/mac/controls/MenuListButtonMac.mm M Source/WebCore/platform/graphics/mac/controls/MenuListMac.h M Source/WebCore/platform/graphics/mac/controls/MenuListMac.mm M Source/WebCore/platform/graphics/mac/controls/MeterMac.h M Source/WebCore/platform/graphics/mac/controls/MeterMac.mm M Source/WebCore/platform/graphics/mac/controls/ProgressBarMac.h M Source/WebCore/platform/graphics/mac/controls/ProgressBarMac.mm M Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.h M Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.mm M Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.h M Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.mm M Source/WebCore/platform/graphics/mac/controls/SliderThumbMac.h M Source/WebCore/platform/graphics/mac/controls/SliderThumbMac.mm M Source/WebCore/platform/graphics/mac/controls/SliderTrackMac.h M Source/WebCore/platform/graphics/mac/controls/SliderTrackMac.mm M Source/WebCore/platform/graphics/mac/controls/TextAreaMac.h M Source/WebCore/platform/graphics/mac/controls/TextAreaMac.mm M Source/WebCore/platform/graphics/mac/controls/TextFieldMac.h M Source/WebCore/platform/graphics/mac/controls/TextFieldMac.mm M Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.h M Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.mm M Source/WebCore/rendering/RenderTheme.cpp M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h Log Message: --- REGRESSION(258644@main): The control looks dark when zooming in https://bugs.webkit.org/show_bug.cgi?id=250798 rdar://104196022 Reviewed by Simon Fraser. Calling getRoundedBorderFor() was dropped in 258644@main when refactoring the MenuListButton drawing to go through GraphicsContext. This caused the left and right border gradients to be not clipped. And this made the background of the control part to be filled with the border gradient which is dark gray. Because we do not have access to the RenderStyle in platform/graphics, we have to calculate getRoundedBorderFor() the control part rect in RenderTheme::paint() and pass it all the way to GraphicsContext and to DisplayList::Recorder. * Source/WebCore/platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawControlPart): * Source/WebCore/platform/graphics/GraphicsContext.h: * Source/WebCore/platform/graphics/controls/ControlPart.cpp: (WebCore::ControlPart::draw const): * Source/WebCore/platform/graphics/controls/ControlPart.h: * Source/WebCore/platform/graphics/controls/PlatformControl.h: (WebCore::PlatformControl::draw): * Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp: (WebCore::DisplayList::DrawControlPart::DrawControlPart): (WebCore::DisplayList::DrawControlPart::apply): (WebCore::DisplayList::dumpItem): * Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:
[webkit-changes] [WebKit/WebKit] d000f8: InlineIterator::Box:logicalLeft/right do not retur...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d000f817a148e8372018d70c108928651acff39c https://github.com/WebKit/WebKit/commit/d000f817a148e8372018d70c108928651acff39c Author: Alan Baradlay Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/layout/integration/inline/InlineIteratorBox.h M Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderInline.cpp M Source/WebCore/rendering/RenderLineBreak.cpp M Source/WebCore/rendering/RenderText.cpp Log Message: --- InlineIterator::Box:logicalLeft/right do not return entirely logical values https://bugs.webkit.org/show_bug.cgi?id=251098 Reviewed by Antti Koivisto. Rename logicalLeft/right to logicalLeft(right)IgnoringInlineDirection to reflect what values they really return. This is a combination of visual and logical values where we use the visual position in inline direction, but don't flip the coordinates for writing mode (e.g vertical). This helps to identify potential coordinate space mismatching at callsites (where we expect logicalLeft return logical value for right-to-left direction.) * Source/WebCore/layout/integration/inline/InlineIteratorBox.h: (WebCore::InlineIterator::Box::logicalTop const): (WebCore::InlineIterator::Box::logicalBottom const): (WebCore::InlineIterator::Box::logicalHeight const): (WebCore::InlineIterator::Box::logicalWidth const): (WebCore::InlineIterator::Box::logicalLeftIgnoringInlineDirection const): (WebCore::InlineIterator::Box::logicalRightIgnoringInlineDirection const): (WebCore::InlineIterator::Box::logicalRectIgnoringInlineDirection const): (WebCore::InlineIterator::Box::logicalLeft const): Deleted. (WebCore::InlineIterator::Box::logicalRight const): Deleted. * Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp: (WebCore::InlineIterator::closestBoxForHorizontalPosition): * Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp: (WebCore::InlineIterator::TextBox::selectionRect const): (WebCore::InlineIterator::TextBox::offsetForPosition const): (WebCore::InlineIterator::TextBox::positionForOffset const): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::inlineSelectionGaps): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::positionWithRTLInlineBoxContainingBlock): * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::innerPaddingBoxWidth const): (WebCore::RenderInline::offsetForInFlowPositionedInline const): * Source/WebCore/rendering/RenderText.cpp: (WebCore::lineDirectionPointFitsInBox): (WebCore::RenderText::positionForPoint): Canonical link: https://commits.webkit.org/259324@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 527e2a: Fix race condition for wasm referenced functions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 527e2a01d73c94cc018b1fa060fdffc15bab69d6 https://github.com/WebKit/WebKit/commit/527e2a01d73c94cc018b1fa060fdffc15bab69d6 Author: Yijia Huang Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A JSTests/wasm/stress/referenced-function.js A JSTests/wasm/stress/resources/funcref-race.wasm M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp M Source/JavaScriptCore/wasm/WasmModuleInformation.h M Source/JavaScriptCore/wasm/WasmSectionParser.cpp M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/BitVector.h M Source/WTF/wtf/CMakeLists.txt A Source/WTF/wtf/FixedBitVector.h M Tools/TestWebKitAPI/CMakeLists.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WTF/FixedBitVector.cpp Log Message: --- Fix race condition for wasm referenced functions https://bugs.webkit.org/show_bug.cgi?id=250847 rdar://104332636 Reviewed by Mark Lam. Fix race condition for updating referenced functions while compiling wasm functions concurrently. * JSTests/wasm/stress/referenced-function.js: Added. (async let): (j.catch): * JSTests/wasm/stress/resources/funcref-race.wasm: Added. * Source/JavaScriptCore/wasm/WasmBBQPlan.cpp: (JSC::Wasm::BBQPlan::compileFunction): * Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation): * Source/JavaScriptCore/wasm/WasmModuleInformation.h: (JSC::Wasm::ModuleInformation::referencedFunctions const): (JSC::Wasm::ModuleInformation::hasReferencedFunction const): (JSC::Wasm::ModuleInformation::addReferencedFunction const): * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/CMakeLists.txt: * Source/WTF/wtf/FixedBitVector.h: Added. (WTF::FixedBitVector::concurrentAllocateOnce): (WTF::FixedBitVector::concurrentTest): (WTF::FixedBitVector::concurrentTestAndSet): (WTF::FixedBitVector::testAndSet): (WTF::FixedBitVector::test): (WTF::FixedBitVector::findBit const): (WTF::FixedBitVector::operator== const): (WTF::FixedBitVector::hash const): (WTF::FixedBitVector::get const): (WTF::FixedBitVector::dump const): (WTF::FixedBitVectorHash::hash): (WTF::FixedBitVectorHash::equal): * Tools/TestWebKitAPI/CMakeLists.txt: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WTF/FixedBitVector.cpp: Added. (TestWebKitAPI::testFixedBitVectorSize): (TestWebKitAPI::testFixedBitVectorTest): (TestWebKitAPI::testFixedBitVectorTestAndSet): (TestWebKitAPI::testFixedBitVectorConcurrentTest): (TestWebKitAPI::testFixedBitVectorConcurrentTestAndSet): (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/259323@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b0db30: [ui-Side compositing] Support custom scrollbars
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b0db30ddd932ac3b92d3f3f814b7f9e22a7bf989 https://github.com/WebKit/WebKit/commit/b0db30ddd932ac3b92d3f3f814b7f9e22a7bf989 Author: Nikolaos Mouchtaris Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/page/FrameView.cpp M Source/WebCore/page/FrameView.h M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h M Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm M Source/WebCore/platform/ScrollTypes.cpp M Source/WebCore/platform/ScrollTypes.h M Source/WebCore/platform/ScrollableArea.h M Source/WebCore/platform/Scrollbar.cpp M Source/WebCore/platform/Scrollbar.h M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm M Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp M Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.cpp Log Message: --- [ui-Side compositing] Support custom scrollbars https://bugs.webkit.org/show_bug.cgi?id=250926 rdar://103890177 Reviewed by Simon Fraser. Since custom scrollbars are currently handled correctly with UI-side compositing, we just need to hide the native scrollbars. We do this by making ScrollbarHiddenByStyle an enum which can now be hidden by custom scrollbars as well. When this gets plumbed to the UIProcess side, check the ScrollableArea parameters to see if we want to hide the native scrollbars or not. * Source/WebCore/page/FrameView.cpp: (WebCore::FrameView::horizontalScrollbarHidden const): (WebCore::FrameView::verticalScrollbarHidden const): (WebCore::FrameView::horizontalScrollbarHiddenByStyle const): Deleted. (WebCore::FrameView::verticalScrollbarHiddenByStyle const): Deleted. * Source/WebCore/page/FrameView.h: * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry): * Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp: (WebCore::operator<<): * Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h: (WebCore::ScrollableAreaParameters::operator== const): * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h: (WebCore::ScrollingTreeScrollingNodeDelegate::updateScrollbarsFromStateNode): * Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h: * Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::updateScrollbarsFromStateNode): * Source/WebCore/platform/ScrollTypes.cpp: (WebCore::operator<<): * Source/WebCore/platform/ScrollTypes.h: * Source/WebCore/platform/ScrollableArea.h: (WebCore::ScrollableArea::horizontalScrollbarHidden const): (WebCore::ScrollableArea::verticalScrollbarHidden const): (WebCore::ScrollableArea::horizontalScrollbarHiddenByStyle const): Deleted. (WebCore::ScrollableArea::verticalScrollbarHiddenByStyle const): Deleted. * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::LegacyWebKitScrollingLayerCoordinator::updateScrollingLayer): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::horizontalScrollbarHidden const): (WebCore::RenderLayerScrollableArea::verticalScrollbarHidden const): (WebCore::RenderLayerScrollableArea::horizontalScrollbarHiddenByStyle const): Deleted. (WebCore::RenderLayerScrollableArea::verticalScrollbarHiddenByStyle const): Deleted. * Source/WebCore/rendering/RenderLayerScrollableArea.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren): * Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp: (WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::commitStateBeforeChildren): * Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.cpp: (WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::commitStateBeforeChildren): Canonical link: https://commits.webkit.org/259322@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org
[webkit-changes] [WebKit/WebKit] 0675bb: Cherry-pick 252432.838@safari-7614-branch (6651709...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0675bbf6a5db80a0dbf04ae7a7485a09b056d032 https://github.com/WebKit/WebKit/commit/0675bbf6a5db80a0dbf04ae7a7485a09b056d032 Author: Arunsundar Kannan Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/fast/forms/textfield-input-type-crash-onblur-expected.txt A LayoutTests/fast/forms/textfield-input-type-crash-onblur.html M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLOptionElement.cpp M Source/WebCore/html/TextFieldInputType.cpp Log Message: --- Cherry-pick 252432.838@safari-7614-branch (665170902bfa). rdar://104601528 UAF crash occurs during a style update when an older freed HTMLElement is accessed https://bugs.webkit.org/show_bug.cgi?id=247389 rdar://101420898 Reviewed by Ryosuke Niwa and Ryan Haddad. * LayoutTests/fast/forms/textfield-input-type-crash-onblur-expected.txt: Added. * LayoutTests/fast/forms/textfield-input-type-crash-onblur.html: Added. * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dataListMayHaveChanged): * Source/WebCore/html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged): * Source/WebCore/html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::createDataListDropdownIndicator): (WebCore::TextFieldInputType::dataListMayHaveChanged): Canonical link: https://commits.webkit.org/252432.838@safari-7614-branch Canonical link: https://commits.webkit.org/259321@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 827706: Web Inspector: Embedder settings are not being per...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 827706a34ae74ff5f6b0b6dcb0bcd017860c4d48 https://github.com/WebKit/WebKit/commit/827706a34ae74ff5f6b0b6dcb0bcd017860c4d48 Author: Patrick Angle Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/Scripts/GeneratePreferences.rb Log Message: --- Web Inspector: Embedder settings are not being persisted, preventing Web Inspector from remembering which side of the window it was attached to https://bugs.webkit.org/show_bug.cgi?id=251110 rdar://104603328 Reviewed by Brent Fulgham and Elliott Williams. Embedder settings should persist to restore behavior prior to 258448@main. This allows Web Inspector to load its width/height/attached side/window state from defaults like before. * Source/WTF/Scripts/GeneratePreferences.rb: Canonical link: https://commits.webkit.org/259320@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 91c8c8: Cherry-pick 252432.826@safari-7614-branch (baca9af...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91c8c8744db1506c01a913220608cc3d33a75a09 https://github.com/WebKit/WebKit/commit/91c8c8744db1506c01a913220608cc3d33a75a09 Author: Chris Dumez Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/HistoryController.cpp M Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm Log Message: --- Cherry-pick 252432.826@safari-7614-branch (baca9afc289e). rdar://104600755 Properly mark history items added without user gesture https://bugs.webkit.org/show_bug.cgi?id=247909 rdar://100579077 Reviewed by Geoffrey Garen. We recently introduced logic to mark history items as "created by JavaScript without a user gesture" so that those could be skipped when the user navigates back/forward via the browser UI. However, which history items we marked with such flag was a little unexpected and didn't quite match what Chrome did to address the same problem. In particular, if on URL1 and then calling `pushState(null, null, 'a')` in JS without a user gesture. We would previously mark the HistoryItem for URL1 as created without a user gesture, instead of marking the one for URL1#a. URL1#a is the actual HistoryItem created by JS so it makes more sense to mark this one (which also matches Chrome's behavior). * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): * Source/WebCore/loader/HistoryController.cpp: (WebCore::FrameLoader::HistoryController::pushState): * Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm: (TEST): Canonical link: https://commits.webkit.org/252432.826@safari-7614-branch Canonical link: https://commits.webkit.org/259319@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 83826f: [WebGPU] Extra deref of SwapChainImpl::m_backing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 83826f3fef4076f2c5be36785b2799f351bf1c78 https://github.com/WebKit/WebKit/commit/83826f3fef4076f2c5be36785b2799f351bf1c78 Author: Mike Wyrzykowski Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.cpp M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.cpp Log Message: --- [WebGPU] Extra deref of SwapChainImpl::m_backing https://bugs.webkit.org/show_bug.cgi?id=250963 Reviewed by Myles C. Maxfield. WebGPUSurfaceImpl and WebGPUSwapChainImpl called release in both destroy and their destructor, resulting in a double release. Fix this issue by setting the backing to null when the object is released. * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.cpp: (PAL::WebGPU::SurfaceImpl::destroy): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.cpp: (PAL::WebGPU::SwapChainImpl::~SwapChainImpl): (PAL::WebGPU::SwapChainImpl::destroy): Canonical link: https://commits.webkit.org/259318@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4bfba2: [JSC] Update Intl.DurationFormat based on Jan ECMA...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4bfba24bc18e04141df7181b750dcebea75e3845 https://github.com/WebKit/WebKit/commit/4bfba24bc18e04141df7181b750dcebea75e3845 Author: Yusuke Suzuki Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M JSTests/stress/intl-durationformat-format-to-parts.js M JSTests/stress/intl-durationformat.js M Source/JavaScriptCore/runtime/IntlDurationFormat.cpp M Source/JavaScriptCore/runtime/IntlDurationFormatPrototype.cpp Log Message: --- [JSC] Update Intl.DurationFormat based on Jan ECMA402 consensus https://bugs.webkit.org/show_bug.cgi?id=251115 rdar://104582024 Reviewed by Mark Lam. This patch upgrades Intl.DurationFormat implementation to align it to Jan ECMA402 meeting consensus. The changes are three-fold. 1. format and formatToParts should accept String too. And throwing a range error when string is not valid[1]. 2. formatToParts should use singular form of unit names instead of plural form. 3. formatToParts should split each unit's representation to make numeric part and unit part accessible[3]. Previously, we just grouped "1 hour" as "hour" part. But after this, we split it into "1" integer, " " literal, and "hour" unit, with unit = "hour". [1]: https://github.com/tc39/proposal-intl-duration-format/issues/128 [2]: https://github.com/tc39/proposal-intl-duration-format/issues/44 [3]: https://github.com/tc39/proposal-intl-duration-format/issues/55 * JSTests/stress/intl-durationformat-format-to-parts.js: (Intl.DurationFormat.shouldBe.JSON.stringify.fmt.formatToParts): (Intl.DurationFormat.shouldBeOneOf): * JSTests/stress/intl-durationformat.js: (test): * Source/JavaScriptCore/runtime/IntlDurationFormat.cpp: (JSC::collectElements): (JSC::IntlDurationFormat::formatToParts const): * Source/JavaScriptCore/runtime/IntlDurationFormatPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/259317@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 102ec0: Fix logging related performance issue
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 102ec0394008a5a57ded222cc1030edc364a5d69 https://github.com/WebKit/WebKit/commit/102ec0394008a5a57ded222cc1030edc364a5d69 Author: Per Arne Vollan Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Fix logging related performance issue https://bugs.webkit.org/show_bug.cgi?id=251101 rdar://103268668 Reviewed by Brent Fulgham. Do not specify live stream mode when setting trace mode, since that is a performance regression due to increased XPC activity. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::initializeLogd): (isInternalBuild): Deleted. Canonical link: https://commits.webkit.org/259316@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7615.1.16.1.6 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec082c: Versioning.
Branch: refs/heads/safari-7615.1.16.1-branch Home: https://github.com/WebKit/WebKit Commit: ec082c0ab92059b8a8af48bf1821ef774794a65a https://github.com/WebKit/WebKit/commit/ec082c0ab92059b8a8af48bf1821ef774794a65a Author: Alan Coon Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7615.1.16.1.6 Canonical link: https://commits.webkit.org/257979.24@safari-7615.1.16.1-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aada34: [ews-build.webkit.org] Convert CheckStatusOnEWSQue...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aada3442f5bf579f8b120bbd338dd4695f64fea9 https://github.com/WebKit/WebKit/commit/aada3442f5bf579f8b120bbd338dd4695f64fea9 Author: Jonathan Bedard Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews-build.webkit.org] Convert CheckStatusOnEWSQueues to Twisted requests https://bugs.webkit.org/show_bug.cgi?id=250880 rdar://104454268 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (CheckStatusOnEWSQueues): Convert to new-style. (CheckStatusOnEWSQueues.get_change_status): Return defered object and use Twisted asynchronous requests. (CheckStatusOnEWSQueues.run): Renamed from 'start'. (CheckStatusOnEWSQueues.start): Renamed to 'run'. Canonical link: https://commits.webkit.org/259315@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 801710: Address v3 sandbox telemetry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8017100ed6759f04b06bfbac676a151e0ab9d9de https://github.com/WebKit/WebKit/commit/8017100ed6759f04b06bfbac676a151e0ab9d9de Author: Per Arne Vollan Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Log Message: --- Address v3 sandbox telemetry https://bugs.webkit.org/show_bug.cgi?id=250329 rdar://104037745 Reviewed by Chris Dumez. Address v3 sandbox telemetry on iOS. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Canonical link: https://commits.webkit.org/259314@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7e8a23: [macOS] Fix sandbox related error message
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7e8a23f0c35a867c4fb8c2f9fd7ab41da855d454 https://github.com/WebKit/WebKit/commit/7e8a23f0c35a867c4fb8c2f9fd7ab41da855d454 Author: Per Arne Vollan Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm Log Message: --- [macOS] Fix sandbox related error message https://bugs.webkit.org/show_bug.cgi?id=251093 rdar://104607120 Reviewed by Chris Dumez. On macOS, creating a generic Mach bootstrap sandbox extension is currently failing. We can temporarily disable creating this sandbox extension on macOS. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm: (WebKit::SandboxExtension::createHandlesForMachLookup): Canonical link: https://commits.webkit.org/259313@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ffc98c: [WebGPU] Align SurfaceDescriptor and SwapChainDesc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ffc98ceb72ee397bd83b6d7d711fcb760b712c34 https://github.com/WebKit/WebKit/commit/ffc98ceb72ee397bd83b6d7d711fcb760b712c34 Author: Myles C. Maxfield Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/Modules/WebGPU/GPUSurfaceDescriptor.h M Source/WebCore/Modules/WebGPU/GPUSwapChainDescriptor.h M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp M Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUSurfaceDescriptor.h M Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUSwapChainDescriptor.h M Source/WebCore/html/canvas/GPUCanvasContextCocoa.cpp M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm M Source/WebGPU/WebGPU/WebGPUExt.h M Source/WebKit/Shared/WebGPU/WebGPUSurfaceDescriptor.cpp M Source/WebKit/Shared/WebGPU/WebGPUSurfaceDescriptor.h M Source/WebKit/Shared/WebGPU/WebGPUSurfaceDescriptor.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUSwapChainDescriptor.cpp M Source/WebKit/Shared/WebGPU/WebGPUSwapChainDescriptor.h M Source/WebKit/Shared/WebGPU/WebGPUSwapChainDescriptor.serialization.in Log Message: --- [WebGPU] Align SurfaceDescriptor and SwapChainDescriptor with the spec and WebGPU.h https://bugs.webkit.org/show_bug.cgi?id=250994 rdar://104539553 Reviewed by Dean Jackson. Conceptually, a Surface corresponds to a GPUCanvasContext, and a SwapChain corresponds to a call to GPUCanvasContext.configure(). Both the spec and WebGPU.h agree that the Surface should be constructable with almost nothing - you don't even need a device or any WebGPU objects to create a GPUCanvasContext object from a canvas. Creating a swap chain (via GPUCanvasContext.configure()) is where the guts are - that's where all the properties of the textures are specified, so that's where we can finally create IOSurfaces. Right now, we treat Surfaces and SwapChains as siblings - they have the same lifetime inside GPUCanvasContext.cpp, so this patch is purely mechanical right now. However, there will be 2 follow-up patches in the future: 1. Connecting CompositorIntegration (from https://github.com/WebKit/WebKit/pull/8933) to Surface. This will provide a natural owner for the IOSurface renderbuffers, as well as a message receiver so these IOSurfaces can be communicated to the compositor. Mechanically, this change will add a CompositorIntegration inside SurfaceDescriptor. 2. We can move the lifetime of Surface to be created a bit earlier than SwapChain, because there's no reason to delay creating it; it can be created with almost no information. A special note about width and height: The WebGPU spec used to include these as arguments to GPUCanvasContext.configure(), but we changed the spec to have that information come from the canvas itself rather than being supplied by the site author. So, conceptually, these fields still belong in the SwapChainDescriptor, and they are present there in this patch. This also matches what WebGPU.h says - those fields are present in the SwapChainDescriptor. * Source/WebCore/Modules/WebGPU/GPUSurfaceDescriptor.h: (WebCore::GPUSurfaceDescriptor::convertToBacking const): (): Deleted. * Source/WebCore/Modules/WebGPU/GPUSwapChainDescriptor.h: (WebCore::GPUSwapChainDescriptor::convertToBacking const): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp: (PAL::WebGPU::DeviceImpl::createSurface): (PAL::WebGPU::DeviceImpl::createSwapChain): (PAL::WebGPU::convertToWidthHeight): Deleted. * Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUSurfaceDescriptor.h: (): Deleted. * Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUSwapChainDescriptor.h: * Source/WebCore/html/canvas/GPUCanvasContext.cpp: (WebCore::GPUCanvasContext::createSwapChainIfNeeded): * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: (WebGPU::createIOSurface): (WebGPU::createSurfaceFromDescriptor): (WebGPU::PresentationContextIOSurface::PresentationContextIOSurface): (WebGPU::PresentationContextIOSurface::configure): * Source/WebGPU/WebGPU/WebGPUExt.h: * Source/WebKit/Shared/WebGPU/WebGPUSurfaceDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUSurfaceDescriptor.h: (): Deleted. * Source/WebKit/Shared/WebGPU/WebGPUSurfaceDescriptor.serialization.in: * Source/WebKit/Shared/WebGPU/WebGPUSwapChainDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUSwapChainDescriptor.h: * Source/WebKit/Shared/WebGPU/WebGPUSwapChainDescriptor.serialization.in: Canonical link: https://commits.webkit.org/259312@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org
[webkit-changes] [WebKit/WebKit] faff4e: Document::m_cssTarget should be a smart pointer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: faff4e3fa083f0e35147b423338648f11412791c https://github.com/WebKit/WebKit/commit/faff4e3fa083f0e35147b423338648f11412791c Author: Ryosuke Niwa Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h Log Message: --- Document::m_cssTarget should be a smart pointer https://bugs.webkit.org/show_bug.cgi?id=251104 Reviewed by Chris Dumez. Use WeakPtr instead of a raw pointer for Document::m_cssTarget. * Source/WebCore/dom/Document.cpp: (WebCore::Document::cssTarget const): * Source/WebCore/dom/Document.h: (WebCore::Document::cssTarget const): Deleted. Canonical link: https://commits.webkit.org/259311@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1eae4d: pointerevents/ios/touch-action-region-dynamic.html...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1eae4d548a3a2cc77c9e41b70ff3663d7a6ea56f https://github.com/WebKit/WebKit/commit/1eae4d548a3a2cc77c9e41b70ff3663d7a6ea56f Author: Mike Wyrzykowski Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/pointerevents/ios/touch-action-region-dynamic-expected.txt Log Message: --- pointerevents/ios/touch-action-region-dynamic.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=251105 Reviewed by Simon Fraser. This appears to be another progression from the commit from August, previously the event regions were outside the layer bounds and now they no longer are. * LayoutTests/pointerevents/ios/touch-action-region-dynamic-expected.txt: Updated expectations. Canonical link: https://commits.webkit.org/259310@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b0c23: [WPE][GTK] Sandbox should not allow mounting entir...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b0c2332b9a6becb2a7b84058c42f02e2ac00c75 https://github.com/WebKit/WebKit/commit/4b0c2332b9a6becb2a7b84058c42f02e2ac00c75 Author: Michael Catanzaro Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp Log Message: --- [WPE][GTK] Sandbox should not allow mounting entire home directory https://bugs.webkit.org/show_bug.cgi?id=250231 Reviewed by Carlos Garcia Campos. We should crash if the application tries to mount /home or $HOME in the sandbox. We cannot prevents apps from mounting whatever they wish, but if they want to be stupid they should have to try somewhat harder than that. * Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp: (pathIsUserHomeDirectory): (pathIsBlocked): Canonical link: https://commits.webkit.org/259309@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c270c: Masonry use calculated height instead of estimated...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c270c15b7888c72d8d10e29bc43e40dba71e1d2 https://github.com/WebKit/WebKit/commit/3c270c15b7888c72d8d10e29bc43e40dba71e1d2 Author: Brandon Stewart Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008.html M Source/WebCore/rendering/GridMasonryLayout.cpp M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp M Source/WebCore/rendering/GridTrackSizingAlgorithm.h Log Message: --- Masonry use calculated height instead of estimated height https://bugs.webkit.org/show_bug.cgi?id=250720 Reviewed by Matt Woodrow. The masonry calculations were being done before we had a done a proper layout. With some refactoring the masonry layout was pushed back in the chain. This allows the children content to have calculated the widths and heights. Now, we can just use the real widths and heights instead of relying on the estimated ones. * Source/WebCore/rendering/GridMasonryLayout.cpp: (WebCore::GridMasonryLayout::setItemGridAxisContainingBlockToGridArea): * Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const): * Source/WebCore/rendering/GridTrackSizingAlgorithm.h: * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008.html: Added. Canonical link: https://commits.webkit.org/259308@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 634b3b: [ GARDENING ] [ Ventura Debug ] fast/images/avif-i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 634b3b06d3851a0724d09e669054e47b4db76b64 https://github.com/WebKit/WebKit/commit/634b3b06d3851a0724d09e669054e47b4db76b64 Author: Robert Jenner Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/mac-ventura/TestExpectations Log Message: --- [ GARDENING ] [ Ventura Debug ] fast/images/avif-image-document.html is a flaky crash (251099) https://bugs.webkit.org/show_bug.cgi?id=251099 rdar://104615689 Unreviewed test gardening. * LayoutTests/platform/mac-ventura/TestExpectations: Canonical link: https://commits.webkit.org/259307@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a1613: REGRESSION (255063@main): visibility:visible child...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a1613fa8b157e2deffe4b253d9d211a44c942a3 https://github.com/WebKit/WebKit/commit/7a1613fa8b157e2deffe4b253d9d211a44c942a3 Author: Alan Baradlay Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/fast/block/paint-non-visible-with-visible-child-expected.html A LayoutTests/fast/block/paint-non-visible-with-visible-child.html M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp Log Message: --- REGRESSION (255063@main): visibility:visible child of visibility:hidden button remains invisible https://bugs.webkit.org/show_bug.cgi?id=251000 Reviewed by Antti Koivisto and Darin Adler. Let's not bail out of painting too early for "visibility: hidden". Such inline-block (and inline-block like) boxes may have visible descendants. * LayoutTests/fast/block/paint-non-visible-with-visible-child-expected.html: Added. * LayoutTests/fast/block/paint-non-visible-with-visible-child.html: Added. * Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp: (WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox): Canonical link: https://commits.webkit.org/259306@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f4a94: [WebGPU] Fixup WEBGPU_IMPLEMENTATION macros
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f4a9441ef2fb080b9a802a7ffc822773b3f676d https://github.com/WebKit/WebKit/commit/7f4a9441ef2fb080b9a802a7ffc822773b3f676d Author: Myles C. Maxfield Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/Modules/WebGPU/GPUQueue.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/Document.idl M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/HTMLCanvasElement.h M Source/WebCore/html/HTMLCanvasElement.idl M Source/WebCore/html/canvas/GPUCanvasContextCocoa.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp Log Message: --- [WebGPU] Fixup WEBGPU_IMPLEMENTATION macros https://bugs.webkit.org/show_bug.cgi?id=250967 rdar://104524084 Reviewed by Dean Jackson. WebGPU is already behind a runtime setting. WEBGPU_IMPLEMENTATION exists not to enforce a policy, but instead just to make code compile successfully. All WebKit ports should be able to be hooked up to WebGPU. For Cocoa ports, they are being hooked up to WebGPU.framework. For non-Cocoa ports, they can link with WGPU or Dawn. The WEBGPU_IMPLEMENTATION macro is intended to indicate whether or not a port has started linking with one of those implementations. Almost nothing has to actually be guarded behind it, though, since almost all of the code for WebGPU in WebCore is just platform- independent plumbing that can be built no matter what. The only things that need to be guarded by WEBGPU_IMPLEMENTATION are code that literally call directly into WebGPU.framework. Most of these call sites are in WebCore/PAL/pal/graphics/WebGPU/Impl, plus a few more around GPU creation functions. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/Modules/WebGPU/GPUQueue.cpp: (WebCore::imageBufferForSource): (WebCore::GPUQueue::copyExternalImageToTexture): * Source/WebCore/dom/Document.cpp: (WebCore::Document::getCSSCanvasContext): * Source/WebCore/dom/Document.h: * Source/WebCore/dom/Document.idl: * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): * Source/WebCore/html/HTMLCanvasElement.h: * Source/WebCore/html/HTMLCanvasElement.idl: Canonical link: https://commits.webkit.org/259305@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e34ea9: [WPE] Activate WebGL2 layout tests in WPE port
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e34ea905e1cc84681835f43324b4146ec9f05c1e https://github.com/WebKit/WebKit/commit/e34ea905e1cc84681835f43324b4146ec9f05c1e Author: Alejandro G. Castro Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations R LayoutTests/platform/wpe/webgl/2.0.0/conformance/attribs/gl-bindAttribLocation-aliasing-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance/attribs/gl-bindAttribLocation-matrix-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance/context/premultiplyalpha-test-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-float-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/buffer-copying-contents-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/get-buffer-sub-data-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/one-large-uniform-buffer-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/context/context-attributes-depth-stencil-antialias-obeyed-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/misc/object-deletion-behaviour-2-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/renderbuffers/multisample-with-full-sample-counts-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/renderbuffers/readbuffer-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/rendering/attrib-type-match-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/rendering/blitframebuffer-stencil-only-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/rendering/instanced-arrays-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/state/gl-get-calls-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/copy-texture-image-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/tex-image-with-bad-args-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/tex-srgb-mipmap-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/texture-npot-expected.txt R LayoutTests/platform/wpe/webgl/2.0.0/conformance2/transform_feedback/unwritten-output-defaults-to-zero-expected.txt M LayoutTests/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt M LayoutTests/webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt Log Message: --- [WPE] Activate WebGL2 layout tests in WPE port https://bugs.webkit.org/show_bug.cgi?id=251080 Reviewed by Adrian Perez de Castro and Carlos Garcia Campos. Unskip the WebGL2 tests for WPE port, added some expectations and remove incorrect expected results. * LayoutTests/platform/wpe/TestExpectations: * LayoutTests/platform/wpe/webgl/2.0.0/conformance/attribs/gl-bindAttribLocation-aliasing-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance/attribs/gl-bindAttribLocation-matrix-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance/context/premultiplyalpha-test-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-float-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/buffer-copying-contents-expected.txt: Removed. * LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/get-buffer-sub-data-expected.txt: Removed. *
[webkit-changes] [WebKit/WebKit] 766490: [macOS] TestWebKitAPI.ServiceWorkers API test fail...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76649060e74759fd21a4c39cfc30883e21835271 https://github.com/WebKit/WebKit/commit/76649060e74759fd21a4c39cfc30883e21835271 Author: Miguel Salinas Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h Log Message: --- [macOS] TestWebKitAPI.ServiceWorkers API test failures https://bugs.webkit.org/show_bug.cgi?id=251032 rdar://104436315 Reviewed by Youenn Fablet. Prevent ProcessThrottler from changing WebProcessProxy's throttle state when testing WebProcessProxy's throttle state. * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::setThrottleStateForTesting): (WebKit::WebProcessProxy::didChangeThrottleState): * Source/WebKit/UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::setThrottleStateForTesting): Deleted. Canonical link: https://commits.webkit.org/259303@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 761e29: Port the remaining editing related types to the ne...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 761e29f6a5fd18be9dd2d161de77239d1368e986 https://github.com/WebKit/WebKit/commit/761e29f6a5fd18be9dd2d161de77239d1368e986 Author: Gavin Phillips Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/editing/CompositionHighlight.h M Source/WebCore/editing/FontAttributeChanges.cpp M Source/WebCore/editing/FontAttributeChanges.h M Source/WebCore/editing/FontAttributes.h M Source/WebCore/editing/FontShadow.h M Source/WebCore/editing/TextManipulationController.cpp M Source/WebCore/editing/TextManipulationController.h A Source/WebCore/editing/TextManipulationControllerExclusionRule.h A Source/WebCore/editing/TextManipulationControllerManipulationFailure.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm Log Message: --- Port the remaining editing related types to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=251025 rdar://104574856 Reviewed by Ryosuke Niwa. This change ports the remaining editing base types to the new serialization format. This includes: - FontShadow - CompositionHighlight - FontChanges - FontAttributeChanges - TextManipulationControllerExclusionRule - TextManipulationControllerExclusionRule::Type - TextManipulationControllerExclusionRule::ElementRule - TextManipulationControllerExclusionRule::AttributeRule - TextManipulationControllerExclusionRule::ClassRule - TextManipulationControllerManipulationFailure - TextManipulationControllerManipulationFailure::Type * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/editing/CompositionHighlight.h: (WebCore::CompositionHighlight::encode const): Deleted. (WebCore::CompositionHighlight::decode): Deleted. * Source/WebCore/editing/FontAttributeChanges.cpp: (WebCore::FontChanges::FontChanges): (WebCore::FontAttributeChanges::FontAttributeChanges): * Source/WebCore/editing/FontAttributeChanges.h: (WebCore::FontChanges::encode const): Deleted. (WebCore::FontChanges::decode): Deleted. (WebCore::FontAttributeChanges::encode const): Deleted. (WebCore::FontAttributeChanges::decode): Deleted. * Source/WebCore/editing/FontAttributes.h: * Source/WebCore/editing/FontShadow.h: (WebCore::FontShadow::encode const): Deleted. (WebCore::FontShadow::decode): Deleted. * Source/WebCore/editing/TextManipulationController.cpp: (WebCore::TextManipulationControllerExclusionRule::match const): (WebCore::TextManipulationController::completeManipulation): (WebCore::TextManipulationController::replace): (WebCore::TextManipulationController::ExclusionRule::match const): Deleted. * Source/WebCore/editing/TextManipulationController.h: (WebCore::TextManipulationController::startObservingParagraphs): (WebCore::TextManipulationController::ExclusionRule::encode const): Deleted. (WebCore::TextManipulationController::ExclusionRule::decode): Deleted. (WebCore::TextManipulationController::ExclusionRule::ElementRule::encode const): Deleted. (WebCore::TextManipulationController::ExclusionRule::ElementRule::decode): Deleted. (WebCore::TextManipulationController::ExclusionRule::AttributeRule::encode const): Deleted. (WebCore::TextManipulationController::ExclusionRule::AttributeRule::decode): Deleted. (WebCore::TextManipulationController::ExclusionRule::ClassRule::encode const): Deleted. (WebCore::TextManipulationController::ExclusionRule::ClassRule::decode): Deleted. (WebCore::TextManipulationController::ManipulationFailure::encode const): Deleted. (WebCore::TextManipulationController::ManipulationFailure::decode): Deleted. * Source/WebCore/editing/TextManipulationControllerExclusionRule.h: Copied from Source/WebCore/editing/FontShadow.h. * Source/WebCore/editing/TextManipulationControllerManipulationFailure.h: Copied from Source/WebCore/editing/FontShadow.h. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/259302@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b02c2: GamepadManager should use WeakHashMap instead of H...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b02c29900705e60f0f8f6acbe01158e1126e086 https://github.com/WebKit/WebKit/commit/0b02c29900705e60f0f8f6acbe01158e1126e086 Author: Ryosuke Niwa Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/Modules/gamepad/GamepadManager.cpp M Source/WebCore/Modules/gamepad/GamepadManager.h M Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp M Source/WebCore/Modules/gamepad/NavigatorGamepad.h M Source/WebCore/page/DOMWindow.cpp Log Message: --- GamepadManager should use WeakHashMap instead of HashMap of raw pointers https://bugs.webkit.org/show_bug.cgi?id=251072 Reviewed by Chris Dumez. Use WeakHashMap instead of HashMap of raw pointers in GamepadManager. * Source/WebCore/Modules/gamepad/GamepadManager.cpp: (WebCore::navigatorGamepadFromDOMWindow): (WebCore::GamepadManager::platformGamepadDisconnected): (WebCore::GamepadManager::platformGamepadInputActivity): (WebCore::GamepadManager::makeGamepadVisible): (WebCore::GamepadManager::registerNavigator): (WebCore::GamepadManager::unregisterNavigator): (WebCore::GamepadManager::registerDOMWindow): (WebCore::GamepadManager::unregisterDOMWindow): (WebCore::GamepadManager::maybeStartMonitoringGamepads): (WebCore::GamepadManager::maybeStopMonitoringGamepads): * Source/WebCore/Modules/gamepad/GamepadManager.h: * Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp: (WebCore::NavigatorGamepad::NavigatorGamepad): (WebCore::NavigatorGamepad::~NavigatorGamepad): * Source/WebCore/Modules/gamepad/NavigatorGamepad.h: * Source/WebCore/page/DOMWindow.cpp: (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::incrementGamepadEventListenerCount): (WebCore::DOMWindow::decrementGamepadEventListenerCount): Canonical link: https://commits.webkit.org/259301@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fc6334: DOMTimerHoldingTank should use WeakHashSet
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fc633484894797049f99bb709aa7bb9588cf4d02 https://github.com/WebKit/WebKit/commit/fc633484894797049f99bb709aa7bb9588cf4d02 Author: Ryosuke Niwa Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/page/ios/DOMTimerHoldingTank.cpp M Source/WebCore/page/ios/DOMTimerHoldingTank.h Log Message: --- DOMTimerHoldingTank should use WeakHashSet https://bugs.webkit.org/show_bug.cgi?id=251069 Reviewed by Chris Dumez. Use WeakHashSet of DOMTimer instead of HashMap of raw pointers. * Source/WebCore/page/ios/DOMTimerHoldingTank.cpp: (WebCore::DOMTimerHoldingTank::add): (WebCore::DOMTimerHoldingTank::remove): (WebCore::DOMTimerHoldingTank::contains): * Source/WebCore/page/ios/DOMTimerHoldingTank.h: Canonical link: https://commits.webkit.org/259300@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b98ab5: Remove unnecessary namespace qualifiers from Specu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b98ab5656677ea6fb0d870c690caada987a4c189 https://github.com/WebKit/WebKit/commit/b98ab5656677ea6fb0d870c690caada987a4c189 Author: Keith Miller Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp Log Message: --- Remove unnecessary namespace qualifiers from SpeculativeJIT https://bugs.webkit.org/show_bug.cgi?id=251031 Reviewed by Darin Adler and Mark Lam. * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileFunction): (JSC::DFG::SpeculativeJIT::exceptionCheck): (JSC::DFG::SpeculativeJIT::emitAllocateRawObject): (JSC::DFG::SpeculativeJIT::emitGetLength): (JSC::DFG::SpeculativeJIT::emitGetCallee): (JSC::DFG::SpeculativeJIT::emitGetArgumentStart): (JSC::DFG::SpeculativeJIT::emitOSRExitFuzzCheck): (JSC::DFG::SpeculativeJIT::speculationCheck): (JSC::DFG::SpeculativeJIT::compileInvalidationPoint): (JSC::DFG::SpeculativeJIT::typeCheck): (JSC::DFG::SpeculativeJIT::silentSpill): (JSC::DFG::SpeculativeJIT::silentFill): (JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode): (JSC::DFG::SpeculativeJIT::checkArray): (JSC::DFG::SpeculativeJIT::arrayify): (JSC::DFG::SpeculativeJIT::fillStorage): (JSC::DFG::SpeculativeJIT::compileGetById): (JSC::DFG::SpeculativeJIT::compileGetByIdFlush): (JSC::DFG::SpeculativeJIT::compileDeleteById): (JSC::DFG::SpeculativeJIT::compileDeleteByVal): (JSC::DFG::SpeculativeJIT::compileInById): (JSC::DFG::SpeculativeJIT::compileInByVal): (JSC::DFG::SpeculativeJIT::compileHasPrivate): (JSC::DFG::SpeculativeJIT::compilePushWithScope): (JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch): (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality): (JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch): (JSC::DFG::SpeculativeJIT::compileStringSlice): (JSC::DFG::SpeculativeJIT::compileStringSubstring): (JSC::DFG::SpeculativeJIT::compileToLowerCase): (JSC::DFG::SpeculativeJIT::compilePeepHoleInt32Branch): (JSC::DFG::SpeculativeJIT::compilePeepHoleBranch): (JSC::DFG::SpeculativeJIT::compileLoopHint): (JSC::DFG::SpeculativeJIT::compileCheckDetached): (JSC::DFG::SpeculativeJIT::compileCurrentBlock): (JSC::DFG::SpeculativeJIT::checkArgumentTypes): (JSC::DFG::SpeculativeJIT::compileCheckTraps): (JSC::DFG::SpeculativeJIT::compileContiguousPutByVal): (JSC::DFG::SpeculativeJIT::compileDoublePutByVal): (JSC::DFG::SpeculativeJIT::compilePutByVal): (JSC::DFG::SpeculativeJIT::compileGetCharCodeAt): (JSC::DFG::SpeculativeJIT::compileGetByValOnString): (JSC::DFG::SpeculativeJIT::compileFromCharCode): (JSC::DFG::SpeculativeJIT::compileValueToInt32): (JSC::DFG::SpeculativeJIT::compileUInt32ToNumber): (JSC::DFG::SpeculativeJIT::compileDoubleAsInt32): (JSC::DFG::SpeculativeJIT::compileDoubleRep): (JSC::DFG::SpeculativeJIT::jumpForTypedArrayOutOfBounds): (JSC::DFG::SpeculativeJIT::emitTypedArrayBoundsCheck): (JSC::DFG::SpeculativeJIT::jumpForTypedArrayIsDetachedIfOutOfBounds): (JSC::DFG::SpeculativeJIT::loadFromIntTypedArray): (JSC::DFG::SpeculativeJIT::setIntTypedArrayLoadResult): (JSC::DFG::SpeculativeJIT::getIntTypedArrayStoreOperand): (JSC::DFG::SpeculativeJIT::getIntTypedArrayStoreOperandForAtomics): (JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImm64): (JSC::DFG::SpeculativeJIT::callOperation): (JSC::DFG::SpeculativeJIT::appendCall): (JSC::DFG::SpeculativeJIT::appendCallSetResult): (JSC::DFG::SpeculativeJIT::addBranch): (JSC::DFG::SpeculativeJIT::emitAllocateJSCell): (JSC::DFG::SpeculativeJIT::emitAllocateJSObject): (JSC::DFG::SpeculativeJIT::emitAllocateJSObjectWithKnownSize): (JSC::DFG::SpeculativeJIT::emitAllocateVariableSizedJSObject): (JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::fillJSValue): (JSC::DFG::SpeculativeJIT::cachedGetById): (JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis): (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined): (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined): (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq): (JSC::DFG::SpeculativeJIT::genericJSValueNonPeepholeStrictEq): (JSC::DFG::SpeculativeJIT::compileCompareEqPtr): (JSC::DFG::SpeculativeJIT::emitCall): (JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal): (JSC::DFG::SpeculativeJIT::fillSpeculateDouble): (JSC::DFG::SpeculativeJIT::fillSpeculateCell): (JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): (JSC::DFG::SpeculativeJIT::compileObjectStrictEquality): (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectStrictEquality): (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
[webkit-changes] [WebKit/WebKit] 1dc698: [@property] Container units are not computationall...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1dc6982298becf494b1554dec68a850533aa7d6b https://github.com/WebKit/WebKit/commit/1dc6982298becf494b1554dec68a850533aa7d6b Author: Antti Koivisto Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/fast/css/custom-properties/at-property-cqi-crash-expected.txt A LayoutTests/fast/css/custom-properties/at-property-cqi-crash.html M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-computational-independence-expected.txt M Source/WebCore/css/CSSPrimitiveValue.cpp M Source/WebCore/css/CSSValue.h Log Message: --- [@property] Container units are not computationally independent https://bugs.webkit.org/show_bug.cgi?id=251084 rdar://104550943 Reviewed by Alan Baradlay. They depend on container dimensions and so should not be allowed in initial-value descriptors. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-computational-independence-expected.txt: * LayoutTests/fast/css/custom-properties/at-property-cqi-crash-expected.txt: Added. * LayoutTests/fast/css/custom-properties/at-property-cqi-crash.html: Added. * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::collectComputedStyleDependencies const): Set a bit indicating there are container dimension dependencies. * Source/WebCore/css/CSSValue.h: (WebCore::ComputedStyleDependencies::isEmpty const): Canonical link: https://commits.webkit.org/259298@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f94dc3: [webkitbugspy] Handle empty description
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f94dc3fc469d521b341e725ccce2bfb55c1aa08b https://github.com/WebKit/WebKit/commit/f94dc3fc469d521b341e725ccce2bfb55c1aa08b Author: Jonathan Bedard Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Tools/Scripts/libraries/webkitbugspy/setup.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py Log Message: --- [webkitbugspy] Handle empty description https://bugs.webkit.org/show_bug.cgi?id=251090 rdar://104602830 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py: (Tracker.populate): Bail out of loops if descritions or comments are empty. Canonical link: https://commits.webkit.org/259297@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 608305: Remove the empty CATransaction in RemoteLayerTreeD...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 608305feff3b865bec12c37926617707d6c41bba https://github.com/WebKit/WebKit/commit/608305feff3b865bec12c37926617707d6c41bba Author: Simon Fraser Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm Log Message: --- Remove the empty CATransaction in RemoteLayerTreeDrawingArea::displayDidRefresh() https://bugs.webkit.org/show_bug.cgi?id=249735 rdar://103608610 Reviewed by Tim Horton. The empty CA transaction was done to garbage-collect IOSurfaces (rdar://problem/16110687). We only need that if we're making IOSurfaces in the web process, which we only do if GPU Process for DOM Rendering is disabled. * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::displayDidRefresh): Canonical link: https://commits.webkit.org/259296@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d5823d: Fix tests that use `eventSender.mouseScrollBy()` t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5823dca0a47f5a8bf31732ca7c74b4dd9b6a991 https://github.com/WebKit/WebKit/commit/d5823dca0a47f5a8bf31732ca7c74b4dd9b6a991 Author: Simon Fraser Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/fast/events/platform-wheelevent-with-delta-zero-crash.html M LayoutTests/fast/events/remove-child-onscroll.html M LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html M LayoutTests/fast/events/wheel/platform-wheelevent-in-scrolling-div.html M LayoutTests/fast/events/wheel/wheel-event-outside-body.html M LayoutTests/fast/events/wheel/wheelevent-basic.html M LayoutTests/fast/events/wheel/wheelevent-in-text-node.html M LayoutTests/fast/events/wheel/wheelevent-mousewheel-interaction.html M LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash.html M LayoutTests/fast/repaint/overflow-auto-in-overflow-auto-scrolled.html M LayoutTests/fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html M LayoutTests/fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html M LayoutTests/fast/scrolling/mac/vertical-scroll-in-horizontal-scroller.html M LayoutTests/fast/scrolling/rtl-scrollbars-listbox-scroll.html M LayoutTests/fast/scrolling/scrolling-inside-scrolled-overflowarea.html M LayoutTests/platform/gtk/TestExpectations M LayoutTests/resources/ui-helper.js M LayoutTests/scrollbars/scroll-rtl-or-bt-layer.html Log Message: --- Fix tests that use `eventSender.mouseScrollBy()` to use UIHelper.statelessMouseWheelScrollAt https://bugs.webkit.org/show_bug.cgi?id=250355 rdar://104058894 Reviewed by Ryosuke Niwa. Replace calls to `eventSender.mouseMoveTo(); eventSender.mouseScrollBy()` with a call to `UIHelper.statelessMouseWheelScrollAt()`, making things async where necessary. Add `UIHelper.waitForEventHandler()`, which wraps the given function in an event handler and waits for it to fire. * LayoutTests/fast/events/platform-wheelevent-with-delta-zero-crash.html: * LayoutTests/fast/events/remove-child-onscroll.html: * LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html: * LayoutTests/fast/events/wheel/platform-wheelevent-in-scrolling-div.html: * LayoutTests/fast/events/wheel/wheel-event-outside-body.html: * LayoutTests/fast/events/wheel/wheelevent-basic.html: * LayoutTests/fast/events/wheel/wheelevent-in-text-node.html: * LayoutTests/fast/events/wheel/wheelevent-mousewheel-interaction.html: * LayoutTests/fast/forms/search/search-scroll-hidden-decoration-container-crash.html: * LayoutTests/fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: * LayoutTests/fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: * LayoutTests/fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html: * LayoutTests/fast/scrolling/mac/vertical-scroll-in-horizontal-scroller.html: * LayoutTests/fast/scrolling/rtl-scrollbars-listbox-scroll.html: * LayoutTests/fast/scrolling/scrolling-inside-scrolled-overflowarea.html: * LayoutTests/resources/ui-helper.js: (window.UIHelper.async statelessMouseWheelScrollAt): (window.UIHelper.waitForEventHandler): (window.UIHelper.callFunctionAndWaitForEvent): * LayoutTests/scrollbars/scroll-rtl-or-bt-layer.html: Canonical link: https://commits.webkit.org/259295@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d85dae: Cherry-pick 252432.816@safari-7614-branch (fa17c46...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d85daec3645fee77f09a0f3e59928f1e1b9aa287 https://github.com/WebKit/WebKit/commit/d85daec3645fee77f09a0f3e59928f1e1b9aa287 Author: Ryosuke Niwa Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/editing/selection/modify-extend-iframe-orphan-expected.txt A LayoutTests/editing/selection/modify-extend-iframe-orphan.html M Source/WebCore/editing/FrameSelection.cpp Log Message: --- Cherry-pick 252432.816@safari-7614-branch (fa17c4664715). rdar://104600217 ASSERTION FAILED: !document().selection().selection().isOrphan() in ContainerNode::removeNodeWithScriptAssertion https://bugs.webkit.org/show_bug.cgi?id=247781 rdar://101497964 Reviewed by Wenson Hsieh, Darin Adler and Geoffrey Garen. The bug was caused by VisibleSelection::setBase setting selection ends to point to nodes in a wrong document as a side effect of calling VisibleSelection::validate when m_anchor isn't cleared due to a node removal when live range selection is disabled. * LayoutTests/editing/selection/modify-extend-iframe-orphan-expected.txt: Added. * LayoutTests/editing/selection/modify-extend-iframe-orphan.html: Added. * Source/WebCore/editing/FrameSelection.cpp: (WebCore::selectionIsOrphanedOrBelongsToWrongDocument): (WebCore::FrameSelection::willBeModified): Canonical link: https://commits.webkit.org/252432.816@safari-7614-branch Canonical link: https://commits.webkit.org/259294@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6bac3a: Cherry-pick 252432.808@safari-7614-branch (b6d2a12...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6bac3a2a1f025e5073f2fe314405c1938775d2a1 https://github.com/WebKit/WebKit/commit/6bac3a2a1f025e5073f2fe314405c1938775d2a1 Author: Wenson Hsieh Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm Log Message: --- Cherry-pick 252432.808@safari-7614-branch (b6d2a12d8d70). rdar://104600105 [macOS] WebContextMenuProxy use-after-free when triggering context menu presentation using IPC https://bugs.webkit.org/show_bug.cgi?id=247590 rdar://102049265 Reviewed by Aditya Keerthi. Replace these raw pointers with `WeakPtr` to avoid accessing invalid memory, in the case where a compromised web process triggers context menu presentation on macOS by sending an out-of-band `WebPageProxy::ShowContextMenu` IPC message. * Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm: (-[WKMenuTarget menuProxy]): (-[WKMenuTarget forwardContextMenuAction:]): Canonical link: https://commits.webkit.org/252432.808@safari-7614-branch Canonical link: https://commits.webkit.org/259293@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d64bf4: touch-action-region-clip-and-transform.html is a c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d64bf428fb59d306c6723e38f69d90e7d2b92c90 https://github.com/WebKit/WebKit/commit/d64bf428fb59d306c6723e38f69d90e7d2b92c90 Author: Mike Wyrzykowski Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/pointerevents/ios/touch-action-region-clip-and-transform-expected.txt Log Message: --- touch-action-region-clip-and-transform.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=251074 Reviewed by Dean Jackson. We made some changes to the event region clipping in August but missed this test which appears to be a progression. The GraphicsLayer between the last and 4th from last appear identical, but the test expecation was different for them. That seems incorrect. Now the test expectations for the two GraphicsLayers are the same, which seems correct. * LayoutTests/pointerevents/ios/touch-action-region-clip-and-transform-expected.txt: Update the test expectation due to the progression. Canonical link: https://commits.webkit.org/259292@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 21b67f: Unreviewed, mark a couple of WebSocket tests as fl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 21b67feb40268866367d24789379757a4dd2109a https://github.com/WebKit/WebKit/commit/21b67feb40268866367d24789379757a4dd2109a Author: Chris Dumez Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- Unreviewed, mark a couple of WebSocket tests as flaky since their import https://bugs.webkit.org/show_bug.cgi?id=251096 rdar://104609070 * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/259291@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 589e3e: Cherry-pick 252432.806@safari-7614-branch (a09205d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 589e3edb7b1c0d3f8d78d399fadd9a54d9c062d4 https://github.com/WebKit/WebKit/commit/589e3edb7b1c0d3f8d78d399fadd9a54d9c062d4 Author: Chris Dumez Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/fast/forms/datalist/datalist-idTargetChanged-crash-expected.txt A LayoutTests/fast/forms/datalist/datalist-idTargetChanged-crash.html M Source/WebCore/html/HTMLInputElement.cpp Log Message: --- Cherry-pick 252432.806@safari-7614-branch (a09205d980f6). rdar://104599817 Assertion hit under IdTargetObserverRegistry::notifyObservers() https://bugs.webkit.org/show_bug.cgi?id=247592 rdar://101454107 Reviewed by Aditya Keerthi, Wenson Hsieh and Geoffrey Garen. ListAttributeTargetObserver::idTargetChanged() is not safe to re-enter. As a result, we have an assertion and a runtime check to protect against this. However, it was still possible to hit this assertion in debug. ListAttributeTargetObserver::idTargetChanged() would call TextFieldInputType::dataListMayHaveChanged() which could run script by calling createDataListDropdownIndicator(). The script could then change the datalist element's id, which would attempt to re-enter. This patch addresses the issue by calling dataListMayHaveChanged() asynchronously. * LayoutTests/fast/forms/datalist/datalist-idTargetChanged-crash-expected.txt: Added. * LayoutTests/fast/forms/datalist/datalist-idTargetChanged-crash.html: Added. * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::ListAttributeTargetObserver::idTargetChanged): Canonical link: https://commits.webkit.org/252432.806@safari-7614-branch Canonical link: https://commits.webkit.org/259290@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0214f5: [GARDENING][ BigSur+ JSC ] stress/intl-enumeration...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0214f5ed6d3423894be20f9a789e2807ddd1dcfe https://github.com/WebKit/WebKit/commit/0214f5ed6d3423894be20f9a789e2807ddd1dcfe Author: Robert Jenner Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M JSTests/stress/intl-enumeration.js Log Message: --- [GARDENING][ BigSur+ JSC ] stress/intl-enumeration.js (JSC-Tests) are constantly failing https://bugs.webkit.org/show_bug.cgi?id=250851 Unreviewed test gardening. Skipping test after unsuccessful attempt to fix. * JSTests/stress/intl-enumeration.js: Canonical link: https://commits.webkit.org/259289@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a050e: Reset 'm_touchPressed' to false in EventHandler::c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a050efadba8c42c2a06a2a6b938be2afe1b4e3a https://github.com/WebKit/WebKit/commit/9a050efadba8c42c2a06a2a6b938be2afe1b4e3a Author: Ahmad Saleem Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/page/EventHandler.cpp Log Message: --- Reset 'm_touchPressed' to false in EventHandler::clear() Reset 'm_touchPressed' to false in EventHandler::clear() https://bugs.webkit.org/show_bug.cgi?id=250952 Reviewed by Aditya Keerthi. Merge - https://chromium.googlesource.com/chromium/blink/+/b7791c376d099dbb0ecebf51203af5b856afb7f6 The member variable 'm_touchPressed' in EventHandler is true if there is at least one active touchpoint. This should be reset to false in EventHandler::clear(), otherwise mousemove events may be incorrectly treated. * Source/WebCore/page/EventHandler.cpp: (EventHandler::clear): Explicitly set 'm_touchPressed' to 'false' Canonical link: https://commits.webkit.org/259288@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3589dd: Fix IsoCellSet::remove()'s return value.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3589dd6fe56969756161494cf76b92588a1e841b https://github.com/WebKit/WebKit/commit/3589dd6fe56969756161494cf76b92588a1e841b Author: Mark Lam Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/JavaScriptCore/heap/IsoCellSetInlines.h M Source/WTF/wtf/Atomics.h M Source/WTF/wtf/Bitmap.h Log Message: --- Fix IsoCellSet::remove()'s return value. https://bugs.webkit.org/show_bug.cgi?id=251071 Reviewed by Yusuke Suzuki. In https://bugs.webkit.org/show_bug.cgi?id=250847, Yijia Huang found a bug in Bitmap::concurrentTestAndClear() where it's returning the inverse of its expected result. Checking for all uses of concurrentTestAndClear(), we find that one result of IsoCellSet::remove() is also similarly incorrect. This patch fixes these errors, and also adds comments to document the intended return values of some relevant functions, as well as the reasoning behind how some of the return values are computed. Note: currently, the result of Bitmap::concurrentTestAndClear() only impacts the return value of IsoCellSet::remove(), and, in turn, the return value of IsoCellSet::remove() is not used anywhere. Hence, these bugs do not currently cause any harm. However, it is good to fix them just for correctness and to avoid potential future issues should we start using their return values in a meaningful way. * Source/JavaScriptCore/heap/IsoCellSetInlines.h: (JSC::IsoCellSet::add): (JSC::IsoCellSet::remove): * Source/WTF/wtf/Atomics.h: * Source/WTF/wtf/Bitmap.h: (WTF::WordType>::testAndSet): (WTF::WordType>::testAndClear): (WTF::WordType>::concurrentTestAndSet): (WTF::WordType>::concurrentTestAndClear): Canonical link: https://commits.webkit.org/259287@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e3ebba: [GTK] Remove WebKitPrintCustomWidget from modern API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3ebba80adf1cc861a986732fe154aa72731b2b1 https://github.com/WebKit/WebKit/commit/e3ebba80adf1cc861a986732fe154aa72731b2b1 Author: Michael Catanzaro Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformGTKDeprecated.cmake M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesGTKDeprecated.txt M Source/WebKit/UIProcess/API/glib/WebKitAutocleanups.h.in M Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.cpp M Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.h.in M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp M Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp Log Message: --- [GTK] Remove WebKitPrintCustomWidget from modern API https://bugs.webkit.org/show_bug.cgi?id=244513 Reviewed by Carlos Garcia Campos. Attaching custom widgets to the print dialog just cannot work when the print dialog is out of process, and we really need to move to an out of process dialog to fix printing in Flatpak. Now, it would be possible to keep this functionality for non-flatpak apps and leave it broken in Flatpak, but I'd much rather reduce user experience divergence. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformGTKDeprecated.cmake: * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesGTKDeprecated.txt: * Source/WebKit/UIProcess/API/glib/WebKitAutocleanups.h.in: * Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.cpp: (webkit_print_custom_widget_class_init): * Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.h.in: * Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkit_print_operation_class_init): (webkitPrintOperationRunDialog): * Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp: (beforeAll): Canonical link: https://commits.webkit.org/259286@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2357a: [WPE][GTK] Remove most webkit_web_view_new_with_*(...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2357aa3082326a6bad6e0d5a0198c159b5617bc https://github.com/WebKit/WebKit/commit/f2357aa3082326a6bad6e0d5a0198c159b5617bc Author: Michael Catanzaro Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp M Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp M Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md M Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h Log Message: --- [WPE][GTK] Remove most webkit_web_view_new_with_*() constructors https://bugs.webkit.org/show_bug.cgi?id=250835 Reviewed by Carlos Garcia Campos. So many constructors is unwieldy, and they're only useful if you need to create a WebKitWebView with exactly one of the many construct properties, which is a pretty niche situation. So get rid of them. An exception is webkit_web_view_new_with_related_view() because it inherits the relevant properties from the related view. * Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in: * Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp: * Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp: * Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md: * Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h: (Test::createWebView): Canonical link: https://commits.webkit.org/259285@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ed8f0: [ Gardening ] REGRESSION(259215@main): [ BigSur+ D...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ed8f0a8a41f38218a1df026ec9dbae06e60d6d7 https://github.com/WebKit/WebKit/commit/7ed8f0a8a41f38218a1df026ec9dbae06e60d6d7 Author: Bri Harris Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [ Gardening ] REGRESSION(259215@main): [ BigSur+ Debug ] storage/indexeddb/modern/de leteindex-4-private.html is a constant cras https://bugs.webkit.org/show_bug.cgi?id=251051 rdar://problem/104579643 Unreviewed Test Gardening Setting expectations while Engineer investigates * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/259284@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] acdb30: [JSC] lowExecutableMemory/exports-oom.js has becom...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: acdb30e44960ee2a20bda67570a16fbb2125bcaf https://github.com/WebKit/WebKit/commit/acdb30e44960ee2a20bda67570a16fbb2125bcaf Author: Angelos Oikonomopoulos Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M JSTests/wasm/lowExecutableMemory/exports-oom.js Log Message: --- [JSC] lowExecutableMemory/exports-oom.js has become flaky on ARM https://bugs.webkit.org/show_bug.cgi?id=251085 Unreviewed gardening. * JSTests/wasm/lowExecutableMemory/exports-oom.js: Canonical link: https://commits.webkit.org/259283@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5a3b3: [ews-build.webkit.org] Support PRs with many files...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5a3b31501e438939583cea5eb92ab96c183f231 https://github.com/WebKit/WebKit/commit/c5a3b31501e438939583cea5eb92ab96c183f231 Author: Jonathan Bedard Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Tools/CISupport/ews-build/events.py Log Message: --- [ews-build.webkit.org] Support PRs with many files changed (Follow-up) https://bugs.webkit.org/show_bug.cgi?id=250714 rdar://104339227 Unreviewed follow-up fix * Tools/CISupport/ews-build/events.py: (GitHubEventHandlerNoEdits._get_pr_files): Twisted response objects have a status_code, not a code. Canonical link: https://commits.webkit.org/259282@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 29e635: [ews-build.webkit.org] Ensure new-style steps corr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29e63587c7cd6e7b1d6af4eeb710f9a7ed7ada20 https://github.com/WebKit/WebKit/commit/29e63587c7cd6e7b1d6af4eeb710f9a7ed7ada20 Author: Jonathan Bedard Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews-build.webkit.org] Ensure new-style steps correctly using defers https://bugs.webkit.org/show_bug.cgi?id=250794 rdar://104398102 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (UpdateWorkingDirectory.run): Return via defer.returnValue. (ApplyPatch.run): Ditto. (ValidateCommitMessage.run): Ditto. Canonical link: https://commits.webkit.org/259281@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f8753: [ews-build.webkit.org] Convert ValidateCommitterAn...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f875349aec33d9e03092650bd8254f9406d72f6 https://github.com/WebKit/WebKit/commit/4f875349aec33d9e03092650bd8254f9406d72f6 Author: Jonathan Bedard Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews-build.webkit.org] Convert ValidateCommitterAndReviewer to new-style https://bugs.webkit.org/show_bug.cgi?id=250875 rdar://10457 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (ValidateCommitterAndReviewer.fail_build): Return exit status. (ValidateCommitterAndReviewer.run): Renamed from 'start', return exit status. (ValidateCommitterAndReviewer.start): Renamed 'run'. Canonical link: https://commits.webkit.org/259280@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc11d0: [WPE] Gardening `fast/block/basic/001.html`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc11d06cac4b0eb636c4aa77656f8dbb21686d6f https://github.com/WebKit/WebKit/commit/bc11d06cac4b0eb636c4aa77656f8dbb21686d6f Author: Vitaly Dyachkov Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/wpe/fast/block/basic/001-expected.txt Log Message: --- [WPE] Gardening `fast/block/basic/001.html` Unreviewed test gardening. * LayoutTests/platform/wpe/fast/block/basic/001-expected.txt: Canonical link: https://commits.webkit.org/259279@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e32b6: [ews-build.webkit.org] Convert BlockPullRequest to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e32b6b25e796964a73687879b9ac5e0a31daeff https://github.com/WebKit/WebKit/commit/4e32b6b25e796964a73687879b9ac5e0a31daeff Author: Jonathan Bedard Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews-build.webkit.org] Convert BlockPullRequest to new-style https://bugs.webkit.org/show_bug.cgi?id=250877 rdar://104453787 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (BlockPullRequest.run): Renamed from 'start', return step status. (BlockPullRequest.start): Renamed 'run'. Canonical link: https://commits.webkit.org/259278@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3abe0e: Support https://wicg.github.io/webcrypto-secure-cu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3abe0e45310ef3e846f8509e44b5514fb2099f76 https://github.com/WebKit/WebKit/commit/3abe0e45310ef3e846f8509e44b5514fb2099f76 Author: Youenn Fablet Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/http/wpt/crypto/serialize-cryptokey-okp-expected.txt A LayoutTests/http/wpt/crypto/serialize-cryptokey-okp.html M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_Ed25519.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_Ed25519.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_Ed25519.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_Ed25519.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/eddsa.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/eddsa.https.any.worker-expected.txt M LayoutTests/platform/glib/TestExpectations M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/spi/cocoa/CoreCryptoSPI.h M Source/WebCore/Sources.txt M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/crypto/CryptoAlgorithmIdentifier.h M Source/WebCore/crypto/CryptoKey.h M Source/WebCore/crypto/SubtleCrypto.cpp A Source/WebCore/crypto/algorithms/CryptoAlgorithmEd25519.cpp A Source/WebCore/crypto/algorithms/CryptoAlgorithmEd25519.h A Source/WebCore/crypto/keys/CryptoKeyOKP.cpp A Source/WebCore/crypto/keys/CryptoKeyOKP.h A Source/WebCore/crypto/mac/CryptoAlgorithmEd25519Cocoa.cpp M Source/WebCore/crypto/mac/CryptoAlgorithmHKDFMac.cpp M Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp A Source/WebCore/crypto/mac/CryptoKeyOKPCocoa.cpp M Source/WebCore/platform/Logging.h Log Message: --- Support https://wicg.github.io/webcrypto-secure-curves/#ed25519 https://bugs.webkit.org/show_bug.cgi?id=246145 rdar://problem/100401588 Reviewed by Chris Dumez. Introduce CryptoKeyOKP to support secure safe curves. Add support for generating, importing and exporting Ed25519 keys. Add a runtime flag to control exposing the support. This patch reuses work done in https://github.com/WebKit/WebKit/pull/5026 by Angela Izquierdo Garcia. * LayoutTests/http/wpt/crypto/serialize-cryptokey-okp-expected.txt: Added. * LayoutTests/http/wpt/crypto/serialize-cryptokey-okp.html: Added. * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/eddsa.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/eddsa.https.any.worker-expected.txt: * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/spi/cocoa/CoreCryptoSPI.h: Added. (cccurve25519_make_priv): (cccurve25519_make_pub): (cccurve25519_make_key_pair): * Source/WebCore/Sources.txt: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::write): (WebCore::CloneDeserializer::read): (WebCore::CloneDeserializer::readOKPKey): (WebCore::CloneDeserializer::readCryptoKey): * Source/WebCore/crypto/CryptoAlgorithmIdentifier.h: * Source/WebCore/crypto/CryptoKey.h: * Source/WebCore/crypto/SubtleCrypto.cpp: (WebCore::normalizeCryptoAlgorithmParameters): (WebCore::isSupportedExportKey): * Source/WebCore/crypto/algorithms/CryptoAlgorithmEd25519.cpp: Added. (WebCore::CryptoAlgorithmEd25519::platformSign): (WebCore::CryptoAlgorithmEd25519::platformVerify):
[webkit-changes] [WebKit/WebKit] 24e3ce: Cherry-pick 256112@main (4a1a50028375). https://bu...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 24e3ce7b1f024cc6dc43f58ef6b4103d109709b2 https://github.com/WebKit/WebKit/commit/24e3ce7b1f024cc6dc43f58ef6b4103d109709b2 Author: Miguel Salinas Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/storage/indexeddb/crash-on-getdatabases-expected.txt A LayoutTests/storage/indexeddb/crash-on-getdatabases.html A LayoutTests/storage/indexeddb/resources/crash-on-getdatabases.js M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp Log Message: --- Cherry-pick 256112@main (4a1a50028375). https://bugs.webkit.org/show_bug.cgi?id=246706 nullptr crash in WebCore::IDBTransaction::dispatchEvent https://bugs.webkit.org/show_bug.cgi?id=246706 rdar://94637046 Reviewed by Sihui Liu. We should check if m_openDBRequest is null in IDBTransaction::dispatchEvent. The repro is flaky but does reproduce for me ~1/3 of the time. I tried to reduce the test case but it either stopped reproducing or reproduced significantly less frequently. * LayoutTests/storage/indexeddb/crash-on-getdatabases-expected.txt: Added. * LayoutTests/storage/indexeddb/crash-on-getdatabases.html: Added. * LayoutTests/storage/indexeddb/resources/crash-on-getdatabases.js: Added. (async testDoesNotCrash): * Source/WebCore/Modules/indexeddb/IDBTransaction.cpp: (WebCore::IDBTransaction::dispatchEvent): Canonical link: https://commits.webkit.org/256112@main Commit: 3544b1eaff9de757625d2d6dc8b897d18dda6167 https://github.com/WebKit/WebKit/commit/3544b1eaff9de757625d2d6dc8b897d18dda6167 Author: Chris Dumez Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/page/Quirks.cpp Log Message: --- Cherry-pick 256081@main (cc22c989e13b). https://bugs.webkit.org/show_bug.cgi?id=247153 Regression(252759@main) Unable to log into marcus.com https://bugs.webkit.org/show_bug.cgi?id=247153 rdar://101086391 Reviewed by Brian Weinstein. Extend showModalDialog quirk to marcus.com to work around their geo-blocking relying on the showModalDialog property existing (somehow). Note that the property is exposed but is undefined, which is sufficient since they don't actually call the showModalDialog function. * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldExposeShowModalDialog const): Canonical link: https://commits.webkit.org/256081@main Commit: c2764831554bdd0597fe5eefd1b7a84b07ea9b1b https://github.com/WebKit/WebKit/commit/c2764831554bdd0597fe5eefd1b7a84b07ea9b1b Author: Darin Adler Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/wtf/text/StringImpl.h M Source/WTF/wtf/text/StringView.h Log Message: --- Cherry-pick 255739@main (a7b9e4efad0c). https://bugs.webkit.org/show_bug.cgi?id=246688 ASSERTION FAILED: !is8Bit() https://bugs.webkit.org/show_bug.cgi?id=246688 rdar://101291623 Reviewed by Mark Lam. * Source/WTF/wtf/text/StringImpl.h: (WTF::StringImpl::characters16 const): Allow calling this on the empty string without asserting. There is no problem returning the 8-bit character pointer as a 16-bit character pointer when the length is zero; the pointer will never be dereferenced. * Source/WTF/wtf/text/StringView.h: (WTF::StringView::characters16 const): Ditto. Canonical link: https://commits.webkit.org/255739@main Commit: f7faf90291eb0a196d9a2007749ffce2c4d57369 https://github.com/WebKit/WebKit/commit/f7faf90291eb0a196d9a2007749ffce2c4d57369 Author: Alicia Boya Garcia Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/wtf/MediaTime.cpp M Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp Log Message: --- Cherry-pick 255767@main (c020c7e213d8). https://bugs.webkit.org/show_bug.cgi?id=246746 [WTF] MediaTime: compute flags on multiplication with doubles https://bugs.webkit.org/show_bug.cgi?id=246746 Reviewed by Yusuke Suzuki. The current multiplication algorithm in WTF::MediaTime updates the time value without updating the flags. This becomes a problem if the multiplication promotes the number to infinity. This patch fixes this problem and adds a test for it. * Source/WTF/wtf/MediaTime.cpp: (WTF::MediaTime::operator* const): * Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/255767@main Commit: 991d269b4371d5ac9733f9d7fc38e42c75fb7ad1 https://github.com/WebKit/WebKit/commit/991d269b4371d5ac9733f9d7fc38e42c75fb7ad1 Author: Alejandro G. Castro Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/inspector/InspectorCanvas.cpp M Source/WebCore/inspector/InspectorCanvasCallTracer.h Log Message: --- Cherry-pick 255778@main
[webkit-changes] [WebKit/WebKit] 48aa7e: [WPE] Gardening `css2.1/t0805-c5518-brdr-t-01-e.html`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 48aa7e7e7b5947169484269ef6056ec82c8c2551 https://github.com/WebKit/WebKit/commit/48aa7e7e7b5947169484269ef6056ec82c8c2551 Author: Vitaly Dyachkov Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/platform/glib/css2.1/t0805-c5518-brdr-t-01-e-expected.txt R LayoutTests/platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.png R LayoutTests/platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.txt R LayoutTests/platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt Log Message: --- [WPE] Gardening `css2.1/t0805-c5518-brdr-t-01-e.html` Unreviewed test gardening. * LayoutTests/platform/glib/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.txt. * LayoutTests/platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Removed. * LayoutTests/platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Removed. Canonical link: https://commits.webkit.org/259276@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ac96e: [WPE] Gardening `css2.1/t0905-c414-flt-wrap-01-d-g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ac96e6cae91a4ed1041e2477e8e1da30d09c4fd https://github.com/WebKit/WebKit/commit/6ac96e6cae91a4ed1041e2477e8e1da30d09c4fd Author: Vitaly Dyachkov Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/wpe/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt Log Message: --- [WPE] Gardening `css2.1/t0905-c414-flt-wrap-01-d-g.html` Unreviewed test gardening. * LayoutTests/platform/wpe/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt: Canonical link: https://commits.webkit.org/259275@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08fff4: [WPE] Gardening `css2.1/t090501-c5525-flt-l-00-b-g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08fff43cb410ad70adc4901c02303eaa5a1002c2 https://github.com/WebKit/WebKit/commit/08fff43cb410ad70adc4901c02303eaa5a1002c2 Author: Vitaly Dyachkov Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/platform/glib/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt R LayoutTests/platform/gtk/css2.1/t090501-c5525-flt-l-00-b-g-expected.png R LayoutTests/platform/gtk/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt R LayoutTests/platform/wpe/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt Log Message: --- [WPE] Gardening `css2.1/t090501-c5525-flt-l-00-b-g.html` Unreviewed test gardening. * LayoutTests/platform/glib/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt. * LayoutTests/platform/gtk/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Removed. * LayoutTests/platform/wpe/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt: Removed. Canonical link: https://commits.webkit.org/259274@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2155ec: [WPE] Gardening `css2.1/t090501-c5525-flt-r-00-b-g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2155ecbcf5c986a0defa5bb5e4a90fea7f216b73 https://github.com/WebKit/WebKit/commit/2155ecbcf5c986a0defa5bb5e4a90fea7f216b73 Author: Vitaly Dyachkov Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: A LayoutTests/platform/glib/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt R LayoutTests/platform/gtk/css2.1/t090501-c5525-flt-r-00-b-g-expected.png R LayoutTests/platform/gtk/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt R LayoutTests/platform/wpe/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt Log Message: --- [WPE] Gardening `css2.1/t090501-c5525-flt-r-00-b-g.html` Unreviewed test gardening. * LayoutTests/platform/glib/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt. * LayoutTests/platform/gtk/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Removed. * LayoutTests/platform/wpe/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt: Removed. Canonical link: https://commits.webkit.org/259273@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d5cec7: [WPE] Gardening `css2.1/t0905-c414-flt-wrap-00-e.h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5cec71af8c238d45112e5c0c8ea563a08ffb6cb https://github.com/WebKit/WebKit/commit/d5cec71af8c238d45112e5c0c8ea563a08ffb6cb Author: Vitaly Dyachkov Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/wpe/css2.1/t0905-c414-flt-wrap-00-e-expected.txt Log Message: --- [WPE] Gardening `css2.1/t0905-c414-flt-wrap-00-e.html` Unreviewed test gardening. * LayoutTests/platform/wpe/css2.1/t0905-c414-flt-wrap-00-e-expected.txt: Canonical link: https://commits.webkit.org/259272@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e363c: REGRESSION(258980@main): [WebRTC] Fix build with r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e363ceb43c9786f7fbab12e706098e3cb52929f https://github.com/WebKit/WebKit/commit/6e363ceb43c9786f7fbab12e706098e3cb52929f Author: Olivier Blin Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.cpp Log Message: --- REGRESSION(258980@main): [WebRTC] Fix build with release log disabled https://bugs.webkit.org/show_bug.cgi?id=251010 Reviewed by Youenn Fablet. * Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.cpp: (WebCore::RealtimeIncomingVideoSource::notifyNewFrame): Frame rate monitor is not available if release log is disabled. Canonical link: https://commits.webkit.org/259271@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f1f3d5: [GLib] Make most public types final
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f1f3d529cb7ff4c9163f5bbb9146cc220e28631a https://github.com/WebKit/WebKit/commit/f1f3d529cb7ff4c9163f5bbb9146cc220e28631a Author: Adrian Perez de Castro Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/wtf/glib/WTFGType.h M Source/WebKit/Shared/API/glib/WebKitContextMenu.cpp M Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp M Source/WebKit/Shared/API/glib/WebKitURIRequest.cpp M Source/WebKit/Shared/API/glib/WebKitURIResponse.cpp M Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp M Source/WebKit/UIProcess/API/glib/WebKitAuthenticationRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp M Source/WebKit/UIProcess/API/glib/WebKitBackForwardList.cpp M Source/WebKit/UIProcess/API/glib/WebKitBackForwardListItem.cpp M Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitDeviceInfoPermissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp M Source/WebKit/UIProcess/API/glib/WebKitEditorState.cpp M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp M Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitFindController.cpp M Source/WebKit/UIProcess/API/glib/WebKitFormSubmissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitGeolocationPermissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitMediaKeySystemPermissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitNavigationPolicyDecision.cpp M Source/WebKit/UIProcess/API/glib/WebKitNotification.cpp M Source/WebKit/UIProcess/API/glib/WebKitNotificationPermissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitOptionMenu.cpp M Source/WebKit/UIProcess/API/glib/WebKitPointerLockPermissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitResponsePolicyDecision.cpp M Source/WebKit/UIProcess/API/glib/WebKitSecurityManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp M Source/WebKit/UIProcess/API/glib/WebKitUserContentFilterStore.cpp M Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitUserMediaPermissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataAccessPermissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitWindowProperties.cpp M Source/WebKit/UIProcess/API/gtk/WebKitColorChooserRequest.cpp M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebInspector.cpp M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [GLib] Make most public types final https://bugs.webkit.org/show_bug.cgi?id=251008 Reviewed by Carlos Garcia Campos. Add a new WEBKIT_DEFINE_TYPE_WITH_CODE macro, plus two helper macros with an _IN_2022_API suffix to be used all around the code. These two macros mark types as final only when ENABLE(2022_GLIB_API) is enabled, otherwise they behave as the existing ones (leaving the types as derivable). This will allow in the future to easily search for types which change between final/non-final, and remove the use of _IN_2022_API macros when the old API is no longer needed. Also, make sure to require GLib 2.70 for the new API. * Source/WTF/wtf/glib/WTFGType.h: Add new macros and switch between final/non-final depending on the value of ENABLE(2022_GLIB_API). * Source/WebKit/Shared/API/glib/WebKitContextMenu.cpp: * Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp: * Source/WebKit/Shared/API/glib/WebKitURIRequest.cpp: * Source/WebKit/Shared/API/glib/WebKitURIResponse.cpp: * Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp: * Source/WebKit/UIProcess/API/glib/WebKitAuthenticationRequest.cpp: * Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp: * Source/WebKit/UIProcess/API/glib/WebKitBackForwardList.cpp: * Source/WebKit/UIProcess/API/glib/WebKitBackForwardListItem.cpp: * Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp: * Source/WebKit/UIProcess/API/glib/WebKitDeviceInfoPermissionRequest.cpp: * Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp: * Source/WebKit/UIProcess/API/glib/WebKitEditorState.cpp: * Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp: * Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp: * Source/WebKit/UIProcess/API/glib/WebKitFindController.cpp: * Source/WebKit/UIProcess/API/glib/WebKitFormSubmissionRequest.cpp: * Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp: *
[webkit-changes] [WebKit/WebKit] 05f8eb: PlayStation Debug build fix following 259231@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05f8eb6368c6644ed330af1c56cf5a165290cc4a https://github.com/WebKit/WebKit/commit/05f8eb6368c6644ed330af1c56cf5a165290cc4a Author: Ross Kirsling Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/platform/libwpe/PlatformKeyboardEventLibWPE.cpp Log Message: --- PlayStation Debug build fix following 259231@main. https://bugs.webkit.org/show_bug.cgi?id=251079 Unreviewed build fix. * Source/WebCore/platform/libwpe/PlatformKeyboardEventLibWPE.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Update overlooked enum value. Canonical link: https://commits.webkit.org/259269@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5cf1f0: Fix !ENABLE(ACCESSIBILITY) build following 259169@...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5cf1f09b2ac867fbb8b01ebb3557bc3036c1cbdd https://github.com/WebKit/WebKit/commit/5cf1f09b2ac867fbb8b01ebb3557bc3036c1cbdd Author: Ross Kirsling Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AXTextMarker.cpp M Source/WebCore/accessibility/AXTextMarker.h Log Message: --- Fix !ENABLE(ACCESSIBILITY) build following 259169@main. https://bugs.webkit.org/show_bug.cgi?id=251070 Unreviewed PlayStation build fix. This was a tricky one because the new feature was not designed in a way to allow for an ENABLE to work. Usually the solution is just to add stub functions; here, the functions depended on a forward-declared type, TextMarkerData, which would cause a circular dependency when replaced with an include. This is resolved by removing the opposite-direction include and transplanting TextMarkerData's method definitions from the header to the impl file. * Source/WebCore/Headers.cmake: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::textMarkerDataForVisiblePosition): (WebCore::AXObjectCache::textMarkerDataForCharacterOffset): (WebCore::AXObjectCache::visiblePositionForTextMarkerData): (WebCore::AXObjectCache::visiblePositionFromCharacterOffset): * Source/WebCore/accessibility/AXTextMarker.cpp: (WebCore::TextMarkerData::TextMarkerData): (WebCore::TextMarkerData::initializeAXIDs): * Source/WebCore/accessibility/AXTextMarker.h: Canonical link: https://commits.webkit.org/259268@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2e91f: Code refactoring to avoid several calls to hasEdit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2e91f349dc761b144e46485520a9f42e61442f7 https://github.com/WebKit/WebKit/commit/e2e91f349dc761b144e46485520a9f42e61442f7 Author: Ahmad Saleem Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WebCore/editing/VisibleUnits.cpp Log Message: --- Code refactoring to avoid several calls to hasEditableStyle() in loop Code refactoring to avoid several calls to hasEditableStyle() in loop https://bugs.webkit.org/show_bug.cgi?id=251042 Reviewed by Ryosuke Niwa. Merge - https://chromium.googlesource.com/chromium/blink/+/85355b065acfc6ffbf960afa2d8e175104c556fa In findStartOfParagraph() and findEndOfParagraph(), hasEditableStyle() is called repeatedly in loop for a node that remains unchanged throughout the function. With this refactoring, this is avoided by using a local variable. * Source/WebCore/editing/VisibleUnits.cpp: (findStartOfParagraph): Introduce 'startNodeIsEditable' to reduce calls to hasEditableStyle() (findEndOfParagraph): Ditto Canonical link: https://commits.webkit.org/259267@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ecbd5f: [CMake] Remove a duplicate AVIF configuration mess...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ecbd5fc1a11d1c2c900e20dafc6fec33dcf43b06 https://github.com/WebKit/WebKit/commit/ecbd5fc1a11d1c2c900e20dafc6fec33dcf43b06 Author: ChangSeok Oh Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [CMake] Remove a duplicate AVIF configuration message. https://bugs.webkit.org/show_bug.cgi?id=251060 Reviewed by Carlos Garcia Campos. This change removes a duplicate USE_AVIF CMake configuration message. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/259266@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1153af: [GStreamer] Fix a crash for fast/speechsynthesis/s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1153afca6d716b3bc6685e910d1b48fc7b5ba73c https://github.com/WebKit/WebKit/commit/1153afca6d716b3bc6685e910d1b48fc7b5ba73c Author: ChangSeok Oh Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.h Log Message: --- [GStreamer] Fix a crash for fast/speechsynthesis/speech-synthesis-real-client-version.html https://bugs.webkit.org/show_bug.cgi?id=251056 Reviewed by Xabier Rodriguez-Calvar. The crash happens when the web content does not specify a voice to use. We handle a null pointer of the voice with the default voice. Test: fast/speechsynthesis/speech-synthesis-real-client-version.html * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp: (WebCore::GstSpeechSynthesisWrapper::speakUtterance): * Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp: (fliteVoice): (webKitFliteSrcSetUtterance): * Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.h: Canonical link: https://commits.webkit.org/259265@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
