[webkit-changes] [WebKit/WebKit] 91d257: [web-animations] keyframes should be recomputed wh...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91d257012a7475b808814fea435ad36d1bf8043f
  
https://github.com/WebKit/WebKit/commit/91d257012a7475b808814fea435ad36d1bf8043f
  Author: Antoine Quint 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/fontWeight-expected.txt
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
M Source/WebCore/animation/KeyframeEffectStack.cpp
M Source/WebCore/style/StyleResolver.cpp
M Source/WebCore/style/StyleResolver.h

  Log Message:
  ---
  [web-animations] keyframes should be recomputed when "bolder" or "lighter" is 
used on a "font-weight" property
https://bugs.webkit.org/show_bug.cgi?id=251493

Reviewed by Antti Koivisto.

Keyframes can set the "font-weight" property to "bolder" or "lighter". When 
such values are used, we
recompute keyframes if the inherited "font-weight" value changes while an 
animation is active.

* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/fontWeight-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
* Source/WebCore/animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::hasRelativeFontWeight const):
* Source/WebCore/animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::applyKeyframeEffects):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::keyframeStylesForAnimation):
* Source/WebCore/style/StyleResolver.h:

Canonical link: https://commits.webkit.org/259740@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 529231: [css-animations] composite operation of implicit k...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 52923169468b34a0026f43a1c3ac9bcae4a1200a
  
https://github.com/WebKit/WebKit/commit/52923169468b34a0026f43a1c3ac9bcae4a1200a
  Author: Antoine Quint 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html
M Source/WebCore/rendering/style/KeyframeList.cpp

  Log Message:
  ---
  [css-animations] composite operation of implicit keyframes for CSS Animations 
should be "replace"
https://bugs.webkit.org/show_bug.cgi?id=251499

Reviewed by Antti Koivisto.

The CSS Animations spec indicates in its "Keyframes" section [0] that the 
default composite is
"replace". As such, when generating an implicit keyframe for an effect tied to 
a CSS Animation,
we should set the composite value to "replace".

This issue was caught by a new version of 
css/css-animations/KeyframeEffect-getKeyframes.tentative.html
which was not yet in our repository, so we update it with the most recent 
changes.

We make an additional change in the final subtest of this WPT to correctly have 
"replace" as
the composite value for the implicit keyframes. I suspect this change was not 
made when Google
last changed that test [1] because Chrome fails to generate the right implicit 
keyframes in this case.

[0] https://drafts.csswg.org/css-animations-2/#keyframes
[1] 
https://github.com/web-platform-tests/wpt/commit/1a5c61d2ca9d0f2c2801adf2b433c7931512152f

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html:
* Source/WebCore/rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::fillImplicitKeyframes):

Canonical link: https://commits.webkit.org/259739@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a83d5a: imported/w3c/web-platform-tests/web-animations/res...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a83d5abf9aefebf1f2553b169b2391333caeae73
  
https://github.com/WebKit/WebKit/commit/a83d5abf9aefebf1f2553b169b2391333caeae73
  Author: Antoine Quint 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/baselineShift-expected.txt
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  ---
  imported/w3c/web-platform-tests/web-animations/responsive/baselineShift.html 
is a failure
https://bugs.webkit.org/show_bug.cgi?id=251490

Reviewed by Antti Koivisto.

The baseline-shift CSS property is represented by two different bits on 
RenderStyle. In the case of
"inherit" we would only forward one of the bits from the parent style. We now 
add a custom "inherit"
function to the style builder to correctly forward both bits from the parent 
style.

This fixes the remaining tests in the 
web-animations/responsive/baselineShift.html WPT which uses
"baseline-shift: inherit" in a @keyframes rule.

* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/baselineShift-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInheritBaselineShift):

Canonical link: https://commits.webkit.org/259738@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70fad0: [web-animations] keyframes should be recomputed if...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70fad032590132bb48443215af1766a1bf3a5828
  
https://github.com/WebKit/WebKit/commit/70fad032590132bb48443215af1766a1bf3a5828
  Author: Antoine Quint 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
M Source/WebCore/style/CustomPropertyRegistry.cpp
M Source/WebCore/style/CustomPropertyRegistry.h

  Log Message:
  ---
  [web-animations] keyframes should be recomputed if a custom property 
registration changes
https://bugs.webkit.org/show_bug.cgi?id=251509

Reviewed by Antti Koivisto.

If the registration of a custom property is changed, we must recompute 
keyframes of any effects
with keyframes targeting that custom property. To that end, we add a new method 
on KeyframeEffect
that the CustomPropertyRegistry can call into to notify the change of a custom 
property's
registration.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::customPropertyRegistrationDidChange):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/style/CustomPropertyRegistry.cpp:
(WebCore::Style::CustomPropertyRegistry::registerFromAPI):
(WebCore::Style::CustomPropertyRegistry::registerFromStylesheet):
(WebCore::Style::CustomPropertyRegistry::notifyAnimationsOfCustomPropertyRegistration):
* Source/WebCore/style/CustomPropertyRegistry.h:

Canonical link: https://commits.webkit.org/259737@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf865e: [web-animations] keyframes should be recomputed wh...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf865e9c2ded23352aa31f4625e0049a0a739cb8
  
https://github.com/WebKit/WebKit/commit/cf865e9c2ded23352aa31f4625e0049a0a739cb8
  Author: Antoine Quint 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/responsive/column-rule-color-001-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/to-color-change-expected.txt
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
M Source/WebCore/animation/KeyframeEffectStack.cpp
M Source/WebCore/style/StyleResolver.cpp
M Source/WebCore/style/StyleResolver.h

  Log Message:
  ---
  [web-animations] keyframes should be recomputed when the "currentcolor" value 
is used
https://bugs.webkit.org/show_bug.cgi?id=251491

Reviewed by Antti Koivisto.

Keyframes can set any number of color-related properties to use `currentcolor`. 
We need
to recompute keyframes if the value to which `currentcolor` would resolve 
changes during
an animation.

To that end, we keep track of properties set to `currentcolor` on keyframes, 
and recompute
the keyframes if we find that `RenderStyle::color()` has changed during style 
resolution.

In the case where one of those properties is the `color` property, the relevant 
value is
not the style's value, but the parent style's value. In this case, which is 
bound to be
rather rare, we elect to always recompute keyframes.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/responsive/column-rule-color-001-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/to-color-change-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::hasPropertySetToCurrentColor const):
(WebCore::KeyframeEffect::hasColorSetToCurrentColor const):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::applyKeyframeEffects):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::keyframeStylesForAnimation):
* Source/WebCore/style/StyleResolver.h:

Canonical link: https://commits.webkit.org/259736@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0f6093: [web-animations] ASSERT(node.isConnected()) reache...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f60938da30b2360f6b007b8d5a7adc3a720616f
  
https://github.com/WebKit/WebKit/commit/0f60938da30b2360f6b007b8d5a7adc3a720616f
  Author: Antoine Quint 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/CSSAnimation-getKeyframes-crash.html
M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  ---
  [web-animations] ASSERT(node.isConnected()) reached in 
Style::Scope::forNode() in 
css/css-animations/CSSAnimation-getKeyframes-crash.html
https://bugs.webkit.org/show_bug.cgi?id=251516

Reviewed by Antti Koivisto.

We should check that the effect's target is non-null and connected before 
calling Style::Scope::forOrdinal()
with that target as the first parameter. This caused a crash in a 
newly-imported WPT test.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/CSSAnimation-getKeyframes-crash.html:
 Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::getKeyframes):

Canonical link: https://commits.webkit.org/259735@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 82ef68: Trim collapsed margins at block-start and block-en...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82ef68207e2f4b6c16b642e5df3a2e79d0e62355
  
https://github.com/WebKit/WebKit/commit/82ef68207e2f4b6c16b642e5df3a2e79d0e62355
  Author: Sammy Gill 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-collapsed-margins-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-collapsed-margins.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-self-collapsing-item-has-larger-block-end-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-self-collapsing-item-has-larger-block-end.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-self-collapsing-item-has-larger-block-start-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-self-collapsing-item-has-larger-block-start.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-collapsed-margins-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-collapsed-margins.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-self-collapsing-item-has-larger-block-end-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-self-collapsing-item-has-larger-block-end.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-self-collapsing-item-larger-block-start-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-self-collapsing-item-larger-block-start.html
M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  ---
  Trim collapsed margins at block-start and block-end when specified by 
margin-trim
https://bugs.webkit.org/show_bug.cgi?id=249781
rdar://103640784

Reviewed by Alan Baradlay.

When collapsed margins at propagated to the block-start or block-end of
a block container and the appropriate margin-trim values are specified,
those margins should also be trimmed.

This can be done by keeping track of whether we are at the block start
or block end of the box as specified by the MarginInfo structure. If
we are currently at the block start of the container, then we should
trim the before margin of the child. If the child is self collapsing,
we should also trim its after margin.

By the time we are in setCollapsedBottomMargin, we are at the block
end of the block container. That means we should be able to trim the
values inside of MarginInfo if margin-trim: block/block-end is
specified.

Here is an example to demonstrate this logic:

container {
display: block;
margin-trim: block;
margin-block-start: 10px;
}
item {
display: block;
margin-block-start: 40px;
width: 50px;
height: 50px;
background-color: green;
}
.collapsed {
margin-block-start: 0px;
height: 0px;
}






- The container will begin layout of its block children and will iterate
over them. Each iteration will take in and update a MarginInfo structure
that is used to handle any sort of collapsing. Initially this structure
will just hold the margin information for the container itself.

- RenderBlockFlow::layoutBlockChild will call RenderBlockFlow::collapseMargins
with the child as an argument, and that method will call
RenderBlockFlow::collapseMarginsWithChildInfo to perform the actual
collapsing.

- Since we are at the before side of the block, which is a part of the
MarginInfo state, and block-start trimming is specified, we will then
trim the block-start margin of the child. We will also trim the block-end
margin of the child since it is self-collapsing.

- Once we are done with this item and we are back in 
RenderBlockFlow::layoutBlockChild
we will check to see if we need to update the MarginInfo state that keeps
track of us being at the before side of the block container. Since
1.) We were at the before side of the block container
2.) The child we just laid out is self collapsing
We will not update our MarginInfo state and we will continue to be at the
before side of the block. This means that this trimming logic will continue
on with the next item in the container. If the first item was not
self collapsing, however, then we would update our MarginInfo state so
that we are no longer at the before side and we would not trim the
block-start margins of the future children.

- After we layout and trim the margins of the second item,
RenderBlockFlow::layoutBlockChildren will call handleAfterSideOfBlock
with the MarginInfo structure 

[webkit-changes] [WebKit/WebKit] 00a856: [WPE] Unreviewed test gardening, unexpected timeou...

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00a85695aaae7e907e69cfaa545a77b421f7fcb8
  
https://github.com/WebKit/WebKit/commit/00a85695aaae7e907e69cfaa545a77b421f7fcb8
  Author: Diego Pino Garcia 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  ---
  [WPE] Unreviewed test gardening, unexpected timeouts and crashes

Garden tests crashing and timing out in WPE Release bot.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/259733@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 35dee8: [GLib] Fix typo of cache_directory parameter to we...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35dee875229dca0d0a03c6a8359e32ca5ec27a64
  
https://github.com/WebKit/WebKit/commit/35dee875229dca0d0a03c6a8359e32ca5ec27a64
  Author: Michael Catanzaro 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp
M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.h.in

  Log Message:
  ---
  [GLib] Fix typo of cache_directory parameter to webkit_network_session_new
https://bugs.webkit.org/show_bug.cgi?id=251534

Reviewed by Adrian Perez de Castro.

This is an introspection API break, so it's good to catch it early.

* Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.h.in:

Canonical link: https://commits.webkit.org/259732@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a82aaf: Optimize padding in CachedRawResource

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a82aafd43736c40bcab96777d5bfc0aa7e7f3775
  
https://github.com/WebKit/WebKit/commit/a82aafd43736c40bcab96777d5bfc0aa7e7f3775
  Author: Simon Fraser 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp
M Source/WebCore/loader/CrossOriginEmbedderPolicy.h
M Source/WebCore/loader/FetchOptions.h
M Source/WebCore/loader/ResourceLoaderOptions.h
M Source/WebCore/loader/cache/CachedRawResource.cpp
M Source/WebCore/loader/cache/CachedRawResource.h
M Source/WebCore/loader/cache/CachedResource.h
M Source/WebCore/platform/network/ResourceRequestBase.h
M Source/WebCore/platform/network/ResourceResponseBase.cpp
M Source/WebCore/platform/network/ResourceResponseBase.h
M Source/WebCore/platform/network/cf/ResourceError.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Optimize padding in CachedRawResource
https://bugs.webkit.org/show_bug.cgi?id=251481
rdar://104901267

Reviewed by Alex Christensen.

CachedRawResource was 1104 bytes big, with 171 bytes of padding. Fix by
reordering data members in classes stored by value in CachedRawResource.
End result is a size of 1056 bytes, with 132 bytes of padding, so there
is more that can be done.

* Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp:
(WebCore::CrossOriginEmbedderPolicy::isolatedCopy const):
(WebCore::CrossOriginEmbedderPolicy::isolatedCopy):
(WebCore::CrossOriginEmbedderPolicy::decode):
* Source/WebCore/loader/CrossOriginEmbedderPolicy.h:
* Source/WebCore/loader/FetchOptions.h:
(WebCore::FetchOptions::isolatedCopy const):
(WebCore::FetchOptions::isolatedCopy):
(WebCore::FetchOptions::FetchOptions):
* Source/WebCore/loader/ResourceLoaderOptions.h:
* Source/WebCore/loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
* Source/WebCore/loader/cache/CachedRawResource.h:
* Source/WebCore/loader/cache/CachedResource.h:
* Source/WebCore/platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::RequestData::RequestData):
* Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::m_type):
(WebCore::m_httpStatusCode): Deleted.
* Source/WebCore/platform/network/ResourceResponseBase.h:
* Source/WebCore/platform/network/cf/ResourceError.h:
(WebCore::ResourceError::ResourceError):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/259731@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d0cbdc: Create compile-time CFString instead of C literal ...

[Rose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0cbdc8286e32465118f4e01ceb89567f4431ecd
  
https://github.com/WebKit/WebKit/commit/d0cbdc8286e32465118f4e01ceb89567f4431ecd
  Author: Rose <83477269+ataridre...@users.noreply.github.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/JavaScriptCore/API/tests/testapi.c

  Log Message:
  ---
  Create compile-time CFString instead of C literal 
https://bugs.webkit.org/show_bug.cgi?id=250937

Reviewed by Yusuke Suzuki.

Creating a CFString from a C literal at runtime is inefficient.
Let's create the string at compile-time instead.

* Source\JavaScriptCore\API\tests\testapi.c:
(static void testCFStrings(void)): Use CFSTR macro

Canonical link: https://commits.webkit.org/259730@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Adrian Perez]

  Branch: refs/tags/webkitgtk-2.38.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Adrian Perez]

  Branch: refs/tags/wpewebkit-2.38.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0ca9d0: Unreviewed. Update OptionsWPE.cmake and NEWS for t...

[Adrian Perez]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ca9d0f8454ab50b95d12d53d768979ab9da6e92
  
https://github.com/WebKit/WebKit/commit/0ca9d0f8454ab50b95d12d53d768979ab9da6e92
  Author: Adrian Perez de Castro 
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
M Source/WebKit/wpe/NEWS
M Source/cmake/OptionsWPE.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.38.4 release

* Source/WebKit/wpe/NEWS: Add release notes.
* Source/cmake/OptionsWPE.cmake: Bump version numbers.


  Commit: 25bff631ebdc38194d2a72549f3cba14f277c7f1
  
https://github.com/WebKit/WebKit/commit/25bff631ebdc38194d2a72549f3cba14f277c7f1
  Author: Adrian Perez de Castro 
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
M Source/WebKit/gtk/NEWS
M Source/cmake/OptionsGTK.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsGTK.cmake and NEWS for the 2.38.4 release

* Source/WebKit/gtk/NEWS: Add release notes.
* Source/cmake/OptionsGTK.cmake: Bump version numbers


Compare: https://github.com/WebKit/WebKit/compare/b177a6504931...25bff631ebdc
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 346569: [ews-build.webkit.org] Convert SetCommitQueueMinus...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3465693b8d327f34da77f64eec0b09016882ce6e
  
https://github.com/WebKit/WebKit/commit/3465693b8d327f34da77f64eec0b09016882ce6e
  Author: Jonathan Bedard 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build.webkit.org] Convert SetCommitQueueMinusFlagOnPatch to Twisted 
asynchronous requests
https://bugs.webkit.org/show_bug.cgi?id=251294
rdar://104761643

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.set_cq_minus_flag_on_patch): Convert to Twisted asynchronous 
requests.
(SetCommitQueueMinusFlagOnPatch.run): Renamed from start.
(SetCommitQueueMinusFlagOnPatch.start): Renamed to run.

Canonical link: https://commits.webkit.org/259729@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 31ea86: [ews-build.webkit.org] Convert RemoveFlagsOnPatch ...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31ea862d60c26b6c9f319f02622bbaa48f7ae2a0
  
https://github.com/WebKit/WebKit/commit/31ea862d60c26b6c9f319f02622bbaa48f7ae2a0
  Author: Jonathan Bedard 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build.webkit.org] Convert RemoveFlagsOnPatch to Twisted asynchronous 
requests
https://bugs.webkit.org/show_bug.cgi?id=251281
rdar://104752905

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.remove_flags_on_patch): Convert to Twisted asynchronous requests.
(RemoveFlagsOnPatch.run): Renamed from start.
(RemoveFlagsOnPatch.start): Renamed to run.

Canonical link: https://commits.webkit.org/259728@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6e6097: [GLib] Remove download-started vfunc from WebKitWe...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e60970017c10edd48dd1a32c0cbed435441c29f
  
https://github.com/WebKit/WebKit/commit/6e60970017c10edd48dd1a32c0cbed435441c29f
  Author: Michael Catanzaro 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.h.in

  Log Message:
  ---
  [GLib] Remove download-started vfunc from WebKitWebContextClass
https://bugs.webkit.org/show_bug.cgi?id=251521

Reviewed by Adrian Perez de Castro.

Now in theory, this class struct should become private and move to the
source file, because WebKitWebContext is no longer derivable and there
is no point to having a public vtable anymore because nothing can use
it.

But in the meantime, this signal is gone and shouldn't be here.

* Source/WebKit/UIProcess/API/glib/WebKitWebContext.h.in:

Canonical link: https://commits.webkit.org/259727@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b98bb7: Make findPropertyIndex & findCustomPropertyIndex f...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b98bb73bfb6f9ae4587896ec0eefd76fde9f4aec
  
https://github.com/WebKit/WebKit/commit/b98bb73bfb6f9ae4587896ec0eefd76fde9f4aec
  Author: Ahmad Saleem 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/css/MutableStyleProperties.cpp

  Log Message:
  ---
  Make findPropertyIndex & findCustomPropertyIndex faster

Make findPropertyIndex & findCustomPropertyIndex faster
https://bugs.webkit.org/show_bug.cgi?id=250581
rdar://problem/104479595

Reviewed by Darin Adler.

Merge - 
https://chromium.googlesource.com/chromium/blink/+/501ce3bc186b2bf535ecf3af9f3ce973fe13fd4c

This patch is potential optimization, which is by modifying to remove calls to
"WTF::Vector::at()" from 'findPropertyIndex' and 'findCustomPropertyIndex' 
functions.

* Source/WebCore/css/MutableStyleProperties.cpp:
(MutableStyleProperties::findPropertyIndex): Add variable for 
'm_propertyVector.data()'
and use it instead of 'm_propertyVector.at(n)'
(MutableStyleProperties::findCustomPropertyIndex): Ditto

Canonical link: https://commits.webkit.org/259726@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 37ea76: Fix infinite recursion in propagateRepaintToParent...

[Chirag Shah]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37ea7633b1ef5a3fab0620cc7f6df2b7ddf89c2c
  
https://github.com/WebKit/WebKit/commit/37ea7633b1ef5a3fab0620cc7f6df2b7ddf89c2c
  Author: Chirag M Shah 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  ---
  Fix infinite recursion in propagateRepaintToParentWithOutlineAutoIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=251409
rdar://104814038

Reviewed by Alan Baradlay.

Now that we map the removed element to the placeholder, we need to use
the original renderer for comparison otherwise we would cause infinite
recursion.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const):

Canonical link: https://commits.webkit.org/259725@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f7a3eb: Remove airplay code for Watch and ATV.

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7a3ebfba198162725dd8c1517add1ccacdfcd5b
  
https://github.com/WebKit/WebKit/commit/f7a3ebfba198162725dd8c1517add1ccacdfcd5b
  Author: Megan Gardner 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M 
Source/WebCore/Modules/modern-media-controls/controls/watchos-layout-traits.js
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.h
M Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm

  Log Message:
  ---
  Remove airplay code for Watch and ATV.
https://bugs.webkit.org/show_bug.cgi?id=251473
rdar://104893264

Reviewed by Eric Carlson.

We don't actually even use Airplay on these platforms, and this
code is old and confusing because it references iPhone and iPad
and this code is run on neither of those platforms.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* 
Source/WebCore/Modules/modern-media-controls/controls/watchos-layout-traits.js:
(WatchOSLayoutTraits.prototype.supportsAirPlay):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView 
_showPlaybackTargetPicker:fromRect:routeSharingPolicy:routingContextUID:]):
* Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.h:
* Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(SOFT_LINK_CLASS): Deleted.
(-[WKAirPlayRoutePicker initWithView:]): Deleted.
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]): Deleted.
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker _windowWillRotate:]): Deleted.
(-[WKAirPlayRoutePicker _windowDidRotate:]): Deleted.
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Deleted.
(-[WKAirPlayRoutePicker show:fromRect:]): Deleted.

Canonical link: https://commits.webkit.org/259724@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9e0ec1: Remove #error added by mistake

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e0ec1e87c86f7966790550aa3f90b15dd6d91c7
  
https://github.com/WebKit/WebKit/commit/9e0ec1e87c86f7966790550aa3f90b15dd6d91c7
  Author: Simon Fraser 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/rendering/style/RenderStyle.cpp

  Log Message:
  ---
  Remove #error added by mistake
https://bugs.webkit.org/show_bug.cgi?id=251557
rdar://104934833

Unreviewed.

Remove code landed by mistake.

* Source/WebCore/rendering/style/RenderStyle.cpp:

Canonical link: https://commits.webkit.org/259723@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 48a646: [ews-build.webkit.org] Use Twisted requests in Clo...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48a6464d55d55fde3d0de9cb709cd7ac671c045a
  
https://github.com/WebKit/WebKit/commit/48a6464d55d55fde3d0de9cb709cd7ac671c045a
  Author: Jonathan Bedard 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/twisted_additions.py

  Log Message:
  ---
  [ews-build.webkit.org] Use Twisted requests in CloseBug
https://bugs.webkit.org/show_bug.cgi?id=251279
rdar://104751322

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.close_bug): Use Twisted's asynchronous requests.
(CloseBug.run): Renamed from start.
(CloseBug.start): Renamed to run.
* Tools/CISupport/ews-build/twisted_additions.py:
(TwistedAdditions.request): Automatically set Content-Type if json is specified.

Canonical link: https://commits.webkit.org/259722@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5e48fa: Non-unified build fixes, early February 2023 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e48fabd1efd472a2733d7e493d11db5e9da67a8
  
https://github.com/WebKit/WebKit/commit/5e48fabd1efd472a2733d7e493d11db5e9da67a8
  Author: Don Olmstead 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/JavaScriptCore/bytecode/BytecodeBasicBlock.cpp
M Source/JavaScriptCore/bytecode/CallLinkStatus.cpp
M Source/JavaScriptCore/runtime/TemporalPlainDate.cpp
M Source/WebCore/Modules/WebGPU/GPUAdapter.cpp
M Source/WebCore/Modules/fetch/FetchBodyOwner.cpp
M Source/WebCore/Modules/push-api/PushPermissionState.h
M Source/WebCore/Modules/push-api/PushSubscription.cpp
M Source/WebCore/Modules/screen-wake-lock/WakeLockManager.cpp
M Source/WebCore/Modules/streams/WritableStream.cpp
M Source/WebCore/Modules/streams/WritableStreamSink.h
M Source/WebCore/Modules/web-locks/WebLockIdentifier.h
M Source/WebCore/Modules/web-locks/WebLockManager.cpp
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/bindings/js/JSServiceWorkerGlobalScopeCustom.cpp
M Source/WebCore/css/CSSCounterStyleRule.cpp
M Source/WebCore/css/CSSKeyframeRule.cpp
M Source/WebCore/css/CSSSupportsRule.cpp
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/DOMCSSNamespace.cpp
M Source/WebCore/css/DOMMatrixReadOnly.cpp
M Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/typedom/DeclaredStylePropertyMap.cpp
M Source/WebCore/dom/DOMImplementation.cpp
M Source/WebCore/dom/ElementData.cpp
M Source/WebCore/editing/FontAttributeChanges.cpp
M Source/WebCore/editing/FontAttributeChanges.h
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/fileapi/BlobURL.cpp
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/html/HTMLFontElement.cpp
M Source/WebCore/html/HTMLTablePartElement.cpp
M Source/WebCore/inspector/agents/InspectorCanvasAgent.h
M Source/WebCore/loader/DocumentLoader.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/Frame.cpp
M Source/WebCore/platform/audio/PlatformMediaSession.cpp
M Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp
M Source/WebCore/rendering/EventRegion.cpp
M Source/WebCore/rendering/GridLayoutFunctions.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp
M 
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M 
Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/WebProcess/WebProcess.cpp

  Log Message:
  ---
  Non-unified build fixes, early February 2023 edition
https://bugs.webkit.org/show_bug.cgi?id=251469

Reviewed by Yusuke Suzuki.

Fix compile issues. A non-unified build flags additional unused
functions and variables.

* Source/JavaScriptCore/bytecode/BytecodeBasicBlock.cpp:
* Source/JavaScriptCore/bytecode/CallLinkStatus.cpp:
* Source/JavaScriptCore/runtime/TemporalPlainDate.cpp:
* Source/WebCore/Modules/WebGPU/GPUAdapter.cpp:
* Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:
* Source/WebCore/Modules/push-api/PushPermissionState.h:
* Source/WebCore/Modules/push-api/PushSubscription.cpp:
* Source/WebCore/Modules/screen-wake-lock/WakeLockManager.cpp:
* Source/WebCore/Modules/streams/WritableStream.cpp:
* Source/WebCore/Modules/streams/WritableStreamSink.h:
* Source/WebCore/Modules/web-locks/WebLockIdentifier.h:
* Source/WebCore/Modules/web-locks/WebLockManager.cpp:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/bindings/js/JSServiceWorkerGlobalScopeCustom.cpp:
* Source/WebCore/css/CSSCounterStyleRule.cpp:
* Source/WebCore/css/CSSKeyframeRule.cpp:
* Source/WebCore/css/CSSSupportsRule.cpp:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
* Source/WebCore/css/DOMCSSNamespace.cpp:
* Source/WebCore/css/DOMMatrixReadOnly.cpp:
* Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:
* Source/WebCore/css/StyleRule.cpp:
* Source/WebCore/css/typedom/DeclaredStylePropertyMap.cpp:
* Source/WebCore/dom/DOMImplementation.cpp:
* Source/WebCore/dom/ElementData.cpp:
* Source/WebCore/editing/FontAttributeChanges.cpp:
* Source/WebCore/editing/FontAttributeChanges.h:
* Source/WebCore/editing/FrameSelection.cpp:
* Source/WebCore/fileapi/BlobURL.cpp:
* Source/WebCore/html/HTMLElement.cpp:
* Source/WebCore/html/HTMLFontElement.cpp:
* Source/WebCore/html/HTMLTablePartElement.cpp:
* Source/WebCore/inspector/agents/InspectorCanvasAgent.h:
* Source/WebCore/loader/DocumentLoader.cpp:
* 

[webkit-changes] [WebKit/WebKit] 4967fd: [GARDNEING][Monterey+ wk2 ] svg/clip-path/clip-opa...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4967fdc8580e0291ec1609d6c5580d44efd3b401
  
https://github.com/WebKit/WebKit/commit/4967fdc8580e0291ec1609d6c5580d44efd3b401
  Author: Robert Jenner 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [GARDNEING][Monterey+ wk2 ] svg/clip-path/clip-opacity-translate.svg is 
consistently failing
https://bugs.webkit.org/show_bug.cgi?id=250046
rdar://problem/103849784

Unreviewed test gardening.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/259720@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 21283e: Add Etienne Segonzac as contributor

[EWS]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21283e484df49c5b40e2ac7e80bae4dc02be823a
  
https://github.com/WebKit/WebKit/commit/21283e484df49c5b40e2ac7e80bae4dc02be823a
  Author: Etienne Segonzac 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add Etienne Segonzac as contributor

Reviewed by Jonathan Bedard.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/259719@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 08c047: [ Ventura ] fast/images/avif-image-docu ment.html ...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 08c04799e28cfe811fefa8e920849fae6535d5f9
  
https://github.com/WebKit/WebKit/commit/08c04799e28cfe811fefa8e920849fae6535d5f9
  Author: Robert Jenner 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
R LayoutTests/platform/mac-ventura/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [ Ventura ] fast/images/avif-image-docu ment.html is a flaky crash (251099)
https://bugs.webkit.org/show_bug.cgi?id=251099

Unreviewed test gardening.

Modifying expectation due to flaky crash impacting EWS. Will remove expectation 
when EWS has been updated to latests version of macOS Ventura, as it no longer 
occurrs there.

* LayoutTests/platform/mac-ventura/TestExpectations: Removed.
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/259718@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6fc661: Cherry-pick 257063@main (f44648f07471). https://bu...

[Chris Dumez]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 6fc661206fd08055f15923113a93ad97ee5b601e
  
https://github.com/WebKit/WebKit/commit/6fc661206fd08055f15923113a93ad97ee5b601e
  Author: Youenn Fablet 
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
A LayoutTests/http/wpt/fetch/fetch-stream-source-expected.txt
A LayoutTests/http/wpt/fetch/fetch-stream-source.html
M Source/WebCore/Modules/streams/ReadableStream.js
M Source/WebCore/Modules/streams/ReadableStreamSource.idl
M Source/WebCore/bindings/js/JSDOMOperationReturningPromise.h

  Log Message:
  ---
  Cherry-pick 257063@main (f44648f07471). 
https://bugs.webkit.org/show_bug.cgi?id=248268

Type getter is not needed for internal ReadableStream sources
https://bugs.webkit.org/show_bug.cgi?id=248268
rdar://102338913

Reviewed by Eric Carlson.

Make ReadableStreamSource method privates.
In ReadableStream, use @getters instead of private getters to allow getting 
private values from prototype.
Covered by added test.

* LayoutTests/http/wpt/fetch/fetch-stream-source-expected.txt: Added.
* LayoutTests/http/wpt/fetch/fetch-stream-source.html: Added.
* Source/WebCore/Modules/streams/ReadableStream.js:
(initializeReadableStream):
* Source/WebCore/Modules/streams/ReadableStreamSource.idl:
* Source/WebCore/bindings/js/JSDOMOperationReturningPromise.h:
(WebCore::IDLOperationReturningPromise::call):

Canonical link: https://commits.webkit.org/257063@main


  Commit: b177a6504931ce0ccd3bcccb06b402a4a0b9d48e
  
https://github.com/WebKit/WebKit/commit/b177a6504931ce0ccd3bcccb06b402a4a0b9d48e
  Author: Chris Dumez 
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/HistoryController.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm

  Log Message:
  ---
  Cherry-pick 252432.826@safari-7614-branch (baca9afc289e). 
https://bugs.webkit.org/show_bug.cgi?id=247909

Properly mark history items added without user gesture
https://bugs.webkit.org/show_bug.cgi?id=247909
rdar://100579077

Reviewed by Geoffrey Garen.

We recently introduced logic to mark history items as "created by JavaScript
without a user gesture" so that those could be skipped when the user 
navigates
back/forward via the browser UI.

However, which history items we marked with such flag was a little 
unexpected
and didn't quite match what Chrome did to address the same problem.

In particular, if on URL1 and then calling `pushState(null, null, 'a')` in 
JS
without a user gesture. We would previously mark the HistoryItem for URL1 as
created without a user gesture, instead of marking the one for URL1#a. 
URL1#a
is the actual HistoryItem created by JS so it makes more sense to mark this
one (which also matches Chrome's behavior).

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):
* Source/WebCore/loader/HistoryController.cpp:
(WebCore::FrameLoader::HistoryController::pushState):
* Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
(TEST):

Canonical link: https://commits.webkit.org/252432.826@safari-7614-branch


Compare: https://github.com/WebKit/WebKit/compare/9293a4e88efd...b177a6504931
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 76864d: [ iOS ] imported/w3c/web-platform-tests/workers/ba...

[btashawn]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76864d423b392861c9c8fb42c54210deb2e3cf1b
  
https://github.com/WebKit/WebKit/commit/76864d423b392861c9c8fb42c54210deb2e3cf1b
  Author: Bri Harris 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [ iOS ] 
imported/w3c/web-platform-tests/workers/baseurl/alpha/import-in-moduleworker.html
 is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=251533
rdar://104923765

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/259717@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c2e9b5: [GTK] Remove webkit_web_context_[g, s]et_use_system...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2e9b5aaac76080146c351d0b6b74a9bb1ac6e56
  
https://github.com/WebKit/WebKit/commit/c2e9b5aaac76080146c351d0b6b74a9bb1ac6e56
  Author: Michael Catanzaro 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.h.in
M Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md

  Log Message:
  ---
  [GTK] Remove webkit_web_context_[g,s]et_use_system_appearance_for_scrollbars()
https://bugs.webkit.org/show_bug.cgi?id=227841

Reviewed by Adrian Perez de Castro.

This API is already not defined and applications that attempt to use it
won't link successfully. We just need to remove it from the header.

* Source/WebKit/UIProcess/API/glib/WebKitWebContext.h.in:
* Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md:

Canonical link: https://commits.webkit.org/259716@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ffba41: [JSC] ref.func in init-expr should be validated wi...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffba415d759f53b160682e9db859d901d36867a9
  
https://github.com/WebKit/WebKit/commit/ffba415d759f53b160682e9db859d901d36867a9
  Author: Yusuke Suzuki 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
A 
JSTests/wasm/stress/init-expr-ref-null-function-index-space-for-validation.js
A 
JSTests/wasm/stress/resources/init-expr-ref-null-function-index-space-for-validation.wasm
M Source/JavaScriptCore/wasm/WasmSectionParser.cpp

  Log Message:
  ---
  [JSC] ref.func in init-expr should be validated with function-index-space
https://bugs.webkit.org/show_bug.cgi?id=251542
rdar://104911237

Reviewed by Mark Lam.

Use functionIndexSpaceSize for validation for ref.func in init-expr, since 
ref.func takes functionIndexSpace.
Note that functionIndexSpaceSize is always larger than functionIndex's size. We 
were wrongly rejecting valid
ref.func via validation.

* 
JSTests/wasm/stress/init-expr-ref-null-function-index-space-for-validation.js: 
Added.
(shouldBe):
(async let):
* 
JSTests/wasm/stress/resources/init-expr-ref-null-function-index-space-for-validation.wasm:
 Added.
* Source/JavaScriptCore/wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseInitExpr):

Canonical link: https://commits.webkit.org/259715@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 04f142: Cherry-pick 259473@main (e534395cf34a). https://bu...

[Chris Dumez]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 04f1427d62940f56aa9d2b4b5a75aa3b56886bf9
  
https://github.com/WebKit/WebKit/commit/04f1427d62940f56aa9d2b4b5a75aa3b56886bf9
  Author: Philippe Normand 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h

  Log Message:
  ---
  Cherry-pick 259473@main (e534395cf34a). 
https://bugs.webkit.org/show_bug.cgi?id=251145

[GStreamer][WebRTC] Missing null/zero checks in 1.22 code paths
https://bugs.webkit.org/show_bug.cgi?id=251145

Reviewed by Xabier Rodriguez-Calvar.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::addRemoteStream): The msid property can 
be null, so needs checking.
(WebCore::GStreamerMediaEndpoint::requestAuxiliarySender): Remove auxiliary 
sender caching. This
code is called once per transport stream, ownership of the sender is passed 
to the caller.

Canonical link: https://commits.webkit.org/259473@main


  Commit: dfe7f9fc1a6df42bb4628a7b5d609563a9dde5a1
  
https://github.com/WebKit/WebKit/commit/dfe7f9fc1a6df42bb4628a7b5d609563a9dde5a1
  Author: moggiesir <21014913+moggie...@users.noreply.github.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WTF/wtf/glib/GUniquePtr.h
M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h

  Log Message:
  ---
  Cherry-pick 259530@main (dbc31d00f78f). 
https://bugs.webkit.org/show_bug.cgi?id=243924

Fix async scroll event propagation for GTK4
https://bugs.webkit.org/show_bug.cgi?id=243924
https://bugs.webkit.org/show_bug.cgi?id=245616

Reviewed by Michael Catanzaro.

Since GTK offers no way to asynchronously decide on whether an event should 
be
propagated or stopped and webkit doesn't want to block the UiProcess on 
event
handing in the WebProcess, webkit2gtk needs to use a bit of a hacky 
workaround.
This involves returning GDK_EVENT_STOP to the original event handling, 
sending
the event to the WebProcess for handling, which then asynchronously 
determines
whether the event was handled. If not, the webkit scroll handler is informed
that the "next" scroll event should be propagated instead of 
handled+stopped,
then re-emits the event for handling by GTK's run loop.

This works fine in GTK3 because there's an API to immediately run the event
loop for a given event (ensuring that the next event that the handler sees 
is
the intended one). For GTK4, the API for re-inserting an event appends the 
event
to the end of the event queue (despite what the documentation says), 
meaning the
next event the handler sees may not be the intended event - thus the wrong 
event
gets propagated and the just re-added event gets sent to the WebProcess 
again.

This coupled with the fact that GDK4 will synthesize scroll-start/scroll-end
events in some cases to ensure scroll events allows have the scroll-start,
scroll, scroll-end sequence can easily cause loops since it's not just 1 
event
that needs to be propagated, it's up to 3.

To work better with the APIs that exist for GTK4, it seems like the best 
option
is to track the set of events that are "pending propagation" instead of 
relying
on the tight interlock of just ignoring the "next" event. The key handling
potentially also needs to be addressed similarly. Unfortunately, even 
tracking
the set of events to ignore is challenging because GTK4 can 
compress/coalesce
scroll events, meaning there will inevitably be some cases where we won't
propagate events that otherwise maybe should have been propagated (and
"unhandled" scroll events may cause some faster/slower than expected 
scrolling
when they get compressed into an not-yet-handled events).

Canonical link: https://commits.webkit.org/259530@main


  Commit: 184939c0c30e2b02f18eff6305386b274ec5ff88
  
https://github.com/WebKit/WebKit/commit/184939c0c30e2b02f18eff6305386b274ec5ff88
  Author: Przemyslaw Gorszkowski 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp

  Log Message:
  ---
  Cherry-pick 259570@main (b69cf1887dfb). 
https://bugs.webkit.org/show_bug.cgi?id=250559

Remove item from cache of SQLiteStorageArea
https://bugs.webkit.org/show_bug.cgi?id=250559

Reviewed by Sihui Liu.

When Storage.removeItem method from Storage API is called,
the cached value in SQLiteStorageArea should be also removed.
It prevents increase the memory usage by network process.

* 

[webkit-changes] [WebKit/WebKit] f89fd6: wasm.yaml/wasm/lowExecutableMemory/imports-oom.js....

[Ryan Haddad]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f89fd6b8491a91aa8dd3c40bc737a319d2e2f68f
  
https://github.com/WebKit/WebKit/commit/f89fd6b8491a91aa8dd3c40bc737a319d2e2f68f
  Author: Ryan Haddad 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M JSTests/wasm/lowExecutableMemory/exports-oom.js
M JSTests/wasm/lowExecutableMemory/imports-oom.js

  Log Message:
  ---
  wasm.yaml/wasm/lowExecutableMemory/imports-oom.js.default-wasm is a flaky 
failure
https://bugs.webkit.org/show_bug.cgi?id=244122
rdar://98882300

Unreviewed test gardening.

Skip the flaky tests.

* JSTests/wasm/lowExecutableMemory/exports-oom.js:
* JSTests/wasm/lowExecutableMemory/imports-oom.js:

Canonical link: https://commits.webkit.org/259714@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7da147: [WPE] Test gardening

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7da147380e8caa516e06b2fdb018cbab20c3c493
  
https://github.com/WebKit/WebKit/commit/7da147380e8caa516e06b2fdb018cbab20c3c493
  Author: Vitaly Dyachkov 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
A LayoutTests/platform/glib/css2.1/t0805-c5519-brdr-r-00-a-expected.txt
A LayoutTests/platform/glib/css2.1/t0805-c5519-brdr-r-01-e-expected.txt
A LayoutTests/platform/glib/css2.1/t0805-c5521-brdr-l-00-a-expected.txt
A LayoutTests/platform/glib/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt
A LayoutTests/platform/glib/css2.1/t0905-c414-flt-02-c-expected.txt
A LayoutTests/platform/glib/css2.1/t0905-c414-flt-03-c-expected.txt
A LayoutTests/platform/glib/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt
A LayoutTests/platform/glib/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt
A LayoutTests/platform/glib/css2.1/t1202-counter-09-b-expected.txt
A LayoutTests/platform/glib/css2.1/t1202-counters-09-b-expected.txt
A LayoutTests/platform/glib/css3/filters/regions-expanding-expected.txt
A 
LayoutTests/platform/glib/css3/masking/clip-path-circle-border-box-expected.txt
A 
LayoutTests/platform/glib/css3/masking/clip-path-circle-content-box-expected.txt
A 
LayoutTests/platform/glib/css3/masking/clip-path-circle-padding-box-expected.txt
A LayoutTests/platform/glib/css3/masking/mask-luminance-png-expected.txt
A LayoutTests/platform/glib/fast/attachment/attachment-progress-expected.txt
A LayoutTests/platform/glib/fast/attachment/attachment-subtitle-expected.txt
A LayoutTests/platform/glib/fast/attachment/attachment-title-expected.txt
A 
LayoutTests/platform/glib/fast/frames/iframe-scrolling-attribute-expected.txt
A 
LayoutTests/platform/glib/fast/html/details-marker-style-mixed-expected.txt
A LayoutTests/platform/glib/fast/html/text-field-input-types-expected.txt
A LayoutTests/platform/glib/fast/inline-block/002-expected.txt
A LayoutTests/platform/glib/fast/inline-block/003-expected.txt
A 
LayoutTests/platform/glib/fast/lists/inlineBoxWrapperNullCheck-expected.txt
A LayoutTests/platform/glib/fast/multicol/scrolling-overflow-expected.txt
A LayoutTests/platform/glib/fast/ruby/nested-ruby-expected.txt
A LayoutTests/platform/glib/fast/ruby/ruby-empty-rt-expected.txt
A LayoutTests/platform/glib/fast/table/frame-and-rules-expected.txt
A LayoutTests/platform/glib/fast/text/arabic-times-new-roman-expected.txt
A 
LayoutTests/platform/glib/fast/text/backslash-to-yen-sign-dynamic-expected.txt
A LayoutTests/platform/glib/fast/text/backslash-to-yen-sign-expected.txt
A LayoutTests/platform/glib/fast/text/basic/001-expected.txt
A LayoutTests/platform/glib/fast/text/basic/002-expected.txt
A LayoutTests/platform/glib/fast/text/basic/003-expected.txt
A LayoutTests/platform/glib/fast/text/basic/006-expected.txt
A LayoutTests/platform/glib/fast/text/basic/008-expected.txt
A LayoutTests/platform/glib/fast/text/cg-vs-atsui-expected.txt
A 
LayoutTests/platform/glib/fast/text/combining-enclosing-keycap-expected.txt
A 
LayoutTests/platform/glib/fast/text/complex-preferred-logical-widths-expected.txt
A 
LayoutTests/platform/glib/fast/text/complex-synthetic-bold-space-width-expected.txt
A LayoutTests/platform/glib/fast/text/complex-text-opacity-expected.txt
A 
LayoutTests/platform/glib/fast/text/embed-at-end-of-pre-wrap-line-expected.txt
A LayoutTests/platform/glib/fast/text/firstline/003-expected.txt
A LayoutTests/platform/glib/fast/text/international/002-expected.txt
A LayoutTests/platform/glib/fast/text/international/003-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/arabic-justify-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/bidi-AN-after-L-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/bidi-CS-after-AN-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/bidi-mirror-he-ar-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/cjk-segmentation-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/hebrew-vowels-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/synthesized-italic-vertical-latin-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/system-language/system-font-punctuation-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/vertical-text-glyph-test-expected.txt
A 
LayoutTests/platform/glib/fast/text/international/wrap-CJK-001-expected.txt
A LayoutTests/platform/glib/fast/text/justify-ideograph-complex-expected.txt
A LayoutTests/platform/glib/fast/text/justify-ideograph-simple-expected.txt
A LayoutTests/platform/glib/fast/text/large-text-composed-char-expected.txt
A 

[webkit-changes] [WebKit/WebKit] 078af4: CFArrayGetCount not SecTrustGetCertificateCount

[Rose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 078af423a71e82ce0563e34d19b7dacb034df5e3
  
https://github.com/WebKit/WebKit/commit/078af423a71e82ce0563e34d19b7dacb034df5e3
  Author: Rose <83477269+ataridre...@users.noreply.github.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp
M Source/WebCore/platform/network/cocoa/CertificateInfoCocoa.mm

  Log Message:
  ---
  CFArrayGetCount not SecTrustGetCertificateCount
https://bugs.webkit.org/show_bug.cgi?id=250938

Reviewed by Chris Dumez.

We already have the CFArrayRef, so let's call CFArrayGetCount instead of
SecTrustGetCertificateCount.

* Source\WebCore\platform\network\cf\CertificateInfoCFNet.cpp:
(bool certificatesMatch(SecTrustRef trust1, SecTrustRef trust2)):
Obtain count1 and count2 from CFArrayGetCount if supported.

* Source\WebCore\platform\network\cocoa\CertificateInfoCocoa.mm:
(void CertificateInfo::dump() const): Obtain entries from
CFArrayGetCount if supported.

Canonical link: https://commits.webkit.org/259712@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b8652a: Disable WebGL in worker threads.

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8652a99205d242d1d4f4247fa3f91def16c9a69
  
https://github.com/WebKit/WebKit/commit/b8652a99205d242d1d4f4247fa3f91def16c9a69
  Author: Matt Woodrow 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformEnableCocoa.h

  Log Message:
  ---
  Disable WebGL in worker threads.
https://bugs.webkit.org/show_bug.cgi?id=251341


Reviewed by Brent Fulgham.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/259711@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f8ccb8: [ews] API test results database integration isn't ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8ccb89db21063d3c82d118b544cdde3c76c51eb
  
https://github.com/WebKit/WebKit/commit/f8ccb89db21063d3c82d118b544cdde3c76c51eb
  Author: Aakash Jain 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] API test results database integration isn't working
https://bugs.webkit.org/show_bug.cgi?id=251461
rdar://104926842

Reviewed by Ryan Haddad.

Buildbot is somehow reading the api-test-results json without the last } 
character. Handle it appropriately.

* Tools/CISupport/ews-build/steps.py:
(RunAPITests.parse_api_failures_from_string):

Canonical link: https://commits.webkit.org/259710@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d1613f: Cherry-pick 252432.954@safari-7614-branch (1144077...

[Ryosuke Niwa]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: d1613f2b066592fe3acc7fbbf2d5f06a43e3e2b9
  
https://github.com/WebKit/WebKit/commit/d1613f2b066592fe3acc7fbbf2d5f06a43e3e2b9
  Author: Chirag M Shah 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp

  Log Message:
  ---
  Cherry-pick 252432.954@safari-7614-branch (114407780ae6). 
rdar://problem/103000322

Guard against overflow when growing the buffer
rdar://problem/103000322

Reviewed by Jonathan Bedard and Chris Dumez.

* Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataEncoder::grow):
(WebKit::HistoryEntryDataEncoder::growCapacity):

Canonical link: https://commits.webkit.org/252432.954@safari-7614-branch


  Commit: f9fd2a39a36583c6930c7455faa867cfb309603b
  
https://github.com/WebKit/WebKit/commit/f9fd2a39a36583c6930c7455faa867cfb309603b
  Author: Ryosuke Niwa 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
A LayoutTests/fast/forms/datalist/datalist-id-change-crash-expected.txt
A LayoutTests/fast/forms/datalist/datalist-id-change-crash.html

  Log Message:
  ---
  Cherry-pick 252432.1015@safari-7614-branch (3be45019e7fd). rdar://104668509

Crash in HTMLInputElement::dataListMayHaveChanged via 
ListAttributeTargetObserver::idTargetChanged
https://bugs.webkit.org/show_bug.cgi?id=250039
rdar://103823004

Reviewed by Wenson Hsieh, Geoffrey Garen and Aditya Keerthi.

Merge https://commits.webkit.org/253773@main to avoid hitting this crash.

* LayoutTests/fast/forms/datalist/datalist-id-change-crash-expected.txt: 
Added.
* LayoutTests/fast/forms/datalist/datalist-id-change-crash.html: Added.
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::resetListAttributeTargetObserver):
(WebCore::ListAttributeTargetObserver::ListAttributeTargetObserver):

Canonical link: https://commits.webkit.org/252432.1015@safari-7614-branch

Canonical link: https://commits.webkit.org/259454@main


Compare: https://github.com/WebKit/WebKit/compare/1ae8226dbb80...f9fd2a39a365
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a810c2: WinCairo can't compile: WebGPUPresentationContextD...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a810c291903cd7987526fd3260193c51dae862c7
  
https://github.com/WebKit/WebKit/commit/a810c291903cd7987526fd3260193c51dae862c7
  Author: Fujii Hironori 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.h

  Log Message:
  ---
  WinCairo can't compile: WebGPUPresentationContextDescriptor.h(33): error 
C3646: 'compositorIntegration': unknown override specifier
https://bugs.webkit.org/show_bug.cgi?id=251537

Unreviewed WinCairo build fix.

* Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.h:

Canonical link: https://commits.webkit.org/259709@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1e816c: [IFC] InlineDisplayLineBuilder::collectEnclosingLi...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e816c14834691a91afd65ec26b54aaf029b98e1
  
https://github.com/WebKit/WebKit/commit/1e816c14834691a91afd65ec26b54aaf029b98e1
  Author: Alan Baradlay 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt
M 
LayoutTests/platform/ios/fast/forms/input-text-scroll-left-on-blur-expected.txt
M LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt
M 
LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt
M LayoutTests/platform/mac/fast/forms/search-rtl-expected.txt
M Source/WebCore/layout/formattingContexts/inline/InlineRect.h
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
M 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp

  Log Message:
  ---
  [IFC] InlineDisplayLineBuilder::collectEnclosingLineGeometry should include 
root inline box in scrollable overflow
https://bugs.webkit.org/show_bug.cgi?id=251414

Reviewed by Antti Koivisto.

Display::Line should include all scrollable overflow that we can compute 
excluding the "padding end" hack in 
LegacyLineLayout::addOverflowFromInlineChildren.

* 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::lineOverflowLogicalWidth): 
LegacyLineLayout::addOverflowFromInlineChildren ignores RTL content, so should 
IFC.
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

Canonical link: https://commits.webkit.org/259708@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e873de: WPT: A subtest in shadow-dom/focus/focus-method-wi...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e873de3c117e4e0e5a8c9103b64b394d0a3c3f3d
  
https://github.com/WebKit/WebKit/commit/e873de3c117e4e0e5a8c9103b64b394d0a3c3f3d
  Author: Ryosuke Niwa 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-method-with-delegatesFocus-expected.txt
M Source/WebCore/dom/Element.cpp

  Log Message:
  ---
  WPT: A subtest in shadow-dom/focus/focus-method-with-delegatesFocus.html fails
https://bugs.webkit.org/show_bug.cgi?id=251462

Reviewed by Tim Nguyen.

The bug was caused by findFocusDelegateInternal only iterating over its direct 
children instead of all descendants.
Fixed the bug by changing it to traverse all descendant nodes.

* 
LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-method-with-delegatesFocus-expected.txt:
* Source/WebCore/dom/Element.cpp:
(WebCore::findFocusDelegateInternal):

Canonical link: https://commits.webkit.org/259707@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a423cd: Expose WebCore::ContentExtensions::parseRuleList a...

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a423cde6af09afbcb38784951a94ff40a28fac6e
  
https://github.com/WebKit/WebKit/commit/a423cde6af09afbcb38784951a94ff40a28fac6e
  Author: Brian Weinstein 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/APIContentRuleList.cpp
M Source/WebKit/UIProcess/API/APIContentRuleList.h
M Source/WebKit/UIProcess/API/Cocoa/WKContentRuleList.mm
M Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListPrivate.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm

  Log Message:
  ---
  Expose WebCore::ContentExtensions::parseRuleList as WebKit SPI
https://bugs.webkit.org/show_bug.cgi?id=251465


Reviewed by Alex Christensen.

This patch also adds tests for passing and failing rule parsing.

* Source/WebKit/UIProcess/API/APIContentRuleList.cpp:
(API::ContentRuleList::parseRuleList): Call into 
WebCore::ContentExtensions::parseRuleList and return the error code if it 
exists.
* Source/WebKit/UIProcess/API/APIContentRuleList.h:
* Source/WebKit/UIProcess/API/Cocoa/WKContentRuleList.mm:
(+[WKContentRuleList _parseRuleList:]): Call into 
API::ContentRuleList::parseRuleList and wrap the error code in an NSError if 
necessary.
* Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListPrivate.h:

Canonical link: https://commits.webkit.org/259706@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dd0930: Prefix the SVGAnimationElement range setting metho...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd0930cde59d3dd6f7bdf7db838e4d400cf98dff
  
https://github.com/WebKit/WebKit/commit/dd0930cde59d3dd6f7bdf7db838e4d400cf98dff
  Author: Said Abou-Hallawa 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/svg/SVGAnimateElementBase.cpp
M Source/WebCore/svg/SVGAnimateElementBase.h
M Source/WebCore/svg/SVGAnimateMotionElement.cpp
M Source/WebCore/svg/SVGAnimateMotionElement.h
M Source/WebCore/svg/SVGAnimationElement.cpp
M Source/WebCore/svg/SVGAnimationElement.h

  Log Message:
  ---
  Prefix the SVGAnimationElement range setting methods with "set" instead of 
"calculate"
https://bugs.webkit.org/show_bug.cgi?id=251450
rdar://104881126

Reviewed by Nikolas Zimmermann.

This will make the code more readable and the names of these methods will match
the names of the SVGAttributeAnimator methods which are called by these methods.

* Source/WebCore/svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::setFromAndToValues):
(WebCore::SVGAnimateElementBase::setFromAndByValues):
(WebCore::SVGAnimateElementBase::setToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateElementBase::calculateFromAndByValues): Deleted.
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue): Deleted.
* Source/WebCore/svg/SVGAnimateElementBase.h:
* Source/WebCore/svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::setFromAndToValues):
(WebCore::SVGAnimateMotionElement::setFromAndByValues):
(WebCore::SVGAnimateMotionElement::setToAtEndOfDurationValue):
(WebCore::SVGAnimateMotionElement::calculateToAtEndOfDurationValue): Deleted.
(WebCore::SVGAnimateMotionElement::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues): Deleted.
* Source/WebCore/svg/SVGAnimateMotionElement.h:
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
(WebCore::SVGAnimationElement::updateAnimation):
* Source/WebCore/svg/SVGAnimationElement.h:

Canonical link: https://commits.webkit.org/259705@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1a9f2a: Fix bug in VTTCue::toJSON() found by new libcpp as...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a9f2a2c95a6f5469424a880f82818f37b21710d
  
https://github.com/WebKit/WebKit/commit/1a9f2a2c95a6f5469424a880f82818f37b21710d
  Author: Chris Dumez 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/html/track/VTTCue.cpp

  Log Message:
  ---
  Fix bug in VTTCue::toJSON() found by new libcpp assertions
https://bugs.webkit.org/show_bug.cgi?id=251476
rdar://104893184

Reviewed by Jer Noble.

Fix bug in VTTCue::toJSON() found by new libcpp assertions. This was
causing media/track/track-extended-descriptions.html to crash on some
bots.

The if condition was reversed.

* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::toJSON const):

Canonical link: https://commits.webkit.org/259704@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 414ff0: [@property] Ensure style is up to date in Computed...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 414ff00191187e3403f8a98e39a30a73f9f0ccd4
  
https://github.com/WebKit/WebKit/commit/414ff00191187e3403f8a98e39a30a73f9f0ccd4
  Author: Antti Koivisto 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt
M Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp

  Log Message:
  ---
  [@property] Ensure style is up to date in 
ComputedStylePropertyMapReadOnly::entries
https://bugs.webkit.org/show_bug.cgi?id=251517
rdar://104916732

Reviewed by Alan Baradlay.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt:
* Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:
(WebCore::ComputedStylePropertyMapReadOnly::size const):
(WebCore::ComputedStylePropertyMapReadOnly::entries const):

Ensure style is up to date for custom properties so that we get the correct 
count.

Canonical link: https://commits.webkit.org/259703@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 63e381: [JSC] Referenced function is functionIndexSpace

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63e3817996f2a420d1f880c520ab06ba245f5f5a
  
https://github.com/WebKit/WebKit/commit/63e3817996f2a420d1f880c520ab06ba245f5f5a
  Author: Yusuke Suzuki 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
A JSTests/wasm/stress/only-referenced.js
A JSTests/wasm/stress/resources/only-referenced.wasm
M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp
M Source/JavaScriptCore/wasm/WasmModuleInformation.h
M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp

  Log Message:
  ---
  [JSC] Referenced function is functionIndexSpace
https://bugs.webkit.org/show_bug.cgi?id=251522
rdar://104912723

Reviewed by Tadeu Zagallo.

Wasm Referenced functions are managed via functionIndexSpace, but we are 
querying to it via functionIndex, which is wrong.
This patch fixes it.

* JSTests/wasm/stress/only-referenced.js: Added.
(async let):
* JSTests/wasm/stress/resources/only-referenced.wasm: Added.
* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::compileFunction):
* Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::didCompleteCompilation):
* Source/JavaScriptCore/wasm/WasmModuleInformation.h:
(JSC::Wasm::ModuleInformation::hasReferencedFunction const):
(JSC::Wasm::ModuleInformation::addReferencedFunction const):
(JSC::Wasm::ModuleInformation::callCanClobberInstance const):
(JSC::Wasm::ModuleInformation::addClobberingTailCall):
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::initializeExports):

Canonical link: https://commits.webkit.org/259702@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 23da5c: [ Ventura EWS ] 2x AVIF tests are constant failure...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 23da5c83731a9dafb37726efa3d0fae742a819ec
  
https://github.com/WebKit/WebKit/commit/23da5c83731a9dafb37726efa3d0fae742a819ec
  Author: Robert Jenner 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
R LayoutTests/platform/mac-ventura-wk1/TestExpectations
R LayoutTests/platform/mac-ventura-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [ Ventura EWS ] 2x AVIF tests are constant failures on EWS only
https://bugs.webkit.org/show_bug.cgi?id=251526
rdar://problem/104922722

Unreviewed test gardening.

Setting expectations for these tests while we wait for EWS to get updated to 
the latest version of macOS ventura. Also, cleaning up test expectation 
directories.

* LayoutTests/platform/mac-ventura-wk1/TestExpectations: Removed.
* LayoutTests/platform/mac-ventura-wk2/TestExpectations: Removed.
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/259701@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 167dfa: Ensure CacheStorageDiskStore make isolated copy of...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 167dfa751c25fc50f7c2aa6199e2dc968c6fee71
  
https://github.com/WebKit/WebKit/commit/167dfa751c25fc50f7c2aa6199e2dc968c6fee71
  Author: Sihui Liu 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp

  Log Message:
  ---
  Ensure CacheStorageDiskStore make isolated copy of arguments when passing 
them between WorkQueues
https://bugs.webkit.org/show_bug.cgi?id=251471
rdar://104892197

Reviewed by Per Arne Vollan.

* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp:
(WebKit::CacheStorageDiskStore::deleteRecords):
(WebKit::CacheStorageDiskStore::writeRecords):

Canonical link: https://commits.webkit.org/259700@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fa74f2: Unreviewed, reverting r259523@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa74f2720e54b2df1c392ff01242cbad39cf459c
  
https://github.com/WebKit/WebKit/commit/fa74f2720e54b2df1c392ff01242cbad39cf459c
  Author: Commit Queue 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/SourcesCocoa.txt
R Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifest.h
R Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifest.mm
R Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifestInternal.h
R Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifestPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKInspectorInternal.h
M Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm

  Log Message:
  ---
  Unreviewed, reverting r259523@main.
https://bugs.webkit.org/show_bug.cgi?id=251525

No longer needed.

Reverted changeset:

"Add WKApplicationManifest API"
https://bugs.webkit.org/show_bug.cgi?id=251298
https://commits.webkit.org/259523@main

Canonical link: https://commits.webkit.org/259699@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7270cc: m_styleSheetCandidateNodes in StyleScope should be...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7270cc8dcf9c1c980f1a864a41c71bdbab1b6b52
  
https://github.com/WebKit/WebKit/commit/7270cc8dcf9c1c980f1a864a41c71bdbab1b6b52
  Author: Ryosuke Niwa 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WTF/wtf/WeakListHashSet.h
M Source/WebCore/style/StyleScope.cpp
M Source/WebCore/style/StyleScope.h
M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp

  Log Message:
  ---
  m_styleSheetCandidateNodes in StyleScope should be WeakListHashSet
https://bugs.webkit.org/show_bug.cgi?id=251402

Reviewed by Antti Koivisto.

Deployed WeakListHashSet for m_styleSheetCandidateNodes in StyleScope.

* Source/WTF/wtf/WeakListHashSet.h:
(WTF::WeakListHashSet::WeakListHashSetIteratorBase::WeakListHashSetIteratorBase):
(WTF::WeakListHashSet::WeakListHashSetIteratorBase::advanceBackwards): Added.
(WTF::WeakListHashSet::WeakListHashSetConstIterator::operator--): Added.
(WTF::WeakListHashSet::WeakListHashSetIterator::operator--): Added.

* Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::addStyleSheetCandidateNode):
(WebCore::Style::Scope::removeStyleSheetCandidateNode):
(WebCore::Style::Scope::collectXSLTransforms):
(WebCore::Style::Scope::collectActiveStyleSheets):

* Source/WebCore/style/StyleScope.h:

* Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(WTF_WeakPtr.WeakListHashSetIterators):

Canonical link: https://commits.webkit.org/259698@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a353ca: Print JIT_COMMENT annotations on capstone

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a353cafc05f980240b2c84790749e33fa52e1d0d
  
https://github.com/WebKit/WebKit/commit/a353cafc05f980240b2c84790749e33fa52e1d0d
  Author: Angelos Oikonomopoulos 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/JavaScriptCore/disassembler/CapstoneDisassembler.cpp

  Log Message:
  ---
  Print JIT_COMMENT annotations on capstone
https://bugs.webkit.org/show_bug.cgi?id=251507

Reviewed by Mark Lam and Yusuke Suzuki.

Makes the debugging experience on 32-bit ARM a bit more pleasant.

* Source/JavaScriptCore/disassembler/CapstoneDisassembler.cpp:
(JSC::tryToDisassemble):

Canonical link: https://commits.webkit.org/259697@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 279d12: [css-scroll-snap] Have ScrollSnapAnimatorState cal...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 279d12080527fa36e94941feedf813eac7b87a5a
  
https://github.com/WebKit/WebKit/commit/279d12080527fa36e94941feedf813eac7b87a5a
  Author: Nikolaos Mouchtaris 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
A LayoutTests/css3/scroll-snap/scroll-snap-remove-snap-area-expected.txt
A LayoutTests/css3/scroll-snap/scroll-snap-remove-snap-area.html
M Source/WebCore/platform/ScrollSnapAnimatorState.cpp
M Source/WebCore/platform/ScrollSnapAnimatorState.h

  Log Message:
  ---
  [css-scroll-snap] Have ScrollSnapAnimatorState calculate the HashSet of 
currently snapped boxes immediately
https://bugs.webkit.org/show_bug.cgi?id=251449
rdar://104816359

Reviewed by Simon Fraser.

The added test css3/scroll-snap/scroll-snap-remove-snap-area.html exposes a bug 
where removing a snap
area while we are currently snapped to multiple boxes will cause the state in 
the offsets stored in
m_currentlySnappedBoxesX and m_currentlySnappedBoxesY to become out of sync 
with the state
in m_snapOffsetsInfo. To resolve this, run currentlySnappedBoxes immediately 
and store its
result, rather than running it when we are no no longer snapped to multiple 
boxes, where the
state in m_currentlySnappedBoxesX and m_currentlySnappedBoxesY could be stale.

* Source/WebCore/platform/ScrollSnapAnimatorState.cpp:
(WebCore::ScrollSnapAnimatorState::currentlySnappedBoxes const):
(WebCore::ScrollSnapAnimatorState::chooseBoxToResnapTo const):
(WebCore::ScrollSnapAnimatorState::resnapAfterLayout):
(WebCore::isSnappedToMultipleBoxes): Deleted.
* Source/WebCore/platform/ScrollSnapAnimatorState.h:

Canonical link: https://commits.webkit.org/259696@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 531e07: Resync web-platform-tests/fs from upstream

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 531e07cf4cb54b3be8237c776ce4ac7598296bd1
  
https://github.com/WebKit/WebKit/commit/531e07cf4cb54b3be8237c776ce4ac7598296bd1
  Author: Sihui Liu 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/imported/w3c/resources/import-expectations.json
M 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.js
M 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker.js
M 
LayoutTests/imported/w3c/web-platform-tests/fs/resources/sandboxed-fs-test-helpers.js
M 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-getUniqueId.js
M 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-remove.js
M 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-removeEntry.js
M 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-create-sync-access-handle.js
M 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-move.js

  Log Message:
  ---
  Resync web-platform-tests/fs from upstream
https://bugs.webkit.org/show_bug.cgi?id=251478

Reviewed by Tim Nguyen.

Based on upstream d80a211a093ebb8289e2c8ef5f9520167fb3b0a4.

* LayoutTests/imported/w3c/resources/import-expectations.json:
* 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.js:
(sync_access_handle_test):
* 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker.js:
(sync_access_handle_test):
* 
LayoutTests/imported/w3c/web-platform-tests/fs/resources/sandboxed-fs-test-helpers.js:
(getFileSystemType):
* 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-getUniqueId.js:
(directory_test.async t):
* 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-remove.js:
(directory_test.async t):
* 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-removeEntry.js:
(directory_test.async t):
* 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-create-sync-access-handle.js:
(directory_test.async t):
* 
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-move.js:
(directory_test.async t):

Canonical link: https://commits.webkit.org/259695@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 20f1ff: [ iOS ] http/wpt/css/css-animations/set-animation-...

[btashawn]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20f1ff1397ad7042e5e2e0e7bdbbf1587418a188
  
https://github.com/WebKit/WebKit/commit/20f1ff1397ad7042e5e2e0e7bdbbf1587418a188
  Author: Bri Harris 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [ iOS ] 
http/wpt/css/css-animations/set-animation-play-state-to-paused-001.html is a 
flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=251482
rdar://104901420

Unreviewed test gardening.

Setting expectation for flaky test.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/259694@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d2a7af: Inline FloatSize::FloatSize(WebCore::IntSize& cons...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2a7afb940a10cd9a2fc90d77fbd50ae12cb01ac
  
https://github.com/WebKit/WebKit/commit/d2a7afb940a10cd9a2fc90d77fbd50ae12cb01ac
  Author: Ahmad Saleem 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/platform/graphics/FloatSize.cpp
M Source/WebCore/platform/graphics/FloatSize.h

  Log Message:
  ---
  Inline FloatSize::FloatSize(WebCore::IntSize& const) constructor

Inline FloatSize::FloatSize(WebCore::IntSize& const) constructor
https://bugs.webkit.org/show_bug.cgi?id=250655
rdar://problem/104536651

Reviewed by Alan Baradlay.

Merge - 
https://chromium.googlesource.com/chromium/blink/+/8ef1d2d2935beef0baf377ee37b76f584b4db631

This patch is potential optimization for scrollview code calling IntSize by 
inlining constructor.

* Source/WebCore/platform/graphics/FloatSize.cpp:
(FloatSize:FloatSize): Remove 'IntSize' constructor function
* Source/WebCore/platform/graphics/FloatSize.h: Inline 'FloatSize' constructor

Canonical link: https://commits.webkit.org/259693@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c74310: [iOS / macOS] fast/repaint/rtl-content-selection-h...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c743104c1d8687d1c46e95a9b5a49b5bfc1fc306
  
https://github.com/WebKit/WebKit/commit/c743104c1d8687d1c46e95a9b5a49b5bfc1fc306
  Author: Alan Baradlay 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/fast/repaint/rtl-content-selection-hairline-gap-expected.txt
M LayoutTests/fast/repaint/rtl-content-selection-hairline-gap.html

  Log Message:
  ---
  [iOS / macOS] fast/repaint/rtl-content-selection-hairline-gap.html is a flaky 
failure
https://bugs.webkit.org/show_bug.cgi?id=251452


Unreviewed.

Do not rely on repaint order.

* LayoutTests/fast/repaint/rtl-content-selection-hairline-gap-expected.txt:
* LayoutTests/fast/repaint/rtl-content-selection-hairline-gap.html:

Canonical link: https://commits.webkit.org/259692@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 632106: [webkitscmpy] Expose hash of HEAD commit

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6321064705379313571b63cace53a7fc0fe6abd0
  
https://github.com/WebKit/WebKit/commit/6321064705379313571b63cace53a7fc0fe6abd0
  Author: Jonathan Bedard 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/setup.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py
M 
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py

  Log Message:
  ---
  [webkitscmpy] Expose hash of HEAD commit
https://bugs.webkit.org/show_bug.cgi?id=251464
rdar://104889825

Reviewed by Aakash Jain.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket.request): Return hash of PR head.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
(GitHub.graphql): Pass hash of PR head.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:
(PullRequest.__init__): Receive hash of PR head.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.PRGenerator.PullRequest): Pass hash of PR head.
(BitBucket.PRGenerator.create): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.PRGenerator.PullRequest): Pass hash of PR head.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

Canonical link: https://commits.webkit.org/259691@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3bf17: Merge WebGL2 enablement flag with WebGL flag

[EWS]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3bf17995e0543582de0d43c9b8429ba2716eb2e
  
https://github.com/WebKit/WebKit/commit/e3bf17995e0543582de0d43c9b8429ba2716eb2e
  Author: Brent Fulgham 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html
M LayoutTests/fast/canvas/webgl/bufferData-offset-length.html
M LayoutTests/fast/canvas/webgl/copyBufferSubData.html
M LayoutTests/fast/canvas/webgl/getBufferSubData-webgl1.html
M LayoutTests/fast/canvas/webgl/webgl2-buffer-targets.html
M LayoutTests/fast/canvas/webgl/webgl2-buffers.html
M LayoutTests/fast/canvas/webgl/webgl2-context-creation.html
M LayoutTests/fast/canvas/webgl/webgl2-getActiveUniforms.html
M LayoutTests/fast/canvas/webgl/webgl2-getbuffersubdata.html
M LayoutTests/fast/canvas/webgl/webgl2-glsl3-compile.html
M LayoutTests/fast/canvas/webgl/webgl2-runtime-flag.html
M LayoutTests/fast/canvas/webgl/webgl2-texStorage.html
M LayoutTests/fast/canvas/webgl/webgl2-texture-upload-enums.html
M LayoutTests/fast/canvas/webgl/webgl2/bindings.html
M LayoutTests/fast/canvas/webgl/webgl2/constants.html
M LayoutTests/fast/canvas/webgl/webgl2/sequences.html
M LayoutTests/inspector/canvas/create-context-webgl2.html
M LayoutTests/inspector/canvas/recording-webgl2-snapshots.html
M LayoutTests/inspector/canvas/requestContent-webgl2.html
M LayoutTests/inspector/canvas/resolveContext-webgl2.html
M LayoutTests/inspector/canvas/resources/recording-webgl2.js
M LayoutTests/inspector/canvas/shaderProgram-add-remove-webgl2.html
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp
M Source/WebCore/Modules/webxr/WebXRWebGLLayer.h
M Source/WebCore/Modules/webxr/WebXRWebGLLayer.idl
M Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp
M Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/Document.idl
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/HTMLCanvasElement.idl
M Source/WebCore/html/OffscreenCanvas.cpp
M Source/WebCore/html/OffscreenCanvas.h
M Source/WebCore/html/OffscreenCanvas.idl
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGL2RenderingContext.h
M Source/WebCore/html/canvas/WebGL2RenderingContext.idl
M Source/WebCore/html/canvas/WebGLAny.h
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
M Source/WebCore/html/canvas/WebGLTransformFeedback.cpp
M Source/WebCore/html/canvas/WebGLTransformFeedback.h
M Source/WebCore/html/canvas/WebGLTransformFeedback.idl
M Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp
M Source/WebCore/html/canvas/WebGLVertexArrayObject.h
M Source/WebCore/html/canvas/WebGLVertexArrayObject.idl
M Source/WebCore/inspector/InspectorCanvas.cpp
M Source/WebCore/inspector/InspectorCanvasCallTracer.h
M Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp
M Source/WebCore/page/PageConsoleClient.cpp
M Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h
M Source/WebCore/platform/graphics/gbm/GraphicsContextGLFallback.cpp
M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp
M 
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
M Source/cmake/OptionsGTK.cmake
M Source/cmake/OptionsMac.cmake
M Source/cmake/OptionsWPE.cmake
M Source/cmake/OptionsWin.cmake
M Source/cmake/WebKitFeatures.cmake
M Tools/DumpRenderTree/win/DumpRenderTree.cpp
M Tools/Scripts/webkitperl/FeatureList.pm

  Log Message:
  ---
  Merge WebGL2 enablement flag with WebGL flag
https://bugs.webkit.org/show_bug.cgi?id=248667


Reviewed by Kimmo Kinnunen.

We've been shipping WebGL2 for many years, and no longer need a separate WebGL2 
flag. Instead, we
should merge the WebGL2 enablement flag (and compile guards) with the 
higher-level WebGL feature.

* LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html: No 
need to enable WebGL2 explicitly.
* LayoutTests/fast/canvas/webgl/bufferData-offset-length.html: Ditto.
* 

[webkit-changes] [WebKit/WebKit] 22004f: Rename FileSystem::FileOpenMode::Write to FileSyst...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22004f62ebe45a346a22574601e6b5191cc62cc5
  
https://github.com/WebKit/WebKit/commit/22004f62ebe45a346a22574601e6b5191cc62cc5
  Author: Sihui Liu 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/JavaScriptCore/jsc.cpp
M Source/JavaScriptCore/wasm/WasmStreamingParser.cpp
M Source/WTF/wtf/FileSystem.cpp
M Source/WTF/wtf/FileSystem.h
M Source/WTF/wtf/glib/FileSystemGlib.cpp
M Source/WTF/wtf/posix/FileSystemPOSIX.cpp
M Source/WTF/wtf/win/FileSystemWin.cpp
M Source/WebCore/Modules/webdatabase/OriginLock.cpp
M Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp
M Source/WebCore/platform/network/BlobRegistryImpl.cpp
M Source/WebCore/platform/network/curl/CookieJarDB.cpp
M Source/WebCore/platform/network/curl/CurlCacheEntry.cpp
M Source/WebCore/platform/network/curl/CurlCacheManager.cpp
M Source/WebCore/workers/service/server/SWScriptStorage.cpp
M Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp
M Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannelCurl.cpp
M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp
M Source/WebKit/Shared/PersistencyUtils.cpp
M Source/WebKit/Shared/WebMemorySampler.cpp
M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp
M Source/WebKit/UIProcess/ios/WKModelView.mm
M Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm
M Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp
M Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm

  Log Message:
  ---
  Rename FileSystem::FileOpenMode::Write to FileSystem::FileOpenMode::Truncate
https://bugs.webkit.org/show_bug.cgi?id=251073
rdar://104590894

Reviewed by Žan Doberšek.

In existing implementation, file opened with FileSystem::FileOpenMode::Write 
will be truncated or recreated if it
exists. This behavior is not clearly indicated in the name, and it causes 
confusion to users. For example, some places
check file size or truncate file after opening it with 
FileSystem::FileOpenMode::Write mode. They may actually need to
use FileSystem::FileOpenMode::ReadWrite mode. Therefore, this patch renames 
FileSystem::FileOpenMode::Write to
FileSystem::FileOpenMode::Truncate. Also, this patch makes glib implementation 
of FileSystem::FileOpenMode::Truncate
mode aligned with POSIX and win implementation, which recreates file when file 
with same name already exists.

* Source/JavaScriptCore/jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/wasm/WasmStreamingParser.cpp:
(JSC::Wasm::dumpWasmSource):
* Source/WTF/wtf/FileSystem.cpp:
(WTF::FileSystemImpl::MappedFileData::mapFileHandle):
(WTF::FileSystemImpl::readOrMakeSalt):
(WTF::FileSystemImpl::overwriteEntireFile):
* Source/WTF/wtf/FileSystem.h:
* Source/WTF/wtf/glib/FileSystemGlib.cpp:
(WTF::FileSystemImpl::openFile):
* Source/WTF/wtf/posix/FileSystemPOSIX.cpp:
(WTF::FileSystemImpl::openFile):
* Source/WTF/wtf/win/FileSystemWin.cpp:
(WTF::FileSystemImpl::openFile):
(WTF::FileSystemImpl::MappedFileData::mapFileHandle):
* Source/WebCore/Modules/webdatabase/OriginLock.cpp:
* Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory):
* Source/WebCore/platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::writeBlobToFilePath):
* Source/WebCore/platform/network/curl/CookieJarDB.cpp:
(WebCore::CookieJarDB::flagDatabaseCorruption):
* Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::saveResponseHeaders):
(WebCore::CurlCacheEntry::openContentFile):
* Source/WebCore/platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::saveIndex):
* Source/WebCore/workers/service/server/SWScriptStorage.cpp:
(WebCore::SWScriptStorage::store):
* Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::download):
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:
(WebKit::ServiceWorkerDownloadTask::setPendingDownloadLocation):
* Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::writeSizeFile):
* Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::dumpContentsToFile):
* Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannelCurl.cpp:
(WebKit::NetworkCache::IOChannel::IOChannel):
* Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse):
* 

[webkit-changes] [WebKit/WebKit] 1b555d: Shrink Layout::ElementBox slightly

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b555d02b07f3338afe4aac3ed96bca02f43992d
  
https://github.com/WebKit/WebKit/commit/1b555d02b07f3338afe4aac3ed96bca02f43992d
  Author: Simon Fraser 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/layout/layouttree/LayoutBox.cpp
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/layout/layouttree/LayoutElementBox.h
M Source/WebCore/rendering/style/RenderStyle.cpp

  Log Message:
  ---
  Shrink Layout::ElementBox slightly
https://bugs.webkit.org/show_bug.cgi?id=251475
rdar://104894626

Reviewed by Alan Baradlay.

Shrink Layout::ElementBox from 184 bytes (13 bytes of padding) to 176 bytes
(5 bytes of padding) by shifting the bitfields in Box up into the spare
4 bytes between CanMakeCheckedPtr's m_count and m_style.

* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::Box):
* Source/WebCore/layout/layouttree/LayoutBox.h:
* Source/WebCore/layout/layouttree/LayoutElementBox.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:

Canonical link: https://commits.webkit.org/259688@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 165e0d: Clear DumpRenderTree and WebKitTestRunner defaults...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 165e0db5c7299e734a4a6c04f157a835d3ee7452
  
https://github.com/WebKit/WebKit/commit/165e0db5c7299e734a4a6c04f157a835d3ee7452
  Author: Simon Fraser 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig
M Tools/DumpRenderTree/mac/Info.plist
M Tools/Scripts/webkitpy/port/mac.py

  Log Message:
  ---
  Clear DumpRenderTree and WebKitTestRunner defaults before running tests
https://bugs.webkit.org/show_bug.cgi?id=251397
rdar://104838472

Reviewed by Jonathan Bedard.

Historically DumpRenderTree had no bundleID specified, so would save 
NSUserDefaults using
"DumpRenderTree". WebKitTestRunner, on the other hand, was correctly set up to 
use
"com.apple.WebKit.WebKitTestRunner". This patch gives DumpRenderTree a bundleID 
with
a "com.apple.WebKit" prefix.

These bundleIDs matter because webkitpy uses them to clear NSUserDefaults 
before test runs;
this worked fine for DumpRenderTree, but failed for WebKitTestRunner because 
the bundleID
was incorrect. Fix that in mac.py, and use the new bundleID 
com.apple.WebKit.DumpRenderTree too.

Generally failing to clear NSUserDefaults before testing isn't an issue, but 
defaults like WebCoreLogging
can get saved into NSUserDefaults if you run WebKitTestRunner directly with 
logging arguments, so clearing
before running tests is useful in that scenario.

* Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
* Tools/DumpRenderTree/mac/Info.plist:
* Tools/Scripts/webkitpy/port/mac.py:
(MacPort.reset_preferences):

Canonical link: https://commits.webkit.org/259687@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7e5444: [GTK] Remove on-demand hardware acceleration setting

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e5444b964e5e8685a2e6809f9600c2b29855654
  
https://github.com/WebKit/WebKit/commit/7e5444b964e5e8685a2e6809f9600c2b29855654
  Author: Michael Catanzaro 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp
M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
M Source/WebKit/UIProcess/API/glib/WebKitSettings.h.in
M Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md
M Tools/MiniBrowser/gtk/BrowserSettingsDialog.c
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp

  Log Message:
  ---
  [GTK] Remove on-demand hardware acceleration setting
https://bugs.webkit.org/show_bug.cgi?id=232516

Reviewed by Carlos Garcia Campos.

There are now only two options for hardware acceleration: ALWAYS or
NEVER. The ON_DEMAND option does not work anymore and should be removed
from the API.

This also fixes the precondition check in 
webkit_settings_get_hardware_acceleration_policy
to correctly return the new default value ALWAYS rather than ON_DEMAND,
which was the original default value.

* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::hardwareAccelerationPolicy):
* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_class_init):
(webkit_settings_get_hardware_acceleration_policy):
(webkit_settings_set_hardware_acceleration_policy):
* Source/WebKit/UIProcess/API/glib/WebKitSettings.h.in:
* Source/WebKit/gtk/migrating-to-webkitgtk-6.0.md:
* Tools/MiniBrowser/gtk/BrowserSettingsDialog.c:
(hardwareAccelerationPolicyToString):
(stringToHardwareAccelerationPolicy):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

Canonical link: https://commits.webkit.org/259686@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e80607: Don't create renderer for foreignElement when it h...

[Chirag Shah]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e806076966607b8327822663338316299261960b
  
https://github.com/WebKit/WebKit/commit/e806076966607b8327822663338316299261960b
  Author: Chirag M Shah 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
A 
LayoutTests/svg/foreignObject/foreign-object-without-svgroot-crash-expected.txt
A LayoutTests/svg/foreignObject/foreign-object-without-svgroot-crash.html
M Source/WebCore/svg/SVGForeignObjectElement.cpp

  Log Message:
  ---
  Don't create renderer for foreignElement when it has no parent
https://bugs.webkit.org/show_bug.cgi?id=241778
rdar://102916021

Reviewed by Nikolas Zimmermann.

If the body is replaced by foreignElement, it results in a DOM which
doesn't have anything to render or layout, but it crashes WebKit because
we trip over an assert because isPaintOffsetCacheEnabled is not disabled
(which happens only when there is a SVGRoot). This change makes it so
that we don't generate the useless renderer in the first place, which is
what happens with other SVGElements.

* 
LayoutTests/svg/foreignObject/foreign-object-without-svgroot-crash-expected.txt:
 Added.
* LayoutTests/svg/foreignObject/foreign-object-without-svgroot-crash.html: 
Added.
* Source/WebCore/svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::rendererIsNeeded):

Canonical link: https://commits.webkit.org/259685@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c6d75c: [IFC] InlineFormattingGeometry::staticPositionForO...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6d75c202f1a68a6775a31e789ce687cee6549d5
  
https://github.com/WebKit/WebKit/commit/c6d75c202f1a68a6775a31e789ce687cee6549d5
  Author: Alan Baradlay 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp

  Log Message:
  ---
  [IFC] InlineFormattingGeometry::staticPositionForOutOfFlowBlockLevelBox 
should be able to handle empty content
https://bugs.webkit.org/show_bug.cgi?id=251477


Reviewed by Antti Koivisto.

This is the block level box variant of webkit.org/b/248158 (<- inline level 
box).
While line-clamp does not produce empty IFCs anymore (changed at 
webkit.org/b/250270), accessing line[0] unconditionally may not be such a great 
idea.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowBlockLevelBox
 const):

Canonical link: https://commits.webkit.org/259684@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0fc624: [GLib] Always mount injected bundle directory in s...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0fc62415db2026ed0dab62716dbc96f560014789
  
https://github.com/WebKit/WebKit/commit/0fc62415db2026ed0dab62716dbc96f560014789
  Author: Michael Catanzaro 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp

  Log Message:
  ---
  [GLib] Always mount injected bundle directory in sandbox
https://bugs.webkit.org/show_bug.cgi?id=251456

Reviewed by Carlos Garcia Campos.

Incredibly, we somehow never noticed that the injected bundle is not
always mounted in the sandbox. It's not very useful if it cannot be
loaded.

* Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextConstructed):

Canonical link: https://commits.webkit.org/259683@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 926070: Change the default iPadOS simulator to one with a ...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92607080b412d700ab8153ccff38a3983b9f3528
  
https://github.com/WebKit/WebKit/commit/92607080b412d700ab8153ccff38a3983b9f3528
  Author: Karl Rackler 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
M Tools/Scripts/webkitpy/port/ios_simulator.py
M Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py

  Log Message:
  ---
  Change the default iPadOS simulator to one with a larger screen size
https://bugs.webkit.org/show_bug.cgi?id=251458
rdar://104886115

Reviewed by Jonathan Bedard and Ryan Haddad.

* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_device_type_test_division):
(RunTest.test_device_type_specific_listing):
(RunTest.test_ipad_test_division):
(RunTest.test_ipad_listing):
* Tools/Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort):
(IPadSimulatorPort):
* Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py:

Canonical link: https://commits.webkit.org/259682@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 10f129: [GLib] Missing documentation for webkit_web_view_r...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 10f129989dc4897f1022296f096559717c7334fe
  
https://github.com/WebKit/WebKit/commit/10f129989dc4897f1022296f096559717c7334fe
  Author: Michael Catanzaro 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp

  Log Message:
  ---
  [GLib] Missing documentation for 
webkit_web_view_run_async_javascript_function_in_world()
https://bugs.webkit.org/show_bug.cgi?id=251512

Reviewed by Philippe Normand.

webkit_web_view_run_async_javascript_function_in_world() is present in
our documentation, but the description of the function is missing, as is
the descriptions of all the parameters and the return value.

It's not a doc comment. Oops!

* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:

Canonical link: https://commits.webkit.org/259681@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 33dd5d: [GStreamer][WebRTC] Crash in statistics handling o...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33dd5dfb48a03e391d600487a9a856e61946cd34
  
https://github.com/WebKit/WebKit/commit/33dd5dfb48a03e391d600487a9a856e61946cd34
  Author: Philippe Normand 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Crash in statistics handling on RPi3
https://bugs.webkit.org/show_bug.cgi?id=251497

Reviewed by Xabier Rodriguez-Calvar.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::fillRTCCandidatePairStats): The state field is not optional, so for 
the time being fill it
with a value not necessarily corresponding to the real platform state.

Canonical link: https://commits.webkit.org/259680@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 19363b: [GTK] Simplify construction of injected bundle path

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19363b5213a148ec97b6f025b213426d69de7056
  
https://github.com/WebKit/WebKit/commit/19363b5213a148ec97b6f025b213426d69de7056
  Author: Michael Catanzaro 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/PlatformGTK.cmake
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp

  Log Message:
  ---
  [GTK] Simplify construction of injected bundle path
https://bugs.webkit.org/show_bug.cgi?id=251457

Reviewed by Adrian Perez de Castro.

Simplify construction of the injected bundle path by defining PKGLIBDIR
for GTK, as is already done for WPE.

* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:
(injectedBundleDirectory):

Canonical link: https://commits.webkit.org/259679@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 914c16: Regression(ScreenOrientation API) Fullscreen exits...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 914c16e8faccc6f14fd3eef8bfaac5065509b98a
  
https://github.com/WebKit/WebKit/commit/914c16e8faccc6f14fd3eef8bfaac5065509b98a
  Author: Chris Dumez 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/fast/dom/Orientation/no-orientation-change-event-when-unparenting-view-expected.txt
A 
LayoutTests/fast/dom/Orientation/no-orientation-change-event-when-unparenting-view.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/platform/ScreenOrientationProvider.cpp
M Source/WebCore/platform/ScreenOrientationProvider.h
M Source/WebCore/platform/ios/ScreenOrientationProviderIOS.mm

  Log Message:
  ---
  Regression(ScreenOrientation API) Fullscreen exits right away on Youtube
https://bugs.webkit.org/show_bug.cgi?id=251396
rdar://104269674

Reviewed by Wenson Hsieh.

When entering fullscreen on youtube, the view would lose its window and
then get added to a new Window. This would end up calling
`ScreenOrientationProvider::setWindow()` first with nil then with the new
window.

To determine the screen orientation, the ScreenOrientationProvider currently
needs access to the window object inside platformCurrentOrientation(). If
it didn't have a window, platformCurrentOrientation() would just return
PortraitPrimary.

When updating the window, setWindow() would call screenOrientationDidChange()
which would call platformCurrentOrientation() again to make sure the cached
orientation is still accurate and to notify the clients that the orientation
has changed otherwise. However, since platformCurrentOrientation() requires
a window, there is no point in calling screenOrientationDidChange() if the
new window is nil. It will just reset the orientation to the PortaitPrimary
value and potentially send an incorrect orientation change notification to
clients. This incorrect notification is what was causing the fullscreen
mode to exit (since fullscreen mode exists on orientation change).

To address this, I made 2 changes:
1. setWindow() now only calls screenOrientationDidChange() if the new
   window is non-nil.
2. platformCurrentOrientation() now returns a std::optional<> to make it
   clear when it wasn't able to determinate the orientation.
4. In screenOrientationDidChange(), if platformCurrentOrientation() returns
   std::nullopt, we now return early so that we don't send clients a
   potentially inaccurate orientation. Once the view gets added again to
   a window, we'll call screenOrientationDidChange() again to make sure
   we send a change notification if needed.

* Source/WebCore/platform/ScreenOrientationProvider.cpp:
(WebCore::ScreenOrientationProvider::screenOrientationDidChange):
(WebCore::ScreenOrientationProvider::currentOrientation):
(WebCore::ScreenOrientationProvider::platformCurrentOrientation):
* Source/WebCore/platform/ScreenOrientationProvider.h:
* Source/WebCore/platform/ios/ScreenOrientationProviderIOS.mm:
(WebCore::ScreenOrientationProvider::platformCurrentOrientation):
(WebCore::ScreenOrientationProvider::setWindow):

Canonical link: https://commits.webkit.org/259678@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] abe64b: [GStreamer][WebRTC] WebRTCProvider might be trigge...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: abe64b617c464693615c81720fd4a0c6c349a749
  
https://github.com/WebKit/WebKit/commit/abe64b617c464693615c81720fd4a0c6c349a749
  Author: Philippe Normand 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] WebRTCProvider might be triggered on uninitialized 
GStreamer runtime
https://bugs.webkit.org/show_bug.cgi?id=251496

Reviewed by Xabier Rodriguez-Calvar.

Make sure GStreamer has been initialized before probing the video encoding 
capabilities.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.cpp:
(WebCore::GStreamerWebRTCProvider::initializeVideoEncodingCapabilities):

Canonical link: https://commits.webkit.org/259677@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7f5f2f: [GTK] Fix for build (linker) failure on WAYLAND ta...

[Kiran Pradeep]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f5f2f78dedbda857d3bfcc6594fa42d023fea5b
  
https://github.com/WebKit/WebKit/commit/7f5f2f78dedbda857d3bfcc6594fa42d023fea5b
  Author: Kiran Pradeep 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp

  Log Message:
  ---
  [GTK] Fix for build (linker) failure on WAYLAND target caused by dependency 
on version WPEBackend_fdo 1.6.0
https://bugs.webkit.org/show_bug.cgi?id=251355

Reviewed by Michael Catanzaro.

WPEBackend_fdo 1.6.0 did not export symbols to get major/minor version numbers. 
e.g. wpe_fdo_get_major_version.
These symbols were exported in version 1.6.1 as shown in
https://github.com/Igalia/WPEBackend-fdo/commit/1dda80de5372e56cdc6f818a3fca493f7cc1f9d6.
 Currently this
results in undefined reference linker error on distributions installing version 
1.6.0. (e.g Ubuntu 20.04)
So these calls are guarded with check of version 1.6.1.

* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU):

Canonical link: https://commits.webkit.org/259676@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9ba4f3: [WPE] Remove WebKitFaviconDatabase from new API

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ba4f3f59221f280e7ff721b6edf18ca0aa06bec
  
https://github.com/WebKit/WebKit/commit/9ba4f3f59221f280e7ff721b6edf18ca0aa06bec
  Author: Carlos Garcia Campos 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebKit/PlatformWPE.cmake
M Source/WebKit/PlatformWPEDeprecated.cmake
M Source/WebKit/SourcesWPE.txt
M Source/WebKit/SourcesWPEDeprecated.txt
M Source/WebKit/UIProcess/API/glib/WebKitAutocleanups.h.in
M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.h.in
M Source/WebKit/UIProcess/API/glib/webkit.h.in

  Log Message:
  ---
  [WPE] Remove WebKitFaviconDatabase from new API
https://bugs.webkit.org/show_bug.cgi?id=251430

Reviewed by Michael Catanzaro.

WPE never supported favicons, I don't know why we expose
WebKitFaviconDatabase, but we don't need it for sure in the new API.

* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/PlatformWPEDeprecated.cmake:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/SourcesWPEDeprecated.txt:
* Source/WebKit/UIProcess/API/glib/WebKitAutocleanups.h.in:
* Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp:
(webkitNetworkSessionConstructed):
* Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.h.in:
* Source/WebKit/UIProcess/API/glib/webkit.h.in:

Canonical link: https://commits.webkit.org/259675@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 02b20b: [GLIB] Unreviewed test gardening, expected to fail...

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02b20b56c9352285ab14399136288650ab463611
  
https://github.com/WebKit/WebKit/commit/02b20b56c9352285ab14399136288650ab463611
  Author: Diego Pino Garcia 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations

  Log Message:
  ---
  [GLIB] Unreviewed test gardening, expected to fail but pass tests

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:

Canonical link: https://commits.webkit.org/259674@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2861d8: [ResizeObserver] The initial last reported size of...

[cathiechen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2861d8c4e29ca8c3384e47f260a0d0e1823c29ae
  
https://github.com/WebKit/WebKit/commit/2861d8c4e29ca8c3384e47f260a0d0e1823c29ae
  Author: Cathie Chen 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/resize-observer/notify-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/resize-observer/observe-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/resize-observer/notify-expected.txt
M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt
M Source/WebCore/page/ResizeObservation.cpp
M Source/WebCore/page/ResizeObserver.cpp
M Source/WebCore/page/ResizeObserver.h

  Log Message:
  ---
  [ResizeObserver] The initial last reported size of ResizeObservation should 
be -1x-1 which always notify observed elements
https://bugs.webkit.org/show_bug.cgi?id=251015

Reviewed by Oriol Brufau and Ryosuke Niwa.

This patch initializes the lastReportedSize of ResizeObservation to -1 x -1, 
which is the conclusion of [1],
it indicates that -1 x -1 is the initial size when first observing an element 
with ResizeObserver.

The previous change makes every ResizeObservation be delivered at least once, 
even if the target is a disconnected element.
When GC happens between observe and gather ResizeObservations, 
JSC::Weak m_callback inside JSCallbackDataWeak
could be released, and the element and JSResizeObserver might not be released, 
for they are not strong connected, this scenario
would trigger the ASSERT in ResizeObserver::deliverObservations. To fix it, 
this patch adds m_targetsWaitingForFirstObservation
to extend the life cycle of ResizeObserver to the first time of 
deliverObservations. The fix is similar to
what IntersectionObserver does in bug 231235.

The test6 of resize-observer/notify.html still fails in mac-wk1, because 
updaterendering is not triggered properly.
Filed [2] to track it.

[1] https://github.com/w3c/csswg-drafts/issues/3664
[2] https://bugs.webkit.org/show_bug.cgi?id=250900

* 
LayoutTests/imported/w3c/web-platform-tests/resize-observer/notify-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/resize-observer/observe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/resize-observer/notify-expected.txt:
 Copied from 
LayoutTests/imported/w3c/web-platform-tests/resize-observer/notify-expected.txt.
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt:
* Source/WebCore/page/ResizeObservation.cpp:
* Source/WebCore/page/ResizeObserver.cpp:
(WebCore::ResizeObserver::observe):
(WebCore::ResizeObserver::deliverObservations):
(WebCore::ResizeObserver::isReachableFromOpaqueRoots const):
(WebCore::ResizeObserver::removeAllTargets):
(WebCore::ResizeObserver::removeObservation):
* Source/WebCore/page/ResizeObserver.h:

Canonical link: https://commits.webkit.org/259673@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad178f: [GStreamer] Missing chain-ups to parent class cons...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad178f924e78b31169f1219d5fcd80ff8e1e27d5
  
https://github.com/WebKit/WebKit/commit/ad178f924e78b31169f1219d5fcd80ff8e1e27d5
  Author: Philippe Normand 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp
M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Missing chain-ups to parent class constructed in custom GStreamer 
elements
https://bugs.webkit.org/show_bug.cgi?id=251446

Reviewed by Xabier Rodriguez-Calvar.

* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
* Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkConstructed):
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderConstructed):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp:
(webkitFliteSrcConstructed):

Canonical link: https://commits.webkit.org/259672@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4697ea: [WGSL] Add a name mangling pass

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4697eaccd00f7f8e11b01e96fe00b5976d8e047f
  
https://github.com/WebKit/WebKit/commit/4697eaccd00f7f8e11b01e96fe00b5976d8e047f
  Author: Tadeu Zagallo 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebGPU/WGSL/CallGraph.h
A Source/WebGPU/WGSL/MangleNames.cpp
A Source/WebGPU/WGSL/MangleNames.h
M Source/WebGPU/WGSL/WGSL.cpp
M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  ---
  [WGSL] Add a name mangling pass
https://bugs.webkit.org/show_bug.cgi?id=251441
rdar://104872078

Reviewed by Myles C. Maxfield.

Initial name mangling pass implementation. It's still a bit bare bones, and 
until
we implement the type checking we can't rename struct fields, but everything 
else
(that is currently supported) works. The implementation is a bit rough, just
renaming everything in place, but it's fairly concise and gets the job done, at
least for the time being.

* Source/WebGPU/WGSL/AST/ASTFunctionDecl.h:
* Source/WebGPU/WGSL/AST/ASTIdentifierExpression.h:
* Source/WebGPU/WGSL/AST/ASTStructureAccess.h:
* Source/WebGPU/WGSL/AST/ASTStructureDecl.h:
* Source/WebGPU/WGSL/AST/ASTTypeDecl.h:
* Source/WebGPU/WGSL/AST/ASTVariableDecl.h:
* Source/WebGPU/WGSL/CallGraph.h:
(WGSL::CallGraph::ast const):
(WGSL::CallGraph::entrypoints const):
(WGSL::CallGraph::ast): Deleted.
(WGSL::CallGraph::entrypoints): Deleted.
* Source/WebGPU/WGSL/MangleNames.cpp: Added.
(WGSL::MangledName::toString const):
(WGSL::NameManglerVisitor::NameManglerVisitor):
(WGSL::NameManglerVisitor::Context::Context):
(WGSL::NameManglerVisitor::Context::lookup const):
(WGSL::NameManglerVisitor::Context::add):
(WGSL::NameManglerVisitor::ContextScope::ContextScope):
(WGSL::NameManglerVisitor::ContextScope::~ContextScope):
(WGSL::NameManglerVisitor::run):
(WGSL::NameManglerVisitor::visit):
(WGSL::NameManglerVisitor::visitFunctionBody):
(WGSL::NameManglerVisitor::visitVariableDeclaration):
(WGSL::NameManglerVisitor::def):
(WGSL::NameManglerVisitor::makeMangledName):
(WGSL::NameManglerVisitor::read const):
(WGSL::mangleNames):
* Source/WebGPU/WGSL/MangleNames.h: Copied from Source/WebGPU/WGSL/CallGraph.h.
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::prepare):
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::getNamedFunction const):

Canonical link: https://commits.webkit.org/259671@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec8c0f: [WGSL] Rename `ArgumentBuffer` roles to `BindGroup`

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec8c0fe9d7ca497f95f5ef3952ff3721ee768f7d
  
https://github.com/WebKit/WebKit/commit/ec8c0fe9d7ca497f95f5ef3952ff3721ee768f7d
  Author: Tadeu Zagallo 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebGPU/WGSL/AST/ASTParameterValue.h
M Source/WebGPU/WGSL/AST/ASTStructure.h
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  ---
  [WGSL] Rename `ArgumentBuffer` roles to `BindGroup`
https://bugs.webkit.org/show_bug.cgi?id=251443
rdar://104873689

Reviewed by Myles C. Maxfield.

Let's try use the WGSL nomenclature instead of Metal in parts of the
codebase that aren't Metal-specific (whenever possible)

* Source/WebGPU/WGSL/AST/ASTFunctionDecl.h:
* Source/WebGPU/WGSL/AST/ASTStructureDecl.h:
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):
(WGSL::RewriteGlobalVariables::insertParameters):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/259670@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87e3bf: [WebGPU] Connect PresentationContext and Composito...

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87e3bf778001ed304bd56f4375eee0e38896632b
  
https://github.com/WebKit/WebKit/commit/87e3bf778001ed304bd56f4375eee0e38896632b
  Author: Myles C. Maxfield 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPU.cpp
M Source/WebCore/Modules/WebGPU/GPU.h
M Source/WebCore/Modules/WebGPU/GPUPresentationContextDescriptor.h
M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp
M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.h
M Source/WebCore/PAL/pal/graphics/WebGPU/WebGPU.h
M 
Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPresentationContextDescriptor.h
M Source/WebCore/html/canvas/GPUCanvasContextCocoa.cpp
M Source/WebCore/html/canvas/GPUCanvasContextCocoa.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.messages.in
M Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp
M Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.h
M 
Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.serialization.in
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h

  Log Message:
  ---
  [WebGPU] Connect PresentationContext and CompositorIntegration
https://bugs.webkit.org/show_bug.cgi?id=251479
rdar://104900104

Reviewed by Tadeu Zagallo.

A PresentationContext is created with a PresentationContextDescriptor, which 
previously had 0
fields. This patch just adds a CompositorIntegration& as a field, so 
PresentationContexts are now
created with a CompositorIntegration.

This patch doesn't actually have the PresentationContext do anything with the 
CompositorIntegration;
it just adds the field in the descriptor. The next patch will make the two 
actually use each other.

* Source/WebCore/Modules/WebGPU/GPU.cpp:
(WebCore::GPU::createCompositorIntegration):
* Source/WebCore/Modules/WebGPU/GPU.h:
* Source/WebCore/Modules/WebGPU/GPUPresentationContextDescriptor.h:
(WebCore::GPUPresentationContextDescriptor::convertToBacking const):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp:
(PAL::WebGPU::GPUImpl::createPresentationContext):
(PAL::WebGPU::GPUImpl::createCompositorIntegration):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.h:
* Source/WebCore/PAL/pal/graphics/WebGPU/WebGPU.h:
* Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPresentationContextDescriptor.h:
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.cpp:
(WebCore::presentationContextDescriptor):
(WebCore::GPUCanvasContextCocoa::GPUCanvasContextCocoa):
(WebCore::GPUCanvasContextCocoa::prepareForDisplay):
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::createCompositorIntegration):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.messages.in:
* Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp:
(WebKit::WebGPU::ConvertToBackingContext::convertToBacking):
(WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking):
* Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.h:
* 
Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.serialization.in:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp:
(WebKit::RemoteGPUProxy::createCompositorIntegration):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h:

Canonical link: https://commits.webkit.org/259669@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4ce5ef: [WGSL] Ignore extraneous semicolons in statements ...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ce5ef2d7e095913f6835b4bd1c6928957b9d1df
  
https://github.com/WebKit/WebKit/commit/4ce5ef2d7e095913f6835b4bd1c6928957b9d1df
  Author: Tadeu Zagallo 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WebGPU/WGSL/Parser.cpp

  Log Message:
  ---
  [WGSL] Ignore extraneous semicolons in statements and declarations
https://bugs.webkit.org/show_bug.cgi?id=251442
rdar://104873247

Reviewed by Myles C. Maxfield.

Update parser to match the spec: semicolons are valid statements and 
declarations.
Add the code to `parseGlobalDecl` to skip semicolons and update `parseStatement`
so we don't allocate an empty node if we find extraneous semicolons.

* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::parseGlobalDecl):
(WGSL::Parser::parseStatement):

Canonical link: https://commits.webkit.org/259668@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b634f: [GCC] Unreviewed, build fix for Ubuntu 20.04 after...

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b634f108da6e782a4fec68deb35974ccf855524
  
https://github.com/WebKit/WebKit/commit/8b634f108da6e782a4fec68deb35974ccf855524
  Author: Diego Pino Garcia 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WTF/wtf/CheckedPtr.h

  Log Message:
  ---
  [GCC] Unreviewed, build fix for Ubuntu 20.04 after 259659@main

GCC9.3 requires explicit definition of operator!=.

* Source/WTF/wtf/CheckedPtr.h:
(WTF::CheckedPtr::operator!= const):

Canonical link: https://commits.webkit.org/259667@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8ded59: Match SVGFEDropShadowElement and SVGFEGaussianBlur...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8ded595d93ee13a06fba590b472274d547483c56
  
https://github.com/WebKit/WebKit/commit/8ded595d93ee13a06fba590b472274d547483c56
  Author: Said Abou-Hallawa 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/idlharness.any-expected.txt
M 
LayoutTests/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.txt
M 
LayoutTests/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html
M 
LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.txt
M 
LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html
M Source/WebCore/svg/SVGFEDropShadowElement.idl
M Source/WebCore/svg/SVGFEGaussianBlurElement.idl

  Log Message:
  ---
  Match SVGFEDropShadowElement and SVGFEGaussianBlurElement.setStdDeviation() 
with the specs
https://bugs.webkit.org/show_bug.cgi?id=251182
rdar://104671451

Reviewed by Ryosuke Niwa.

The specs state that the inputs of this method are two non optional finite float
arguments.

https://drafts.fxtf.org/filter-effects/#InterfaceSVGFEGaussianBlurElement
https://drafts.fxtf.org/filter-effects/#InterfaceSVGFEDropShadowElement

* 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/idlharness.any-expected.txt:
* 
LayoutTests/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.txt:
* 
LayoutTests/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html:
* 
LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.txt:
* 
LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html:
* Source/WebCore/svg/SVGFEDropShadowElement.idl:
* Source/WebCore/svg/SVGFEGaussianBlurElement.idl:

Canonical link: https://commits.webkit.org/259666@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87a890: Cherry-pick 252432.940@safari-7614-branch (e34a3c3...

[David-Li-Jy]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 87a8908368977e945744a964b929bd136d7664a1
  
https://github.com/WebKit/WebKit/commit/87a8908368977e945744a964b929bd136d7664a1
  Author: Chirag M Shah 
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
M Source/WebCore/Modules/websockets/WebSocketDeflater.cpp

  Log Message:
  ---
  Cherry-pick 252432.940@safari-7614-branch (e34a3c3b5918). 
rdar://problem/80071711

Fix int overflow leading to OOB write
rdar://problem/80071711

Reviewed by Chris Dumez and Ryan Haddad.

* Source/WebCore/Modules/websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::destroy):
(WebCore::RenderTreeBuilder::attach):
(WebCore::RenderTreeBuilder::attachToRenderElementInternal):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createTextRenderer):

Canonical link: https://commits.webkit.org/252432.940@safari-7614-branch


  Commit: d12a9865c45835577955174cc86da4bf000f4aa5
  
https://github.com/WebKit/WebKit/commit/d12a9865c45835577955174cc86da4bf000f4aa5
  Author: Charlie Wolfe 
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
A 
LayoutTests/http/tests/navigation/cross-origin-navigation-fires-onload-expected.txt
A 
LayoutTests/http/tests/navigation/cross-origin-navigation-fires-onload.html
A LayoutTests/http/tests/navigation/resources/postmessage-on-hashchange.html
M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  ---
  Cherry-pick 252432.942@safari-7614-branch (d7af255eed5c). 
https://bugs.webkit.org/show_bug.cgi?id=241753

cross origin iframe load event can be used for a malicious way
https://bugs.webkit.org/show_bug.cgi?id=241753
rdar://95467115

Reviewed by Chris Dumez and Ryan Haddad.

This bug describes an issue where it is possible to guess a URL that is
redirected to by a cross-origin iframe. To fix this, WebKit should fire a
load event when the direct parent frame is cross-origin.

This fix is very similar to what is described in https://crbug.com/1248444.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):
* 
LayoutTests/http/tests/navigation/cross-origin-navigation-fires-onload-expected.txt:
 Added.
* 
LayoutTests/http/tests/navigation/cross-origin-navigation-fires-onload.html: 
Added.
* 
LayoutTests/http/tests/navigation/resources/postmessage-on-hashchange.html: 
Added.

Canonical link: https://commits.webkit.org/252432.942@safari-7614-branch


  Commit: a462ab39cd5284c9dda5a03b0c1b79112be2c715
  
https://github.com/WebKit/WebKit/commit/a462ab39cd5284c9dda5a03b0c1b79112be2c715
  Author: Rob Buis 
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
A LayoutTests/fast/block/crash-empty-layoutStateStack-expected.txt
A LayoutTests/fast/block/crash-empty-layoutStateStack.html
M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  ---
  Cherry-pick 256843.3@webkit-2022.12-embargoed (1d7abcd180ab). 
https://bugs.webkit.org/show_bug.cgi?id=248771

Protect against empty layout state
https://bugs.webkit.org/show_bug.cgi?id=248771

Reviewed by Alan Baradlay.

Protect against empty layout state.

* LayoutTests/fast/block/crash-empty-layoutStateStack-expected.txt: Added.
* LayoutTests/fast/block/crash-empty-layoutStateStack.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObject):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):

Canonical link: https://commits.webkit.org/256843.3@webkit-2022.12-embargoed


  Commit: 4cc83dae19c5dbcf96f740bac271505a041abea2
  
https://github.com/WebKit/WebKit/commit/4cc83dae19c5dbcf96f740bac271505a041abea2
  Author: Philippe Normand 
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 259419@main (537d68a65fe7). 
https://bugs.webkit.org/show_bug.cgi?id=251142

[GStreamer][1.22] Critical warning in internal text combiner element
https://bugs.webkit.org/show_bug.cgi?id=251142

Reviewed by Xabier Rodriguez-Calvar.

The `concat` pad request was done with a pad template not belonging to the 
element, so instead use
the simple request-pad API and let the element figure out the pad template 
itself.

* Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webkitTextCombinerRequestNewPad):

Canonical link: https://commits.webkit.org/259419@main


  Commit: fe00271b8218ea548c30f4618f51ff16cce3e638
  

[webkit-changes] [WebKit/WebKit] 4c52b0: Use Markable instead of std::optional when storing...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c52b0658f9cb5c07e054f4ae1ffe7788da7be3e
  
https://github.com/WebKit/WebKit/commit/4c52b0658f9cb5c07e054f4ae1ffe7788da7be3e
  Author: Alex Christensen 
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
M Source/WTF/wtf/UUID.h
M Source/WebCore/Modules/push-api/PushSubscriptionIdentifier.h
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp
M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
M Source/WebKit/Platform/IPC/DaemonCoders.h
M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h
M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in
M Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h
M Source/WebKit/webpushd/PushClientConnection.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  ---
  Use Markable instead of std::optional when storing UUIDs in structs
https://bugs.webkit.org/show_bug.cgi?id=251485
rdar://104902597

Reviewed by Yusuke Suzuki.

This removes unnecessary and unused padding bytes, decreasing memory use.

* Source/WTF/wtf/UUID.h:
(WTF::UUID::MarkableTraits::isEmptyValue):
(WTF::UUID::MarkableTraits::emptyValue):
* Source/WebCore/Modules/push-api/PushSubscriptionIdentifier.h:
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::decode):
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:
* Source/WebKit/Platform/IPC/DaemonCoders.h:
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h:
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in:
* Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h:
(WebKit::WebExtensionControllerConfiguration::identifier const):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::identifier const):
* Source/WebKit/webpushd/PushClientConnection.h:
(WebPushD::ClientConnection::dataStoreIdentifier const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

Canonical link: https://commits.webkit.org/259665@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes