[webkit-changes] [WebKit/WebKit] 1fdbfd: REGRESSION (259904@main): [ iOS ] Two editing/sele...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fdbfd80de70e622ef15360b8cc069e72432c99e https://github.com/WebKit/WebKit/commit/1fdbfd80de70e622ef15360b8cc069e72432c99e Author: Ryosuke Niwa Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/editing/selection/ios/change-selection-by-tapping-with-existing-selection.html M LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-with-mousedown-handler.html M LayoutTests/platform/ios/TestExpectations Log Message: --- REGRESSION (259904@main): [ iOS ] Two editing/selection/iOS/ tests are a consistent timeout https://bugs.webkit.org/show_bug.cgi?id=252313 Reviewed by Wenson Hsieh. The bug was caused by these tests using invalid offsets. Use valid offsets instead. * LayoutTests/editing/selection/ios/change-selection-by-tapping-with-existing-selection.html: * LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-with-mousedown-handler.html: * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/260354@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bad2b1: Integrate PGM for large heap allocations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bad2b1b9cb893c36c7d869820a8fae97ab36356e https://github.com/WebKit/WebKit/commit/bad2b1b9cb893c36c7d869820a8fae97ab36356e Author: Brandon Stewart Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/bmalloc/bmalloc.xcodeproj/project.pbxproj M Source/bmalloc/libpas/src/libpas/bmalloc_heap_config.h M Source/bmalloc/libpas/src/libpas/iso_heap_config.h M Source/bmalloc/libpas/src/libpas/pas_heap.c M Source/bmalloc/libpas/src/libpas/pas_heap_config_utils.h M Source/bmalloc/libpas/src/libpas/pas_large_heap.c M Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c M Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h M Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h M Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h M Source/bmalloc/libpas/src/test/PGMTests.cpp Log Message: --- Integrate PGM for large heap allocations https://bugs.webkit.org/show_bug.cgi?id=249371 Reviewed by Yusuke Suzuki. This patch turns on PGM allocations for large heaps. PGM will be enabled 1 in 1000 times upon process launch, and a PGM allocation will be performed every 4,000 to 5,000 times. This patch also adds re-allocation support to PGM. PGM allocations can be re-allocated to a non pgm allocation and vice versa. Based on benchmarks there was no noticable memory or performance overhead observed when enabling this feature. * Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj: * Source/bmalloc/libpas/src/libpas/bmalloc_heap_config.h: * Source/bmalloc/libpas/src/libpas/iso_heap_config.h: * Source/bmalloc/libpas/src/libpas/pas_heap.c: (pas_heap_create): * Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c: (pas_probabilistic_guard_malloc_allocate): (pas_probabilistic_guard_malloc_return_as_large_map_entry): (pas_probabilistic_guard_malloc_should_call_pgm): (pas_probabilistic_guard_malloc_initialize_pgm): * Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h: * Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h: (pas_try_allocate_common_impl_slow): * Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h: (pas_try_reallocate): * Source/bmalloc/libpas/src/test/PGMTests.cpp: (std::testPGMRealloc): (addPGMTests): Canonical link: https://commits.webkit.org/260353@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e48050: css/css-transitions/non-rendered-element-004.tenta...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e48050be43a572745d972e1aff015538f469b9d4 https://github.com/WebKit/WebKit/commit/e48050be43a572745d972e1aff015538f469b9d4 Author: Antoine Quint Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/non-rendered-element-004.tentative-expected.txt M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp Log Message: --- css/css-transitions/non-rendered-element-004.tentative.html is a unique failure https://bugs.webkit.org/show_bug.cgi?id=235137 rdar://87785165 Reviewed by Antti Koivisto. While we correctly call Styleable::cancelDeclarativeAnimations() during renderer teardown in RenderTreeUpdater::tearDownRenderers(), only the provided element and its descendants would be considered, but we did no work for anonymous renderers such as ::marker renderers. We now also call Styleable::cancelDeclarativeAnimations() if we're dealing with an element with a RenderListMarker renderer. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/non-rendered-element-004.tentative-expected.txt: * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::tearDownRenderers): Canonical link: https://commits.webkit.org/260352@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9605dc: Check for fileSystemPath being non-null when addin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9605dc730f989f14ed646967fd70ab807d54ab36 https://github.com/WebKit/WebKit/commit/9605dc730f989f14ed646967fd70ab807d54ab36 Author: Chirag M Shah Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: A LayoutTests/fast/history/add-file-with-invalid-utf8-crash-expected.txt A LayoutTests/fast/history/add-file-with-invalid-utf8-crash.html M Source/WebKit/UIProcess/WebProcessProxy.cpp Log Message: --- Check for fileSystemPath being non-null when adding to set https://bugs.webkit.org/show_bug.cgi?id=252341 rdar://99575855 Reviewed by Chris Dumez. This change fixes the crash in the UI process when the fileSystemPath is not a valid UTF-8. * LayoutTests/fast/history/add-file-with-invalid-utf8-crash-expected.txt: Added. * LayoutTests/fast/history/add-file-with-invalid-utf8-crash.html: Added. * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::addPreviouslyApprovedFileURL): (WebKit::WebProcessProxy::wasPreviouslyApprovedFileURL const): Canonical link: https://commits.webkit.org/260351@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d1c78b: Remove WinCairo WK1 Tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1c78b14827757d6e4da73219f3d46dae4e0c050 https://github.com/WebKit/WebKit/commit/d1c78b14827757d6e4da73219f3d46dae4e0c050 Author: Brandon Stewart Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: R LayoutTests/platform/wincairo-wk1/TestExpectations R LayoutTests/platform/wincairo-wk1/http/tests/security/401-logout/401-logout-expected.txt R LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt R LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt Log Message: --- Remove WinCairo WK1 Tests https://bugs.webkit.org/show_bug.cgi?id=252371 Reviewed by Fujii Hironori. Remove WinCairo WK1 tests as it is not supported anymore. * LayoutTests/platform/wincairo-wk1/TestExpectations: Removed. * LayoutTests/platform/wincairo-wk1/http/tests/security/401-logout/401-logout-expected.txt: Removed. * LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt: Removed. * LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt: Removed. Canonical link: https://commits.webkit.org/260350@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ee416: Update parserSetAttributes() to take in a Span ins...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ee416a7a42e06bc63dc488a43757ebc9f283bb7 https://github.com/WebKit/WebKit/commit/7ee416a7a42e06bc63dc488a43757ebc9f283bb7 Author: Chris Dumez Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/dom/DocumentSharedObjectPool.cpp M Source/WebCore/dom/DocumentSharedObjectPool.h M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/ElementData.cpp M Source/WebCore/dom/ElementData.h M Source/WebCore/html/parser/HTMLConstructionSite.cpp M Source/WebCore/html/shadow/TextControlInnerElements.cpp M Source/WebCore/xml/XMLErrors.cpp M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Log Message: --- Update parserSetAttributes() to take in a Span instead of a Vector https://bugs.webkit.org/show_bug.cgi?id=252361 Reviewed by Ryosuke Niwa. Update parserSetAttributes() to take in a Span instead of a Vector. Its implementation doesn't require a Vector, a Span suffices. Using a Span has a couple of benefits: 1. It allows some call sites to not create a Vector at all to set a single attribute. 2. It allows call sites to use Vectors that can have various inline capacities. * Source/WebCore/dom/DocumentSharedObjectPool.cpp: (WebCore::hasSameAttributes): (WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes): * Source/WebCore/dom/DocumentSharedObjectPool.h: * Source/WebCore/dom/Element.cpp: (WebCore::Element::parserSetAttributes): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/ElementData.cpp: (WebCore::ShareableElementData::createWithAttributes): (WebCore::ShareableElementData::ShareableElementData): * Source/WebCore/dom/ElementData.h: * Source/WebCore/html/parser/HTMLConstructionSite.cpp: (WebCore::setAttributes): * Source/WebCore/html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::updateInnerTextElementEditabilityImpl): * Source/WebCore/xml/XMLErrors.cpp: (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLErrors::insertErrorMessageBlock): * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::setAttributes): Canonical link: https://commits.webkit.org/260349@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4eee78: Drop unnecessary HTMLFastPathParser::m_source data...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4eee780a02c6d68cae8ad4364d56b51b9ba6aa2d https://github.com/WebKit/WebKit/commit/4eee780a02c6d68cae8ad4364d56b51b9ba6aa2d Author: Chris Dumez Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp Log Message: --- Drop unnecessary HTMLFastPathParser::m_source data member https://bugs.webkit.org/show_bug.cgi?id=252362 Reviewed by Ryosuke Niwa. * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: (WebCore::HTMLFastPathParser::HTMLFastPathParser): Canonical link: https://commits.webkit.org/260348@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a05f1b: Shrink in-memory display list buffers when shrinkT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a05f1b5d1351ea0824c32e1ec195b0c42132078a https://github.com/WebKit/WebKit/commit/a05f1b5d1351ea0824c32e1ec195b0c42132078a Author: Cameron McCormack Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp Log Message: --- Shrink in-memory display list buffers when shrinkToFit() is called https://bugs.webkit.org/show_bug.cgi?id=252295 Reviewed by Simon Fraser. It's only the current writable buffer that's likely to have a lot of wasted space. * Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp: (WebCore::DisplayList::ItemBuffer::shrinkToFit): Canonical link: https://commits.webkit.org/260347@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e4108: [Xcode] Change header postprocessing logic to bett...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e4108c84c0445fce64c1cccabd28635b62e90d6 https://github.com/WebKit/WebKit/commit/6e4108c84c0445fce64c1cccabd28635b62e90d6 Author: Elliott Williams Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebKit/Configurations/WebKit.xcconfig Log Message: --- [Xcode] Change header postprocessing logic to better reflect when it's needed internally https://bugs.webkit.org/show_bug.cgi?id=251818 rdar://105031778 Reviewed by Alexey Proskuryakov. WebKit currently assumes that API_AVAILABLE annotations will only use a major OS version. We have to remember to bump this number annually, and it prevents us from using minor versions in WebKit's API/SPI headers to more accurately reflect availability. Rather than make WebKit's internal configuration logic aware of all software update versions (which is prohibitively difficult due to xcconfig's limitations), introduce a new policy for when to enable API_AVAILABLE annotations: - Annotations are OFF in debug/release builds. - Annotations are ON in production builds, unless the build has staged frameworks (i.e. it is a downlevel or STP build). Internally, the production build environment may modify this policy by overriding the WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED setting. * Source/WebKit/Configurations/WebKit.xcconfig: Canonical link: https://commits.webkit.org/260346@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc0001: [browserperfdash-benchmark] Add optional --timesta...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc0001d225dfccadb1bdd2587c39f64c078058fe https://github.com/WebKit/WebKit/commit/dc0001d225dfccadb1bdd2587c39f64c078058fe Author: Carlos Alberto Lopez Perez Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py Log Message: --- [browserperfdash-benchmark] Add optional --timestamp parameter to send the data to the server with a custom date. https://bugs.webkit.org/show_bug.cgi?id=252355 Reviewed by Dewei Zhu. Add an optional paramter '--timestamp' that allows to send the data to the server marked with a specific date. So then the dashboard will add the benchmark data as it was generated on the date specified. This is useful for the following two use cases: 1) Several machines downloading builds and doing performance tests in parallel are not guaranteed to end the testing in the order they downloaded the builds. So by passing a timestamp that can be obtained from the git revision of the build (or even from the build executable timestamp) the data gets sorted properly on the dashboard. 2) Some data for older versions is missed, this way it is possible to tell the bot to run the benchmarks with an older version and then have the data ordered properly on the dashboard. * Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: (parse_args): (BrowserPerfDashRunner.__init__): Canonical link: https://commits.webkit.org/260345@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b591dc: [WGSL] Implement override declaration parsing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b591dc88c1634c6b585578a54d0734565cb1b601 https://github.com/WebKit/WebKit/commit/b591dc88c1634c6b585578a54d0734565cb1b601 Author: Dan Glastonbury Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebGPU/WGSL/AST/ASTOverrideValue.h M Source/WebGPU/WGSL/AST/ASTVisitor.cpp M Source/WebGPU/WGSL/Lexer.cpp M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WGSL/ParserPrivate.h M Source/WebGPU/WGSL/Token.cpp M Source/WebGPU/WGSL/Token.h M Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp Log Message: --- [WGSL] Implement override declaration parsing https://bugs.webkit.org/show_bug.cgi?id=252289 rdar://105480302 Reviewed by Tadeu Zagallo. Implement parsing of override declarations according to WGSL spec. * Source/WebGPU/WGSL/AST/ASTOverrideValue.h: (WGSL::AST::OverrideValue::OverrideValue): (WGSL::AST::OverrideValue::maybeInitializer): (WGSL::AST::OverrideValue::initializer): Deleted. * Source/WebGPU/WGSL/AST/ASTVisitor.cpp: (WGSL::AST::Visitor::visit): * Source/WebGPU/WGSL/Lexer.cpp: (WGSL::Lexer::lex): * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseGlobalDecl): (WGSL::Parser::parseOverrideValueWithAttributes): * Source/WebGPU/WGSL/ParserPrivate.h: * Source/WebGPU/WGSL/Token.cpp: (WGSL::toString): * Source/WebGPU/WGSL/Token.h: * Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp: (TestWGSLAPI::TEST): * Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp: (TestWGSLAPI::TEST): Canonical link: https://commits.webkit.org/260344@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b5fa2d: Check for visual data before accessing to avoid cr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b5fa2df93bda1950b37be8145179d28f8a94cab3 https://github.com/WebKit/WebKit/commit/b5fa2df93bda1950b37be8145179d28f8a94cab3 Author: Megan Gardner Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- Check for visual data before accessing to avoid crash. https://bugs.webkit.org/show_bug.cgi?id=252363 rdar://105522607 Reviewed by Tim Horton. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _selectionClipRect]): Canonical link: https://commits.webkit.org/260343@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dfe14f: [WGSL] Implement parsing of constant declarations ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dfe14f41830df0fe73ba99c50f916305305b84e7 https://github.com/WebKit/WebKit/commit/dfe14f41830df0fe73ba99c50f916305305b84e7 Author: Dan Glastonbury Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebGPU/WGSL/AST/ASTValue.h M Source/WebGPU/WGSL/Lexer.cpp M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WGSL/ParserPrivate.h M Source/WebGPU/WGSL/Token.cpp M Source/WebGPU/WGSL/Token.h M Source/WebGPU/WGSL/WGSLShaderModule.h M Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp Log Message: --- [WGSL] Implement parsing of constant declarations and statements https://bugs.webkit.org/show_bug.cgi?id=252288 rdar://105480283 Reviewed by Tadeu Zagallo. Implement parsing of constant declarations and statements according to WGSL spec. * Source/WebGPU/WGSL/AST/ASTValue.h: * Source/WebGPU/WGSL/Lexer.cpp: (WGSL::Lexer::lex): * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseGlobalDecl): (WGSL::Parser::parseStatement): (WGSL::Parser::parseConstantValue): * Source/WebGPU/WGSL/ParserPrivate.h: * Source/WebGPU/WGSL/Token.cpp: (WGSL::toString): * Source/WebGPU/WGSL/Token.h: * Source/WebGPU/WGSL/WGSLShaderModule.h: (WGSL::ShaderModule::values): * Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp: (TestWGSLAPI::TEST): * Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp: (TestWGSLAPI::TEST): Canonical link: https://commits.webkit.org/260342@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d5f4e: Turn off AirPlay for unsupported cases.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d5f4ec1123380b50a799a61be248247f91cc750 https://github.com/WebKit/WebKit/commit/5d5f4ec1123380b50a799a61be248247f91cc750 Author: Megan Gardner Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp M Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h M Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl M Source/WebCore/dom/EventNames.in M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.idl Log Message: --- Turn off AirPlay for unsupported cases. https://bugs.webkit.org/show_bug.cgi?id=252275 rdar://103322594 Reviewed by Tim Horton. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp: * Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h: * Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl: * Source/WebCore/dom/EventNames.in: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): * Source/WebCore/html/HTMLMediaElement.idl: Canonical link: https://commits.webkit.org/260341@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d49a9: REGRESSION (258754@main): [ Monterey ] fast/forms/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d49a9974356e3f81de2171c03f7a992bf8c0db9 https://github.com/WebKit/WebKit/commit/8d49a9974356e3f81de2171c03f7a992bf8c0db9 Author: Tim Nguyen Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: A LayoutTests/platform/mac-monterey/fast/forms/input-button-sizes-expected.txt Log Message: --- REGRESSION (258754@main): [ Monterey ] fast/forms/input-button-sizes.html is a constant failure. https://bugs.webkit.org/show_bug.cgi?id=252327 rdar://105504579 Unreviewed, test gardening. * LayoutTests/platform/mac-monterey/fast/forms/input-button-sizes-expected.txt: Added. Canonical link: https://commits.webkit.org/260340@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 99f4e3: Remove Preprocessor Checks for Clang Prior to Vers...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99f4e3022fb8676139a5d58950f131dad0e2cbc0 https://github.com/WebKit/WebKit/commit/99f4e3022fb8676139a5d58950f131dad0e2cbc0 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WTF/wtf/Int128.cpp Log Message: --- Remove Preprocessor Checks for Clang Prior to Version 9 https://bugs.webkit.org/show_bug.cgi?id=252351 Reviewed by Michael Catanzaro. Given how clang has had its respective bugs resolved and fixed, we do not need these workarounds anymore. *Source\WTF\wtf\Int128.cpp: Remove clang + SSE3 workaround Canonical link: https://commits.webkit.org/260339@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 559f00: [WGSL] Implement parsing of let statements
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 559f009359931aec78bad6adb3663dbf7a76a484 https://github.com/WebKit/WebKit/commit/559f009359931aec78bad6adb3663dbf7a76a484 Author: Dan Glastonbury Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebGPU/WGSL/AST/AST.h M Source/WebGPU/WGSL/AST/ASTForward.h M Source/WebGPU/WGSL/AST/ASTNode.h M Source/WebGPU/WGSL/AST/ASTStatement.h M Source/WebGPU/WGSL/AST/ASTValue.h A Source/WebGPU/WGSL/AST/ASTValueStatement.h M Source/WebGPU/WGSL/Lexer.cpp M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WGSL/ParserPrivate.h M Source/WebGPU/WGSL/Token.cpp M Source/WebGPU/WGSL/Token.h M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp Log Message: --- [WGSL] Implement parsing of let statements https://bugs.webkit.org/show_bug.cgi?id=252287 rdar://105480246 Reviewed by Tadeu Zagallo. Implement parsing of let statements local to functions according to WGSL spec. * Source/WebGPU/WGSL/AST/AST.h: * Source/WebGPU/WGSL/AST/ASTForward.h: * Source/WebGPU/WGSL/AST/ASTNode.h: * Source/WebGPU/WGSL/AST/ASTStatement.h: (isType): * Source/WebGPU/WGSL/AST/ASTValue.h: * Source/WebGPU/WGSL/AST/ASTValueStatement.h: Copied from Source/WebGPU/WGSL/AST/ASTValue.h. * Source/WebGPU/WGSL/Lexer.cpp: (WGSL::Lexer::lex): * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseStatement): (WGSL::Parser::parseLetValue): * Source/WebGPU/WGSL/ParserPrivate.h: * Source/WebGPU/WGSL/Token.cpp: (WGSL::toString): * Source/WebGPU/WGSL/Token.h: * Source/WebGPU/WebGPU.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp: (TestWGSLAPI::TEST): * Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp: (TestWGSLAPI::TEST): Canonical link: https://commits.webkit.org/260338@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9fdab7: [WinCairo] run-api-tests: Failed to list TestWebKi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9fdab7d948f31524ca1362e9b1465282dbc2ffe1 https://github.com/WebKit/WebKit/commit/9fdab7d948f31524ca1362e9b1465282dbc2ffe1 Author: Fujii Hironori Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Tools/Scripts/webkitpy/port/win.py Log Message: --- [WinCairo] run-api-tests: Failed to list TestWebKitLegacy tests https://bugs.webkit.org/show_bug.cgi?id=252334 Reviewed by Ross Kirsling. * Tools/Scripts/webkitpy/port/win.py: (WinPort): Removed TestWebKitLegacy.exe, added TestWebKit.exe. Canonical link: https://commits.webkit.org/260337@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ee0c4: [WGSL] Use a SortedArrayMap to match keywords and ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ee0c4ea8853a3017f9a45c06ea1adda18be6b05 https://github.com/WebKit/WebKit/commit/9ee0c4ea8853a3017f9a45c06ea1adda18be6b05 Author: Dan Glastonbury Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebGPU/WGSL/Lexer.cpp Log Message: --- [WGSL] Use a SortedArrayMap to match keywords and reserved words https://bugs.webkit.org/show_bug.cgi?id=252278 rdar://problem/105476092 Reviewed by Tadeu Zagallo. In lieu of a tool to generate a trie for detecting keywords and reserved words, replace the long sequence of if/return with a SortedArrayMap of keyword to TokenType. * Source/WebGPU/WGSL/Lexer.cpp: (WGSL::Lexer::lex): Canonical link: https://commits.webkit.org/260336@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d25915: Web Inspector: Add support for getting user agents...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d25915a5a0c5cc5c2a0b1e2b38f4010a309b0419 https://github.com/WebKit/WebKit/commit/d25915a5a0c5cc5c2a0b1e2b38f4010a309b0419 Author: Patrick Angle Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebInspectorUI/UserInterface/Base/Main.js M Source/WebInspectorUI/UserInterface/Base/WebInspector.js Log Message: --- Web Inspector: Add support for getting user agents from WebKitAdditions if present https://bugs.webkit.org/show_bug.cgi?id=252030 rdar://96018617 Reviewed by Devin Rousso and Tim Horton. Ports may desire to provide their own set of User Agents for Web Inspector to display for remote inspection via WebKitAdditions. * Source/WebInspectorUI/UserInterface/Base/Main.js: (WI.loaded): - Place an empty WebKitAdditions in the global scope if one doesn't already exist, since optional chaining can't be used to check for a non-declared root object. - Also some drive-by indentation fixes for the UAs. Canonical link: https://commits.webkit.org/260335@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bcb8f: WebProcess::m_userGestureTokens should be WeakHash...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bcb8ff8fb7d4a1d9f0d5db7e17e284a4728f47e https://github.com/WebKit/WebKit/commit/3bcb8ff8fb7d4a1d9f0d5db7e17e284a4728f47e Author: Ryosuke Niwa Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h Log Message: --- WebProcess::m_userGestureTokens should be WeakHashMap instead of HashMap of raw pointers https://bugs.webkit.org/show_bug.cgi?id=252346 Reviewed by Chris Dumez. * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::userGestureTokenIdentifier): (WebKit::WebProcess::userGestureTokenDestroyed): * Source/WebKit/WebProcess/WebProcess.h: Canonical link: https://commits.webkit.org/260334@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 544d14: WebGeolocationManager should use WeakHashMap of We...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 544d14e5357117f044702793e3169ec97c6ef0a6 https://github.com/WebKit/WebKit/commit/544d14e5357117f044702793e3169ec97c6ef0a6 Author: Ryosuke Niwa Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp M Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.h Log Message: --- WebGeolocationManager should use WeakHashMap of WebPage instead of raw pointers https://bugs.webkit.org/show_bug.cgi?id=252343 Reviewed by Chris Dumez. Deployed WeakHashMap in place of HashMap of raw pointers. * Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp: (WebKit::WebGeolocationManager::registerWebPage): (WebKit::WebGeolocationManager::unregisterWebPage): (WebKit::WebGeolocationManager::setEnableHighAccuracyForPage): * Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.h: Canonical link: https://commits.webkit.org/260333@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6173b: Web Inspector: Add initial support for color-mix C...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6173b46292f4fda92346060b35d6a78bf7eb650 https://github.com/WebKit/WebKit/commit/f6173b46292f4fda92346060b35d6a78bf7eb650 Author: Patrick Angle Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebInspectorUI/UserInterface/Models/Color.js M Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js Log Message: --- Web Inspector: Add initial support for color-mix CSS values https://bugs.webkit.org/show_bug.cgi?id=252031 rdar://105254118 Reviewed by Tim Nguyen. Correct the display of `color-mix` to not truncate itself when not being edited, and to correctly show nested color swatches within itself. This is achieved by sending tokens within a function's parentheses back through _addColorTokens so that they in turn can be parsed for functions and color keywords. We also now enforce that a function keyword is followed by a parenthesis to form a function, since some keywords like `rgb` and `hsl` are now also used to denote the color space in which mixing should occur. * Source/WebInspectorUI/UserInterface/Models/Color.js: * Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype._addColorTokens): Canonical link: https://commits.webkit.org/260332@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c3b03a: [iOS] Don't assume the type of objects returned by...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3b03a9bd5f5b389206d97112f60d903c6e01d63 https://github.com/WebKit/WebKit/commit/c3b03a9bd5f5b389206d97112f60d903c6e01d63 Author: Eric Carlson Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm Log Message: --- [iOS] Don't assume the type of objects returned by `[NSBundle objectForInfoDictionaryKey:` https://bugs.webkit.org/show_bug.cgi?id=252342 rdar://105248790 Reviewed by Jer Noble. The "UIBackgroundModes" in an application's info.plist is _supposed_ to be a dictionary, but it can be any valid plist type so don't assume `[NSBundle objectForInfoDictionaryKey:@"UIBackgroundModes"` will return an NSDictionary. * Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm: (WebCore::RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange): Canonical link: https://commits.webkit.org/260331@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e6c8fa: [WGSL] Handle parsing of unconstrained vector and ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e6c8fa17cce481d5b813bfabfef1d723542983b5 https://github.com/WebKit/WebKit/commit/e6c8fa17cce481d5b813bfabfef1d723542983b5 Author: Dan Glastonbury Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebGPU/WGSL/Parser.cpp M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp Log Message: --- [WGSL] Handle parsing of unconstrained vector and matrix types. https://bugs.webkit.org/show_bug.cgi?id=252286 rdar://problem/105480155 Reviewed by Tadeu Zagallo. `vec4(1.0, 1.0, 1.0, 1.0)` is a valid type constructor where element type needs to be deduced from the type of the arguments. This change conditionally accepts the element type if the identifier is one of the known prefixes for ParameterizedTypeName, otherwise NamedTypeName is returned. * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseTypeNameAfterIdentifier): * Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp: (TestWGSLAPI::TEST): Canonical link: https://commits.webkit.org/260330@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b97572: [popover] Implement beforetoggle event
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b975729cd495d6e06a8ce8ca0edbe8c44db97fd2 https://github.com/WebKit/WebKit/commit/b975729cd495d6e06a8ce8ca0edbe8c44db97fd2 Author: Tim Nguyen Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-animation-corner-cases.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-beforetoggle-opening-event.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/toggleevent-interface.tentative-expected.txt M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/WebCoreBuiltinNames.h M Source/WebCore/dom/Event.h M Source/WebCore/dom/EventNames.h M Source/WebCore/dom/EventNames.in A Source/WebCore/dom/ToggleEvent.cpp A Source/WebCore/dom/ToggleEvent.h A Source/WebCore/dom/ToggleEvent.idl M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h Log Message: --- [popover] Implement beforetoggle event https://bugs.webkit.org/show_bug.cgi?id=252214 rdar://105471198 Reviewed by Ryosuke Niwa. - Add ToggleEvent interface used by beforetoggle & toggle events. - Fire beforetoggle events when appropriate * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-animation-corner-cases.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-beforetoggle-opening-event.tentative-expected.txt: This test still fails because it needs special [popup=auto] behavior to be implemented. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/toggleevent-interface.tentative-expected.txt: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/dom/Event.h: (WebCore::Event::isToggleEvent const): * Source/WebCore/dom/EventNames.h: * Source/WebCore/dom/EventNames.in: * Source/WebCore/dom/ToggleEvent.cpp: Added. (WebCore::ToggleEvent::ToggleEvent): (WebCore::ToggleEvent::create): (WebCore::ToggleEvent::createForBindings): (WebCore::ToggleEvent::eventInterface const): * Source/WebCore/dom/ToggleEvent.h: Added. * Source/WebCore/dom/ToggleEvent.idl: Added. * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::showPopover): (WebCore::HTMLElement::hidePopoverInternal): (WebCore::HTMLElement::hidePopover): (WebCore::HTMLElement::popoverAttributeChanged): * Source/WebCore/html/HTMLElement.h: Canonical link: https://commits.webkit.org/260329@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6128bf: Add API to allow transparent backgrounds when crea...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6128bfc2feebff15fdde6e8823e0531da36005a8 https://github.com/WebKit/WebKit/commit/6128bfc2feebff15fdde6e8823e0531da36005a8 Author: Richard Robinson Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKPDFConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/WKPDFConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm Log Message: --- Add API to allow transparent backgrounds when creating a PDF https://bugs.webkit.org/show_bug.cgi?id=250340 rdar://76982433 Reviewed by Simon Fraser. Adds an API to allow PDFs to have a transparent background when being created, instead of always forcing a white background. * Source/WebCore/rendering/BackgroundPainter.cpp: (WebCore::BackgroundPainter::paintFillLayers): * Source/WebCore/rendering/PaintPhase.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents): (WebCore::RenderLayer::calculateClipRects const): * Source/WebKit/UIProcess/API/Cocoa/WKPDFConfiguration.h: * Source/WebKit/UIProcess/API/Cocoa/WKPDFConfiguration.mm: (-[WKPDFConfiguration init]): (-[WKPDFConfiguration copyWithZone:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView createPDFWithConfiguration:completionHandler:]): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::drawToPDF): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawToPDF): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/260328@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f0092: Optimize Reflect.get() leveraging the recently int...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f0092e17fdbdd3127963eeb9eb45e8db4506726 https://github.com/WebKit/WebKit/commit/0f0092e17fdbdd3127963eeb9eb45e8db4506726 Author: Alexey Shvayka Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: A JSTests/microbenchmarks/reflect-get-with-receiver.js A JSTests/microbenchmarks/reflect-get.js M Source/JavaScriptCore/builtins/BuiltinNames.h M Source/JavaScriptCore/builtins/ReflectObject.js M Source/JavaScriptCore/runtime/ReflectObject.cpp Log Message: --- Optimize Reflect.get() leveraging the recently introduced GetByValWithThis IC https://bugs.webkit.org/show_bug.cgi?id=252328 Reviewed by Yusuke Suzuki. This change re-implements Reflect.get() as JSBuiltin to leverage GetByValWithThis IC, speeding up microbenchmarks 8.5X times and JetStream3/proxy-vue by 1.5-2%. ToT patch reflect-get-with-receiver 331.8347+-1.6323 ^ 38.7435+-0.2977 ^ definitely 8.5649x faster reflect-get 91.5221+-0.3572 ^ 10.7350+-0.0942 ^ definitely 8.5256x faster * JSTests/microbenchmarks/reflect-get-with-receiver.js: Added. * JSTests/microbenchmarks/reflect-get.js: Added. * Source/JavaScriptCore/builtins/BuiltinNames.h: * Source/JavaScriptCore/builtins/ReflectObject.js: * Source/JavaScriptCore/runtime/ReflectObject.cpp: Canonical link: https://commits.webkit.org/260327@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 208b4c: [JSC] Disable canonicalizePrePostIncrements since ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 208b4cf4242b8e3ff79b921aea8d9a191e80ef5e https://github.com/WebKit/WebKit/commit/208b4cf4242b8e3ff79b921aea8d9a191e80ef5e Author: Yusuke Suzuki Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/JavaScriptCore/runtime/OptionsList.h Log Message: --- [JSC] Disable canonicalizePrePostIncrements since the bug is not fully fixed yet https://bugs.webkit.org/show_bug.cgi?id=252304 rdar://105487806 Reviewed by Alexey Shvayka. See discussion here[1]. This phase still has a bug. So we disable it. [1]: https://bugs.webkit.org/show_bug.cgi?id=228538#c14 * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/260326@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e87820: Performance Dashboard should be able to gracefully...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e87820646ce924819148b2900a4458d63950672f https://github.com/WebKit/WebKit/commit/e87820646ce924819148b2900a4458d63950672f Author: Dewei Zhu Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Websites/perf.webkit.org/public/include/manifest-generator.php M Websites/perf.webkit.org/public/v3/components/pane-selector.js M Websites/perf.webkit.org/public/v3/models/platform.js M Websites/perf.webkit.org/public/v3/pages/charts-page.js M Websites/perf.webkit.org/server-tests/api-manifest-tests.js Log Message: --- Performance Dashboard should be able to gracefully handle hidden platforms. https://bugs.webkit.org/show_bug.cgi?id=252290 rdar://100648187 Reviewed by Ryosuke Niwa. Fix a bug that analysis task page on performance dashboard does not load properly when any platform in this task is hidden. * Websites/perf.webkit.org/public/include/manifest-generator.php: Include 'platform_hidden' field in platform manifest and stop filtering out hidden platforms in manifest. * Websites/perf.webkit.org/public/v3/components/pane-selector.js: (PaneSelector.prototype._renderPlatformList): Add code to ensure hidden platform does not show in pane. * Websites/perf.webkit.org/public/v3/models/platform.js: Added 'hidden' field and a 'isHidden' function to indicate if a platform is hidden. (Platform): (Platform.prototype.isHidden): * Websites/perf.webkit.org/public/v3/pages/charts-page.js: Filter out hidden platforms from 'ChartsPage.alternatePlatforms'. (ChartsPage): (ChartsPage.prototype.alternatePlatforms): * Websites/perf.webkit.org/server-tests/api-manifest-tests.js: Added unit test for 'Platform.isHidden'. Canonical link: https://commits.webkit.org/260325@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b88545: Preserve-3d isn't applied to pseudo elements.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b88545397c4f76fd23906b8e81980423c62c5a13 https://github.com/WebKit/WebKit/commit/b88545397c4f76fd23906b8e81980423c62c5a13 Author: Matt Woodrow Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-pseudo-element-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-pseudo-element-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-pseudo-element.html M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp Log Message: --- Preserve-3d isn't applied to pseudo elements. https://bugs.webkit.org/show_bug.cgi?id=252277 Reviewed by Simon Fraser. We need to check the parent element in the composed tree to determine if we should be applying preserve-3d. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-pseudo-element-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-pseudo-element-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve3d-pseudo-element.html: Added. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::parentLayerIsDOMParent): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::ancestorLayerIsDOMParent): Canonical link: https://commits.webkit.org/260324@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42bf9a: [GTK] [l10n] Updated Ukrainian translation of WebK...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42bf9a6d6316f47f3e2778db1c136238555e0792 https://github.com/WebKit/WebKit/commit/42bf9a6d6316f47f3e2778db1c136238555e0792 Author: Michael Catanzaro Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/platform/gtk/po/uk.po Log Message: --- [GTK] [l10n] Updated Ukrainian translation of WebKitGTK+ https://bugs.webkit.org/show_bug.cgi?id=252318 Unreviewed translation update * Source/WebCore/platform/gtk/po/uk.po: Canonical link: https://commits.webkit.org/260323@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3217a5: [ macOS WK1 ] media/media-source/media-source-vide...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3217a5cfa19ddd59258b3ec1e85594928cfb44c3 https://github.com/WebKit/WebKit/commit/3217a5cfa19ddd59258b3ec1e85594928cfb44c3 Author: Bri Harris Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/media/media-source/media-source-video-renders.html M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [ macOS WK1 ] media/media-source/media-source-video-renders.html is constant failure. https://bugs.webkit.org/show_bug.cgi?id=252322 rdar://105502071 Unreviewed test gardening. Rebaseline for failing test. * LayoutTests/media/media-source/media-source-video-renders.html: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/260322@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4084ba: Various tests in imported/w3c/web-platform-tests/e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4084bac88a4ab31511cfd1b10398e4b58f0a20e9 https://github.com/WebKit/WebKit/commit/4084bac88a4ab31511cfd1b10398e4b58f0a20e9 Author: Ryosuke Niwa Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=block=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=inline=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=inline-block=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=list-item=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=table-cell=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre=block=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre=inline=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre=inline-block=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre=list-item=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre=table-cell=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line=block=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line=inline=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line=inline-block=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line=list-item=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line=table-cell=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap=block=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap=inline=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap=inline-block=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap=list-item=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap=table-cell=shift-enter-expected.txt M LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js Log Message: --- Various tests in imported/w3c/web-platform-tests/editing/other fail due to shift key generating content https://bugs.webkit.org/show_bug.cgi?id=252296 Reviewed by Wenson Hsieh. Don't generate keydown events for modifiers to avoid generating superfluous content. * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=block=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=inline=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=inline-block=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=list-item=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal=table-cell=shift-enter-expected.txt: *
[webkit-changes] [WebKit/WebKit] c659be: Cherry-pick fa68fec45f7c. rdar://problem/105483437
Branch: refs/heads/safari-7616.1.2-branch Home: https://github.com/WebKit/WebKit Commit: c659be5af58af177ca6c20b1e3efcb2844cac10c https://github.com/WebKit/WebKit/commit/c659be5af58af177ca6c20b1e3efcb2844cac10c Author: Tim Horton Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- Cherry-pick fa68fec45f7c. rdar://problem/105483437 Disable unsupported CA features https://bugs.webkit.org/show_bug.cgi?id=252332 rdar://105506055 Reviewed by Wenson Hsieh. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/260320@main Canonical link: https://commits.webkit.org/260164.1@safari-7616.1.2-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7616.1.1.1 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a82cc0: Cherry-pick fa68fec45f7c. rdar://problem/105483437
Branch: refs/heads/safari-7616.1.1-branch Home: https://github.com/WebKit/WebKit Commit: a82cc0400332c60aa1a6120d532dc3b731499829 https://github.com/WebKit/WebKit/commit/a82cc0400332c60aa1a6120d532dc3b731499829 Author: Tim Horton Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- Cherry-pick fa68fec45f7c. rdar://problem/105483437 Disable unsupported CA features https://bugs.webkit.org/show_bug.cgi?id=252332 rdar://105506055 Reviewed by Wenson Hsieh. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/260320@main Canonical link: https://commits.webkit.org/259872.8@safari-7616.1.1-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eb1ce6: Versioning.
Branch: refs/heads/safari-7616.1.1-branch Home: https://github.com/WebKit/WebKit Commit: eb1ce6e07a6550da9d83f7376e36de9e3ceb0de4 https://github.com/WebKit/WebKit/commit/eb1ce6e07a6550da9d83f7376e36de9e3ceb0de4 Author: Russell Epstein Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7616.1.1.1 Canonical link: https://commits.webkit.org/259872.7@safari-7616.1.1-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa68fe: Disable unsupported CA features
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa68fec45f7ce4091b510ddef3e2a4e6fd35ad8c https://github.com/WebKit/WebKit/commit/fa68fec45f7ce4091b510ddef3e2a4e6fd35ad8c Author: Tim Horton Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- Disable unsupported CA features https://bugs.webkit.org/show_bug.cgi?id=252332 rdar://105506055 Reviewed by Wenson Hsieh. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/260320@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 155bed: HTMLFrameOwnerElement: use Document::creationURL()...
Branch: refs/heads/webkit-2023.2-embargoed Home: https://github.com/WebKit/WebKit Commit: 155bed7390009a843b69d83e18f31097c198f7d7 https://github.com/WebKit/WebKit/commit/155bed7390009a843b69d83e18f31097c198f7d7 Author: Claudio Saavedra Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html M Source/WebCore/html/HTMLFrameOwnerElement.cpp Log Message: --- HTMLFrameOwnerElement: use Document::creationURL() for self-reference check https://bugs.webkit.org/show_bug.cgi?id=248469 Reviewed by Darin Adler. Document::url() can be changed through the History API, therefore it's not a reliable source to verify whether a given URL is self-referencing. Use creationURL instead, which is immutable. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt: Added. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html: Added. * Source/WebCore/html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::isProhibitedSelfReference const): Canonical link: https://commits.webkit.org/256843.2@webkit-2022.12-embargoed Commit: 1d7abcd180abe9c3164366f5b6c0fb86e69790b5 https://github.com/WebKit/WebKit/commit/1d7abcd180abe9c3164366f5b6c0fb86e69790b5 Author: Rob Buis Date: 2022-12-08 (Thu, 08 Dec 2022) Changed paths: A LayoutTests/fast/block/crash-empty-layoutStateStack-expected.txt A LayoutTests/fast/block/crash-empty-layoutStateStack.html M Source/WebCore/rendering/RenderBlock.cpp Log Message: --- Protect against empty layout state https://bugs.webkit.org/show_bug.cgi?id=248771 Reviewed by Alan Baradlay. Protect against empty layout state. * LayoutTests/fast/block/crash-empty-layoutStateStack-expected.txt: Added. * LayoutTests/fast/block/crash-empty-layoutStateStack.html: Added. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObject): (WebCore::RenderBlock::markForPaginationRelayoutIfNeeded): Canonical link: https://commits.webkit.org/256843.3@webkit-2022.12-embargoed Commit: 6234ec9c65b9f2d07fc59985ffba242fdd0da686 https://github.com/WebKit/WebKit/commit/6234ec9c65b9f2d07fc59985ffba242fdd0da686 Author: Rob Buis Date: 2022-12-16 (Fri, 16 Dec 2022) Changed paths: A LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt A LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html M Source/WebCore/rendering/RenderLayerModelObject.cpp Log Message: --- Do not issue repaints when in detached state https://bugs.webkit.org/show_bug.cgi?id=248773 Reviewed by Antti Koivisto. Do not issue repaints when the RenderObject is in detached state while removing render subtrees. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt: Added. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html: Added. * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderTableCell::willBeRemovedFromTree const): Canonical link: https://commits.webkit.org/256843.4@webkit-2022.12-embargoed Commit: 312254f5776dd16bde18cd4d99444d81a0c331d6 https://github.com/WebKit/WebKit/commit/312254f5776dd16bde18cd4d99444d81a0c331d6 Author: Rob Buis Date: 2022-12-16 (Fri, 16 Dec 2022) Changed paths: A LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt A LayoutTests/fast/css/content/quote-display-contents-crash.html M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/Element.cpp Log Message: --- Check displayContentsChanged in destroyRenderTreeIfNeeded https://bugs.webkit.org/show_bug.cgi?id=248776 rdar://102807985> Reviewed by Antti Koivisto. Check displayContentsChanged in destroyRenderTreeIfNeeded since display: contents may be removed due to focus removal while removing subtrees but we still need to clean up pseudo elements. * LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt: Added. * LayoutTests/fast/css/content/quote-display-contents-crash.html: Added. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::destroyRenderTreeIfNeeded): * Source/WebCore/dom/Element.cpp: (WebCore::Element::resolveComputedStyle): Canonical link: https://commits.webkit.org/256843.5@webkit-2022.12-embargoed Commit: c4c0ef6360b2aa3fd32b1b9f6a5b6b5ccaa61a98 https://github.com/WebKit/WebKit/commit/c4c0ef6360b2aa3fd32b1b9f6a5b6b5ccaa61a98 Author: Rob Buis Date: 2023-01-12 (Thu, 12 Jan 2023) Changed paths: A LayoutTests/fast/dom/set-outer-text-on-moved-element-expected.html A LayoutTests/fast/dom/set-outer-text-on-moved-element.html M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp Log Message: --- Verify that style update roots are for correct
[webkit-changes] [WebKit/WebKit] 147e3e: Reduce custom property storage for sites with larg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 147e3eca970c1bf4808e592c92d1a94ef2723b2f https://github.com/WebKit/WebKit/commit/147e3eca970c1bf4808e592c92d1a94ef2723b2f Author: Cameron McCormack Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/CSSComputedStyleDeclaration.cpp M Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h A Source/WebCore/rendering/style/StyleCustomPropertyData.cpp M Source/WebCore/rendering/style/StyleCustomPropertyData.h M Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp M Source/WebCore/rendering/style/StyleMiscNonInheritedData.h Log Message: --- Reduce custom property storage for sites with large numbers of custom properties on the root https://bugs.webkit.org/show_bug.cgi?id=252142 Reviewed by Antti Koivisto and Darin Adler. Some sites have a large number of custom properties set on the root element, inheriting into the entire document. When different custom properties or values are set on descendant elements, we clone all of the inherited properties. This patch changes the storage in StyleCustomPropertyData so that the first time we copy() one that has some custom properties in it, we point the cloned object to the original StyleCustomPropertyData as the source of inherited custom properties, and leave m_values (now renamed to m_ownValues) empty. Any subsequent copy() of a StyleCustomPropertyData that already has a pointer to the inherited custom properties will copy that pointer, and clone m_ownValues like before. We don't generate an unlimited linked list of inherited custom properties to look up, to avoid custom property lookup time having worst case linear time in the depth of the tree. This saves around 800 KB on the youtube.com in Membuster. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::item const): * Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp: (WebCore::ComputedStylePropertyMapReadOnly::entries const): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setCustomPropertyValue): * Source/WebCore/rendering/style/RenderStyle.h: (WebCore::RenderStyle::inheritedCustomProperties const): (WebCore::RenderStyle::nonInheritedCustomProperties const): * Source/WebCore/rendering/style/StyleCustomPropertyData.cpp: Added. (WebCore::StyleCustomPropertyData::StyleCustomPropertyData): (WebCore::StyleCustomPropertyData::get const): (WebCore::StyleCustomPropertyData::set): (WebCore::StyleCustomPropertyData::operator== const): (WebCore::StyleCustomPropertyData::forEach const): (WebCore::StyleCustomPropertyData::findKeyAtIndex const): (WebCore::StyleCustomPropertyData::size const): * Source/WebCore/rendering/style/StyleCustomPropertyData.h: (WebCore::StyleCustomPropertyData::copy const): (WebCore::StyleCustomPropertyData::operator!= const): (WebCore::StyleCustomPropertyData::operator== const): Deleted. (WebCore::StyleCustomPropertyData::setCustomPropertyValue): Deleted. (WebCore::StyleCustomPropertyData::StyleCustomPropertyData): Deleted. Canonical link: https://commits.webkit.org/260319@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f67976: Implement margin-trim for floats in block containe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f679766e27a17ddcbdd8a562f6f1581fab68d053 https://github.com/WebKit/WebKit/commit/f679766e27a17ddcbdd8a562f6f1581fab68d053 Author: Sammy Gill Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-end-deeply-nested-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-end-deeply-nested.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-end-up-to-content-block-layout-different-containers-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-end-up-to-content-block-layout-different-containers-vert-lr-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-end-up-to-content-block-layout-different-containers-vert-lr.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-end-up-to-content-block-layout-different-containers.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-end-up-to-content-block-layout-same-container-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-end-up-to-content-block-layout-same-container.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-start-block-layout-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-start-block-layout.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-start-relative-positioned-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-start-relative-positioned.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-start-with-transforms-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-block-start-with-transforms.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-fit-content-block-layout-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-fit-content-block-layout.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-end-block-layout-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-end-block-layout.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-start-block-layout-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-start-block-layout.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-left-trimmed-margin-allows-float-to-fit-block-layout-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-left-trimmed-margin-allows-float-to-fit-block-layout-vert-lr-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-left-trimmed-margin-allows-float-to-fit-block-layout-vert-lr.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-left-trimmed-margin-allows-float-to-fit-block-layout.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-min-content-with-block-content-block-layout-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-min-content-with-block-content-block-layout.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-right-trimmed-margin-allows-float-to-fit-block-layout-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-right-trimmed-margin-allows-float-to-fit-block-layout.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-overflowing-float-margins-tirmmed-at-final-position-block-layout-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-overflowing-float-margins-tirmmed-at-final-position-block-layout.html M Source/WebCore/rendering/FloatingObjects.cpp M Source/WebCore/rendering/FloatingObjects.h M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBlock.h M
[webkit-changes] [WebKit/WebKit] 439120: [ macOS WK1 ] media/media-source/media-source-vide...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43912039883bd876474deadd9281d8234959a534 https://github.com/WebKit/WebKit/commit/43912039883bd876474deadd9281d8234959a534 Author: Bri Harris Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [ macOS WK1 ] media/media-source/media-source-video-renders.html is constant failure. https://bugs.webkit.org/show_bug.cgi?id=252322 rdar://105502071 Unreviewed test gardening. Setting expectations for failing test. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/260317@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c58c08: Save recent searches with name attribute
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c58c088437779ba48d081ebc83242e3b71f34ca7 https://github.com/WebKit/WebKit/commit/c58c088437779ba48d081ebc83242e3b71f34ca7 Author: Sihui Liu Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/forms/search/search-recent-searches-expected.txt A LayoutTests/fast/forms/search/search-recent-searches.html M LayoutTests/imported/blink/fast/forms/search-popup-crasher.html M LayoutTests/platform/mac/TestExpectations M Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm M Source/WebCore/rendering/RenderSearchField.cpp M Source/WebCore/rendering/RenderSearchField.h M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl Log Message: --- Save recent searches with name attribute https://bugs.webkit.org/show_bug.cgi?id=252139 rdar://105369635 Reviewed by Darin Adler. autosave attribute is non-standard and is not tracked in any active proposal, so we should stop using it to decide whether a search item can be saved. This patch changes the logic to use name attribute to match Chrome and Firefox's behavior. New test: fast/forms/search/search-recent-searches.html * LayoutTests/TestExpectations: * LayoutTests/fast/forms/search/search-recent-searches-expected.txt: Added. * LayoutTests/fast/forms/search/search-recent-searches.html: Added. * LayoutTests/imported/blink/fast/forms/search-popup-crasher.html: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm: (WebCore::saveRecentSearches): * Source/WebCore/rendering/RenderSearchField.cpp: (WebCore::RenderSearchField::recentSearches): (WebCore::RenderSearchField::autosaveName const): * Source/WebCore/rendering/RenderSearchField.h: * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::recentSearches): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: Canonical link: https://commits.webkit.org/260316@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ccfd01: Update .github/CODEOWNERS for Site Quirks and Sand...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ccfd01b632764a159c85d87820010fe7a0f9fc12 https://github.com/WebKit/WebKit/commit/ccfd01b632764a159c85d87820010fe7a0f9fc12 Author: Brent Fulgham Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M .github/CODEOWNERS Log Message: --- Update .github/CODEOWNERS for Site Quirks and Sandboxes https://bugs.webkit.org/show_bug.cgi?id=252271 Reviewed by Per Arne Vollan. We lost some of the automated notifications we used to have before we switched to GitHub. This patch adds owners to a few files where we'd like to be notified of changes. * .github/CODEOWNERS: Canonical link: https://commits.webkit.org/260315@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d8787: [GStreamer] Don't emit playbackStateChanged() even...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5d8787383e48b02ff7d7c92a3ea0ca17f7755f4c
https://github.com/WebKit/WebKit/commit/5d8787383e48b02ff7d7c92a3ea0ca17f7755f4c
Author: Enrique Ocaña González
Date: 2023-02-15 (Wed, 15 Feb 2023)
Changed paths:
A LayoutTests/media/video-pause-while-seeking-expected.txt
A LayoutTests/media/video-pause-while-seeking.html
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Log Message:
---
[GStreamer] Don't emit playbackStateChanged() event after a seek
https://bugs.webkit.org/show_bug.cgi?id=252063
It is not possible to pause the playback during a seek. Sink elements
lose their states entering ASYNC PAUSED->PAUSED transition. Calling HTML
video.pause() during a seek doesn't result in pipeline state change call
as player reports it's paused already. Forcing gst_element_set_state()
doesn't really help in this case as pipeline enters inconsistent state
after a seek that everything is playing but sinks are paused.
In addition, triggering playbackStateChanged() at seek end causes
HTMLMediaElement::playInternal() that cleans up all signs of previous
pause() call.
Don't emit playbackStateChanged() at seek end so HTML won't force
playInternal() and HTMLMediaElement will call pauseInternal() again
after a seek (from updatePlayState()).
This fixes following scenario:
video.currentTime = x.xx
video.play();
// ensure async duringn a seek (video didn't pause after initial
// seek had finished)
setTimeout(()=>{ video.pause(); }, 1}
Original author: Andrzej Surdej (https://github.com/asurdej-comcast)
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1013
Reviewed by Philippe Normand.
* LayoutTests/media/video-pause-while-seeking-expected.txt: Added.
* LayoutTests/media/video-pause-while-seeking.html: Added.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Don't update playback
state during a seek.
Canonical link: https://commits.webkit.org/260314@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d8792c: [Gardening]: REGRESSION (260130@main): [ iOS ] Thr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d8792cd23857c37821258b7a643af8bf9c0c0d02 https://github.com/WebKit/WebKit/commit/d8792cd23857c37821258b7a643af8bf9c0c0d02 Author: Karl Rackler Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [Gardening]: REGRESSION (260130@main): [ iOS ] Three imported/w3c/web-platform-tests/css/css-counter-styles/devanagari/ are a consistent failure https://bugs.webkit.org/show_bug.cgi?id=252317 rdar://105498065 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/260313@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8115ef: REGRESSION(260301@main): Broke debug build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8115ef7fc60f2c228b09f8789c26935cc475d655 https://github.com/WebKit/WebKit/commit/8115ef7fc60f2c228b09f8789c26935cc475d655 Author: Philippe Normand Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp Log Message: --- REGRESSION(260301@main): Broke debug build https://bugs.webkit.org/show_bug.cgi?id=252316 Unreviewed, add RunLoop.h include, needed for Debug builds. * Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: Canonical link: https://commits.webkit.org/260312@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c04fda: [Gardening]: REGRESSION (259904@main): [ iOS ] Two...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c04fdaf9cd74e266de6dfe6ca6dc0e65637504e4 https://github.com/WebKit/WebKit/commit/c04fdaf9cd74e266de6dfe6ca6dc0e65637504e4 Author: Karl Rackler Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [Gardening]: REGRESSION (259904@main): [ iOS ] Two editing/selection/iOS/ tests are a consistent timeout https://bugs.webkit.org/show_bug.cgi?id=252313 rdar://105496266 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/260311@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3cde6: [IFC][Partial layout] Populate layout tree increme...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3cde6a7c25f7f0aeef62945c3d97678b3bd3ed8 https://github.com/WebKit/WebKit/commit/f3cde6a7c25f7f0aeef62945c3d97678b3bd3ed8 Author: Alan Baradlay Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h M Source/WebCore/rendering/RenderObject.cpp Log Message: --- [IFC][Partial layout] Populate layout tree incrementally https://bugs.webkit.org/show_bug.cgi?id=252255 Reviewed by Antti Koivisto. Partial layout implies partial tree building (not a strict requirement though). This patch enables us to start supporting the simple case of "new text content has been appended since the last layout". It's disabled for now. * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp: (WebCore::LayoutIntegration::BoxTree::insert): * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h: * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterContentChange): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.h: * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::shouldInvalidateLineLayoutPathAfterContentChange): (WebCore::LayoutIntegration::LineLayout::insertedIntoTree): * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h: * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::insertedIntoTree): Canonical link: https://commits.webkit.org/260310@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b178b: [IFC] LineBoxes do not need to outlive line layout.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b178ba3eda0c15772a8185e709ebd479af757c9 https://github.com/WebKit/WebKit/commit/9b178ba3eda0c15772a8185e709ebd479af757c9 Author: Alan Baradlay Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingState.h Log Message: --- [IFC] LineBoxes do not need to outlive line layout. https://bugs.webkit.org/show_bug.cgi?id=252280 Reviewed by Antti Koivisto. They are input to InlineDisplayLineBuilder/InlineDisplayContentBuilder, but we never reuse them in subsequent layouts. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::createDisplayContentForLine): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingState.h: (WebCore::Layout::InlineFormattingState::clearLineAndBoxes): (WebCore::Layout::InlineFormattingState::shrinkToFit): (WebCore::Layout::InlineFormattingState::lineBoxes const): Deleted. (WebCore::Layout::InlineFormattingState::addLineBox): Deleted. Canonical link: https://commits.webkit.org/260309@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 353a1b: Plumb the entire NetworkConnectionIntegrity option...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 353a1b7ca24dafae87a0111b8891a189880d8c78 https://github.com/WebKit/WebKit/commit/353a1b7ca24dafae87a0111b8891a189880d8c78 Author: Wenson Hsieh Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/platform/network/NetworkConnectionIntegrity.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h Log Message: --- Plumb the entire NetworkConnectionIntegrity option set into `enableNetworkConnectionIntegrity` https://bugs.webkit.org/show_bug.cgi?id=252294 rdar://105412782 Reviewed by Aditya Keerthi. Add a new NetworkConnectionIntegrity policy bit, and plumb it through the helper function `enableNetworkConnectionIntegrity`. * Source/WebCore/platform/network/NetworkConnectionIntegrity.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::enableNetworkConnectionIntegrity): (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::createWebSocketTask): * Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm: (-[WKWebpagePreferences _networkConnectionIntegrityEnabled]): (-[WKWebpagePreferences _setNetworkConnectionIntegrityEnabled:]): Set three flags when the embedding client "enables" network connection integrity. (-[WKWebpagePreferences _networkConnectionIntegrityPolicy]): (-[WKWebpagePreferences _setNetworkConnectionIntegrityPolicy:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h: Canonical link: https://commits.webkit.org/260308@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ca11a: Support for CSS text-transform: full-size-kana
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ca11a6d7868e1c06e58c38eaa8349d5d39e1345 https://github.com/WebKit/WebKit/commit/8ca11a6d7868e1c06e58c38eaa8349d5d39e1345 Author: Matthieu Dubet Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-valid-expected.txt M LayoutTests/inspector/css/getSupportedCSSProperties-expected.txt M Source/WebCore/css/CSSPrimitiveValueMappings.h M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleConstants.cpp M Source/WebCore/rendering/style/RenderStyleConstants.h Log Message: --- Support for CSS text-transform: full-size-kana https://bugs.webkit.org/show_bug.cgi?id=251934 rdar://105181094 Reviewed by Tim Nguyen and Darin Adler. The mapping from small kanas to full size kanas is specified at https://drafts.csswg.org/css-text-3/#small-kana * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-valid-expected.txt: * LayoutTests/inspector/css/getSupportedCSSProperties-expected.txt: * Source/WebCore/css/CSSPrimitiveValueMappings.h: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/rendering/RenderText.cpp: (WebCore::convertToFullSizeKana): (WebCore::applyTextTransform): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleConstants.cpp: (WebCore::operator<<): * Source/WebCore/rendering/style/RenderStyleConstants.h: Canonical link: https://commits.webkit.org/260307@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/wpewebkit-2.38.5 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7224fc: Unreviewed. Update OptionsWPE.cmake and NEWS for t...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 7224fc38b1a67738fa802bfb75e09b22a90d02bc https://github.com/WebKit/WebKit/commit/7224fc38b1a67738fa802bfb75e09b22a90d02bc Author: Adrian Perez de Castro Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebKit/wpe/NEWS M Source/cmake/OptionsWPE.cmake Log Message: --- Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.38.5 release * Source/WebKit/wpe/NEWS: Add release notes. * Source/cmake/OptionsWPE.cmake: Bump version numbers. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9febb: Implement text-autospace parser for auto and no-au...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9febb26c871be962432254ecb980a9a36ac7f13 https://github.com/WebKit/WebKit/commit/a9febb26c871be962432254ecb980a9a36ac7f13 Author: Vitor Roriz Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h M Source/WebCore/platform/text/TextSpacing.h M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/StyleRareInheritedData.cpp M Source/WebCore/rendering/style/StyleRareInheritedData.h M Source/WebCore/style/StyleBuilderConverter.h Log Message: --- Implement text-autospace parser for auto and no-autospace https://bugs.webkit.org/show_bug.cgi?id=252119 rdar://105340814 Reviewed by Myles C. Maxfield. text-spacing longhand: text-autospace parser for auto and no-autospace Reference: https://github.com/w3c/csswg-drafts/issues/4246#issuecomment-1404738513 Implement a parser for text-autospace (text-spacing longhand) for none and auto-space values. We can then iterate from here add remaining values. Syntax: text-autospace: auto | no-autospace * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::textAutospaceFromStyle):
[webkit-changes] [WebKit/WebKit] 14e770: Rebaseline text-spacing-trim tests for WK1 after 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14e770dccd2bc68571a5778500cd0fb89d79477a https://github.com/WebKit/WebKit/commit/14e770dccd2bc68571a5778500cd0fb89d79477a Author: Vitor Roriz Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt Log Message: --- Rebaseline text-spacing-trim tests for WK1 after 260288@main https://bugs.webkit.org/show_bug.cgi?id=252305 rdar://105488225 Rebaselining tests for WK1 after merging text-spacing-trim patch (260288@main). Reviewed by Antoine Quint. * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: Canonical link: https://commits.webkit.org/260305@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0d659: [css-fonts] font-feature-settings needs a test to ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0d659bc3e6678f0f8fb519152d14e28f5e0d44c https://github.com/WebKit/WebKit/commit/f0d659bc3e6678f0f8fb519152d14e28f5e0d44c Author: Antoine Quint Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-feature-settings-computed.html Log Message: --- [css-fonts] font-feature-settings needs a test to check features are sorted alphabetically https://bugs.webkit.org/show_bug.cgi?id=252300 Reviewed by Myles C. Maxfield. We recently made a code change as part of bug 252238 to sort values in the `font-feature-settings` computed style alphabetically and filed a spec issue (https://github.com/w3c/csswg-drafts/issues/8450) such that the css-fonts spec would mandate the same thing. This has now been done so we can now make the `font-feature-settings` computed style test more prescriptive in that regard. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-feature-settings-computed.html: Canonical link: https://commits.webkit.org/260304@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/webkitgtk-2.38.5 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95ee38: Unreviewed. Update OptionsGTK.cmake and NEWS for t...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 95ee384471af86e2f71c556d33e4df5faa9944e7 https://github.com/WebKit/WebKit/commit/95ee384471af86e2f71c556d33e4df5faa9944e7 Author: Carlos Garcia Campos Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebKit/gtk/NEWS M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. Update OptionsGTK.cmake and NEWS for the 2.38.5 release * Source/WebKit/gtk/NEWS: Add release notes for 2.38.5. * Source/cmake/OptionsGTK.cmake: Bump version numbers. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ae0d71: Cherry-pick 1b2eb138ef92. rdar://problem/105236768
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: ae0d71e5d25e617db34a34c7875e36e0b3838003 https://github.com/WebKit/WebKit/commit/ae0d71e5d25e617db34a34c7875e36e0b3838003 Author: Yusuke Suzuki Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h Log Message: --- Cherry-pick 1b2eb138ef92. rdar://problem/105236768 [JSC] ToThis object folding should check if AbstractValue is always an object https://bugs.webkit.org/show_bug.cgi?id=251944 rdar://105175786 Reviewed by Geoffrey Garen and Mark Lam. ToThis can become Identity for strict mode if it is just primitive values or its object does not have toThis function overriding. This is correct, but folding ToThis to Undefined etc. (not Identity) needs to check that an input only contains objects. This patch adds appropriate checks to prevent from converting ToThis(GlobalObject | Int32) to Undefined for example. * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::isToThisAnIdentity): Canonical link: https://commits.webkit.org/259548.63@safari-7615-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d99a52: [JSC] Optimize bound function calls
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d99a52c875990a31eac613edd3c1462905159ebc https://github.com/WebKit/WebKit/commit/d99a52c875990a31eac613edd3c1462905159ebc Author: Yusuke Suzuki Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: A JSTests/stress/bound-function-inlining.js M JSTests/stress/bound-function-stack-overflow.js A JSTests/stress/bound-function-strength-reduction-this.js A JSTests/stress/bound-function-strength-reduction.js A JSTests/stress/function-bind-call-frame.js A JSTests/stress/function-bind-caller.js A JSTests/stress/function-bind-do-not-miss-already-bound-args.js A JSTests/stress/function-bind-double-wrap-throw-more.js A JSTests/stress/function-bind-double-wrap-throw.js A JSTests/stress/function-bind-getter-call-osr-exit.js A JSTests/stress/function-bind-inlined-osr-exit.js A JSTests/stress/function-bind-setter-call-osr-exit.js A JSTests/stress/function-bind-tail-call-osr-exit.js A JSTests/stress/function-bind-throw.js M JSTests/stress/sampling-profiler-bound-function-name.js M JSTests/stress/stack-overflow-in-custom-hasInstance.js M Source/JavaScriptCore/builtins/FunctionPrototype.js M Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp M Source/JavaScriptCore/bytecode/InlineCallFrame.cpp M Source/JavaScriptCore/bytecode/InlineCallFrame.h M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGDoesGC.cpp M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/dfg/DFGGraph.cpp M Source/JavaScriptCore/dfg/DFGGraph.h M Source/JavaScriptCore/dfg/DFGNodeType.h M Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp M Source/JavaScriptCore/dfg/DFGSafeToExecute.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp M Source/JavaScriptCore/ftl/FTLCapabilities.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JITOperations.cpp M Source/JavaScriptCore/jit/ThunkGenerators.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter.asm M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp M Source/JavaScriptCore/runtime/CommonSlowPaths.h M Source/JavaScriptCore/runtime/JSBoundFunction.cpp M Source/JavaScriptCore/runtime/JSBoundFunction.h M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/VM.cpp M Source/JavaScriptCore/tools/JSDollarVM.cpp Log Message: --- [JSC] Optimize bound function calls https://bugs.webkit.org/show_bug.cgi?id=225135 rdar://77539823 Reviewed by Mark Lam. This patch allows inlining JSBoundFunction calls from DFG and FTL. 1. We should not report bound function in the stack trace. But we were doing that. This patch fixes it by making it ImplementationVisibility::Private. This also aligns JSC with V8 and this also makes this patch simpler because we do not need to care about the stack trace when inlining bound function calls. 2. We optimize double-bound functions. (func.bind(...).bind(...)) by folding captured arguments into one, so effectively unwrapping it. 3. DFG ByteCodeParser attempts to inline bound function calls from CallVariant data & intrinsic marking. Even though we failed to do that, we attempt to unwrapping the call in DFG strength reduction further. Bound function calls get much faster with this patch by inlining / unwrapping. ToT Patched bound-function-call5.2044+-0.0275 ^ 1.9831+-0.0342^ definitely 2.6244x faster function-bind-no-inlining-repeat-call 47.4999+-0.2317 ^ 43.0725+-0.1098^ definitely 1.1028x faster * JSTests/stress/bound-function-inlining.js: Added. (shouldBe): (test): (t): * JSTests/stress/bound-function-stack-overflow.js: *
[webkit-changes] [WebKit/WebKit] 290b7f: Cherry-pick 260252@main (ff7c48892878). https://bu...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 290b7f6860d99d72e9bf85041ad34bb2a445a0a4 https://github.com/WebKit/WebKit/commit/290b7f6860d99d72e9bf85041ad34bb2a445a0a4 Author: Carlos Garcia Campos Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/platform/network/soup/ResourceRequest.h M Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp M Source/WebKit/NetworkProcess/NetworkLoad.cpp M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp Log Message: --- Cherry-pick 260252@main (ff7c48892878). https://bugs.webkit.org/show_bug.cgi?id=249844 [GTK] Uploading any media uses too much memory https://bugs.webkit.org/show_bug.cgi?id=249844 Reviewed by Michael Catanzaro. Stop serializing the HTTP body as part of ResourceRequest since we don't really need to send the request body over IPC. * Source/WebCore/platform/network/ResourceRequestBase.h: * Source/WebCore/platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::encodingRequiresPlatformData const): * Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): (WebCore::ResourceRequest::fromResourceRequestData): (WebCore::ResourceRequest::getRequestDataToSerialize const): (WebCore::ResourceRequest::getResourceRequestPlatformData const): Deleted. * Source/WebKit/NetworkProcess/NetworkLoad.cpp: (WebKit::updateRequest): * Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::continueHTTPRedirection): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/260252@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a72b8: [PAL] Move NSColorSPI.h from /cocoa to /mac
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a72b8bca65ed2e1d3978014150a6f0f1f74319e https://github.com/WebKit/WebKit/commit/6a72b8bca65ed2e1d3978014150a6f0f1f74319e Author: Aditya Keerthi Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj M Source/WebCore/PAL/pal/PlatformMac.cmake R Source/WebCore/PAL/pal/spi/cocoa/NSColorSPI.h A Source/WebCore/PAL/pal/spi/mac/NSColorSPI.h M Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm M Source/WebCore/page/mac/TextIndicatorWindow.mm M Source/WebCore/rendering/RenderThemeMac.mm M Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm Log Message: --- [PAL] Move NSColorSPI.h from /cocoa to /mac https://bugs.webkit.org/show_bug.cgi?id=252298 Reviewed by Wenson Hsieh. NSColor is only available on macOS. * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/PlatformMac.cmake: * Source/WebCore/PAL/pal/spi/mac/NSColorSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/NSColorSPI.h. * Source/WebCore/page/cocoa/WebTextIndicatorLayer.mm: * Source/WebCore/page/mac/TextIndicatorWindow.mm: * Source/WebCore/rendering/RenderThemeMac.mm: * Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm: Canonical link: https://commits.webkit.org/260302@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ccc5c: [GLIB] Unify code for accessing default `cairo_fon...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ccc5caacd23526def9cf7111283b5233be038e1 https://github.com/WebKit/WebKit/commit/9ccc5caacd23526def9cf7111283b5233be038e1 Author: Vitaly Dyachkov Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WebCore/platform/Cairo.cmake M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp M Source/WebCore/platform/graphics/cairo/CairoUtilities.h M Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp M Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp M Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.h M Tools/TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp Log Message: --- [GLIB] Unify code for accessing default `cairo_font_options` https://bugs.webkit.org/show_bug.cgi?id=252057 Reviewed by Carlos Garcia Campos. Currently, there are two different implementations of `getDefaultCairoFontOptions()` on WPE and GTK. WPE version simply returns a static value created by `cairo_font_options_create()`, whereas GTK one is creating a singleton class that stores and updates an instance variable to keep it in sync with `GtkSettings`. This patch makes `getDefaultCairoFontOptions()` simply return a static value and adds `setDefaultCairoFontOptions()` function. GTK port use it to set a new value when `GtkSettingsManagerProxy` applies new settings. * Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: (WebCore::getDefaultCairoFontOptions): (WebCore::setDefaultCairoFontOptions): * Source/WebCore/platform/graphics/cairo/CairoUtilities.h: * Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp: (WebCore::SystemFontOptions::singleton): Deleted. (WebCore::SystemFontOptions::SystemFontOptions): Deleted. (WebCore::SystemFontOptions::fontOptions const): Deleted. (WebCore::SystemFontOptions::updateFontOptions): Deleted. (WebCore::getDefaultCairoFontOptions): Deleted. * Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp: (WebKit::GtkSettingsManagerProxy::applySettings): (WebKit::GtkSettingsManagerProxy::applyFontOptions): * Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.h: Canonical link: https://commits.webkit.org/260301@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
