[webkit-changes] [WebKit/WebKit] a4350b: MotionMark Images subtest rendering is incorrect o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4350b5e3b698b76790a7e2c9cc0f58f5ee66fcc https://github.com/WebKit/WebKit/commit/a4350b5e3b698b76790a7e2c9cc0f58f5ee66fcc Author: Kimmo Kinnunen Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: A LayoutTests/fast/canvas/small-canvas-layer-putImageData-expected.html A LayoutTests/fast/canvas/small-canvas-layer-putImageData.html M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h M Source/WebCore/WebCore.order M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h M Source/WebCore/platform/graphics/GraphicsContext.h M Source/WebCore/platform/graphics/NullGraphicsContext.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp M Source/WebCore/platform/graphics/cg/GraphicsContextCG.h R Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp M Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h M Source/WebCore/platform/graphics/mac/WebLayer.mm M Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp M Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp A Tools/TestWebKitAPI/Tests/WebCore/cg/GraphicsContextCGTests.mm R Tools/TestWebKitAPI/Tests/WebCore/cg/GraphicsContextTestsCG.cpp Log Message: --- MotionMark Images subtest rendering is incorrect on ASi (no dissolve effect) https://bugs.webkit.org/show_bug.cgi?id=252482 rdar://problem/105606592 Reviewed by Simon Fraser. Fix rendering of accelerated canvas elements into small layer tiles after putImageData. ImageBufferIOSurfaceBackend::putPixelBuffer would clean the CGImage cache, if there's possibility that the cache exists. ImageBufferIOSurfaceBackend::copyNativeImageForDrawing() does not currently mark the cache as being active. Instead, it relies on after-the-fact cleanup via ImageBufferIOSurfaceBackend::finalizeDrawIntoContext(). ImageBufferIOSurfaceBackend::finalizeDrawIntoContext() would only cleanup if the draw happened on an non-accelerated context. Accelerated context status would be determined by whether WebKit requested the layer to be accelerated. In case the layer is small, CoreAnimation might give a bitmap-backed CGContext for the drawing context, even though WebKit requested an accelerated context. WebKit would mark the context as accelerated, even when it was not. This would lead into scenario where the CGImage cache would not be cleaned after each draw, and hence putImageData would not be visible. Fix by removing the GraphicsContextCG::setIsAcceleratedContext(). Instead, query the actual state from the CGContext. Adds a test in ImageBufferTests that tests the code paths. This test would not have caught the issue, since the bug as incorrect use of setIsAcceleratedContext() rooted from PlatformCALayer::drawLayerContents. Nevertheless, the test would have given a bit more confidence that the complicated invalidation logic was correct in the specific case. Adds a trivial test for the acceleration status query based on the CGContext. * Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp: (WebCore::BifurcatedGraphicsContext::setIsAcceleratedContext): Deleted. * Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h: * Source/WebCore/platform/graphics/GraphicsContext.h: * Source/WebCore/platform/graphics/NullGraphicsContext.h: * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayer::drawLayerContents): * Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContextCG::renderingMode const): (WebCore::GraphicsContextCG::setIsAcceleratedContext): Deleted. * Source/WebCore/platform/graphics/cg/GraphicsContextCG.h: * Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: * Source/WebCore/platform/graphics/cocoa/IOSurface.mm: (WebCore::IOSurface::ensureGraphicsContext): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h: * Source/WebCore/platform/graphics/mac/WebLayer.mm: (-[WebSimpleLayer drawInContext:]): * Source/WebKitLegacy/mac/WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): * Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp: (TestWebKitAPI::imageBufferPixelIs): (TestWebKitAPI::hasTestPattern): (TestWebKitAPI::drawTestPattern): (TestWebKitAPI::createPixelBu
[webkit-changes] [WebKit/WebKit] 989e6b: Build failure in CARingBuffer.h when the build is ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 989e6bef9a95ef968b4bf97946edd01af8aacd72 https://github.com/WebKit/WebKit/commit/989e6bef9a95ef968b4bf97946edd01af8aacd72 Author: Antoine Quint Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/platform/audio/cocoa/CARingBuffer.h Log Message: --- Build failure in CARingBuffer.h when the build is not unified https://bugs.webkit.org/show_bug.cgi?id=253016 Reviewed by Alexey Proskuryakov. * Source/WebCore/platform/audio/cocoa/CARingBuffer.h: Canonical link: https://commits.webkit.org/260926@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d83831: Build failure in CoreTextCompositionEngine.h when ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d838315bb27b4b285f2c883b0b94432830b383f1 https://github.com/WebKit/WebKit/commit/d838315bb27b4b285f2c883b0b94432830b383f1 Author: Antoine Quint Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/platform/text/mac/CoreTextCompositionEngine.h Log Message: --- Build failure in CoreTextCompositionEngine.h when the build is not unified https://bugs.webkit.org/show_bug.cgi?id=253017 Reviewed by Alexey Proskuryakov. * Source/WebCore/platform/text/mac/CoreTextCompositionEngine.h: Canonical link: https://commits.webkit.org/260925@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 903910: OffscreenCanvas WebGL doesn't fire the context los...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 903910f95dd36fc7cbc660fb96daab4df0372a07 https://github.com/WebKit/WebKit/commit/903910f95dd36fc7cbc660fb96daab4df0372a07 Author: Matt Woodrow Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebCore/html/CanvasBase.h M Source/WebCore/html/CustomPaintCanvas.h M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/HTMLCanvasElement.h M Source/WebCore/html/OffscreenCanvas.cpp M Source/WebCore/html/OffscreenCanvas.h M Source/WebCore/html/OffscreenCanvas.idl M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLSync.cpp Log Message: --- OffscreenCanvas WebGL doesn't fire the context lost event. https://bugs.webkit.org/show_bug.cgi?id=250532 Reviewed by Ryosuke Niwa. Adds support for dispatching the event to OffscreenCanvas too, and enables the WebGL tests that cover this. * LayoutTests/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/html/CanvasBase.h: * Source/WebCore/html/CustomPaintCanvas.h: * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::queueTaskKeepingObjectAlive): (WebCore::HTMLCanvasElement::dispatchEvent): * Source/WebCore/html/HTMLCanvasElement.h: * Source/WebCore/html/OffscreenCanvas.cpp: (WebCore::OffscreenCanvas::create): (WebCore::OffscreenCanvas::OffscreenCanvas): (WebCore::OffscreenCanvas::transferToImageBitmap): (WebCore::OffscreenCanvas::queueTaskKeepingObjectAlive): (WebCore::OffscreenCanvas::dispatchEvent): * Source/WebCore/html/OffscreenCanvas.h: * Source/WebCore/html/OffscreenCanvas.idl: * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent): (WebCore::WebGLRenderingContextBase::maybeRestoreContext): * Source/WebCore/html/canvas/WebGLSync.cpp: (WebCore::WebGLSync::scheduleAllowCacheUpdate): Canonical link: https://commits.webkit.org/260924@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe58e5: Disable Apple Compression API in Compression Streams
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe58e5cd0281e47d9e9739df609cf404067d1c96 https://github.com/WebKit/WebKit/commit/fe58e5cd0281e47d9e9739df609cf404067d1c96 Author: Brandon Stewart Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp M Source/WebCore/Modules/compression/DecompressionStreamDecoder.h Log Message: --- Disable Apple Compression API in Compression Streams https://bugs.webkit.org/show_bug.cgi?id=253042 Reviewed by Brent Fulgham. Disable Compression API for Compression Streams right now as it is causing issues on web sites. * Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp: (WebCore::DecompressionStreamDecoder::decompress): * Source/WebCore/Modules/compression/DecompressionStreamDecoder.h: (WebCore::DecompressionStreamDecoder::DecompressionStreamDecoder): Canonical link: https://commits.webkit.org/260923@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14090b: Unreviewed, reverting r260916@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14090b540e86b96f9bc4075fa6f542d502762ec3 https://github.com/WebKit/WebKit/commit/14090b540e86b96f9bc4075fa6f542d502762ec3 Author: Commit Queue Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Unreviewed, reverting r260916@main. https://bugs.webkit.org/show_bug.cgi?id=253053 Caused sandbox compilation failures in local builds Reverted changeset: "[Lockdown Mode] Conditionalize sandbox access" https://bugs.webkit.org/show_bug.cgi?id=252621 https://commits.webkit.org/260916@main Canonical link: https://commits.webkit.org/260922@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7dd18b: [JSC][32bit] Fix JIT being disabled when compiling...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7dd18bda3626e7ca2f007d2ea8f7df7104bc95ab https://github.com/WebKit/WebKit/commit/7dd18bda3626e7ca2f007d2ea8f7df7104bc95ab Author: Mikhail R. Gadelha Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/JavaScriptCore/b3/air/AirArg.h M Source/JavaScriptCore/wasm/WasmOpcodeOrigin.h M Source/WTF/wtf/PlatformCPU.h M Source/bmalloc/bmalloc/BPlatform.h M Source/cmake/OptionsCommon.cmake Log Message: --- [JSC][32bit] Fix JIT being disabled when compiling JSC on linux with clang https://bugs.webkit.org/show_bug.cgi?id=234034 Reviewed by Justin Michaud. JIT was always disabled when building JSC with clang on linux 32 bits because CMake checked if the compiler defined __thumb2__ and while gcc does define it by default, clang doesn't. This patch adds extra compilation flags when compiling JSC with clang for arm (except on Darwin), so the expected __thumb2__ define is defined and JIT is enabled. Also some minor changes: (1) this patch also adds __ARM_ARCH_8__ and __ARM_ARCH_8A__ to the list that sets BTHUMB_ARCH_VERSION and WTF_THUMB_ARCH_VERSION to 4. These two seem to be used mostly for sanity check. (2) a small fix in AirArg where clang complains about a missing typename. gcc seems to accept either. * Source/JavaScriptCore/b3/air/AirArg.h: (JSC::B3::Air::Arg::isValidAddrForm): * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::parseAndCompileAirImpl): * Source/WTF/wtf/PlatformCPU.h: * Source/bmalloc/bmalloc/BPlatform.h: * Source/cmake/OptionsCommon.cmake: Canonical link: https://commits.webkit.org/260921@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 98b2a2: ManagedMediaSource content should be evicted whene...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 98b2a211bb5343e6bac6144a68fcc572bd33e940 https://github.com/WebKit/WebKit/commit/98b2a211bb5343e6bac6144a68fcc572bd33e940 Author: Jean-Yves Avenard Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/media/media-source/media-managedmse-memorypressure-expected.txt M LayoutTests/media/media-source/media-managedmse-memorypressure.html M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/page/MemoryRelease.cpp Log Message: --- ManagedMediaSource content should be evicted whenever it is under memory pressure https://bugs.webkit.org/show_bug.cgi?id=252938 rdar://105908445 Reviewed by Youenn Fablet. Let the MediaElement control when eviction under memory pressure should occur. * LayoutTests/media/media-source/media-managedmse-memorypressure-expected.txt: * LayoutTests/media/media-source/media-managedmse-memorypressure.html: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::purgeBufferedDataIfPossible): * Source/WebCore/page/MemoryRelease.cpp: (WebCore::releaseCriticalMemory): Canonical link: https://commits.webkit.org/260920@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b00ce1: Block CARenderServer in experimental sandbox
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b00ce10d352eada165c6ceb8e81c20c0239efd5b https://github.com/WebKit/WebKit/commit/b00ce10d352eada165c6ceb8e81c20c0239efd5b Author: Per Arne Vollan Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Block CARenderServer in experimental sandbox https://bugs.webkit.org/show_bug.cgi?id=252998 rdar://problem/106010274 Reviewed by Brent Fulgham. Block CARenderServer in experimental sandbox in the WebContent process. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/260919@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5f719d: Revert 260295@main because it was unnecessary
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5f719dd2df1a9782b80da2718c003437878dda92 https://github.com/WebKit/WebKit/commit/5f719dd2df1a9782b80da2718c003437878dda92 Author: Myles C. Maxfield Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/mac-wk1/editing/mac/attributed-string/font-style-variant-effect-expected.txt Log Message: --- Revert 260295@main because it was unnecessary https://bugs.webkit.org/show_bug.cgi?id=253033 rdar://105997287 Unreviewed gardening. 1. https://commits.webkit.org/260130@main caused the test to fail 2. https://commits.webkit.org/260295@main updated the test's expected results (which is what this radar was originally about) 3. https://commits.webkit.org/260447@main caused the test to fail the opposite way So https://commits.webkit.org/260447@main fixed the bug, and https://commits.webkit.org/260295@main was wrong. * LayoutTests/platform/mac-wk1/editing/mac/attributed-string/font-style-variant-effect-expected.txt: Canonical link: https://commits.webkit.org/260918@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 83c11a: [UI-side compositing] Send wheel events to the scr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 83c11a0b9f7acd0feddc52a6e30689ebefa81c86 https://github.com/WebKit/WebKit/commit/83c11a0b9f7acd0feddc52a6e30689ebefa81c86 Author: Simon Fraser Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h M Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm Log Message: --- [UI-side compositing] Send wheel events to the scrolling thread in the UI process https://bugs.webkit.org/show_bug.cgi?id=253023 rdar://105992947 Reviewed by Tim Horton. Start sending wheel events to the scrolling thread in the UI process. The primary change is that RemoteScrollingCoordinatorProxyMac overrides handleWheelEvent() to send events to m_wheelEventDispatcher, which bounces them to the scrolling thread. RemoteScrollingCoordinatorProxyMac::displayDidRefresh() also forwards to m_wheelEventDispatcher, but with a name that reflects that fact that this is the "post-commit" displayDidRefresh() that always happens on the main thread. RemoteScrollingTreeMac now has to bounce a number of scrolling tree callbacks back to the main thread, and make sure that scroll animations that start as a result of a scrolling tree commit on the main thread actually run on the scrolling thread. Wire up RemoteLayerTreeEventDispatcher::hasNodeWithAnimatedScrollChanged() in order to correctly keep a display link running while there are scroll animations. Remove some code from RemoteScrollingCoordinatorProxyMac for functionality now handled by RemoteLayerTreeEventDispatcher. * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h: * Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::didCommitTreeOnScrollingThread): No need for clear(); we did a std::exchange() above. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::handleWheelEvent): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp: (WebKit::RemoteLayerTreeEventDispatcher::hasNodeWithAnimatedScrollChanged): (WebKit::RemoteLayerTreeEventDispatcher::handleWheelEvent): (WebKit::RemoteLayerTreeEventDispatcher::wheelEventWasHandledByScrollingThread): (WebKit::RemoteLayerTreeEventDispatcher::internalHandleWheelEvent): (WebKit::RemoteLayerTreeEventDispatcher::mainThreadDisplayDidRefresh): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm: (WebKit::RemoteScrollingCoordinatorProxyMac::RemoteScrollingCoordinatorProxyMac): (WebKit::RemoteScrollingCoordinatorProxyMac::handleWheelEvent): (WebKit::RemoteScrollingCoordinatorProxyMac::hasNodeWithAnimatedScrollChanged): (WebKit::RemoteScrollingCoordinatorProxyMac::displayDidRefresh): (WebKit::RemoteScrollingCoordinatorProxyMac::filteredWheelEvent): Deleted. (WebKit::RemoteScrollingCoordinatorProxyMac::didReceiveWheelEvent): Deleted. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::displayDidRefresh): (WebKit::RemoteScrollingTreeMac::handleMouseEvent): (WebKit::RemoteScrollingTreeMac::didCommitTree): (WebKit::RemoteScrollingTreeMac::startPendingScrollAnimations): (WebKit::RemoteScrollingTreeMac::hasNodeWithAnimatedScrollChanged): (WebKit::RemoteScrollingTreeMac::scrollingTreeNodeDidScroll): (WebKit::RemoteScrollingTreeMac::scrollingTreeNodeDidStopAnimatedScroll): (WebKit::RemoteScrollingTreeMac::scrollingTreeNodeRequestsScroll): (WebKit::RemoteScrollingTreeMac::currentSnapPointIndicesDidChange): (WebKit::RemoteScrollingTreeMac::reportExposedUnfilledArea): (WebKit::RemoteScrollingTreeMac::reportSynchronousScrollingReasonsChanged): (WebKit::RemoteScrollingTreeMac::receivedWheelEventWithPhases): (WebKit::RemoteScrollingTreeMac::deferWheelEventTestCompletionForReason): (WebKit::RemoteScrollingTreeMac::removeWheelEventTestCompletionDeferralForReason): Canonical link: https://commits.webkit.org/260917@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/w
[webkit-changes] [WebKit/WebKit] d50594: [Lockdown Mode] Conditionalize sandbox access
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d50594881e1a17689982d7b415e21174f24ea4e6 https://github.com/WebKit/WebKit/commit/d50594881e1a17689982d7b415e21174f24ea4e6 Author: Per Arne Vollan Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- [Lockdown Mode] Conditionalize sandbox access https://bugs.webkit.org/show_bug.cgi?id=252621 rdar://105698648 Reviewed by Brent Fulgham. Conditionalize sandbox access based on Lockdown Mode sandbox flag. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/260916@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fcb19e: WTF::safeAdd returns twice
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcb19eb585605f1da2bb76c32c371445f15930dd https://github.com/WebKit/WebKit/commit/fcb19eb585605f1da2bb76c32c371445f15930dd Author: Sihui Liu Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WTF/wtf/CheckedArithmetic.h Log Message: --- WTF::safeAdd returns twice https://bugs.webkit.org/show_bug.cgi?id=253021 rdar://105991124 Reviewed by Chris Dumez. Remove one return statement. * Source/WTF/wtf/CheckedArithmetic.h: (WTF::safeAdd): Canonical link: https://commits.webkit.org/260915@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a665ea: [GARDENING] REGRESSION(260774@main):[ iOS ] 7X med...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a665ea44f2da3a9e88ee2d7d9f84301dbc6ad93d https://github.com/WebKit/WebKit/commit/a665ea44f2da3a9e88ee2d7d9f84301dbc6ad93d Author: Robert Jenner Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [GARDENING] REGRESSION(260774@main):[ iOS ] 7X media/video layout-tests broke https://bugs.webkit.org/show_bug.cgi?id=253035 rdar://105998972 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/260914@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2c2474: REGRESSION (257937@main): Hover state UI leaves gr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c24741506078dc94911bda59d8cc1521fdd4dd3 https://github.com/WebKit/WebKit/commit/2c24741506078dc94911bda59d8cc1521fdd4dd3 Author: Alan Baradlay Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: A LayoutTests/fast/repaint/out-of-flow-inside-relative-inline-expected.txt A LayoutTests/fast/repaint/out-of-flow-inside-relative-inline.html M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- REGRESSION (257937@main): Hover state UI leaves graphic artifacts on Techmeme.com https://bugs.webkit.org/show_bug.cgi?id=253014 Reviewed by Antti Koivisto. This patch ensures that when the line layout path gets invalidated (and we eagerly destroy geometry information -there's a FIXME on that) both in-, and out-of-flow content get repainted. (This is the case when calling repaint on an absolute positioned box nested in a relative positioned inline box (e.g. ends up in RenderInline::offsetForInFlowPositionedInline which needs display box geometry information -which we eagerly destroy; see above). * LayoutTests/fast/repaint/out-of-flow-inside-relative-inline-expected.txt: Added. * LayoutTests/fast/repaint/out-of-flow-inside-relative-inline.html: Added. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::invalidateLineLayoutPath): Canonical link: https://commits.webkit.org/260913@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5c08dd: Implement counter-style additive-symbols translation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c08dda8b880c88f13e7c9ff3139c3cfcc59ccd7 https://github.com/WebKit/WebKit/commit/5c08dda8b880c88f13e7c9ff3139c3cfcc59ccd7 Author: Vitor Roriz Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/css/CSSCounterStyleDescriptors.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp Log Message: --- Implement counter-style additive-symbols translation https://bugs.webkit.org/show_bug.cgi?id=252926 rdar://103837257 Reviewed by Darin Adler and Tim Nguyen. We are missing translation of the counter-styles additive-symbols for the CSSCounterStylesDescriptor. We are also introducing some fixes and style adequation to the other translation functions. * Source/WebCore/css/CSSCounterStyleDescriptors.cpp: (WebCore::translateRangeFromStyleProperties): (WebCore::symbolToString): (WebCore::translateAdditiveSymbolsFromStyleProperties): (WebCore::translatePadFromStyleProperties): (WebCore::translateNegativeSymbolsFromStyleProperties): (WebCore::translateSymbolsFromStyleProperties): (WebCore::translateFallbackNameFromStyleProperties): (WebCore::translatePrefixFromStyleProperties): (WebCore::translateSuffixFromStyleProperties): (WebCore::extractDataFromSystemDescriptor): (WebCore::CSSCounterStyleDescriptors::create): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeCounterStyleAdditiveSymbols): Canonical link: https://commits.webkit.org/260912@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bec322: [IFC] Floats never overflow though they may over-c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bec322fbf04b922058bee860ab3d725c51956e60 https://github.com/WebKit/WebKit/commit/bec322fbf04b922058bee860ab3d725c51956e60 Author: Alan Baradlay Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h M Source/WebCore/layout/formattingContexts/inline/InlineLineTypes.h Log Message: --- [IFC] Floats never overflow though they may over-constrain the line https://bugs.webkit.org/show_bug.cgi?id=253005 Reviewed by Antti Koivisto. 1. Floats shrink the available horizontal space for the inline content 2. When they shrink the line too much so that the (placed) inline content does not fit anymore (line is over-constrained) we need to suspend float layout at this vertical position. However inline layout can continue as long as there's still available space left. 3. Such "suspended" floats are placed when we get to the next available vertical position (next line in this case). (Rename and move things around) * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::lineLayout): (WebCore::Layout::InlineFormattingContext::resetGeometryForClampedContent): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h: * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::layoutInlineContent): (WebCore::Layout::LineBuilder::initialize): (WebCore::Layout::LineBuilder::placeInlineContent): (WebCore::Layout::LineBuilder::shouldTryToPlaceFloatBox const): (WebCore::Layout::LineBuilder::tryPlacingFloatBox): (WebCore::Layout::LineBuilder::isLastLineWithInlineContent const): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h: (WebCore::Layout::LineBuilder::isFloatLayoutSuspended const): * Source/WebCore/layout/formattingContexts/inline/InlineLineTypes.h: Canonical link: https://commits.webkit.org/260911@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a061ab: Regression(255828@main) App launch time has slight...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a061abebfe51202cf24417a6bedf4d4916357b71 https://github.com/WebKit/WebKit/commit/a061abebfe51202cf24417a6bedf4d4916357b71 Author: Chris Dumez Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/UIProcess/WebProcessPool.h Log Message: --- Regression(255828@main) App launch time has slightly regressed https://bugs.webkit.org/show_bug.cgi?id=252993 rdar://105236601 Reviewed by Michael Saboff. Move logic to determine the value of s_shouldCrashWhenCreatingWebProcess off the main thread in order to address the app launch time regression. * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::initializeShouldCrashWhenCreatingWebProcess): (WebKit::WebProcessPool::platformInitialize): (WebKit::determineIfWeShouldCrashWhenCreatingWebProcess): Deleted. * Source/WebKit/UIProcess/WebProcessPool.h: Canonical link: https://commits.webkit.org/260910@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 775f73: [webkitcorepy] Add a PartialProxy class
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 775f730ac67edfb60a140d4550965b89b6205547 https://github.com/WebKit/WebKit/commit/775f730ac67edfb60a140d4550965b89b6205547 Author: Jonathan Bedard Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/setup.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py A Tools/Scripts/libraries/webkitcorepy/webkitcorepy/partial_proxy.py A Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/partial_proxy_unittest.py Log Message: --- [webkitcorepy] Add a PartialProxy class https://bugs.webkit.org/show_bug.cgi?id=253007 rdar://105984609 Rubber-stamped by Aakash Jain. Allow Python programs to send requests to specific hosts through a proxy, but not requests to all hosts. * Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Export PartialProxy class. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/partial_proxy.py: Added. (PartialProxy.__init__): Store the hosts and http and https proxies. (PartialProxy.__enter__): Mock all request calls to use a temporary Session object. (PartialProxy.__enter__.Session): Add proxy arguments to requests to the specified hosts. (PartialProxy.__exit__): * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/partial_proxy_unittest.py: Added. (DummySession): Session object which simply stores the passed proxy arguments. (PartialProxyTest.test_session): Canonical link: https://commits.webkit.org/260909@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d6a392: [iOS / macOS] svg/compositing/outermost-svg-with-b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d6a3928bd1bb36ca30427ec151af4f9e308726fd https://github.com/WebKit/WebKit/commit/d6a3928bd1bb36ca30427ec151af4f9e308726fd Author: Robert Jenner Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac/TestExpectations M LayoutTests/svg/compositing/outermost-svg-with-border-padding.html Log Message: --- [iOS / macOS] svg/compositing/outermost-svg-with-border-padding.html is consistently failing (252088) https://bugs.webkit.org/show_bug.cgi?id=252088 rdar://105301796 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/svg/compositing/outermost-svg-with-border-padding.html: Canonical link: https://commits.webkit.org/260908@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ae028a: REBASELINE: [iPad] 3X platform/ipad/fast/viewport ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae028ab5fb24bf8a5470d4187c9ba666f4902f89 https://github.com/WebKit/WebKit/commit/ae028ab5fb24bf8a5470d4187c9ba666f4902f89 Author: Robert Jenner Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/ipad/fast/viewport/empty-meta-expected.txt M LayoutTests/platform/ipad/fast/viewport/meta-viewport-ignored-expected.txt M LayoutTests/platform/ipad/fast/viewport/width-is-device-width-expected.txt Log Message: --- REBASELINE: [iPad] 3X platform/ipad/fast/viewport are constant text failures https://bugs.webkit.org/show_bug.cgi?id=253030 Unreviewed test gardening. * LayoutTests/platform/ipad/fast/viewport/empty-meta-expected.txt: * LayoutTests/platform/ipad/fast/viewport/meta-viewport-ignored-expected.txt: * LayoutTests/platform/ipad/fast/viewport/width-is-device-width-expected.txt: Canonical link: https://commits.webkit.org/260907@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35416b: Floats' trimmed margins should not contribute to c...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 35416b6b8ce498954d542f25d74cb15f3a35f089
https://github.com/WebKit/WebKit/commit/35416b6b8ce498954d542f25d74cb15f3a35f089
Author: Sammy Gill
Date: 2023-02-27 (Mon, 27 Feb 2023)
Changed paths:
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-expected.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-orthogonal-expected.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-orthogonal.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-rtl-expected.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-rtl.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-trim-float-drives-container-intrinsic-size-inline-layout-expected.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-trim-float-drives-container-intrinsic-size-inline-layout.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-trim-text-drives-container-intrinsic-size-inline-layout-expected.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-trim-text-drives-container-intrinsic-size-inline-layout-vert-lr-expected.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-trim-text-drives-container-intrinsic-size-inline-layout-vert-lr.html
A
LayoutTests/fast/inline/legacy-margin-trim/block-container-float-inline-trim-text-drives-container-intrinsic-size-inline-layout.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-orthogonal-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-orthogonal.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-rtl-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size-rtl.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-start-trim-float-drives-container-intrinsic-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-trim-float-drives-container-intrinsic-size-inline-layout-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-trim-float-drives-container-intrinsic-size-inline-layout.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-trim-text-drives-container-intrinsic-size-inline-layout-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-trim-text-drives-container-intrinsic-size-inline-layout-vert-lr-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-trim-text-drives-container-intrinsic-size-inline-layout-vert-lr.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-inline-trim-text-drives-container-intrinsic-size-inline-layout.html
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
Log Message:
---
Floats' trimmed margins should not contribute to containing block's intrinsic
sizing (legacy line layout)
https://bugs.webkit.org/show_bug.cgi?id=252976
rdar://105960289
Reviewed by Alan Baradlay.
When a containing block establishes and inline formatting context and
it is being sized under some sort of intrinsic sizing constraint (e.g.
width: min-content), then the margins of any float within that
containing block should not contribute to the intrinsic sizing if it
is specified under margin-trim. The logic is the same as in the block
layout case and we can use the same helper to check whether a margin
should contribute to the sizing:
shouldChildInlineMarginContributeToContainerIntrinsicSize.
container {
display: block;
inline-size: min-content;
font-fa
[webkit-changes] [WebKit/WebKit] f13d5a: Cherry-pick 259890@main (38fc0ce11b21). https://bu...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: f13d5a4d1481a5f910bf28895c2191f7387eebca https://github.com/WebKit/WebKit/commit/f13d5a4d1481a5f910bf28895c2191f7387eebca Author: Xabier Rodriguez-Calvar Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp Log Message: --- Cherry-pick 259890@main (38fc0ce11b21). https://bugs.webkit.org/show_bug.cgi?id=251587 [GStreamer][EME][Thunder] Add PlayReady support https://bugs.webkit.org/show_bug.cgi?id=251587 Reviewed by Philippe Normand. Enable PlayReady if the Thunder plugins are present. Also add a small check just in case there is no Thunder running in debug mode. Added key ID corner case hack. Sometimes PlayReady key IDs come with some bytes swapped so we add both original and swapped key IDs to the hashmap. * Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp: (WebCore::CDMFactoryThunder::supportedKeySystems const): (WebCore::CDMInstanceSessionThunder::keyUpdatedCallback): Canonical link: https://commits.webkit.org/259890@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2672d: [JSC] Implement wasm exception in new BBQ
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2672d2623ed17421641e2827515bd6b02c893ea https://github.com/WebKit/WebKit/commit/e2672d2623ed17421641e2827515bd6b02c893ea Author: Yusuke Suzuki Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmB3IRGenerator.h M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp M Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h Log Message: --- [JSC] Implement wasm exception in new BBQ https://bugs.webkit.org/show_bug.cgi?id=252959 rdar://105692614 Reviewed by Tadeu Zagallo. This patch implements wasm exception in new BBQ. The implementation is just following to how exception is implemented in the other tiers (LLInt, old BBQ Air), so not introducing a new concept. 1. Catch / CatchAll blocks should have implicit stack slot to hold exception (as the same to old Air and LLInt). This is represented as implicitSlots. 2. When catch / catch-all is running, we already flush everything in endBlock. Thus, we do not need to have stackmap at all: every wasm temps are on stack. So only thing we need is just spreading wasm exception parameters to the block's parameters (this is the same to what wasm LLInt exception handling is doing). 3. Each try-block and exception-throwing operations incremenets m_callSiteIndex. And emit it to CCallHelpers::tagFor(CallFrameSlot::argumentCountIncludingThis) slot. This number is used as a range of covering of the exception handler. (This is exactly the same design to DFG / FTL exception handling). And this is the same to old BBQ Air exception handling. 4. Entrance of exception handler is represented as a label inside code. And these labels are extracted for exception handlers. * Source/JavaScriptCore/wasm/WasmB3IRGenerator.h: * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::ControlData::ControlData): (JSC::Wasm::BBQJIT::ControlData::endBlock): (JSC::Wasm::BBQJIT::ControlData::startBlock): (JSC::Wasm::BBQJIT::ControlData::resumeBlock): (JSC::Wasm::BBQJIT::ControlData::releaseJumps): (JSC::Wasm::BBQJIT::ControlData::implicitSlots const): (JSC::Wasm::BBQJIT::ControlData::argumentLocations const): (JSC::Wasm::BBQJIT::ControlData::resultLocations const): (JSC::Wasm::BBQJIT::ControlData::setCatchKind): (JSC::Wasm::BBQJIT::ControlData::tryStart const): (JSC::Wasm::BBQJIT::ControlData::tryEnd const): (JSC::Wasm::BBQJIT::ControlData::tryCatchDepth const): (JSC::Wasm::BBQJIT::ControlData::setTryInfo): (JSC::Wasm::BBQJIT::BBQJIT): (JSC::Wasm::BBQJIT::topValue): (JSC::Wasm::BBQJIT::exception): (JSC::Wasm::BBQJIT::emitEntryTierUpCheck): (JSC::Wasm::BBQJIT::addTopLevel): (JSC::Wasm::BBQJIT::addBlock): (JSC::Wasm::BBQJIT::addLoop): (JSC::Wasm::BBQJIT::addIf): (JSC::Wasm::BBQJIT::addElse): (JSC::Wasm::BBQJIT::addElseToUnreachable): (JSC::Wasm::BBQJIT::addTry): (JSC::Wasm::BBQJIT::emitCatchPrologue): (JSC::Wasm::BBQJIT::emitCatchAllImpl): (JSC::Wasm::BBQJIT::emitCatchImpl): (JSC::Wasm::BBQJIT::addCatch): (JSC::Wasm::BBQJIT::addCatchToUnreachable): (JSC::Wasm::BBQJIT::addCatchAll): (JSC::Wasm::BBQJIT::addCatchAllToUnreachable): (JSC::Wasm::BBQJIT::addDelegate): (JSC::Wasm::BBQJIT::addDelegateToUnreachable): (JSC::Wasm::BBQJIT::addThrow): (JSC::Wasm::BBQJIT::addRethrow): (JSC::Wasm::BBQJIT::prepareForExceptions): (JSC::Wasm::BBQJIT::addReturn): (JSC::Wasm::BBQJIT::endBlock): (JSC::Wasm::BBQJIT::addEndToUnreachable): (JSC::Wasm::BBQJIT::endTopLevel): (JSC::Wasm::BBQJIT::flushRegistersForException): (JSC::Wasm::BBQJIT::returnValuesFromCall): (JSC::Wasm::BBQJIT::emitCCall): (JSC::Wasm::BBQJIT::addCall): (JSC::Wasm::BBQJIT::emitIndirectCall): (JSC::Wasm::BBQJIT::notifyFunctionUsesSIMD): (JSC::Wasm::BBQJIT::takeExceptionHandlers): (JSC::Wasm::BBQJIT::takeCatchEntrypoints): (JSC::Wasm::BBQJIT::emitShuffle): (JSC::Wasm::parseAndCompileBBQ): (JSC::Wasm::BBQJIT::ControlData::allocateArgumentOrResult): Deleted. * Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h: (JSC::Wasm::computeExceptionHandlerAndLoopEntrypointLocations): Canonical link: https://commits.webkit.org/260905@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 65b6e6: Cherry-pick 260882@main (1516848f1a90). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: 65b6e65017be1193706c8e3f38e5f4de57dd1ec6 https://github.com/WebKit/WebKit/commit/65b6e65017be1193706c8e3f38e5f4de57dd1ec6 Author: Vitaly Dyachkov Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/gtk/TestExpectations M Source/WebCore/rendering/style/RenderStyleConstants.h Log Message: --- Cherry-pick 260882@main (1516848f1a90). https://bugs.webkit.org/show_bug.cgi?id=229740 [WPE][GTK] Prevent HarfBuzz advance overflow https://bugs.webkit.org/show_bug.cgi?id=229740 Reviewed by Carlos Garcia Campos. When taking the complex text path we get glyph advances by calling `hb_buffer_get_glyph_positions`. HarfBuzz uses `hb_position_t` aka `int32_t` type to store advances and offset, where the first 16 bits are used to store the integer part and the second 16 bits to store the fractional precision part. Since this type is singed we are left with only 15 bits for maximum positive advance value which gives us 32767 or `std::numeric_limits::max()`. Fixes `fast/box-shadow/box-shadow-huge-area-crash.html`. * LayoutTests/platform/gtk/TestExpectations: * Source/WebCore/rendering/style/RenderStyleConstants.h: Canonical link: https://commits.webkit.org/260882@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 472e74: Cherry-pick 260882@main (1516848f1a90). https://bu...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 472e74898cccf6fbb9ee6befaafe9477d2600a60 https://github.com/WebKit/WebKit/commit/472e74898cccf6fbb9ee6befaafe9477d2600a60 Author: Vitaly Dyachkov Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/gtk/TestExpectations M Source/WebCore/rendering/style/RenderStyleConstants.h Log Message: --- Cherry-pick 260882@main (1516848f1a90). https://bugs.webkit.org/show_bug.cgi?id=229740 [WPE][GTK] Prevent HarfBuzz advance overflow https://bugs.webkit.org/show_bug.cgi?id=229740 Reviewed by Carlos Garcia Campos. When taking the complex text path we get glyph advances by calling `hb_buffer_get_glyph_positions`. HarfBuzz uses `hb_position_t` aka `int32_t` type to store advances and offset, where the first 16 bits are used to store the integer part and the second 16 bits to store the fractional precision part. Since this type is singed we are left with only 15 bits for maximum positive advance value which gives us 32767 or `std::numeric_limits::max()`. Fixes `fast/box-shadow/box-shadow-huge-area-crash.html`. * LayoutTests/platform/gtk/TestExpectations: * Source/WebCore/rendering/style/RenderStyleConstants.h: Canonical link: https://commits.webkit.org/260882@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1ce84d: Change the default iPadOS simulator to one with a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ce84dcfeba0b213fa64c47104c8e87295f4a4ba https://github.com/WebKit/WebKit/commit/1ce84dcfeba0b213fa64c47104c8e87295f4a4ba Author: Robert Jenner Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py M Tools/Scripts/webkitpy/port/ios_simulator.py M Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py Log Message: --- Change the default iPadOS simulator to one with a larger screen size https://bugs.webkit.org/show_bug.cgi?id=251458 rdar://104886115 Reviewed by Ryan Haddad. * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_device_type_test_division): (RunTest.test_device_type_specific_listing): (RunTest.test_ipad_test_division): (RunTest.test_ipad_listing): * Tools/Scripts/webkitpy/port/ios_simulator.py: (IOSSimulatorPort): (IPadSimulatorPort): * Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py: Canonical link: https://commits.webkit.org/260904@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 926d98: [GCC] Unreviewed, build fix for Ubuntu 20.04 after...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 926d98c19de1441e3e25da7c0543e1f471b8e272 https://github.com/WebKit/WebKit/commit/926d98c19de1441e3e25da7c0543e1f471b8e272 Author: Diego Pino Garcia Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp Log Message: --- [GCC] Unreviewed, build fix for Ubuntu 20.04 after 260883@main Restore change still needed for GCC9.4. * Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp: (PAL::tableForEncoding): Canonical link: https://commits.webkit.org/260903@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5b66b2: Cherry-pick b3bdeda02fd5. rdar://problem/105616856
Branch: refs/heads/safari-7616.1.4-branch Home: https://github.com/WebKit/WebKit Commit: 5b66b2604932b0682180501f451e04330be5aeb7 https://github.com/WebKit/WebKit/commit/5b66b2604932b0682180501f451e04330be5aeb7 Author: Etienne Segonzac Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm Log Message: --- Cherry-pick b3bdeda02fd5. rdar://problem/105616856 Adopt new subclass for InteractionRegion layers https://bugs.webkit.org/show_bug.cgi?id=252743 Reviewed by Darin Adler. Use the new extension point to get the InteractionRegion layer subclass. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: (interactionRegionLayerClass): (WebKit::updateLayersForInteractionRegions): Remove the explicit string conversion for the element identifier. Canonical link: https://commits.webkit.org/260892@main Canonical link: https://commits.webkit.org/260848.1@safari-7616.1.4-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3dafcd: WARNING_CFLAGS should use $(inherited) instead of ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3dafcdaa89c03f7d6d58cee71bbb6d13130a3e34 https://github.com/WebKit/WebKit/commit/3dafcdaa89c03f7d6d58cee71bbb6d13130a3e34 Author: David Kilzer Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Configurations/CommonBase.xcconfig M Source/JavaScriptCore/Configurations/Base.xcconfig M Source/ThirdParty/ANGLE/Configurations/Base.xcconfig M Source/ThirdParty/gtest/xcode/Config/General.xcconfig M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig M Source/WTF/Configurations/Base.xcconfig M Source/WebCore/Configurations/Base.xcconfig M Source/WebCore/PAL/Configurations/Base.xcconfig M Source/WebCore/PAL/ThirdParty/libavif/Configurations/Base.xcconfig M Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/Base.xcconfig M Source/WebGPU/Configurations/Base.xcconfig M Source/WebInspectorUI/Configurations/Base.xcconfig M Source/WebKit/Configurations/Base.xcconfig M Source/WebKitLegacy/mac/Configurations/Base.xcconfig M Source/bmalloc/Configurations/Base.xcconfig M Tools/DumpRenderTree/mac/Configurations/Base.xcconfig M Tools/ImageDiff/cg/Configurations/Base.xcconfig M Tools/MiniBrowser/Configurations/Base.xcconfig M Tools/MobileMiniBrowser/Configurations/Base.xcconfig M Tools/TestWebKitAPI/Configurations/Base.xcconfig M Tools/WebEditingTester/Configurations/Base.xcconfig M Tools/WebGPUPlayground/Configurations/Base.xcconfig M Tools/WebKitTestRunner/Configurations/Base.xcconfig M Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig Log Message: --- WARNING_CFLAGS should use $(inherited) instead of $(WK_COMMON_WARNING_CFLAGS) https://bugs.webkit.org/show_bug.cgi?id=252992 Reviewed by Elliott Williams. Switch from using $(WK_COMMON_WARNING_CFLAGS) to $(inherited) in all Base.xcconfig files. * Configurations/CommonBase.xcconfig: * Source/JavaScriptCore/Configurations/Base.xcconfig: * Source/ThirdParty/ANGLE/Configurations/Base.xcconfig: * Source/ThirdParty/gtest/xcode/Config/General.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig: * Source/WTF/Configurations/Base.xcconfig: * Source/WebCore/Configurations/Base.xcconfig: * Source/WebCore/PAL/Configurations/Base.xcconfig: * Source/WebCore/PAL/ThirdParty/libavif/Configurations/Base.xcconfig: * Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/Base.xcconfig: * Source/WebGPU/Configurations/Base.xcconfig: * Source/WebInspectorUI/Configurations/Base.xcconfig: * Source/WebKit/Configurations/Base.xcconfig: * Source/WebKitLegacy/mac/Configurations/Base.xcconfig: * Source/bmalloc/Configurations/Base.xcconfig: * Tools/DumpRenderTree/mac/Configurations/Base.xcconfig: * Tools/ImageDiff/cg/Configurations/Base.xcconfig: * Tools/MiniBrowser/Configurations/Base.xcconfig: * Tools/MobileMiniBrowser/Configurations/Base.xcconfig: * Tools/TestWebKitAPI/Configurations/Base.xcconfig: * Tools/WebEditingTester/Configurations/Base.xcconfig: * Tools/WebGPUPlayground/Configurations/Base.xcconfig: * Tools/WebKitTestRunner/Configurations/Base.xcconfig: * Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig: Canonical link: https://commits.webkit.org/260902@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 229b3d: ImageBuffer::clone can fail, and pass nullptr to s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 229b3dbf26ebb0b908fae678f18f69ec25485a11 https://github.com/WebKit/WebKit/commit/229b3dbf26ebb0b908fae678f18f69ec25485a11 Author: Matt Woodrow Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/html/OffscreenCanvas.cpp Log Message: --- ImageBuffer::clone can fail, and pass nullptr to sinkIntoSerializedImageBuffer https://bugs.webkit.org/show_bug.cgi?id=252965 Reviewed by Said Abou-Hallawa. ImageBuffer::clone can fail if the GPU process has crashed, and we can silently fail here and while waiting for it to restart. * Source/WebCore/html/OffscreenCanvas.cpp: (WebCore::OffscreenCanvas::commitToPlaceholderCanvas): Canonical link: https://commits.webkit.org/260901@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2609ef: Regression 257767@main: WebKitPerl-Tests-EWS build...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2609ef79bbc2d841e61d17a5001f550a832a33e3 https://github.com/WebKit/WebKit/commit/2609ef79bbc2d841e61d17a5001f550a832a33e3 Author: Aakash Jain Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- Regression 257767@main: WebKitPerl-Tests-EWS build marked as SUCCESS despite failing tests https://bugs.webkit.org/show_bug.cgi?id=253018 Reviewed by Jonathan Bedard. Matching the base class appropriately. * Tools/CISupport/ews-build/steps.py: (RunWebKitPerlTests.evaluateCommand): (ReRunWebKitPerlTests.evaluateCommand): Canonical link: https://commits.webkit.org/260900@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 265e62: imported/w3c/web-platform-tests/preload/moduleprel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 265e62c4e52fe7be526ad2c1c006f69f4e7d3cf9 https://github.com/WebKit/WebKit/commit/265e62c4e52fe7be526ad2c1c006f69f4e7d3cf9 Author: Ryosuke Niwa Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- imported/w3c/web-platform-tests/preload/modulepreload.html is flaky https://bugs.webkit.org/show_bug.cgi?id=252942 Unreviewed test gardening. * LayoutTests/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/260899@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8575a: [UI-side compositing] RemoteScrollingTree needs to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8575a9871eced896e8c64b5166f3c59bab146e4 https://github.com/WebKit/WebKit/commit/e8575a9871eced896e8c64b5166f3c59bab146e4 Author: Simon Fraser Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingTreeIOS.cpp M Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm Log Message: --- [UI-side compositing] RemoteScrollingTree needs to hold a weak ref to the RemoteScrollingCoordinatorProxy https://bugs.webkit.org/show_bug.cgi?id=252963 rdar://105949247 Reviewed by Tim Horton. The scrolling thread can extend the lifetime of the RemoteScrollingTree via activity on that thread, so RemoteScrollingTree needs to hold a nullable reference to the RemoteScrollingCoordinatorProxy; use a WeakPtr. Add null checks everywhere we use m_scrollingCoordinatorProxy. All of these are on the main thread. * Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp: (WebCore::operator<<): Add missing space in logging. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp: (WebKit::RemoteScrollingTree::RemoteScrollingTree): (WebKit::RemoteScrollingTree::invalidate): (WebKit::RemoteScrollingTree::scrollingCoordinatorProxy const): (WebKit::RemoteScrollingTree::scrollingTreeNodeDidScroll): (WebKit::RemoteScrollingTree::scrollingTreeNodeDidStopAnimatedScroll): (WebKit::RemoteScrollingTree::scrollingTreeNodeRequestsScroll): (WebKit::RemoteScrollingTree::currentSnapPointIndicesDidChange): (WebKit::RemoteScrollingTree::reportExposedUnfilledArea): (WebKit::RemoteScrollingTree::reportSynchronousScrollingReasonsChanged): (WebKit::RemoteScrollingTree::receivedWheelEventWithPhases): (WebKit::RemoteScrollingTree::deferWheelEventTestCompletionForReason): (WebKit::RemoteScrollingTree::removeWheelEventTestCompletionDeferralForReason): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h: Various final -> override since a future patch will override these functions. (WebKit::RemoteScrollingTree::scrollingCoordinatorProxy const): Deleted. * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingTreeIOS.cpp: (WebKit::RemoteScrollingTreeIOS::scrollingTreeNodeWillStartPanGesture): (WebKit::RemoteScrollingTreeIOS::scrollingTreeNodeWillStartScroll): (WebKit::RemoteScrollingTreeIOS::scrollingTreeNodeDidEndScroll): * Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: (WebKit::ScrollingTreeScrollingNodeDelegateIOS::handleAsynchronousCancelableScrollEvent): (WebKit::ScrollingTreeScrollingNodeDelegateIOS::findActingScrollParent): (WebKit::ScrollingTreeScrollingNodeDelegateIOS::cancelPointersForGestureRecognizer): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::hasNodeWithAnimatedScrollChanged): Canonical link: https://commits.webkit.org/260898@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7616.1.4-branch Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b8d16f: [macOS] Add support for QR code detection when sho...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b8d16fc06260ef10522f25e883994e7242554ecf https://github.com/WebKit/WebKit/commit/b8d16fc06260ef10522f25e883994e7242554ecf Author: Aditya Keerthi Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj M Source/WebCore/PAL/pal/PlatformMac.cmake A Source/WebCore/PAL/pal/cocoa/VisionSoftLink.h A Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm M Source/WebKit/Shared/ContextMenuContextData.h M Source/WebKit/UIProcess/API/APIContextMenuClient.h M Source/WebKit/UIProcess/API/APIContextMenuElementInfoMac.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKContextMenuElementInfo.h M Source/WebKit/UIProcess/API/Cocoa/_WKContextMenuElementInfo.mm M Source/WebKit/UIProcess/Cocoa/UIDelegate.h M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm M Source/WebKit/UIProcess/WebContextMenuProxy.h M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebKit/qr-code.png M Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm Log Message: --- [macOS] Add support for QR code detection when showing a context menu https://bugs.webkit.org/show_bug.cgi?id=252971 rdar://105953011 Reviewed by Wenson Hsieh. Safari currently implements support for QR code detection when showing a context menu using an injected bundle. This patch works towards two goals by adding equivalent support at the WebKit layer: 1. Reducing the surface of Safari's injected bundle. 2. Enabling iokit blocking in the Web Process. Safari's QR code detection is implemented using the Vision framework in the Web Process. With iokit blocking enabled, this approach will fail, as Vision fails to create `CIImage`s. This patch adds initial support for QR code detection when showing a context menu in WebKit. Support is implemented by using the Vision framework in the UIProcess and is controlled by new SPI on `WKWebViewConfiguration`, as QR code detection is not inexpensive. Note that Safari's heuristics for detecting QR codes outside of elements are currently unsupported. These heuristics will be implemented in a subsequent patch. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Add an off-by-default setting for QR code detection when showing a context menu. * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WTF/wtf/PlatformHave.h: The Vision framework is available on all Cocoa platforms other than watchOS. * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/PlatformMac.cmake: * Source/WebCore/PAL/pal/cocoa/VisionSoftLink.h: Added. * Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm: Added. * Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h: * Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm: (WebKit::imageFilledWithWhiteBackground): Adjust the image used to perform QR code detection to have a white background to support transparent images. (WebKit::requestPayloadForQRCode): Add a helper method to obtain QR code data from a `CGImageRef`. * Source/WebKit/Shared/ContextMenuContextData.h: (WebKit::ContextMenuContextData::qrCodePayloadString const): (WebKit::ContextMenuContextData::setQRCodePayloadString): * Source/WebKit/UIProcess/API/APIContextMenuClient.h: (API::ContextMenuClient::menuFromProposedMenu): Adjust the method to take a `ContextMenuContextData` rather than a `WebHitTestResultData` to include additional context. * Source/WebKit/UIProcess/API/APIContextMenuElementInfoMac.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setupPageConfiguration:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _contextMenuQRCodeDetectionEnabled]): (-[WKWebViewConfiguration _setContextMenuQRCodeDetectionEnabled:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Add SPI to control whether QR code detection is performed when showing a context menu. Detection is not performed by default. * Source/WebKit/UIProcess/API/Cocoa/_WKContextMenuElementInfo.h: Expose the detection result via SPI on `_WKContextMenuElementInfo`. * Source/WebKit/UIProcess/API/Cocoa/_WKContextMenuElementInfo.mm: (-[_WKContextMenuElementInfo qrCodePayloadString]): * Source/WebKit/UIProcess/Cocoa/UIDele
[webkit-changes] [WebKit/WebKit] a27ac6: Restore 100, 000 limit in HTMLOptionsCollection.len...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a27ac64f683e8d0a798123758cb4bf5a0bc75cd0 https://github.com/WebKit/WebKit/commit/a27ac64f683e8d0a798123758cb4bf5a0bc75cd0 Author: Ahmad Saleem Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt M LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt M LayoutTests/fast/forms/select-max-length-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/select/options-length-too-large-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/select/options-length-too-large.html M Source/WebCore/html/HTMLSelectElement.cpp Log Message: --- Restore 100,000 limit in HTMLOptionsCollection.length setter https://bugs.webkit.org/show_bug.cgi?id=252983 Reviewed by Chris Dumez. This patch is to align WebKit with Blink / Chromium and Gecko / Firefox. Merge - https://chromium.googlesource.com/chromium/src/+/f27e6ea87ecf211c8b8644813422a9e7f19cd1cc This patch updates 'maxSelectItems' to new value of 100,000 to reflect update in spec. Further, it is updated to be only used when new length is greater than current length. Additionally, add comments to reflect the details as needed. Web-Spec: https://html.spec.whatwg.org/#dom-htmloptionscollection-length Issue: https://github.com/whatwg/html/issues/8337 * Source/WebCore/html/HTMLSelectElement.cpp: (maxSelectItems): Update constant value (HTMLSelectElement::setItem): Remove '=' and update comments and console message (HTMLSelectElement::setLength): Add comment and update console message * LayoutTests/imported/w3c/web-platform-tests/html/select/options-length-too-large.html: Add Test Case * LayoutTests/imported/w3c/web-platform-tests/html/select/options-length-too-large-expected.txt: Add Test Case Expectation * LayoutTests/fast/forms/select-max-length-expected.txt: Rebaselined * LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt: Rebaselined * LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/260896@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75ee90: Update JavaScriptCore TBA versions for macOS 13.3 ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75ee90767a643d903a09955acaf5e75e62587d47 https://github.com/WebKit/WebKit/commit/75ee90767a643d903a09955acaf5e75e62587d47 Author: Elliott Williams Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/JavaScriptCore/API/APIIntegrityPrivate.h M Source/JavaScriptCore/API/JSContext.h M Source/JavaScriptCore/API/JSContextPrivate.h M Source/JavaScriptCore/API/JSContextRef.h M Source/JavaScriptCore/API/JSContextRefPrivate.h M Source/JavaScriptCore/API/JSRemoteInspector.h Log Message: --- Update JavaScriptCore TBA versions for macOS 13.3 and iOS 16.4 https://bugs.webkit.org/show_bug.cgi?id=252649 rdar://105682433 Reviewed by Patrick Angle and Yusuke Suzuki. Finalize the availability version numbers for API/SPI that are newly available in the latest seed, plus some older declarations that were never updated. * Source/JavaScriptCore/API/APIIntegrityPrivate.h: * Source/JavaScriptCore/API/JSContext.h: * Source/JavaScriptCore/API/JSContextPrivate.h: * Source/JavaScriptCore/API/JSContextRef.h: * Source/JavaScriptCore/API/JSContextRefPrivate.h: * Source/JavaScriptCore/API/JSRemoteInspector.h: Canonical link: https://commits.webkit.org/260895@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 70600b: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 70600b3c1600c5de9a8ef987cbbd51aedbf11d6a https://github.com/WebKit/WebKit/commit/70600b3c1600c5de9a8ef987cbbd51aedbf11d6a Author: Russell Epstein Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7616.1.5 Canonical link: https://commits.webkit.org/260894@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10c781: Implement EXT_polygon_offset_clamp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10c781652eaee47a601708e699ff39e3c722bf19 https://github.com/WebKit/WebKit/commit/10c781652eaee47a601708e699ff39e3c722bf19 Author: Alexey Knyazev <3479527+lexaknya...@users.noreply.github.com> Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-default-expected.txt M LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-off-expected.txt M LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-on-expected.txt M LayoutTests/webgl/resources/webgl-draft-extensions-flag.js M LayoutTests/webgl/webgl-draft-extensions-flag-default-expected.txt M LayoutTests/webgl/webgl-draft-extensions-flag-off-expected.txt M LayoutTests/webgl/webgl-draft-extensions-flag-on-expected.txt M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp A Source/WebCore/html/canvas/EXTPolygonOffsetClamp.cpp A Source/WebCore/html/canvas/EXTPolygonOffsetClamp.h A Source/WebCore/html/canvas/EXTPolygonOffsetClamp.idl M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp M Source/WebCore/html/canvas/WebGLExtension.h M Source/WebCore/html/canvas/WebGLRenderingContext.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.h M Source/WebCore/platform/graphics/GraphicsContextGL.h M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp Log Message: --- Implement EXT_polygon_offset_clamp https://bugs.webkit.org/show_bug.cgi?id=252956 Reviewed by Kimmo Kinnunen. * LayoutTests/TestExpectations: * LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-default-expected.txt: * LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-off-expected.txt: * LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-on-expected.txt: * LayoutTests/webgl/resources/webgl-draft-extensions-flag.js: * LayoutTests/webgl/webgl-draft-extensions-flag-default-expected.txt: * LayoutTests/webgl/webgl-draft-extensions-flag-off-expected.txt: * LayoutTests/webgl/webgl-draft-extensions-flag-on-expected.txt: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp: (WebCore::convertToJSValue): * Source/WebCore/html/canvas/EXTPolygonOffsetClamp.cpp: Added. (WebCore::EXTPolygonOffsetClamp::EXTPolygonOffsetClamp): (WebCore::EXTPolygonOffsetClamp::getName const): (WebCore::EXTPolygonOffsetClamp::supported): (WebCore::EXTPolygonOffsetClamp::polygonOffsetClampEXT): * Source/WebCore/html/canvas/EXTPolygonOffsetClamp.h: Added. * Source/WebCore/html/canvas/EXTPolygonOffsetClamp.idl: Added. * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getExtension): (WebCore::WebGL2RenderingContext::getSupportedExtensions): * Source/WebCore/html/canvas/WebGLExtension.h: * Source/WebCore/html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::getParameter): (WebCore::WebGLRenderingContextBase::extensionIsEnabled): (WebCore::WebGLRenderingContextBase::loseExtensions): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::polygonOffsetClampEXT): * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h: (polygonOffsetClampEXT): * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp: (WebKit::RemoteGraphicsContextGLProxy::polygonOff
[webkit-changes] [WebKit/WebKit] b3bded: Adopt new subclass for InteractionRegion layers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3bdeda02fd5995a5ac0f90d8dfb3d52904ae337 https://github.com/WebKit/WebKit/commit/b3bdeda02fd5995a5ac0f90d8dfb3d52904ae337 Author: Etienne Segonzac Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm Log Message: --- Adopt new subclass for InteractionRegion layers https://bugs.webkit.org/show_bug.cgi?id=252743 Reviewed by Darin Adler. Use the new extension point to get the InteractionRegion layer subclass. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: (interactionRegionLayerClass): (WebKit::updateLayersForInteractionRegions): Remove the explicit string conversion for the element identifier. Canonical link: https://commits.webkit.org/260892@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 78e6b5: Twitter is not filtered by content filter
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 78e6b51bcaed35eb4c3448440f52c565be38 https://github.com/WebKit/WebKit/commit/78e6b51bcaed35eb4c3448440f52c565be38 Author: Per Arne Vollan Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/http/wpt/service-workers/basic-fetch-with-contentfilter.https-expected.txt A LayoutTests/http/wpt/service-workers/basic-fetch-with-contentfilter.https.html A LayoutTests/http/wpt/service-workers/basic-fetch-with-contentfilter.js M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/NetworkProcess/NetworkResourceLoader.h M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h Log Message: --- Twitter is not filtered by content filter https://bugs.webkit.org/show_bug.cgi?id=252496 rdar://103032824 Reviewed by Sihui Liu. Twitter is not filtered by content filter since service worker fetch is missing filtering code. Make sure content filtering is started on service worker fetch, and let the content filter intercept the fetch if it should be blocked. The didReceiveData method in ServiceWorkerFetchTask has been split into two methods, since it was being called both when receiving data over IPC and from the network. The unsafeBuffer method in IPC::SharedBufferReference is only allowed to be called on the receiver side. The call to startContentFiltering was moved to a location where it will also be called on service worker fetch, which required a little refactoring. * LayoutTests/TestExpectations: * LayoutTests/http/wpt/service-workers/basic-fetch-with-contentfilter.https-expected.txt: Added. * LayoutTests/http/wpt/service-workers/basic-fetch-with-contentfilter.https.html: Added. * LayoutTests/http/wpt/service-workers/basic-fetch-with-contentfilter.js: Added. (doTest): * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::start): (WebKit::NetworkResourceLoader::startRequest): (WebKit::NetworkResourceLoader::startWithServiceWorker): (WebKit::NetworkResourceLoader::requestIsForServiceWorkerOnly): (WebKit::NetworkResourceLoader::serviceWorkerDidNotHandle): (WebKit::NetworkResourceLoader::continueAfterServiceWorkerReceivedData): (WebKit::NetworkResourceLoader::continueAfterServiceWorkerReceivedResponse): (WebKit::NetworkResourceLoader::serviceWorkerDidFinish): * Source/WebKit/NetworkProcess/NetworkResourceLoader.h: * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp: (WebKit::ServiceWorkerFetchTask::processResponse): (WebKit::ServiceWorkerFetchTask::didReceiveData): (WebKit::ServiceWorkerFetchTask::didReceiveDataFromPreloader): (WebKit::ServiceWorkerFetchTask::didFinish): (WebKit::ServiceWorkerFetchTask::loadBodyFromPreloader): * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h: Canonical link: https://commits.webkit.org/260891@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ccb7a: Unreviewed, reverting r260871@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ccb7a2b4b8f9a17b0b3f9474dffdb015091797f https://github.com/WebKit/WebKit/commit/5ccb7a2b4b8f9a17b0b3f9474dffdb015091797f Author: Commit Queue Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/media/media-source/media-managedmse-memorypressure-expected.txt M LayoutTests/media/media-source/media-managedmse-memorypressure.html M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/page/MemoryRelease.cpp Log Message: --- Unreviewed, reverting r260871@main. https://bugs.webkit.org/show_bug.cgi?id=253004 Caused TestWebKitAPI.WebKit.MediaBufferingPolicy to consistently fail Reverted changeset: "ManagedMediaSource content should be evicted whenever it is under memory pressure" https://bugs.webkit.org/show_bug.cgi?id=252938 https://commits.webkit.org/260871@main Canonical link: https://commits.webkit.org/260890@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68c30e: Non-continuous SpeechRecognition returns multiple ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68c30e63bd2664d632c899686f369678e11685a7 https://github.com/WebKit/WebKit/commit/68c30e63bd2664d632c899686f369678e11685a7 Author: Tim Horton Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTask.mm Log Message: --- Non-continuous SpeechRecognition returns multiple results, eventually gets stuck returning the same utterance https://bugs.webkit.org/show_bug.cgi?id=252936 rdar://105898841 Reviewed by Sihui Liu. In non-continuous mode, our SpeechRecognizer behavior differs greatly from other browsers and the spec: it returns multiple results, and returns all utterances from the session in confidence order on each new recognition, resulting in the "most confident" transcript getting "stuck" after a while. * Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTask.mm: (-[WebSpeechRecognizerTaskImpl speechRecognitionTask:didFinishRecognition:]): Explicitly stop the session once we get one recognition result when in non-continuous mode, because this is not communicated to the Speech framework in any other way, so it just keeps happily recognizing. Also, avoid dispatching extraneous recognitions while we're cancelling, or, more importantly, when we're stopping in non-continuous mode. Canonical link: https://commits.webkit.org/260889@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d6d61b: Revert [260410@main] Add support for new flavor in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d6d61bb1b76bbac53b403d217428e65a12c4e2e3 https://github.com/WebKit/WebKit/commit/d6d61bb1b76bbac53b403d217428e65a12c4e2e3 Author: Karl Rackler Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/PlatformJSCOnly.cmake M Source/WTF/wtf/PlatformMac.cmake M Source/WTF/wtf/threads/Signals.cpp Log Message: --- Revert [260410@main] Add support for new flavor in thread_set_exception_ports https://bugs.webkit.org/show_bug.cgi?id=247635 rdar://101307915 Unreviewed revert This reverts because six http/wpt/service-workers/service-worker-spinning tests are a consistent crash. * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/PlatformJSCOnly.cmake: * Source/WTF/wtf/PlatformMac.cmake: * Source/WTF/wtf/threads/Signals.cpp: (WTF::setExceptionPorts): Canonical link: https://commits.webkit.org/260888@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 560cb9: PROGRESSION (260811@main): Failed test 'prependToE...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 560cb981b3f50d2d041a9959a602c19584a314d9 https://github.com/WebKit/WebKit/commit/560cb981b3f50d2d041a9959a602c19584a314d9 Author: Karl Rackler Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Tools/Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl Log Message: --- PROGRESSION (260811@main): Failed test 'prependToEnvironmentVariableList: Debug with FTW' https://bugs.webkit.org/show_bug.cgi?id=253001 rdar://105980986 Reviewed by Ryan Haddad. Fix for webkitperl-test after 260811@main * Tools/Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Canonical link: https://commits.webkit.org/260887@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 65be88: Speech Recognition API terminates after one uttera...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 65be88f6990f6ec48f709473da4e8058fd48682f https://github.com/WebKit/WebKit/commit/65be88f6990f6ec48f709473da4e8058fd48682f Author: Tim Horton Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTask.mm Log Message: --- Speech Recognition API terminates after one utterance or a short time in the open source build https://bugs.webkit.org/show_bug.cgi?id=252921 Reviewed by Sihui Liu. * Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTask.mm: (-[WebSpeechRecognizerTaskImpl initWithIdentifier:locale:doMultipleRecognitions:reportInterimResults:maxAlternatives:delegateCallback:]): These bits of SPI are properly forward declared, so we should use them even for the open source build. Canonical link: https://commits.webkit.org/260886@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d84755: [ iOS Debug ] fast/loader/crash-replacing-location...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d847552014dbd0d8480bbea83a63bb102213ef32 https://github.com/WebKit/WebKit/commit/d847552014dbd0d8480bbea83a63bb102213ef32 Author: Bri Harris Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [ iOS Debug ] fast/loader/crash-replacing-location-before-load.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=251047 rdar://104576815 Unreviewed test gardening. Removing expectations after software change. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/260885@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b48237: [IFC][Partial layout] Do not run partial invalidat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b482371b189c78cd520cddec3f65d56dea5ba48c https://github.com/WebKit/WebKit/commit/b482371b189c78cd520cddec3f65d56dea5ba48c Author: Alan Baradlay Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: A LayoutTests/fast/inline/partial-layout-with-bidi-reordering-crash-expected.txt A LayoutTests/fast/inline/partial-layout-with-bidi-reordering-crash.html M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h Log Message: --- [IFC][Partial layout] Do not run partial invalidation when the new content needs visual reordering https://bugs.webkit.org/show_bug.cgi?id=252935 Reviewed by Antti Koivisto. Partial inline item collection with bidi reordering is not supported yet (bidi reordering works on paragraph level). * LayoutTests/fast/inline/partial-layout-with-bidi-reordering-crash-expected.txt: Added. * LayoutTests/fast/inline/partial-layout-with-bidi-reordering-crash.html: Added. * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterContentChangeFor): * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::contentNeedsVisualReordering const): * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h: Canonical link: https://commits.webkit.org/260884@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/eng/Block-logging-service-in-sandbox Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/eng/Make-Accessibility-work-when-Site-isolation-is-enabled Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/eng/Twitter-is-not-filtered-by-content-filter Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/eng/252880-build-fix Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d13961: Remove old GCC workarounds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d139619c4a1e761411647d6c27b646e81c80c1b7 https://github.com/WebKit/WebKit/commit/d139619c4a1e761411647d6c27b646e81c80c1b7 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/JavaScriptCore/bytecode/InlineAccess.h M Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp M Source/WebCore/bridge/objc/WebScriptObject.mm M Source/WebCore/bridge/objc/objc_instance.mm M Source/WebCore/bridge/objc/objc_runtime.mm Log Message: --- Remove old GCC workarounds https://bugs.webkit.org/show_bug.cgi?id=252898 Reviewed by Michael Catanzaro. GCC is not used to compile Objective-C anymore, and GCC now supports std::max() inside a constexpr function. Source/JavaScriptCore/bytecode/InlineAccess.h: Make sizeForLengthAccess constexpr Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp: Make size constexpr Source/WebCore/bridge/objc/WebScriptObject.mm:(getListFromNSArray:) Remove gcc 3.3 workaround Source/WebCore/bridge/objc/objc_instance.mm: Remove const workarounds Source/WebCore/bridge/objc/objc_runtime.mm: Remove const workaround Canonical link: https://commits.webkit.org/260883@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 151684: [WPE][GTK] Prevent HarfBuzz advance overflow
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1516848f1a9082adedc08b28f53f483ec50c2831 https://github.com/WebKit/WebKit/commit/1516848f1a9082adedc08b28f53f483ec50c2831 Author: Vitaly Dyachkov Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/gtk/TestExpectations M Source/WebCore/rendering/style/RenderStyleConstants.h Log Message: --- [WPE][GTK] Prevent HarfBuzz advance overflow https://bugs.webkit.org/show_bug.cgi?id=229740 Reviewed by Carlos Garcia Campos. When taking the complex text path we get glyph advances by calling `hb_buffer_get_glyph_positions`. HarfBuzz uses `hb_position_t` aka `int32_t` type to store advances and offset, where the first 16 bits are used to store the integer part and the second 16 bits to store the fractional precision part. Since this type is singed we are left with only 15 bits for maximum positive advance value which gives us 32767 or `std::numeric_limits::max()`. Fixes `fast/box-shadow/box-shadow-huge-area-crash.html`. * LayoutTests/platform/gtk/TestExpectations: * Source/WebCore/rendering/style/RenderStyleConstants.h: Canonical link: https://commits.webkit.org/260882@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e96233: [GStreamer][GL] Enable DMABuf sink
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e962336d3261fc58317d3a0e90032e5c900a79e4 https://github.com/WebKit/WebKit/commit/e962336d3261fc58317d3a0e90032e5c900a79e4 Author: Philippe Normand Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp M Tools/Scripts/webkitpy/port/glib.py Log Message: --- [GStreamer][GL] Enable DMABuf sink https://bugs.webkit.org/show_bug.cgi?id=252826 Reviewed by Žan Doberšek and Xabier Rodriguez-Calvar. Unconditionally enable the DMABuf sink when running with GStreamer 1.22 and newer. The WEBKIT_GST_DMABUF_SINK_DISABLED environment variable can be set to fallback to the GL sink. * Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: (webKitDMABufVideoSinkGetProperty): (webKitDMABufVideoSinkIsEnabled): (webKitDMABufVideoSinkProbePlatform): * Tools/Scripts/webkitpy/port/glib.py: (GLibPort.setup_environ_for_server): Canonical link: https://commits.webkit.org/260881@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0fa0f: REGRESSION (258514@main): Transition of !important...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0fa0f2073f1886a7272a69040adaaafde9754fd https://github.com/WebKit/WebKit/commit/e0fa0f2073f1886a7272a69040adaaafde9754fd Author: Antti Koivisto Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/transition-important-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/transition-important.html M Source/WebCore/style/PropertyCascade.cpp M Source/WebCore/style/PropertyCascade.h M Source/WebCore/style/StyleTreeResolver.cpp M Source/WebCore/style/StyleTreeResolver.h Log Message: --- REGRESSION (258514@main): Transition of !important property fails to animate https://bugs.webkit.org/show_bug.cgi?id=111329 rdar://105929421 Reviewed by Antoine Quint. The cascade precedence is (https://drafts.csswg.org/css-cascade-5/#cascade-sort) 1) Transition declarations [css-transitions-1] 2) Important user agent declarations 3) Important user declarations 4) Important author declarations 5) Animation declarations [css-animations-1] 6) Normal author declarations 7) Normal user declarations 8) Normal user agent declarations but we were treating transitions and animations similarly. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/transition-important-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/transition-important.html: Added. * Source/WebCore/style/PropertyCascade.cpp: (WebCore::Style::PropertyCascade::addMatch): (WebCore::Style::PropertyCascade::shouldApplyAfterAnimation): Don't let !important properties override transitions. * Source/WebCore/style/PropertyCascade.h: * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate): Tell the cascade if this is a transition or animation. Note that this is still incorrect in the (rare) case where you would have both running on an element at the same time. (WebCore::Style::TreeResolver::applyCascadeAfterAnimation): * Source/WebCore/style/StyleTreeResolver.h: Canonical link: https://commits.webkit.org/260880@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9dbbb7: Port out-of-line display list items to the new ser...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9dbbb78ff5f144ced7c9091bc09262d84df511d3 https://github.com/WebKit/WebKit/commit/9dbbb78ff5f144ced7c9091bc09262d84df511d3 Author: Gavin Phillips Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make A Source/WebKit/Shared/DisplayListArgumentCoders.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp M Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp Log Message: --- Port out-of-line display list items to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=252895 rdar://105881207 Reviewed by Alex Christensen. Ports the out-of-line display list items to the new serialization format. This includes: - SetState - SetLineDash - ClipOutToPath - ClipPath - ClipPath - DrawGlyphs - DrawSystemImage - DrawLinesForText - DrawPath - DrawFocusRingPath - DrawFocusRingRects - FillRectWithColor - FillRectWithGradient - FillCompositedRect - FillRoundedRect - FillRectWithRoundedHole - FillPath - StrokePath * Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp: (WebCore::DisplayList::DrawLinesForText::DrawLinesForText): (WebCore::DisplayList::FillRectWithGradient::FillRectWithGradient): * Source/WebCore/platform/graphics/displaylists/DisplayListItems.h: (WebCore::DisplayList::DrawGlyphs::fontIdentifier const): (WebCore::DisplayList::DrawGlyphs::positionedGlyphs const): (WebCore::DisplayList::FillRectWithGradient::gradient const): (WebCore::DisplayList::SetState::encode const): Deleted. (WebCore::DisplayList::SetState::decode): Deleted. (WebCore::DisplayList::SetLineDash::encode const): Deleted. (WebCore::DisplayList::SetLineDash::decode): Deleted. (WebCore::DisplayList::ClipOutToPath::encode const): Deleted. (WebCore::DisplayList::ClipOutToPath::decode): Deleted. (WebCore::DisplayList::ClipPath::encode const): Deleted. (WebCore::DisplayList::ClipPath::decode): Deleted. (WebCore::DisplayList::DrawGlyphs::fontIdentifier): Deleted. (WebCore::DisplayList::DrawGlyphs::encode const): Deleted. (WebCore::DisplayList::DrawGlyphs::decode): Deleted. (WebCore::DisplayList::DrawSystemImage::encode const): Deleted. (WebCore::DisplayList::DrawSystemImage::decode): Deleted. (WebCore::DisplayList::DrawLinesForText::encode const): Deleted. (WebCore::DisplayList::DrawLinesForText::decode): Deleted. (WebCore::DisplayList::DrawPath::encode const): Deleted. (WebCore::DisplayList::DrawPath::decode): Deleted. (WebCore::DisplayList::DrawFocusRingPath::encode const): Deleted. (WebCore::DisplayList::DrawFocusRingPath::decode): Deleted. (WebCore::DisplayList::DrawFocusRingRects::encode const): Deleted. (WebCore::DisplayList::DrawFocusRingRects::decode): Deleted. (WebCore::DisplayList::FillRectWithColor::encode const): Deleted. (WebCore::DisplayList::FillRectWithColor::decode): Deleted. (WebCore::DisplayList::FillRectWithGradient::encode const): Deleted. (WebCore::DisplayList::FillRectWithGradient::decode): Deleted. (WebCore::DisplayList::FillCompositedRect::encode const): Deleted. (WebCore::DisplayList::FillCompositedRect::decode): Deleted. (WebCore::DisplayList::FillRoundedRect::encode const): Deleted. (WebCore::DisplayList::FillRoundedRect::decode): Deleted. (WebCore::DisplayList::FillRectWithRoundedHole::encode const): Deleted. (WebCore::DisplayList::FillRectWithRoundedHole::decode): Deleted. (WebCore::DisplayList::FillPath::encode const): Deleted. (WebCore::DisplayList::FillPath::decode): Deleted. (WebCore::DisplayList::StrokePath::encode const): Deleted. (WebCore::DisplayList::StrokePath::decode): Deleted. * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp: (WebCore::DisplayList::RecorderImpl::recordDrawLinesForText): * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp: (WebKit::RemoteDisplayListRecorderProxy::recordDrawLinesForText): * Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/260879@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b831bf: Allow fixed width integer types as bit fields
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b831bf8d6468696e8854fc8da2c24d426342eb86 https://github.com/WebKit/WebKit/commit/b831bf8d6468696e8854fc8da2c24d426342eb86 Author: Tadeu Zagallo Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Tools/Scripts/webkitpy/style/checkers/cpp.py M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py Log Message: --- Allow fixed width integer types as bit fields https://bugs.webkit.org/show_bug.cgi?id=252475 rdar://105593556 Reviewed by David Kilzer. Currently, the style checker complains about uint8_t and friends as bit fields, claiming that it's not an unsigned integral type. This patch updates the rule to accept all intN_t and uintN_t types. * Tools/Scripts/webkitpy/style/checkers/cpp.py: (check_language): * Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest): Canonical link: https://commits.webkit.org/260878@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 214c2f: Update WebGL conformance tests 2023-02-26 (c8f07b5...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 214c2ffd0b7a7b13dfa186b75dd154d1fa508910 https://github.com/WebKit/WebKit/commit/214c2ffd0b7a7b13dfa186b75dd154d1fa508910 Author: Kimmo Kinnunen Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: A LayoutTests/webgl/1.0.x/conformance/extensions/ext-polygon-offset-clamp-expected.txt A LayoutTests/webgl/1.0.x/conformance/extensions/ext-polygon-offset-clamp.html A LayoutTests/webgl/1.0.x/conformance/textures/misc/texture-srgb-upload-expected.txt A LayoutTests/webgl/1.0.x/conformance/textures/misc/texture-srgb-upload.html A LayoutTests/webgl/2.0.y/conformance/extensions/ext-polygon-offset-clamp-expected.txt A LayoutTests/webgl/2.0.y/conformance/extensions/ext-polygon-offset-clamp.html A LayoutTests/webgl/2.0.y/conformance/textures/misc/texture-srgb-upload-expected.txt A LayoutTests/webgl/2.0.y/conformance/textures/misc/texture-srgb-upload.html A LayoutTests/webgl/2.0.y/conformance2/glsl3/texture-bias-expected.txt A LayoutTests/webgl/2.0.y/conformance2/glsl3/texture-bias.html A LayoutTests/webgl/resources/webgl_test_files/conformance/extensions/ext-polygon-offset-clamp.html A LayoutTests/webgl/resources/webgl_test_files/conformance/textures/misc/texture-srgb-upload.html A LayoutTests/webgl/resources/webgl_test_files/conformance2/glsl3/texture-bias.html Log Message: --- Update WebGL conformance tests 2023-02-26 (c8f07b53c6e56b0f52a62daafd1951859ce255cc) https://bugs.webkit.org/show_bug.cgi?id=252979 rdar://105964744 Unreviewed, imported from upstream. * LayoutTests/webgl/1.0.x/conformance/extensions/ext-polygon-offset-clamp-expected.txt: Added. * LayoutTests/webgl/1.0.x/conformance/extensions/ext-polygon-offset-clamp.html: Added. * LayoutTests/webgl/1.0.x/conformance/textures/misc/texture-srgb-upload-expected.txt: Added. * LayoutTests/webgl/1.0.x/conformance/textures/misc/texture-srgb-upload.html: Added. * LayoutTests/webgl/2.0.y/conformance/extensions/ext-polygon-offset-clamp-expected.txt: Added. * LayoutTests/webgl/2.0.y/conformance/extensions/ext-polygon-offset-clamp.html: Added. * LayoutTests/webgl/2.0.y/conformance/textures/misc/texture-srgb-upload-expected.txt: Added. * LayoutTests/webgl/2.0.y/conformance/textures/misc/texture-srgb-upload.html: Added. * LayoutTests/webgl/2.0.y/conformance2/glsl3/texture-bias-expected.txt: Added. * LayoutTests/webgl/2.0.y/conformance2/glsl3/texture-bias.html: Added. * LayoutTests/webgl/resources/webgl_test_files/conformance/extensions/ext-polygon-offset-clamp.html: Added. * LayoutTests/webgl/resources/webgl_test_files/conformance/textures/misc/texture-srgb-upload.html: Added. * LayoutTests/webgl/resources/webgl_test_files/conformance2/glsl3/texture-bias.html: Added. Canonical link: https://commits.webkit.org/260877@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2c65a3: [MSE] Make input argument to canPlayThroughRange()...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c65a39b4fd6b58315b59850c81f7f836c8eb018 https://github.com/WebKit/WebKit/commit/2c65a39b4fd6b58315b59850c81f7f836c8eb018 Author: Alicia Boya Garcia Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/Modules/mediasource/SourceBuffer.cpp M Source/WebCore/Modules/mediasource/SourceBuffer.h Log Message: --- [MSE] Make input argument to canPlayThroughRange() const https://bugs.webkit.org/show_bug.cgi?id=252894 Reviewed by Xabier Rodriguez-Calvar. Arguments passed by reference without const are generally assumed to be output arguments. This is not the case here. This patch fixes it. * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::canPlayThroughRange): * Source/WebCore/Modules/mediasource/SourceBuffer.h: Canonical link: https://commits.webkit.org/260876@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] afe779: REGRESSION(260082@main): [GStreamer][1.20] YT broken
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: afe779a29470fc44ec35e7aff6aa68a541e651d5 https://github.com/WebKit/WebKit/commit/afe779a29470fc44ec35e7aff6aa68a541e651d5 Author: Philippe Normand Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp Log Message: --- REGRESSION(260082@main): [GStreamer][1.20] YT broken https://bugs.webkit.org/show_bug.cgi?id=252958 Reviewed by Xabier Rodriguez-Calvar. In 260082@main we made the MSE source element act as an adaptive stream, triggering a different code path in urisourcebin, that turned out to be broken in GStreamer versions older than 1.22 and triggering caps negotiation errors during typefinding in urisourcebin. The commit that fixed this in GStreamer 1.22 is too big for backporting, so fallback to previous behavior in runtimes older than 1.22. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElement): * Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp: (webkit_media_src_class_init): * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: (webkit_media_stream_src_class_init): Canonical link: https://commits.webkit.org/260875@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cbbc16: [JSC] Fix unnecessary moves in read/modify assignment
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cbbc1673e3e58028002cea7b245a42672ba2daa4 https://github.com/WebKit/WebKit/commit/cbbc1673e3e58028002cea7b245a42672ba2daa4 Author: Tadeu Zagallo Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/JavaScriptCore/parser/ASTBuilder.h Log Message: --- [JSC] Fix unnecessary moves in read/modify assignment https://bugs.webkit.org/show_bug.cgi?id=252902 Reviewed by Yusuke Suzuki. When generating bytecode for read/modify assignments, e.g. `x += y`, we have to guard against the right-hand side modifying the variables (e.g. `x += y[x=z]` or `x += y[y=z]`). In order to do so, the variables are copied after reading. We detect whether there are assignments on the left- and right-hand sides by recording the number of assignments the code contains at three points: before and after parsing the left-hand side and after parsing the right-hand side expression. We then check if the values before and after parsing the left are equal to determine if it contains any assignments on the left, and compare the values after parsing the left and after parsing the right. However, we never take into account that we are actively parsing an assignment, so the values after parsing the left-hand side and after parsing the right-hand side could never be the same. The fix is to simply take into account the assignment we just parsed, so we say the right doesn't contain any assignments if after parsing the right-hand side expression we have 1 more assingment than after parsing the left-hand side expression. * Source/JavaScriptCore/parser/ASTBuilder.h: (JSC::ASTBuilder::createAssignment): Canonical link: https://commits.webkit.org/260874@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f9e2e1: [GStreamer][MediaStream] Unify stream collection h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f9e2e16a6e8d7899cefb934c5a33f98015be0bb2 https://github.com/WebKit/WebKit/commit/f9e2e16a6e8d7899cefb934c5a33f98015be0bb2 Author: Philippe Normand Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.h Log Message: --- [GStreamer][MediaStream] Unify stream collection handling with MSE https://bugs.webkit.org/show_bug.cgi?id=252815 Reviewed by Xabier Rodriguez-Calvar. Both the MSE and mediastream source elements now post their stream collection in a similar fashion. The custom mediastream tags handling was removed too, I don't know why that was needed in the first place. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage): (WebCore::MediaPlayerPrivateGStreamer::naturalSize const): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: (mediaStreamTrackPrivateGetTags): (webkitMediaStreamNew): (WebKitMediaStreamObserver::didRemoveTrack): (webkitMediaStreamSrcChangeState): (webkitMediaStreamSrcChain): (webkitMediaStreamSrcPostStreamCollection): (webkitMediaStreamSrcEnsureStreamCollectionPosted): (webkitMediaStreamSrcAddTrack): (webkitMediaStreamSrcSetStream): * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.h: Canonical link: https://commits.webkit.org/260873@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 05b9d3: [JSC] Avoid unnecessary move in FunctionCallResolv...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05b9d3d37cb2fd7b34bd0724b1e039891710825b https://github.com/WebKit/WebKit/commit/05b9d3d37cb2fd7b34bd0724b1e039891710825b Author: Tadeu Zagallo Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- [JSC] Avoid unnecessary move in FunctionCallResolveNode https://bugs.webkit.org/show_bug.cgi?id=252912 rdar://105887432 Reviewed by Yusuke Suzuki. When generating bytecode for FunctionCallResolveNode, if the target function is a local variable, we don't need to move it into a new temporary unless there's an assignment in the call arguments. E.g. we need to copy `f` for `f(f=x)`, but not for `f(x)`. * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallResolveNode::emitBytecode): Canonical link: https://commits.webkit.org/260872@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa6272: Cherry-pick 260550@main (c9e0b19e65ac). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: fa62729cfbdcd04125da541ee3bdaba526eacc10 https://github.com/WebKit/WebKit/commit/fa62729cfbdcd04125da541ee3bdaba526eacc10 Author: Tadeu Zagallo Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/dom/EventListener.h Log Message: --- Cherry-pick 260550@main (c9e0b19e65ac). https://bugs.webkit.org/show_bug.cgi?id=252567 [WebCore] Shrink EventListener https://bugs.webkit.org/show_bug.cgi?id=252567 rdar://105679210 Reviewed by Chris Dumez. Reduce the size of `WebCore::EventListener` from 32 to 24 bytes by reordering the super classes and reducing the size of the `Type` enum. This in turn reduces the size of `JSEventListener` to 48 bytes, bringing it to next size class down. * Source/WebCore/dom/EventListener.h: Canonical link: https://commits.webkit.org/260550@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fee371: ManagedMediaSource content should be evicted whene...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fee371950f6239d24a6734e461dfcedd4a1daa8a https://github.com/WebKit/WebKit/commit/fee371950f6239d24a6734e461dfcedd4a1daa8a Author: Jean-Yves Avenard Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/media/media-source/media-managedmse-memorypressure-expected.txt M LayoutTests/media/media-source/media-managedmse-memorypressure.html M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/page/MemoryRelease.cpp Log Message: --- ManagedMediaSource content should be evicted whenever it is under memory pressure https://bugs.webkit.org/show_bug.cgi?id=252938 rdar://105908445 Reviewed by Youenn Fablet. Let the MediaElement control when eviction under memory pressure should occur. * LayoutTests/media/media-source/media-managedmse-memorypressure-expected.txt: * LayoutTests/media/media-source/media-managedmse-memorypressure.html: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::purgeBufferedDataIfPossible): * Source/WebCore/page/MemoryRelease.cpp: (WebCore::releaseCriticalMemory): Canonical link: https://commits.webkit.org/260871@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ff556: Under memory pressure, non active SourceBuffers sh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ff5566a514b479065e34a377acd3f6a00173417 https://github.com/WebKit/WebKit/commit/6ff5566a514b479065e34a377acd3f6a00173417 Author: Jean-Yves Avenard Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: A LayoutTests/media/media-source/media-managedmse-memorypressure-inactive-expected.txt A LayoutTests/media/media-source/media-managedmse-memorypressure-inactive.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp M Source/WebCore/platform/graphics/SourceBufferPrivate.h M Source/WebCore/platform/graphics/TrackBuffer.cpp M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h Log Message: --- Under memory pressure, non active SourceBuffers should be completely emptied https://bugs.webkit.org/show_bug.cgi?id=252957 rdar://105940463 Reviewed by Youenn Fablet. Fully clear all track buffers of a non active source buffer as it's not currently playing. * LayoutTests/media/media-source/media-managedmse-memorypressure-inactive-expected.txt: Added. * LayoutTests/media/media-source/media-managedmse-memorypressure-inactive.html: Added. * LayoutTests/platform/glib/TestExpectations: Memory Pressure handler isn't set on these platforms. * Source/WebCore/platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::clearTrackBuffers): (WebCore::SourceBufferPrivate::memoryPressure): (WebCore::SourceBufferPrivate::removeCodedFrames): Fly by fix, ensure m_client is set. * Source/WebCore/platform/graphics/SourceBufferPrivate.h: * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp: (WebKit::SourceBufferPrivateRemote::clearTrackBuffers): * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h: Canonical link: https://commits.webkit.org/260870@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 236631: [GLib] Make webkit://gpu output exportable as JSON
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2366316b2b5ea71666021cfe241698ef590f44e7 https://github.com/WebKit/WebKit/commit/2366316b2b5ea71666021cfe241698ef590f44e7 Author: Philippe Normand Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp Log Message: --- [GLib] Make webkit://gpu output exportable as JSON https://bugs.webkit.org/show_bug.cgi?id=252960 Reviewed by Adrian Perez de Castro. The webkit://gpu HTML tables are now generated from an internal JSON payload that can be copied to clipboard at runtime. The goal is to ease information sharing between bug reporters and maintainers. * Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp: (WebKit::WebKitProtocolHandler::handleGPU): Canonical link: https://commits.webkit.org/260869@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5cd01f: AX: Wrong role displayed for input in Safari inspe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5cd01f201aba0badba296cecd95fd077c5e64819 https://github.com/WebKit/WebKit/commit/5cd01f201aba0badba296cecd95fd077c5e64819 Author: Tyler Wilcock Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M LayoutTests/accessibility/mac/active-descendant-with-aria-controls-expected.txt M LayoutTests/accessibility/mac/relationships-in-frames-expected.txt M LayoutTests/accessibility/roles-computedRoleString.html M LayoutTests/platform/glib/accessibility/aria-visible-element-roles-expected.txt M LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt M LayoutTests/platform/gtk/inspector/dom/getAccessibilityPropertiesForNode-expected.txt M LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt M LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt M LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt M LayoutTests/platform/wpe/accessibility/aria-visible-element-roles-expected.txt M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityNodeObject.h M Source/WebCore/accessibility/AccessibilityObject.cpp Log Message: --- AX: Wrong role displayed for input in Safari inspector https://bugs.webkit.org/show_bug.cgi?id=250124 rdar://problem/103907008 Reviewed by Chris Fleizach. This bug occurred because gAriaReverseRoleMap had no mapping for AccessibilityRole::TextField, meaning that when Web Inspector called AccessibilityObject::computedRoleString() for some types of input elements we would return an empty string. This necessitated some changes to AccessibilityNodeObject::determineAriaRoleAttribute() to avoid mapping text inputs (which are inherently single-line) to the WebCore AccessibilityRole::TextArea role. * LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt: * LayoutTests/accessibility/mac/active-descendant-with-aria-controls-expected.txt: * LayoutTests/accessibility/mac/relationships-in-frames-expected.txt: The role="textbox" element in these tests has contenteditable, making it a multi-line input. With this patch, we now properly compute it to have a role of AXTextArea instead of AXTextField. * LayoutTests/accessibility/roles-computedRoleString.html: * LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt: * LayoutTests/platform/glib/accessibility/aria-visible-element-roles-expected.txt: * LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: * LayoutTests/platform/gtk/inspector/dom/getAccessibilityPropertiesForNode-expected.txt: * LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt: * LayoutTests/platform/wpe/accessibility/aria-visible-element-roles-expected.txt: Update expectations now that various input type elements map to a role. * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::matchesTextAreaRole const): Added. (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const): (WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const): * Source/WebCore/accessibility/AccessibilityNodeObject.h: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::initializeRoleMap): Map "textbox" role to AccessibilityRole::TextField to match other browsers. Canonical link: https://commits.webkit.org/260868@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 074120: Add tests to make sure confirm/prompt work from cr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07412048195177731c9cc21937bd440add942d1d https://github.com/WebKit/WebKit/commit/07412048195177731c9cc21937bd440add942d1d Author: Chirag M Shah Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm M Tools/TestWebKitAPI/cocoa/TestUIDelegate.h M Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm Log Message: --- Add tests to make sure confirm/prompt work from cross-origin iframes with site isolation. https://bugs.webkit.org/show_bug.cgi?id=252923 rdar://99897405 Reviewed by Alex Christensen. alert/confirm/prompt dialogs are expected to work from cross-origin iframes with site isolation. We already tests that alert works, but this change adds tests for confirm/prompt as well. * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/cocoa/TestUIDelegate.h: * Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm: (-[TestUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]): (-[TestUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]): (-[TestUIDelegate waitForConfirm]): (-[TestUIDelegate waitForPromptWithDefaultInput:]): (-[WKWebView _test_waitForConfirm]): (-[WKWebView _test_waitForPromptWithDefaultInput:]): Canonical link: https://commits.webkit.org/260867@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f1cb9: REGRESSION (260781@main): [iOS] TestWebKitAPI.Font...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f1cb9750c4d8b376bcb35de57729f53af0ff833 https://github.com/WebKit/WebKit/commit/3f1cb9750c4d8b376bcb35de57729f53af0ff833 Author: Myles C. Maxfield Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/WebCore/editing/cocoa/FontAttributeChangesCocoa.mm M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h Log Message: --- REGRESSION (260781@main): [iOS] TestWebKitAPI.FontAttributes.FontTextStyle is consistently failing https://bugs.webkit.org/show_bug.cgi?id=252916 rdar://105891055 Reviewed by Wenson Hsieh. This was caused by the logic in FontChanges::platformFontFamilyNameForCSS(). When a font change occurs, the FontChanges object represents it with 2 fields: m_fontName and m_fontFamily. The purpose of FontChanges::platformFontFamilyNameForCSS() is to determine what value should be supplied to the font-family CSS property, to represent the change. The logic in that function is: Prefer using m_fontFamily, but only if round-tripping the font family through our font selection logic would end up creating the same font that's specified by m_fontName. In the previous sentence, the phrase "the same font" is implemented by comparing PostScript name. If round-tripping the font creates a different font than m_fontName, use m_fontName directly. However, when the font changes to a text style font, m_fontName is ".SFUI-Regular" and m_fontFamily is "UICTFontTextStyleTitle1". FontChanges::platformFontFamilyNameForCSS() was finding that round-tripping the family through our font selection code was no longer producing a font with the exact same postscript name as ".SFUI-Regular", and was therefore implementing the font change by specifying "font-family: .SFUI-Regular" instead of "font-family: UICTFontTextStyleTitle1". Ever since 240717@main, dot-prefixed fonts intentionally don't work in WebKit, so "font-family: .SFUI-Regular" was causing the test to fail. Our round-tripping code wasn't producing a font with the exact same name as ".SFUI-Regular" because it was instead producing a font with the name ".SFUI-Regular_wdth_opsz_GRAD_wght1F4". This font name _means_ the same thing as the original, but it's a synthesized name that Core Text created. Eventually, we should migrate this check to be more robust. However, a more straightforward solution is to just react to the fact that dot-prefixed fonts intentionally don't work in WebKit, and therefore FontChanges::platformFontFamilyNameForCSS() should just not return a dot-prefixed font name. This is more defensive than changing the font equality check, and it's also easier to implement. If there are behavior changes in content, those behavior changes would be to make more fonts work as requested. * Source/WebCore/editing/cocoa/FontAttributeChangesCocoa.mm: (WebCore::FontChanges::platformFontFamilyNameForCSS const): * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::fontNameIsSystemFont): * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h: Canonical link: https://commits.webkit.org/260866@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
