[webkit-changes] [WebKit/WebKit] 20a06e: [WGSL] Don't compute size and alignment for struct...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20a06e254bc94121f60dba1db7a4bed90380890d https://github.com/WebKit/WebKit/commit/20a06e254bc94121f60dba1db7a4bed90380890d Author: Tadeu Zagallo Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp Log Message: --- [WGSL] Don't compute size and alignment for structs that shouldn't be packed https://bugs.webkit.org/show_bug.cgi?id=257122 rdar://109658987 Reviewed by Dan Glastonbury. Structs that shouldn't be packed might contain types for which we don't compute size and alignment, so we shouldn't try to compute it. * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::visit): Canonical link: https://commits.webkit.org/264406@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 604943: Respond to review feedback on 264230@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 604943662b19bcc8b4720b2b4bfe90af4a4ac86f https://github.com/WebKit/WebKit/commit/604943662b19bcc8b4720b2b4bfe90af4a4ac86f Author: Simon Fraser Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm Log Message: --- Respond to review feedback on 264230@main https://bugs.webkit.org/show_bug.cgi?id=257167 rdar://109685883 Unreviewed fix. Respond to review comment on https://github.com/WebKit/WebKit/pull/14050, using a WTF_REQUIRES_LOCK() annotation. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::didCommitTree): Canonical link: https://commits.webkit.org/264405@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 650c69: [PlayStation] Start RemoteInspectorServer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 650c693e1678cb6f0fd0a31353f959ab204473eb https://github.com/WebKit/WebKit/commit/650c693e1678cb6f0fd0a31353f959ab204473eb Author: Haruhisa SHIN Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/API/JSRemoteInspectorServer.cpp M Tools/MiniBrowser/playstation/main.cpp Log Message: --- [PlayStation] Start RemoteInspectorServer https://bugs.webkit.org/show_bug.cgi?id=256576 Reviewed by Devin Rousso and Fujii Hironori. The MiniBrowser starts RemoteInspectorServer. Also, fixed build error when ENABLE_REMOTE_INSPECTOR is OFF. * Source/JavaScriptCore/API/JSRemoteInspectorServer.cpp: (JSRemoteInspectorServerStart): * Tools/MiniBrowser/playstation/main.cpp: (initialize): Canonical link: https://commits.webkit.org/264404@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c45236: [macOS] WebProcess names in Activity Monitor canno...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c452365a271afb1e06bbce644c0da0948188783a https://github.com/WebKit/WebKit/commit/c452365a271afb1e06bbce644c0da0948188783a Author: Chris Dumez Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm Log Message: --- [macOS] WebProcess names in Activity Monitor cannot include non-Latin1 characters https://bugs.webkit.org/show_bug.cgi?id=257179 rdar://109691473 Reviewed by Alex Christensen. We are sending the application name as UTF-8 over XPC like so: ``` xpc_dictionary_set_string(bootstrapMessage.get(), "ui-process-name", [[[NSProcessInfo processInfo] processName] UTF8String]); ``` But we were decoding it as Latin1 instead of UTF-8 on the recipient side. This was the cause of the bug. * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm: (WebKit::XPCServiceInitializerDelegate::getClientProcessName): Canonical link: https://commits.webkit.org/264403@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f01494: Fix Safari macOS/iOS high speed audio/video algorithm
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f01494f3adc77374f4935bae8aca1125b083a26b https://github.com/WebKit/WebKit/commit/f01494f3adc77374f4935bae8aca1125b083a26b Author: Jer Noble Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp Log Message: --- Fix Safari macOS/iOS high speed audio/video algorithm https://bugs.webkit.org/show_bug.cgi?id=191053 rdar://103940613 Reviewed by Eric Carlson. The default values for `PitchCorrectionAlgorithm` in `UnifiedWebPreferences.yaml` are not being propogated across the process boundary to the GPU process. Additionally, MediaPlayerPrivateMediaSourceAVFObjC is ignoring the setting entirely and just doing its own thing. Move the existing utility function `audioTimePitchAlgorithmForMediaPlayerPitchCorrectionAlgorithm()` from MediaPlayerPrivateAVFoundationObjC.mm into MediaSessionManagerCocoa.mm. Then use that utility method in `MediaPlayerPrivateMediaSourceAVFObjC` instead of hard-coding "Spectral" vs. "Varispeed". `MediaPlayerPrivateRemote` will only explicitly send a message to `RemoteMediaPlayerProxy` when `setPitchCorrectionAlgorithm()` is called, which means in the general case that the GPU process never receives the correct pitch correction algorithm setting. Include `PitchCorrectionAlgorithm` in the list of values passed to `RemoteMediaPlayerProxy` in `prepareForPlayback()`. Canonical link: https://commits.webkit.org/264402@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9eadb9: Remove SubframePageProxy and associated processes ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9eadb9b6c14f00e9d345a22ea725b74fc36b17a4 https://github.com/WebKit/WebKit/commit/9eadb9b6c14f00e9d345a22ea725b74fc36b17a4 Author: Alex Christensen Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/UIProcess/SubframePageProxy.h M Source/WebKit/UIProcess/WebFrameProxy.cpp M Source/WebKit/UIProcess/WebFrameProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Remove SubframePageProxy and associated processes when no longer used https://bugs.webkit.org/show_bug.cgi?id=257166 rdar://105024979 Reviewed by Chris Dumez. A SubframePageProxy needs to keep track of how many frames are using it, and when that number hits zero it needs to be deleted. This sounds a lot like reference counting. Make it RefCounted and change its ownership to the WebFrameProxy. The WebPageProxy still needs to keep a map of RegistrableDomain to SubframePageProxy to be able to reuse the same process for multiple iframes, but this map can keep weak references. * Source/WebKit/UIProcess/SubframePageProxy.h: (WebKit::SubframePageProxy::create): * Source/WebKit/UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::commitProvisionalFrame): (WebKit::WebFrameProxy::setSubframePageProxy): * Source/WebKit/UIProcess/WebFrameProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateRemoteFrameSize): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::addSubframePageProxy): (WebKit::WebPageProxy::removeSubpageFrameProxyIfUnused): (WebKit::WebPageProxy::subpageFrameProxyForRegistrableDomain const): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/264401@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca484a: [Cocoa] Playback is paused after scrubbing with to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca484addbacdec7e84b87023f410498bc6da8613 https://github.com/WebKit/WebKit/commit/ca484addbacdec7e84b87023f410498bc6da8613 Author: Eric Carlson Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/platform/mac/WebPlaybackControlsManager.mm Log Message: --- [Cocoa] Playback is paused after scrubbing with touch bar https://bugs.webkit.org/show_bug.cgi?id=257177 rdar://109523926 Reviewed by Jer Noble. * Source/WebCore/platform/mac/WebPlaybackControlsManager.mm: (-[WebPlaybackControlsManager setPlaying:]): Don't send a remote playback command to the model if is already in the correct state. Canonical link: https://commits.webkit.org/264400@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df4fd0: Simplify Compression Streams Large Flush Output Te...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df4fd08173e18981947d97aafd6efde8dee4db5c https://github.com/WebKit/WebKit/commit/df4fd08173e18981947d97aafd6efde8dee4db5c Author: Brandon Stewart Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any.js Log Message: --- Simplify Compression Streams Large Flush Output Test Logic https://bugs.webkit.org/show_bug.cgi?id=257159 Reviewed by Tim Nguyen. Remove a lot of the hand written code to handle the concatinating of output together. This was already handled in the concatenate-stream.js. Also fix Tim's comments in WPT. * LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any.js: (async compressData): (promise_test.async t): Canonical link: https://commits.webkit.org/264399@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a75a4: Remove serialization keyword NoForwardDeclaration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a75a47bd571b5ae5f0d7dd16527883ed80bb772 https://github.com/WebKit/WebKit/commit/6a75a47bd571b5ae5f0d7dd16527883ed80bb772 Author: Alex Christensen Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Remove serialization keyword NoForwardDeclaration https://bugs.webkit.org/show_bug.cgi?id=257145 rdar://109672374 Reviewed by Sihui Liu. It's not needed and slows down the build. Use [Nested] instead because the one place it is used is for a nested class. * Source/WebKit/Scripts/generate-serializers.py: (SerializedType.__init__): (alias_struct_or_class): (generate_header): (generate_impl): (parse_serialized_types): (generate_headers_for_header): Deleted. * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/264398@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb5a5f: Notifications API: default silent to platform conv...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb5a5fbce2e993ee60fbb3046b6e6c03693b49a0 https://github.com/WebKit/WebKit/commit/bb5a5fbce2e993ee60fbb3046b6e6c03693b49a0 Author: Marcos Caceres Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/interfaces/notifications.idl M LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https.html M Source/WebCore/Modules/notifications/Notification.h M Source/WebCore/Modules/notifications/Notification.idl M Source/WebCore/Modules/notifications/NotificationOptions.idl M Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm Log Message: --- Notifications API: default silent to platform convention https://bugs.webkit.org/show_bug.cgi?id=256828 rdar://109390045 Reviewed by Brady Eidson. Makes the silent member on the NotificationOption dictionary default to null. This is then reflected by the silent attribute of the Notification interface. Spec change: https://github.com/whatwg/notifications/pull/194 * LayoutTests/imported/w3c/web-platform-tests/interfaces/notifications.idl: * LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https.html: * Source/WebCore/Modules/notifications/Notification.h: * Source/WebCore/Modules/notifications/Notification.idl: * Source/WebCore/Modules/notifications/NotificationOptions.idl: Canonical link: https://commits.webkit.org/264397@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4722fd: [JHBuild] Add libsoup3 to moduleset
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4722fd366aca21fbdec110f043bcb66e36b72ef8 https://github.com/WebKit/WebKit/commit/4722fd366aca21fbdec110f043bcb66e36b72ef8 Author: Diego Pino Garcia Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Tools/gtk/jhbuild.modules M Tools/jhbuild/jhbuild-minimal.modules M Tools/jhbuild/jhbuildrc_common.py R Tools/jhbuild/patches/libsoup-lower-glib-dependency-to-2.38.patch M Tools/wpe/jhbuild.modules Log Message: --- [JHBuild] Add libsoup3 to moduleset https://bugs.webkit.org/show_bug.cgi?id=256356 Reviewed by Adrian Perez de Castro. The libsoup2 module has been removed from the moduleset since even the oldest system supported at this moment (Debian 11) provides a more up-to-date version of libsoup2 than the one listed in the moduleset. Define environment flag 'JHBUILD_USE_SOUP2=ON' to skip provisioning of libsoup3 and build using libsoup2 instead. * Tools/gtk/jhbuild.modules: * Tools/jhbuild/jhbuild-minimal.modules: * Tools/jhbuild/jhbuildrc_common.py: * Tools/jhbuild/patches/libsoup-lower-glib-dependency-to-2.38.patch: Removed. * Tools/wpe/jhbuild.modules: Canonical link: https://commits.webkit.org/264396@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 497729: [GLIB] Fix build error after 264196@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4977290ab4ab35258a6da9b13795c9b0f7894bf4 https://github.com/WebKit/WebKit/commit/4977290ab4ab35258a6da9b13795c9b0f7894bf4 Author: Diego Pino Garcia Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WTF/wtf/glib/Sandbox.cpp Log Message: --- [GLIB] Fix build error after 264196@main https://bugs.webkit.org/show_bug.cgi?id=256917 Reviewed by Michael Catanzaro. Variable BWRAP_EXECUTABLE is only defined when BUBBLEWRAP_SANDBOX is enabled. * Source/WTF/wtf/glib/Sandbox.cpp: (WTF::isInsideUnsupportedContainer): Canonical link: https://commits.webkit.org/264395@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c4bd0c: Build fix for Swift Overlay change
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4bd0caa50b90692d2c59e41b17d12fa67c2374f https://github.com/WebKit/WebKit/commit/c4bd0caa50b90692d2c59e41b17d12fa67c2374f Author: Brady Eidson Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/SwiftOverlay/WebKitSwiftOverlay.xcodeproj/project.pbxproj Log Message: --- Build fix for Swift Overlay change https://bugs.webkit.org/show_bug.cgi?id=257171 rdar://109687568 Unreviewed. * Source/WebKit/SwiftOverlay/WebKitSwiftOverlay.xcodeproj/project.pbxproj: Fix error in the catalyst version of the new script step. Canonical link: https://commits.webkit.org/264394@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7128c7: [GTK] Hook up prefers-contrast media query on GTK3
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7128c7a8144c5d486ab1dd3ac4b74f59b33a9de3 https://github.com/WebKit/WebKit/commit/7128c7a8144c5d486ab1dd3ac4b74f59b33a9de3 Author: Patrick Griffis Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/css/query/MediaQueryFeatures.cpp M Source/WebCore/platform/adwaita/ThemeAdwaita.cpp M Source/WebCore/platform/adwaita/ThemeAdwaita.h Log Message: --- [GTK] Hook up prefers-contrast media query on GTK3 https://bugs.webkit.org/show_bug.cgi?id=256436 Reviewed by Michael Catanzaro. This implements the prefers-contrast media query on the GTK3 port by relying on gtk-theme-name. * Source/WebCore/css/query/MediaQueryFeatures.cpp: (WebCore::MQ::Features::prefersContrast): * Source/WebCore/platform/adwaita/ThemeAdwaita.cpp: (WebCore::ThemeAdwaita::ThemeAdwaita): (WebCore::ThemeAdwaita::refreshGtkSettings): (WebCore::ThemeAdwaita::userPrefersContrast const): * Source/WebCore/platform/adwaita/ThemeAdwaita.h: Canonical link: https://commits.webkit.org/264393@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 73dd09: Unreviewed, reverting 264265@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 73dd0916a142193a105d0c88fd6906ac06cd4b2a https://github.com/WebKit/WebKit/commit/73dd0916a142193a105d0c88fd6906ac06cd4b2a Author: Commit Queue Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/builtins/BuiltinExecutables.cpp M Source/JavaScriptCore/builtins/BuiltinExecutables.h M Source/JavaScriptCore/builtins/BuiltinNames.cpp M Source/JavaScriptCore/builtins/BuiltinNames.h M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/JSString.h M Source/JavaScriptCore/runtime/SmallStrings.cpp M Source/JavaScriptCore/runtime/SmallStrings.h M Source/JavaScriptCore/runtime/VM.cpp M Source/WTF/wtf/CompactPtr.h M Source/WTF/wtf/Threading.cpp M Source/WTF/wtf/URL.cpp M Source/WTF/wtf/spi/cocoa/MachVMSPI.h M Source/WTF/wtf/text/AtomString.cpp M Source/WTF/wtf/text/AtomString.h M Source/WTF/wtf/text/AtomStringImpl.cpp M Source/WTF/wtf/text/AtomStringImpl.h M Source/WTF/wtf/text/StringImpl.cpp M Source/WTF/wtf/text/StringImpl.h M Source/WTF/wtf/text/SymbolImpl.cpp M Source/WTF/wtf/text/SymbolImpl.h M Source/WTF/wtf/text/UniquedStringImpl.h M Source/WTF/wtf/text/WTFString.cpp M Source/WTF/wtf/text/WTFString.h M Source/WebCore/bindings/scripts/StaticString.pm M Source/WebCore/css/CSSFontFaceSet.cpp M Source/WebCore/css/CSSFontSelector.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/make_names.pl M Source/WebCore/platform/graphics/FontCascadeFonts.cpp M Source/WebCore/style/StyleResolveForFontRaw.cpp M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm M Tools/TestWebKitAPI/Tests/WTF/JSONValue.cpp M Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp M Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp M Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm Log Message: --- Unreviewed, reverting 264265@main. https://bugs.webkit.org/show_bug.cgi?id=257174 0.7% iOS RAMification regression Reverted changeset: "Remove static strings and symbols" https://bugs.webkit.org/show_bug.cgi?id=256744 https://commits.webkit.org/264265@main Canonical link: https://commits.webkit.org/264392@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0975f: [JSC] Check OOM in JSC shell btoa / atob functions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0975fe50c3160d17a7f759053f12c0fac68939b https://github.com/WebKit/WebKit/commit/f0975fe50c3160d17a7f759053f12c0fac68939b Author: Yusuke Suzuki Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A JSTests/stress/atob-btoa-oom-check.js M Source/JavaScriptCore/jsc.cpp Log Message: --- [JSC] Check OOM in JSC shell btoa / atob functions https://bugs.webkit.org/show_bug.cgi?id=257165 rdar://109401358 Reviewed by Mark Lam and Keith Miller. Check OOM. JSString::value can throw an error. We should just use toWTFString to obtain String. * JSTests/stress/atob-btoa-oom-check.js: Added. * Source/JavaScriptCore/jsc.cpp: (JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/264391@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3201e5: [JSC] Early return in microtask draining when term...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3201e5f5a718fc241b820adb575455d2e3bc9b95 https://github.com/WebKit/WebKit/commit/3201e5f5a718fc241b820adb575455d2e3bc9b95 Author: Yusuke Suzuki Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A JSTests/stress/exception-check-unhandled-promise-rejection-in-shell.js M Source/JavaScriptCore/runtime/VM.cpp Log Message: --- [JSC] Early return in microtask draining when termination happens https://bugs.webkit.org/show_bug.cgi?id=257163 rdar://109401883 Reviewed by Mark Lam. This is Debug only, JSC shell only issue. Early returning from microtask draining when termination happens. * JSTests/stress/exception-check-unhandled-promise-rejection-in-shell.js: Added. (async foo): * Source/JavaScriptCore/runtime/VM.cpp: (JSC::VM::didExhaustMicrotaskQueue): (JSC::VM::drainMicrotasks): Canonical link: https://commits.webkit.org/264390@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6483fe: AX: Cache Horizontal and Vertical ScrollBars only ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6483fe30062855f62f031b201e9e7888c1b1a70d https://github.com/WebKit/WebKit/commit/6483fe30062855f62f031b201e9e7888c1b1a70d Author: Andres Gonzalez Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm Log Message: --- AX: Cache Horizontal and Vertical ScrollBars only for ScrollViews in AXIsolatedObject initialization. https://bugs.webkit.org/show_bug.cgi?id=257140 Reviewed by Tyler Wilcock. The Horizontal/VericalSrollBar properties are only exposed for ScrollViews, so no need to cache it for any other AXIsolatedObject. In addition, this patch includes a correction for patch in https://bugs.webkit.org/show_bug.cgi?id=257045 that missed to undo the change to cache RelativeFrames for Scrollbars. * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeProperties): * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): Canonical link: https://commits.webkit.org/264389@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e8ee7: Re-import css/css-fonts WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e8ee79b8b481c2aeac3eeb9099540e39e97a263 https://github.com/WebKit/WebKit/commit/5e8ee79b8b481c2aeac3eeb9099540e39e97a263 Author: Tim Nguyen Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-size-adjust-composition-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-size-adjust-composition.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-style-interpolation-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-style-interpolation.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-variation-settings-composition-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-variation-settings-composition.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/cjk-kerning-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/cjk-kerning.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/discrete-no-interpolation-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/discrete-no-interpolation.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-colorization-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-colorization-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-colorization.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-features-two-stylesheets-crash.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-language-override-02-expected-mismatch.html R LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected.html R LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-empty-font-family-notref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-empty-font-family-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-empty-font-family.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-shorthand-subproperties-reset-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-shorthand-subproperties-reset.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-order-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-order-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-order-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-units-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-units-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-units-001.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-synthesis-style-first-letter-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-synthesis-style-first-letter-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-synthesis-style-first-letter.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-synthesis-weight-first-letter-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-synthesis-weight-first-letter-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-synthesis-weight-first-letter.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-19-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-19-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-19.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-layers-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-layers-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-layers.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-emoji-1-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-emoji-1-notref.html A LayoutTests/imp
[webkit-changes] [WebKit/WebKit] e660f9: Fix IDL generation after 264293@main when MODERN_M...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e660f99575ec73b90472c4050dd6eb76c17bb569 https://github.com/WebKit/WebKit/commit/e660f99575ec73b90472c4050dd6eb76c17bb569 Author: mokjasmine Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl Log Message: --- Fix IDL generation after 264293@main when MODERN_MEDIA_CONTROLS is off https://bugs.webkit.org/show_bug.cgi?id=257168 Reviewed by Don Olmstead. Guard `SourceType` with a `MODERN_MEDIA_CONTROLS` conditional. * Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl: Canonical link: https://commits.webkit.org/264387@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 21a4b1: [iOS] REGRESSION (264028@main): Memory regression
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 21a4b1c5559f6ddda3f3c4166e5ab33cab2c475d https://github.com/WebKit/WebKit/commit/21a4b1c5559f6ddda3f3c4166e5ab33cab2c475d Author: Brent Fulgham Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- [iOS] REGRESSION (264028@main): Memory regression https://bugs.webkit.org/show_bug.cgi?id=257126 Reviewed by Per Arne Vollan. Relaxing the iOS GPU Process Sandbox in Bug 256728 had the unintended effect of increasing memory use. Since blocking this call didn't create any functional issues, but regressed memory, we will instead silence the logging to avoid flooding telemetry with irrelevant logging. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/264386@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e3871: Remove WebPageProxy's frameIdentifierToDomainMap
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e38712a375b60ca1407802fbfe9d66f299b8dd5 https://github.com/WebKit/WebKit/commit/3e38712a375b60ca1407802fbfe9d66f299b8dd5 Author: Alex Christensen Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/WebProcessPool.cpp Log Message: --- Remove WebPageProxy's frameIdentifierToDomainMap https://bugs.webkit.org/show_bug.cgi?id=257146 rdar://109673536 Reviewed by Chris Dumez. It is an unnecessary map, and it adds more bookkeeping. We aren't cleaning up after frames navigate, and this is a step towards that. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateRemoteFrameSize): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::addSubframePageProxy): (WebKit::WebPageProxy::subframePageProxyForFrameID const): Deleted. (WebKit::WebPageProxy::addSubframePageProxyForFrameID): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): Canonical link: https://commits.webkit.org/264385@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 348235: [import-w3c-tests] Make --clean-dest-dir work with...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 348235605fd930951b703860d93c3af15066998f https://github.com/WebKit/WebKit/commit/348235605fd930951b703860d93c3af15066998f Author: Sam Sneddon Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Tools/Scripts/webkitpy/w3c/test_importer.py M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py Log Message: --- [import-w3c-tests] Make --clean-dest-dir work with partial imports https://bugs.webkit.org/show_bug.cgi?id=256751 Reviewed by Jonathan Bedard. We need to do this slightly more lazily, and not just blanket clean the entire destination directory. Fix updating resource-files.json to write the file even if we aren't importing new support files, as might be true of a partial import. And finally fix removing items from tests-options.json to match against the correct path, and avoid mutating the object we're iterating over (which raises an RuntimeError). * Tools/Scripts/webkitpy/w3c/test_importer.py: (TestImporter.__init__): (TestImporter.do_import): (TestImporter.import_tests): (TestImporter.remove_slow_from_w3c_tests_options): * Tools/Scripts/webkitpy/w3c/test_importer_unittest.py: Canonical link: https://commits.webkit.org/264384@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7e5ac4: Make it possible to hard-code touch point radius
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7e5ac4506822fab82a65230a1cc9a679369fe99f https://github.com/WebKit/WebKit/commit/7e5ac4506822fab82a65230a1cc9a679369fe99f Author: Tim Horton Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm Log Message: --- Make it possible to hard-code touch point radius https://bugs.webkit.org/show_bug.cgi?id=257147 rdar://109067957 Reviewed by Megan Gardner, Wenson Hsieh and Aditya Keerthi. * Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm: (WebKit::convertTouchType): (WebKit::radiusForTouchPoint): (WebKit::NativeWebTouchEvent::extractWebTouchPoint): Add a build flag that allows fixing the touch point radius. Drive-by remove some staging. Canonical link: https://commits.webkit.org/264383@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2ec9c: Network connection integrity policies are missing ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2ec9c11767361af98d651ab55ba2028b3d1ff4b https://github.com/WebKit/WebKit/commit/c2ec9c11767361af98d651ab55ba2028b3d1ff4b Author: Wenson Hsieh Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Tools/TestWebKitAPI/cocoa/HTTPServer.h M Tools/TestWebKitAPI/cocoa/HTTPServer.mm Log Message: --- Network connection integrity policies are missing when connecting via https://bugs.webkit.org/show_bug.cgi?id=257096 rdar://107356544 Reviewed by Tim Horton. Add logic to set network connection integrity policy flags when sending a network request triggered by a link element with `rel=preconnect`. See below for more details. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _networkProcessIdentifier]): Add a testing hook that returns the network process PID, for use in a new (internal) API test. * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::policySourceDocumentLoaderForFrame): Pull existing logic for grabbing a suitable `DocumentLoader` for a given frame out of `addParametersShared` and into a separate helper function, so that we can use it in multiple places. (WebKit::addParametersShared): (WebKit::WebLoaderStrategy::preconnectTo): Use the new helper function above to populate network connection integrity flags on the outbound resource load when handling preconnect. * Tools/TestWebKitAPI/cocoa/HTTPServer.h: * Tools/TestWebKitAPI/cocoa/HTTPServer.mm: (TestWebKitAPI::HTTPServer::totalConnections const): Add a helper method on the mock HTTP server to return the total connection count. Canonical link: https://commits.webkit.org/264382@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8792d3: WebKitSwiftOverlay should (once again) include a W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8792d34445e2d3f82cf7d6039409d483d9ebcdab https://github.com/WebKit/WebKit/commit/8792d34445e2d3f82cf7d6039409d483d9ebcdab Author: Brady Eidson Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/SwiftOverlay/WebKitSwiftOverlay.xcodeproj/project.pbxproj Log Message: --- WebKitSwiftOverlay should (once again) include a WebKitAdditions overlay https://bugs.webkit.org/show_bug.cgi?id=257046 rdar://109674033 Reviewed by Tim Horton. Informal review by James Savage. Include WebKitAdditionsSwiftOverlay from a well known location. * Source/WebKit/SwiftOverlay/WebKitSwiftOverlay.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/264381@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 69433a: [IFC] Move InlineIterator::TextBox::offsetForPosit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 69433a69fa7fd5b35f4aa706354b03649becb984 https://github.com/WebKit/WebKit/commit/69433a69fa7fd5b35f4aa706354b03649becb984 Author: Alan Baradlay Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.h M Source/WebCore/rendering/LegacyInlineTextBox.cpp M Source/WebCore/rendering/RenderText.cpp Log Message: --- [IFC] Move InlineIterator::TextBox::offsetForPosition to RenderText https://bugs.webkit.org/show_bug.cgi?id=257076 Reviewed by Antti Koivisto. * Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp: (WebCore::InlineIterator::TextBox::offsetForPosition const): Deleted. * Source/WebCore/layout/integration/inline/InlineIteratorTextBox.h: * Source/WebCore/rendering/LegacyInlineTextBox.cpp: (WebCore::LegacyInlineTextBox::placeEllipsisBox): * Source/WebCore/rendering/RenderText.cpp: (WebCore::offsetForPositionInRun): (WebCore::RenderText::positionForPoint): Canonical link: https://commits.webkit.org/264380@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e31b49: [image-set] Re-import WPT changes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e31b4971569eed571c0d339f2038432b45a9bed8 https://github.com/WebKit/WebKit/commit/e31b4971569eed571c0d339f2038432b45a9bed8 Author: Ryan Reno Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-negative-resolution-rendering-3-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-negative-resolution-rendering-3.html M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-type-first-match-rendering.html M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-zero-resolution-rendering-2-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-zero-resolution-rendering-2.html M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-zero-resolution-rendering-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-zero-resolution-rendering.html M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/w3c-import.log Log Message: --- [image-set] Re-import WPT changes https://bugs.webkit.org/show_bug.cgi?id=257128 rdar://109664556 Reviewed by Tim Nguyen. Re-import changes to upstream image-set WPT as of upstream commit ba004353155163b0c356b753394e50d2dd6f0b87 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-negative-resolution-rendering-3-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-negative-resolution-rendering-3.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-type-first-match-rendering.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-zero-resolution-rendering-2-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-zero-resolution-rendering-2.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-zero-resolution-rendering-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-zero-resolution-rendering.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/w3c-import.log: Canonical link: https://commits.webkit.org/264379@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7093bc: Cherry-pick 264244@main (a84036c6d1d6). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: 7093bcb6d649597962c82fd0e9a92d329ba8fb48 https://github.com/WebKit/WebKit/commit/7093bcb6d649597962c82fd0e9a92d329ba8fb48 Author: Carlos Alberto Lopez Perez Date: 2023-05-20 (Sat, 20 May 2023) Changed paths: M Source/cmake/BubblewrapSandboxChecks.cmake M Tools/yocto/targets.conf Log Message: --- Cherry-pick 264244@main (a84036c6d1d6). https://bugs.webkit.org/show_bug.cgi?id=251835 [WPE][GTK][CMake] The path to bwrap and xdg-dbus-proxy should not be auto-detected when cross-compiling https://bugs.webkit.org/show_bug.cgi?id=256679 Reviewed by Adrian Perez de Castro. When enabling -DENABLE_BUBBLEWRAP_SANDBOX=ON is needed to define to the build the paths (full-paths) to the bwrap and xdg-dbus-proxy binaries. The current CMake code is auto-detecting those paths by calling the CMake function find_program(): so it is defining the paths to those programs with the values from the host system. But when cross-compiling that is wrong because the target binaries end with the values for the paths from the host system which don't necessary have to match the values from the target system. I can't see how it will be possible to auto-detect the value that this programs will have in the target system from the host system, so the only sane way of dealing with this seems to be to give an error at configure time and ask for those paths to be defined manually. This patch changes the code to only try to auto-detect those binaries when no cross-compiling. Also update the default build parameters for the cross-building of targets with cross-toolchain-helper to define the right paths that those targets will have at run-time. * Source/cmake/BubblewrapSandboxChecks.cmake: * Tools/yocto/targets.conf: Canonical link: https://commits.webkit.org/264244@main Commit: 8e4517d1d5e1ee00e8e410f27796b1cba50dc5f0 https://github.com/WebKit/WebKit/commit/8e4517d1d5e1ee00e8e410f27796b1cba50dc5f0 Author: Patrick Griffis Date: 2023-05-20 (Sat, 20 May 2023) Changed paths: M Source/WTF/wtf/glib/Sandbox.cpp M Source/WTF/wtf/glib/Sandbox.h M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp Log Message: --- Cherry-pick 264196@main (4c39f3875728). https://bugs.webkit.org/show_bug.cgi?id=256917 [GLib] Re-enable bwrap sandbox in containers when supported https://bugs.webkit.org/show_bug.cgi?id=256917 Reviewed by Michael Catanzaro. This detects if bwrap actually works inside of a container instead of always disabling it. * Source/WTF/wtf/glib/Sandbox.cpp: (WTF::isInsideUnsupportedContainer): (WTF::isInsideContainer): Deleted. * Source/WTF/wtf/glib/Sandbox.h: * Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp: (WebKit::ProcessLauncher::launchProcess): Canonical link: https://commits.webkit.org/264196@main Commit: 521133306268084f6a6d9367b7a1cf4d15b1fd6a https://github.com/WebKit/WebKit/commit/521133306268084f6a6d9367b7a1cf4d15b1fd6a Author: Chirag M Shah Date: 2023-05-20 (Sat, 20 May 2023) Changed paths: A LayoutTests/fullscreen/element-clear-during-fullscreen-crash-expected.txt A LayoutTests/fullscreen/element-clear-during-fullscreen-crash.html M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp Log Message: --- Cherry-pick 259548.352@safari-7615-branch (9f301d9e042e). https://bugs.webkit.org/show_bug.cgi?id=253129 Bail out early if m_element is deleted https://bugs.webkit.org/show_bug.cgi?id=253129 rdar://104290899 Reviewed by Jer Noble. A call to WebFullScreenManager::willEnterFullScreen() can end up calling WebFullScreenManager::clearElement() which can happen when location.hash is changed. This clears the m_element which is then later used in willEnterFullScreen(). This change bails out early if this happens and cleans up the state-machine. * LayoutTests/fullscreen/element-clear-during-fullscreen-crash-expected.txt: Added. * LayoutTests/fullscreen/element-clear-during-fullscreen-crash.html: Added. * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::willEnterFullScreen): Canonical link: https://commits.webkit.org/259548.352@safari-7615-branch Commit: ffc8ffc4b0d337d53425b2806d6e66012bcad21a https://github.com/WebKit/WebKit/commit/ffc8ffc4b0d337d53425b2806d6e66012bcad21a Author: Chirag M Shah Date: 2023-05-20 (Sat, 20 May 2023) Changed paths: A LayoutTests/fast/html/element-moving-to-new-document-crash-expected.txt A LayoutTests/fast/html/element-moving-to-new-document-crash.html M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/UserActionElementSet.cpp M Source/WebCore/dom/UserActionElemen
[webkit-changes] [WebKit/WebKit] 365d91: Fix syntax error in merchant-validation.php on web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 365d91ad2c52506f5ad014bf54777becf6bd5875 https://github.com/WebKit/WebKit/commit/365d91ad2c52506f5ad014bf54777becf6bd5875 Author: Alex Zenla Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Websites/webkit.org/demos/payment-request/merchant-validation.php Log Message: --- Fix syntax error in merchant-validation.php on webkit.org https://bugs.webkit.org/show_bug.cgi?id=256998 Reviewed by Alexey Proskuryakov. This fixes a syntax error present in the merchant-validation.php backend. * Websites/webkit.org/demos/payment-request/merchant-validation.php: Fix a syntax error around error handling in a curl request. Canonical link: https://commits.webkit.org/264378@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d523e: Avoid blocking logd with sandbox state flag
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d523edc586116d30a82c28e10b32372dec6824f https://github.com/WebKit/WebKit/commit/0d523edc586116d30a82c28e10b32372dec6824f Author: Per Arne Vollan Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Avoid blocking logd with sandbox state flag https://bugs.webkit.org/show_bug.cgi?id=257129 rdar://108267763 Reviewed by Brent Fulgham. Avoid blocking logd with sandbox state flag, since that appears to have some performance impact. Instead, use the 'apple-internal' modifier in the sandbox. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::initializeLogd): (WebKit::XPCServiceEventHandler): (WebKit::blockLogdInSandbox): Deleted. * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/264377@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 99eac4: Teach TextBreakIterator about strict and loose lin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99eac467073eccfa5ff272ce4c8212273b2c1040 https://github.com/WebKit/WebKit/commit/99eac467073eccfa5ff272ce4c8212273b2c1040 Author: Myles C. Maxfield Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WTF/wtf/text/LineBreakIteratorPoolICU.h M Source/WTF/wtf/text/TextBreakIterator.cpp M Source/WTF/wtf/text/TextBreakIterator.h M Source/WTF/wtf/text/WTFString.h M Source/WTF/wtf/text/cocoa/TextBreakIteratorInternalICUCocoa.cpp M Source/WTF/wtf/text/icu/TextBreakIteratorICU.h M Source/WebCore/platform/graphics/ComplexTextController.cpp M Source/WebCore/platform/graphics/ComposedCharacterClusterTextIterator.h M Source/WebCore/rendering/RenderText.cpp M Tools/TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp Log Message: --- Teach TextBreakIterator about strict and loose line breaking behaviors https://bugs.webkit.org/show_bug.cgi?id=257108 rdar://109634206 Reviewed by Cameron McCormack. This is the first part of our line breaker refactoring. We currently have 2 totally separate classes, both of which can perform line breaking: TextBreakIterator and LazyLineBreakIterator. TextBreakIterator has multiple backends - it can be backed by either ICU or Core Foundation. It also supports all kinds of text segmentation: caret positions, grapheme cluster segmentation, etc. LazyLineBreakIterator only works with ICU, and can only do line breaking. However, it supports loose and strict line breaking modes, and supports a "prior context." It's kind of a shame that we have 2 classes which both do similar things, so I'm going to try to unify them into a single class which can do everything. I'd like to improve TextBreakIterator to be able to do everything that LazyLineBreakIterator can do, and then delete LazyLineBreakIterator, because I think that's going to be the most straightforward way of doing it. This patch teaches TextBreakIterator about the different line breaking behaviors, by turning the "mode" enum into a variant, and giving the Line struct a behavior enum. * Source/WTF/wtf/text/TextBreakIterator.cpp: (WTF::mapModeToBackingIterator): * Source/WTF/wtf/text/TextBreakIterator.h: (WTF::TextBreakIterator::LineMode::operator== const): (WTF::TextBreakIterator::CaretMode::operator== const): (WTF::TextBreakIterator::DeleteMode::operator== const): (WTF::TextBreakIterator::CharacterMode::operator== const): (WTF::LazyLineBreakIterator::get): (WTF::TextBreakIteratorCache::TextBreakIteratorCache): Deleted. * Source/WTF/wtf/text/WTFString.h: (WTF::StringLiterals::operator _str): * Source/WTF/wtf/text/cocoa/TextBreakIteratorInternalICUCocoa.cpp: (WTF::mapModeToBackingIterator): * Source/WTF/wtf/text/icu/TextBreakIteratorICU.h: (WTF::TextBreakIteratorICU::TextBreakIteratorICU): (WTF::TextBreakIteratorICU::makeLocaleWithBreakKeyword): * Source/WebCore/platform/graphics/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition): (WebCore::ComplexTextController::collectComplexTextRuns): * Source/WebCore/platform/graphics/ComposedCharacterClusterTextIterator.h: (WebCore::ComposedCharacterClusterTextIterator::ComposedCharacterClusterTextIterator): * Source/WebCore/rendering/RenderText.cpp: (WebCore::RenderText::previousOffset const): (WebCore::RenderText::previousOffsetForBackwardDeletion const): (WebCore::RenderText::nextOffset const): * Tools/TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/264376@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 752217: [ANGLE] UBO convert only whole block
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 752217c5a3e5a505e30d85337034756ab682e0f1 https://github.com/WebKit/WebKit/commit/752217c5a3e5a505e30d85337034756ab682e0f1 Author: Dan Glastonbury Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm Log Message: --- [ANGLE] UBO convert only whole block rdar://106964250 Reviewed by Dean Jackson. OpenGL doesn't guarantee that the buffer backing uniform blocks needs to be a multiple of the block size. When converting OpenGL layout blocks to Metal layout, ConvertUniformBufferData is rounding up the size of the backing buffer to a multiple of the block size which leads to reading out of bounds. To ensure we don't read outside the source buffer, this change replaces calls to `memcpy` with `memcpy_guarded` which accepts a pointer to the limit of available data and copies as much data as is available, writing zeroes for any unavailable amount. Conversion of bools didn't use memcpy, so the raw pointer is checked against maxSrcPtr and only dereferenced if valid, otherwise zero is used. This has been tested with ASan and UBSan enabled against the OpenGL dEQP tests for Uniform Buffer Objects in ANGLE. * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm: Originally-landed-as: 259548.667@safari-7615-branch (4aa8750579fb). rdar://106964250 Canonical link: https://commits.webkit.org/264375@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 028635: Move the save icon SVG to mask-image
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02863595fea348b8af80a9b2e2168cb9c50836a8 https://github.com/WebKit/WebKit/commit/02863595fea348b8af80a9b2e2168cb9c50836a8 Author: Gerald Squelart Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt M LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt M Source/WebCore/html/shadow/attachmentElementShadow.css Log Message: --- Move the save icon SVG to mask-image https://bugs.webkit.org/show_bug.cgi?id=256777 rdar://108621346 Reviewed by Tim Nguyen. This makes it possible to use a semantic color as background, which will be correctly updated when the system light/dark mode changes. And resize the icon, and use the bold version, to be closer to the specs. Also unset the save button background-color inherited from the standard button CSS, which was having an impact on other colors. * LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt: * LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt: * Source/WebCore/html/shadow/attachmentElementShadow.css: (button#attachment-save-button): (div#attachment-save-icon): Canonical link: https://commits.webkit.org/264374@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f56d3: Ensure that tagArrayPtr's size diversifier's top 1...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f56d3ddcc282e02236742bdd1a8e24e1c5f94e1 https://github.com/WebKit/WebKit/commit/2f56d3ddcc282e02236742bdd1a8e24e1c5f94e1 Author: Mark Lam Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/assembler/testmasm.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/WTF/wtf/PtrTag.h Log Message: --- Ensure that tagArrayPtr's size diversifier's top 16 bits are always 0. https://bugs.webkit.org/show_bug.cgi?id=255475 rdar://107724053 Reviewed by Justin Michaud. On ARM64, sizes never exceed 48 bits anyway. This also ensures that the signed values will not conflict with the namespace of other data pointers signed with the same PAC key. * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::zeroExtend48ToWord): * Source/JavaScriptCore/assembler/testmasm.cpp: (JSC::testZeroExtend48ToWord): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::emitNewTypedArrayWithSize): * Source/WTF/wtf/PtrTag.h: (WTF::tagArrayPtr): (WTF::retagArrayPtr): Originally-landed-as: 259548.636@safari-7615-branch (a45dfa3dc3d4). rdar://107724053 Canonical link: https://commits.webkit.org/264373@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2875a: Fix crash when innerTextElement() can be null when...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2875a3ad7ac0693e0853f58d7884c85345f89a1 https://github.com/WebKit/WebKit/commit/f2875a3ad7ac0693e0853f58d7884c85345f89a1 Author: Chirag M Shah Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/rendering/render-text-control-crash-with-designmode-off-expected.txt A LayoutTests/fast/rendering/render-text-control-crash-with-designmode-off.html M Source/WebCore/rendering/RenderTextControl.cpp M Source/WebCore/rendering/RenderTextControlSingleLine.cpp Log Message: --- Fix crash when innerTextElement() can be null when designMode="off" https://bugs.webkit.org/show_bug.cgi?id=255423 rdar://107985448 Reviewed by Antti Koivisto. This change guards against innerTextElement() being null. The file already checked for this in some places, but it wasn't consistent. * LayoutTests/fast/rendering/render-text-control-crash-with-designmode-off-expected.txt: Added. * LayoutTests/fast/rendering/render-text-control-crash-with-designmode-off.html: Added. * Source/WebCore/rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockLogicalWidth const): (WebCore::RenderTextControl::computeLogicalHeight const): (WebCore::RenderTextControl::computeIntrinsicLogicalWidths const): * Source/WebCore/rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth const): Originally-landed-as: 259548.635@safari-7615-branch (064579d997ae). rdar://107985448 Canonical link: https://commits.webkit.org/264372@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 46ea28: [GPUP][CoreIPC] Integer overflow in SharedVideoFra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46ea28d672831cac886966dd100c4bfe4d9ae418 https://github.com/WebKit/WebKit/commit/46ea28d672831cac886966dd100c4bfe4d9ae418 Author: Youenn Fablet Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/ipc/shared-video-frame-size-expected.txt A LayoutTests/ipc/shared-video-frame-size.html M Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm Log Message: --- [GPUP][CoreIPC] Integer overflow in SharedVideoFrameInfo::storageSize leading to OOB read rdar://107023292 Reviewed by Eric Carlson. Compute with safeMultitply/safeAdd the total size of the frame. If there is an overflow, we now fail the decoding of SharedVideoFrameInfo. Covered by provided IPC test. * LayoutTests/ipc/shared-video-frame-size-expected.txt: Added. * LayoutTests/ipc/shared-video-frame-size.html: Added. * Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm: (WebCore::SharedVideoFrameInfo::storageSize const): (WebCore::SharedVideoFrameInfo::decode): Originally-landed-as: 259548.597@safari-7615-branch (7811f6f9e18f). rdar://107023292 Canonical link: https://commits.webkit.org/264371@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb7a56: untagArrayPtr() should do validation if FPAC is no...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb7a5657ea12cf9077f082fa243c40fa3244dd5c https://github.com/WebKit/WebKit/commit/fb7a5657ea12cf9077f082fa243c40fa3244dd5c Author: Mark Lam Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h Log Message: --- untagArrayPtr() should do validation if FPAC is not available, not the other way around. https://bugs.webkit.org/show_bug.cgi?id=255136 rdar://107739543 Reviewed by Yusuke Suzuki and Justin Michaud. The current code erroneously tests for the inverted condition. * Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h: (JSC::MacroAssemblerARM64E::untagArrayPtr): (JSC::MacroAssemblerARM64E::untagArrayPtrLength64): Originally-landed-as: 259548.592@safari-7615-branch (61fa810ab89d). rdar://107739543 Canonical link: https://commits.webkit.org/264370@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9d7925: CDMPrivateFairPlayStreaming parsing of WebCore::IS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d792587594f2ea0714bdf233d63c6dbf7e060d1 https://github.com/WebKit/WebKit/commit/9d792587594f2ea0714bdf233d63c6dbf7e060d1 Author: Arunsundar Kannan Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/http/tests/media/fairplay/fps-init-data-cenc-oob-crash-expected.txt A LayoutTests/http/tests/media/fairplay/fps-init-data-cenc-oob-crash.html M Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.cpp Log Message: --- CDMPrivateFairPlayStreaming parsing of WebCore::ISOFairPlayStreamingKeyRequestInfoBox can trigger an OOB read. https://bugs.webkit.org/show_bug.cgi?id=255075 rdar://103843976 Reviewed by Jer Noble. ISOFairPlayStreamingKeyRequestInfoBox::parse is missing basic bounds checking before memcpy. This change add the check. * LayoutTests/http/tests/media/fairplay/fps-init-data-cenc-oob-crash-expected.txt: Added. * LayoutTests/http/tests/media/fairplay/fps-init-data-cenc-oob-crash.html: Added. * Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.cpp: (WebCore::ISOFairPlayStreamingKeyRequestInfoBox::parse): (WebCore::ISOFairPlayStreamingKeyAssetIdBox::parse): (WebCore::ISOFairPlayStreamingKeyContextBox::parse): Originally-landed-as: 259548.588@safari-7615-branch (3f8875488cf5). rdar://103843976 Canonical link: https://commits.webkit.org/264369@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] faae30: v2: CrashTracer: com.apple.WebKit.Networking at Ja...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: faae309df854b228ebf98ab1f9593b1c98d9eaab https://github.com/WebKit/WebKit/commit/faae309df854b228ebf98ab1f9593b1c98d9eaab Author: Sihui Liu Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.h Log Message: --- v2: CrashTracer: com.apple.WebKit.Networking at JavaScriptCore: WTF::StringImpl::hashSlowCase const rdar://106965632 Reviewed by Youenn Fablet and Ryosuke Niwa. Moving a lambda might involve copying its captured variables. According to crash trace, recordInfos (Vector) captured by didReadRecordFiles is copied when running on the WorkQueue of CacheStorageDiskStore (com.apple.WebKit.CacheStorageCache). This is an issue as CacheStorageRecordInformation is not thread-safe. To avoid this, we now replace the lambda with CompletionHandler, which has a more definitive move behavior that does not involves copy. * Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp: (WebKit::CacheStorageDiskStore::readAllRecordInfosInternal): (WebKit::CacheStorageDiskStore::readAllRecordInfos): (WebKit::CacheStorageDiskStore::readRecordsInternal): (WebKit::CacheStorageDiskStore::readRecords): * Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.h: Originally-landed-as: 259548.577@safari-7615-branch (3679790c14ce). rdar://106965632 Canonical link: https://commits.webkit.org/264368@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c31488: Potential OOB Read in ISOProtectionSystemSpecificH...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c31488496881035b30feee2217f4640a6c71e18b https://github.com/WebKit/WebKit/commit/c31488496881035b30feee2217f4640a6c71e18b Author: Arunsundar Kannan Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp Log Message: --- Potential OOB Read in ISOProtectionSystemSpecificHeaderBox::parse(...). https://bugs.webkit.org/show_bug.cgi?id=254931. rdar://107441432 Reviewed by Jer Noble. There is a potential OOB access in ISOProtectionSystemSpecificHeaderBox::parse when we do memcpy without a bounds check. This adds a bounds check to prevent such access. * Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp: (WebCore::ISOProtectionSystemSpecificHeaderBox::parse): Originally-landed-as: 259548.574@safari-7615-branch (0c76eb21f2d8). rdar://107441432 Canonical link: https://commits.webkit.org/264367@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4899da: Fix equals() for GlyphDisplayListCacheEntryHash
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4899da4a450aca002aebb22cb19b4d1437e48eab https://github.com/WebKit/WebKit/commit/4899da4a450aca002aebb22cb19b4d1437e48eab Author: Chirag M Shah Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/rendering/glyph-display-list-cache-crash-expected.txt A LayoutTests/fast/rendering/glyph-display-list-cache-crash.html M Source/WebCore/rendering/GlyphDisplayListCache.h Log Message: --- Fix equals() for GlyphDisplayListCacheEntryHash https://bugs.webkit.org/show_bug.cgi?id=254941 rdar://107416408 Reviewed by Cameron McCormack. This change fixes a heap use after free in GlyphDisplayListCache, which happens when the destructor of GlyphDisplayListCacheEntry tries to remove this from the HashSet. The change fixes the security issue by correcting the equal() implementation, which now only checks for pointer equality. * LayoutTests/fast/rendering/glyph-display-list-cache-crash-expected.txt: Added. * LayoutTests/fast/rendering/glyph-display-list-cache-crash.html: Added. * Source/WebCore/rendering/GlyphDisplayListCache.h: (WebCore::GlyphDisplayListCacheEntryHash::equal): Originally-landed-as: 259548.555@safari-7615-branch (707d4fb8838c). rdar://107416408 Canonical link: https://commits.webkit.org/264366@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 698c6e: [JSC] RegExpGlobalData::performMatch issue leading...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 698c6e293734c3c46f223b77d5b4ee48b320e32c https://github.com/WebKit/WebKit/commit/698c6e293734c3c46f223b77d5b4ee48b320e32c Author: Michael Saboff Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A JSTests/stress/string-replace-regexp-matchBOL-correct-advancing.js M Source/JavaScriptCore/runtime/StringPrototype.cpp M Source/JavaScriptCore/yarr/YarrInterpreter.cpp Log Message: --- [JSC] RegExpGlobalData::performMatch issue leading to OOB read https://bugs.webkit.org/show_bug.cgi?id=254930 rdar://107436732 Reviewed by Alexey Shvayka. Fixed two issues: 1) In YarrInterpreter.cpp::matchAssertionBOL() we were advancing the string position for non-BMP characters. Since it is an assertion, we shouldn't advance the character position. Made the same fix to matchAssertionEOL(). 2) In StringPrototype.cpp::replaceUsingRegExpSearch(), we need to advance past both elements of a non-BMP character for the case where the RegExp match is empty. * JSTests/stress/string-replace-regexp-matchBOL-correct-advancing.js: New test. * Source/JavaScriptCore/runtime/StringPrototype.cpp: (JSC::replaceUsingRegExpSearch): * Source/JavaScriptCore/yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::InputStream::readCheckedDontAdvance): (JSC::Yarr::Interpreter::matchAssertionBOL): (JSC::Yarr::Interpreter::matchAssertionEOL): Originally-landed-as: 259548.551@safari-7615-branch (e34edaa74575). rdar://107436732 Canonical link: https://commits.webkit.org/264365@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5c059a: CDMPrivateFairPlayStreaming parsing of WebCore::IS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c059ab32c26d642874354e3be0f8802d8e71e1b https://github.com/WebKit/WebKit/commit/5c059ab32c26d642874354e3be0f8802d8e71e1b Author: Arunsundar Kannan Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/http/tests/media/fairplay/fps-init-data-sinf-oob-crash-expected.txt A LayoutTests/http/tests/media/fairplay/fps-init-data-sinf-oob-crash.html M Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.cpp Log Message: --- CDMPrivateFairPlayStreaming parsing of WebCore::ISOTrackEncryptionBox can lead to a heap-buffer-overflow. https://bugs.webkit.org/show_bug.cgi?id=254781. rdar://103849722 Reviewed by Jer Noble. WebCore::ISOTrackEncryptionBox::parse() is missing basic bounds checking before memcpy. This change add the check. * LayoutTests/http/tests/media/fairplay/fps-init-data-sinf-oob-crash-expected.txt: Added. * LayoutTests/http/tests/media/fairplay/fps-init-data-sinf-oob-crash.html: Added. * Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.cpp: (WebCore::ISOTrackEncryptionBox::parse): Originally-landed-as: 259548.536@safari-7615-branch (8320a5247c74). rdar://103849722 Canonical link: https://commits.webkit.org/264364@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85fd23: Potential use-after-free in WebAnimation::commitSt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85fd2302d16a09a82d9a6e81eb286babb23c4b3c https://github.com/WebKit/WebKit/commit/85fd2302d16a09a82d9a6e81eb286babb23c4b3c Author: Antoine Quint Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/animation/WebAnimation.cpp Log Message: --- Potential use-after-free in WebAnimation::commitStyles https://bugs.webkit.org/show_bug.cgi?id=254840 rdar://107444873 Reviewed by Dean Jackson and Darin Adler. Ensure that the animation's effect and target are kept alive for the duration of this method since it is possible that calling updateStyleIfNeeded() could call into JavaScript and thus these two pointers could be changed to a null value using the Web Animations API. * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::commitStyles): Originally-landed-as: 259548.532@safari-7615-branch (1d6fe184ea53). rdar://107444873 Canonical link: https://commits.webkit.org/264363@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c3bc98: Fix spanner reset logic
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3bc98d2edafe692e7aa90fa8d6c188e4c7b0168 https://github.com/WebKit/WebKit/commit/c3bc98d2edafe692e7aa90fa8d6c188e4c7b0168 Author: Rob Buis Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/multicol/crash-when-constructing-nested-columns2-expected.txt A LayoutTests/fast/multicol/crash-when-constructing-nested-columns2.html M Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp Log Message: --- Fix spanner reset logic https://bugs.webkit.org/show_bug.cgi?id=245374 rdar://98438399 Reviewed by Alan Baradlay. In restoreColumnSpannersForContainer we want to reset the spanners to their original position and remove the placeholders, however in some cases the attach step will call multiColumnDescendantInserted and re-insert placeholders. To fix this, prevent calling the spanner processing logic by multiColumnDescendantInserted by introducing a new flag gRestoringColumnSpannersForContainer. * LayoutTests/fast/multicol/crash-when-constructing-nested-columns2-expected.txt: Added. * LayoutTests/fast/multicol/crash-when-constructing-nested-columns2.html: Added. * Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp: (WebCore::RenderTreeBuilder::MultiColumn::restoreColumnSpannersForContainer): (WebCore::RenderTreeBuilder::MultiColumn::multiColumnDescendantInserted): (WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant): Originally-landed-as: 260286.15@webkit-2023.2-embargoed (028f984310b6). https://bugs.webkit.org/show_bug.cgi?id=245374 Canonical link: https://commits.webkit.org/264361@main Commit: 18b93e6b5e09f167e09d9ac7770996e3760e2cb5 https://github.com/WebKit/WebKit/commit/18b93e6b5e09f167e09d9ac7770996e3760e2cb5 Author: Rob Buis Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h Log Message: --- Improve isInsideMulticolumnFlow lambda for top-layer elements https://bugs.webkit.org/show_bug.cgi?id=245374 rdar://98438399 Reviewed by Alan Baradlay. Improve isInsideMulticolumnFlow lambda for top-layer elements. Top-layer elements can skip many ancestors since the containing block is the RenderView. So instead of checking the fragmentedFlowRoot boundary, check the containing block fragmented flow state. * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::setFragmentedFlowStateIncludingDescendants): (WebCore::RenderObject::initializeFragmentedFlowStateOnInsertion): (WebCore::RenderObject::resetFragmentedFlowStateOnRemoval): * Source/WebCore/rendering/RenderObject.h: Originally-landed-as: 260286.14@webkit-2023.2-embargoed (0888aabefd69). https://bugs.webkit.org/show_bug.cgi?id=245374 Canonical link: https://commits.webkit.org/264362@main Compare: https://github.com/WebKit/WebKit/compare/92eaeb4b37d9...18b93e6b5e09 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 92eaeb: [JSC] Use ARM64 ubfiz for Shl(ZExt32(Trunc(value))...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92eaeb4b37d9179720ff4fc5809eb1ed0bd94f3b https://github.com/WebKit/WebKit/commit/92eaeb4b37d9179720ff4fc5809eb1ed0bd94f3b Author: Yusuke Suzuki Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/b3/B3LowerToAir.cpp Log Message: --- [JSC] Use ARM64 ubfiz for Shl(ZExt32(Trunc(value)), Imm) https://bugs.webkit.org/show_bug.cgi?id=257113 rdar://109645676 Reviewed by Keith Miller. We are missing ubfiz optimization for ZExt32 while we prefer that than BitAnd. This patch just extends it for ZExt32. * Source/JavaScriptCore/b3/B3LowerToAir.cpp: Canonical link: https://commits.webkit.org/264360@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 439b3f: Ignore snap offsets with an identifier of zero
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 439b3f7091afcdcb29c02821fd8ead3b24d90d60 https://github.com/WebKit/WebKit/commit/439b3f7091afcdcb29c02821fd8ead3b24d90d60 Author: JC Alvarado Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/scrolling/scroll-snap-crash-expected.txt A LayoutTests/fast/scrolling/scroll-snap-crash.html M Source/WebCore/platform/ScrollSnapAnimatorState.cpp Log Message: --- Ignore snap offsets with an identifier of zero https://bugs.webkit.org/show_bug.cgi?id=254383 rdar://107130316 Reviewed by Simon Fraser. When updating snap offsets, if there is no element for a RenderBox, then a snap offset with an identifier of 0 is created. This can lead to issues when we add that offset identifier to a HashSet so we should ignore them in ScrollSnapAnimatorState::currentlySnappedBoxes(). * LayoutTests/fast/animation/scroll-snap-crash-expected.txt: Added. * LayoutTests/fast/animation/scroll-snap-crash.html: Added. * Source/WebCore/platform/ScrollSnapAnimatorState.cpp: (WebCore::ScrollSnapAnimatorState::currentlySnappedBoxes const): Originally-landed-as: 259548.525@safari-7615-branch (3d4fc69bfad2). rdar://107130316 Canonical link: https://commits.webkit.org/264359@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9565d9: Null ptr deref in CSSStyleSheet::replaceSync.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9565d92681d724cfb509da570d98241ab6263272 https://github.com/WebKit/WebKit/commit/9565d92681d724cfb509da570d98241ab6263272 Author: Arunsundar Kannan Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/cssom/css-stylesheet-replaceSync-null-deref-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/cssom/css-stylesheet-replaceSync-null-deref.html M Source/WebCore/css/CSSStyleSheet.cpp Log Message: --- Null ptr deref in CSSStyleSheet::replaceSync. https://bugs.webkit.org/show_bug.cgi?id=254727. rdar://101629411. Reviewed by Chris Dumez. Added a null check in CSSStyleSheet::replaceSync to prevent a null deref. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/css-stylesheet-replaceSync-null-deref-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/css-stylesheet-replaceSync-null-deref.html: Added. * Source/WebCore/css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::replaceSync): Originally-landed-as: 259548.524@safari-7615-branch (a48f8590fa3e). rdar://101629411 Canonical link: https://commits.webkit.org/264358@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25df56: Lookalike character sanitization should only apply...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25df5694ce1b952c6249849e6458ed632996a12c https://github.com/WebKit/WebKit/commit/25df5694ce1b952c6249849e6458ed632996a12c Author: Wenson Hsieh Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm Log Message: --- Lookalike character sanitization should only apply to main resource URLs https://bugs.webkit.org/show_bug.cgi?id=257134 Reviewed by Aditya Keerthi. Make a slight adjustment to lookalike character sanitization, so that it only applies when loading main resources. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::updateRequestAndAddExtraFields): * Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h: * Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm: (-[TestNavigationDelegate _webView:didChangeLookalikeCharactersFromURL:toURL:]): Also, add a new callback on `TestNavigationDelegate`, which we'll adopt in a new API test. Canonical link: https://commits.webkit.org/264357@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dfd97e: Scrollbar does not pick up changed styles until ho...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dfd97e668d4ac82721a6f233a392b695c42ab799 https://github.com/WebKit/WebKit/commit/dfd97e668d4ac82721a6f233a392b695c42ab799 Author: Vitaly Dyachkov Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M LayoutTests/fast/css/scrollbar-dynamic-style-change-expected.html M LayoutTests/fast/css/scrollbar-dynamic-style-change.html M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- Scrollbar does not pick up changed styles until hovered https://bugs.webkit.org/show_bug.cgi?id=113727 Reviewed by Simon Fraser. Resolve the pseudo-element `::-webkit-scrollbar` in the same way as it is done with other pseudo-elements that can be applied to any element. * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): (WebCore::Style::TreeResolver::resolvePseudoElement): * LayoutTests/fast/css/scrollbar-dynamic-style-change-expected.html: Rebaselined * LayoutTests/fast/css/scrollbar-dynamic-style-change.html: Ditto Canonical link: https://commits.webkit.org/264356@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 777fe1: Fix heap use-after-free in Update::addSVGRendererU...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 777fe1501522cc907234a327b306b3cafffb1501 https://github.com/WebKit/WebKit/commit/777fe1501522cc907234a327b306b3cafffb1501 Author: Chirag M Shah Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/svg/animations/svg-element-attribute-changed-crash-expected.txt A LayoutTests/svg/animations/svg-element-attribute-changed-crash.html M Source/WebCore/svg/properties/SVGAnimatedProperty.cpp Log Message: --- Fix heap use-after-free in Update::addSVGRendererUpdate https://bugs.webkit.org/show_bug.cgi?id=254281 rdar://107052707 Reviewed by Ryosuke Niwa. Update::addSVGRendererUpdate can end up removing the SVGElement from m_roots, which can result in SVGElement being deleted when an attribute change happens. This change prevents that by protecting the SVGElement using a RefPtr. * LayoutTests/svg/animations/svg-element-attribute-changed-crash-expected.txt: Added. * LayoutTests/svg/animations/svg-element-attribute-changed-crash.html: Added. * Source/WebCore/svg/properties/SVGAnimatedProperty.cpp: (WebCore::SVGAnimatedProperty::commitPropertyChange): Originally-landed-as: 259548.475@safari-7615-branch (aaa1c998206d). rdar://107052707 Canonical link: https://commits.webkit.org/264355@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 331064: Web Inspector: Deeply nested async stack traces ar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33106442561e29aec6760903d306bb78c3eee2fc https://github.com/WebKit/WebKit/commit/33106442561e29aec6760903d306bb78c3eee2fc Author: Patrick Angle Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M LayoutTests/inspector/debugger/async-stack-trace-truncate-expected.txt M LayoutTests/inspector/debugger/async-stack-trace-truncate.html M Source/JavaScriptCore/inspector/AsyncStackTrace.cpp M Source/JavaScriptCore/inspector/ScriptCallStack.cpp M Source/JavaScriptCore/inspector/ScriptCallStack.h Log Message: --- Web Inspector: Deeply nested async stack traces are not fully truncated https://bugs.webkit.org/show_bug.cgi?id=254244 rdar://105900359 Reviewed by Yusuke Suzuki. As of 252630@main, ScriptCallStack holds a reference to its parent AsyncStackTrace to enable providing async stack traces in places where previously the async context was being lost. However when this was added, the truncation functionality used to ensure that AsyncStackTrace did not create an infinitely nested set of objects did not take the new reference into account. In practice, we should break that relationship any time we are removing the parent of the AsyncStackTrace. This allows us to correctly release ownership of AsyncStackTraces as we nest deeper, then preventing us from recursing during their deconstruction later. * LayoutTests/inspector/debugger/async-stack-trace-truncate-expected.txt: * LayoutTests/inspector/debugger/async-stack-trace-truncate.html: - Add test case that creates a nested set of AsyncStackTrace/ScriptCallStack that will exceed the size of the stack if not correctly truncated. * Source/JavaScriptCore/inspector/AsyncStackTrace.cpp: (Inspector::AsyncStackTrace::remove): Remove the ScriptCallStack's parent at the same time we remove the AsyncStackTrace's parent. * Source/JavaScriptCore/inspector/ScriptCallStack.cpp: (Inspector::ScriptCallStack::removeParentStackTrace): * Source/JavaScriptCore/inspector/ScriptCallStack.h: Originally-landed-as: 259548.467@safari-7615-branch (69eae63cd374). rdar://105900359 Canonical link: https://commits.webkit.org/264354@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4c271: Increase max scrollbar update passes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4c271f0d9f8b4f3b7ea38335366734a81433920 https://github.com/WebKit/WebKit/commit/e4c271f0d9f8b4f3b7ea38335366734a81433920 Author: JC Alvarado Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/editing/frame-selection-in-child-view-crash-expected.txt A LayoutTests/fast/editing/frame-selection-in-child-view-crash.html M Source/WebCore/platform/ScrollView.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm Log Message: --- Increase max scrollbar update passes rdar://104064235 Reviewed by Simon Fraser. Scrollbars are not fully updated in a single layout which can lead to an additional layout in the scriptDisallowedScope in FrameView::scrollRectToVisibleInChildView. * LayoutTests/fast/editing/frame-selection-in-child-view-crash-expected.txt: Added. * LayoutTests/fast/editing/frame-selection-in-child-view-crash.html: Added. * Source/WebCore/platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars): * Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm: (TEST): Add scrollbarSize to width in WritingMode tests because we should expect vertical overflow in these cases. This test would pass prior to this patch despite the displayed WebView having both a vertical and horizontal scroll bar. Originally-landed-as: 259548.465@safari-7615-branch (cf0b3436ba58). rdar://104064235 Canonical link: https://commits.webkit.org/264353@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89b88f: Adapt OOF with specified height case in availableL...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89b88fd5da18c2017a4261858c4750c6487c4926 https://github.com/WebKit/WebKit/commit/89b88fd5da18c2017a4261858c4750c6487c4926 Author: Rob Buis Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar-expected.txt A LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar.html M Source/WebCore/rendering/RenderBlock.cpp Log Message: --- Adapt OOF with specified height case in availableLogicalHeightForPercentageComputation https://bugs.webkit.org/show_bug.cgi?id=253037 rdar://105938634 Reviewed by Alan Baradlay. The computed height for OOF can result in being zero for certain insets (but never negative). In that case subtracting scrollbar sizes could result in negative values like in the test case, so clamp to zero. * LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar-expected.txt: Added. * LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar.html: Added. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const): Originally-landed-as: 260286.13@webkit-2023.2-embargoed (0a7c35b68439). https://bugs.webkit.org/show_bug.cgi?id=253037 Canonical link: https://commits.webkit.org/264352@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c98a1: Add test for display contents on focus change
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c98a1beca342adf46e228d27278c9102d08e580 https://github.com/WebKit/WebKit/commit/3c98a1beca342adf46e228d27278c9102d08e580 Author: Claudio Saavedra Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/css/content/display-contents-on-focus-crash-expected.txt A LayoutTests/fast/css/content/display-contents-on-focus-crash.html Log Message: --- Add test for display contents on focus change https://bugs.webkit.org/show_bug.cgi?id=251380 rdar://104813991 Reviewed by Antti Koivisto. Already fixed by #248776, but add this test for completeness. * LayoutTests/fast/css/content/display-contents-on-focus-crash-expected.txt: Added. * LayoutTests/fast/css/content/display-contents-on-focus-crash.html: Added. Originally-landed-as: 260286.12@webkit-2023.2-embargoed (042db6f5677e). https://bugs.webkit.org/show_bug.cgi?id=251380 Canonical link: https://commits.webkit.org/264351@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 576fb6: Take legend element into account in propagateRepai...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 576fb607ea63b0a91732c80950c4170dc34ac639 https://github.com/WebKit/WebKit/commit/576fb607ea63b0a91732c80950c4170dc34ac639 Author: Rob Buis Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/multicol/legend-in-column-outline-auto-crash-expected.txt A LayoutTests/fast/multicol/legend-in-column-outline-auto-crash.html M Source/WebCore/rendering/RenderObject.cpp Log Message: --- Take legend element into account in propagateRepaintToParentWithOutlineAutoIfNeeded https://bugs.webkit.org/show_bug.cgi?id=251381 rdar://104813886 Reviewed by Alan Baradlay. In change r259412 logic was introduced for spanner placeholders and a check was done to see if the previous sibling renderer is a column set. However legends are kept out of column flows and thus may also have a column set as previous sibling, in this case we don't want to enter the spanner placeholder logic. * LayoutTests/fast/multicol/legend-in-column-outline-auto-crash-expected.txt: Added. * LayoutTests/fast/multicol/legend-in-column-outline-auto-crash.html: Added. * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const): Originally-landed-as: 260286.11@webkit-2023.2-embargoed (e7b0459eaad2). rdar://104813886 Canonical link: https://commits.webkit.org/264350@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f75e6: Add crash test for bad update of fixed position sc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f75e69d34965ffeb9c91e9dae5f3e79e460eeba https://github.com/WebKit/WebKit/commit/7f75e69d34965ffeb9c91e9dae5f3e79e460eeba Author: Rob Buis Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/scrolling/fixed-positioned-element-update-crash-expected.txt A LayoutTests/fast/scrolling/fixed-positioned-element-update-crash.html Log Message: --- Add crash test for bad update of fixed position scrolling node https://bugs.webkit.org/show_bug.cgi?id=245389 rdar://99637052 Reviewed by Simon Fraser. This was already fixed with #255114, but add the test for completeness. * LayoutTests/fast/scrolling/fixed-positioned-element-update-crash-expected.txt: Added. * LayoutTests/fast/scrolling/fixed-positioned-element-update-crash.html: Added. Originally-landed-as: 260286.10@webkit-2023.2-embargoed (010528ca060e). https://bugs.webkit.org/show_bug.cgi?id=245389 Canonical link: https://commits.webkit.org/264349@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d55bc: Add stress test for liveness-based interference an...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d55bc6393fbe0108ecd1196c2bdc351fc4fdcf0 https://github.com/WebKit/WebKit/commit/8d55bc6393fbe0108ecd1196c2bdc351fc4fdcf0 Author: David Degazio Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A JSTests/stress/loop-osr-with-inlined-create-rest.js Log Message: --- Add stress test for liveness-based interference analysis across loop OSR https://bugs.webkit.org/show_bug.cgi?id=253902 rdar://105671759 Reviewed by Yusuke Suzuki. Adds a stress test that breaks without https://bugs.webkit.org/show_bug.cgi?id=252798, to ensure we don't regress this behavior in the future. * JSTests/stress/loop-osr-with-inlined-create-rest.js: Added. (bar): (foo): Originally-landed-as: 259548.426@safari-7615-branch (dde3cbd34027). rdar://105671759 Canonical link: https://commits.webkit.org/264348@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1b5e5c: OSS: [WebRTC] Heap-buffer-overflow in av1_get_one_...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1b5e5ce3caa031758574aa68e9c118e269b5a122 https://github.com/WebKit/WebKit/commit/1b5e5ce3caa031758574aa68e9c118e269b5a122 Author: Youenn Fablet Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/ratectrl.c M Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/ratectrl.h Log Message: --- OSS: [WebRTC] Heap-buffer-overflow in av1_get_one_pass_rt_params - Heap Buffer Overflow in AV1 Video Encoder rdar://106645234 Reviewed by Eric Carlson. Cherry-picking of https://aomedia.googlesource.com/aom/+/bee1caded272127a6d6b70ac79479083d183d5d0%5E%21/#F0. I had to manually apply the patch since it does not apply cleanly. * Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/ratectrl.c: (av1_rc_postencode_update): (av1_rc_postencode_update_drop_frame): (av1_get_one_pass_rt_params): * Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/ratectrl.h: Originally-landed-as: 259548.439@safari-7615-branch (4a5ecd489674). rdar://106645234 Canonical link: https://commits.webkit.org/264347@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e357a6: Web content process crashes when mutating grid-tem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e357a6a2cd384f7aa70e6aa4f2e552829e971b3c https://github.com/WebKit/WebKit/commit/e357a6a2cd384f7aa70e6aa4f2e552829e971b3c Author: Arunsundar Kannan Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/css-grid-layout/GridtrackSizing-overflowon-mutating-grid-columns-expected.txt A LayoutTests/fast/css-grid-layout/GridtrackSizing-overflowon-mutating-grid-columns.html M Source/WebCore/rendering/RenderGrid.cpp Log Message: --- Web content process crashes when mutating grid-template-columns of subgrid parent grid. https://bugs.webkit.org/show_bug.cgi?id=253916. rdar://106458581. Reviewed by Matt Woodrow. After grid-template-column of the subgrid's parent grid mutates, needsItemsPlacement flag is not set for the subgrid's currentgrid. As a result, gridTracks for subgrids->curretGrid() don't undergo resizing, resulting in a OOB in copyUsedTrackSizesForSubgrid().This changes sets needsItemPlacement flag as needed. * LayoutTests/fast/css-grid-layout/GridtrackSizing-overflowon-mutating-grid-columns-expected.txt: Added. * LayoutTests/fast/css-grid-layout/GridtrackSizing-overflowon-mutating-grid-columns.html: Added. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::placeItemsOnGrid): Originally-landed-as: 259548.434@safari-7615-branch (54a21b4db4fa). rdar://106458581 Canonical link: https://commits.webkit.org/264346@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 402947: Fixes navigator.credentials.preventSilentAccess()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40294715d0c0e48bf27775eadfe7b76ec2e62250 https://github.com/WebKit/WebKit/commit/40294715d0c0e48bf27775eadfe7b76ec2e62250 Author: Luke Warlow Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M LayoutTests/http/wpt/credential-management/credentialscontainer-preventSilentAccess-basics.https.html M Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp Log Message: --- Fixes navigator.credentials.preventSilentAccess() https://bugs.webkit.org/show_bug.cgi?id=242002 Reviewed by J Pascoe. This change makes the function resolve rather than throw matching the spec. * LayoutTests/http/wpt/credential-management/credentialscontainer-preventSilentAccess-basics.https.html: * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::preventSilentAccess const): Canonical link: https://commits.webkit.org/264345@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c57f44: Deprecate isSpaceOrNewline
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c57f446617deaacdaa5d5435b909afd1d3fe596b https://github.com/WebKit/WebKit/commit/c57f446617deaacdaa5d5435b909afd1d3fe596b Author: Anne van Kesteren Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/runtime/ExceptionHelpers.cpp M Source/WTF/wtf/JSONValues.cpp M Source/WTF/wtf/text/StringImpl.cpp M Source/WTF/wtf/text/StringImpl.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/editing/TextIterator.cpp M Source/WebCore/editing/TypingCommand.cpp M Source/WebCore/editing/VisibleSelection.cpp M Source/WebCore/html/TypeAhead.cpp M Source/WebCore/inspector/InspectorStyleSheet.cpp M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp M Source/WebCore/page/LoggedInStatus.cpp M Source/WebCore/page/TextIndicator.cpp M Source/WebCore/page/ios/FrameIOS.mm M Source/WebCore/platform/Length.cpp M Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp M Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp M Source/WebCore/rendering/LegacyInlineFlowBox.cpp M Source/WebCore/rendering/LegacyLineLayout.cpp M Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm Log Message: --- Deprecate isSpaceOrNewline https://bugs.webkit.org/show_bug.cgi?id=257101 rdar://109621392 Reviewed by Darin Adler. This renames isSpaceOrNewline to deprecatedIsSpaceOrNewline. And similarly renames its inverse to deprecatedIsNotSpaceOrNewline. This is because it looks like Unicode White_Space, but misses U+0085 and U+00A0 in the Latin1 scenario. Some callers account for the latter, but never the former. And many callers don't even realize. Given that isUnicodeWhitespace exists callers could migrate to that instead. simplifyWhiteSpace and stripWhiteSpace that use this underneath will be dealt with in bug 257084. * Source/JavaScriptCore/runtime/ExceptionHelpers.cpp: (JSC::invalidParameterInSourceAppender): (JSC::invalidParameterInstanceofSourceAppender): * Source/WTF/wtf/JSONValues.cpp: (WTF::JSONImpl::Value::parseJSON): * Source/WTF/wtf/text/StringImpl.cpp: (WTF::StringImpl::stripWhiteSpace): (WTF::StringImpl::simplifyWhiteSpace): * Source/WTF/wtf/text/StringImpl.h: (WTF::deprecatedIsSpaceOrNewline): (WTF::isUnicodeWhitespace): (WTF::deprecatedIsNotSpaceOrNewline): (WTF::isSpaceOrNewline): Deleted. (WTF::isNotSpaceOrNewline): Deleted. * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::stringForRange const): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]): * Source/WebCore/editing/Editor.cpp: (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::editorUIUpdateTimerFired): * Source/WebCore/editing/FrameSelection.cpp: (WebCore::FrameSelection::selectionAtWordStart const): (WebCore::FrameSelection::wordSelectionContainingCaretSelection): (WebCore::FrameSelection::selectionAtSentenceStart const): * Source/WebCore/editing/TextIterator.cpp: (WebCore::WordAwareIterator::advance): * Source/WebCore/editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::markMisspellingsAfterTyping): * Source/WebCore/editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace): * Source/WebCore/html/TypeAhead.cpp: (WebCore::stripLeadingWhiteSpace): * Source/WebCore/inspector/InspectorStyleSheet.cpp: (WebCore::StyleSheetHandler::observeProperty): (WebCore::StyleSheetHandler::observeComment): * Source/WebCore/inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttributesAsText): * Source/WebCore/page/LoggedInStatus.cpp: (WebCore::LoggedInStatus::create): * Source/WebCore/page/TextIndicator.cpp: (WebCore::containsOnlyWhiteSpaceText): * Source/WebCore/page/ios/FrameIOS.mm: (WebCore::LocalFrame::wordsInCurrentParagraph const): * Source/WebCore/platform/Length.cpp: (WebCore::parseLength): * Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::setStatusLine): * Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp: (WebCore::sanitizeFilename): * Source/WebCore/rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::placeBoxRangeInInlineDirection): * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::computeInlineDirectionPositionsForSegment): * Source/WebCore/rend
[webkit-changes] [WebKit/WebKit] 1b6cd8: SecStaticCodeCreateWithPath use causes crash with ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1b6cd84a49f12ee364eaa84a040ca57340d21a26 https://github.com/WebKit/WebKit/commit/1b6cd84a49f12ee364eaa84a040ca57340d21a26 Author: Per Arne Vollan Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- SecStaticCodeCreateWithPath use causes crash with ASAN https://bugs.webkit.org/show_bug.cgi?id=256919 rdar://109470436 Reviewed by Brent Fulgham. This is a speculative fix. Go back to using CFBundleCopyBundleURL instead of CFBundleCopyExecutableURL, since we did not observe any asan crashes with this approach. Also check that the returned bundle URL is valid. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): Canonical link: https://commits.webkit.org/264343@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e3309b: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3309b6702b08d3499f403c887dc05a3f104692c https://github.com/WebKit/WebKit/commit/e3309b6702b08d3499f403c887dc05a3f104692c Author: Russell Epstein Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7616.1.16 Canonical link: https://commits.webkit.org/264342@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 703cad: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 703cad17fb61dfff76b21b2562cdf7c9694de55e https://github.com/WebKit/WebKit/commit/703cad17fb61dfff76b21b2562cdf7c9694de55e Author: Russell Epstein Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7616.1.15 Canonical link: https://commits.webkit.org/264341@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e1b48c: AX: Stop clearing caching info for table components
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1b48c3d6e0d4d087c9d2deb30099f96aa435a8f https://github.com/WebKit/WebKit/commit/e1b48c3d6e0d4d087c9d2deb30099f96aa435a8f Author: Chris Fleizach Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/accessibility/AccessibilityObject.cpp Log Message: --- AX: Stop clearing caching info for table components https://bugs.webkit.org/show_bug.cgi?id=257065 rdar://109589379 Reviewed by Andres Gonzalez. In table cells, we're spending a lot of time recreating isIgnored state because there are mock objects (like columns) that return children that are also children of other objects. That runs into a check about verifying the parent object is the same. Removing the check does not cause any functional difference. The performance is actually much better without this, which was a reason it was added: https://bugs.webkit.org/show_bug.cgi?id=171443. * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::setIsIgnoredFromParentDataForChild): Canonical link: https://commits.webkit.org/264340@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95ec7f: Add `-list` flag to testb3
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95ec7fc55b008cd504f2e8b6c178f5b864a51825 https://github.com/WebKit/WebKit/commit/95ec7fc55b008cd504f2e8b6c178f5b864a51825 Author: Joseph Griego Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/b3/testb3.h M Source/JavaScriptCore/b3/testb3_1.cpp M Source/JavaScriptCore/b3/testb3_2.cpp M Source/JavaScriptCore/b3/testb3_3.cpp M Source/JavaScriptCore/b3/testb3_4.cpp M Source/JavaScriptCore/b3/testb3_6.cpp M Source/JavaScriptCore/b3/testb3_7.cpp M Source/JavaScriptCore/b3/testb3_8.cpp Log Message: --- Add `-list` flag to testb3 https://bugs.webkit.org/show_bug.cgi?id=256857 Reviewed by Justin Michaud. This is useful to write scripts that need to analyze runs of testb3 or to continue past failures (which manifest as crashes). `testb3` now can be invoked as: testb3 [-list] [-filter ] the `-list` flag causes testb3 to simply print the defined test cases; `-filter` acts like the current argument (filtering the test cases to run). `-filter` is ignored if `-list` was passed. `testb3` will also continue to accept the current commandline: testb3 [filter] To accomplish this, the `const char* filter` parameter has been replaced everywhere with a TestConfig parameter that stores a filter and also now a run mode. * Source/JavaScriptCore/b3/testb3.h: * Source/JavaScriptCore/b3/testb3_1.cpp: (shouldRun): (run): (main): * Source/JavaScriptCore/b3/testb3_2.cpp: (testBitOrImms32): * Source/JavaScriptCore/b3/testb3_3.cpp: (testNegPtr): (addArgTests): * Source/JavaScriptCore/b3/testb3_4.cpp: (testPatchpointAnyImm): * Source/JavaScriptCore/b3/testb3_6.cpp: (addSShrShTests): * Source/JavaScriptCore/b3/testb3_7.cpp: (tupleNestedLoop): * Source/JavaScriptCore/b3/testb3_8.cpp: (testAtomicXchg): (testLoad): Canonical link: https://commits.webkit.org/264339@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 74c993: [JSC] Remove scratch register use in stackoverflow...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74c993d56b0139a0dbce8c9500fef1a2a8bc7b11 https://github.com/WebKit/WebKit/commit/74c993d56b0139a0dbce8c9500fef1a2a8bc7b11 Author: Yusuke Suzuki Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/jit/AssemblyHelpers.cpp M Source/JavaScriptCore/jit/AssemblyHelpers.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp Log Message: --- [JSC] Remove scratch register use in stackoverflow check in Wasm OMG https://bugs.webkit.org/show_bug.cgi?id=257099 rdar://109617032 Reviewed by Michael Saboff. We can change the logic carefully and we can remove scratch register use in stackoverflow check in Wasm OMG. * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::B3IRGenerator): Canonical link: https://commits.webkit.org/264338@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e76387: Fix break with MODERN_MEDIA_CONTROLS disabled afte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e76387590957743e738a129d76106cf7fbd0f279 https://github.com/WebKit/WebKit/commit/e76387590957743e738a129d76106cf7fbd0f279 Author: Yousuke Kimoto Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl Log Message: --- Fix break with MODERN_MEDIA_CONTROLS disabled after 264293@main https://bugs.webkit.org/show_bug.cgi?id=257114 Reviewed by Eric Carlson and Jer Noble. `Since MediaControlsHost::sourceType()` is implemented in a `MODERN_MEDIA_CONTROLS` macro block, the API and related things should be managed with the macro condition. * Source/WebCore/Modules/mediacontrols/MediaControlsHost.h: Expanded the `MODERN_MEDIA_CONTROLS` block to include `sourceType()` and related definitions. * Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl: Added a `MODERN_MEDIA_CONTROLS` condition for sourceType Canonical link: https://commits.webkit.org/264335@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d9ba14: Document::m_nodeIterators should be WeakHashSet
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9ba14bdee8bc50f19a82610165fa3e720884afa https://github.com/WebKit/WebKit/commit/d9ba14bdee8bc50f19a82610165fa3e720884afa Author: Ryosuke Niwa Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/NodeIterator.h Log Message: --- Document::m_nodeIterators should be WeakHashSet https://bugs.webkit.org/show_bug.cgi?id=257079 Reviewed by Chris Dumez. Make NodeIterator compatible with WeakPtr and use WeakHashSet for m_nodeIterators in Document. * Source/WebCore/dom/Document.cpp: (WebCore::Document::attachNodeIterator): (WebCore::Document::detachNodeIterator): (WebCore::Document::moveNodeIteratorsToNewDocument): Renamed from moveNodeIteratorsToNewDocumentSlowCase. (WebCore::Document::nodeChildrenWillBeRemoved): (WebCore::Document::nodeWillBeRemoved): * Source/WebCore/dom/Document.h: (WebCore::Document::moveNodeIteratorsToNewDocument): Deleted. * Source/WebCore/dom/NodeIterator.h: Canonical link: https://commits.webkit.org/264334@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45c054: [JSC] Optimize Move32 in ARM64
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45c0547c1d8e948bee6c53314d285d7ed7b7a63d https://github.com/WebKit/WebKit/commit/45c0547c1d8e948bee6c53314d285d7ed7b7a63d Author: Yusuke Suzuki Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp Log Message: --- [JSC] Optimize Move32 in ARM64 https://bugs.webkit.org/show_bug.cgi?id=257097 rdar://109615916 Reviewed by Michael Saboff. Move32 is actually more costly than Move in ARM64. We should prefer Move over Move32 in register allocator in ARM64. We also use "and" instead of "uxth" for zero-extend ops since "and" is cheaper than "uxth" (and clang chooses it). * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::zeroExtend16To32): (JSC::MacroAssemblerARM64::zeroExtend16To64): (JSC::MacroAssemblerARM64::zeroExtend8To32): (JSC::MacroAssemblerARM64::zeroExtend8To64): (JSC::MacroAssemblerARM64::zeroExtend32ToWord): * Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp: Canonical link: https://commits.webkit.org/264333@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 591e13: [WebRTC] heap-use-after-free : webrtc::`anonymous ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 591e13fe4afb8fe1cfaf0eb18d1c0ba8bf4db67f https://github.com/WebKit/WebKit/commit/591e13fe4afb8fe1cfaf0eb18d1c0ba8bf4db67f Author: Youenn Fablet Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/ThirdParty/libwebrtc/Source/webrtc/api/stats/rtc_stats_report.h M Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtc_stats_collector.cc M Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtc_stats_collector_unittest.cc M Source/ThirdParty/libwebrtc/Source/webrtc/pc/test/fake_peer_connection_for_stats.h M Source/ThirdParty/libwebrtc/Source/webrtc/stats/rtc_stats_report.cc Log Message: --- [WebRTC] heap-use-after-free : webrtc::`anonymous namespace'::ProduceRemoteInboundRtpStreamStatsFromReportBlockData https://bugs.webkit.org/show_bug.cgi?id=253510 rdar://106063452 Reviewed by Eric Carlson. We first cherry-pick libwebrc b2be392c708c975ff5a81d8cd4dba588752a8dad to remove duplicate RTCCodec entries. We then apply da6297dc53cb2eaae7b1c5381652de9d707a7d48. * Source/ThirdParty/libwebrtc/Source/webrtc/api/stats/rtc_stats_report.h: * Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtc_stats_collector.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/pc/rtc_stats_collector_unittest.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/pc/test/fake_peer_connection_for_stats.h: (webrtc::FakePeerConnectionForStats::AddVoiceChannel): (webrtc::FakePeerConnectionForStats::AddVideoChannel): (webrtc::FakePeerConnectionForStats::GetOrCreateFirstTransceiverOfType): (webrtc::FakePeerConnectionForStats::CreateTransceiverOfType): * Source/ThirdParty/libwebrtc/Source/webrtc/stats/rtc_stats_report.cc: Originally-landed-as: 259548.382@safari-7615-branch (adde9296b1b1). rdar://106063452 Canonical link: https://commits.webkit.org/264332@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4de497: Remove WebCore::newCoordsArray()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4de497ecb697773a29d7761db237c060f6d742af https://github.com/WebKit/WebKit/commit/4de497ecb697773a29d7761db237c060f6d742af Author: Anne van Kesteren Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/platform/Length.cpp M Source/WebCore/platform/Length.h Log Message: --- Remove WebCore::newCoordsArray() https://bugs.webkit.org/show_bug.cgi?id=257124 rdar://109660821 Reviewed by Darin Adler. It's not used and it calls something we don't like (simplifyWhiteSpace()). * Source/WebCore/platform/Length.cpp: (WebCore::newCoordsArray): Deleted. * Source/WebCore/platform/Length.h: Canonical link: https://commits.webkit.org/264331@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8730f0: Move Page::renderingUpdateCompleted call to outsid...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8730f010fcbddd092d2602b3e4c1d61482adf6d4 https://github.com/WebKit/WebKit/commit/8730f010fcbddd092d2602b3e4c1d61482adf6d4 Author: Alex Christensen Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/page/Page.cpp Log Message: --- Move Page::renderingUpdateCompleted call to outside loop in Page::finalizeRenderingUpdate https://bugs.webkit.org/show_bug.cgi?id=257127 rdar://109664043 Reviewed by Tim Horton. This does not change behavior with site isolation off because a page will only ever have one root frame, which is always the main frame. A root frame is a local frame that does not have a local parent, which means its layer is a root drawing layer in this process that will be composited in the UI process. This change is needed as a step towards drawing multiple iframes in the same process, in which case a Page would have multiple root frames. It only needs to call renderingUpdateCompleted once and if it doesn't then assertions and crashes happen. This change is also needed to fix some crashes from https://github.com/WebKit/WebKit/pull/14025 but this change is completely unrelated so I'm doing it in a separate PR. * Source/WebCore/page/Page.cpp: (WebCore::Page::finalizeRenderingUpdate): (WebCore::Page::finalizeRenderingUpdateForRootFrame): Canonical link: https://commits.webkit.org/264330@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d2f304: WebFrame::didCommitLoadInAnotherProcess should wor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d2f3048d0225e4f7ebf5d30f65d2d3f49fb67f50 https://github.com/WebKit/WebKit/commit/d2f3048d0225e4f7ebf5d30f65d2d3f49fb67f50 Author: Alex Christensen Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- WebFrame::didCommitLoadInAnotherProcess should work with frames that don't have an owner element or parent in the same process https://bugs.webkit.org/show_bug.cgi?id=257125 rdar://109663423 Reviewed by Chris Dumez. It can happen without an owner element in the same process when a site isolated iframe navigates to a new domain, such as in the ParentNavigatingCrossOriginIframeToSameOrigin API test. It can happen without a parent when window.open is used to make a popup that is site isolated, which hasn't landed yet but will soon. So this does some of the same things as https://github.com/WebKit/WebKit/pull/10169 I also noticed that the code in the completion lambda of WebRemoteFrameClient::changeLocation wasn't called so I removed it and replaced it with a comment explaining what is actually happening. * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::changeLocation): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::didCommitLoadInAnotherProcess): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/264329@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58f0a3: ASan global-buffer-overflow READ in com.apple.WebK...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58f0a3c82680947b6205bec08d30ec0abb629130 https://github.com/WebKit/WebKit/commit/58f0a3c82680947b6205bec08d30ec0abb629130 Author: Youenn Fablet Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/arm/neon/av1_fwd_txfm2d_neon.c Log Message: --- ASan global-buffer-overflow READ in com.apple.WebKit.WebContent.Development at libwebrtc.dylib: av1_lowbd_fwd_txfm2d_8x8_neon https://bugs.webkit.org/show_bug.cgi?id=253512 rdar://105650593 Reviewed by Eric Carlson. Cherry-pick from upstream the corresponding fix (582d2fd1e9b6a212cb7d30bcf63d3c1e78aa8fca). Remove the call to vld1_s8, which reads 8 bytes while only 3 bytes are available, even though only 2 are used. * Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/arm/neon/av1_fwd_txfm2d_neon.c: (av1_lowbd_fwd_txfm2d_4x8_neon): (av1_lowbd_fwd_txfm2d_4x16_neon): (av1_lowbd_fwd_txfm2d_8x4_neon): (av1_lowbd_fwd_txfm2d_8x8_neon): (av1_lowbd_fwd_txfm2d_8x16_neon): (av1_lowbd_fwd_txfm2d_8x32_neon): (av1_lowbd_fwd_txfm2d_16x4_neon): (av1_lowbd_fwd_txfm2d_16x8_neon): (av1_lowbd_fwd_txfm2d_16x16_neon): (av1_lowbd_fwd_txfm2d_16x32_neon): (av1_lowbd_fwd_txfm2d_32x8_neon): (av1_lowbd_fwd_txfm2d_32x16_neon): Originally-landed-as: 259548.383@safari-7615-branch (4b0ac875e7fa). rdar://105650593 Canonical link: https://commits.webkit.org/264328@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6f57c: av1/encoder/encoder_utils.c & a/av1/common/resize:...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6f57c1a1ab98c1ee64db9a32a8d42e78d5d49a4 https://github.com/WebKit/WebKit/commit/a6f57c1a1ab98c1ee64db9a32a8d42e78d5d49a4 Author: Youenn Fablet Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/common/resize.c M Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/common/resize.h M Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/encoder_utils.c Log Message: --- av1/encoder/encoder_utils.c & a/av1/common/resize: Stack-buffer-overflow in aom_scaled_2d_ssse3 https://bugs.webkit.org/show_bug.cgi?id=253498 rdar://106063201 Reviewed by Eric Carlson. Cherry-pick upstream change from https://aomedia.googlesource.com/aom/+/6318378f833b2a0d8e67fb3d12bcdc4e1c26b0e6%5E%21/#F2. * Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/common/resize.c: (av1_realloc_and_scale_if_required): * Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/common/resize.h: * Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/encoder_utils.c: (av1_scale_references): Originally-landed-as: 259548.381@safari-7615-branch (1de648970cbf). rdar://106063201 Canonical link: https://commits.webkit.org/264327@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb4ca5: FTL missing bound check of for-in loop
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb4ca5da0f8e84a9e186efd411a0f14d709de0b4 https://github.com/WebKit/WebKit/commit/fb4ca5da0f8e84a9e186efd411a0f14d709de0b4 Author: Yusuke Suzuki Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A JSTests/stress/ftl-bound-check-for-enumerator-next-update-index-and-mode.js M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp Log Message: --- FTL missing bound check of for-in loop https://bugs.webkit.org/show_bug.cgi?id=252801 rdar://105820083 Reviewed by Michael Saboff. EnumeratorNextUpdateIndexAndMode for IndexedMode uses HasIndexProperty internally. But this node does not do bound check when ArrayMode is inBounds in FTL since FTL SSALowering phase extracts this bound check as a separate CheckInBounds node. But EnumeratorNextUpdateIndexAndMode, we cannot do that since EnumeratorNextUpdateIndexAndMode's index is incremented internally. Thus, we need to do bound check inside EnumeratorNextUpdateIndexAndMode when it is not done in HasIndexProperty's code. * JSTests/stress/ftl-bound-check-for-enumerator-next-update-index-and-mode.js: Added. (shouldBe): (opt): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): Originally-landed-as: 259548.377@safari-7615-branch (25a414a61f3e). rdar://105820083 Canonical link: https://commits.webkit.org/264326@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 63f8f7: [GStreamer][Realtek] Enable 'lowdelay-mode' for re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63f8f7abbc23b8e3b0b984bd63991fe7659a5a48 https://github.com/WebKit/WebKit/commit/63f8f7abbc23b8e3b0b984bd63991fe7659a5a48 Author: Vivienne Watermeier Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer][Realtek] Enable 'lowdelay-mode' for realtek omx decoder https://bugs.webkit.org/show_bug.cgi?id=257121 Reviewed by Philippe Normand. Enabling low delay mode will force the video decoder to decode frames one by one without holding a reference frame. Original author: Manoj Bhatta See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1087 * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): Enable 'lowdelay-mode' property Canonical link: https://commits.webkit.org/264325@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b40525: Adopt ASDInstallWebAttributionService replacing AS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b40525e847936bf95df365170dfbd4a9175e0e9b https://github.com/WebKit/WebKit/commit/b40525e847936bf95df365170dfbd4a9175e0e9b Author: Alex Christensen Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/NetworkProcess/cocoa/AppStoreDaemonSPI.h M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/Scripts/process-entitlements.sh Log Message: --- Adopt ASDInstallWebAttributionService replacing ASDInstallAttribution https://bugs.webkit.org/show_bug.cgi?id=257006 rdar://100043903 Reviewed by John Wilander. And adopt the new entitlement. Remove the code using ASDInstallAttribution on platforms that don't have ASDInstallWebAttributionService because we don't need to keep it working on those platforms because those platforms will never see this change. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/NetworkProcess/cocoa/AppStoreDaemonSPI.h: * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::donateToSKAdNetwork): * Source/WebKit/Scripts/process-entitlements.sh: Canonical link: https://commits.webkit.org/264324@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bdf217: Rename Decimal::ceiling() to Decimal::ceil()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bdf217f5a3d31b7dbfe6e85c8b41fd946c295c51 https://github.com/WebKit/WebKit/commit/bdf217f5a3d31b7dbfe6e85c8b41fd946c295c51 Author: Anne van Kesteren Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/html/InputType.cpp M Source/WebCore/platform/Decimal.cpp M Source/WebCore/platform/Decimal.h Log Message: --- Rename Decimal::ceiling() to Decimal::ceil() https://bugs.webkit.org/show_bug.cgi?id=78032 rdar://109645652 Reviewed by Darin Adler. Per Darin the underlying problem was fixed in macOS Snow Leopard (rdar://problem/6286405) which is now well over a decade old. wtf_ceil itself was cleaned up in 2015 in 8fadbd7385e0. * Source/WebCore/html/InputType.cpp: (WebCore::InputType::applyStep): (WebCore::InputType::stepUpFromRenderer): * Source/WebCore/platform/Decimal.cpp: (WebCore::Decimal::ceil const): (WebCore::Decimal::remainder const): (WebCore::Decimal::ceiling const): Deleted. * Source/WebCore/platform/Decimal.h: Canonical link: https://commits.webkit.org/264323@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] caf109: [webkitcorepy] Support multiple autoinstallers run...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: caf109704d373d1a9ad7ec3bc6caa23c6ab7a0b1 https://github.com/WebKit/WebKit/commit/caf109704d373d1a9ad7ec3bc6caa23c6ab7a0b1 Author: Jonathan Bedard Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/setup.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/file_lock.py Log Message: --- [webkitcorepy] Support multiple autoinstallers running in parallel https://bugs.webkit.org/show_bug.cgi?id=256933 rdar://109488201 Reviewed by Alexey Proskuryakov. Lay down a lockfile so that only one autoinstaller process can modify an autoinstall location at a time. * Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py: (Package.install): While installing a package, acquire the lock to prevent other processes from installing packages while this one is. (AutoInstall): Define manifest.json and lockfile as class members. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/file_lock.py: (FileLock.acquire): Disable patch in Timeout to avoid infinite recursion. Canonical link: https://commits.webkit.org/264322@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c10ca: [webkitcorepy] Fix race condition in FileLock
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c10cac855587753cfb42e0e7f3b62e2480eb62e https://github.com/WebKit/WebKit/commit/1c10cac855587753cfb42e0e7f3b62e2480eb62e Author: Jonathan Bedard Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/setup.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/file_lock.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/file_lock_unittest.py Log Message: --- [webkitcorepy] Fix race condition in FileLock https://bugs.webkit.org/show_bug.cgi?id=256931 rdar://109487762 Reviewed by Alexey Proskuryakov. * Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/file_lock.py: (FileLock.is_process_running): Check if a specific PID is running. (FileLock.acquire): Create and acquire lock in a single operation on Unix systems. Save the current PID to the file, which allows future processes to ignore this lock if the PID saved in it is dead. For systems which support it, use O_EXLOCK and interrupts instead of a spinlock. Raise exceptions when we fail to acquire the lock. (FileLock.release): Delete the lockfile before releasing it on Unix systems. Systems using O_EXLOCK simply need to close their file handle. (FileLock.__exit__): Don't raise a 2nd exception if __enter__ has raised one. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/file_lock_unittest.py: (action): (FileLockTestCase.test_locked): (FileLockTestCase.test_locked_timeout): (FileLockTestCase.test_double): (FileLockTestCase.test_race): Canonical link: https://commits.webkit.org/264321@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e29a8: AX: Schedule the accessibility regions paint befor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e29a8fa8f79edd8288745d4ba1adcb839b597bf https://github.com/WebKit/WebKit/commit/1e29a8fa8f79edd8288745d4ba1adcb839b597bf Author: Andres Gonzalez Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp Log Message: --- AX: Schedule the accessibility regions paint before building the isolated tree. https://bugs.webkit.org/show_bug.cgi?id=257045 Reviewed by Tyler Wilcock. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreateIsolatedTree): Moved the call to scheduleObjectRegionsUpdate before the creation of the isolated tree so that the relative frame can be cached in the isolated objects that are about to be created. (WebCore::AXObjectCache::buildIsolatedTree): Fixed the notifications sent after the whole isolated tree is built. * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::createEmptyContent): Set the initial focused object in the newly created empty isolated tree to the WebArea. Canonical link: https://commits.webkit.org/264320@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d17df: [GStreamer] Element factories stored in registry s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d17df994a9eaa9c0142df92b23b3b136f846e5d https://github.com/WebKit/WebKit/commit/8d17df994a9eaa9c0142df92b23b3b136f846e5d Author: Philippe Normand Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp Log Message: --- [GStreamer] Element factories stored in registry scanner reported as leaked https://bugs.webkit.org/show_bug.cgi?id=257081 Reviewed by Xabier Rodriguez-Calvar. Valid `selectedFactory` ends up stored in the scanner singleton, so flag it as MAYBE_LEAKED. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForCaps const): Canonical link: https://commits.webkit.org/264319@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3aa8c0: [WebGPU] Incorrect default value for GPUPrimitiveS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3aa8c01094ba1d3765933b98ed4aca3f796d7c74 https://github.com/WebKit/WebKit/commit/3aa8c01094ba1d3765933b98ed4aca3f796d7c74 Author: Tadeu Zagallo Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp Log Message: --- [WebGPU] Incorrect default value for GPUPrimitiveState.topology https://bugs.webkit.org/show_bug.cgi?id=257024 rdar://109564272 Reviewed by Myles C. Maxfield. Although the IDL has the correct default value, while converting between PAL::WebGPU::RenderPipelineDescriptor and WGPURenderPipelineDescriptor, we set the topology to `point-list` when not explicitly specified. * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp: (PAL::WebGPU::convertToBacking): Canonical link: https://commits.webkit.org/264318@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 554289: [GStreamer] Typo fix in MediaPlayerPrivateGStreame...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 554289577e26cf5cc58df3eb3eb576d37a641c37 https://github.com/WebKit/WebKit/commit/554289577e26cf5cc58df3eb3eb576d37a641c37 Author: Žan Doberšek Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer] Typo fix in MediaPlayerPrivateGStreamer::handleMessage() https://bugs.webkit.org/show_bug.cgi?id=257111 Unreviewed build fix in MediaPlayerPrivateGStreamer::handleMessage(), fixing a pair of typos in a rare-ish platform block of GST_MESSAGE_STATE_CHANGE handling. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Canonical link: https://commits.webkit.org/264317@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 49647f: [WGSL] Don't modify the user-defined vertex output...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 49647f66ed78c1542903200be12d1e213e7bbaab https://github.com/WebKit/WebKit/commit/49647f66ed78c1542903200be12d1e213e7bbaab Author: Tadeu Zagallo Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebGPU/WGSL/EntryPointRewriter.cpp M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/WGSLShaderModule.h Log Message: --- [WGSL] Don't modify the user-defined vertex output struct https://bugs.webkit.org/show_bug.cgi?id=257032 rdar://109565231 Reviewed by Myles C. Maxfield. The user-defined struct can be used for other purposes, and it's not safe to modify it. * Source/WebGPU/WGSL/EntryPointRewriter.cpp: (WGSL::EntryPointRewriter::checkReturnType): * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/WGSLShaderModule.h: (WGSL::ShaderModule::replace): (WGSL::ShaderModule::std::enable_if_thttps://commits.webkit.org/264316@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] acbaa4: [WGSL] Add support for private global variables
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: acbaa4f2a24bdd437164bcbb020e72ee27ea2932 https://github.com/WebKit/WebKit/commit/acbaa4f2a24bdd437164bcbb020e72ee27ea2932 Author: Tadeu Zagallo Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp Log Message: --- [WGSL] Add support for private global variables https://bugs.webkit.org/show_bug.cgi?id=257034 rdar://109565923 Reviewed by Myles C. Maxfield. Previously we only support global resources, this is the first iteration for supporting global variables in the `private` address space. * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::visitEntryPoint): (WGSL::RewriteGlobalVariables::determineUsedGlobals): (WGSL::RewriteGlobalVariables::insertStructs): (WGSL::RewriteGlobalVariables::insertParameters): (WGSL::RewriteGlobalVariables::insertLocalDefinitions): Canonical link: https://commits.webkit.org/264315@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e511c2: [WGSL] Add support for calls with simple built-in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e511c232f3f7a97c1ee7f4c8a0b50d4eb0f03e1a https://github.com/WebKit/WebKit/commit/e511c232f3f7a97c1ee7f4c8a0b50d4eb0f03e1a Author: Tadeu Zagallo Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/Parser.cpp Log Message: --- [WGSL] Add support for calls with simple built-in types https://bugs.webkit.org/show_bug.cgi?id=257028 rdar://109564906 Reviewed by Myles C. Maxfield. Allow function calls with simple built-in types (i.e. function-style cast) such as `f32(x)`. The way we currently handle it is not great, since we treat type names as keywords in the lexer, but all of this will have to be refactored soon when we update the parser to solve the template ambiguity. For now, this unblocks a few more CTS tests to pass. * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parsePrimaryExpression): Canonical link: https://commits.webkit.org/264314@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d5fe1: [WGSL] Global variables don't need to be mangled
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d5fe1667498ade1a7ad5edf54d4542e852f6f15 https://github.com/WebKit/WebKit/commit/4d5fe1667498ade1a7ad5edf54d4542e852f6f15 Author: Tadeu Zagallo Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebGPU/WGSL/MangleNames.cpp Log Message: --- [WGSL] Global variables don't need to be mangled https://bugs.webkit.org/show_bug.cgi?id=257025 rdar://109564753 Reviewed by Myles C. Maxfield. The final program does not contain any global variables, so we don't need to mangle them * Source/WebGPU/WGSL/MangleNames.cpp: (WGSL::MangledName::toString const): (WGSL::NameManglerVisitor::visitFunctionBody): (WGSL::NameManglerVisitor::visit): Canonical link: https://commits.webkit.org/264313@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 140a13: REGRESSION (262629@main): [ wk2 ] webgl/webgl-meta...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 140a13b384e73ce2e33cde7cbf8a58076f11ab52
https://github.com/WebKit/WebKit/commit/140a13b384e73ce2e33cde7cbf8a58076f11ab52
Author: Kimmo Kinnunen
Date: 2023-05-22 (Mon, 22 May 2023)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-bigsur/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations
A LayoutTests/webgl/webgl-backend-type-expected.txt
A LayoutTests/webgl/webgl-backend-type.html
M
LayoutTests/webgl/webgl-fail-remote-context-ipc-buffer-allocation-no-crash.html
R LayoutTests/webgl/webgl-metal-disabled-expected.txt
R LayoutTests/webgl/webgl-metal-disabled.html
R LayoutTests/webgl/webgl-metal-enabled-expected.txt
R LayoutTests/webgl/webgl-metal-enabled.html
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebCore/testing/Internals.mm
Log Message:
---
REGRESSION (262629@main): [ wk2 ] webgl/webgl-metal-enabled.html is a
constant failure
https://bugs.webkit.org/show_bug.cgi?id=256841
rdar://108629326
Reviewed by Dan Glastonbury.
Remove webgl-metal-disabled.html webgl-metal-enabled.html
It's overly verbose, needing quite low-level access in Internals.
Also the condition platformSupportsMetal() is not accurate anymore
and it cannot work, as the feature detection cannot be done in WP
with IOKit blocking.
This is already tested with webgl/webgl-via-metal-flag-{off,on}.html
These test uses translated shader source to detect "did it use Metal".
webgl/webgl-via-metal-flag-off.html should pass when platform supports
OpenGL.
webgl/webgl-via-metal-flag-on.html should pass when platform supports
Metal.
Add a new test:
webgl/webgl-backend-type.html
Outputs the default backend type. This can be used to ensure that the
default does not flip accidentally.
Removes Internals::hasLowAndHighPowerGPUs(), similarly current
implementation cannot work with IOKit blocking, and the function is not
used at all.
* LayoutTests/TestExpectations:
* LayoutTests/webgl/webgl-metal-disabled-expected.txt: Removed.
* LayoutTests/webgl/webgl-metal-disabled.html: Removed.
* LayoutTests/webgl/webgl-metal-enabled-expected.txt: Removed.
* LayoutTests/webgl/webgl-metal-enabled.html: Removed.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::requestedMetal): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.mm:
(WebCore::Internals::platformSupportsMetal): Deleted.
Canonical link: https://commits.webkit.org/264312@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
