[webkit-changes] [WebKit/WebKit] 38e5d1: Correct return value in URLParser::defaultPortForP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 38e5d18210f94c26f20e4eae500015deef740081 https://github.com/WebKit/WebKit/commit/38e5d18210f94c26f20e4eae500015deef740081 Author: Anne van Kesteren Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/percent-encoding.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/resources/percent-encoding.json M LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt M Source/WTF/wtf/URLParser.cpp Log Message: --- Correct return value in URLParser::defaultPortForProtocol() https://bugs.webkit.org/show_bug.cgi?id=257441 rdar://109947586 Reviewed by Alex Christensen. It returns an optional integer, not a boolean. Tests for this specific case are exported via https://github.com/web-platform-tests/wpt/pull/40278. * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/percent-encoding.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/resources/percent-encoding.json: * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt: * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::defaultPortForProtocol): Canonical link: https://commits.webkit.org/264661@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e28ed6: [Curl] Remove the legacy CurlDownload code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e28ed6a22681dd39c13bf7564fe9464b7f217241 https://github.com/WebKit/WebKit/commit/e28ed6a22681dd39c13bf7564fe9464b7f217241 Author: Kenji Shukuwa Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/platform/Curl.cmake R Source/WebCore/platform/network/curl/CurlDownload.cpp R Source/WebCore/platform/network/curl/CurlDownload.h Log Message: --- [Curl] Remove the legacy CurlDownload code https://bugs.webkit.org/show_bug.cgi?id=257468 Reviewed by Fujii Hironori. WinCairo WK1 was removed. So CurlDownload[.h|.cpp] is no longer needed. * Source/WebCore/platform/Curl.cmake: * Source/WebCore/platform/network/curl/CurlDownload.cpp: Removed. * Source/WebCore/platform/network/curl/CurlDownload.h: Removed. Canonical link: https://commits.webkit.org/264660@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 023f54: [WebGL] Abstract working with EGL sync objects cre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 023f54b8e5b80830c6d4eee7f54143aa4d15b9b9 https://github.com/WebKit/WebKit/commit/023f54b8e5b80830c6d4eee7f54143aa4d15b9b9 Author: Dan Glastonbury Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/platform/graphics/GraphicsContextGL.h M Source/WebCore/platform/graphics/GraphicsTypesGL.h M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp M Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm M Tools/Scripts/generate-gpup-webgl Log Message: --- [WebGL] Abstract working with EGL sync objects created from MTLSharedEvent https://bugs.webkit.org/show_bug.cgi?id=256954 rdar://problem/109502752 Reviewed by Kimmo Kinnunen. When the GPU process is enabled, the Web process no long has access to the APIs required to create shared events passed from the UI process. This change added APIs to allow creationg of sync objects from events that can be represented by a MachSendRight (MTLSharedEvent), that can be used in the Web or GPU process. Support work for WebXR in GPUP. * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebCore/platform/graphics/GraphicsTypesGL.h: * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::createEGLSync): (WebCore::GraphicsContextGLANGLE::destroyEGLSync): (WebCore::GraphicsContextGLANGLE::clientWaitEGLSyncWithFlush): * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::createEGLSync): (WebCore::GraphicsContextGLCocoa::insertFinishedSignalOrInvoke): (WebCore::GraphicsContextGLCocoa::createSyncWithSharedEvent): Deleted. (WebCore::GraphicsContextGLCocoa::destroySync): Deleted. (WebCore::GraphicsContextGLCocoa::clientWaitSyncWithFlush): Deleted. * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp: (WebKit::RemoteGraphicsContextGLCocoa::createEGLSync): * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h: (destroyEGLSync): (clientWaitEGLSyncWithFlush): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp: (WebKit::RemoteGraphicsContextGLProxy::createEGLSync): * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp: (WebKit::RemoteGraphicsContextGLProxy::destroyEGLSync): (WebKit::RemoteGraphicsContextGLProxy::clientWaitEGLSyncWithFlush): * Tools/Scripts/generate-gpup-webgl: Canonical link: https://commits.webkit.org/264659@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd5518: Add runtime logging to AudioSession and related cl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd551880cee9f2657d8d315d51eea9ac9c40d73e https://github.com/WebKit/WebKit/commit/cd551880cee9f2657d8d315d51eea9ac9c40d73e Author: Eric Carlson Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/platform/audio/AudioSession.cpp M Source/WebCore/platform/audio/AudioSession.h M Source/WebCore/platform/audio/ios/AudioSessionIOS.mm M Source/WebCore/platform/audio/mac/AudioSessionMac.h M Source/WebCore/platform/audio/mac/AudioSessionMac.mm M Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.h M Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.mm M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.h M Source/WebKit/UIProcess/Media/AudioSessionRoutingArbitratorProxy.cpp M Source/WebKit/UIProcess/Media/AudioSessionRoutingArbitratorProxy.h M Source/WebKit/UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.cpp M Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.h Log Message: --- Add runtime logging to AudioSession and related classes https://bugs.webkit.org/show_bug.cgi?id=257431 rdar://109934372 Reviewed by Youenn Fablet. * Source/WebCore/platform/audio/AudioSession.cpp: (WebCore::AudioSession::tryToSetActive): (WebCore::AudioSession::beginInterruption): (WebCore::AudioSession::endInterruption): (WebCore::AudioSession::setCategoryOverride): (WebCore::AudioSession::logger): (WebCore::AudioSession::logChannel const): * Source/WebCore/platform/audio/AudioSession.h: * Source/WebCore/platform/audio/ios/AudioSessionIOS.mm: (WebCore::AudioSessionIOS::setHostProcessAttribution): (WebCore::AudioSessionIOS::setPresentingProcesses): (WebCore::AudioSessionIOS::setCategory): (WebCore::AudioSessionIOS::setPreferredBufferSize): * Source/WebCore/platform/audio/mac/AudioSessionMac.h: * Source/WebCore/platform/audio/mac/AudioSessionMac.mm: (WebCore::AudioSessionMac::audioOutputDeviceChanged): (WebCore::AudioSessionMac::setIsPlayingToBluetoothOverride): (WebCore::AudioSessionMac::setCategory): (WebCore::AudioSessionMac::setPreferredBufferSize): (WebCore::AudioSessionMac::logChannel const): (WebCore::AudioSessionMac::logIdentifier const): * Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.h: * Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.mm: (WebCore::SharedRoutingArbitrator::Token::logIdentifier const): (WebCore::SharedRoutingArbitrator::beginRoutingArbitrationForToken): (WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken): (WebCore::SharedRoutingArbitrator::setLogger): (WebCore::SharedRoutingArbitrator::logger): (WebCore::SharedRoutingArbitrator::logChannel const): * Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp: (WebKit::LocalAudioSessionRoutingArbitrator::LocalAudioSessionRoutingArbitrator): (WebKit::LocalAudioSessionRoutingArbitrator::beginRoutingArbitrationWithCategory): (WebKit::LocalAudioSessionRoutingArbitrator::logger): (WebKit::LocalAudioSessionRoutingArbitrator::logChannel const): (WebKit::LocalAudioSessionRoutingArbitrator::canLog const): * Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.h: * Source/WebKit/UIProcess/Media/AudioSessionRoutingArbitratorProxy.cpp: (WebKit::AudioSessionRoutingArbitratorProxy::AudioSessionRoutingArbitratorProxy): (WebKit::AudioSessionRoutingArbitratorProxy::logger): (WebKit::AudioSessionRoutingArbitratorProxy::logChannel const): * Source/WebKit/UIProcess/Media/AudioSessionRoutingArbitratorProxy.h: (WebKit::AudioSessionRoutingArbitratorProxy::logIdentifier const): (WebKit::AudioSessionRoutingArbitratorProxy::logClassName const): * Source/WebKit/UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm: (WebKit::AudioSessionRoutingArbitratorProxy::AudioSessionRoutingArbitratorProxy): (WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory): (WebKit::AudioSessionRoutingArbitratorProxy::endRoutingArbitration): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): (WebKit::m_routingArbitrator): (WebKit::WebProcessProxy::setWebsiteDataStore): (WebKit::WebProcessProxy::logger): (WebKit::m_webPermissionController): Deleted. * Source/WebKit/UIProcess/WebProcessProxy.h: * Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.cpp: (WebKit::m_logIdentifier): (WebKit::AudioSessionRoutingArbitrator::canLog const): * Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.h: Canonical link: https://commits.webkit.org/264658@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org
[webkit-changes] [WebKit/WebKit] 3719e0: Remove HTML conformance concepts from MathML code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3719e049046bfe237cc3d0aa041735cbb8a68d41 https://github.com/WebKit/WebKit/commit/3719e049046bfe237cc3d0aa041735cbb8a68d41 Author: Anne van Kesteren Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html-integration-point-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/math-parse03-expected.txt M LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-non-html-expected.txt M LayoutTests/mathml/presentation/foreign-element-in-annotation-xml-expected.txt M LayoutTests/mathml/presentation/foreign-element-in-annotation-xml.html M LayoutTests/mathml/presentation/foreign-element-in-token-expected.txt M LayoutTests/mathml/presentation/foreign-element-in-token.html A LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt M LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt R LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt R LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt A LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt R LayoutTests/platform/wpe/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt M Source/WebCore/mathml/MathMLAnnotationElement.cpp M Source/WebCore/mathml/MathMLPresentationElement.cpp M Source/WebCore/mathml/MathMLPresentationElement.h M Source/WebCore/mathml/MathMLTokenElement.cpp Log Message: --- Remove HTML conformance concepts from MathML code https://bugs.webkit.org/show_bug.cgi?id=256833 rdar://109710721 Reviewed by Frédéric Wang. MathML should not be itself validating what elements can and cannot be nested inside of it. It's really a function of the node tree and CSS whether something ends up rendering or not. * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html-integration-point-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/math-parse03-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-non-html-expected.txt: * LayoutTests/mathml/presentation/foreign-element-in-annotation-xml-expected.txt: * LayoutTests/mathml/presentation/foreign-element-in-annotation-xml.html: * LayoutTests/mathml/presentation/foreign-element-in-token-expected.txt: * LayoutTests/mathml/presentation/foreign-element-in-token.html: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Renamed from LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Removed. * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: * LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: * LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Renamed from LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Removed. * Source/WebCore/mathml/MathMLAnnotationElement.cpp: (WebCore::MathMLAnnotationElement::childShouldCreateRenderer const): * Source/WebCore/mathml/MathMLPresentationElement.cpp: (WebCore::MathMLPresentationElement::isPhrasingContent): Deleted. (WebCore::MathMLPresentationElement::isFlowContent): Deleted. * Source/WebCore/mathml/MathMLPresentationElement.h: * Source/WebCore/mathml/MathMLTokenElement.cpp: (WebCore::MathMLTokenElement::childShouldCreateRenderer const): Canonical link: https://commits.webkit.org/264657@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 62e378: No need to trim whitespace before parsing as a URL
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 62e378d5047e24a0de8c2614906fdc5cc0ee010e https://github.com/WebKit/WebKit/commit/62e378d5047e24a0de8c2614906fdc5cc0ee010e Author: Anne van Kesteren Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/editing/cocoa/HTMLConverter.mm M Source/WebCore/editing/gtk/EditorGtk.cpp M Source/WebCore/editing/ios/EditorIOS.mm M Source/WebCore/html/HTMLBaseElement.cpp M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLFormElement.cpp M Source/WebCore/html/HTMLImageElement.cpp M Source/WebCore/html/parser/HTMLPreloadScanner.cpp M Source/WebCore/mathml/MathMLElement.cpp M Source/WebCore/page/DragController.cpp M Source/WebCore/rendering/HitTestResult.cpp M Source/WebCore/svg/SVGImageLoader.cpp M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Source/WebKitLegacy/mac/DOM/DOM.mm M Source/WebKitLegacy/mac/DOM/DOMHTML.mm M Source/WebKitLegacy/mac/DOM/WebDOMOperations.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm Log Message: --- No need to trim whitespace before parsing as a URL https://bugs.webkit.org/show_bug.cgi?id=257438 rdar://109939661 Reviewed by Michael Catanzaro and Alex Christensen. The URL parser already trims all C0 controls and space code points. * Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp: (WebCore::YouTubePluginReplacement::youTubeURL): * Source/WebCore/dom/Element.cpp: (WebCore::Element::absoluteLinkURL const): * Source/WebCore/editing/cocoa/HTMLConverter.mm: (HTMLConverter::_addLinkForElement): (HTMLConverter::_processElement): * Source/WebCore/editing/gtk/EditorGtk.cpp: (WebCore::Editor::writeImageToPasteboard): * Source/WebCore/editing/ios/EditorIOS.mm: (WebCore::Editor::writeImageToPasteboard): * Source/WebCore/html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::href const): * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::formAction const): * Source/WebCore/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::action const): * Source/WebCore/html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::isServerMap const): * Source/WebCore/html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::updatePredictedBaseURL): * Source/WebCore/mathml/MathMLElement.cpp: (WebCore::MathMLElement::defaultEventHandler): * Source/WebCore/page/DragController.cpp: (WebCore::DragController::doSystemDrag): * Source/WebCore/rendering/HitTestResult.cpp: (WebCore::HitTestResult::absolutePDFURL const): * Source/WebCore/svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI const): * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::openFunc): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::elementPositionInformation): (WebKit::WebPage::performActionOnElement): * Source/WebKitLegacy/mac/DOM/DOM.mm: (-[DOMNode hrefURL]): (-[DOMElement _getURLAttribute:]): * Source/WebKitLegacy/mac/DOM/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): * Source/WebKitLegacy/mac/DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]): * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Canonical link: https://commits.webkit.org/264656@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5aa25a: DNS lookup should request then wait for IPv4 and I...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5aa25a106be747000c280a1e55134b906f9ffc41 https://github.com/WebKit/WebKit/commit/5aa25a106be747000c280a1e55134b906f9ffc41 Author: Alex Christensen Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/platform/network/DNS.cpp M Source/WebCore/platform/network/DNS.h M Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp Log Message: --- DNS lookup should request then wait for IPv4 and IPv6 addresses https://bugs.webkit.org/show_bug.cgi?id=257404 rdar://109911384 Reviewed by Youenn Fablet. As advised by one who knows DNS better than I do, with the code I wrote earlier today in https://github.com/WebKit/WebKit/pull/14326 I am missing some of the IP addresses. To receive a set of IP addresses equivalent to what CFHost received, I need to add the kDNSServiceFlagsReturnIntermediates flag. Also, there are some times when we receive IPv4 addresses then get a callback with kDNSServiceFlagsMoreComing and then sometime later receive IPv6 addresses, or vice versa. The addresses from the second set of callbacks were being dropped. To fix this, I explicitly add the protocols kDNSServiceProtocol_IPv4 | kDNSServiceProtocol_IPv6 to request callbacks for both protocols. This makes it so that sometimes I get callbacks with kDNSServiceErr_NoSuchRecord and callbacks with IP addresses that are all zeros. We simiply ignore kDNSServiceErr_NoSuchRecord and filter out all the all-zero IP addresses. That way the result of DNSResolveQueueCFNet::performDNSLookup always contains all the IP addresses. I manually verified that IP address lists were incomplete sometimes before this change, and now they are complete all the time. There are also two unit tests that exercise this code path, webrtc/datachannel/mdns-ice-candidates.html and TestWebKitAPI.WebKit2.RTCDataChannelPostMessage and I verified that they both pass. * Source/WebCore/platform/network/DNS.cpp: (WebCore::IPAddress::isAllZeros const): * Source/WebCore/platform/network/DNS.h: * Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp: (WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::complete): (WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::addIPAddress): (WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::shouldWaitForMoreAddresses const): (WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::filterZeroAddresses): (WebCore::dnsLookupCallback): (WebCore::DNSResolveQueueCFNet::performDNSLookup): Canonical link: https://commits.webkit.org/264655@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2caf60: [GTK][WPE] Mark fast/mediastream/RTCRtpSender-outl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2caf60ff3b66f466ff7ea3601f0227cdb9da5eae https://github.com/WebKit/WebKit/commit/2caf60ff3b66f466ff7ea3601f0227cdb9da5eae Author: Claudio Saavedra Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK][WPE] Mark fast/mediastream/RTCRtpSender-outlives-RTCPeerConnection.html as flaky Unreviewed gardening. This test is crashing a lot on GTK, a few times in WPE. Opened bug #257456 for investigation, mark the flakiness for now. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/264654@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6648ca: [GTK][WPE] imported/w3c/web-platform-tests/html/us...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6648ca5f20edbfc787d01d2661a987477fbdeee6 https://github.com/WebKit/WebKit/commit/6648ca5f20edbfc787d01d2661a987477fbdeee6 Author: Claudio Saavedra Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK][WPE] imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html?touch crashing https://bugs.webkit.org/show_bug.cgi?id=257454 Unreviewed gardening. * LayoutTests/platform/glib/TestExpectations: Skip until the patch in bug #233092 lands. Canonical link: https://commits.webkit.org/264653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/webkitgtk-2.40.2 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 92cd88: Unreviewed. Update OptionsGTK.cmake and NEWS for t...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: 92cd880b3f3d3d546b0431cd5d7da419e4cac98e https://github.com/WebKit/WebKit/commit/92cd880b3f3d3d546b0431cd5d7da419e4cac98e Author: Carlos Garcia Campos Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebKit/gtk/NEWS M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. Update OptionsGTK.cmake and NEWS for the 2.40.2 release * Source/WebKit/gtk/NEWS: Add release notes for 2.40.2. * Source/cmake/OptionsGTK.cmake: Bump version numbers. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ba090: [WGSL] Initial constant resolution implementation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ba090e99148d4ffea4f8c4ceb7cbf0dd60a5f37 https://github.com/WebKit/WebKit/commit/7ba090e99148d4ffea4f8c4ceb7cbf0dd60a5f37 Author: Tadeu Zagallo Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: A Source/WebGPU/WGSL/ConstantRewriter.cpp A Source/WebGPU/WGSL/ConstantRewriter.h M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/WGSL.cpp A Source/WebGPU/WGSL/tests/valid/constants.wgsl M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj Log Message: --- [WGSL] Initial constant resolution implementation https://bugs.webkit.org/show_bug.cgi?id=257381 rdar://109888410 Reviewed by Mike Wyrzykowski. Add a simple constant resolution phase. For now, it can only handle literals, but it will be expanded soon to handle other types of data and expressions. * Source/WebGPU/WGSL/ConstantRewriter.cpp: Added. (WGSL::ConstantValue::dump const): (WGSL::ConstantRewriter::ConstantRewriter): (WGSL::ConstantRewriter::rewrite): (WGSL::ConstantRewriter::visit): (WGSL::ConstantRewriter::evaluate): (WGSL::ConstantRewriter::materialize): (WGSL::ConstantRewriter::error): (WGSL::rewriteConstants): * Source/WebGPU/WGSL/ConstantRewriter.h: Added. * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::determineUsedGlobals): * Source/WebGPU/WGSL/WGSL.cpp: (WGSL::staticCheck): * Source/WebGPU/WGSL/tests/valid/constants.wgsl: Added. * Source/WebGPU/WebGPU.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/264652@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2d7aa: [GTK] Unreviewed non-unified build fix after 26458...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2d7aa707d713afb1f8368a6e2c01950455998df https://github.com/WebKit/WebKit/commit/e2d7aa707d713afb1f8368a6e2c01950455998df Author: Diego Pino Garcia Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/platform/network/DNS.cpp Log Message: --- [GTK] Unreviewed non-unified build fix after 264586@main https://bugs.webkit.org/show_bug.cgi?id=257303 Add missing header CompletionHandler.h. * Source/WebCore/platform/network/DNS.cpp: Canonical link: https://commits.webkit.org/264651@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cfcd3f: [WGSL] Incorrect swizzle validation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cfcd3f2f153c669fa78dd6d679c001b82b66996e https://github.com/WebKit/WebKit/commit/cfcd3f2f153c669fa78dd6d679c001b82b66996e Author: Tadeu Zagallo Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/tests/invalid/vector.wgsl A Source/WebGPU/WGSL/tests/valid/swizzle.wgsl Log Message: --- [WGSL] Incorrect swizzle validation https://bugs.webkit.org/show_bug.cgi?id=257378 rdar://109886275 Reviewed by Mike Wyrzykowski. Swizzle characters need to be checked for bounds, e.g. we can't access vec2.z, but the original patch was incorrectly checking the offset of the swizzle against the size of the resulting vector, not the vector we are loading from. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::vectorFieldAccess): * Source/WebGPU/WGSL/tests/invalid/vector.wgsl: * Source/WebGPU/WGSL/tests/valid/swizzle.wgsl: Added. Canonical link: https://commits.webkit.org/264650@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 93d7cf: Cherry-pick 264648@main (153153309cef). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: 93d7cfcb112d5dfbeea0a53de13880342883c40b https://github.com/WebKit/WebKit/commit/93d7cfcb112d5dfbeea0a53de13880342883c40b Author: Carlos Garcia Campos Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp Log Message: --- Cherry-pick 264648@main (153153309cef). https://bugs.webkit.org/show_bug.cgi?id=255398 [GTK] Crash in GraphicsContextGLGBM::allocateDrawBufferObject https://bugs.webkit.org/show_bug.cgi?id=255398 Reviewed by Michael Catanzaro. GBMBufferSwapchain::getBuffer() can return nullptr for several reasons, so we need to handle that case in GraphicsContextGLGBM::allocateDrawBufferObject(). This also adds error messages for the cases where getBuffer() returns nullptr, and returns earlier without creating any buffer when the given format is unsupported. * Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp: (WebCore::isBufferFormatSupported): (WebCore::GBMBufferSwapchain::getBuffer): * Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp: (WebCore::GraphicsContextGLGBM::allocateDrawBufferObject): Canonical link: https://commits.webkit.org/264648@main Commit: e64c4e78fd4256cf82fe1a43f840364621cfea51 https://github.com/WebKit/WebKit/commit/e64c4e78fd4256cf82fe1a43f840364621cfea51 Author: Carlos Garcia Campos Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/html/OffscreenCanvas.cpp Log Message: --- Unrviewed. Fix the build * Source/WebCore/html/OffscreenCanvas.cpp: (WebCore::shouldEnableWebGL): Fix unused parameter error. Compare: https://github.com/WebKit/WebKit/compare/b94d54bf819e...e64c4e78fd42 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7c487: Re-import html/semantics/popovers WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7c487a14b4d9e1b5841ff093bb4838e7431e729 https://github.com/WebKit/WebKit/commit/c7c487a14b4d9e1b5841ff093bb4838e7431e729 Author: Rob Buis Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-all-elements.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-css-properties.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-css-properties.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-child-dialog-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-child-dialog.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-crash.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hide-hide.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hide-hide.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hide-hover.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hide-hover.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hide-show.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hide-show.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hide-toggle.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hide-toggle.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-move-documents.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display-expected.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display.tentative-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-overlay-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-overlay.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-action-hover.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-action-hover.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types-with-hints.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types-with-hints.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-hover-hide-common.js M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log A
[webkit-changes] [WebKit/WebKit] 153153: [GTK] Crash in GraphicsContextGLGBM::allocateDrawB...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 153153309cef73f2b65f8dfc3991044e705fe5a5 https://github.com/WebKit/WebKit/commit/153153309cef73f2b65f8dfc3991044e705fe5a5 Author: Carlos Garcia Campos Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp Log Message: --- [GTK] Crash in GraphicsContextGLGBM::allocateDrawBufferObject https://bugs.webkit.org/show_bug.cgi?id=255398 Reviewed by Michael Catanzaro. GBMBufferSwapchain::getBuffer() can return nullptr for several reasons, so we need to handle that case in GraphicsContextGLGBM::allocateDrawBufferObject(). This also adds error messages for the cases where getBuffer() returns nullptr, and returns earlier without creating any buffer when the given format is unsupported. * Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp: (WebCore::isBufferFormatSupported): (WebCore::GBMBufferSwapchain::getBuffer): * Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp: (WebCore::GraphicsContextGLGBM::allocateDrawBufferObject): Canonical link: https://commits.webkit.org/264648@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ef427: [WGSL] Missing type promotion for AbstractScalarType
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ef427c5fc10d06956c7f9086a478638a0a1 https://github.com/WebKit/WebKit/commit/6ef427c5fc10d06956c7f9086a478638a0a1 Author: Tadeu Zagallo Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebGPU/WGSL/Overload.cpp Log Message: --- [WGSL] Missing type promotion for AbstractScalarType https://bugs.webkit.org/show_bug.cgi?id=257380 rdar://109887993 Reviewed by Mike Wyrzykowski. We currently have a duplicate implementation of Overload::materialize for type variables. This duplication will be removed soon, but in the mean time we are missing the promotion step to satisfy constraints in the type variable in one of them. * Source/WebGPU/WGSL/Overload.cpp: (WGSL::OverloadResolver::materialize const): Canonical link: https://commits.webkit.org/264647@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 435dd7: [GTK] Layout Test media/video-seek-with-negative-p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 435dd73cccb588f8caf5fba1ef4f59b63c843dbc https://github.com/WebKit/WebKit/commit/435dd73cccb588f8caf5fba1ef4f59b63c843dbc Author: Philippe Normand Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GTK] Layout Test media/video-seek-with-negative-playback.html timeouts on the release bot. https://bugs.webkit.org/show_bug.cgi?id=135086 Reviewed by Xabier Rodriguez-Calvar. The test was flaky timeout because sometimes the seek updating the playback rate was done before any of the sinks had reported a non-zero playback position. So we ended up doing a seek with both `start` and `end` positions set to zero, leading to a stall, no `timeupdate` event dispatched, hence test timing out. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::doSeek): Canonical link: https://commits.webkit.org/264646@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
