[webkit-changes] [WebKit/WebKit] 72da1b: [iOS] Set `-[VKCImageAnalyzerRequest imageSource]`...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72da1b34cd3a5c20f588514272d25140bbd94ff7 https://github.com/WebKit/WebKit/commit/72da1b34cd3a5c20f588514272d25140bbd94ff7 Author: Wenson Hsieh Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- [iOS] Set `-[VKCImageAnalyzerRequest imageSource]` when performing image analysis on paused videos https://bugs.webkit.org/show_bug.cgi?id=257844 rdar://109173247 Reviewed by Aditya Keerthi. Set the `-imageSource` flag to `VKImageAnalyzerRequestImageSourceVideoFrame` when triggering image analysis on iOS over paused videos, to help improve analytics for visual look up and object detection; no change in behavior, otherwise. * Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView imageAnalysisGestureDidBegin:]): (-[WKContentView _completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]): (-[WKContentView imageAnalysisGestureDidTimeOut:]): (-[WKContentView beginTextRecognitionForFullscreenVideo:playerViewController:]): (-[WKContentView beginTextRecognitionForVideoInElementFullscreen:bounds:]): Canonical link: https://commits.webkit.org/264976@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 074a78: [WGSL] Initial support for packing and unpacking v...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 074a78d9d7fba2ccf27d4d98fd25cdddb638a498 https://github.com/WebKit/WebKit/commit/074a78d9d7fba2ccf27d4d98fd25cdddb638a498 Author: Tadeu Zagallo Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebGPU/WGSL/AST/ASTStructure.h M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/tests/valid/packing.wgsl Log Message: --- [WGSL] Initial support for packing and unpacking values on assignment https://bugs.webkit.org/show_bug.cgi?id=257797 rdar://110389019 Reviewed by Dan Glastonbury. In 264864@main I started the process of distinguishing between structs that need to be "packed", i.e. respect the size and alignment of types as defined in the WGSL spec. This is the first patch that introduces explicit convertions between packed and unpacked structs. For now, we only pack/unpack at assignments, which is not enough, but other patches will follow extending this functionality to other operations. * Source/WebGPU/WGSL/AST/ASTStructure.h: * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::visit): (WGSL::RewriteGlobalVariables::pack): (WGSL::RewriteGlobalVariables::getPacking): (WGSL::RewriteGlobalVariables::packResourceStruct): * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::write): (WGSL::Metal::FunctionDefinitionWriter::generatePackingHelpers): * Source/WebGPU/WGSL/tests/valid/packing.wgsl: Canonical link: https://commits.webkit.org/264975@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba3971: bbc.co.uk: Video goes black with only audio playin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba3971672860729711b0a50ce424ab62ca319ca7 https://github.com/WebKit/WebKit/commit/ba3971672860729711b0a50ce424ab62ca319ca7 Author: Jean-Yves Avenard Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/dom/FullscreenManager.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- bbc.co.uk: Video goes black with only audio playing when exiting PiP mode https://bugs.webkit.org/show_bug.cgi?id=257711 rdar://108304377 Reviewed by Jer Noble. Only fire the fullscreen change event once we did enter fullscreen. This gives time for the UI process to complete exiting PiP in the UI process. The process for exiting PiP and go back into fullscreen is a complicated (and unnecessary) dance between the content and the UI process. didStopPictureInPicture (UI) -> requestRestoreFullScreen (CP) -> EnterFullScreen (UI) -> WillEnterFullscreen (CP) -> beganEnterFullScreen (UI) -> didEnterFullScreen (UI) -> didEnterFullScreen (CP) Previously, the events `fullscreenchange` was fired in WillEnterFullscreen. if a JS event listener was set, and attempted to exit PiP then (as BBC website is doing) it would have left VideoFullscreenInterfaceAVKit in a broken state once it received `beganEnterFullScreen` as it's not an handled chained of event. By letting the UI process complete the exit of PiP back to fullscreen, we can avoid the problem from occurring alltogether, and this is simply done by firing the events and resolving the promise in didEnterFullScreen. We limit this behaviour to BBC.com This entire code is in serious need of a rewrite. Manually tested under all possible interface scenarios: - Entering PiP, Exiting PiP using BBC main player control. - Entering PiP, Exiting PiP using PiP controller button. - Entering fullscreen via BBC control, entering PiP using PiP button, exiting PiP using BBC main player control - As above but using PiP controller button as last step. - Going into Auto-Pip by swiping home and exiting PiP. - Entering PiP, quitting PiP (X button) * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::willEnterFullscreen): (WebCore::FullscreenManager::didEnterFullscreen): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDelayFullscreenEventWhenExitingPictureInPictureQuirk const): * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/264974@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c38822: Inline-level elements with self-painting layer ren...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c38822c4ed1cacacccbaf4c04dbd02047ad5ebed https://github.com/WebKit/WebKit/commit/c38822c4ed1cacacccbaf4c04dbd02047ad5ebed Author: Alan Baradlay Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: A LayoutTests/fast/inline/overflow-truncate-with-self-painting-layer-expected.html A LayoutTests/fast/inline/overflow-truncate-with-self-painting-layer.html A LayoutTests/fast/inline/overflow-truncate-with-self-painting-layer2-expected.html A LayoutTests/fast/inline/overflow-truncate-with-self-painting-layer2.html M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h Log Message: --- Inline-level elements with self-painting layer renders overlapping ellipsis. https://bugs.webkit.org/show_bug.cgi?id=257811 Reviewed by Simon Fraser. "text-overflow: ellipsis" visually replaces partially overflowing content with "..." We achieve this by 1. skipping partially overflowing content at paint time (text content gets partially truncated, while inline level boxes are skipped completely) 2. paint "..." starting from where the truncated inline content ends ("overflow: hidden" takes care of clipping the remaining, fully overflowing content) This patch ensures that such truncated boxes don't get painted even when they are on self-painting layers. * LayoutTests/fast/inline/overflow-truncate-with-self-painting-layer-expected.html: Added. * LayoutTests/fast/inline/overflow-truncate-with-self-painting-layer.html: Added. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions): At this point we finished with inline layout and start transferring geometry/state information over to the render tree. Let's update the associated RenderLayers here. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::computeHasVisibleContent const): * Source/WebCore/rendering/RenderLayer.h: (WebCore::RenderLayer::setIsHiddenByOverflowTruncation): Canonical link: https://commits.webkit.org/264973@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 902999: CSSOMViewScrollingAPIEnabled is "unstable" but ena...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 90299984e9e74856648e16281d519ad1003b6e6e https://github.com/WebKit/WebKit/commit/90299984e9e74856648e16281d519ad1003b6e6e Author: Elliott Williams Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- CSSOMViewScrollingAPIEnabled is "unstable" but enabled by default https://bugs.webkit.org/show_bug.cgi?id=257841 Reviewed by Tim Nguyen and Simon Fraser. Set its status to stable. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/264972@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d1500: [Cocoa] Enable HEIC
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d15007530ba97cafde25c94d23e3ec6bb6dafe4 https://github.com/WebKit/WebKit/commit/8d15007530ba97cafde25c94d23e3ec6bb6dafe4 Author: Myles C. Maxfield Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M LayoutTests/fast/canvas/toDataURL-unsupportedTypes-expected.txt M LayoutTests/fast/canvas/toDataURL-unsupportedTypes.html M LayoutTests/fast/forms/file/entries-api/image-no-transcode-drag-drop-expected.txt M LayoutTests/fast/forms/file/entries-api/image-no-transcode-open-panel-expected.txt M LayoutTests/fast/images/animated-heics-draw.html M LayoutTests/fast/images/animated-heics-verify.html M LayoutTests/fast/images/heic-as-background-image.html M LayoutTests/http/tests/misc/heic-accept-header.html M Source/WTF/wtf/PlatformHave.h M Source/WebCore/loader/cache/CachedResourceRequest.cpp M Source/WebCore/platform/MIMETypeRegistry.cpp M Source/WebCore/platform/graphics/cg/UTIRegistry.cpp Log Message: --- [Cocoa] Enable HEIC https://bugs.webkit.org/show_bug.cgi?id=257763 rdar://110346646 Reviewed by Said Abou-Hallawa. There are 3 reasons to enable it: 1. HEIC uses the same technology as H.265 videos, which are already enabled by default in many (most? almost all?) major browsers. So there is no concern about increasing the surface area of new technology on the web. 2. It's just a true fact that there are just a lot of HEIC images out there in the wild. Some of them end up on the internet. You can't stop them. It just happens. 3. Apple's devices have hardware decoders for HEIC, which make them both more performant and use less energy than other image formats. Running some tests, using hardware decoding HEIC images uses 26% less power and 13% less time than using software decoding of AVIF, for (roughly) equivalent quality images. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/loader/cache/CachedResourceRequest.cpp: (WebCore::acceptHeaderValueForHEICImageResource): (WebCore::acceptHeaderValueForImageResource): * Source/WebCore/platform/MIMETypeRegistry.cpp: * Source/WebCore/platform/graphics/cg/UTIRegistry.cpp: (WebCore::defaultSupportedImageTypes): Canonical link: https://commits.webkit.org/264971@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d5581f: Unreviewed, reverting 264961@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5581fe7e0ef2455469990b0189007e004c7173c https://github.com/WebKit/WebKit/commit/d5581fe7e0ef2455469990b0189007e004c7173c Author: Commit Queue Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj R Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.h R Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.mm M Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm Log Message: --- Unreviewed, reverting 264961@main. https://bugs.webkit.org/show_bug.cgi?id=257843 broke Apple internal builds Reverted changeset: "[Cocoa] Move new LockdownMode Framework to Open Source" https://bugs.webkit.org/show_bug.cgi?id=257761 https://commits.webkit.org/264961@main Canonical link: https://commits.webkit.org/264970@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce1f5b: REGRESSION (264086@main): [iOS 17] Autocorrect hig...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce1f5b1c5dd74c19b8833b169298249b915d0901 https://github.com/WebKit/WebKit/commit/ce1f5b1c5dd74c19b8833b169298249b915d0901 Author: Wenson Hsieh Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/dom/SimpleRange.h M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm Log Message: --- REGRESSION (264086@main): [iOS 17] Autocorrect highlight is sometimes incorrect in Mail compose https://bugs.webkit.org/show_bug.cgi?id=257830 rdar://109582406 Reviewed by Megan Gardner and Aditya Keerthi. The refactoring in 264086@main introduced a subtle behavior change in the case where the text iterator emits spaces for soft line breaks in an `_editable` web view. When emitting text for a soft line break, we previously appended the zero rect in the list of `textRects` for this character range; however, after `264086@main`, we now skip the rect altogether, which causes the list of rects to fall out of sync with the combined `contextBefore` + `selectedText` + `contextAfter` string. Consequently, UIKit (which currently assumes that indices into the string correspond directly to indices of rects in `textRects`) ends up using the wrong character layout rects. This patch fixes the above by restoring preexisting behavior and appending a single empty rect in the case where the text iterator finds (non-empty) text, but there are no character rects. Additionally, I attempted to add a debug assertion to verify that the number of resulting text rects is always consistent with the combined length of the context and selection strings; however, this uncovered some bugs in the existing implementation, even prior the changes in 264086@main, where we would sometimes end up with either too many or too few rects, when running the following three layout tests: • editing/selection/ios/update-selection-after-iframe-scroll.html • editing/selection/ios/update-selection-after-overflow-scroll.html • editing/selection/shift-click-includes-existing-selection.html This patch fixes the assertion in `editing/selection/shift-click-includes-existing-selection.html`, where we end up with too many text rects due to the fact that the text iterator advances to both the upstream and downstream positions of a line break, emitting "\n" both times with the same rect. To avoid this, we keep track of the last `SimpleRange` we observed, and avoid emitting a duplicate rect in the case where we advance to the a range we just visited. Test: DocumentEditingContext.CharacterRectsInEditableWebView * Source/WebCore/dom/SimpleRange.h: * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::requestDocumentEditingContext): * Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Canonical link: https://commits.webkit.org/264969@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da98ff: Generate serialization of WCUpdateInfo structures
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da98ff9957fb6271100ae900060ef9293868edea https://github.com/WebKit/WebKit/commit/da98ff9957fb6271100ae900060ef9293868edea Author: Don Olmstead Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/PlatformPlayStation.cmake M Source/WebKit/PlatformWin.cmake M Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h A Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in Log Message: --- Generate serialization of WCUpdateInfo structures https://bugs.webkit.org/show_bug.cgi?id=257839 Reviewed by Fujii Hironori. Add generated serializers of `WCTileUpdate` and `WCUpdateInfo`. * Source/WebKit/PlatformPlayStation.cmake: * Source/WebKit/PlatformWin.cmake: * Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h: (WebKit::WCTileUpdate::encode const): Deleted. (WebKit::WCTileUpdate::decode): Deleted. (WebKit::WCUpdateInfo::encode const): Deleted. (WebKit::WCUpdateInfo::decode): Deleted. * Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in: Added. Canonical link: https://commits.webkit.org/264968@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0e3fcb: [JSC] Add global replace caching
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e3fcb9531e248c468366393fd4f2127ea5dcb56 https://github.com/WebKit/WebKit/commit/0e3fcb9531e248c468366393fd4f2127ea5dcb56 Author: Yusuke Suzuki Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: A JSTests/stress/v8-regexp-results-cache.js A JSTests/stress/v8-string-replace-cache.js A JSTests/stress/v8-string-replace.js M Source/JavaScriptCore/CMakeLists.txt M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/heap/Heap.cpp M Source/JavaScriptCore/runtime/ArgList.h M Source/JavaScriptCore/runtime/JSImmutableButterfly.cpp M Source/JavaScriptCore/runtime/JSImmutableButterfly.h M Source/JavaScriptCore/runtime/OptionsList.h M Source/JavaScriptCore/runtime/RegExpGlobalData.h M Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h M Source/JavaScriptCore/runtime/StringPrototype.cpp A Source/JavaScriptCore/runtime/StringReplaceCache.h A Source/JavaScriptCore/runtime/StringReplaceCacheInlines.h M Source/JavaScriptCore/runtime/VM.h Log Message: --- [JSC] Add global replace caching https://bugs.webkit.org/show_bug.cgi?id=257826 rdar://110417641 Reviewed by Michael Saboff. This patch adds String.replace(/regexp-global/g, func) result cache, which is in the same fashion to V8's cache. We cache the result only when the subject string length is >= 0x1000, aligned to V8's behavior. This cache is cleared on every GC, so it does not affect on memory usage in practice: once GC happens, everything gets cleared, so it is not retaining things. * JSTests/stress/v8-regexp-results-cache.js: Added. * JSTests/stress/v8-string-replace-cache.js: Added. (replaceTest): (r): (i.r): (string_appeared_here.string_appeared_here.replace_obj.toString): (search_obj.toString): (replace_obj_side_effects.toString): (testIndices99): (testIndices59): (const.fake_replacer.Symbol.toPrimitive): * JSTests/stress/v8-string-replace.js: Added. (replaceTest): (r): (i.r): (string_appeared_here.string_appeared_here.replace_obj.toString): (search_obj.toString): (replace_obj_side_effects.toString): (testIndices99): (testIndices59): (const.fake_replacer.Symbol.toPrimitive): * Source/JavaScriptCore/CMakeLists.txt: * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/heap/Heap.cpp: (JSC::Heap::finalize): * Source/JavaScriptCore/runtime/ArgList.h: * Source/JavaScriptCore/runtime/JSImmutableButterfly.cpp: (JSC::JSImmutableButterfly::tryCreateFromArgList): * Source/JavaScriptCore/runtime/JSImmutableButterfly.h: * Source/JavaScriptCore/runtime/OptionsList.h: * Source/JavaScriptCore/runtime/RegExpGlobalData.h: (JSC::RegExpGlobalData::ovector const): * Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h: (JSC::RegExpGlobalData::resetResultFromCache): * Source/JavaScriptCore/runtime/StringPrototype.cpp: (JSC::replaceUsingRegExpSearchWithCache): (JSC::replaceUsingRegExpSearch): * Source/JavaScriptCore/runtime/StringReplaceCache.h: Copied from Source/JavaScriptCore/runtime/RegExpGlobalData.h. (JSC::StringReplaceCache::clear): * Source/JavaScriptCore/runtime/StringReplaceCacheInlines.h: Added. (JSC::StringReplaceCache::get): (JSC::StringReplaceCache::set): * Source/JavaScriptCore/runtime/VM.h: Canonical link: https://commits.webkit.org/264967@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2ef685: [WebXR] Use WebCore type for framebuffer size.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2ef6856abf7b164414faa05f88d511caf7913e8c https://github.com/WebKit/WebKit/commit/2ef6856abf7b164414faa05f88d511caf7913e8c Author: Dan Glastonbury Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h M Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp Log Message: --- [WebXR] Use WebCore type for framebuffer size. https://bugs.webkit.org/show_bug.cgi?id=257781 rdar://problem/110377022 Reviewed by Kimmo Kinnunen. WebXRWebGLLayer converts the IntSize representing the framebuffer dimensions into seperate width and height values, as well as converting signed to unsigned integer, when scaling the dimensions to accommodate DPI. This patch uses the WebCore type IntSize to store the framebuffer dimensions instead of separate width & height and keeps the values as signed integers. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::create): (WebCore::WebXROpaqueFramebuffer::WebXROpaqueFramebuffer): (WebCore::WebXROpaqueFramebuffer::startFrame): (WebCore::WebXROpaqueFramebuffer::endFrame): (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): (WebCore::WebXROpaqueFramebuffer::allocateRenderbufferStorage): (WebCore::WebXROpaqueFramebuffer::allocateColorStorage): (WebCore::WebXROpaqueFramebuffer::allocateDepthStencilStorage): * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h: (WebCore::WebXROpaqueFramebuffer::width const): (WebCore::WebXROpaqueFramebuffer::height const): * Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp: (WebCore::createOpaqueFramebuffer): Canonical link: https://commits.webkit.org/264966@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8006d: [CMake] Support port specific serialization files
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8006dabab6836a2cb5ae2685348dd40e1153326 https://github.com/WebKit/WebKit/commit/e8006dabab6836a2cb5ae2685348dd40e1153326 Author: Don Olmstead Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/CMakeLists.txt Log Message: --- [CMake] Support port specific serialization files https://bugs.webkit.org/show_bug.cgi?id=257834 Reviewed by Alex Christensen. Move the definition of `WebKit_SERIALIZATION_IN_FILES` above the call to `WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS` so a port can append to that value. * Source/WebKit/CMakeLists.txt: Canonical link: https://commits.webkit.org/264965@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f3d38: Fix typo in WC class names
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f3d38914686251c5a708c2532307a3f3f9c98d8 https://github.com/WebKit/WebKit/commit/6f3d38914686251c5a708c2532307a3f3f9c98d8 Author: Don Olmstead Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp M Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.h M Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.messages.in M Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp M Source/WebKit/GPUProcess/graphics/wc/WCScene.h M Source/WebKit/WebProcess/GPU/graphics/wc/RemoteWCLayerTreeHostProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/wc/RemoteWCLayerTreeHostProxy.h M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.h M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.h R Source/WebKit/WebProcess/WebPage/wc/WCUpateInfo.h A Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h Log Message: --- Fix typo in WC class names https://bugs.webkit.org/show_bug.cgi?id=257835 Reviewed by Fujii Hironori. Rename `WCUpateInfo` -> `WCUpdateInfo` and `WCLayerUpateInfo` -> `WCLayerUpdateInfo`. Rename the file as well. * Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp: (WebKit::RemoteWCLayerTreeHost::update): * Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.h: * Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.messages.in: * Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp: (WebKit::WCScene::update): * Source/WebKit/GPUProcess/graphics/wc/WCScene.h: * Source/WebKit/WebProcess/GPU/graphics/wc/RemoteWCLayerTreeHostProxy.cpp: (WebKit::RemoteWCLayerTreeHostProxy::update): * Source/WebKit/WebProcess/GPU/graphics/wc/RemoteWCLayerTreeHostProxy.h: * Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp: (WebKit::flushLayerImageBuffers): (WebKit::DrawingAreaWC::commitLayerUpdateInfo): (WebKit::DrawingAreaWC::commitLayerUpateInfo): Deleted. * Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.h: * Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp: (WebKit::GraphicsLayerWC::flushCompositingStateForThisLayerOnly): * Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.h: * Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h: Renamed from Source/WebKit/WebProcess/WebPage/wc/WCUpateInfo.h. (WebKit::WCLayerUpdateInfo::decode): (WebKit::WCUpdateInfo::decode): Canonical link: https://commits.webkit.org/264964@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 70f1cb: Adopt PLATFORM(VISION) wherever PLATFORM(IOS) is u...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 70f1cbcc20e8912f4f6b1cbc1a4f0fbd699f435d https://github.com/WebKit/WebKit/commit/70f1cbcc20e8912f4f6b1cbc1a4f0fbd699f435d Author: Tim Horton Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp M Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm M Tools/TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm M Tools/TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/Coding.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoTextRecognition.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBInPageCache.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/NotificationAPI.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSStylusSupport.mm M Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm M Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm M Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm M Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLNoCrashOnOtherThreadAccess.mm M Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm M Tools/TestWebKitAPI/cocoa/DaemonTestUtilities.h M Tools/TestWebKitAPI/cocoa/DaemonTestUtilities.mm M Tools/TestWebKitAPI/config.h M Tools/TestWebKitAPI/ios/UIKitSPI.h M Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/ios/TestControllerIOS.mm Log Message: --- Adopt PLATFORM(VISION) wherever PLATFORM(IOS) is used (Tools version) https://bugs.webkit.org/show_bug.cgi?id=257837 rdar://110427723 Reviewed by Megan Gardner and Aditya Keerthi. * Tools/TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm: * Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: (TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoTextRecognition.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm: * Tools/TestWebKitAP
[webkit-changes] [WebKit/WebKit] b6aac3: Add visionOS information to PlatformOS.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6aac36367ab52dc6261763b5bb8eafd1cbd96d3 https://github.com/WebKit/WebKit/commit/b6aac36367ab52dc6261763b5bb8eafd1cbd96d3 Author: Megan Gardner Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformOS.h Log Message: --- Add visionOS information to PlatformOS.h https://bugs.webkit.org/show_bug.cgi?id=257831 rdar://110420747 Reviewed by Tim Horton. * Source/WTF/wtf/PlatformOS.h: Canonical link: https://commits.webkit.org/264962@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4883c5: [Cocoa] Move new LockdownMode Framework to Open So...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4883c52ce3250f4665685e993adedf1eafe19833 https://github.com/WebKit/WebKit/commit/4883c52ce3250f4665685e993adedf1eafe19833 Author: Brent Fulgham Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.h A Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.mm M Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm Log Message: --- [Cocoa] Move new LockdownMode Framework to Open Source https://bugs.webkit.org/show_bug.cgi?id=257761 Reviewed by Tim Horton. Migrate internal use of the new LockdownMode framework to Open Source now that it has been released with the WWDC 2023 Seed * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.h: Added. * Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.mm: Added. (PAL::isLockdownModeEnabled): * Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm: (+[_WKSystemPreferences isCaptivePortalModeEnabled]): Canonical link: https://commits.webkit.org/264961@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b9744e: Adopt PLATFORM(VISION) wherever PLATFORM(IOS) is used
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9744e378fc06cbad26696797692160934266d22 https://github.com/WebKit/WebKit/commit/b9744e378fc06cbad26696797692160934266d22 Author: Tim Horton Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/JavaScriptCore/API/JSTypedArray.cpp M Source/JavaScriptCore/API/tests/testapi.mm M Source/JavaScriptCore/runtime/ObjectPrototype.cpp M Source/JavaScriptCore/runtime/ObjectPrototypeInlines.h M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/Platform.h M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WTF/wtf/spi/darwin/AbortWithReasonSPI.h M Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp M Source/WebCore/PAL/pal/ios/ReplayKitSoftLink.h M Source/WebCore/PAL/pal/ios/ReplayKitSoftLink.mm M Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h M Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h M Source/WebCore/PAL/pal/spi/ios/BarcodeSupportSPI.h M Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h M Source/WebCore/page/ScreenOrientationType.h M Source/WebCore/platform/cocoa/ParentalControlsContentFilter.h M Source/WebCore/platform/cocoa/ParentalControlsContentFilter.mm M Source/WebCore/platform/cocoa/SystemBattery.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm M Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp M Source/WebCore/platform/mediastream/ios/ReplayKitCaptureSource.h M Source/WebCore/platform/mediastream/ios/ReplayKitCaptureSource.mm M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp M Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm M Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp M Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm M Source/WebCore/rendering/RenderThemeIOS.mm M Source/WebCore/testing/Internals.cpp M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.mm M Source/WebKit/Platform/spi/ios/UIKitSPI.h M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h M Source/WebKit/Shared/Cocoa/ARKitSoftLink.mm M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm M Source/WebKit/Shared/Cocoa/LoadParametersCocoa.mm M Source/WebKit/Shared/LoadParameters.h M Source/WebKit/Shared/WebPageCreationParameters.cpp M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/Shared/WebProcessCreationParameters.h M Source/WebKit/Shared/WebProcessCreationParameters.serialization.in M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Source/WebKit/UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm M Source/WebKit/UIProcess/Cocoa/UIDelegate.h M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h M Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.cpp M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Source/WebKit/webpushd/InstallCoordinationSPI.h M Source/WebKit/webpushd/LaunchServicesSPI.h M Source/WebKit/webpushd/WebPushDaemon.mm
[webkit-changes] [WebKit/WebKit] 932073: [Cocoa] Enable JPEG XL on 2023-aligned OSes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 932073284e4c73ce9884d0c6e15fe86fe99685c5 https://github.com/WebKit/WebKit/commit/932073284e4c73ce9884d0c6e15fe86fe99685c5 Author: Myles C. Maxfield Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/loader/cache/CachedResourceRequest.cpp M Source/WebCore/platform/MIMETypeRegistry.cpp M Source/WebCore/platform/graphics/cg/UTIRegistry.cpp Log Message: --- [Cocoa] Enable JPEG XL on 2023-aligned OSes https://bugs.webkit.org/show_bug.cgi?id=257762 rdar://110345663 Reviewed by Said Abou-Hallawa. Simply upstream the enablement flag. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/loader/cache/CachedResourceRequest.cpp: (WebCore::acceptHeaderValueForJPEGXLImageResource): * Source/WebCore/platform/MIMETypeRegistry.cpp: * Source/WebCore/platform/graphics/cg/UTIRegistry.cpp: (WebCore::defaultSupportedImageTypes): Canonical link: https://commits.webkit.org/264959@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8e09f2: REGRESSION(??): Clicking ‘Next Episode’ on Netflix...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e09f28bc0dfe61e8c4b1b4a41d49801f479358c https://github.com/WebKit/WebKit/commit/8e09f28bc0dfe61e8c4b1b4a41d49801f479358c Author: Jer Noble Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Log Message: --- REGRESSION(??): Clicking ‘Next Episode’ on Netflix results in black video feed https://bugs.webkit.org/show_bug.cgi?id=257820 rdar://110281016 Reviewed by Eric Carlson. When entering "standby" fullscreen mode (to ensure media playing in Element fullscreen automatically enters picture-in-picture mode when the application is backgrounded), we send a `setupFullscreenWithID()` message to the VideoFullscreenManagerProxy from `enterVideoFullscreenForVideoElement()` containing the videos location in screen coordinates. Inside `setupFullscreenWithID()` we use the initial screen rect to derive the initial layer size when creating a hosting layer for the video content. In the case of Netflix content in fullscreen mode, this step happens before the layer is created by the player, and when the layer is eventually created, the layer host view is already the correct size, and the WebContent and GPU processes are never informed of the new layer's size. Rather than use the initial window rect of the video element, pass in the current value of `videoInlineSize()` as the initial layer size, as we do in other places. * Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h: * Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in: * Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID): * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement): Canonical link: https://commits.webkit.org/264958@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2dd4f2: [ iOS, macOS ] imported/w3c/web-platform-tests/htm...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2dd4f2cd5de8f589e2079f205822a8d0c69773d9 https://github.com/WebKit/WebKit/commit/2dd4f2cd5de8f589e2079f205822a8d0c69773d9 Author: Bri Harris Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [ iOS, macOS ] imported/w3c/web-platform-tests/html/rendering/the-details-element/summary-text-decoration.html is a constant ImageOnly failure webkit.org/b/257832 rdar://110421013 Unreviewed test gardening. Expectations for failing tests. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/264957@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0bee33: Fix the RLBS build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0bee330e2072a86c95702de4fa5f780f0c00e506 https://github.com/WebKit/WebKit/commit/0bee330e2072a86c95702de4fa5f780f0c00e506 Author: Tim Horton Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm Log Message: --- Fix the RLBS build https://bugs.webkit.org/show_bug.cgi?id=257827 rdar://110418728 Unreviewed build fix. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::encode const): Canonical link: https://commits.webkit.org/264956@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58785d: Fixes crashes due to missing WebPrivacy framework ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58785de4b8ec3cd420748f0e907cb37f990c3963 https://github.com/WebKit/WebKit/commit/58785de4b8ec3cd420748f0e907cb37f990c3963 Author: Wenson Hsieh Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm Log Message: --- Fixes crashes due to missing WebPrivacy framework on Ventura/Monterey downlevels after 264942@main https://bugs.webkit.org/show_bug.cgi?id=257699 rdar://110238364 Reviewed by Tim Horton. Add missing WebPrivacy framework availability checks before attempting to access soft-linked string constants. * Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm: (-[WKWebPrivacyNotificationListener init]): (-[WKWebPrivacyNotificationListener dealloc]): (-[WKWebPrivacyNotificationListener didUpdate:]): (WebKit::LinkDecorationFilteringController::observeUpdates): Canonical link: https://commits.webkit.org/264955@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 450764: [iOS simulator] Fix TestWebKitAPI build after 2649...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 450764cda1cb65b5faa1c7024c5caa2cdc0c71ad https://github.com/WebKit/WebKit/commit/450764cda1cb65b5faa1c7024c5caa2cdc0c71ad Author: Abrar Rahman Protyasha Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm Log Message: --- [iOS simulator] Fix TestWebKitAPI build after 264915@main rdar://110414816 https://bugs.webkit.org/show_bug.cgi?id=257821 Reviewed by Megan Gardner and Wenson Hsieh. On the iOS simulator, we don't call the `libnetwork` functions because the Proxy API tests are skipped since 264915@main. As such, we avoid soft linking against `libnetwork` on the simulator builds to prevent unused function errors. * Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Canonical link: https://commits.webkit.org/264954@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1b0e67: Revert "[Xcode] Dependencies in preprocessed sandb...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1b0e675562c9830888f9c53b83ed2674c27cd63b https://github.com/WebKit/WebKit/commit/1b0e675562c9830888f9c53b83ed2674c27cd63b Author: Elliott Williams Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/Configurations/SandboxProfiles.xcconfig M Source/WebKit/Configurations/WebKit.xcconfig M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources-output.xcfilelist M Source/WebKit/DerivedSources.make R Source/WebKit/Scripts/preprocess-sandbox-profile-rule.sh M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Revert "[Xcode] Dependencies in preprocessed sandbox profiles not tracked" https://bugs.webkit.org/show_bug.cgi?id=257814 rdar://110353926 Unreviewed. Seems to be causing missing sandbox profiles on some Mac builds. Revert all commits landed under the bug: Revert "Restore iOS sandbox profile generation in engineering builds" This reverts commit c9a65a407c6b09028fa5a074dbc9fc60011937d4. Revert "Add quoting for arrays containing whitespace paths in preprocess-sandbox-profile-rule.sh" This reverts commit 6f04c95bf8f346bf66b311ee0448fce8d60b1791. Revert "Fix whitespace-containing path in preprocess-sandbox-profile-rule.sh" This reverts commit 5f13e1c10eb0f44f1a71f4d6c56d59313f614577. Revert "[Xcode] Dependencies in preprocessed sandbox profiles not tracked" This reverts commit 40fd93b1f2eff242effa1c79d30571d1547c9a74. Canonical link: https://commits.webkit.org/264953@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4bbe3: AX: AXObjectCache::setIsolatedTreeFocusedObject sh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4bbe36cdab2afbefd487727b429c52598495807 https://github.com/WebKit/WebKit/commit/b4bbe36cdab2afbefd487727b429c52598495807 Author: Andres Gonzalez Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: A LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes-expected.txt A LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes.html M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- AX: AXObjectCache::setIsolatedTreeFocusedObject should handle the same special cases as focusedObjectForPage. https://bugs.webkit.org/show_bug.cgi?id=257739 Reviewed by Chris Fleizach and Tyler Wilcock. Added AXObjectCache::focusedObjectForNode to handle the special cases for both focusedObjectForPage and setIsolatedTreeFocusedObject. This makes getting the focused object more consistent between ITM on and off. It will also allow to get the focused Object from the Isolated tree without hitting the main thread. * LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes-expected.txt: Added. * LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes.html: Added. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::focusedObjectForPage): (WebCore::AXObjectCache::focusedObjectForNode): (WebCore::AXObjectCache::setIsolatedTreeFocusedObject): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleActiveDescendantChanged): * Source/WebCore/accessibility/AXObjectCache.h: Canonical link: https://commits.webkit.org/264952@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 762746: Add signposts and profiling support to MotionMark
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7627468cdd1d9e63d527fe9af141e0b8217e7377 https://github.com/WebKit/WebKit/commit/7627468cdd1d9e63d527fe9af141e0b8217e7377 Author: Hysu Xiong Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: A Tools/Scripts/webkitpy/benchmark_runner/data/patches/signposts/MotionMark.patch M Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.2.1.plan Log Message: --- Add signposts and profiling support to MotionMark https://bugs.webkit.org/show_bug.cgi?id=249595 rdar://103522107 Reviewed by Dewei Zhu. This patch adds signpost patches to Speedometer plans, which will allow us to annotate generated profiles (--profile). Currently, for each iteration, two signposts are created: one overarching signpost called "${suite}.${test}" labeling the full subtest run, and "${suite}.${test}: warmup" labeling just the warmup section. * Tools/Scripts/webkitpy/benchmark_runner/data/patches/signposts/MotionMark.patch: Added. * Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.2.1.plan: Canonical link: https://commits.webkit.org/264951@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f7bcfe: Add Apple Vision Pro to acceptable targets for Web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f7bcfe132b211b2e28dbaab5ab4cb72b5d8eebe3 https://github.com/WebKit/WebKit/commit/f7bcfe132b211b2e28dbaab5ab4cb72b5d8eebe3 Author: Megan Gardner Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig Log Message: --- Add Apple Vision Pro to acceptable targets for WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=257819 rdar://110411126 Reviewed by Tim Horton. * Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Canonical link: https://commits.webkit.org/264950@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 580bf6: REGRESSION (264795@main) Twitter.com: Video blank/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 580bf6c28d2b381a9a51fb66f54c445bc51d967d https://github.com/WebKit/WebKit/commit/580bf6c28d2b381a9a51fb66f54c445bc51d967d Author: Jer Noble Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm Log Message: --- REGRESSION (264795@main) Twitter.com: Video blank/black while scrolling https://bugs.webkit.org/show_bug.cgi?id=257805 rdar://110320059 Reviewed by Eric Carlson. Use videoInlineSize() rather than presentationSize() to determine whether or not a layer should be created in MediaPlayerPrivateMediaSourceAVFObjC. And to ensure the layer does get created when videoInlineSize() changes, override setVideoInlineSizeFenced() in that class, and call it from RemoteMediaPlayerProxy::setVideoInlineSizeFenced(). * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer const): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoInlineSizeFenced): * Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm: (WebKit::RemoteMediaPlayerProxy::setVideoInlineSizeFenced): Canonical link: https://commits.webkit.org/264949@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82ae26: Import missing Web Platform Tests for Highlight
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82ae26a64dc185dbca5f64bcf14f6cd34bd49a1b https://github.com/WebKit/WebKit/commit/82ae26a64dc185dbca5f64bcf14f6cd34bd49a1b Author: Jessica Cheung Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/Highlight-iteration-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/Highlight-iteration-with-modifications-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/Highlight-iteration-with-modifications.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/Highlight-iteration.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/Highlight-type-attribute.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/Highlight-type-attribute.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/HighlightRegistry-iteration-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/HighlightRegistry-iteration-with-modifications-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/HighlightRegistry-iteration-with-modifications.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/HighlightRegistry-iteration.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/HighlightRegistry-maplike-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/HighlightRegistry-maplike.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/highlight-pseudo-computed-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/highlight-pseudo-computed.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/highlight-pseudo-parsing-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/highlight-pseudo-parsing.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/css-highlight-painting-underline-offset-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/css-highlight-painting-underline-offset-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/css-highlight-painting-underline-offset-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/css-target-text-decoration-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/css-target-text-decoration-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/css-target-text-decoration-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-002-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-003-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-003-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-003.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-004-2-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-004-2-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-004-2.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-004-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-004-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-004.html A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-005-expected.html A LayoutTes
[webkit-changes] [WebKit/WebKit] 74cbf1: [BBQ] direct call import codegen improvement
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74cbf1af3f5baeff32417f0f1ae9c12da7ded258 https://github.com/WebKit/WebKit/commit/74cbf1af3f5baeff32417f0f1ae9c12da7ded258 Author: Keith Miller Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp Log Message: --- [BBQ] direct call import codegen improvement https://bugs.webkit.org/show_bug.cgi?id=257721 Reviewed by Yusuke Suzuki. Since the limit on imported functions is 100,000 the offset of the function stub will always be less than 2^31. Thus we can use an Address rather than a separate add. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::addCall): Canonical link: https://commits.webkit.org/264948@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c031c7: Unreviewed, fix the build after 264942@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c031c73f648e7fc7fd84875f65c76468aab36d9d https://github.com/WebKit/WebKit/commit/c031c73f648e7fc7fd84875f65c76468aab36d9d Author: Wenson Hsieh Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- Unreviewed, fix the build after 264942@main rdar://110401563 Simplify this `HAVE()` macro to just check whether or not the WebPrivacy framework umbrella header is present, instead of enumerating version checks per platform. This fixes a build failure on tvOS, on which the framework isn't available. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/264946@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 309ff2: Correct statuses for certain CSS properties
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 309ff24a9f51908bd7c7a16d4e942cb6d46b7939 https://github.com/WebKit/WebKit/commit/309ff24a9f51908bd7c7a16d4e942cb6d46b7939 Author: Luke Warlow Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/css/CSSProperties.json Log Message: --- Correct statuses for certain CSS properties https://bugs.webkit.org/show_bug.cgi?id=257766 Reviewed by Tim Nguyen. Adds missing "in development" status for scrollbar-width and scrollbar-gutter. Also change various other properties to be stable. * Source/WebCore/css/CSSProperties.json: Canonical link: https://commits.webkit.org/264945@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a104b1: [FFC] ASSERTION FAILED: formattingContextRoot.hasC...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a104b168ce9f0aee8436f8e60f5cf80cdf20c30e https://github.com/WebKit/WebKit/commit/a104b168ce9f0aee8436f8e60f5cf80cdf20c30e Author: Alan Baradlay Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/rendering/RenderFlexibleBox.cpp M Source/WebCore/rendering/RenderFlexibleBox.h Log Message: --- [FFC] ASSERTION FAILED: formattingContextRoot.hasChild() when flex item has inline content https://bugs.webkit.org/show_bug.cgi?id=257802 Reviewed by Antti Koivisto. With the (relatively) recent change of sharing Layout::Boxes across integration type of formatting contexts (e.g. for an inline-block box which is both a root of an IFC and a leaf box in the parent IFC we only construct a single Layout::Box), we have to keep the integration object alive in order to not get the flex subtree destroyed including the flex items which act as root boxes for the associated IFCs. * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext): * Source/WebCore/rendering/RenderFlexibleBox.h: Canonical link: https://commits.webkit.org/264944@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df850b: with float:left disappears when editing...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df850bbc342ee6caba4371b51ccfde480ab6db54 https://github.com/WebKit/WebKit/commit/df850bbc342ee6caba4371b51ccfde480ab6db54 Author: Alan Baradlay Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderLayer.cpp Log Message: --- with float:left disappears when editing text https://bugs.webkit.org/show_bug.cgi?id=132188 Reviewed by Simon Fraser. Consider the following example: 1. A float box can intrude into multiple containers ("top" and "middle"). 2. Containers construct FloatingObjects for intruding floats (multiple FloatingObjects can point to the same float when it crosses containers). 3. Float boxes (usually) are painted by the top most container where they intrude ("top"). 4. However self-painting float boxes always paint themselves (this is not specific to floats, all renderers behave like this). 5. FloatingObject's m_paintsFloat controls which container is responsible for painting the (non-self-painting) float box. When a float box goes from self-painting to non-self painting, we need to ensure that one of its containers takes care of painting it by adjusting the associated FloatingObject's paint flag. It is usually done as part of the layout process at RenderBlockFlow::addIntrudingFloats when containers finish running layout on their child renderers (including float boxes) (i.e. the containing block chain takes care of updating this bit). However when the float box is the root of the layout (i.e. subtree layout) none of its containers get the chance to update this paint flag since layout flow never reaches said ancestors. (note when the layout's entry point is the float box, it's guaranteed that none of the intruding/overhanging properties change at the containing block level (i.e. no need to extend the layout to the ancestor chain). At this point this is really only about ensuring that one of the ancestors (through the already constructed FloatingObjects) starts painting this float box. * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::updateFloatBoxAfterSelfPaintingLayerChange): * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const): Canonical link: https://commits.webkit.org/264943@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7584d3: Upstream advanced privacy protections for private ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7584d308c00916c50f2b670f78c283a04e06db8e https://github.com/WebKit/WebKit/commit/7584d308c00916c50f2b670f78c283a04e06db8e Author: Wenson Hsieh Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M LayoutTests/http/tests/resourceLoadStatistics/omit-document-referrer-nested-third-party-iframe-ephemeral.html M LayoutTests/http/tests/resourceLoadStatistics/omit-document-referrer-third-party-iframe-ephemeral.html M LayoutTests/http/tests/resourceLoadStatistics/omit-referrer-for-navigation-ephemeral.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/PlatformHave.h M Source/WebCore/Headers.cmake M Source/WebCore/Modules/async-clipboard/Clipboard.cpp M Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj M Source/WebCore/PAL/pal/PlatformMac.cmake R Source/WebCore/PAL/pal/cocoa/NetworkConnectionIntegritySoftLink.h R Source/WebCore/PAL/pal/cocoa/NetworkConnectionIntegritySoftLink.mm A Source/WebCore/PAL/pal/cocoa/WebPrivacySoftLink.h A Source/WebCore/PAL/pal/cocoa/WebPrivacySoftLink.mm M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h R Source/WebCore/PAL/pal/spi/cocoa/NetworkConnectionIntegritySPI.h A Source/WebCore/PAL/pal/spi/cocoa/WebPrivacySPI.h M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/contentextensions/ContentExtensionsBackend.cpp M Source/WebCore/contentextensions/ContentExtensionsBackend.h M Source/WebCore/dom/DataTransfer.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm M Source/WebCore/inspector/agents/WebConsoleAgent.cpp M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/DocumentLoader.h M Source/WebCore/loader/FrameLoadRequest.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/cache/CachedResourceLoader.cpp M Source/WebCore/page/ChromeClient.h A Source/WebCore/page/LinkDecorationFilteringData.h M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebCore/page/LocalFrame.cpp R Source/WebCore/page/LookalikeCharactersSanitizationData.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/page/Screen.cpp M Source/WebCore/page/UserContentProvider.cpp A Source/WebCore/platform/network/AdvancedPrivacyProtections.h R Source/WebCore/platform/network/NetworkConnectionIntegrity.h M Source/WebCore/platform/network/ResourceRequestBase.cpp M Source/WebCore/platform/network/ResourceRequestBase.h M Source/WebCore/platform/network/cf/ResourceError.h M Source/WebCore/platform/network/cf/ResourceRequest.h M Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm M Source/WebCore/platform/network/mac/ResourceErrorMac.mm M Source/WebCore/rendering/HitTestResult.cpp M Source/WebKit/NetworkProcess/BackgroundFetchLoad.cpp M Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp M Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in M Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp M Source/WebKit/NetworkProcess/NetworkLoadChecker.h M Source/WebKit/NetworkProcess/NetworkLoadParameters.h M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h M Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp M Source/WebKit/NetworkProcess/NetworkSocketChannel.h M Source/WebKit/NetworkProcess/PingLoad.cpp M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp M Source/WebKit/NetworkProcess/cache/AsyncRevalidation.cpp M Source/WebKit/NetworkProcess/cache/AsyncRevalidation.h M Source/WebKit/NetworkProcess/cache/NetworkCache.cpp M Source/WebKit/NetworkProcess/cache/NetworkCache.h M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/Web
[webkit-changes] [WebKit/WebKit] 81084d: Address socket option telemetry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81084d1e70d6177c4e9391b092f6c029f19fb3db https://github.com/WebKit/WebKit/commit/81084d1e70d6177c4e9391b092f6c029f19fb3db Author: Per Arne Vollan Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in Log Message: --- Address socket option telemetry https://bugs.webkit.org/show_bug.cgi?id=257767 rdar://107427539 Reviewed by Brent Fulgham. Address socket option telemetry in the Networking process sandbox. * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Canonical link: https://commits.webkit.org/264941@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c2201: REGRESSION (263724@main): Jumpiness and jitterines...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c2201e62a9afb3da7a0f19e6bcd8bda1f0dd2e2 https://github.com/WebKit/WebKit/commit/7c2201e62a9afb3da7a0f19e6bcd8bda1f0dd2e2 Author: Ryosuke Niwa Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: A LayoutTests/fast/scrolling/scroll-anchoring-after-page-load-expected.html A LayoutTests/fast/scrolling/scroll-anchoring-after-page-load.html M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h Log Message: --- REGRESSION (263724@main): Jumpiness and jitteriness in scrolling on searchfox.org https://bugs.webkit.org/show_bug.cgi?id=257576 Reviewed by Simon Fraser. The bug was caused by WebKit no longer clearing the scroll anchoring element upon page load completion. This turned out to be not a Web compatible change. Fix fast/dynamic/anchor-lock.html in another way by remembering to which node scrolling was scheduled in LocalFrameView instead of relying on m_maintainScrollPositionAnchor to be not cleared upon page load completion, which is not generally Web compatible. * LayoutTests/fast/scrolling/scroll-anchoring-after-page-load-expected.html: Added. * LayoutTests/fast/scrolling/scroll-anchoring-after-page-load.html: Added. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::completed): * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::scheduleScrollToAnchorAndTextFragment): * Source/WebCore/page/LocalFrameView.h: Canonical link: https://commits.webkit.org/264940@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fea0e1: Use "enum class" instead of plain enum for ThemeTypes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fea0e1d56ed57b95191a9a593e0cd7a6e8b2c975 https://github.com/WebKit/WebKit/commit/fea0e1d56ed57b95191a9a593e0cd7a6e8b2c975 Author: Matthieu Dubet Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/platform/ThemeTypes.cpp M Source/WebCore/platform/ThemeTypes.h Log Message: --- Use "enum class" instead of plain enum for ThemeTypes https://bugs.webkit.org/show_bug.cgi?id=257784 rdar://110378475 Reviewed by Youenn Fablet. * Source/WebCore/platform/ThemeTypes.cpp: (WebCore::operator<<): * Source/WebCore/platform/ThemeTypes.h Canonical link: https://commits.webkit.org/264939@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a255a: [WGSL] Assertion failure in call graph builder
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a255a75bb55df2aef23ab7c0720d27a89e698aa https://github.com/WebKit/WebKit/commit/7a255a75bb55df2aef23ab7c0720d27a89e698aa Author: Tadeu Zagallo Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebGPU/WGSL/CallGraph.cpp Log Message: --- [WGSL] Assertion failure in call graph builder https://bugs.webkit.org/show_bug.cgi?id=257795 rdar://110386328 Unreviewed. Added an assertion before landing 264932@main but didn't realize that the member variable was uninitialized which caused the assertion to always fail. * Source/WebGPU/WGSL/CallGraph.cpp: Canonical link: https://commits.webkit.org/264938@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f6bd1: Fix scrollbar-gutter stable in vertical writing modes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f6bd1d186405f2134662981c82a0857f353b5e2 https://github.com/WebKit/WebKit/commit/0f6bd1d186405f2134662981c82a0857f353b5e2 Author: Luke Warlow Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.h Log Message: --- Fix scrollbar-gutter stable in vertical writing modes https://bugs.webkit.org/show_bug.cgi?id=257605 Reviewed by Simon Fraser. Stable scrollbar gutters on non-viewports now correctly account for vertical writing modes. * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::includeHorizontalScrollbarSize const): (WebCore::RenderBox::verticalScrollbarWidth const): (WebCore::RenderBox::horizontalScrollbarHeight const): (WebCore::RenderBox::overflowClipRect const): * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::constrainingRectForStickyPosition const): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::verticalScrollbarWidth const): (WebCore::RenderLayerScrollableArea::horizontalScrollbarHeight const): (WebCore::RenderLayerScrollableArea::computeScrollOrigin): * Source/WebCore/rendering/RenderLayerScrollableArea.h: Canonical link: https://commits.webkit.org/264937@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df5c46: LayoutTests/imported/w3c/web-platform-tests/screen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df5c46999eb344972288ba06dae8137e42243154 https://github.com/WebKit/WebKit/commit/df5c46999eb344972288ba06dae8137e42243154 Author: Marcos Caceres Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-check.html M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-check.html is flaky https://bugs.webkit.org/show_bug.cgi?id=257637 rdar://110152655 Reviewed by Tim Nguyen. Added some promises that actually wait for the events, which fixes things as far as flakiness is concerned. * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-check.html: * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/264936@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a33f8a: RemoteSerializedImageBuffer tracks WP-side reads r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a33f8a24c752c23225ebeb863f4523b5f2ee4201 https://github.com/WebKit/WebKit/commit/a33f8a24c752c23225ebeb863f4523b5f2ee4201 Author: Kimmo Kinnunen Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteSerializedImageBufferIdentifier.h M Tools/TestWebKitAPI/Tests/IPC/ThreadSafeObjectHeapTests.cpp Log Message: --- RemoteSerializedImageBuffer tracks WP-side reads redundantly https://bugs.webkit.org/show_bug.cgi?id=257744 rdar://109799857 Reviewed by Matt Woodrow. RemoteSerializedImageBuffers are created with MoveToSerializedBuffer and destroyed with either MoveToImageBuffer or ReleaseSerializedImageBuffer. These are just create and consume operations, and as such do not need more complicated read and write tracking. The source RemoteImageBuffer identifier is the same as the eventual destination RemoteImageBuffer identifier. Also RemoteSerializedImageBuffer can be identified with the same identifier. Use the thread-ThreadSafeObjectHeap only in the remote side, and only with add and remove semantics. * Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::releaseSerializedImageBuffer): * Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h: * Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::moveToSerializedBuffer): (WebKit::RemoteRenderingBackend::moveToImageBuffer): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in: * Source/WebKit/Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): (headers_for_type): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp: (WebKit::RemoteSerializedImageBufferProxy::RemoteSerializedImageBufferProxy): (WebKit::RemoteSerializedImageBufferProxy::sinkIntoImageBuffer): (WebKit::RemoteSerializedImageBufferProxy::~RemoteSerializedImageBufferProxy): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::moveToSerializedBuffer): (WebKit::RemoteRenderingBackendProxy::moveToImageBuffer): * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteSerializedImageBufferIdentifier.h: (): Deleted. * Tools/TestWebKitAPI/Tests/IPC/ThreadSafeObjectHeapTests.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/264935@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 706305: Synchronize css/cssom WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 706305248d7949685acb826bab427aff851d3c92 https://github.com/WebKit/WebKit/commit/706305248d7949685acb826bab427aff851d3c92 Author: Anne van Kesteren Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSFontFeatureValuesRule-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSFontFeatureValuesRule.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/adoptedstylesheets-observablearray.html R LayoutTests/imported/w3c/web-platform-tests/css/cssom/css-stylesheet-replaceSync-null-deref-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/cssom/css-stylesheet-replaceSync-null-deref.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-absolute.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-fixed.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-nobox.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-relative.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-static.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-sticky.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/support/getComputedStyle-insets.js M LayoutTests/imported/w3c/web-platform-tests/css/cssom/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/cssom/xml-stylesheet-pi-in-doctype-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/cssom/xml-stylesheet-pi-in-doctype.xhtml Log Message: --- Synchronize css/cssom WPT https://bugs.webkit.org/show_bug.cgi?id=257741 rdar://110310268 Reviewed by Tim Nguyen. Synchronize web-platform-tests/css/cssom up to upstream commit 57c5006103146974adb3af50d325c3b6ce7153d0, except for CSSStyleSheet-constructable-concat.html which does not pass as a reference test on CI and does pass partially in its current state. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSFontFeatureValuesRule-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSFontFeatureValuesRule.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/adoptedstylesheets-observablearray.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/css-stylesheet-replaceSync-null-deref-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/css-stylesheet-replaceSync-null-deref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-absolute.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-fixed.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-nobox.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-relative.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-static.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-sticky.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/support/getComputedStyle-insets.js: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/xml-stylesheet-pi-in-doctype-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/xml-stylesheet-pi-in-doctype.xhtml: Added. Canonical link: https://commits.webkit.org/264934@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f9e9fc: [Cocoa] Expose colorSpace in HW encoders VideoDeco...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f9e9fc8f8b1b89d88194a1fc76dd13031749b87f https://github.com/WebKit/WebKit/commit/f9e9fc8f8b1b89d88194a1fc76dd13031749b87f Author: Youenn Fablet Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h264_annexb-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h264_avc-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_annexb-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_avc-expected.txt M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/base/RTCVideoEncoder.h M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/VideoEncoder.h A Source/WebCore/platform/VideoEncoderActiveConfiguration.h M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm M Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in Log Message: --- [Cocoa] Expose colorSpace in HW encoders VideoDecoderConfig https://bugs.webkit.org/show_bug.cgi?id=257742 rdar://problem/110310512 Reviewed by Eric Carlson. We were setting colorSpace for libvpx encoders but not for remote encoders. Add support for this in LibWebRTCCodecsProxy. We make changes to RTCVideoEncoderH264 to trigger the description callback in the annexB case too so that we can send the color space. In the future, RTCVideoEncoderH264 and others might send themselves their color space. Update WebProcess side to create the VideoEncoderActiveConfiguration with colorSpace in LibWebRTCCodecs. We separate VideoEncoderActiveConfiguration in its own file to reduce header and it might be useful in the future to directly send VideoEncoderActiveConfiguration from GPUProcess to WebProcess. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h264_annexb-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h264_avc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_annexb-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_avc-expected.txt: * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/base/RTCVideoEncoder.h: * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm: (-[RTCVideoEncoderH264 initWithCodecInfo:]): (-[RTCVideoEncoderH264 setUseAnnexB:]): (-[RTCVideoEncoderH264 frameWasEncoded:flags:sampleBuffer:codecSpecificInfo:width:height:renderTimeMs:timestamp:rotation:isKeyFrameRequired:]): * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/VideoEncoder.h: * Source/WebCore/platform/VideoEncoderActiveConfiguration.h: Added. * Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm: (WebKit::LibWebRTCCodecsProxy::createEncoder): * Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp: (WebKit::RemoteVideoEncoder::RemoteVideoEncoder): (WebKit::RemoteVideoEncoderCallbacks::notifyEncoderDescription): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: (WebKit::LibWebRTCCodecs::setEncodingConfiguration): (WebKit::LibWebRTCCodecs::setEncodingDescription): Deleted. * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h: * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in: Canonical link: https://commits.webkit.org/264933@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0bdc0c: [WGSL] Make callee ordering deterministic
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0bdc0ccabceb139e0f8fe7498eee77bf63969208 https://github.com/WebKit/WebKit/commit/0bdc0ccabceb139e0f8fe7498eee77bf63969208 Author: Tadeu Zagallo Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebGPU/WGSL/CallGraph.cpp Log Message: --- [WGSL] Make callee ordering deterministic https://bugs.webkit.org/show_bug.cgi?id=257714 rdar://110263964 Reviewed by Myles C. Maxfield. The call graph's callee list was built from a HashMap, which meant we visited callees in a non-deterministic order. This makes it harder to write tests that rely on the order of the output, and we also had crashes that were happening only when we visited the callees in a certain order. To fix this, we consistently put callees in a list as we discover them and use the previous hash map to keep track of where a given callee is on the list so we can add call sites to it later. * Source/WebGPU/WGSL/CallGraph.cpp: (WGSL::CallGraphBuilder::visit): Canonical link: https://commits.webkit.org/264932@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d3c9d: [WGSL] Only rewrite globals in callees once
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d3c9d7305a521d954325bac38b15dd7f4c2fc6d https://github.com/WebKit/WebKit/commit/3d3c9d7305a521d954325bac38b15dd7f4c2fc6d Author: Tadeu Zagallo Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl Log Message: --- [WGSL] Only rewrite globals in callees once https://bugs.webkit.org/show_bug.cgi?id=257716 rdar://110265430 Reviewed by Dan Glastonbury. A callee might be reached through multiple paths in the call graph (e.g. f->h and f->g->h), so we need to keep track of the callees we already visited. However, when we encounter a callee we already visited we (might) still need to rewrite all the call sites to that callee if its signature was modified (i.e. if it needs global variable(s) to be passed to it). * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::visitCallee): * Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl: Canonical link: https://commits.webkit.org/264931@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5129c7: LocalSampleBufferDisplayLayer crops frames with a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5129c74d949f2fade9967d3a3266019c629a9358 https://github.com/WebKit/WebKit/commit/5129c74d949f2fade9967d3a3266019c629a9358 Author: Youenn Fablet Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm Log Message: --- LocalSampleBufferDisplayLayer crops frames with a rotation of 90 degrees https://bugs.webkit.org/show_bug.cgi?id=257747 rdar://110139703 Reviewed by Eric Carlson. We broke the computation of bounds and position in case of rotations in https://github.com/WebKit/WebKit/commit/0e0d7976dfe09316e3cb57a4786defeb5c5d7eb6. We update the code to be back to the previous version. * Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm: (WebCore::LocalSampleBufferDisplayLayer::updateRootLayerBoundsAndPosition): Canonical link: https://commits.webkit.org/264930@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 37dcbb: Expose Lockdown Mode as an option which can be pas...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 37dcbbda1dd88c5e7f241ccaa7f3e3f3720259d9 https://github.com/WebKit/WebKit/commit/37dcbbda1dd88c5e7f241ccaa7f3e3f3720259d9 Author: Gavin Phillips Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Tools/WebKitTestRunner/Options.cpp M Tools/WebKitTestRunner/Options.h M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm Log Message: --- Expose Lockdown Mode as an option which can be passed to WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=257760 rdar://110339741 Reviewed by Jonathan Bedard. Add a --lockdown-mode option to WebKitTestRunner which forces it to run as though Lockdown Mode is enabled. * Tools/WebKitTestRunner/Options.cpp: (WTR::handleOptionLockdownMode): (WTR::OptionsHandler::OptionsHandler): * Tools/WebKitTestRunner/Options.h: * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::cocoaPlatformInitialize): Canonical link: https://commits.webkit.org/264929@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b44aa5: Make IPC::Connection::Handle move-only.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b44aa50aceaea3c7b7e4cf783c43ed93e4a4047d https://github.com/WebKit/WebKit/commit/b44aa50aceaea3c7b7e4cf783c43ed93e4a4047d Author: Matt Woodrow Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebKit/Platform/IPC/Connection.cpp M Source/WebKit/Platform/IPC/Connection.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp M Source/WebKit/WebProcess/Network/NetworkProcessConnectionInfo.h M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp M Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.cpp Log Message: --- Make IPC::Connection::Handle move-only. https://bugs.webkit.org/show_bug.cgi?id=257579 Reviewed by Dan Glastonbury. Connection::Handle represents a way to construct the remote end of a connection, and its lifetime controls disconnection messages being sent to the local end. We shouldn't ever want to copy these, only one remote end can be constructed. t show * Source/WebKit/Platform/IPC/Connection.cpp: (IPC::Connection::Handle::encode): (IPC::Connection::Handle::decode): * Source/WebKit/Platform/IPC/Connection.h: (IPC::Connection::Handle::Handle): (IPC::Connection::Handle::operator bool const): (IPC::Connection::Identifier::Identifier): (IPC::Connection::Identifier::operator bool const): * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::getNetworkProcessConnection): * Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp: (WebKit::GPUProcessConnection::create): * Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp: (WebKit::WebInspectorUI::updateConnection): * Source/WebKit/WebProcess/Network/NetworkProcessConnectionInfo.h: (WebKit::NetworkProcessConnectionInfo::encode): (WebKit::NetworkProcessConnectionInfo::encode const): Deleted. * Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp: (TestWebKitAPI::MockTestMessageWithConnection::arguments): (TestWebKitAPI::MockTestMessageWithConnection::MockTestMessageWithConnection): (TestWebKitAPI::TEST_F): (TestWebKitAPI::TEST_P): * Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.cpp: (TestWebKitAPI::ConnectionTestBase::setupBase): Canonical link: https://commits.webkit.org/264928@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes